From nobody Tue Mar 3 03:07:43 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1771859413; cv=none; d=zohomail.com; s=zohoarc; b=FGlR/05fhb5ZLMfj59gTiKVTSk5k3nMyLQZsEZqPRcNpnmmKgi/Y+YfPOwrPXIB++HCp0aQ5/jav/77mHu0u+7MGe2inErHbLdIAFWcJ4ZxdXuFHXRWnztF2AvMDDkjvy33MelvbzWMcZyaMTsW4tOCz0OI5IFsZcJmg3C7PNc0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1771859413; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=1lQVC/zsWXNjKSP/W5pxacMKKm1VeCK3EuGDHKNxR00=; b=ENx/No1I69z9EDbXmxQRvBBxj78PqboiMlBpiLRXHUc0DK1nP4I02AyiD4b1p5DR9ogcuq3vcILxbN/RxE99yqCIDfIGkR7fgc6wOaXEAtAukrgd1zrx0wQknOY8Ayydd9X2r0DuU+gjuBASamWA8m4zPoSexxVQZrwEQ1yfv98= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1771859413670824.1247277799836; Mon, 23 Feb 2026 07:10:13 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.1239103.1540533 (Exim 4.92) (envelope-from ) id 1vuXZ9-0005Mq-Kx; Mon, 23 Feb 2026 15:09:43 +0000 Received: by outflank-mailman (output) from mailman id 1239103.1540533; Mon, 23 Feb 2026 15:09:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vuXZ9-0005Mj-I4; Mon, 23 Feb 2026 15:09:43 +0000 Received: by outflank-mailman (input) for mailman id 1239103; Mon, 23 Feb 2026 15:09:42 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vuXZ8-0005Md-Dz for xen-devel@lists.xenproject.org; Mon, 23 Feb 2026 15:09:42 +0000 Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [2a00:1450:4864:20::32c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ad920836-10c9-11f1-b164-2bf370ae4941; Mon, 23 Feb 2026 16:09:41 +0100 (CET) Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-4807068eacbso35275405e9.2 for ; Mon, 23 Feb 2026 07:09:41 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43970d4bf89sm18715016f8f.29.2026.02.23.07.09.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Feb 2026 07:09:39 -0800 (PST) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ad920836-10c9-11f1-b164-2bf370ae4941 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1771859381; x=1772464181; darn=lists.xenproject.org; h=content-transfer-encoding:autocrypt:content-language:cc:to:subject :from:user-agent:mime-version:date:message-id:from:to:cc:subject :date:message-id:reply-to; bh=1lQVC/zsWXNjKSP/W5pxacMKKm1VeCK3EuGDHKNxR00=; b=Tb6G8Y8uul3bnHKMvgAaFvvPXcxIAnS/aNPsUILOfvCF35ne5rgfkEmy0vbbqEuyg3 rU4996GxfuRytVYmS2uhm6aKAh5wOiN/N3aQOyCexPlDOBNGL3WDXnJMOq3qEpu/KYwX PzylCLhFh/bIeuqMJMF2iNue0I04pbTnrYLrDD9tDt0VwwOg/uGld2DXbPK4zvUgjHYM xLgK1VrbN5AqUVbDOk/lavrbwgQV6EkxtEBWDkcJadh8+0aZ6LzpxIUjEj8g6mtK/MUQ b8oZkkPdEy+s1do9mdSq0Zk3yB3Znz/Yc8v8xKvFlJYuYQSQdYITazRH4L2Z70R+7c1Q oG5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771859381; x=1772464181; h=content-transfer-encoding:autocrypt:content-language:cc:to:subject :from:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1lQVC/zsWXNjKSP/W5pxacMKKm1VeCK3EuGDHKNxR00=; b=xATi9FvVT1BhQF/plcQQXieAEBzwsZH3IhYpE9sjA1djoaF8NgFKofwH0gtOlU8sii Qr4Y9EMzRYZNCnCW3ckQG9gChJ1jl77eTubI98AgWpKKHn5Qmsa7udNIZZeN45TSuwhc UxR4zLNEXlk5UUYOYqyPL9lgyf8YgmySstZqa+TjV+D7xb5QDowbA6Gb2e+LZmp9E/34 jiHRQKtuAVnKZm/mNORgYS6OVqNgWN7qPHdgawoJLLpitpqvR48EswwZgB0YPXuayc5m aOaLSIbAhniiLk5urC1TzP3PI2NY3OsNPLDXl14QrDx40cx0LFq0zSdnUX/pzo8KjRKk eAUA== X-Gm-Message-State: AOJu0YyYdqzhKGRSC+RKAHmgQrU5w4esdc5mfMbO/7QAdU47El1ZRein AtNPvdu//G+2LYWsTbuB5lp917Ze2jUPDkvLkAeQdezk+9I/FecdTrCNN/cQACXtwn9XNrlWXrX QpKo= X-Gm-Gg: AZuq6aJs+RZkhh/8TO1ln7/haHYehbVT3GEf6FgmUgWmY2QmAQXwfpxNPHb8LJYYLkD OEDs0/K0C4ecJcNPwKLgjch7wb8HB2Mn5wPFapDG3yQok0thNo6o0Law+iL7VUmkvDuxQyECU7G wrp0bdkbDoieVsb5G1HbKkqY+uyNEin1lOM8zkZXKjMRrOpaBCB6uj2FhEnqBD6O98JgUcEwbhB n7KZfVEIe2yFmVbWnjQGOsquULvkD7ta/8nsjTYeqjz4gAqV5JUb/T1Xs1pdy4ghaZdmFC8EIO5 A6Yzlhi1QialUGC6Y0r6LSfDu6SZb0FF/hRovGAd95aKn0gjTouWjmKJv0G4R2RFDTCS2jhHPOj /SFKRwRu+ZV5PHW+JfnDgeCCa7jfx15pKmcUFnxzVmahRdBoMbFOobrBO42R7zUm5VJZM7+A2n5 s77In2hGNlMtB6MOiV2SsuNCYiXyX2nTidqiah5MZanH5eQgshVuqAwyDNXFY9oD2maIS8Zeny6 6l1xJfwMFmnEOE= X-Received: by 2002:a05:600c:8805:b0:47a:7fd0:9eea with SMTP id 5b1f17b1804b1-483aaa17361mr72390545e9.3.1771859380663; Mon, 23 Feb 2026 07:09:40 -0800 (PST) Message-ID: Date: Mon, 23 Feb 2026 16:09:40 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Jan Beulich Subject: [PATCH v2] wait: drop wake_up_{all,one}() To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Julien Grall , Stefano Stabellini , Anthony PERARD , Michal Orzel , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1771859414704158500 Content-Type: text/plain; charset="utf-8" wake_up_one() isn't used at all, so violates Misra rule 2.1 (unreachable code). wake_up_all() is only used locally, yet rather than making it static its sole user can invoke wake_up_nr() in the intended way directly. Signed-off-by: Jan Beulich Reviewed-by: Andrew Cooper --- v2: Keep destroy_waitqueue_head() at its old position. --- a/xen/common/wait.c +++ b/xen/common/wait.c @@ -87,7 +87,7 @@ void init_waitqueue_head(struct waitqueu =20 void destroy_waitqueue_head(struct waitqueue_head *wq) { - wake_up_all(wq); + wake_up_nr(wq, UINT_MAX); } =20 void wake_up_nr(struct waitqueue_head *wq, unsigned int nr) @@ -107,16 +107,6 @@ void wake_up_nr(struct waitqueue_head *w spin_unlock(&wq->lock); } =20 -void wake_up_one(struct waitqueue_head *wq) -{ - wake_up_nr(wq, 1); -} - -void wake_up_all(struct waitqueue_head *wq) -{ - wake_up_nr(wq, UINT_MAX); -} - #ifdef CONFIG_X86 =20 static void __prepare_to_wait(struct waitqueue_vcpu *wqv) --- a/xen/include/xen/wait.h +++ b/xen/include/xen/wait.h @@ -31,8 +31,6 @@ void destroy_waitqueue_head(struct waitq =20 /* Wake VCPU(s) waiting on specified waitqueue. */ void wake_up_nr(struct waitqueue_head *wq, unsigned int nr); -void wake_up_one(struct waitqueue_head *wq); -void wake_up_all(struct waitqueue_head *wq); =20 /* Wait on specified waitqueue until @condition is true. */ #define wait_event(wq, condition) \