From nobody Fri Nov 29 18:50:41 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=fail(p=none dis=none) header.from=arm.com Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1632853219624161.80286881075597; Tue, 28 Sep 2021 11:20:19 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.198210.351586 (Exim 4.92) (envelope-from ) id 1mVHi2-0007Zu-UC; Tue, 28 Sep 2021 18:20:06 +0000 Received: by outflank-mailman (output) from mailman id 198210.351586; Tue, 28 Sep 2021 18:20:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mVHi2-0007Zl-Ol; Tue, 28 Sep 2021 18:20:06 +0000 Received: by outflank-mailman (input) for mailman id 198210; Tue, 28 Sep 2021 18:20:05 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mVHi1-0006l6-HU for xen-devel@lists.xenproject.org; Tue, 28 Sep 2021 18:20:05 +0000 Received: from foss.arm.com (unknown [217.140.110.172]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTP id ae47c80b-2088-11ec-bcc4-12813bfff9fa; Tue, 28 Sep 2021 18:19:56 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 734E46D; Tue, 28 Sep 2021 11:19:56 -0700 (PDT) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.1]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 8E1703F793; Tue, 28 Sep 2021 11:19:55 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ae47c80b-2088-11ec-bcc4-12813bfff9fa From: Rahul Singh To: xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, rahul.singh@arm.com, Andre.Przywara@arm.com, Jan Beulich , Paul Durrant Subject: [PATCH v3 03/17] xen/arm: solve compilation error on ARM with ACPI && HAS_PCI Date: Tue, 28 Sep 2021 19:18:12 +0100 Message-Id: X-Mailer: git-send-email 2.17.1 In-Reply-To: References: In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1632853220947100001 prelink.o: In function `pcie_aer_get_firmware_first=E2=80=99: drivers/passthrough/pci.c:1251: undefined reference to `apei_hest_parse' Compilation error is observed when ACPI and HAS_PCI is enabled for ARM architecture. APEI not supported on ARM yet move the code under CONFIG_X86 flag to gate the code for ARM. Signed-off-by: Rahul Singh Acked-by: Stefano Stabellini Acked-by: Jan Beulich Reviewed-by: Bertrand Marquis --- Change in v3: Added Acked-by: Stefano Stabellini Change in v2: Add in code comment "APEI not supported on ARM yet" --- xen/drivers/passthrough/pci.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci.c index 8996403161..d774a6154e 100644 --- a/xen/drivers/passthrough/pci.c +++ b/xen/drivers/passthrough/pci.c @@ -1150,7 +1150,8 @@ void __hwdom_init setup_hwdom_pci_devices( pcidevs_unlock(); } =20 -#ifdef CONFIG_ACPI +/* APEI not supported on ARM yet. */ +#if defined(CONFIG_ACPI) && defined(CONFIG_X86) #include #include =20 --=20 2.17.1