From nobody Thu Oct 30 15:26:07 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1760959116; cv=none; d=zohomail.com; s=zohoarc; b=iRPcZlOxMT+D2Cex0eEMqXZ+yOZIYY6aNCp0szuopkua7fS0BMRNZ9iMQMfopY1FPFqeohsXQQ6DWIqAm1kzzX3oYwQAU9ZdtNXfWvwZr+m7PvyTCN9HGtFwHsNRbPyPjIEOpa9s9xaJ1d75trpxAj8errUC/ghAuh87A7hJuJs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1760959116; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=KVGn4sSgSWJeCO6UHgtOAx+xuyuXxHCg46TnMeapxz4=; b=ewtERW4eMju2r8DMkS8JmQ9sJmh4WxXcQXVDuge23zsC7yHriOBZ+GEmmI0LdGNfooU7/MUvjUfpGr5U3xQPSjZLAzH+abp5ycAeCT18gv9W/wUGm/YOOoTyhH7SH97QfUHnAM5hfVkBLBHel6gDV49J4P3XfN0AMf8KrE92PeA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 17609591160384.31666122001559; Mon, 20 Oct 2025 04:18:36 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1146131.1478594 (Exim 4.92) (envelope-from ) id 1vAnu4-0002X0-P1; Mon, 20 Oct 2025 11:18:16 +0000 Received: by outflank-mailman (output) from mailman id 1146131.1478594; Mon, 20 Oct 2025 11:18:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vAnu4-0002Wt-M2; Mon, 20 Oct 2025 11:18:16 +0000 Received: by outflank-mailman (input) for mailman id 1146131; Mon, 20 Oct 2025 11:18:15 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vAnu3-0002Wn-Mh for xen-devel@lists.xenproject.org; Mon, 20 Oct 2025 11:18:15 +0000 Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [2a00:1450:4864:20::431]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 77d64fd8-ada6-11f0-980a-7dc792cee155; Mon, 20 Oct 2025 13:18:13 +0200 (CEST) Received: by mail-wr1-x431.google.com with SMTP id ffacd0b85a97d-426ed6f4db5so2795930f8f.0 for ; Mon, 20 Oct 2025 04:18:13 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-471144b5c34sm238288115e9.10.2025.10.20.04.18.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Oct 2025 04:18:12 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 77d64fd8-ada6-11f0-980a-7dc792cee155 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1760959093; x=1761563893; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=KVGn4sSgSWJeCO6UHgtOAx+xuyuXxHCg46TnMeapxz4=; b=Eia43L4yoT3jzNAxTNf9azSIxr57j3FQQDyZXH1Ztp5r5lCfh7kgteWbbhTz+d405m 3omkGcBJGSdq3ygJVTFUzaBlJv9mUt5NqmLuETE+gopW11eCtjQ5h0WePun0/lR9qsj3 jC0Ry7LvLKIFoQymCXHcm1vh43DSDWn1gbUmBhCiCKzB6BrjnzDeqP66asn3aqJ4bs+G 2xmidKOPw1xJWqB9hlcNlAVK/Unz9XHzJSWsWv4WPc6MWJSGhhPHji/n94u8mmA8Kkx8 P1jJyKEUrhGq23aJCZCQYg60RGY/thmj/BcGRRts4kzI4l6SpbNpLNH4crZblWWXHPwm RVQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760959093; x=1761563893; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=KVGn4sSgSWJeCO6UHgtOAx+xuyuXxHCg46TnMeapxz4=; b=Pg24slOp1Lxh37+lguwoaTsgiYCli7QUZ87uLZpdC5xMFCZrjQ5Vb4Czl5M1mWFxzA DQsZjWVtuqWvQPH6LAjHtsVHhZbAYm/eZi6lapzYmpyOVpJqvTvG54qxhfDSZnPZO1X7 /x4355K6PYC1FBpHY0E2bKtmGPk3t85F3QNBtAcj3S256wAip3U4ozMBbWCltp2niACA 9OcNI0zui6P4kUBy2EME4h/EI7mtrOxlvrgJ8q00Nl3FXIxvLGzf2S1SjWl9GZUVyY9P AsuxblniRE/6rB+dTtjU4wvO0vGxUCKAZf4rGR0BmS7tGMhRkD1Q3N6ITxjWDURNk9Ha mI3A== X-Gm-Message-State: AOJu0YzBaSrbLjH0wshqPgQd1QalBTSPNQbF/5w7xRFcBi1YjVgS3Pty DtpSZ70eiYLJJXgLT6s9umhbopbvD/KPdjqmc1wA8HnRenEBeUZ4ACvUSEqC69Y9sQjfxrPGx9v bJwg= X-Gm-Gg: ASbGnctZG0H3U/8bN176Xio+mMokrVEzeRIcAi3AGZbh/1oaBJ10oJ5iexOmKHF6K4e NSd4T3awFfvpfjL4xJxZyb85hqN2wKNxceQO0Xt8sGVFLATFRwvgIlgwxP2ez7285qIRqWT05Dx Uo/Ka0vgVkolsZ3F8CC1tCEts68s/D6tW8ASgA2btzIPMDigSYiWzRzpGsMjU7Wq/2LxDUAwh7l KZ0eUA8qCWoGGCjIhFDKs2R2tO5+tUg+YasAOnXVQ3Q3TxC0q+eT5TZzueaGAie2ZeqUKlg5yyv 7I0rGp/TjGhnStv7vBxMlYWybbU1TY1YK5UG3SzEalUbpw9Tz7EteM73k8hRTCET0ITMy8vkOU9 B8vB0aKAnzYLeh4twFEqTf9aYyA7WXbNCkHRGy9OCvm1iH+18qyS8QFw8gwzu17JwSgFwFKm+Bj jUuMcWxsoHpcA5+Dy0NjZnL9TWNnXbQkbK81lrcqcKXGmZPL3v0SM44/HHbpb5XqgsR0IMwmU= X-Google-Smtp-Source: AGHT+IEeLtHxI4cjVnB/zNhFXjIUxVciyqMKTfrEeVESCvrehyFM9Jjg2xcIxTZfTBWwfCknjNsJ/Q== X-Received: by 2002:a05:6000:2c0c:b0:3df:22a3:d240 with SMTP id ffacd0b85a97d-426fb6a1c87mr11575515f8f.4.1760959093082; Mon, 20 Oct 2025 04:18:13 -0700 (PDT) Message-ID: <53011168-7b4c-4232-9295-f33399580578@suse.com> Date: Mon, 20 Oct 2025 13:18:13 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH v2 for-4.21 1/9] x86/HPET: disable unused channels From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Oleksii Kurochko References: Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1760959117713158500 Keeping channels enabled when they're unused is only causing problems: Extra interrupts harm performance, and extra nested interrupts could even have caused worse problems. Note that no explicit "enable" is necessary - that's implicitly done by set_channel_irq_affinity() once the channel goes into use again. Along with disabling the counter, also "clear" the channel's "next event", for it to be properly written by whatever the next user is going to want (possibly avoiding too early an IRQ). Further, along the same lines, don't enable channels early when starting up an IRQ. This similarly should happen no earlier than from set_channel_irq_affinity() (here: once a channel goes into use the very first time). This eliminates a single instance of (XEN) [VT-D]INTR-REMAP: Request device [0000:00:1f.0] fault index 0 (XEN) [VT-D]INTR-REMAP: reason 25 - Blocked a compatibility format interrup= t request during boot. (Why exactly there's only one instance, when we use multiple counters and hence multiple IRQs, I can't tell. My understanding would be that this was due to __hpet_setup_msi_irq() being called only after request_irq() [and hence the .startup handler], yet that should have affected all channels.) Fixes: 3ba523ff957c ("CPUIDLE: enable MSI capable HPET for timer broadcast") Signed-off-by: Jan Beulich Reviewed-by: Roger Pau Monn=C3=A9 Release-Acked-by: Oleksii Kurochko --- A window still remains for IRQs to be caused by stale comparator values: hpet_attach_channel() is called ahead of reprogram_hpet_evt_channel(). Should we also write the comparator to "far into the future"? Furthermore this prolongues the window until "old" vectors may be released again, as this way we potentially (and intentionally) delay the ocurrence of the next IRQ for the channel in question. (This issue will disappear once we switch to a fixed, global vector.) --- a/xen/arch/x86/hpet.c +++ b/xen/arch/x86/hpet.c @@ -262,10 +262,9 @@ static void cf_check hpet_msi_unmask(str ch->msi.msi_attrib.host_masked =3D 0; } =20 -static void cf_check hpet_msi_mask(struct irq_desc *desc) +static void hpet_disable_channel(struct hpet_event_channel *ch) { u32 cfg; - struct hpet_event_channel *ch =3D desc->action->dev_id; =20 cfg =3D hpet_read32(HPET_Tn_CFG(ch->idx)); cfg &=3D ~HPET_TN_ENABLE; @@ -273,6 +272,11 @@ static void cf_check hpet_msi_mask(struc ch->msi.msi_attrib.host_masked =3D 1; } =20 +static void cf_check hpet_msi_mask(struct irq_desc *desc) +{ + hpet_disable_channel(desc->action->dev_id); +} + static int hpet_msi_write(struct hpet_event_channel *ch, struct msi_msg *m= sg) { ch->msi.msg =3D *msg; @@ -295,12 +299,6 @@ static int hpet_msi_write(struct hpet_ev return 0; } =20 -static unsigned int cf_check hpet_msi_startup(struct irq_desc *desc) -{ - hpet_msi_unmask(desc); - return 0; -} - #define hpet_msi_shutdown hpet_msi_mask =20 static void cf_check hpet_msi_set_affinity( @@ -326,7 +324,7 @@ static void cf_check hpet_msi_set_affini */ static hw_irq_controller hpet_msi_type =3D { .typename =3D "HPET-MSI", - .startup =3D hpet_msi_startup, + .startup =3D irq_startup_none, .shutdown =3D hpet_msi_shutdown, .enable =3D hpet_msi_unmask, .disable =3D hpet_msi_mask, @@ -526,6 +524,8 @@ static void hpet_detach_channel(unsigned spin_unlock_irq(&ch->lock); else if ( (next =3D cpumask_first(ch->cpumask)) >=3D nr_cpu_ids ) { + hpet_disable_channel(ch); + ch->next_event =3D STIME_MAX; ch->cpu =3D -1; clear_bit(HPET_EVT_USED_BIT, &ch->flags); spin_unlock_irq(&ch->lock); From nobody Thu Oct 30 15:26:07 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1760959134; cv=none; d=zohomail.com; s=zohoarc; b=cgOTzOelBWlLM2NPfW97yscAUuyszNVpfWp+xe6Xn377e7g9SI042JlZv76wdmrJa1VCBOYakFgnKWOnlgF2XSOSBr1F5rITSgZN04Ob8FyB8tukvFCxOqJZgS/HVXipnyZcJI+u3Uby9k/Wd2giGvHuW6Vr3+5OadxVpPdlCO0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1760959134; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=xp3ZzG5lh8bOBtP+FhKCPfyNrES6CNI7e8J4OO1+r18=; b=A2wX/UYnn2H/8lRKVc4bsydOysUwXvSyhNoHJVt2XJNo6RfNtXq3ufyoUhVEpF6ESX9oqJEYlbQaGyqjECIA5E5NXGygRvBK5lhL873ecyLiS1OVCG2nZpISaHT68XiX3wItQfJuuSqe/nq4FN8l2JkgIF+/QEMOT4zp0IiGYOk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1760959134758746.7473659444656; Mon, 20 Oct 2025 04:18:54 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1146136.1478604 (Exim 4.92) (envelope-from ) id 1vAnuO-0002vP-1W; Mon, 20 Oct 2025 11:18:36 +0000 Received: by outflank-mailman (output) from mailman id 1146136.1478604; Mon, 20 Oct 2025 11:18:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vAnuN-0002vI-UZ; Mon, 20 Oct 2025 11:18:35 +0000 Received: by outflank-mailman (input) for mailman id 1146136; Mon, 20 Oct 2025 11:18:35 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vAnuN-0001y1-4x for xen-devel@lists.xenproject.org; Mon, 20 Oct 2025 11:18:35 +0000 Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [2a00:1450:4864:20::42b]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 842da1ca-ada6-11f0-9d15-b5c5bf9af7f9; Mon, 20 Oct 2025 13:18:34 +0200 (CEST) Received: by mail-wr1-x42b.google.com with SMTP id ffacd0b85a97d-4270491e9easo2582076f8f.2 for ; Mon, 20 Oct 2025 04:18:34 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-427f00b97f8sm14777104f8f.36.2025.10.20.04.18.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Oct 2025 04:18:33 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 842da1ca-ada6-11f0-9d15-b5c5bf9af7f9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1760959114; x=1761563914; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=xp3ZzG5lh8bOBtP+FhKCPfyNrES6CNI7e8J4OO1+r18=; b=dJduLkdmSR+qE9Wi4WZhd5/c6F2jl2cG0jK3qQpnaJbLrS26rH/+SsCZYu7Wv5Fb83 qoXNMl7EcN8ApqJMmAVNPaoct7KAHQKtwxIkqZIG8wODBVWQ/EJ7j+ly1jxZLqiO4FS3 486ejycvEOSx+ZqbN446PnkZs07HX5OzTxCMDDcrK3uN0z89GbRLa0kza34Ggmbh3iBf cpHU4WLQS03OnV0mi+eEUKcGTpQddXnUTP4hKzdabfuDVJNcP0KkBm+Ndl/I0LagOSBA To7sm6yKEwCsh30zWbpISNafKde453DoFmCg2zfTseEobYVNhlL0IMRIQfdUHzT84JOT Xi7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760959114; x=1761563914; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=xp3ZzG5lh8bOBtP+FhKCPfyNrES6CNI7e8J4OO1+r18=; b=RAehYwv7VO/NjJvAZ+p8sbyaX7qFhSre5AveHKZ9fqr4rbs9u4c+0qKDjtMP3eqNnP DRMbFYRJTMEGpxRW7+y68Q0SXuSposPpoa9lMly9Gw1c7iciqLZrkPp9mTrt8HucwQpq pPyJeocAPCeaG6/WBRanDbG2+vzW1JYQ80EccXp5JbzTeHb1pm+wm4GdO1ojcbFG/h6X GHWIt+mz0RQWbopTx0hJJc9//9cVN2U6RusLLMvntqjgpU8Q5oVr81wMMdNSRGWqK3su rcAnclHjnajh8g/fVsYLFLPLly2Qki0Gv494c4Oc6hAN+DWjrHNrHDDjbYPJDHFbTWzI xbJA== X-Gm-Message-State: AOJu0YwiZE1geGKyfV1eual0QonzpkEuRlAdqyX3TPtF9GFx+yHn/vbX ONPwf9KREPlZKQB2Sy7WQINCjWNHl5KF8Pe3ipCaCnHCYWPE4RkbRa4jtyFgJ8ADINgxb7O2InW 58ec= X-Gm-Gg: ASbGnctVc1GeqltqnkgAphbR1K5lV44RD0uww58zhUkPFHPrrzwMwT5AMBrhyg2QITB VtPXRHeaqq2BuC/zBh8ftdtA+J0kr7NdqiEftxynIN/cyis4l8URgkoMBj6neE1Z7XSl80QyH6W u7WFagPsTTtwNZozMqKhWNkLHCZKA485OssXLcM3L6jxndtVxHGdWV8tFL7W1ZcZrrfWKGRZOmc +Tyydoa8J6VxHn3nXtCqaOhLyavapkd+c3Gt5QO6Vhoy7Vp/v+F5rZ72mHaw3wQRhZItPJTjqN9 h1t3694Z5o1HcTwNaAkOYVDBHgAFydwEXvUQQ+V1rKLKUlmJ5Hlf5gJ9r2WA1a8M28TjfC5dt21 wDO053LxdB0X+2McG2O+8cPnmMvz6wNNbnRfZnaZVDrlyc1WXBgyoUAgUvVU14Fw+dqkwJ5DX8H kQ8RoTUqz8ukb1wlXhX0TmTo/JeyOVcTdPPt07GkQ1LHpDQa6X42qgh+RSxxGZvc5VBNRsvB0= X-Google-Smtp-Source: AGHT+IERMekt1Z9Tal+0KY4nEFISAZZNXuyoDQC7eKhFKqV/SBqcnPeOcBTKpr9xTKiruHgXmMfnZg== X-Received: by 2002:a05:6000:2303:b0:427:6cb:74a4 with SMTP id ffacd0b85a97d-42706cb74a9mr8432642f8f.39.1760959113689; Mon, 20 Oct 2025 04:18:33 -0700 (PDT) Message-ID: Date: Mon, 20 Oct 2025 13:18:34 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH v2 for-4.21 2/9] x86/HPET: use single, global, low-priority vector for broadcast IRQ From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Oleksii Kurochko References: Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1760959135756158500 Content-Type: text/plain; charset="utf-8" Using dynamically allocated / maintained vectors has several downsides: - possible nesting of IRQs due to the effects of IRQ migration, - reduction of vectors available for devices, - IRQs not moving as intended if there's shortage of vectors, - higher runtime overhead. As the vector also doesn't need to be of any priority (first and foremost it really shouldn't be of higher or same priority as the timer IRQ, as that raises TIMER_SOFTIRQ anyway), avoid any "ordinary" vectors altogther and use a vector from the 0x10...0x1f exception vector space. Exception vs interrupt can easily be distinguished by checking for the presence of an error code. With a fixed vector, less updating is now necessary in set_channel_irq_affinity(); in particular channels don't need transiently masking anymore, as the necessary update is now atomic. To fully leverage this, however, we want to stop using hpet_msi_set_affinity() there. With the transient masking dropped, we're no longer at risk of missing events. In principle a change to setup_vector_irq() would be necessary, but only if we used low-prio vectors as direct-APIC ones. Since the change would be at best benign here, it is being omitted. Fixes: 996576b965cc ("xen: allow up to 16383 cpus") Signed-off-by: Jan Beulich Release-Acked-by: Oleksii Kurochko --- This is an alternative proposal to https://lists.xen.org/archives/html/xen-devel/2014-03/msg00399.html. Should we keep hpet_msi_set_affinity() at all? We'd better not have the generic IRQ subsystem play with our IRQs' affinities ... (If so, this likely would want to be a separate patch, though.) The hpet_enable_channel() call could in principle be made (effectively) conditional, at the price of introducing a check in hpet_enable_channel(). However, as much as eliminating the masking didn't help with the many excess (early) IRQs I'm observing on Intel hardware, doing so doesn't help either. The Fixes: tag indicates where the problem got signficantly worse; in principle it was there already before (crashing at perhaps 6 or 7 levels of nested IRQs). --- v2: Re-work set_channel_irq_affinity() intensively. Re-base over the dropping of another patch. Drop setup_vector_irq() change. --- a/xen/arch/x86/hpet.c +++ b/xen/arch/x86/hpet.c @@ -9,17 +9,19 @@ #include #include #include +#include #include #include #include #include =20 #include -#include #include +#include +#include #include +#include #include -#include =20 #define MAX_DELTA_NS MILLISECS(10*1000) #define MIN_DELTA_NS MICROSECS(20) @@ -251,10 +253,9 @@ static void cf_check hpet_interrupt_hand ch->event_handler(ch); } =20 -static void cf_check hpet_msi_unmask(struct irq_desc *desc) +static void hpet_enable_channel(struct hpet_event_channel *ch) { u32 cfg; - struct hpet_event_channel *ch =3D desc->action->dev_id; =20 cfg =3D hpet_read32(HPET_Tn_CFG(ch->idx)); cfg |=3D HPET_TN_ENABLE; @@ -262,6 +263,11 @@ static void cf_check hpet_msi_unmask(str ch->msi.msi_attrib.host_masked =3D 0; } =20 +static void cf_check hpet_msi_unmask(struct irq_desc *desc) +{ + hpet_enable_channel(desc->action->dev_id); +} + static void hpet_disable_channel(struct hpet_event_channel *ch) { u32 cfg; @@ -307,15 +313,13 @@ static void cf_check hpet_msi_set_affini struct hpet_event_channel *ch =3D desc->action->dev_id; struct msi_msg msg =3D ch->msi.msg; =20 - msg.dest32 =3D set_desc_affinity(desc, mask); - if ( msg.dest32 =3D=3D BAD_APICID ) - return; + /* This really is only for dump_irqs(). */ + cpumask_copy(desc->arch.cpu_mask, mask); =20 - msg.data &=3D ~MSI_DATA_VECTOR_MASK; - msg.data |=3D MSI_DATA_VECTOR(desc->arch.vector); + msg.dest32 =3D cpu_mask_to_apicid(mask); msg.address_lo &=3D ~MSI_ADDR_DEST_ID_MASK; msg.address_lo |=3D MSI_ADDR_DEST_ID(msg.dest32); - if ( msg.data !=3D ch->msi.msg.data || msg.dest32 !=3D ch->msi.msg.des= t32 ) + if ( msg.dest32 !=3D ch->msi.msg.dest32 ) hpet_msi_write(ch, &msg); } =20 @@ -328,7 +332,7 @@ static hw_irq_controller hpet_msi_type =3D .shutdown =3D hpet_msi_shutdown, .enable =3D hpet_msi_unmask, .disable =3D hpet_msi_mask, - .ack =3D ack_nonmaskable_msi_irq, + .ack =3D irq_actor_none, .end =3D end_nonmaskable_irq, .set_affinity =3D hpet_msi_set_affinity, }; @@ -347,6 +351,12 @@ static int __init hpet_setup_msi_irq(str u32 cfg =3D hpet_read32(HPET_Tn_CFG(ch->idx)); irq_desc_t *desc =3D irq_to_desc(ch->msi.irq); =20 + clear_irq_vector(ch->msi.irq); + ret =3D bind_irq_vector(ch->msi.irq, HPET_BROADCAST_VECTOR, &cpu_onlin= e_map); + if ( ret ) + return ret; + cpumask_setall(desc->affinity); + if ( iommu_intremap !=3D iommu_intremap_off ) { ch->msi.hpet_id =3D hpet_blockid; @@ -476,19 +486,50 @@ static struct hpet_event_channel *hpet_g static void set_channel_irq_affinity(struct hpet_event_channel *ch) { struct irq_desc *desc =3D irq_to_desc(ch->msi.irq); + struct msi_msg msg =3D ch->msi.msg; =20 ASSERT(!local_irq_is_enabled()); spin_lock(&desc->lock); - hpet_msi_mask(desc); - hpet_msi_set_affinity(desc, cpumask_of(ch->cpu)); - hpet_msi_unmask(desc); + + per_cpu(vector_irq, ch->cpu)[HPET_BROADCAST_VECTOR] =3D ch->msi.irq; + + /* + * Open-coding a reduced form of hpet_msi_set_affinity() here. With t= he + * actual update below (either of the IRTE or of [just] message addres= s; + * with interrupt remapping message address/data don't change) now bei= ng + * atomic, we can avoid masking the IRQ around the update. As a result + * we're no longer at risk of missing IRQs (provided hpet_broadcast_en= ter() + * keeps setting the new deadline only afterwards). + */ + cpumask_copy(desc->arch.cpu_mask, cpumask_of(ch->cpu)); + spin_unlock(&desc->lock); =20 - spin_unlock(&ch->lock); + msg.dest32 =3D cpu_physical_id(ch->cpu); + msg.address_lo &=3D ~MSI_ADDR_DEST_ID_MASK; + msg.address_lo |=3D MSI_ADDR_DEST_ID(msg.dest32); + if ( msg.dest32 !=3D ch->msi.msg.dest32 ) + { + ch->msi.msg =3D msg; + + if ( iommu_intremap !=3D iommu_intremap_off ) + { + int rc =3D iommu_update_ire_from_msi(&ch->msi, &msg); =20 - /* We may have missed an interrupt due to the temporary masking. */ - if ( ch->event_handler && ch->next_event < NOW() ) - ch->event_handler(ch); + ASSERT(rc <=3D 0); + if ( rc > 0 ) + { + ASSERT(msg.data =3D=3D hpet_read32(HPET_Tn_ROUTE(ch->idx))= ); + ASSERT(msg.address_lo =3D=3D + hpet_read32(HPET_Tn_ROUTE(ch->idx) + 4)); + } + } + else + hpet_write32(msg.address_lo, HPET_Tn_ROUTE(ch->idx) + 4); + } + + hpet_enable_channel(ch); + spin_unlock(&ch->lock); } =20 static void hpet_attach_channel(unsigned int cpu, --- a/xen/arch/x86/include/asm/irq-vectors.h +++ b/xen/arch/x86/include/asm/irq-vectors.h @@ -18,6 +18,15 @@ /* IRQ0 (timer) is statically allocated but must be high priority. */ #define IRQ0_VECTOR 0xf0 =20 +/* + * Low-priority (for now statically allocated) vectors, sharing entry + * points with exceptions in the 0x10 ... 0x1f range, as long as the + * respective exception has an error code. + */ +#define FIRST_LOPRIORITY_VECTOR 0x10 +#define HPET_BROADCAST_VECTOR X86_EXC_AC +#define LAST_LOPRIORITY_VECTOR 0x1f + /* Legacy PIC uses vectors 0x20-0x2f. */ #define FIRST_LEGACY_VECTOR FIRST_DYNAMIC_VECTOR #define LAST_LEGACY_VECTOR (FIRST_LEGACY_VECTOR + 0xf) @@ -40,7 +49,7 @@ /* There's no IRQ2 at the PIC. */ #define IRQ_MOVE_CLEANUP_VECTOR (FIRST_LEGACY_VECTOR + 2) =20 -#define FIRST_IRQ_VECTOR FIRST_DYNAMIC_VECTOR +#define FIRST_IRQ_VECTOR FIRST_LOPRIORITY_VECTOR #define LAST_IRQ_VECTOR LAST_HIPRIORITY_VECTOR =20 #endif /* _ASM_IRQ_VECTORS_H */ --- a/xen/arch/x86/msi.c +++ b/xen/arch/x86/msi.c @@ -158,7 +158,7 @@ void msi_compose_msg(unsigned vector, co { memset(msg, 0, sizeof(*msg)); =20 - if ( vector < FIRST_DYNAMIC_VECTOR ) + if ( vector < FIRST_LOPRIORITY_VECTOR ) return; =20 if ( cpu_mask ) --- a/xen/arch/x86/x86_64/entry.S +++ b/xen/arch/x86/x86_64/entry.S @@ -1045,7 +1045,13 @@ END(entry_GP) =20 FUNC(entry_AC) ENDBR64 + /* #AC shares its entry point with the HPET broadcast interrupt. */ + test $8, %spl + jz .Lac + push $0 +.Lac: movb $X86_EXC_AC, EFRAME_entry_vector(%rsp) + jnz common_interrupt jmp handle_exception END(entry_AC) From nobody Thu Oct 30 15:26:07 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1760959174; cv=none; d=zohomail.com; s=zohoarc; b=muSzPyn6cXmivcwDkBeTV5MTu/z07xJZ7UsBYB/ZVK+0G8pS7E0dFysnLnIw+GlOAuUmQXOJc7JneCPCUcrkA74/YDWO65XsIk+x+SmVi79GNINtLUtVUoz9/o7vRY8apCz72T3sl7dNCSyZoK0R04soqljKEdLx0+S8duspkgQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1760959174; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=AI0XfI34h1Zl5StAh9WFtTOYxg7ZUNHMx3r652w6/xg=; b=X7Qn3N11YBmf9ZI0sLgSXaDTyPiAMcyb92BUQBDWPobqNuL+qTVjiXCLy4MhCBuSNYMgbohVgatJRkK/2TVvuuF0ih02JK0b4ETtodAw37AAywsdr5iBYJN4fc6AkQgFQCbMvKUDafQO4oTuyRh1BRqR5z8DfKRbHiXZ6/wBXy8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1760959174151131.743797274043; Mon, 20 Oct 2025 04:19:34 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1146150.1478614 (Exim 4.92) (envelope-from ) id 1vAnv9-0003YR-9c; Mon, 20 Oct 2025 11:19:23 +0000 Received: by outflank-mailman (output) from mailman id 1146150.1478614; Mon, 20 Oct 2025 11:19:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vAnv9-0003YK-6c; Mon, 20 Oct 2025 11:19:23 +0000 Received: by outflank-mailman (input) for mailman id 1146150; Mon, 20 Oct 2025 11:19:22 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vAnv8-0003Y5-9L for xen-devel@lists.xenproject.org; Mon, 20 Oct 2025 11:19:22 +0000 Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [2a00:1450:4864:20::42f]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9f9a3ed0-ada6-11f0-980a-7dc792cee155; Mon, 20 Oct 2025 13:19:20 +0200 (CEST) Received: by mail-wr1-x42f.google.com with SMTP id ffacd0b85a97d-4283be7df63so1014106f8f.1 for ; Mon, 20 Oct 2025 04:19:20 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-427ea5b3acfsm14781399f8f.14.2025.10.20.04.19.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Oct 2025 04:19:19 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9f9a3ed0-ada6-11f0-980a-7dc792cee155 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1760959160; x=1761563960; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=AI0XfI34h1Zl5StAh9WFtTOYxg7ZUNHMx3r652w6/xg=; b=W+/4+05DNcG+00bPdjuUWXuROpZ3FqlT41iNBgHt6vawcicItb8l7tsQGJyDvUpwJR zJxD0fPLdWootS0mrlCLf9OBDQ37M4zEV4fGim45rf6MXTLmanf0IiQ6C5t9qAWw+uT1 9mBh458RtyBjytlXxhGnOx4oKcUyGEgNKwfReTrj0rmKKdickxzgNmEdFqtWBFlpUWbA T1qLIzmIsUYKJyXQFqXQeRpu6SuwXt3QvpeOifbCXahQR1DgI5dk8uJm9tAjFLUZTTQ2 Lcx+Be+gYYPbAKm/rQbzEeHikj9Vu6rDXaycbsZ2dY8fNQujHqDyN5kk/tUljJOvHaX9 qrWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760959160; x=1761563960; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=AI0XfI34h1Zl5StAh9WFtTOYxg7ZUNHMx3r652w6/xg=; b=NY+9pUAPDYtj+OvrEbN7IfFYrMOtATLKi726ctO5E358fIdQhRPJBRWTkE+gjAzn9j +byqIEyTebapcnPKGyLP8mSNkYfG+akCm+LJailiYyCGHCYTFEz0p0JFzpYhYrdi6QgE s2AbY8EjJMMxbhk7THFRvLlerZqHkwh6pffSeZa/oLVVCXwubMTO1O8LBoCJtsVwXQsa uu20e/H9F36X02fomFPMUF6ZyLmIFC52YJinJO/4hHnBzt8uDDfVtvXdHYuJd/pzpxaW nJg4J6w62u0qjTSxvR10NewWD+LnYM6H142L832A810i3dey4+QFk8ncGca/CF5IVjQE UvgA== X-Gm-Message-State: AOJu0YwOPCJHccCmNEqrpgccWOMJa4To2vGqSr1EQl68/e8uq34Bn8Cs JEZCHbwZSl8w+aJeK67NNXxCkoJhNKDVAueLeBTiZy0XDIY3X7VF4eACGCIPZVVPacUlMeUiVbo XWkk= X-Gm-Gg: ASbGnct69Ft2seR7yvFEup1LGFB25IJyd8iwUqfclLLU2I3/O1aqTjKWK+MFm9vvOLV nDELtc1/UNYpB8JoKlW097//wdBnDd7jc6IgZgBrf0w5/HZ4CM6b8IlpMlgsUbTasNflfod7EVw E/YCKatKlRTUa0Oo3CUSbJ66+vxC3wwi8BeQWbCCAweN89odL8xIXUO8pq40QVTLRBQc9kF+VkC x0g56CB3y+6UaqeL/R/YoS0ZEJa8JsnT+5GkSC0eVXAAImCPzNdfqMxIMv5KHM6Gh6dlo03mDMX +3ji7ec8T3C8ST0DGdViJLQ47SvNdqAAuPscyMqgpMKsuGUlpIG1qZwnj7ATzLeojRinuCLPGPx gFsy9HZ21LMCEa1jy94OMXYgUhph2DgSa0YYtnpbn/2bwUssys9kLzHWBXK1YY5cWXaSDMguuii dNl2WfMOix2VxgHUcI0/cprsqirGx3dCMYjnFCKPXaK4QDhfyHJZyumOISCZuN X-Google-Smtp-Source: AGHT+IHCXE0dJDtsjlPTRwNty5pqiwlUd1ly4yT/a6uQB5hIdfdbppAaqSjA3JntMNUWWYupbhdqPA== X-Received: by 2002:a05:6000:2301:b0:428:3e62:3225 with SMTP id ffacd0b85a97d-4283e6236f6mr5165411f8f.60.1760959159759; Mon, 20 Oct 2025 04:19:19 -0700 (PDT) Message-ID: Date: Mon, 20 Oct 2025 13:19:20 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH v2 for-4.21 3/9] x86/HPET: replace handle_hpet_broadcast()'s on-stack cpumask_t From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Oleksii Kurochko References: Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1760959176156158500 Content-Type: text/plain; charset="utf-8" With large NR_CPUS on-stack cpumask_t variables are problematic. Now that the IRQ handler can't be invoked in a nested manner anymore, we can instead use a per-CPU variable. While we can't use scratch_cpumask in code invoked from IRQ handlers, simply amend that one with a HPET-special form. (Note that only one of the two IRQ handling functions can come into play at any one time.) Fixes: 996576b965cc ("xen: allow up to 16383 cpus") Signed-off-by: Jan Beulich Reviewed-by: Roger Pau Monn=C3=A9 --- While doing this I noticed that this and all pre-existing uses of DEFINE_PER_CPU_READ_MOSTLY() aren't quite right: When the type is cpumask_var_t, the variable is read-mostly only when NR_CPUS <=3D 2 * BITS_PER_LONG. That'll want sorting separately, though. It is important for this to not be moved ahead of "x86/HPET: use single, global, low-priority vector for broadcast IRQ", as the original call here from set_channel_irq_affinity() may not use the new variable (it would need to use scratch_cpumask instead). --- v2: New. --- a/xen/arch/x86/hpet.c +++ b/xen/arch/x86/hpet.c @@ -196,7 +196,7 @@ static void evt_do_broadcast(cpumask_t * =20 static void cf_check handle_hpet_broadcast(struct hpet_event_channel *ch) { - cpumask_t mask; + cpumask_t *scratch =3D this_cpu(hpet_scratch_cpumask); s_time_t now, next_event; unsigned int cpu; unsigned long flags; @@ -209,7 +209,7 @@ again: spin_unlock_irqrestore(&ch->lock, flags); =20 next_event =3D STIME_MAX; - cpumask_clear(&mask); + cpumask_clear(scratch); now =3D NOW(); =20 /* find all expired events */ @@ -218,13 +218,13 @@ again: s_time_t deadline =3D ACCESS_ONCE(per_cpu(timer_deadline, cpu)); =20 if ( deadline <=3D now ) - __cpumask_set_cpu(cpu, &mask); + __cpumask_set_cpu(cpu, scratch); else if ( deadline < next_event ) next_event =3D deadline; } =20 /* wakeup the cpus which have an expired event. */ - evt_do_broadcast(&mask); + evt_do_broadcast(scratch); =20 if ( next_event !=3D STIME_MAX ) { --- a/xen/arch/x86/include/asm/smp.h +++ b/xen/arch/x86/include/asm/smp.h @@ -22,6 +22,7 @@ DECLARE_PER_CPU(cpumask_var_t, cpu_sibling_mask); DECLARE_PER_CPU(cpumask_var_t, cpu_core_mask); DECLARE_PER_CPU(cpumask_var_t, scratch_cpumask); +DECLARE_PER_CPU(cpumask_var_t, hpet_scratch_cpumask); DECLARE_PER_CPU(cpumask_var_t, send_ipi_cpumask); =20 /* --- a/xen/arch/x86/smpboot.c +++ b/xen/arch/x86/smpboot.c @@ -55,6 +55,9 @@ DEFINE_PER_CPU_READ_MOSTLY(cpumask_var_t DEFINE_PER_CPU_READ_MOSTLY(cpumask_var_t, scratch_cpumask); static cpumask_t scratch_cpu0mask; =20 +DEFINE_PER_CPU_READ_MOSTLY(cpumask_var_t, hpet_scratch_cpumask); +static cpumask_t hpet_scratch_cpu0mask; + DEFINE_PER_CPU_READ_MOSTLY(cpumask_var_t, send_ipi_cpumask); static cpumask_t send_ipi_cpu0mask; =20 @@ -976,6 +979,8 @@ static void cpu_smpboot_free(unsigned in FREE_CPUMASK_VAR(per_cpu(cpu_core_mask, cpu)); if ( per_cpu(scratch_cpumask, cpu) !=3D &scratch_cpu0mask ) FREE_CPUMASK_VAR(per_cpu(scratch_cpumask, cpu)); + if ( per_cpu(hpet_scratch_cpumask, cpu) !=3D &hpet_scratch_cpu0mas= k ) + FREE_CPUMASK_VAR(per_cpu(hpet_scratch_cpumask, cpu)); if ( per_cpu(send_ipi_cpumask, cpu) !=3D &send_ipi_cpu0mask ) FREE_CPUMASK_VAR(per_cpu(send_ipi_cpumask, cpu)); } @@ -1112,6 +1117,7 @@ static int cpu_smpboot_alloc(unsigned in if ( !(cond_zalloc_cpumask_var(&per_cpu(cpu_sibling_mask, cpu)) && cond_zalloc_cpumask_var(&per_cpu(cpu_core_mask, cpu)) && cond_alloc_cpumask_var(&per_cpu(scratch_cpumask, cpu)) && + cond_alloc_cpumask_var(&per_cpu(hpet_scratch_cpumask, cpu)) && cond_alloc_cpumask_var(&per_cpu(send_ipi_cpumask, cpu))) ) goto out; =20 @@ -1239,6 +1245,7 @@ void __init smp_prepare_boot_cpu(void) cpumask_set_cpu(cpu, &cpu_present_map); #if NR_CPUS > 2 * BITS_PER_LONG per_cpu(scratch_cpumask, cpu) =3D &scratch_cpu0mask; + per_cpu(hpet_scratch_cpumask, cpu) =3D &hpet_scratch_cpu0mask; per_cpu(send_ipi_cpumask, cpu) =3D &send_ipi_cpu0mask; #endif From nobody Thu Oct 30 15:26:07 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1760959589; cv=none; d=zohomail.com; s=zohoarc; b=Pa/S2t7ZDM/eyt9Nd6YRGV8Zrj4Zcjj7VoErFAjI1O6AQhpJFrHsIt5Xt845TtuvQ1eIv1/ZVAVzHupQVIn/Yuwa9erVC1u3uOzrEz3ntEZBSduxetbou5EQo9G7ufp+2VcdaEz3d+F19QS71fmUiQS4/51grJqoJD69M6QRhkw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1760959589; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=CR7zFEwvrxzSG3gB+46rCvPXK38/dK1o+Nvm/MzzJ9E=; b=bEa45Kb6XzbQJ27ekL9qnDjWeAQw7HZ03RT2cfeTvLH3IASh5Y3+1jbVRJl6oaqdF3E5kf9dnfIIMt0m/vXVo+lJcnK5Cu+irVAif7FeuAc2ZD1Laf6F1tez8203rh+jz2uhVz9Kh/NUm+M02aeTbnJLKf764dg6UfxI9xNRCo8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1760959589368661.3184394344081; Mon, 20 Oct 2025 04:26:29 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1146198.1478669 (Exim 4.92) (envelope-from ) id 1vAo1q-0007Ac-8K; Mon, 20 Oct 2025 11:26:18 +0000 Received: by outflank-mailman (output) from mailman id 1146198.1478669; Mon, 20 Oct 2025 11:26:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vAo1q-00079J-21; Mon, 20 Oct 2025 11:26:18 +0000 Received: by outflank-mailman (input) for mailman id 1146198; Mon, 20 Oct 2025 11:26:16 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vAnvY-0001y1-QE for xen-devel@lists.xenproject.org; Mon, 20 Oct 2025 11:19:48 +0000 Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [2a00:1450:4864:20::336]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b030de25-ada6-11f0-9d15-b5c5bf9af7f9; Mon, 20 Oct 2025 13:19:48 +0200 (CEST) Received: by mail-wm1-x336.google.com with SMTP id 5b1f17b1804b1-471b80b994bso21402135e9.3 for ; Mon, 20 Oct 2025 04:19:48 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-427ea5a0f88sm14360924f8f.7.2025.10.20.04.19.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Oct 2025 04:19:47 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b030de25-ada6-11f0-9d15-b5c5bf9af7f9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1760959188; x=1761563988; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=CR7zFEwvrxzSG3gB+46rCvPXK38/dK1o+Nvm/MzzJ9E=; b=KU37/lenM3sFxXsCG7bWjyd56Lab/YJ7K6KDTHxjLUxriGFt4jS/6528MyWhd2EuHl GiXuP5jUDXfyzSAKgwCcCxF6Wn1n+oS9ZupoDFOxmO8DzlXNId1OQyyUdVhH5ULRFVFR L2x/3ZlDBO0BWVUwM4t9JqefQ7d8bSa0Kb2ouV6/S54EbYzOAaGGLvYNGE5ZLfRYQc/U uYLvlVGQKZl46uVEH0Imes1poM+7Bt4jR57kWatTSp7BRkkl5ZUYQBcXAw1hco8mry7F wMvRiUTR4F3eRqyVSnnO1zmj4VA8LzvScFWbKN86XuvoM7LcKgdL6B+hCjy/cFiOSSUE b4Ww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760959188; x=1761563988; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=CR7zFEwvrxzSG3gB+46rCvPXK38/dK1o+Nvm/MzzJ9E=; b=VMCyGFYaptIEFXWs3dvFy8mLpz7wlbtcCGmGE22bFQeOGtBlr1dC6qOPjdDm+SAPrY J/Xrphr5vqkEptMUojeV26CG0WaJrBM1C5YO0w7jqHFf8D/K37F80l3b8eHRbJ1o4nMP 14kG+FGTYQFX3c3G3EnAB+VIbCnh6rNRpqpb+EhwvSN4FQSR1HrFNZwQo3wV5wy77m/n dGuNemw0S77t5G8zn/gibOuX4p4ilwsiggjvjs7q5eITB4KordunxGzEzDfwX5Aq+bVR yE0IVLhnQQZNxSscVXEYQXSy9BsbNMFDigngGUXlRW9jICXcuhDKzwS43ajzxQ7NOBJz yImg== X-Gm-Message-State: AOJu0Yxo2Dhzxj4iJoB+rj0p7LYlD7ooEJsa7JODbpp2SeL9TYdPdc+l j7FNjvEXADbVuf7D0AvG0dhBysHRQThTofovYQte8jHkJ2pUfKVBzxgUcLyH28VCzdqfcsDwpTo rEH8= X-Gm-Gg: ASbGncvGTPFnwTvn/2qBEJBIVmpF8tyihHj5DB0q0FZj05IadvbylqVoSzGdtPr7QEZ bqW5ZfuW8xVOq2QYTXBdGVqjNTRRH88VmvK/RffpG57gf/gvW+HIeP2evOcvXt51ySnjnKkbeB3 8onTEIEJre688Q/MJfYZnUMeDqXMVp6eNPNFtvLUIALSWh5jtHYGSX/SDhSRoJI9mMQ6GCW6IoL hXjnbX8L+k2ffEXAM7UhJY3lahaBidCRf8kBBAnWAIjNYCMnaFa7cA/1emMQ/Vvvk1Sc9rs8NHN YG6HQ+wNF3IptQdVi3wi1kfoEc80e+rsyO3vvaEnEnqnv/yh/Uo3uzaD7/DAAHJndy5ilRiKo7P 53wO84BUUcJNdoP+oNI3TH+di9/nGTkrbKq+p4yNartbNyn3J4JcIny/nqXpmGJXa9czkqBcpQJ NhgFo/jXhTyPAnDk8KK8Ap5ym+vQLuSQpgE52hKbTkpicA1MZ5iJo+WYAo0r9gUbqXBwXzJRQ= X-Google-Smtp-Source: AGHT+IEd49XdP31L+DSylBiy/DOCgThBkpasnl3hoODQF5+iU+ABD66x9VEEnjzlv83dAxeMPWlKDQ== X-Received: by 2002:a05:600c:4e86:b0:471:13fc:4ad3 with SMTP id 5b1f17b1804b1-4711787847bmr109747565e9.2.1760959187605; Mon, 20 Oct 2025 04:19:47 -0700 (PDT) Message-ID: Date: Mon, 20 Oct 2025 13:19:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH v2 4/9] x86/HPET: avoid indirect call to event handler From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= References: Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1760959591669154100 Content-Type: text/plain; charset="utf-8" It's only ever handle_hpet_broadcast() that's used. While we now don't enable IRQs right away, still play safe and convert the function pointer to a boolean, to make sure no calls occur too early. Signed-off-by: Jan Beulich --- v2: Re-base over changes earlier in the series. --- a/xen/arch/x86/hpet.c +++ b/xen/arch/x86/hpet.c @@ -40,7 +40,7 @@ struct hpet_event_channel s_time_t next_event; cpumask_var_t cpumask; spinlock_t lock; - void (*event_handler)(struct hpet_event_channel *ch); + bool event_handler; =20 unsigned int idx; /* physical channel idx */ unsigned int cpu; /* msi target */ @@ -194,7 +194,7 @@ static void evt_do_broadcast(cpumask_t * cpumask_raise_softirq(mask, TIMER_SOFTIRQ); } =20 -static void cf_check handle_hpet_broadcast(struct hpet_event_channel *ch) +static void handle_hpet_broadcast(struct hpet_event_channel *ch) { cpumask_t *scratch =3D this_cpu(hpet_scratch_cpumask); s_time_t now, next_event; @@ -250,7 +250,7 @@ static void cf_check hpet_interrupt_hand return; } =20 - ch->event_handler(ch); + handle_hpet_broadcast(ch); } =20 static void hpet_enable_channel(struct hpet_event_channel *ch) @@ -657,7 +657,7 @@ void __init hpet_broadcast_init(void) hpet_events[i].next_event =3D STIME_MAX; spin_lock_init(&hpet_events[i].lock); smp_wmb(); - hpet_events[i].event_handler =3D handle_hpet_broadcast; + hpet_events[i].event_handler =3D true; =20 hpet_events[i].msi.msi_attrib.maskbit =3D 1; hpet_events[i].msi.msi_attrib.pos =3D MSI_TYPE_HPET; @@ -808,7 +808,9 @@ int hpet_legacy_irq_tick(void) (hpet_events->flags & (HPET_EVT_DISABLE|HPET_EVT_LEGACY)) !=3D HPET_EVT_LEGACY ) return 0; - hpet_events->event_handler(hpet_events); + + handle_hpet_broadcast(hpet_events); + return 1; } From nobody Thu Oct 30 15:26:07 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1760959624; cv=none; d=zohomail.com; s=zohoarc; b=U+L30dIRJlnr1+FR0JFfEkXt4OvXFwHVwUAzgy7uDvfz+0njHkkr15lGgH33VbB+a4DcTynbrfd0VUcihhI1tddUfO/B7WnwV4NWlzFFAwI7HZEdOSzVL+Bx6HcDK/uM8UWZZedszqLErtxiZF1Pzrl1SflI6qp17GMn/raX9e0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1760959624; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=4ft3MIA/0HMfE9mn1CrSRGwasVj918sVnbBRryONFvI=; b=Tdc4vY80nfD7hgurHHLb34xew3UUNKY1Q3clMQgR6Y2RYoTSBWg27Y+1UOBFTzvF0AGa65Rwt9ZYyyixUQEcpfT2vXE7Jto3gKTv/SHpsb+5ec/V3qY/mPpxiw+clkvzueRsDFRw7ttbNPK3ZXPobwK6qDYseS4twLnfczNNRVk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1760959624297600.2870593473746; Mon, 20 Oct 2025 04:27:04 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1146231.1478690 (Exim 4.92) (envelope-from ) id 1vAo2I-0008Pv-1D; Mon, 20 Oct 2025 11:26:46 +0000 Received: by outflank-mailman (output) from mailman id 1146231.1478690; Mon, 20 Oct 2025 11:26:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vAo2H-0008PU-P1; Mon, 20 Oct 2025 11:26:45 +0000 Received: by outflank-mailman (input) for mailman id 1146231; Mon, 20 Oct 2025 11:26:45 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vAnvv-0001y1-Hx for xen-devel@lists.xenproject.org; Mon, 20 Oct 2025 11:20:11 +0000 Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [2a00:1450:4864:20::435]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id bdb4c719-ada6-11f0-9d15-b5c5bf9af7f9; Mon, 20 Oct 2025 13:20:11 +0200 (CEST) Received: by mail-wr1-x435.google.com with SMTP id ffacd0b85a97d-426f1574a14so3118878f8f.3 for ; Mon, 20 Oct 2025 04:20:11 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-427ea5b3c65sm14775468f8f.15.2025.10.20.04.20.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Oct 2025 04:20:09 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bdb4c719-ada6-11f0-9d15-b5c5bf9af7f9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1760959210; x=1761564010; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=4ft3MIA/0HMfE9mn1CrSRGwasVj918sVnbBRryONFvI=; b=KchrSwBYdFKlg9rBgtvq/FVuIq6lS4C1xMIgvoSd5JSUeIcHo5kxFzs6Ys7gvkuO/q VClNQIvVIuYjLzdhJ8nqroP8S5zJQSGHyKFMUjiU5gOTceQHN16sq2eF7dib9B5RFaFa 2aIT+uO4/Idxi3vZ/3bGZX3OGx/ZZX+O/qpyGUuZwp8sHnzRQy732GamQ4bWfAwMjg/6 oSVIlSUXMQjYuIQiUxbvRw4saMPv4tBPIqCCUiye28hC1O3O6Xi0ua/KmSkingw5qBwr 5CSw3NOKNNwt+mfZaYLqyjTmhqbKPO8x1JE+AapC7RBgEBQYx0yxKt66RNWTlF/ZGFC2 VYCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760959210; x=1761564010; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=4ft3MIA/0HMfE9mn1CrSRGwasVj918sVnbBRryONFvI=; b=gjQRpF3Qw8RgXuYENend5CveGLTQdVVdS0e0w17mDnP5rNeLUFQBC3uZ4k5YQxf9Zc zaE62Am8F45ArStqLIIGuX9DFr5cJ+hgvoo8G+ATiuBpXA2i6WdgUq1t+pl18fwU9onM NQq/0kXafENP83dAVHYAoTFWF9c7tCIqPldt3BCDART6+0R6U2BAAYfyFL0Gy7AFybLS c23RpHBowjGIBWmjkY0jo9W8dwpuEz9bGxXhPKjhksW2E+GnzbP3KDByYc8H2dLeSkJp k0ZzmuiJQ2pDJuNItjHxRJI55ZFm1rdgY+ny/1W7bkvytPRoAuaT0vV3sDHIXppTGFmd eZhw== X-Gm-Message-State: AOJu0Yw9FMjXYWPm4zNp/PuckvHUQl1kepwEUtl5cbeoPe24Y4Ermd78 1zl6/Wqy3331SF5JTF5I9regnEG7Ley4XkZL9h/kVmCFRtBU4wJ/Yt5/MVaXRRLbNTvclRPAX21 MH9Y= X-Gm-Gg: ASbGncuebV0MQ0HdB1VcBfeB/FAJ1UXJ4OI3x02MA6KR/ezYkNL+4EKBg/KKFREF2oz wgUQA53z17brIyt4F/V9M9xzviO14ecRd3t9Xj50Fi2cbUlVBDRLdf6mnx2nGXSFNsekVcPHbVy N+yRn+Vv+roSg15KM4FSE6rfcnVL/N5Wr3yYDbJipTauFAaXMZjcAIqwuk9qBke2eiY0WIHweCL rAlHsqOg1xwEUo5PmfyxGWu3XW+XbKCgVR2RwliqOyGBVG6ObRwZ5i0jfLfslBM+dCiG/YN/xDe fPFiXPcFaorqt5RbjwR1+ujjpJH4WdDtQpTGrm+7BYuRk/UdRmHdyZ6JznZmzwB4XN7FIGIHZg8 MlLQRNeSBFNMwY0yn3GoYajr9RtdqY/IKPtw9oIki9tfbMLgENW8PPdq2SgLc5g+GYT1Hl31nWZ oJfznc6pT52JjRdkLqpS6GkeOCew/fY2ktk/TH8NqFkPvMYSq0d4nFoLYI7pW/ X-Google-Smtp-Source: AGHT+IFtQTKy/kD9PVEIcrRDmAyEd7RxNmjmlzPY/NFMDBBs2q9i+v800+Wp2aSt0Pa8jb5qSvSR5A== X-Received: by 2002:a05:600c:8185:b0:46f:b43a:aeed with SMTP id 5b1f17b1804b1-4711792cc0cmr88221065e9.40.1760959210236; Mon, 20 Oct 2025 04:20:10 -0700 (PDT) Message-ID: <95d977f5-6ccc-4a86-9ddd-bce0f70bc476@suse.com> Date: Mon, 20 Oct 2025 13:20:10 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH v2 5/9] x86/HPET: make another channel flags update atomic From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= References: Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1760959625954154100 Content-Type: text/plain; charset="utf-8" Unlike the setting of HPET_EVT_LEGACY in hpet_broadcast_init(), the setting of HPET_EVT_DISABLE in hpet_disable_legacy_broadcast() isn't init- only and hence can race other flag manipulation (not all of which occur while holding the channel's lock). While possibly any such updates would only ever occur when HPET_EVT_LEGACY isn't set in the first place, this doesn't look straightforward to prove, so better be on the safe side. Fixes: d09486dba36a ("cpuidle: Enable hpet broadcast by default") Signed-off-by: Jan Beulich --- a/xen/arch/x86/hpet.c +++ b/xen/arch/x86/hpet.c @@ -723,7 +723,7 @@ void hpet_disable_legacy_broadcast(void) =20 spin_lock_irqsave(&hpet_events->lock, flags); =20 - hpet_events->flags |=3D HPET_EVT_DISABLE; + set_bit(HPET_EVT_DISABLE_BIT, &hpet_events->flags); =20 /* disable HPET T0 */ cfg =3D hpet_read32(HPET_Tn_CFG(0)); From nobody Thu Oct 30 15:26:07 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1760959592; cv=none; d=zohomail.com; s=zohoarc; b=NwXPc/8hwg83lm5rceU50ni3WhUMAoLrp8DJYizlQJuJrgeR68q18mfJYMXf7dzK5pmSsuX6jjC1H1zemEKj6/2pfLt8Ja+pKyGZ3hV8w68AajszTQV2YQAmrZxbr0nI3rV6S3DUfGxCJ2/heHs7rWfo/ntZGtw/aWaq9XbFfqI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1760959592; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=gZ3R8cULpQMQwOc+UqUj9nrwmmhaEMKCYifki/vLVNU=; b=D9f2cSP/3B4CBndF6KakYjdY4EB3JndXAlgrJFfm73Y/+Q0fGdA3U/wq33MGO5NFCRQcRk8tPcDArxiKawcaYq1UbXX7SellonnClUcwgtOVPhBFX8mhnD5XNUkJPobHzEoFAlNF5McWiaLWtpa1LK0qDLDIPSwG6JJELida2yo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1760959592234126.72157768063414; Mon, 20 Oct 2025 04:26:32 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1146197.1478664 (Exim 4.92) (envelope-from ) id 1vAo1p-00077k-Uy; Mon, 20 Oct 2025 11:26:17 +0000 Received: by outflank-mailman (output) from mailman id 1146197.1478664; Mon, 20 Oct 2025 11:26:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vAo1p-00077a-Rf; Mon, 20 Oct 2025 11:26:17 +0000 Received: by outflank-mailman (input) for mailman id 1146197; Mon, 20 Oct 2025 11:26:16 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vAnwI-0001y1-2l for xen-devel@lists.xenproject.org; Mon, 20 Oct 2025 11:20:34 +0000 Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com [2a00:1450:4864:20::32b]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id cb3dacea-ada6-11f0-9d15-b5c5bf9af7f9; Mon, 20 Oct 2025 13:20:33 +0200 (CEST) Received: by mail-wm1-x32b.google.com with SMTP id 5b1f17b1804b1-471191ac79dso34219125e9.3 for ; Mon, 20 Oct 2025 04:20:33 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4714fb1b668sm160551465e9.0.2025.10.20.04.20.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Oct 2025 04:20:32 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cb3dacea-ada6-11f0-9d15-b5c5bf9af7f9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1760959233; x=1761564033; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=gZ3R8cULpQMQwOc+UqUj9nrwmmhaEMKCYifki/vLVNU=; b=DceKL+9YLPjkm+el3qQR0zM0kdrAAILTW7+s99QFuTdkECgcvCUqCnXuOS1YKFmAPz yVODD3cuJutIbU4IOBXUpF4qVJ0dSDLxslOvxFdsXOd6POfFx2KQwRraFRXghJlNKrOI RT5Zck581EgKzeK6uFCDHVzmtC9blw5PeWqKN+pX+AsBSBgUXQFBMKDaRi7kVscKTS5m WeLUUe2wWn91Flqh83DicYEh7TXyFs7AMf1b8Sekbfw8mZurZ/pUk8v9B6V7DUEwPmMm RActOaAw1Oym0yFJqOVafdYxFHdnvEkWjIYDX5k7hBhYsJQWuq3L7vCND2+UVOP6v9u5 XHwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760959233; x=1761564033; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=gZ3R8cULpQMQwOc+UqUj9nrwmmhaEMKCYifki/vLVNU=; b=FBuFaqSTZeiGy5kNFYIO1oqSxMI7rzGh3Q65M1yfKvV+kxmH7Quyno36AGeog5V6Lm k8ONaylJFIlmHJMTWeSZ307DfKZunBhHlCwbGbJkdH76VXnlOsIPhlPOSuLRlYDJnKT2 gQX4itjCfTZMf7y8FxfXS9ZrK0U/7TIxl4rtJN2JHovwnn6Eh2qT7E3yihanUN3fAIpn Bq4Y5CR80/vhcpF+S2vxtA7yPUCczhEjgR9OE1K/WZcEOTY3NioF3vGrsm5t62aTNTYW pmoCDRmoqpz+FWT/3cfocOdnKUxvq6zNiJriIyt5noI3YvZLHesDA+8a0yxxfkr1iPMY tDiA== X-Gm-Message-State: AOJu0YwcAJrx2STC82MfxipS8Qt8cHCSDCOzI60NtIVlRHTWONW/Rx7y Me3mtAL36q9UIFoEpFYKE3CdK93VImSzSDk7kjJBoPFmlIKOhacsoHlSWoM9XSo7AkGfJN5z9TS Acng= X-Gm-Gg: ASbGncvNiFe0mFBECcDOlRDYxzAkqAp3Ai/lDizyV+w5zKRA/l50HpToyvqsofzfXuV sbxZfL3LkmFmcpD8uWZn2gkPb/IanlEzR+CfIRQGM1BjGh1ckWfnp0oxQ/XmR3hyQKdY0eNJGfV kIaKRIhLvS2Wx/0U9nJ7ZW48EmQPcd7a50Qfbg4/HAYo0d01OKa4OaMQcvqe+6EhEBC4jAJ+FEm 4Ee6hvZqsJoSENkfv5yJ1CthkyJkopARGuHrKFEK5tYx9xONr+DeNMTYoeM3Nsntp3Xn9RpYK9S ssrJeh2N+KQo5d4GlrJRzPsDJJ2fczefTjDGS9vbTOwdnqfzUBK394SDrwvEPgoPi6sqhLiCHvM 1PYohOXKT5PxfvHMWBLX7b0yvI1dEffVwZ+P4aJ4V0H6EjFmUmeF0iCGOBkLyYFqfxcQqYNzhms A6BZD/O2NXbZrHRTCMDS9nrnpJgjAW0eADXRu4/Zr7vqJjQ3EMAE7bYhvPwvIF5JK6NZz+z5g= X-Google-Smtp-Source: AGHT+IEi0i5z6/lAoElAu4dVvd6h16qlzj2i2NBbrigFv4RURjPUaGqDEzcD3w8BLdN8pnmTaMGhjw== X-Received: by 2002:a05:600c:3b0a:b0:46e:4499:ba30 with SMTP id 5b1f17b1804b1-47117917a33mr109948755e9.30.1760959233050; Mon, 20 Oct 2025 04:20:33 -0700 (PDT) Message-ID: <4cdeac0d-8f73-44cf-a78e-8e3490047dd6@suse.com> Date: Mon, 20 Oct 2025 13:20:33 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH v2 6/9] x86/HPET: move legacy tick IRQ count adjustment From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= References: Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1760959593616154100 Content-Type: text/plain; charset="utf-8" If already we play with the IRQ count, we should do so only if we actually "consume" the interrupt; normal timer IRQs should not have any adjustment done. Fixes: 353533232730 ("cpuidle: fix the menu governor to enhance IO performa= nce") Signed-off-by: Jan Beulich --- _Why_ we do these adjustments (also elsewhere) I don't reeally know. --- a/xen/arch/x86/hpet.c +++ b/xen/arch/x86/hpet.c @@ -802,13 +802,13 @@ int hpet_broadcast_is_available(void) =20 int hpet_legacy_irq_tick(void) { - this_cpu(irq_count)--; - if ( !hpet_events || (hpet_events->flags & (HPET_EVT_DISABLE|HPET_EVT_LEGACY)) !=3D HPET_EVT_LEGACY ) return 0; =20 + this_cpu(irq_count)--; + handle_hpet_broadcast(hpet_events); =20 return 1; From nobody Thu Oct 30 15:26:07 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1760959628; cv=none; d=zohomail.com; s=zohoarc; b=nntLoNhwJycoH6avvBmGoYB/62NVs4yg7SHrV66vws8xITKPZCNqGe8ErFgpnjihVC0agwDQh/GIrtBKehno37597liJsSmVR7l7QelW4utghbgDM2Ezjy+0RB0OufTcQz3TE6uZPKowIRQJIJBGZPlD2VimTDNHt6dkyIM+5KI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1760959628; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=rds4jnnN9NVrTZyuc+q65+QBQEjCAV7rC8oJIxMqDF8=; b=Kv4j5hKiiCuI8saFE9gDLeUSV6oOu9r6plafGTKricxMoN7OH/dO2mL/dzHdLIJ/+667CqaJHSm1S/3wjOnU+3kRQn7AR06pJTFbJo9WWa53fZNN2auGGZqvdF/D9/MFJ89wQ2g+gnBr5srVzwiv5TI/lGN98l6p1Hwce80hmgQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1760959628390711.1031111004561; Mon, 20 Oct 2025 04:27:08 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1146229.1478684 (Exim 4.92) (envelope-from ) id 1vAo2H-0008Nz-LX; Mon, 20 Oct 2025 11:26:45 +0000 Received: by outflank-mailman (output) from mailman id 1146229.1478684; Mon, 20 Oct 2025 11:26:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vAo2H-0008Ns-Ir; Mon, 20 Oct 2025 11:26:45 +0000 Received: by outflank-mailman (input) for mailman id 1146229; Mon, 20 Oct 2025 11:26:44 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vAnwg-0001y1-S1 for xen-devel@lists.xenproject.org; Mon, 20 Oct 2025 11:20:58 +0000 Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [2a00:1450:4864:20::330]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d9fd58f3-ada6-11f0-9d15-b5c5bf9af7f9; Mon, 20 Oct 2025 13:20:58 +0200 (CEST) Received: by mail-wm1-x330.google.com with SMTP id 5b1f17b1804b1-46fcf9f63b6so22311905e9.2 for ; Mon, 20 Oct 2025 04:20:58 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47154d38309sm142168915e9.9.2025.10.20.04.20.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Oct 2025 04:20:57 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d9fd58f3-ada6-11f0-9d15-b5c5bf9af7f9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1760959258; x=1761564058; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=rds4jnnN9NVrTZyuc+q65+QBQEjCAV7rC8oJIxMqDF8=; b=DvtaxUr3fc0WHOImWZeiK+H6ToJPY9jRlhe5DyKLGXpsTfurc0yvR/3pEatQsaBg7v Jzlwqzwv0NrBJ5Kk+KbmTaelbXiC1uZKMRIQQULlIhfM5nkec8hAGgO9+5IYUf5G9tja XWyt8T64Iy8pZGjJZkCs+dQNG0KKpk9tMDAXSisogRHhWU7y/s3/Kca/+cke6WBuxykN 1XWpuBFH95MIsDHzVncHH09a2c3OwUYtQ11xH8kKVFy/lCqq7/zIVq3aEN7mVSCra7ii MiRPnTHjWX66jsiySarVIF2ppdP9oLpBUtn3a03X38to4k8t+5eeEGwFQ2Uj44400Wmr Nb2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760959258; x=1761564058; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=rds4jnnN9NVrTZyuc+q65+QBQEjCAV7rC8oJIxMqDF8=; b=qg8m1RMzcaEQvWBt7nzBW/lc7jj63GYMvq/PAAi70lZRlXRtGotbnLlbVp9LThTdVR C2Mki77hXYtewVBPa+r4eR6vbUxSkunG3W9CZfoUNvOxSkq2j17mGy9CROpd68Ux/eTQ 0iMYrk3c69m21UwaGJUnJUYFXGN8xmVRq4RgsNHPmgH5heRyxMR/bpHf1eZ43t+H0qAw xIuJWw7qJ5O4Mm+o6DAJv9hMoD0UNU65J2Vl/cx3ujnWCyLl8QavczP1YJ7uGclOeNMF JUhtNd1EzrCWP64Q8jGZTE0Z98ha+IVR3QW24JZWGMwTOQjwfTuYrhuMuyo+wu/bumEy tXrg== X-Gm-Message-State: AOJu0Yz4MDQR7EB6maWUsV/rxs4i92EbuBhgOjkwUPYJCg2Oby1HJmja /i1gkvmlpXXxxyRh/bukA9Lsl/Uxt9LX/Fl0sx8DnVsgBsSHrnDYAzfyMsNp1uLWElvGrTVe38C 2EMU= X-Gm-Gg: ASbGncvXnkp1TFWRV/R3BKVKmsrh26Sii7YqHfW2/yWTVAvX+lc/4BaPfkUYKlFCxQq guDr7q/48VSTmBC1nJNnYgwhzelN7IuCdzueiGlYsnJZj/z0r9OW0PrsBZTQ5UBapbK+5SJ2L9p 3oTB8xANYCbYV5lCBR92zu4LdC2UmoHUUrTa8FGsYnJeJjBZwX/fPHvx6x1hNGtbysLhPUkzSf4 62VSKcQ/4DZQ/8QB75svI1zQhMihNP1WGUBJhMl3Vi9BAidFQ+Hzao+SPnKiuzoiex/HCuWYQXA 7DVQeo5gBXTTyUZOvqlXapTyx2QeyyBAoOGAvfp0OdoBA2ef2Ao5oUjQCqxKX5pktYE1UVdYilM unBdMUHMleoooPAVsPEC0Bl8pBbE9VfGsAtZcrnxUG8xrUvt6T2XjTcthCgBONPY4j9XDjtb0nB I7zFHiwUTOfWDhAcZOxmLToIVXGAvLnHCyp8nVuZbhq/CoYxheHN3ObjupFXKqC+yU2OHFWayYr Yv2hMpBgg== X-Google-Smtp-Source: AGHT+IFxeSoKZVTafA7dqmByPVATZl0pltbsEYB4cctuuaQSYVLfZrncYc3yd+dH+OjUjxxC/ofeWQ== X-Received: by 2002:a05:600c:6385:b0:458:a7fa:211d with SMTP id 5b1f17b1804b1-47117912365mr94081455e9.29.1760959257809; Mon, 20 Oct 2025 04:20:57 -0700 (PDT) Message-ID: <7e376968-1eb6-4f0d-a9eb-167b26d90786@suse.com> Date: Mon, 20 Oct 2025 13:20:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH v2 7/9] x86/HPET: reduce hpet_next_event() call sites From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= References: Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1760959630003154100 Content-Type: text/plain; charset="utf-8" I'm surprised gcc doesn't manage to do that: At least in debug builds two call sites exist, just like source code has it. That's not necessary though - by using do/while we can reduce this to a single call site. Then the function will be inlined. While improving code gen, also switch the function's 2nd parameter to unsigned. Signed-off-by: Jan Beulich --- Oddly enough the CDQE is replaced by an entirely unnecessary 32-bit MOV of a register to itself (i.e. zero-extending to 64 bits), as that's immediately preceded by a 32-bit ADD targeting the same register. --- a/xen/arch/x86/hpet.c +++ b/xen/arch/x86/hpet.c @@ -124,7 +124,7 @@ static inline unsigned long ns2ticks(uns return (unsigned long) tmp; } =20 -static int hpet_next_event(unsigned long delta, int timer) +static int hpet_next_event(unsigned long delta, unsigned int timer) { uint32_t cnt, cmp; unsigned long flags; @@ -173,12 +173,10 @@ static int reprogram_hpet_evt_channel( delta =3D max_t(int64_t, delta, MIN_DELTA_NS); delta =3D ns2ticks(delta, ch->shift, ch->mult); =20 - ret =3D hpet_next_event(delta, ch->idx); - while ( ret && force ) - { - delta +=3D delta; + do { ret =3D hpet_next_event(delta, ch->idx); - } + delta +=3D delta; + } while ( ret && force ); =20 return ret; } From nobody Thu Oct 30 15:26:07 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1760959581; cv=none; d=zohomail.com; s=zohoarc; b=CkKXFmstQhc2tcKqrkGrs6MEG8S7HyGNSJPmNq004v/RPtcGrjrFC0Vk1ZUFa7Ob0rnimL/ofkIpJQTBRTaQu0DYKpC7IuC2r/KrMXOWGk3L+MC9cyV52pchcKgDnLk2jTBzYyxr4GirlIGoufMZPUE/dStrnvaRIyVJf4sgmf4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1760959581; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=/bovBnMZlpdcR5xnSOmFdCORNaMff19Gz4ZDC+SsaVo=; b=CDhbS9D2uxjjxz45N59lLarC5WNkIo7+JCwVwTBMWTmGsoji9gCCNtRagoF7IODP9//w3CkduUhlpiex6tNjX6aj3C5VyaHZ/QCVwkRgUpur7LZ9UFA0IENaGKAJZxbV28bsgoL8xzOPsVJuTYgfmUODQpeN33LrLu3y5bg9Vh4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1760959581143437.4717058299632; Mon, 20 Oct 2025 04:26:21 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1146193.1478653 (Exim 4.92) (envelope-from ) id 1vAo1g-0006ml-NP; Mon, 20 Oct 2025 11:26:08 +0000 Received: by outflank-mailman (output) from mailman id 1146193.1478653; Mon, 20 Oct 2025 11:26:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vAo1g-0006me-Kt; Mon, 20 Oct 2025 11:26:08 +0000 Received: by outflank-mailman (input) for mailman id 1146193; Mon, 20 Oct 2025 11:26:07 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vAnx1-0001y1-9g for xen-devel@lists.xenproject.org; Mon, 20 Oct 2025 11:21:19 +0000 Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [2a00:1450:4864:20::334]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e6213609-ada6-11f0-9d15-b5c5bf9af7f9; Mon, 20 Oct 2025 13:21:18 +0200 (CEST) Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-4711f156326so28740375e9.1 for ; Mon, 20 Oct 2025 04:21:18 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-427f00b9f9dsm14822154f8f.39.2025.10.20.04.21.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Oct 2025 04:21:17 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e6213609-ada6-11f0-9d15-b5c5bf9af7f9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1760959278; x=1761564078; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=/bovBnMZlpdcR5xnSOmFdCORNaMff19Gz4ZDC+SsaVo=; b=Jwm/qoTpS3+DoZnfu86ydyF6w/oTxnqUmDQB5AMCzMjW2wC0zPt+s50TZo4/N6HrTY 3OVcPFUAjOacGiJVuOJHELNgITz4QMKl0SOuvPcWVFGRE6acvwMdfBnxNtf0CHH971PG j4caC0/fHjoJ50Q8nbJ9lEA/NXtJWig9xIczh7YhU1prRZ1Yk/h6coYiFplNpkV7BLWk 5biM0TEG2uY8Tq665if81DqRbgvd9cFjMhH9CSUSmTi3vujDMh4YerWxBTCNST1rjiUa bxQG+0c64uNaVJ1zCuYrooOznVsV2wYpbA2r3/eCPbKc91gigms2s2YMzwB+TygOK7u6 HSyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760959278; x=1761564078; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=/bovBnMZlpdcR5xnSOmFdCORNaMff19Gz4ZDC+SsaVo=; b=t8JUjwcoDKaKcSRpzV0T5Qs5ghD6eudIo5KROzYrrf9QOTm2serACO8RBu4uZQxxxE CnA9RN/n/0oVKmFfdtbrt23wfRa/3OPEh+20MNSlakq3jXg1QNwi/qVaaBWRL2BUDDDN molrHaJRgH8b0wIO7YfF7c2xJKgoxwV6K3RsD8yFOs08rhqtVcX1FFdPuHxY3RBrXfjZ jh7Z3yRV3xcLuFfI5rbpjwk9NeQrsrsoK6OLgKO2K3lhG09tNpNfyFwhh9j8WUyOhKzQ lEB/ht1GkvPMaTcWbZ/J8MVOFphKWasJAJ9qBZwyq16k7nNblBYF/4Ac4l7X+1B7PiDS npfA== X-Gm-Message-State: AOJu0YxRRD7XtSvIQVxQh5d7+MkryB0S4oHLLri1xAEftohGi6oVhazl 4HAqH3AdAfXtq/LRPhn684RNlFWMbbnZi6YRQphlvpX9uIBxTMgBgCm6PXgI0I8Oow5u+7KmTRf jvSE= X-Gm-Gg: ASbGncvfpxBy4aQ6XwSUHQNhWzTyMFqie7tFSFiul3uQcGH7F2GWmxcwrpCnQMjJ1oL IGc4nqTdX1IrFABtHpF7Od/gz8hzwUJvDCiimEOCYvS0TKfzljPKT1BkS2zEDa+ObiQ8T46Gvsu z1IUQgnuYeS1r9ebGdrtocKp9GHgtLOOSy++c7JBTVuMXz+Ut381TvXB0iHLbUEqxfMZ4fdj5m6 on7G1LYghDgnBohnJbpDupeHG4gn4LlmctjlyeOPhaYSNjXfLVj6sT0fqdUkkNe8qWM0ZXL8QjD wg6nDuwXnZKgIYZFMZm9CEBaPWhd9cwSkXmB8mvAXumt/1XfASudCAGvyIjJkpTrT2HnmVcxRxV V1/KsQ0Ba1wcaHFz3C/ZzQAKcVcxLHpYAcOe0RS0cghiEg2AQqN0PUZacaDmUhcg6qK9eiHnD1r /q+DsVaskij7GZj2e6Q/VKskg1MouWhQMcSeCH/3VdEl20RyziWSiBdfcb8cziFjFIoIqQY9M= X-Google-Smtp-Source: AGHT+IGZVHllDvy8xBuSDysKAU/0iFJ7N0bKLzv76WL3TZeTF1MU7jcqslieCUYBzpX92bNpmmdgUg== X-Received: by 2002:a05:6000:22c5:b0:427:492:79e5 with SMTP id ffacd0b85a97d-42704d7504emr7602131f8f.21.1760959278154; Mon, 20 Oct 2025 04:21:18 -0700 (PDT) Message-ID: <2e140536-6e24-4de7-a5f6-0c0e19951f13@suse.com> Date: Mon, 20 Oct 2025 13:21:18 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH v2 for-4.21 8/9] x86/HPET: don't use hardcoded 0 for "long timeout" From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Oleksii Kurochko References: Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1760959600438154100 Content-Type: text/plain; charset="utf-8" With 32-bit counters, writing 0 means on average half the wrapping period until an interrupt would be raised. Yet of course in extreme cases an interrupt would be raised almost right away. Write the present counter value instead, to make the timeout predicatbly a full wrapping period. Fixes: e862b83e8433 ("CPUIDLE: Avoid remnant HPET intr while force hpetbroa= dcast") Signed-off-by: Jan Beulich --- Actually - can't we just disable the channel instead of setting a "long" timeout? Of course we'd then also need to enable it a few lines down. Yet in turn we could then remove the enabling from set_channel_irq_affinity(). --- a/xen/arch/x86/hpet.c +++ b/xen/arch/x86/hpet.c @@ -165,7 +165,7 @@ static int reprogram_hpet_evt_channel( if ( expire =3D=3D STIME_MAX ) { /* We assume it will take a long time for the timer to wrap. */ - hpet_write32(0, HPET_Tn_CMP(ch->idx)); + hpet_write32(hpet_read32(HPET_COUNTER), HPET_Tn_CMP(ch->idx)); return 0; } From nobody Thu Oct 30 15:26:07 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1760959330; cv=none; d=zohomail.com; s=zohoarc; b=NxVHhbX2Zydvj32N15KZWwWxXixpX/ShQkuAJZV1dotpze2oYhRvYhnjcdbfI8XHbvxfdrg57YYTm+oa8NLLoPVnJvHtnwcHph17ZmFsJimVByQv8q9In/Xuj+8kLs1AY4xq3IpShcHwKodwvokp222dCzXudxSY6TEM55uHXcU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1760959330; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Yfju5TuSYr1gnKBFs17R38Pvw/Jb2fzNTTH63D/Pa3U=; b=EhRoOukanWXBmyAZ5UuGF57kGsqeKkLEyHwSV1ktiuq+ThpGFMLq5aI7O5SQMw9+Uiuj8Y6WC2Uh14fd0cvHbWEfDJIuBU8yHKdqr458J/IKutuLnVIL1MLymvkG9aF+C5D+7iubAPXM4pmNQSS2skS1xflSJWXQvguSyabk1KM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 176095933052644.02161017613389; Mon, 20 Oct 2025 04:22:10 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1146159.1478623 (Exim 4.92) (envelope-from ) id 1vAnxb-00058R-Ra; Mon, 20 Oct 2025 11:21:55 +0000 Received: by outflank-mailman (output) from mailman id 1146159.1478623; Mon, 20 Oct 2025 11:21:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vAnxb-00058K-OM; Mon, 20 Oct 2025 11:21:55 +0000 Received: by outflank-mailman (input) for mailman id 1146159; Mon, 20 Oct 2025 11:21:54 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vAnxa-00058E-5Q for xen-devel@lists.xenproject.org; Mon, 20 Oct 2025 11:21:54 +0000 Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com [2a00:1450:4864:20::332]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f9b12817-ada6-11f0-980a-7dc792cee155; Mon, 20 Oct 2025 13:21:51 +0200 (CEST) Received: by mail-wm1-x332.google.com with SMTP id 5b1f17b1804b1-47100eae3e5so39349555e9.1 for ; Mon, 20 Oct 2025 04:21:51 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47160987184sm59788055e9.11.2025.10.20.04.21.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Oct 2025 04:21:50 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f9b12817-ada6-11f0-980a-7dc792cee155 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1760959311; x=1761564111; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=Yfju5TuSYr1gnKBFs17R38Pvw/Jb2fzNTTH63D/Pa3U=; b=EVoV4FFZ9R4OPzh/RUdqZM4nmyJL+xldLXM4kiY2Wh5WHuxUNmt3hkYP2VN6o0t8n3 mQ+FZwkeO5numFXz1RsRwhZ+5DTMkw4y8Djwwid0rBACSot/+lKQlW4I2K1R6W0z1DzV aywrOlKgwEuegsyQsfo+vVPl4CHs0I8gHiy9F+buQcekxChHEbeOKBkZ7Ref4zoGtI68 Rb0BfjfeGl+sQWlMrI2LZEIamCIP+Sbs84XPQT2yDLObFcmj6vo9tqQ28SYvy7H26iC8 CCRFwzY2ly3sOFfxRoflEAfYJrkeCk5U7C3d0qQ+4Sx7QXWk/JfP3p9Cy+LdlT/1Au2b 4ung== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760959311; x=1761564111; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Yfju5TuSYr1gnKBFs17R38Pvw/Jb2fzNTTH63D/Pa3U=; b=GKNyAdiyAxYdYPXvRjtddNLnaciCAF/GSWgTmHeMF+MyB1s9uk7Ee1+NTESOY68jfL RuPdCSyN7JCJsRZI6FHA5GW1Amazkg0n1u88ebtby0V3ozTMEwm14GfcjEC3bteddDnt cE1G+Di1kygZRtpbDIHHs6ZwxvEjTWyGx33PSyIA2gTh3G94sL94WKYhq4Gv+OCmtdYj iImuN8frufq5cq2sKqYjNc3qVFI7C4EZGJ0gQaYAirZ7KPMeQb3w2heHi16wjXHpy8Un DVAuiZc/eXbATKzI3UcNhlZDQR5cueQHBvKT15yw1KRrgxwkYpcpAMbKbm49TmhVaIBM iAgQ== X-Gm-Message-State: AOJu0YxN4BHJCYI6jYZqNTQ367e6vO5W+gM9K0hH30a/UCPA7nOFDBtr l7eDRyxsVDHdDPgfWTSaYVlPi27lSeYEAtJHwnxWyT6GGqmnGB/qbByNKbY7GvqA4vigzTAbz+w gdv8= X-Gm-Gg: ASbGncs9I8MDNLPaQyztjrxvOWLtgK4hUSKASuYCgqlrVa++QOwBhDCxLGWWQtaRYqt d86UXzDK10X1BDL9gwd/oHdQAJIwfuZ5s0kneULiI77/ySIMpCnUarG4Ust5z7C88fbkzhUi2qf /SZ0SU8xmKuccMmuzyYk4qBTvs4kGCSgbTluTO986ALB8MBUV6XxPlOx+uDux5FhfRkvcM8ij+6 K64GY0KA8xq/aMVUXF4zMUZmErgaOoQECg3TZhuUs6QGRRj7ln+VLxQoARw9EfIV7c4yL9rH52O 0MdNa15wPKjlpABWcLM21EHRJtfxNa3I9o41ulAdBPeol/OYyFPPX9ittq62DJLyRpmnXmikgo5 sYl/EBJ/ek5lUOmFiQWFTiWOuwIybdzjomQn0AQn/Gi2dQTgyabXCows1OmqwoPXUuHACJVwAPr Pky0EWUR0TZzZNLgDNHcrmPNjS5KrP/mNlHlFesDN8VgVY9EYlP4S1M1RXHV2NOKPmhTIMAMs= X-Google-Smtp-Source: AGHT+IEtmGDyRsBl9htJ526cm9h+9wIw5KznJsMXYVif6/SuHdjk7VYyyZ1p99weciLPSfTIwx7dXw== X-Received: by 2002:a05:600c:3488:b0:459:e398:ed89 with SMTP id 5b1f17b1804b1-4711786c586mr89914955e9.1.1760959311006; Mon, 20 Oct 2025 04:21:51 -0700 (PDT) Message-ID: <65b6c05b-49f4-4a3e-aa13-abf5da99f9cb@suse.com> Date: Mon, 20 Oct 2025 13:21:51 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH v2 9/9] x86/HPET: simplify "expire" check a little in reprogram_hpet_evt_channel() From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= References: Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1760959332168158500 Content-Type: text/plain; charset="utf-8" When this was added, the log message was updated correctly, but the zero case was needlessly checked separately: hpet_broadcast_enter() had a zero check added at the same time, while handle_hpet_broadcast() can't possibly pass 0 here anyway. Fixes: 7145897cfb81 ("cpuidle: Fix for timer_deadline=3D=3D0 case") Signed-off-by: Jan Beulich --- v2: New. --- a/xen/arch/x86/hpet.c +++ b/xen/arch/x86/hpet.c @@ -147,10 +147,10 @@ static int reprogram_hpet_evt_channel( int64_t delta; int ret; =20 - if ( (ch->flags & HPET_EVT_DISABLE) || (expire =3D=3D 0) ) + if ( ch->flags & HPET_EVT_DISABLE ) return 0; =20 - if ( unlikely(expire < 0) ) + if ( unlikely(expire <=3D 0) ) { printk(KERN_DEBUG "reprogram: expire <=3D 0\n"); return -ETIME;