From nobody Mon Feb 9 18:19:36 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1619017108; cv=none; d=zohomail.com; s=zohoarc; b=EgwvFCunUK/iJe7pb4y9yEasXktzn2XRPRZCZVx/r3sDZ7nEpTPSgIrfBOqVPjHHqfais25qwhLpWCMr4BvVPWHGIhBytvAyzNLRW9gPYRkqEmfPaUmpwhnpig54dmGwKFxUi+Nk/MbwnnpZmHg/bnBRP5qgzo196CrbMqAXMUs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1619017108; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=PW+XxMcrclQ3Woj7YTyYCjraRWb4WLw8fXwPv9OBWoI=; b=nEA0lbHObYiCWCXN/opBCUlrOiFfSfnAmA1zWukRv5JuMOj6OwmNHmQMhbj7KIsfF+SM6yfdswYMFdeW/1epsXpn8JFCWmGoQLae1QBTGTQbcnOVw2isRyhRPGlvatvoBS1eDwhXw2FWTXwbwQIdEQv+e/cGhyNRbGJW+/2twMY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) header.from= Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1619017108621639.6614073565322; Wed, 21 Apr 2021 07:58:28 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.114799.218845 (Exim 4.92) (envelope-from ) id 1lZEIw-0008Ju-7u; Wed, 21 Apr 2021 14:58:14 +0000 Received: by outflank-mailman (output) from mailman id 114799.218845; Wed, 21 Apr 2021 14:58:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lZEIw-0008Jn-4G; Wed, 21 Apr 2021 14:58:14 +0000 Received: by outflank-mailman (input) for mailman id 114799; Wed, 21 Apr 2021 14:58:13 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lZEIv-0008Jg-8h for xen-devel@lists.xenproject.org; Wed, 21 Apr 2021 14:58:13 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id fd55a24a-ca85-42bd-bf69-2fd0fdeb40ff; Wed, 21 Apr 2021 14:58:12 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 91783B4F5; Wed, 21 Apr 2021 14:58:11 +0000 (UTC) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fd55a24a-ca85-42bd-bf69-2fd0fdeb40ff X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1619017091; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PW+XxMcrclQ3Woj7YTyYCjraRWb4WLw8fXwPv9OBWoI=; b=C5iUJDEKmDytH3E/JE6ybsGGTSClh2t7iobc0KwmwvYv+5WL05v1VfGIUSQAMmz/6WqY9B uiXjCRaTDs+8sxk1K1Y9KBK+9lm3Iz2ezOGyOjR/0OTHEwcqz6br8qb8VyD6xI4If6Dlr3 U/A1gnd2nudemy02NM7BHM6W0ArZmPM= Subject: [PATCH v2 5/8] EFI/runtime: avoid effectively open-coding x{m,z}alloc_array() From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu References: <091b4b91-712f-3526-78d1-80d31faf8e41@suse.com> Message-ID: Date: Wed, 21 Apr 2021 16:58:11 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: <091b4b91-712f-3526-78d1-80d31faf8e41@suse.com> Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @suse.com) Content-Type: text/plain; charset="utf-8" There is a difference in generated code: x{m,z}alloc_bytes() forces SMP_CACHE_BYTES alignment. But if code really cared about such higher than default alignment, it should request so explicitly rather than using a type-unsafe interface. And if e.g. cache line sharing was a concern, the allocator itself should arrange to avoid such. Signed-off-by: Jan Beulich --- a/xen/common/efi/runtime.c +++ b/xen/common/efi/runtime.c @@ -486,7 +486,7 @@ int efi_runtime_call(struct xenpf_efi_ru size =3D op->u.get_variable.size; if ( size ) { - data =3D xmalloc_bytes(size); + data =3D xmalloc_array(unsigned char, size); if ( !data ) { xfree(name); @@ -536,7 +536,7 @@ int efi_runtime_call(struct xenpf_efi_ru return -EIO; } =20 - data =3D xmalloc_bytes(op->u.set_variable.size); + data =3D xmalloc_array(unsigned char, op->u.set_variable.size); if ( !data ) rc =3D -ENOMEM; else if ( copy_from_guest(data, op->u.set_variable.data, @@ -571,7 +571,7 @@ int efi_runtime_call(struct xenpf_efi_ru return -EINVAL; =20 size =3D op->u.get_next_variable_name.size; - name.raw =3D xzalloc_bytes(size); + name.raw =3D xzalloc_array(unsigned char, size); if ( !name.raw ) return -ENOMEM; if ( copy_from_guest(name.raw, op->u.get_next_variable_name.name,