From nobody Tue May 7 18:28:54 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1612191437; cv=none; d=zohomail.com; s=zohoarc; b=XFgV6lHEVUbRnzjD4JyKmRE860pWWwzoVebBhsjjvBPmXk2jfCgtck4qvSP+wE0IwCIcdBVHr2LRbWVYyBy02NBjG/wjsxADz0AJ/qOaTL3Hw7n4mC+/ZLOk5123W64LolmGwe1z9rj8D4etEaA0HG6DsL3U9QW7Ig4Oj6dB/iU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1612191437; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=gpjsoXyymi3tg3gNQWwGrxdoOaO5dOb3D73T4UALbJY=; b=SYF3LHaVm+Pf1DnL3Ju5Ul2Oz+YlT3Pe1bXueT7YNNvILdb72FGrYFRPRg0+xTsamMUgk81nrCMwSk+ivM9xFxaqqHvWNvqBOq6tQYCQwQaE3bI2iI9NfOixsJxb/ykiKe6FYoJZP3QNHN2BDNUU9tSyRZ8oEyC8jVt9/JF2eNI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) header.from= Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1612191437345977.9594790782311; Mon, 1 Feb 2021 06:57:17 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.79931.145801 (Exim 4.92) (envelope-from ) id 1l6adT-0002A3-NE; Mon, 01 Feb 2021 14:57:03 +0000 Received: by outflank-mailman (output) from mailman id 79931.145801; Mon, 01 Feb 2021 14:57:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1l6adT-00029w-K2; Mon, 01 Feb 2021 14:57:03 +0000 Received: by outflank-mailman (input) for mailman id 79931; Mon, 01 Feb 2021 14:57:02 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1l6adS-00029l-JC for xen-devel@lists.xenproject.org; Mon, 01 Feb 2021 14:57:02 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id e9c5d348-d9cd-422d-a2be-e0cf2a827521; Mon, 01 Feb 2021 14:57:00 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id CD1BAAB92; Mon, 1 Feb 2021 14:56:59 +0000 (UTC) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e9c5d348-d9cd-422d-a2be-e0cf2a827521 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1612191419; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=gpjsoXyymi3tg3gNQWwGrxdoOaO5dOb3D73T4UALbJY=; b=O4jT9VS+Vw7V5cpYT9lciX+jT/8jHDht0cw27NOF7UCQLEainrdSOaNGOvaRB+ZJiljoYE LoAbHbV8uhV2xWmmlyxWrxP5zhy9Ih39kc+rmJMoov71Z3Bl18IzCufXUz5SXHL02CyH5m Kye9Ycd/Uy1LVsc+szPH+qUW7qddjFY= To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Julien Grall , Ian Jackson From: Jan Beulich Subject: [PATCH] x86/build: correctly record dependencies of asm-offsets.s Message-ID: Date: Mon, 1 Feb 2021 15:56:59 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @suse.com) Content-Type: text/plain; charset="utf-8" Going through an intermediate *.new file requires telling the compiler what the real target is, so that the inclusion of the resulting .*.d file will actually be useful. Fixes: 7d2d7a43d014 ("x86/build: limit rebuilding of asm-offsets.h") Reported-by: Julien Grall Signed-off-by: Jan Beulich Acked-by: Andrew Cooper , whatever the --- Already on the original patch I did suggest that perhaps Arm would want to follow suit. So again - perhaps the rules should be unified by moving to common code? --- a/xen/arch/x86/Makefile +++ b/xen/arch/x86/Makefile @@ -241,7 +241,7 @@ efi/buildid.o efi/relocs-dummy.o: $(BASE efi/buildid.o efi/relocs-dummy.o: ; =20 asm-offsets.s: $(TARGET_SUBARCH)/asm-offsets.c $(BASEDIR)/include/asm-x86/= asm-macros.h - $(CC) $(filter-out -Wa$(comma)% -flto,$(c_flags)) -S -g0 -o $@.new $< + $(CC) $(filter-out -Wa$(comma)% -flto,$(c_flags)) -S -g0 -o $@.new -MQ $@= $< $(call move-if-changed,$@.new,$@) =20 asm-macros.i: CFLAGS-y +=3D -D__ASSEMBLY__ -P