From nobody Sun Apr 5 18:22:09 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1774370343; cv=none; d=zohomail.com; s=zohoarc; b=OxXHmZlUigY+ozKwQwFWe3mdVEa1qmWyaJ+7pgEFacK0mu/LIU1mMD+F5/mR+asqA6WGvtuLasqnAheXb+0QrIwk5byq6+WoAkJ4LgU604otHPMEyuQ5BHgFudxiK4J6CfxuILUuaG7stoo2FMUpvI2hNpAI7j3LIRuz2A7PCJc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1774370343; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=PYk9vEEfGRYDleF6fCoNLGed2AL29CgD3kCqdLh6Eqg=; b=Op9G+lCmCQgQdrBSUDdO37VH3EIyaYlHEhKSx53HFfonNTr6WJ7yVjCHrY9eZTf5zrh+qgE37mNGF9Ms65wswePvhshvKhV02XHLkrKbnnHuX5qDiN4U2lXr8Khhrm/wKOZZYj4756HWvKKJQpEW8FSUFrdWLoB5AzpVQE57048= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1774370343519616.7769159075215; Tue, 24 Mar 2026 09:39:03 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1261126.1554246 (Exim 4.92) (envelope-from ) id 1w54mE-0002v0-PH; Tue, 24 Mar 2026 16:38:46 +0000 Received: by outflank-mailman (output) from mailman id 1261126.1554246; Tue, 24 Mar 2026 16:38:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1w54mE-0002us-LI; Tue, 24 Mar 2026 16:38:46 +0000 Received: by outflank-mailman (input) for mailman id 1261126; Tue, 24 Mar 2026 16:38:45 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1w54mD-0002ug-Md for xen-devel@lists.xenproject.org; Tue, 24 Mar 2026 16:38:45 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1w54mC-001q6T-UB for xen-devel@lists.xenproject.org; Tue, 24 Mar 2026 17:38:44 +0100 Received: from [10.42.69.3] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 69c2bdf6-2eae-0a2a0a5409dd-0a2a4503ba16-48 for ; Tue, 24 Mar 2026 17:38:44 +0100 Received: from [209.85.128.53] (helo=mail-wm1-f53.google.com) by tlsNG-33051d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.55.2) (envelope-from ) id 69c2be14-1947-0a2a45030019-d1558035bd03-3 for ; Tue, 24 Mar 2026 17:38:44 +0100 Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-486ff201041so36507355e9.1 for ; Tue, 24 Mar 2026 09:38:44 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48716549160sm905435e9.3.2026.03.24.09.38.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 Mar 2026 09:38:44 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:In-Reply-To:Autocrypt:Content-Language:References:Cc:To:From:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1774370324; x=1774975124; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=PYk9vEEfGRYDleF6fCoNLGed2AL29CgD3kCqdLh6Eqg=; b=Ka25E67T5QSaxqUuPbGBjeu4LGthhVk0aCnO6VyrZLOYoPKDSudDTzOzMpbYGz24mu zhaNupCEpVzx9MSzzNxTs3EPW7YsgnGPRqRglJ3Xu+fyp3bK/jmhdi5el98Erd8CcWFv YOB6nVxrMoyKAG2pofO8gTJtAD+u0Tveul9ovVf5mXd9yAMV4djGi2TYNCMYh8UfNXNu MiLAWPO3KrYGkAHWA39SmkzqiItWumFW7aBilLcF+8rhja8gRmjWBBC2jsWkr7UsnwgO ZJ/Axj5FsBmjvNmqjuHeNPR3VQp1zZDJKt2OTzc6uMf2wV2FDvjjAmhTCIz6XXI2zAVw wEZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774370324; x=1774975124; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=PYk9vEEfGRYDleF6fCoNLGed2AL29CgD3kCqdLh6Eqg=; b=TuD7FuHXKttKC7b+pt5B8+M1976NM87J7cjwgVFXmc6FdiFb/pktDzf+siwm6WOcqe Z4x+pBXhghljn92+OwyhpfErWsAPtt9YFJiYwBNxNfSHDYnn3zrfLk0PmjT7dwrKmR7u EWjpPOyx+3sxppO1jstRY1IdVEmNVFq5oRq7akBornwLBT8hGnGDtvY+66VK8VFcLN5I oKtk0Ml8pNCxx1mUzn26Qf4QviQJO3QYWnXJ7lFpjSCUvAvqhgku2zFCUd2C7hCJAVQF 0n/P3EKY4N3as6LAfhRb/LuDTONhq0l70JcJxxZGM1m4xiqFOAon6C36pk9t3R8JpxzP IFfw== X-Gm-Message-State: AOJu0YwUHVhwMWr6s/u66ULOsWFjdHQoikKTl96ax5CQAOBjHYD7l0Np fh5gSG5zbNPgP7vNmrAGzT68Trc/71B/AlPAD9PVzwszmM95SulUo3VsvFQgZbPAetZ8JVjeNgk tkzMOGw== X-Gm-Gg: ATEYQzzHM3/OKU41WtfPAfCnz+nhCX1TpPLuMGI6iAEkrXzvPsTnO4l2wHZO241hcHB aRllZ/NKwTQPq2qf0yHK8iDyl2yp8XQzIeqKjFtnuIvcZ5gYzAh1B5hGhLbRlpN2IgFBGMBHIDl 0H2XBCKrCeH26jf35ogqn+VlI4r3h8hJTd1F17KdFTEVzhsA0hrkAhR2IQIXo24P2T5KkRkzB8D 8n+Xkf2+P7bA2nWN5ZWtfHHQESLSIRvy/N08acptKJqDuyJyRjNaAGD5aulTZp3bVPmrdlF0eED ViRu1Q1TZrhjOzZWTffpxU2+UAHBpJV0WyOqHxXas35v62fAVtIFZnmQLxT0vaQqPZReaH9ArgF YfnoCyUZwTDIg9xpT6Hb4YFH2hQvy5GPpsBW59Eq/DevRdJg+1mZx/cqV+Pc4PgPbUaGtpGIKSn SErnpWAvDndF5ylAXHLx3E1+Tivlp7/dr58XYi+eU8Qf2jUQzUHYciFpo248xdGghoFu3qVd007 z4Grh1SJeDz5DOMNXAwgDZDRQ== X-Received: by 2002:a05:600c:8886:b0:480:4a8f:2d5c with SMTP id 5b1f17b1804b1-4871606dd88mr4297395e9.29.1774370324272; Tue, 24 Mar 2026 09:38:44 -0700 (PDT) Message-ID: Date: Tue, 24 Mar 2026 17:38:42 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH 4/5] ns16550: harden positional parsing From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Julien Grall , Stefano Stabellini , Anthony PERARD , Michal Orzel , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Kamil Frankowicz References: <63284ab7-8e38-4448-a789-1b9c23c4d95c@suse.com> Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <63284ab7-8e38-4448-a789-1b9c23c4d95c@suse.com> Content-Transfer-Encoding: quoted-printable X-purgate-ID: tlsNG-33051d/1774370324-4866F72C-FF9CEDF9/0/0 X-purgate-type: clean X-purgate-size: 706 X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1774370345373158500 Content-Type: text/plain; charset="utf-8" Advancing past a character without knowing whether that's the NUL char is at risk of reading beyond the buffer. Fixes: 25de1f692059 ("Allow arch-specific defaults to be specified for ns16= 550") Reported-by: Kamil Frankowicz Signed-off-by: Jan Beulich --- a/xen/drivers/char/ns16550.c +++ b/xen/drivers/char/ns16550.c @@ -1541,6 +1541,9 @@ static bool __init parse_positional(stru { uart->data_bits =3D simple_strtoul(conf, &conf, 10); =20 + if ( !*conf ) + PARSE_ERR_RET("bad DPS setting"); + uart->parity =3D parse_parity_char(*conf); =20 uart->stop_bits =3D simple_strtoul(conf + 1, &conf, 10);