From nobody Tue Mar 3 04:56:07 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1772106727; cv=none; d=zohomail.com; s=zohoarc; b=c4kkFio9a+CWLwrELOWTgXTnkNXo7nArtFgUVkMFFUhtc8QJckjzewqE+p7vQpbyxAqwbFZRiT7XzzHTLDIpZvx19wjKngxBt/Q5qyPxKqunaclQMkprSXmRS01hTBP7AOROnk9qLEq+Zy1PfKGL93/qfot2tTrQP31xiiMxKIQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1772106727; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=5K7jSa5ElCzdAIrKGdTJ7REReHRZ8bMvKPzPSDPHE2w=; b=dI2VjGJNGVpJRUwcu4Eggm5S7TaQkaH4tw3hNsksgKuqWGc7KFoMwN90Obzqh+z7k22EJY47y74kUjvc/RQr71kMShGwv/smnKBwIAWYZFllkMTbuPQqoy0zwNC43So2VeGWSsUrNJNqV4QYG8KNVobT15QdpzeRXttghdni7UU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1772106727052915.2371640541709; Thu, 26 Feb 2026 03:52:07 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.1241465.1542574 (Exim 4.92) (envelope-from ) id 1vvZuA-0000JG-3B; Thu, 26 Feb 2026 11:51:42 +0000 Received: by outflank-mailman (output) from mailman id 1241465.1542574; Thu, 26 Feb 2026 11:51:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vvZu9-0000IO-Tz; Thu, 26 Feb 2026 11:51:41 +0000 Received: by outflank-mailman (input) for mailman id 1241465; Thu, 26 Feb 2026 11:51:40 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vvZu8-0006EH-Lp for xen-devel@lists.xenproject.org; Thu, 26 Feb 2026 11:51:40 +0000 Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [2a00:1450:4864:20::333]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 81f1a138-1309-11f1-9ccf-f158ae23cfc8; Thu, 26 Feb 2026 12:51:38 +0100 (CET) Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-48372efa020so6535065e9.2 for ; Thu, 26 Feb 2026 03:51:38 -0800 (PST) Received: from fedora (user-109-243-67-101.play-internet.pl. [109.243.67.101]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-483bd68826asm220079295e9.0.2026.02.26.03.51.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Feb 2026 03:51:37 -0800 (PST) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 81f1a138-1309-11f1-9ccf-f158ae23cfc8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772106697; x=1772711497; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=5K7jSa5ElCzdAIrKGdTJ7REReHRZ8bMvKPzPSDPHE2w=; b=BlritWwLH0Oix637nUS19EKZuNhonSpPTeOta/484dHWjyvEiiq+Qf/j6/IbkArtC0 qqoaDup3MvTLVsdwiJ4BooHpmY2Wuka/mP82M9JpGA6GJx4W0ftWRp1w4fu1nTM2LvaV qTnQDmvngw+XErcc+MTCsUW5umZc8OYQIRxmMAtU3iwBSRXnQB6+N4LJHfKZ38zmQWQX LQWQS52kDayk4NYpBxo62cMbv0XLdt1x4b/w75D0KJyOo8HprNMDBbj1C5ARdo8cnLmb oc1BezGzHq+FkD4EyDvhV5jzTigrl9RLktRB1DySwF4eytuGklBf4MXCD69b/jHmzDIJ f6+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772106697; x=1772711497; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=5K7jSa5ElCzdAIrKGdTJ7REReHRZ8bMvKPzPSDPHE2w=; b=KSZFnEZTV1YmiDeIgbnqYfX/w5UmJq5dvFJYBcw0SBa6jwoJb70mtpOLhkU4O/K2u8 HPqcPqOJOGnKmtJzhpDIP+TQnhSfbpwFdChT2MED+UnZYUjcTzdnP79/7q+5vwgNlNXm /QF2Xv9WblOuqSdYueHULQNwAu4eqDK91dpMHl6QzCmnFCtEjIxC71nhfJmNh35VR4cL zi7F33v1w4657cxamGJwKg+Vwaz1HOEbIemLBYtFqbE6clOfu0Tf+Ot/O0HT/qXG/Dwn /EZLDXQLiKUsAtRAZKxWV7QqHYfh8qSIeQAoUYWwXBybODFLzB39jITn7iqtiSx2OA7H ecBg== X-Gm-Message-State: AOJu0YxobSNn557v7NuGNHlucey6AfSPBgyaAjzordWpD9F2+FpzZTBO zjPsOB2HeV8/wADvtxiIhiMu/Tdh6L/qL5OQZiYs4sDFb9fC5ohxd+S14rf+hw== X-Gm-Gg: ATEYQzx2AjoDfn5ubeXoXz0k/fczU8EqJLTpvl8aIoXJEPiL4SNC1S2pMmqxmMymfWu gGWnmp7H/6S7tEjDE2Wst8tQnSwHBiLmF5FoZKpWjZaV3kXGEDC5RqYrIpvYfkl9gJemw/zmr+6 TnME6rvfmoVcPW8MXW9AjiQp+sV1Um2mN8YIoGPYo3bquObz9JasZftvj9IecFmPPTdQYql4V8r 2jZs3vH0FWapO5dNy9xRW7uuYDp/Yi1TMc7G5W4dX88ZmVDcF4KnnN5WwOidovWLejH6bB0DMvH 6HOPcRSFJFHrrwUvD3t9gCFjwTg9ljR/4g/gaW2aUwtXl1NL0W787EDX0n+JDjlKn4eJnyO3KJa TaPerCxD50sttMe1iKJ0cQrqio4XZwpiXx+K5/3CkVLJu00CFXNWKtxJJ/4ByS4IJH9oYTsbhEI TI+fOCJ6enp/Br0HZzrQQoRQcOR67Vp0ybBs/OYH1px/uu8leQ616RoR2dOqJMqYvoKg== X-Received: by 2002:a05:600c:548a:b0:483:b2a8:33ff with SMTP id 5b1f17b1804b1-483c216bdefmr63756335e9.4.1772106697348; Thu, 26 Feb 2026 03:51:37 -0800 (PST) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Romain Caritey , Oleksii Kurochko , Alistair Francis , Connor Davis , Andrew Cooper , Anthony PERARD , Michal Orzel , Jan Beulich , Julien Grall , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Stefano Stabellini Subject: [PATCH v6 10/14] xen/riscv: introduce sbi_set_timer() Date: Thu, 26 Feb 2026 12:51:10 +0100 Message-ID: X-Mailer: git-send-email 2.53.0 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1772106729209158500 Introduce a function pointer for sbi_set_timer(), since different OpenSBI versions may implement the TIME extension with different extension IDs and/or function IDs. If the TIME extension is not available, fall back to the legacy timer mechanism. This is useful when Xen runs as a guest under another Xen, because the TIME extension is not currently virtualised and therefore will not appear as available. Despite of the fact that sbi_set_timer_v01 is introduced and used as fall back, SBI v0.1 still isn't fully supported (with the current SBI calls usage, sbi_rfence_v01 should be introduced too), so panic() in sbi_init() isn't removed. The sbi_set_timer() pointer will be used by reprogram_timer() to program Xen=E2=80=99s physical timer as without SSTC extension there is no any other option except SBI call to do that as only M-timer is available for us. Use dprintk() for all the cases to print that a speicifc SBI extension is available as it isn't really necessary in case of release builds. Signed-off-by: Oleksii Kurochko Acked-by: Jan Beulich --- Changes in v6: - Nothing changed. Only rebase. --- Changes in v5: - Add inclusion of to to deal with the compila= tion issue: ./arch/riscv/include/asm/sbi.h:156:30: error: expected ')' before 'sbi_= set_timer' 156 | extern int (* __ro_after_init sbi_set_timer)(uint64_t stime_value= ); - Rephrase the first sentence of the comment above declaration of sbi_set_t= imer pointer to function. --- Changes in v4: - Add "stime_value is in absolute time" to the comment above declaration of sbi_set_timer() function pointer. - Add Acked-by: Jan Beulich . --- Changes in v3: - Init sbi_set_timer with sbi_set_timer_v01 as fallback value. - Sort SBI IDs in the same way as SBI EXT IDs are declared. - Add __ro_after_init for sbi_set_timer variable. - use dprintk instead of printk to print information if SBI ext is availab= le. --- Changes in v2: - Move up defintion of SBI_EXT_TIME_SET_TIMER and use the same padding as defintions around it. - Add an extra comment about stime_value granuality above declaration of sbi_set_timer function pointer. - Refactor implemetation of sbi_set_timer_v02(). - Provide fallback for sbi_set_timer_v01(). - Update the commit message. --- xen/arch/riscv/include/asm/sbi.h | 22 ++++++++++++++++++ xen/arch/riscv/sbi.c | 40 +++++++++++++++++++++++++++++++- 2 files changed, 61 insertions(+), 1 deletion(-) diff --git a/xen/arch/riscv/include/asm/sbi.h b/xen/arch/riscv/include/asm/= sbi.h index 79f7ff5c5501..ed7af200288f 100644 --- a/xen/arch/riscv/include/asm/sbi.h +++ b/xen/arch/riscv/include/asm/sbi.h @@ -13,6 +13,7 @@ #define ASM__RISCV__SBI_H =20 #include +#include =20 /* SBI-defined implementation ID */ #define SBI_XEN_IMPID 7 @@ -29,6 +30,7 @@ =20 #define SBI_EXT_BASE 0x10 #define SBI_EXT_RFENCE 0x52464E43 +#define SBI_EXT_TIME 0x54494D45 =20 /* SBI function IDs for BASE extension */ #define SBI_EXT_BASE_GET_SPEC_VERSION 0x0 @@ -48,6 +50,9 @@ #define SBI_EXT_RFENCE_REMOTE_HFENCE_VVMA 0x5 #define SBI_EXT_RFENCE_REMOTE_HFENCE_VVMA_ASID 0x6 =20 +/* SBI function IDs for TIME extension */ +#define SBI_EXT_TIME_SET_TIMER 0x0 + #define SBI_SPEC_VERSION_MAJOR_MASK 0x7f000000 #define SBI_SPEC_VERSION_MINOR_MASK 0x00ffffff =20 @@ -134,6 +139,23 @@ int sbi_remote_hfence_gvma(const cpumask_t *cpu_mask, = vaddr_t start, int sbi_remote_hfence_gvma_vmid(const cpumask_t *cpu_mask, vaddr_t start, size_t size, unsigned long vmid); =20 +/* + * Programs the clock for next event at (or after) stime_value. stime_valu= e is + * in absolute time. This function must clear the pending timer interrupt = bit + * as well. + * + * If the supervisor wishes to clear the timer interrupt without schedulin= g the + * next timer event, it can either request a timer interrupt infinitely far + * into the future (i.e., (uint64_t)-1), or it can instead mask the timer + * interrupt by clearing sie.STIE CSR bit. + * + * The stime_value parameter represents absolute time measured in ticks. + * + * This SBI call returns 0 upon success or an implementation specific nega= tive + * error code. + */ +extern int (* __ro_after_init sbi_set_timer)(uint64_t stime_value); + /* * Initialize SBI library * diff --git a/xen/arch/riscv/sbi.c b/xen/arch/riscv/sbi.c index 425dce44c679..b4a7ae6940c1 100644 --- a/xen/arch/riscv/sbi.c +++ b/xen/arch/riscv/sbi.c @@ -249,6 +249,38 @@ static int (* __ro_after_init sbi_rfence)(unsigned lon= g fid, unsigned long arg4, unsigned long arg5); =20 +static int cf_check sbi_set_timer_v02(uint64_t stime_value) +{ + struct sbiret ret; + + ret =3D sbi_ecall(SBI_EXT_TIME, SBI_EXT_TIME_SET_TIMER, stime_value, +#ifdef CONFIG_RISCV_32 + stime_value >> 32, +#else + 0, +#endif + 0, 0, 0, 0); + + return sbi_err_map_xen_errno(ret.error); +} + +static int cf_check sbi_set_timer_v01(uint64_t stime_value) +{ + struct sbiret ret; + + ret =3D sbi_ecall(SBI_EXT_0_1_SET_TIMER, 0, stime_value, +#ifdef CONFIG_RISCV_32 + stime_value >> 32, +#else + 0, +#endif + 0, 0, 0, 0); + + return sbi_err_map_xen_errno(ret.error); +} + +int (* __ro_after_init sbi_set_timer)(uint64_t stime_value) =3D sbi_set_ti= mer_v01; + int sbi_remote_sfence_vma(const cpumask_t *cpu_mask, vaddr_t start, size_t size) { @@ -324,7 +356,13 @@ int __init sbi_init(void) if ( sbi_probe_extension(SBI_EXT_RFENCE) > 0 ) { sbi_rfence =3D sbi_rfence_v02; - printk("SBI v0.2 RFENCE extension detected\n"); + dprintk(XENLOG_INFO, "SBI v0.2 RFENCE extension detected\n"); + } + + if ( sbi_probe_extension(SBI_EXT_TIME) > 0 ) + { + sbi_set_timer =3D sbi_set_timer_v02; + dprintk(XENLOG_INFO, "SBI v0.2 TIME extension detected\n"); } } else --=20 2.53.0