From nobody Mon Mar 23 19:53:34 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1773691938809348.3715588234744; Mon, 16 Mar 2026 13:12:18 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1255757.1550589 (Exim 4.92) (envelope-from ) id 1w2EI8-0003zD-3s; Mon, 16 Mar 2026 20:11:56 +0000 Received: by outflank-mailman (output) from mailman id 1255757.1550589; Mon, 16 Mar 2026 20:11:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1w2EI8-0003z6-1A; Mon, 16 Mar 2026 20:11:56 +0000 Received: by outflank-mailman (input) for mailman id 1255757; Mon, 16 Mar 2026 20:11:54 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1w2EI6-0003yx-QK for xen-devel@lists.xenproject.org; Mon, 16 Mar 2026 20:11:54 +0000 Received: from mailhost.m5p.com (mailhost.m5p.com [74.104.188.4]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5ed099f8-2174-11f1-9ccf-f158ae23cfc8; Mon, 16 Mar 2026 21:11:52 +0100 (CET) Received: from m5p.com (mailhost.m5p.com [IPv6:2001:470:8ac4:0:0:0:0:f7]) by mailhost.m5p.com (8.18.1/8.17.1) with ESMTPS id 62GKBhlo095463 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Mon, 16 Mar 2026 16:11:48 -0400 (EDT) (envelope-from ehem@m5p.com) Received: (from ehem@localhost) by m5p.com (8.18.1/8.15.2/Submit) id 62GKBgnw095462; Mon, 16 Mar 2026 13:11:42 -0700 (PDT) (envelope-from ehem) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5ed099f8-2174-11f1-9ccf-f158ae23cfc8 Date: Mon, 16 Mar 2026 13:11:42 -0700 From: Elliott Mitchell To: xen-devel@lists.xenproject.org Cc: Anthony PERARD Subject: [PATCH] tools: remove setup_physical_bridge_port() function Message-ID: MIME-Version: 1.0 Content-Disposition: inline X-Spam-Status: No, score=0.4 required=10.0 tests=KHOP_HELO_FCRDNS autolearn=no autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on mattapan.m5p.com X-ZM-MESSAGEID: 1773691940362158500 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Only the setup_virtual_bridge_port() function was used. As such merge that with _setup_bridge_port() and leave that as the remaining function. Signed-off-by: Elliott Mitchell --- Since the script originates with the Xen Project, I would like to draw attention to Debian bug #1067152: https://bugs.debian.org/1067152 In different words, the issue is the vif#.# interfaces end up getting autogenerated IPv6 link-local addresses which they shouldn't have. This doesn't effect IPv6 connectivity for the front-end network devices. --- tools/hotplug/Linux/vif-bridge | 2 +- tools/hotplug/Linux/vif-openvswitch | 2 +- tools/hotplug/Linux/xen-network-common.sh | 22 ++++++---------------- 3 files changed, 8 insertions(+), 18 deletions(-) diff --git a/tools/hotplug/Linux/vif-bridge b/tools/hotplug/Linux/vif-bridge index 906047e82f..6164c7a52f 100644 --- a/tools/hotplug/Linux/vif-bridge +++ b/tools/hotplug/Linux/vif-bridge @@ -78,7 +78,7 @@ fi =20 case "$command" in add|online) - setup_virtual_bridge_port "$dev" + setup_bridge_port "$dev" set_mtu "$bridge" "$dev" "$type_if" add_to_bridge "$bridge" "$dev" ;; diff --git a/tools/hotplug/Linux/vif-openvswitch b/tools/hotplug/Linux/vif-= openvswitch index 18bfb6cefb..a8aea2acb5 100644 --- a/tools/hotplug/Linux/vif-openvswitch +++ b/tools/hotplug/Linux/vif-openvswitch @@ -88,7 +88,7 @@ add_to_openvswitch () { case "$command" in add|online) check_tools - setup_virtual_bridge_port $dev + setup_bridge_port $dev add_to_openvswitch $dev ;; =20 diff --git a/tools/hotplug/Linux/xen-network-common.sh b/tools/hotplug/Linu= x/xen-network-common.sh index 42fa704e8d..0150a4840e 100644 --- a/tools/hotplug/Linux/xen-network-common.sh +++ b/tools/hotplug/Linux/xen-network-common.sh @@ -79,32 +79,22 @@ find_dhcpd_arg_file() } =20 # configure interfaces which act as pure bridge ports: -_setup_bridge_port() { +setup_bridge_port() { local dev=3D"$1" - local virtual=3D"$2" =20 # take interface down ... ip link set dev ${dev} down =20 - if [ $virtual -ne 0 ] ; then - # Initialise a dummy MAC address. We choose the numerically - # largest non-broadcast address to prevent the address getting - # stolen by an Ethernet bridge for STP purposes. - # (FE:FF:FF:FF:FF:FF) - ip link set dev ${dev} address fe:ff:ff:ff:ff:ff || true - fi + # Initialise a dummy MAC address. We choose the numerically + # largest non-broadcast address to prevent the address getting + # stolen by an Ethernet bridge for STP purposes. + # (FE:FF:FF:FF:FF:FF) + ip link set dev ${dev} address fe:ff:ff:ff:ff:ff || true =20 # ... and configure it ip address flush dev ${dev} } =20 -setup_physical_bridge_port() { - _setup_bridge_port $1 0 -} -setup_virtual_bridge_port() { - _setup_bridge_port $1 1 -} - # Usage: create_bridge bridge create_bridge () { local bridge=3D$1 --=20 --=20 (\___(\___(\______ --=3D> 8-) EHM <=3D-- ______/)___/)___= /) \BS ( | ehem+sigmsg@m5p.com PGP 87145445 | ) / \_CS\ | _____ -O #include O- _____ | / _/ 8A19\___\_|_/58D2 7E3D DDF4 7BA6 <-PGP-> 41D1 B375 37D0 8714\_|_/___/5445