From nobody Thu Sep 19 01:45:50 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1719310508806823.6148013707408; Tue, 25 Jun 2024 03:15:08 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.747553.1155014 (Exim 4.92) (envelope-from ) id 1sM3CQ-0008OD-23; Tue, 25 Jun 2024 10:14:54 +0000 Received: by outflank-mailman (output) from mailman id 747553.1155014; Tue, 25 Jun 2024 10:14:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1sM3CP-0008O2-Uu; Tue, 25 Jun 2024 10:14:53 +0000 Received: by outflank-mailman (input) for mailman id 747553; Tue, 25 Jun 2024 10:14:52 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1sM3CO-0007Vr-Lz for xen-devel@lists.xenproject.org; Tue, 25 Jun 2024 10:14:52 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c28c9499-32db-11ef-90a3-e314d9c70b13; Tue, 25 Jun 2024 12:14:52 +0200 (CEST) Received: from delta.bugseng.com.homenet.telecomitalia.it (host-87-17-171-46.retail.telecomitalia.it [87.17.171.46]) by support.bugseng.com (Postfix) with ESMTPSA id 94A5B4EE073D; Tue, 25 Jun 2024 12:14:49 +0200 (CEST) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c28c9499-32db-11ef-90a3-e314d9c70b13 From: Alessandro Zucchelli To: xen-devel@lists.xenproject.org Cc: consulting@bugseng.com, Alessandro Zucchelli , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini Subject: [PATCH 3/3] common/softirq: address violation of MISRA C Rule 13.6 Date: Tue, 25 Jun 2024 12:14:21 +0200 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1719310509194100001 Content-Type: text/plain; charset="utf-8" In the file common/softirq macro set_bit is called with argument smp_processor_id. Once expanded this set_bit's argument is used in sizeof operations and thus 'smp_processor_id', being a macro that expands to a function call with potential side effects, generates a violation. To address this violation the value of smp_processor_id is therefore stored in a variable called 'cpu' before passing it to macro set_bit. No functional change. Signed-off-by: Alessandro Zucchelli Reviewed-by: Stefano Stabellini --- xen/common/softirq.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/xen/common/softirq.c b/xen/common/softirq.c index bee4a82009..c5f3870534 100644 --- a/xen/common/softirq.c +++ b/xen/common/softirq.c @@ -139,7 +139,8 @@ void cpu_raise_softirq_batch_finish(void) =20 void raise_softirq(unsigned int nr) { - set_bit(nr, &softirq_pending(smp_processor_id())); + unsigned int cpu =3D smp_processor_id(); + set_bit(nr, &softirq_pending(cpu)); } =20 /* --=20 2.34.1