From nobody Mon Jun 8 04:25:58 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1780408381; cv=none; d=zohomail.com; s=zohoarc; b=PMEal2GmMm0/CziwOlEJGU6ubUTfczPLQJv6Sel1kPeE1dOwacPQI1xfmYaWudEeR468qycpgSjYG4yl5C2DBRiz+A9vWP9Wrg9TKxPJKwvF4Nrj17Wief6FpWRqXYOlNAXkBxKL/S83+gHLkXNI1xeVeKS2qVEcoM8W39HRZDs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1780408381; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Tpnmn+L6WxBMBsYLWgK2xN4hOzNIW1jb44I8BXzpbs0=; b=fPFUuzfd7AuPMXPkD5DRg8kqEJ2MFEHCBUuRumO8KECiwcUlfj4HsEm+1V1rNMMDPifR1qOVMyGbRBkVlA3wl8VV2x0Tsr6AjBcomCSF7Bd3fKWmIyoSH5Nvu5vRAD2w5hqHaoaIR5kQNHAttrf3yaXTQwvNCqsWv5Ip3QdvhEc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1780408381441103.4393321080405; Tue, 2 Jun 2026 06:53:01 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1325070.1590599 (Exim 4.92) (envelope-from ) id 1wUPXx-0000On-KR; Tue, 02 Jun 2026 13:52:45 +0000 Received: by outflank-mailman (output) from mailman id 1325070.1590599; Tue, 02 Jun 2026 13:52:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wUPXx-0000Og-Gf; Tue, 02 Jun 2026 13:52:45 +0000 Received: by outflank-mailman (input) for mailman id 1325070; Tue, 02 Jun 2026 13:52:44 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wUPXw-0000NV-NP for xen-devel@lists.xenproject.org; Tue, 02 Jun 2026 13:52:44 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wUPXw-003qeU-3t for xen-devel@lists.xenproject.org; Tue, 02 Jun 2026 15:52:44 +0200 Received: from [10.42.69.2] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a1ee026-e002-0a2a0a5209dd-0a2a450298c4-28 for ; Tue, 02 Jun 2026 15:52:43 +0200 Received: from [209.85.128.46] (helo=mail-wm1-f46.google.com) by tlsNG-720697.mxtls.expurgate.net with ESMTPS (eXpurgate 4.56.1) (envelope-from ) id 6a1ee02b-af86-0a2a45020019-d155802eb526-3 for ; Tue, 02 Jun 2026 15:52:43 +0200 Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-4906869f0cbso107478555e9.1 for ; Tue, 02 Jun 2026 06:52:43 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-490b0daefbbsm116929945e9.0.2026.06.02.06.52.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 Jun 2026 06:52:42 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Autocrypt:Content-Language:Cc:To:Subject:From:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1780408363; x=1781013163; darn=lists.xenproject.org; h=content-transfer-encoding:autocrypt:content-language:cc:to:subject :from:user-agent:mime-version:date:message-id:from:to:cc:subject :date:message-id:reply-to; bh=Tpnmn+L6WxBMBsYLWgK2xN4hOzNIW1jb44I8BXzpbs0=; b=NvWgky2cWBCBr0SUSwfqjYBzRYlk6tbejTlspp+5fo62TUmS++lD754WT9TmHBxJCe dlDlNxzfnLr1C8WW8livgZaiFRU2W/KSDgLq6WV11W4eKYLv/JvGO//y1UxhDH5N3tfo UXVCCdYeeKNJpMADW1LeZRiFa81Lc/DnZ4lfqEVMZP9t6uMF3VkZ/Vq+/btJ9pXh3gjY all1VQngffZYfWStDCqbZcOj0O6RIfU4C2g9TMN+Ca5qbdxluRx6Wc/qAnmu7cu3J4Oe 82IiqnsTb/EsO0poTEA5gTmjQ7tOdcO9KHF5bpO7AGGFklQwPzC5NEZMWm3mU94dyC26 +xgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780408363; x=1781013163; h=content-transfer-encoding:autocrypt:content-language:cc:to:subject :from:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Tpnmn+L6WxBMBsYLWgK2xN4hOzNIW1jb44I8BXzpbs0=; b=LB2xnJqeK+KbBCK+HHEJIaJ/P1arEK5h8FN8fJaVNeqkBVm+VqINXHc0+/6Bx+jeky Wza6hvMjYRuhM/BgmpTfOBwvu3yjiDYiiQBaZ11GV+fNn6IpOhwEOHIYVAflbIq4E+z4 h1dQtQ/juVpoSdZkhvV+tYViBLUSNk2PsRd5gVDsEgrtecS7Z9DJ+tjFseNyalTfJySC nrPjGMvZrN47rRRJjnvOtGJ2DerlGT6A/d+9t55hykN5+yvM5qGj1g3NQnfy8J3nyLv8 ze1IV7bztGTY4REnz6EZJcjksmWayaU/JHZ8bJO61t8zjvpiV79N/myHaQ8WYFaM3p1k QBow== X-Gm-Message-State: AOJu0Yw3IqmYc8edNkODrP5qkaeIKyRF69+pazBBXH0h54QPu861bFxT DaRi+Qgj7pMsolsxzEYRuBqHCbsxOb+4vXz5NbJrypWllhCghNf+nrQLmGqC48LGqSxtZJrQDMc G6Es= X-Gm-Gg: Acq92OGZM/xY+B7PAvEwKrgBN9VYtbAgJ56FCUNVdNDjlIf3AfUWMpm296cqgvDNTmQ No1wacjpLp871heclh1aVDnmch1P0qlKt2ifK/JSRh+a+K0SiAY25NeqsZ6N2yJfv+FHz5/N/fZ +bbXrp8alnt5q8KOgb0DGpViTjyewBVm3pxUARkIrh47OOBFQ0/74RMqy4NcVzhXOPHPybB5H0P 7D0EZzMJ2jrEp+RvMtJCxTCs50R1cdWrAnum7EDf4gdun++KaJ/bvdqMKCwDwE2Z03FuVLjsczT gLOPHCgXAtDQs+Hzhsjfqcm8aKjj90Ukf647dfcgTGg1p+729n3vgrlOgDU/AEgZK512Z3KWVE4 f9vgZplCPAoy8GJY32DwQ7DRmZJPCxB+DQQxQ+GEKQB1YpUPSChnhMY5J5sO8MIBSJwt+wIat78 3lTy99beaycYAan4CoObcJHHL2OybI+Pr15qyqmQ7LGYhJALrkT/ESG2PGdtqZhavqLJZev4Wfb baAolc43OmdYwdrgKFvbor1HA== X-Received: by 2002:a05:600c:c0d1:20b0:490:688b:f10d with SMTP id 5b1f17b1804b1-490a290ec8fmr209884595e9.7.1780408363294; Tue, 02 Jun 2026 06:52:43 -0700 (PDT) Message-ID: Date: Tue, 2 Jun 2026 15:52:50 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Jan Beulich Subject: [PATCH v3] x86/PV: drop a local variable from pv_emulate_gate_op() To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Teddy Astie , Nicola Vetrini , Oleksii Kurochko Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL Content-Transfer-Encoding: quoted-printable X-purgate-ID: tlsNG-720697/1780408363-B0979161-9781395D/0/0 X-purgate-type: clean X-purgate-size: 800 X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1780408382605158500 Content-Type: text/plain; charset="utf-8" The inner "rc" shadows the function scope one, thus violating Misra C:2012 rule 5.3 ("An identifier declared in an inner scope shall not hide an identifier declared in an outer scope"). Drop the inner variable, as there's no other (later) use of the value it holds. No difference in generated code. Signed-off-by: Jan Beulich Reviewed-by: Andrew Cooper --- v3: Use alternative approach. v2: Re-base. --- unstable.orig/xen/arch/x86/pv/emul-gate-op.c 2026-06-02 15:15:17.960392= 177 +0200 +++ unstable/xen/arch/x86/pv/emul-gate-op.c 2026-06-02 15:40:58.000000000 += 0200 @@ -287,7 +287,6 @@ void pv_emulate_gate_op(struct cpu_user_ { unsigned int ss, esp, *stkp; uint32_t value; - int rc; #define push(item) do \ { \ value =3D (item); \