From nobody Mon Feb 9 10:11:57 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1617884229; cv=none; d=zohomail.com; s=zohoarc; b=mBy238oykXkxPVN7n/6suLixYJ6hklhViy9RueC3/6I5+XB/JYK8Ym4KhkGj8cUVKcwQVfloSo3zFCpakTkk9AgLlsb/NUwaWv61Ajh04+EJkOF4mEPCNS6ocWygB8PKEYpyqTA7ruHgauNe0OpEoOPZb6XG0ImU/a7pdBwe8sU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1617884229; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=eDvHAwIF6mX0AlxLLrgGKEgwtN3OOz7sw/+4M1PC1Ao=; b=TqW6l2vlp0c3DUQS+zcQTuRcYuQfNzvI+UXbCWbC8SSEvUw5aDnQNdCHZrrvQHIhqhAG7PJ/MxB50E7eLd18DA/z5vk43YSN4gmFmI4mgW/f6CLXSqd2e8DYGNGiUoMYEkAKY3vXCzOuFl7DeY+Dp2oWJiG9qXzcKZebVYDEXjE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) header.from= Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1617884229306735.9248110915617; Thu, 8 Apr 2021 05:17:09 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.107229.204965 (Exim 4.92) (envelope-from ) id 1lUTab-0003My-W3; Thu, 08 Apr 2021 12:16:49 +0000 Received: by outflank-mailman (output) from mailman id 107229.204965; Thu, 08 Apr 2021 12:16:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lUTab-0003Mr-SN; Thu, 08 Apr 2021 12:16:49 +0000 Received: by outflank-mailman (input) for mailman id 107229; Thu, 08 Apr 2021 12:16:49 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lUTab-0003Mm-2R for xen-devel@lists.xenproject.org; Thu, 08 Apr 2021 12:16:49 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id d25c10aa-527d-42d8-b670-624b41a06f87; Thu, 08 Apr 2021 12:16:48 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 3BCCDB2D3; Thu, 8 Apr 2021 12:16:47 +0000 (UTC) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d25c10aa-527d-42d8-b670-624b41a06f87 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617884207; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eDvHAwIF6mX0AlxLLrgGKEgwtN3OOz7sw/+4M1PC1Ao=; b=Jh10VdM3VM36k/09nhklM42jup0OlzVtOlN26h+O5CKp2dy9zekrqWlkFkZxhrAdMVXPE+ wtv8awxlYvw/qGHwnGaDtc+1jY3Q9k1hYsKGcYeLlClgLGHL/LdjhEWsDd1uInPxEiJvxf ScWViD8W3wCUgazRsQwS7IgsQ2lTt7g= Subject: [PATCH 01/11] x86/HVM: avoid effectively open-coding xzalloc_flex_struct() From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: Message-ID: Date: Thu, 8 Apr 2021 14:16:47 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @suse.com) Content-Type: text/plain; charset="utf-8" Drop hvm_irq_size(), which exists for just this purpose. There is a difference in generated code: xzalloc_bytes() forces SMP_CACHE_BYTES alignment. I think we not only don't need this here, but actually don't want it. Signed-off-by: Jan Beulich Acked-by: Andrew Cooper --- a/xen/arch/x86/hvm/hvm.c +++ b/xen/arch/x86/hvm/hvm.c @@ -642,7 +642,8 @@ int hvm_domain_initialise(struct domain d->arch.hvm.params =3D xzalloc_array(uint64_t, HVM_NR_PARAMS); d->arch.hvm.io_handler =3D xzalloc_array(struct hvm_io_handler, NR_IO_HANDLERS); - d->arch.hvm.irq =3D xzalloc_bytes(hvm_irq_size(nr_gsis)); + d->arch.hvm.irq =3D xzalloc_flex_struct(struct hvm_irq, + gsi_assert_count, nr_gsis); =20 rc =3D -ENOMEM; if ( !d->arch.hvm.pl_time || !d->arch.hvm.irq || --- a/xen/include/asm-x86/hvm/irq.h +++ b/xen/include/asm-x86/hvm/irq.h @@ -98,7 +98,6 @@ struct hvm_irq { #define hvm_pci_intx_link(dev, intx) \ (((dev) + (intx)) & 3) #define hvm_domain_irq(d) ((d)->arch.hvm.irq) -#define hvm_irq_size(cnt) offsetof(struct hvm_irq, gsi_assert_count[cnt]) =20 #define hvm_isa_irq_to_gsi(isa_irq) ((isa_irq) ? : 2) =20