From nobody Sat Feb 7 06:20:55 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1769692098; cv=none; d=zohomail.com; s=zohoarc; b=bqxd1/noJkxXq872M7PeTzNJKIu5NnOP+j6opANANRr6ubljshx2c3DmuMeq7uXQMaV3xDxhvFhpSOl2LJOe46qYy6ZsKrNlA/HmVsL5wGF/6nMZERdCNKeBASizRodl1r0k+wD5h/Fc/NOEezCB3t36Mr6MBp4S43PQJINJ0D4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1769692098; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=ft06fTllGkPgCR7qdGHfeQmVyf+2wXDHmiMWPlYjxps=; b=cueldosSJp+9RqjNl3js9L8TjlyKog86TRBBSjJVBzaWPusKvEKJ44kYl3DllxV2OdNb3+u0s/f8Qi2mlZCgdLAzI0jYJN238w5JJgmEVpa0shCf4VxuioxZJFMswqqZkbscDKK8w7Swg1bKMV9lOS4FiU8foqYfLwix8Qw2gw8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 17696920987231.860389628719986; Thu, 29 Jan 2026 05:08:18 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.1216418.1526370 (Exim 4.92) (envelope-from ) id 1vlRkk-00038v-4N; Thu, 29 Jan 2026 13:08:06 +0000 Received: by outflank-mailman (output) from mailman id 1216418.1526370; Thu, 29 Jan 2026 13:08:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vlRkk-00038o-1l; Thu, 29 Jan 2026 13:08:06 +0000 Received: by outflank-mailman (input) for mailman id 1216418; Thu, 29 Jan 2026 13:08:04 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vlRki-00038i-7g for xen-devel@lists.xenproject.org; Thu, 29 Jan 2026 13:08:04 +0000 Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [2a00:1450:4864:20::334]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8a81f3b4-fd13-11f0-9ccf-f158ae23cfc8; Thu, 29 Jan 2026 14:08:02 +0100 (CET) Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-48068ed1eccso9000395e9.2 for ; Thu, 29 Jan 2026 05:08:02 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-481a5d6e186sm3722095e9.9.2026.01.29.05.08.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Jan 2026 05:08:01 -0800 (PST) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8a81f3b4-fd13-11f0-9ccf-f158ae23cfc8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1769692081; x=1770296881; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=ft06fTllGkPgCR7qdGHfeQmVyf+2wXDHmiMWPlYjxps=; b=E8h1b8AhdwNeBSRG7J3UT9shsu/GrVn266wo4jYPeWgqQXpZyoA1iv2xq/nGNuC9Bc K86HnV0xVs7MOz6XIXsVhxD4AUqH87ATB0GLVUtUm74qKc7w06BM/yeeeRsdT+zCO3eB e+1V6n9TUcMiqHM5+Km2jK3F8UHnUkQ1MWccsXpxTYi3+h8LjwP+lT1XNqan7M13SM53 jFrFNKDHWdKjQb7oO7yt7E58xuIAShWSBHcbFdHF8GM3PI0oyGVy8PoOMTSnsu7L6pyI GdyNgNi2toREXeZiiZQCWw03CNV0qH+H+cRsOM9qerWifA1l31xpscV32ODqb7NM/lLZ 6dcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769692081; x=1770296881; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ft06fTllGkPgCR7qdGHfeQmVyf+2wXDHmiMWPlYjxps=; b=K3yylhTkVTEEx+1XZhfedD+YDnPWpbvYzBhQFnbfYVLbHpaOr1qQDvrLmmUvJl+fqV 2XHJnqbi+rAEs6raHZAgPdq1Dr22zu8pgls7jah2o6oRJ/nZhMRhvdufidCcQkt6EGZp heH2bYAFZMK0lfWfRZXraFg2VrgWBL6mTtU/827UIXmSsvCI5bObPRRa9PhDY4OC96RP adPnSBDQ/YPFnsSBIkczgS3qUxNyn12HYSWWToCxBDEBEMf+B7OaIFMwG3iv9d8KF/XC 2bauGoZ0XXcpgKdRnd/hEmejy+WJVePrw7r9EkAY6gRKwO+PCVIDGW0Bw9mOMdsJYQHg +ESA== X-Gm-Message-State: AOJu0YzIifHTOA/96NoIX+WIsgijjl2Te+8jtbBN3jSQZ//YDvuyQ/cs 66KonbNMWBV9wQLxSus5Cze9ilfqAmnBQyIlk4WM5dHsigFEHMVhZNzAz9CDhnOpmf0odm9KqqL KIDE= X-Gm-Gg: AZuq6aKZ/I49eY8Ynf3YJCDzD27zXccS/7AykvRzDmhtqFC7zeqTTl/pUfLkAa6g1mB FSZOHLsw1KqWK3TtbFLl44T8b7f2ZSfZi4K6JxfO+jx/cUgGAsDq9+D1ibrasF7HktJ8sIdwxc7 1pjR5PpkjLzURSSfOj2aLUfoJQm84s5BZgmWPPEFUHOiHMcjE1dgOY6IPALlbJ/xfL4E586KdoK hT+WUhL9WL6pWfkk8sZVGHl8z0zQhMdveftChMi1cqeTA7+7aB2oqHWBij+KWFzxWqbJCkHkV+M X4Qet3XbRGo0zQjKHRolvFQlCZSrWYlmRWpPYlLbYJVPVUR8nrRPY45d51/TVkQmYVUYV4u0qk3 ydjmeWZAQl508G2eK9R8c/1OLA2xDprXdUcJ2+OMqUq0K6bEnPQkpsDx/yfkA4g6rHt9Q3FEHmg pXjmYOh6RWaHS9kyagGIt7F1QSDUkdyseI0S5ofTbKVfn7eq+74S2dJoV/Gc5SXXpdLgMoSbonu ek= X-Received: by 2002:a05:600c:871a:b0:477:93f7:bbc5 with SMTP id 5b1f17b1804b1-4806c00c0aemr101803605e9.10.1769692081362; Thu, 29 Jan 2026 05:08:01 -0800 (PST) Message-ID: Date: Thu, 29 Jan 2026 14:07:58 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH v3 1/6] PCI: handle PCI->PCIe bridges as well in free_pdev() From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Julien Grall , Stefano Stabellini , Anthony PERARD , Michal Orzel , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Stewart Hildebrand References: Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1769692101822154100 Content-Type: text/plain; charset="utf-8" Don't know how I managed to overlook the freeing side when adding the case to alloc_pdev(). Fixes: cd2b9f0b1986 ("PCI: handle PCI->PCIe bridges as well in alloc_pdev()= ") Signed-off-by: Jan Beulich Acked-by: Roger Pau Monn=C3=A9 --- v3: New. --- Noticed due to the original patch still applying cleanly, just with an offset of a few dozen lines. --- a/xen/drivers/passthrough/pci.c +++ b/xen/drivers/passthrough/pci.c @@ -436,6 +436,7 @@ static void free_pdev(struct pci_seg *ps unsigned long flags; =20 case DEV_TYPE_PCIe2PCI_BRIDGE: + case DEV_TYPE_PCI2PCIe_BRIDGE: case DEV_TYPE_LEGACY_PCI_BRIDGE: sec_bus =3D pci_conf_read8(pdev->sbdf, PCI_SECONDARY_BUS); sub_bus =3D pci_conf_read8(pdev->sbdf, PCI_SUBORDINATE_BUS); From nobody Sat Feb 7 06:20:55 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1769692129; cv=none; d=zohomail.com; s=zohoarc; b=VrrVSUw+K9N001jhNdy8vyfam4V8l8cRS8JKKBkt7of0CwMS6XhR0wxzzfs07HX+QEn25Q4GVH8YNWlAVow+OV1GdgV47/xxKROKJOWWY2X/K7em+5NRBG3jOGqwJ3TyJz/jOJQLNbOyT3UpwvjnXDjPwPJoObUoTOpXZp0bprU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1769692129; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=L+psAJ7UCo75ato/kJWZ5qYPGZM3zv9DbaC1Tdx5QNA=; b=W0NjfH7LMSftmetyslHCqrTiUCq223iqrVhl5wqf97Cq05BWm0uJjnL7XP18yC1MQP8f01FeWrf7YQK95PrBxYnQW88AdPJtIbC+cS4lqVZkzhnq7vSEFxZYmjnkDRg9pLJO7ZBggDWClPWNJ2FXcz0dyVzRCXfFS5MbRiMW0SU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1769692129076485.49035678809423; Thu, 29 Jan 2026 05:08:49 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.1216428.1526381 (Exim 4.92) (envelope-from ) id 1vlRlB-0003Xa-Bg; Thu, 29 Jan 2026 13:08:33 +0000 Received: by outflank-mailman (output) from mailman id 1216428.1526381; Thu, 29 Jan 2026 13:08:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vlRlB-0003XT-93; Thu, 29 Jan 2026 13:08:33 +0000 Received: by outflank-mailman (input) for mailman id 1216428; Thu, 29 Jan 2026 13:08:32 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vlRlA-0003Nf-91 for xen-devel@lists.xenproject.org; Thu, 29 Jan 2026 13:08:32 +0000 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [2a00:1450:4864:20::442]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9bdfc517-fd13-11f0-b160-2bf370ae4941; Thu, 29 Jan 2026 14:08:31 +0100 (CET) Received: by mail-wr1-x442.google.com with SMTP id ffacd0b85a97d-42fb2314eb0so866782f8f.2 for ; Thu, 29 Jan 2026 05:08:31 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-435e1354205sm14915758f8f.41.2026.01.29.05.08.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Jan 2026 05:08:30 -0800 (PST) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9bdfc517-fd13-11f0-b160-2bf370ae4941 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1769692111; x=1770296911; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=L+psAJ7UCo75ato/kJWZ5qYPGZM3zv9DbaC1Tdx5QNA=; b=V0jsGFMnuwZkB7sn5El70nZs43+R9TQuk0iaBLOWnWB/aE7f38HoR5c+zfjRhahsE/ CNAozeGQaivKCN032ATAZbbrFbufe8vi+zt+UDnDcqz4z1Sf5IjSe2YFAvEG+tInMRx6 lgtHfBy1OSaS4IjWAxpbRxxzaOYAmqC6uceuAZgGz32VkbXsnV/hM3sXicrzcxkG8zn1 +SIVzVjRLJC08B5kNisc6gNjhnrvh8utPHGHs2YOgEUPJH3VoynVtuz3cZdFiv+RNKnt gF9KY4MbG7hDvMi/4fTZSYD2fFf9XhpHHi7fujltXA7JF+QfxYAJxMNYocHOf1hVZNNR 3JPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769692111; x=1770296911; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=L+psAJ7UCo75ato/kJWZ5qYPGZM3zv9DbaC1Tdx5QNA=; b=Z3DvvryfzFi1I3X02nRb++zTOxHHWKcDPcYb0GcPdstEqSO2orP0Lk43+/gXejzX8r fx0McabrtgsQ4LiPS62WBWMFwZzNAMP2TEpDFRv2iA0bU9n2saOJNUL62CbXIHMY25c4 CMZK+RrpU9BRgjVZROCiCqBVkqzTv4MUQQpQJIWGUHHXjOg33Cf2yvaBuGRh8ZC8Tqyn eoAn/9zYRYhnX87zANlljsL5N7rQYbiR452muydfpdZLu350QDGqIe/AO/Jnti2QsIcl kGSsH8AoS76EBwbeilnbim92Dd403gNQtLQKvpKdvyXGS+Ae1+hkZZINmxx/bUpmC6Pg bkhQ== X-Gm-Message-State: AOJu0YztukGSP8Ziya12Ka01znc4dIeeXg/Qvd9jDiOKbNQu+S4P1zzr i9sfB+s+8bIalL9iyOTSShCATUuHAC4pkl619XZcC9FdQLV2PzgzjHMhjpIadu7ZRPu3Tf4Bzyj 7Ii4nkw== X-Gm-Gg: AZuq6aJZkR+8rFukM/CqyZpOXGRF8F+AdxBsrqzs1HTw7DSmlg9R5xmFqr0sWfMyA6W ROCf5MRA3boahCjqAe32y2PvhLNU1J3zvNt/Z51TyfCBTMlYz+bLuFxMypuE6dllIe+AB0oHnF7 s+LFM1Dhru9ORIE3rq0IVGv0nSG1PafcQ66j8cUyBSvBF7Rm4+lhHRW+djH1ciNsAt4mBgloamO iwD5dEvSRFNyANeYDnBKIg3T6s/iKeJ+q9RWfBOl0FS6sWTvxGZzXaZOunrcbswG1VQ3EsT3MSO K6JS+7wVu1+suTSTBtdGcgM3rLvSceblq/jUiSlTFcYSw7JJGNPK1H1ZBOrSHBxZeqck+3/lF10 e1zA/lbW06lfwVvnI6Sbe6Dq5vnMl1jq5A9e7WzBpkckUVN0w6U+zarWxrtX8TyFaK0u0E9hgT3 LQLGdSExDSnM1uiK2ZO8PtwyJ/OuQV8jh3TUrfGrW3k2oDkRwrILZmllHVGTaMbMATx773swn0A 9Y= X-Received: by 2002:a05:6000:1786:b0:433:42d1:f71f with SMTP id ffacd0b85a97d-435dd1c1d59mr13079823f8f.38.1769692110530; Thu, 29 Jan 2026 05:08:30 -0800 (PST) Message-ID: <99d45a27-ce67-4f10-9883-dba96f055285@suse.com> Date: Thu, 29 Jan 2026 14:08:27 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH v3 2/6] PCI: determine whether a device has extended config space From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Julien Grall , Stefano Stabellini , Anthony PERARD , Michal Orzel , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Stewart Hildebrand References: Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1769692130772158500 Legacy PCI devices don't have any extended config space. Reading any part thereof may return all ones or other arbitrary data, e.g. in some cases base config space contents repeatedly. Logic follows Linux 6.19-rc's pci_cfg_space_size(), albeit leveraging our determination of device type; in particular some comments are taken verbatim from there. Like with Linux'es CONFIG_PCI_QUIRKS, only the alias detection logic is covered by the new "pci=3Dno-quirks". The singular access at PCI_CFG_SPACE_SIZE is left unconditional. Signed-off-by: Jan Beulich Acked-by: Roger Pau Monn=C3=A9 --- The warning near the bottom of pci_check_extcfg() may be issued multiple times for a single device now. Should we try to avoid that? Note that no vPCI adjustments are done here, but they're going to be needed: Whatever requires extended capabilities will need re- evaluating / newly establishing / tearing down in case an invocation of PHYSDEVOP_pci_mmcfg_reserved alters global state. --- v3: Add command line (sub-)option. v2: Major re-work to also check upon PHYSDEVOP_pci_mmcfg_reserved invocation. --- a/docs/misc/xen-command-line.pandoc +++ b/docs/misc/xen-command-line.pandoc @@ -2009,12 +2009,21 @@ Only effective if CONFIG_PARTIAL_EMULATI behavior.** =20 ### pci - =3D List of [ serr=3D, perr=3D ] + =3D List of [ serr=3D, perr=3D, quirks=3D ] + +* `serr` and `perr` =20 Default: Signaling left as set by firmware. =20 -Override the firmware settings, and explicitly enable or disable the -signalling of PCI System and Parity errors. + Override the firmware settings, and explicitly enable or disable the + signalling of PCI System and Parity errors. + +* `quirks` + + Default: `on` + + In its negative form, allows to suppress certain quirk workarounds, in c= ase + they cause issues. =20 ### pci-phantom > `=3D[:]:,` --- a/xen/arch/x86/physdev.c +++ b/xen/arch/x86/physdev.c @@ -22,6 +22,8 @@ int physdev_map_pirq(struct domain *d, i struct msi_info *msi); int physdev_unmap_pirq(struct domain *d, int pirq); =20 +int cf_check physdev_check_pci_extcfg(struct pci_dev *pdev, void *arg); + #include "x86_64/mmconfig.h" =20 #ifndef COMPAT @@ -160,6 +162,17 @@ int physdev_unmap_pirq(struct domain *d, =20 return ret; } + +int cf_check physdev_check_pci_extcfg(struct pci_dev *pdev, void *arg) +{ + const struct physdev_pci_mmcfg_reserved *info =3D arg; + + ASSERT(pdev->seg =3D=3D info->segment); + if ( pdev->bus >=3D info->start_bus && pdev->bus <=3D info->end_bus ) + pci_check_extcfg(pdev); + + return 0; +} #endif /* COMPAT */ =20 ret_t do_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg) @@ -511,6 +524,11 @@ ret_t do_physdev_op(int cmd, XEN_GUEST_H =20 ret =3D pci_mmcfg_reserved(info.address, info.segment, info.start_bus, info.end_bus, info.flags); + + if ( !ret ) + ret =3D pci_segment_iterate(info.segment, physdev_check_pci_ex= tcfg, + &info); + if ( !ret && has_vpci(currd) && (info.flags & XEN_PCI_MMCFG_RESERV= ED) ) { /* --- a/xen/drivers/passthrough/pci.c +++ b/xen/drivers/passthrough/pci.c @@ -183,6 +183,7 @@ custom_param("pci-phantom", parse_phanto =20 static u16 __read_mostly command_mask; static u16 __read_mostly bridge_ctl_mask; +static bool __ro_after_init opt_pci_quirks =3D true; =20 static int __init cf_check parse_pci_param(const char *s) { @@ -207,6 +208,8 @@ static int __init cf_check parse_pci_par cmd_mask =3D PCI_COMMAND_PARITY; brctl_mask =3D PCI_BRIDGE_CTL_PARITY; } + else if ( (val =3D parse_boolean("quirks", s, ss)) >=3D 0 ) + opt_pci_quirks =3D val; else rc =3D -EINVAL; =20 @@ -422,6 +425,9 @@ static struct pci_dev *alloc_pdev(struct } =20 apply_quirks(pdev); + + pci_check_extcfg(pdev); + check_pdev(pdev); =20 return pdev; @@ -719,6 +725,11 @@ int pci_add_device(u16 seg, u8 bus, u8 d =20 list_add(&pdev->vf_list, &pf_pdev->vf_list); } + + if ( !pdev->ext_cfg ) + printk(XENLOG_WARNING + "%pp: VF without extended config space?\n", + &pdev->sbdf); } } =20 @@ -1042,6 +1053,79 @@ enum pdev_type pdev_type(u16 seg, u8 bus return pos ? DEV_TYPE_PCIe_ENDPOINT : DEV_TYPE_PCI; } =20 +void pci_check_extcfg(struct pci_dev *pdev) +{ + unsigned int pos; + + pdev->ext_cfg =3D false; + + switch ( pdev->type ) + { + case DEV_TYPE_PCIe_ENDPOINT: + case DEV_TYPE_PCIe_BRIDGE: + case DEV_TYPE_PCI_HOST_BRIDGE: + case DEV_TYPE_PCIe2PCI_BRIDGE: + case DEV_TYPE_PCI2PCIe_BRIDGE: + break; + + case DEV_TYPE_LEGACY_PCI_BRIDGE: + case DEV_TYPE_PCI: + pos =3D pci_find_cap_offset(pdev->sbdf, PCI_CAP_ID_PCIX); + if ( !pos || + !(pci_conf_read32(pdev->sbdf, pos + PCI_X_STATUS) & + (PCI_X_STATUS_266MHZ | PCI_X_STATUS_533MHZ)) ) + return; + break; + + default: + return; + } + + /* + * Regular PCI devices have 256 bytes, but PCI-X 2 and PCI Express dev= ices + * have 4096 bytes. Even if the device is capable, that doesn't mean = we + * can access it. Maybe we don't have a way to generate extended conf= ig + * space accesses, or the device is behind a reverse Express bridge. = So + * we try reading the dword at PCI_CFG_SPACE_SIZE which must either be= 0 + * or a valid extended capability header. + */ + if ( pci_conf_read32(pdev->sbdf, PCI_CFG_SPACE_SIZE) =3D=3D 0xffffffff= U ) + return; + + if ( opt_pci_quirks ) + { + /* + * PCI Express to PCI/PCI-X Bridge Specification, rev 1.0, 4.1.4 s= ays + * that when forwarding a type1 configuration request the bridge m= ust + * check that the extended register address field is zero. The br= idge + * is not permitted to forward the transactions and must handle it= as + * an Unsupported Request. Some bridges do not follow this rule a= nd + * simply drop the extended register bits, resulting in the standa= rd + * config space being aliased, every 256 bytes across the entire + * configuration space. Test for this condition by comparing the = first + * dword of each potential alias to the vendor/device ID. + * Known offenders: + * ASM1083/1085 PCIe-to-PCI Reversible Bridge (1b21:1080, rev 01= & 03) + * AMD/ATI SBx00 PCI to PCI Bridge (1002:4384, rev 40) + */ + unsigned int sig =3D pci_conf_read32(pdev->sbdf, PCI_VENDOR_ID); + + for ( pos =3D PCI_CFG_SPACE_SIZE; + pos < PCI_CFG_SPACE_EXP_SIZE; pos +=3D PCI_CFG_SPACE_SIZE ) + if ( pci_conf_read32(pdev->sbdf, pos) !=3D sig ) + break; + + if ( pos >=3D PCI_CFG_SPACE_EXP_SIZE ) + { + printk(XENLOG_WARNING "%pp: extended config space aliases base= one\n", + &pdev->sbdf); + return; + } + } + + pdev->ext_cfg =3D true; +} + /* * find the upstream PCIe-to-PCI/PCIX bridge or PCI legacy bridge * return 0: the device is integrated PCI device or PCIe @@ -1842,6 +1926,29 @@ int pci_iterate_devices(int (*handler)(s return pci_segments_iterate(iterate_all, &iter) ?: iter.rc; } =20 +/* Iterate a single PCI segment, with locking but without preemption. */ +int pci_segment_iterate(unsigned int segment, + int (*handler)(struct pci_dev *pdev, void *arg), + void *arg) +{ + struct pci_seg *seg =3D get_pseg(segment); + struct segment_iter iter =3D { + .handler =3D handler, + .arg =3D arg, + }; + + if ( !seg ) + return -ENODEV; + + pcidevs_lock(); + + iter.rc =3D iterate_all(seg, &iter) ?: iter.rc; + + pcidevs_unlock(); + + return iter.rc; +} + /* * Local variables: * mode: C --- a/xen/include/xen/pci.h +++ b/xen/include/xen/pci.h @@ -126,6 +126,9 @@ struct pci_dev { =20 nodeid_t node; /* NUMA node */ =20 + /* Whether the device has (accessible) extended config space. */ + bool ext_cfg; + /* Device to be quarantined, don't automatically re-assign to dom0 */ bool quarantine; =20 @@ -242,6 +245,11 @@ void pci_check_disable_device(u16 seg, u int pci_iterate_devices(int (*handler)(struct pci_dev *pdev, void *arg), void *arg); =20 +/* Iterate a single PCI segment, with locking but without preemption. */ +int pci_segment_iterate(unsigned int segment, + int (*handler)(struct pci_dev *pdev, void *arg), + void *arg); + uint8_t pci_conf_read8(pci_sbdf_t sbdf, unsigned int reg); uint16_t pci_conf_read16(pci_sbdf_t sbdf, unsigned int reg); uint32_t pci_conf_read32(pci_sbdf_t sbdf, unsigned int reg); @@ -260,6 +268,7 @@ unsigned int pci_find_next_cap_ttl(pci_s unsigned int *ttl); unsigned int pci_find_next_cap(pci_sbdf_t sbdf, unsigned int pos, unsigned int cap); +void pci_check_extcfg(struct pci_dev *pdev); unsigned int pci_find_ext_capability(const struct pci_dev *pdev, unsigned int cap); unsigned int pci_find_next_ext_capability(const struct pci_dev *pdev, From nobody Sat Feb 7 06:20:55 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1769692147; cv=none; d=zohomail.com; s=zohoarc; b=mGhqkFgByFM3hwngSSHXfuJ9PUMMbcz7XcYeD1KYcO7vhftEuZ4SDcBGtZOWV5/Q/nL51jweMGIXgSeAVSCUIw1WIMRktPLspjekSOww0Sh/75CpWt8LaU9sQfwe+ljCF4/6152BCBLkCfKDY0SvGAL77SDVxvZSdaU1S2y5QJk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1769692147; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=q7HeAt5kQvtbrf8+RdQ3a+ODredpYahprDWyAOhDj04=; b=cxbxVkXKt1ikqsL+6L7SRCj429fFK8Vaf4/rb84HvlZLpG6BQwan4eI34yT4hJt+K9qayl6dgo+B4Jn8QuASES5r1H1TTGKLsNJksdDdRX3mEdNtwOtRq8wGcmqOZHB7RV+QVBuDEqmEGFYJ66nIrhTtirNrjOaurVXSAC4Pem0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1769692147896752.9566061788314; Thu, 29 Jan 2026 05:09:07 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.1216439.1526392 (Exim 4.92) (envelope-from ) id 1vlRlZ-00043z-LY; Thu, 29 Jan 2026 13:08:57 +0000 Received: by outflank-mailman (output) from mailman id 1216439.1526392; Thu, 29 Jan 2026 13:08:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vlRlZ-00043s-GY; Thu, 29 Jan 2026 13:08:57 +0000 Received: by outflank-mailman (input) for mailman id 1216439; Thu, 29 Jan 2026 13:08:56 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vlRlY-00038i-Mo for xen-devel@lists.xenproject.org; Thu, 29 Jan 2026 13:08:56 +0000 Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [2a00:1450:4864:20::334]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id aa3ecf93-fd13-11f0-9ccf-f158ae23cfc8; Thu, 29 Jan 2026 14:08:55 +0100 (CET) Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-48039fdc8aeso5725355e9.3 for ; Thu, 29 Jan 2026 05:08:55 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48066bee687sm293711645e9.5.2026.01.29.05.08.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Jan 2026 05:08:54 -0800 (PST) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: aa3ecf93-fd13-11f0-9ccf-f158ae23cfc8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1769692135; x=1770296935; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=q7HeAt5kQvtbrf8+RdQ3a+ODredpYahprDWyAOhDj04=; b=SJRbApp+YKZyNb8nkAVx1JycJG3WI1/g0uJAIjhVi64nBX1IwFhuZquCKVwcrRZqXY mZXO4n5uBVoE5CrJtLuOp6H2nF2TySty6BPqPr2CGKIruZdXsJ5sc5/q8Cdv07LeUbyC 46o5D+jNoF9JeWdVUnoQRYcCP4Afwx5H+Y5VTq+BGaaTEQMmFYZgzRinRIP4cpzTj2SI J6D6kbfh1Z7I56eFnLQxJxsWlStTdAnAF2xKwHEPoKfDbQv1NIuaCkOGxYSguZFh2CwK D7ttA5rnT80SfUJJBz9f7maZJYGoEYkLzmjzamM95h5upaegeYvsx0FHRYM2jfoDzLL5 KZJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769692135; x=1770296935; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=q7HeAt5kQvtbrf8+RdQ3a+ODredpYahprDWyAOhDj04=; b=jSbGfjULW1flnIMxZ8o++KVRGRLviCdXeM/tj1G5il8vhbCSDyeOyhsHf19rKmQJWR VtJWShqVd9XXJUBiL9ogPa5tmtdY/NF4/awBFukNa2RRZDlfDwZ+Nshr+DYQBd6/X65t wYlUiSjb0X5Y1NRqVGcO+/c0uVirE3lXi1xB2GmcrbGHESGiEtWbboG/JEFIBSpDVzpR haoq7632lfbfe5aDXcDNi033SVqtwxO0sAHm8IW9CTfnK2XZTmaoB2cjVUVVC3wgeeT3 hl6c9QBhDbxKP9alfAppls7bdaMDUuesxN1WudjBtupf6ItQA4hYr1Ms79yZ6B3CTppl /NXw== X-Gm-Message-State: AOJu0YxlBRPcw+RWFnuc2fuAUspY7+agIaeVtahKb0Ffuc9WT4KsEB1m VpP1r5yFGngM860ojlf65g1VG6DkugelYZAx9fgBX442cOzvRQ30dQg6iCNiYQYK5joHRekizOt KP6c= X-Gm-Gg: AZuq6aLZqPJRNy/L1hQJISngsWDx2oPxo6SCmnLJr+VABrQDzxEDxMN5Pgke71+QFnQ HvmM5BfhS1/MRebiUW0lgS/131m+YfNXbCLSWgqY+S6tSHTSgOGp/BTJJUvlhLsNsWoL7ZmHUwJ I7iSMJhgSds/aGyyBxOnusb0aKxwAFniFCwLlGPN0Do+fg5SqxocAyDaWiUA6NBeddxZbg0Hmnm hsZXV+bwDPwtNbFChDP9V1iZ83N25i8azrXbayx6VAS9ykTFM+VFu3uLgJlNUQ14JW2Xo8x7op3 173Cp0wpUU/dtu6qzSemxlbA20I6SUwuTWRkc7nVPL/myJieh467DJqrfqEr/AbjM6ozdkLTnaK 65JAsXyr5pcASwAaFEUkBTGOYDn9MfdtHHrFtj1o7s1FEjTptkpeSvlZSg2TxdfvIPVkbkc/9AQ cfpzJGNdG3Xe4voZCIBfwH+fXMED38XHqRBY58uX7I48v+3ZAw2ltq9OUL0DqPKeVnTVzwPWWlc is= X-Received: by 2002:a05:600c:8b22:b0:47e:e61d:b8d2 with SMTP id 5b1f17b1804b1-48069c7c4d7mr112909255e9.27.1769692134608; Thu, 29 Jan 2026 05:08:54 -0800 (PST) Message-ID: <47c2fe41-c8c0-4c86-b3c7-8c7f96e59f1f@suse.com> Date: Thu, 29 Jan 2026 14:08:52 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH v3 3/6] PCI: don't look for ext-caps when there's no extended cfg space From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Julien Grall , Stefano Stabellini , Anthony PERARD , Michal Orzel , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Stewart Hildebrand References: Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1769692156607158500 Avoid interpreting as extended capabilities what may be about anything. In doing so, vPCI then also won't mis-interpret data from beyond base config space anymore. Fixes: 3b35911d709e ("Enable pci mmcfg and ATS for x86_64") Fixes: a845b50c12f3 ("vpci/header: Emulate extended capability list for dom= 0") Signed-off-by: Jan Beulich Reviewed-by: Stewart Hildebrand Acked-by: Roger Pau Monn=C3=A9 --- Because of the multiple prereq changes, despite the Fixes: tags I'm not quite sure whether to backport this. (I'm leaning towards "no".) --- a/xen/drivers/pci/pci.c +++ b/xen/drivers/pci/pci.c @@ -113,6 +113,12 @@ unsigned int pci_find_next_ext_capabilit int ttl =3D 480; /* 3840 bytes, minimum 8 bytes per capability */ unsigned int pos =3D max(start, PCI_CFG_SPACE_SIZE + 0U); =20 + if ( !pdev->ext_cfg ) + { + ASSERT(!start); + return 0; + } + header =3D pci_conf_read32(pdev->sbdf, pos); =20 /* From nobody Sat Feb 7 06:20:55 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1769692667; cv=none; d=zohomail.com; s=zohoarc; b=XpJ6lhGnF+Sk2TCBQNoe9dxh1rKG/zjvK1AfbX+r5H0fpKm6XaTJ/FqOEDGE0usq42KBGXVCP8OwOkueqGJfYvIgYr54PDwE4Nr5TSvbTKHWWVWzDCW4rYss2HnJMvStQyxN0gPORyjhdTSIY/Sub57gsyYPjk86dLtBnQj+Fg0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1769692667; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=K7IkmbOcHe05WP2EwO1MxrERnpyx6lY4fuz+tGdEjyM=; b=RbEo8jgm0uhpgoCNqfhL6Pg7mQZIldcll1JPUNmlkS2UuaGJOuWDFh7Y4jlE/NWCkZ8Jsd5JAr5iwQPR5USiV81tEfwhy0ii3TPGrKlIYOuR3KS/2yKJ1w1m70+ul3OsbCckKydyjKJXq912oKbCW+aYRU7yGimhV9W9gLVBi7M= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1769692667469166.18125991765964; Thu, 29 Jan 2026 05:17:47 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.1216468.1526421 (Exim 4.92) (envelope-from ) id 1vlRtu-0006gE-QT; Thu, 29 Jan 2026 13:17:34 +0000 Received: by outflank-mailman (output) from mailman id 1216468.1526421; Thu, 29 Jan 2026 13:17:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vlRtu-0006g0-MK; Thu, 29 Jan 2026 13:17:34 +0000 Received: by outflank-mailman (input) for mailman id 1216468; Thu, 29 Jan 2026 13:17:33 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vlRm8-00038i-7Y for xen-devel@lists.xenproject.org; Thu, 29 Jan 2026 13:09:32 +0000 Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [2a00:1450:4864:20::330]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id bf433566-fd13-11f0-9ccf-f158ae23cfc8; Thu, 29 Jan 2026 14:09:30 +0100 (CET) Received: by mail-wm1-x330.google.com with SMTP id 5b1f17b1804b1-4806cc07ce7so8666835e9.1 for ; Thu, 29 Jan 2026 05:09:30 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-481a5d4b5ecsm4080235e9.2.2026.01.29.05.09.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Jan 2026 05:09:29 -0800 (PST) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bf433566-fd13-11f0-9ccf-f158ae23cfc8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1769692170; x=1770296970; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=K7IkmbOcHe05WP2EwO1MxrERnpyx6lY4fuz+tGdEjyM=; b=TSM6LIAgtYMAVj+7QVxEfHVxAiYpj28bBpEMKAO3kSoz0hrp0iujaxE/Cezj7c0pUF KcAh20VPNKHRPqJzo979qIfsDJ0QTJIBQeinA/rTq/ZtpqZpmlsz5BeRekQcdHPcHXH7 4jn19Xx2UkLICeAJPizH/ilaOewx+rDjBaCgLTnhwTOACKFhrTPn7M6xD1GLNou5mUqZ mew5vM/3LDVpw4ZLBiKdL8gbX5WFXJ5ve0Ayvx8/e8KFirKudk1W0RraYBLfxnskLD+a 0BRvEindFLWXPIivVrA1JNFW7s+8vnm4Tfvh1wLoHQxzyEkjFw7IfwfCjGz7dnEJU4C1 epyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769692170; x=1770296970; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=K7IkmbOcHe05WP2EwO1MxrERnpyx6lY4fuz+tGdEjyM=; b=aO84B064M6+JOPyTZfmjndgv4WCHNgDl+ZHg28zOvU+x2nLnxwtoRe+3OIm5o3KQFu aFTAgAzbOOTPquC0iqYCmKhxw039mW7WFxUJNsNftqufBBWotlfuKZ8UEe/OiRQoVcHr Kgw9/diX0vAVKRopwTZ0N/eTmeGrGdLT9ZI2H1AFWWSarwJPWh2WrOs7g2RhLBG5woXS HBOKD0cw/4YMFrZfM2c16L2E+1KOabWMX7lp/mFVZo/bjhmCE4oHw2jLUy1hquGt+10T 13mwp++7haoWrhPOSkcK41VD7d0g3h+xuDi8H7GTSavWulDsjdOE52X9FxrnIy9mQGzQ QWww== X-Gm-Message-State: AOJu0YxYzQHVbN/yg/0eL9BNBPUckkRuQF93quX/Fjcwpk45i3O8X1GB yftTslBUneCokr/M5MJ3DYDNWfcKyaUui7YIJd4tUdqH87U6AhYUzmErKGxo7J3I+MtBV7J6++L GfAw= X-Gm-Gg: AZuq6aLAPBD1B0/bErmgIjZrfD0sMF0O3A2LmRgfYW/0ehLawD0UZngOdMJwFqywDOQ Oku3aplHOYA9Wrx4exPeoMinw8iIJk0Pp6/Im1+ZoIQpwv3PyW9wGmNF/but8EKHxCLYzoX22Y+ GzW4CNG0SQSykZFpGBlVwtD9mX1x/bObiOjRzUOx/wqmybCS4lEVqNhegsydSca0QGtGYML+q/s hJpMw98FRnQqY+bkP6gNKsHZHfDmd/sH0FKk96UmWGieyhdXkuJHdY+2TmjtRYaSbYqJM8WwCA0 g9fLU9rBB38qmwZ3VKpgas+tQbhV/YQEitZSUqVhHxW+TW6lT76NE0RlPKV7BIMHl5WTDlGYo5J NYDEZ797cqmy1mM9ZCigkD9igXS5Ow8dHf8OotjJemiki2NG6FkB+faJWDbONLB3pqF7JKewQZA 2v+UYtIxJbOMhwElm4MuflhJbNfg8A2Q+jjRoZz6L8/TFHwnty91iRObSuNC96LhF7wlz1uL5xq yo= X-Received: by 2002:a05:600c:4689:b0:477:9574:d641 with SMTP id 5b1f17b1804b1-48069c5bd29mr121741155e9.22.1769692169912; Thu, 29 Jan 2026 05:09:29 -0800 (PST) Message-ID: Date: Thu, 29 Jan 2026 14:09:27 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH v3 4/6] vPCI: really no ext-caps without extended config space From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Stewart Hildebrand References: Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1769692669382154100 Content-Type: text/plain; charset="utf-8" For DomU-s, whether to emulate accesses to the first 32 bits of extended config space as read-as-zero or read-as-all-ones depends on whether a device actually has extended config space. If it doesn't, read-as-zero isn't correct; not getting this right may confuse functions like Linux 6.19-rc's pci_ext_cfg_is_aliased(). For Dom0 this then simply allows dropping a later conditional. Fixes: a845b50c12f3 ("vpci/header: Emulate extended capability list for dom= 0") Signed-off-by: Jan Beulich Acked-by: Roger Pau Monn=C3=A9 --- v3: Move code condition to top-level function scope. Eliminate a later conditional in exchange. --- a/xen/drivers/vpci/header.c +++ b/xen/drivers/vpci/header.c @@ -829,6 +829,9 @@ static int vpci_init_ext_capability_list { unsigned int pos =3D PCI_CFG_SPACE_SIZE; =20 + if ( !pdev->ext_cfg ) + return 0; + if ( !is_hardware_domain(pdev->domain) ) /* Extended capabilities read as zero, write ignore for DomU */ return vpci_add_register(pdev->vpci, vpci_read_val, NULL, @@ -841,10 +844,9 @@ static int vpci_init_ext_capability_list =20 if ( header =3D=3D 0xffffffffU ) { - if ( pos !=3D PCI_CFG_SPACE_SIZE ) - printk(XENLOG_WARNING - "%pd %pp: broken extended cap list, offset %#x\n", - pdev->domain, &pdev->sbdf, pos); + printk(XENLOG_WARNING + "%pd %pp: broken extended cap list, offset %#x\n", + pdev->domain, &pdev->sbdf, pos); return 0; } From nobody Sat Feb 7 06:20:55 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1769692223; cv=none; d=zohomail.com; s=zohoarc; b=KjsXwvUH7IXx3mBtML5pbbjZoA72YWX5lPOJEHjRKdWZXDwWTokdNY6FCW4lGIVJim/A8HAFm9GkNOGEbSTbUTPn06il+NvMftjSZbukPol8VMqu5o6zj7stVkigcJBaZsqCyrW2YhkCTuMTY+nboe4fFr874M7WdhHcC5E/c14= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1769692223; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=gmIbWuEiblilxseM1vB5o3yWlIHmhzxF+tqb0Hhe36U=; b=CchnqLmaOZK0egqi4PlSJgOnpQcTt0j4yjMxndXGcZPveAI2OzLjz8IE8TbvqgtjwdxWJJfU1ieX3cj8DgBgrlCzvmfybDZ65ajbduK+3AKUYJPFO8ckGYZ7wm7Frsw7I61Cvued69Ntppvq1fp0RohG2X1wWn8u3ZkUDInIR2I= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1769692223543778.6568284644253; Thu, 29 Jan 2026 05:10:23 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.1216448.1526401 (Exim 4.92) (envelope-from ) id 1vlRmh-0005XT-0H; Thu, 29 Jan 2026 13:10:07 +0000 Received: by outflank-mailman (output) from mailman id 1216448.1526401; Thu, 29 Jan 2026 13:10:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vlRmg-0005XM-Tb; Thu, 29 Jan 2026 13:10:06 +0000 Received: by outflank-mailman (input) for mailman id 1216448; Thu, 29 Jan 2026 13:10:05 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vlRmf-0005LI-I4 for xen-devel@lists.xenproject.org; Thu, 29 Jan 2026 13:10:05 +0000 Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [2a00:1450:4864:20::334]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d32ce607-fd13-11f0-b160-2bf370ae4941; Thu, 29 Jan 2026 14:10:03 +0100 (CET) Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-4801ea9bafdso4120375e9.3 for ; Thu, 29 Jan 2026 05:10:04 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48066bfb59asm183476535e9.7.2026.01.29.05.10.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Jan 2026 05:10:03 -0800 (PST) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d32ce607-fd13-11f0-b160-2bf370ae4941 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1769692203; x=1770297003; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=gmIbWuEiblilxseM1vB5o3yWlIHmhzxF+tqb0Hhe36U=; b=PHDbP831jtwSknvsWqhq8keOFejbal+hFI6rKbYBaTKE2T2ZRNORE4b0oQrSwfG2yt ygtL+5fUg5DHHvLKPEwH2jXuUFtM+oSNUio/nLKUjrnjH5D+1VNV9YmcvIoP+wzRX9xE yQM6NOLeww1GLY2BCzHr0NXvkO7ypUXCCNUxos+ZnRY86ACPAa4XuHNNjE6da1gzsm2g MxbVutwHJ0u5D0/liNUdYSaxa1+2cU6Z78yfdo2nH3tc81SFE461keBJjxGUQL7oInE8 +Kqo4y0exBvyhtxycTpr3827yfkkz/HCJOB3XfspU0G/Tj4Ek/hbZ3/YpyIKH7PvW6Qf P6IQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769692203; x=1770297003; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=gmIbWuEiblilxseM1vB5o3yWlIHmhzxF+tqb0Hhe36U=; b=tU1EA+QY0Gi+kW9wB22WBfBwBXZJJ7afEnpUbv1HLOWe1gIN7Q2HKfivtnXABw88Qg A04VS0UGVIlZ85U0oeA0joVsLcjYpnED02QETS1fpzxz6KeQhzG1PuUUEJEF1MX+Fw9M z4PXQbqPbjrVMkCdU93GC2vCKZQx/yrgiSKBqnvaVHGZQ8lhdPgjYKezzTo/rJE5BLfP Xbr8rnZJeqAndUoNDGHshPKhzGb92yfLOVH0EKyB9wQpOK6DIW6E6XBCkG8GR6Uq4sew vF+tHD+aNaOZBYZl/WvKNRuYBifhhgunPtLAsJ8KfmkUIpXq7kSq9vd4LaH3kb0fSjad yVzw== X-Gm-Message-State: AOJu0YzfwSyUMsa7hKyOSPLjBxBPLoUzjoRBdEXYDHDlMgtX4pMrp4i0 5+Gh22SOLE93NHl42y1GKcJHHy6nXbfIWdGkAnvk9hAybjRK7DWt5IK27t5WcW+ZSWbFHA7Zin7 S7ls= X-Gm-Gg: AZuq6aJ+upLtuEM/X85C1ZtKSTCDkXSlRIrficNRCuKmdWCUow5V1/MqWL+uDiwZj/h oF1zTUf86YjD9ymHSID0WA2XJ/z4irdT/RujbJKn9jX2rB9qDjErpv8nSvRPKUN+QSSHNYPSk3T mr1c14Uc5wUKFATMZ21vpTYl79Kaag0I6o/9R24FsIBmjWO6X1+DFXGOFIp8oIliky++Uw6I/qG 6E5ZPXS15iQ+mGRU/efykQ+9+8m+36CQABxXV8zulH+QGQIvGKQUdXFw+ycUdoBX8YXucSDSclg c4MKvBArE9tDX1wccFvp4I5bcloOytJCkCF407zlDra5MEMunBic/3we1T2kn4Y43b4ti2dzwJQ AIP6diV2gRIR/eCGiQedbokFA+L2Trrm1opBelhKIJ8ppoyRPGhMmXeF1NFPnXc5pCg64ORxF45 ibMcfWKenKTcNsR88nspq/IcktBnERC0jS7O7fZWug3vf/RPKpVA9ZaadiTX+IAJj/nBhGkL2HL o0= X-Received: by 2002:a05:600c:4e8b:b0:480:4a4f:c366 with SMTP id 5b1f17b1804b1-48069c486e6mr97299665e9.20.1769692203387; Thu, 29 Jan 2026 05:10:03 -0800 (PST) Message-ID: Date: Thu, 29 Jan 2026 14:10:01 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH v3 5/6] x86/PCI: avoid re-evaluation of extended config space accessibility From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Stewart Hildebrand References: Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1769692225087158500 Content-Type: text/plain; charset="utf-8" When, during boot, we have already correctly determined availability of the MMCFG access method for a given bus range, there's then no need to invoke pci_check_extcfg() again for every of the devices. This in particular avoids ->ext_cfg to transiently indicate the wrong state. Switch to using Xen style on lines being touched and immediately adjacent ones. Signed-off-by: Jan Beulich Acked-by: Roger Pau Monn=C3=A9 --- v3: New. --- a/xen/arch/x86/physdev.c +++ b/xen/arch/x86/physdev.c @@ -528,6 +528,8 @@ ret_t do_physdev_op(int cmd, XEN_GUEST_H if ( !ret ) ret =3D pci_segment_iterate(info.segment, physdev_check_pci_ex= tcfg, &info); + else if ( ret > 0 ) /* Indication of "no change". */ + ret =3D 0; =20 if ( !ret && has_vpci(currd) && (info.flags & XEN_PCI_MMCFG_RESERV= ED) ) { --- a/xen/arch/x86/x86_64/mmconfig.h +++ b/xen/arch/x86/x86_64/mmconfig.h @@ -74,6 +74,6 @@ int pci_mmcfg_reserved(uint64_t address, unsigned int flags); int pci_mmcfg_arch_init(void); int pci_mmcfg_arch_enable(unsigned int idx); -void pci_mmcfg_arch_disable(unsigned int idx); +int pci_mmcfg_arch_disable(unsigned int idx); =20 #endif /* X86_64_MMCONFIG_H */ --- a/xen/arch/x86/x86_64/mmconfig-shared.c +++ b/xen/arch/x86/x86_64/mmconfig-shared.c @@ -388,8 +388,9 @@ static bool __init pci_mmcfg_reject_brok (unsigned int)cfg->start_bus_number, (unsigned int)cfg->end_bus_number); =20 - if (!is_mmconf_reserved(addr, size, i, cfg) || - pci_mmcfg_arch_enable(i)) { + if ( !is_mmconf_reserved(addr, size, i, cfg) || + pci_mmcfg_arch_enable(i) < 0 ) + { pci_mmcfg_arch_disable(i); valid =3D 0; } @@ -417,8 +418,8 @@ void __init acpi_mmcfg_init(void) unsigned int i; =20 pci_mmcfg_arch_init(); - for (i =3D 0; i < pci_mmcfg_config_num; ++i) - if (pci_mmcfg_arch_enable(i)) + for ( i =3D 0; i < pci_mmcfg_config_num; ++i ) + if ( pci_mmcfg_arch_enable(i) < 0 ) valid =3D 0; } else { acpi_table_parse(ACPI_SIG_MCFG, acpi_parse_mcfg); @@ -458,10 +459,11 @@ int pci_mmcfg_reserved(uint64_t address, segment, start_bus, end_bus, address, cfg->address); return -EIO; } - if (flags & XEN_PCI_MMCFG_RESERVED) + + if ( flags & XEN_PCI_MMCFG_RESERVED ) return pci_mmcfg_arch_enable(i); - pci_mmcfg_arch_disable(i); - return 0; + + return pci_mmcfg_arch_disable(i); } } =20 --- a/xen/arch/x86/x86_64/mmconfig_64.c +++ b/xen/arch/x86/x86_64/mmconfig_64.c @@ -138,8 +138,9 @@ int pci_mmcfg_arch_enable(unsigned int i const typeof(pci_mmcfg_config[0]) *cfg =3D pci_mmcfg_virt[idx].cfg; unsigned long start_mfn, end_mfn; =20 - if (pci_mmcfg_virt[idx].virt) - return 0; + if ( pci_mmcfg_virt[idx].virt ) + return 1; + pci_mmcfg_virt[idx].virt =3D mcfg_ioremap(cfg, idx, PAGE_HYPERVISOR_UC= ); if (!pci_mmcfg_virt[idx].virt) { printk(KERN_ERR "PCI: Cannot map MCFG aperture for segment %04x\n", @@ -160,10 +161,13 @@ int pci_mmcfg_arch_enable(unsigned int i return 0; } =20 -void pci_mmcfg_arch_disable(unsigned int idx) +int pci_mmcfg_arch_disable(unsigned int idx) { const typeof(pci_mmcfg_config[0]) *cfg =3D pci_mmcfg_virt[idx].cfg; =20 + if ( !pci_mmcfg_virt[idx].virt ) + return 1; + pci_mmcfg_virt[idx].virt =3D NULL; /* * Don't use destroy_xen_mappings() here, or make sure that at least @@ -173,6 +177,8 @@ void pci_mmcfg_arch_disable(unsigned int mcfg_ioremap(cfg, idx, 0); printk(KERN_WARNING "PCI: Not using MCFG for segment %04x bus %02x-%02= x\n", cfg->pci_segment, cfg->start_bus_number, cfg->end_bus_number); + + return 0; } =20 bool pci_mmcfg_decode(unsigned long mfn, unsigned int *seg, unsigned int *= bdf) From nobody Sat Feb 7 06:20:55 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1769692672; cv=none; d=zohomail.com; s=zohoarc; b=eoAlDj40cV35gR5mBEjseTsZlg6VUUSbMid6w69bKiZlApb0OwkJRIJf5oeUHynr/9SA/jdH3yhVOGupCfGW5GQfDyjyPhVKfqVI3+22txlD1zHGnKxoLFDo8h1piwvThIhb1B8wPMmrimUsPHFcRg/ItpJqYit1IOzhYU4kj3M= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1769692672; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Tv0OvyCcYzBuokmRIqcrOcEo5thGITFjrVvRj+Q4tm4=; b=JboZUaoSxxxfdQQIIK5PieQrqZYftPlnW/ra1NtPDHg+NgpwyrW732DTSH7wO+Urb5iZ0NeQP8wiyjK5fxJN4ZwqicyvX2Lj15FQBZMAVQ3aTr1eafNyZwLJnDhNptc0UsuXKCJZdD0p2t3yxawa1OiCPyNeXLjT20e/bqn7z6w= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1769692672516270.5791477420929; Thu, 29 Jan 2026 05:17:52 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.1216466.1526411 (Exim 4.92) (envelope-from ) id 1vlRtq-0006OD-K4; Thu, 29 Jan 2026 13:17:30 +0000 Received: by outflank-mailman (output) from mailman id 1216466.1526411; Thu, 29 Jan 2026 13:17:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vlRtq-0006O6-GS; Thu, 29 Jan 2026 13:17:30 +0000 Received: by outflank-mailman (input) for mailman id 1216466; Thu, 29 Jan 2026 13:17:29 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vlRnE-00038i-DI for xen-devel@lists.xenproject.org; Thu, 29 Jan 2026 13:10:40 +0000 Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [2a00:1450:4864:20::433]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e7478094-fd13-11f0-9ccf-f158ae23cfc8; Thu, 29 Jan 2026 14:10:37 +0100 (CET) Received: by mail-wr1-x433.google.com with SMTP id ffacd0b85a97d-42fbc305914so946701f8f.0 for ; Thu, 29 Jan 2026 05:10:37 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-435e132303fsm14536283f8f.36.2026.01.29.05.10.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Jan 2026 05:10:36 -0800 (PST) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e7478094-fd13-11f0-9ccf-f158ae23cfc8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1769692237; x=1770297037; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=Tv0OvyCcYzBuokmRIqcrOcEo5thGITFjrVvRj+Q4tm4=; b=NlAg3sw3HbqeIbmpm19W2MZRsveJaTpDi0QEbhUVd3ViSsXbuO7qqg4aSqFbL7Yqg9 GzQb6sSb6eX2/rr2Jh+g1/tlCRtr3z8pNvNud4snS1SDyQk5844cryHGON7YuU3h8VgS 8dYTtqfiwk+I/muEGVhRL1TwwlXeckuebtbFMg2iTcVcfoECRoaAbAA6O++zj2GonDqu ekCMm9XlIMroOUyHkztkXMyovBbciU55yMGdkTHNHb1RdQpuPvTeb6V0g5e5snrQhJli oCOohy/5sUHUdIs08jaAGhuu1N31lFuyovwDlg6SSq/mfUhUxh6w+omtQGQlMB+592AO hpww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769692237; x=1770297037; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Tv0OvyCcYzBuokmRIqcrOcEo5thGITFjrVvRj+Q4tm4=; b=bP/W+/REAJIPU7TEUOi7k1Bqtr5WX5zYMcCujeC7FpOcHMqdgxaeYFwxhMZ4WiIK5q aF0y4EFIpf0Qq1+6kFiE/XevueMiMOd+dtL1jeLyOywv6MAw1/3fxVDy5+FWA2b6ap+e 6KIRoIj12cfauIJT/oz2xQir/CblbOO8wNBAmeFn7IBIBDbnmxC0xCL5dJMaP4KRgqVx QThJzLP9x0KIHcvpyKOMeOx+5izJWuhY/sBsaju3Q+JhdmfAhEcW7gDTZBL5XlCEod3h qpwmAh2BiYaHDWdMTMrzH2/+NyZrPbkWZitxFG0ERtgVqLsez5uTBHwBMangYqlfEn65 RaWg== X-Gm-Message-State: AOJu0Yw6CbEbzS3BB0CLAvWU7n6ZtvieE4S8wQ++5/Zjnil+71/SLn/E dOQwb45kHkWR6+y012wSK5jbkMsv2rOn+19PISw6lN0uQvIzur4c8xG9UAxMZiUQyh7b8AeWR57 DAWM= X-Gm-Gg: AZuq6aJ2cSpTVP+SFs5xHu6wOCMsoQX3bz1WI+0bRCdOrveGf0shfzI3qMgRSFfP6/I sKSA3EJStAs5i2zD7SLn1LOwTSCU7TcVz3pMaSICKrSs6Tt9zDbtl7JWqNEqRfGRgO8Ce96P9eu pbc4JTXSdbSSd5EZOjDT8qFwUUauwOU+ZseNT8cX45hqjxH+NKesADz/xeWLZHp5Rkrh0oPQcWe io/bRfF8KQU3iGMaI2jTJhno23tbQ+MDUN6kXya3JR6WCVh9NTjj1qy9m8Ztp9WnGs/VYv2JoZN cpQ7lw3T5RPdr345ussDCGoVffK0LF+lOW8CmalZyhRxVArY2AULS1cv63vu5aWJexYB9hbBauX kXGF25waL8hIdMEBhqSKouSw8RdqXYlQnhohXfgMNc+h6c8ZDmrG0f521tEnPVMcQBEQULggdxu CDd2Bo3Ol8H0vggM8JOtsS51I9Qatf3ayECYpIfxpibtsOxE/aEDcLbf66TfvQEWzNWWO/dIHSp Pn0DJUM6cgStQ== X-Received: by 2002:a05:6000:2082:b0:435:a9c9:159 with SMTP id ffacd0b85a97d-435dd05aba3mr12142676f8f.18.1769692237050; Thu, 29 Jan 2026 05:10:37 -0800 (PST) Message-ID: Date: Thu, 29 Jan 2026 14:10:34 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH v3 6/6] vPCI: re-init extended-capability lists when MMCFG availability changed From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Stewart Hildebrand References: Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1769692675254154100 Content-Type: text/plain; charset="utf-8" When Dom0 informs up about MMCFG usability, this may change whether extended capabilities are available (accessible) for devices. Zap what might be on record, and re-initialize the list. No synchronization is added for the case where devices may already be in use. That'll need sorting when (a) DomU support was added and (b) DomU-s may run already while Dom0 / hwdom still boots (dom0less, Hyperlaunch). Signed-off-by: Jan Beulich --- vpci_reinit_ext_capability_list()'s return value isn't checked, as it doesn't feel quite right to fail the hypercall because of this. At the same time it also doesn't feel quite right to have the function return "void". Thoughts? --- v3: New. --- a/xen/arch/x86/physdev.c +++ b/xen/arch/x86/physdev.c @@ -8,6 +8,8 @@ #include #include #include +#include + #include #include #include @@ -169,7 +171,10 @@ int cf_check physdev_check_pci_extcfg(st =20 ASSERT(pdev->seg =3D=3D info->segment); if ( pdev->bus >=3D info->start_bus && pdev->bus <=3D info->end_bus ) + { pci_check_extcfg(pdev); + vpci_reinit_ext_capability_list(pdev); + } =20 return 0; } --- a/xen/drivers/vpci/header.c +++ b/xen/drivers/vpci/header.c @@ -869,6 +869,18 @@ static int vpci_init_ext_capability_list return 0; } =20 +int vpci_reinit_ext_capability_list(const struct pci_dev *pdev) +{ + if ( !pdev->vpci ) + return 0; + + if ( vpci_remove_registers(pdev->vpci, PCI_CFG_SPACE_SIZE, + PCI_CFG_SPACE_EXP_SIZE - PCI_CFG_SPACE_SIZE= ) ) + ASSERT_UNREACHABLE(); + + return vpci_init_ext_capability_list(pdev); +} + int vpci_init_header(struct pci_dev *pdev) { uint16_t cmd; --- a/xen/include/xen/vpci.h +++ b/xen/include/xen/vpci.h @@ -45,6 +45,7 @@ typedef struct { REGISTER_VPCI_CAPABILITY(PCI_EXT_CAP_ID_##name, name, finit, fclean, t= rue) =20 int __must_check vpci_init_header(struct pci_dev *pdev); +int vpci_reinit_ext_capability_list(const struct pci_dev *pdev); =20 /* Assign vPCI to device by adding handlers. */ int __must_check vpci_assign_device(struct pci_dev *pdev); @@ -300,6 +301,11 @@ bool vpci_ecam_read(pci_sbdf_t sbdf, uns #else /* !CONFIG_HAS_VPCI */ struct vpci_vcpu {}; =20 +static inline int vpci_reinit_ext_capability_list(const struct pci_dev *pd= ev) +{ + return 0; +} + static inline int vpci_assign_device(struct pci_dev *pdev) { return 0;