From nobody Thu Oct 30 15:26:05 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1761422997; cv=none; d=zohomail.com; s=zohoarc; b=nHRtQC4cQ9FKVphx9DgknpQ8DOSW1VVBIZkJI0rx2ZpU7iN1Tw0Q2pSlMrSMCmo7CmJpHx3Y+yXlcnCSeSLQeqgPwi7zghZ/dpjLug7R5UUBaVB5AlmOYS80xlpfjjm57guYuJ36XmcNqYM32OJ8dioPdJ2iVjKf26eKTRAjf7w= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1761422997; h=Content-Type:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=rsTuzccq5BBMJUG6ObPUHlp6hFKmAerwIxImdU/w9aw=; b=ZeSwvcz1A2NuTIeB+AlLJhlRAiB4wEUaZCAYZZOL849KDVKk1dvs2t2ujCMbuh/+5MiZFhDpnzo8qimQ4rtlac51GZ/HQyg9zm7qC3c6t5PN/Fv8xSoF+JUtkcvJwKpbxZA6rM3qSz3KrxkNlMkJQmjRkkVhW5Twt+9aCzhbC1M= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1761422997402130.26040454408678; Sat, 25 Oct 2025 13:09:57 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1151233.1481904 (Exim 4.92) (envelope-from ) id 1vCkZq-00039F-2z; Sat, 25 Oct 2025 20:09:26 +0000 Received: by outflank-mailman (output) from mailman id 1151233.1481904; Sat, 25 Oct 2025 20:09:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vCkZq-000398-0T; Sat, 25 Oct 2025 20:09:26 +0000 Received: by outflank-mailman (input) for mailman id 1151233; Sat, 25 Oct 2025 20:09:24 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vCkZn-000392-Th for xen-devel@lists.xenproject.org; Sat, 25 Oct 2025 20:09:23 +0000 Received: from mail-yx1-xb12d.google.com (mail-yx1-xb12d.google.com [2607:f8b0:4864:20::b12d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7e08c03b-b1de-11f0-980a-7dc792cee155; Sat, 25 Oct 2025 22:09:21 +0200 (CEST) Received: by mail-yx1-xb12d.google.com with SMTP id 956f58d0204a3-63e35e48a27so3289725d50.0 for ; Sat, 25 Oct 2025 13:09:21 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7e08c03b-b1de-11f0-980a-7dc792cee155 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761422960; x=1762027760; darn=lists.xenproject.org; h=cc:to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=rsTuzccq5BBMJUG6ObPUHlp6hFKmAerwIxImdU/w9aw=; b=JFhwc9XhAyHMZNHxpgxwVHjpqyOAChaUDZoN9IJ33bxB9RaPToLW1LOnuAnUckaBHP TVF24FznVo6m+p+kd1GBQe8pfAnJoeY1SgEL700324wXOkVPX9b9JECfZLQGNybNviPV ySIa4WMhmATjNSWYdmN3a1F9CqD9lDqUQBE634xg5pdq/sHMBrk7BLrdnzXfIy5GWhQX q57sazno/CC6uGQaKAlrr+qfQ5berUsPuBDnu4mRBqrlzBCz42De6PURtzeriRGCGbVf HQyRcxuiFpmK/U1r8SDGIh6Su3D1YUzY4O9Rfkl3AVbaApyCnlwg9qNe4as8qdvJlDKA aZug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761422960; x=1762027760; h=cc:to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=rsTuzccq5BBMJUG6ObPUHlp6hFKmAerwIxImdU/w9aw=; b=DLLNH6Wqvj2EDF2cKW4X6+yQkTtfGnc9A4pqAKFqi7mp183BZwUgvQRRgiulyMMO4U RVAUkn5r62Pg7QCGI9/Ldgy0SRAtbXxzOVlNG5E/LOAroBVyTBdyppF4821+XG3wixjO xz3922QnDcz5wjjsvsQKYJBV0G31bVsRpEo0uA4FQqjWTXfHSbgBzOQsveQHZND7lf+l 7jXQvIFRHUYXHKAI/YgZaGmT6anVa7gRDgmjlqjlWuojnUajPKQUdmqZhcrMGcyZsDNl plY+QcoAC3XOgC7dtjx5/FfyjllEyUd4pZx/ovyDITzcg+JDR54aE8SxwJCyeOFrubjz 6NYw== X-Gm-Message-State: AOJu0YyZSeUs0vurC4Z1yx4GY6tZMpnYtsi3DOCbV4X54pOowEmgM184 g6yhP/1c+GiVU/1BaQS4XlKZXIX2txwD1pQbUSblIVWBXnsFKvFkksnQcBgETRpb6xA+8uT0/88 8RiERjhHWYnyCJ+Z6ixScVP1QPjuhJOTICiSr X-Gm-Gg: ASbGncsElyV4nKTAp1KQRMWyoB2mGYS9JkV1LRL7aEaY2TuJg+cvqojjASk+gtUYNjr zMcqo9ZDU9r3Y5sroHA1C/fM/TqqUu+NLIJXjewH+2QgRru8jUpfhNzZMmazfaEoZYmVwyjKskQ RsurZjxNtJdqCP5nuJn6CSj+/3Vjt0fK7kEo3WD9Y2hSJzlgdf2RMhHOHv9r7QjRHLs1NsSi09o Mq7SFIj9bXLosgzFPJywhjfzsr7MglfOFI/hMZswspIfS8MyEMZtx6g9WWK X-Google-Smtp-Source: AGHT+IEPJLFh+9PuUvoA8kwP4K0mNmrcllMgyWgkTlwYzLHdppceX0an36fMdS+ugtCHXaIzXatBiKv9QQXVUNEod5A= X-Received: by 2002:a05:690e:1593:10b0:63b:5b6e:2967 with SMTP id 956f58d0204a3-63e16109f8bmr22981869d50.5.1761422959632; Sat, 25 Oct 2025 13:09:19 -0700 (PDT) MIME-Version: 1.0 From: Frediano Ziglio Date: Sat, 25 Oct 2025 21:09:08 +0100 X-Gm-Features: AS18NWB3-kwS9AMxjFSzJTXWkcnR_V9pU7FD_O0PGt461J0JMJRcwyEwkP3BK9I Message-ID: Subject: [PATCH v2] xen/pci: prevent infinite loop for faulty SR-IOV cards To: xen-devel Cc: Jan Beulich , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Andrew Cooper X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1761422999423154100 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" If a SR-IOV card presents an I/O space inside a BAR the code will continue to loop on the same card. This is due to the missing increment of the cycle variable. Fixes: a1a6d59862f4 ("pci: split code to size BARs from pci_add_device") Signed-off-by: Frediano Ziglio Reviewed-by: Jan Beulich --- Changes since v1: - add Fixes comment --- xen/drivers/passthrough/pci.c | 1 + 1 file changed, 1 insertion(+) diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci.c index 3edcfa8a04..52c22fa50c 100644 --- a/xen/drivers/passthrough/pci.c +++ b/xen/drivers/passthrough/pci.c @@ -746,6 +746,7 @@ int pci_add_device(u16 seg, u8 bus, u8 devfn, printk(XENLOG_WARNING "SR-IOV device %pp with vf BAR%u in IO space\n", &pdev->sbdf, i); + ++i; continue; } ret =3D pci_size_mem_bar(pdev->sbdf, idx, NULL, --=20 2.43.0