From nobody Tue Feb 10 05:27:01 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1606144937; cv=none; d=zohomail.com; s=zohoarc; b=BpWE+/5mVTQ2GM27dYK9hlv2SIfAx2DAmoXlzMkRgkPWd0tyy1/kcTgcDaUSbmAmkika/ECSVsMuKFwYRNPlxFavzB0QABg55Mn9adfGi4ZciJcvbl1HsP/vf/ljxJDTEX/LepS57iKp8JKrmhpvfYxf49CfmO7MdXDo+VIz+Uc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1606144937; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=/ldUqwFP54C4R/7w401QZG+FeOKXlfpX2Gg3oaRW57A=; b=Bsf1qc0IzMmfymS+gH3DcZdoF2nYlukLalRskaRhtwkP/6xMqHdqy23xeqwcb2U684K5T2aTdjTvkyLE8SiaxajuTWOp2BUl/MoCR4sc58Rr1Lk9PD9DrRNxe372u+RzEtA6zXcf5+d2bQfuxHCxQHrEu3wsrRitqGJF6JXRWkI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) header.from= Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1606144937648392.34427170690935; Mon, 23 Nov 2020 07:22:17 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.34643.65808 (Exim 4.92) (envelope-from ) id 1khDf9-0006kr-9O; Mon, 23 Nov 2020 15:21:55 +0000 Received: by outflank-mailman (output) from mailman id 34643.65808; Mon, 23 Nov 2020 15:21:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1khDf9-0006kk-5C; Mon, 23 Nov 2020 15:21:55 +0000 Received: by outflank-mailman (input) for mailman id 34643; Mon, 23 Nov 2020 15:21:53 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1khDf7-0006kV-Dm for xen-devel@lists.xenproject.org; Mon, 23 Nov 2020 15:21:53 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 9e3d3f61-ee19-4ff6-b288-ca9cb0580c30; Mon, 23 Nov 2020 15:21:52 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id A4AAFB00D; Mon, 23 Nov 2020 15:21:51 +0000 (UTC) Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1khDf7-0006kV-Dm for xen-devel@lists.xenproject.org; Mon, 23 Nov 2020 15:21:53 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 9e3d3f61-ee19-4ff6-b288-ca9cb0580c30; Mon, 23 Nov 2020 15:21:52 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id A4AAFB00D; Mon, 23 Nov 2020 15:21:51 +0000 (UTC) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9e3d3f61-ee19-4ff6-b288-ca9cb0580c30 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1606144911; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/ldUqwFP54C4R/7w401QZG+FeOKXlfpX2Gg3oaRW57A=; b=qiLShgIg0egBAZqvag3aTqfWVsVr6aQi7sHrBUi1VHu6DKM9gPe38Kua5oMXFYE4Eq7Vo0 a5EPQnG6qHxNRK0OdH+Gf7Y5W9u8JJNgRdBoqwgEm3uTMezxKV9jTTE6Ijl2G7bBf0A9fx bYSGyqYiPy3yF2TYewyibcq6zm6bOjA= Subject: [PATCH v3 3/8] lib: move list sorting code From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Ian Jackson , Julien Grall , Wei Liu , Stefano Stabellini References: <1a6bac6a-7d83-f5b6-c5b9-8b3b39824d40@suse.com> Message-ID: <9e855f2f-c654-6515-ae4f-9c69859c1c88@suse.com> Date: Mon, 23 Nov 2020 16:21:51 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: <1a6bac6a-7d83-f5b6-c5b9-8b3b39824d40@suse.com> Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @suse.com) Content-Type: text/plain; charset="utf-8" Build the source file always, as by putting it into an archive it still won't be linked into final binaries when not needed. This way possible build breakage will be easier to notice, and it's more consistent with us unconditionally building other library kind of code (e.g. sort() or bsearch()). While moving the source file, take the opportunity and drop the pointless EXPORT_SYMBOL() and an unnecessary #include. Signed-off-by: Jan Beulich Reviewed-by: Bertrand Marquis --- xen/arch/arm/Kconfig | 4 +--- xen/common/Kconfig | 3 --- xen/common/Makefile | 1 - xen/lib/Makefile | 1 + xen/{common/list_sort.c =3D> lib/list-sort.c} | 2 -- 5 files changed, 2 insertions(+), 9 deletions(-) rename xen/{common/list_sort.c =3D> lib/list-sort.c} (98%) diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig index f5b1bcda0323..38b6c31ba5dd 100644 --- a/xen/arch/arm/Kconfig +++ b/xen/arch/arm/Kconfig @@ -56,9 +56,7 @@ config HVM def_bool y =20 config NEW_VGIC - bool - prompt "Use new VGIC implementation" - select NEEDS_LIST_SORT + bool "Use new VGIC implementation" ---help--- =20 This is an alternative implementation of the ARM GIC interrupt diff --git a/xen/common/Kconfig b/xen/common/Kconfig index 3e2cf2508899..0661328a99e7 100644 --- a/xen/common/Kconfig +++ b/xen/common/Kconfig @@ -66,9 +66,6 @@ config MEM_ACCESS config NEEDS_LIBELF bool =20 -config NEEDS_LIST_SORT - bool - menu "Speculative hardening" =20 config SPECULATIVE_HARDEN_ARRAY diff --git a/xen/common/Makefile b/xen/common/Makefile index d109f279a490..332e7d667cec 100644 --- a/xen/common/Makefile +++ b/xen/common/Makefile @@ -21,7 +21,6 @@ obj-y +=3D keyhandler.o obj-$(CONFIG_KEXEC) +=3D kexec.o obj-$(CONFIG_KEXEC) +=3D kimage.o obj-y +=3D lib.o -obj-$(CONFIG_NEEDS_LIST_SORT) +=3D list_sort.o obj-$(CONFIG_LIVEPATCH) +=3D livepatch.o livepatch_elf.o obj-$(CONFIG_MEM_ACCESS) +=3D mem_access.o obj-y +=3D memory.o diff --git a/xen/lib/Makefile b/xen/lib/Makefile index b8814361d63e..764f3624b5f9 100644 --- a/xen/lib/Makefile +++ b/xen/lib/Makefile @@ -1,3 +1,4 @@ obj-$(CONFIG_X86) +=3D x86/ =20 lib-y +=3D ctype.o +lib-y +=3D list-sort.o diff --git a/xen/common/list_sort.c b/xen/lib/list-sort.c similarity index 98% rename from xen/common/list_sort.c rename to xen/lib/list-sort.c index af2b2f6519f1..f8d8bbf28178 100644 --- a/xen/common/list_sort.c +++ b/xen/lib/list-sort.c @@ -15,7 +15,6 @@ * this program; If not, see . */ =20 -#include #include =20 #define MAX_LIST_LENGTH_BITS 20 @@ -154,4 +153,3 @@ void list_sort(void *priv, struct list_head *head, =20 merge_and_restore_back_links(priv, cmp, head, part[max_lev], list); } -EXPORT_SYMBOL(list_sort);