From nobody Mon Jan 26 07:39:21 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1769009188; cv=none; d=zohomail.com; s=zohoarc; b=S1vy4unQxFFqTPW9zNAyHOqU1sK/LNnFhnRf4hG/VIcq9eX2GmDRMahPZslE+A+eIRwUijf4PX4vo5VMqm9LOn0B+PVbpBiNQWug8W6HnYR/438g/B7XATQysYidqWZZ3Qz2ah2dG5HedywTbh747rMNQMCo11yveaxfryzdhcU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1769009188; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=eSECRAgdJ7kh97tI1tfVcwsS2/Sh8RoFc4OEZoh/Wu0=; b=hAVl9+ZgDPZeSrc6Wn/6oeC5Ib4ydF0LzdLAPVIVr2B3ys9uIkdWE4uvOhl65BRN93lEigpmJq0ZNhLP6NPuNoE0yB7jecr4PmEm1EGYrF5COIoAMcROQPov8EMR7Rp7aKxo467q6oXzmymxqV6K67T6ntxbWgb/WyaCLlG8ufE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1769009188887613.5930017729294; Wed, 21 Jan 2026 07:26:28 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.1209911.1521793 (Exim 4.92) (envelope-from ) id 1via5y-0008Ih-I7; Wed, 21 Jan 2026 15:26:10 +0000 Received: by outflank-mailman (output) from mailman id 1209911.1521793; Wed, 21 Jan 2026 15:26:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1via5y-0008Ia-DL; Wed, 21 Jan 2026 15:26:10 +0000 Received: by outflank-mailman (input) for mailman id 1209911; Wed, 21 Jan 2026 15:26:09 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1via5x-0008IQ-DX for xen-devel@lists.xenproject.org; Wed, 21 Jan 2026 15:26:09 +0000 Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [2a00:1450:4864:20::42b]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 80e7860b-f6dd-11f0-9ccf-f158ae23cfc8; Wed, 21 Jan 2026 16:26:07 +0100 (CET) Received: by mail-wr1-x42b.google.com with SMTP id ffacd0b85a97d-4327555464cso3652196f8f.1 for ; Wed, 21 Jan 2026 07:26:06 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43569921dddsm38605495f8f.6.2026.01.21.07.26.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 Jan 2026 07:26:05 -0800 (PST) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 80e7860b-f6dd-11f0-9ccf-f158ae23cfc8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1769009165; x=1769613965; darn=lists.xenproject.org; h=content-transfer-encoding:autocrypt:subject:from:cc:to :content-language:user-agent:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=eSECRAgdJ7kh97tI1tfVcwsS2/Sh8RoFc4OEZoh/Wu0=; b=aHk3NoDL62knARGgtdwwq1BBypHfzxsby73koXeqYOcS+qIY5BcUd2ghM3VW4paB6V QL+1deMNKlZZFWcAgXverBDaGj8T2/5HmAbKOQFYNJ89RoDljX/+u8lZi7V5v/sLU4HW W6/eM7OaJ0jgi07YnDMz9ngrhLTlQx+XGXjiyJYK26+ceVBEW08/17SU+09UfemSneLp LAVy6kf09TSFWDT3wKnjsMXv/oIHDAedPRtIfc0MbjVkOgm4n/dSK3/Oc5n2JFTWHJYQ N+azcuDgO9CovDaRiUIRRhZSltGeqTrCxF9WRkUBPpTxfUlhQrdhZwTGXfICmwFQeqm5 LuFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769009165; x=1769613965; h=content-transfer-encoding:autocrypt:subject:from:cc:to :content-language:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=eSECRAgdJ7kh97tI1tfVcwsS2/Sh8RoFc4OEZoh/Wu0=; b=b+eWzN4uQUxvjxY51ftugMtBqxGRLVbacvw89d/MZVdo2RYS5iN3ljhzjxEvH9TIUa JeGNoGgRyqeDuorxqB+PKM3QtvgMtT6mAS49a9UrJxiDYUi+LPtFLzRdBxmpaZrgquFa oBaZQXIXmw2qbjA+XFYOpU6qOTJbDQXiaf5LBAWInNwwguXVvHDm8r8D9bYXuEw+cQgC 01e68y/JgHdiCxbks/tQMn4/ILLC2KUU833MWhkdGxT8JBz4aQFesuZVddPgLNGx1Y6d p3dK4X1JCkA4KL7huYTbYzfMiksXcves6hHB799H3K8R+D2mP4ehMXfgUmtdxXSDnDr9 BN/A== X-Gm-Message-State: AOJu0YwpOXmGfRx5Ew62nD45aAhDk0yi8gf8qE6ugo3BegAZE0rf8xxj 7M+vgH47bFppGMO0mEzaLPcrMWmJadoDV6sPDBgd8gKt7ol6RjX/had3g4ylphSE12ddJ3pgNq3 zCd8= X-Gm-Gg: AZuq6aLb8UHoPzFr5mnRaalTe0sN0saEipKGNOcCveSNthk+pVkd6TLeuebE42RVIUS EoXLqXtD37wIYeMcZ9ayWYOLJ/MGvBWIgqbyMynLDm/8mBQ5ZBkLb0pvaT6n61inkcb5cCoMboS AwL7KC2twtCYu5htL99nXTxG3Cx1uACcMBE+bVn7AAImj/UZwy3W9hz/ksicYiBkiSM4BElpb9m v31MF3WtHRno2eTtm2GYhf8QFCniYuhjLf7xBZztgUReg+3rCDVV/4+2CL60+kKUj5QSDwks//U 5ODBZzHSKALEDom9ophNTuVpruXu9chclFWHc038vOjrjQqeQ/m6p3PSSlvrniez/iUEuEJVPqu tLgpkK3SImPm8opuxvaIgR7LdwGIE8egDcIawnScs9TJR4NlrupPnOplpZPabLZeF2F0v1kSQD8 TpLuLsq5dAV8qjQ6gVTidtsLDmDbfv5Mv9bI6/+B5Sp/5WtTEGA9zQRn6+GB9xv31MK1t2zXYfd sw= X-Received: by 2002:a05:600c:a412:b0:479:3a86:dc1d with SMTP id 5b1f17b1804b1-4803f2a438fmr65180595e9.37.1769009165525; Wed, 21 Jan 2026 07:26:05 -0800 (PST) Message-ID: <9dc297d2-08f1-460a-b513-91deaecbd2d4@suse.com> Date: Wed, 21 Jan 2026 16:26:03 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Julien Grall , Stefano Stabellini , Anthony PERARD , Michal Orzel , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= From: Jan Beulich Subject: [PATCH] symbols: don't omit "end" symbols upon mixed code / data aliases Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1769009190816154100 Content-Type: text/plain; charset="utf-8" At the example of _sinitext - that symbol has four aliases on x86: __init_begin, __2M_init_start, __2M_rodata_end, and whatever the first function in .init.text. With the GNU toolchain all of them are marked 'T' or 't'. With Clang/LLVM, however, some are marked 'r'. Since, to save space, we want fake "end" symbols only for text, right now want_symbol_end() has a respective check. That is getting in the way, however, when the final of those symbols is 'r'. Remove the check and instead zap the size for anything that is non-code. Fixes: 6eede548df21 ('symbols: avoid emitting "end" symbols for data items') Signed-off-by: Jan Beulich Acked-by: Roger Pau Monn=C3=A9 --- Roger, just fyi that I think that this change would mask the other issue that you reported, without actually adressing the underlying problem. Hence both changes will be wanted. --- a/xen/tools/symbols.c +++ b/xen/tools/symbols.c @@ -164,6 +164,10 @@ static int read_symbol(FILE *in, struct else if (str[0] =3D=3D '$') goto skip_tail; =20 + /* We want fake "end" symbols only for text / code. */ + if (toupper((uint8_t)stype) !=3D 'T') + s->size =3D 0; + /* include the type field in the symbol name, so that it gets * compressed together */ s->len =3D strlen(str) + 1; @@ -312,7 +316,6 @@ static int compare_name_orig(const void static bool want_symbol_end(unsigned int idx) { return table[idx].size && - toupper(table[idx].type) =3D=3D 'T' && (idx + 1 =3D=3D table_cnt || table[idx].addr + table[idx].size < table[idx + 1].addr); }