From nobody Sun May 19 00:42:47 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=suse.com); dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=2; a=rsa-sha256; t=1664445088; cv=pass; d=zohomail.com; s=zohoarc; b=n4+5EajwvFI0QtcjhlO0hd2yLpazuH4xsaVaLDV8BBatGXpNsMqRYTZl+wbdvQuCv9peDSdUPfTadTwGFr7lw/a+wePmscFtPr5htDkEBQC5htukPkO52zsueRWkBKkKwDeEousspei1AMK6E/NfDC8jHlnhK0AYJmGP/7icdHI= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1664445088; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=+86ZEmgrwt0Ukv/jXJFhwGTpqrhzbbbTEia7yvF+u/0=; b=UKW3toMFrThZrfDmT7aEQ3v8+lASaitMelnIriUs3RtIfAz1jQ7PSiiZyqILMmJ5zYp/OM9BIpBa+s8BijMHVTNSZQO0OpveW2tC/oosFWjWg7gOomJk0VW96E5RoAjl26Bf8nOTonHka1RcfMZpG80bMwKCHEqVUsUv5LCPikw= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=suse.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1664445088073975.9123205778665; Thu, 29 Sep 2022 02:51:28 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.413556.657268 (Exim 4.92) (envelope-from ) id 1odqCE-0004cM-EN; Thu, 29 Sep 2022 09:51:10 +0000 Received: by outflank-mailman (output) from mailman id 413556.657268; Thu, 29 Sep 2022 09:51:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odqCE-0004cF-BW; Thu, 29 Sep 2022 09:51:10 +0000 Received: by outflank-mailman (input) for mailman id 413556; Thu, 29 Sep 2022 09:51:08 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odqCC-0004c7-Iu for xen-devel@lists.xenproject.org; Thu, 29 Sep 2022 09:51:08 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2051.outbound.protection.outlook.com [40.107.20.51]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3d252d72-3fdc-11ed-964a-05401a9f4f97; Thu, 29 Sep 2022 11:51:07 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PR3PR04MB7209.eurprd04.prod.outlook.com (2603:10a6:102:92::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.19; Thu, 29 Sep 2022 09:51:05 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.017; Thu, 29 Sep 2022 09:51:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3d252d72-3fdc-11ed-964a-05401a9f4f97 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cWq67xcV4i9QBj90mg9Nu2eBsPYNCBSPVq0FKG55chfUeTGAa+u/RpOwbWasoMB/Ttp1cWti8rtPlfvMOh9xAJubTtO9gJlJCAsZqQK3O0Jq7qOGvUqqCSXPdGVEOkgpwm4zCcBtw+o2Y1EDxNWV77u9eHVe+bpoCnQT2nbTRrhQyYvB+Lcc5y+I3rX9NjUJVzYYuqIi3gOG4aQuWSO/bX+04F+ubPue/2Xp8nUf1ZzIwTNtSDLPBlStWa3JsXPWhFRVH8Uv3BHMyOswIsTau0Q8NEjBXBBngI1qPR1FT6xL0HIunNpkWTBFWc+uJLBt515WoU7mN+N+PEfm1CzFnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+86ZEmgrwt0Ukv/jXJFhwGTpqrhzbbbTEia7yvF+u/0=; b=YhveM2T/ZRzuDMCZCZbWpNNhZLX7uw9oJPq0CrZMNtF56VIYaTa9hX+UheXZ8KBL5v8YXpt7u1aX/IFNtsCFWeSqP4gimN/XYbq0NOCc7EPPpwJHtwHTsKVbUCZfoFcAFdY11vh3/Rhrter5H0XYm7CIP7iKvuA3iHMafvqctAwr87FBXTtXk5TsfYr0givDCG90XQ+fHKuSUk6D8UWf3wYxCU/Tw5zv0TFryiafCKDZ6T7rUlTbVunAPrLaRjGmThtJfllngl/D0zzZvSu10pblqXcL5tERonUZGy7FmaSgNGtNn8f1/JA7aHtTYgy6melIuRXhnnctylrgrV8+mQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+86ZEmgrwt0Ukv/jXJFhwGTpqrhzbbbTEia7yvF+u/0=; b=fnWa6xGQpL8utn7klNM+OykDOBexy1+lgbZHntTziy3B+rUp/nnsx2gj2TEsKph5mCmhmctwcqzR3NLxWwabPMrgT2TxjUsqWlefRst1S3fzj5Ti7fErGmCbrlFw68vkYkG7ZC6qm6epaQE8hGwR4CYttdd8UMTR9w/Knn6/OsozorTwJC9vgd7WnmV539BrvAWaDfEcnT0kt+q/BofWKWdqD4LoPnpzVUVyv9fCZ2wUonVZvEV5+YW1jVFowlANzxeSzraAOAmyfLE6S+YXfcuLg7ewEmX4WQMq19ur7ltuRMOhYeH4Yb/JEchJ9Ow5DvADeT8VCjPaNZc5NjRjmg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <8b5c0b8f-b243-47b1-2ce9-f315d5c7138c@suse.com> Date: Thu, 29 Sep 2022 11:51:03 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: [PATCH 1/2][4.17] x86: re-connect VCPUOP_send_nmi for 32-bit guests Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Henry Wang References: <96adeb88-dcc4-5ca2-54a4-883058169dbb@suse.com> In-Reply-To: <96adeb88-dcc4-5ca2-54a4-883058169dbb@suse.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AS9PR06CA0244.eurprd06.prod.outlook.com (2603:10a6:20b:45f::35) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PR3PR04MB7209:EE_ X-MS-Office365-Filtering-Correlation-Id: 5b0ada32-8c7a-44b0-ce0c-08daa200205a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Btkv9oXTgbuermqLg0rDUEHeAmDQTpPm7F6xHZ0gPk+QqZkHCOjGoU4b8qiLg2mcjqcjJWq6VlH2wQ6NXqRVI6cNeYQe/BaxlVPWhKxl7eFtP4wk4Sbv7nw9Xu05T92We/Y0BKbW81aq15shKu6Q0Oqx9UvyKrfAU0qZzYGgvVh0R5jSxwZqrGgtQageERjGr41HaDj/gpksyYafitFRBKwl7jtUF7QLjAmfM5Ja304AyuvGinoT9XJOkYYq3ERW/h8Ih/lxrb3ogoVrvASweR2yqIUcngQGUG2k1iBnRphvoe/btnmxwJ+nAt/lGY6r2a96k82gNri+SOUk5d9DrwTlhvc0u/TP3RQQ7wVxTYA9CbD4r/vIL+8GqIMu9lr6I2ryhCa0lkUPJKw0vvAF+k0lxcYjqUxPgkZDuaVo1BgCSiQL7nHSiIuoGJN6UkHjaxlRGSwjLutzfpRc1YRnmHPivWht9nlkVtcGd11S15S/Rv8Hdv33/5pKY7MT2CYV4ltUr8lKhOFUYW0mhjrorv5qYURkabfLaVYyFt5JfzdedkcYBrocR4mAx+ZgxP/7QGvIRjrVYz+abzq/Pscp2gw90H+3BLn5oMgJh5aObXy5wV+YZxuwPifzB6SrdeshBaxbvmWcmIWA0yGzee/I3liY/ZYHAw4lQ5IvAi971ozJO2vMTU2EqE+hcnxRq6mI8Yf7cy+6t78JB05Hudfi6I7i8d8cfMkRX5U7pAv5h90yKg1hxNdmiBvxNQaIjBzrhT0Y3xFmufrIQjRvY9zurWlatLPUQkFkDe1odumv4j0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(376002)(366004)(346002)(39860400002)(136003)(451199015)(31686004)(6486002)(316002)(54906003)(6916009)(478600001)(31696002)(36756003)(2616005)(8936002)(66946007)(4326008)(8676002)(66556008)(66476007)(38100700002)(6506007)(186003)(2906002)(26005)(4744005)(6512007)(41300700001)(5660300002)(86362001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q2Q5SlJYZmRpUzRCaWpkTHdFRElTL0s0Y292dnZGclhMREpYRW55eW44dktB?= =?utf-8?B?ajl0Z3hWUEEwdnNqMUVsMElRbjR4c2IyRDloSUdiVTMxdStXOU8rRiswREVI?= =?utf-8?B?U3crc1QzNm41Yk5jQXBid0dKNFNEeXdLSnZ1MTNMNWx5bzlHMWw0VjA5aGdx?= =?utf-8?B?dXU5d2d2a3VuUjFTeFR5b0VBbnlSMUtKKzdwRlVIaDN5NnlSZEY0NmxBK2hj?= =?utf-8?B?Uk9UWDBKUVR3ODBLZnhVbDRmemh6cXgvcXlXY09jTXZUUHNpNnVxTzMzSDRP?= =?utf-8?B?ZnRZR3lQNHJrNEQxOUdsWUd3YkczaVY1WlJqNlZCMnVOL0IvRXpKWjlpbzBa?= =?utf-8?B?Z1RNdHdmRlpGN1FRK3p0SEFHYWc2Y0FEZzUrRzE5VXlIOG5MZlJYckFnMFh2?= =?utf-8?B?aktRbk9DYi9pVEIxY1Q2UnVERGRTQ0FWY2tCZm9BcG9MN1FhaGJPdCtKK3J0?= =?utf-8?B?MU41UTlRVWtGRHE1UjZQTGRkSHNDVkxLZXdrZ0xMcC9YaVBwT0VmVVdraUdy?= =?utf-8?B?L1V0VWlxcVRGeENkME1RVFpoN3pzdUZaT1Y4Z09xdjkxRXVXWWJ2VXE2QTBL?= =?utf-8?B?VWsxdWVZTTJVNEc0bkV2TXh4b0YrZzViNk9vOHQ5aHJYYVNFelZ1SmE5cGJE?= =?utf-8?B?ZHoxbDBUMUpaVU9GSkRlK0s3aTJtK0trWnprUmxGekFHYUdiV1p0djZjMUVO?= =?utf-8?B?QU80VFVQMmVycGp6WWJ2eUh6cTRkZHFYbm1tNExoZWdYdncxUGV1RTYrTFR2?= =?utf-8?B?Q2FlamdocEF0OWx0cm54SU1rbGx0ZUlXeDRGc0Q2Z2hqZXRVNDVzb2ZyOGc5?= =?utf-8?B?L2NkUFpuRUdGc3ZtS3dNcDZYZEtGREhsZ0JRTXJvMHMwQlBEWCtPQ3RadHNr?= =?utf-8?B?L3FuNmZtZUFuUEQ3RVZxVFBRTkplVkFHLzdZb2RseEtndVVsVE1maTdObktB?= =?utf-8?B?dVc4aFRpdFVXZW1uMU0zMG11bzRUVHFlbXFNbHBzSDBpZUZwSm1JdWJWQU9a?= =?utf-8?B?Q01IRUl2RnhBeklNQytRNXBoK2NMcThodFByRExWM2tUTjRFbllhR2dsSkNm?= =?utf-8?B?TmZKUDE1eVhnTmdXWXU4Y2pLL2E2a3dwNkhKY1RQUWFMYXZHWWpyNy81VmJI?= =?utf-8?B?YkZaMmxjRWFXek1LaGI3QVM2Yk1JaTJRd0pMaG9sTmJmaTBnN3grL011Y0xD?= =?utf-8?B?U2pHNWRVc3IrL1N6R2hlelQ2QTF0czNvUllxdUNoaXkwK25xbGk3Q0diVTdn?= =?utf-8?B?UHVMUDhtSk5QQVBwdjhxMG41WXowS1BUbllBQkozMk1VM1I2b1dHcjdhWFFI?= =?utf-8?B?dHhkK09MY0FuTGhkK3V2V2RQa2pqcmk3QjJpRXA2ZXM4MTlmU0JCRE9zdzN6?= =?utf-8?B?QXk3THo1N0JycTBOWlZ3OVR1K3c5bjRveU5oTDBReks2cG5DQ0djQUp1U1Z1?= =?utf-8?B?dFJVZ3J3S0hRUVBIUDB6amNkUldHdC96NGViK3YxSXV0SnhJWnRvNGxEdlNF?= =?utf-8?B?LzlFM01NZHl4T0crN2lnYi9NTG1EL0phTGROOUprejMwQm0xckJUTlEzVHJl?= =?utf-8?B?dHNuMXBzRG9uaHJzNDVwZDBkRzBGN01lS04yeXdESzZMcDFGdm83bU5acHBG?= =?utf-8?B?QmFIL29lckZxSkpCL0MzdHlWWExMa0t5MnNKTUMvTDhkVHpHNVdJL2htSUFs?= =?utf-8?B?bVQ3RzFHODlJc0tZYTJSbzlVTExxVy8yaFFSMUd1UmpSYTE2VjlSakd1amtG?= =?utf-8?B?MzdOUVVKaGo0UE1TQ3JXYzZOaFJUY0dBbmlIbkRHVUhLbVNUTVM3Yml3Mlda?= =?utf-8?B?M1BFMUVKUlVWM3RwQUdYNW5YVk5ZVWFOMUFQZ3JZM3o2OHNpMVV6SjA4a1NP?= =?utf-8?B?N3RvNERCNFFzRWN5MFFHQ0dZTytwVllia01wUUF3UHhBNWVHR0ZUS1J1ZEFC?= =?utf-8?B?M3UwUFZBQ3lpKytTN2pUalkwUm1nbVExeC9ZaUZiUENXRERGaUNJUzUrZ3pL?= =?utf-8?B?d1ZkdG52cytpRHRkZzJPL0RTOWVud2d6c2xDNWROTVpuNWRHMGMwckpiaE5S?= =?utf-8?B?dGdWZjVuZ0ltV1lTaVplZzVKdFBwNVhsa0R6Nzl3dzQxNDBnb2JYSmw3ZjhL?= =?utf-8?Q?ENAdDyKUHY9SrDmFqTCVs73A8?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5b0ada32-8c7a-44b0-ce0c-08daa200205a X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2022 09:51:05.4586 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: NHyX0ytwDWk84vuu7jV52GCZ4BgrDZvCqnsomZ5/FwaW+yTBBKg4/YqmOHklLc8/zCJ9754wdmyEUpKpE+rHcQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR04MB7209 X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1664445088669100001 Content-Type: text/plain; charset="utf-8" With the "inversion" of VCPUOP handling, processing arch-specific ones first, the forwarding of this sub-op from the (common) compat handler to (common) non-compat one did no longer have the intended effect. It now needs forwarding between the arch-specific handlers. Fixes: 8a96c0ea7999 ("xen: move do_vcpu_op() to arch specific code") Signed-off-by: Jan Beulich Reviewed-by: Roger Pau Monn=C3=A9 --- a/xen/arch/x86/x86_64/domain.c +++ b/xen/arch/x86/x86_64/domain.c @@ -58,6 +58,7 @@ compat_vcpu_op(int cmd, unsigned int vcp break; } =20 + case VCPUOP_send_nmi: case VCPUOP_get_physid: rc =3D do_vcpu_op(cmd, vcpuid, arg); break; --- a/xen/common/compat/domain.c +++ b/xen/common/compat/domain.c @@ -99,7 +99,6 @@ int compat_common_vcpu_op(int cmd, struc case VCPUOP_stop_periodic_timer: case VCPUOP_stop_singleshot_timer: case VCPUOP_register_vcpu_info: - case VCPUOP_send_nmi: rc =3D common_vcpu_op(cmd, v, arg); break; From nobody Sun May 19 00:42:47 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=suse.com); dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=2; a=rsa-sha256; t=1664445125; cv=pass; d=zohomail.com; s=zohoarc; b=V0Q2aJUo2z1U2ktOeEvfC4c/qDD+OHs2HSADK8PujFko43nydRFakVX1E8pDnG8cTeBwvunRdumKFzSqPfLSPmaQOY10D4Ph3/PlLspoeaVg6sn3uZvpA7EStsMQyqhvZ3NZEP3WLUIYaw1ayXwiUmtpuPVU0/dhQ632YOXMJ4U= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1664445125; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=8ZUSWYGYKpp/n4o39lEQC3Rdxp/5hH97CjYq0VBAQYI=; b=Vd6C0LV1fTLRBQ5IfQ8SdDTJLBmeDgcSrmbeCWoHj6sjqL5U8oA49KP2isKIK5Hn+FUEniQB8DXVyIXfzxF9q3jkf+AoAxGLwzXLGwCOvFJumFKED+8GskoNPc0gHSod5IwkJwWBwg+07OwU1cHlrwaIZGgUXVRql/k11LvpQ4s= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=suse.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1664445125254748.4269711827234; Thu, 29 Sep 2022 02:52:05 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.413564.657290 (Exim 4.92) (envelope-from ) id 1odqCo-0005UY-4m; Thu, 29 Sep 2022 09:51:46 +0000 Received: by outflank-mailman (output) from mailman id 413564.657290; Thu, 29 Sep 2022 09:51:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odqCn-0005UR-W5; Thu, 29 Sep 2022 09:51:45 +0000 Received: by outflank-mailman (input) for mailman id 413564; Thu, 29 Sep 2022 09:51:44 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odqCm-00052L-Ep for xen-devel@lists.xenproject.org; Thu, 29 Sep 2022 09:51:44 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2045.outbound.protection.outlook.com [40.107.20.45]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4e9cbeeb-3fdc-11ed-9374-c1cf23e5d27e; Thu, 29 Sep 2022 11:51:36 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PR3PR04MB7209.eurprd04.prod.outlook.com (2603:10a6:102:92::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.19; Thu, 29 Sep 2022 09:51:42 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.017; Thu, 29 Sep 2022 09:51:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4e9cbeeb-3fdc-11ed-9374-c1cf23e5d27e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Um44iDY80XmzcMlLtS6N8A0ynJTcsxm9wFfNc4LWo3RWm+/INPezGtBGjM7F45kpxJw4IvRNHW7I5XDhx5F+/vsHV33RfEVe38hbGRKZUUxSy20QirwOeYwbM2Dyg6hkI7RyXj7FKWH+tp56rZUWZ4wTzRlXlrz+Y/6peN5o0FExo3S80Fh368MSHqno2z9PeMO8zZz+idiNmMjEReQ5E9wD7cLphLvg4Um9R00bmzqQF+gx23GVxvgg/nvTyaOMBuUANMwK1spiO8pTg+2jZhQ/UE744wE+p2b8Mb3hd5O+eQW9FuntZo+2VMhjQOA9FVv9F5+eJdn9YcQzIgG//g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8ZUSWYGYKpp/n4o39lEQC3Rdxp/5hH97CjYq0VBAQYI=; b=ZOEXnSHTYYlljHNAOFp1HZw3fC+tb1hwHh8uqZ2P6IBZIlF7nREOJp1i50PDN/dqUH2YsU+HA/PPcguk0dnfIZw1pZPcoYUuHVloWzyWD8dZ6fruXT/5MFzb8LavI/rCRvCDOqnGsm5rxW0ix8FKipaPFePtU2Xwd1rNdiQgRDS/rp4dGYL0pQYzjSNYh8ApDn7llrjvCfIWsoQbGPYP5KP85aYir/RQbsdNr0kvNmgEO9pIQVjvgxGgF1kTxuLckOduJACnjmDwqeB4+8SZlp+GR8TWSk+0wf3tybxCdmTfFu8Ss1O6bIUA0ZGSfpbidSpQIPUAFIRMBKpeOotznA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8ZUSWYGYKpp/n4o39lEQC3Rdxp/5hH97CjYq0VBAQYI=; b=vgn2rS2nU+TPh441gnjZXXHd5YfP0wW6hMTPWaXA9krIkWu8tbrQx/TFn7i/nU3DP5IYOuhOILDsgV/oslCzP4qrgT92oVnZmHEDjFpAVhzM04zqYLoPPAjcELYT0ratAn9h3BjEEsvrqxpyjfZw64Sz1tR0AAs6vSblZTXcAMGNTs78SXcodCSQtzE8bIVvX4uaRmH7OwwMT3fGVP5kihbHGDoba8vXiyZ1mTowosHpsVN9w+rivlSqng/B0HFPXvZppAuTaKNqzt+COvtc5wsD7BQlFM+qcRCBArC7XSBwazAJEMkoga7/rmmuN0TXwy5kxnuIHWpv4/jUfM4Rmw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 29 Sep 2022 11:51:40 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: [PATCH 2/2][4.17?] x86: wire up VCPUOP_register_vcpu_time_memory_area for 32-bit guests Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Henry Wang References: <96adeb88-dcc4-5ca2-54a4-883058169dbb@suse.com> In-Reply-To: <96adeb88-dcc4-5ca2-54a4-883058169dbb@suse.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AS9PR06CA0266.eurprd06.prod.outlook.com (2603:10a6:20b:45f::15) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PR3PR04MB7209:EE_ X-MS-Office365-Filtering-Correlation-Id: 9fa5ab9c-e278-4e64-acb8-08daa2003620 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qCfAdH/giAUrQedouOK+Hlbi6dndLFkoVGz9lslt9VOMNh2FghCwFhiI5secQYP+0edhdcbtLplZ7l0BQDEBxWt3UjHcMMnrXdLvu0wN+1NolagJWFBEHmqI3RkvpOIsSl+DaKuDTgJCSpxWDkLVAwRO7izVOCvrYl402lc7s5ejPK2NhJMjgvmKnggmRK5jl7dIbfcXKyN0lSDoHrsllVQtKn/6phMjYzPQpLmw7cZrN2EgUgXdrYtsTfGzEJMJMonJof8YjedOWb1vj0uTfk87QQ4VY84Oq0M/zEzzcAyXpQ2iaDHusHC1Edf6E/J/zs3/X8GqpE09UtjNCxfLeITTSaEbQI7Ob6te5R21gASqhRTX9WgnKT0VUY7HrIj92O7um9Rix3eSUZ33ujUTIjwzoSXnsLfZpPY7BGYhK5Un0bWoUD8qrhEDBU1xdIhCfxXTMYc1773/9Tor33UAYaqRydG5gE5FVG0qpYoXcJUzG35Y4KZkyjTtE30qMYssMa9L3ib5sLZLwibEUYMdh8fcXsl8RpVWQzh0YFaS6rUSndLIJlSofTjcG461S/LAOGJAal410kaS97tBkCw91SmGymI26bKKhUoV0qPSWwYR06WdDemXb8c1F0VXIVy6lHFeTQhev/DXJ0zcDIWSZr/J+tD1squLqvomuCcBFaB1malLGv3qIW77QljrfpGuLT8UdI1WF4zkeTB8hHVSOshAUfvDv/DfGQ8ZJZBQkciz2ghs+wi7LjNcfj0hg+R7a6BMnigZ+c28v4R42eXjZz2aRJhmucIVI3VeWq1JU0Y= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(376002)(366004)(346002)(39860400002)(136003)(451199015)(31686004)(6486002)(316002)(54906003)(6916009)(66899015)(478600001)(83380400001)(31696002)(36756003)(2616005)(8936002)(66946007)(4326008)(8676002)(66556008)(66476007)(38100700002)(6506007)(186003)(2906002)(26005)(6512007)(41300700001)(5660300002)(86362001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dEJXd1hJdmJTTXF2R1lXZDMyT2VZUFlaY2I3ME13U0l5cjk5SjhIay9TV0k0?= =?utf-8?B?WkhqMjIyQzhYZ0QrVWhudVBneXhaQ3k5T2FvSFBpeWpSQmdRZHdjVzRDMUZm?= =?utf-8?B?TTJVZFRuM01EdW4yR1AwNU9Pczk0czJEWG1VVzlJTS93V3Z4WHFZN3dVVWV3?= =?utf-8?B?SHRBZExPTlFwZ1pVRmRFaWE0U2MrdSttU0xvVmg3aUFtR01lT3hKbForNDJ0?= =?utf-8?B?R09DL3JSR0tOVzlwb1RMa2YzQnlneEpjL3V3djFIVUxsUTF1bFpKZ1FaWkho?= =?utf-8?B?bURURTNZVmlCSU52VVFyY3RRa0ZVNWhoVStJdmYxUDRFV2RJOHJ6bmNReDE4?= =?utf-8?B?d1dTT1k2b00yaDlsLzhmb0xQdTJENGZhTWlaT0xIanE1c1hzbkVxRlBaQ3pq?= =?utf-8?B?QVBNQjg0b29NNDArTEFKQkhVcUk3MkU4TWNKOVdnVE9CYzY5YUtKdTB2dksx?= =?utf-8?B?ME9RZHBRMmxtK2hGUFA5N0cxZzJNUGNCMTFVdklRYWlpalFnbFR4R3pmZXhy?= =?utf-8?B?Nk5pQ2EyQmVKb29POC8vMFVoS3ZrWnh6MTZQSE5VZlo1OFBSblNTWk9mR0RX?= =?utf-8?B?WVJEZEdOVjZxR1FSTVNuMDhZaDFVREtGV2l0dnhML0dHYVpQWGpLL1ovbTZL?= =?utf-8?B?WW1QaS8xWWxFc3hkR3V0dTAvUHk0Y0QyTXdDWlhOc1Jyd3pUZmRqZGY4blUr?= =?utf-8?B?d0lxYUdWR1RYeDFWQnpKZU9OK1RYclczVDIwbjJSK3ptZXFLa2xzU2owMDB1?= =?utf-8?B?Wmd4TDNFQVYybVUyZGNjN1MxbFVGcjBONlVKL0xUY3ZzL1lzNnViZ2U5NVZS?= =?utf-8?B?WXpxeWZFZEhFTjRURFNGU3Eyc0R1NmRyMHh5eDFER0k4YWpMM3N2SGZOM2Nz?= =?utf-8?B?R0EwU0NIYWwzeWJPYUxRTE1HWENnM0J5eTkxN1NKSGpEOWF2cHdNTXFvQm1Z?= =?utf-8?B?T29ER3puQ1JuTnAvL01EUG1haXF0M1NqeU1aay8rZUFrbnYwekExbzVoVlB6?= =?utf-8?B?OFhnVmtEcFprVkJiQUtsQzhMOFRnWWhrWVdCdUJldzZqdmV4T3FxSDUxdVZ5?= =?utf-8?B?aHRMYVpZY2k2T0JPSkRMV0N0WmRrL2RPTmwweXUvaGREb3RkT0NseGNqdnQ3?= =?utf-8?B?RHJmMU4wWWZ4NS85YmNObDh6T05XSitkU0x4MEV5UHpGd21ZaGJESkllUHFz?= =?utf-8?B?Q09QODdnaXg2a2JIdDkwb1ArYzJzV01IUkJjeUE4amtGSXd5NEdpNnlEdjBW?= =?utf-8?B?dEkzT0J0Q01YUFlPRXUxNGNwNlRrdksrRlA0Mm1aNHlmMnA2bEE0bGR0Skow?= =?utf-8?B?d2VNTU9jZVV5S0EvdngxVkZKQWVRNWV3MFAxaUNlblI2RjVaYlMvMFI5SHpD?= =?utf-8?B?U0EvVVdPUnViTm5kT25SaWFiN200ZjVNRG1DcUU5RDBXdkQ0RGVrRXF1VU9C?= =?utf-8?B?UHNFTi9hTkpDS1R5aDNLaGRYQWxmdExma3ovS2w2VjBXekNFTktzc3U4T1VD?= =?utf-8?B?MFpOanppUzNxQ0ZaVjB1SHdZeU5TaUxBWWpCdm1jVldnaHBZY01FaE50eDFS?= =?utf-8?B?TnV5L3NxZEkvSEVjaUU1bEZhSU1EbWhTS0NSY3o5WGU4aXNPYVBSNEplQ1Np?= =?utf-8?B?cFNwN1VvdmNzdDVFSmtHV0prZzdPOFZsaFpDdjFwYUZrajVlSmp2TVRmRS91?= =?utf-8?B?TWp2N2Rra09pQVdURkpQN2ZXek5VcnZCR25CbUNvbFkxTzJvZVJMSThZTUZw?= =?utf-8?B?aXdIdDBZVHhVK1dteW03emR1OWQwZ29MaTBQYmpRcHdBdlBpQzV3SFVqb2x6?= =?utf-8?B?MWZ1Q0xXaDFPUDlWYU9WVU9ySmNLd091Z2YrTFNteDMzVHVBSjR0bU8zS3JG?= =?utf-8?B?MUcwWEdyT2IxWVBFMllGYWNoakZod3dHSXZLMmM2MTdvMGJBM29CU0VVTCtt?= =?utf-8?B?M253SXBiSzJGSkJFYmxxTUxoSzIwcS9qVVNnWVlSTU1Fd3MvSG9xSFh5TkJY?= =?utf-8?B?SXkxTURHMnVFUGNCZlhnQzFsRVprUGlRV1RtdUZ1WlRPaVpVbU1LWUhveHgv?= =?utf-8?B?czdvQ2ZROWhTS3pBcUZyKzBpMFpRbGRzdU1CeWZZYjI3VUlwQ2YwV2c5b0hv?= =?utf-8?Q?pqfBzJIcR+11fx17bVOBtFnfz?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9fa5ab9c-e278-4e64-acb8-08daa2003620 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2022 09:51:41.9875 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: fTFEhn9OmmkYkr65a06lMXQXXN9GlMobRnkGPwFbMmcjmxWBboH6jU0yPN13yOSYgGWneLD0UlHkmspAWH2JlA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR04MB7209 X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1664445127008100001 Content-Type: text/plain; charset="utf-8" Forever sinced its introduction VCPUOP_register_vcpu_time_memory_area was available only to native domains. Linux, for example, would attempt to use it irrespective of guest bitness (including in its so called PVHVM mode) as long as it finds XEN_PVCLOCK_TSC_STABLE_BIT set (which we set only for clocksource=3Dtsc, which in turn needs engaging via command line option). Fixes: a5d39947cb89 ("Allow guests to register secondary vcpu_time_info") Signed-off-by: Jan Beulich Acked-by: Roger Pau Monn=C3=A9 --- Is it actually correct for us to do cross-vCPU updates of the area here (and also in the native counterpart as well as for runstate area updates)? The virtual address may be valid for the given vCPU only, but may be mapped to something else on the current vCPU (yet we only deal with it not being mapped at all). Note how HVM code already calls update_vcpu_system_time() only when v =3D=3D current. I'm surprised by Linux not using the secondary area in a broader fashion. But I'm also surprised that they would only ever register an area for vCPU 0. --- a/xen/arch/x86/x86_64/domain.c +++ b/xen/arch/x86/x86_64/domain.c @@ -58,6 +58,26 @@ compat_vcpu_op(int cmd, unsigned int vcp break; } =20 + case VCPUOP_register_vcpu_time_memory_area: + { + struct compat_vcpu_register_time_memory_area area =3D { .addr.p = =3D 0 }; + + rc =3D -EFAULT; + if ( copy_from_guest(&area.addr.h, arg, 1) ) + break; + + if ( area.addr.h.c !=3D area.addr.p || + !compat_handle_okay(area.addr.h, 1) ) + break; + + rc =3D 0; + guest_from_compat_handle(v->arch.time_info_guest, area.addr.h); + + force_update_vcpu_system_time(v); + + break; + } + case VCPUOP_send_nmi: case VCPUOP_get_physid: rc =3D do_vcpu_op(cmd, vcpuid, arg);