[PATCH] x86/monitor: don't open-code hvm_has_set_descriptor_access_exiting()

Jan Beulich posted 1 patch 2 years, 3 months ago
Test gitlab-ci passed
Patches applied successfully (tree, apply log)
git fetch https://gitlab.com/xen-project/patchew/xen tags/patchew/925bb889-8048-e275-12e7-a4f5d31fb76d@suse.com
[PATCH] x86/monitor: don't open-code hvm_has_set_descriptor_access_exiting()
Posted by Jan Beulich 2 years, 3 months ago
Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/arch/x86/monitor.c
+++ b/xen/arch/x86/monitor.c
@@ -263,7 +263,7 @@ int arch_monitor_domctl_event(struct dom
         if ( unlikely(old_status == requested_status) )
             return -EEXIST;
 
-        if ( !hvm_funcs.set_descriptor_access_exiting )
+        if ( !hvm_has_set_descriptor_access_exiting() )
             return -EOPNOTSUPP;
 
         domain_pause(d);


Re: [PATCH] x86/monitor: don't open-code hvm_has_set_descriptor_access_exiting()
Posted by Alexandru Stefan ISAILA 2 years, 3 months ago

> On 30 Nov 2021, at 18:11, Jan Beulich <jbeulich@suse.com> wrote:
> 
> CAUTION: This email originated from outside of our organization. Do not click links or open attachments unless you recognize the sender and know the content is safe.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed by: Alexandru Isaila <aisaila@bitdefender.com>
> 
> --- a/xen/arch/x86/monitor.c
> +++ b/xen/arch/x86/monitor.c
> @@ -263,7 +263,7 @@ int arch_monitor_domctl_event(struct dom
>         if ( unlikely(old_status == requested_status) )
>             return -EEXIST;
> 
> -        if ( !hvm_funcs.set_descriptor_access_exiting )
> +        if ( !hvm_has_set_descriptor_access_exiting() )
>             return -EOPNOTSUPP;
> 
>         domain_pause(d);
> 

Re: [PATCH] x86/monitor: don't open-code hvm_has_set_descriptor_access_exiting()
Posted by Jan Beulich 2 years, 3 months ago
On 30.11.2021 17:11, Jan Beulich wrote:
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

May I ask for an ack (or otherwise) here please?

Thanks, Jan

> --- a/xen/arch/x86/monitor.c
> +++ b/xen/arch/x86/monitor.c
> @@ -263,7 +263,7 @@ int arch_monitor_domctl_event(struct dom
>          if ( unlikely(old_status == requested_status) )
>              return -EEXIST;
>  
> -        if ( !hvm_funcs.set_descriptor_access_exiting )
> +        if ( !hvm_has_set_descriptor_access_exiting() )
>              return -EOPNOTSUPP;
>  
>          domain_pause(d);
> 


Re: [PATCH] x86/monitor: don't open-code hvm_has_set_descriptor_access_exiting()
Posted by Andrew Cooper 2 years, 3 months ago
On 30/11/2021 16:11, Jan Beulich wrote:
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>