From nobody Thu Sep 3 07:03:33 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1787900406; cv=none; d=zohomail.com; s=zohoarc; b=OgfRiQKcraYNbzQO2i8uP5C5AfiiSnxyZu+YiHoz4rLMb7MCIaBWm8gvqnGLcgfFKq76fZ31nFByRjidSNRceBbY1VUfLFoQ9JH0B5HQhdun/WsikNZKZEpo0rTgfibrB1HCufrrgGxv7xpogvyYETzz93nGSIIJjzlA1ZNV2TQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1787900406; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=oqu+Q0osoQJYn18e0xy/OsR8FRgD25zg2JGzP482jGc=; b=RxqNv2MgDPwsdn+TaFeBt/v9lYGKk9q2P8GyoalWsvuhhOb92YNgOSxmL39EPdohW9u9Hw/ROK6smYCbcyIXZYTc66cUfrDAK4sKhhBCxUz3QYi6GjvIcVQNRljwEg1FJgJfYaTzXOW5jUmWedixRxO/mRL3l0C4usYTfwCnHlE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1787900406113431.6456366748788; Fri, 28 Aug 2026 00:00:06 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1401587.1637125 (Exim 4.92) (envelope-from ) id 1wzqZ0-0008EL-S4; Fri, 28 Aug 2026 06:59:46 +0000 Received: by outflank-mailman (output) from mailman id 1401587.1637125; Fri, 28 Aug 2026 06:59:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wzqZ0-0008EE-Nq; Fri, 28 Aug 2026 06:59:46 +0000 Received: by outflank-mailman (input) for mailman id 1401587; Fri, 28 Aug 2026 06:59:45 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wzqYz-0008Dy-HH for xen-devel@lists.xenproject.org; Fri, 28 Aug 2026 06:59:45 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wzqYx-00Dl7l-7j for xen-devel@lists.xenproject.org; Fri, 28 Aug 2026 08:59:43 +0200 Received: from [10.42.69.5] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a9131c7-2eae-0a2a0a5409dd-0a2a4505c7c2-42 for ; Fri, 28 Aug 2026 08:59:43 +0200 Received: from [209.85.128.43] (helo=mail-wm1-f43.google.com) by tlsNG-c201ff.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a9131df-4cb1-0a2a45050019-d155802bdd90-3 for ; Fri, 28 Aug 2026 08:59:43 +0200 Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-499ac87c92bso5231945e9.1 for ; Thu, 27 Aug 2026 23:59:43 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49b95013d06sm37120195e9.12.2026.08.27.23.59.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 27 Aug 2026 23:59:42 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Autocrypt:Content-Language:References:Cc:To:From:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1787900382; x=1788505182; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to:content-type; bh=oqu+Q0osoQJYn18e0xy/OsR8FRgD25zg2JGzP482jGc=; b=FORPWQkvISF9BysPN5UyXtabUu2tHizdVeYmS7cJDsu43rNCTnJ0PSik6pdLgHGkO4 pbXNHi9J9i3aEyfdC+h/OL50GoHIe0Hob/v7v1A08jZJxzGfpf2ob6orSMrbnfVvnxfd CvpY/BRPoQSrRI6RNbf/L9jp8CzLtIZQs/tYuJQE8U8rrTwmXwMV30p4btBh2/Tih/PK DC66XrKlPqyBfgjxY7Om+a7i0JM3YGEnpf50Zo10OHY9+5HHJYF/LvxI2NX4FAtt8wXF hjmySKLDtZM7y3TLYJx0PjcbwlTD+lhl2BRWcZNrmLI1vEzwLLlKDAODf5jQqf9ehNy7 Pb+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787900382; x=1788505182; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=oqu+Q0osoQJYn18e0xy/OsR8FRgD25zg2JGzP482jGc=; b=k2WIWYOkhe59DOQukh9fFXuy0APJKmD4gCdsTSKPgmh7UvqpeCJDYdE4jXoxEv2/Ro V5CPQngSNPBYIwM4Ab2PNJpUS8O67vUTJOdDruyRG5HI8/p7xm76F9oUHj6sP5odmclx hkXOUBscuMHxGJjriGbp3E85xgmRPEoeTU+0IbfTULxfAkrCTMU9/KL/Jg9DadymZzdX tONvegNaMBv4ixYLzVU5Ts8jQhrqNZioZ1JYh7KQCyk+ALLDakbhZJaPqA37ck+X8j4e qIql36bO/i9eCb/+k4ykgr443xK6qJ0IVp0eQK/hPeFiIT33gptelr0P8aRFI8wxXydQ ua4w== X-Gm-Message-State: AFuF++kR9QZergkf3MQRNlacGc/1mg9sLaKtZJXfB8ZnX/+JPozJP6xg Y0Fqp5iCgeKzOx//enfEpqiTkP3gb2Wb2o5idEeaOxXqqCMYmVhuG+kLoEMkfrghebYw9qn1DLb eXpuPfw== X-Gm-Gg: AR+sD10U/HS/EpDyWv/IbbdZU0Iyag09wEJtNwHmRxE2Ruxi43/QgG1L/zK3vlR+q29 Rxywe2faI14lBYLTJ6U1TsE8w2NGx8EsWMkr5deqCvcsPMlc+GkZimer0J3OxY9q2gPxha791Zb rgtCajHkQ/kxZWC745rSFnLQEDSysQ8k0OuEIZdcx3YTYH6vqJxfe/1k+MJnFw8Y4DSE3b1it0I pMW7zC7vx3Yz/m8b+Od5DOzxynQ+z4xTB7/ihtixWnXu3NEcV7nXe1a8g+Gb3/9OYACX9WcW0/e 7vRQ5ek6YVXZxfADkmN/2L33VAZPoJzfvQWtk7Drt58p9wOgwktymtZdQzHMWT2FOJcsFU53ub7 AHqspssff4eiUp1CwS/bBm5DWXKwgUgQ65mbcRYcZ+8AIU3z5y98o5931FirvzP5tVz9xohp6EM dhFTJtJz11lMZNCl75Td4HV/77+jrHkpHbu5VWDaCInvC3ryZfh2GZIVZEqQ4MukxJ6qx8c0CqB JqAAqrrBNPXUEtftovla/fmhk1YwuvRiKHHn6JKIOo82i6w9req X-Received: by 2002:a05:600c:83c3:b0:499:b01e:911c with SMTP id 5b1f17b1804b1-49b91c26535mr61714235e9.2.1787900382668; Thu, 27 Aug 2026 23:59:42 -0700 (PDT) Message-ID: <85c111a5-105c-4b8f-8b81-d7ec1d0f9436@suse.com> Date: Fri, 28 Aug 2026 08:59:41 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH 01/12] x86/IO-APIC: address Misra 2.1 rule violations From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Nicola Vetrini , Andrew Cooper , Teddy Astie , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= References: <90d0e3d6-2e12-43f1-815d-7936ca4c5fc6@suse.com> Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <90d0e3d6-2e12-43f1-815d-7936ca4c5fc6@suse.com> Content-Transfer-Encoding: quoted-printable X-purgate-ID: tlsNG-c201ff/1787900383-247132A1-121F5018/0/0 X-purgate-type: clean X-purgate-size: 3800 X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1787900409034158500 Content-Type: text/plain; charset="utf-8" In both functions cases 0..3 are handled, and a 2-bit mask is applied to the switch() expression. Therefore the default: cases are reported unreachable by Eclair. Subsume the "case 2" blocks each into the corresponding default ones. While there also drop all the pointless figure braces inside the various case blocks, inserting blank lines instead between them. No functional change. Signed-off-by: Jan Beulich Reviewed-by: Nicola Vetrini --- a/xen/arch/x86/io_apic.c +++ b/xen/arch/x86/io_apic.c @@ -804,66 +804,48 @@ static int __init MPBIOS_polarity(int id switch (mp_irqs[idx].mpc_irqflag & 3) { case 0: /* conforms, ie. bus-type dependent polarity */ - { switch (mp_bus_id_to_type[bus]) { case MP_BUS_ISA: /* ISA pin */ - { polarity =3D default_ISA_polarity(idx); break; - } + case MP_BUS_EISA: /* EISA pin */ - { polarity =3D default_EISA_polarity(idx); break; - } + case MP_BUS_PCI: /* PCI pin */ - { polarity =3D default_PCI_polarity(idx); break; - } + case MP_BUS_MCA: /* MCA pin */ - { polarity =3D default_MCA_polarity(idx); break; - } + case MP_BUS_NEC98: /* NEC 98 pin */ - { polarity =3D default_NEC98_polarity(idx); break; - } + default: - { printk(KERN_WARNING "broken BIOS!!\n"); polarity =3D 1; break; } - } break; - } + case 1: /* high active */ - { polarity =3D 0; break; - } - case 2: /* reserved */ - { - printk(KERN_WARNING "broken BIOS!!\n"); - polarity =3D 1; - break; - } + case 3: /* low active */ - { polarity =3D 1; break; - } - default: /* invalid */ - { + + default: /* reserved */ printk(KERN_WARNING "broken BIOS!!\n"); polarity =3D 1; break; } - } return polarity; } =20 @@ -878,66 +860,48 @@ static int MPBIOS_trigger(int idx) switch ((mp_irqs[idx].mpc_irqflag>>2) & 3) { case 0: /* conforms, ie. bus-type dependent */ - { switch (mp_bus_id_to_type[bus]) { case MP_BUS_ISA: /* ISA pin */ - { trigger =3D default_ISA_trigger(idx); break; - } + case MP_BUS_EISA: /* EISA pin */ - { trigger =3D default_EISA_trigger(idx); break; - } + case MP_BUS_PCI: /* PCI pin */ - { trigger =3D default_PCI_trigger(idx); break; - } + case MP_BUS_MCA: /* MCA pin */ - { trigger =3D default_MCA_trigger(idx); break; - } + case MP_BUS_NEC98: /* NEC 98 pin */ - { trigger =3D default_NEC98_trigger(idx); break; - } + default: - { printk(KERN_WARNING "broken BIOS!!\n"); trigger =3D 1; break; } - } break; - } + case 1: /* edge */ - { trigger =3D 0; break; - } - case 2: /* reserved */ - { - printk(KERN_WARNING "broken BIOS!!\n"); - trigger =3D 1; - break; - } + case 3: /* level */ - { trigger =3D 1; break; - } - default: /* invalid */ - { + + default: /* reserved */ printk(KERN_WARNING "broken BIOS!!\n"); trigger =3D 0; break; } - } return trigger; } From nobody Thu Sep 3 07:03:33 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1787900421; cv=none; d=zohomail.com; s=zohoarc; b=bmdAlcT5FG4Jq+uE/Q19ETCQjbrQ5NFc/HcdwMiM7VIo45phBcLgbKFPp12x2wuPVujrv4/pWovZRIjkI/cAmrjwqSCtV8nUFYU2qks7JUSiaOf2KJso0fBVBthOOn5cTtwqgdt4DqvIGMlIAyzEgVA0dlRCEtIuAaK2+rzjR9Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1787900421; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=glK8r2X1HDZrfZbkA9pEuF32dcf5dlBYeyJpXiQwXoQ=; b=ONrn3MJ50I+Bu3GIidtOxiUQSHmi/78FuRs7TAXw5Z4EGQLNM/kwDbLA3xmOrNYwIhDxNN6bZFavr75/mmeOjlYhqtK5Xb9ig8fZ5jxzCLafjvJPBSq4OaoaKyhQDc00XYxoU/wh5+Cn55F8QCUaYuPDLkbByuUtvElIQ7ORpP4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1787900421057573.7859998670591; Fri, 28 Aug 2026 00:00:21 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1401589.1637133 (Exim 4.92) (envelope-from ) id 1wzqZN-0001JZ-28; Fri, 28 Aug 2026 07:00:09 +0000 Received: by outflank-mailman (output) from mailman id 1401589.1637133; Fri, 28 Aug 2026 07:00:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wzqZM-0001JP-VG; Fri, 28 Aug 2026 07:00:08 +0000 Received: by outflank-mailman (input) for mailman id 1401589; Fri, 28 Aug 2026 07:00:07 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wzqZL-0001D7-Li for xen-devel@lists.xenproject.org; Fri, 28 Aug 2026 07:00:07 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wzqZL-002GzA-2A for xen-devel@lists.xenproject.org; Fri, 28 Aug 2026 09:00:07 +0200 Received: from [10.42.69.1] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a9131f4-bab6-0a2a0a5309dd-0a2a450180c6-28 for ; Fri, 28 Aug 2026 09:00:06 +0200 Received: from [209.85.128.44] (helo=mail-wm1-f44.google.com) by tlsNG-d62444.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a9131f6-5984-0a2a45010019-d155802cd5b9-3 for ; Fri, 28 Aug 2026 09:00:06 +0200 Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-490cf322ed0so5494255e9.1 for ; Fri, 28 Aug 2026 00:00:06 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49b94dd2517sm26945855e9.7.2026.08.28.00.00.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 28 Aug 2026 00:00:05 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Autocrypt:Content-Language:References:Cc:To:From:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1787900406; x=1788505206; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to:content-type; bh=glK8r2X1HDZrfZbkA9pEuF32dcf5dlBYeyJpXiQwXoQ=; b=XVyogzra0xEzrNKpQSj4tzdlahWELG75zxU+xCE/aeIiStWTF1x3sfjQFvnqJ12WP8 KOX+VeP5KC+WgWJtawBpYDNce2TGgR7g+mDD0nLokPMj69qMfp4GtQLpHOHRdF5MtsBs /18O/P+C/6Neel2D/kGRjLR08r1TaTlyx5EwQApj4o92chBzpNfDDWiYgAIHB28uVp45 XtaItEY0rREYakSjihiksr0UPwoOEK0v1ofJpSTSDK4vXaObjq1ERNPd0h8xpc5CAv06 ebsWYZEPMOX65cDeZ1MkEauYqVMYosAV6SLsiRp2KOJ0AHsqDSeqEGIq+wZLJ8O9wh5z S8FA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787900406; x=1788505206; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=glK8r2X1HDZrfZbkA9pEuF32dcf5dlBYeyJpXiQwXoQ=; b=OfKMeCDfn8FKto8U0Sn8mayQagTD3ZQW7vx7VYUsVBQ2V8snNFB9VBiyNVgXvd4gRW um2KzN+x8qa9rIxBfZf2hmvKzy1WC2Yh+Nji3UmBL7/tBFa9S8MiP0INMaj4gsEr+QAD ohL9FtMsxQYPvKZx9qS29sh10efB3t9+SeAlLu47izGfXUsf3VkVGlxSibVVo6UQYDYe A7CIoFRVqgy4dBBC0Db+j20cbQmVPw1WBy0aYb3vLrHdqjDz1kLRj+t1OklBl9blye+Q ZMkIp4U07qvO6XNWmH4v+SWxT9oa+bWPQQD8yNad5fh7k0FcFHK4lM0qDa53flJIFkuQ 9rhQ== X-Gm-Message-State: AFuF++nih3Yj7K9gPriljc6wEN32kP5U3CiAZr2lTZVz7Cg9UfpmAFaO veFWE0Iq//6UFLvufC/7SlSH45HD9DCKL/dVQ6xsbdTQd2yFlHwTbXJKeSbGiTctDimFWg+Syab UB/Etxw== X-Gm-Gg: AR+sD12xaw9owJjOSJ9NLQnE/8je/0FGdDt6fwCcwTgzKzhsRHOgfXQWGhQbtgcOIY2 g+PinZsLSYINnow3/C01bU5RO+y7YV7dGX3cdXuSKEpcBhY/dk/mhDi4XpFd01cjlntdkcloooz BUE2lncYG0cHH9JLqBLrNE1xb4ktT/b51Rs8hZ/Rz6aUiyKr23TeNUC4GX8AX+P1L6bgi7osp/I 0jn4oIQDxFTuneq4G0TC9XjzY2KvAH4/5jmB1HKTBxTAdNulzSoLf/4u+9sweI746v8IXfyAaM6 2xnIMTXYPB4WtAXCk1jvSHsjIPrrnMQ+jC+jN58hh9rslWapxZ2p2FnJ/45zGZ0YTlorEo7c3VG 933+SRZRIdfjqRgTFffw4mQi/YiaAqPwMBZtLih9mEgyNB5mfmqTAMuCbJ87KDQef79VeO2K75R WJMshuVcB2X7He0/UCnMdLXKro76WhyLc6NwkzqyqljEcT+AnZ462YCu7ViCgvTS73zb9thb1KR N0SgNo+1Q4r0bvINMy3342n22WX8KTU/Sh8+qemowmsDaR8pZ+z3my0iXKTI04= X-Received: by 2002:a05:600c:698c:b0:499:adb5:e7b2 with SMTP id 5b1f17b1804b1-49b91c3ddc7mr81316065e9.11.1787900406113; Fri, 28 Aug 2026 00:00:06 -0700 (PDT) Message-ID: <12b3dd09-7249-47cd-8c66-e0efc1611b14@suse.com> Date: Fri, 28 Aug 2026 09:00:04 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH 02/12] x86/mm: pagetable_dying() is HVM+SHADOW_PAGING only From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Nicola Vetrini , Andrew Cooper , Teddy Astie , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= References: <90d0e3d6-2e12-43f1-815d-7936ca4c5fc6@suse.com> Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <90d0e3d6-2e12-43f1-815d-7936ca4c5fc6@suse.com> Content-Transfer-Encoding: quoted-printable X-purgate-ID: tlsNG-d62444/1787900406-BF66C757-ECD8ED89/0/0 X-purgate-type: clean X-purgate-size: 1249 X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1787900423582154100 Content-Type: text/plain; charset="utf-8" The referenced commit didn't go far enough, leaving a Misra rule 2.1 (unreachable code) violation: The function lacks "noreturn" in this configuration. Since with SHADOW_PAGING=3Dn paging_mode_shadow() is compile- time-constant false, the compiler can DCE the call site. Hence we can avoid building the function itself altogether. No functional change. Fixes: 2fb2dee1ac62 ("x86/mm: pagetable_dying() is HVM-only") Signed-off-by: Jan Beulich --- a/xen/arch/x86/mm/paging.c +++ b/xen/arch/x86/mm/paging.c @@ -872,22 +872,18 @@ int paging_enable(struct domain *d, u32 } #endif =20 -#ifdef CONFIG_HVM +#if defined(CONFIG_HVM) && defined(CONFIG_SHADOW_PAGING) /* Called from the guest to indicate that a process is being torn down * and therefore its pagetables will soon be discarded */ void pagetable_dying(paddr_t gpa) { -#ifdef CONFIG_SHADOW_PAGING struct vcpu *curr =3D current; =20 ASSERT(paging_mode_shadow(curr->domain)); =20 curr->arch.paging.mode->shadow.pagetable_dying(gpa); -#else - BUG(); -#endif } -#endif /* CONFIG_HVM */ +#endif /* HVM && SHADOW_PAGING */ =20 /* Print paging-assistance info to the console */ void paging_dump_domain_info(struct domain *d) From nobody Thu Sep 3 07:03:33 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1787900480; cv=none; d=zohomail.com; s=zohoarc; b=hTAGKf3LMydaF4N1OPPmZT37fMl8vZL/N/DTQwTbv/VllYWu0S12jSp3hj93tw3ekw6e7T08zPQdP3XIv3Jk4HtnXAHC2mDVu/aH2UBuVK87u1xMvT+qiQeUuZ1dfJepSUaqyNEmyLKxn+PR9Anf6P4GHmTtiu1IcBY+5zVIhQ4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1787900480; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=+m1CwKzFOQuLY7Ed6bVSIiSUHeYqUHSn/bbUY8FHCIs=; b=m+P1TDCyKG0MfpzyUzNRKMLg3cY1h/EDNPjo0mj6wB2NCxFVnoXFPk8PiFTl+xCeRUidaCkoPRCVMTWpMIA2yvQQS2hUZZ9zbip53W/kh1Iv9dIY05cuk215xui7o5l/ILp7hnwLdthpZFJioWVbsDSdFcPBOr2K3M5uHUwQxRA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1787900480276851.4284790541842; Fri, 28 Aug 2026 00:01:20 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1401600.1637143 (Exim 4.92) (envelope-from ) id 1wzqaE-00028V-Dz; Fri, 28 Aug 2026 07:01:02 +0000 Received: by outflank-mailman (output) from mailman id 1401600.1637143; Fri, 28 Aug 2026 07:01:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wzqaE-00028O-AG; Fri, 28 Aug 2026 07:01:02 +0000 Received: by outflank-mailman (input) for mailman id 1401600; Fri, 28 Aug 2026 07:01:00 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wzqaC-00026e-F8 for xen-devel@lists.xenproject.org; Fri, 28 Aug 2026 07:01:00 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wzqaB-0015sL-S0 for xen-devel@lists.xenproject.org; Fri, 28 Aug 2026 09:00:59 +0200 Received: from [10.42.69.6] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a913227-e002-0a2a0a5209dd-0a2a450686f0-34 for ; Fri, 28 Aug 2026 09:00:59 +0200 Received: from [209.85.221.46] (helo=mail-wr1-f46.google.com) by tlsNG-16d1c6.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a91322b-195a-0a2a45060019-d155dd2ebd88-3 for ; Fri, 28 Aug 2026 09:00:59 +0200 Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-4798bea72f9so413302f8f.1 for ; Fri, 28 Aug 2026 00:00:59 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-482fbb20784sm1813269f8f.18.2026.08.28.00.00.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 28 Aug 2026 00:00:58 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Autocrypt:Content-Language:References:Cc:To:From:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1787900459; x=1788505259; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to:content-type; bh=+m1CwKzFOQuLY7Ed6bVSIiSUHeYqUHSn/bbUY8FHCIs=; b=G1c9/lU0+9C43z1fyx3cUGQTa9gsBJm6gYWUxnsieSvnrGPvJ6icb2F1itf0TpGOMS JswKz/gtz6WDFn3/sH2pfH+/3VwTvCd5nkiiY/ihz4CZBam6NBe3jL67Yjwxq6c8c9W5 S/hgs/gq6tU8BEwESP7vI4y/ywWwdJgiNrEQNYoz6cCENr6q33I+NkU7/417vNBPFHhX vv4JaCG+s04rEqogfY2pmRaIjn3ah650FSFYm7hmnebMXzQlLYNeFbImEA3nE1oswH/f e6ImMbcCZ4s4YIs1EPsdXD1CGfZom1WRLo/CuOzOPxT5KMbxf7K+SniuYHFrfJ+64/VE RKzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787900459; x=1788505259; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=+m1CwKzFOQuLY7Ed6bVSIiSUHeYqUHSn/bbUY8FHCIs=; b=RlExf13EF0TXjpL8RUsc6g3ob3H47naB8r/gHt0Ct5IhT4KM0nfBsISuqh2HBYKeOK +FA4pUZC/OZDlS+xbJfnFdjZsVpJfi0xVAR9FcFDpSQeEATd1tfgLteoSqGDT+TaNq2l Zv5XIZr5Wmqrh2wPK3HBRxkUBG/A4M8ET+VDqmLYso2UBZW35leE9MLeZKFeJH6elICJ oSbMngG9U9mMnPgSVYcNUMvuSSytm42sJIKyYf8b/9AH3EDI1obEbvCsucJyXwWcye2v EYtf/fA0HkDNQtG5y5XIr/uLR26KcKTPaPcPvbW/6Zu3+xRvVVlf11j9dvQacxXWe82r Zg0g== X-Gm-Message-State: AFuF++nH7ETiOW67yM3GjQDlX2Ox+V4qtgF66Bn3REVlrZ8GYDKrhDAd o93B5r0aNxYsgmV932ga1lPSChnJMQX6YxulQg+abMLlOXRBZihV/ubd+viyXvL9Q478fQSHi7J MT6M26A== X-Gm-Gg: AR+sD10JtYtwbGIu5yR+dtD8zcO7U9khy+q0aUbA85uiKwFWiWtpRybImJF811q0GfP jMew1NNGXrvaQyVkj1uu/uwljPIZ/l2Nji68UYjP4PSUJZmLmJGwwfavd/Gq7GpReUWZ+6p54ph tDZTkjGVS1TbMklL2EEKsWuuxT+BAhMIemdcQFWM0ZhsBCDxz6sAFbNWqfJkqfavTD2KPYCh3T/ csI86xyU6hHBkLdZAjE4aHxFemz2B6Qb67wFkepQ3WvqLdXiq38QOG1Tp2JKlBndgEq3Q7SffyM Zd6y8K85pyPNG8uS7n1zXWEyvT41gU1q1+AdjZdxKlLkLgSWz+dGq5S2gVvDZ4IEncDobmxnPTA i9V5ivGTt9RA9uid78BTytjTYFNUDO4LVX/lYGl9DybppIEGGFg6kkByca0yFTZHkDDwT0PCfZB NShRFFkN1w0nle42aPWRt3CEo6rBIIb/ptb6hgfpnvk8Yte2cslrB96nw4ulqkSvBVkQykBlV5E jyHKGULvPMlllqSTjybz1wQrRxPxov/l7b9/8DWyE3ftz2BomPkBeA5YFgs7cE= X-Received: by 2002:a05:600c:3b21:b0:498:952:e276 with SMTP id 5b1f17b1804b1-49b91c3f643mr61587435e9.8.1787900459184; Fri, 28 Aug 2026 00:00:59 -0700 (PDT) Message-ID: <9c4e5674-e79e-4623-b87c-ada690778ffa@suse.com> Date: Fri, 28 Aug 2026 09:00:57 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH 03/12] x86/shadow: eliminate unused forms of sh_map_and_validate_gle() From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Nicola Vetrini , Andrew Cooper , Teddy Astie , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Tim Deegan References: <90d0e3d6-2e12-43f1-815d-7936ca4c5fc6@suse.com> Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <90d0e3d6-2e12-43f1-815d-7936ca4c5fc6@suse.com> Content-Transfer-Encoding: quoted-printable X-purgate-ID: tlsNG-16d1c6/1787900459-F6C7777B-5CA53083/0/0 X-purgate-type: clean X-purgate-size: 2390 X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1787900482538154100 Content-Type: text/plain; charset="utf-8" The L2H, L3, and L4 forms only have GUEST_PAGING_LEVELS=3D4 call sites, i.e. their 2- and 3-level forms are unreachable, violating Misra rule 2.1. The L2H form additionally is unused (call site DCE-d) with PV32=3Dn. Signed-off-by: Jan Beulich --- a/xen/arch/x86/mm/shadow/multi.c +++ b/xen/arch/x86/mm/shadow/multi.c @@ -1789,35 +1789,30 @@ sh_map_and_validate(struct vcpu *v, mfn_ return result; } =20 +#if GUEST_PAGING_LEVELS >=3D 4 =20 int sh_map_and_validate_gl4e(struct vcpu *v, mfn_t gl4mfn, void *new_gl4p, u32 size) { -#if GUEST_PAGING_LEVELS >=3D 4 return sh_map_and_validate(v, gl4mfn, new_gl4p, size, SH_type_l4_shadow, shadow_l4_index, validate_gl4e); -#else // ! GUEST_PAGING_LEVELS >=3D 4 - BUG(); /* Called in wrong paging mode! */ -#endif } =20 int sh_map_and_validate_gl3e(struct vcpu *v, mfn_t gl3mfn, void *new_gl3p, u32 size) { -#if GUEST_PAGING_LEVELS >=3D 4 return sh_map_and_validate(v, gl3mfn, new_gl3p, size, SH_type_l3_shadow, shadow_l3_index, validate_gl3e); -#else // ! GUEST_PAGING_LEVELS >=3D 4 - BUG(); /* Called in wrong paging mode! */ -#endif } =20 +#endif /* GUEST_PAGING_LEVELS >=3D 4 */ + int sh_map_and_validate_gl2e(struct vcpu *v, mfn_t gl2mfn, void *new_gl2p, u32 size) @@ -1828,19 +1823,17 @@ sh_map_and_validate_gl2e(struct vcpu *v, validate_gl2e); } =20 +#if defined(CONFIG_PV32) && GUEST_PAGING_LEVELS >=3D 4 int sh_map_and_validate_gl2he(struct vcpu *v, mfn_t gl2mfn, void *new_gl2p, u32 size) { -#if GUEST_PAGING_LEVELS >=3D 4 && defined(CONFIG_PV32) return sh_map_and_validate(v, gl2mfn, new_gl2p, size, SH_type_l2h_shadow, shadow_l2_index, validate_gl2e); -#else /* Non-PAE guests don't have different kinds of l2 table */ - BUG(); /* Called in wrong paging mode! */ -#endif } +#endif /* CONFIG_PV32 && GUEST_PAGING_LEVELS >=3D 4 */ =20 int sh_map_and_validate_gl1e(struct vcpu *v, mfn_t gl1mfn, From nobody Thu Sep 3 07:03:33 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1787900523; cv=none; d=zohomail.com; s=zohoarc; b=CMsSaj+PF41tU4CatdcTrkKAILTdY+O0eP2zWv86C+zPxdHeHuIMP33G6Bv1ON1m7XZSC0BDRHa//tkHUDUpIf6jsV9sCN6QO794Woo8WcY4FAwOrqaFSLuewA5/XdWoUIDk1Rswj3kCgSdQVzCmC/xnXkLRpT56u1KgAl7Pq1k= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1787900523; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=PK9zMBufoVGWq6x8z32e+ws1C3h4VMgJkNucIWcX4mE=; b=bUnbPsLoqICVTvn/mz+a0RNUlNBlWxC8srog/GcWq8O7H7vHhKhoFAvZi+ad/4Y0Z7XMKH1bWsp5D7yTmnHJ5GVzhoj3iJRI7+Zh/rVe80IQeJ3tLML9qViaFCEWjKWb9tIv5oUEWFh8WOJKVqbySS9xSLstMz1gpfioC6sL33A= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1787900523083397.4841221191249; Fri, 28 Aug 2026 00:02:03 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1401607.1637151 (Exim 4.92) (envelope-from ) id 1wzqb1-0002iP-MU; Fri, 28 Aug 2026 07:01:51 +0000 Received: by outflank-mailman (output) from mailman id 1401607.1637151; Fri, 28 Aug 2026 07:01:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wzqb1-0002iI-Ic; Fri, 28 Aug 2026 07:01:51 +0000 Received: by outflank-mailman (input) for mailman id 1401607; Fri, 28 Aug 2026 07:01:51 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wzqb1-0002hv-23 for xen-devel@lists.xenproject.org; Fri, 28 Aug 2026 07:01:51 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wzqb0-00BS6p-Eq for xen-devel@lists.xenproject.org; Fri, 28 Aug 2026 09:01:50 +0200 Received: from [10.42.69.4] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a91324f-e002-0a2a0a5209dd-0a2a4504a508-40 for ; Fri, 28 Aug 2026 09:01:50 +0200 Received: from [209.85.221.43] (helo=mail-wr1-f43.google.com) by tlsNG-ebf023.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a91325e-b57f-0a2a45040019-d155dd2bb479-3 for ; Fri, 28 Aug 2026 09:01:50 +0200 Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-482c58a8683so494707f8f.0 for ; Fri, 28 Aug 2026 00:01:50 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-482fbb27936sm1770875f8f.28.2026.08.28.00.01.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 28 Aug 2026 00:01:49 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Autocrypt:Content-Language:References:Cc:To:From:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1787900510; x=1788505310; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to:content-type; bh=PK9zMBufoVGWq6x8z32e+ws1C3h4VMgJkNucIWcX4mE=; b=FjJle4PiBWVqSV0EfiSFSwxt9px+/XgF6MhLqMF1/v3AaJZf0qbzJsGBw0FeBNJOLH 7PyB4ZhprIlO8lHtjS7QervrjvK6xkeuC/RTqdN/N7N2JzAvcpFwSFbDyRo05ItY7303 sGVlIhq2Hv35BPZM9sp4noJeVFwusZe4FNDkgqSDo7rYDfyVb6vNx+pkHU9DSSwW6wB3 RbzSumN4mh7LiVtNY5sXb6P2FhyqlHNP7FhfVWRy3LBNv6FM9M7ChFiP5nhY4Uc5Em4+ nikBvAeQIkq51GIq/y6908k/doo21NAiqg8U8v0bngJ7B8k9HTD+8arXjEvnf/4wKAPh FFwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787900510; x=1788505310; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=PK9zMBufoVGWq6x8z32e+ws1C3h4VMgJkNucIWcX4mE=; b=N3lEeQPXczeMAG1pTJjEpPBBh0nlbsEFYF8gzDEqHO6zzDa3hu3Pv6Cl0MpFnyvIlz v5FDpuA2UQQcaQGgzr0h+rr96ApjfU1tubza+2ICjvdVcpZL4XokRb3D5hbpoBZLHzM3 3axR4Eha8ZMZ1qQoZCHR+bKlKkrTjFM3LQ4u6t94vTwqDOjLu1IzzrJuWQhykPtkQ05g d9+45NYWrfN6zyfAkoPVtaw8h60to1hVMm6pttBxeLOlgtzGgqF+au8P9SL11kDPTAB2 aD818ZhhJE0LTbRbZlPIWb+mbFhXOLgROX1TuRL2t7dK1K6rn7NtWDhR/RAxoANN6EUB 1IGg== X-Gm-Message-State: AFuF++lEcSQ4wz36ar9Uc6bzbboqbxrX/Whtb24BShM5I/gopXcIylDG dfAGQgaGpRcHJD0iyvhxQbvx8eKpHePaU8KbB6EEs4jhnoThcpO9xn5xciFFbdEK0GdQ9EgoJBk FbOu/cA== X-Gm-Gg: AR+sD108FDDm1h41feWvyHZ9giD0qjG7PrO/aq1DOBGXq4vJO/0ozjidQRZ65orh5T5 HWwPnJMQAd+wjhZyJPO8Ptek9UVCrPQvSN4tJJpl35FJEQHExugk18rKlqJO1eEyHuDyhp2Xjef ZH6DX22q6rhVq4pgiJceiAGIH0XSco4LiNTvB2ApADYBfcvufantlXdh78gOADR5WJIEfuIyYi7 9BRYsHkOphjUHlL+oewcHUAIKBx3qACc4ZbR3DgTceSZfKp5noM6ssatO0RzeqPhZda2ddrUFsW HZnSknvBtG4IOfFemTy9zolyCuEbpqX+2Xoq9J8LBE0vQSznWier4xOn5Bnx0kUPJ+643e2JB10 Cus/gcpgt/KzYacN6ap3fOVYqabDsFbopUVdQuf418Z/EhCOM7YUHvndtPQ4xMWK62OdB5+MLfT B3kmxgoGMnVI1G1+aiNOgc3+7ksHq7pyaP6F8D+/VQjqW5SJw/c/e20etIslg7qzA/e6ZNDW+86 WRwgzppBvh3JkYkew8tP/vArFWFGIxk0lTa2E43i+q8aEIpd+4nrVl6ajWJIwc= X-Received: by 2002:a05:6000:2904:b0:482:ea9b:962c with SMTP id ffacd0b85a97d-482f79c91e1mr7402311f8f.22.1787900509801; Fri, 28 Aug 2026 00:01:49 -0700 (PDT) Message-ID: Date: Fri, 28 Aug 2026 09:01:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH 04/12] x86: add noreturn in a few more places From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Nicola Vetrini , Andrew Cooper , Teddy Astie , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= References: <90d0e3d6-2e12-43f1-815d-7936ca4c5fc6@suse.com> Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <90d0e3d6-2e12-43f1-815d-7936ca4c5fc6@suse.com> Content-Transfer-Encoding: quoted-printable X-purgate-ID: tlsNG-ebf023/1787900510-502E4B50-9F64A953/0/0 X-purgate-type: clean X-purgate-size: 4001 X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1787900525375154100 Content-Type: text/plain; charset="utf-8" start_secondary(), do_double_fault(), play_dead(), and tboot_s3_error() never return, so would better be annotated anyway. The do_double_fault() change needs accompanying by adjustments to entry_from_{pv,xen}(), as Eclair then deems the "return" there as unreachable. context_switch() and continue_running() are odd: We can't (unconditionally) add noreturn to their declarations, as Arm's variants do return. Put the attribute on x86'es definitions instead (the use of unreachable() in reset_stack_and_call_ind() allows the compiler to figure that out itself, but Eclair wants the annotation in addition). Signed-off-by: Jan Beulich Reviewed-by: Nicola Vetrini --- entry_from_pv() wants the annotation only when PV=3Dn, yet once added gcc then warns about "return" being used in a "noreturn" function. Is there any other approach to address this besides adding #ifdef inside the function (i.e. replacing the !IS_ENABLED(CONFIG_PV) check that's there)? --- a/xen/arch/x86/domain.c +++ b/xen/arch/x86/domain.c @@ -2163,7 +2163,7 @@ static void __context_switch(void) per_cpu(curr_vcpu, cpu) =3D n; } =20 -void context_switch(struct vcpu *prev, struct vcpu *next) +void noreturn context_switch(struct vcpu *prev, struct vcpu *next) { unsigned int cpu =3D smp_processor_id(); struct cpu_info *info =3D get_cpu_info(); @@ -2240,7 +2240,7 @@ void context_switch(struct vcpu *prev, s reset_stack_and_call_ind(nextd->arch.ctxt_switch->tail); } =20 -void continue_running(struct vcpu *same) +void noreturn continue_running(struct vcpu *same) { reset_stack_and_call_ind(same->domain->arch.ctxt_switch->tail); } --- a/xen/arch/x86/include/asm/cpuidle.h +++ b/xen/arch/x86/include/asm/cpuidle.h @@ -26,7 +26,7 @@ static inline int mwait_idle_init(struct int cpuidle_init_cpu(unsigned int cpu); void cf_check default_dead_idle(void); void cf_check acpi_dead_idle(void); -void play_dead(void); +void noreturn play_dead(void); void trace_exit_reason(u32 *irq_traced); void update_idle_stats(struct acpi_processor_power *power, struct acpi_processor_cx *cx, --- a/xen/arch/x86/include/asm/tboot.h +++ b/xen/arch/x86/include/asm/tboot.h @@ -126,7 +126,7 @@ int tboot_in_measured_env(void); int tboot_protect_mem_regions(void); int cf_check tboot_parse_dmar_table(acpi_table_handler dmar_handler); int tboot_s3_resume(void); -void tboot_s3_error(int error); +void noreturn tboot_s3_error(int error); int tboot_wake_ap(int apicid, unsigned long sipi_vec); #else static inline void tboot_probe(void) {} --- a/xen/arch/x86/smpboot.c +++ b/xen/arch/x86/smpboot.c @@ -326,7 +326,7 @@ static void set_cpu_sibling_map(unsigned } } =20 -void asmlinkage start_secondary(void) +void asmlinkage noreturn start_secondary(void) { struct cpu_info *info =3D get_cpu_info(); unsigned int cpu =3D smp_processor_id(); --- a/xen/arch/x86/traps.c +++ b/xen/arch/x86/traps.c @@ -1080,7 +1080,7 @@ const char *vector_name(unsigned int vec return (vec < ARRAY_SIZE(names) && names[vec][0]) ? names[vec] : "???"; } =20 -void asmlinkage do_double_fault(struct cpu_user_regs *regs) +void asmlinkage noreturn do_double_fault(struct cpu_user_regs *regs) { unsigned int cpu; struct extra_state state; @@ -2304,7 +2304,7 @@ void asmlinkage entry_from_pv(struct cpu case X86_ET_HW_EXC: switch ( vec ) { - case X86_EXC_DF: return do_double_fault(regs); + case X86_EXC_DF: do_double_fault(regs); /* noreturn */ case X86_EXC_MC: return do_machine_check(regs); } break; @@ -2615,7 +2615,7 @@ void asmlinkage entry_from_xen(struct cp case X86_ET_HW_EXC: switch ( regs->fred_ss.vector ) { - case X86_EXC_DF: return do_double_fault(regs); + case X86_EXC_DF: do_double_fault(regs); /* noreturn */ case X86_EXC_MC: return do_machine_check(regs); } break; From nobody Thu Sep 3 07:03:33 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1787900561; cv=none; d=zohomail.com; s=zohoarc; b=D7wVv6w8p49UHVFJyKxPfvyA8yx9DMYFotB7WxCOWl7e5LmJHWtFRXIWuNVrGU16QBAaJV4BTmvTgN/74ND9PRRfnpOMUggFENaUE9zFJMXZAq2EtR/AM+sls4Sm1MkygaoIAbKV7Sk92phICQ3Oxa8VlMOGgA3x4SYkk1Vs/oU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1787900561; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=I1byslbOG0CeFzmY2s3/l4wrq9b0PgsYDl6emmZmMS4=; b=BeB1JmcIdj9+4WleNuBmQTfXB+c6WcwN9pKxEU+WnNboK+U/qCKdcdjZEni3+hr8/91K49SzMdLFzfgoozletbfxwvlHCKSgTzaUnctEnSYgN4k/9CK+bNGiJ9nonTGR5hSr+Qgwr+qEe8cGLkHfN3wM2gOWgj4ADNIBb9oCNyk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1787900561715394.8210580373134; Fri, 28 Aug 2026 00:02:41 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1401612.1637159 (Exim 4.92) (envelope-from ) id 1wzqbV-0003H0-Td; Fri, 28 Aug 2026 07:02:21 +0000 Received: by outflank-mailman (output) from mailman id 1401612.1637159; Fri, 28 Aug 2026 07:02:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wzqbV-0003Gs-QU; Fri, 28 Aug 2026 07:02:21 +0000 Received: by outflank-mailman (input) for mailman id 1401612; Fri, 28 Aug 2026 07:02:20 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wzqbU-0003FW-Rb for xen-devel@lists.xenproject.org; Fri, 28 Aug 2026 07:02:20 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wzqbU-009FjH-7t for xen-devel@lists.xenproject.org; Fri, 28 Aug 2026 09:02:20 +0200 Received: from [10.42.69.5] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a913275-8faa-0a2a0a5109dd-0a2a4505ae48-40 for ; Fri, 28 Aug 2026 09:02:20 +0200 Received: from [209.85.128.46] (helo=mail-wm1-f46.google.com) by tlsNG-c201ff.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a91327c-4cb1-0a2a45050019-d155802eb505-3 for ; Fri, 28 Aug 2026 09:02:20 +0200 Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-49557167508so5866045e9.1 for ; Fri, 28 Aug 2026 00:02:20 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49b94dcb3d9sm28839595e9.5.2026.08.28.00.02.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 28 Aug 2026 00:02:19 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Autocrypt:Content-Language:References:Cc:To:From:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1787900540; x=1788505340; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to:content-type; bh=I1byslbOG0CeFzmY2s3/l4wrq9b0PgsYDl6emmZmMS4=; b=LY/nj0veQReLQo8MGqj+h2PwS4e/15ZjgRJyHiiL/tOVc/R99bMLaIePRh70YQsd6u qqVZyV7hZB8Nw6EgkywFNh2eL8VRcTBbwTCCJUW2TCQxciW5CO7Hj6vOAf+YgbDqWPNj 4SQ/Qmycjq551RmCW/kR2DtN6VJwM/8/0UzJdOC1PhFh2uKIUV2R0wDrlcDpBQi9QzUH IkQ+AKnzQxuNU6xw30sLUXFMJa/frLZ+zD5AWycE4giEk5H1rw+B7a4kqAIQvYfy7ltA QQ8uOEmn8jTKEJhWOgM5wZrKf98W7Bh17eVErEtSTuJfT9PdMeF0J5J4+jyo6mS1Sn5I w3QQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787900540; x=1788505340; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=I1byslbOG0CeFzmY2s3/l4wrq9b0PgsYDl6emmZmMS4=; b=Ij3Mit3I+ivCAbuusmjB6zH4zcjSF0HaLsWZJ0b5ZANksEeI2wWctsKDwRHuyv5MhH 088uzCjPngiHFayAdiolM2tGXw+E/4HhPwZY0pyvD/eEAzsW3f4mqm0vBukhyEbiAqPN NQWj8nhXu/DUlmVyzP52GwkNJNA/fDR30V0RWyEZc7rw/xVFwJgMjDnL0dQt3zE1Er/n HyIsSzk6alLt+mVpTn1ky96dFTmQhhrJX01djQ6xl/5yov9oBNgwI46264DnZMcg+Pfk CemctUz5w6ZxY9fMaT1cMsn37eutv4Jx+cQob9njiZ4Q7ecuHz/wbk5DkdRoNgN7/V+H N1tw== X-Gm-Message-State: AFuF++kY1X1ZsJf2pkOmyxx39dDMil1pYJERdVCp+MgHWkiBt5AF1/Rc J0l3X7tQ98OCP2HCZPVnkFWVTo4vIuvmNnVU3To+NGuCN5ICLkF5d09HzHuH483tG8thWyI8u1+ s3W7mDg== X-Gm-Gg: AR+sD1042K9HyDPTVpyotoKACXogAT95s0rt3fcPkCq2Tk/eNBEgcVnMnfb6HgrAreu b/AQq/BDQAjscEomfB/kxzh4dW0iXAHtvSGQxZCCFgepT/0XY0YQpBXGdvJ3P9beo+xVH+eOTTO xLzx7IKfeDpzZ0Xv/bHzQLP6VxV+NhXEdf8v3qo3Mg+sxrUx/yvEspYEjPLyarSTpNku40xhUJ2 v/ZPmNZ5Dzv2ST86NeS41Ig+uJ2kPOlLwTv6r2GYtM80Vzz1ZzFPsiaW1CijEYteFVRz1hWYvYr VxMetsW6jCPJPNElsP95eAMhcfKt6/R+gXZ2ALoDufZDg8TjgszNnoI/yBoVphc2izBbnlG/F4H INi3ebMqBEzIUiMD0A75Kl8ale6EiwMhJf2BlzGTTJUa+PrXhhEdjwUlFU3Dr7CAIo5x/bCeAZI ufpWh7CRh7l9TFpV1x83HFmgHhovMvtt7QPkxuuqJwiLBUkUPMEuTodNF47SDOfeAZ54YZTzWNd FstgQffYfkpkz/IEOUqpF5gZvlNwnL7hvtPE22HQuwhSmQuS4X3ar8/7M4OzsE= X-Received: by 2002:a05:600c:8486:b0:499:dbba:9859 with SMTP id 5b1f17b1804b1-49b91c27436mr64024755e9.5.1787900539660; Fri, 28 Aug 2026 00:02:19 -0700 (PDT) Message-ID: <96de425a-29f7-4759-8466-b72bbe40b90b@suse.com> Date: Fri, 28 Aug 2026 09:02:18 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH 05/12] x86/crash: address Misra 2.1 rule violation From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Nicola Vetrini , Andrew Cooper , Teddy Astie , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= References: <90d0e3d6-2e12-43f1-815d-7936ca4c5fc6@suse.com> Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <90d0e3d6-2e12-43f1-815d-7936ca4c5fc6@suse.com> Content-Transfer-Encoding: quoted-printable X-purgate-ID: tlsNG-c201ff/1787900540-72AB72A1-FF57D71F/0/0 X-purgate-type: clean X-purgate-size: 438 X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1787900563512154100 Content-Type: text/plain; charset="utf-8" The use of unreachable(), when unreachability is visible to Eclair (and compilers), is deemed a violation. Drop the redundant statement. No functional change. Signed-off-by: Jan Beulich --- a/xen/arch/x86/crash.c +++ b/xen/arch/x86/crash.c @@ -118,8 +118,6 @@ static int cf_check do_nmi_crash( =20 for ( ; ; ) halt(); - - unreachable(); } =20 static void nmi_shootdown_cpus(void) From nobody Thu Sep 3 07:03:33 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1787900592; cv=none; d=zohomail.com; s=zohoarc; b=LbnfQtlVcEPzwfQwOCo6azT1A3Z5SMznCVz5jcqZE1g3doWn8PTqVovWJZmnCHKPovhJ3ssXdpvlTMK/bd70tic5AmG6SUWuYEjux1bTWncI+cu2wrPeCNIC7kmlsfrtrXk568XuPuowejhmQbfJp0Qm4za6Rx49AJSTXq65/VM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1787900592; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=AAGR8QqK5GSSuw5IrkPcVKUO4dAwD5cpH9pk+9rg2/s=; b=IN75OJQ0xeAaGTXS6cNyeVIrIzIZuJUjOd2PXztvqC4E48wugL8A5Jk6EfZwmZim+5KTlGs64IUnjPddVfuVyOC0QYOX4OxR35Z/JJcqyfyXD18D8jl1GpLpeFyP3hMl5YyHES4dCSbPakAT8AL4GzwQWoLxLjAYssBDd6Y5yS8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1787900592352595.8339384512227; Fri, 28 Aug 2026 00:03:12 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1401618.1637169 (Exim 4.92) (envelope-from ) id 1wzqc5-0003nJ-5q; Fri, 28 Aug 2026 07:02:57 +0000 Received: by outflank-mailman (output) from mailman id 1401618.1637169; Fri, 28 Aug 2026 07:02:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wzqc5-0003nC-2k; Fri, 28 Aug 2026 07:02:57 +0000 Received: by outflank-mailman (input) for mailman id 1401618; Fri, 28 Aug 2026 07:02:56 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wzqc4-0003n4-CX for xen-devel@lists.xenproject.org; Fri, 28 Aug 2026 07:02:56 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wzqc3-002Hwb-PV for xen-devel@lists.xenproject.org; Fri, 28 Aug 2026 09:02:55 +0200 Received: from [10.42.69.3] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a91329c-bab6-0a2a0a5309dd-0a2a4503db8a-12 for ; Fri, 28 Aug 2026 09:02:55 +0200 Received: from [209.85.128.53] (helo=mail-wm1-f53.google.com) by tlsNG-33051d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a91329f-fae8-0a2a45030019-d1558035b502-3 for ; Fri, 28 Aug 2026 09:02:55 +0200 Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-49557167508so5870635e9.1 for ; Fri, 28 Aug 2026 00:02:55 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49b91c5790csm36127975e9.0.2026.08.28.00.02.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 28 Aug 2026 00:02:54 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Autocrypt:Content-Language:References:Cc:To:From:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1787900575; x=1788505375; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to:content-type; bh=AAGR8QqK5GSSuw5IrkPcVKUO4dAwD5cpH9pk+9rg2/s=; b=an0avKRxzuQ0vOD8sA/X6TH89s8aa3G4HE5TjDltZ1X+gdmuhE4SNL2Y3OCMq9Drlb 99+bGxY9lTYKanEa68ASq1yYZZtfSG0mEvCLrWLfDxKqUXEVZRjgeghAgc6M1z0VIGjU 9U2S5yTW297KO9PucED/QSqcVD1ZTYCeDYX/bfVvw/MC++0wfvoYKkd+gj4gngxU+ht+ li5A8Jk2LzhNwFCuEERniI44chuOZL1qUa2LRipilQk3RhCpwnU+XiaWCJCL8bGHfyBd KNa2epiuY6Jy3Mfo3H/9YkoSey+WFnQP47Ocf9q7qmCdbNSnRN/S2p3l1/XVzM5snMiK LLOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787900575; x=1788505375; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=AAGR8QqK5GSSuw5IrkPcVKUO4dAwD5cpH9pk+9rg2/s=; b=pHzleCSsEJ76a2t0Gwk1I/ZKZtWLFAtG9Vik1AgbV700yPdWlw549inLhxoF37zbEF q50PzqErbgzIinFs3FrHZVQmn7JyjHsi9b5A7rWhcsr0X1T0P7y9ealPn/7XW1r05e3G I5UrbZwAJ7nrhq+ApCVM/kfXA3BZs1G6UaiF40vbpf9V+zep5BCdRiRMOn6SNlCTW2/Z dVHXVfe++5XGmjI+aLd7AzQGK7AZNVBeqBzfUAD1WASyZgayKQICrrYzwHnBwU7EK8if LzOzHGEXfqZUXSi/TiundxNcRZi9eNcp/LMTfALJqOuCB+QIYW/Cusur7i5nVajHsWJZ 58OA== X-Gm-Message-State: AFuF++nupJ4cL2TgkP9E7DR1qt+b0XHPeA/p3IN1iUt9nYZ1VgkDaCOz bteGBvBllqzWt5N8qIJgSqxacj1xNBMfMmedOxtFV0ZBdLLHdzb4pvnokN+LGSfX882/5OFoo3K rA9EpNA== X-Gm-Gg: AR+sD10JP1KLNCoDJYhj5ReVxUJl8uNJYkR8KeF6WciI4ZGjHC1A6ABdznvLST2IIwY yi99xpo1LA7nYZAYIgiKtwhVGMoTnrormFxhvoeKFE8qtqFT147yIuc1wxGz1YXbkKDJ4Tvhr0Y ECh32+rrqeWMG6Iii7jbyEJKdI53Y+bzpAex6oSHPDy/nte0Dq3PBLxF2QNUWBJ3kX9VcDdxKMH lHlO/m9l6bBVuxLYkgc1gT6gIMvzi+cdoiFibEc+qM0u2hZnbbpEYaao/RIBb7bOsFzq27Ku/LL xw8DWqG/uZo9g1jgDUYsLO3eBbl4O3LiqxHJvHViMhWLT+2RpnVnevxtF7gW1S1QK1eLH0E5xub cyv7K9tTfCvjAA9NXw+PBBlgkzgw+siZx0a3gK7RQU4q9r7Q6YkVuu3MytR694gmJK8yPmHih+H OfW5dt9T40FpCEzH7Q6MRGTcAK1xnH26x8ObI0TTHwJnWcxqXPoYQlPvTGM1h3DsAsfLy2b5Vu9 1QqVKjHz1IvBrDI5h2HdrndRSgT0sKmgxEfBjRtW0gBQFqXafzCogpZFeuKfEg= X-Received: by 2002:a05:600c:4452:b0:493:f140:c3fb with SMTP id 5b1f17b1804b1-49b91c2e42bmr63460935e9.7.1787900575240; Fri, 28 Aug 2026 00:02:55 -0700 (PDT) Message-ID: <26fe76ce-db8f-4641-aeea-667fb6ee3932@suse.com> Date: Fri, 28 Aug 2026 09:02:53 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH 06/12] kexec: machine_reboot_kexec() doesn't return From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Nicola Vetrini , Andrew Cooper References: <90d0e3d6-2e12-43f1-815d-7936ca4c5fc6@suse.com> Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <90d0e3d6-2e12-43f1-815d-7936ca4c5fc6@suse.com> Content-Transfer-Encoding: quoted-printable X-purgate-ID: tlsNG-33051d/1787900575-6E8CD4E9-D9DE6AAF/0/0 X-purgate-type: clean X-purgate-size: 1278 X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1787900594071158500 Content-Type: text/plain; charset="utf-8" Mark it as such, and then remove the code following at its sole call site, for Eclair flagging that as a Misra rule 2.1 (unreachable code) violation. Signed-off-by: Jan Beulich Reviewed-by: Nicola Vetrini --- a/xen/common/kexec.c +++ b/xen/common/kexec.c @@ -401,7 +401,7 @@ void kexec_crash(enum crash_reason reaso BUG(); } =20 -static long cf_check kexec_reboot(void *_image) +static long noreturn cf_check kexec_reboot(void *_image) { struct kexec_image *image =3D _image; =20 @@ -409,9 +409,6 @@ static long cf_check kexec_reboot(void * =20 kexec_common_shutdown(); machine_reboot_kexec(image); - - BUG(); - return 0; } =20 static void cf_check do_crashdump_trigger(unsigned char key) --- a/xen/include/xen/kexec.h +++ b/xen/include/xen/kexec.h @@ -48,7 +48,7 @@ int machine_kexec_add_page(struct kexec_ int machine_kexec_load(struct kexec_image *image); void machine_kexec_unload(struct kexec_image *image); void machine_kexec_reserved(xen_kexec_reserve_t *reservation); -void machine_reboot_kexec(struct kexec_image *image); +void noreturn machine_reboot_kexec(struct kexec_image *image); void machine_kexec(struct kexec_image *image); void kexec_crash(enum crash_reason reason); void kexec_crash_save_cpu(void); From nobody Thu Sep 3 07:03:33 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1787900639; cv=none; d=zohomail.com; s=zohoarc; b=nktg1qQu1BB13uEaq2lHcHRJbMHe6mY2psd4QTCLsn+Hrhg7bnswH/KAqfUeDZQzRvF9TrQJzsQGwsTbIME/lTz8ht1XNfl9/9o0mkVy3LPfnjVjvrfWezB3gocw5bVyiXbympvQ6kvE2+BsvJjEBWI15syVBccC3D9rRtAoZW0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1787900639; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=xgIaJ540DVn9gMAwDjHqVBhyS2+4Ub8sOGYDzk1OFhQ=; b=YQs0RxPRfm2xGo+GxFgCLfDofRokwJ9da5axjw3+lF/rzNEtxkS7swF2cywn5cwJR0fBsjyew2IdeC1Up0tXx0zTvNikCU+4dC98BgWU4IjuIszvFhP/6RzDFSZ88F6WCRggSnWXHdqUBzrXfTm03mGT05HgXjR/2KQV77XRcR4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1787900639189367.9913958520083; Fri, 28 Aug 2026 00:03:59 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1401626.1637178 (Exim 4.92) (envelope-from ) id 1wzqcf-0004Qn-FX; Fri, 28 Aug 2026 07:03:33 +0000 Received: by outflank-mailman (output) from mailman id 1401626.1637178; Fri, 28 Aug 2026 07:03:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wzqcf-0004Qg-Cj; Fri, 28 Aug 2026 07:03:33 +0000 Received: by outflank-mailman (input) for mailman id 1401626; Fri, 28 Aug 2026 07:03:32 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wzqce-0004QO-0k for xen-devel@lists.xenproject.org; Fri, 28 Aug 2026 07:03:32 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wzqcd-00BSfo-Dk for xen-devel@lists.xenproject.org; Fri, 28 Aug 2026 09:03:31 +0200 Received: from [10.42.69.8] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a9132bd-e002-0a2a0a5209dd-0a2a4508880e-16 for ; Fri, 28 Aug 2026 09:03:31 +0200 Received: from [209.85.221.53] (helo=mail-wr1-f53.google.com) by tlsNG-c1860d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a9132be-f659-0a2a45080019-d155dd35e805-3 for ; Fri, 28 Aug 2026 09:03:26 +0200 Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-482e4998d28so416562f8f.2 for ; Fri, 28 Aug 2026 00:03:26 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49b92679be5sm33489005e9.3.2026.08.28.00.03.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 28 Aug 2026 00:03:25 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Autocrypt:Content-Language:References:Cc:To:From:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1787900606; x=1788505406; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to:content-type; bh=xgIaJ540DVn9gMAwDjHqVBhyS2+4Ub8sOGYDzk1OFhQ=; b=HLZF3tFGyAn4piaLpUP+9hkBHKaGqAwZCwSYzqi/Q93BFK63tkssEpYz4leYsm/KCF 7C3CkHVEV/iYP6aw9OWs2gR6HTxT/k2R6tIV/KFwYKczAiy1K6rJsNg+Jv66/rG1IJpy VWmBiruVxCrimUb9ShvbSgcyzPiTheROUxh/s26OU+Dg6ebj4HdGq6F4uSMd61N4bbms JYcIfWUboBJqFjkg12wl3s0Qc9IYWbPnZz+ocfUd8z2zg6odGjTZJMyABBOAriPfWciH ZGMDX+lIXy+kCFfQJBH0zZKzkNLlxXVn1arLvAqRp5xrc04RTkLXdT1/Qk7JjuddYre0 eUnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787900606; x=1788505406; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=xgIaJ540DVn9gMAwDjHqVBhyS2+4Ub8sOGYDzk1OFhQ=; b=U6bNBpgDXfoVhx9U8s+NET4bI1HPwbVfek36PaMAn1IWfablO6xheHyubEwm5xWw2v 09B1I87PL05c04KPlKq/DZfASaMwHoW9gVkqzqp5798Bvk9qaTV3frzvEwv0cULJgGEi VMwd+Ke+Y09b4jMPkMwTMVsKgj59RG7+Pe+d1K+Qwio9clB+iJnwcytC5K66VpdJRq9x CIC0HjIKq88eck2ZCRw4MXg3EC1PkMIprAyk0CvNAbQQ0Gcrj5jEyeyvIqKquAGwStDm l06//+fA6XylvjKwgk7DdnHt7fZCC0AZ3y0YdCkczbbmGSMSxZ/7LEt+LemDg3qs009M FcaQ== X-Gm-Message-State: AFuF++mfvtEi6XJkWiqvOkHqQRpYxwDij/EZ4Qy4ocWZ2XpqSrCm1nCD eTq4jYKvNGAdeuRAbShCDobh+oMZLdT/pgw/ZK/imZCRwnsdBL2giIwHg9ty2jj0296x5J8zd6a Xg6Fajg== X-Gm-Gg: AR+sD10OHhOMUeT+6ljKKtzhj6xD4zcO6v/EM4epidVi1SncI5hr38BvMUg7FSUMHdA 9EFlmVagR4VHorRYLbkhGxHDGMVzj9ln33oWNL3K1KWuQ8i5/t9MSk++eB8Dh9I6mD6X7nK45Aq B+43hMiBC+o+XKkRNGUDNy697vMkaDsXBf6Y01ye96jCrXSWsQDqli96X9q9IPXq7VLsfeyKHwZ GWyWOfGjmAjDQNgv1CLj6rvOZ19YGTuy5YJFvQurVci8mKJ9Y1QJ0i0pUAnH1uglBlxuSvaW+pv h57Qo6eno40EF7+pAcMkp5eB6JFx8CITarKxEqnPnPWyz1OgW36FSm6uMOOl1c0e5P1+J38eSeS DT4j4aTJ4XYFK4ylR5s6HO0ehRevI1Xt8WDT+LyGolhrWxKRBqDyicsfjItpm9za85He0Q8DjKy Mvvg4ihe/BZ0EFtu0ROQ6ia0yHaQS6nhq6n5XybJlKCAlvk4kNwF9BYo3xCl1FNLwOdUlcHfVZc fwFWuw/bJfEvoW0jjqDh/CU8xuXLmAPgz0MIz3omw7spgv7oMLd X-Received: by 2002:a05:600c:870c:b0:499:dc34:bdc with SMTP id 5b1f17b1804b1-49b91c1c401mr75871115e9.1.1787900606073; Fri, 28 Aug 2026 00:03:26 -0700 (PDT) Message-ID: <6e98181c-459c-4c45-b8c0-c427e3c0bbc8@suse.com> Date: Fri, 28 Aug 2026 09:03:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH 07/12] altp2m: address Misra 2.1 rule violation From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Nicola Vetrini , Andrew Cooper , Julien Grall , Stefano Stabellini , Anthony PERARD , Michal Orzel , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= References: <90d0e3d6-2e12-43f1-815d-7936ca4c5fc6@suse.com> Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <90d0e3d6-2e12-43f1-815d-7936ca4c5fc6@suse.com> Content-Transfer-Encoding: quoted-printable X-purgate-ID: tlsNG-c1860d/1787900606-D6D4087B-D3067CFC/0/0 X-purgate-type: clean X-purgate-size: 937 X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1787900640628154100 Content-Type: text/plain; charset="utf-8" The stub altp2m_vcpu_idx() is recognized as "noreturn" function lacking respective annotation (or having a return statement), which hence is deemed unreachable code by Misra / Eclair. All call sites are guarded by altp2m_active() checks, hence an inline function isn't needed. A declaration will suffice, with call sites then getting DCE-d. No functional change. Signed-off-by: Jan Beulich Reviewed-by: Stefano Stabellini --- a/xen/include/asm-generic/altp2m.h +++ b/xen/include/asm-generic/altp2m.h @@ -14,13 +14,8 @@ static inline bool altp2m_active(const s return false; } =20 -/* Alternate p2m VCPU */ -static inline unsigned int altp2m_vcpu_idx(const struct vcpu *v) -{ - /* Not implemented on GENERIC, should not be reached. */ - BUG(); - return 0; -} +/* Alternate p2m VCPU - placeholder on GENERIC */ +unsigned int altp2m_vcpu_idx(const struct vcpu *v); =20 #endif /* __ASM_GENERIC_ALTP2M_H */ From nobody Thu Sep 3 07:03:33 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1787900672; cv=none; d=zohomail.com; s=zohoarc; b=C3exAwdgdCndYHYKARzNpxq5eFxQ1HVdM3TOmO9GFL/lbHWvS/Dz3Jxcz0n/qwYaLMzewpVZmTB8an2b+Lo4/8gbMm4G40cROhd2Oz+3TU4wWzVUKbxJ3xxy+iGDCe4ti8wfSHFNqs9tQ+vVvwX2Mp/OUuXO5f1QtqCDUuzhcuE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1787900672; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=DmF1sxJKk6keuGbs+Ea+dEobCZFX5puzwyTbL1N5ULM=; b=jNahWnH54L+D3ZYgZItrWBxA/xQ713tQPCF1HJB48r8OXmxq0XoQbed2gG7Yz+NJJmkTRHv+E7fisbZdsjspRVgo3+0qJ0OXKfBQKTQ38va9gmAyIUbbVdDFFiMsg/glYiJR97ddWaDYUMGYgsay8S/+Zl03z/XzkBVn+gBgISA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1787900672197722.4922007731144; Fri, 28 Aug 2026 00:04:32 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1401631.1637186 (Exim 4.92) (envelope-from ) id 1wzqdC-0004yV-NH; Fri, 28 Aug 2026 07:04:06 +0000 Received: by outflank-mailman (output) from mailman id 1401631.1637186; Fri, 28 Aug 2026 07:04:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wzqdC-0004yO-KJ; Fri, 28 Aug 2026 07:04:06 +0000 Received: by outflank-mailman (input) for mailman id 1401631; Fri, 28 Aug 2026 07:04:04 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wzqdA-0004xw-KA for xen-devel@lists.xenproject.org; Fri, 28 Aug 2026 07:04:04 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wzqdA-00DmW4-0z for xen-devel@lists.xenproject.org; Fri, 28 Aug 2026 09:04:04 +0200 Received: from [10.42.69.8] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a9132df-2eae-0a2a0a5409dd-0a2a4508af0a-26 for ; Fri, 28 Aug 2026 09:04:04 +0200 Received: from [209.85.128.42] (helo=mail-wm1-f42.google.com) by tlsNG-c1860d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a9132e3-f659-0a2a45080019-d155802ab58a-3 for ; Fri, 28 Aug 2026 09:04:03 +0200 Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-49557167508so5879625e9.1 for ; Fri, 28 Aug 2026 00:04:03 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49b497fa9c5sm103143025e9.4.2026.08.28.00.04.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 28 Aug 2026 00:04:03 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Autocrypt:Content-Language:References:Cc:To:From:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1787900643; x=1788505443; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to:content-type; bh=DmF1sxJKk6keuGbs+Ea+dEobCZFX5puzwyTbL1N5ULM=; b=IUttZ1QqG7XhlILV0P+E3X+ePLpWRMh+3k6CuLDiJk1G7P/JryDnlSbPm3gaOWGWWT H53R5dVGpZUrVdEky9h/nywr+xNZUUTAby75qPeQIKezsezuWwVs2Dl7AKVRQazqqQbr By6/S0RNnG+p9tDslib6hqQi7baYfVsLD4gP2f7sBOyv65awszGN9MWqtXZzD4PX+E5j OeH4csFyxzvUWbpHAzFBZNxtKWQ9BN9yK74tB4vbx+sdL7AAKTkJ8CjkL671J4ujsRYQ wd31Mb0WAUnUAul7YYdUfD7RbPy44UUXA5mSfgSbEWQj9JBokmL6OS8huFmYFiEh1ox6 W1pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787900643; x=1788505443; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=DmF1sxJKk6keuGbs+Ea+dEobCZFX5puzwyTbL1N5ULM=; b=UB83/OZIbifbYR1fNmiibIw7oyszRC50SnHbNehdERGit4lC3Lic+4S0Do11Viy6vB 8jC7GbO/e+ibNn0F574ksFJCvEuq0KsDc7dOdv2jUZ3qlaa+tONWhD8ojUFjwSkBZNMJ w26zS3xs6sw6M+uTaPHlh7k0Y2u24gKDIc0UUfYC02eSKOf5iUpNtVU5hb0WETQhp/RY FsUZ1WOxDI0nTM+EvxArmKsnJB8oaCJUxxwa5k5fob32Z3w4Hz40cvxEqAl1WqgD/I48 /EnZYuTr4p8kD+wAr5AnCefjFk6Q7sniVnXYizViT+13QIKOWQafGxOg5BP2sztkUOo1 1U9g== X-Gm-Message-State: AFuF++nj27CF05/xzphsi3WrB+JEBoD6rtNZZiVWaZQ98ThqYx5EWMMO Fh4r6tNL7fekmHWfiktGA62hkMd90NIdlf3Wcr7m4vaxg/o04RkAwJUBMh2wA0KI+oLXxhrYbmp 9B163oA== X-Gm-Gg: AR+sD11m4AQIaOvBP6N65FjFek1mxSvLjI4A2xJRWozTWWS34qDDsQA+g1eoTnUGIVN am0/e00B4Pox2kM9D98zxVekLAAsImO0iPcqpuCC/TqTQTM2COT/9NTvCr8w92wfWe0TUFEfroR ub5Vz0+nG8bnhYcPARQkEX+ZAXK3Ss94JJ70YJ0a8Pt3c1t62sAigtIDOroalMUU43Z3SM8jj4E wz9Ve9EN14JUoHJ0dAHFNUdol97o3XUAyfdwRnvHXynZClq62hQUimLFm6ZSOJoSCB1Ocl1lsYi wm/0MkY6DxJpClmQOGVA2RjvO7yE3U4nD4kzGSz6Lor8Qj/bMGSfZ5Vm/CaaSCZNm02l+tazQ6U 9y8FaT05mkHvduvgvskGkBtDOq4kgKOheNjXOJbCs5hejoFMcnvzmozX5TnXxU2XcB52zSuiqNu BJX/XPJyrczlnOxUXzHaJvLSAjkM9UcDnM6kVDLGguNKuFupQo4HUCJuB6xBtwj0PiB0dzhblvb YTVGj8NHMh3aGkO8FVI/RUz/WymnO9KDlCJSWTbce8Y+0RPESUGZoHF6LjSfKU= X-Received: by 2002:a05:600c:4594:b0:49b:4d64:bbc4 with SMTP id 5b1f17b1804b1-49b91c2f990mr57810185e9.8.1787900643344; Fri, 28 Aug 2026 00:04:03 -0700 (PDT) Message-ID: Date: Fri, 28 Aug 2026 09:04:01 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH 08/12] Arm/GIC: add noreturn in a few more places From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Nicola Vetrini , Julien Grall , Stefano Stabellini , Volodymyr Babchuk , Bertrand Marquis , Michal Orzel References: <90d0e3d6-2e12-43f1-815d-7936ca4c5fc6@suse.com> Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <90d0e3d6-2e12-43f1-815d-7936ca4c5fc6@suse.com> Content-Transfer-Encoding: quoted-printable X-purgate-ID: tlsNG-c1860d/1787900643-D735D87B-83B1FCEB/0/0 X-purgate-type: clean X-purgate-size: 2030 X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1787900674485158500 Content-Type: text/plain; charset="utf-8" LPI related functions having just BUG() in them are disliked by Misra / Eclair, as long as they don't also have a noreturn attribute. Signed-off-by: Jan Beulich Reviewed-by: Stefano Stabellini --- From its description "Unreachability caused by calls to the following functions or macros is deliberate and there is no risk of code being unexpectedly left out." I would have expected the respective entry in deviations.ecl to cover all of these cases, but clearly that isn't the case. Of course having noreturn on functions returning non-void is somewhat odd. --- a/xen/arch/arm/gic-v2.c +++ b/xen/arch/arm/gic-v2.c @@ -1315,7 +1315,7 @@ static int __init gicv2_init(void) return 0; } =20 -static void gicv2_do_LPI(unsigned int lpi) +static void noreturn gicv2_do_LPI(unsigned int lpi) { /* No LPIs in a GICv2 */ BUG(); --- a/xen/arch/arm/include/asm/gic_v3_its.h +++ b/xen/arch/arm/include/asm/gic_v3_its.h @@ -229,7 +229,7 @@ static inline unsigned int vgic_v3_its_c return 0; } =20 -static inline void gicv3_do_LPI(unsigned int lpi) +static inline void noreturn gicv3_do_LPI(unsigned int lpi) { /* We don't enable LPIs without an ITS. */ BUG(); --- a/xen/arch/arm/vgic-v2.c +++ b/xen/arch/arm/vgic-v2.c @@ -718,14 +718,15 @@ static void vgic_v2_domain_free(struct d /* Nothing to be cleanup for this driver */ } =20 -static struct pending_irq *vgic_v2_lpi_to_pending(struct domain *d, - unsigned int vlpi) +static struct pending_irq *noreturn vgic_v2_lpi_to_pending(struct domain *= d, + unsigned int vl= pi) { /* Dummy function, no LPIs on a VGICv2. */ BUG(); } =20 -static int vgic_v2_lpi_get_priority(struct domain *d, unsigned int vlpi) +static int noreturn vgic_v2_lpi_get_priority(struct domain *d, + unsigned int vlpi) { /* Dummy function, no LPIs on a VGICv2. */ BUG(); From nobody Thu Sep 3 07:03:33 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1787900700; cv=none; d=zohomail.com; s=zohoarc; b=D7lFkrE007+NKRTnuZ9RnPvH9g9qkZFRdp4sfMsSzJ45X8TQykey3R49AYScxvxDZ+yYkXyxly4Izr7PvFEYiBzCN8cD8ZaF3io5RGBdG6NOQ+rnQ+GOurexREuToGMT98Gon60yp2JhgMxKPU2ION+1eyb/0t0bP3BKjY1EIZ8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1787900700; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=m/fuBmCCJ5a1zaL+2kWjQQLEuHgPrkNDDGBZHEQWcC0=; b=IDSME6Z3gP3/XE+wpNqJnoKO1HEq/n8Rs5H5oCX+BVq1QbFfWeTNGp2cW1AnxDqSwcxyYxTjXjXJj41DY/F/o2FRmYYP63M3XkoI7SUdd2dg90KD3I9+lZdktSv1xsWQaby6pzssHsEFbomdWs+T1/DUHrTRyRlE0nmG4c+giVE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1787900700765945.6173861206636; Fri, 28 Aug 2026 00:05:00 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1401640.1637205 (Exim 4.92) (envelope-from ) id 1wzqdj-0005qD-9v; Fri, 28 Aug 2026 07:04:39 +0000 Received: by outflank-mailman (output) from mailman id 1401640.1637205; Fri, 28 Aug 2026 07:04:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wzqdj-0005q6-6X; Fri, 28 Aug 2026 07:04:39 +0000 Received: by outflank-mailman (input) for mailman id 1401640; Fri, 28 Aug 2026 07:04:38 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wzqdh-0005o5-Rj for xen-devel@lists.xenproject.org; Fri, 28 Aug 2026 07:04:37 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wzqdh-00DmdV-8H for xen-devel@lists.xenproject.org; Fri, 28 Aug 2026 09:04:37 +0200 Received: from [10.42.69.1] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a9132f4-8faa-0a2a0a5109dd-0a2a4501e002-44 for ; Fri, 28 Aug 2026 09:04:37 +0200 Received: from [209.85.128.45] (helo=mail-wm1-f45.google.com) by tlsNG-d62444.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a913305-5984-0a2a45010019-d155802de834-3 for ; Fri, 28 Aug 2026 09:04:37 +0200 Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-49b8be0409fso2935395e9.2 for ; Fri, 28 Aug 2026 00:04:37 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49c44feb966sm4170955e9.6.2026.08.28.00.04.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 28 Aug 2026 00:04:36 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Autocrypt:Content-Language:References:Cc:To:From:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1787900677; x=1788505477; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to:content-type; bh=m/fuBmCCJ5a1zaL+2kWjQQLEuHgPrkNDDGBZHEQWcC0=; b=ENPJ3ZH5ZEz8gzJ8U0LVuJfR9/0Zz5UJLfsK9x7sBR4pteT+SQ9q7pYjQTVi9nAVnp EiYQfRivPyeDg/31vMlYU9SyBqO6EOaqbtipvgr/KEFxANJAVksGwMAZR7Wm2x4O4T8D qBzvnR/o8rDx+6eWAvFlYyWiqHJDBElb1SGL8BT8Je4efZWRJknHx+VIWIIc76DFqLw+ tOqsRKKHBPSit85QaQK9imM7WpHk+fJt3d/w6KK5J7cDBLnhRn2E9K0Prie8aiWu5VmU aBxsz332LUw/fLq1LCbdCfEdZbdI2t4OoWd6J6sEK3E/EHa0V0e+fUfVn05+YQygdXCc 89mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787900677; x=1788505477; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=m/fuBmCCJ5a1zaL+2kWjQQLEuHgPrkNDDGBZHEQWcC0=; b=UAA+vUSCnzkTsJZ+DQLz/t/3dQrtAT4h75Opv79C2HnUMel3PnDYK77XX+9k1Wd+wF CUHPQz50pSznQyTPt9DRiNm4RcwOIqLpTf4CGL/Y8hhMS3gRh04w7hyPIhKiCJnKdQTS glLEChsc4J3tmfoj6dmhx50WQOW8GJpCUfDuZ14DU7IvFPbDSnFa/ni4koW1Vh0i630s bV2SUxZmj/6POvapwOaQD/mKjuyhRbdzCOPRXU39ioj7oftKxFfhFEJ0gy+XUIdHFaGC IrkCofPl9NmQyGdJqAgynGAmAaGFBBYF8UXQQNbdysNDi1fLf50OuGVeyxp4X9DcBlHh Mdow== X-Gm-Message-State: AFuF++mq26poplI5WwwQymMBeN9Mbf9oNIU1pKYU5kUMjlPYrxQ5mUIs lkXmzeqSo3nh9K621PpDqwQ2yjApMEo3sMs0spEwV2iRLy9qS3272JzKSvqDQfznUVc27JGvRZS n/OS6gQ== X-Gm-Gg: AR+sD121KTJHVRaZ1+ZJgEr4hr3As463Q2EgkKTdvDXp6HRZyWTX3J4uZF+FtSiPzHw PBsYXmK2v1VKcZHIqG+000I4cQgRH4eUG0SyE1VWZt7GB7qYTz4iMRoqrDH6NBvo64zltTPlce3 K5MgydcUQDO27DtxvZRKF8t0ibFXZVykCIJNaUmZ3nOMKdbFOWqm8e4NzVToFkGTBMJBW43EVUs C/xXRL+tH3kkLc6ai5YwYv2xc+yEbRna9tauuJpOhwYmz2HsaBOExGjdtkAsK3o9G8ANy4Ihbl7 zhhVkuRT4xBwhDLxn0PiVHIfn6sEF1zVSJ+pi089zVwxbz6AEgyJ000Xr8VYPxoxEzsnIe5V1NX 8vpGQ2MhYshb7Vxg+oq0BqQglcAan4V1xTQ0iZj7UM3sCx7Vy8Z9Wy+CW4MsMhdZrx2Ul4NiX0f 8A/1jRO27b2q+kDP2+fWp+wmkghVoxBe/NvnXgMiU6x4jkvDr0SOcM5AEZ2UZS6UwoMI9UV9U9I d5tR832Q0lPpt9pnORJWaGvfj0tucJcTVHd3nMYqlrLfRt6GFpWhP0fTPKyh/w= X-Received: by 2002:a05:600c:6215:b0:499:5a50:b022 with SMTP id 5b1f17b1804b1-49b91c1bb18mr67259705e9.3.1787900676675; Fri, 28 Aug 2026 00:04:36 -0700 (PDT) Message-ID: <06c5efc0-e130-417f-8333-b8eacd1c6d77@suse.com> Date: Fri, 28 Aug 2026 09:04:35 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH 09/12] Eclair: deviate BUILD_ERROR() wrt rule 2.1 and introduce variants From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Nicola Vetrini , Andrew Cooper , Julien Grall , Stefano Stabellini , Anthony PERARD , Michal Orzel , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= References: <90d0e3d6-2e12-43f1-815d-7936ca4c5fc6@suse.com> Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <90d0e3d6-2e12-43f1-815d-7936ca4c5fc6@suse.com> Content-Transfer-Encoding: quoted-printable X-purgate-ID: tlsNG-d62444/1787900677-1F86F757-E8D1E3E7/0/0 X-purgate-type: clean X-purgate-size: 2567 X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1787900703618154100 Content-Type: text/plain; charset="utf-8" BUILD_ERROR() is even stronger a guard than assertions in general, and ASSERT_UNREACHABLE() (or BUG()) in particular. Deviate it just like those to allow use for marking unreachable portions of code. In some cases code being unreachable is dependent upon configuration. Introduce two variants, as constructs like if ( IS_ENABLED(CONFIG_...) ) BUILD_ERROR("..."); results in the if() still being reported as unreachable. Sadly these two new macros introduce a new 20.12 violation each, which hence also needs deviating. Signed-off-by: Jan Beulich Reviewed-by: Nicola Vetrini Reviewed-by: Stefano Stabellini --- a/automation/eclair_analysis/ECLAIR/deviations.ecl +++ b/automation/eclair_analysis/ECLAIR/deviations.ecl @@ -19,6 +19,7 @@ Constant expressions and unreachable bra =20 -doc_begin=3D"Unreachability inside an ASSERT_UNREACHABLE() and analogous = macro calls is deliberate and safe." -config=3DMC3A2.R2.1,reports+=3D{deliberate, "any_area(any_loc(any_exp(mac= ro(name(ASSERT_UNREACHABLE||PARSE_ERR_RET||PARSE_ERR||FAIL_MSR||FAIL_CPUID)= ))))"} +-config=3DMC3A2.R2.1,reports+=3D{deliberate, "any_area(any_loc(any_exp(mac= ro(^BUILD_ERROR(|_IF(|_NOT))$))))"} -doc_end =20 -doc_begin=3D"The asm-offset files are not linked deliberately, since they= are used to generate definitions for asm modules." @@ -667,6 +668,7 @@ deliberate." to the # or ## operators within the following macros are deliberate, to pr= ovide useful diagnostic messages to the user." -config=3DMC3A2.R20.12,macros+=3D{deliberate, "name(ASSERT||BUILD_BUG_ON||= BUILD_BUG_ON_ZERO||RUNTIME_CHECK)"} +-config=3DMC3A2.R20.12,macros+=3D{deliberate, "^BUILD_ERROR(|_IF(|_NOT))$"} -doc_end =20 -doc_begin=3D"The helper macro GENERATE_CASE may use a macro parameter for= ordinary --- a/xen/include/xen/macros.h +++ b/xen/include/xen/macros.h @@ -64,6 +64,21 @@ */ #define BUILD_ERROR(msg) asm ( ".error \"" msg "\"" ) =20 +/* + * Like above, but conditional upon @cfg (not) being enabled. @cfg must be + * suitable to pass to IS_ENABLED(). + */ +#define BUILD_ERROR_IF(cfg) \ + (IS_ENABLED(cfg) \ + ? ({ BUILD_ERROR( #cfg " unexpectedly enabled"); }) \ + : (void)0) + +#define BUILD_ERROR_IF_NOT(cfg) \ + (!IS_ENABLED(cfg) \ + ? ({ BUILD_ERROR( #cfg " unexpectedly disabled"); }) \ + : (void)0) + + /* Hide a value from the optimiser. */ #define HIDE(x) \ ({ \ From nobody Thu Sep 3 07:03:33 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1787900728; cv=none; d=zohomail.com; s=zohoarc; b=h1zXhw2kakdB2AiKrDo+cB8UMHVHT6uUJ1SHgLomnEi6kQSKw8BN7KSUKV26ZqOqTVAsKsug7VP+/qkZMwl0ucH3CkB5c3w7tt08vFoP2pAmFCba85YOPWCy1oijTMFl+AmSPlHW93liak2Y2sD6mMqPQRDs6ZWBQhqHzVvUXmc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1787900728; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=TWfdIfEKkF0sERNM/mSdQ9IUQZ7pPCDfv2hRzvZW3AU=; b=mzEEtKjU8qK6SCGyjIaDUQu81ugxGYOcB5NGm3F/GWtsakM0P20/hx5NP+be5hwGk+eau0p3cmo7O/JLCWGdIRkixtNG7OfGm6S6R188bDiaSpLX9/MRnf14GhpZejMdi9ZerpAqRNMMRdngQEDH4bPiZokDHPLp2wwe3+eIi2M= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1787900728305187.20095332072913; Fri, 28 Aug 2026 00:05:28 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1401652.1637214 (Exim 4.92) (envelope-from ) id 1wzqeJ-0006ch-HD; Fri, 28 Aug 2026 07:05:15 +0000 Received: by outflank-mailman (output) from mailman id 1401652.1637214; Fri, 28 Aug 2026 07:05:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wzqeJ-0006ca-ER; Fri, 28 Aug 2026 07:05:15 +0000 Received: by outflank-mailman (input) for mailman id 1401652; Fri, 28 Aug 2026 07:05:13 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wzqeH-0006bD-RX for xen-devel@lists.xenproject.org; Fri, 28 Aug 2026 07:05:13 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wzqeH-006Opq-8D for xen-devel@lists.xenproject.org; Fri, 28 Aug 2026 09:05:13 +0200 Received: from [10.42.69.11] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a913324-8faa-0a2a0a5109dd-0a2a450bc0ba-20 for ; Fri, 28 Aug 2026 09:05:13 +0200 Received: from [209.85.128.41] (helo=mail-wm1-f41.google.com) by tlsNG-42698a.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a913329-b7e8-0a2a450b0019-d1558029f05f-3 for ; Fri, 28 Aug 2026 09:05:13 +0200 Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-4953e04ef16so5924255e9.2 for ; Fri, 28 Aug 2026 00:05:13 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49b4942298fsm106061005e9.1.2026.08.28.00.05.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 28 Aug 2026 00:05:12 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Autocrypt:Content-Language:References:Cc:To:From:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1787900713; x=1788505513; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to:content-type; bh=TWfdIfEKkF0sERNM/mSdQ9IUQZ7pPCDfv2hRzvZW3AU=; b=O/6PatNDn6O5s2IuJZaIzuY2bwpgNcSPxSZCEeNClu/19wkqaR8r757nZkgznBSYrn mtJVtUiAHgZ9AHOiVIZ/1oN0iTVBZT0nN0x+nwVIcGOvdvk+9SFfLkwxZfDBDbE9ee5a J/Cql7JKs1rtMysvBpuTJPo3SQNpRiLfgkX/ZBoTcCs+KP6Yj8Kzcu1nqo3hxamCC2pG srQlgH5w64mlsbfpG8P1waN3jr4eefdJnyvfQ26+doEsluSbECW1TPo1Tw/Ha/4yQxse qACnPd3dAVBOYUbZesoF0JNKgXZV/nppSn4LZ+6hvAWK/6blkLNAHuetrD9jpScm93qE bn1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787900713; x=1788505513; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=TWfdIfEKkF0sERNM/mSdQ9IUQZ7pPCDfv2hRzvZW3AU=; b=Bjli/3XIeyMk3Zhmbz6Z/vPRQjDVaNULC6vSGSCS7WVN3XAjfBwK8fLLCDK7VnNkca ul+Dvu4onJaIahuuRu0DGb0iecLXdCk1tFq0m2pu28krbcAcSy2H/GNJyr5OhwwpoHUh HfkF5aRth3Uq5MxGmeSMQx7EUwdGJ/AVRVWhXc0FtlezfA/ZzYV4xDacmMvN1X6VYxPu vDUcCpAJc73x9mwBh4ziNwJ9CsMlI32feOdNpqfTB3EYu14mHjFdVJuvE3IZM+RLGGP+ /ktk8tjBKnj2yKsFNpWuOnQ21V7sE6Sq97/U7mpIsfX/DxVF3/7HApDo/WMsHD/g95gG UNjg== X-Gm-Message-State: AFuF++nrC3PozNFkfVh+Q6D9sC+jX1M+ODOI/jSSOoDrgK/RVy2ZFuKL uxo3TFyH8euL9WHoD/2ZKhEtFbDaSygi9yKJ//zpxz1NS/Xpv4TKflDq57xUwuPlwcMVE7kY8hU rI1xElQ== X-Gm-Gg: AR+sD10F1FIHF+7jc9mdIksi6ABrWxUyWnyE/SwL3FqYX1FYDuGkDlqQqIQDQj7MtFc OjC9hrhQssVSXobdmmLRs1iFGxLGaWKMKqsL5om5mIZ+T7318/RYcKlkyDLlmJRPjq1RX62WTcO VWBbCJ+vQWU3YYUkHGnAker7nkzJdI6N3Va/0wBKq2xx8a1VmGE/VIPx0WzoYwvpRizFq1cdD4O oVDkWszJe1/QGsEuqE2dCWmGr934kU2mZrM2MZTglLPHm6M1BRMfRuEGrRIxkPvo1+uzp9Sh5h8 RBCrCXFpVgrja7iYyKHz7UliRVaqlSwLErY09O3SmD/0fFjosPZ1KAPF5RD/B2UaIp6DXE1tH7U 1Spf3SbZPWdKy6GaMe8hot4cvQHsgGLuj8f+juIPhQVI4DaJGDdE2sq6Znuv5tMFZZFarvfLwN0 OwkPXVLYLeMGrLiFYCxhE0mdlJbEnFEdWYUIF9g9fPz11irFYDshxKV4vnCjS25G1wDhjp54TyM m1lPBgC9UmVMFluauaeaZz9FjxYFxm2yf8QbVwksqKXxddrb+dghg== X-Received: by 2002:a05:600c:a55:b0:499:60bf:c6f7 with SMTP id 5b1f17b1804b1-49b91c4cc2cmr63870935e9.13.1787900712683; Fri, 28 Aug 2026 00:05:12 -0700 (PDT) Message-ID: Date: Fri, 28 Aug 2026 09:05:11 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH 10/12] PCI/physdev: address Misra 2.1 rule violation From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Nicola Vetrini , Andrew Cooper , Julien Grall , Stefano Stabellini , Anthony PERARD , Michal Orzel , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= References: <90d0e3d6-2e12-43f1-815d-7936ca4c5fc6@suse.com> Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <90d0e3d6-2e12-43f1-815d-7936ca4c5fc6@suse.com> Content-Transfer-Encoding: quoted-printable X-purgate-ID: tlsNG-42698a/1787900713-ABAD09EA-59BF5E21/0/0 X-purgate-type: clean X-purgate-size: 620 X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1787900730205154100 Content-Type: text/plain; charset="utf-8" Cases 0..3 are handled, and a 2-bit mask is applied to the switch() expression. Therefore the default: case is reported unreachable by Eclair. Insert BUILD_ERROR() to annotate this for Eclair. No functional change. Signed-off-by: Jan Beulich Reviewed-by: Stefano Stabellini --- a/xen/drivers/pci/physdev.c +++ b/xen/drivers/pci/physdev.c @@ -114,7 +114,7 @@ ret_t pci_physdev_op(int cmd, XEN_GUEST_ break; =20 default: - ret =3D -EINVAL; + BUILD_ERROR("PCI_DEVICE_RESET_* inconsistency"); break; } write_unlock(&pdev->domain->pci_lock); From nobody Thu Sep 3 07:03:33 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1787900777; cv=none; d=zohomail.com; s=zohoarc; b=LMAgJ4lH6qy7ApjjWsJw0qfSDofNPWySpICdZUMfD+OqN714iMPDYMekeuE8UAvma6WxTZU47xN26f+mjjYrpX/OghFoKtnpFjCGV4gbo43EnlJ/Z7uASPaL5IegLfWG0zTelXrmy8CkhGsIYWT8bLa42FHySVefH7uXpcbF+1g= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1787900777; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=xeBcqU4ONhlQiamT59WM+Tt5fXRzCZEnMYHTumLui88=; b=Q6YtslmKhyALKkPZTPPDHvk6LvYx0TsYATm5cSA9YCdIDj8eCjM81JpwaNkMAV+aykZ6XpxWnYndllEQ3nnEFWtTH1Nj1l8oZC8M/juyySk+9fP/dtaUD+5cvQOhi1hWvNtaMoapSigQm6HBi6R6oPcuzpOPQHQRQFotQswncDw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1787900776786314.99786637977536; Fri, 28 Aug 2026 00:06:16 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1401662.1637223 (Exim 4.92) (envelope-from ) id 1wzqep-0007CG-PU; Fri, 28 Aug 2026 07:05:47 +0000 Received: by outflank-mailman (output) from mailman id 1401662.1637223; Fri, 28 Aug 2026 07:05:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wzqep-0007C5-M0; Fri, 28 Aug 2026 07:05:47 +0000 Received: by outflank-mailman (input) for mailman id 1401662; Fri, 28 Aug 2026 07:05:46 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wzqeo-0007Af-4e for xen-devel@lists.xenproject.org; Fri, 28 Aug 2026 07:05:46 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wzqen-006PDC-Hf for xen-devel@lists.xenproject.org; Fri, 28 Aug 2026 09:05:45 +0200 Received: from [10.42.69.4] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a913343-bab6-0a2a0a5309dd-0a2a4504da3e-32 for ; Fri, 28 Aug 2026 09:05:45 +0200 Received: from [209.85.128.44] (helo=mail-wm1-f44.google.com) by tlsNG-ebf023.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a913349-b57f-0a2a45040019-d155802cad37-3 for ; Fri, 28 Aug 2026 09:05:45 +0200 Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-49b0dd3c9a0so4100305e9.1 for ; Fri, 28 Aug 2026 00:05:45 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49b94dd2517sm27274095e9.7.2026.08.28.00.05.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 28 Aug 2026 00:05:44 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Autocrypt:Content-Language:References:Cc:To:From:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1787900745; x=1788505545; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to:content-type; bh=xeBcqU4ONhlQiamT59WM+Tt5fXRzCZEnMYHTumLui88=; b=e5HbokPhDqYiFyMWxgW5GjIiHOt0T4Nu8qx4WEzVJhXFJWiJ3dQB/uR9kCo820PR4H KCcC3sDIl06ro3YqW/lZZSpxlEtAeRgdNKmcxa7WWFMyM+Ed+RF5H3I2kFVg4q2vqrQ7 leNFl51pv2krAbPY/GqzBm5N5Dh/x7kNs4w+fFCxTkJ+hiiG75DqqTzu9e88YObxg0dq tMcbDm+J4Q3+OB6e0Axu6Iu60Twzav04/8Lnp2Uu9hgfZLd/7dmFO1b6hutT2ErjVQpO PdmnJ4eCojO820qGlPKLaSSJJTOUNVE5/ciDOgF9KdgONH56hmCGk/6RQHceofeMwZty neJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787900745; x=1788505545; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=xeBcqU4ONhlQiamT59WM+Tt5fXRzCZEnMYHTumLui88=; b=MfHHNoXHtviE+sua24BJhunkmcY3aILTNWs3hacd5tgDHpwZGlH1t0A/FQ/6I/aHie CcZDMYkaD2CcUzO0j29phzEPqvTrqPStaHifMA4aqcCE3P6u9fUdpRhzqat6m69ViVNy JEZDMD6VoDipGMjrfjjTdWetLRtm1xcrKyLFoyKfiZzbPPzWjJgO77wMyP7KFPecI13z 5wpsYKqNkeZk+hdoT3s/gxlOfH48qbjl6K5BGzw5uX0pXEi0N2C1Cb+CAX5+NkK4gzon IXNFkR1/aly16u0zHIcu+IkAzNbpIOSFgSeZmHWszY20q8SoIeupk1zLcgupWQMfn4yM 1PbQ== X-Gm-Message-State: AFuF++ne9CgUWzT3cAoyHHbo3anyM4l+6qoIT8TgxpahbWoG2Qr40Es3 fIV6otpxJ2FKJdiN6qECo1faVwSxJmt4s9iR6qZTHkp0DIx51+DRCa2U7qzq7W1nm32KUG0JZ8w Ax1TTPg== X-Gm-Gg: AR+sD12JxFLyzGBFgx4rzGyAKocS17Pp1xEey4V8FM4hJSx9oBPLgLfBcsQpsI17eka W21Lad8VtEC/FgDzXLEDGTmPpQyE1Dl7y3GP4v5iiXAi5+7791m8YB8YiU6kwl2BBA2EA5p8taJ tciqE5g22Owen5yzBIw1eWRPt6kuXrysJF2CHc29Mh9LhVBcnDEL1toNbhMXVkVl9AQ/4rXmJlo 6SXbBIOnbnO6xBiURrpvFwNPMuaKT6qhpmWSd8RwPmf0PN91IiyzToXbgwxsVCAJFlWmOihw7/E ZGEwHSTNw31Dc1Rm+z8ODu0xtsdTi7T38274OOWsta46fZqcf2SrT4ze8iHEVTIPC0aU+iZTnAg LS15lSpf4oVh6jMBjuZMpC5MMj81B3NHqPCq+zuG3XInRrGCSd5rAT45TOywQJLoFd0wuVtVfrD BWr/2y/HdMTkjJhpFDfHIHZj6Y5ygX8HsO08sTAfgvF141KuhXlYx7l4PpXrWIANRsKyzFWt5jz 8bAKEmfV6Jce6Z6wJxxJxbO4GUh11Gja4Kg8vpNYlF+wsL+nZ+F X-Received: by 2002:a05:600c:1f8f:b0:499:b65d:1250 with SMTP id 5b1f17b1804b1-49b91c1fc4bmr44557995e9.2.1787900744936; Fri, 28 Aug 2026 00:05:44 -0700 (PDT) Message-ID: <65330fe2-0a0d-4b70-a647-27290d0041e0@suse.com> Date: Fri, 28 Aug 2026 09:05:43 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH 11/12] x86/HVM: address Misra 2.1 rule violations From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Nicola Vetrini , Andrew Cooper , Teddy Astie , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= References: <90d0e3d6-2e12-43f1-815d-7936ca4c5fc6@suse.com> Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <90d0e3d6-2e12-43f1-815d-7936ca4c5fc6@suse.com> Content-Transfer-Encoding: quoted-printable X-purgate-ID: tlsNG-ebf023/1787900745-52AC8B50-FBE8B311/0/0 X-purgate-type: clean X-purgate-size: 884 X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1787900780744154100 Content-Type: text/plain; charset="utf-8" In hvm_set_cr3() the "bad_cr3" label is reachable only with SHADOW_PAGING=3Dy; the code being there is therefore a Misra rule 2.1 (unreachable code) violation when SHADOW_PAGING=3Dn. Similarly code past the initial switch() in hvm_debug_op() is reachable only when CONFIG_INTEL_VMX=3Dy. No functional change. Signed-off-by: Jan Beulich --- a/xen/arch/x86/hvm/hvm.c +++ b/xen/arch/x86/hvm/hvm.c @@ -2455,6 +2455,7 @@ int hvm_set_cr3(unsigned long value, boo return X86EMUL_OKAY; =20 bad_cr3: + BUILD_ERROR_IF_NOT(CONFIG_SHADOW_PAGING); gdprintk(XENLOG_ERR, "Invalid CR3\n"); domain_crash(currd); return X86EMUL_UNHANDLEABLE; @@ -5201,6 +5202,8 @@ int hvm_debug_op(struct vcpu *v, int32_t return -ENOSYS; } =20 + BUILD_ERROR_IF_NOT(CONFIG_INTEL_VMX); + vcpu_pause(v); =20 switch ( op ) From nobody Thu Sep 3 07:03:33 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1787900795; cv=none; d=zohomail.com; s=zohoarc; b=Ug0ExzOj4P6DRAmT2lwtDciwvCFOORXRuBzWrFrxiEJyWZXDQDn/kzejGGpdltOJ0ZCe4Y2d5+yZZOokYoHJi4rHyMHhD92gcfo5k11E35T4RFwEzdseDd99VpZwlbFCAa1OLf8SGC0bO5t+IarSxbx0sMBrsiwgVplO5+5xkyk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1787900795; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=fQitUjUUG5fOaprIaKXCQa+mw1Of9Q5sRiQtWfrJUBc=; b=gsHtzQiInp6kvG5xlowJLO9nq2oMWXsfk9cm6pPsApaZgCKEI8JfvV20KsQmsD2nbSqIQD4ArIjnztyHwmtaU2l+v+FhFRE1EFtmh/Rbrr4blYbT/u14EiWZZiRIJoyFHU0rVTXvhlhRiwnhKhQWYsTy+zyG/Rw5aovQ2BBI+vQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1787900795783395.12946778318894; Fri, 28 Aug 2026 00:06:35 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1401668.1637231 (Exim 4.92) (envelope-from ) id 1wzqfQ-0007lf-1E; Fri, 28 Aug 2026 07:06:24 +0000 Received: by outflank-mailman (output) from mailman id 1401668.1637231; Fri, 28 Aug 2026 07:06:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wzqfP-0007lY-Um; Fri, 28 Aug 2026 07:06:23 +0000 Received: by outflank-mailman (input) for mailman id 1401668; Fri, 28 Aug 2026 07:06:22 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wzqfO-0007kD-Iw for xen-devel@lists.xenproject.org; Fri, 28 Aug 2026 07:06:22 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wzqfN-00BTdK-Vn for xen-devel@lists.xenproject.org; Fri, 28 Aug 2026 09:06:21 +0200 Received: from [10.42.69.2] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a91336b-e002-0a2a0a5209dd-0a2a4502a99c-14 for ; Fri, 28 Aug 2026 09:06:21 +0200 Received: from [209.85.221.49] (helo=mail-wr1-f49.google.com) by tlsNG-720697.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a91336d-6ca4-0a2a45020019-d155dd31d490-3 for ; Fri, 28 Aug 2026 09:06:21 +0200 Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-47f93b2fe4cso231934f8f.0 for ; Fri, 28 Aug 2026 00:06:21 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-482fbab3fdbsm1690444f8f.6.2026.08.28.00.06.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 28 Aug 2026 00:06:21 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Autocrypt:Content-Language:References:Cc:To:From:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1787900781; x=1788505581; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to:content-type; bh=fQitUjUUG5fOaprIaKXCQa+mw1Of9Q5sRiQtWfrJUBc=; b=OVnbCOgdY3+MxVxinoEy1+MMYEA7B2eXRPgXg4iw92hIf4sfT/YtzjhxsMZpkRtSHi 8rIigWonQqiuHBhUTr4Ro2tq5nDfadyWMigtgXJ/CsQIcq20kBDfHmp/lr7Xryjgftzs aLmpQVQKhM0TMIpBFFRaJK/gRX0Hj+3sorORaKAGNnOzOVtriogMTrhvbb3pogim3+YH LybBsk3Yw0ypYOTi75NRUBACSPdBSoDXa+NU3OKsny4n2qJ4NOdbSeN28pSZJ3y/T0qr VF4IGLDZ0/oqPOVpF4d/HvYnDMl18nNV9c6sKFWZ5Na4WFNQvKa4F6nPZHMkI2qA/PO8 +8OQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787900781; x=1788505581; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=fQitUjUUG5fOaprIaKXCQa+mw1Of9Q5sRiQtWfrJUBc=; b=ffSBGlvhmKWjNojzpp/pMKi1dZ/UqCPT4gyuXcUUnHP5haQ2hiQ0huZN65toOYRI3t nm5Jp6QdSD7VP77R7septdNWui8IqKSVQIWPOCyc0CzdVZIxEiYBc7THM1JyhNHlyUc1 6cdKNnCoYmbgNlfuY2Ai++B68/SU8Uexe1rGUVWK34GnKc0Vv8Dit7lYhsvRruPhThQu XM35HzTQyOSh+BmieXQUfpKxR2BhvX6uqPl0MMJme0vNsoB3H3W0KyKCwPQ+ORqbQ83F 1Wpk8MKb2jVLtxaAp7wXz/vTTmNm5kv+MT8Mx83Ts4ROFoEDmXi+oOKDUiM++XEg/sr1 vBZQ== X-Gm-Message-State: AFuF++kjKU2I4wAa9HCkctXAcu6Lkkf9UVYkspMtqWKu+MdUr9Du90md RHR3Z8hq+sdj7BHpy/+ikqsHkr3QTbxCR0vkiptIxp/UIMkzF3+ivoNm8LgU2u2DwjqWVrD0FgS RqqbGrg== X-Gm-Gg: AR+sD1049PmyhEicXgDdRGHJDAkOmgSC2c5kftl6OkylQ/f7QW1y/2qzHtYFvLGX7Ml 2SRxlsDLL0FjcC6WIVF4xoLu4CTv42hRk3j0doLt//KIB/63d1MdlKQ8sMgtC08GFyWQ3IUdeyh I8oA49bhDKgUcQdBXzXBa66XGcn3B2vIy9IQuJakl02GFXzqx9j3VsqDF4sIOkLNPK0KzuzfVuN yEc/C7BY5KeAWccFrF3IAOXyl7tI111z1VYO+t/yIMFxAZg0u31sWuuxsxmscfzQm/mSTTclOYY ttdfFkkFJuMDgZuc6Qd55bP8Iy/Vps0XV0To0yNuLUBqwivZ38logTr08O+hxOOLKvJ9cHh26JD tpoY/jPYuDDPqhbzA+aEMnIuAUYJdG3sp0idH1AhtqaqdLakuUyzBzMyT1R7AME/EUSqL9q82YH t1c9sY3c/KYZfYukAwjjUutVE3hbMCsGFcaMR71ScD//X1L5aTVQpLhoDKoX571LcfRqVPj22qy uAfuoGl+6GNzQBpLNIypaDJ8w69UenD719/Q7NYMiNIrI2aj/hw X-Received: by 2002:a5d:64c5:0:b0:47f:f3d4:26da with SMTP id ffacd0b85a97d-482f79c1888mr5437392f8f.11.1787900781432; Fri, 28 Aug 2026 00:06:21 -0700 (PDT) Message-ID: Date: Fri, 28 Aug 2026 09:06:20 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH 12/12] x86/nSVM: address Misra 2.1 rule violation From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Nicola Vetrini , Andrew Cooper , Teddy Astie , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= References: <90d0e3d6-2e12-43f1-815d-7936ca4c5fc6@suse.com> Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <90d0e3d6-2e12-43f1-815d-7936ca4c5fc6@suse.com> Content-Transfer-Encoding: quoted-printable X-purgate-ID: tlsNG-720697/1787900781-F04A62AC-AE6828D4/0/0 X-purgate-type: clean X-purgate-size: 550 X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1787900797113158500 Content-Type: text/plain; charset="utf-8" The 16-bit range of "port" is fully handled by the switch(). Therefore the default: case is reported unreachable by Eclair. Insert BUILD_ERROR() to annotate this for Eclair. No functional change. Signed-off-by: Jan Beulich --- a/xen/arch/x86/hvm/svm/nestedsvm.c +++ b/xen/arch/x86/hvm/svm/nestedsvm.c @@ -845,7 +845,7 @@ nsvm_vmcb_guest_intercepts_ioio(paddr_t ++gfn; break; default: - BUG(); + BUILD_ERROR("I/O port range not fully covered"); break; }