From nobody Tue May 21 19:56:47 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=suse.com); dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=2; a=rsa-sha256; t=1660895416; cv=pass; d=zohomail.com; s=zohoarc; b=GL6YqHQ1A9SmQfLhD88xhV5qppdHPXlH8zNjH9thzdPxLq7zMI7YB+runR+0men3Tw65BnsDY0s2bR4s+adMZGOlLxaUfGe/xH6zA3YA2JDqGJOC51D2En23oVIEyzeJXFLPK5dGy00Z/gU41jKlqpwpHZyr4XEY+Zec/eYDj1M= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1660895416; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=A3RXVG+eaVf926YK1W8KCyqneq7P2OQCjFonkAYO/ek=; b=leyzSD+NyE3C+P3rJsIdNSmmtbRI+Y4KqJQeh5kM/hqrFOiVMuHNnnLp3PR/qHnoC5XQigk5pgXr/WkM1VKYQLq56Ug2NL08VdUSROkk9/X81U3CQPgbSOMuBydDfKJzaActlYO8hrut5/N5VOxFIg6hjvoY5L38T2vQx4tbn2I= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=suse.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1660895416940950.2856126194513; Fri, 19 Aug 2022 00:50:16 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.390053.627236 (Exim 4.92) (envelope-from ) id 1oOwlS-0007vn-0w; Fri, 19 Aug 2022 07:49:58 +0000 Received: by outflank-mailman (output) from mailman id 390053.627236; Fri, 19 Aug 2022 07:49:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oOwlR-0007vg-UB; Fri, 19 Aug 2022 07:49:57 +0000 Received: by outflank-mailman (input) for mailman id 390053; Fri, 19 Aug 2022 07:49:56 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oOwlQ-0007vW-Nt for xen-devel@lists.xenproject.org; Fri, 19 Aug 2022 07:49:56 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2066.outbound.protection.outlook.com [40.107.22.66]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 84142997-1f93-11ed-bd2e-47488cf2e6aa; Fri, 19 Aug 2022 09:49:55 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB7655.eurprd04.prod.outlook.com (2603:10a6:20b:292::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5546.18; Fri, 19 Aug 2022 07:49:53 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2d5d:bae0:430f:70ad]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2d5d:bae0:430f:70ad%4]) with mapi id 15.20.5525.010; Fri, 19 Aug 2022 07:49:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 84142997-1f93-11ed-bd2e-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=C9jU7UQEEEUBuISkTU24kuI6qDygnXYuE7GakadlFbfV0cz37IT2cS/0aWR+86ld7oHVuUwYS63h9DIbpG4/lhGDdeDfRLciVQNpuNBE40dO4XbPTF4555lFUCzdISQKoiQqBzD24nQPVb3DWalQQz+rXkx0OPBhvPLBJdaamr6coxDwaqFRUM/jvpcJyBUd8Z1TBg7BAb6dLUF6F9ou41D8s4nvzgQPJMG26tvfEBxwShetsKGNjprYFi8WuxMBP7tKD4+6l5hmgAM463ZeVbAVCySO4DPduPYickTpisuQmnT3QlXwm8YvTgAU7IpnEwVSoajgcAnHg6MWEBhtnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=A3RXVG+eaVf926YK1W8KCyqneq7P2OQCjFonkAYO/ek=; b=PdN3cI+DFcv5swa5LDbGUulF6aVcsrBunWFFvDAhaJajP8IIG7wTN+RM/fn2grfOyEWb5W4MPjCs/oKHmCcteq71UrShO4613T3ZPw46YLxKyvjJ/ft/I88nH7ZZGfr54WmBtLFA4KfVQMKOu/9gyV9Uzcvd4P4xyVkEDT+CzUMKlnCuW4nZ6ZFXcxWTJR7kKV1Lv2x1jMElrDFddYsDqrgmixGLw8TL5+ajZoGE6ID/Vpakp+0A37DKcPXJJiY3L5DNotvFoDHzptUtF3N5FORiH6NDJ2TBhvNFt+lqjg50+lC8yAd7qXyxeD4BkVQg6VXriSR6Bf9MAF5gqd5pqw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=A3RXVG+eaVf926YK1W8KCyqneq7P2OQCjFonkAYO/ek=; b=c4p6p6dfmKIqv6Oh6uCVrSbzLasSdgjRyQEhkcl7mZqJ01aLPbkVIgvOhXCcUO0T/tItvJWLvclATKUOl4yx7V6pYGS9o2yeCGmjgtSHj4iahI6dd1B6Lan9TWDj+U7BnXpRLH8CUfRbnAi7qteDP/vPfUQtazkIDjK5TPS1rKbHqPmL9A1dcGm4dKrTs2U/SiL2H3uBnnsWceo1FZT/nf1NGNUGY3/CpAKQGf6s+A5WnkMh/e286WLKyFu7vdQ7o6AnNcnQCKW5YOlApWWySFO8GzpMsMX/6ouNlpbxnMbGL1NK6M9EBnKXmUud3xWPmzulxSrDLaTPl0IgfXV5GQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <14e9bd8c-3f4c-4d7c-401a-c9de7b483308@suse.com> Date: Fri, 19 Aug 2022 09:49:51 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: [PATCH 1/2] Arm32: correct string.h functions for "int" -> "unsigned char" conversion Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Julien Grall , Stefano Stabellini , Volodymyr Babchuk , Bertrand Marquis References: <8e5df72f-2ed8-3bec-18ff-3da228ab9ee0@suse.com> In-Reply-To: <8e5df72f-2ed8-3bec-18ff-3da228ab9ee0@suse.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AS9PR06CA0133.eurprd06.prod.outlook.com (2603:10a6:20b:467::34) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: dfe121e3-f231-4bf5-f7c4-08da81b76724 X-MS-TrafficTypeDiagnostic: AS8PR04MB7655:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: nx+akOKrmMn8xTe0LC2hdtELXOYglTRZ3zFvyGw6skJhN6Kuj08AQIO8f531eMu5QgXLO/RXE1hyEmBYDDaRLRJFZ3w55UF5Hbj+vun2a3NsGkVu13fgqn4kSe1vrt/conqMpoZkNl1vxp7PRnuqPDr6cxPjQyEtBmwm4nnvPri5aewlB3sCYivEuqIY5DJ+OsGrcXGm6SSfyRH8wpnAJh8FfNs462EQD7caMwJwYsoVFTLUaejoT+AZLhXOXfU/RtiVk1kAt+BJzH8cRdi04N4FFBEpEX8s3vTqvv5UgJZP5PnL6ARR+xRug6VaRIqIAS9Y8oPczDOEGyhDLRmDXbkqgEqAFbiw/JhCiouOc7aM9xGZitxAP0VaNe2RDrlS6APk+DQr9hHrgLONiQKflT36JqbqFe0/P6xMeYOxaioSF3LJXvrZ8Y6nZideq3PIZbURKQnN+cENdkde1luQHZphJ/+Fzq+cuEClQzDZD1CNn0ciJ4rXGqb1JR2YwOW2D8qfCQY24k0YzudBAdwoQbNNG2UQR9Q5IDN9cBe0wZH4E6JWjX7lXijJS2IL9M2/i1Q9fhYQdNZTmevr5DHyJ67MSYcarTvpbso2TEJ8vOeeEAJS6Jrn+40wBR/fSv4rJSvYQcbsF7AXfZLSuGioqjDfR+QkqgLqzjkh+iNQPN4UK/bUhpwbZurtB2S4JgG4EEBtqxNJ68YDBn9DuZauCRwLO3QBhYtH5x7S/5Hw+e+G1gyni8s60Wp146RkN446iz9Yy7EZ7WgaOVVdIWeRVgHySbzvbecq0LZ63xxI3e4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(396003)(136003)(346002)(39860400002)(376002)(366004)(6506007)(26005)(6512007)(86362001)(31696002)(41300700001)(6486002)(38100700002)(478600001)(2616005)(186003)(66476007)(66556008)(66946007)(54906003)(6916009)(5660300002)(8676002)(4326008)(316002)(2906002)(31686004)(36756003)(8936002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VUFCU3JMaUw1NkYzYWV1b0pSQmJ6elh0WXRLRVM0RnRoTGVrVEdPOFF0bE9J?= =?utf-8?B?RUhKY0xFOEdkc3pkOXkrUTg1dkNlZmdEdGFIUkRXYjhraDl2OXlpUHJPK05V?= =?utf-8?B?ZFhFbXhOcWp5OEcxU0c2cmlzTzlVTGFTc0xMWk9LdzBrQi9sZ0NuRmh5SkVO?= =?utf-8?B?WDdMYmMrODJjSk5ENDNucnlaOTM4WkFzQUl5bW0rbnVObi9xQmVzTU9PUDdi?= =?utf-8?B?L2tiQTBGcGhoeG9RbUJxK25UZFZvdW9SdUpOc042WVZTYVNRK3JGQW9oaGtY?= =?utf-8?B?d0R6Wnl3VlkwRmJ3QW5iYWxzVTJXSktTUzA5YmVKWitTRDM4QmJBL0JiZWM5?= =?utf-8?B?UjFVbGV1cDI1Z2FsQnp6WFlWTUdoZFVXbTB1ZlFod0VFU0ZBd1hyL1FPcjRV?= =?utf-8?B?L0JEa0ZEeTRzeUIzNlBSMkpSekR4dlI0MTgySDVBYkJaYmpSQUdzK25OekYw?= =?utf-8?B?UXVyWWZoMVo4ZVNsU1JaOFZQek1LRjY5SHFyUVpIdmlDN1dySDBKQUoyV1Ja?= =?utf-8?B?dDRCT080YlpSVXJLMHhnTzllRkFNQVRqREVjRHJlUWNlTW1SMGw2bnFTdnhs?= =?utf-8?B?T0k0Q2pTZUd6dEhDSFZYVFZ2MHl1eVcrTDdMdG5QM1JQOEJ4ejdXZkdubS9V?= =?utf-8?B?a3Jac0hFUmtPSS9MMFplVmZpWWtJS1h4UHpucEpSbGhHRjYxSHZmSFhrWHlW?= =?utf-8?B?M1ZhYXFQMmpRZnFyUngzREt1cDkzUmx2NVdEUlZaS2VKOVBqSWw4YlpTeWNP?= =?utf-8?B?RHJmNTNpSGtHT0haRlU1am80Yms2OXd5OWc3cThtdi83RENvQmNnMTdGUlJn?= =?utf-8?B?Tmd4WHp1RW96V2xha0EvRzRSeVlSeWM2eTI3R2huaXhHU0hjWVdtY1lSeHVL?= =?utf-8?B?RStKZWxwZVZCdXAwWk9xU0VaYTZKc2ZOWVFSNXlSaHI4Q1JXQk5nWTgxVFhl?= =?utf-8?B?TldvRFpuZXp0MEIra0NKSGx3WjBnNEY2RnhSU1RlY1FpcWtGVGxaWk4zSDVa?= =?utf-8?B?blhkakJId0s5R1BPa0JRMmF3T3ViRWRXaHNWcDNjOXJ3c0tKS3RPK1FhbzBo?= =?utf-8?B?T1RsY1FzcFRMRVptcDJseW9NYW1DZWVya1U2allHN1RJSUpYU3N3M2MzaUhX?= =?utf-8?B?QThsNWw0czlzNnk5MUNMdHhGcFdxYUIxQ09tUEZ1S1ZGdmtGa3ByS0NVTXhP?= =?utf-8?B?T2FHRWFwVmhKTENuQTdSUG5vT3VWOHRNMjRuUU5wS2VFeTlvL2FtQnVGVmRO?= =?utf-8?B?cmpzQ3Y4bzhKcW1nZ1BLMzQ5L0dPMDN6V2tKQjR3eWdkS1owTExZY0hjQ2FH?= =?utf-8?B?ZmhxT0pQMzk1bjg1alhuRnRKN2Z3QmVjdWg2elFlWW9Ueld6dHlqN1E1b1JG?= =?utf-8?B?bzc3YlhNNmVKellhbDFpT3pxVVZ0WUVUbGtYd3lQd1RkR0NaT1BuQnlOZDQ2?= =?utf-8?B?OUFmdlhzdFgzSEhpT05hN1dGWDk3dmdPRXUzT1UyeUNEc3IxZFo2Vk9TVXBW?= =?utf-8?B?bTlXZnZXN25KWnYzOHIxUjM4VjRaaVRWWDAvbDZPazBOK1ZIcGFlcDQxbjdr?= =?utf-8?B?bGg1S1Q4UzI4VWd4S0ZRTENxR0hCRlRTMDV3YWc3b29aSDhQTHRFOVA1M0RO?= =?utf-8?B?RHlPcEhtNjVDeUtlcWtlV1BsWXdQd1c2OGZOa1dqVXQxQjNCMTcrT3hrNjk5?= =?utf-8?B?cisrMDVBbldBelRaRStIV0NDMGJTYXI1VkI0cU1nQ3d4VE1ET1FtMndtMHVh?= =?utf-8?B?QUtSTWVVVldEcnRSNTQ4K082cnYwRFZBRWlXL2VnZUxSeStIa0pWd2dlc1JR?= =?utf-8?B?T3Bud0FONzJkVGp3V3B3UXpudjYvNTRFWloyT0J5WWprVlh4bTN1UmZhZ3ZD?= =?utf-8?B?TjRCOFpocGNhaVNrN1FZNEtua1pqY1pqelp3bHVGNlFSbW9vaEo5WWdBVURx?= =?utf-8?B?QVdkRjYzRHpScXZxNTQ2N05CWlJ1Rlo0emhPUi9xTWZnelBlS3pYb0xaZkVk?= =?utf-8?B?c2g0WlVBRWVTV3pEYmliRHo4YXVwYWUzNUNJS1FFcnh3bW90NjBYUitKVmht?= =?utf-8?B?a0lRUjk0RFl6M3ZDOXQrdWZqa01GZDFZMDM2bWdteXYyK1hSek1YZ3ZNemtp?= =?utf-8?Q?08kjaoy6T1n9l/V3LS2hoJYO8?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: dfe121e3-f231-4bf5-f7c4-08da81b76724 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Aug 2022 07:49:53.7226 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bcOMmDrAAJ0L0pswp0m2bQOVN0hLfXn4KS2/rL5TeZhRrb0F8haOzk2tJe4aRnEowh1/9wFfytcaR37ptaJBXw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7655 X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1660895417840100001 Content-Type: text/plain; charset="utf-8" While Arm64 does so uniformly, for Arm32 only strchr() currently handles this properly. Add the necessary conversion also to strrchr(), memchr(), and memset(). As to the placement in memset(): Putting the new insn at the beginning of the function could perhaps be deemed more "obvious", but the code reachable without ever making it to the "1" label only ever does byte stores. Signed-off-by: Jan Beulich --- a/xen/arch/arm/arm32/lib/memchr.S +++ b/xen/arch/arm/arm32/lib/memchr.S @@ -14,6 +14,7 @@ .text .align 5 ENTRY(memchr) + and r1, r1, #0xff 1: subs r2, r2, #1 bmi 2f ldrb r3, [r0], #1 --- a/xen/arch/arm/arm32/lib/memset.S +++ b/xen/arch/arm/arm32/lib/memset.S @@ -21,7 +21,8 @@ ENTRY(memset) /* * we know that the pointer in ip is aligned to a word boundary. */ -1: orr r1, r1, r1, lsl #8 +1: and r1, r1, #0xff + orr r1, r1, r1, lsl #8 orr r1, r1, r1, lsl #16 mov r3, r1 cmp r2, #16 --- a/xen/arch/arm/arm32/lib/strrchr.S +++ b/xen/arch/arm/arm32/lib/strrchr.S @@ -14,6 +14,7 @@ .text .align 5 ENTRY(strrchr) + and r1, r1, #0xff mov r3, #0 1: ldrb r2, [r0], #1 teq r2, r1 From nobody Tue May 21 19:56:47 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=suse.com); dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=2; a=rsa-sha256; t=1660895446; cv=pass; d=zohomail.com; s=zohoarc; b=go+VdQiRwaoNHdoWrHv+la5jUNIw/Z1hGRf5iAoes98sQ4ysk2jy7depuMjMn2tkf/9UucTgrLn14OQOtIsWyxIkZf7P47azLmBg5/I4+eaLdiaatYHuHIYDKahiXsbp6qgGDQqDGSxjMypkoabD8v5sxoECThGpFuOcMRFnzQ4= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1660895446; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=bflGzSbGwtVrTpLswCHuwtkvvy0efCiqZEXeFBXqy0E=; b=RUQ285UG4IAUUiSckXQVNyRuyOTByoU36GRI9/d3qZjW/TuaolFLeu5wQ6hDXaU8eSWWXG30eboa5GuHI0K7oZY6Xgp2kE9RldyljfYGZiAKW5ZFi/KWoErNQqYAU8Sj09W8cL0lb93/Vbb0OO3utcIwlL9c+0nELtdi34RSkbc= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=suse.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1660895446620270.3748417996087; Fri, 19 Aug 2022 00:50:46 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.390056.627248 (Exim 4.92) (envelope-from ) id 1oOwlw-0000m0-98; Fri, 19 Aug 2022 07:50:28 +0000 Received: by outflank-mailman (output) from mailman id 390056.627248; Fri, 19 Aug 2022 07:50:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oOwlw-0000lr-6X; Fri, 19 Aug 2022 07:50:28 +0000 Received: by outflank-mailman (input) for mailman id 390056; Fri, 19 Aug 2022 07:50:26 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oOwlu-0007vW-15 for xen-devel@lists.xenproject.org; Fri, 19 Aug 2022 07:50:26 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-eopbgr130044.outbound.protection.outlook.com [40.107.13.44]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 95a11e3f-1f93-11ed-bd2e-47488cf2e6aa; Fri, 19 Aug 2022 09:50:25 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB7655.eurprd04.prod.outlook.com (2603:10a6:20b:292::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5546.18; Fri, 19 Aug 2022 07:50:23 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2d5d:bae0:430f:70ad]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2d5d:bae0:430f:70ad%4]) with mapi id 15.20.5525.010; Fri, 19 Aug 2022 07:50:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 95a11e3f-1f93-11ed-bd2e-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=B46+e6JIEynXpj2p6Bbt4Dy3Fx34r9h/JKIBe7czepM3fBPBow76H0Y0DAQyNr3snu0c9e1VfqkIHrVcx85OD8Bp7iM9Uwbp4S54ssWUJ+xqzryBJieultmZ1QgZoGgk8CZJMOIb8MSnerCmID/m1ggNWAPcgsEdyKFdCSFSXc4+O8vEIx2A1/cjlZtL0G80a3BuWVKRRILXCg4lY4fIf4fb5+CQPLQXsixSfiaYnO4Dtg1ksD0k44tSpdYXQjZvR922SjNopLcNJBOEzCMMeR4QcJmF1AMhVszeWk0/bgiCrQ/jtgZdN/wjJnjZjOVkWFCOHC/kLNTjf61iW5Xm3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bflGzSbGwtVrTpLswCHuwtkvvy0efCiqZEXeFBXqy0E=; b=kVY3FQs8KXWB/lgbjdkR8FMrNbxHUX/GqBaSa2/+i+4aEwcq0evnv6jj7i7gN5Ugd+BkaPGftKl+VtzfPKjx/QACfW5bjc9FVNC6CmfNpA/alyuCEw4r22TZDFy/R+Wcet5GQv/WPj2kqf2ircPxwPeNlvvr6BU4k+yjs/nO/L/Rz46SJkdxGJctKRkGaq4AMCiTVauMio5VSO/rzSOq8Obnp5Z53qm66GYQVqdsjRTgsHaSVwn0ahmPX0SHVNcfD7lqnZL/ZyR2/YNXPu/cx7ePAyAOzaRfTnh86Xbf+RspuFoQrOykIcMI6m7B3PAURjkJyYbpM4H9Friy3ErkIg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bflGzSbGwtVrTpLswCHuwtkvvy0efCiqZEXeFBXqy0E=; b=pDW2YXkVqDFKeLkmOdDhe5QnFXFYAyde5DiYIdgv8HT0uHNzVeBdybAt0LSBXkDblBWsgoYt1perTxL8RdMBWQRl/qOsM9utNAskqlDuyYl9n4us5CSuPOOj3QSGKNjC1tBhgEXNtr5/c3oIe0WkmFA7DMzGOT91Y9tLrjGut4S97SSM/EZTisnB/J5/KuOH/4vvlJIP1qWstltkkYoLxVZSPlCBBTYBqv6NjUpwoOvPrZA0BOUJmX0Ahm4RxeMSb5HnVtRt/y3CZ9E5HEaRXsjWSrI+L9H7cH9VY6G6bpfFt0dZ2QbvnOT+9H8eM20FU9wcQQayaIr3tfOs+lVm5A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <80abb94d-67d1-ef71-afbc-4d0bd9d8a557@suse.com> Date: Fri, 19 Aug 2022 09:50:21 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: [PATCH 2/2] Arm32: tidy the memset() macro Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Julien Grall , Stefano Stabellini , Volodymyr Babchuk , Bertrand Marquis References: <8e5df72f-2ed8-3bec-18ff-3da228ab9ee0@suse.com> In-Reply-To: <8e5df72f-2ed8-3bec-18ff-3da228ab9ee0@suse.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AS9PR06CA0143.eurprd06.prod.outlook.com (2603:10a6:20b:467::20) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8b181504-47f8-4ac5-3c00-08da81b77912 X-MS-TrafficTypeDiagnostic: AS8PR04MB7655:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1r9bfw6x3k78h2TlnQ1Bb+RdrhLC5o+sLHxkY7ONxK8Xe7zov2f+3N2ZvfU3lVSXlUHd57soRKczzijtU0mElWMvdRnnhrPqNHM2ulxkk69fcR/XOl7kC/8zPC5jtBf97mDmqn/BCs9XM8U1oB+M1STWOtsTXqtu6y2VZGCwIxl3liGnwnivhPd1ZBsyusd+1BITa0B+QQ5bZsnEjIi0HWYr+CGNmiPDc8AMLxzzbQsTvpbeSWo2wkoHLCtVaYdIixLgdlDCGKiwFn7bfbkIXhAxxPKB4GKE2b8gJMv3bBIoCxHIOeDcNaTP4u5Dmiko2XiyeKrI0qUsIpW6nxMJBA791BU+Ej/JJBgfHkd17fhIDPS3giSCwFA1BOKwZYvwvrMRV2baPBaElbzLK4ES4yg74z5bqmK6ua0wrpniby2MxcLneoq6D1WzCzocG3+1zZI1Frqqa0bq7OaVPIna2+miaB4f5zaXvtiZiEdlZfgO1nDJthZ8gxaWk7xV6/7Lzcvoe0b16+a8FkzpyJXWOO9geDlTwt0VQcNJfnVrrN+a8x+AvWCi9vh7Wbk0IDrfsjxJR1XzHAsZkxuuPupM4wKO/sqcbCHE6TjC4YU9GenheeuznQZSrk7DoexuxEffA9jhEN9my+AgNIZye6XV5vLCzz4EZPcwNGfCRWaxcjrF7a0HUYzVSuKJ7GrXlFE4ttzCRoOPdDBjE6rD3qV05IkrYzAVVDQA89dOz0NIwZeW7fg40HDlletRIfIfi6rzQmHHdc3V/0FO8FCYSZ6XDqSktW8XIEQUJJtr96e31GM= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(396003)(136003)(346002)(39860400002)(376002)(366004)(6506007)(26005)(6512007)(86362001)(31696002)(41300700001)(6486002)(38100700002)(478600001)(2616005)(186003)(66476007)(66556008)(66946007)(54906003)(6916009)(5660300002)(8676002)(4326008)(316002)(2906002)(31686004)(36756003)(8936002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ckF4TTh5NHpkc3QwZGZqeTh0Mi95MmdiU0d1S2J0K0xtVVJUVGNJNFNmYk40?= =?utf-8?B?cng4UVM5Zm14Z3l0TnRFRzZxbndRVlRXSlJsN2thLzAvRjJQMU43THpCaEtv?= =?utf-8?B?Ulo5SUw2UkROcGhHWUlvL2o1ZDNIaVB5eVBoaitwQlFtZnpkRWVYVWFmNnBr?= =?utf-8?B?K3l2OUhsTWZtTFpSTmRmb2g3MEtEN3gwaW9IZ2dwMFNCYzZmU0NCd0wyMi9o?= =?utf-8?B?S3JOcHZ0cmFFK1QrYlVTVDA5NUZnek9lVFlKZmQ0OWN5Y1NvRUNCRUN3Tysr?= =?utf-8?B?ekZqMWs4S1cvUHlwTnF1ZHRNQlRQQzNzN1dsZnlSdmNFY3NCbFpNWGoraFB0?= =?utf-8?B?WjhOYVI4eW0wNEkvQmVpS0Z0R0dmYjIvVjVzMFNuRTZ4Rkh0Q0VaY1paaUJL?= =?utf-8?B?c2RMWlZ0TXpGdmlwd1BkdkVNd2tqUzJjU1RhS3ZtNm9XV0ZtNE1LS1pnYllB?= =?utf-8?B?MVhrS3FpWlh3bUEvYUVjZVZvcDdSY1l0UjdUajdwYTZ2T0FGcWlOYlhYNzc2?= =?utf-8?B?ajhkb2VaTHRGbjJFNy9sS0tJK1dENVdkNVovcjh6WGVYZlY4QmowNmZmVW1S?= =?utf-8?B?aFFSaG1DVFdDei9lekc2MG1lVzUxRFZrbWR4Wk5oQVppQ3J5dlJIcU1BTng1?= =?utf-8?B?SFU5enhMRzhtdSs0TUhwMHNjcHRFUm1xWWdaU0o2eVJOaTRyQlVWUzExKzFj?= =?utf-8?B?R0VXb2h4S1pTMkgxcm02TE9WbkJ4RzNaTnRrVXl4ZE5BRnNoR3F1SGNHNVl2?= =?utf-8?B?dEZVSytlUlQreko3VTh5cU40Z0tpekFIVWt5elg1Z1IwYjdjajJBdHg1bmh5?= =?utf-8?B?bm1RVkFUZFV5bUNXMXFiN1VoQzhkVllRaEE1elgrenQ5SUZtMXF5K3NWcUEx?= =?utf-8?B?aTV4cTlpNWxjOUhQbkJCQWJLVTVQYUQ5SlVkUFZRRWdSSU9zQmtJVGplNVU5?= =?utf-8?B?c3ovVkdrNHN3RGN5QnRPZXlPdDNOZDRVdWx1eE1wb3BrNGtwVlQ0M053dGRY?= =?utf-8?B?ZmhUOTVzbVpXQlJkZEtic0dIbGd3aWEwZlkxMGVDK3hVMWd0aUd3cnEvZEs4?= =?utf-8?B?cVc2UWdld01SMVhiUU1YdUZqa0Z6K0NJSU5JYXp1L0lHa1VZYjE5ZGJrTTVy?= =?utf-8?B?REsxN1g5Mzh6M1ZhRllBdHoyMmlSbkF3eUgxNGZ2dytaRGZRTUV4YXpzd0k3?= =?utf-8?B?M1R2b0RwWHUvemUza2FERmg3dmFHb0NHdFEyL01sYmhaVXV3M01kRThSMDV6?= =?utf-8?B?dWZPaG85Ung1SGlOdzUrY3pOTmZodGs0QnpBZkx1YmxsQjF0NTVSNUE2Vmg4?= =?utf-8?B?ZzNzMU5KT1AzdmRrS2Z3Y1ltQTlMakNZeUdrNU9Ud1lKTzlFZW1zZ2hsc1pm?= =?utf-8?B?R1hOQ3ZsRVpaWEoraEsreGo2WUZCb01hUk4vOEIvUHRHVlNFVHd2aFZGeE8w?= =?utf-8?B?b3owOUg5RmxVTGlqM21BMWJ2Mk9abnIvUGU0OW5PNy9iVEZheVRwb3VNUzhn?= =?utf-8?B?R2d1QVFHSWpWa0V3ekpHRWJJd3JuV1lDME5yMzlvRUgzZEZ4R3MwdXBWN1FH?= =?utf-8?B?bnE5akJLbEYweVJDRDBLV2NtUjdIQWswSVN5THYxNGZlblJtVmxWQzlpcndL?= =?utf-8?B?YnZuVEw3NXpYUXRKcEsvWGs4WGFBZEdyTFhadVlLWWgwZU82ZnpzWkZHbUYv?= =?utf-8?B?NGFVR09OYnhNN3RHVy9lWFVKa0plSXdJY016dThEQVAzb09EaTR1bkh2Y0cz?= =?utf-8?B?VkkyUm01WmV6TGVaenRZQ2RZQmpEZTQ1SCsrUjNhNUt2bHpLNHdZZkpHVVRR?= =?utf-8?B?MmFFTEdvWUhZL2VkMklPY1lHQlVwNjdPeTdPelp6M3BTK1Z1QmlRaFBKWUx4?= =?utf-8?B?SkwwU2lydFNnS2pXNzBXSGt0OXZvbUxaMkxnWkhKT1ZmQWp0MmpqN2NJcWVk?= =?utf-8?B?U3J5NkJkQnhVNVVqSkVuVjQ4Vk5KeGtuSFFYZnpjU2tyelNsM1VYaVZoclph?= =?utf-8?B?akN0Ky9RS29TVzhwUXVYbkI3Ny9HMWtMb0xUYXpvOVRBKzVGc2RsbERqNnVI?= =?utf-8?B?VGZYN1NMRVdDZjZIaWZoYTZtMEtGMEpxbk81VTRKcFh4cFhQNkl5Mi9LcC9n?= =?utf-8?Q?0/2ga6YfZA0zn3g+VAMKwkeei?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8b181504-47f8-4ac5-3c00-08da81b77912 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Aug 2022 07:50:23.7989 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /4R+5+5gycNrM7NpsEOJFu+cQTSk6MDyxYih7NePqJaoTi0ZwyjYUzpZtC6R+Mh0NXCEhmakqnUBKpJPa2vIEw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7655 X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1660895447851100001 Content-Type: text/plain; charset="utf-8" - add parentheses where they were missing (MISRA) - make sure to evaluate also v exactly once (MISRA) - remove excess parentheses - rename local variables to not have leading underscores - apply Xen coding style Signed-off-by: Jan Beulich --- I wonder whether "if ( n_ )" is really helpful: It's extra code in all callers passing a non-constant size, just to cover a pretty rare case which memset() is required to deal with correctly anyway, and which __memzero() also handles quite fine from all I can tell. --- a/xen/arch/arm/include/asm/string.h +++ b/xen/arch/arm/include/asm/string.h @@ -28,17 +28,19 @@ =20 void __memzero(void *ptr, size_t n); =20 -#define memset(p, v, n) \ - ({ \ - void *__p =3D (p); size_t __n =3D n; = \ - if ((__n) !=3D 0) { \ - if (__builtin_constant_p((v)) && (v) =3D=3D 0) = \ - __memzero((__p),(__n)); \ - else \ - memset((__p),(v),(__n)); \ - } \ - (__p); \ - }) +#define memset(p, v, n) \ + ({ \ + void *p_ =3D (p); size_t n_ =3D (n); \ + typeof(v) v_ =3D (v); \ + if ( n_ ) \ + { \ + if ( __builtin_constant_p(v) && !v_ ) \ + __memzero(p_, n_); \ + else \ + memset(p_, v_, n_); \ + } \ + p_; \ + }) =20 #endif From nobody Tue May 21 19:56:47 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=suse.com); dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=2; a=rsa-sha256; t=1661345243; cv=pass; d=zohomail.com; s=zohoarc; b=kUFoh7E0f1bppw5RrjVxx+P+oKzgumgBcyhC74KqbrPpzCOBMdjwctGtcT7yilpKfk15xH3ekDg4J2+Mvod4gkZua+PqB8lPMpuCEkIQneblhACk3d019YWK+Osesl6uCQLqxxQ/GgMpBvbHTPGRhjc7NMB+kPd8QVvfGahqBDA= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1661345243; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=YjiSw0+oR37MnXYpyF2iC1Q6ey9w7qhXBSA03B3hZe0=; b=aEkdbU6b3HyHX3ZJS0+/rD7+ZNHW04DD9f8aDThNfOTm2ewyRfz+SuncgKrHK1dO6xuc2UIUxNQu8WW2a388+G+Pu4Z6KuNh/I207tIl1D7gnBY6E/UFlYBBaULzn5+FvxAEv6OleujFlWYZo9UbPtIKCm+KkBVeT3bOVCu+6kE= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=suse.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1661345243637850.8069930693191; Wed, 24 Aug 2022 05:47:23 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.392556.630993 (Exim 4.92) (envelope-from ) id 1oQpmg-00079z-Sj; Wed, 24 Aug 2022 12:47:02 +0000 Received: by outflank-mailman (output) from mailman id 392556.630993; Wed, 24 Aug 2022 12:47:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oQpmg-00079s-Pa; Wed, 24 Aug 2022 12:47:02 +0000 Received: by outflank-mailman (input) for mailman id 392556; Wed, 24 Aug 2022 12:47:02 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oQpmg-000796-1o for xen-devel@lists.xenproject.org; Wed, 24 Aug 2022 12:47:02 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2086.outbound.protection.outlook.com [40.107.22.86]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d8ece830-23aa-11ed-bd2e-47488cf2e6aa; Wed, 24 Aug 2022 14:47:01 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR0402MB3796.eurprd04.prod.outlook.com (2603:10a6:208:11::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5566.15; Wed, 24 Aug 2022 12:33:08 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2d5d:bae0:430f:70ad]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2d5d:bae0:430f:70ad%4]) with mapi id 15.20.5566.015; Wed, 24 Aug 2022 12:33:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d8ece830-23aa-11ed-bd2e-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DK7OsHg7XeVqS303vF+WcYzgYVEN1+OW8X7I64+XE4X+6EfsvNPOmt8BFe3TRnPcac8rsYnDRdjDA1ON3+Hr/GX41CEXdzbYaauBXOpcQA3Bu2c266/QzmA+njKVm1O9nKwcFdHIHHHFzjp+wzMEDZifTCUL31++KjJw2njGeSQ6Bch/Joc0V7hBTZhjuwjOr7ud3v9wk/gLSEK/Of9ylVKWjhFQ9fSEOPN1JJLuFGr/oaXPYjioBbTUPW7/V5nzuQdYaWaBp4ocoSlDH3TiSOPMrxXaBNc5L6SsryYubub6aO0QopL+qLyWmdNA8zvoDq3lN9WG9Id49l9UnSCZhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YjiSw0+oR37MnXYpyF2iC1Q6ey9w7qhXBSA03B3hZe0=; b=DOaRJet8uaj5sFVuxX799DFfeK63r8VcmbQQ8TU6hdt5LhU2xZy9QkVLJmA8Xteoz7pb96qUX+0KKzXvb4GebzlHTYPNXSHypBdyiAHWV0tYJj79R/ep3G+nY784Lxsc88wwH2qM3TkRozpbnqHFbhgFLZDbK76IGeNOl4ZEgeZhq9PCAI0u4dl79BYv7I2viCkR1Tr4npYoG/jqODb3nZzGBTnBIZXNx8djqWOglWwumFkozDWVB6/a1BZAiWjYxWx0qICta1q7apPMhW76WGlEHh4UWPzBevy+qxFe92HkYHOlkmiPXApKuplSu2/GJOBDxC+Ia/p8NaRqvci+lQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YjiSw0+oR37MnXYpyF2iC1Q6ey9w7qhXBSA03B3hZe0=; b=G9afci9qJl1UE2i27LsYTv0JrKmrfYnk586UcRa84zBV/IY+syFjZO40GSrJPMG8b5mvdSmltG3kFmqz9ibQp9cMQ6iZLwBB83gmNOKr3yzR6x2jHpxry/7Sbo55kAjoi/yYGZ8Gh9hNd33PUy1IiPEVyOxVOgcwPV6cQwT/iExOXg/KLYaDoAd3yidNm++XCC4q6L/J1sWPxmJ6pW2aT9f1IAz5bP/HkEC8AVm1PSrINuT3Bhm5wSLwMMd9aOfpEkVj13E4jZ/xJtQ/9612a3qOyodZh6ykRdxUj0qZKB4FqCBMpaYlE6bCr5JW0jcmHggvI1J2UYaVL4ypirWhvw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <031ce9f6-ede4-f371-da04-ff8c2df209dc@suse.com> Date: Wed, 24 Aug 2022 14:33:06 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 From: Jan Beulich Subject: [PATCH v2] Arm32: correct string.h functions for "int" -> "unsigned char" conversion To: "xen-devel@lists.xenproject.org" Cc: Julien Grall , Stefano Stabellini , Volodymyr Babchuk , Bertrand Marquis References: <8e5df72f-2ed8-3bec-18ff-3da228ab9ee0@suse.com> Content-Language: en-US In-Reply-To: <8e5df72f-2ed8-3bec-18ff-3da228ab9ee0@suse.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: FR3P281CA0054.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4a::18) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3db1b082-9be0-4b84-2ce5-08da85ccccb0 X-MS-TrafficTypeDiagnostic: AM0PR0402MB3796:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: n3ON2sBECBSAppuV5NoYCf4/kHIc5w8F6ZJhbYctbWnlJwHryLCG5Oy+nDgHl08VzozK/I7RQhmYXfW++DCFybOClStJDUj5+W0Eb4qaJNk4nlkKITSqw3Hk+TTHNkQPqusPd5uGwLSh54YD83yLEyJFozRvjSazGyxDahR8yiPkzK5PaVP0iFz35ZwOrPh3xwcve+scUCBvjU8Suey16Jcsq1ijvvSHgedZPpCgOvQ80Nhm8TD5RdtRcJUgA6ibxGolYDGUQVqheOqPAaIjCXTLhzk/MhChmGNlxG7flqJJnugB3PvV07bg50qOLkkvipf+tE5fYn4nh5YgN0L0RinuyHxtL5UvEFKvehrd073VyK13MAvK41jrPmChFYkYlmGwiya1uD3ro1HGg7Azsfe7J/8qcHpOGn5pZlnaaB7TQl3L12mxW5ONXAmCcyxvQ/IJ6Ug7powTWF4I2ywh8+DZ6iBxhAXa1ujBRzG9IyEQxJS8Cf+jWfyHUi5JDJ4AmPHuRqZ+oGziMVrMNIQPJw+xy+DywR+AE87HN9hO97mPSZ/AML65mwY6vPz9gkovvhNMC3SWcQrxDgW0disBg27BXE3VkoZX1cdy3sAUZGr6zvHRKxV8s+2R90B/m7tbgg/7YsrE0hG270pZH5JqNsDkpJa9qQhRBWRoICEfh6K4Z5Ne3tah8OBWJmESEv9+btqMYPWBKdMvBWpjaxw4n3/p145ONFV4uxAMoDFWinMp61+3pIOyimD7mk/D4Ow8QS4u54dt/rWYqdWVD43BYxBFxCsdeacpSaMqAlek2/8= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(39860400002)(136003)(396003)(366004)(346002)(376002)(54906003)(38100700002)(6916009)(6512007)(31696002)(31686004)(316002)(86362001)(6506007)(36756003)(5660300002)(66476007)(66556008)(8676002)(66946007)(186003)(2906002)(26005)(2616005)(8936002)(4326008)(41300700001)(6486002)(478600001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WEFOTmUycy9XY2pNK1ZyVjZwcUZ3ekV0ZjdUdG13M0tGUUd1ejJoTmZYQU02?= =?utf-8?B?RGpMbVI5ZEhjTFBlRGN5RUJabng1dzBSOEJSdTRCM0FRalZEQWVXWmV6Um96?= =?utf-8?B?d0RvNHRBRDNWdXB1ZXpqMlIwZkN0UndYNVR2NWt6a05aaERaa1RBcnVKTCtF?= =?utf-8?B?aGJpTzRFdlJFYUxwVHJXSmNzWkwwMHhXeHBjVDNFam9RRmhCV01wd1VUN1dr?= =?utf-8?B?MHhhcUx5T1g5UmJhYUNhYlNzRFVqR0I3UjVtYkR3LzNUWjEwL3gzaU8wK1Bp?= =?utf-8?B?all0VzFQQmZIM283L081d3ZFU3R6cWQwVzBhZlNFTlB0V3FJL2lrWjVjRG9I?= =?utf-8?B?dFRsLzU2aVg2TklSUFhxd3ViMkRIUHJyTUlLN1djWFlYMVlOTWZEYTJ5OW9F?= =?utf-8?B?RE9UZ3p6OENGOG9EQ3A1MjdzeU9DV1VkaXkzM2lEQ2xwbzMyNjVQUWVna0VU?= =?utf-8?B?RkprNkxlbFVMUWxaV0R1WUp3ZjcwbEw2OE1wa2lFaUJhYllrR0NUenZ2R1FJ?= =?utf-8?B?NEZpNHRPTVhud0dGcmJib1dzT1Z5S0F2eGlQckd5bnZ2N0MrSDgyNWFPNDlV?= =?utf-8?B?Nk0wMzJER2ViYllaZDJrbFNleHF6UFBCMnVMaFlaLzNNdDlmSVAwU3pxd2VS?= =?utf-8?B?bUIwQjcvZThHdXNjYVM1VDNLdTFOZkVJb3ZMbGVCMzh4Mm5OTC9yVjI2aXhn?= =?utf-8?B?KzE5Szl0dDVGZHJ0ODFKODF1U2g1ak9MVWdKYzZHbHhRWWtSYWdTc1Ryak83?= =?utf-8?B?T0NkbGZRQ3ZDMWhKTEdZRzZWTEpJREgwQlRvTGV5c1B6MDBmUldGU2UyRC9m?= =?utf-8?B?OE0rQkR5YVdLR284TFI0c2ZQY1VzdU5laFZwNFFmL1dZMlVPWm9yZlRnTmFG?= =?utf-8?B?N1kwdEpPQ0NVK21ZZjNRdHNzbEJ1N3lqTDNYZUxEOWZoa2ZnRXlyTElOTFFD?= =?utf-8?B?QnZPeVpkSEs2MUlWN3hESzBwUGExY0pBRW5BSzBFUk5MOXVkVWR3ZXhKVXNQ?= =?utf-8?B?dkk4WTRzNUhEaEx4Z08xeE5HZHczUWx3dmRmT2gvTEpicnNsOEp5OWhWWkJQ?= =?utf-8?B?SHlKODlRZXcxV1NxMzZGTnBNbktQMi83ZHdXY2N6NFZWRDRxZWJOMTVRbGxC?= =?utf-8?B?M0dnRjJTcVQyTzJCcTI1aTlZeVpnOXJRNmlFUEdadkhBR0xua0JzV25jNmt1?= =?utf-8?B?aU9JT2w2NHZYZDM1U3lKQUF6cEN1bktqd1ZWajlDOUtzNGdkaUQ3d3phZkQ5?= =?utf-8?B?RGozb2pITW0xVVVUWER2aWwyYkRjOGtJTzBaU0lUaTlHZFlxbXJTTmNML2xy?= =?utf-8?B?dzA5QWMxcFkxMXdaMGFQQlc2UkdNY1ZqZG52ZkxndzdiU0dHcCtMOGNlT2pV?= =?utf-8?B?V1NkcmljWEJhVUI2RmU4b0lZdG1OUkc5cDBxbVhtZEVsbTl6b2N4eS9UbTJF?= =?utf-8?B?YzExYTh5TXZFSGlKaktrWElSWkQvenBUc21DNDduaW1QU2l6eklDM1NDY0Q1?= =?utf-8?B?bksrM1ovVTRESWFGb0FkMHJmNmpObERzaUVlVHp5YmtSOUFlVmxTN3J1SmRs?= =?utf-8?B?QjFjV0RPRmVBQ01YU2N0aktnbHFGTGl4c0NZZWpVYzFhV3NTOWRZekg0NVlm?= =?utf-8?B?SGJYdFRtb1ZudU1zellGd0w2b2llc2tTbmtQVEFBRGlDbVN6bFVJQTVoazBD?= =?utf-8?B?UllDdlNrUExaUWUyNnlKWmtBRkQ4SWJMODhUc296T2pQbmJKR3lKN1dad2ZH?= =?utf-8?B?SmZGWEhzSHhLVG5nUVZTVUYyM3dkcFVyM2psME1xY2R3Z3Y0L3BXS0lUT25Z?= =?utf-8?B?VFZJR1h4cEtCaXdPOXBFUmdzZDFrNUhGUy9IQU1nRndjV21vUEVXMVY3eWda?= =?utf-8?B?VlVFSHhBZVU4QlM0R29BMUplK2pIend1VWRCUXp3T3ZjVUJjM25aR0Vqc05D?= =?utf-8?B?QXgrQUYzTHh1d1g0QXI1dnBvYitjdytuTSs4MWdpSndxUW04Q1JSaTRkZVMv?= =?utf-8?B?bS9ta0wzVEE0dEdjZzR5NEpCMkthTHNCMzFUTndVclpkSE91cmgyWEZJbHI4?= =?utf-8?B?cHJick10M1lmdmFmamFXYUluOWcrS1FDck9iUGY2QThndlpNc3ZuM0l5TFRW?= =?utf-8?Q?eT/1wz8glDcNDe49vQl8eHLQV?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3db1b082-9be0-4b84-2ce5-08da85ccccb0 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Aug 2022 12:33:08.1985 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: mF1W2hznHrKFtbcEwgBkC+BFcleXJNkU9XvbVPdpnlKM/D5DFMub5g2QDyNypUDb6CPuf5LkVv7VTaNgpEcGGQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0402MB3796 X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1661345245720100001 Content-Type: text/plain; charset="utf-8" While Arm64 does so uniformly, for Arm32 only strchr() currently handles this properly. Add the necessary conversion also to strrchr(), memchr(), and memset(). As to the placement in memset(): Putting the new insn at the beginning of the function is apparently deemed more "obvious". It could be placed later, as the code reachable without ever making it to the "1" label only ever does byte stores. Signed-off-by: Jan Beulich Reviewed-by: Bertrand Marquis --- v2: For memset() use the "more obvious" adjustment. --- a/xen/arch/arm/arm32/lib/memchr.S +++ b/xen/arch/arm/arm32/lib/memchr.S @@ -14,6 +14,7 @@ .text .align 5 ENTRY(memchr) + and r1, r1, #0xff 1: subs r2, r2, #1 bmi 2f ldrb r3, [r0], #1 --- a/xen/arch/arm/arm32/lib/memset.S +++ b/xen/arch/arm/arm32/lib/memset.S @@ -15,6 +15,7 @@ .align 5 =20 ENTRY(memset) + and r1, r1, #0xff ands r3, r0, #3 @ 1 unaligned? mov ip, r0 @ preserve r0 as return value bne 6f @ 1 --- a/xen/arch/arm/arm32/lib/strrchr.S +++ b/xen/arch/arm/arm32/lib/strrchr.S @@ -14,6 +14,7 @@ .text .align 5 ENTRY(strrchr) + and r1, r1, #0xff mov r3, #0 1: ldrb r2, [r0], #1 teq r2, r1