From nobody Mon Feb 9 20:36:05 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1691492944706351.4798751978715; Tue, 8 Aug 2023 04:09:04 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.579643.907744 (Exim 4.92) (envelope-from ) id 1qTKZy-0006lY-Bx; Tue, 08 Aug 2023 11:08:46 +0000 Received: by outflank-mailman (output) from mailman id 579643.907744; Tue, 08 Aug 2023 11:08:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTKZy-0006jn-2W; Tue, 08 Aug 2023 11:08:46 +0000 Received: by outflank-mailman (input) for mailman id 579643; Tue, 08 Aug 2023 11:08:44 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTKZw-00068O-LO for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 11:08:44 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f022ab89-35db-11ee-b280-6b7b168915f2; Tue, 08 Aug 2023 13:08:44 +0200 (CEST) Received: from nico.bugseng.com (unknown [147.123.100.131]) by support.bugseng.com (Postfix) with ESMTPSA id 1193B4EE0743; Tue, 8 Aug 2023 13:08:43 +0200 (CEST) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f022ab89-35db-11ee-b280-6b7b168915f2 From: Nicola Vetrini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Nicola Vetrini , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [XEN PATCH v2 5/5] x86: refactor macros in 'xen-mca.h' Date: Tue, 8 Aug 2023 13:08:07 +0200 Message-Id: <8df1af6384606d8176525fbffb364ec814d48db1.1691492441.git.nicola.vetrini@bugseng.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1691493057914100001 Content-Type: text/plain; charset="utf-8" The macros defined 'xen/include/public/arch-x86/xen-mca.h' are revised to address the following concerns: - needless underscore prefixes for parameter names; - the variable 'i' in function 'mce_action' that is shadowed by the local variable in the macro. Therefore, the refactoring aims to resolve present shadowing issues, which violate MISRA C:2012 Rule 5.3, and lessen the probability of future ones with some renames. No functional change. Signed-off-by: Nicola Vetrini Reviewed-by: Jan Beulich Reviewed-by: Stefano Stabellini --- Changes in v2: - Added missing parentheses. - Clarified commit message. --- xen/include/public/arch-x86/xen-mca.h | 38 +++++++++++++-------------- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/xen/include/public/arch-x86/xen-mca.h b/xen/include/public/arc= h-x86/xen-mca.h index b897536ec5..bb1b12f14f 100644 --- a/xen/include/public/arch-x86/xen-mca.h +++ b/xen/include/public/arch-x86/xen-mca.h @@ -280,39 +280,39 @@ DEFINE_XEN_GUEST_HANDLE(xen_mc_logical_cpu_t); /* Prototype: * uint32_t x86_mcinfo_nentries(struct mc_info *mi); */ -#define x86_mcinfo_nentries(_mi) \ - (_mi)->mi_nentries +#define x86_mcinfo_nentries(mi) \ + (mi)->mi_nentries /* Prototype: * struct mcinfo_common *x86_mcinfo_first(struct mc_info *mi); */ -#define x86_mcinfo_first(_mi) \ - ((struct mcinfo_common *)(_mi)->mi_data) +#define x86_mcinfo_first(mi) \ + ((struct mcinfo_common *)(mi)->mi_data) /* Prototype: * struct mcinfo_common *x86_mcinfo_next(struct mcinfo_common *mic); */ -#define x86_mcinfo_next(_mic) \ - ((struct mcinfo_common *)((uint8_t *)(_mic) + (_mic)->size)) +#define x86_mcinfo_next(mic) \ + ((struct mcinfo_common *)((uint8_t *)(mic) + (mic)->size)) =20 /* Prototype: - * void x86_mcinfo_lookup(void *ret, struct mc_info *mi, uint16_t type); + * void x86_mcinfo_lookup(void *ret, struct mc_info *mi, uint16_t mc_ty= pe); */ -#define x86_mcinfo_lookup(_ret, _mi, _type) \ +#define x86_mcinfo_lookup(ret, mi, mc_type) \ do { \ - uint32_t found, i; \ - struct mcinfo_common *_mic; \ + uint32_t found_, i_; \ + struct mcinfo_common *mic_; \ \ - found =3D 0; \ - (_ret) =3D NULL; \ - if (_mi =3D=3D NULL) break; \ - _mic =3D x86_mcinfo_first(_mi); \ - for (i =3D 0; i < x86_mcinfo_nentries(_mi); i++) { \ - if (_mic->type =3D=3D (_type)) { \ - found =3D 1; \ + found_ =3D 0; \ + (ret) =3D NULL; \ + if ((mi) =3D=3D NULL) break; \ + mic_ =3D x86_mcinfo_first(mi); \ + for (i_ =3D 0; i_ < x86_mcinfo_nentries(mi); i_++) { \ + if (mic_->type =3D=3D (mc_type)) { \ + found_ =3D 1; \ break; \ } \ - _mic =3D x86_mcinfo_next(_mic); \ + mic_ =3D x86_mcinfo_next(mic_); \ } \ - (_ret) =3D found ? _mic : NULL; \ + (ret) =3D found_ ? mic_ : NULL; \ } while (0) =20 =20 --=20 2.34.1