From nobody Sun Feb 8 16:12:52 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1606328233; cv=none; d=zohomail.com; s=zohoarc; b=X20Qdx99hmD7XD+Ph+2hoUO+8aXV0X7xuZdSPurxitwI+PQ5riKAzSsZOIAGXlk1TGusIje81K0IVza4evtpldpm1jSl37ZzdDe37TS54doWTnLVWraDIScbzdLD8evReYNOHFBkYHy1MoDSGSkQytAEPJIekZwQrZwrFqVoDQg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1606328233; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=pDJ5jQDnMuelr009ngl7NbNVbQedVfmHYDt2wSOCZRM=; b=dwDOC2i/irXDFIZJP97QpGIy0Gbq21VCXprCsR3x1gASTlaQWYg+euR32N6xryaQ21WZe/gxm3L933eXr6ytOtfKeBdXbz2yByvUgk1TRgTatT+c1kr9GRMCeSa5cL2dZnDsjxtlqSSsyDCheOyAocZsFZOAWQdQFlGNtLdAFL8= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1606328233157691.6918986215454; Wed, 25 Nov 2020 10:17:13 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.37955.70576 (Exim 4.92) (envelope-from ) id 1khzLg-0001a6-Fc; Wed, 25 Nov 2020 18:17:00 +0000 Received: by outflank-mailman (output) from mailman id 37955.70576; Wed, 25 Nov 2020 18:17:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1khzLg-0001Zv-BZ; Wed, 25 Nov 2020 18:17:00 +0000 Received: by outflank-mailman (input) for mailman id 37955; Wed, 25 Nov 2020 18:16:58 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1khzLe-0001Oz-9f for xen-devel@lists.xenproject.org; Wed, 25 Nov 2020 18:16:58 +0000 Received: from foss.arm.com (unknown [217.140.110.172]) by us1-rack-iad1.inumbo.com (Halon) with ESMTP id 8db06e9a-3041-4f8a-a772-db9e0c6eee0a; Wed, 25 Nov 2020 18:16:50 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id BDFEB11D4; Wed, 25 Nov 2020 10:16:50 -0800 (PST) Received: from scm-wfh-server-rahsin01.stack04.eu02.mi.arm.com (unknown [10.58.246.76]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 715AE3F23F; Wed, 25 Nov 2020 10:16:49 -0800 (PST) Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1khzLe-0001Oz-9f for xen-devel@lists.xenproject.org; Wed, 25 Nov 2020 18:16:58 +0000 Received: from foss.arm.com (unknown [217.140.110.172]) by us1-rack-iad1.inumbo.com (Halon) with ESMTP id 8db06e9a-3041-4f8a-a772-db9e0c6eee0a; Wed, 25 Nov 2020 18:16:50 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id BDFEB11D4; Wed, 25 Nov 2020 10:16:50 -0800 (PST) Received: from scm-wfh-server-rahsin01.stack04.eu02.mi.arm.com (unknown [10.58.246.76]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 715AE3F23F; Wed, 25 Nov 2020 10:16:49 -0800 (PST) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8db06e9a-3041-4f8a-a772-db9e0c6eee0a From: Rahul Singh To: xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, rahul.singh@arm.com, Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH v4 3/3] ns16550: Gate all PCI code with CONFIG_X86 Date: Wed, 25 Nov 2020 18:16:04 +0000 Message-Id: <6d64bb35a6ce247faaa3df2ebae27b6bfa1d969e.1606326929.git.rahul.singh@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: References: In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable The NS16550 driver is assuming that NS16550 PCI card are usable if the architecture supports PCI (i.e. CONFIG_HAS_PCI=3Dy). However, the code is very x86 focus and will fail to build on Arm (/!\ it is not all the errors): ns16550.c: In function =E2=80=98ns16550_init_irq=E2=80=99: ns16550.c:726:21: error: implicit declaration of function =E2=80=98create_i= rq=E2=80=99; did you mean =E2=80=98release_irq=E2=80=99? [-Werror=3Dimplicit-function-de= claration] uart->irq =3D create_irq(0, false); ^~~~~~~~~~ release_irq ns16550.c:726:21: error: nested extern declaration of =E2=80=98create_irq= =E2=80=99 [-Werror=3Dnested-externs] ns16550.c: In function =E2=80=98ns16550_init_postirq=E2=80=99: ns16550.c:768:33: error: =E2=80=98mmio_ro_ranges=E2=80=99 undeclared (first= use in this function); did you mean =E2=80=98mmio_handler=E2=80=99? rangeset_add_range(mmio_ro_ranges, uart->io_base, ^~~~~~~~~~~~~~ mmio_handler ns16550.c:768:33: note: each undeclared identifier is reported only once for each function it appears in ns16550.c:780:20: error: variable =E2=80=98msi=E2=80=99 has initializer but= incomplete type struct msi_info msi =3D { ^~~~~~~~ Enabling support for NS16550 PCI card on Arm would require more plumbing in addition to fixing the compilation error. Arm systems tend to have platform UART available such as NS16550, PL011. So there are limited reasons to get NS16550 PCI support for now on Arm. Guard all remaining PCI code that is not under x86 flag with CONFIG_X86. No functional change intended. Signed-off-by: Rahul Singh Acked-by: Stefano Stabellini Reviewed-by: Bertrand Marquis --- Changes in v4: - As per the discussion guard all remaining PCI code with CONFIG_X86 --- xen/drivers/char/ns16550.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/xen/drivers/char/ns16550.c b/xen/drivers/char/ns16550.c index 9235d854fe..26e601857a 100644 --- a/xen/drivers/char/ns16550.c +++ b/xen/drivers/char/ns16550.c @@ -16,7 +16,7 @@ #include #include #include -#ifdef CONFIG_HAS_PCI +#if defined(CONFIG_X86) && defined(CONFIG_HAS_PCI) #include #include #include @@ -51,7 +51,7 @@ static struct ns16550 { unsigned int timeout_ms; bool_t intr_works; bool_t dw_usr_bsy; -#ifdef CONFIG_HAS_PCI +#if defined(CONFIG_X86) && defined(CONFIG_HAS_PCI) /* PCI card parameters. */ bool_t pb_bdf_enable; /* if =3D1, pb-bdf effective, port behind brid= ge */ bool_t ps_bdf_enable; /* if =3D1, ps_bdf effective, port on pci card= */ @@ -66,7 +66,7 @@ static struct ns16550 { #endif } ns16550_com[2] =3D { { 0 } }; =20 -#ifdef CONFIG_HAS_PCI +#if defined(CONFIG_X86) && defined(CONFIG_HAS_PCI) struct ns16550_config { u16 vendor_id; u16 dev_id; @@ -256,7 +256,7 @@ static int ns16550_getc(struct serial_port *port, char = *pc) =20 static void pci_serial_early_init(struct ns16550 *uart) { -#ifdef CONFIG_HAS_PCI +#if defined(CONFIG_X86) && defined(CONFIG_HAS_PCI) if ( !uart->ps_bdf_enable || uart->io_base >=3D 0x10000 ) return; =20 @@ -355,7 +355,7 @@ static void __init ns16550_init_preirq(struct serial_po= rt *port) =20 static void __init ns16550_init_irq(struct serial_port *port) { -#ifdef CONFIG_HAS_PCI +#if defined(CONFIG_X86) && defined(CONFIG_HAS_PCI) struct ns16550 *uart =3D port->uart; =20 if ( uart->msi ) @@ -397,7 +397,7 @@ static void __init ns16550_init_postirq(struct serial_p= ort *port) uart->timeout_ms =3D max_t( unsigned int, 1, (bits * uart->fifo_size * 1000) / uart->baud); =20 -#ifdef CONFIG_HAS_PCI +#if defined(CONFIG_X86) && defined(CONFIG_HAS_PCI) if ( uart->bar || uart->ps_bdf_enable ) { if ( uart->param && uart->param->mmio && @@ -477,7 +477,7 @@ static void ns16550_suspend(struct serial_port *port) =20 stop_timer(&uart->timer); =20 -#ifdef CONFIG_HAS_PCI +#if defined(CONFIG_X86) && defined(CONFIG_HAS_PCI) if ( uart->bar ) uart->cr =3D pci_conf_read16(PCI_SBDF(0, uart->ps_bdf[0], uart->ps_= bdf[1], uart->ps_bdf[2]), PCI_COMMAND); @@ -486,7 +486,7 @@ static void ns16550_suspend(struct serial_port *port) =20 static void _ns16550_resume(struct serial_port *port) { -#ifdef CONFIG_HAS_PCI +#if defined(CONFIG_X86) && defined(CONFIG_HAS_PCI) struct ns16550 *uart =3D port->uart; =20 if ( uart->bar ) --=20 2.17.1