From nobody Mon Feb 9 18:45:20 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1690987147589216.74367761294354; Wed, 2 Aug 2023 07:39:07 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.574974.900654 (Exim 4.92) (envelope-from ) id 1qRCzp-0007KM-TU; Wed, 02 Aug 2023 14:38:41 +0000 Received: by outflank-mailman (output) from mailman id 574974.900654; Wed, 02 Aug 2023 14:38:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRCzp-0007J7-PX; Wed, 02 Aug 2023 14:38:41 +0000 Received: by outflank-mailman (input) for mailman id 574974; Wed, 02 Aug 2023 14:38:40 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRCzo-0006bO-Px for xen-devel@lists.xenproject.org; Wed, 02 Aug 2023 14:38:40 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 45699fe4-3142-11ee-b260-6b7b168915f2; Wed, 02 Aug 2023 16:38:39 +0200 (CEST) Received: from nico.bugseng.com (unknown [147.123.100.131]) by support.bugseng.com (Postfix) with ESMTPSA id 04B374EE0742; Wed, 2 Aug 2023 16:38:38 +0200 (CEST) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 45699fe4-3142-11ee-b260-6b7b168915f2 From: Nicola Vetrini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Nicola Vetrini , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [XEN PATCH 03/11] x86/uaccess: move declarations to address MISRA C:2012 Rule 2.1 Date: Wed, 2 Aug 2023 16:38:09 +0200 Message-Id: <6d5e4f307b360393e29641d727ef78b697643f47.1690985045.git.nicola.vetrini@bugseng.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1690989431435100003 Content-Type: text/plain; charset="utf-8" The variable declarations inside macros {put,get}_unsafe_size are considered unreachable code, as they appear in a switch statement, before any clause. They are moved in the enclosing scope to resolve the violation. No functional changes. Signed-off-by: Nicola Vetrini Reviewed-by: Stefano Stabellini --- xen/arch/x86/include/asm/uaccess.h | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/xen/arch/x86/include/asm/uaccess.h b/xen/arch/x86/include/asm/= uaccess.h index 684fccd95c..a2aaab1e87 100644 --- a/xen/arch/x86/include/asm/uaccess.h +++ b/xen/arch/x86/include/asm/uaccess.h @@ -191,11 +191,12 @@ struct __large_struct { unsigned long buf[100]; }; =20 #define put_unsafe_size(x, ptr, size, grd, retval, errret) = \ do { = \ + long dummy_; = \ + = \ retval =3D 0; = \ stac(); = \ switch ( size ) = \ { = \ - long dummy_; = \ case 1: = \ put_unsafe_asm(x, ptr, grd, retval, "b", "b", "iq", errret); = \ break; = \ @@ -218,11 +219,12 @@ do { = \ =20 #define get_unsafe_size(x, ptr, size, grd, retval, errret) = \ do { = \ + long dummy_; = \ + = \ retval =3D 0; = \ stac(); = \ switch ( size ) = \ { = \ - long dummy_; = \ case 1: get_unsafe_asm(x, ptr, grd, retval, "b", "=3Dq", errret); brea= k; \ case 2: get_unsafe_asm(x, ptr, grd, retval, "w", "=3Dr", errret); brea= k; \ case 4: get_unsafe_asm(x, ptr, grd, retval, "k", "=3Dr", errret); brea= k; \ --=20 2.34.1