From nobody Wed May 1 02:06:43 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1dmarc=pass fromdomain=suse.com); dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=2; a=rsa-sha256; t=1624375094; cv=pass; d=zohomail.com; s=zohoarc; b=BuA87OqocXosHN+9d1Cs4nXBYST1gWwGFHT+ieWhINk9hOFseKw1DfP/bgWIri+xytY+p22oSidKLhmVgf5ljHv/cVdJdLBfET5tUiTwP3eJ8wqofl89ILwUtA5kTHdH/dgIoDSNGh5yJfnRxjxNz3x4nYNlSNoFIQTY+bYqQvE= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1624375094; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=nSjrFG92yCM/r3hkNcHh022+l3pV9APtRcoqPp/lD/Y=; b=EOPKU2lK55/OS+yf4vhZgsUSQvbqDlSZ8M4l8wyFNDZIH4FKvcNJAuRjv4mRDhIu+hrYh+kI9aOaaE9CZbG8dcuukbQEEnwKgOalVrH/zlHiFgCyDTGzbEipRgKgYNTs4o5eN9mHK3VwYBhVEpQQjJts7tFv4RS5U3W0RC/mq8M= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1dmarc=pass fromdomain=suse.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1624375094662986.267849538303; Tue, 22 Jun 2021 08:18:14 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.145898.268360 (Exim 4.92) (envelope-from ) id 1lviA4-0007GF-F2; Tue, 22 Jun 2021 15:18:00 +0000 Received: by outflank-mailman (output) from mailman id 145898.268360; Tue, 22 Jun 2021 15:18:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lviA4-0007G8-Bz; Tue, 22 Jun 2021 15:18:00 +0000 Received: by outflank-mailman (input) for mailman id 145898; Tue, 22 Jun 2021 15:17:58 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lviA2-0007G0-Ho for xen-devel@lists.xenproject.org; Tue, 22 Jun 2021 15:17:58 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 1b8ddb81-b846-47de-a8ff-f1fbe46eb514; Tue, 22 Jun 2021 15:17:57 +0000 (UTC) Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-db5eur03lp2050.outbound.protection.outlook.com [104.47.10.50]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-18-aivuLulkPmu8ZRcb5NoxNg-1; Tue, 22 Jun 2021 17:17:55 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR0401MB2445.eurprd04.prod.outlook.com (2603:10a6:800:55::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4264.18; Tue, 22 Jun 2021 15:17:53 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::f06c:6f5d:34d2:1c36]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::f06c:6f5d:34d2:1c36%5]) with mapi id 15.20.4242.023; Tue, 22 Jun 2021 15:17:53 +0000 Received: from [10.156.60.236] (37.24.206.209) by FR3P281CA0001.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1d::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4264.7 via Frontend Transport; Tue, 22 Jun 2021 15:17:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1b8ddb81-b846-47de-a8ff-f1fbe46eb514 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1624375076; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nSjrFG92yCM/r3hkNcHh022+l3pV9APtRcoqPp/lD/Y=; b=IkEjoS6lCOeRUxmeBCxGgXARVvBsQ5TFn8KlS97wRgl9mawNAu0Q0M82CflV9IddfcBkls 5l8yhYikdXKBu9L4RvlKtuJrRVMIxJ/7BG/GccOep5XmkNaCr+fTw9KSR3n+lwl+Lxo3SO 0tMUOci+GO1XT/lxd6pMNySpCo9/H50= X-MC-Unique: aivuLulkPmu8ZRcb5NoxNg-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PVZDEdr8mieCB4Jwfs3AvNwXJwzL8vthjqfImqvJPFXMM1zrVHsTelDFWWE6Z2u3mL1a4qnNMIv7klZ/4oNV+7dZ53tOmIpDM33W/lwmzow3uQbNlJNy8yLWgHn+uJvA4tIhu93flmkVvJyRFtB5S4wLM4W11nNqk6P4gJyTWAKGIVQs9g4v6Pwq9QfL7BLnBOHVmmgOplsXOu7WLx66hcPiDgErWTZQaNCHs1DjazhM9m2XmOPgE5S+VSQv1fls5Sb4Davc9BOGFA4LIw0RT8uaGsOV4MuZTxTISrgzH6CScwMZwPeY99aV5XJT40hrbLarwqrAIsX0J1XEZduvug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nSjrFG92yCM/r3hkNcHh022+l3pV9APtRcoqPp/lD/Y=; b=FOKLzwF3Ojlz16x4m5P0IwDsBQIsjZs4cSmKyO4VGNUY9y0avxQ4m/FR5aOqV5/UDhVPY8R0vD7SZFL+8gedHTsTkpHtpce10lSdN2V+84YOhH+t+a6pQxVtWQB9PrbBrGFD7TwGvPKkLgMXzLmphDfXzTR77R9H5G7rboU29lagg0HFkaTJja5mETjbMluyVF5ChnfOQAfp6ovLDGc3WgN0tOab99035xv0iZDdcl8yLQp/dTRw4l1d2FxClYaul8nMEKA23BWKAOhhPMHxRl060Sok/uH1JZFVCaukd7tpSchLungiFz8pI7Ur20clHrNNx5a0thRpvAXRzwpHww== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=suse.com; Subject: [PATCH v2 1/6] x86/HVM: wire up multicalls From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Ian Jackson , Juergen Gross References: <6c532607-c2a3-d0ab-e4e5-428f85f4a045@suse.com> Message-ID: Date: Tue, 22 Jun 2021 17:17:51 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 In-Reply-To: <6c532607-c2a3-d0ab-e4e5-428f85f4a045@suse.com> Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Originating-IP: [37.24.206.209] X-ClientProxiedBy: FR3P281CA0001.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1d::10) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6f37d13f-1e4b-4364-dfa0-08d93590e7df X-MS-TrafficTypeDiagnostic: VI1PR0401MB2445: X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6108; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: LuJxCbLLbTKPVs4vUXAyavKerV0mbZFm5QhOGhF5TpWlzY+WcwMXVgyrURlO4xek773Ob3Al1ysqqeIJGo+QIx6VnGaDwoWP2K8ZzdL4lla8X/VWcy8cSZl02yYeuLmQyhXV2DJS1Uf+binZupKi0DVzkHOVZD9XBP26tqEnbJx/UraSGpZ08RYVaRWf0p0dLgyOtdP4wRhiUJOH3ceuepC5PXuEe9hm/npyhpjuwcbIhUOzVFvN7BkX795fmQdwhCcrmnwlgUQtZzzVBtS6bdCoS87rC3ajBUDISZS9pI/vgzBH7DrAEBkzrk2cGislOvjebstynPlDiRtMsYNq9zZKn2nxWBATMZGPhhpWgq59FjajkfWCcqDnBwhUb0lqpBVSafnhWC1/pYlQMV282RynQ0lsZkXh7OkQZAKhi+0y/ovesrKNkAQvVCcN/nr8VwMsGbhcaIWOSkZ3QJyN5jx6w7Onck4JYJi6k1XqIvR2H5NPq1LS17gcXmqamEnpBHf4VjJZRGgAF5sICba1e1YnWD/hD2jvfMLsdFy5wFzDk4rszpd5IqSD4wgG/sWqp0m8qeLHKvKlWOapmGqs8+G8o9puP8KGLQIarXT8EvAdGenBTiRgGDQMslA5EE7IL3snB1v4tGwAuZeEDrxWoUKUk6cbdHUaiXxaOfr3KBHSuLB95IKDa595Iygt7mhY X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(39850400004)(376002)(346002)(396003)(366004)(136003)(54906003)(2906002)(5660300002)(66556008)(66476007)(66946007)(186003)(4326008)(26005)(107886003)(16526019)(6486002)(478600001)(31686004)(36756003)(8936002)(6916009)(8676002)(86362001)(31696002)(83380400001)(2616005)(956004)(16576012)(316002)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?amN5R0x1NFQxMjBiZ3EzcThaanhTMnBCVlVRSlNpdi9qYlpHV0RhQ0E5UXI3?= =?utf-8?B?VFdheDN6NlhkUlFaL2MxbVp2K3VEdnFCNjQ2VFlaRGRGTVoyL2x2a3JFWWZi?= =?utf-8?B?Rll6QzU1ajJJZnliYllmT3pjdTk0dDdGNVpYcDV2NVB1bEM5eGcxekNOM3BN?= =?utf-8?B?bW93ZG9QUUpESVU4V0hTeFFpN2s1ZldVY3Vtdmk5RnJCNGgxQTFIR0RKVnBj?= =?utf-8?B?TDNvQmtvYXJhTVN2cU9ZVFJBUzBTT2VwT3VnVlFvUERBb2hXRzVKaXJTRmtw?= =?utf-8?B?MzF2KzNpZ2VRdFo5dmRlRGFiZyt5Ry8xbjlkNTNvK1hpQ2plSkVCZ3BKMXZT?= =?utf-8?B?VXNEd1g5S0FubTlUbkVBUjNxWFczTGtQNGFDUnlWeW1vcVR0andac3B0OUQz?= =?utf-8?B?OGJQRXhrRFY5Mjl4VXl1dmpFNTV4Q3lVVitteEYxSE1qMEUwZzA1K0FLRjVU?= =?utf-8?B?THRxRW1nUXRKemhqQ0w4b0hGSDNNcnZqNkhZWFY3TlRodzhOdjlUUXFHS2x0?= =?utf-8?B?ZjVDY20ycmpCVklQL1hZbzJhcUVzNnlyenphSEptYkEyTE0ydFV2bTFETy9k?= =?utf-8?B?Rjl3K2RpZ0Erd3U4aUJ0NHg5c1czY2hvZFVWM2kxREJxYk5zWGJwak0waXJN?= =?utf-8?B?a1NJT2V4YWxPYkNLZUhqcXhYL01HcEsyWGFBZkJqYlhjWWNuQTJxVm8vQ0w2?= =?utf-8?B?L001RzVpMkZmbGdQTkJSRzE5cXQzQ1ZGdmI0TzZxTzU3eEw3Z1JYQUlKandp?= =?utf-8?B?enQrY2lqSGh4RmJWWElmblR1ay9CMkw5N2tNNEUvU0NlY0cvWmhoMEpDZVVT?= =?utf-8?B?bklXNmxKS3g5NG9EUmNhQXdkMDBqdENjUmsvM1NROXdtNENPdlF6SGhmVXFZ?= =?utf-8?B?aXVXR0djcHE5a21mYXNuR2p3L1BROWRoa0tvZDV0cEFBazRlbXdSZUlaekp4?= =?utf-8?B?TWJ6VlFLMXNIK20yWHgrMDdGdVU5Qm1DWFRJcjAzRDN3MFZld0R1ZUdiRmFO?= =?utf-8?B?VEhKenFhaDU3d1lvQldUeXNBSnRPT1BjRjgzTDdZWm5lMit2aXU4cHpucGE4?= =?utf-8?B?RFNvQnhqeThSRUJKQWl3eGFscEw1ZjdDandCSVF1VnZ3Tm4yZEg3OTBjaHVQ?= =?utf-8?B?eldSVEZ6OUpFUHBWaFlrYWNobzdMOGhjK3pzMjY3L1RwdXYzTVRBLzEwN3kx?= =?utf-8?B?bHRES3FLRzkrdmx3VDduMW9jdHB3emxhdnc3Q1RBUTY2L0R3N0tXcEFNa3Vt?= =?utf-8?B?anM1bVJ5YlpENnlhSkhpRW5oaTZUbzUvNDlURDkyUnVac0MyREJTVTQxTUFT?= =?utf-8?B?ZmFXUFBQZjVDa1Bhb0M1YzhZREdZR282czJQdms0SFdGTWNaaDRUVHRCa2Nk?= =?utf-8?B?ZTdGTm5BcDRMZUVtSEJnZXkwS2h5b2NIeDIwQWhXUHY2UTYvWnNkY1lPcVRY?= =?utf-8?B?M2phTUZkZEJoUExmNUszUGdNcXg5ZUd4UVJrZmh1NTRyU2tkYmdUMVFwN2VO?= =?utf-8?B?RFJmQkI0N3FoVFFaeDBlek9XOFpZa1N0em9GeG9QYkJkR04yMWlrY3k0NFBI?= =?utf-8?B?Tk14Rm5iVUZadHZ3SlBHTUVUZGk4NFFKN3ZuelBqNmVZL0JSai81REhDK3Jt?= =?utf-8?B?bDlBbEdmZ0RDbWFSdS9VdDFoZVBVTmtCT3dhZ1kvTGJQUnkrMU5SVTR6VGFG?= =?utf-8?B?S1o0cjRKNTZIclV6cDVyS0czMnBwYUNBK3FlMVlta2FyTEk5K3hkRUJwRklr?= =?utf-8?Q?XS1dwwg4YAKeh5hjKwwP5UJkNh3+glFGmN1qZc5?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6f37d13f-1e4b-4364-dfa0-08d93590e7df X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jun 2021 15:17:53.2566 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 3v+jbFkIYEiJgdK063B+qRuVF90l/23xtsqgGAQFChQxMQwh/nvvzkEwYx1FOV9x5ThkIpsLf7e1nFUPy1NODg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2445 X-ZohoMail-DKIM: pass (identity @suse.com) Content-Type: text/plain; charset="utf-8" To be able to use them from, in particular, the tool stack, they need to be supported for all guest types. Note that xc_resource_op() already does, so would not work without this on PVH Dom0. Signed-off-by: Jan Beulich Begrudingly acked-by: Andrew Cooper Acked-by: Ian Jackson --- a/xen/arch/x86/hvm/hypercall.c +++ b/xen/arch/x86/hvm/hypercall.c @@ -26,6 +26,7 @@ #include #include #include +#include =20 #include #include @@ -125,6 +126,7 @@ static const struct { hypercall_fn_t *native, *compat; } hvm_hypercall_table[] =3D { HVM_CALL(memory_op), + COMPAT_CALL(multicall), #ifdef CONFIG_GRANT_TABLE HVM_CALL(grant_table_op), #endif @@ -334,6 +336,39 @@ int hvm_hypercall(struct cpu_user_regs * return curr->hcall_preempted ? HVM_HCALL_preempted : HVM_HCALL_complet= ed; } =20 +enum mc_disposition hvm_do_multicall_call(struct mc_state *state) +{ + struct vcpu *curr =3D current; + hypercall_fn_t *func =3D NULL; + + if ( hvm_guest_x86_mode(curr) =3D=3D 8 ) + { + struct multicall_entry *call =3D &state->call; + + if ( call->op < ARRAY_SIZE(hvm_hypercall_table) ) + func =3D array_access_nospec(hvm_hypercall_table, call->op).na= tive; + if ( func ) + call->result =3D func(call->args[0], call->args[1], call->args= [2], + call->args[3], call->args[4], call->args[5= ]); + else + call->result =3D -ENOSYS; + } + else + { + struct compat_multicall_entry *call =3D &state->compat_call; + + if ( call->op < ARRAY_SIZE(hvm_hypercall_table) ) + func =3D array_access_nospec(hvm_hypercall_table, call->op).co= mpat; + if ( func ) + call->result =3D func(call->args[0], call->args[1], call->args= [2], + call->args[3], call->args[4], call->args[5= ]); + else + call->result =3D -ENOSYS; + } + + return !hvm_get_cpl(curr) ? mc_continue : mc_preempt; +} + /* * Local variables: * mode: C --- a/xen/arch/x86/hypercall.c +++ b/xen/arch/x86/hypercall.c @@ -20,6 +20,7 @@ */ =20 #include +#include =20 #ifdef CONFIG_COMPAT #define ARGS(x, n) \ @@ -273,13 +274,18 @@ int hypercall_xlat_continuation(unsigned return rc; } =20 -#ifndef CONFIG_PV -/* Stub for arch_do_multicall_call */ -enum mc_disposition arch_do_multicall_call(struct mc_state *mc) +enum mc_disposition arch_do_multicall_call(struct mc_state *state) { + const struct domain *currd =3D current->domain; + + if ( is_pv_domain(currd) ) + return pv_do_multicall_call(state); + + if ( is_hvm_domain(currd) ) + return hvm_do_multicall_call(state); + return mc_exit; } -#endif =20 /* * Local variables: --- a/xen/arch/x86/pv/hypercall.c +++ b/xen/arch/x86/pv/hypercall.c @@ -23,6 +23,7 @@ #include #include #include +#include #include =20 #ifdef CONFIG_PV32 @@ -245,7 +246,7 @@ void pv_hypercall(struct cpu_user_regs * perfc_incr(hypercalls); } =20 -enum mc_disposition arch_do_multicall_call(struct mc_state *state) +enum mc_disposition pv_do_multicall_call(struct mc_state *state) { struct vcpu *curr =3D current; unsigned long op; --- /dev/null +++ b/xen/include/asm-x86/multicall.h @@ -0,0 +1,12 @@ +/*************************************************************************= ***** + * asm-x86/multicall.h + */ + +#ifndef __ASM_X86_MULTICALL_H__ +#define __ASM_X86_MULTICALL_H__ + +#include + +typeof(arch_do_multicall_call) pv_do_multicall_call, hvm_do_multicall_call; + +#endif /* __ASM_X86_MULTICALL_H__ */ From nobody Wed May 1 02:06:43 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1dmarc=pass fromdomain=suse.com); dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=2; a=rsa-sha256; t=1624375120; cv=pass; d=zohomail.com; s=zohoarc; b=QWhm1Ibk1jhxdqJw5kxdSmEfeOmUTAn/jrJe0rv8dcRoexR0hlHZ4aDg22o7mcXPqG58NsWMuFurjhd8klv3PBrJmw4nSH0QB/zQnM0JrXmCU+D1DIimCaPyYfGEKemA9kz2hyCQTEIbFj5I5HQLJXuI5N+81Cjc+IwsleH3dM0= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1624375120; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=/bbmcF2dLfMyovvu1hUGHMNb0R327+N+VEXYHAXs66E=; b=fpJtonITA/tNnYU10Cj9x9YN+bO7ug0ODJMd1ccz0fNqkp3EDTOnB1Ms9LUqGdG/H+uwkLRtBuNJRx1H7Jg7r3MgqxxR5jmk3hdB8DCpyySfUNNJ7vIfBte88kfl/FFSh5zHZcY1X56WiXXFzmE5AfT/TWfJk4mGFjoA2L6zTic= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1dmarc=pass fromdomain=suse.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 162437512045836.866128281309784; Tue, 22 Jun 2021 08:18:40 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.145903.268370 (Exim 4.92) (envelope-from ) id 1lviAX-0007oj-Ne; Tue, 22 Jun 2021 15:18:29 +0000 Received: by outflank-mailman (output) from mailman id 145903.268370; Tue, 22 Jun 2021 15:18:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lviAX-0007oc-Kf; Tue, 22 Jun 2021 15:18:29 +0000 Received: by outflank-mailman (input) for mailman id 145903; Tue, 22 Jun 2021 15:18:28 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lviAW-0007oS-BJ for xen-devel@lists.xenproject.org; Tue, 22 Jun 2021 15:18:28 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 35ea69e4-2842-4ddd-b153-ae9677eb296b; Tue, 22 Jun 2021 15:18:26 +0000 (UTC) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05lp2104.outbound.protection.outlook.com [104.47.17.104]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-34-vbilEjMmNLC95g-EmX-spg-2; Tue, 22 Jun 2021 17:18:24 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VE1PR04MB6478.eurprd04.prod.outlook.com (2603:10a6:803:12a::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4242.21; Tue, 22 Jun 2021 15:18:21 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::f06c:6f5d:34d2:1c36]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::f06c:6f5d:34d2:1c36%5]) with mapi id 15.20.4242.023; Tue, 22 Jun 2021 15:18:21 +0000 Received: from [10.156.60.236] (37.24.206.209) by FR3P281CA0018.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1d::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4264.7 via Frontend Transport; Tue, 22 Jun 2021 15:18:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 35ea69e4-2842-4ddd-b153-ae9677eb296b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1624375105; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/bbmcF2dLfMyovvu1hUGHMNb0R327+N+VEXYHAXs66E=; b=QlLPqon1+UwlZlCMubS4XV9pvMt7zJY6JJhB3IXcUcQt5waaQZ3ERfB7Ig0f/CwtQ9Kq6T A38rL+fpxqPATscipoyoZO5WKgxUpFbZikYNtDoubotq1iF7T8CDfBXBuPeYdehZOPtp6S Vo4jjJhgasYUDUYNibcNamNlAVaIw8U= X-MC-Unique: vbilEjMmNLC95g-EmX-spg-2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=S2j0IASNa5nR4KKaIRZHlECF5NvhpaYFWioGDwq7eHNhlWQfEbMPAIVusigqngRkIh4oRHmSwHtPjeZ9xHnrDQJX3ojlRfnsDjkZr/OtneDVduSHuG5zQgHFNj30oxJctWVUtbVrmYKqsWdlwVIqVxLnA4lPdTASkqruaInjmbRmWUFEXWN7/Y53qFfYn66hwEIeJzelPX20GcSxH7FRGtNKFnB0cS52QgEzT4A+wA15LmYZhPIL2OsAmjilqFiAY507hvWe0aHlFyQU1TG6YhQhOQZIo1HoJ/I2sBfnglTBqaatd7GnmRw53TqQbYtWImWSH5SSxmrRxmqOSzTMzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/bbmcF2dLfMyovvu1hUGHMNb0R327+N+VEXYHAXs66E=; b=ir59Oj/ExaGbMb21bypfYMpyharY3NuUnL6LyqrKPEQle+iDHwP3ymddkNL9a+ZhwkxqpCFhXc742n2luw7BNP+nQIYLwCgz1d/lfopfraRjcOknwMPII7laet2Fw+NM49gryRwCm6vzHQUA9rTUweOml8dNL9xgIOwrlvOIAPxfj+nMW5ErEDiJ6jtj4GdsPBvIsluh6K5vBrGxJPeIm63XdCcXumrh4uTDhbcyMEI+t/lXGA6jeCRP+mUcVVFuhj+wdmlzCpPkeTXmRR3YYDRibPWXVvxEDkkgWhdNO9dD0Fgzo3MKlnoVdEMcBde20y2iJwbLdRf5oKyRNLJwow== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=suse.com; Subject: [PATCH v2 2/6] libxencall: osdep_hypercall() should return long From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Ian Jackson , Juergen Gross References: <6c532607-c2a3-d0ab-e4e5-428f85f4a045@suse.com> Message-ID: <0a912030-8ead-62e8-863b-01f296782bfb@suse.com> Date: Tue, 22 Jun 2021 17:18:19 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 In-Reply-To: <6c532607-c2a3-d0ab-e4e5-428f85f4a045@suse.com> Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Originating-IP: [37.24.206.209] X-ClientProxiedBy: FR3P281CA0018.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1d::11) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: aedf138b-9f0b-4ea4-f992-08d93590f8bb X-MS-TrafficTypeDiagnostic: VE1PR04MB6478: X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:5516; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: L7AlSXWM/DHEHuoaGD1RSQldZSH/m/2J+QZDb81RJnPLYAMDSZHmer8GUv7Ha3SjI+ZZYMrd2OFEMI506GubTAMTZk0bzVb3+OAfBoi01HhCRdue9KRsoHy+qIl3oPrWZnCGIvP1zhRArs3fPbomlOjc5PkDlPrTpPEPBR27PU3oCEkrTaFpW2lFpSKTBix5kwdINtxmKh03ZHCY7pF1xMc+hPS1MdNXK3Ocu92WqgMNqNV2ztfUXBDpYk55jLEuXSvUmfUWxMb4oAimIHOIIXHVcMr9TNRxTBXS0mspTLN3pSZs1YgWozWtGQf4J0RKr/5YslkFDGUfvXTse0kpqKpBWD3wqtxDr763ZVvFNrQq8iJKLiJBfmZyRzxTrUpm4P4g6gvX3j7YcTivPcij4Swo3SyqOv8ejxJEl0nDg74LjpdDTODkcpBKbCgGfjj4xQZC7qG07tpv2GS2nV22ZPZ0DAEUmGBubEQrq8yBEiAMJTHEnoefKBgBZqKCRMoiwUPHNbph7wSf3/X+Zz1BUXhnl+40mwh98OZIB9niMh6VlgC2ZK8XCxJBN/gKbNspUg5aS8ME1FC83mUmWYvDJdRjkDmhOvMkR/ItSB+vtctR2j5dZESILCv63KrtGbMoTv7Kfz/Nes3o9x8qocngwUGg+znfbnCw4xrktNaD0BIGlU0/CaaHWlShs3CZNVCE X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(136003)(346002)(39850400004)(376002)(396003)(366004)(26005)(186003)(5660300002)(4326008)(16526019)(36756003)(38100700002)(2616005)(107886003)(316002)(956004)(54906003)(16576012)(2906002)(31696002)(66946007)(8936002)(86362001)(83380400001)(6916009)(478600001)(6486002)(8676002)(66556008)(66476007)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dlo5MHpWMytvaEJYa09wQlpOaDc1SkVPMUNNTXlpclpQSDFwNkIyeEgwRExD?= =?utf-8?B?dzh1V1RPTUdLN01XMkRtaDFyb3hpVHZGSXhEUjRkZGJmY3REM0MxQ214U1pt?= =?utf-8?B?VTZSaUV3ZXNlWlk0bEw0UzcrRFNFaGd1ZEhkMjhVbE5IaDd5Y1kvclNRdVhP?= =?utf-8?B?OXliSG9QS0diY2FSaUQwS2FKTm5tb0wxeG84OXQrNHBTMVJHcDAvYkMyMzlq?= =?utf-8?B?R0F4dXg1OEZydm93cWsrSjdrNVFEamF2bUpZeFBCZktsV3FwZTliSVYwNENY?= =?utf-8?B?WWFhWlZSaktaSGs3ek1CWXBGeTBpMzhJZURkUW9aVkNyMVo0Y2JKcDlLdTVl?= =?utf-8?B?SHdVU2FaUzNlbkxNS0IwQ3BwV3BLQ0J1bEJUUDZZOWJlRUlhcWtzcTVhdStl?= =?utf-8?B?WXZoWWUvZDJIK29mdXBDak5ZbXlpRzlwZkhVWWE3TnQ1ejdRMC9uS2lGdjJV?= =?utf-8?B?SFFSSnNwQVo0MGFLS01PSTRwVkxUa0Z3Nm9XbjQwcTJBQjJKV3FGa2tBTGdq?= =?utf-8?B?enZLRzJqK29sa041UnF0dmpGcEt2ZS9pWlNQOWxFdkF6WlIrZmgyTVBiSkxE?= =?utf-8?B?QVFRUlBnMHNGQ3A5YU9Bcjlma3VVSk1IWDhuOU1qdlRxS0NiMUswUVRiZTJr?= =?utf-8?B?ZEwxUGdybjRsSW5sRXpFeTZOTEhXSDRmeUdMcjBJK1A5VUgvR1k3VWdJMDFx?= =?utf-8?B?T0hCZEVud2lkOWtId3dsd0dhZDhtUHFVRllQZzVyanhjSExQL0JwSmFPVGE3?= =?utf-8?B?T3dUK082cjlPUithU29mdDVSUVRGc1FCWlBsSS8yb1h1U1hvbE0zSHJuNGcy?= =?utf-8?B?YjlzbFFLU2x6YmNBUDczaWZVVHlOSnZzT1BUM3N5eitKMXdYcFUwOUF2K05V?= =?utf-8?B?LzlmL1NMWXVQK2RHUW54SUpLemtzcFVYL1RONXRLb1JqQ3hVNjFzTExuQmkv?= =?utf-8?B?Uml0QURPUjRHaGhGbjcrRHI2blZ6RVlkV29DdHBaS2hyU0VmcTVVWEdERWM4?= =?utf-8?B?eUc2UHdWaFpueEllVGZqNUNXUURrYkdLNjh2N1NKcFpzOWZCTW5oa1FnQVVr?= =?utf-8?B?T092RWZCTVJ0MU43YmxQaEEzVWVBS1IrNlhjdU5kODdYZGltVEpKU3RzWVhJ?= =?utf-8?B?bWQ3bjh5YXdkY2ZaU3k2UExTS0VCNENCY3Z2c2ZkeEJaekVYeXlCWGs5a3NW?= =?utf-8?B?MndxOUtrWWhJK2hQclloZWc3bGNpY29kMG50c0hqN0V4b29BMUhETFpGREVk?= =?utf-8?B?MHpsNS9XZ2J0VEo2Y2paY3J1eFRoTXFlcFRwcFljMGVjMnVQNHE4QnU4L1Fn?= =?utf-8?B?S1Avcm50NUJsTEhiakYvajFuVDMranVvbnowQjJjczNZUHNSQ1BGcWUyWENR?= =?utf-8?B?Q3VQWUFSaWIwR21NRVI1L29TZFcyMnI4WGlSS2lsV0c2YnpSRnNYVmRMTXJP?= =?utf-8?B?aXBzaDJZaVdtaFFNK0JHRTFmZndFR3pORG95Zy9YQUlZNjdYOURHQm1VUnNU?= =?utf-8?B?czZWanhaZm1YejE4QjZiUXBtY2dvOWtGd3huM20vcVcxb3IvbUVnMnh3L285?= =?utf-8?B?M1JiekVrb3FVS0ZoM2dFN2VHblVRZXZLdHZOS3hJckdoRlhXS2JYeTJFRndU?= =?utf-8?B?bjBOaFhzNXVOVlVQTlVPYms2NEhicTRRSzVCM0dhaTd4WkcrRTMyVXQ2ejBL?= =?utf-8?B?ekVXWkQxRmtsL0t2WldzWnQrYm1tYUs0cUJFVmpCOTQ2cUk2dWZQM2VTRWFL?= =?utf-8?Q?Zfc6HhcT8ShB6LyK2f5w//fi7dGvYeCBIMl3SSs?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: aedf138b-9f0b-4ea4-f992-08d93590f8bb X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jun 2021 15:18:21.5246 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Pz6XHDyYunzyGJf3POskmJsz8b5DnS8ABM3mLJbKDOdHWCihk6eiMfV+63DdGtw9vdOwme/YFGSF5m1aAENdEw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6478 X-ZohoMail-DKIM: pass (identity @suse.com) Content-Type: text/plain; charset="utf-8" Some hypercalls, memory-op in particular, can return values requiring more than 31 bits to represent. Hence the underlying layers need to make sure they won't truncate such values. (Note that for Solaris the function also gets renamed, to match the other OSes.) Due to them merely propagating ioctl()'s return value, this change is benign on Linux and Solaris. IOW there's an actual effect here only for the BSDs and MiniOS, but even then further adjustments are needed at the xencall() level. Signed-off-by: Jan Beulich Acked-by: Andrew Cooper Acked-by: Ian Jackson --- a/tools/libs/call/freebsd.c +++ b/tools/libs/call/freebsd.c @@ -62,7 +62,7 @@ int osdep_xencall_close(xencall_handle * return close(fd); } =20 -int osdep_hypercall(xencall_handle *xcall, privcmd_hypercall_t *hypercall) +long osdep_hypercall(xencall_handle *xcall, privcmd_hypercall_t *hypercall) { int fd =3D xcall->fd; int ret; --- a/tools/libs/call/linux.c +++ b/tools/libs/call/linux.c @@ -80,7 +80,7 @@ int osdep_xencall_close(xencall_handle * return 0; } =20 -int osdep_hypercall(xencall_handle *xcall, privcmd_hypercall_t *hypercall) +long osdep_hypercall(xencall_handle *xcall, privcmd_hypercall_t *hypercall) { return ioctl(xcall->fd, IOCTL_PRIVCMD_HYPERCALL, hypercall); } --- a/tools/libs/call/minios.c +++ b/tools/libs/call/minios.c @@ -38,7 +38,7 @@ int osdep_xencall_close(xencall_handle * return 0; } =20 -int osdep_hypercall(xencall_handle *xcall, privcmd_hypercall_t *hypercall) +long osdep_hypercall(xencall_handle *xcall, privcmd_hypercall_t *hypercall) { multicall_entry_t call; int i, ret; --- a/tools/libs/call/netbsd.c +++ b/tools/libs/call/netbsd.c @@ -96,7 +96,7 @@ void osdep_free_pages(xencall_handle *xc free(ptr); } =20 -int osdep_hypercall(xencall_handle *xcall, privcmd_hypercall_t *hypercall) +long osdep_hypercall(xencall_handle *xcall, privcmd_hypercall_t *hypercall) { int fd =3D xcall->fd; int error =3D ioctl(fd, IOCTL_PRIVCMD_HYPERCALL, hypercall); --- a/tools/libs/call/private.h +++ b/tools/libs/call/private.h @@ -55,7 +55,7 @@ struct xencall_handle { int osdep_xencall_open(xencall_handle *xcall); int osdep_xencall_close(xencall_handle *xcall); =20 -int osdep_hypercall(xencall_handle *xcall, privcmd_hypercall_t *hypercall); +long osdep_hypercall(xencall_handle *xcall, privcmd_hypercall_t *hypercall= ); =20 void *osdep_alloc_pages(xencall_handle *xcall, size_t nr_pages); void osdep_free_pages(xencall_handle *xcall, void *p, size_t nr_pages); --- a/tools/libs/call/solaris.c +++ b/tools/libs/call/solaris.c @@ -80,7 +80,7 @@ void osdep_free_hypercall_buffer(xencall free(ptr); } =20 -int do_xen_hypercall(xencall_handle *xcall, privcmd_hypercall_t *hypercall) +long osdep_hypercall(xencall_handle *xcall, privcmd_hypercall_t *hypercall) { int fd =3D xcall->fd; return ioctl(fd, IOCTL_PRIVCMD_HYPERCALL, hypercall); From nobody Wed May 1 02:06:43 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1dmarc=pass fromdomain=suse.com); dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=2; a=rsa-sha256; t=1624375147; cv=pass; d=zohomail.com; s=zohoarc; b=JNSNia6RRxDeaZJET/NH4Nuwpa7Hv1aD9iBiV87Fho+iYqcgtUznPxEq7FF4lLLUSpziKMOLHfKO5c6FDwP9qMdII6zv8QKFQ/5a1IpL99mrsyH2N12BKVBseW3JH8sx7/xlSRF8Fjk6tMn+d7om7krUIPYQjWfWgr2R+BE8/X0= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1624375147; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=H8bfy44Kldc2RqppGX0GDbslnJnZuK1kudBdrWRi9kc=; b=c5fTMoj9m1eweZio6vT0mlJWFy+67ZEzK1aGr7RC5hG1lSKKSwbpz2dOisN7NV/p2IX+RlE1ITFpcEXGy4aSl/eASTJdPlCtZAkMM4bdDtpwLgTPBOnUQDuPzNx2WX8BjLQtYXKLHPqcQz8f0Y96WjSivmOJGlD+sMVSnRzLK6Q= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1dmarc=pass fromdomain=suse.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1624375147572417.6915254371471; Tue, 22 Jun 2021 08:19:07 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.145904.268382 (Exim 4.92) (envelope-from ) id 1lviAr-0008Gg-24; Tue, 22 Jun 2021 15:18:49 +0000 Received: by outflank-mailman (output) from mailman id 145904.268382; Tue, 22 Jun 2021 15:18:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lviAq-0008GZ-UD; Tue, 22 Jun 2021 15:18:48 +0000 Received: by outflank-mailman (input) for mailman id 145904; Tue, 22 Jun 2021 15:18:48 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lviAp-0008En-V1 for xen-devel@lists.xenproject.org; Tue, 22 Jun 2021 15:18:47 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id bb75cbff-754a-4c11-94fc-1c9c6f25f856; Tue, 22 Jun 2021 15:18:46 +0000 (UTC) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05lp2107.outbound.protection.outlook.com [104.47.17.107]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-19-Fa_m54PQP6eF-ciZ81bwUw-1; Tue, 22 Jun 2021 17:18:44 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VE1PR04MB6478.eurprd04.prod.outlook.com (2603:10a6:803:12a::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4242.21; Tue, 22 Jun 2021 15:18:43 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::f06c:6f5d:34d2:1c36]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::f06c:6f5d:34d2:1c36%5]) with mapi id 15.20.4242.023; Tue, 22 Jun 2021 15:18:43 +0000 Received: from [10.156.60.236] (37.24.206.209) by PR0P264CA0263.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4242.18 via Frontend Transport; Tue, 22 Jun 2021 15:18:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bb75cbff-754a-4c11-94fc-1c9c6f25f856 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1624375126; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=H8bfy44Kldc2RqppGX0GDbslnJnZuK1kudBdrWRi9kc=; b=I9QWOPLQMHSt9CkiOdEuXi1s0Lc2oWdIrwLbZYe102YmaTVu6l0voQTqsYYVw1hs1GwbjE D7lNH/RKO5TcDw+ttF6/lc/WS8JtDHVpFxJde8bf2jVkOy0Q05yirSjHKRYeViD+C1QiFm /hpgUgj5+/qoJ8o+5Jjtg+oRRnaSNR8= X-MC-Unique: Fa_m54PQP6eF-ciZ81bwUw-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZABdDmzHteT8ecvqp3G/jO/1syomfBkwkR/qouxxIXlUvOY2Db60xyUPHOTsdnrwJPuumXTW5dx9ogGug9ASF7pFDCxfEg53VMSY7YbhuaojchOoA/oI28LPS6yTxHsiVvod/wcpKcwJlIia+4eqf5uwcv3EXHaJTpYAup/dk1ZRO7dgaFte4RkYp4NzmnjEGl/5N9kBWk9AFUym6LOhQNhWhJAvHLDjcZZV9KgPVbketx6c7wz59FbYf9J9Cnb4al4q5qGY1ojq7iA7JKS+wRrTBaIvWOlc5LA/EbAdU6kYfgN3rcdD9ZKcDsL46aTGLwwb1lQTgEIAV/eUXE/5OA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=H8bfy44Kldc2RqppGX0GDbslnJnZuK1kudBdrWRi9kc=; b=P9FxXsRRMy49hPf2nzaNwZfZf9YKIV9wU2NBjvhZVANXwZbFSdDVlfJ4UbFwVXIxna3/+wQAglgpetaadaymP4xuAbTInNBDCiits6Lh1zQC8htZr9tV3QKWXsMZ8JA+2ikOxSxXMEeeZZzXZu6yZmttOPkIaYxgNxkYxYqgKlYIYxsInLUeDGdP7GRLcuMhv4ZMOOZ1zQMTkVMziSGHutn4Wma9E6MfUE7YAtaS2wse1juBBIP04RQA5hNRJdy77WDOHy0NY835ixlXi9zFLir0b03iTS/HMGi5alCkvZ2EoMzNa3HuCsSt12x6ARhGThzNQS7lupieO0HZOaNgww== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=suse.com; Subject: [PATCH v2 3/6] libxencall: introduce variant of xencall2() returning long From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Ian Jackson , Juergen Gross References: <6c532607-c2a3-d0ab-e4e5-428f85f4a045@suse.com> Message-ID: Date: Tue, 22 Jun 2021 17:18:42 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 In-Reply-To: <6c532607-c2a3-d0ab-e4e5-428f85f4a045@suse.com> Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Originating-IP: [37.24.206.209] X-ClientProxiedBy: PR0P264CA0263.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100::35) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c06bc438-2769-4886-86ad-08d9359105fc X-MS-TrafficTypeDiagnostic: VE1PR04MB6478: X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6108; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gUDDvKzVKiCCj9xzUaYYLKGC/hdCUgGTqdigMLN9pgc+9YegNHzpkuUSH5Iyk8AUGN1EZn0eOW7+hdntP6C+pZTxZoiR+LdxELYVM+ERTmZhr0G4mY8OFmn6cPo2VrG+/KhF0WJ9L5QSSUBjJ6vb+vO2x92sWQq/4dv3vEreyialBAPhR28atST4cXioa4hSNALNfKbTcmTD9TPWVCAA26L7D/QPxT+N9kjEyRJHGElMkOzHuYvS09ugABexXDPY1C9SVbakc3U3XA3yqid3aT4bN/FWvZHlkEhY5nyMMCe9RS1XHYwsfl9/6iKRvay0G0brn/ymBdipvqImwViW/fcGUN1DkYFBMviTb6qOJdqHY5fFIqVZ0+sU6VL7ZRT+7qggyDYXBwWvv5ZNqtJ/tEk8fkfrtpTmpXvAiso3fDr2riNteQ+dXRtzwh0z4FuZE4QkfODxOgDUAVp3GDT1g1ix3I5M4GudnfxbcDBh67JYE4WeBNB1vnJVU+HqAvgKZqzOIMq/+/okEHhwUtiwRhJENq/8k2wQ6HffTr69aLL8NPkw9KfUFGiQQSuKRARnPSSxwHDB6sALUvf8TyIEseUV5VZmsLgSYwx2Op8LN1XAGKFveSLmJqrHNqgtCJVpZp1KdJedVfEm1rj/1caNygui04k5tLHlNADgH8ZcVAaC5E46dIhXfbAOjzzLSYdw X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(136003)(346002)(39850400004)(376002)(396003)(366004)(26005)(186003)(5660300002)(4326008)(16526019)(36756003)(38100700002)(2616005)(107886003)(316002)(956004)(54906003)(16576012)(2906002)(31696002)(66946007)(8936002)(86362001)(6916009)(478600001)(6486002)(8676002)(66556008)(66476007)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bVhYVG4xN3ZiWjBIMW1TTk0vV3VueGZHNzJXNGhLTVFsQm1BTHZNVW5OSUNt?= =?utf-8?B?MUI3czNqdkhZVnZEOWJabGFTaDRyU283azJJWnlRRk9aREY0bHZ2OUVlT2Ri?= =?utf-8?B?NHkwRmJiZXZONG9BVVJueXFqdFlZREFsVVgrd3pDc0F5TmNicHhiRXQxTXpD?= =?utf-8?B?cVhuZnpET1VsYlhseXZyTHB6RGR6SGpUcnQrSzlSWnlSeFBVQ0Y1MzlVdExo?= =?utf-8?B?T3pZRHNPbVRFTG5jSmFkeEFOVGhzYjNOR3pmLzEvREt4SEJHSTlQOWs0aytI?= =?utf-8?B?NlljTVRPcUVpMy95S0RMejZ5UEFIcERzZ3ZuYy85RCtZVkN0L0VEdTF1OE5I?= =?utf-8?B?dG4vaFgrNmVUbVdoSi9RK1JaTmdjOTVVZDNUL3RUT2lGR0V4RWZtRkxiMFlW?= =?utf-8?B?RHdqNUtkU2JXWVFGWDBXNVZqUkQzU04zam9LYnJ1dTRtak1xd3VHbVJ6V21Z?= =?utf-8?B?TXJJcFFRVXBQeG1oeWh3WDdaV0V0V2RyUlp6NmlEZGVSb3QvemcrY0tvZmdZ?= =?utf-8?B?bEVPQXJ2RnN5ZkR4d0NEd3FBM0loZjBjbjE5bkRmTnlaVXJYOEpuMnkzRlVu?= =?utf-8?B?NTZNQkhiT0VtRCt2MXRNOEtUQTJWeHEwN2RBL3paWmFaeCtDMGp3M3Z4SnhE?= =?utf-8?B?M05QNnN6TUVlOGhSOHg3SU9zY3E1QTQyL1h2ZWZsZHROL28yM1MvZVB2Ykdw?= =?utf-8?B?YUpCd2NJekJsMVR5a1YzM2FjdWF4bjU1VTVoV0hCU1d5cEpVSlRGaUFvSExj?= =?utf-8?B?V0phUUtMbkRiUm15WnVIVklCVGNBNU1tTEd3THRUK2xtcE1CRGZqejZSTHJE?= =?utf-8?B?dm9hU0tMOUtLOHYweGtWMGtNS1JJdnhUTFNEc1c1WTVXbnlIaFhKMGJFYXo0?= =?utf-8?B?am1qbENncUxOblVQcDMvakdLN0hPTkVVbXY5Z3pRbDN6T3d3ZEZjS0NnZ0JC?= =?utf-8?B?WHlKeVlvRFg1c1VvRWJ0VFVOSjFBWWJvcGFPZVk1a3hNYy9QalExYURSTVhl?= =?utf-8?B?QTVKNUlMNnJDUGdNajhiVUtPWFdvZ0RwdXVKZk5Jb3V4SmtIZ1NKak4rS2tM?= =?utf-8?B?OXlVamZuY3I2UEtGMzA2VWlJU0pXMkpmODBxWEVIYWFBN3pZWFJsK0ZBL3Y3?= =?utf-8?B?aUpXajNIdkJvcG1VaTRFMk5qRkVLVHJyTGl5THY3Zjd0NTNvWlBQRUpVa3pv?= =?utf-8?B?bWRyb2w4eTVnVW9yWFZSMFZHNWlDK0hjSEpTZ0pTbzhkcVlBdGNreER3U21F?= =?utf-8?B?QVE4ZUoyT3lDcWlvb05kLzdLWWZMQ2pGRDN1WGRHOUxMU3V2RDMxdDh3cHNB?= =?utf-8?B?Ri92RHp3Smh6SWFKdFBKTGpnN3h5SVZBL3FuTHo0KzgrU0NoQzcvV09JUzBu?= =?utf-8?B?N0huanBOL09TTXdWb1QzWWRTeHNMMHR1UHJzTWEySmNFMFk2N2k3alVCaDJi?= =?utf-8?B?anF4a04zTGY3UjVFS2VTVDhvNnBzaGg2cU8rS0RmSnZpK0hQYVhENlFkcC8r?= =?utf-8?B?dzQwd0hsM2taK2pFcXpROHVLYWZIY2pRUHcwTEIxdXZRSEhzMEc5OGN5SDlZ?= =?utf-8?B?RFRxYUJhUEZCaHFLRWMrVmsvbWlwSkYzWmsvS2VGaDI3MStzeFJiRU1pdjJG?= =?utf-8?B?V24ySUttUFZSVEFpNGt6cFBQRHlhdjRYaUFtalBEQ3pMN1ZWamU5K0RxSE93?= =?utf-8?B?ZnFKWkVsdENaQUI2SnRiTEdzT2cxWUt6WGpCSG44bGYrREVIZEpVcG02dVU5?= =?utf-8?Q?xHk3BjVxgJIj60+15dmKFP2a+TVfcXERkIQ2bV4?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: c06bc438-2769-4886-86ad-08d9359105fc X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jun 2021 15:18:43.7670 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9tc9Vx6D3GP3CSY+XZ8ho/Ind66LGTJurpJDoqtwRaqm8zdp5jKDax0AMm/jFDhCp333ek20xdQolCFG+RzeCQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6478 X-ZohoMail-DKIM: pass (identity @suse.com) Content-Type: text/plain; charset="utf-8" Some hypercalls, memory-op in particular, can return values requiring more than 31 bits to represent. Hence the underlying layers need to make sure they won't truncate such values. Signed-off-by: Jan Beulich Acked-by: Ian Jackson Acked-by: Andrew Cooper --- v2: Move dropping of xencall6 from the version script to a separate patch. --- I wasn't sure whether equivalents for the other xencall() should also be introduced, and hence I went for the minimal solution first. Otoh there's also xencall0() without any users ... --- a/tools/include/xencall.h +++ b/tools/include/xencall.h @@ -113,6 +113,10 @@ int xencall5(xencall_handle *xcall, unsi uint64_t arg1, uint64_t arg2, uint64_t arg3, uint64_t arg4, uint64_t arg5); =20 +/* Variant(s) of the above, as needed, returning "long" instead of "int". = */ +long xencall2L(xencall_handle *xcall, unsigned int op, + uint64_t arg1, uint64_t arg2); + /* * Allocate and free memory which is suitable for use as a pointer * argument to a hypercall. --- a/tools/libs/call/core.c +++ b/tools/libs/call/core.c @@ -127,6 +127,17 @@ int xencall2(xencall_handle *xcall, unsi return osdep_hypercall(xcall, &call); } =20 +long xencall2L(xencall_handle *xcall, unsigned int op, + uint64_t arg1, uint64_t arg2) +{ + privcmd_hypercall_t call =3D { + .op =3D op, + .arg =3D { arg1, arg2 }, + }; + + return osdep_hypercall(xcall, &call); +} + int xencall3(xencall_handle *xcall, unsigned int op, uint64_t arg1, uint64_t arg2, uint64_t arg3) { --- a/tools/libs/call/libxencall.map +++ b/tools/libs/call/libxencall.map @@ -27,3 +27,8 @@ VERS_1.2 { global: xencall_fd; } VERS_1.1; + +VERS_1.3 { + global: + xencall2L; +} VERS_1.2; From nobody Wed May 1 02:06:43 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=fail (BodyHash is different from the expected one); dmarc=pass(p=quarantine dis=none) header.from=suse.com Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1624375165098240.4439275461218; Tue, 22 Jun 2021 08:19:25 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.145909.268392 (Exim 4.92) (envelope-from ) id 1lviBF-0000a9-EZ; Tue, 22 Jun 2021 15:19:13 +0000 Received: by outflank-mailman (output) from mailman id 145909.268392; Tue, 22 Jun 2021 15:19:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lviBF-0000a2-BK; Tue, 22 Jun 2021 15:19:13 +0000 Received: by outflank-mailman (input) for mailman id 145909; Tue, 22 Jun 2021 15:19:11 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lviBD-0000XJ-Mc for xen-devel@lists.xenproject.org; Tue, 22 Jun 2021 15:19:11 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 998ae3e5-60d6-4031-abb0-03934d01a185; Tue, 22 Jun 2021 15:19:10 +0000 (UTC) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05lp2109.outbound.protection.outlook.com [104.47.17.109]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-17-6zrQ2TaTMkqiTtvGoEOE0w-2; Tue, 22 Jun 2021 17:19:08 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VE1PR04MB6478.eurprd04.prod.outlook.com (2603:10a6:803:12a::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4242.21; Tue, 22 Jun 2021 15:19:06 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::f06c:6f5d:34d2:1c36]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::f06c:6f5d:34d2:1c36%5]) with mapi id 15.20.4242.023; Tue, 22 Jun 2021 15:19:06 +0000 Received: from [10.156.60.236] (37.24.206.209) by PR1P264CA0022.FRAP264.PROD.OUTLOOK.COM (2603:10a6:102:19f::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4264.18 via Frontend Transport; Tue, 22 Jun 2021 15:19:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 998ae3e5-60d6-4031-abb0-03934d01a185 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1624375149; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=h7aZ9aamUBA9PBvkAH24rsLpHVK608muDDgeGAckfnI=; b=aS8BNci371L7vMIMzl9srivjh3hBVrl5HwhCcaPU3npBsfVWE5AtbkBK8RvjbiKAywvrkx HSrep8NFvAOdU/izWN6zfYs5L+uYezUYbcvA9MgSBju2daG//PSlApG4aPNQ+vSJKe19h0 cv66Xt5JkUSQspcyyWWmhh28e+6VNCs= X-MC-Unique: 6zrQ2TaTMkqiTtvGoEOE0w-2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OoF6GGcQ0TodynqEUwR3HXb+4LvimWVBOX/LWgojfN4MABHmlIwTimmPclQeJB6KFsM8RV/Acxr35rJJTsr84zgTSvDpTEeHFYLVA/EIdN701YpzshuR3ZBweWPlfNDo+gl3O67h8omnrRo0MfU2RlFeFOfdrYYywOmr6ilM/vUjhS+m5jmTxS7cotbD8vsk1BNNl6rIqNdAiCCSbK3GSwM3CfpHMgkklyIw2CkU0YlLxjOUGuQdtSbxzyy6w8RwHkTeHX8k0Q8y64+cIUST3pRiOgaAVmwSVfqzdjGT3tOTWKEkm2UH822obVXs8l35i4wshaPX8jfR19pvl3xkag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PwPksR3zOXlIg4DjGCbrhutFiluGq2C63mB3WLwPcfg=; b=a8mBeyHUwTDt1boieaUJo9i4xWpV30HOBBCh4Kb3FT2DhvMKpbrpGw7gmKqyYcF3SIHZF+n3GnrJjm+AGcStdIv1a4dvFiwUPrZ8+HnIcrhJ4JXoJll+OOFYtU1ZDIeIdTanE6CadO/XeBB0HncyP0/LBe+w2c4bCL2O3EsDCQX/SsfpFjsG5EcbtlP/HCPRdsVoVWqmc9yfpTc/Q5jIOFJl8JP7/59H+McreytCRCpA+cGnc07dXu+9cX3FZh0h+5ARqey6bHVA4P82vGIrdZ3VrzXAxUkboGAxI5A80QAG+GTnZIXzGeMxiECpfUcYZspfoq1lbGh2C79J8dJWaQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=suse.com; Subject: [PATCH v2 4/6] libxc: use multicall for memory-op on Linux (and Solaris) From: Jan Beulich To: "xen-devel@lists.xenproject.org" CC: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Ian Jackson , Juergen Gross References: <6c532607-c2a3-d0ab-e4e5-428f85f4a045@suse.com> Message-ID: Date: Tue, 22 Jun 2021 17:19:04 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 In-Reply-To: <6c532607-c2a3-d0ab-e4e5-428f85f4a045@suse.com> Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Originating-IP: [37.24.206.209] X-ClientProxiedBy: PR1P264CA0022.FRAP264.PROD.OUTLOOK.COM (2603:10a6:102:19f::9) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2af4d3b3-c47e-4da7-2ee7-08d93591136e X-MS-TrafficTypeDiagnostic: VE1PR04MB6478: X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: kPZVrueqmqCyMIXqHap0u4FjWA5I14tDUujkboLal9DQ3naUECJGVN+qvodZMGyDM0FWsiOYBiXeUyqLkLVVadwQrCcEuGCf87+KT+IPoQCGTHNYbEToA6f53sANC1BrfWCwJ0R+wN5Q0YWdskgOqEXVG8SL69gmRkQ/oBxxNLc9kEpwhaBYpQE4YOJreRi1ot+Fvi1czjt35cEbrwRVUFJ/MPcd3jUZ5iYLOSq4OAVffSubYb742FI+by98GD0N2Rv475YMiP1hqta+vCYrPWfM162tUT0NGop5ReK9y6sZ9pyog1X4a+3dtbhAIMWAHgKjtWHUutLTLgzXpARNnPWB5dG9IUeyC2pRr3duPTuOuhrlQ/14opze5Hll+J67ojrMG6HzsOmNcXTm6V8yXKy/gC9Nbk8RmR4cshdsBDwyu74aTSUo5kl5YeKrJ4FN0YX2kHdAGtFKbR9QsJBxZP9omtcXaAYC0VAi5UrewgLnA5qpSRpt5p9jjp0KCTQrNo1E+dx8P+1fm2QlhDSI01uCkp+zbBFbpaxWS+IlkoRVw6i3jjIGcsPlkGPifnQ1OswGav9y4r/Tj6mUFOavF1y8kJQO31RBMmk1XwShd0WHc/qMqC0d/opQ0jcDZor90UIeiuVdqsP8HhtMOnvAgmVwITPOXGh2jjZvibutvqJWdyScRpAdp+6BzBlQlPGU X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(136003)(346002)(39850400004)(376002)(396003)(366004)(26005)(186003)(5660300002)(4326008)(16526019)(36756003)(38100700002)(2616005)(107886003)(316002)(956004)(54906003)(16576012)(2906002)(66574015)(31696002)(66946007)(8936002)(86362001)(83380400001)(6916009)(478600001)(6486002)(8676002)(66556008)(66476007)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?RUpPJBFxRdYJawBxj1vTgUDdSTCvXM1/Vhfa7cO1LhXJEtB2xGAntV9uJMJm?= =?us-ascii?Q?ZaLm1WYDdqTRZsv+hSauZaTBJwIxZimiXT414vnBGTcRdtZTVYMhIRWYbqX5?= =?us-ascii?Q?9mjbvmSPqybCHpfkCOupvIV2K5BvEOZzQYtJmix2NMJQeKxSliDgZRI3c2UR?= =?us-ascii?Q?6GdDNgV0JfiqIIVVGbz/Oowb0EZkB134Zdo+KlyT9BOhQIuRuBultgUiMP2Z?= =?us-ascii?Q?seyR4zGhiY4WLHBNc+nr7K8xCi9/1YdYSe/wHVQi2LKUaG14R6PlOGW6SacQ?= =?us-ascii?Q?wk9he1QaIu54Phogtf6GueoTouQMpvuXwPhhW0GNTrpazfTNRbJdVatJ8yXf?= =?us-ascii?Q?iUU53po5xGb9mA/VV2I/3YScXm4XmR36dAyrwhCIZ5AKpnH23Ha1XyzxZ3c5?= =?us-ascii?Q?fPt2Jiucre6rHHmMicxULto/+gk9rKM+dhf0m7X3u7dw1NdCcEzs0WBEbQ9t?= =?us-ascii?Q?QkOhmKjoje6OEaFsLST7q74O4wGoJdmX4a6ZbbNG1LAV0PLy7iUuPXQaDBKK?= =?us-ascii?Q?WIEZBLN4AenYy9deoRMQEbru8HO41s0lO7LgiUIGsGhwKJBh4Svfv6dz30DF?= =?us-ascii?Q?deBEYEcVOHfJbwNkwPg2WY7tgR/j+H39VffMnYYzWqqEepcASAGFJQO9juHu?= =?us-ascii?Q?3y9YGOjQuViZjPm64AzHZVCyOp53MUpDB0YspOAa2t0IDlJOdSEX/whCNYAY?= =?us-ascii?Q?8+2uMyYvOUBsgtHPrdEDRfxF4O8dvody3JQCKfm+EBM+bpGBHhsWnQyqYWrH?= =?us-ascii?Q?kEzNenmr1OZZB00d/wRbPgT/5XgtUmH7cZkvzduDjYGYMmqBsmOeuMIHy1hE?= =?us-ascii?Q?6W7qzEbLgk7PsXNVRxVpCIxsPxc+AWd/UwR84BdKk+rOUp14YpLvhpplSejU?= =?us-ascii?Q?H0qtAPXXXZz94vNv5E8ondBvdKqyJjGVyC8j1hpjcofnNFkmew1WXUrlgFZI?= =?us-ascii?Q?Bw1sWHV0p9QsoHizErpwwxZOiOgmmhjJMaLi3fz77S7iaRSrs2nSncIK0sQo?= =?us-ascii?Q?01W+jr8ys+Sg5HzkQkow61v98K2WjaPuYjpssNuyMHqInKQd7udImahjHjWD?= =?us-ascii?Q?xrlGF2z43CpFkPwf96iW+s8CCAuI0OOCDX8FYSo2USWlP/d9curQQ2AKTiyR?= =?us-ascii?Q?hdew/VXRk3A1g79YjsBCqhVUPiCk0AeON1KLOKX3T56C6JaborLD8kKi+WbW?= =?us-ascii?Q?G1VHL1hwiL6kmWe4leX7I+j5KLY/1sAzqiff/mGS48h2PyCc2QdYRnWefkEF?= =?us-ascii?Q?nFNMHtALK08pXBkNM9ZWYf48ldUytIrSZm0asNN4r7aB1vrxbReIBbWdXFhV?= =?us-ascii?Q?g18ar28YAch0PetxwgOBV4yQ?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2af4d3b3-c47e-4da7-2ee7-08d93591136e X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jun 2021 15:19:06.3243 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: pnohVVCWTz4H60C68EKvgp7ZWF9n498W8LboSspQaRwNDfAwxdMr6/eD6939Kw4yxlJNrhX5yyrzvfZR8WPeUg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6478 X-ZohoMail-DKIM: pass (identity @suse.com) Content-Type: text/plain; charset="utf-8" Some sub-functions, XENMEM_maximum_gpfn and XENMEM_maximum_ram_page in particular, can return values requiring more than 31 bits to represent. Hence we cannot issue the hypercall directly when the return value of ioctl() is used to propagate this value (note that this is not the case for the BSDs, and MiniOS already wraps all hypercalls in a multicall). Suggested-by: J=C3=BCrgen Gro=C3=9F Signed-off-by: Jan Beulich Acked-by: Ian Jackson --- a/tools/libs/ctrl/xc_private.c +++ b/tools/libs/ctrl/xc_private.c @@ -337,8 +337,47 @@ long do_memory_op(xc_interface *xch, int goto out1; } =20 - ret =3D xencall2(xch->xcall, __HYPERVISOR_memory_op, - cmd, HYPERCALL_BUFFER_AS_ARG(arg)); +#if defined(__linux__) || defined(__sun__) + /* + * Some sub-ops return values which don't fit in "int". On platforms + * without a specific hypercall return value field in the privcmd + * interface structure, issue the request as a single-element multical= l, + * to be able to capture the full return value. + */ + if ( sizeof(long) > sizeof(int) ) + { + multicall_entry_t multicall =3D { + .op =3D __HYPERVISOR_memory_op, + .args[0] =3D cmd, + .args[1] =3D HYPERCALL_BUFFER_AS_ARG(arg), + }, *call =3D &multicall; + DECLARE_HYPERCALL_BOUNCE(call, sizeof(*call), + XC_HYPERCALL_BUFFER_BOUNCE_BOTH); + + if ( xc_hypercall_bounce_pre(xch, call) ) + { + PERROR("Could not bounce buffer for memory_op hypercall"); + goto out1; + } + + ret =3D do_multicall_op(xch, HYPERCALL_BUFFER(call), 1); + + xc_hypercall_bounce_post(xch, call); + + if ( !ret ) + { + ret =3D multicall.result; + if ( multicall.result > ~0xfffUL ) + { + errno =3D -ret; + ret =3D -1; + } + } + } + else +#endif + ret =3D xencall2L(xch->xcall, __HYPERVISOR_memory_op, + cmd, HYPERCALL_BUFFER_AS_ARG(arg)); =20 xc_hypercall_bounce_post(xch, arg); out1: From nobody Wed May 1 02:06:43 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1dmarc=pass fromdomain=suse.com); dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=2; a=rsa-sha256; t=1624375186; cv=pass; d=zohomail.com; s=zohoarc; b=GtE3C8CsD7iTFeG0FWl0VRn3QIVC4NQEG/WojWA7GDaz5B1GtiTyhGsQyd4KZn2gsPUK5XtLH6Z/+mjFsEGSuLxTvnPzdEFo8PhvDBQhqiz5ShCExDa2fTpEq1Cut5iyyJU3kFwPGhJJr3g1QDQR5YIObhrYpLPGYsOwZqgmblY= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1624375186; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=n+RA79yrrkoc85+kR+9lxbJJZIXFoICggX2gAQT5Oiw=; b=gd7KvS9O/cc1IKAPD07rtrxk7z9haIdQ2mXYiIqBBt9iMPb1JLu5N6uSO41u/ABVt3mzY4Tid+/5dLCG8QXJXhhiZKkz5Iavt3yFc7XYBmPEEQMmZzfo2Ryr9NitPctO/VnNkLPjtfEwPZivYnKQdBL1fmfheHQYOwRFwdTRCF8= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1dmarc=pass fromdomain=suse.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1624375186182707.0258597079062; Tue, 22 Jun 2021 08:19:46 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.145913.268404 (Exim 4.92) (envelope-from ) id 1lviBY-000158-OP; Tue, 22 Jun 2021 15:19:32 +0000 Received: by outflank-mailman (output) from mailman id 145913.268404; Tue, 22 Jun 2021 15:19:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lviBY-000151-LD; Tue, 22 Jun 2021 15:19:32 +0000 Received: by outflank-mailman (input) for mailman id 145913; Tue, 22 Jun 2021 15:19:31 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lviBX-00011D-0m for xen-devel@lists.xenproject.org; Tue, 22 Jun 2021 15:19:31 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 1552bf0d-5e04-4f1e-bb80-8d5d36dee918; Tue, 22 Jun 2021 15:19:30 +0000 (UTC) Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-am5eur03lp2050.outbound.protection.outlook.com [104.47.8.50]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-36-EjaQGootNOWTr-Qsi8WUZQ-2; Tue, 22 Jun 2021 17:19:28 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VE1PR04MB6478.eurprd04.prod.outlook.com (2603:10a6:803:12a::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4242.21; Tue, 22 Jun 2021 15:19:26 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::f06c:6f5d:34d2:1c36]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::f06c:6f5d:34d2:1c36%5]) with mapi id 15.20.4242.023; Tue, 22 Jun 2021 15:19:26 +0000 Received: from [10.156.60.236] (37.24.206.209) by PR1P264CA0002.FRAP264.PROD.OUTLOOK.COM (2603:10a6:102:19e::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.22 via Frontend Transport; Tue, 22 Jun 2021 15:19:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1552bf0d-5e04-4f1e-bb80-8d5d36dee918 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1624375169; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=n+RA79yrrkoc85+kR+9lxbJJZIXFoICggX2gAQT5Oiw=; b=YYEPU0t9ETg/l0xQXtmuQgkK8xujZ+5+wzJOxuFrlvAWn/HosTobkS5GA8jVDEZml5d6hK jqoUdlTTIWqb/nLjobrcKpSeaAyfbjnnKfkhxXCLHjfhwvRmKjiApbWNqfCwbQLqmKftXM qAqOIA60zkKAf8X5X5Akpkfx32YLI3g= X-MC-Unique: EjaQGootNOWTr-Qsi8WUZQ-2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QR5lT6eN8nUgwo3hqeFyOU/uZJt4Jxyd+J+sHKY+lXml3CtPfL2Pc1t4j2kV/ulsCVWdXhOGM6ExbrYR0bTR4CPbIekrzN9QP5ansZfnuLnjQvJJq1Wsj5l/L3qlVGQXtIRB1hkLrUBplKtPF1+qyh0Um4QaHLpS4Ek3I6TO3JCrUYTzgOFK0thKLOAmXcyeXXOAhq5rIHz/KB8Xy8+AWgXNO6Xas18xmA4QEw+D/CbRde3qZHFT3ixnshqy92SCcoQ51Q27POI7ye5Cz9tua4BVVt4TjeHSsClPgGEoR05sSZ8gBVjT8jXh/K6A0ViLJ6b8lYV+8v+0TDZlJ7lPdg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=n+RA79yrrkoc85+kR+9lxbJJZIXFoICggX2gAQT5Oiw=; b=lljFb9IhQ0FZ6QZBKE7bmgXYuvWIqLgIHcED5GOJvI6Sg25/Mo9U4N9Z6v2iGtcjOIVaWJTQvVuv6RzFUQo9IHGsxz4jnpS+ejZSsoRdO9fkrBvOJRtO7wU5L4I5yK/APsz7fh/VmKBRNxlSjSH1mOFQ/EGP8otMiZEWlDQlnePTsw2XEmjNMVBKZGSyygPnwZHj3gJWsG53a8a6oAjE0OUvvOzW0tjP6dSN+BAtxSRkmo0NGi0Kzm9Ne5r7bFuYmnU7qeE1GFLNxpZZUAmzZuaHeVQm/Av3nXVVCpmYyISr2xNcG3rUbad1Ld/vtloGuDgboebBXRtGo/XdrqolUQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=suse.com; Subject: [PATCH v2 5/6] libxencall: drop bogus mentioning of xencall6() From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Ian Jackson , Juergen Gross References: <6c532607-c2a3-d0ab-e4e5-428f85f4a045@suse.com> Message-ID: <1792bdfc-7510-6628-e63c-aee2c7d2cab5@suse.com> Date: Tue, 22 Jun 2021 17:19:24 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 In-Reply-To: <6c532607-c2a3-d0ab-e4e5-428f85f4a045@suse.com> Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Originating-IP: [37.24.206.209] X-ClientProxiedBy: PR1P264CA0002.FRAP264.PROD.OUTLOOK.COM (2603:10a6:102:19e::7) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 466f75d3-720c-4221-a87a-08d935911f51 X-MS-TrafficTypeDiagnostic: VE1PR04MB6478: X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: V5no5adaQmJmsYZYJWWP+tX6bD5MiRu9+RVS8jMO/dLCxb8BVK6jcBGin4wLhpB5B/SA5cjLvkZSx235bnbunTDOWy/NNGT97DQjxzokwtpd38d1lKv/SFCFYZ8zsVKfvtT/a7JgdHEqWbXHL2QFnMMBeKACYpOOv8gWEiP78OR6ktnDm0vC7GcJVu3vItk3/Ceb02R3JVWShhZYHvEePGaNb4ZbbOSM6fXjHdFKmvmyU5+09YqZKoyGY9t/QWIeupOmqjAy3ClrUMLO/P2ljW6e6tg4Bs3aILjx8ry5/bXE14JnXiNZeOdQm4lxdF7cJH1pVxNWQ8IWRDotoUaS8E1QYhlnTsZirM1TMqolN2bkCc9AVZeNHpyXeXccVHO7yZseRisBPwIz02tgcuvWpF/DlZb/NiNTh6Sz1MrsaEq/Qm/lttM4SjBy+oCalwfs8zxy2pzl2KATJrBUUNIgjWiwfVqm6M7wyTAKr7STmZ6jRPW12YseW3hSSOD2n0THE31YYmcxfEC1NK4K/4MjNvxz/kgHfJDYN1q+TfEIs2g9SJAEfAA3crue9WE1F7GuCh8HXIO6ounIek8A21OeX12IjCr5UoW2nY/xL9MaJDN9tuf4M4Ziepo6Jzwr582rp8R5jr7sqI/F16Mz1LgNP9ieC+UF8MaJ6WA+kHWvkWZNHbaQxwRuz/qIVq/7MnrC X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(136003)(346002)(39850400004)(376002)(396003)(366004)(26005)(186003)(5660300002)(4326008)(16526019)(36756003)(38100700002)(2616005)(107886003)(4744005)(316002)(956004)(54906003)(16576012)(2906002)(31696002)(66946007)(8936002)(86362001)(6916009)(478600001)(6486002)(8676002)(66556008)(66476007)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?M3ZEZHpFTlNLT2FPaEZxTzd1Wm9KUU5jNXFhUHZ4KzREZUVPUUVDNmpuZkJl?= =?utf-8?B?ZGs4U0FyNWNod2JVTDYxM0k0b0ZYOHlDNzhGY0hTVHlrU3M5akwyNzYwL2JW?= =?utf-8?B?Q1hnanRCOFpXQlhEOWI2YUd6T1N5TkZocElYL1RTVmwrVGMwMC91MXUyVmlT?= =?utf-8?B?UmQzR2dVN2RqeDVReVlhcHpBVDQ4MFA1b1ZiMi8vaWZ6bXNoZGtvY0NXdExq?= =?utf-8?B?MytFN0N3LzVOZStnbzZTc1ZENlNsWEVBTjFSTkNiNHdmbmluMGh0KzFFejJt?= =?utf-8?B?R1lFbUlaLzNVVXFIbXA5MFZJUmR4UmdEQ3lvWnI0b1U0cnpDVzllSGxwTnli?= =?utf-8?B?NlpldWxZak9DOG9aZisrbWNkZEJqNFB4ZVBraWt4VFRRZGxRYkNMM1VsWXBr?= =?utf-8?B?ZVBDNWd3d01HVUJhRURxd2Z2b3Rwc0w4R2p3d2JDbFNYTTN3TURxMEhnWXdU?= =?utf-8?B?NTRzblFTR1lTbHgyTUgrdjRMQkQwczh4c09BWUwzMnZ2MXY3WWtnTEMxZmtI?= =?utf-8?B?RGZXVnRPSWw0SVpEYmg4OUorcW5NWWJELzZaWnV0STZnRFBJUzY4VStUcGVU?= =?utf-8?B?eU5STEIyLzUwdXNDVDBjdjJPaVJneHRqalJSREVRYmp6SkE3amNqMnBJeGZ5?= =?utf-8?B?UjljYVFhN1ZtVmQ4UlVmMlFqMWRuM2xTNUVCWmppQnlremsveGpuTTVHdXRR?= =?utf-8?B?d1dQYWhZWXFaL2Y3NkJhSHFVRjJpdE0wWGtuTFhZU3gxbTdMNzF2OU94ZEVv?= =?utf-8?B?VUtHQUZWcnV4c1g0UERicjA3dHlUaHRCUnpJZUdPVCthVVBDRUp3NkF1Zyt3?= =?utf-8?B?cEYrcDEvTWdpRm8vNWpzUWRhM1l1b1ZhWUlpd3BBaXRnVnBNbGhTV2VFL0Yr?= =?utf-8?B?V2pZdVpWeXpOYXZNSmQvVHR3T1JtR0lJQjlWTEE3c1pLTlVoc2JsQ1NQVEd1?= =?utf-8?B?OWxWV05sRjFXcGhzeXZPam5QZVExNTRRUTNQMzBSbFhvTmpTOFhkcjU4Zm9p?= =?utf-8?B?OXorTGtETGkzWnFGOEkyTC9vZjBHVDdsMW5TVDgveWNGTERFclRmRWEyWWll?= =?utf-8?B?Vy9pVzFHbXd3Ykx0dU95a3V0Z3BqOGRneHhBcS95c001Z2hteFpzalAxeWZp?= =?utf-8?B?YTdtOEZmdjJTM2JHbzI2VzJtbGIyaVRWQUhFT2U1ZDFONVRjT3IwSktJaHAz?= =?utf-8?B?T1lsZWNQczhwbS9HMVV1L2NWNkh1R1FrOWttMHUzbldIMllsQk9rUWJ6WEI3?= =?utf-8?B?ZGRLeXF5c0E1bEV3K2tIdW9BbWhOWjBmRzM3Q3ZuOUl0N0ZGbVRFVGpEbFdt?= =?utf-8?B?c2pjZXA2YWZpdVZKSEoydmdlVDJzNjRUcXA4NE9uZG5ST2E3UXpiRUZDckkx?= =?utf-8?B?ZExySmhTMmFSOEpjeEdHVFpzRXlkemRqRnByNVBCOUJMbUpHRzB2MG9mKzdU?= =?utf-8?B?OW1sYlBzekxRbnQzVHdGcS9PMzNUWHpZTXpQV0d1d0lOam90QXY0YitMZUlG?= =?utf-8?B?T0JXaDV4NWYrdGx2MTFXTTdsUWJUYkFXYXQ2blNJWkdYYmRBbVdHcWdGbzRi?= =?utf-8?B?UjI3MzZXb0lIK1F0VjhBL1hhVSsrdDZndUdjLzJlbStLbDgwZm9UT3oyYnlB?= =?utf-8?B?SGtidWxSSEN5YWVIaFFWNzJiQ0VPK25USitjTks5K0REMmdWZFl0dUlYSDNw?= =?utf-8?B?ZTdVMmV6cXRBV2dBSzZvbmJPL1JrU3VuTkJrRU9TQjlVclpkaTUzQW0wTE1t?= =?utf-8?Q?I8fXkiX6ZE0NBjUsXo6S8pGm30Vwfj9Roj3PVDf?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 466f75d3-720c-4221-a87a-08d935911f51 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jun 2021 15:19:26.2670 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: W28wX9AKm0/AP/3oHofUSx4d/CxK07IYcK3tWNxf5oDOuVzPz+GRpfXczKuizrNeem6pN1ykKWFasQJ7uyxDAQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6478 X-ZohoMail-DKIM: pass (identity @suse.com) Content-Type: text/plain; charset="utf-8" There's no xencall6(), so the version script also shouldn't mention it. If such a function would ever appear, it shouldn't land in version 1.0. Signed-off-by: Jan Beulich Acked-by: Ian Jackson Reviewed-by: Andrew Cooper --- v2: Split out of earlier patch. --- a/tools/libs/call/libxencall.map +++ b/tools/libs/call/libxencall.map @@ -9,7 +9,6 @@ VERS_1.0 { xencall3; xencall4; xencall5; - xencall6; =20 xencall_alloc_buffer; xencall_free_buffer; From nobody Wed May 1 02:06:43 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1dmarc=pass fromdomain=suse.com); dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=2; a=rsa-sha256; t=1624375228; cv=pass; d=zohomail.com; s=zohoarc; b=LfdDtx1dhLO12cCHB0MqIZo75PMpfG48xeYz10Kpl+dZSzTWVEkYq1E0Y2IlAc7mGOuA1lGJ76p6YTgDX42xwzHbpldhAZBpg7phV2Qkiq8PcHnOa/m8fNPMPRUg9lUHUv+gm+2tJ4f+NjiEwcJcqMw7om7p4B9kq1nCRtwosA8= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1624375228; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Og7xcSihKTx4mD8l0odbkYhE4SgiX50KQmBwymR7sNw=; b=oBcSd2a7MQmsLqocYjyDfAKCbOGalchLnv+WhAIZhrN8q6XbGEPUVTDA2O50H+kYT4sShvLMXo26co+abZdYdSX9juXkytHrCeyusX4UUAMGjumoHq/YJdA0zfJhQ6RQmnFR3WA76n5uRXXEAPq7XipBsGJpM3cZbsKEqzXM7CE= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1dmarc=pass fromdomain=suse.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1624375228304397.5809762457154; Tue, 22 Jun 2021 08:20:28 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.145921.268415 (Exim 4.92) (envelope-from ) id 1lviCC-0002UX-1j; Tue, 22 Jun 2021 15:20:12 +0000 Received: by outflank-mailman (output) from mailman id 145921.268415; Tue, 22 Jun 2021 15:20:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lviCB-0002UQ-Uj; Tue, 22 Jun 2021 15:20:11 +0000 Received: by outflank-mailman (input) for mailman id 145921; Tue, 22 Jun 2021 15:20:10 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lviCA-0002Tt-Ky for xen-devel@lists.xenproject.org; Tue, 22 Jun 2021 15:20:10 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 253937bb-8550-4922-98f7-4079fef71411; Tue, 22 Jun 2021 15:20:09 +0000 (UTC) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05lp2105.outbound.protection.outlook.com [104.47.17.105]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-30-5rTlzz3pNXOZEdWPCLCoPw-2; Tue, 22 Jun 2021 17:20:07 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VE1PR04MB6478.eurprd04.prod.outlook.com (2603:10a6:803:12a::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4242.21; Tue, 22 Jun 2021 15:20:04 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::f06c:6f5d:34d2:1c36]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::f06c:6f5d:34d2:1c36%5]) with mapi id 15.20.4242.023; Tue, 22 Jun 2021 15:20:04 +0000 Received: from [10.156.60.236] (37.24.206.209) by PR2PR09CA0022.eurprd09.prod.outlook.com (2603:10a6:101:16::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4242.18 via Frontend Transport; Tue, 22 Jun 2021 15:20:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 253937bb-8550-4922-98f7-4079fef71411 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1624375208; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Og7xcSihKTx4mD8l0odbkYhE4SgiX50KQmBwymR7sNw=; b=h4Ng03j4luCQoddfREkTDPaZQQbDw8aI8iV95OOYKLe+PunZwHWrrfOj9J53QjITZDARZr +LQA6aNtprN0yl137yQBpJZhIPchfozO8MvGGU6iOds5+UMPsQyjgRz8IeJP2Q+ZFkONhc A8DuOMHbHayTqLtVgg/PbL8cC7Rshks= X-MC-Unique: 5rTlzz3pNXOZEdWPCLCoPw-2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MIpdHQwhCtZK++gMEWTkSAUTnkXJpzi6L1GXgGrXrdqlUmPJGlqKM7zQKCBVEm073rDNPuwQPIuDwYoM5c9HIY5u/0jBeKMCIrG3gPSyliuVCQ3cdg+FJhXoa4J3HnnEX0I9BNubhV0iMnwNZ9O2vFqR3uLyLeRg/nv/7Cxr/CugSl/pDdXXTAu2pjITRDPQJv7OV8l8nHBj0yrMNCQGVJ3M98lYyy3srIgQMrDoRV6TGgCGjexODvvJ+RUYkxc/Kbq03Irn5+RbmJRKITCS/Zmrv5WS0UmciqFCzLy+oOe9p9vWL7diR9U+saPe2x72NSnjYnEE6VQTtNrFYTSyUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Og7xcSihKTx4mD8l0odbkYhE4SgiX50KQmBwymR7sNw=; b=Ftx7AgSXqBg3UyQldkqjCDigyWEJlD4fwpwGF5k64oo/M3vFArsX2E9LulU66b8UigNokjtJWuolEETZyUlFPJgFc1uYCVY1suxN/WwPRKDQpfZ+r/M8FN8oRK0Ak+ZGZD8Pl1NF0qZMA19y7P7TniplBBsAKabD/bGy393Uzh2FnKsnRD7E2Ig6CYfKOynGO/v3gPDbuB1y10zxXf9TpkxxnkwxgiXPu9kvDiuDe/ZNlXHbcah9sqtJC3wFqhORKanv0JkdzakfOxSeWzx4tqKclN9SKgXD/QT0xCs5bd0Sz/0hKI8O5wHnaZPg0j/woQudMeATW9IAE4cW7/9Xsw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=suse.com; Subject: [PATCH v2 6/6] libxc: make xc_domain_maximum_gpfn() endianness-agnostic From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Juergen Gross , Andrew Cooper , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu References: <6c532607-c2a3-d0ab-e4e5-428f85f4a045@suse.com> Message-ID: Date: Tue, 22 Jun 2021 17:20:02 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 In-Reply-To: <6c532607-c2a3-d0ab-e4e5-428f85f4a045@suse.com> Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Originating-IP: [37.24.206.209] X-ClientProxiedBy: PR2PR09CA0022.eurprd09.prod.outlook.com (2603:10a6:101:16::34) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2b1f91f6-246f-4bd0-07cf-08d935913620 X-MS-TrafficTypeDiagnostic: VE1PR04MB6478: X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: cFyWxvbp+oMFkbut65Pk5jFUjlvVpICzlfRRJzWYKH5EDLxvo3JOMnIDfaiIsAB6j+xUpZ3hgpT3K86HdOmC1KOTG23/q7zqxPuILwf3OooU8/xlCrFmdquw9qseTnEFvqNFeqEs0uK+vFC/51zeJpDM3drWI8T3ujQo/3jOS40RDIeW79ZZpWk/fk8I4Nlas10EoKcvmUTolLbrRRoVApPQ6KgDFYSN85R0pL5zm3JPe4YWF+KbAzheZjGLbn+72WwMc6LxyWx0/dRtiu3736VzWoIQcUnkFLCncyIWrjQJjIK+u22RlgBSqfH79uRHoz6r7meqL9hKsPccq4T1bSnExYyPsyGZaRQGuE+LHp7m1o28QxuzVIpk7i0pSz/1muxBe/810sbuFRYU2Etp22U4INrzEd9tG4nqEFg5tKaw7/kweQj4JdettXftCzK+7pSY3iSkx5mTliRfbkhrtDrJmsUTygcILhZTsopeIBVAnO4xEJrHiIfJGK0nmBb6RujOUvRA9qqerdloYKVKoaX+UsDo27s4NJXO9sLya6yIogLSNi8Y1wQyHmp7XPczrQGtlX8DmYXOAwpzv1/XRp8cL4ttpLO/1AWeepKb39LDGBOqagVpuGDyD9IHtnsQwLo7S8S1VILjWutO4N7RCFo55Tb3ssrxcBcIbdxKpzc4gRo0CBJizBmCW0pXPRuY X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(136003)(346002)(39850400004)(376002)(396003)(366004)(26005)(186003)(5660300002)(4326008)(16526019)(36756003)(38100700002)(2616005)(316002)(956004)(54906003)(16576012)(2906002)(31696002)(66946007)(8936002)(86362001)(83380400001)(6916009)(478600001)(6486002)(8676002)(66556008)(66476007)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VGVMNnlBVUEwa2tXRlc0UzhGaTl1WXBmSEl2QjhTK0cyNEJIdzNuMTNIa24v?= =?utf-8?B?VzluWDNkb0Q0RkhtM1Y5MkVPandSTnpYSGJjS0dHcFFZd1J6cXVWTFcwVjZ3?= =?utf-8?B?R2hJS3ozZi9jenZYOURnNG1ZZTlCSmJPVkdBRlVUM3RTK3VnTk85MTA2R0hr?= =?utf-8?B?VkdTUXhuSFQybS84V3E4QktCc0d4QVV6K1cxdHpock9rUzZ5cTZnUUpvbWZr?= =?utf-8?B?VkFqUG5EV09vODBtKy9hZENtbDRwSnlOYURvd2VBVkRGeTBqWjJZTEVBWWtN?= =?utf-8?B?d3hRUldwUlpJdkt5MndRZWtYQXpuRE1FRUdSNHlrMS9vSmdqLzdidWJ5Mjlr?= =?utf-8?B?OVZKak1WWm5BQWEvL1hLWnFFbTdvTlFQbkJFMExGUDhVc3Fjd3pSbFkyMmIz?= =?utf-8?B?a1k1YVlIV28vdXhZNU9MblVrL3hTL3l3YzRaNGZLT295RUFtdFJCTDRaSGNU?= =?utf-8?B?S2xjNlJCMFVuWk9OZjgyOE93OHFNRTJZRm9kRlRzc3ptQTNuM21Wcy8zd2k4?= =?utf-8?B?S01wTlBTKzM3Qkw5T2N0U3hhRlZTQTNrK2tKbzU1RUptQXY0TDZjaXBrS21L?= =?utf-8?B?ZmJQbGdidk5ZdXNEbGlIekp4bk1DcG1Qc0dNd0pZcTRkQVFEYkl2c3FBYmpT?= =?utf-8?B?d0RuK3d1T3BCQk01MFZ2M3JSblZ5aUtSQWVIWjVqM3JKWjBKbXppVmFPbGty?= =?utf-8?B?aHc3bHhvRDB1cE1adVhqNjlFTVhpb2xaZ2pzTUk5RGxhNk9GdnUwOXFLMmNQ?= =?utf-8?B?MXYwMHcxdXFTeEtxSnhvVmZQbFVnMlFvb0h4MGQ5bmVLZkxRbDJWWUdxNGI1?= =?utf-8?B?NVBHcFhWTEp1eVQ4V0dnZHZlQlFuQkF1eVJwd0J5YkdEY1RHbHNZZmM1dlAz?= =?utf-8?B?WjF2Rm5LOUFpU2pScnRVNTcrOGF6cE1lNHdUTDc2c3U1SFlKV1JicHZuNnRZ?= =?utf-8?B?SG55dTJ2TGNxdjk1RVBKdWJ0RVZzalZERDdQai9mYWpVOE1jcWUzdmVEVW15?= =?utf-8?B?L1RXZFhwR2JkZHFVMlNhUStMWGpxeG5tTUh6QmRlOW51cHJIeFE0ZHczUWFv?= =?utf-8?B?bXVxeENhKzhiZFpLOCt4Z256M0JnVkNnSjZBSEFYNVZySHhtSmt1UXpSMEJR?= =?utf-8?B?U0Q1N0V4RHFHOFhaL0NsK1k0Q25TcWdRY2ZpUkFBZ05IemU1ckpoUUFKYkVO?= =?utf-8?B?dXBTbmprQUNwdkpUamRaZGtSMDA4aHcxamdPWGhFSU1OU05PRWpodm5tZk9o?= =?utf-8?B?WE9kSC9xQXlha2cwbE0wRFVuWVVWOGhqRWErOURoWWoyUm1qaG52ckhXUncw?= =?utf-8?B?eTcza01GL0ZXWkVnRjduemtZT1NzS2gxcWdFN2NYRGw5a3M2UUJwWkZWc2E1?= =?utf-8?B?TXdIR093bWRSWkNMblhYYlh0eHpBNHU2ZVNzVS80UFRYcThDcXpaVk91Vksz?= =?utf-8?B?YThJUC9ITlFGSno2dnNNYW9EME9JRW5KM09iZmQ4a1FuSmxIKzVKTzRlZ3E1?= =?utf-8?B?TTFwdGEvZFY5VkNpZVRScnJUZ3hlSEpLYUtBY2RhMjEzOVBINkx6cGlqbkVY?= =?utf-8?B?aFNaNm9seU5mQXk2K2ZpVkJXRmRRVE1ZOVN3a3BSUlFMWGJpS3VWSDRmZVBF?= =?utf-8?B?WkM2aUJ0bVJncFhiOXpTRjFSU0ZBdGduS2xwdGoxazlMMWVYWEpPeG9pckZs?= =?utf-8?B?ZDVRWUR4Ti9BMTNPYUs5djNqMXJscXFZSlZ1ZitNSG9xaWM3UFRqaVhvSzFk?= =?utf-8?Q?OFG8x0bm9o7KssZ4VyQqAcga1zlUza3ofbwj126?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2b1f91f6-246f-4bd0-07cf-08d935913620 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jun 2021 15:20:04.5803 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: x1c42363XXMi6dBvJRmVnKEADMwNB6dDjrtTIXFhSAtPOphvay9MPzbmKZ077tz3B2q8nYiHAR6B5J31IA+QkA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6478 X-ZohoMail-DKIM: pass (identity @suse.com) Content-Type: text/plain; charset="utf-8" libxc generally uses uint32_t to represent domain IDs. This is fine as long as addresses of such variables aren't taken, to then pass into hypercalls: To the hypervisor, a domain ID is a 16-bit value. Introduce a wrapper struct to deal with the issue. (On architectures with arguments passed in registers, an intermediate variable would have been created by the compiler already anyway, just one of the wrong type.) The public interface change is both source and binary compatible for the architectures we currently support. Signed-off-by: Jan Beulich Acked-by: Ian Jackson Reviewed-by: Andrew Cooper --- v2: Introduce wrapper struct in public interface. --- Together with the comment change I was half tempted to also rename the sub-function identifier to XENMEM_maximum_gfn. But I then decided this would go too far here. --- a/tools/libs/ctrl/xc_domain.c +++ b/tools/libs/ctrl/xc_domain.c @@ -856,7 +856,8 @@ int xc_domain_get_tsc_info(xc_interface =20 int xc_domain_maximum_gpfn(xc_interface *xch, uint32_t domid, xen_pfn_t *g= pfns) { - long rc =3D do_memory_op(xch, XENMEM_maximum_gpfn, &domid, sizeof(domi= d)); + struct xen_memory_domain dom =3D { .domid =3D domid }; + long rc =3D do_memory_op(xch, XENMEM_maximum_gpfn, &dom, sizeof(dom)); =20 if ( rc >=3D 0 ) { --- a/xen/common/memory.c +++ b/xen/common/memory.c @@ -1351,7 +1351,6 @@ long do_memory_op(unsigned long cmd, XEN long rc; struct xen_memory_reservation reservation; struct memop_args args; - domid_t domid; unsigned long start_extent =3D cmd >> MEMOP_EXTENT_SHIFT; int op =3D cmd & MEMOP_CMD_MASK; =20 @@ -1452,13 +1451,16 @@ long do_memory_op(unsigned long cmd, XEN case XENMEM_current_reservation: case XENMEM_maximum_reservation: case XENMEM_maximum_gpfn: + { + struct xen_memory_domain domain; + if ( unlikely(start_extent) ) return -EINVAL; =20 - if ( copy_from_guest(&domid, arg, 1) ) + if ( copy_from_guest(&domain, arg, 1) ) return -EFAULT; =20 - d =3D rcu_lock_domain_by_any_id(domid); + d =3D rcu_lock_domain_by_any_id(domain.domid); if ( d =3D=3D NULL ) return -ESRCH; =20 @@ -1486,6 +1488,7 @@ long do_memory_op(unsigned long cmd, XEN rcu_unlock_domain(d); =20 break; + } =20 case XENMEM_add_to_physmap: { --- a/xen/include/public/memory.h +++ b/xen/include/public/memory.h @@ -148,16 +148,23 @@ DEFINE_XEN_GUEST_HANDLE(xen_memory_excha */ #define XENMEM_maximum_ram_page 2 =20 +struct xen_memory_domain { + /* [IN] Domain information is being queried for. */ + domid_t domid; +}; + /* * Returns the current or maximum memory reservation, in pages, of the * specified domain (may be DOMID_SELF). Returns -ve errcode on failure. - * arg =3D=3D addr of domid_t. + * arg =3D=3D addr of struct xen_memory_domain. */ #define XENMEM_current_reservation 3 #define XENMEM_maximum_reservation 4 =20 /* - * Returns the maximum GPFN in use by the guest, or -ve errcode on failure. + * Returns the maximum GFN in use by the specified domain (may be DOMID_SE= LF). + * Returns -ve errcode on failure. + * arg =3D=3D addr of struct xen_memory_domain. */ #define XENMEM_maximum_gpfn 14 =20