From nobody Thu Oct 30 15:35:56 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1761234614; cv=none; d=zohomail.com; s=zohoarc; b=HMWbPVfxABUstanfL2xNF1kOZKB1T1LkPw2Z7Gl6euAcvu4jicWWJ+o6ptlASlYSR48BoH2wizj3yYRqvhlY75bfz+8C5WQfFiy/0aeaojnkbeNi5+2etL/PJjbPQ+hRKKkJXoDeHuQQqS4Y9gkL0pyxKpL8Uc6xl7Bqh1Xzn98= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1761234614; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=xYN7wbVt5Z5S6tRDPU16XcW0H4EsCETtfXEP3dnQTa4=; b=gCRKAWk1TvbmUySHdQnRBGGWC+CzDkrQGnNXUQK1+INedF9K4V98mEIeUO5089/ERLY8lEuga9NYUtmMLJOcg1DwKtfrMneykfO2xgy31Blzs0ec6QwCHLXUYMb0HyJo8sn2VAPm/3fnD6Nvq+/yZt52M90TA9cGSP+JbYOXCLQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1761234614583408.4281541858163; Thu, 23 Oct 2025 08:50:14 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1149377.1481037 (Exim 4.92) (envelope-from ) id 1vBxZj-0003pW-2P; Thu, 23 Oct 2025 15:50:03 +0000 Received: by outflank-mailman (output) from mailman id 1149377.1481037; Thu, 23 Oct 2025 15:50:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vBxZi-0003pA-UF; Thu, 23 Oct 2025 15:50:02 +0000 Received: by outflank-mailman (input) for mailman id 1149377; Thu, 23 Oct 2025 15:50:01 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vBxZh-0003ZG-QU for xen-devel@lists.xenproject.org; Thu, 23 Oct 2025 15:50:01 +0000 Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [2a00:1450:4864:20::32e]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ee2c4cf3-b027-11f0-980a-7dc792cee155; Thu, 23 Oct 2025 17:49:59 +0200 (CEST) Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-4711825a02bso8183095e9.2 for ; Thu, 23 Oct 2025 08:49:59 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-475c427f77bsm106482355e9.3.2025.10.23.08.49.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Oct 2025 08:49:58 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ee2c4cf3-b027-11f0-980a-7dc792cee155 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1761234599; x=1761839399; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=xYN7wbVt5Z5S6tRDPU16XcW0H4EsCETtfXEP3dnQTa4=; b=JwW6nP4hN1bumgl1fWHqCRmoWFo/KyU4ZBjyXUmJe+S4AjDDRcozdZDxIs1eBqbSb3 ozzV2C3ze7k8W5aXtfek16NUzkKq4h9Dp34TAqHcvGo60GDAiwek9a0I3IojjV9jZ5Ty QVidZwqdx4E+c0rxYzS+4oqmhLVf5cMUA51Ze/CirFMTj99Thr9C1+3zyUpxAYSJ4RMc VWZdVpiG6bdwJ7tjdYAV8+O4ape6j5QWnWlYjseHfrU5GsWMfKSi9eB2wdea9zFxEFB/ ogXhkOiWHM3tgcd8G5ekATsKT80TAVTzRNd9q859G6nKWcOY97zCPUw8f0I6bU3POpD6 gMOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761234599; x=1761839399; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=xYN7wbVt5Z5S6tRDPU16XcW0H4EsCETtfXEP3dnQTa4=; b=BfI5l1v0/Uej+HRLLP6SwAjH9yAqsE7UsVUvnUY77OStDU88moahqckunibGWms54V QIA5xDkIbz3itb6QmX5zzhd4O/0+UMOgv+6LRCYoKNzA4R4VuJ1fTj/597IT7PnujwkW 6f/mspe4iObKFAvBrUe7IHvKF89ZcDVKQjDmegMT4qCFS46FLLeytrcu078FMkPwznpl jfuigASOl/LmlYvxhgrfKTI8YlvpCdHNSf7u5mwtL0kdRJ2uDck0BLBzF3cPUhTGVWPx 5YjqNZ0L4a9MPIxEjkJmy7IPYfTxkT3K+GvqlejExrMwnae8l+XBi4meGXMLtBIXThSa OvZQ== X-Gm-Message-State: AOJu0YwvwqFfV0+3vbZOTcvrmM/lXd3o5Ju7P8tduR9Gn6x8FTYEDAwG 7SmB+dFewqMCjgRYI3bI1VUdjyw4VQjaSJrRf+Kmq33ln74uhBO6KP6hzG3Zyx5OJiaSPx76GsM bUEE= X-Gm-Gg: ASbGncumya9CqolUuAmECIZJFr5iwBgAwe50/2ey82ac+Az1i/0C/3oK2UndamSTJQR hcOOnT6ZtR/I+xPdNdlRjs4XQQiPZgQifnpgR8n2zG7IZc33VOhh9zSgQV1XmbNriZ0UkGJRnIJ udLgKRtsoMQRKe2sd5g7bFMOvsAv2/GSXIio8O6OVC7ri8uyyiwj8xs6s0RUxOgZk68VqH6HVPz fLBw/QCFV9LRqtbJ5R6eWjTmupnf9HCAmp1O+nydZrRq0aCQ/XeSdBJkjh4rFzKZX9VjbycZn4x OiT67rvFV65SBTAI+wVMwSno5aIx5Ekl67O2FvD9RKrwm0nSHrSUZOq2AGs7QP6DFyFvJh8pP7R o18vOA3hhJ+SyB7fOd+8tteTHXvLfFO8hU4bhuKHhuQpd63YVBmS5ZUy/s9G9+6nDmBOGzINTwa c+hI1IGIOmB869njEf3A5/ohApvfqhGg1AlrOsye3GVO6zjvHaSmZKUUILkL0N X-Google-Smtp-Source: AGHT+IGnwDYxW5UufGMOiBlDPLZ2gPYdS3aIFPWYUR9OjKDI4sg/WJpI/GzVSBGD0n8f7kYKcmYcVw== X-Received: by 2002:a05:600d:6357:b0:46e:1a07:7bd5 with SMTP id 5b1f17b1804b1-47160987501mr108488445e9.29.1761234598886; Thu, 23 Oct 2025 08:49:58 -0700 (PDT) Message-ID: <86001bc5-de05-4a5b-9683-54d09c5fa8a8@suse.com> Date: Thu, 23 Oct 2025 17:49:57 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH v3 for-4.21 1/9] x86/HPET: deal with unused channels From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Oleksii Kurochko References: <6a8a912c-7276-42bd-af2b-b94fc6ce4291@suse.com> Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <6a8a912c-7276-42bd-af2b-b94fc6ce4291@suse.com> Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1761234617174154100 Content-Type: text/plain; charset="utf-8" Keeping channels enabled when they're unused is only causing problems: Extra interrupts harm performance, and extra nested interrupts could even have caused worse problems. However, on all Intel hardware I looked at closely, a 0->1 transition of the enable bit causes an immediate IRQ. Hence disabling channels isn't a good idea there. Set a "long" timeout instead. Along with that also "clear" the channel's "next event", for it to be properly written by whatever the next user is going to want (possibly avoiding too early an IRQ). Further, along the same lines, don't enable channels early when starting up an IRQ. This doesn't need to happen earlier than from set_channel_irq_affinity() (once a channel goes into use the very first time). This eliminates a single instance of (XEN) [VT-D]INTR-REMAP: Request device [0000:00:1f.0] fault index 0 (XEN) [VT-D]INTR-REMAP: reason 25 - Blocked a compatibility format interrup= t request during boot. (Why exactly there's only one instance, when we use multiple counters and hence multiple IRQs, I can't tell. My understanding would be that this was due to __hpet_setup_msi_irq() being called only after request_irq() [and hence the .startup handler], yet that should have affected all channels.) Fixes: 3ba523ff957c ("CPUIDLE: enable MSI capable HPET for timer broadcast") Signed-off-by: Jan Beulich Release-Acked-by: Oleksii Kurochko Reviewed-by: Roger Pau Monn=C3=A9 --- A window still remains for IRQs to be caused by stale comparator values: hpet_attach_channel() is called ahead of reprogram_hpet_evt_channel(). Should we also write the comparator to "far into the future"? Furthermore this prolongues the window until "old" vectors may be released again, as this way we potentially (and intentionally) delay the ocurrence of the next IRQ for the channel in question. (This issue will disappear once we switch to a fixed, global vector.) --- v3: Don't disable channels, only set long timeouts. --- a/xen/arch/x86/hpet.c +++ b/xen/arch/x86/hpet.c @@ -295,12 +295,6 @@ static int hpet_msi_write(struct hpet_ev return 0; } =20 -static unsigned int cf_check hpet_msi_startup(struct irq_desc *desc) -{ - hpet_msi_unmask(desc); - return 0; -} - #define hpet_msi_shutdown hpet_msi_mask =20 static void cf_check hpet_msi_set_affinity( @@ -326,7 +320,7 @@ static void cf_check hpet_msi_set_affini */ static hw_irq_controller hpet_msi_type =3D { .typename =3D "HPET-MSI", - .startup =3D hpet_msi_startup, + .startup =3D irq_startup_none, .shutdown =3D hpet_msi_shutdown, .enable =3D hpet_msi_unmask, .disable =3D hpet_msi_mask, @@ -526,6 +520,8 @@ static void hpet_detach_channel(unsigned spin_unlock_irq(&ch->lock); else if ( (next =3D cpumask_first(ch->cpumask)) >=3D nr_cpu_ids ) { + hpet_write32(hpet_read32(HPET_COUNTER), HPET_Tn_CMP(ch->idx)); + ch->next_event =3D STIME_MAX; ch->cpu =3D -1; clear_bit(HPET_EVT_USED_BIT, &ch->flags); spin_unlock_irq(&ch->lock); From nobody Thu Oct 30 15:35:56 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1761234640; cv=none; d=zohomail.com; s=zohoarc; b=lOnCZTQZOBaD/m/PEtA+BjINWcLXIxP92JVxPLZhrwvVyHivGz3F8n9lcaLIdI7bAlnJmin+EZMq4oqTOlvTB4Bus3M2FCIgVDDAqcumUicApWPmXqvoy8aWSmj4dcplLrRrYUkGBlDhaVg51I77klxY6XdpGJvaoXYun6O+If8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1761234640; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=a9ZNQQ7vTuQm2QNqSsqSv8lrn9EAqULHGC/5EXkGJlU=; b=NCspS5C9uzkD7yl0W0JtKaZH86ZSQhMkTaN2sFX2wVKYuA6hd4GZZ3bdixYDVI4rZfxOK/w+VxWGQLmWJDIlDMPefI0sNdsfnfTYZ30dMUCafczt25sD5Ijz+tD1BBYksVuSCDnecg8URRwhviJlHmBiNLhhzY5oWPUnQkxM3ro= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 176123464050288.72761977441871; Thu, 23 Oct 2025 08:50:40 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1149383.1481046 (Exim 4.92) (envelope-from ) id 1vBxa2-0004tm-86; Thu, 23 Oct 2025 15:50:22 +0000 Received: by outflank-mailman (output) from mailman id 1149383.1481046; Thu, 23 Oct 2025 15:50:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vBxa2-0004tf-4s; Thu, 23 Oct 2025 15:50:22 +0000 Received: by outflank-mailman (input) for mailman id 1149383; Thu, 23 Oct 2025 15:50:20 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vBxa0-0004p6-IM for xen-devel@lists.xenproject.org; Thu, 23 Oct 2025 15:50:20 +0000 Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [2a00:1450:4864:20::333]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id fa4be06c-b027-11f0-9d15-b5c5bf9af7f9; Thu, 23 Oct 2025 17:50:19 +0200 (CEST) Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-471b80b994bso13873525e9.3 for ; Thu, 23 Oct 2025 08:50:19 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-429898acd69sm4641473f8f.24.2025.10.23.08.50.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Oct 2025 08:50:19 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fa4be06c-b027-11f0-9d15-b5c5bf9af7f9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1761234619; x=1761839419; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=a9ZNQQ7vTuQm2QNqSsqSv8lrn9EAqULHGC/5EXkGJlU=; b=PhhmBufmrDG1smwf4jQwEf9JMYqrsaHF04hdGxlW0UOyG5WA7vWTUDB3hQHtkfoo0O jMF20XKh4ytpm5b7bv9C7L4tNt4ujbitPt49R4ojd8bfRLJLZ6UofXeHT1dtHwvJeCcD 8Xwa/Co98pkgoFdTAG5LJYlbMM9NxOuQFyPklcre3rIiLFkY81zxtOv5YrhJf+W+zvjC dnu5IK9CRDiTSnC68ryfw1TTvUTO1XLog3+m0/TcA/X4uOkmJMKi8QokOSbCXdiaTupz O0ocO08isRnHw79jCRtf1uMSigyhatoeIQ8Kv5Rb95WHjDyluApMXv/ygST8GMJCJt2E PUYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761234619; x=1761839419; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=a9ZNQQ7vTuQm2QNqSsqSv8lrn9EAqULHGC/5EXkGJlU=; b=w4ZYIEqFKtm7TGS9g/4Afa0o88G1/En1A6IbufZTYPBl3grJgy4dwk6IT6QwWedWns 3AehOLSFcMvQxLHkJJsn25iGHXn56sLn19vagJG9IH9zZRmy186PzMlIawXqI2a07Ddg pG1j3DUDFYQVNzrHYP9rHfQAlVZf8H4nN33D4RtUv2m3FLffIWuspfSWbWnFkGFUjya3 zVLWHPsQfqWIHMvYsWzI+UCLqUHcf/c1tVWIfNnvlbS/DWklzU23ciaLNx2TzoMvRP2M lHQum6es6lFoP61DMTePBwA1g8wVDqghDDDTpkO73bjRr5CYXXgURFYrxfrqg+dGV47M 8tQg== X-Gm-Message-State: AOJu0Yw6uR9lBwZ4rmpJ7e3MNlkQ0R2PnHXfGngUomXrpNSC7POPVKYX /7jruTtJRzMRnTEQJlSiPk06e873zy9fPrx5HNFmBfqc7412d0M0am+ydrN3FlGapC6sjAQGKd6 vZKM= X-Gm-Gg: ASbGncsvYfp9To6cG0W/He5o/FgWMBXfc6E/xduEMdEsLYeIhyQNRfr8lCui42ykaAD q2NrNE0HJxjgRppC98uxp5EQzJfTBNoRTZAx7iI4zgwZN1+E8DojEwGsHDJhp3hgkh/p9Tfq5Yp wqdwMfk/sIX/oMfNJyuzAkY5PdmfXPEfV6AjhaB08GgEyVt3l3QWqK2dit23HhLkcqOte7qb4KT A804zwr5F+1Azj6F58EE9aqKuVdCQ4Q4T8VyuvssZJW5z1XsnDIjePdm5+rpmSY7IDouJN3o96c BBv/sXSZMkKcFmD41h47J0f6+FeXFXRgKlLImbUi5xszKnojdtWyrawGAtS0giEoQopgnGbbGBU TNuPWrXNg0aZFb8V+MMJF67oss5mF+DAXw6aN06Og30yj9nMM4y3fXywBb2lbniStQJm6rXjBLK 6+DQwyxB20pveJ0oMrBkuCS9t0snIYkwg5vsgvA1dmY8j5tzTFAmS3guwhektAvVV24tfb9hQ= X-Google-Smtp-Source: AGHT+IGQBPhlThbmlmJjl0yAMzuSuRiXUtmza9hOPOiw+uoESTecF6URo8jIeblThClQ4hlVqDPrWA== X-Received: by 2002:a05:600c:4715:b0:45b:9a46:69e9 with SMTP id 5b1f17b1804b1-4711791c8c3mr184939895e9.31.1761234619230; Thu, 23 Oct 2025 08:50:19 -0700 (PDT) Message-ID: <545d98e0-755d-471b-84c5-54f129a5aece@suse.com> Date: Thu, 23 Oct 2025 17:50:17 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH v3 for-4.21 2/9] x86/HPET: use single, global, low-priority vector for broadcast IRQ From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Oleksii Kurochko References: <6a8a912c-7276-42bd-af2b-b94fc6ce4291@suse.com> Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <6a8a912c-7276-42bd-af2b-b94fc6ce4291@suse.com> Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1761234647951158500 Content-Type: text/plain; charset="utf-8" Using dynamically allocated / maintained vectors has several downsides: - possible nesting of IRQs due to the effects of IRQ migration, - reduction of vectors available for devices, - IRQs not moving as intended if there's shortage of vectors, - higher runtime overhead. As the vector also doesn't need to be of any priority (first and foremost it really shouldn't be of higher or same priority as the timer IRQ, as that raises TIMER_SOFTIRQ anyway), simply use the lowest one above the legacy range. The vector needs reserving early, until it is known whether it actually is used. If it isn't, it's made available for general use. With a fixed vector, less updating is now necessary in set_channel_irq_affinity(); in particular channels don't need transiently masking anymore, as the necessary update is now atomic. To fully leverage this, however, we want to stop using hpet_msi_set_affinity() there. With the transient masking dropped, we're no longer at risk of missing events. Fixes: 996576b965cc ("xen: allow up to 16383 cpus") Signed-off-by: Jan Beulich Release-Acked-by: Oleksii Kurochko Reviewed-by: Roger Pau Monn=C3=A9 --- This is an alternative proposal to https://lists.xen.org/archives/html/xen-devel/2014-03/msg00399.html. Should we keep hpet_msi_set_affinity() at all? We'd better not have the generic IRQ subsystem play with our IRQs' affinities, and fixup_irqs() isn't relevant here. (If so, this likely would want to be a separate patch, though.) The hpet_enable_channel() call could in principle be made (effectively) conditional, at the price of introducing a check in there. However, as much as eliminating the masking didn't help with the many excess (early) IRQs I'm observing on Intel hardware, doing so doesn't help either. The Fixes: tag indicates where the problem got signficantly worse; in principle it was there already before (crashing at perhaps 6 or 7 levels of nested IRQs). --- v3: Switch to using vector 0x30, to unbreak AMD, including an adjustment to AMD IOMMU intremap logic. Adjust condition around assertions in set_channel_irq_affinity(). v2: Re-work set_channel_irq_affinity() intensively. Re-base over the dropping of another patch. Drop setup_vector_irq() change. --- a/xen/arch/x86/hpet.c +++ b/xen/arch/x86/hpet.c @@ -9,17 +9,19 @@ #include #include #include +#include #include #include #include #include =20 #include -#include #include +#include +#include #include +#include #include -#include =20 #define MAX_DELTA_NS MILLISECS(10*1000) #define MIN_DELTA_NS MICROSECS(20) @@ -251,10 +253,9 @@ static void cf_check hpet_interrupt_hand ch->event_handler(ch); } =20 -static void cf_check hpet_msi_unmask(struct irq_desc *desc) +static void hpet_enable_channel(struct hpet_event_channel *ch) { u32 cfg; - struct hpet_event_channel *ch =3D desc->action->dev_id; =20 cfg =3D hpet_read32(HPET_Tn_CFG(ch->idx)); cfg |=3D HPET_TN_ENABLE; @@ -262,6 +263,11 @@ static void cf_check hpet_msi_unmask(str ch->msi.msi_attrib.host_masked =3D 0; } =20 +static void cf_check hpet_msi_unmask(struct irq_desc *desc) +{ + hpet_enable_channel(desc->action->dev_id); +} + static void cf_check hpet_msi_mask(struct irq_desc *desc) { u32 cfg; @@ -303,15 +309,13 @@ static void cf_check hpet_msi_set_affini struct hpet_event_channel *ch =3D desc->action->dev_id; struct msi_msg msg =3D ch->msi.msg; =20 - msg.dest32 =3D set_desc_affinity(desc, mask); - if ( msg.dest32 =3D=3D BAD_APICID ) - return; + /* This really is only for dump_irqs(). */ + cpumask_copy(desc->arch.cpu_mask, mask); =20 - msg.data &=3D ~MSI_DATA_VECTOR_MASK; - msg.data |=3D MSI_DATA_VECTOR(desc->arch.vector); + msg.dest32 =3D cpu_mask_to_apicid(mask); msg.address_lo &=3D ~MSI_ADDR_DEST_ID_MASK; msg.address_lo |=3D MSI_ADDR_DEST_ID(msg.dest32); - if ( msg.data !=3D ch->msi.msg.data || msg.dest32 !=3D ch->msi.msg.des= t32 ) + if ( msg.dest32 !=3D ch->msi.msg.dest32 ) hpet_msi_write(ch, &msg); } =20 @@ -324,7 +328,7 @@ static hw_irq_controller hpet_msi_type =3D .shutdown =3D hpet_msi_shutdown, .enable =3D hpet_msi_unmask, .disable =3D hpet_msi_mask, - .ack =3D ack_nonmaskable_msi_irq, + .ack =3D irq_actor_none, .end =3D end_nonmaskable_irq, .set_affinity =3D hpet_msi_set_affinity, }; @@ -343,6 +347,12 @@ static int __init hpet_setup_msi_irq(str u32 cfg =3D hpet_read32(HPET_Tn_CFG(ch->idx)); irq_desc_t *desc =3D irq_to_desc(ch->msi.irq); =20 + clear_irq_vector(ch->msi.irq); + ret =3D bind_irq_vector(ch->msi.irq, HPET_BROADCAST_VECTOR, &cpu_onlin= e_map); + if ( ret ) + return ret; + cpumask_setall(desc->affinity); + if ( iommu_intremap !=3D iommu_intremap_off ) { ch->msi.hpet_id =3D hpet_blockid; @@ -472,19 +482,50 @@ static struct hpet_event_channel *hpet_g static void set_channel_irq_affinity(struct hpet_event_channel *ch) { struct irq_desc *desc =3D irq_to_desc(ch->msi.irq); + struct msi_msg msg =3D ch->msi.msg; =20 ASSERT(!local_irq_is_enabled()); spin_lock(&desc->lock); - hpet_msi_mask(desc); - hpet_msi_set_affinity(desc, cpumask_of(ch->cpu)); - hpet_msi_unmask(desc); + + per_cpu(vector_irq, ch->cpu)[HPET_BROADCAST_VECTOR] =3D ch->msi.irq; + + /* + * Open-coding a reduced form of hpet_msi_set_affinity() here. With t= he + * actual update below (either of the IRTE or of [just] message addres= s; + * with interrupt remapping message address/data don't change) now bei= ng + * atomic, we can avoid masking the IRQ around the update. As a result + * we're no longer at risk of missing IRQs (provided hpet_broadcast_en= ter() + * keeps setting the new deadline only afterwards). + */ + cpumask_copy(desc->arch.cpu_mask, cpumask_of(ch->cpu)); + spin_unlock(&desc->lock); =20 - spin_unlock(&ch->lock); + msg.dest32 =3D cpu_physical_id(ch->cpu); + msg.address_lo &=3D ~MSI_ADDR_DEST_ID_MASK; + msg.address_lo |=3D MSI_ADDR_DEST_ID(msg.dest32); + if ( msg.dest32 !=3D ch->msi.msg.dest32 ) + { + ch->msi.msg =3D msg; =20 - /* We may have missed an interrupt due to the temporary masking. */ - if ( ch->event_handler && ch->next_event < NOW() ) - ch->event_handler(ch); + if ( iommu_intremap !=3D iommu_intremap_off ) + { + int rc =3D iommu_update_ire_from_msi(&ch->msi, &msg); + + ASSERT(rc <=3D 0); + if ( rc >=3D 0 ) + { + ASSERT(msg.data =3D=3D hpet_read32(HPET_Tn_ROUTE(ch->idx))= ); + ASSERT(msg.address_lo =3D=3D + hpet_read32(HPET_Tn_ROUTE(ch->idx) + 4)); + } + } + else + hpet_write32(msg.address_lo, HPET_Tn_ROUTE(ch->idx) + 4); + } + + hpet_enable_channel(ch); + spin_unlock(&ch->lock); } =20 static void hpet_attach_channel(unsigned int cpu, @@ -622,6 +663,12 @@ void __init hpet_broadcast_init(void) hpet_events->flags =3D HPET_EVT_LEGACY; } =20 +void __init hpet_broadcast_late_init(void) +{ + if ( !num_hpets_used ) + free_lopriority_vector(HPET_BROADCAST_VECTOR); +} + void hpet_broadcast_resume(void) { u32 cfg; --- a/xen/arch/x86/include/asm/hpet.h +++ b/xen/arch/x86/include/asm/hpet.h @@ -90,6 +90,7 @@ void hpet_disable_legacy_replacement_mod * rather than using the LAPIC timer. Used for Cx state entry. */ void hpet_broadcast_init(void); +void hpet_broadcast_late_init(void); void hpet_broadcast_resume(void); void cf_check hpet_broadcast_enter(void); void cf_check hpet_broadcast_exit(void); --- a/xen/arch/x86/include/asm/irq.h +++ b/xen/arch/x86/include/asm/irq.h @@ -116,6 +116,7 @@ void cf_check call_function_interrupt(vo void cf_check irq_move_cleanup_interrupt(void); =20 uint8_t alloc_hipriority_vector(void); +void free_lopriority_vector(uint8_t vector); =20 void set_direct_apic_vector(uint8_t vector, void (*handler)(void)); void alloc_direct_apic_vector(uint8_t *vector, void (*handler)(void)); --- a/xen/arch/x86/include/asm/irq-vectors.h +++ b/xen/arch/x86/include/asm/irq-vectors.h @@ -22,6 +22,9 @@ #define FIRST_LEGACY_VECTOR FIRST_DYNAMIC_VECTOR #define LAST_LEGACY_VECTOR (FIRST_LEGACY_VECTOR + 0xf) =20 +/* HPET broadcast is statically allocated and wants to be low priority. */ +#define HPET_BROADCAST_VECTOR (LAST_LEGACY_VECTOR + 1) + #ifdef CONFIG_PV32 #define HYPERCALL_VECTOR 0x82 #endif --- a/xen/arch/x86/irq.c +++ b/xen/arch/x86/irq.c @@ -468,6 +468,12 @@ int __init init_irq_data(void) vector++ ) __set_bit(vector, used_vectors); =20 + /* + * Prevent the HPET broadcast vector from being used, until it is known + * whether it's actually needed. + */ + __set_bit(HPET_BROADCAST_VECTOR, used_vectors); + return 0; } =20 @@ -991,6 +997,13 @@ void alloc_direct_apic_vector(uint8_t *v spin_unlock(&lock); } =20 +/* This could free any vectors, but is needed only for low-prio ones. */ +void __init free_lopriority_vector(uint8_t vector) +{ + ASSERT(vector < FIRST_HIPRIORITY_VECTOR); + clear_bit(vector, used_vectors); +} + static void cf_check irq_ratelimit_timer_fn(void *data) { struct irq_desc *desc, *tmp; --- a/xen/arch/x86/time.c +++ b/xen/arch/x86/time.c @@ -2675,6 +2675,8 @@ static int __init cf_check disable_pit_i "Force enable with 'cpuidle'.\n"); } =20 + hpet_broadcast_late_init(); + return 0; } __initcall(disable_pit_irq); --- a/xen/drivers/passthrough/amd/iommu_intr.c +++ b/xen/drivers/passthrough/amd/iommu_intr.c @@ -551,6 +551,13 @@ int cf_check amd_iommu_msi_msg_update_ir for ( i =3D 1; i < nr; ++i ) msi_desc[i].remap_index =3D msi_desc->remap_index + i; msg->data =3D data; + /* + * While the low address bits don't matter, "canonicalize" the add= ress + * by zapping the bits that were transferred to the IRTE. This way + * callers can check for there actually needing to be an update to + * wherever the address is put. + */ + msg->address_lo &=3D ~(MSI_ADDR_DESTMODE_MASK | MSI_ADDR_DEST_ID_M= ASK); } =20 return rc; From nobody Thu Oct 30 15:35:56 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1761234684; cv=none; d=zohomail.com; s=zohoarc; b=iNQUrTriLt59IsCqUw3EUmh6M+2wq6Pa2FuUoNOxLFXEY+c5nZV07VMpDbUh7NOfq2qo7xV62MUwtsEY9Fyyy/SpqUkdR5hdEtvHUpextnfx7wPDytDMS35qQqYgiL47EIEYOsXrDumyz37X3ba2tfLMnJP7DFvFJOsa6TcFwC0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1761234684; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=9TMhIC/Uy9aMDm9ORaG98m2uAOJkSyvYUFdpB79e4bk=; b=VQD+w2U8vCf9tYiIKmdkKX0ODMRuDfpM5ZDa1G2IC/efcLeP/LKhi9wC7Z4NdR8ZzaVp7Vt3X3dK5JQGlFTvLOCca2a1q/Q9IfGd3zmChs9+Xz/xZQmQkUln38UONsxm2X3KifOI1/c0Tjo2rN97zTooOnc9oPY+x77xxPshZHQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1761234684598523.9136953791747; Thu, 23 Oct 2025 08:51:24 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1149398.1481056 (Exim 4.92) (envelope-from ) id 1vBxap-0005Z7-NB; Thu, 23 Oct 2025 15:51:11 +0000 Received: by outflank-mailman (output) from mailman id 1149398.1481056; Thu, 23 Oct 2025 15:51:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vBxap-0005Yy-Js; Thu, 23 Oct 2025 15:51:11 +0000 Received: by outflank-mailman (input) for mailman id 1149398; Thu, 23 Oct 2025 15:51:10 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vBxao-0003ZG-7e for xen-devel@lists.xenproject.org; Thu, 23 Oct 2025 15:51:10 +0000 Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [2a00:1450:4864:20::334]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 172fb32a-b028-11f0-980a-7dc792cee155; Thu, 23 Oct 2025 17:51:08 +0200 (CEST) Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-47100eae3e5so9893755e9.1 for ; Thu, 23 Oct 2025 08:51:08 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-475caf2eb9csm43491125e9.14.2025.10.23.08.51.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Oct 2025 08:51:07 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 172fb32a-b028-11f0-980a-7dc792cee155 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1761234668; x=1761839468; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=9TMhIC/Uy9aMDm9ORaG98m2uAOJkSyvYUFdpB79e4bk=; b=AIE/uE9fCfg2VPocl9Kpgm7YtQt+UB2V+mlfladaF2AuzRFVlRUH6uq6AlLfM1F59q XbL4r9rRsB0ELrBohL6LlgZPuDmcQ6jjz4KIF/jAjcemG6rbU8EnAw/U51J/L3cOqBZI 3bqWISgirE0UOZunGqxHqNvC8CTsPM0I3KiVP6DmWMZ06EJNrgV/05RPBdhm/ul1eKhP qQKXbfaqpTkEqAr/ziuk1ERMy2jQ+WfGGKqhMJhHOxGG5YKM55kNnSsTAm9WfGR0sUS7 5q1DIcDuxx65zLd6I+zS5KXS37k82t3T3fotYbaECOQuG/FcwlpxTMCdOTn7Ijjits3j /KGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761234668; x=1761839468; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=9TMhIC/Uy9aMDm9ORaG98m2uAOJkSyvYUFdpB79e4bk=; b=SuMSAA+v43b9c1eiT+xv2UqOMSEAVdW1SROgk0iEx6034hc9lm9D6xwdgDNeED+4L6 AcA2MQtJunPpjvL5E5gkQeLckBUD7Moh5S4xGZzckxkuTZD6+vg7B3APqy0PfZ3CTiMr WD3sA/2ztpQIJWRuAiTfsQVe9XPN4ptv+GginyVrFBq5iFBTfjgGpZFZJ8/KNqsPv27e tpr/lko9/Lt1ORrANR1LSg72apxpLbdIuhVrkI1fDqPNPubfOqwC0oHS8xRu9bv6LYQ9 lPAaG27yPfS73x3fBiR/+ZP/n0CymeWZL3MEfVRnY08CfMG8UPJiW2lrQFbiU16M6vs1 +U3w== X-Gm-Message-State: AOJu0YwQSBU0YCfnjdNTcPc81ag2PfRniZ+Yz7lFmefNeY/i5U/4U9ET ELslbIkD8XgZeo9bGn3++BAgiFz6QvQYfMoC7OR6aCprQsMKKS5gkUEC1R/Rc85mfCRU9LaNJCV W4U4= X-Gm-Gg: ASbGncvv+/BqJrkSadwgJAaE7Y7wIPlkT+vGogSyuAqE9z18rD7T4yA2kqLU/YzGMd7 mdk7ujRMv/C+xIbnVeU1Uo/rjeIuQZi2TfKEq7v45k0Hp/7S9PqAmbwYG3osOo6xHZFC4VBtTDF a9pkSDOnq0s5FtDnUZtvu9mkN1SU4W2pOPpvrkB6bTHVM39X3bPa1STxwK29IZx962nL5cgwhsZ u7MH+f7oL6QrQfvFFlrGRgrO3vGD+1gt5PwFUKdQdNsqwZ055Hs4/+6/+QF7qAMkRnIuasmSdpm VE0UPUheqIJusYWfGXvgDqT4+RjsnVeIeO/0dFG0xzU+3ZjJYHSCTms9iu5k9tC7RcpRZIGrgJn hkhIE4WRLhE4whMuxI1kvkKW2IyKnh0r5Wz5jyWmd4JrmsoT6SlPNP9fzbF3Y3M5xp0XmWrjZ6w qmdOeR2hyaR1PRZbPLIlt4D8o3Hya0JIWjM0c/Lqc3MBvmdPF0xsVJsHhs5CQvdlsTdNc++iiLQ qb90mr3OA== X-Google-Smtp-Source: AGHT+IGyXxh3f8geRhvyG8xnAOPitOOxj1G0PMMfhzwHd81bO351pZ/QkUzH9EzUUi5m7cTKG+k7CQ== X-Received: by 2002:a05:600c:34d5:b0:46f:b42e:e39e with SMTP id 5b1f17b1804b1-4711791da0amr191684615e9.39.1761234667806; Thu, 23 Oct 2025 08:51:07 -0700 (PDT) Message-ID: Date: Thu, 23 Oct 2025 17:51:06 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH v3 for-4.21 3/9] x86/HPET: replace handle_hpet_broadcast()'s on-stack cpumask_t From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Oleksii Kurochko References: <6a8a912c-7276-42bd-af2b-b94fc6ce4291@suse.com> Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <6a8a912c-7276-42bd-af2b-b94fc6ce4291@suse.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1761234685855154100 With large NR_CPUS on-stack cpumask_t variables are problematic. Now that the IRQ handler can't be invoked in a nested manner anymore, we can instead use a per-CPU variable. While we can't use scratch_cpumask in code invoked from IRQ handlers, simply amend that one with a HPET-special form. (Note that only one of the two IRQ handling functions can come into play at any one time.) Fixes: 996576b965cc ("xen: allow up to 16383 cpus") Signed-off-by: Jan Beulich Reviewed-by: Roger Pau Monn=C3=A9 --- While doing this I noticed that this and all pre-existing uses of DEFINE_PER_CPU_READ_MOSTLY() aren't quite right: When the type is cpumask_var_t, the variable is read-mostly only when NR_CPUS <=3D 2 * BITS_PER_LONG. That'll want sorting separately, though. It is important for this to not be moved ahead of "x86/HPET: use single, global, low-priority vector for broadcast IRQ", as the original call here from set_channel_irq_affinity() may not use the new variable (it would need to use scratch_cpumask instead). --- v2: New. --- a/xen/arch/x86/hpet.c +++ b/xen/arch/x86/hpet.c @@ -196,7 +196,7 @@ static void evt_do_broadcast(cpumask_t * =20 static void cf_check handle_hpet_broadcast(struct hpet_event_channel *ch) { - cpumask_t mask; + cpumask_t *scratch =3D this_cpu(hpet_scratch_cpumask); s_time_t now, next_event; unsigned int cpu; unsigned long flags; @@ -209,7 +209,7 @@ again: spin_unlock_irqrestore(&ch->lock, flags); =20 next_event =3D STIME_MAX; - cpumask_clear(&mask); + cpumask_clear(scratch); now =3D NOW(); =20 /* find all expired events */ @@ -218,13 +218,13 @@ again: s_time_t deadline =3D ACCESS_ONCE(per_cpu(timer_deadline, cpu)); =20 if ( deadline <=3D now ) - __cpumask_set_cpu(cpu, &mask); + __cpumask_set_cpu(cpu, scratch); else if ( deadline < next_event ) next_event =3D deadline; } =20 /* wakeup the cpus which have an expired event. */ - evt_do_broadcast(&mask); + evt_do_broadcast(scratch); =20 if ( next_event !=3D STIME_MAX ) { --- a/xen/arch/x86/include/asm/smp.h +++ b/xen/arch/x86/include/asm/smp.h @@ -22,6 +22,7 @@ DECLARE_PER_CPU(cpumask_var_t, cpu_sibling_mask); DECLARE_PER_CPU(cpumask_var_t, cpu_core_mask); DECLARE_PER_CPU(cpumask_var_t, scratch_cpumask); +DECLARE_PER_CPU(cpumask_var_t, hpet_scratch_cpumask); DECLARE_PER_CPU(cpumask_var_t, send_ipi_cpumask); =20 /* --- a/xen/arch/x86/smpboot.c +++ b/xen/arch/x86/smpboot.c @@ -55,6 +55,9 @@ DEFINE_PER_CPU_READ_MOSTLY(cpumask_var_t DEFINE_PER_CPU_READ_MOSTLY(cpumask_var_t, scratch_cpumask); static cpumask_t scratch_cpu0mask; =20 +DEFINE_PER_CPU_READ_MOSTLY(cpumask_var_t, hpet_scratch_cpumask); +static cpumask_t hpet_scratch_cpu0mask; + DEFINE_PER_CPU_READ_MOSTLY(cpumask_var_t, send_ipi_cpumask); static cpumask_t send_ipi_cpu0mask; =20 @@ -976,6 +979,8 @@ static void cpu_smpboot_free(unsigned in FREE_CPUMASK_VAR(per_cpu(cpu_core_mask, cpu)); if ( per_cpu(scratch_cpumask, cpu) !=3D &scratch_cpu0mask ) FREE_CPUMASK_VAR(per_cpu(scratch_cpumask, cpu)); + if ( per_cpu(hpet_scratch_cpumask, cpu) !=3D &hpet_scratch_cpu0mas= k ) + FREE_CPUMASK_VAR(per_cpu(hpet_scratch_cpumask, cpu)); if ( per_cpu(send_ipi_cpumask, cpu) !=3D &send_ipi_cpu0mask ) FREE_CPUMASK_VAR(per_cpu(send_ipi_cpumask, cpu)); } @@ -1112,6 +1117,7 @@ static int cpu_smpboot_alloc(unsigned in if ( !(cond_zalloc_cpumask_var(&per_cpu(cpu_sibling_mask, cpu)) && cond_zalloc_cpumask_var(&per_cpu(cpu_core_mask, cpu)) && cond_alloc_cpumask_var(&per_cpu(scratch_cpumask, cpu)) && + cond_alloc_cpumask_var(&per_cpu(hpet_scratch_cpumask, cpu)) && cond_alloc_cpumask_var(&per_cpu(send_ipi_cpumask, cpu))) ) goto out; =20 @@ -1239,6 +1245,7 @@ void __init smp_prepare_boot_cpu(void) cpumask_set_cpu(cpu, &cpu_present_map); #if NR_CPUS > 2 * BITS_PER_LONG per_cpu(scratch_cpumask, cpu) =3D &scratch_cpu0mask; + per_cpu(hpet_scratch_cpumask, cpu) =3D &hpet_scratch_cpu0mask; per_cpu(send_ipi_cpumask, cpu) =3D &send_ipi_cpu0mask; #endif =20 From nobody Thu Oct 30 15:35:56 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1761234709; cv=none; d=zohomail.com; s=zohoarc; b=jAs+JrvTovnom1nKJ+RQSrAaqGryAoDCz+EMVSNr44Qd/uBskT7Ouag7iuuYB71sl5NdcVC1PJC6KIWZaCjH9+krSVrnA5ruMcex8QTwY99mN1iyDOOz5UjwQzdvYWFXBRKxJz8FKCXjlxUu2Vu2W0w2XNU22y8tHmgpaskTLhY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1761234709; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=4Cp/OnTGttesfQdpppyi71qgWTMBvTIXz79fP5OO8Os=; b=d0nJLxlt51/fjIsUD0LMACzTwr24DsK2oiBlFbE0k/YnMYK5W0CNfe8gn2tfM1DaD81+h9H4b93CAd2bvGVaC3aHr1IIjdu4k+2O4guDTS2+54Ot4CyqnRqaFVf5+2txADMeP8dEQufNF2a2OPx9ACABHbAWZnY0hSYA2GUP6u4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1761234709876351.92964324431296; Thu, 23 Oct 2025 08:51:49 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1149403.1481066 (Exim 4.92) (envelope-from ) id 1vBxbC-000633-UB; Thu, 23 Oct 2025 15:51:34 +0000 Received: by outflank-mailman (output) from mailman id 1149403.1481066; Thu, 23 Oct 2025 15:51:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vBxbC-00062w-RJ; Thu, 23 Oct 2025 15:51:34 +0000 Received: by outflank-mailman (input) for mailman id 1149403; Thu, 23 Oct 2025 15:51:33 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vBxbB-0005s8-L0 for xen-devel@lists.xenproject.org; Thu, 23 Oct 2025 15:51:33 +0000 Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [2a00:1450:4864:20::431]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 25ff1f71-b028-11f0-9d15-b5c5bf9af7f9; Thu, 23 Oct 2025 17:51:33 +0200 (CEST) Received: by mail-wr1-x431.google.com with SMTP id ffacd0b85a97d-42966ce6dbdso683658f8f.0 for ; Thu, 23 Oct 2025 08:51:33 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-429897f57cesm4840745f8f.17.2025.10.23.08.51.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Oct 2025 08:51:32 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 25ff1f71-b028-11f0-9d15-b5c5bf9af7f9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1761234693; x=1761839493; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=4Cp/OnTGttesfQdpppyi71qgWTMBvTIXz79fP5OO8Os=; b=UplUv+CdUACd7PJm13hLdEqQZXGjjkVe+ITIw4W1VAOsdwWOZFIR4dbXzAkmcRQy91 Wiw6UJGffJWO5yjrNTWUumRTGNbvma5kYQmZk9zAIA62Y6MQWaJhvV5CTMfn4eQTZYKU W6j++PUN/2ohplkU+YhEQyKZMFJRfmaq4Wx8coFz3kjk+ugY4yZf5LxtZtP2n5VqbFsv AVnSlayXHWEuEDjA/93kcecT21MfnmeX28KnFJCyCP0rcM2x7ZHRAzfqUie5AoZvZoAA hc6R2vobhtB3zLZcIvt/RbPVMH2LaTDuUp513C9iF4qt7Dgve7ELj3HQMKCPWuyPefSW 6M8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761234693; x=1761839493; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=4Cp/OnTGttesfQdpppyi71qgWTMBvTIXz79fP5OO8Os=; b=O5evsT/v2Vh5T9OC2auNbr62UkEK7E1Rw319CruShkcRfD5EXZau37bjIJmt3xQPHq lgSszdsN+qKWjvUiJyz0MEJdsJRvqLxmT0qBkep2RaPHE7Cp1aLfkY619TSnT1rIuw55 sCyr/sPBRuQBzQXA8pEPNLDOtmHjDoKcLRT7cELdnCx51GNYKRTTkeVgKjcpXwSJv7XY xZfikp/FfaSSM72Xj60iYlP2hKIkQ/GLBjhNh+zGWGJhcmIRfvSY/BPD5EahSYgqDvW+ m4ND7bRQ4Kz0y12vm4nXb+1cf5Xs063UGIQWWiWaOX0WTNNLlaOzRVEwtdjVfKip1wlr A+gQ== X-Gm-Message-State: AOJu0YyeY+r7CwcaJBIs7Eayhp7Yr+IJUdjWQHz8L4bAyR+q+iYxhu8u EWaJXdlTkk09/z3glo2IO/YQqldN9zdSU70rS/RqtBpvOhX0ClCy8xjeEToPKRRMHT23GUn9KqY 6pAY= X-Gm-Gg: ASbGncvJhi4xYLN/zp9fKZpKq0xVmsIWtu97P5EguBcTjSOTurGOmlwBIE4/2dZQRM9 QBOPFvcdnvdGXK7U2NlDcmFO2/JcDqDzd3ezT2zD4ZdEpcYrIcw4zdFD657qhGeTwTJsQG2oL+I gC7wyOWPgb2/g9HeDIdFYdOKNGo3cQGOlDEbwtJA2jEWbpIy4Me4ovm0kE7riVYoDSq6tyyP8iZ zt446+66rCc+cR29R9+bfvSgnKbvWVkYIvlBbXhdrD9OTMKBO/t5YeO0jzAvpf2lrOmg8asot6Y sq7RlWuTyOd+pZ5GMphvqopuYIP42daMDeZYBLXoq+cNoJdarIZpYOyvwFqvhzW/dlW+HJV+Dhy NDAYYMKI8z3GsdX9yBqLG2kACf53uTpMFNhrhGWrCNZGf2ZEH2aK9olR2iLkedYxI2EYfS/IIaP 2EidCEBp76R38Rz0F+LeQTbC+N/t5EFy5e1Q4GZg9Wukgb6zlL4E5g/pFMmUgU X-Google-Smtp-Source: AGHT+IGLFPt8XWzNziO8+TFnxf6btUr/x7MpRprI+egs57Qzic0bKY+EnzRQm2pRkFNcZvzYpSuh3g== X-Received: by 2002:a05:6000:200f:b0:428:3e7f:88c3 with SMTP id ffacd0b85a97d-4283e7f8a82mr12867040f8f.50.1761234692571; Thu, 23 Oct 2025 08:51:32 -0700 (PDT) Message-ID: <1a79b0dc-56ee-4dd2-905e-bf989e6a6aed@suse.com> Date: Thu, 23 Oct 2025 17:51:30 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH v3 4/9] x86/HPET: avoid indirect call to event handler From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Oleksii Kurochko References: <6a8a912c-7276-42bd-af2b-b94fc6ce4291@suse.com> Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <6a8a912c-7276-42bd-af2b-b94fc6ce4291@suse.com> Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1761234712078154100 Content-Type: text/plain; charset="utf-8" It's only ever handle_hpet_broadcast() that's used. While we now don't enable IRQs right away, still play safe and convert the function pointer to a boolean, to make sure no calls occur too early. Signed-off-by: Jan Beulich --- v2: Re-base over changes earlier in the series. --- a/xen/arch/x86/hpet.c +++ b/xen/arch/x86/hpet.c @@ -40,7 +40,7 @@ struct hpet_event_channel s_time_t next_event; cpumask_var_t cpumask; spinlock_t lock; - void (*event_handler)(struct hpet_event_channel *ch); + bool event_handler; =20 unsigned int idx; /* physical channel idx */ unsigned int cpu; /* msi target */ @@ -194,7 +194,7 @@ static void evt_do_broadcast(cpumask_t * cpumask_raise_softirq(mask, TIMER_SOFTIRQ); } =20 -static void cf_check handle_hpet_broadcast(struct hpet_event_channel *ch) +static void handle_hpet_broadcast(struct hpet_event_channel *ch) { cpumask_t *scratch =3D this_cpu(hpet_scratch_cpumask); s_time_t now, next_event; @@ -250,7 +250,7 @@ static void cf_check hpet_interrupt_hand return; } =20 - ch->event_handler(ch); + handle_hpet_broadcast(ch); } =20 static void hpet_enable_channel(struct hpet_event_channel *ch) @@ -653,7 +653,7 @@ void __init hpet_broadcast_init(void) hpet_events[i].next_event =3D STIME_MAX; spin_lock_init(&hpet_events[i].lock); smp_wmb(); - hpet_events[i].event_handler =3D handle_hpet_broadcast; + hpet_events[i].event_handler =3D true; =20 hpet_events[i].msi.msi_attrib.maskbit =3D 1; hpet_events[i].msi.msi_attrib.pos =3D MSI_TYPE_HPET; @@ -810,7 +810,9 @@ int hpet_legacy_irq_tick(void) (hpet_events->flags & (HPET_EVT_DISABLE|HPET_EVT_LEGACY)) !=3D HPET_EVT_LEGACY ) return 0; - hpet_events->event_handler(hpet_events); + + handle_hpet_broadcast(hpet_events); + return 1; } From nobody Thu Oct 30 15:35:56 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1761234729; cv=none; d=zohomail.com; s=zohoarc; b=Qi38+9QF9QudXD0jci6DB+6fcybCfUZBjmrOBOVneDvrBDVcSMqeckmZ6z1Cm/BX+DVZADfJddWwuCDKKujdJBQWrrUeVi5tSElllAkA/19fAphsjmLxMqlcXoQO4xWn9zuP5aU981Zx9UVfun9aDWyOzYzfEc3zlptkumZASZk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1761234729; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=+mHbAOKYHQAzDXnfae+5y/OBfyT/X7+SHGVm0yj/ZMY=; b=gtjM/6/uWfa5sD/I6icjQiI1ALTIzFK5geIGfoEc7rShnTEYi+GSW8X4p2qS8FFeNFqDxvt5i2tck1ov4zN8O9IQKEOsUse5vCUvQAtWz2dqY7yEmADQPWV2gwJ6lHwBVhqXlsK9+yNyjspnGnE1ziPN7T7ws7nyhWrghFTxeik= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 176123472976669.26850159544358; Thu, 23 Oct 2025 08:52:09 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1149416.1481075 (Exim 4.92) (envelope-from ) id 1vBxba-0006Xp-58; Thu, 23 Oct 2025 15:51:58 +0000 Received: by outflank-mailman (output) from mailman id 1149416.1481075; Thu, 23 Oct 2025 15:51:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vBxba-0006Xi-2G; Thu, 23 Oct 2025 15:51:58 +0000 Received: by outflank-mailman (input) for mailman id 1149416; Thu, 23 Oct 2025 15:51:57 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vBxbZ-0003ZG-Nc for xen-devel@lists.xenproject.org; Thu, 23 Oct 2025 15:51:57 +0000 Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [2a00:1450:4864:20::329]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 336534cc-b028-11f0-980a-7dc792cee155; Thu, 23 Oct 2025 17:51:55 +0200 (CEST) Received: by mail-wm1-x329.google.com with SMTP id 5b1f17b1804b1-46fcf9f63b6so5940215e9.2 for ; Thu, 23 Oct 2025 08:51:55 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-474949dd479sm67938045e9.0.2025.10.23.08.51.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Oct 2025 08:51:54 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 336534cc-b028-11f0-980a-7dc792cee155 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1761234715; x=1761839515; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=+mHbAOKYHQAzDXnfae+5y/OBfyT/X7+SHGVm0yj/ZMY=; b=C5ML9nQ1XjcoZQ0ofrSnVDoYqzHb7TSd6mF1LLpNXfJqT8VpjoQsv39xNa4FOu0jFG WvLVMzPhKU+3zTLbtd11GRqyG9BVYdQuDv6vvi5SiXiyLMjYQDDRHerw3loSZpGPpMsJ FJp3ol8coinYfmAw+YcN8/YELJEs5atbg5C/vuQiVZjyyKDC9h0jzA+oGDqnGlHbJh0x bg29899PgSoRVfRgFYx+JWZWMrxOXaevhFZYFTxPS2jU0906Y5HiqOU8vG9pTUkEZW+F 3QVF+r1OyHrHTadu+2dV2ZfKDs2A6g66ej2pw38EOwXJUQnr/0y6O+Z0xkiPgd3PngMJ MSFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761234715; x=1761839515; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+mHbAOKYHQAzDXnfae+5y/OBfyT/X7+SHGVm0yj/ZMY=; b=WrNlX9Oonw7J+5FlffNYC/QTOzlinDG5ZPRUheIZcA7GUlwA2QkV27soGjt+/S7luA g5zEa3JPfisVLaMS/D3p3YtSfdxI7JVhX2ssqMqvYtD4jITzE2xJGyc1ZOk1YKnhsRnZ G9B0ZITwnGV3nru66kasPsp7z2OQQLgtqZi7h9BgB4jBFMMvzZVVSg6WZHS3bhr5GcgQ DsN4MYGSNCcKbprKNfDlX2O7U599/QFTS5newkjnff/8ZLfg/hotCY52yik8fHBUFBWo zkor/KItOB5EKTsNkZQOb+XdTWOhhvLfkLfrmeJSwPmS3xYuUGq5YTuQVGhzwotHUlnT iWZQ== X-Gm-Message-State: AOJu0Yw/VqXeAuT2vuxBJZJa4iirMalMhI28Gg3dI4b7Uij1IZOBabdi qvmCQ58sMF2+y/FEuSJUke+reKs8rY91ulblOpyIKFvc88Lni1LpxX5dK4sJS9Zs7dhqP3XgEwE 3034= X-Gm-Gg: ASbGncu/E7dJR5LBQlK/Txb2nkFT1xAOLbrZMn2Bj+ZVoDnCNh9GDHpJtnsZLwiZrfU 70H8HLbDSyWukF2D3OK45ySuoYC6S5k2t6q1/tT4eL1KcvFX/NQvHHmaC3g6A3iXqnXI+cwPc6r TSxEKv12cg72WAG4PTuEqaQMwDwVpmGHPbqSJ0jlHBm1ha/H6e9RBy6lBEuU4rXsgJuScr4nIjX 2fzmc05XlXdKa87La31JSJCgZih6QS7uf0XhkAJsJWC4ujbKgqLchzjMitawhV8YayE9lDQfHqZ D+XFW2+t1mh0FJTxEIknO9e4iQSWgrTmq1a9AwMNpjul1++cfXRQbL8FBVzkO4g1FKyn1/2stOm 0vHTrYa7X6a3VuagXylNDHhgLlPngUvK69mnXkhaNuJAM0HNeX+2f2hIVDTUwqDoinV2X1zvvLO bh4Mm/+pWYJKXS/OZkgFdo/N5Qi0M4AycHOFN6PeA4Srls7AAk3kUvR73qUIs5+oo23T2iP/o= X-Google-Smtp-Source: AGHT+IH25LbB6uYFvxruMTxCvVvSzakrZAUjmNAH48P1fuANhCw+Tv86aJwHv4rh3i481lwkSEmfew== X-Received: by 2002:a05:600c:820f:b0:46f:b42e:e365 with SMTP id 5b1f17b1804b1-4711791dce8mr186824585e9.39.1761234715199; Thu, 23 Oct 2025 08:51:55 -0700 (PDT) Message-ID: Date: Thu, 23 Oct 2025 17:51:53 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH v3 5/9] x86/HPET: make another channel flags update atomic From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= References: <6a8a912c-7276-42bd-af2b-b94fc6ce4291@suse.com> Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <6a8a912c-7276-42bd-af2b-b94fc6ce4291@suse.com> Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1761234730717158500 Content-Type: text/plain; charset="utf-8" Unlike the setting of HPET_EVT_LEGACY in hpet_broadcast_init(), the setting of HPET_EVT_DISABLE in hpet_disable_legacy_broadcast() isn't init- only and hence can race other flag manipulation (not all of which occur while holding the channel's lock). While possibly any such updates would only ever occur when HPET_EVT_LEGACY isn't set in the first place, this doesn't look straightforward to prove, so better be on the safe side. Fixes: d09486dba36a ("cpuidle: Enable hpet broadcast by default") Signed-off-by: Jan Beulich --- a/xen/arch/x86/hpet.c +++ b/xen/arch/x86/hpet.c @@ -725,7 +725,7 @@ void hpet_disable_legacy_broadcast(void) =20 spin_lock_irqsave(&hpet_events->lock, flags); =20 - hpet_events->flags |=3D HPET_EVT_DISABLE; + set_bit(HPET_EVT_DISABLE_BIT, &hpet_events->flags); =20 /* disable HPET T0 */ cfg =3D hpet_read32(HPET_Tn_CFG(0)); From nobody Thu Oct 30 15:35:56 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1761234756; cv=none; d=zohomail.com; s=zohoarc; b=TpxIjy7gXwgWb178Lps1ijVJ4YDX/K9SXQUfYeaPRuQpt+kxw5b2zKp1KfHvojEhFAvzIRzHITbUENGhp8bkkE0nwXw/duNVjQ0dlZqQZCCk8C1PUc1zWBsHGqRadM7/18tQ9juzXDOKYYa8T9FeNhJWhozrDOQ4BEqvBtzfBh0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1761234756; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Edc9JejnVOurqFLHJl7vyGwNsXxDwYwpev1b5zjSyqQ=; b=E+heWVeAVre6xW8vUZL31oLLkjMzxiKpufPbfuxSc54pnA5XIc90BqqJDhtyfhfYyk/12zK8KsPJVMwX3HMfssrtpmfgxknMf+l7DGczI1dUdOc4po6YBB0M7i3S5HZFN/9AKwxlrb2f3n3ohxcggrQP/keNS7Fskll5sq2+QJ8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 176123475666687.79510368526428; Thu, 23 Oct 2025 08:52:36 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1149423.1481086 (Exim 4.92) (envelope-from ) id 1vBxbu-00071a-Cc; Thu, 23 Oct 2025 15:52:18 +0000 Received: by outflank-mailman (output) from mailman id 1149423.1481086; Thu, 23 Oct 2025 15:52:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vBxbu-00071T-9U; Thu, 23 Oct 2025 15:52:18 +0000 Received: by outflank-mailman (input) for mailman id 1149423; Thu, 23 Oct 2025 15:52:17 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vBxbt-0003ZG-Of for xen-devel@lists.xenproject.org; Thu, 23 Oct 2025 15:52:17 +0000 Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [2a00:1450:4864:20::330]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3f83bd5e-b028-11f0-980a-7dc792cee155; Thu, 23 Oct 2025 17:52:16 +0200 (CEST) Received: by mail-wm1-x330.google.com with SMTP id 5b1f17b1804b1-47103b6058fso7644415e9.1 for ; Thu, 23 Oct 2025 08:52:16 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-475c428f709sm104727735e9.8.2025.10.23.08.52.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Oct 2025 08:52:15 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3f83bd5e-b028-11f0-980a-7dc792cee155 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1761234735; x=1761839535; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=Edc9JejnVOurqFLHJl7vyGwNsXxDwYwpev1b5zjSyqQ=; b=UgS0dPClJt7nMmT3hN4h+Y5IfJ9VZT2jN79tC16hPGvZaDBXsfgLbHi3Z+nEg3iN2U WwN8s3weT7wnq2Yxb6XHiFyQMmfjF6KDH07B1a9gvHFQDKZh3KjCrZGq6CC2uVeKcgX+ qKJhIaxpM9DKqsVHtZZbo2wdszKMdPZrlcg4zA/n/RdhfF87igqUq547SEkeE/XYFfyi DUTLjWkus38EtreTG4kKVeCFayq6axK9QHXMPSku3fLZm45Zjvib9y3yq9zhFH7ctbuX XECRp+LjtpH8+nMNjiGWkDQ69Ewo2dI5LxWbZFqEXYbIcjQ149bCV1uYc+pvYFlf0s3C BoVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761234735; x=1761839535; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Edc9JejnVOurqFLHJl7vyGwNsXxDwYwpev1b5zjSyqQ=; b=rmcVxVtjNx+uX/QB7TzjObtgVaLQjMWHupLvtaaCzEEh6yOHYdZzHlxzc6850H9p6t Eftje5NQZ54zwN2AKSYlcua9MuFYnt/IwNtFbv0CmMJe4oBYqGmzQVY57lx0QJNSlDGO MyCitwwHM/QzaaQ3yWnZ7yuAdMCyleHWGTbW0LEjFUgSiD9cLqx3qMFLsSG6DiPhzqDN bbyr89gsRXGSm/1xV5KGqduf1rMlqtVb6Vbc/TRnADUc8TVJQZ0k6JQdmCYBZzJYdIJo ONPd/y7xHncFtN9Zhz74ACBBq+zw1aXfiFoim+b/Ob1X2B5AWyicVaFcd5nuESSCf1mX e+Yw== X-Gm-Message-State: AOJu0YzWpxWhnLIshxpmv+bvaBp4VdBVhxd5QwOXu5YnyD80SuTY1Coj I2wYY+gkI1CQmCs9FO2yR5UuUCZba7unXE3kn74dIwwEyoxmaIIDN90FpACXsE6A6Tr9B6eqKU1 dzjI= X-Gm-Gg: ASbGncsBoUNMRkNOmIs6kHbyT2btMymg3kSHkNEII9o5Aqz5guWGJ6YHB0V+THQP/1Q vgpSKAOAIYMiTdI781yJ+M3v18AmbLF1OoH7fK81VE7KKSepx0psPKsM6Wg0nJBjvGb7Y1bRDVO gteVwc3vxZ5q9DjIAHusBYCTeO241Q+JFeIDDogNJ5zvgq2GqT08WELfGuTyd/sW5W38TacbhNW 1Pj1yGD7ZOG25ZRO6cy/ENnf7qIT51T3zFEY7YnNVHZZBZ8ax3Yofm9IdrJDGRLwRkl5yAV4bGo Cw2UOv6G8htfISA3K2+j+lHYcbMHlpDfw6SLIPM+PnnMHT82vs6r9yeW9pm+J2PsPjHN/32L8ee AVtaWOVobWT57/uqmbY8n6isoHsJADgACwXaTpDZcgM7/rRy+PJvxyLZOGxUOIMhp+zF+ehKJFp 3Ay6GEAD2NPvCoJoQ/dmmD2z70/Dkf7mZPMx7PQgOPCYJooXTr9S9HbYsB/AbHy5U5I02g5l4= X-Google-Smtp-Source: AGHT+IH5gdWl4wMqnzk1J4RYATwheSuNMWvOGJi+6NGUWwBQatZNDjqUztJE5axxCaLk+yZUBVfO6A== X-Received: by 2002:a05:600c:3f10:b0:46e:6339:79c5 with SMTP id 5b1f17b1804b1-475c3fa1f3emr64243325e9.5.1761234735503; Thu, 23 Oct 2025 08:52:15 -0700 (PDT) Message-ID: <18f2e2b9-94f5-43c1-9801-e7ca7d7a74b0@suse.com> Date: Thu, 23 Oct 2025 17:52:13 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH v3 6/9] x86/HPET: move legacy tick IRQ count adjustment From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= References: <6a8a912c-7276-42bd-af2b-b94fc6ce4291@suse.com> Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <6a8a912c-7276-42bd-af2b-b94fc6ce4291@suse.com> Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1761234756980158500 Content-Type: text/plain; charset="utf-8" If already we play with the IRQ count, we should do so only if we actually "consume" the interrupt; normal timer IRQs should not have any adjustment done. Fixes: 353533232730 ("cpuidle: fix the menu governor to enhance IO performa= nce") Signed-off-by: Jan Beulich --- _Why_ we do these adjustments (also elsewhere) I don't reeally know. --- a/xen/arch/x86/hpet.c +++ b/xen/arch/x86/hpet.c @@ -804,13 +804,13 @@ int hpet_broadcast_is_available(void) =20 int hpet_legacy_irq_tick(void) { - this_cpu(irq_count)--; - if ( !hpet_events || (hpet_events->flags & (HPET_EVT_DISABLE|HPET_EVT_LEGACY)) !=3D HPET_EVT_LEGACY ) return 0; =20 + this_cpu(irq_count)--; + handle_hpet_broadcast(hpet_events); =20 return 1; From nobody Thu Oct 30 15:35:56 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1761235129; cv=none; d=zohomail.com; s=zohoarc; b=mLLzfg8CZtBmqsa0rmXitQbuV1Czq0nF6QGZIUr29NyQ4IqK6U2HIKiAA2o5EijBvqDmuE38jNZdM2zpGprHXeZfGWowCGpkEmZ9WUulDr4h1Vt3JGLI7TzGnsmGA7HXYKfVJyT+j8kFWBIx+aMg3DfrL5IIgZ26sIiSmwYcMis= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1761235129; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=rds4jnnN9NVrTZyuc+q65+QBQEjCAV7rC8oJIxMqDF8=; b=b81/+O56by3r1NFQIwx5GxFZWqIjOlwL6t4fKaj+ULuN7oo9ZaSM4/P069R+KM8bf45RqIxT1udbPiQN0ftg4Iq61LVy1LmZVWjaHJGllLdCV+bgF1H3vw7e/2fzFDAIU3+F96zgnxbGDcZFd65v9Z3xvGWwQXSTx06FHTL85Rs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1761235129315534.2871473239173; Thu, 23 Oct 2025 08:58:49 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1149458.1481116 (Exim 4.92) (envelope-from ) id 1vBxhy-0000wN-FL; Thu, 23 Oct 2025 15:58:34 +0000 Received: by outflank-mailman (output) from mailman id 1149458.1481116; Thu, 23 Oct 2025 15:58:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vBxhy-0000wG-Cd; Thu, 23 Oct 2025 15:58:34 +0000 Received: by outflank-mailman (input) for mailman id 1149458; Thu, 23 Oct 2025 15:58:33 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vBxcF-0003ZG-DY for xen-devel@lists.xenproject.org; Thu, 23 Oct 2025 15:52:39 +0000 Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [2a00:1450:4864:20::334]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4c84f619-b028-11f0-980a-7dc792cee155; Thu, 23 Oct 2025 17:52:37 +0200 (CEST) Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-47103b6058fso7646845e9.1 for ; Thu, 23 Oct 2025 08:52:37 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-475cad4c81dsm45156035e9.0.2025.10.23.08.52.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Oct 2025 08:52:37 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4c84f619-b028-11f0-980a-7dc792cee155 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1761234757; x=1761839557; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=rds4jnnN9NVrTZyuc+q65+QBQEjCAV7rC8oJIxMqDF8=; b=U/iVwEQbu9xhnKFHRnu/ngvhY7V+rmU8Uq0rSlbzCuB/TEtd5biqh08dXJ1be7zdB5 etQMRTA3XLaW6NoMGKws66BvVx9269wUgLmMm2GViJLGNBreYAmD8BoVzBhUcFWdMd6o JVcQZq5ziIQa0dcUYHdgY+q/Phfzm4JDIxcVfKim03ivD10TPp3MkLTFyA0ezigquK5i KQ9tYcNzrAxsR1de+P3K+bs7x4OmzELn0Sxuqr77o2O+UQrRmqSDZCxCJ2MkwM9umFYr j7SNU5dZiRQzunc4UGZ865UblV/ZaEjz10Z4fq63FaRaCCFjiTAtZ5HTD/bJ7GwtcezH tl/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761234757; x=1761839557; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=rds4jnnN9NVrTZyuc+q65+QBQEjCAV7rC8oJIxMqDF8=; b=rakPMWRbdyEtCnn5grP8TU7lDDX/iS27hHK3MMy9Gl9r3wiMKYHY8WQ46q7wwurTt9 J7iUgdVHSSOfzRA3IwwXHyI5Mt0pDRISG1QAwuF1H/W45xwd89UHzyRzd9LV6blqxxHD NQxigGBcPuAkHOJcP3TdqOf2wYpLsdFilE04LgSbvDJ4kMIRbjapzqW8ZLYHrLpYos57 qzekR5WXNO4ChDGTksSC+xdP+GYQv9MO2Zx67tqpPINLmjk6fo2rW5P1rpIs/ugUiTry rFGRfrRzVJbu7Glv6GLGGfEBI0+Lh8JYyoGqzj5WZtAUS3Imk2SUQSPYKxXOZm/qOMiv Q1aw== X-Gm-Message-State: AOJu0YxCETzMugc9PlsxTkxx6XqaKg1UdyOj14Xq/nWu14lV5/X5zxm4 zMunrsFfxYGB4ViEFS+GhccyMQcPetQ/hqq47/4U4gKNcB3y/Fxxn67wIv/UMuXbe20KHgZPuuf Zjm8= X-Gm-Gg: ASbGncsUW4X5TlyWwvpe+zh2Yf0iRE8q2uIKAGtHPD5wq5bbnqu1XdkZZwODrdeeGbz MJ53Y0V7qwEs5IPJ0h2Q3E2kN0OLaMlWQfjcuxGKLadQuMRrcWOITTFdB/9Ojz5N04U1oiae1ec S9+BS5YPdBjgvPLy/ZA6NDePGr4rpXoXp/AK8fgy0F+ad4nEfBG5x9j9Fa6hidymNPY6ntliCkv PLQYMIjbjQ/Krm9tiocqdTYvWopUU8N9bWyLCij0B8M5d4NezflX6iTXic7TXFc+pd+sMGcCYdA 6TZv076NxdJ7z59elvWJbe/E/DC+cwWy4fi5C4bCGaCgw6C//c8YAEBAwOlkqKe4tHMivMCMZdl WoA7W5WyUDLOr6Z7+g0rf3Yl8+sdGaPDP60VxOMdLMe6Y8Df8f+hb6YfhgZwv2+pEjiKTWWjCTM XC0/J5fHYpxqEbvK98KejjuCbSSEtJqbYROG/pp3qocVbKFbwYkCYwl2JTaBzcxbYnVNSEokY= X-Google-Smtp-Source: AGHT+IE/BxDx1PZIGOupQL8eMkohjodSLG4a3UQ9TF5ZY/S5BZL6F1gt3BKwI+tTiRTTns/GDCeoKw== X-Received: by 2002:a05:600c:55d6:b0:46f:b42e:e362 with SMTP id 5b1f17b1804b1-475c6f7076cmr35920245e9.19.1761234757309; Thu, 23 Oct 2025 08:52:37 -0700 (PDT) Message-ID: <292960d3-37cd-4c07-b0fb-528b560ee44b@suse.com> Date: Thu, 23 Oct 2025 17:52:35 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH v3 7/9] x86/HPET: reduce hpet_next_event() call sites From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= References: <6a8a912c-7276-42bd-af2b-b94fc6ce4291@suse.com> Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <6a8a912c-7276-42bd-af2b-b94fc6ce4291@suse.com> Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1761235149114154100 Content-Type: text/plain; charset="utf-8" I'm surprised gcc doesn't manage to do that: At least in debug builds two call sites exist, just like source code has it. That's not necessary though - by using do/while we can reduce this to a single call site. Then the function will be inlined. While improving code gen, also switch the function's 2nd parameter to unsigned. Signed-off-by: Jan Beulich --- Oddly enough the CDQE is replaced by an entirely unnecessary 32-bit MOV of a register to itself (i.e. zero-extending to 64 bits), as that's immediately preceded by a 32-bit ADD targeting the same register. --- a/xen/arch/x86/hpet.c +++ b/xen/arch/x86/hpet.c @@ -124,7 +124,7 @@ static inline unsigned long ns2ticks(uns return (unsigned long) tmp; } =20 -static int hpet_next_event(unsigned long delta, int timer) +static int hpet_next_event(unsigned long delta, unsigned int timer) { uint32_t cnt, cmp; unsigned long flags; @@ -173,12 +173,10 @@ static int reprogram_hpet_evt_channel( delta =3D max_t(int64_t, delta, MIN_DELTA_NS); delta =3D ns2ticks(delta, ch->shift, ch->mult); =20 - ret =3D hpet_next_event(delta, ch->idx); - while ( ret && force ) - { - delta +=3D delta; + do { ret =3D hpet_next_event(delta, ch->idx); - } + delta +=3D delta; + } while ( ret && force ); =20 return ret; } From nobody Thu Oct 30 15:35:56 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1761235072; cv=none; d=zohomail.com; s=zohoarc; b=BmCSh6jHi90bi46uPpXFHKutwoW1VRa7f0HKAJUmQxThbzXX0XVLsdmm2Wd4sz0H3W3kuXDJaeYs+dfzAePoEjZu6LPikVjqdesPHj8xwykjzPodf/r92PGOUzfWEoVvjBeSgL+Yyw5Wa0Hh2N0a4FAKDo3JRc7fTvdaQ0qCrKg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1761235072; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=PS7ucokoN9+hEjFZSIghu/GmWjPiHcD6tMlnYOR0lq8=; b=UUpVLHB6b/cEFwRJGscln1+b1rSNFg7E4aHwLIq5+lRPmf/0QrVJxrfP/ipZC+UX0oOsps/qxBbhk2bYl8AJ/V5Yuqfvo8LzuuRt9Xu/eTaHRXaydzQdyI4H2M92W5GCw8fVEElFjXWeRPjmTFsEgyMLH0L0ftV+XqgF550QZ/o= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1761235072298782.1460294112569; Thu, 23 Oct 2025 08:57:52 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1149445.1481105 (Exim 4.92) (envelope-from ) id 1vBxh1-0000Be-6H; Thu, 23 Oct 2025 15:57:35 +0000 Received: by outflank-mailman (output) from mailman id 1149445.1481105; Thu, 23 Oct 2025 15:57:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vBxh1-0000BP-3h; Thu, 23 Oct 2025 15:57:35 +0000 Received: by outflank-mailman (input) for mailman id 1149445; Thu, 23 Oct 2025 15:57:33 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vBxcX-0003ZG-G8 for xen-devel@lists.xenproject.org; Thu, 23 Oct 2025 15:52:57 +0000 Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [2a00:1450:4864:20::435]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 57481c2d-b028-11f0-980a-7dc792cee155; Thu, 23 Oct 2025 17:52:55 +0200 (CEST) Received: by mail-wr1-x435.google.com with SMTP id ffacd0b85a97d-4270a3464caso470211f8f.1 for ; Thu, 23 Oct 2025 08:52:55 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-429898eac60sm4517747f8f.39.2025.10.23.08.52.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Oct 2025 08:52:55 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 57481c2d-b028-11f0-980a-7dc792cee155 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1761234775; x=1761839575; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=PS7ucokoN9+hEjFZSIghu/GmWjPiHcD6tMlnYOR0lq8=; b=WuLmgoDMlTfnp7crL3D29ifCTcFUeb0DBuMatdNj8e3XZWUZbAOttwxdqIuXmWvyO1 tksLcqURiXWYT2ALB83zhRpHBalHjZOOP23dPkFMRByUlvKqocEcViPJ+GgooPF/8+dW 61Ux5UDO89HJUY+l5q7u2xtUyWM8A5S7OAxNU41ZXh9TahAd0EYLYYgDfWXa317KlZCH Hpl5gpFYEPDcZeyBnsmBmfCAgLlz+BzXRXxOvuK2+Lvnp26RKALCbe9GfK3jj6KXck5X vg1WsFV1VqzG/s7DmCXI+UjJ6vc5ABbYdOD1DlX+RQswxOFGKnkeumSb6yNoM22f7qG7 gnkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761234775; x=1761839575; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=PS7ucokoN9+hEjFZSIghu/GmWjPiHcD6tMlnYOR0lq8=; b=HtJV+fs70Jj77cjXRpF5qs358Dprh6c7T99V2kJAUBqgyxrLUjr3+NSexzYD7u8l7V 6lHzl1xWG7ON0tTjB/jks8jJDHzReXjF2jR+zAs2jdhuYxYLNYCXc7WGFT0i0MUViGRO Mus1fZH+kg9r5aaUGbHGsQP62WTxAFwKOybA3GO5RYeOCwD5hE70z8p1+JRgQg7nAo1P +GwBIuYm2vRi7zoU0P5mfM+7eZRFfLsXtiKKXjMrU5Gx9T0rtPk3ozmiqd/OeMQP+fUQ oSDOt9w+t8Os2eODoC5iD5FndwLjTdEaR0a+eSJ/oOuxkZrRpNxGfe220ov5YFzH3JKw Vi/Q== X-Gm-Message-State: AOJu0YzI5Rs94RJ8ZUGOorHP4XHlu3QYct7VKEd4RbcQ1OU40o2isWEe SDlLURdI7zIwEEcLlVKZp77dT+jSMQl2Cg3/HzW2o9u8E2/S9nLtAUJptobwXGDRebw1evLSjw6 x7eA= X-Gm-Gg: ASbGncueGt8SujS/h4k0+sZUygIOgO8Llp20UOY5IWFhjXLUAcf+HiCd501IBdq2oT1 2pKGEkHGjzM9bI4qQwoi64o8SaOahwIAESdjuxehfL2ZQaFJLkxXxrfIWL7zA92bhWDHWn00cOX HJNdVENdZSj9S5U58uIyXgXFvylBVMxMqn2HHSwLpcexbN8vKvr+2he5ziB+vaV+nEypcmRgZ+/ YqomjGaPfbIp2EzcfEX5FuU+WdKWXJ+imECHs6ogaBRDQcKqoDeEC3nNEa94KBXlJTzk7s/XhO7 JZ4htuVKuKblnfYB2KQNcid2vc6FERYv5wMY6TWWxzb9GiQjbxZH3VzUPHGhSwqW66fN9fOZfW4 /4R1K2diAtpktvxLhoBtVksag2UC4p+yOZdC1D3Au95tpZPTdH8KrnRwsK5cSvpknqKtrpdifae neBMWB3FUSYvWv605+L1fXfh2+gihk9TZh8NZ1+Eq5ydSITH+NzfAegz6AGAb1 X-Google-Smtp-Source: AGHT+IEw5vr3sX4/p69hMs8HEEAiC3uG/ZgZS22kpenU9sT4/lr2eWLaAk4CkFjapBhq7Fp+0eTpSg== X-Received: by 2002:a5d:5f91:0:b0:428:3d14:7385 with SMTP id ffacd0b85a97d-4298a059f15mr1799694f8f.28.1761234775377; Thu, 23 Oct 2025 08:52:55 -0700 (PDT) Message-ID: Date: Thu, 23 Oct 2025 17:52:53 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH v3 8/9] x86/HPET: drop "long timeout" handling from reprogram_hpet_evt_channel() From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= References: <6a8a912c-7276-42bd-af2b-b94fc6ce4291@suse.com> Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <6a8a912c-7276-42bd-af2b-b94fc6ce4291@suse.com> Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1761235079075158500 Content-Type: text/plain; charset="utf-8" Neither caller passes STIME_MAX, so (bogusly) handling the case isn't necessary. "Bogusly" because with 32-bit counters, writing 0 means on average half the wrapping period until an interrupt would be raised, while of course in extreme cases an interrupt would be raised almost right away. Amends: aa42fc0e9cd9 ("cpuidle: remove hpet access in hpet_broadcast_exit") Signed-off-by: Jan Beulich --- v3: Drop the code instead of adjusting it. --- a/xen/arch/x86/hpet.c +++ b/xen/arch/x86/hpet.c @@ -162,13 +162,6 @@ static int reprogram_hpet_evt_channel( =20 ch->next_event =3D expire; =20 - if ( expire =3D=3D STIME_MAX ) - { - /* We assume it will take a long time for the timer to wrap. */ - hpet_write32(0, HPET_Tn_CMP(ch->idx)); - return 0; - } - delta =3D min_t(int64_t, delta, MAX_DELTA_NS); delta =3D max_t(int64_t, delta, MIN_DELTA_NS); delta =3D ns2ticks(delta, ch->shift, ch->mult); From nobody Thu Oct 30 15:35:56 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1761234824; cv=none; d=zohomail.com; s=zohoarc; b=Gn/HrMhmF+cbn06KKjcO+HQPVawDlo2MI8LZXaRsGrky3vPMbLq6BBY0IHBprBCn+VAI39WTWcP14lx+LOUGaLhY7s/RdPJ9/d6n5AVwA22hVuP3P4Pbin3pxclMeb4Z34vAlg5JH3Akc5Ev+4G4HrXgYqYaa4buFmAPH65EDtE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1761234824; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Yfju5TuSYr1gnKBFs17R38Pvw/Jb2fzNTTH63D/Pa3U=; b=F22kgRqez5YFzhuhnyeQSuiGzp3tBAIVP4xQrDxZ9xvc62UdJ85U4KhbgFX6yb90qzY0FbhPJUIiEP2r0DT8mZSzkJmiUlNlpDoMGwWA2hp9mgYOkivwPGLDtG+NoSdTB9aaXHxih+DIe+kMTcQsZJAiszJm7l9WPDRwycu8UME= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1761234824814718.7323757482353; Thu, 23 Oct 2025 08:53:44 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1149434.1481095 (Exim 4.92) (envelope-from ) id 1vBxd2-0007hg-OL; Thu, 23 Oct 2025 15:53:28 +0000 Received: by outflank-mailman (output) from mailman id 1149434.1481095; Thu, 23 Oct 2025 15:53:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vBxd2-0007hZ-LN; Thu, 23 Oct 2025 15:53:28 +0000 Received: by outflank-mailman (input) for mailman id 1149434; Thu, 23 Oct 2025 15:53:27 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vBxd1-0007hQ-BD for xen-devel@lists.xenproject.org; Thu, 23 Oct 2025 15:53:27 +0000 Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [2a00:1450:4864:20::330]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 696c909a-b028-11f0-9d15-b5c5bf9af7f9; Thu, 23 Oct 2025 17:53:26 +0200 (CEST) Received: by mail-wm1-x330.google.com with SMTP id 5b1f17b1804b1-47117e75258so7729415e9.2 for ; Thu, 23 Oct 2025 08:53:26 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-475c4281314sm103700925e9.4.2025.10.23.08.53.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Oct 2025 08:53:25 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 696c909a-b028-11f0-9d15-b5c5bf9af7f9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1761234806; x=1761839606; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=Yfju5TuSYr1gnKBFs17R38Pvw/Jb2fzNTTH63D/Pa3U=; b=eBy4ZJit/ANNGxvUnlT9DNIEip8yiLFna+IZJKj0mS5k8gDU8I0FoBmQYAHN977b2c qv1eqvRSvNbgxKZbIPtRGDsjv7xeIPfe0cF+Li89eHqx9ste80G4oc41jAH3RuxXzZEx TZICiXIIGSwJzdhE7RZPcF6xD+9mMPie5kicm1PmNplg9EBYDMgD13H6KuNo/Y/4wqDL 6T0V2N5tUXajq1HCtQWz7esFWKeXgQEqVEbDaUgOI3tcaO5Adpefl/rwpAv+49nSIl/E jssEEhbdu71e8FQPaQelp4RrTui41+1ffm/rrHUoYUeD+SIiI26F5QQZGjDNEJWPv6k3 bB0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761234806; x=1761839606; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Yfju5TuSYr1gnKBFs17R38Pvw/Jb2fzNTTH63D/Pa3U=; b=dgATLl03eYsTSizBivoOSpoCd7P8OiRlwaR0TURVzTi4weZ2XTRVgytfDIccvjteoD 9G7M6gT1IHN27MTynkBRPr6zuMMpJcEBqOF2gQ6iaDQnIsy0wytXqQEHPgm0BH6M6BG3 ShiqHVvog6EjY3ZsmlH+8ywJWfOilMWBzRnoiTU+oQUv5QYszb0CIXn+SYMDOUFgGXDb YWilnzEJkDc6oX5pQW1INQkiIGZJYc1/BrL9gylUfrXw1R2oVMArP79n/CYVz6fdXvwi knHw9hkjtRu3iLpPNyfancFAIPmrlzgG1fxSCdI3l4naZ/imDovkPxjyYxntnaPuNvjr aI/Q== X-Gm-Message-State: AOJu0YzgMteBUGgjeRcMSBu6TqRZ1HTTW0cqkXywjvlFdnnssaPGaTTe N86wJeOk1RL08qtSs0SL9rpA2z0a9+Ptc8ezbTm9UnFMG0hy/lYEZ5ONAA3N4KOAEdvlAwwNxof jrpM= X-Gm-Gg: ASbGnctBhNRDb+bsBbE9QTgkq1oEh16R0IWoyezl/pUrbhB8Xz0Z3b52KAv3KPK3krE 2fFA/0NHZjSl1KAYH7F7KmzhjCKpkc4WGuXuvrGfGoreQTgdgy0vPH/5mVLsRtL9SvZUcFtevp6 QtXwJDG6kKgRyF5KlVEQXwzEHa6jlDiZItAgyhBhjoKLioxwLEbBAno9aK/5L8yNzMPgEUE85+K RdLt41CwglLCZmErB3DPHRqAmlkwjAX+yYCYf2WraILEqGMbtQ9kQlHmrTkw2sPa6uIo+uAiD2M bGgwp2JC2xHwnuWDVuWK4uxcB59S9E7AM+AB/3cjRGtc1chl4MtPxGq/9lKSjUqNFkjv/fIkzyM mZJJbJ9RGW51RdAIf55YgVP5QIT1KgVU3p+GyTQHfshNrUfykCrj+ioVNsQSMhJmXw0BSCKP4Q3 VK7XDL3ua3KW8atIQkQmXCauzzzAHGuj1HmIOT+TN/tPJX+fEmwwaGXkz/stPT X-Google-Smtp-Source: AGHT+IHeklUfRModfDEmbNU6EzqivzIwOReNcO1R1E45nwegGH4IqjeeVfWLsrm4xTPEWX7N8fLelA== X-Received: by 2002:a05:600c:4695:b0:46e:32dd:1b1a with SMTP id 5b1f17b1804b1-475caf92922mr21227715e9.7.1761234805771; Thu, 23 Oct 2025 08:53:25 -0700 (PDT) Message-ID: Date: Thu, 23 Oct 2025 17:53:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH v3 9/9] x86/HPET: simplify "expire" check a little in reprogram_hpet_evt_channel() From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= References: <6a8a912c-7276-42bd-af2b-b94fc6ce4291@suse.com> Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <6a8a912c-7276-42bd-af2b-b94fc6ce4291@suse.com> Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1761234825878158500 Content-Type: text/plain; charset="utf-8" When this was added, the log message was updated correctly, but the zero case was needlessly checked separately: hpet_broadcast_enter() had a zero check added at the same time, while handle_hpet_broadcast() can't possibly pass 0 here anyway. Fixes: 7145897cfb81 ("cpuidle: Fix for timer_deadline=3D=3D0 case") Signed-off-by: Jan Beulich --- v2: New. --- a/xen/arch/x86/hpet.c +++ b/xen/arch/x86/hpet.c @@ -147,10 +147,10 @@ static int reprogram_hpet_evt_channel( int64_t delta; int ret; =20 - if ( (ch->flags & HPET_EVT_DISABLE) || (expire =3D=3D 0) ) + if ( ch->flags & HPET_EVT_DISABLE ) return 0; =20 - if ( unlikely(expire < 0) ) + if ( unlikely(expire <=3D 0) ) { printk(KERN_DEBUG "reprogram: expire <=3D 0\n"); return -ETIME;