From nobody Tue Apr 30 06:12:06 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=suse.com); dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=2; a=rsa-sha256; t=1642688222; cv=pass; d=zohomail.com; s=zohoarc; b=NrdeOD3YhTfXcADwCmdw3BvdYUtt0vmCeP3g0VDModhKRKfz+ZfFBieOW/NAgRNpXXNW7XxjcuVncFC3QUKJeuP3PXmZ5xHc5BK1X1Y6TBLU+weC/mNBPlAwUXIiM7ze9jUgQHBcQHTliYV4ISRzUs+L0fs5UH2xbmgOrsc7uJk= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1642688222; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=oEVB2y/I9AJv59oC5zCnIj1lphgp7QzAQDw4BT4hvyk=; b=gbLcLR2ulzBEumK4KQINub4O2c7EHM+qV1o8gqrsnwNPTSRffnUW7G0+ZQllTmMG2YYhn/MuZsvfL1y2UGg9mZZnEjIrfoQdvJIj4rsENFf1M+jL+0hW6ESu2xqIWbhL2sGSDFzGn3VExZh5dojbIDh61kd/VfzrGrcFtqkn0PI= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=suse.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1642688222399285.6085726903458; Thu, 20 Jan 2022 06:17:02 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.259084.446868 (Exim 4.92) (envelope-from ) id 1nAYF1-0001qe-OR; Thu, 20 Jan 2022 14:16:43 +0000 Received: by outflank-mailman (output) from mailman id 259084.446868; Thu, 20 Jan 2022 14:16:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nAYF1-0001qX-LI; Thu, 20 Jan 2022 14:16:43 +0000 Received: by outflank-mailman (input) for mailman id 259084; Thu, 20 Jan 2022 14:16:42 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nAYF0-0001qR-7H for xen-devel@lists.xenproject.org; Thu, 20 Jan 2022 14:16:42 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9675d046-79fb-11ec-8fa7-f31e035a9116; Thu, 20 Jan 2022 15:16:41 +0100 (CET) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05lp2107.outbound.protection.outlook.com [104.47.17.107]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-39-ffoycnpLNzi9iczhDmV1hw-1; Thu, 20 Jan 2022 15:16:39 +0100 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by DB8PR04MB5786.eurprd04.prod.outlook.com (2603:10a6:10:a8::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4888.11; Thu, 20 Jan 2022 14:16:37 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4909.010; Thu, 20 Jan 2022 14:16:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9675d046-79fb-11ec-8fa7-f31e035a9116 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1642688200; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oEVB2y/I9AJv59oC5zCnIj1lphgp7QzAQDw4BT4hvyk=; b=UrDwfH4S3j765wkV0gxCmKE85SVB6UGUnzI8rgcC3NG+ZVMJjawqWyemS/1NJep2oDrrtl bczuwtxORhfW4fCgEoCnvz/bLJWjQN1IEItq1AKlJxAYFfIt69FKQZvEO5n0vCzIZPh5Pm ENDTwhD2vN1PboBUdIsF557NISx0/7c= X-MC-Unique: ffoycnpLNzi9iczhDmV1hw-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AcVhkpTDaC0R7RzKOEiuOZSFjifH29kVY+4EElnXEhj43OxirVrd6MYjAAMp3AsA/8FcUSbenEuvWCbkLZVWDx8XCnr66GkiZc9YJXByLpSQXSwSAbtQqg/Rn/cmS/5LjPX3HQXwJeNNq/ESJkphqEz6Gd8hr4OGuYbshkql2nz76+OypU2/gefEvDUb/CNeYSt87jMoXNBfMUM5P37Y0u8cLdiFPG2yjxMskCBGl4f2FK2rjHjucABZtg5GV3DpLssI7wQrggpilM1JMvbEC0mxkyaZ4hW0C8P3qLFSDA+GEa1uQaChrVvPyB9VxgBnHNuZ0zPCZB1rfKgCLzrcnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oEVB2y/I9AJv59oC5zCnIj1lphgp7QzAQDw4BT4hvyk=; b=C1Cge6HrMNd776vL2MgZIWKIj141aCvz5i1GqOvIBe9oD0rfdGSInOzFDACxdh5woB9GxCcTm4bMTrFFh24LNoVL2ujyJ1HWuwn+qfXN/fkzYorpupnuQelLecdbGkijrQksgrX8Ed5pa1IswWHUr5F4zsB3SunUfl9S1JVKlLsrGpMWbYvEnCwqXaeXgM3gcENEwCEw/9uc13iY5jl3KS53dRfdY2vEMUHrqNL2k81rJvbRbQeWLLkwtw90s0Qa0/bMaxqEIgjYKG1xti4xKNNDsW5dej7XNsv/qhMn5hyvRfPZnq42JJUt9wa3L+9550qfMcbBAwlYYFChOdVVpQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <0a8981c6-b3fe-c805-f45b-b6da5d0aa1af@suse.com> Date: Thu, 20 Jan 2022 15:16:35 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: [PATCH v2 1/2] x86/Intel: Sapphire Rapids Xeons also support PPIN Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <64a5a3ac-8f4c-b13d-0b7d-4c4ec15e2721@suse.com> In-Reply-To: <64a5a3ac-8f4c-b13d-0b7d-4c4ec15e2721@suse.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AS8PR04CA0089.eurprd04.prod.outlook.com (2603:10a6:20b:313::34) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3cdd0f45-f61a-4330-3176-08d9dc1f7863 X-MS-TrafficTypeDiagnostic: DB8PR04MB5786:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:5797; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xZsc9yQIooaxZjUyJhDZV9FjCtruv32MHwuF80CactK64pyKDdYw9M3vIyCFeQz+oRCveAsdzSuedWt3LEfrtNKUOJL7xoTo/Rnv1XAzlps190eTohcZvR7+nGU4VRb6+bIjPlpSwdtjBQaAK70cnMzL9NZ1deSDt0fJ/cUFGK0E9H2HZus+CdFun6cewNKFhO+CxQHmW7MiDwNtF6NqHvVQCJNH9lHhpqFrxLB5F5sX3ug1TB8u4+7tl3eEBKPHH5OOck29DD9CU2JNkz+m39c5h7rv+0n/TOzc9ybhyr2pfOSGz3WAc8X2ipx2yIxZPWY538GD9rKw2Fr/qNLrmuxnflu5mGpqsHYYeYiOv7XKecKKMvExP7SW2KoHidoDkHsoZ0vKA5QnaVF2mjafFXPeSOzLtd/auc+lUdGx3SACCZgSPQM71XB68/bNZNJBxZ1JytlpnxsMbWHXAO3ObFT4NwRFOr7L7tn7VCPsGzZI1IDwKRQmaNm2q+cVDejI768BuQikncXX+IuQSO6d9sp1x4KgUBfPGbgs5bspRspfnvhhMyvgIL2rmCkVXHiv1bG3G3JzaVi0gDHXeTu3+UkrkGveL+pGbJdyN7OsL1PjKXkoK9YN0EYjRSPUJuAsBwM1VA8GnPPpFeC4eu7uNBdx8KAhjrMF/sDUnQry55WOGTTDazil6vEqmt+ifUfJ+xi0uawmtmky1+90UHBOiC3ETLJvwCTNV3mB9vs0XpfuOENkNZ7YRx2gI88q9kFK X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(5660300002)(2906002)(66556008)(2616005)(66476007)(6486002)(38100700002)(26005)(6916009)(186003)(86362001)(4326008)(6506007)(36756003)(66946007)(31696002)(316002)(8936002)(31686004)(8676002)(508600001)(6512007)(4744005)(54906003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cW83ek9xN3Y1akFWZ3VPVlBEL0hyditjSGNNU29TYmYvMTBYaXhPdS8xV29z?= =?utf-8?B?TVRleHdvYWo1V05rbzJKNkZwSFF1d1YvdEh4UzI4Mm1MNHZIVnhSc3pVNjUw?= =?utf-8?B?NlBTRFdXTlNybUNINHNlb0hPdk9mQ05nVDI1NThhR1RFZkFKbWgzQkFWdkpG?= =?utf-8?B?TnR5T2dxVUFDZVR3aFc2MTNXcXRzWVBaZ2cxZjJuVkIrNzlPcWlXdmJmc2I4?= =?utf-8?B?UC9VcWxHTTFWMTc0U2ppc3oveGpORXFXWFlXVGxUQU81RHdGbTlDZCsxVG9p?= =?utf-8?B?UXE0Zm5NOG1kNjR2VEFudWZUNmxzcld4NEJuek9WSytQcG9MM2dCMWJxVGFS?= =?utf-8?B?T3M5VmZYaXhqRXNrQld2WFBWOUNJcm51Mk8vaC9zeTE1a3BKOHhUMjlzd1Zy?= =?utf-8?B?emROU3ZkeFVldTBQMGFiVUZEcjJWTitLMmQyWlRMTVNwdFI3dGUybHg4ejdB?= =?utf-8?B?UTE4M3Vqc1NsSDJZZXVOaGdPTVhYVnVVUXRwUUVlblcxd1hCQUFiRjRiQUlo?= =?utf-8?B?S3Y4TXg5YVE0UEtieWJjMXhsQXZORmVpbHJHT0pNR1NrSWpQQVdxZi9rdlUx?= =?utf-8?B?dzQwTWlYeC9CL2NvaSs3MUE5SkNkWFJhRXdFb0RaUkhsbHp2WFZUR0pUVHND?= =?utf-8?B?c1k2MU9UdlpyVnJxZzNvdXdZUDVyQ0I5czZ0SHN3Wnd3a1hGZ2RTYXc1dEZW?= =?utf-8?B?eU5DMHRScGFZcktnTWtDdnEwK1VxOTZOS1FRd3pNRHFnRFlwVVJRM1dYUVlL?= =?utf-8?B?UFFwdkgyU01uZ3pSR0lacStNVkpYcGFqSUxEbXZ5TmFZY01pWDhQdzg5Rzc4?= =?utf-8?B?SDN0MHMvOU00K002Z1J1cEFIMmVSSTYxK2hwOWJ5ZGpDVzAyaXNOZStCUmJB?= =?utf-8?B?UnNZbXo1TEl6bHVkdXZtSkpCVTkvUEJkWWwrSlV1bFlLcFBPK1d5RERoUHAy?= =?utf-8?B?b0gxM0R6ZFdacEZjYTM2Q0UvWjRJY041TmdDTWhzUGpPOForbGNRV251eVV1?= =?utf-8?B?Q1VoaUtnMGQ3TjVQc1p6WkhNZ3lCbyt6aWJkNU9RZzhMTThtYXBoV0tRdkxp?= =?utf-8?B?US9mbW5KaXAxMzZaYTZNUU9adW8wZDgzYi9xY0xNenNTV2lkT1ZPKzlnNXAz?= =?utf-8?B?MVltUFpTSTM3TXVjbTlTcWxTWHRpeG5YRmRwZzBHa2ozeTlQc1U5MGhzTGpk?= =?utf-8?B?bm5RbFUvSlBOL0M0dWZxRTBNc0lvbDNSbW1tbERvNTZLRTRBZHk3TmxKdjFi?= =?utf-8?B?TnEzcU9jZUttcStEWXg1SFRxTDNidi9DTXhNODFZREVaN0U1R0ZCbGxWWE82?= =?utf-8?B?NU54d0M5ZHlwKytZTzRIMzVBMk5paEFzaVZNb2VhU0dEaGw0UGt2SHIwMG9p?= =?utf-8?B?Z0ZXNHZRRExic3pKUDRITG5YN21jV1ZWS0J5VERFdlZlZTg0SnFNaS82bDlE?= =?utf-8?B?TVpLWUpMcENBdVRWWUhweUdMclRJNjJjMEczMVBtNGpUUWtGME0vaXhEVmlF?= =?utf-8?B?QVFKdUlSR1ZNbTlDa2t2UjZVNitxdFZrNkY3YTJuTVJzbEM2c1JGakd0bkNh?= =?utf-8?B?clBnYU9UVEU5UFY2UDZ3MHRFQlRIM3g1eHVWYUJGVy9wMDdCdmt0SkdlRkRP?= =?utf-8?B?SnZHSnFQQTU2UFNMZXBiUjFobndBZDRNZkhxemtKQkFmN08zTzViMWd4cUps?= =?utf-8?B?ZmVZOGR6bUgvQUxZV0xDR0FUZlgyZktnTzVNRXdzK1N3eG1ER3dsYmVROURW?= =?utf-8?B?NEpzNkVlbW40ellFWWlaY3FpdGlEa1o3c1NPbzFTKzBORHpzVkxUb05BVXdt?= =?utf-8?B?YXRUQXJWSmgvcUx2RC9TWDVOZnFMYlkyc3BZd1RmMytvUnhjTXJSZThVVURI?= =?utf-8?B?b2x0WkNxVGZ1V2xUY3dYa2o3dlRwTmNWRWdDQUZPK0ppbExUVG9jSXFzeEhT?= =?utf-8?B?cU0yM29WZ1lUZXN2QTRwNjJnWXVTWXJNWWduamdIaDlpaHhMQzlmOCtEQmZL?= =?utf-8?B?RWoySllUN1J3WXRybVFodStMQklqdUxYQUQ4bWNjcTZBOFFTbWRQL2JoVm9r?= =?utf-8?B?RkFKbjdJRmdmaFFtSWJqRmNTNXdqTFpkdVZnSlRNTFF4Q24wdGdPR3JQc3Iy?= =?utf-8?B?Uzh6a0MzQWc2V2hnZEhpYWJmMitlcmVwb0RYTjJ6a0dXaVJIcEpYMHdGMnlx?= =?utf-8?Q?VKkbyO8UfcOGxkwwifsMLMs=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3cdd0f45-f61a-4330-3176-08d9dc1f7863 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jan 2022 14:16:37.3058 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 5CODEykEDIPB5rmbbKQ8fAyUxN2ghU+nT9zSDooIVA1AEjrPxS2DIBsdY+SVf8dtzTRTRuG2rkMGi8XrQxniig== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB5786 X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1642688226354100001 Content-Type: text/plain; charset="utf-8" This is as per Linux commit a331f5fdd36d ("x86/mce: Add Xeon Sapphire Rapids to list of CPUs that support PPIN") just in case a subsequent change making use of the respective new CPUID bit doesn't cover this model. Signed-off-by: Jan Beulich --- It is unclear to me whether this change is actually made obsolete by the subsequent one adding support for the respective new CPUID bit. It also continues to be unclear for which CPU models, if any, the PPIN_CAP bit in PLATFORM_INFO could be used in favor of a model check. --- v2: New. --- a/xen/arch/x86/cpu/mcheck/mce_intel.c +++ b/xen/arch/x86/cpu/mcheck/mce_intel.c @@ -873,6 +873,7 @@ static void intel_init_ppin(const struct case 0x57: /* Knights Landing */ case 0x6a: /* Icelake X */ case 0x85: /* Knights Mill */ + case 0x8f: /* Sapphire Rapids X */ =20 if ( (c !=3D &boot_cpu_data && !ppin_msr) || rdmsr_safe(MSR_PPIN_CTL, val) ) From nobody Tue Apr 30 06:12:06 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=suse.com); dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=2; a=rsa-sha256; t=1642688256; cv=pass; d=zohomail.com; s=zohoarc; b=PAU+t2ZTJ38NyXHti1XPaZAUbb13yjebrOrNOktthPYL+FOB4/YSspVxrk1ewbwCn8liyMulbIRz2TqCsO7zg3/AJrUY4YFzr2vuDB/TNNplMXEvS//TT4xe96fghOWsG6tU6IT4iWsU/jnHWAocW1BCyp6mcOrSWpBSZC02yCU= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1642688256; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=hSoDsIzAqt0gE1mEnXjo3VJvwAW5xapG8X8G07FEs6o=; b=Twzoj2UsnFqbZmlD9ZLo9zOza6T9MROyRx9eeR8vGjbnMiboQXnyF3pOwE43pdv9l7XagRsj9QMwOOBGwsgcOK67hTVLXk88eNaXbOuqHloGG88s6jqsa3L0WB2W1LrVETJV+vTEIWOVXBolj58464D5zP3aDR9G554zpTmZkxU= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=suse.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1642688256749371.0854994216878; Thu, 20 Jan 2022 06:17:36 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.259086.446879 (Exim 4.92) (envelope-from ) id 1nAYFd-0002QW-21; Thu, 20 Jan 2022 14:17:21 +0000 Received: by outflank-mailman (output) from mailman id 259086.446879; Thu, 20 Jan 2022 14:17:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nAYFc-0002QP-V6; Thu, 20 Jan 2022 14:17:20 +0000 Received: by outflank-mailman (input) for mailman id 259086; Thu, 20 Jan 2022 14:17:19 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nAYFa-0002D7-VI for xen-devel@lists.xenproject.org; Thu, 20 Jan 2022 14:17:19 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ac96892d-79fb-11ec-bc18-3156f6d857e4; Thu, 20 Jan 2022 15:17:18 +0100 (CET) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05lp2106.outbound.protection.outlook.com [104.47.18.106]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-33-OCKKYu1mNK6pDA7MmKA6aA-1; Thu, 20 Jan 2022 15:17:16 +0100 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by DB8PR04MB5786.eurprd04.prod.outlook.com (2603:10a6:10:a8::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4888.11; Thu, 20 Jan 2022 14:17:15 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4909.010; Thu, 20 Jan 2022 14:17:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ac96892d-79fb-11ec-bc18-3156f6d857e4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1642688238; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hSoDsIzAqt0gE1mEnXjo3VJvwAW5xapG8X8G07FEs6o=; b=O3meA6GNUdnZlLP+l9E9TdA3lkPMyxMU+6BF51XokmBemzvlpFcJ2sB0cmL/ZCenSYOhPL xKF447NTkS71iWWhW2+BLhx6zhpmH9K5SE97aJS3Iy2wH8Perq/CIzlQRO9jt6VIQc0yxv Lo+5j/Rm5vb7tItYc7QuBbrELE+xBHY= X-MC-Unique: OCKKYu1mNK6pDA7MmKA6aA-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EhaZRN4PgvEwDLqjG69f0f2kRpglF7UMB/jeq+5KLexr7CV4Yot/6RzrPY3RWj6LbKbWuphyFiEk2lefjniYwFjL+4s3SMbFg6e/feiVd2Y1/suR8MrR4kEjPNoa/oW/ZgrEuCW0ZZ0+O2MreLBeV3vi4LoX2H8NhGP8Y0FiGknX2T65CDZKcvXLmf0UXiEUA1PWZgSu9Le4wwqt0lftA2YiCthxMIzRn+VPzgI27dr2kyNEc2Cl14F/yaEwoFMcA6ip+r/FbpvujUcFAm7DtVi/ObyvlPhssG28IOaEKtw8vxw5dp04QOgAkKYTYM2ikzKOnrE8yHgy3mE86g2wlA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hSoDsIzAqt0gE1mEnXjo3VJvwAW5xapG8X8G07FEs6o=; b=Kmvh2grLHHBIkwRB/hU8EX03D2nNq4giv/1etiXR1jBb6hEwhj8QPeGIPduf3hWLMrVRnaIW+YWhTtuBG0Acfm6eoJ0k73RB2K+WxnyxazqGQoKh8w8JN3E7Vho0EA8YuBuB7SIzLRaatglH0gC4SzgiBaePi99LxdOAQy54FaCcXXUDuq/PPKL81jJ7kLtI3zKbQJ2AmE/sUXXTZJ/1K2U4O588TP82Zj3xghzxbnsbF3IhGpC9096Amgxrh0uTdWdDs9TZVIeKnNM3hd9J2JB+09mL3Vk+6yHed0GmtnpWbdzgEbxs4ONDxCCONbXtY5WUziIlwYiQ2yM8BrJPxg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <2d13a663-f03e-b1e2-0c38-5dc3282dab10@suse.com> Date: Thu, 20 Jan 2022 15:17:14 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: [PATCH v2 2/2] x86/Intel: use CPUID bit to determine PPIN availability Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <64a5a3ac-8f4c-b13d-0b7d-4c4ec15e2721@suse.com> In-Reply-To: <64a5a3ac-8f4c-b13d-0b7d-4c4ec15e2721@suse.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AS8PR04CA0083.eurprd04.prod.outlook.com (2603:10a6:20b:313::28) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ba4bfa96-a676-4be1-5f1b-08d9dc1f8f3e X-MS-TrafficTypeDiagnostic: DB8PR04MB5786:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Jo2SHIa2j+Mr/2iaBZCu7Rvo7cu9km0+tdrUFRIhgDoXgqpTKAgpOsywudEcnGjpCUFY/GkULNlnBLj7iC7nWBglG4ZVhVl16NqwXD8VQhWGg2LUeT+dE9iyihgb9pp4eGxMqThix96Gc1ipp1Np+raOQDRN/v5vtJzTHmHwI2FatL65PoKSapltO8CQoXnREzXL5ODGBdWPfe3irn/CtoZG00m3avZ2tz+sthPO4xB124iqipJnrBbBIlnm3AL/SUp+gsE9LVKSzu9Ii7upwPJWFND9aK9YLQIuuIpJrnw9I6SnLOBYPLbl7MmSiEiHZVKl6zF/4GqJZL1a3rIrMA+TpuzRwe/+BUwY6U/gKrwK58U51rYdAC/HpIcSqe09mZvOJ9LJtjHGjAei3vz1RC2ruaV3SA6LiBNC5SVQdInLP533CqR/QE2RJklPu9wKeSJ6iMqzoI7IsRUIj7jNe0GLszUKqoPplNUQncCfcRB8GI4i96HADEsVB4CxTkqyCCIKq4j8ykxvMGRZADCKkzgEn7sjSPka6Tz/Yy0UDs+Wa0b4wArTD+XgMVn/Sn61XPJf/r0gKsjhaiEkq90BsQ8fPOWds5kIDUyp4rjYuYHC75PiNdnK32ZztXqc7pIePVXPivmAVBbTjwqJjXPmL2NxWBZ8Sb6BulUyEfvtGJwRQVLIqbKn+8EeYhny53RhRsnafzDc6/3a1d83EMPFq0ZVJjiCZQ2IoAdpNWaBzk9g66D8YtbRfnkK23L9sw74 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(5660300002)(2906002)(66556008)(2616005)(66476007)(6486002)(38100700002)(26005)(6916009)(83380400001)(186003)(86362001)(4326008)(6506007)(36756003)(66946007)(31696002)(316002)(8936002)(31686004)(8676002)(508600001)(6512007)(54906003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZTJSdjRXNGYxemR0ZXpIdTZLNGZOT1F5RE9aSTZsakFJQkw2NXdPekhjZnRM?= =?utf-8?B?SjMyV1BYYzJTcXd6bjY5SGQ2S0VpMG9vSGdJY2gzaXQwQUlvV0g2V3pLNk5V?= =?utf-8?B?Z2taak1PTjVFeFpYbmhQS2wweGRLeXpEcGZXVDdRRnpOWWxKRklHV3JmbE9F?= =?utf-8?B?cGduRklCQVZMUCtFendFMFBVNGtBbjhtS1Bjb2EwcnVhdWtkT0ZaK2xnR2tt?= =?utf-8?B?NlJ5aUpMQklkUFJVc0xOMjc0U0JPU1djK1U2b2FVOUtWWHZjY0xiN2RvTGY1?= =?utf-8?B?bGdGS2ZnazlWYnltcEsvMnNjOWtjNGsxVFhWdWR1bmxZR1BiTDZNUS9Rcjly?= =?utf-8?B?Z2YwY3dFdkcvVkpkblY4WExnMW4rVElRMkJwTFlWSGkrenJsdi84cHhFTGl6?= =?utf-8?B?VENESjFHZEhtT0toUmZ5Z0ozcnZmSEwrd0pqdmhvSE9XTzh6UFpPRkFwM0dp?= =?utf-8?B?MndxYmJQeE51djZyL2RIblIvYkNrbHp6SHp5SEdnQ1VyOGNyWkNwY1BZTXJY?= =?utf-8?B?L1F5enNOTXN0SEx2TW9YUmZFWmc4QWs1R1FYWklibUFHRVA2THd3L1JtNzVx?= =?utf-8?B?RUtlcjYvVkZocFlXc2YzVm9lTHNpOTFCdm14QktJa25IVHJyWDlzcUsxWnZz?= =?utf-8?B?OE52Nk9NTE9ETzlVZTBRMFhiK0IvSzZQSHBFLzVBMHlpMjVEeHpZQWowWUJZ?= =?utf-8?B?K0JzTlhzRytTWGhtN2tkYUFVUFQvMzdPOUVWOGpRK2pBZVBwK2gwTTdjZEti?= =?utf-8?B?U3RmS1laM04rUXMyZmQzcEZJRGMrYjFMNUxwYTVQck5tR09FajRMd0wwWmE1?= =?utf-8?B?Sng0Q0FWZ1VyRGJaRGVSakprV2owMVZQMnM2YVRsTWZHNlJlMTdFUW1qZVRD?= =?utf-8?B?cmg0dVh1dHQ5RGduVTFJN2UvQ3RCWE1iU25DZjNOdm5SRVZ4VDB1T2RCVkJu?= =?utf-8?B?Y0MwM3JzZEN1MnkvNTB6bjVkYkRPVzg5ZWpoekgwZktqWDgxMnNPUGpGT2NB?= =?utf-8?B?WEV5Zzh4dWlwMWQ4MGhwUHRXMXpFc0ZhdzFCS3hJdVQzNCtyd2pGMFphNTVD?= =?utf-8?B?UExPekZEM255ZldKMVE1bUZxQm0rSlRtNHBidHNnNTBEekRJSGhHUmZiT21O?= =?utf-8?B?S2dxSWlFYk1YcGxoSUNsSFMvTTMvcmFjanNab2V1NzI5SDllV0lVODUrM2R6?= =?utf-8?B?UG1DaElxQ3RNcy8vc3NxUlBSTGlMbXMrbHFubmhRdWVtbEhxdkFwdG1jZmVz?= =?utf-8?B?OHNwTndrUkRpbEdYdHR2aERacnp2SjVCUitkVWt1c3hQditRaEtHVUoxa0NL?= =?utf-8?B?Y2tPdFBNb1E5aCt0cGdRLzBwSTVBeVpVS00wQU1QTU8rRVYwTityQkpybkww?= =?utf-8?B?TzB0TGhPU3JZRXJLSi9nNmNIdFVlT1FkMHB1NUx2b3hOTUlQUUFSb3FCUElH?= =?utf-8?B?cWlSTVZCN0ZRSXlycUg0MXNtc2daeVhUVTZ6NVFnbFJvRkxPSWpMaDA1Z3NK?= =?utf-8?B?dEp2emExdVc0MEczOTJvZmNqa21oMHV5Mk9pR0dIb1F0NDZjYzZqODJSaDgy?= =?utf-8?B?eWhZRFhnRUNSZ1AxM3k4aEFpRVZSOHlLUU5RTmY2OWJVcExrcExVRGVoTkpq?= =?utf-8?B?M3ZjWFhFWXloM0drN1pwRmJtT3VoVVNzc2ZTRGF2Rlpyai9ZZmMvZHRNUllW?= =?utf-8?B?cnh3TjI3dm5ZLzdYN2svZm9TSTVNQ05NSnNHMmViNjVNYkdjVDE5YURMNklv?= =?utf-8?B?Vy9hMkVZWlRNK2VGZWJWcUNlMERaWng0UlZZSFIzNWpFclNOU01ycWh1ZG1V?= =?utf-8?B?bGRaZEt3bGJpdjRGVU05QnJLN2FnZnR3bitncEpxdEJCcDNoWTRaQWtVaWdm?= =?utf-8?B?VE1LcVgyN3IvMjRyNXBBYXY4QTkrNHdicEhBYTdLaDRCREpoUkhCcG1IM2Zw?= =?utf-8?B?VDR6bjdPZHFqRHBFYUE1RFhsOEZ1SWViVytaT2xpZHhlRFZJSTlOS1l2MFRm?= =?utf-8?B?aHZ5RkhhSTVlWllneHlNUnVWcjFVRkR3VHlaM3BsZVNIT2NIMk85UzJZYkJO?= =?utf-8?B?aTBjL1BWRjlkQTBTcDJqcmxPWFE3WjZDdDNYV2JMTE9YSHRYTWQxV2JPMmVF?= =?utf-8?B?VVNWQXBzZkxXbHIrU2xCOFduUUlIMTE0djFDOUc0TG1KczBWZjdxbzZKSk5V?= =?utf-8?Q?mNoXIzpZE8D5E+Lm1PnEGLw=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: ba4bfa96-a676-4be1-5f1b-08d9dc1f8f3e X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jan 2022 14:17:15.6321 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: B5EytEB/N5yy7D60KSCBBZtbkI/x3sHGcKT3Q/S+Ev22LsY/5Zpwc8rFxm/VQIpudmVCx1+D0m7jH3A3kX9xwQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB5786 X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1642688259041100001 Content-Type: text/plain; charset="utf-8" As of SDM revision 076 there is a CPUID bit for this functionality. Use it to amend the existing model-based logic. Signed-off-by: Jan Beulich --- It continues to be unclear for which CPU models, if any, the PPIN_CAP bit in PLATFORM_INFO could be used in favor of a model check. --- v2: Don't rename AMD's identifier in xen-cpuid.c. Name Intel's just "ppin" as well. Move str_7b1[]. Update a comment. --- a/tools/misc/xen-cpuid.c +++ b/tools/misc/xen-cpuid.c @@ -195,6 +195,11 @@ static const char *const str_e21a[32] =3D [ 6] =3D "nscb", }; =20 +static const char *const str_7b1[32] =3D +{ + [ 0] =3D "ppin", +}; + static const struct { const char *name; const char *abbr; @@ -213,6 +218,7 @@ static const struct { { "0x00000007:0.edx", "7d0", str_7d0 }, { "0x00000007:1.eax", "7a1", str_7a1 }, { "0x80000021.eax", "e21a", str_e21a }, + { "0x00000007:1.ebx", "7b1", str_7b1 }, }; =20 #define COL_ALIGN "18" --- a/xen/arch/x86/cpu/mcheck/mce_intel.c +++ b/xen/arch/x86/cpu/mcheck/mce_intel.c @@ -859,12 +859,20 @@ static void intel_init_ppin(const struct /* * Even if testing the presence of the MSR would be enough, we don't * want to risk the situation where other models reuse this MSR for - * other purposes. + * other purposes. Despite the late addition of a CPUID bit (rendering + * the MSR architectural), keep using the same detection logic there. */ switch ( c->x86_model ) { uint64_t val; =20 + default: + if ( !cpu_has(c, X86_FEATURE_INTEL_PPIN) ) + { + ppin_msr =3D 0; + return; + } + fallthrough; case 0x3e: /* IvyBridge X */ case 0x3f: /* Haswell X */ case 0x4f: /* Broadwell X */ --- a/xen/include/public/arch-x86/cpufeatureset.h +++ b/xen/include/public/arch-x86/cpufeatureset.h @@ -299,6 +299,9 @@ XEN_CPUFEATURE(FSRCS, 10*32+12) / XEN_CPUFEATURE(LFENCE_DISPATCH, 11*32+ 2) /*A LFENCE always serializin= g */ XEN_CPUFEATURE(NSCB, 11*32+ 6) /*A Null Selector Clears Bas= e (and limit too) */ =20 +/* Intel-defined CPU features, CPUID level 0x00000007:1.ebx, word 12 */ +XEN_CPUFEATURE(INTEL_PPIN, 12*32+ 0) /* Protected Processor Inve= ntory Number */ + #endif /* XEN_CPUFEATURE */ =20 /* Clean up from a default include. Close the enum (for C). */ --- a/xen/include/xen/lib/x86/cpuid.h +++ b/xen/include/xen/lib/x86/cpuid.h @@ -16,6 +16,7 @@ #define FEATURESET_7d0 9 /* 0x00000007:0.edx */ #define FEATURESET_7a1 10 /* 0x00000007:1.eax */ #define FEATURESET_e21a 11 /* 0x80000021.eax */ +#define FEATURESET_7b1 12 /* 0x00000007:1.ebx */ =20 struct cpuid_leaf { @@ -188,6 +189,10 @@ struct cpuid_policy uint32_t _7a1; struct { DECL_BITFIELD(7a1); }; }; + union { + uint32_t _7b1; + struct { DECL_BITFIELD(7b1); }; + }; }; } feat; =20 From nobody Tue Apr 30 06:12:06 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=suse.com); dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=2; a=rsa-sha256; t=1643288126; cv=pass; d=zohomail.com; s=zohoarc; b=Sg8MtxpX+a2xbJZfWLZQ8J9iWh1ncflUUq+WnbdafRD5Y+Tz9gxKKVNNtDdlY2+vqRVguRdZdjtkfB/ddgerZqvtqaJ2lA+VVSKo0erGByXLRHwVjUtIzL9+Bt12IW+ylb6Qupb11vwtpa475ak4+1GMi3p9PcmR4EwJ7cKp5eM= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1643288126; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=jUcJmN6jlKijIbl/I51T24eZTzV7QGvASK1sSh8ViyY=; b=FFwSYJ5FNhNS8ulo7caLGjXX6OB+QsjUR6uvwBFft8E4d7L2Tumwx7IQWnDEeVFInohlNE5g1ej6TC9JGpz9Q0AkhpWGQK36aOo6vkKE7L9ZbtNpm+vwSpc5lyuUwN/L82Oer8TiFriU44KD5GqdKhRMbXfGEYpm2WiANMK4ReI= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=suse.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1643288126852275.1435193188032; Thu, 27 Jan 2022 04:55:26 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.261459.452732 (Exim 4.92) (envelope-from ) id 1nD4If-0003uF-L2; Thu, 27 Jan 2022 12:54:53 +0000 Received: by outflank-mailman (output) from mailman id 261459.452732; Thu, 27 Jan 2022 12:54:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nD4If-0003u8-Hi; Thu, 27 Jan 2022 12:54:53 +0000 Received: by outflank-mailman (input) for mailman id 261459; Thu, 27 Jan 2022 12:54:52 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nD4Ie-0003u2-8u for xen-devel@lists.xenproject.org; Thu, 27 Jan 2022 12:54:52 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 50c2904f-7f70-11ec-8f75-fffcc8bd4f1a; Thu, 27 Jan 2022 13:54:51 +0100 (CET) Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-am5eur02lp2053.outbound.protection.outlook.com [104.47.4.53]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-15-DWnCEEcaMaWHZ0mTJJvaLw-1; Thu, 27 Jan 2022 13:54:49 +0100 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by AS1PR04MB9407.eurprd04.prod.outlook.com (2603:10a6:20b:4d9::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4930.17; Thu, 27 Jan 2022 12:54:43 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::a1a4:21a6:8390:b5d5]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::a1a4:21a6:8390:b5d5%5]) with mapi id 15.20.4930.017; Thu, 27 Jan 2022 12:54:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 50c2904f-7f70-11ec-8f75-fffcc8bd4f1a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1643288090; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jUcJmN6jlKijIbl/I51T24eZTzV7QGvASK1sSh8ViyY=; b=A+KuYW8iqGwOJHZHd7L367ita9L/SVyqvcZ9bzXBUmY4wMyaE6kuDOdKmdsRyBye4LElDr 7Zh+FtCxDIGN6p/2TYFfjyOoO/IY+71g8L5EOkI2foweHsFli1OPPd4x7ysCEIRHuXMVcP zYbaz18b2L1gBQKFwv2E2MJsy/N09Y0= X-MC-Unique: DWnCEEcaMaWHZ0mTJJvaLw-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EeVpcIlHYW7TNNDudCUbIsw/IhFT2Uv9tYK5R+D9znWIc303GlwbYSCLEQhcj0bAOQFf++aAwZiAZEwExoPFzHCd5eUSBCnBVn6l2tbr9LAx+Ril07aesjycPY5RIrTIAV6Agn/VybM3IDja/ty5pRDMKm/Gr7M/uV3+ImqHf4hSYcZ8zSwxC+msN64bBpOSgTVntC91N4SB9Db5aR9QOYJZko4zDKSdq+5pWsduhIzu2S8msPgUmdxNy1vTn3cxt98HWX8mSfT5kY7Gw4CPNdTvQFy1oyqqebPZrjbp+uPvg8Jb5YMk3VpgxJeGGNMd00CGx0xD0amCBN/zTAgYNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jUcJmN6jlKijIbl/I51T24eZTzV7QGvASK1sSh8ViyY=; b=fyOybCQG1cvVgum08Qsv4R0fVSMvVehI8fHTwFoDQxZ4MaqZXvDCBzotXjIbefxI/UynxJaHW6ulAgnFdlbclW4nG9gBT17O184nngGf5MGlWBburuaHQD0xvv95t2VhIVpnZNbhLrknlNgT8YrqW8dT98r4Eja/v/3e4k8mIldWoGalR/0iCdN8FicTZdG87iBEELAP6FSArBV0IIzrQeo1U8SFAWiDqdi0PyVcOk+u7ftMJctbIPYwvGvsmPMQ3omGRwccQ7W+72GAOuZR8pMZzIgZfg+v0GE0mLldkFM3m6TCyPRXvwXT62uiJgQ1/+RSm2HcIyDHCWN72AeLyQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 27 Jan 2022 13:54:42 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 From: Jan Beulich Subject: [PATCH v3] x86/Intel: use CPUID bit to determine PPIN availability To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <64a5a3ac-8f4c-b13d-0b7d-4c4ec15e2721@suse.com> Content-Language: en-US In-Reply-To: <64a5a3ac-8f4c-b13d-0b7d-4c4ec15e2721@suse.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AS9PR06CA0344.eurprd06.prod.outlook.com (2603:10a6:20b:466::27) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 13418d3f-762e-4904-7993-08d9e194302f X-MS-TrafficTypeDiagnostic: AS1PR04MB9407:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: cchV9Fc/D+VWXkW7Eur2ysvRaHPSnyd+jftB2neeuE4IhrX60FhDfIa9ytB954y60iaWbb1pzPcH2Ro6vniVXgXVkvvdtZ5ZiqPVQOVWTi6aRuY4E0agDQxpxm0aqxwbyyOJwFPen0YdWhl25Q/x+uTSPyBVc07RbEBz8WnZqmxkdQ17KeMJjaF2QiD0z/3qwicoPl8Fj5eit7OWXfdQHNi5NIMg0jdyu54jNMzQ9k1nhKLp/GyIOskfLO6AqQq+GADuKhv9qiI3YyTO3+LMpMdj/me1yHOwihKXHcNrG4jWPyuLoHLZrcR5lQNooX0M6uW/+XY+ZIDPDRFoH1qC1jIdgwKj6KeqjriIHN1CmiXb+qlIDVdS1iGOubVSCErdKBLsf3WXSDTn5OAHgxDzDqr4zY8UDNWkTY6gCfRzIr5Vmmla7lVzS69SpEhxnTIF74jbwEhm08P3wb6GBhzdnr9ooo8ROuI5hglblEgmgEdBAMJtXurQwR0yLPenrzMLAJva7jLXlkkgvP1+6vOB+eIgVF6ep6xQrUbsS5R3IpA+un2Gux+PC+8Vj41NzsonKJCIY3iF0vxhMA4IA2bydvE8lBWzUe1UqtKfKhX+rLCV6ths1hyx9PnwcKpaJWL8sHJ9xWxmopp5KxtXRys/NribgCMeCusUdEH4J7FBEtVIDWULrrmO67a+1fdFO0tm0Z8awqQ5OpbcxQDBKORfGgIdOPTin2E1L1pnlzEVhsoqx+Cwz+J6cIOwIuVUUQJI X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(38100700002)(83380400001)(6506007)(2906002)(26005)(186003)(2616005)(6512007)(66946007)(66476007)(66556008)(31696002)(4326008)(8936002)(5660300002)(31686004)(8676002)(6486002)(508600001)(316002)(6916009)(86362001)(54906003)(36756003)(43740500002)(45980500001)(20210929001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R3gzMW1ybkpnODJhaFlnbi9rV0NtSDdmTHJwSGpyV3FmZlpxckpYcXNjMFFU?= =?utf-8?B?alhrMGdNWmY2Vk5ZM2pIQ09WMVVxalZVanFRS2s4dDdlVHdtb1E5UHp6MmVa?= =?utf-8?B?WDBSUnQzY1RQVy92ZzgxZFQ4bW0zNENlSm00cHptd0tOdzhtNGtuTnBBaDB5?= =?utf-8?B?eGJ1WnJVNkxxUWo3Z3FhT0QvQkNWQWF5ZUl0N3NUZGxsZUZpSVZpVHlQYUNk?= =?utf-8?B?bkljdWJCQ2x5TmtwUVpkZDR4QVUxQThGY2pwS1hKNUJjaGJnL0w0RDFGcjJB?= =?utf-8?B?VjhCT21GZUc2aGp5ZmNzdlVaSk1MRnVOWW5xVEpvdWNnblNHQzVlYzZ6NHFs?= =?utf-8?B?VVJzbTFhNjNwWDZPNWZmNVEzNU1TVFhNRytiWVh3ZWdQWFgxaFFGRHJ0NG9s?= =?utf-8?B?NlRuYWs1NmNZQlZ3cWZ4THQxMHZVVHh1ajJHdVRCZUVQYXhQcTlsMlBFeTBa?= =?utf-8?B?MnQ1THNTUC9WUUVEb243djJOS2hXUXoxdHk2L09TM05saHY5ZEZXSkcwYzUr?= =?utf-8?B?QVlHOVVISG00T1hRSEFVWEs1VmNPcE1vL2J5R0ZHaHBNd0Z3a1NmL1FxQlB6?= =?utf-8?B?VnlzUkZTb2hudmw4WUtvYjZQS2R3eWlOdHREdTBXZDVrUHpqbEduOVpRVkVo?= =?utf-8?B?ODExZU1QNy9TUWo2VEhFR3BJayt2UkUzcEx3VHBvd2d6V1dDUmMyVFV6OXFv?= =?utf-8?B?aHBmVmtUMGxVUlVCSnVVQnQ0NUlWRE9sUTZzQzh5dEt2Y3dGcjN6MHQrRTlV?= =?utf-8?B?RE5peC83bC9IdGJReE1ZVHJMZkxrMWdhSlJCT1JGWFdjOG82WTZWZlJtTWJQ?= =?utf-8?B?TjZLbGNsWkFzOHNCVWRxWStpanhCanJ6MW9OZW5udWFhQnRzeGJRNW9NZDFU?= =?utf-8?B?QjIzZmJ3VGhGUjFwdHlmR3hTcHlVQjhjT3dKeXg0enJ2V1Y3YXkwOFhySUcv?= =?utf-8?B?dDZRVEgvRkhWeWZxYXZFVGtvRitnRlRtdS9lRzY1aHBzY0dGZjFhbmZPS3pU?= =?utf-8?B?U2p0YklpTkxZL05LeTFzdXpJUzZjdE1BNmltODVwZ1h1NjZBQlJLRTdYS1Jo?= =?utf-8?B?bFladFBNR29EalRxTit3azdUQkFGU3JNV1Zza3d4MEMwZ0pMTm55U25PS0xm?= =?utf-8?B?bTRad2lCdDF6UldFeVRkU2lnbHp1MEdzSndhaDJJTDNzajErdEpwRW9weG9z?= =?utf-8?B?elZpV0NhM1lKZ3ZwWnQxUFlOd2NRbFBoTENHWFMzK0hjNWhibnZiRXZhQXFH?= =?utf-8?B?UzlQUDh6aFZvUVlRZ2NlRlA0S3phY2hpWTR1T3RoM0hSQ2JVdjdwN0xvOTR6?= =?utf-8?B?RG1zUHplME04Qmw5b3g1SXJJb0VJd3Rjd2FGeG1ET0NqTktGK296NTh3cWRy?= =?utf-8?B?YVJwVStIK2k4MmUxS3hNR09hUDNWR3laTDBzT1NBMVBsUSsvWXE1Wnk0bHJL?= =?utf-8?B?UHV1UktNdnkyVzAydzR6ZUlHVTVqdDhDZXJTTW5zbHgyVnBKTmZPNytnR3Fa?= =?utf-8?B?MGp2UlF4bEJRaTY4QmZzOFZURFAxOU5QOXQ2MDNuY0l5ZGlLTGRubzIzRGZD?= =?utf-8?B?aUoybHJmSWE2clNKRlF3dWF4UkVpR2FzaFU5Sy9TWjlEVlZmUGlNNWhqOGE4?= =?utf-8?B?SkEwWUlNdjBKT3dQalFMRWVMdzRVN05CZnhiYUpraXJWeEs4U3JBdjZMV2dJ?= =?utf-8?B?QjZjaTNST3lLSFZtbEhVMnJnc2t5dnFveVVHTGxvam5XNnkrZEpVc0hVZlRN?= =?utf-8?B?dDFlNURENWx5Zkk2R2tVanZ1S05DODAxRURTQUgyZWNYRXlCVm0vOVhGbHlk?= =?utf-8?B?ZzF5NHE3dHZUbGhmYWltU0E2eGd2ejlndjNtcmZyNXdkRTMwbEdNOTUrMEZ3?= =?utf-8?B?WktwRTZISUgrOUk0Z2VMNlpTT1ZiQ0tNN2ZPd3ZSd1FKd2FaVmhnQzJtL21O?= =?utf-8?B?V1NFa0t6N1E0Y24wVFAvaGswQS84MjVsay8rbDBTWlhQbWNBRFFTMXdaQjZU?= =?utf-8?B?anhGMTgwdGdpWitBZ3RpZDQ0OFZMSVV4Uy91cFBzcnpmSTBXM004MjRndUdC?= =?utf-8?B?MjN3MkdNZmIzTGZLTWZRZTE2ZDJHbHFqbkE2Mk1iR2RSVkQwUDVwTnNBQlVX?= =?utf-8?B?WXp5Ni93eUg4anRGM0gxSjhVS2F5SWZGM1hqajFYNVNtVFo5U0dQYm1DVThZ?= =?utf-8?Q?xICij7FRR2kVSXYaMA6sYpw=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 13418d3f-762e-4904-7993-08d9e194302f X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jan 2022 12:54:43.1025 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: EKYPJlMTQcDdVgcFGsuSZT0PhgIc5+lZndZ0GX0C8ec5sbhl1IzBunqzb1Vr6sXb0wVjY/+PA3wo/kvCm5FZMA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR04MB9407 X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1643288129133100001 Content-Type: text/plain; charset="utf-8" As of SDM revision 076 there is a CPUID bit for this functionality. Use it to amend the existing model-based logic. Signed-off-by: Jan Beulich --- It continues to be unclear for which CPU models, if any, the PPIN_CAP bit in PLATFORM_INFO could be used in favor of a model check. --- v3: Actually record CPUID[7:1].EBX. Adjust policy <-> feature conversion functions. v2: Don't rename AMD's identifier in xen-cpuid.c. Name Intel's just "ppin" as well. Move str_7b1[]. Update a comment. --- a/tools/misc/xen-cpuid.c +++ b/tools/misc/xen-cpuid.c @@ -195,6 +195,11 @@ static const char *const str_e21a[32] =3D [ 6] =3D "nscb", }; =20 +static const char *const str_7b1[32] =3D +{ + [ 0] =3D "ppin", +}; + static const struct { const char *name; const char *abbr; @@ -213,6 +218,7 @@ static const struct { { "0x00000007:0.edx", "7d0", str_7d0 }, { "0x00000007:1.eax", "7a1", str_7a1 }, { "0x80000021.eax", "e21a", str_e21a }, + { "0x00000007:1.ebx", "7b1", str_7b1 }, }; =20 #define COL_ALIGN "18" --- a/xen/arch/x86/cpu/common.c +++ b/xen/arch/x86/cpu/common.c @@ -445,7 +445,8 @@ static void generic_identify(struct cpui if (eax > 0) cpuid_count(0x00000007, 1, &c->x86_capability[cpufeat_word(X86_FEATURE_AVX512_BF16)], - &tmp, &tmp, &tmp); + &c->x86_capability[cpufeat_word(X86_FEATURE_INTEL_PPIN)], + &tmp, &tmp); } =20 if (c->cpuid_level >=3D 0xd) --- a/xen/arch/x86/cpu/mcheck/mce_intel.c +++ b/xen/arch/x86/cpu/mcheck/mce_intel.c @@ -859,12 +859,20 @@ static void intel_init_ppin(const struct /* * Even if testing the presence of the MSR would be enough, we don't * want to risk the situation where other models reuse this MSR for - * other purposes. + * other purposes. Despite the late addition of a CPUID bit (rendering + * the MSR architectural), keep using the same detection logic there. */ switch ( c->x86_model ) { uint64_t val; =20 + default: + if ( !cpu_has(c, X86_FEATURE_INTEL_PPIN) ) + { + ppin_msr =3D 0; + return; + } + fallthrough; case 0x3e: /* IvyBridge X */ case 0x3f: /* Haswell X */ case 0x4f: /* Broadwell X */ --- a/xen/include/public/arch-x86/cpufeatureset.h +++ b/xen/include/public/arch-x86/cpufeatureset.h @@ -299,6 +299,9 @@ XEN_CPUFEATURE(FSRCS, 10*32+12) / XEN_CPUFEATURE(LFENCE_DISPATCH, 11*32+ 2) /*A LFENCE always serializin= g */ XEN_CPUFEATURE(NSCB, 11*32+ 6) /*A Null Selector Clears Bas= e (and limit too) */ =20 +/* Intel-defined CPU features, CPUID level 0x00000007:1.ebx, word 12 */ +XEN_CPUFEATURE(INTEL_PPIN, 12*32+ 0) /* Protected Processor Inve= ntory Number */ + #endif /* XEN_CPUFEATURE */ =20 /* Clean up from a default include. Close the enum (for C). */ --- a/xen/include/xen/lib/x86/cpuid.h +++ b/xen/include/xen/lib/x86/cpuid.h @@ -16,6 +16,7 @@ #define FEATURESET_7d0 9 /* 0x00000007:0.edx */ #define FEATURESET_7a1 10 /* 0x00000007:1.eax */ #define FEATURESET_e21a 11 /* 0x80000021.eax */ +#define FEATURESET_7b1 12 /* 0x00000007:1.ebx */ =20 struct cpuid_leaf { @@ -188,6 +189,10 @@ struct cpuid_policy uint32_t _7a1; struct { DECL_BITFIELD(7a1); }; }; + union { + uint32_t _7b1; + struct { DECL_BITFIELD(7b1); }; + }; }; } feat; =20 @@ -327,6 +332,7 @@ static inline void cpuid_policy_to_featu fs[FEATURESET_7d0] =3D p->feat._7d0; fs[FEATURESET_7a1] =3D p->feat._7a1; fs[FEATURESET_e21a] =3D p->extd.e21a; + fs[FEATURESET_7b1] =3D p->feat._7b1; } =20 /* Fill in a CPUID policy from a featureset bitmap. */ @@ -345,6 +351,7 @@ static inline void cpuid_featureset_to_p p->feat._7d0 =3D fs[FEATURESET_7d0]; p->feat._7a1 =3D fs[FEATURESET_7a1]; p->extd.e21a =3D fs[FEATURESET_e21a]; + p->feat._7b1 =3D fs[FEATURESET_7b1]; } =20 static inline uint64_t cpuid_policy_xcr0_max(const struct cpuid_policy *p)