From nobody Sun Apr 5 16:32:51 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1774370200; cv=none; d=zohomail.com; s=zohoarc; b=IhEoPIWvbEr3HLF+EN0NMf79IzJLcBE9CO/a9uWYGasfMEWFTH4Iy3kCkF2nmTFHDyLs26JGzSfWgmzBxNc/Q/efY7Q1TZe5gFoVFWUmQDev3VS1UJa2g24TBwuCe/SJZk/F6IlcwSvEO4zBnEsYkr9F59QISdDH48XTIR5J+UA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1774370200; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=6ryDNV+LUR403GgrG/TR7em/GAAuhw03SibcyX6lEjQ=; b=nWjurIL6uujWC17BPdJB3Y6hgBBmMaYTqKvYXq7RsWPz5bep4Bfcdkd2E88CqcldmZo22Wu2cYk2HyD2Faq5rGpG516XIWfQWrVO9iLiGFLJejKL/Tdx16ezDKu+iaKZ8TAH8rJYWmgRZa9m5h5LnCNDu2enkX2rwlU2ZZEyA7g= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1774370200156597.6245011082314; Tue, 24 Mar 2026 09:36:40 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1261100.1554218 (Exim 4.92) (envelope-from ) id 1w54jx-0001Cg-Tz; Tue, 24 Mar 2026 16:36:25 +0000 Received: by outflank-mailman (output) from mailman id 1261100.1554218; Tue, 24 Mar 2026 16:36:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1w54jx-0001CZ-Qs; Tue, 24 Mar 2026 16:36:25 +0000 Received: by outflank-mailman (input) for mailman id 1261100; Tue, 24 Mar 2026 16:36:24 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1w54jw-0001CT-Tz for xen-devel@lists.xenproject.org; Tue, 24 Mar 2026 16:36:24 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1w54jw-009nzh-A0 for xen-devel@lists.xenproject.org; Tue, 24 Mar 2026 17:36:24 +0100 Received: from [10.42.69.7] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 69c2bd86-bab6-0a2a0a5309dd-0a2a45079c00-2 for ; Tue, 24 Mar 2026 17:36:24 +0100 Received: from [209.85.128.49] (helo=mail-wm1-f49.google.com) by tlsNG-ef75cf.mxtls.expurgate.net with ESMTPS (eXpurgate 4.55.2) (envelope-from ) id 69c2bd88-fd74-0a2a45070019-d1558031ac61-3 for ; Tue, 24 Mar 2026 17:36:24 +0100 Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-486fb439299so46432595e9.0 for ; Tue, 24 Mar 2026 09:36:24 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-487116f1905sm65404635e9.3.2026.03.24.09.36.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 Mar 2026 09:36:23 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:In-Reply-To:Autocrypt:Content-Language:References:Cc:To:From:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1774370184; x=1774974984; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=6ryDNV+LUR403GgrG/TR7em/GAAuhw03SibcyX6lEjQ=; b=OKvpbIpPyyTLISWKoFsPFDfzLa3B9eRS7e5K/S2QHq3wMZZ3QkcUvWOH2ghv5RAXCo mGa5UqJdxpzDMDhAQdUQgnafJ+xw5od1j2zfmGTpJBpHmFzEJg2/olt41iFysdhETWhr Plb3Yh2x4tT3Wfih3UYCCydrgsYGGqvILc5BvUGZBpW+AoaNwa7LTD26zDIcniutqZOz 5PxQzXQz6f40SmvCVQurOXbBTYkeuD9yaZhdLVdvkD650cl/4MO4WH/PX0+iQf6aGZMm 82vUz6gxUSOFXALazyUOgIv7FBF1V2+2uqwKNfwJ07AE1yNkZVLFTVXAPxTUO0BX/HRB ryIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774370184; x=1774974984; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=6ryDNV+LUR403GgrG/TR7em/GAAuhw03SibcyX6lEjQ=; b=XUveUEimMglX2OdwyhjSmdYv7Q1OoUROqB2NTu5eyZxAtUxpAqGj3pX8idjvsWaDgp SoJpnsIRGAlyvbzTZICaOLEGi1A2HdcqCvcLq/DTqIs2PoA5T2wiwiziYL8OVKc9MdHm +eFxvuByt60i2ByeXtbAe4H2hIN8EQ07dsv6EnhifWpTaZUQl19VjW/ppdirDOeEGovX C/amYQQdICdugS0PUvu2HTUllnc0Cx5gC+VjQByWwOX2BkpRswW5TJaC2EmNgzcrUYdi HFRBH6l4I6qejjOHgHw5x027dhH14t5YrIAPpw0u9vx/dmnNQihVE9k/ojPQ1mcyhwR1 x0mg== X-Gm-Message-State: AOJu0Yx2jPgTmd/2UwKwzMyCEx3X0pjo5XLOISb5jMMJQzE1/Iy6txu7 Rc7GFE+n/8mBv8tO9k3d1uLmjCUdeKDgBJC7y2veTOzfrJ6jgYfFP0ebcvUDG8Okvq8RNwjjQO3 vwoKZHg== X-Gm-Gg: ATEYQzwul3H+DFHJh2dU52L0S4srAcDNW88J7CGi2MMsPEoNfqln2IQv9E4w6dCz/u8 uJAQcOiBlN/ePh2jSSjAhOeRXbX4/x6dSFZgsFChCSf/Ur+Q83VmvKfftL7HPxzmpP0lZE6gKXw qVJ5t5KDl6mMtB4q9oB2lmSs/JREa/WNn8X2eRlKefEiD2Hz91k4EfvbBjUQI8CGrXjXbIFo6tR Y336zPYx490Ho1UCzcJGmlM4akmZJw+PTj/z+gd8ztatULiqzYiSOkfTphEfD2zQIr3kWMl918Z vRJy5ccxWxdxi3WddxAIuxnhMXFBKq0O2ZNhGwgBNh6aspYwKTFeJ7rA6tXzeG74Qn2M/PrKtva IS20fCclRtiR15hVRXEW8Cx5I3Ty4tfUPDGCUPPJZoz20sMDU1cgM1x2NJwd5JjRFa0IqV5cq07 NmYDGqsK4eHVbBXXEU7CCqiKe10lzzjh0N0gYCBnsRBh8C77AAF0KGhoMegCrxehPgPUd77soWo 3cLfg0hLQWY6HI= X-Received: by 2002:a05:600c:8b51:b0:485:3f41:e113 with SMTP id 5b1f17b1804b1-48715fc37a1mr6628225e9.1.1774370183608; Tue, 24 Mar 2026 09:36:23 -0700 (PDT) Message-ID: Date: Tue, 24 Mar 2026 17:36:22 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH 1/5] EFI: avoid OOB config file reads From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Marek Marczykowski , Daniel Smith , Kamil Frankowicz References: <63284ab7-8e38-4448-a789-1b9c23c4d95c@suse.com> Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <63284ab7-8e38-4448-a789-1b9c23c4d95c@suse.com> Content-Transfer-Encoding: quoted-printable X-purgate-ID: tlsNG-ef75cf/1774370184-562B1303-87F74F55/0/0 X-purgate-type: clean X-purgate-size: 725 X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1774370200760158500 Content-Type: text/plain; charset="utf-8" The message emitted by pre_parse() pretty clearly states the intention. Make sure we actually do so. Fixes: bf6501a62e80 ("x86-64: EFI boot code") Reported-by: Kamil Frankowicz Signed-off-by: Jan Beulich --- a/xen/common/efi/boot.c +++ b/xen/common/efi/boot.c @@ -907,8 +907,13 @@ static void __init pre_parse(const struc start =3D 0; } if ( file->size && end[-1] ) + { PrintStr(L"No newline at end of config file," " last line will be ignored.\r\n"); + + for ( UINTN pos =3D file->size; pos-- && *--end; ) + *end =3D 0; + } } =20 static void __init init_secure_boot_mode(void) From nobody Sun Apr 5 16:32:51 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1774370275; cv=none; d=zohomail.com; s=zohoarc; b=UxakcfLwam2xLTYix4vA538+9ts9fbUlKiOJ1Gs/57rN/rAbEzSigJTJspPQnH9DdFX6Yr4EoY02THbaxtvf3xWajUcSgrNDlKz6t/+Oov0KM8viCK24+KxVB3PA3YsNQrwrRf3fAGQkODzsOexL48TshJpw7UeFUPxnR9rkIm0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1774370275; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=XnNfB1/2AyY2UunH96rDhznb/JdhQ9aY7JCKKR0Fvo0=; b=Ltaxwuik0dJ5iZOt7W6yitX7R2VPBbMAfVijhdeisdsyenja6dI5BpVibclMrOuLmjQuR2gXImmSwr7yxUSi+Dt7l0ftkjg6OLSYepkfuKcYeVFNRoZaiL0LFpP3FEev3YKr2OOcEbggszBlK1IpIXcry2wmb1a+NCdYpzhUUAc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1774370275004556.0746678725102; Tue, 24 Mar 2026 09:37:55 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1261110.1554227 (Exim 4.92) (envelope-from ) id 1w54l9-0001ke-6d; Tue, 24 Mar 2026 16:37:39 +0000 Received: by outflank-mailman (output) from mailman id 1261110.1554227; Tue, 24 Mar 2026 16:37:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1w54l9-0001kX-3F; Tue, 24 Mar 2026 16:37:39 +0000 Received: by outflank-mailman (input) for mailman id 1261110; Tue, 24 Mar 2026 16:37:37 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1w54l7-0001kN-SS for xen-devel@lists.xenproject.org; Tue, 24 Mar 2026 16:37:37 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1w54l7-00BRGv-8M for xen-devel@lists.xenproject.org; Tue, 24 Mar 2026 17:37:37 +0100 Received: from [10.42.69.10] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 69c2bdb6-bab6-0a2a0a5309dd-0a2a450a8d16-38 for ; Tue, 24 Mar 2026 17:37:37 +0100 Received: from [209.85.221.50] (helo=mail-wr1-f50.google.com) by tlsNG-4011c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.55.2) (envelope-from ) id 69c2bdd1-1772-0a2a450a0019-d155dd32c58e-3 for ; Tue, 24 Mar 2026 17:37:37 +0100 Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-439b7c2788dso2683636f8f.1 for ; Tue, 24 Mar 2026 09:37:37 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43b64703c7fsm39269135f8f.23.2026.03.24.09.37.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 Mar 2026 09:37:36 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:In-Reply-To:Autocrypt:Content-Language:References:Cc:To:From:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1774370256; x=1774975056; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=XnNfB1/2AyY2UunH96rDhznb/JdhQ9aY7JCKKR0Fvo0=; b=ZQ8DTCrSwQv1HLQL4sChiMAn4CWS/WvlUz1ijtilZJL1hduUy0vPxEUPMrsrvqMBge GNod/sLm4Fpy0UQcSBRpkj0pKmI+DXeFTxN/d2BsQv0V2uASUBHYyMccvcEAMcfEw147 WfgLpBdC218mrADLDyBYnENx/eGcuB0SFAY3aRjYD+fR/0WKw78wbxsmfHJpzeeEP6je XVYrCUxoMTJkTR212BQgvanxOnPP2z2IPuEbbygPo2jw4d5FjJrR1WYvu0XAd9PZNgBt TTDLG7m++pXD1z4iJpcc/idAPah/vdDF0V3q4uLzb7l1bb1EDo4i3ovXA936ThPigyg7 NKhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774370256; x=1774975056; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=XnNfB1/2AyY2UunH96rDhznb/JdhQ9aY7JCKKR0Fvo0=; b=rI2kvSbZbRJFZNZThOatMhkqzooOxBSXfcFKprPodmCnchZINm3RC0866g0USjMQMT HhY/z96WYBWcsDQ5G31C6ThxiZRc+toSr+bX89mdzG2gtCarf2MMYKMQAHVHk/fHDc7u /INYwYUSl4qnpaXAivENbOEuJ2q2yv4C/CWqUuU47LE+m54soHd4acBVjwPTBupZn3M/ xzx8XHm/beM93MXdnR4C8BbfTii6fQOnOlXR7tVZJOXgiSDIUCrHe/RbxBQj11oSQSMy LSoWznqrNG3o18GTr9HX4J9+CtV8HxT5e+fMuQecnWjHsCEaEvoZR/Hkbx3/lYyZfugF BPbA== X-Gm-Message-State: AOJu0YxPAspzVx/fjC8K+hdM81H39kvAqkwvTU6MQ5l1JkPCtvP9tea5 E2nWxoBh7105SxwwXge01NE7NcfTSkaSvyiQoa/bpZhcH6sqXBZDdm1P+pzDujf5eGdRWjTZcl5 2FTBidg== X-Gm-Gg: ATEYQzyvsn7JHGQtU9e0KBmjhX91S2Zr5RwPYTY3sBrBsCl+KGL0FKGK0H86ewlLqIW OcLW9rObJAErpB685fEuuJO5d3aqyQn3p10mK2veGnTGycKERWjTNGUp8Y2nw+jp24/53Xfdb8+ wB77TnSJhqHXbnjPOPgVTC+DRT8tuRNWzaRWHVjDZIp3ditY6GmSfa0DVGjMrJ9jXHIPjzfGuwq Ago3QwSH4RiHh48IjcNGMYN3E+c3h3XLHmAfsd763roh0HcmF8ECI80GbqUG4NOb5naK/AAV8Cp cjxr2FRw8BjCxSQC7R170UfnGnW2iGc3mFjBMkG/+6VNLIWj/yXgIZXDqFsH//O5Ek7oszatd3Y D3IVZo2iSZ+vjs2kOuLpQmazvoTrl6drYS+s1Eugvqzd9B1qKkaLvAcuVYzcRWoh5EymFv327CK qghCaD9Z22zl8QlEMoPiKzeWkpbxjCK7q7cf9wzP8IhN9R3Dr7L4s50jJJve2piQwETv7x8CXtu F7kfkiGmrpOoRVuBuJeO6xFhA== X-Received: by 2002:a05:6000:26c3:b0:43b:42af:75b with SMTP id ffacd0b85a97d-43b88a3a379mr178235f8f.55.1774370256476; Tue, 24 Mar 2026 09:37:36 -0700 (PDT) Message-ID: <97d6ba6c-4ffe-4e1b-814a-d51a0bcf363e@suse.com> Date: Tue, 24 Mar 2026 17:37:35 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH 2/5] llc-coloring: improve checking while parsing From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Julien Grall , Stefano Stabellini , Anthony PERARD , Michal Orzel , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Kamil Frankowicz References: <63284ab7-8e38-4448-a789-1b9c23c4d95c@suse.com> Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <63284ab7-8e38-4448-a789-1b9c23c4d95c@suse.com> Content-Transfer-Encoding: quoted-printable X-purgate-ID: tlsNG-4011c0/1774370257-BFE9D900-DD563593/0/0 X-purgate-type: clean X-purgate-size: 1151 X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1774370276876158500 Content-Type: text/plain; charset="utf-8" We can easily avoid the risk of wrapping UINT_MAX <-> 0 by applying a check against the compile-time-constant maximum number of colors. Additionally the overflow checks suffered from an off-by-1, as the parsed ranges are inclusive (e.g. end =3D=3D start being possible, requiring 1 arr= ay slot, while availability of 0 slots was checked in that case). Fixes: 6cdea3444eaf ("xen/arm: add Dom0 cache coloring support") Reported-by: Kamil Frankowicz Signed-off-by: Jan Beulich --- a/xen/common/llc-coloring.c +++ b/xen/common/llc-coloring.c @@ -76,8 +76,9 @@ static int __init parse_color_config(con else /* Single value */ end =3D start; =20 - if ( start > end || (end - start) > (UINT_MAX - *num_colors) || - (*num_colors + (end - start)) >=3D max_num_colors ) + if ( end >=3D NR_LLC_COLORS || start > end || + (end - start) >=3D (UINT_MAX - *num_colors) || + (*num_colors + (end - start + 1)) >=3D max_num_colors ) return -EINVAL; =20 /* Colors are range checked in check_colors() */ From nobody Sun Apr 5 16:32:51 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1774370302; cv=none; d=zohomail.com; s=zohoarc; b=cUc2INe1NL/IqbOs4CQlsRrx5xyk3K5ZEk5UMb4BWR5A+9kWyLY8pw27BG2DgC1TzPmLSBmgDBFCThCFqHMocGXJkELRZeX5Xul8oOW65WISve1ETQNq4iZXUwga1wKQSy87NqELwcd5MyjN8ihPco06Tzj7HvLpffAMF7Zz4D8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1774370302; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=xSea3csxQK27kPKZBEWvJfLuReO04l6n0dzZu3l9za4=; b=cUn07ENTijNyltlyJHK6jkSuWCzLYe6FrtstDu9mT0rzFKVE1680CByOz8Y6hSt8HWJV0vUbvUjzaRAGBYJQdI3CVF5Be0qUHEi2ptHlxwrxhn2gnKGjClZIwU+5uKhzK0IxaPbkss/TymxSYnKXJEcvleLtz9Vi7bC5m19rAxg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1774370302327869.2413590179227; Tue, 24 Mar 2026 09:38:22 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1261117.1554236 (Exim 4.92) (envelope-from ) id 1w54le-0002Kk-DQ; Tue, 24 Mar 2026 16:38:10 +0000 Received: by outflank-mailman (output) from mailman id 1261117.1554236; Tue, 24 Mar 2026 16:38:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1w54le-0002Kd-Aj; Tue, 24 Mar 2026 16:38:10 +0000 Received: by outflank-mailman (input) for mailman id 1261117; Tue, 24 Mar 2026 16:38:09 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1w54ld-0002KT-5K for xen-devel@lists.xenproject.org; Tue, 24 Mar 2026 16:38:09 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1w54lc-002tLY-HE for xen-devel@lists.xenproject.org; Tue, 24 Mar 2026 17:38:08 +0100 Received: from [10.42.69.1] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 69c2bdd6-e002-0a2a0a5209dd-0a2a4501d79a-44 for ; Tue, 24 Mar 2026 17:38:08 +0100 Received: from [209.85.221.45] (helo=mail-wr1-f45.google.com) by tlsNG-d62444.mxtls.expurgate.net with ESMTPS (eXpurgate 4.55.2) (envelope-from ) id 69c2bdf0-6400-0a2a45010019-d155dd2dc40c-3 for ; Tue, 24 Mar 2026 17:38:08 +0100 Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-43b4f48c47cso3012782f8f.0 for ; Tue, 24 Mar 2026 09:38:08 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43b644bd0dcsm38781283f8f.11.2026.03.24.09.38.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 Mar 2026 09:38:07 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:In-Reply-To:Autocrypt:Content-Language:References:Cc:To:From:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1774370288; x=1774975088; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=xSea3csxQK27kPKZBEWvJfLuReO04l6n0dzZu3l9za4=; b=STgvz5zz0blYFZ6IjCfecpjZQWGK4DDQOdSYLZhqP2+x9fWI8OoJ7Eg0sBQMc3MEBM XtNfMMd4J2VrrL+r7IjcXUewsoss8JhN6sX4QkPjPTKKwokB7PWPM+xHiJlVhXPH11FG 2zBh5E+zRX6+0tC4EHTgZ0FZ6eaSNYf6A30y/L0Ubx8zyNB8qZOqassb40qfB3jGsCNU sjPecOHhjUq/oXnMDs1TQYv0KuX/cx4ej5owuPZTi8JNzWhuejS6D+1I2+4EMlubjs5L wVOdWIldeHAF+8/g6Eq/slyqIeGexCwvvhEL7AKzBJ41fOTtWWN2ZSzm2o8UmtVAM7UP kIGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774370288; x=1774975088; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=xSea3csxQK27kPKZBEWvJfLuReO04l6n0dzZu3l9za4=; b=IJRzvvYMG8Vb8bqO/TXqeaI+RjMep7pHABCCp7H5Nh8wQc+MoRK/W+qJqTDdaHSqrb uoLzCQuLkmiw0YbDfk1eRN2DwX98hVOD7etV6zJ85qOMI3+apo5h9aHKEwb242gu6tPq cs3Nv7QxWuwbrU1jgWSMECpUmwjQuY+CLqqjPqx5q5Z2aiIdFXTzR0FHH3l0EUL0eLYs mb4VPt4HGerCcV3yLxg0oBzW5zx2NrR3chAnGcuBY67J6C6+W2NG6SZQONT7HD0vw0ni yT7qn/yMqRxiaaIwqsuTSmf4yoOYr2Tg7AKHhIbaxYV6cYK+K2ZTBsmV2RWBFpCHKbNE 2veQ== X-Gm-Message-State: AOJu0YzU/4nUmsgAvJU31uoOgirzZyxPjBvq+m+F6NOEQwmcuoFQzcgu xZkRWfGZw4WxQuMyW2n2RQELCpGo6oN2quCbzj+IKBok/h0fDCYi5EKjhVXDDouLf/HHv4jtJ52 Uu2D3pw== X-Gm-Gg: ATEYQzyrJ1Z8NkTHkgr59YiAn+CQswvrU5RI4Bal1AXqcnxfwEavpDE+WtezfsqkXxc i1/H2y1C5tClK5VNJKZAlnLlhFJ4wRItxcCXYWl/SHzywwL1N1Q2dR5XfthURTldw6USREJlL4x OgrVvKtUn5hYEXMQJuoTreHkk+NT54OCrghRhsQCZt8FbjPjn8MlZXfQS+KY1mc0ufgI671vL/k oVb8PFk86OPfF/awvDLp2eH7/KCFsKic4SlnZM+0/iPELGAblkUMtH1LA7fKEGQg9AYKW6GrI+W 8rDv6wIxG5OGw3EfwOnhVEhrTprAJKlrdbcTSRj5IqLsHNO5X8QLpU1Aw2RB1o3nkjWYPb7E3X3 Md4auWmzEjjD2Tb1z5/lcGnR+na2eEXSWExjknPOpKFIS9Y5fja7aIpYHS+bYovTFF7QSlRmVkk Du6AuzVvR32TSrBnW5I/aYhTNbkwpbZSdQQDRUMEAWe70kKMic8u8rROe/ZN0eP/+ZS+lSRVAt5 uET+GrjQs1b9rI= X-Received: by 2002:a05:6000:2dc7:b0:439:b6d6:723 with SMTP id ffacd0b85a97d-43b88a1bcc5mr226529f8f.42.1774370287775; Tue, 24 Mar 2026 09:38:07 -0700 (PDT) Message-ID: <66135036-b516-4665-b875-996456a34640@suse.com> Date: Tue, 24 Mar 2026 17:38:06 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH 3/5] ns16550: harden name/value pair parsing From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Julien Grall , Stefano Stabellini , Anthony PERARD , Michal Orzel , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Kamil Frankowicz References: <63284ab7-8e38-4448-a789-1b9c23c4d95c@suse.com> Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <63284ab7-8e38-4448-a789-1b9c23c4d95c@suse.com> Content-Transfer-Encoding: quoted-printable X-purgate-ID: tlsNG-d62444/1774370288-48E12DF3-01D664D8/0/0 X-purgate-type: clean X-purgate-size: 957 X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1774370303015158500 Content-Type: text/plain; charset="utf-8" strsep(), unless passed a 1st argument which itself points at a NULL pointer, won't return NULL. Instead if the separator(s) looked for isn't found, that pointed-to field would be updated to hold NULL. Hence the important check in get_token() is for token to be non-NULL after the call (which get_token()'s callers rely upon), while the checking of param_name is left there just in case. Fixes: 97fd49a7e074 ("ns16550: add support for UART parameters to be specif= ed with name-value pairs") Reported-by: Kamil Frankowicz Signed-off-by: Jan Beulich --- a/xen/drivers/char/ns16550.c +++ b/xen/drivers/char/ns16550.c @@ -1466,7 +1466,7 @@ static enum __init serial_param_type get unsigned int i; =20 param_name =3D strsep(&token, "=3D"); - if ( param_name =3D=3D NULL ) + if ( !param_name || !token ) return num_serial_params; =20 /* Linear search for the parameter. */ From nobody Sun Apr 5 16:32:51 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1774370343; cv=none; d=zohomail.com; s=zohoarc; b=OxXHmZlUigY+ozKwQwFWe3mdVEa1qmWyaJ+7pgEFacK0mu/LIU1mMD+F5/mR+asqA6WGvtuLasqnAheXb+0QrIwk5byq6+WoAkJ4LgU604otHPMEyuQ5BHgFudxiK4J6CfxuILUuaG7stoo2FMUpvI2hNpAI7j3LIRuz2A7PCJc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1774370343; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=PYk9vEEfGRYDleF6fCoNLGed2AL29CgD3kCqdLh6Eqg=; b=Op9G+lCmCQgQdrBSUDdO37VH3EIyaYlHEhKSx53HFfonNTr6WJ7yVjCHrY9eZTf5zrh+qgE37mNGF9Ms65wswePvhshvKhV02XHLkrKbnnHuX5qDiN4U2lXr8Khhrm/wKOZZYj4756HWvKKJQpEW8FSUFrdWLoB5AzpVQE57048= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1774370343519616.7769159075215; Tue, 24 Mar 2026 09:39:03 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1261126.1554246 (Exim 4.92) (envelope-from ) id 1w54mE-0002v0-PH; Tue, 24 Mar 2026 16:38:46 +0000 Received: by outflank-mailman (output) from mailman id 1261126.1554246; Tue, 24 Mar 2026 16:38:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1w54mE-0002us-LI; Tue, 24 Mar 2026 16:38:46 +0000 Received: by outflank-mailman (input) for mailman id 1261126; Tue, 24 Mar 2026 16:38:45 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1w54mD-0002ug-Md for xen-devel@lists.xenproject.org; Tue, 24 Mar 2026 16:38:45 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1w54mC-001q6T-UB for xen-devel@lists.xenproject.org; Tue, 24 Mar 2026 17:38:44 +0100 Received: from [10.42.69.3] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 69c2bdf6-2eae-0a2a0a5409dd-0a2a4503ba16-48 for ; Tue, 24 Mar 2026 17:38:44 +0100 Received: from [209.85.128.53] (helo=mail-wm1-f53.google.com) by tlsNG-33051d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.55.2) (envelope-from ) id 69c2be14-1947-0a2a45030019-d1558035bd03-3 for ; Tue, 24 Mar 2026 17:38:44 +0100 Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-486ff201041so36507355e9.1 for ; Tue, 24 Mar 2026 09:38:44 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48716549160sm905435e9.3.2026.03.24.09.38.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 Mar 2026 09:38:44 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:In-Reply-To:Autocrypt:Content-Language:References:Cc:To:From:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1774370324; x=1774975124; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=PYk9vEEfGRYDleF6fCoNLGed2AL29CgD3kCqdLh6Eqg=; b=Ka25E67T5QSaxqUuPbGBjeu4LGthhVk0aCnO6VyrZLOYoPKDSudDTzOzMpbYGz24mu zhaNupCEpVzx9MSzzNxTs3EPW7YsgnGPRqRglJ3Xu+fyp3bK/jmhdi5el98Erd8CcWFv YOB6nVxrMoyKAG2pofO8gTJtAD+u0Tveul9ovVf5mXd9yAMV4djGi2TYNCMYh8UfNXNu MiLAWPO3KrYGkAHWA39SmkzqiItWumFW7aBilLcF+8rhja8gRmjWBBC2jsWkr7UsnwgO ZJ/Axj5FsBmjvNmqjuHeNPR3VQp1zZDJKt2OTzc6uMf2wV2FDvjjAmhTCIz6XXI2zAVw wEZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774370324; x=1774975124; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=PYk9vEEfGRYDleF6fCoNLGed2AL29CgD3kCqdLh6Eqg=; b=TuD7FuHXKttKC7b+pt5B8+M1976NM87J7cjwgVFXmc6FdiFb/pktDzf+siwm6WOcqe Z4x+pBXhghljn92+OwyhpfErWsAPtt9YFJiYwBNxNfSHDYnn3zrfLk0PmjT7dwrKmR7u EWjpPOyx+3sxppO1jstRY1IdVEmNVFq5oRq7akBornwLBT8hGnGDtvY+66VK8VFcLN5I oKtk0Ml8pNCxx1mUzn26Qf4QviQJO3QYWnXJ7lFpjSCUvAvqhgku2zFCUd2C7hCJAVQF 0n/P3EKY4N3as6LAfhRb/LuDTONhq0l70JcJxxZGM1m4xiqFOAon6C36pk9t3R8JpxzP IFfw== X-Gm-Message-State: AOJu0YwUHVhwMWr6s/u66ULOsWFjdHQoikKTl96ax5CQAOBjHYD7l0Np fh5gSG5zbNPgP7vNmrAGzT68Trc/71B/AlPAD9PVzwszmM95SulUo3VsvFQgZbPAetZ8JVjeNgk tkzMOGw== X-Gm-Gg: ATEYQzzHM3/OKU41WtfPAfCnz+nhCX1TpPLuMGI6iAEkrXzvPsTnO4l2wHZO241hcHB aRllZ/NKwTQPq2qf0yHK8iDyl2yp8XQzIeqKjFtnuIvcZ5gYzAh1B5hGhLbRlpN2IgFBGMBHIDl 0H2XBCKrCeH26jf35ogqn+VlI4r3h8hJTd1F17KdFTEVzhsA0hrkAhR2IQIXo24P2T5KkRkzB8D 8n+Xkf2+P7bA2nWN5ZWtfHHQESLSIRvy/N08acptKJqDuyJyRjNaAGD5aulTZp3bVPmrdlF0eED ViRu1Q1TZrhjOzZWTffpxU2+UAHBpJV0WyOqHxXas35v62fAVtIFZnmQLxT0vaQqPZReaH9ArgF YfnoCyUZwTDIg9xpT6Hb4YFH2hQvy5GPpsBW59Eq/DevRdJg+1mZx/cqV+Pc4PgPbUaGtpGIKSn SErnpWAvDndF5ylAXHLx3E1+Tivlp7/dr58XYi+eU8Qf2jUQzUHYciFpo248xdGghoFu3qVd007 z4Grh1SJeDz5DOMNXAwgDZDRQ== X-Received: by 2002:a05:600c:8886:b0:480:4a8f:2d5c with SMTP id 5b1f17b1804b1-4871606dd88mr4297395e9.29.1774370324272; Tue, 24 Mar 2026 09:38:44 -0700 (PDT) Message-ID: Date: Tue, 24 Mar 2026 17:38:42 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH 4/5] ns16550: harden positional parsing From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Julien Grall , Stefano Stabellini , Anthony PERARD , Michal Orzel , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Kamil Frankowicz References: <63284ab7-8e38-4448-a789-1b9c23c4d95c@suse.com> Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <63284ab7-8e38-4448-a789-1b9c23c4d95c@suse.com> Content-Transfer-Encoding: quoted-printable X-purgate-ID: tlsNG-33051d/1774370324-4866F72C-FF9CEDF9/0/0 X-purgate-type: clean X-purgate-size: 706 X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1774370345373158500 Content-Type: text/plain; charset="utf-8" Advancing past a character without knowing whether that's the NUL char is at risk of reading beyond the buffer. Fixes: 25de1f692059 ("Allow arch-specific defaults to be specified for ns16= 550") Reported-by: Kamil Frankowicz Signed-off-by: Jan Beulich --- a/xen/drivers/char/ns16550.c +++ b/xen/drivers/char/ns16550.c @@ -1541,6 +1541,9 @@ static bool __init parse_positional(stru { uart->data_bits =3D simple_strtoul(conf, &conf, 10); =20 + if ( !*conf ) + PARSE_ERR_RET("bad DPS setting"); + uart->parity =3D parse_parity_char(*conf); =20 uart->stop_bits =3D simple_strtoul(conf + 1, &conf, 10); From nobody Sun Apr 5 16:32:51 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1774370372; cv=none; d=zohomail.com; s=zohoarc; b=NzEO35GbG0Ew6xtfkXu35+S+Bx6U14/riu4GxoudY0WiCaL1z775skr+BzOUXyV1H89mYBcXoIpwVgRZulMrYd3I6PVGxhtM3nAW3CbHulpqvHXaeyFX8MOwV38YjlKLtLTpSd81JGwmqYW8OuVXIbQvjj5Xsz8ecLTyzcuXCMc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1774370372; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=56tWNbz8qa5QLyK5OKVcFjuIr6ITFbD/4bSejjAPp80=; b=Lg7m/x1KlIbiGWKuqKdZJCYzC+QoJYaw2/PCIJj62rL/TKR9Qj4VC9RIwZpnq/5PKdv3Cfo05TD73fVPDZie7WK7bzMYnKvYVkii4itIMemy50gu2Gnu7uzJgLIHy/yc0PB/UBhNSBvXzdnnBGGTCCOCoq4zrcNp41J/UNct3Ek= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1774370372166504.6026901780142; Tue, 24 Mar 2026 09:39:32 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1261137.1554253 (Exim 4.92) (envelope-from ) id 1w54mi-0003Nx-Vg; Tue, 24 Mar 2026 16:39:16 +0000 Received: by outflank-mailman (output) from mailman id 1261137.1554253; Tue, 24 Mar 2026 16:39:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1w54mi-0003Nq-T9; Tue, 24 Mar 2026 16:39:16 +0000 Received: by outflank-mailman (input) for mailman id 1261137; Tue, 24 Mar 2026 16:39:15 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1w54mh-0003Ni-TF for xen-devel@lists.xenproject.org; Tue, 24 Mar 2026 16:39:15 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1w54mf-009iyf-NS for xen-devel@lists.xenproject.org; Tue, 24 Mar 2026 17:39:15 +0100 Received: from [10.42.69.8] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 69c2be2a-e002-0a2a0a5209dd-0a2a4508cf38-38 for ; Tue, 24 Mar 2026 17:39:15 +0100 Received: from [209.85.128.53] (helo=mail-wm1-f53.google.com) by tlsNG-c1860d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.55.2) (envelope-from ) id 69c2be32-1950-0a2a45080019-d1558035e044-3 for ; Tue, 24 Mar 2026 17:39:15 +0100 Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-486b96760easo13743175e9.2 for ; Tue, 24 Mar 2026 09:39:15 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48711702191sm58742875e9.5.2026.03.24.09.39.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 Mar 2026 09:39:13 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:In-Reply-To:Autocrypt:Content-Language:References:Cc:To:From:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1774370354; x=1774975154; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=56tWNbz8qa5QLyK5OKVcFjuIr6ITFbD/4bSejjAPp80=; b=Gd47qZhOYNt8HfYvSq6KUOb+12F0jwrTNQkNwzlaUmKKRFmiCtDW3kxZRU9mTv8CkK qB4Z80IX30974QgX2dW5dTX3PjAp26SWuSV4YRCUaq0wuUeTsprSmGRJgvuy1hDIE8Gt bOWLZEHBFYRBw78fDKPbdtG3Uny/WNsKwISSmJuzQCnlMuv0nWGElyoPV1wuVfv7iUXl RZR786bdVrBHXOR2XTVwTnlSLMcDAYkcfFZRkF018rSSzGLR7ytPY8AKT0eifLSzdINC eN4K7GCKL7y8mZ1+0/LR8lunh1PkQ4RFEafcF18sguiLnlEQK4X7x025AGCaJxmYdwZd UrIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774370354; x=1774975154; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=56tWNbz8qa5QLyK5OKVcFjuIr6ITFbD/4bSejjAPp80=; b=J2SUoWrg0RE54/BH7wgjOz+XCwq2LZArJECeY7cFj488BYxldkmPDTbW/Ky2kagxRu TxX313c/afQJVdg1hiqjHgOlWtOzi1I1pQTf2paQCKPicIxf6QSaN1TPCgYAxJvLXx6N foZJOd0AaiQAjVIH43tnhcLl/rnantggCbtPOWxj+wl9PoqvrmpUyRKq3aBykBs3DESM rgPqbPbJweXb5E2/FcP42nUeoSz5U29WE1yK9uu1txiFJVQETZ1qovjD1w9/4RmVYw3d N/y6UlSHuSlUaLp/L0X+1gNORSSOkBVnKMcZfiQKu5wc3LC/vCHwtor2gpa+vHmUPTCY oxXg== X-Gm-Message-State: AOJu0YzkC+y2G+2qhA77zw4vRWFkKkEu09icrpwGxK30eK5LGvp61K26 9ceoFEkD2W2tsfo/2cwDWq4s3MVTPOFChJ+2HiQ7Udg6Td3Pa9HuJm8y2b5um110fEKas/sJTeZ V9LS8Dg== X-Gm-Gg: ATEYQzzZR0W/vK2iGi8sSGO0c1StkrkGqef9Wgx6zoDmoBLufsV72ZCpRamgTnPUFQH Dtvate+Dr/QVWt3xj7pAGh1lJpiKMRXuBdkGMdGvLvDkL7Er5wC7VOEYoB8kQ4Ft/XYfdNxjw29 kdbEBV03US/xm/zB8+PHZAfHqt4XUerK6tg0diTCqTJy82siiHTflw+JDzwamAJ7VwDN2hTCcjT /woVPuH8R88qcF+AKG8Dh5+D9ie2mU1Ler2i6JICn5pLjcTnHVu5kG0HCNgCeUAxyCyfZooW9jt rXTPq5aSiLu2hIVQ1k1Itrha0oSYlSsgnZaurgCg0pSeMpt25x7yZ94ZyF/oAf4SVgKRJ9geBBK DJRsEkZzoX4xIk3LDscIVcaTaZUf1p98gWIu5WInr9+778vkwtVNx3aszXEl8Wdacm+zd+VJ1g9 pnHk0Zg7tBS3DQt0cy6F8QWVZvsxC0uMUfvqxjwmg7JNfuctk6sN7wb84UzQF+buPghAqb5xTIw ZkJVQEQgn6Wk0c= X-Received: by 2002:a05:600c:8b31:b0:485:30f7:6e88 with SMTP id 5b1f17b1804b1-487160881a5mr6352565e9.31.1774370354351; Tue, 24 Mar 2026 09:39:14 -0700 (PDT) Message-ID: <5e8b4faa-5540-4406-8706-d546e3d2c46b@suse.com> Date: Tue, 24 Mar 2026 17:39:12 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH 5/5] video/vesa: harden font height parsing From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Julien Grall , Stefano Stabellini , Anthony PERARD , Michal Orzel , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Kamil Frankowicz References: <63284ab7-8e38-4448-a789-1b9c23c4d95c@suse.com> Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <63284ab7-8e38-4448-a789-1b9c23c4d95c@suse.com> Content-Transfer-Encoding: quoted-printable X-purgate-ID: tlsNG-c1860d/1774370355-F1CE2726-B768BCF5/0/0 X-purgate-type: clean X-purgate-size: 810 X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1774370375371158500 Content-Type: text/plain; charset="utf-8" We should not prematurely increment the pointer, to avoid inadvertently skipping the NUL terminator. Fixes: 6d9199bd0f22 ("x86-64: enable hypervisor output on VESA frame buffer= ") Reported-by: Kamil Frankowicz Signed-off-by: Jan Beulich --- a/xen/drivers/video/vesa.c +++ b/xen/drivers/video/vesa.c @@ -31,8 +31,8 @@ static unsigned int __initdata vram_rema static unsigned int __initdata font_height; static int __init cf_check parse_font_height(const char *s) { - if ( simple_strtoul(s, &s, 10) =3D=3D 8 && (*s++ =3D=3D 'x') ) - font_height =3D simple_strtoul(s, &s, 10); + if ( simple_strtoul(s, &s, 10) =3D=3D 8 && (*s =3D=3D 'x') ) + font_height =3D simple_strtoul(s + 1, &s, 10); if ( *s !=3D '\0' ) font_height =3D 0;