From nobody Mon Feb 9 14:50:14 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1619016984; cv=none; d=zohomail.com; s=zohoarc; b=AI2j+XUh10y0mJvkHmxaRHmzofI9ZwZDZWeebYif5dVhhcVwjaYkkrxubGlnJGWfMkNiMInnG95rn904sM/FUFWyDd/6YSL+ACgMkG0098nP/xJBtnADtHV2FkSwhc5P7qm3puxZf3iYRzvmzTUWOzLhsto2fbNN6/EGExDhfZ0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1619016984; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=dn8xizhAj6dt285tHoUKq6uKJm2JGhL8Ej0gFCwHguo=; b=nsLdSdO1td+P4cabdy27Jy+r2AVoPmqPkKuP1tOpfQCfBN+u7DtQBV3Xr9lJizqFP1lXcNppuImaDimwUhcci5V9gmJvIIV7gopJreKr6W5hjCTJu+0uDFiXsoMjmzr/o1Jb3xTXNImM3P2Fp1+j2OpmOsePJc13cEJXRJXWUYw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) header.from= Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 161901698484859.413285995218644; Wed, 21 Apr 2021 07:56:24 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.114783.218794 (Exim 4.92) (envelope-from ) id 1lZEGs-0007qo-So; Wed, 21 Apr 2021 14:56:06 +0000 Received: by outflank-mailman (output) from mailman id 114783.218794; Wed, 21 Apr 2021 14:56:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lZEGs-0007qh-Pc; Wed, 21 Apr 2021 14:56:06 +0000 Received: by outflank-mailman (input) for mailman id 114783; Wed, 21 Apr 2021 14:56:05 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lZEGr-0007qX-K6 for xen-devel@lists.xenproject.org; Wed, 21 Apr 2021 14:56:05 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id a8511cc5-5931-4b24-a74b-bace21e8a439; Wed, 21 Apr 2021 14:56:04 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id DB6ACB4D6; Wed, 21 Apr 2021 14:56:03 +0000 (UTC) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a8511cc5-5931-4b24-a74b-bace21e8a439 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1619016964; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dn8xizhAj6dt285tHoUKq6uKJm2JGhL8Ej0gFCwHguo=; b=MFnylNO45EvnvRMzxksM5Fj45ojdxak99ir226m0Ju+/3yvh6yz0UsCVdKEE6fcy3yRZ76 /rJNBrC4FS+iqh2KstFVCIJ4jY8H4wsTijEUAp9XmnKJujciIV6ZeZxvWxzzGYAF/xdxqt HbhqV09TBt5LgFr+8NrCfib/zBiaePw= Subject: [PATCH v2 1/8] x86/MCE: avoid effectively open-coding xmalloc_array() From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <091b4b91-712f-3526-78d1-80d31faf8e41@suse.com> Message-ID: <631d4b11-cfc5-c609-6169-28ba08aa978c@suse.com> Date: Wed, 21 Apr 2021 16:56:03 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: <091b4b91-712f-3526-78d1-80d31faf8e41@suse.com> Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @suse.com) Content-Type: text/plain; charset="utf-8" There is a difference in generated code: xmalloc_bytes() forces SMP_CACHE_BYTES alignment. But if code really cared about such higher than default alignment, it should request so explicitly rather than using a type-unsafe interface. And if e.g. cache line sharing was a concern, the allocator itself should arrange to avoid such. Signed-off-by: Jan Beulich --- a/xen/arch/x86/cpu/mcheck/mctelem.c +++ b/xen/arch/x86/cpu/mcheck/mctelem.c @@ -345,7 +345,7 @@ void __init mctelem_init(unsigned int da =20 if ((mctctl.mctc_elems =3D xmalloc_array(struct mctelem_ent, MC_NENT)) =3D=3D NULL || - (datarr =3D xmalloc_bytes(MC_NENT * datasz)) =3D=3D NULL) { + (datarr =3D xmalloc_array(char, MC_NENT * datasz)) =3D=3D NULL) { xfree(mctctl.mctc_elems); printk("Allocations for MCA telemetry failed\n"); return;