From nobody Wed Nov 27 22:31:09 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 169045478052522.642477797876268; Thu, 27 Jul 2023 03:46:20 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.571001.893768 (Exim 4.92) (envelope-from ) id 1qOyVM-0005uf-MB; Thu, 27 Jul 2023 10:46:00 +0000 Received: by outflank-mailman (output) from mailman id 571001.893768; Thu, 27 Jul 2023 10:46:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qOyVM-0005uY-Jh; Thu, 27 Jul 2023 10:46:00 +0000 Received: by outflank-mailman (input) for mailman id 571001; Thu, 27 Jul 2023 10:45:59 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qOyVL-0005uQ-Oo for xen-devel@lists.xenproject.org; Thu, 27 Jul 2023 10:45:59 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c42f73ef-2c6a-11ee-8613-37d641c3527e; Thu, 27 Jul 2023 12:45:57 +0200 (CEST) Received: from nico.bugseng.com (unknown [37.161.207.213]) by support.bugseng.com (Postfix) with ESMTPSA id B38DB4EE073F; Thu, 27 Jul 2023 12:45:54 +0200 (CEST) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c42f73ef-2c6a-11ee-8613-37d641c3527e From: Nicola Vetrini To: simone.ballarin@bugseng.com, xen-devel@lists.xenproject.org Cc: Nicola Vetrini , Jan Beulich , Andrew Cooper , George Dunlap , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [XEN PATCH 3/4] x86/mm: mechanically rename variable to avoid shadowing Date: Thu, 27 Jul 2023 12:45:43 +0200 Message-Id: <62f4a9e7a19b37c970e52f138a6eeb8f7363b7bc.1690449587.git.nicola.vetrini@bugseng.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1690454782570100001 Content-Type: text/plain; charset="utf-8" The rename s/p2mt/t/ is done to avoid shadowing the same declaration in the enclosing scope. Signed-off-by: Nicola Vetrini --- Is the semantics of the function altered if the inner declaration is removed entirely? --- xen/arch/x86/mm/p2m.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/xen/arch/x86/mm/p2m.c b/xen/arch/x86/mm/p2m.c index 714358f953..fa9f7616e8 100644 --- a/xen/arch/x86/mm/p2m.c +++ b/xen/arch/x86/mm/p2m.c @@ -2439,12 +2439,12 @@ int xenmem_add_to_physmap_one( =20 case XENMAPSPACE_gmfn: { - p2m_type_t p2mt; + p2m_type_t t; =20 gfn =3D idx; - mfn =3D get_gfn_unshare(d, gfn, &p2mt); + mfn =3D get_gfn_unshare(d, gfn, &t); /* If the page is still shared, exit early */ - if ( p2m_is_shared(p2mt) ) + if ( p2m_is_shared(t) ) { put_gfn(d, gfn); return -ENOMEM; --=20 2.34.1