From nobody Thu Jul 23 22:27:23 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1781600478; cv=none; d=zohomail.com; s=zohoarc; b=mWQ3K55RQ2GlCTREl9jJc5K2VQDWkmBv5sgSvwYJwU3eLWmHfuti/WBSx2hZsVWOUkWooyrsdPjfDjd11CkXRL689MoUcrbsCVWsmiN78bsDsQUz0bEAeei778vJIBRqridaXwfn45gnq4L9jeU/5Tj0ZhdG3oLTizrF7NpMbX4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1781600478; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=3KIC7FhXKRQjgufOU+xqDX7cseUxDHhdniiRrgNNmds=; b=eATkt98RJSjFnyySqQuRoC1Q9ud/mOZddpovduf/ekGj3WoMXVazdzsvhfpsR/Wei3rSJMaB3myBcDuNikEbmI82DuIwY0KMWp8f+vFyd4tVgMAML6rd0U8ZBicclmrRU0dhgimAZbcr874Tt/Uqay8o4VJlJ4fVlRm4SMJdHII= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1781600478437820.6685022515516; Tue, 16 Jun 2026 02:01:18 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1338828.1599883 (Exim 4.92) (envelope-from ) id 1wZPfG-000081-WB; Tue, 16 Jun 2026 09:00:58 +0000 Received: by outflank-mailman (output) from mailman id 1338828.1599883; Tue, 16 Jun 2026 09:00:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wZPfG-00007u-Sz; Tue, 16 Jun 2026 09:00:58 +0000 Received: by outflank-mailman (input) for mailman id 1338828; Tue, 16 Jun 2026 09:00:57 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wZPfF-00007m-Qf for xen-devel@lists.xenproject.org; Tue, 16 Jun 2026 09:00:57 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wZPfF-008tyZ-7I for xen-devel@lists.xenproject.org; Tue, 16 Jun 2026 11:00:57 +0200 Received: from [10.42.69.6] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a3110c8-5cb7-0a2a0a5109dd-0a2a4506c738-4 for ; Tue, 16 Jun 2026 11:00:57 +0200 Received: from [209.85.221.52] (helo=mail-wr1-f52.google.com) by tlsNG-16d1c6.mxtls.expurgate.net with ESMTPS (eXpurgate 4.56.1) (envelope-from ) id 6a3110c8-7371-0a2a45060019-d155dd34d44f-3 for ; Tue, 16 Jun 2026 11:00:57 +0200 Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-45ef29c5561so2305033f8f.0 for ; Tue, 16 Jun 2026 02:00:56 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4606f26393asm45176510f8f.5.2026.06.16.02.00.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 Jun 2026 02:00:55 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:In-Reply-To:Autocrypt:Content-Language:References:Cc:To:From:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1781600456; x=1782205256; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=3KIC7FhXKRQjgufOU+xqDX7cseUxDHhdniiRrgNNmds=; b=TvA6OQCnA1iAaf6MB/1LqUfTG7XFlSQliEWj1LZwlS6txF9hiHzVUe2w9FOCTnAbTW PWXiQ1jtiE8w/pmHu+taZp3Pu7SZOZHmmhcCxgOKvjt33hHoWbbFWe58/v2rDwZAlCU/ buyu7YINHBhLHxOFvC4TYS8Xk8J8rZRRZZIv79rvnZX0F69tb9PYXEIu973TSIFmFop/ gWv8soeUUx+Ef/cjCmHQnapK7wr1P2QBEUIM9Sd9E3fjhpQDZUFrtdZtz/AfQVg/ZUd0 eqp4FlBgUwePwtL+dIdzUkZSs/0v9vKVv17s/vmq1s49Sd0WoeIf0Fr26w4/FHmxY1xO ZgHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781600456; x=1782205256; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=3KIC7FhXKRQjgufOU+xqDX7cseUxDHhdniiRrgNNmds=; b=FcCfYPCw7bipLXL1Wn67oy8Ml8Xeef97fQDh6ik2OEXfeBHs5xtPWz0GLEZnv5f9pX cXTadjbhbjZe7oGFyolnX+PaU7Iv2Aefvzu1xjA9PF3GA9OESmoLoRt07VKEIDcflTQ4 C1sbAPvg3h0P4hTJp/soxWhOpfTOpBihZm+G47/0UunP0IDUGMrOT+DfLJXhLxPcMI5o 2Lj0jOLJxtU8YHDsqV/2On5GCaUaavELtYnt4MrPkAUutjrYog0w+H7eWvx49ZT/PY9B Bw2KRq3kQv2/23RAjxjc0VM9I0b3r4/3fKGZLrCku9l6b2f3z4RMnC3PhqML/ZRmiUZJ jPig== X-Gm-Message-State: AOJu0YxiQ0Ozq3fZjVipSsL1srpt2Bbs9elRy2s1AgfTbJHpkqC8pjAw EVfivEOpmZaDow9HqQ8A0Dp5GrgwyqD35Rrhy7DXKczHB1dxqTVzFM3KzysI0c4FA/e0OTXqtOY TwyM= X-Gm-Gg: Acq92OGT1gSYCOA6TzGoLPkznp3B/oRi73Yy/uy0A+WUQuf8pVirTw63BCoidNWsC0v ZlFBCpUjE1vmJ8CqVsJc9gjFBCF5JAuo3Wb9Zcdfanw8Obz3moyuLcblSHpLm0a9Hl92YRV4Pwx NjGGxU7oQa5TxVpjE3L/OSleJgqFNJIGy62KVynxs6yUH/Z0QnUXUO1pOahXPHRMCoaZsRJScF1 aRqtYXV9cq5dpvpB0YUd4PO6QMJLtOlJ92eIAo+bZ1OPLWVxVG4MClB4MS5888tpNBaoOB3SYoG o4tMuL+tK8V+FG+TqW/ST1cgQ2w8+uoyQiCBn6e6cGTGDxSTEOFa9F86tJW8ShZ+8bbvWpd48vZ chXZW1t12rX+J/4UeTZX6HnSZCwMT3o/z2N+DLUEbBd9fuBvba+0VNF/7skL77suL69PXEzNWX3 ttQS7Ff9KKf5957LBHoqSP/Ahlsd8Hs5X8pULrgdvM14ErvrsnWSYQDIxu1T+Nvi7nZ4i78e3Tt r9ruAF+NUgtPF0= X-Received: by 2002:a05:6000:987:b0:460:3233:f994 with SMTP id ffacd0b85a97d-4607ebf6969mr19546916f8f.43.1781600456261; Tue, 16 Jun 2026 02:00:56 -0700 (PDT) Message-ID: <8adede4b-f25d-4a77-9fec-bd099119b005@suse.com> Date: Tue, 16 Jun 2026 11:00:54 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH 1/4] libxc: adjust string size calculations in xc_{,de,test_}assign_dt_device() From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Anthony PERARD , Juergen Gross References: <5d242cad-d907-4321-8ac1-363c0f9b623d@suse.com> Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <5d242cad-d907-4321-8ac1-363c0f9b623d@suse.com> Content-Transfer-Encoding: quoted-printable X-purgate-ID: tlsNG-16d1c6/1781600457-8596CD75-D3A002AA/0/0 X-purgate-type: clean X-purgate-size: 1043 X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1781600479523158500 Content-Type: text/plain; charset="utf-8" In preparation for a hypervisor change also include the nul terminator in the size calculations. Signed-off-by: Jan Beulich Acked-by: Anthony PERARD Reviewed-by: Juergen Gross Reviewed-by: Teddy Astie --- a/tools/libs/ctrl/xc_domain.c +++ b/tools/libs/ctrl/xc_domain.c @@ -1592,7 +1592,7 @@ int xc_assign_dt_device( char *path) { int rc; - size_t size =3D strlen(path); + size_t size =3D strlen(path) + 1; struct xen_domctl domctl =3D {}; DECLARE_HYPERCALL_BOUNCE(path, size, XC_HYPERCALL_BUFFER_BOUNCE_IN); =20 @@ -1624,7 +1624,7 @@ int xc_test_assign_dt_device( char *path) { int rc; - size_t size =3D strlen(path); + size_t size =3D strlen(path) + 1; struct xen_domctl domctl =3D {}; DECLARE_HYPERCALL_BOUNCE(path, size, XC_HYPERCALL_BUFFER_BOUNCE_IN); =20 @@ -1652,7 +1652,7 @@ int xc_deassign_dt_device( char *path) { int rc; - size_t size =3D strlen(path); + size_t size =3D strlen(path) + 1; struct xen_domctl domctl =3D {}; DECLARE_HYPERCALL_BOUNCE(path, size, XC_HYPERCALL_BUFFER_BOUNCE_IN); From nobody Thu Jul 23 22:27:23 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1781600517; cv=none; d=zohomail.com; s=zohoarc; b=iVvx+bmzvs3wyijma8PQzTHAgYe2TWhmMgAe2tsdyQElQbG8waOc3gPaGgvM57GnJlR1sWPlwANhgxjIxTmGXiYHR7FmD9Bn6XZ9vSznzglD3MMHlPj3DjiJ594hhQ4S8x6oFBLZCEwjGsAMct+DU+vZcW4T6gmvVR4OLJ72+G4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1781600517; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=+Ir8X1cHcnOxogTsg6S6E9OZXlvuN+lWcXDa5be49dE=; b=BbP3nKKvt/D9EyUxy186XlVRfcQOUpOPJnZCfU2EwlQ7PLCQo/hEW+rBa9fNQjfiv98TbWoPKlH4TvvVvFVsWIFAje08BpAGR6qEuVNjxIAALSSqp/p6fmS3QWuwMcOdQSNeB3HrwgZHnh44V80YiVyVtqxVdEJMJ73LqoCm+Ak= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1781600517835861.3479228526597; Tue, 16 Jun 2026 02:01:57 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1338833.1599892 (Exim 4.92) (envelope-from ) id 1wZPg1-0000kW-8N; Tue, 16 Jun 2026 09:01:45 +0000 Received: by outflank-mailman (output) from mailman id 1338833.1599892; Tue, 16 Jun 2026 09:01:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wZPg1-0000kP-4f; Tue, 16 Jun 2026 09:01:45 +0000 Received: by outflank-mailman (input) for mailman id 1338833; Tue, 16 Jun 2026 09:01:44 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wZPg0-0000j8-3E for xen-devel@lists.xenproject.org; Tue, 16 Jun 2026 09:01:44 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wZPfz-004tva-G3 for xen-devel@lists.xenproject.org; Tue, 16 Jun 2026 11:01:43 +0200 Received: from [10.42.69.3] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a3110e6-bab6-0a2a0a5309dd-0a2a4503830c-38 for ; Tue, 16 Jun 2026 11:01:43 +0200 Received: from [209.85.128.49] (helo=mail-wm1-f49.google.com) by tlsNG-33051d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.56.1) (envelope-from ) id 6a3110f7-672d-0a2a45030019-d1558031a5dc-3 for ; Tue, 16 Jun 2026 11:01:43 +0200 Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-490b3e03939so30648505e9.1 for ; Tue, 16 Jun 2026 02:01:43 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4606f26434dsm43025805f8f.1.2026.06.16.02.01.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 Jun 2026 02:01:42 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:In-Reply-To:Autocrypt:Content-Language:References:Cc:To:From:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1781600503; x=1782205303; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=+Ir8X1cHcnOxogTsg6S6E9OZXlvuN+lWcXDa5be49dE=; b=Lyl8l4gO41zxDLpe+GFN2claHMqUj6NJUQIRBMro6g4kTAMnJIhCCZT7toiaapa0Tg Qpjen9r2KbQGzzvHmn7XEtmMDmtIIly3Y+XIsh+DvRBa8qWsFbH5shAGFjAJFPtJM7Lz ckoZ9cNhMgB7PFTxNH0R3tGpWyf8dAeXWnjRc2x9fKuIzo4h4/VdfjBQfegF01U0e+eB 34YnvMHvG2LcM2w/OKyEo0Wcbx5HYhBYe6WeF9cW+J/gzicQmPg6FsvSN6EPGUg78+d+ Ncq/PhMsHNM10uMWuVYzmQ7LfMItZJHFau9biG2nmAwpjWhJ4oTDYGqJ43W6bjuVA6ue Ajnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781600503; x=1782205303; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+Ir8X1cHcnOxogTsg6S6E9OZXlvuN+lWcXDa5be49dE=; b=sGCr4E4rwpKKtIvRcyFIPm811HyAdJ6V1E1Hx9c6PyKV4XckLHP439S58DJyBkIpti 54ig1XMFuJGhDnUKkdYoX7ZqcVj65woJRAkkcRQhGohEpNfsnQ6aKiaUyqvCyDoJ0v5X wjWYJ/0OhhIiA+J650NzPR/aZoWqeJrY8rQ2BNEjSFYVmkprQ07z/4IV42iSmvuwpXps mFEisUIzT2IGoA5mCpDcg/lfA/2tkFxff98oEwbn8LZ2f9okP4ouWGf+gaJhdB4mZExC btpFyPREtr0l26u0IE7FAlYQd5B/Oik3YAVXykPfPR4wiUCBIbp+TedRr6vYQnAN0NH3 uEmA== X-Gm-Message-State: AOJu0YznuP1zFHjA7PZY4vkkV2NVYvEBdM6u6IEUVUM8i/v/PaFP2uXW v573o33qaoI8UlXo1qMVrTvGFHuXw044S3KrGswIr9tgo9mAJ7Qmvnq5ipLe7U0KS+0Srpmgsi3 b8rs= X-Gm-Gg: Acq92OEWbKgtZnsqBnrpB2dTduRiGgs4qCkGxYvDZFC+Cu9ZrbbSz8DSodt0EGwErca 6x/gUy8dh49JLpzTIGCI68Fk38ND1AV8L51gAD6yu529elbFJ5mCZANYSM6GyADcBz1PKQ6epzB 1j+H22MqCYFVqjEZ4rDdBlmnPCaDn8MKQh4pUjbWlQDqiDHK+gd6/LC4+1KhmIecWKpZnWFSblA yXjZq2ZItWUYKAmCiJlHqj/kfbEjDss/vDkdO0bhGh2wxVq9FeCbrYjF4PALIxtFEoTfqkxCtCI w1GvAaCu1U19geSrWyyNzl0+1vDYq0/UiyUg2iAUP/UVoPUrBe+tX7rZSwwfUbPT/udpRgX/c4Z QOJ/Pk8xvGIigxU5AEo5stMjL2E4Rm01TVj8gfqe9X/XuPa8TnPkBAJ6pKmouvzoTGLobtg3lQA xIi2I0JVzg8xpZqig4eHVOn09o6o+wbve65T1J9pMtRCdq0LnGn3INlK4kvWaiQR+s8h+EPP8eH f6VGsxJQC4Pgjg= X-Received: by 2002:a05:600c:4a12:b0:490:bf3d:c7de with SMTP id 5b1f17b1804b1-4922faf9363mr27448125e9.10.1781600502479; Tue, 16 Jun 2026 02:01:42 -0700 (PDT) Message-ID: Date: Tue, 16 Jun 2026 11:01:41 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH 2/4] libxc: drop size parameter from xc_flask_context_to_sid() From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Anthony PERARD , Juergen Gross , Daniel Smith , Marek Marczykowski References: <5d242cad-d907-4321-8ac1-363c0f9b623d@suse.com> Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <5d242cad-d907-4321-8ac1-363c0f9b623d@suse.com> Content-Transfer-Encoding: quoted-printable X-purgate-ID: tlsNG-33051d/1781600503-42F62938-4E29E7BF/0/0 X-purgate-type: clean X-purgate-size: 3553 X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1781600523648158500 Content-Type: text/plain; charset="utf-8" Nul-terminated strings are passed in all cases, so the strlen() can very well be invoked by the function itself. In preparation for a hypervisor change also include the nul terminator in the size calculation. Signed-off-by: Jan Beulich Acked-by: Marek Marczykowski-G=C3=B3recki Reviewed-by: Teddy Astie --- Ideally libxl_flask_context_to_sid() would follow suit, but aiui doing so would break its (stable) ABI. Of course the casts in xc_flask_access() are suspicious. --- a/tools/helpers/init-xenstore-domain.c +++ b/tools/helpers/init-xenstore-domain.c @@ -108,7 +108,7 @@ static int build(xc_interface *xch) =20 if ( flask ) { - rv =3D xc_flask_context_to_sid(xch, flask, strlen(flask), &config.= ssidref); + rv =3D xc_flask_context_to_sid(xch, flask, &config.ssidref); if ( rv ) { fprintf(stderr, "xc_flask_context_to_sid failed\n"); --- a/tools/include/xenctrl.h +++ b/tools/include/xenctrl.h @@ -2372,7 +2372,7 @@ long xc_sharing_used_frames(xc_interface /*** End sharing interface ***/ =20 int xc_flask_load(xc_interface *xc_handle, char *buf, uint32_t size); -int xc_flask_context_to_sid(xc_interface *xc_handle, char *buf, uint32_t s= ize, uint32_t *sid); +int xc_flask_context_to_sid(xc_interface *xc_handle, char *buf, uint32_t *= sid); int xc_flask_sid_to_context(xc_interface *xc_handle, int sid, char *buf, u= int32_t size); int xc_flask_getenforce(xc_interface *xc_handle); int xc_flask_setenforce(xc_interface *xc_handle, int mode); --- a/tools/libs/ctrl/xc_flask.c +++ b/tools/libs/ctrl/xc_flask.c @@ -83,10 +83,11 @@ int xc_flask_load(xc_interface *xch, cha return err; } =20 -int xc_flask_context_to_sid(xc_interface *xch, char *buf, uint32_t size, u= int32_t *sid) +int xc_flask_context_to_sid(xc_interface *xch, char *buf, uint32_t *sid) { int err; struct xen_flask_op op =3D {}; + size_t size =3D strlen(buf) + 1; DECLARE_HYPERCALL_BOUNCE(buf, size, XC_HYPERCALL_BUFFER_BOUNCE_IN); =20 if ( xc_hypercall_bounce_pre(xch, buf) ) @@ -247,7 +248,7 @@ static int xc_flask_add(xc_interface *xc int err; struct xen_flask_op op =3D {}; =20 - err =3D xc_flask_context_to_sid(xch, scontext, strlen(scontext), &sid); + err =3D xc_flask_context_to_sid(xch, scontext, &sid); if ( err ) return err; =20 @@ -323,10 +324,10 @@ int xc_flask_access(xc_interface *xch, c struct xen_flask_op op =3D {}; int err; =20 - err =3D xc_flask_context_to_sid(xch, (char*)scon, strlen(scon), &op.u.= access.ssid); + err =3D xc_flask_context_to_sid(xch, (char*)scon, &op.u.access.ssid); if ( err ) return err; - err =3D xc_flask_context_to_sid(xch, (char*)tcon, strlen(tcon), &op.u.= access.tsid); + err =3D xc_flask_context_to_sid(xch, (char*)tcon, &op.u.access.tsid); if ( err ) return err; =20 --- a/tools/libs/light/libxl_flask.c +++ b/tools/libs/light/libxl_flask.c @@ -21,7 +21,8 @@ int libxl_flask_context_to_sid(libxl_ctx { int rc; =20 - rc =3D xc_flask_context_to_sid(ctx->xch, buf, len, ssidref); + assert(len =3D=3D strlen(buf)); + rc =3D xc_flask_context_to_sid(ctx->xch, buf, ssidref); =20 return rc; } --- a/tools/python/xen/lowlevel/xc/xc.c +++ b/tools/python/xen/lowlevel/xc/xc.c @@ -1754,7 +1754,7 @@ static PyObject *pyflask_context_to_sid( return PyErr_SetFromErrno(xc_error_obj); } =20 - ret =3D xc_flask_context_to_sid(xc_handle, ctx, strlen(ctx), &sid); + ret =3D xc_flask_context_to_sid(xc_handle, ctx, &sid); =20 xc_interface_close(xc_handle); From nobody Thu Jul 23 22:27:23 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1781600581; cv=none; d=zohomail.com; s=zohoarc; b=VRZx7Qj9ciuYQsrShrf5TAqijiUzur7AEdcgU3FhEHwd0Y3JwiRsn4HaVXP3cwYym7wC7ykbllGkddDleAJVQ6x1wbKku+e3E76lrv2uEwMODkHnwbH5sGDs9wp0y812a6+O6XK6TsDcKNGAKt+mcyuX8jYOXJXJuOhkW118EA4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1781600581; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=+O/5aLoJh/nqfou7kFqhsCjNAsFYq66chW2xynNKcIA=; b=c9b2oiD+f5F9t5sHyO65MHQVl0vk8pSf4VMl8UWT7Uzy/ElxxWXnb3oAs6k/QEykoEABB62D4m8ZXvMvGTyhDFtvfKUyjuxqK9sdLS553qfCFCcyhQhHzF7xu48jscdDifV4iEOrSHYeXfSaLVhv+6XXcpVuwMfa9K7MkjLAaAw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1781600581255456.769661524566; Tue, 16 Jun 2026 02:03:01 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1338840.1599900 (Exim 4.92) (envelope-from ) id 1wZPgk-0001Mw-Fg; Tue, 16 Jun 2026 09:02:30 +0000 Received: by outflank-mailman (output) from mailman id 1338840.1599900; Tue, 16 Jun 2026 09:02:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wZPgk-0001Mp-Cx; Tue, 16 Jun 2026 09:02:30 +0000 Received: by outflank-mailman (input) for mailman id 1338840; Tue, 16 Jun 2026 09:02:29 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wZPgi-0001Ma-Ta for xen-devel@lists.xenproject.org; Tue, 16 Jun 2026 09:02:29 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wZPgi-002z0G-AE for xen-devel@lists.xenproject.org; Tue, 16 Jun 2026 11:02:28 +0200 Received: from [10.42.69.11] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a311118-bab6-0a2a0a5309dd-0a2a450bbc0e-48 for ; Tue, 16 Jun 2026 11:02:28 +0200 Received: from [209.85.128.50] (helo=mail-wm1-f50.google.com) by tlsNG-42698a.mxtls.expurgate.net with ESMTPS (eXpurgate 4.56.1) (envelope-from ) id 6a311124-212f-0a2a450b0019-d1558032dda2-3 for ; Tue, 16 Jun 2026 11:02:28 +0200 Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-49222fb062bso32872445e9.1 for ; Tue, 16 Jun 2026 02:02:28 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49230a45b30sm41084035e9.2.2026.06.16.02.02.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 Jun 2026 02:02:27 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:In-Reply-To:Autocrypt:Content-Language:References:Cc:To:From:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1781600548; x=1782205348; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=+O/5aLoJh/nqfou7kFqhsCjNAsFYq66chW2xynNKcIA=; b=BOXPYbZr0sbBrzg4gFtmFF8Wj7+I4EoJK4kf4Ykp/gO6994ieJIhKvvxMWdG1sIKE8 0SnSW6cnHNiNlIG1IKAxIqIA1BjeuW1ZsJAEYjUP0DgvX3eQQG7lAlxJqsllsvWFggww t+hhzOSYWuyJk+Jv7DO41xqZg17D2ejJFV/FoJbza1KzmJ6PX/AjFtCElBkjPYlDY/Kv PfVbFdIkKjsMhbNKvUtpsK4K5WpGvlRKiiEClVxc+wr29s8NaqR7UOh8rDpRBKmOIWgD 7yZCsIUR1CiHeoRm4lrTy4njYXiSE4eVRceLEKBwjXHq9pqnbJS+eoqagVF7nkMnSask UFYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781600548; x=1782205348; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+O/5aLoJh/nqfou7kFqhsCjNAsFYq66chW2xynNKcIA=; b=ChtOl5s+m/dsoPo7PMKpSZQY2RuKWUlA15o9sKAoxSYQ2SxkRX+NeOrSKGgCsp49Tu E1r2XE2lyQhERIbqbSHCjnpWmbyhyakE0EF0cXll7EDU1W+Bs5ZX0V0ODdit22k2kv6y q4giSUavbpavMsNsKGZvlF92Pcq5gbnQIQCUgeBnt46RkaOfiIEUDcYCkl0p4U+GwerH Kfcy7GOMPjHryysSdalq94Ogvcs82uAWlG54LHtH+ZevmOX6BNbvjptfipB86zLGoHn0 JHlQHYIHe/+0K/BgUHk7tQwcqxBe0Twv7KJdXYKKmfIFthfvsvZ5TVrLOoWfsWCmndlM lN+g== X-Gm-Message-State: AOJu0YxRZOnT0xTKrEY35xXu+Z4II/a5w6O0aeeqLMF7rB6IDaztw5bO 4kqoi4vipWs9RLbrFxMWLp12O+QQTRSQZ8tW0M+gcEe0fsiMvIvBnAkoLy0tB1IGED5HfiqrhVA RXKY= X-Gm-Gg: Acq92OHCUxox8bjv71Oe8Yz/ZRed9LSXvZ0OAc6NA2RHIh77NPcjkYpoGmyVVcFCFD0 +LfWFzofJVtB3BkH6Ef77Dp1egT34Z8apMqyuAQjG9Eeggu0h/3qDOnu0a3GSaZuCgDMqKJ99We lm1eLCuJ+d3r3vgTpT19ukeJr+oe4AAAjeDkEA3+dnFAV+FQ5JK63RHdB9Ed9b/o+3xIzAGnL4w C5NwmA/1h4yCtCo+ds9fjRzQOZU6UPDuo+6sEriUX6xXTuBFQbuxBgPyYskFc9BNRDJMD3abENV 6PtV8pdgchEAxRuygeAT7RYDrLkzByjahKhEkaesmJ5sUPajARQ8Z3dEYaMENcTVshmiB3SNvwe zqhCcO6Bf9aB+BSzuR8RGBapxDSefh8Xjul6vG4JV5RDimzWbCev4vuagjWaIEYafBxcd/WdxbC +QidUmPgxEGEHeiKBeE+9GHKfDUil98ygqZuezu9AVJ01XouJlJl1PhRmWW/D/V6rybjv/Trts9 LzC79azMukL2YM= X-Received: by 2002:a05:600c:4e4e:b0:490:b28d:a6f9 with SMTP id 5b1f17b1804b1-4922ff72917mr38595785e9.8.1781600547537; Tue, 16 Jun 2026 02:02:27 -0700 (PDT) Message-ID: <83af338a-3ef2-4be3-99f0-cfe38a09cda0@suse.com> Date: Tue, 16 Jun 2026 11:02:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH 3/4] libxc: adjust string size calculations in xc_flask_{getbool_byname,setbool}() From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Anthony PERARD , Juergen Gross , Daniel Smith References: <5d242cad-d907-4321-8ac1-363c0f9b623d@suse.com> Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <5d242cad-d907-4321-8ac1-363c0f9b623d@suse.com> Content-Transfer-Encoding: quoted-printable X-purgate-ID: tlsNG-42698a/1781600548-13F7EF3B-8FC96224/0/0 X-purgate-type: clean X-purgate-size: 1718 X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1781600582413158500 Content-Type: text/plain; charset="utf-8" In preparation for a hypervisor change also include the nul terminator in the size calculations. (Note that xc_flask_getbool_byid() doesn't support FLASK_GETBOOL's "ID being -1" variant of operation, and hence doesn't need fiddling with. Signed-off-by: Jan Beulich Acked-by: Anthony PERARD Reviewed-by: Juergen Gross Reviewed-by: Teddy Astie --- a/tools/libs/ctrl/xc_flask.c +++ b/tools/libs/ctrl/xc_flask.c @@ -187,7 +187,8 @@ int xc_flask_getbool_byname(xc_interface { int rv; struct xen_flask_op op =3D {}; - DECLARE_HYPERCALL_BOUNCE(name, strlen(name), XC_HYPERCALL_BUFFER_BOUNC= E_IN); + size_t size =3D strlen(name) + 1; + DECLARE_HYPERCALL_BOUNCE(name, size, XC_HYPERCALL_BUFFER_BOUNCE_IN); =20 if ( xc_hypercall_bounce_pre(xch, name) ) { @@ -197,7 +198,7 @@ int xc_flask_getbool_byname(xc_interface =20 op.cmd =3D FLASK_GETBOOL; op.u.boolean.bool_id =3D -1; - op.u.boolean.size =3D strlen(name); + op.u.boolean.size =3D size; set_xen_guest_handle(op.u.boolean.name, name); =20 rv =3D xc_flask_op(xch, &op); @@ -219,7 +220,8 @@ int xc_flask_setbool(xc_interface *xch, { int rv; struct xen_flask_op op =3D {}; - DECLARE_HYPERCALL_BOUNCE(name, strlen(name), XC_HYPERCALL_BUFFER_BOUNC= E_IN); + size_t size =3D strlen(name) + 1; + DECLARE_HYPERCALL_BOUNCE(name, size, XC_HYPERCALL_BUFFER_BOUNCE_IN); =20 if ( xc_hypercall_bounce_pre(xch, name) ) { @@ -231,7 +233,7 @@ int xc_flask_setbool(xc_interface *xch, op.u.boolean.bool_id =3D -1; op.u.boolean.new_value =3D value; op.u.boolean.commit =3D 1; - op.u.boolean.size =3D strlen(name); + op.u.boolean.size =3D size; set_xen_guest_handle(op.u.boolean.name, name); =20 rv =3D xc_flask_op(xch, &op); From nobody Thu Jul 23 22:27:23 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1781600623; cv=none; d=zohomail.com; s=zohoarc; b=mSVBw7avbeS/q2tKc8PP4pFuconX8uEMf3AiYN82NgYO1GQK17YW3SJmo8k9U3v/bj4vfZ7MD/XgykvrDaJBEI1pzIAI+iqTETYD3iNvYjS9DQG6ILGJxYf8pFwPM+UdXio7aeQ073ZvS6IzkUagzm0l+BmMnPorwXOGY4s1BLc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1781600623; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Dga1/oyfPqrdOGX1Yrc05VbMApsKHkKaZphLkonwUHo=; b=g029sUiCLVT81Pdw9wXY0yRXe5Ubma9dejy3sdqX6TpLdMTxMITf2rKEJYSHCX8qlqEsBEVS4kJ1hl8074vSkg0YZepScJKYgNbPCe2FGrD/A9CqIkmwm0n1DUTfqLLvHvxu4P3AKog/uwLJ0pg+6a4pmSIjgjKrtY3jfBA28Jw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1781600623607622.470357700531; Tue, 16 Jun 2026 02:03:43 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1338846.1599910 (Exim 4.92) (envelope-from ) id 1wZPhg-00026s-Sw; Tue, 16 Jun 2026 09:03:28 +0000 Received: by outflank-mailman (output) from mailman id 1338846.1599910; Tue, 16 Jun 2026 09:03:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wZPhg-00026k-PO; Tue, 16 Jun 2026 09:03:28 +0000 Received: by outflank-mailman (input) for mailman id 1338846; Tue, 16 Jun 2026 09:03:26 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wZPhe-00026b-OH for xen-devel@lists.xenproject.org; Tue, 16 Jun 2026 09:03:26 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wZPhe-009KpH-50 for xen-devel@lists.xenproject.org; Tue, 16 Jun 2026 11:03:26 +0200 Received: from [10.42.69.2] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a311155-2eae-0a2a0a5409dd-0a2a4502defc-46 for ; Tue, 16 Jun 2026 11:03:25 +0200 Received: from [209.85.221.54] (helo=mail-wr1-f54.google.com) by tlsNG-720697.mxtls.expurgate.net with ESMTPS (eXpurgate 4.56.1) (envelope-from ) id 6a31115d-af86-0a2a45020019-d155dd36ad45-3 for ; Tue, 16 Jun 2026 11:03:25 +0200 Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-45fd45e596cso2403789f8f.1 for ; Tue, 16 Jun 2026 02:03:25 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4619b9b7750sm14807493f8f.6.2026.06.16.02.03.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 Jun 2026 02:03:24 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:In-Reply-To:Autocrypt:Content-Language:References:Cc:To:From:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1781600605; x=1782205405; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=Dga1/oyfPqrdOGX1Yrc05VbMApsKHkKaZphLkonwUHo=; b=btlMAXWbl6LoCkfw9vbx4ER5AFrsec2liHhD7z+7BbvPk9AMYGbFqFksg8EJb4XBre ZA4ATa8z5ODkL04mqQV9aswBaEYxD+lV84N9opLeZ5i1E0vnp+N3biNFoAOS/ccxGUEM Y6sblVfKjO9qWVHdlIMotBDOzgdCwNaI8qorPjrAOvcehDXQslC5sJa7kTFdh3IJVYjO WIYCFWompVTTwwWC5Rr02ZbAL2BiCqtS/7FVBegI7aGo1cTy3f+mvRzhv1tUye3CshsU VX4Gp5WUJJsy1tzfLKLN8VpzGmEyV9P8rwY2gGbR6IRs3cLy2RLA7vT4zV7cflB7wLEe CjGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781600605; x=1782205405; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Dga1/oyfPqrdOGX1Yrc05VbMApsKHkKaZphLkonwUHo=; b=ie2KcYBos7ckbI9wPgIzLXWVZBj9ixydLWDPORPMMx1GugeAwTvoAbm9/k6zSUB+Ha 0OC68kbxJ/6pkIK98vJh8ZQK9JEWCIzE1ybkZbFDj/u8ze0qGKUdK4po7mYWHNwbR/BS xX/dPZpSx2g2D9X4CzAbUdocsf9Yf6/7ReXcJSZkcnuTsLfzWzKQ5U6yBI6URjqd8unx 7bAhczNQ2fHoD0qbBsGia29Qj77vhmM5r8lYzT0ZGSHgUxpTvuWbHg5bewXDb1OCaAvq CPC0aBkGCbnYDEuQOgsAyXGf7eIuuVlD6g2/b5vyHahot7Yg+rzszd8Z2p83mn28gOhC yGNg== X-Gm-Message-State: AOJu0YwGuCc2xPNJ88chthr84QkoQYrRDHGcFXLNFWXfrubGmnTusWTV UN/NTSHIudUxbQ8yo7S0vrWFtuQB+yEBXp0No4JtPeRjAfOsvRCvK38bwbA5wnWETZaihFQWic+ P9Dg= X-Gm-Gg: Acq92OGRoIv07SCytCnDZEzfkt3TQqH7wAvhiwuRMYxVsBqngi3piCLl7EC0wEvIvmw Ze6Hiw58CHD4inWjdKlvABv36SMMOGEDdFM6aijZRTiTizIZeDE+VTLUf50FuZFlNi2jYGJd4q5 nJfYh7GfYNuGuVqH8Lo64M5Kn9iLTXdeDpyaEojMDzCzjBi4g/pb+Ta6T4+CfB02ScWko0PkrQj 1mNv4kQhOV345EmJ0FSxLWcqB3jBuYeC4H7SFHmewi28jgQazru28w3r4R80/RL7UCRhNgvbYiC 0kUorfWjlAzIgS/UaU4jMlYvqXISdrg7Xa8t1FPdqctEA9zP8gHD5kQCIl6piieh2eMUvvy3tK9 4+qtHtB6sBGDgo0//JY7PaWnDL8pYpy5Ll24PvFj8gzkpQaIcdA4IUyl3sict5qr9NM++n8h0uT 1so2cSzOJtHnIxoXPkKWSkdGT3bCZaVnmId3VWS1dsDk1pRca2IG1uvATUW2Xw4oOvCu7DHsP5g /g13Bxlsx0Gd3U= X-Received: by 2002:a05:600c:34c3:b0:490:c2a2:e91e with SMTP id 5b1f17b1804b1-4922ffc0622mr43887735e9.34.1781600604754; Tue, 16 Jun 2026 02:03:24 -0700 (PDT) Message-ID: <7e492b98-26d5-4d90-a703-ee25beae7e23@suse.com> Date: Tue, 16 Jun 2026 11:03:23 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH 4/4] lib: make safe_copy_string_from_guest() validate input From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Julien Grall , Stefano Stabellini , Anthony PERARD , Michal Orzel , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Daniel Smith , Oleksii Kurochko References: <5d242cad-d907-4321-8ac1-363c0f9b623d@suse.com> Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <5d242cad-d907-4321-8ac1-363c0f9b623d@suse.com> Content-Transfer-Encoding: quoted-printable X-purgate-ID: tlsNG-720697/1781600605-80145161-240C44FE/0/0 X-purgate-type: clean X-purgate-size: 3965 X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1781600624235158500 Content-Type: text/plain; charset="utf-8" ... rather than papering over guest flaws: Strings passed ought to be nul- terminated (yet sadly libxc hasn't been doing so thus far). This way we also avoid order-1 allocations, seeing that all present callers pass PAGE_SIZE for max_size. Signed-off-by: Jan Beulich --- I can't spot any caller side use of FLASK_DEVICETREE_LABEL, hence there's no corresponding prereq patch. --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -11,6 +11,8 @@ The format is based on [Keep a Changelog to obtain an automatically allocated domid. The prior sentinel values = (0 since the start of Xen, and DOMID_INVALID since Xen 4.21) now no longer represent a wildcard input. + - XEN_DOMCTL_DEV_DT's, FLASK_[GS]ETBOOL's, and FLASK_DEVICETREE_LABEL's i= nput + string sizes need to include the nul terminator. - On x86: - Enable pf-fixup option by default for PVH dom0. - The libxenguest bzImage loader now uses the system liblz4 library. --- a/xen/lib/guest-strcpy.c +++ b/xen/lib/guest-strcpy.c @@ -3,8 +3,8 @@ #include =20 /* - * The function copies a string from the guest and adds a NUL to - * make sure the string is correctly terminated. + * The function copies a string from the guest and checks there's a NUL + * terminating the string. */ char *safe_copy_string_from_guest(XEN_GUEST_HANDLE(char) u_buf, size_t size, size_t max_size) @@ -14,8 +14,7 @@ char *safe_copy_string_from_guest(XEN_GU if ( size > max_size ) return ERR_PTR(-ENOBUFS); =20 - /* Add an extra +1 to append \0 */ - tmp =3D xmalloc_array(char, size + 1); + tmp =3D xmalloc_array(char, size); if ( !tmp ) return ERR_PTR(-ENOMEM); =20 @@ -24,7 +23,12 @@ char *safe_copy_string_from_guest(XEN_GU xfree(tmp); return ERR_PTR(-EFAULT); } - tmp[size] =3D '\0'; + + if ( !memchr(tmp, 0, size) ) + { + xfree(tmp); + return ERR_PTR(-EMSGSIZE); + } =20 return tmp; } --- a/xen/include/public/domctl.h +++ b/xen/include/public/domctl.h @@ -574,7 +574,7 @@ struct xen_domctl_assign_device { uint32_t machine_sbdf; /* machine PCI ID of assigned device = */ } pci; struct { - uint32_t size; /* Length of the path */ + uint32_t size; /* Length of the path, including nul terminator= */ XEN_GUEST_HANDLE_64(char) path; /* Path to the device tree nod= e */ #ifdef __XEN__ struct dt_device_node *dev; /* Resolved device node of the abo= ve */ --- a/xen/include/public/xsm/flask_op.h +++ b/xen/include/public/xsm/flask_op.h @@ -26,7 +26,8 @@ typedef struct xen_flask_setenforce xen_ struct xen_flask_sid_context { /* IN/OUT: sid to convert to/from string */ uint32_t sid; - /* IN: size of the context buffer + /* + * IN: size of the context buffer, including nul terminator * OUT: actual size of the output context string */ uint32_t size; @@ -86,8 +87,11 @@ struct xen_flask_boolean { uint8_t new_value; /* IN: commit new value instead of only setting pending [SET] */ uint8_t commit; - /* IN: size of boolean name buffer [GET/SET] - * OUT: actual size of name [GET only] */ + /* + * IN: size of boolean name buffer [GET/SET]; must cover nul terminator + * if "name" (below) is an input + * OUT: actual size of name [GET only] + */ uint32_t size; /* IN: if bool_id is -1, used to find boolean [GET/SET] * OUT: textual name of boolean [GET only] @@ -150,7 +154,7 @@ typedef struct xen_flask_relabel xen_fla struct xen_flask_devicetree_label { /* IN */ uint32_t sid; - uint32_t length; + uint32_t length; /* length of the path, including nul terminator */ XEN_GUEST_HANDLE(char) path; }; typedef struct xen_flask_devicetree_label xen_flask_devicetree_label_t;