From nobody Fri Oct 31 09:34:00 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1750176671; cv=none; d=zohomail.com; s=zohoarc; b=Ze5PPQZzD/w6wcj8YVAxC2/5oBUi8HMf6lKDWK2dHFs7pudTdB9qRoGHmwZ3TYdDoV1Ptos2gWXMW/pnASX6frRovJ1JOjEDsCCNAK02883Y1YoDiZbS9ACnxiWeji47jV44tQwpTyYmqPk/Nqzp/FO1QAqapLJPruWmLyIWLrw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1750176671; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=3VoPrsapEJe6cnYVGPlEbMcKBx2LN9u76bVC8NTafYM=; b=RJe0M5vR/bMBAWpcsJJxUOc+zRRyBI9/TdJNQVwShnYhv8IRfB1V1EOfWUTF8POU6VXuOwOhUQNZWgjGfBaJ9eoT6s8sahYK6c06XpjLGDw0hE92i3GRsiGNKkjpkgPJJX+IsEfHc5OiuViAJgtjGijRAcC7C14bf5jQAzvKrgk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1750176671212876.200005126652; Tue, 17 Jun 2025 09:11:11 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1018354.1395258 (Exim 4.92) (envelope-from ) id 1uRYti-0002GW-GX; Tue, 17 Jun 2025 16:10:54 +0000 Received: by outflank-mailman (output) from mailman id 1018354.1395258; Tue, 17 Jun 2025 16:10:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1uRYti-0002GP-B2; Tue, 17 Jun 2025 16:10:54 +0000 Received: by outflank-mailman (input) for mailman id 1018354; Tue, 17 Jun 2025 16:10:52 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1uRYm2-0007f6-Gy for xen-devel@lists.xenproject.org; Tue, 17 Jun 2025 16:02:58 +0000 Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com [2a00:1450:4864:20::130]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 88a830a3-4b94-11f0-b894-0df219b8e170; Tue, 17 Jun 2025 18:02:56 +0200 (CEST) Received: by mail-lf1-x130.google.com with SMTP id 2adb3069b0e04-5535652f42cso5897291e87.2 for ; Tue, 17 Jun 2025 09:02:56 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-74890083c0fsm9033929b3a.72.2025.06.17.09.02.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Jun 2025 09:02:55 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 88a830a3-4b94-11f0-b894-0df219b8e170 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1750176176; x=1750780976; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=3VoPrsapEJe6cnYVGPlEbMcKBx2LN9u76bVC8NTafYM=; b=QTcdaAEYqvb6VCs1ey0tE+knX2Rwk9sVOrxa7HHcfzE3ZTSJn7VmBHT5L5P2/Ttej/ /Fd9UZf36oZjj90oFtjDMRRsh+cn6+53PwUEzJY9MT+EIAHVH1Aw1dvdXna/TAVxYeZM cz8RlhFVzgFdEQlY4t4W2Y9FV5TQ8wKgqGhOh30kLxk/AMFoGB5ulOPsp5EyrRc+ZyQq fPfWDton79Brw25ZXj4CuOsEjTgsp/sG1lPGrv2yj+XIu4mVpXR9BlQsjCaah40d0sKB uPV1n/8AAcBVXlu+F1EejDGjrAAf6wQyWKL83tSnKj4ySnjZgzSm7f5wqxJwqPcPTB4h bN9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750176176; x=1750780976; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3VoPrsapEJe6cnYVGPlEbMcKBx2LN9u76bVC8NTafYM=; b=YE4/uX/yxQwruWZBAL/Ta+T7GXzRuIqgM6I+/ew1QjZmC5K2nlRGeVmH2rPIbU48nx EH3SsKDJyMw5dA+DMPu4CPiMQY7QEOa6mvL2lUhVpjNaAn2PUtP67EmcKTmrjD2o7eIz 6h13H0e/t12EnfCqjAuJReXd7uwj3wjzx5nG6VQDt0ZOSk55BcJJI8HPSDruH9W5sL1O m01/3J7AqtxQkJfcVgAJ/rQtGoa9MRpTZiNvCvpLek3310J9aD3DKKxB0P4KWnwuvRe7 IhCZlLhMYhu7PbDyHUGXt6IkIBx6+z1Bh4HkV01rNMhY25M1yKj6rDn0ftNqlfo6vVI6 vO8g== X-Gm-Message-State: AOJu0YwdXXGug6MSo4MFjxse2BT91w/m9nXN/o7Q31EANUvsxD0lQNYV h91R4rvOihrEy8qIdu+v8xtEP2zlNebVY1jUL8v2AstCHPcbqQ6IcitRGtKzvpTwW2bC+ow5T7e 8/rg= X-Gm-Gg: ASbGnctn8nSTRDpPObVBGEaie8hPuVggq1+sFco5NzT9uHpIMyjq/Llz1HWco77iaK4 M4VnYw1spGd00Uuy7JhiXdxvRctJDQQroghgzElH/1WYeTQAh5yzN+EXTfzmTCQT4Tw5gZRPurR HhBi2gXZClXbWTs1xB7P5tSr/sFr+jcH+3rqpLeLEPvKAmibskKYc4Z3nuDZrtODtA8Z9Vjctyy yavT2iiA/6z248H0Mzw81IylZv5kM4xsC+BddKx8fnir/FYwV83Qsopd1p8Xk5nies3c7oP3Wfh 02l5oUEwhov7D3yEZSrnpQrvHZUa71w7P3x8+PVojEhDBp3Vx5NuZAeoFjZCjGRJub2oRNX9AgM oIlR8QSy6EbCPCjRc81sxbxjRkSgkpvXq2B3Lvm5MyVncLCY= X-Google-Smtp-Source: AGHT+IE19BxAWlHpgOXiWe2qTL9rpAV4ct7l2odaZJlPG0+KL8RAh62AvEcmfqulcGKe0/k4ttRBJA== X-Received: by 2002:a05:6512:4011:b0:553:ad48:3f2b with SMTP id 2adb3069b0e04-553b6e7d1e3mr3501048e87.2.1750176176030; Tue, 17 Jun 2025 09:02:56 -0700 (PDT) Message-ID: <5bc8d03f-ee68-4405-b615-f3183d60c2b5@suse.com> Date: Tue, 17 Jun 2025 18:02:49 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH v2 5/5] vVMX: address size in decode_vmx_inst() From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= References: <080f33dc-6381-4b85-8fd5-78e93e265b13@suse.com> Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <080f33dc-6381-4b85-8fd5-78e93e265b13@suse.com> Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1750176673128116600 Content-Type: text/plain; charset="utf-8" While the original use of the address size file in the instruction info provided was wrong, it still wants using: The offset into the designated segment still may need truncating accordingly. Fixes: 09fce8016596 ("Nested VMX: Emulation of guest VMXON/OFF instruction") Signed-off-by: Jan Beulich --- a/xen/arch/x86/hvm/vmx/vvmx.c +++ b/xen/arch/x86/hvm/vmx/vvmx.c @@ -453,6 +453,13 @@ static int decode_vmx_inst(struct cpu_us size =3D 4 << mode_64bit; =20 offset =3D base + index * scale + disp; + switch ( info.fields.addr_size ) + { + case 0: offset =3D (uint16_t)offset; break; + case 1: offset =3D (uint32_t)offset; break; + default: break; + } + base =3D !mode_64bit || info.fields.segment >=3D x86_seg_fs ? seg_base + offset : offset; if ( offset + size - 1 < offset ||