From nobody Mon Feb 9 05:45:28 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1691058489539752.4400130248479; Thu, 3 Aug 2023 03:28:09 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.576227.902158 (Exim 4.92) (envelope-from ) id 1qRVYW-0002fi-2f; Thu, 03 Aug 2023 10:27:44 +0000 Received: by outflank-mailman (output) from mailman id 576227.902158; Thu, 03 Aug 2023 10:27:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRVYV-0002fQ-W3; Thu, 03 Aug 2023 10:27:43 +0000 Received: by outflank-mailman (input) for mailman id 576227; Thu, 03 Aug 2023 10:27:42 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRVYU-0000aV-Sk for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 10:27:42 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6038b78b-31e8-11ee-8613-37d641c3527e; Thu, 03 Aug 2023 12:27:41 +0200 (CEST) Received: from beta.station (net-188-218-251-179.cust.vodafonedsl.it [188.218.251.179]) by support.bugseng.com (Postfix) with ESMTPSA id 8CAAA4EE0740; Thu, 3 Aug 2023 12:27:40 +0200 (CEST) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6038b78b-31e8-11ee-8613-37d641c3527e From: Simone Ballarin To: xen-devel@lists.xenproject.org Cc: consulting@bugseng.com, Gianluca Luparini , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Simone Ballarin Subject: [XEN PATCH 13/13] xen: address violations of MISRA C:2012 Rule 7.3 Date: Thu, 3 Aug 2023 12:22:28 +0200 Message-Id: <5b625185f779b9903463b8abd1aabfe7d5d8e548.1691053438.git.simone.ballarin@bugseng.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1691058490818100001 Content-Type: text/plain; charset="utf-8" From: Gianluca Luparini The xen sources contain violations of MISRA C:2012 Rule 7.3 whose headline states: "The lowercase character 'l' shall not be used in a literal suffix". Use the "L" suffix instead of the "l" suffix, to avoid potential ambiguity. If the "u" suffix is used near "L", use the "U" suffix instead, for consist= ency. The changes in this patch are mechanical. Signed-off-by: Gianluca Luparini Signed-off-by: Simone Ballarin Reviewed-by: Stefano Stabellini --- xen/include/xen/bitops.h | 8 ++++---- xen/include/xen/tasklet.h | 4 ++-- xen/include/xen/time.h | 4 ++-- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/xen/include/xen/bitops.h b/xen/include/xen/bitops.h index e926047932..654f525fb4 100644 --- a/xen/include/xen/bitops.h +++ b/xen/include/xen/bitops.h @@ -186,12 +186,12 @@ static inline unsigned int generic_hweight64(uint64_t= w) if ( BITS_PER_LONG < 64 ) return generic_hweight32(w >> 32) + generic_hweight32(w); =20 - w -=3D (w >> 1) & 0x5555555555555555ul; - w =3D (w & 0x3333333333333333ul) + ((w >> 2) & 0x3333333333333333ul); - w =3D (w + (w >> 4)) & 0x0f0f0f0f0f0f0f0ful; + w -=3D (w >> 1) & 0x5555555555555555UL; + w =3D (w & 0x3333333333333333UL) + ((w >> 2) & 0x3333333333333333UL); + w =3D (w + (w >> 4)) & 0x0f0f0f0f0f0f0f0fUL; =20 if ( IS_ENABLED(CONFIG_HAS_FAST_MULTIPLY) ) - return (w * 0x0101010101010101ul) >> 56; + return (w * 0x0101010101010101UL) >> 56; =20 w +=3D w >> 8; w +=3D w >> 16; diff --git a/xen/include/xen/tasklet.h b/xen/include/xen/tasklet.h index ea73171f6e..193acf8f42 100644 --- a/xen/include/xen/tasklet.h +++ b/xen/include/xen/tasklet.h @@ -37,8 +37,8 @@ struct tasklet DECLARE_PER_CPU(unsigned long, tasklet_work_to_do); #define _TASKLET_enqueued 0 /* Tasklet work is enqueued for this CPU. */ #define _TASKLET_scheduled 1 /* Scheduler has scheduled do_tasklet(). */ -#define TASKLET_enqueued (1ul << _TASKLET_enqueued) -#define TASKLET_scheduled (1ul << _TASKLET_scheduled) +#define TASKLET_enqueued (1UL << _TASKLET_enqueued) +#define TASKLET_scheduled (1UL << _TASKLET_scheduled) =20 static inline bool tasklet_work_to_do(unsigned int cpu) { diff --git a/xen/include/xen/time.h b/xen/include/xen/time.h index 9ceaec541f..5aafdda4f3 100644 --- a/xen/include/xen/time.h +++ b/xen/include/xen/time.h @@ -57,9 +57,9 @@ struct tm wallclock_time(uint64_t *ns); #define SECONDS(_s) ((s_time_t)((_s) * 1000000000ULL)) #define MILLISECS(_ms) ((s_time_t)((_ms) * 1000000ULL)) #define MICROSECS(_us) ((s_time_t)((_us) * 1000ULL)) -#define STIME_MAX ((s_time_t)((uint64_t)~0ull>>1)) +#define STIME_MAX ((s_time_t)((uint64_t)~0ULL>>1)) /* Chosen so (NOW() + delta) wont overflow without an uptime of 200 years = */ -#define STIME_DELTA_MAX ((s_time_t)((uint64_t)~0ull>>2)) +#define STIME_DELTA_MAX ((s_time_t)((uint64_t)~0ULL>>2)) =20 /* Explicitly OR with 1 just in case version number gets out of sync. */ #define version_update_begin(v) (((v) + 1) | 1) --=20 2.34.1