From nobody Sun Dec 14 05:56:51 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1763987392; cv=none; d=zohomail.com; s=zohoarc; b=RZIe0vwZQhe3rAHaLZHhA2tEUnWf9TENLK5wj2wFd5y6UsgBgYMPDNHMrf1uertsbpLUOi5yn3y1EVtO+/ocSHEoiD4weIyt5NsLT1G395ZIvmEZNDOFvdwV/gVqnGn6YCWMrVnMZ1WeHxHj84CQ+EGidyIrFB1FLIcONf3Mh3s= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1763987392; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Uq8T8Ut7nBFs5m+qS+nnXIlDrchpr4rx4FlUw159pzQ=; b=HcBdnpB8ud1gKf2305mWkWgaq7oMX1uCjOMF7+VhWmM8shDIPaXBLmZxw8z2KKx4H6OORbAF2Lt8C+xIXuh4rRw6YhfN9GweSwFC+NwsBLJxZO5h9U2V+LVAbam5dWyiOzNJ9TPaRM5MM11MsS+JzcJZT+Ww3ZJpLz2A6keWl1I= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1763987392023417.917473786302; Mon, 24 Nov 2025 04:29:52 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.1170481.1495544 (Exim 4.92) (envelope-from ) id 1vNVhJ-0004ef-SV; Mon, 24 Nov 2025 12:29:37 +0000 Received: by outflank-mailman (output) from mailman id 1170481.1495544; Mon, 24 Nov 2025 12:29:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vNVhJ-0004eY-Pz; Mon, 24 Nov 2025 12:29:37 +0000 Received: by outflank-mailman (input) for mailman id 1170481; Mon, 24 Nov 2025 12:29:35 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vNVhH-0004cg-Ua for xen-devel@lists.xenproject.org; Mon, 24 Nov 2025 12:29:35 +0000 Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [2a00:1450:4864:20::331]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3c6f57b1-c931-11f0-9d18-b5c5bf9af7f9; Mon, 24 Nov 2025 13:29:35 +0100 (CET) Received: by mail-wm1-x331.google.com with SMTP id 5b1f17b1804b1-47774d3536dso32714165e9.0 for ; Mon, 24 Nov 2025 04:29:35 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-477bf1e86b3sm227919165e9.6.2025.11.24.04.29.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Nov 2025 04:29:34 -0800 (PST) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3c6f57b1-c931-11f0-9d18-b5c5bf9af7f9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1763987375; x=1764592175; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=Uq8T8Ut7nBFs5m+qS+nnXIlDrchpr4rx4FlUw159pzQ=; b=Dj+guRVOYaQ9bQKHQVJoOEWdDghkgBJkpMQfhbocHbovraVH+YBjoCaWVtESCIN+Vp Gto58n2Is6sLuTGJ6e+levYUSZznrtEspDc6Ws8jZWRovJmQGyFjK5KLq8a9ix39fTqo Y2gzK9H4PAkG0eSXtE3dxzTwKr57dmriUO65SDeQutN10rFothdTxGvKC21RdEDN/sZJ Wy4KDBXEGtWEwxbCjC/h7qnL5CZPzQyQAhjQ+oosxDzg2OTmHhJuVe9bnBmSfEJFed8y zzaRiSq+NNkdpdG4XIf5h9rzUrweoMlpiQKJaNtbhCrkWHjgsGZcJH+77C7k3hSxaOHN sPzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763987375; x=1764592175; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Uq8T8Ut7nBFs5m+qS+nnXIlDrchpr4rx4FlUw159pzQ=; b=Q46D65ovc3/lq73letOmXdnex4i/VOqNhVeZroXymAmAVUhkGDPayrC6EPTkHzSMBi +Moj/YBG/Ce/PrCGVicfkGr+Hq+zlsFORnHNiaduYMIJRpZpAn2h2RwQyn10NipTQN5c z44fBFTchlSLe8/dUmRtkqx9yBOUlq4hflxvqaWTBryk6Tq/F2sPjhwKXFtlum5NlnCw KJ3A856GAtIPixxTbwUT8iAGnx3XYJ9aOar2NApj9gQx1GIiDGWxiinVVxppqX5fsVee 3Bc1UaFV4sHn7/Ej8gawPZwdOOm1D9nYKFl9C4hq4DwygA1LHz8alZ/JElZF/XMHP5Ku Dc6A== X-Gm-Message-State: AOJu0YwLAibqOjX+elPPJUIEUM+EPfYtIQci7bYFzryhQTml4s0lKpt/ J2QhRsFAh8ge2/myerHkuqWwBBJLU1Ddej3HNCpeP7UthILEc/N3fe2Rtsc3Hezw5SnijHEhpjx Luuw= X-Gm-Gg: ASbGncvWP2pU0hi2JAqpKXkDYpU9m7q6c8abFrJ23MGz8Ypn2gK0PspXg2zhtG5Roaw UkcwoV9MmjKUj593Zc20Oj3/KmRy3YclHnljgYwQAx4WZ1Qmbv8VNP7ZpFS+tc0YbM0ya3ujiuH ebOV/x5M/1715CSqjLz+5P2T60hmow1NMD4ZIseCfylbZxq9EYxBEvVJYi7cmMxXRfWsZ1Z3vJ0 NLAiGFLHrIB0J4nTnBm0BfKVJsK9u+QzJWZ6lFwYUWt11YPDWK9ubzBgXSLkANY3fhxMkhi1dLi X4rtAP1SjqjcDR5cv6hvRHFDHEr3Jeki6f6pgR9GMCgFKGOO4zIVBcLZgR4duuDg7JE+NKcJnUq 5gccx+YEsPMF1T1l2Co6NNjQTMbwX4K5bWm9icptH++1gC8DsJwZQACL5Cjg4uS5GVWWecgf2XI eO3Xibm3URF71heefGXUjf0QBY47eXcTD0JLPWR5UvPLurR44HCyXO6yN5fQK/rxpOAFIK6gEI3 hQ= X-Google-Smtp-Source: AGHT+IGwloRQ+kF3xPZB5o2a3bfC7PgT7rI3XJAc58AlNPaD713BOvTDDEDqeqGNoHEIaHs6CrLuNA== X-Received: by 2002:a05:600c:642:b0:477:9a61:fd06 with SMTP id 5b1f17b1804b1-477b9ead384mr94298145e9.8.1763987374786; Mon, 24 Nov 2025 04:29:34 -0800 (PST) Message-ID: <96e8cf62-987e-45fb-9463-8a3069d346f4@suse.com> Date: Mon, 24 Nov 2025 13:29:36 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH v2 1/4] x86/vPMU: move APIC ack past the handling of the interrupt From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= References: <5ac2e9b1-81f2-41d9-8f05-d546a49c43a7@suse.com> Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <5ac2e9b1-81f2-41d9-8f05-d546a49c43a7@suse.com> Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1763987393797019200 Content-Type: text/plain; charset="utf-8" While benign as long as it's using a direct-APIC-vector (handlers for which are called with IRQs off), follow the more usual pattern of ack-ing the IRQ only after handling it. Requested-by: Andrew Cooper Signed-off-by: Jan Beulich Reviewed-by: Andrew Cooper --- v2: New. --- a/xen/arch/x86/apic.c +++ b/xen/arch/x86/apic.c @@ -1319,8 +1319,8 @@ static void cf_check error_interrupt(voi =20 static void cf_check pmu_interrupt(void) { - ack_APIC_irq(); vpmu_do_interrupt(); + ack_APIC_irq(); } =20 void __init apic_intr_init(void) From nobody Sun Dec 14 05:56:51 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1763987417; cv=none; d=zohomail.com; s=zohoarc; b=BZZpLl9w/KsKGOx1XiZptnmy0HEqbQVhR6ecY2z4ifICAWJXB4wnsvCiwHlbFmNnOVgzg30TqrtBoNEhztrZeCrPicKTWkLQJlAxocZg8FRAHiCkCHafEcwqFDt0fq4geuFpa3url9zxXSJH9ULuFWN+lMogX1IoI40/9I9cy/I= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1763987417; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=loYtzp0ab1X2xMw5ZpAYNU+RwEo6LK1Qt3iW0KjPiTQ=; b=P0MaPz5euYh7YT9Skp6s9Ge0iFkFjkKysB3z6a9QbuYoDACXr8+6H/t2mLebglZlFd2uNSx/d5BD+uBK0dU/rRBtu8SogTU7/ae/FuHf6fAWkvf7yce11KYdt3GwO2O4nV9zXZ3c8et9VfZGc2vN5i207VJkE4Z7sOKNqr584A0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1763987416978306.04607176427817; Mon, 24 Nov 2025 04:30:16 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.1170485.1495554 (Exim 4.92) (envelope-from ) id 1vNVhg-00054S-52; Mon, 24 Nov 2025 12:30:00 +0000 Received: by outflank-mailman (output) from mailman id 1170485.1495554; Mon, 24 Nov 2025 12:30:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vNVhg-00054L-23; Mon, 24 Nov 2025 12:30:00 +0000 Received: by outflank-mailman (input) for mailman id 1170485; Mon, 24 Nov 2025 12:29:59 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vNVhf-00053p-AD for xen-devel@lists.xenproject.org; Mon, 24 Nov 2025 12:29:59 +0000 Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [2a00:1450:4864:20::431]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4954ad95-c931-11f0-980a-7dc792cee155; Mon, 24 Nov 2025 13:29:57 +0100 (CET) Received: by mail-wr1-x431.google.com with SMTP id ffacd0b85a97d-42b3c5defb2so2741052f8f.2 for ; Mon, 24 Nov 2025 04:29:57 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42cb7f2e574sm28027049f8f.3.2025.11.24.04.29.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Nov 2025 04:29:56 -0800 (PST) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4954ad95-c931-11f0-980a-7dc792cee155 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1763987396; x=1764592196; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=loYtzp0ab1X2xMw5ZpAYNU+RwEo6LK1Qt3iW0KjPiTQ=; b=eIQjI7WBHz797RDOC0nzXmerMZOw5qsBWpKllMT83q67Bc4QFJ1iQgw6jMcEBg3dM7 YgIJZCGB2e3TS1lLjafNvir7xxEypx7VF3F8tjK4wN6n+2zcJNLhRNo8DluHtyUnc8Z+ L5r35nlB93fSbV4y2gBZ8BNw2xvIizl2TfuGi2iPpNby6S+ZwAJOsr0gR6f24KdhfAvN eqOpvQOG1sBcvj2i7SZJDfDaW1yu45uk8ZU61uvfLQ3ayOIukooqRne/2dzP7MHkZAaJ Nlw4dbBcBh3LVNtbvFfgNmhTB9k6nlq6vLTtI2HguUfpWi2rP5amxNKfmbhP/pu+Ohth fBHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763987396; x=1764592196; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=loYtzp0ab1X2xMw5ZpAYNU+RwEo6LK1Qt3iW0KjPiTQ=; b=u36EzG+GD1zK9c/cKhjg5e9nQaNaD4SSmexsPEWyzXeN8tyKDSq9gISwH1kLcQQXYZ YDnm7mlDPxW2D6wJDun7vkdACmRv1WJr79xzvyG4NlU3pPSPk36exCGfJ8ANP/cCdXM6 eDraAGCBESmEBgnJwTbJxbRZt8/8KQY43E4NW7X1sVQLu6BmoIfrxRA+yBkxqOQklqka bCX+7w9rVnvoLXBxiuSq3xcaRZD18FAUyyKd9sWQ7AEIcKtj0aThD+0nE8b3gIz9NcqH aEf3QWQpy8vLr7GGbUqMk7WTyA7AH0RcWEN9JnUH5twhPm8tq/gAOl2OVVI7DVfwu2YT D5ow== X-Gm-Message-State: AOJu0YySx/WHvZ0+zG9a9Pbxwg9AaPTRnTICgqa/yDMWsA443qHLbu7s nrA3NS5Mmi2r9WzwP5dqsNyTMu8xfJ6uewY/C+0JpO0aGRC1nlttapwF2feqfjJPimnLAhjm2fM LBHQ= X-Gm-Gg: ASbGncsQmXhsi9/hY/Av1n4Btu1onSbVBmw/fXTvTd3HLeUGCnVWREJaIXUITSO1IM9 /uZjoROlzaLjNAkuzqqIieYkLpiqzYG00ODbSG5oteTApcjGRtBNayha0U7Ne065sKMUyM9+I8t 1c8hOGNgvLNJqoLst+/WoxoqBZ2VjjnKS4WQLVTMPzWpLQAn7GdMivSSACW6V800t2Df78ve5Ee vYy/EZLSFbsMVWxMMFgzOcxIaChTH0v2+DifKg7MZ1iKwypdAexrCoMgkIuvB5lhgXeQIsCRfaP Hh8ZC7I8v6i3hvxJ3ov7GTfRi10tyepK86Ptz7EvIRIvfYCFOV/kYkkuH9G4sXzmue3nV1NiB5o r0bp6Yi8qIH6+U0PwzejY2n55wGdn7LYwLxClDvzfvGGVxqw980BwSxwBv+3LaAOB9zsMdmFu9m cockKUE5xZ1UnzHokCHuI8d0MfqLNFDNYMRzg5j+QTUC6z58guQYDfB1BN35LwQztJzmUr8rth+ 58= X-Google-Smtp-Source: AGHT+IGUo5krvOHlWHuUrqWM84LfzTSr6Moq/i3I5gjCmPghpd0wOiBERWwyIY2Iuav9MBJxMqbuuQ== X-Received: by 2002:a05:6000:2585:b0:42b:2ee0:569f with SMTP id ffacd0b85a97d-42cc1d0cf1emr13037823f8f.33.1763987396439; Mon, 24 Nov 2025 04:29:56 -0800 (PST) Message-ID: Date: Mon, 24 Nov 2025 13:29:58 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH v2 2/4] x86/MCE: restrict allocation of thermal and CMCI vector to BSP From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= References: <5ac2e9b1-81f2-41d9-8f05-d546a49c43a7@suse.com> Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <5ac2e9b1-81f2-41d9-8f05-d546a49c43a7@suse.com> Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1763987418925019200 Content-Type: text/plain; charset="utf-8" There's no need to do this for every AP; just do it once when setting up the BSP. Then both vector variables can also validly become ro-after-init. While touching intel_init_thermal(), constify its 1st parameter, which in turn requires touching intel_thermal_supported() as well. Signed-off-by: Jan Beulich --- This contextually (but not functionally) collides with "x86/MCE: adjust S3 resume handling". --- a/xen/arch/x86/cpu/mcheck/mce.c +++ b/xen/arch/x86/cpu/mcheck/mce.c @@ -37,7 +37,7 @@ bool is_mc_panic; DEFINE_PER_CPU_READ_MOSTLY(unsigned int, nr_mce_banks); unsigned int __read_mostly firstbank; unsigned int __read_mostly ppin_msr; -uint8_t __read_mostly cmci_apic_vector; +uint8_t __ro_after_init cmci_apic_vector; bool __read_mostly cmci_support; =20 /* If mce_force_broadcast =3D=3D 1, lmce_support will be disabled forcibly= . */ --- a/xen/arch/x86/cpu/mcheck/mce_intel.c +++ b/xen/arch/x86/cpu/mcheck/mce_intel.c @@ -87,7 +87,7 @@ static void cf_check intel_thermal_inter } =20 /* Thermal monitoring depends on APIC, ACPI and clock modulation */ -static bool intel_thermal_supported(struct cpuinfo_x86 *c) +static bool intel_thermal_supported(const struct cpuinfo_x86 *c) { if ( !cpu_has_apic ) return false; @@ -110,13 +110,13 @@ static void __init mcheck_intel_therm_in } =20 /* P4/Xeon Thermal regulation detect and init */ -static void intel_init_thermal(struct cpuinfo_x86 *c) +static void intel_init_thermal(const struct cpuinfo_x86 *c, bool bsp) { uint64_t msr_content; uint32_t val; int tm2 =3D 0; unsigned int cpu =3D smp_processor_id(); - static uint8_t thermal_apic_vector; + static uint8_t __ro_after_init thermal_apic_vector; =20 if ( !intel_thermal_supported(c) ) return; /* -ENODEV */ @@ -160,7 +160,8 @@ static void intel_init_thermal(struct cp return; /* -EBUSY */ } =20 - alloc_direct_apic_vector(&thermal_apic_vector, intel_thermal_interrupt= ); + if ( bsp ) + alloc_direct_apic_vector(&thermal_apic_vector, intel_thermal_inter= rupt); =20 /* The temperature transition interrupt handler setup */ val =3D thermal_apic_vector; /* our delivery vector */ @@ -667,7 +668,7 @@ static void cf_check cmci_interrupt(void mctelem_dismiss(mctc); } =20 -static void intel_init_cmci(struct cpuinfo_x86 *c) +static void intel_init_cmci(struct cpuinfo_x86 *c, bool bsp) { u32 l, apic; int cpu =3D smp_processor_id(); @@ -687,7 +688,8 @@ static void intel_init_cmci(struct cpuin return; } =20 - alloc_direct_apic_vector(&cmci_apic_vector, cmci_interrupt); + if ( bsp ) + alloc_direct_apic_vector(&cmci_apic_vector, cmci_interrupt); =20 apic =3D cmci_apic_vector; apic |=3D (APIC_DM_FIXED | APIC_LVT_MASKED); @@ -993,9 +995,9 @@ enum mcheck_type intel_mcheck_init(struc =20 intel_init_mce(bsp); =20 - intel_init_cmci(c); + intel_init_cmci(c, bsp); =20 - intel_init_thermal(c); + intel_init_thermal(c, bsp); =20 intel_init_ppin(c); From nobody Sun Dec 14 05:56:51 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1763987436; cv=none; d=zohomail.com; s=zohoarc; b=a2WzeljqjVZTmokk+U53w3xjwfXrUhgRRe/r0KISpB9hhnx7uvzaHySohAoZJ3Dtjx5PQ2blQC2CLtzl2HLainW/HI4r6It6SuGgWAlg4eh/tYC6xW9VpVS5eR4SNWQkDMBVQL9RkK1c2mkIG2VqXbq443YmGu9QMaR4ahjb/TI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1763987436; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=tp+i/cfVucDDUMwChy0ACXhvtjRm+kadP0KVDlNVdFY=; b=b/a4sY9MxjvBtpWww2Vy15LfgbhUgsSkTxRI55P5VnGBk2LvzKux9yT7xuGQkSTlXYZLxyEBeAPYr+3WsilvutBaUdYY8ktcahGCVp8QVrfBfjxbhCbXfTHNXKaOCOEnHf0F+tAaoXPAm62ZK2qyk3r76v4He769CG5WoQbyYIE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 176398743637610.928075632930927; Mon, 24 Nov 2025 04:30:36 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.1170494.1495565 (Exim 4.92) (envelope-from ) id 1vNVi1-0006W6-Cd; Mon, 24 Nov 2025 12:30:21 +0000 Received: by outflank-mailman (output) from mailman id 1170494.1495565; Mon, 24 Nov 2025 12:30:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vNVi1-0006Vv-A0; Mon, 24 Nov 2025 12:30:21 +0000 Received: by outflank-mailman (input) for mailman id 1170494; Mon, 24 Nov 2025 12:30:20 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vNVi0-00053p-A9 for xen-devel@lists.xenproject.org; Mon, 24 Nov 2025 12:30:20 +0000 Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [2a00:1450:4864:20::333]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 56099bda-c931-11f0-980a-7dc792cee155; Mon, 24 Nov 2025 13:30:18 +0100 (CET) Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-477619f8ae5so23805535e9.3 for ; Mon, 24 Nov 2025 04:30:18 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-477bf1e86b3sm227956435e9.6.2025.11.24.04.30.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Nov 2025 04:30:17 -0800 (PST) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 56099bda-c931-11f0-980a-7dc792cee155 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1763987418; x=1764592218; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=tp+i/cfVucDDUMwChy0ACXhvtjRm+kadP0KVDlNVdFY=; b=ELyyH2BNaQGCzhcUPfOe/KTNq/w+qI/itRZgfkzjOmmGsU4rAbTDA+q66LC54q/o8e fMpdGzR2giR1gnQJijKScO7KGgMWY8CYqr5BQ8VJRpms+hmf6UGErr6Q7hhIRy4s3oTv lpaI30X3E1K6CJcnmnm3fhqvaETlM/tEnCbxNQivy3AgfO0FtcwJNWoikvcke+GgfUeB ly0rmN0LaAOZKy/gC0Vkl6JCS69hVNe0FrkSu6aVFxxqJDizLTdNSIZVpQNPEBqUQM/0 CF746EH+2K1SxzYbt7zILeSWeQts7+131S4MILbcpygfFIgpvt3OthWTcYapLPIxRsMT FIwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763987418; x=1764592218; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=tp+i/cfVucDDUMwChy0ACXhvtjRm+kadP0KVDlNVdFY=; b=he14Oj0G73gdusK12vNx7ReSZiKYFZfw24eNApoAeQpriRgvKTdFj9RX0kP9BlS4PL 52ye/4TpBvjNdszcHPGxozRPHDpa9trOxPnFueQh/3QPgm+B7gs4vyCou16jM6G/b2lQ +0sjn3+N7Aar61ew6SzipaGWCw5f3OIjYeaja3fUStZ5yiTGbSk/D1Hb0tjyah+woYQp JQVnZJPfBvQRpDubGm9TqSWJ6cXR9EHYBOnJQ0tFmQBROdabAof8PyvzuMU2hKZ7ucoc NUpyq6brGGuchOrazP3EZqDAAVTeDDIFA6VIiA2UIwa9LPfhhJ+dkFSMM6NeeNzgW3qm fjvQ== X-Gm-Message-State: AOJu0YzEqiK8n6F2FWKvAhU/f1pKlIm+9PUFa2haXUTbCoCAFB79/TYK UwTXBXGaE5jyJhEVT6rferU7O5LYu6ZTi957tAGV5zGS3jqRVe3J+5IBIg7AONS4JG8XRXWmbiH GhfY= X-Gm-Gg: ASbGncsCGc06BPtlPfKkN6uOiWl6ylmkuviwNfJx30FDbagUJmBV2pMfM/qnYWOtk4P QeBMuZOXnpNAqF7DIQIn5qBi4NQ4+mcRsK+IYVQzYi741Y/fUB5ByJXWED7u8jtJUnnHyX13vTc L2G5XoWpiGgqKnQMIFBpnCMLyzQk6HB+L+iZYLEruDwTXdAENtkpvCMT7sU3XScAUwVY9lL4ZYa nfthLDVXKrEeG5iVf9sl/8s0S02BycG6v33RKpWIxJvJ563K5QR2D9XWZ5Bi6I/u90r5rmSb8I1 iDF9skna2P2rtph6Ay2bfcWaXDtliBvLmWkVMhEVmSv1dwWrwJiPvBOEIbFf44yCOOS/v+gumVX 52+PFs0ePm31WtrBliHpcw8L122RXPVRK67h2/OTr6t1zhOqkN/DP0NsoQy/LiXtP3tpvWZqgY4 gc3t3D1ZIDoqJG4DPzdtcH9yptirKUCS5C4P/7TnPl3FceRQ+MqaWtSvEpJ+yMMIKn80w5vyxXT 98= X-Google-Smtp-Source: AGHT+IEFQcTpHEJ1+VAIief0RR0eJLlhlKIioP/kCJtvv1FC07NrLWROgp7R6dYhwWkowpZBrEWJ8A== X-Received: by 2002:a05:600c:3146:b0:477:df7:b020 with SMTP id 5b1f17b1804b1-477c01b2211mr111541015e9.18.1763987417740; Mon, 24 Nov 2025 04:30:17 -0800 (PST) Message-ID: Date: Mon, 24 Nov 2025 13:30:19 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH v2 3/4] x86/IRQ: direct-APIC-vector setting is now init-only From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= References: <5ac2e9b1-81f2-41d9-8f05-d546a49c43a7@suse.com> Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <5ac2e9b1-81f2-41d9-8f05-d546a49c43a7@suse.com> Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1763987437121019200 Content-Type: text/plain; charset="utf-8" With all callers of alloc_direct_apic_vector() now being limited to BSP setup, it and its helpers (whose other callers have already been init- only) can become __init. As a result data items can be adjusted, too. With alloc_direct_apic_vector() now being __init, it's meaningless to use a lock, and the indirection is also pretty pointless. Drop both while at it. Signed-off-by: Jan Beulich Signed-off-by: Andrew Cooper Acked-by: Jan Beulich --- v2: Re-work alloc_direct_apic_vector(). --- a/xen/arch/x86/cpu/mcheck/mce_intel.c +++ b/xen/arch/x86/cpu/mcheck/mce_intel.c @@ -161,7 +161,7 @@ static void intel_init_thermal(const str } =20 if ( bsp ) - alloc_direct_apic_vector(&thermal_apic_vector, intel_thermal_inter= rupt); + thermal_apic_vector =3D alloc_direct_apic_vector(intel_thermal_int= errupt); =20 /* The temperature transition interrupt handler setup */ val =3D thermal_apic_vector; /* our delivery vector */ @@ -689,7 +689,7 @@ static void intel_init_cmci(struct cpuin } =20 if ( bsp ) - alloc_direct_apic_vector(&cmci_apic_vector, cmci_interrupt); + cmci_apic_vector =3D alloc_direct_apic_vector(cmci_interrupt); =20 apic =3D cmci_apic_vector; apic |=3D (APIC_DM_FIXED | APIC_LVT_MASKED); --- a/xen/arch/x86/guest/xen/xen.c +++ b/xen/arch/x86/guest/xen/xen.c @@ -293,7 +293,7 @@ static void __init cf_check setup(void) XEN_LEGACY_MAX_VCPUS); } =20 - alloc_direct_apic_vector(&evtchn_upcall_vector, xen_evtchn_upcall); + evtchn_upcall_vector =3D alloc_direct_apic_vector(xen_evtchn_upcall); =20 BUG_ON(init_evtchn()); } --- a/xen/arch/x86/hvm/vmx/vmx.c +++ b/xen/arch/x86/hvm/vmx/vmx.c @@ -3181,10 +3181,10 @@ const struct hvm_function_table * __init =20 if ( cpu_has_vmx_posted_intr_processing ) { - alloc_direct_apic_vector(&posted_intr_vector, pi_notification_inte= rrupt); + posted_intr_vector =3D alloc_direct_apic_vector(pi_notification_in= terrupt); if ( iommu_intpost ) { - alloc_direct_apic_vector(&pi_wakeup_vector, pi_wakeup_interrup= t); + pi_wakeup_vector =3D alloc_direct_apic_vector(pi_wakeup_interr= upt); =20 vmx_function_table.pi_update_irte =3D vmx_pi_update_irte; } --- a/xen/arch/x86/include/asm/irq.h +++ b/xen/arch/x86/include/asm/irq.h @@ -119,7 +119,7 @@ uint8_t alloc_hipriority_vector(void); void free_lopriority_vector(uint8_t vector); =20 void set_direct_apic_vector(uint8_t vector, void (*handler)(void)); -void alloc_direct_apic_vector(uint8_t *vector, void (*handler)(void)); +uint8_t alloc_direct_apic_vector(void (*handler)(void)); =20 void do_IRQ(struct cpu_user_regs *regs); =20 --- a/xen/arch/x86/irq.c +++ b/xen/arch/x86/irq.c @@ -970,31 +970,28 @@ void pirq_set_affinity(struct domain *d, DEFINE_PER_CPU(unsigned int, irq_count); static DEFINE_PER_CPU(bool, check_eoi_deferral); =20 -uint8_t alloc_hipriority_vector(void) +uint8_t __init alloc_hipriority_vector(void) { - static uint8_t next =3D FIRST_HIPRIORITY_VECTOR; + static uint8_t __initdata next =3D FIRST_HIPRIORITY_VECTOR; BUG_ON(next < FIRST_HIPRIORITY_VECTOR); BUG_ON(next > LAST_HIPRIORITY_VECTOR); return next++; } =20 -static void (*direct_apic_vector[X86_IDT_VECTORS])(void); -void set_direct_apic_vector(uint8_t vector, void (*handler)(void)) +static void (*__ro_after_init direct_apic_vector[X86_IDT_VECTORS])(void); +void __init set_direct_apic_vector(uint8_t vector, void (*handler)(void)) { BUG_ON(direct_apic_vector[vector] !=3D NULL); direct_apic_vector[vector] =3D handler; } =20 -void alloc_direct_apic_vector(uint8_t *vector, void (*handler)(void)) +uint8_t __init alloc_direct_apic_vector(void (*handler)(void)) { - static DEFINE_SPINLOCK(lock); + uint8_t vec =3D alloc_hipriority_vector(); =20 - spin_lock(&lock); - if (*vector =3D=3D 0) { - *vector =3D alloc_hipriority_vector(); - set_direct_apic_vector(*vector, handler); - } - spin_unlock(&lock); + set_direct_apic_vector(vec, handler); + + return vec; } =20 /* This could free any vectors, but is needed only for low-prio ones. */ From nobody Sun Dec 14 05:56:51 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1763987455; cv=none; d=zohomail.com; s=zohoarc; b=BdUUxMpMfAd/kOQQCxm48UyRr477R+a1K07ltTQpTWUSxMwqhJxDXhyLmsZseRh5oHtC2tFdIFza5SMUJB2jf0yj4LTpqG1HCMbHOxIoyXIXF7pdS8S4Qyr8/jEXBNMMc0/paW5jC2uTSj4sSdW6l/kL1NCmqxSxMd5+JJl3lb0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1763987455; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=cLRL3+uYW8mTZJpIYDPRqMA57ukZVFvfr5R4kBjg4KY=; b=lBoV+l+484WYQmUzQcnjSpMtCQrBUnB66mepgKXbP3oXZSOL67lU806Z+3OwjXqedn5x+tmxuQfS8TOSy+GJoV2QhqwqK+tRpvD+vZX1+T61KDUe0T90K3MQ2PxIGQufi7hL/6s8I5l8fhrgM/mTLzoSL6eUp1DJlcEp5yZIAzk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1763987455529873.9122590704214; Mon, 24 Nov 2025 04:30:55 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.1170504.1495575 (Exim 4.92) (envelope-from ) id 1vNViK-00070C-Oe; Mon, 24 Nov 2025 12:30:40 +0000 Received: by outflank-mailman (output) from mailman id 1170504.1495575; Mon, 24 Nov 2025 12:30:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vNViK-000705-Lk; Mon, 24 Nov 2025 12:30:40 +0000 Received: by outflank-mailman (input) for mailman id 1170504; Mon, 24 Nov 2025 12:30:38 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vNViI-0004cg-Qc for xen-devel@lists.xenproject.org; Mon, 24 Nov 2025 12:30:38 +0000 Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [2a00:1450:4864:20::433]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 61c011c0-c931-11f0-9d18-b5c5bf9af7f9; Mon, 24 Nov 2025 13:30:38 +0100 (CET) Received: by mail-wr1-x433.google.com with SMTP id ffacd0b85a97d-42b3669ca3dso1711245f8f.0 for ; Mon, 24 Nov 2025 04:30:38 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42cb7f34fddsm29199079f8f.14.2025.11.24.04.30.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Nov 2025 04:30:37 -0800 (PST) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 61c011c0-c931-11f0-9d18-b5c5bf9af7f9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1763987437; x=1764592237; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=cLRL3+uYW8mTZJpIYDPRqMA57ukZVFvfr5R4kBjg4KY=; b=OYJjjF6X6fj9HVft6v+V4KgTTFbU7OMPFlP6L/LYVkCa0KTvBv+5Syu/iMQFiv5y89 OyY0jd46zBv3r5xaN4FUEKGLmgZ20Xte8lCtH+ZBJU4rxROLW14oKTkkXpcKNmzOwFHI krRplfvqYpnGu8AoyavAdsJycst+dNyd/ZrPVp77JgZ2+muM3Igr7VLDOg3uWhqGuH2S dHc05/iHR6lOCI4qVhIz9rHjWI6tsyAuHzTF0jyjVKljL9nLMslsdY/JOQQoPlz3hwKm w7Vkr0aiSQtyPqGQ+lJAPArYkTMgO95Bnxt1A09lf2C7ltVxA7G+dNFY0vznTFbcYYZe aa+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763987437; x=1764592237; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=cLRL3+uYW8mTZJpIYDPRqMA57ukZVFvfr5R4kBjg4KY=; b=SLAet+nflclUnl/56C6YrwTFsyknbz1L7LB2ZbgzkEHZ8pwpLDDK0TGMT2xjPPDcPo kWSJ/SVomgZh+ZFsY8HGrhznAMqfxJGT7/8eLJayCNynjuDnqsUcCDIgMzMVCjSr9jA/ nmKq1fuR9C3Md3xulzyjk7s6Mq7OEXSs+BLXsR+HFuoPh+lCpscKdamJQjG7joqNM9sx ox+6/gGDOMEsCixlv6A04T61+wGW6ErNRH5DDx9jww+O90Pi2pqDXotUaIvNBP+e4uVK t1WFuX9uaQUk3P2/PYYwn9lvCFhnXk/OLMVMoIf9OYBrVYvkggRoJOMr8Cp3K3UObBzd PPzg== X-Gm-Message-State: AOJu0YwCNTkH2u6DzkqwwJjf9zuZ9qQ00ds6JZFhRxVcF0Ls4TCxJRtX lgYhPKhbBWnAjlb0EBJZ7UGPvoAIeiCAXiR2WRmFOWZCdR1N4QZIafwmieKOSkfW+hjbfnlcTZi hKz0= X-Gm-Gg: ASbGncuA0ifw7KWBg79RJaM8Bi8lT1qseEwvhhxUtb9tq80wHU8LL+8wlHjPEs3EXVg H3k4X/vA0My0DMZ/wL2gw1xMVSusEnbVW7tAnH4hA4hzyZJI0alQg/CUc0nBoex89Mhoe5ZXRSU K7KBiwVLEwOuNq07txeHhfBQvjuEF+sFpCoK68p3xCan0lDdrDia7jg8ULgMIJ26ML38RSUVf1p +GT9BhAOBUIjf64bsYzqiwJpXHHThgvoc1OE5KXxtY+WCpjsi5oU938AnfVelsjK2sTyocSdxWM YChagPs65Zf41E3F960sdJc7GeNw/th489eUuG70z9zUaIJ726TBjUvEayyw2BbWYMTLMNTEjkk JKJMpP7zfVvcd8ray68NVBijOSSWntkVLFIQwvCaU5iJ8HIMW75QZJ79SIlC3pIqBF3ypbspGs1 YVc5abGpfu0uboYdAJUzut0K7IUIrk/3GJsUzNGdc463PwUYkj0dSpa/FcbHytx1O001bo+V/ie rA= X-Google-Smtp-Source: AGHT+IEM4p5ClNaoIlR+EwMjxV3393KV4qYIpcRb3vKdTSU9Iy1DUsTuApQp/kvXk7ivGLSOHjuGHQ== X-Received: by 2002:adf:b30a:0:b0:42b:3366:634b with SMTP id ffacd0b85a97d-42cc1d0cecfmr8055683f8f.31.1763987437328; Mon, 24 Nov 2025 04:30:37 -0800 (PST) Message-ID: Date: Mon, 24 Nov 2025 13:30:39 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH v2 4/4] x86/vPMU: don't statically reserve the interrupt vector From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= References: <5ac2e9b1-81f2-41d9-8f05-d546a49c43a7@suse.com> Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <5ac2e9b1-81f2-41d9-8f05-d546a49c43a7@suse.com> Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1763987457265019200 Content-Type: text/plain; charset="utf-8" Move the setup to vPMU code, doing the allocation of a vector only when one is actually going to be needed. With that the handler functions also don't need to be scattered across two places anymore. Add the freed up vector to the dynamically allocatable range. Signed-off-by: Jan Beulich Acked-by: Andrew Cooper --- In case down the road we also want to have a build mode with vPMU code excluded, this may also simplify things a little there. --- v2: Re-base over patch moving the APIC ack and over change to alloc_direct_apic_vector(). --- a/xen/arch/x86/apic.c +++ b/xen/arch/x86/apic.c @@ -1313,16 +1313,6 @@ static void cf_check error_interrupt(voi entries[3], entries[2], entries[1], entries[0]); } =20 -/* - * This interrupt handles performance counters interrupt - */ - -static void cf_check pmu_interrupt(void) -{ - vpmu_do_interrupt(); - ack_APIC_irq(); -} - void __init apic_intr_init(void) { smp_intr_init(); @@ -1333,9 +1323,6 @@ void __init apic_intr_init(void) /* IPI vectors for APIC spurious and error interrupts */ set_direct_apic_vector(SPURIOUS_APIC_VECTOR, spurious_interrupt); set_direct_apic_vector(ERROR_APIC_VECTOR, error_interrupt); - - /* Performance Counters Interrupt */ - set_direct_apic_vector(PMU_APIC_VECTOR, pmu_interrupt); } =20 /* --- a/xen/arch/x86/cpu/vpmu.c +++ b/xen/arch/x86/cpu/vpmu.c @@ -40,6 +40,8 @@ static struct arch_vpmu_ops __initdata v static DEFINE_SPINLOCK(vpmu_lock); static unsigned vpmu_count; =20 +static uint8_t __ro_after_init pmu_apic_vector; + static DEFINE_PER_CPU(struct vcpu *, last_vcpu); =20 static int __init cf_check parse_vpmu_params(const char *s) @@ -94,7 +96,7 @@ void vpmu_lvtpc_update(uint32_t val) =20 vpmu =3D vcpu_vpmu(curr); =20 - vpmu->hw_lapic_lvtpc =3D PMU_APIC_VECTOR | (val & APIC_LVT_MASKED); + vpmu->hw_lapic_lvtpc =3D pmu_apic_vector | (val & APIC_LVT_MASKED); =20 /* Postpone APIC updates for PV(H) guests if PMU interrupt is pending = */ if ( has_vlapic(curr->domain) || !vpmu->xenpmu_data || @@ -160,7 +162,7 @@ static inline struct vcpu *choose_hwdom_ return hardware_domain->vcpu[idx]; } =20 -void vpmu_do_interrupt(void) +static void vpmu_do_interrupt(void) { struct vcpu *sampled =3D current, *sampling; struct vpmu_struct *vpmu; @@ -322,6 +324,12 @@ void vpmu_do_interrupt(void) #endif } =20 +static void cf_check vpmu_interrupt(void) +{ + vpmu_do_interrupt(); + ack_APIC_irq(); +} + #ifdef CONFIG_MEM_SHARING int vpmu_allocate_context(struct vcpu *v) { @@ -369,7 +377,7 @@ void vpmu_save(struct vcpu *v) =20 vpmu_reset(vpmu, VPMU_CONTEXT_SAVE); =20 - apic_write(APIC_LVTPC, PMU_APIC_VECTOR | APIC_LVT_MASKED); + apic_write(APIC_LVTPC, pmu_apic_vector | APIC_LVT_MASKED); } =20 int vpmu_load(struct vcpu *v, bool from_guest) @@ -432,7 +440,7 @@ static int vpmu_arch_initialise(struct v return ret; } =20 - vpmu->hw_lapic_lvtpc =3D PMU_APIC_VECTOR | APIC_LVT_MASKED; + vpmu->hw_lapic_lvtpc =3D pmu_apic_vector | APIC_LVT_MASKED; vpmu_set(vpmu, VPMU_INITIALIZED); =20 return 0; @@ -860,6 +868,8 @@ static int __init cf_check vpmu_init(voi register_cpu_notifier(&cpu_nfb); printk(XENLOG_INFO "VPMU: version " __stringify(XENPMU_VER_MAJ) "." __stringify(XENPMU_VER_MIN) "\n"); + + pmu_apic_vector =3D alloc_direct_apic_vector(vpmu_interrupt); } else { --- a/xen/arch/x86/include/asm/irq-vectors.h +++ b/xen/arch/x86/include/asm/irq-vectors.h @@ -8,13 +8,12 @@ #define EVENT_CHECK_VECTOR 0xfc #define CALL_FUNCTION_VECTOR 0xfb #define LOCAL_TIMER_VECTOR 0xfa -#define PMU_APIC_VECTOR 0xf9 /* * High-priority dynamically-allocated vectors. For interrupts that * must be higher priority than any guest-bound interrupt. */ #define FIRST_HIPRIORITY_VECTOR 0xf1 -#define LAST_HIPRIORITY_VECTOR 0xf8 +#define LAST_HIPRIORITY_VECTOR 0xf9 /* IRQ0 (timer) is statically allocated but must be high priority. */ #define IRQ0_VECTOR 0xf0 =20 --- a/xen/arch/x86/include/asm/vpmu.h +++ b/xen/arch/x86/include/asm/vpmu.h @@ -99,7 +99,6 @@ static inline bool vpmu_are_all_set(cons =20 void vpmu_lvtpc_update(uint32_t val); int vpmu_do_msr(unsigned int msr, uint64_t *msr_content, bool is_write); -void vpmu_do_interrupt(void); void vpmu_initialise(struct vcpu *v); void vpmu_destroy(struct vcpu *v); void vpmu_save(struct vcpu *v);