From nobody Wed Nov 19 01:56:09 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1763390244; cv=none; d=zohomail.com; s=zohoarc; b=VgbscLE0c1ZjApz4sh7BY2TPwQarsCiL/t2cLMzRx/lKUitJhy0Knn7l4/7pA95eSn97DaXcGa79iG4NmPvcU57WHArmyWVMsmCcoJPOJTDOVi6dboxcarw0/QXh3hgUdkSP1S944HuLUkfUnHbyav9YYoGNb9VfjlP97L7W50I= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1763390244; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=AKQeDaPnIv1KfZ5B6JBPXaTggTJ6NzsOedI2MNMCM30=; b=XuE2yfKbgwLrzuDFQHreSgm1g2Vn3cS1iiUfPIBcKakIoTwXnVosL4a4jMwyPIZ/U1YYXjrsI0b6LlXgz3J2mSt2TvIOBS/OVxvTUMVDjdbDb97uh5PDD/qYUfBocm+RBStwKImu1MThCB0nJj4Z+w5xZPa0VmksYwjDvcqtk3k= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1763390244041823.1728644177766; Mon, 17 Nov 2025 06:37:24 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.1164050.1491065 (Exim 4.92) (envelope-from ) id 1vL0Lr-0005Zi-4C; Mon, 17 Nov 2025 14:37:07 +0000 Received: by outflank-mailman (output) from mailman id 1164050.1491065; Mon, 17 Nov 2025 14:37:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vL0Lr-0005Zb-0R; Mon, 17 Nov 2025 14:37:07 +0000 Received: by outflank-mailman (input) for mailman id 1164050; Mon, 17 Nov 2025 14:37:06 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vL0Lq-0005ZT-1t for xen-devel@lists.xenproject.org; Mon, 17 Nov 2025 14:37:06 +0000 Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [2a00:1450:4864:20::632]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e30d29f8-c3c2-11f0-9d18-b5c5bf9af7f9; Mon, 17 Nov 2025 15:37:05 +0100 (CET) Received: by mail-ej1-x632.google.com with SMTP id a640c23a62f3a-b739b3fc2a0so167231766b.3 for ; Mon, 17 Nov 2025 06:37:05 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b734fad4635sm1097379066b.26.2025.11.17.06.37.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Nov 2025 06:37:03 -0800 (PST) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e30d29f8-c3c2-11f0-9d18-b5c5bf9af7f9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1763390224; x=1763995024; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=AKQeDaPnIv1KfZ5B6JBPXaTggTJ6NzsOedI2MNMCM30=; b=LsDfhiB2wCikk4KkLyTIKYREJktRIGeECR1sI3hp+/M51IxKi362k1fFaMLh094B8L BlvnGWQGxR+0UJK76coJRK6nfK82go9pyldtl7/KP2yD2Js41qEcayt1qUtQhOLRaHBt bfnCDaQXPJuQfmCqzX2weRMtkfd9v+hTLkf0nRvyjSXMtSWRPZUvRU+SEqwvjjPJ3UOA uybNKHqD9gFizgTdat/2NZ8uvmVne46NGZnTklUM7Qd4ZnTGnX/YLyOts4WR8RmJPJT9 qP8VsmrKR/NtBgyPyaWEugokegJ9lKRCFXXfChH+5RnVp0wyFwIBky8fk5gik052uaak xPmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763390224; x=1763995024; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=AKQeDaPnIv1KfZ5B6JBPXaTggTJ6NzsOedI2MNMCM30=; b=N2R17P6ebgplDwmRF8xSwQx150VBX0r+o57SFqbEm2x1NK71dj3V2WPmfYzh2eAbMU cgJxMhoBaiu2GlgH5Dk3TsM00tVQetN2LiGAi4sKiFWL4qbSgu7F6fs9HrAoz19Oisdf kpYTf/h9msQStD8y2l+pIeepadYeyag2gpnTBNSx7yTOYKmWoV26978i82DiSLiM6rLK XDE4S2VCwdyA6xRPNp7gdrVfl6Bjgp9kBGlRqBK7brNrOuja1PVz+yaqJnFlHIlY2S2G 2fKsuw46Q5PeWxNJ7yZjyfLOUkPRrCAVyWA7giX+eaM85D6k9brDcL/+Dcin24CDLs2N C7mQ== X-Gm-Message-State: AOJu0YymdKT7ULArYFJy3aMptTH+Sb65m0CbETomWOW2THV+2fODuY13 Di3BO9kLyhijS/lUADb1f7LMBKSmI4BACDh/j3gZQIz1u1MQkSFAQs3mBpriwwd1iQ7gf2QtT9w lClA= X-Gm-Gg: ASbGnctPBhDTxThzJROg3NvryF1xpFpwC8FJ3RgTJBkeZMjYpi7bv2wACADVv2/zK2B +9qUgachwspmPylGoFa1iT/403mhqAvVrA7szHn0XaK1d4Y1Mdlr4HID6a0TI0rKrS/GzDWKPOj pLoZ3tznfnA4bhEE7U3NmXrhzGZscq6eMdEyM7jp8vF984reqlHEDMHGEEA6jh7GP0tkfJhPTig xQsa6C2tGmCk3wZainVwD+5CnEbdsqj3SKNyENXprXt+JbR/lBX7+j0kcCFJ9CghSGA7XjKmawF coGOctfkUXo5PN4MB6S9DRAKBRZzPbcGEWjS2wX1CFgZ7RRHulfTXfqU+DtckTxkVamHLCxcIqx umh1yZ2R14RuJTq8F7K3kdDW1jO2TAFnl2Kbbi7oeiY3dYmaE7xD+JvbjMkEUlRmDNYEkZVi9x0 sYeydrPjsi6OEy6gc2ajYTQz85q3/AS3c5rNuztP+XpCVk867NE8Hh623SzdPeGJ49M65HNrTvU Ger3EITTLhyUw== X-Google-Smtp-Source: AGHT+IEkCvQPlPu4gcwC5trd8MEVUbQiQgtKA88WNv5FDtC9Zf0YNwlyJgEtQZ6fQFNQdG4Wr19P5Q== X-Received: by 2002:a17:907:3cc3:b0:b73:2d99:d8a3 with SMTP id a640c23a62f3a-b736782d0a8mr1464255166b.26.1763390224429; Mon, 17 Nov 2025 06:37:04 -0800 (PST) Message-ID: <1af753e5-33a1-46de-a407-969059e7228f@suse.com> Date: Mon, 17 Nov 2025 15:37:04 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH v4 1/8] x86/HPET: avoid indirect call to event handler From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= References: <57f34114-54b7-483d-8ac0-e9fa49df959f@suse.com> Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <57f34114-54b7-483d-8ac0-e9fa49df959f@suse.com> Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1763390250211153000 Content-Type: text/plain; charset="utf-8" It's only ever handle_hpet_broadcast() that's used. While we now don't enable IRQs right away, still play safe and convert the function pointer to a boolean, to make sure no calls occur too early. Signed-off-by: Jan Beulich --- v2: Re-base over changes earlier in the series. --- a/xen/arch/x86/hpet.c +++ b/xen/arch/x86/hpet.c @@ -40,7 +40,7 @@ struct hpet_event_channel s_time_t next_event; cpumask_var_t cpumask; spinlock_t lock; - void (*event_handler)(struct hpet_event_channel *ch); + bool event_handler; =20 unsigned int idx; /* physical channel idx */ unsigned int cpu; /* msi target */ @@ -194,7 +194,7 @@ static void evt_do_broadcast(cpumask_t * cpumask_raise_softirq(mask, TIMER_SOFTIRQ); } =20 -static void cf_check handle_hpet_broadcast(struct hpet_event_channel *ch) +static void handle_hpet_broadcast(struct hpet_event_channel *ch) { cpumask_t *scratch =3D this_cpu(hpet_scratch_cpumask); s_time_t now, next_event; @@ -250,7 +250,7 @@ static void cf_check hpet_interrupt_hand return; } =20 - ch->event_handler(ch); + handle_hpet_broadcast(ch); } =20 static void hpet_enable_channel(struct hpet_event_channel *ch) @@ -657,7 +657,7 @@ void __init hpet_broadcast_init(void) hpet_events[i].next_event =3D STIME_MAX; spin_lock_init(&hpet_events[i].lock); smp_wmb(); - hpet_events[i].event_handler =3D handle_hpet_broadcast; + hpet_events[i].event_handler =3D true; =20 hpet_events[i].msi.msi_attrib.maskbit =3D 1; hpet_events[i].msi.msi_attrib.pos =3D MSI_TYPE_HPET; @@ -814,7 +814,9 @@ int hpet_legacy_irq_tick(void) (hpet_events->flags & (HPET_EVT_DISABLE|HPET_EVT_LEGACY)) !=3D HPET_EVT_LEGACY ) return 0; - hpet_events->event_handler(hpet_events); + + handle_hpet_broadcast(hpet_events); + return 1; } From nobody Wed Nov 19 01:56:09 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1763390259; cv=none; d=zohomail.com; s=zohoarc; b=bgNLZrrHMCvZc7p1YGGPpyfTo5TTt+LgxI67y+aq/NAWjEfCPT3CuBZhmjTSYMh6fZyp49N0b3AX56SQ7Z3wWBKrlB4GSZmiwpdVQQySrrEHh4YfVGXpBKUXCkAsy+Kv7f0dg1U4eSYOD5R/vLM6fciT6Uh88S8JkPvSWvUJUjA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1763390259; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Pi3hAuAMJUxmVpqdTz3Up9yhIVz/lddzqlLZoEEpb3Y=; b=Dq6pTWyYzqjFmDJxZ6240yj3TxolzVmXMUqbF3Hv+fdXjbOremdy3ocPxNX+ILc7M5852G6dpddMQqgJ+VIX83T8VP9KteB7nBABugTs0IVD0FXKVGk1gZsWFmAcrHZfxI9ScYTycc7JcDFjtXKZBs1oXY7VnEYYwYEwwFk7L38= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1763390259564605.6431125244869; Mon, 17 Nov 2025 06:37:39 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.1164056.1491075 (Exim 4.92) (envelope-from ) id 1vL0M8-0005wL-D0; Mon, 17 Nov 2025 14:37:24 +0000 Received: by outflank-mailman (output) from mailman id 1164056.1491075; Mon, 17 Nov 2025 14:37:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vL0M8-0005wE-AN; Mon, 17 Nov 2025 14:37:24 +0000 Received: by outflank-mailman (input) for mailman id 1164056; Mon, 17 Nov 2025 14:37:22 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vL0M6-0005ZT-PL for xen-devel@lists.xenproject.org; Mon, 17 Nov 2025 14:37:22 +0000 Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com [2a00:1450:4864:20::52f]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ed5a8193-c3c2-11f0-9d18-b5c5bf9af7f9; Mon, 17 Nov 2025 15:37:22 +0100 (CET) Received: by mail-ed1-x52f.google.com with SMTP id 4fb4d7f45d1cf-64162c04f90so7138732a12.0 for ; Mon, 17 Nov 2025 06:37:22 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-644f13ff4d4sm893247a12.12.2025.11.17.06.37.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Nov 2025 06:37:20 -0800 (PST) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ed5a8193-c3c2-11f0-9d18-b5c5bf9af7f9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1763390242; x=1763995042; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=Pi3hAuAMJUxmVpqdTz3Up9yhIVz/lddzqlLZoEEpb3Y=; b=RvbtP2u5m2d/rQ5SI0xoWx/CitlxRnJj264SMUw1LxHRc2Oy2NQO2SnQLUJqxGCTsa 7Z+K+mnwfzgVf8A+X975gsJrMTKet6mXBxgKC5pkVIEOv6kL8gHXVvGpQfGSptpWP0yn yXpZw07OQcS08j7z2bWmMFPBvmQfQ54oPO/kx1YUcou67Ur1xSNOPLV+j1Mo4Jkq0uDK 3CwoF+PwiPlz0MeJd0SFp7kuCVbSNdkiK6+EjrjsLyFnNn8lJYpjU1tjCpO2VB6g6+za 1SMSoxxRUroN8A17ep9C0XTbgedu9JQdKjy4r03yydSdNBS51y3iS22nFi2rzCiBdnZy B7tg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763390242; x=1763995042; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Pi3hAuAMJUxmVpqdTz3Up9yhIVz/lddzqlLZoEEpb3Y=; b=oFEqW2XXM31+SXqz8ei/TEK75ivL+8RCNhzBOgBL3Fc/HnIKbqc1IcJG30MouGdvgI d36QYlvjjsSkC+ZxF0UkawnhfiBZAQzCDI11S06rXcsYg9eBgY8b/Wti9oQzkKJJ57cb i6FKl8bF26/zbFdLk5Yl1BetzpP20T711L7DFuQL+buisu57Mx29ETXZESDHHLK1JpqV 0UDF2onUy8B9dwvmAbqWUYY8I9Kxt397yhkatgWj+iwcy21U3cMGKTCXOtP0OSLK4J1Y NQmMJbqXDaZZYmJEN4yLooqdAatZVfOWxHQlF9sIUYKyByCgd/uUrNsHZMRuuCxFf2/G X06Q== X-Gm-Message-State: AOJu0YzCjc1PyEZgVTWmxtkDRR6Ejhwypr8e3kKt/sOHOgowqibRejNk AGNd7D7I5JZa+X63g8LBHoHsHpaf5phVIA4xjnpyZ3vcbLeg+GHD0XdaEIG/Ia2E1Gv39Duaz+S eQTk= X-Gm-Gg: ASbGncsFuToW6x90LApVQ0qdbAUSAlpaqub8HcAwlta8x/1/JyUYp6DW47iBetMPuOe SiPJhNjwziv/zsTRNkb+5wI40DpL2s3aVaMiXwZ1+rwOUj8hGL0ZrPoSj3opoviFmbvJWWkeWbQ tkHy33pLO/VLVISqmaUFjXtR+c1l4+3UV6Mp5PTXYOkmEtgmBTIANIBBqkcIzejuywtd9Kw0CIZ mubROWmnLoqRlV61TxeRIRkJYxzC1bYt1wroVg/xMUnj6Z7eyyCIZREugV2eZzyECqb800PK1i+ n5NT63uSiOOWu3GqL7B1OMudhG83PsTeMttErYA8djB5IWN3haD8NL9QD2k9J4QG6fIsXQZ31Ak esYv1t+NVlIV9ZnOksB6FM6gWepUXF+BLAqkg1fuia8txasuSO+Yn6KbxwQhg3nUKPUFp3WgTig llHv9z9Paeno3Z9wlXrhFQa5fY/dj6nsTXjFAhof7+cka90FdmiUZjT044bUlLXZBDumFFmXExr o8= X-Google-Smtp-Source: AGHT+IFniZkxnTJdJQe9SScifhauIDQBS+wodcuIYDT2WN5jhRL8z9Lkoll/wu84wNy3F5AVzLg9gA== X-Received: by 2002:a05:6402:354e:b0:640:ba44:c731 with SMTP id 4fb4d7f45d1cf-64350e76377mr9584890a12.21.1763390241623; Mon, 17 Nov 2025 06:37:21 -0800 (PST) Message-ID: <757cba5d-2c9f-40ae-8eae-6309979bbba5@suse.com> Date: Mon, 17 Nov 2025 15:37:21 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH v4 2/8] x86/HPET: make another channel flags update atomic From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= References: <57f34114-54b7-483d-8ac0-e9fa49df959f@suse.com> Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <57f34114-54b7-483d-8ac0-e9fa49df959f@suse.com> Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1763390260759158500 Content-Type: text/plain; charset="utf-8" Unlike the setting of HPET_EVT_LEGACY in hpet_broadcast_init(), the setting of HPET_EVT_DISABLE in hpet_disable_legacy_broadcast() isn't init- only and hence can race other flag manipulation (not all of which occur while holding the channel's lock). While possibly any such updates would only ever occur when HPET_EVT_LEGACY isn't set in the first place, this doesn't look straightforward to prove, so better be on the safe side. Fixes: d09486dba36a ("cpuidle: Enable hpet broadcast by default") Signed-off-by: Jan Beulich --- a/xen/arch/x86/hpet.c +++ b/xen/arch/x86/hpet.c @@ -729,7 +729,7 @@ void hpet_disable_legacy_broadcast(void) =20 spin_lock_irqsave(&hpet_events->lock, flags); =20 - hpet_events->flags |=3D HPET_EVT_DISABLE; + set_bit(HPET_EVT_DISABLE_BIT, &hpet_events->flags); =20 /* disable HPET T0 */ cfg =3D hpet_read32(HPET_Tn_CFG(0)); From nobody Wed Nov 19 01:56:09 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1763390282; cv=none; d=zohomail.com; s=zohoarc; b=TpsxSxgfO2L5dtd31/vD0tiCTlmJs/ZQGw07Yg1Vugxh1bILUycJ/sPblUK2xUNK1nPsVZujlX6/BmKO3ZlQNTNkZAcnWw3++wTMnPq3sSeDa6R3EgacU86evgAvQoh6H52nscZIGwNeBuGhuRNgJzIXx3m1mmT+/xzmWSxf6mQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1763390282; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=FxLRE0WPEJ3Pkau/hTURV7LKflRLzGIKPzRs3Fi2rrI=; b=IrPnL7QKq9i1JcSHljvj09p/5ciUAJ9n/+WwKsBgz6SVkBwhatMecAjhNq/X5O3MhnroIzzoo5WrzVRAgGNwx1C4WOJ+OFJWVlfbGgn8PK4MCDzrGP60POVgTxH6NDDaOueQiDNtKX4sqfdgHHTNxd3lWfVE5sZB9VGnE9G9QKA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1763390282183327.47413439198203; Mon, 17 Nov 2025 06:38:02 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.1164071.1491084 (Exim 4.92) (envelope-from ) id 1vL0MW-0006Yd-KG; Mon, 17 Nov 2025 14:37:48 +0000 Received: by outflank-mailman (output) from mailman id 1164071.1491084; Mon, 17 Nov 2025 14:37:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vL0MW-0006YW-HQ; Mon, 17 Nov 2025 14:37:48 +0000 Received: by outflank-mailman (input) for mailman id 1164071; Mon, 17 Nov 2025 14:37:47 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vL0MV-0006Gl-LO for xen-devel@lists.xenproject.org; Mon, 17 Nov 2025 14:37:47 +0000 Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [2a00:1450:4864:20::52b]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id fb706bc0-c3c2-11f0-980a-7dc792cee155; Mon, 17 Nov 2025 15:37:45 +0100 (CET) Received: by mail-ed1-x52b.google.com with SMTP id 4fb4d7f45d1cf-640aaa89697so5705983a12.3 for ; Mon, 17 Nov 2025 06:37:45 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b734fed9e9fsm1088430066b.69.2025.11.17.06.37.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Nov 2025 06:37:44 -0800 (PST) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fb706bc0-c3c2-11f0-980a-7dc792cee155 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1763390265; x=1763995065; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=FxLRE0WPEJ3Pkau/hTURV7LKflRLzGIKPzRs3Fi2rrI=; b=YluFULYMLCtEiU3EFaayRBSI3AbRgLmxQwifVW4PrbcvMR1BBONmqXRsIY+yKcpp9B vNrGzZl1sQfd/8f11PawnBAj08ftXlYpU4zexjr9q3v6FD7KztHHgHYi70dyYElk8qWP D0jbxA9wKjeV/ylxX6pa6IGrZB7uw6HaMNX2wqTmU+UPcj5Vt8W2gWRf4Kiy8GkEMCbk v4EVCn8xExWZXiDSkR480ttEJO2hf1YBiFtPgk5+tvLImTdBeX1faqHcm/7cK/gKk+kn 1zqJDeVjsPKL/7wPwIE0EGfIy3Op4j91VHjByh0eNfeINlu9ZFlNBWsEdvA51+XFK8U9 N/Fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763390265; x=1763995065; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=FxLRE0WPEJ3Pkau/hTURV7LKflRLzGIKPzRs3Fi2rrI=; b=Vo64BfkOdENM+zrSu6TwuUDuVPUJz2eDI3ODrf6biScLXN67IWYNjlcjagZQQE4cP1 E4heFfWgu1b3dTWZIzevOuEUfzGbJOG0dRzG7JMEYNoqFoZdmzE6Tco6b2jft45wGscI NfjQ2HSCdhVy8Cr0jqnelbgjDUpJ9tyyvaJ/G2KbkCecINURzHnZ8g+VH0e2fIAOAXVZ rpm3x4M/4IRsV3ZYo84FHEUf3+rhjUIuivRZcx8dOfE09yt7ZXgqpw4UiWCIeXJomtE4 +w6LW+8kcVYtUcdAv+GJ0KSQJ6iqnhJFtkyoC9DIXbDE42zMoXJEVuvOukQuR++qERl4 FBAg== X-Gm-Message-State: AOJu0YxYv75nTur4YhRGi2vO92H6jKHQC80VoHv0+K4l8gKminYfNa2U 4pJ4qQxEnzbQ00w9QugWQHhaoSE3C+T+aWKPOyPxbq2CAoC8933Ae96W3JgWJFaVEaJPHere2eX KOG0= X-Gm-Gg: ASbGncv9AUS8NmWqPrgqNGCcLsJ+B7lqoyUKAEp+V31Y42ddh9c3a5QkGdLuiJhME6D 6dvqbO+4WgLd75n99sTXOxLpdaddNSMtBHNDOc6pfUHDU7/xmJ3g1+n7j2FEC0hZgBLMKT8frtw Sl8DseBiXA37j4BFZ4g7Hnh6UIHG+yrpWCNKIHoUZeJK99ECCN68GgLjmXMGIy52ZBaqRY9heap m5e9rGkPMcDd+yx/svwt8aFwy2VqhZPBmrXIb5BqqcIQXj+vl/bo3k47H1+Cblxm9Mb4vXWGeb5 DN07dbNuTdmD95xH5U00i+qJdRyXTuh+K6j1g5rqwVrH3uMW4zzZ3QsAHRICr16pQg7wjAH/cV6 pgcWWZ0CA4l590OUWYom/WMRif4Jt3MtwkHcWy91DqESXiC7Nc0awPxQOjfcfoeiHUgRbt1+3JA w+W1j5Yu4v/FxuMWh66ehHmHUqPZ/QbBqB4RduVQdCiAFtNYxDl9W70of6kUxRUlf8 X-Google-Smtp-Source: AGHT+IFY/O9NLahv0nVl+GxpqwZFTlElQ1yNgeGIgARKr4xxHgOQkldYRdySVAXTi4XTVWNdWDYVug== X-Received: by 2002:a17:906:279b:b0:b73:6987:e902 with SMTP id a640c23a62f3a-b736987f3d3mr1083323466b.48.1763390265424; Mon, 17 Nov 2025 06:37:45 -0800 (PST) Message-ID: Date: Mon, 17 Nov 2025 15:37:45 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH v4 3/8] x86/HPET: move legacy tick IRQ count adjustment From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= References: <57f34114-54b7-483d-8ac0-e9fa49df959f@suse.com> Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <57f34114-54b7-483d-8ac0-e9fa49df959f@suse.com> Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1763390283519153000 Content-Type: text/plain; charset="utf-8" If already we play with the IRQ count, we should do so only if we actually "consume" the interrupt; normal timer IRQs should not have any adjustment done. Fixes: 353533232730 ("cpuidle: fix the menu governor to enhance IO performa= nce") Signed-off-by: Jan Beulich --- _Why_ we do these adjustments (also elsewhere) I don't really know. --- a/xen/arch/x86/hpet.c +++ b/xen/arch/x86/hpet.c @@ -808,13 +808,13 @@ int hpet_broadcast_is_available(void) =20 int hpet_legacy_irq_tick(void) { - this_cpu(irq_count)--; - if ( !hpet_events || (hpet_events->flags & (HPET_EVT_DISABLE|HPET_EVT_LEGACY)) !=3D HPET_EVT_LEGACY ) return 0; =20 + this_cpu(irq_count)--; + handle_hpet_broadcast(hpet_events); =20 return 1; From nobody Wed Nov 19 01:56:09 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1763390343; cv=none; d=zohomail.com; s=zohoarc; b=C4sVuytgUM6xwKU1L1UTj7iUxPwThEgtsEs5WTOn/Z3mRzzZxOjztWTa/6ivoGOqGoJi5nW9A1D7P+yr3AaT0CtN8SB+f3LxA4VetaQmK31/hXzNtMzqhG4ToVPVjGD24spIclIuJjy3FSR1ux/JtNMSy+6rn1hkGQHL0Kt3Sws= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1763390343; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=rds4jnnN9NVrTZyuc+q65+QBQEjCAV7rC8oJIxMqDF8=; b=g2hinHGof0ouXzzbZSyX6aAWPs3Pn0YR24o8ZG6bl4rOzDpG92Wzn1U7hKU8KWc0OFC3Xh0AlYjgDtZx+G+ZWSZb5wQYGlJ9LiKOq4o9JARvpHZhVAlxZJcq6aCEr4IQNGKdSanqsS5qBfifk7TnV6QSqpiM1xXx1saF1fOmMvE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 17633903433181018.1347845963411; Mon, 17 Nov 2025 06:39:03 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.1164087.1491095 (Exim 4.92) (envelope-from ) id 1vL0NS-00079w-Sz; Mon, 17 Nov 2025 14:38:46 +0000 Received: by outflank-mailman (output) from mailman id 1164087.1491095; Mon, 17 Nov 2025 14:38:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vL0NS-00079p-Pk; Mon, 17 Nov 2025 14:38:46 +0000 Received: by outflank-mailman (input) for mailman id 1164087; Mon, 17 Nov 2025 14:38:45 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vL0NR-00079j-Fx for xen-devel@lists.xenproject.org; Mon, 17 Nov 2025 14:38:45 +0000 Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [2a00:1450:4864:20::636]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1dc17cae-c3c3-11f0-980a-7dc792cee155; Mon, 17 Nov 2025 15:38:43 +0100 (CET) Received: by mail-ej1-x636.google.com with SMTP id a640c23a62f3a-b736d883ac4so530683566b.2 for ; Mon, 17 Nov 2025 06:38:43 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b734fd809fasm1102791066b.45.2025.11.17.06.38.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Nov 2025 06:38:42 -0800 (PST) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1dc17cae-c3c3-11f0-980a-7dc792cee155 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1763390323; x=1763995123; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=rds4jnnN9NVrTZyuc+q65+QBQEjCAV7rC8oJIxMqDF8=; b=Xnnul6Y6+e7SeE7ESpogxBMfFwp2oz6ZV+sRaiR3xGU4IFvSuXiBg3qx0C4yqGuWNA 8qlL/WW94rPDMkVFgmoi9Bam/+ioKemY3saENxT8yxWdJVuKveU7EAwHKvb4A/byVstR f7jPbPZ9J42Mpnw7pwIffLoovuqZkSsk/ecjiuJgfC3M5E2UW83fbNb7CB5IBqPMIz75 KaQ+B/iM22s7gcr6zuIqpNInT7tSFQDJ5bO3nw0RIe8X2DPBbUYrdk5LqqJ14KXRERSA okiheAPJ7RFH8Nsy+1SzShF/O02x6P+yOHcmlhmKGABeRE+14brcPxUohNmGKlp/+1nq xrDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763390323; x=1763995123; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=rds4jnnN9NVrTZyuc+q65+QBQEjCAV7rC8oJIxMqDF8=; b=Mvz0k/MDFa+Kl88totXaIWKv6l0aWdP1SwVj9tmQ11KnsUq/6m2Onm0SBoRnb/wjt1 UopjN22tBS9ykjh+fnq4am/jt7HA8x1s89Mt2IyZwHuVX33xJYpz7LWP7b8YulXXBkQf tETftBs3JjyquWOjv3hdMgZ+Ay/3Xdq4lDO7Tw2+QqqZJHEp1iyNjFSd28fS1FruBDpw JA5t/T6wvl+Uqgvnp70tYJqrJwYGvysfsIvQUN7FJknnLOeCYQd3evUHlUSdEKwWkexD vtF1HGCZ9fl28yn1PsQzM37j5tiuPJ45BnDYYF7jXlpnJnw6U54MeOvwW4/KKgdAAfQi Q1FQ== X-Gm-Message-State: AOJu0YzzQrNsW3kJdOQ8vcC6ddfyP3ot92yrHajFJBCs5I+hGUA0LtWA cCuEtzhyVzBo97Gn0vPew4K3bLiM1mY8kxt06u7+ocn3p9XxlI4bVbFNwjM9V71S+gK7b16ZXvd 3h3k= X-Gm-Gg: ASbGnctlotq6jbA1U6EGbDdL6Na394XCtNiUmJ0hD6JYnXg3Q4Mhxhp79SMmbw3UqjO UucEO5JMe540kJilQ2W3xuw45/fkaDnQPJ75C6Zj8B7hgFyCU6Q8fhm6MnXnUXSES24RDPjfFax 5yKd5CvudIqv4TN8kQxEbNf6PyvMUWJ958dr2FtKsLFGyoRS0UBJgM1o48sk2U3VOnRtYKFcmSS Idbr9DKKhXfCiUdUa1nuoj8DFCmw3IZNUuL4cuPwe/aksqkFJLEJU6Zb4VK9OCa1fURJTZaEH71 CciJ//okeBuO4K28EG2Xfz0kWuv3Acl/5teKK1mOnsNKU3mY+nijV3Y7fGJCLOR/xtv5y+GY4nA oMbGSWR24zgg6PW1yYdGrh+IyRADM8uhZyye/vdjeof7s4c390EWFjiRen0/0g0imuGlDXZy8sQ 5n+Yo7L8sMiw4woT9K2CLV6H7MnVrIewqg3dUN6S/9UDgnlqSsrT7o5mKIYlwvuSdU X-Google-Smtp-Source: AGHT+IHN8hAro7HMRpjt+WtI+SDOHX9UIMDu50lsNW7OSX79hbx5UOZi6OJEXaCRRxswTg/tv/wsqw== X-Received: by 2002:a17:907:6d0b:b0:b73:58b4:1247 with SMTP id a640c23a62f3a-b7367926438mr1286890866b.25.1763390322891; Mon, 17 Nov 2025 06:38:42 -0800 (PST) Message-ID: Date: Mon, 17 Nov 2025 15:38:43 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH v4 4/8] x86/HPET: reduce hpet_next_event() call sites From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= References: <57f34114-54b7-483d-8ac0-e9fa49df959f@suse.com> Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <57f34114-54b7-483d-8ac0-e9fa49df959f@suse.com> Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1763390344337158500 Content-Type: text/plain; charset="utf-8" I'm surprised gcc doesn't manage to do that: At least in debug builds two call sites exist, just like source code has it. That's not necessary though - by using do/while we can reduce this to a single call site. Then the function will be inlined. While improving code gen, also switch the function's 2nd parameter to unsigned. Signed-off-by: Jan Beulich --- Oddly enough the CDQE is replaced by an entirely unnecessary 32-bit MOV of a register to itself (i.e. zero-extending to 64 bits), as that's immediately preceded by a 32-bit ADD targeting the same register. --- a/xen/arch/x86/hpet.c +++ b/xen/arch/x86/hpet.c @@ -124,7 +124,7 @@ static inline unsigned long ns2ticks(uns return (unsigned long) tmp; } =20 -static int hpet_next_event(unsigned long delta, int timer) +static int hpet_next_event(unsigned long delta, unsigned int timer) { uint32_t cnt, cmp; unsigned long flags; @@ -173,12 +173,10 @@ static int reprogram_hpet_evt_channel( delta =3D max_t(int64_t, delta, MIN_DELTA_NS); delta =3D ns2ticks(delta, ch->shift, ch->mult); =20 - ret =3D hpet_next_event(delta, ch->idx); - while ( ret && force ) - { - delta +=3D delta; + do { ret =3D hpet_next_event(delta, ch->idx); - } + delta +=3D delta; + } while ( ret && force ); =20 return ret; } From nobody Wed Nov 19 01:56:09 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1763390360; cv=none; d=zohomail.com; s=zohoarc; b=Chd/wEpkX6OWBFuQKUX1jZxcpmwuHdwHmVtoGthli8x6igf5MZvHk6FJ1PUiDaekQ4oJWC7JXgBjRkVxik1fQJ0w7P3lNMH1q9pd2WGF7tZmEDcKcx4ttbLiWJI7KhNjH4xWxA48whZjQM3UwKDWPyKlFHF8gBBzPxcUruIkqZo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1763390360; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=PS7ucokoN9+hEjFZSIghu/GmWjPiHcD6tMlnYOR0lq8=; b=MC8Pj+kOa5qt/Cd0g985GyyMLNJ0mpWRorjF29Ii8vly8wR6YFM/FKSqCcmxJFZSiov/2kApQIsYDVu3wKbegdSMFfJy/1aYv6NLtwmvWg6pAOPbCvHRL6r/zx+bxLAfiiP9dRkCEECnbDtlCtqU7YwIT3vwP7m/6fKTYWNB6KQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1763390360827350.8848039410926; Mon, 17 Nov 2025 06:39:20 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.1164093.1491104 (Exim 4.92) (envelope-from ) id 1vL0Nm-0007Za-2H; Mon, 17 Nov 2025 14:39:06 +0000 Received: by outflank-mailman (output) from mailman id 1164093.1491104; Mon, 17 Nov 2025 14:39:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vL0Nl-0007ZT-Vu; Mon, 17 Nov 2025 14:39:05 +0000 Received: by outflank-mailman (input) for mailman id 1164093; Mon, 17 Nov 2025 14:39:04 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vL0Nk-0007Pr-9T for xen-devel@lists.xenproject.org; Mon, 17 Nov 2025 14:39:04 +0000 Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com [2a00:1450:4864:20::62f]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 29a8dfb7-c3c3-11f0-9d18-b5c5bf9af7f9; Mon, 17 Nov 2025 15:39:03 +0100 (CET) Received: by mail-ej1-x62f.google.com with SMTP id a640c23a62f3a-b6d402422c2so689584666b.2 for ; Mon, 17 Nov 2025 06:39:03 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b734fed9e9fsm1088716766b.69.2025.11.17.06.39.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Nov 2025 06:39:02 -0800 (PST) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 29a8dfb7-c3c3-11f0-9d18-b5c5bf9af7f9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1763390343; x=1763995143; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=PS7ucokoN9+hEjFZSIghu/GmWjPiHcD6tMlnYOR0lq8=; b=bJZVdFIbSZ6PRmtK8h9XLY+dB/peLqr02IeKedxGLXKUdeaNLsp+QRvF+pdwrACxeK 9khvSodbpdqYMHCcsvasUDtayCrjoqwyawb60Gzf9Tz/H1PX9OpUC3Kp5cj+xn2a5FxD 9TBU0t+bgb8/Ep0G+crLAi5OoJl4UZMoCov8CALYp2SsvkguodZIcNGnsEYqAqEyOJzo ONgejAP7p5vj8NOiftC4BGQ6ZI7WhYmb3gZwsjCzzP1Vym5Rb6hwksH07AdXSoz2C1yY AXrDJCeW1eiGszQuvg51yKLEt8eL0ZMZEDIYY2hokSK4evSt5JMgrjyqn4R5Hff1Z64g fPEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763390343; x=1763995143; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=PS7ucokoN9+hEjFZSIghu/GmWjPiHcD6tMlnYOR0lq8=; b=BBMX2RanCnCpvA82Z91ECGr0Q6Rvjl+NjU1NwnPH0sp8DLmmXhJQ9sRl2US/ZLqHF6 fsr7GDwJva/IPONpWNNMpmqJlZw+ZB997uOCYMiuO+oM3onSBanrVXPB9Fqmak/Zt/rh KrEWqhPWVgbPFY0vc9RPm5mX9ol1ckhwqTiDeR+fTF7PwNEHL8T/ra2rbmxVylCHxKa8 TQ4WWGSI9o1fJRTMFCnltAKbC4bsC702ADXaS0jGFENNUqs2yqG5aVede6MztLPPnu2l rW5ngX1MapTEI+hM/wognl3sRa33B8gtoS1EBhkjvhVqPq+2VPaZ1DLKEAFRgA7BBKuV JFBw== X-Gm-Message-State: AOJu0YyMMHDu1M9PItZTQWWOZ30/E+7DtSBr3Pq4sztDWlvaGJQZQ1sM C2EJT9dqPBX0cAf8U35Cqg7HZ/d34udq8VdqYZSwCzf3gBysp0nj7DXrfiEe+XP5z12+Gd09HOS tnmM= X-Gm-Gg: ASbGncv8vSxCZhHRokOCHFzyXUfJMTr2F0SObXFhzzHXW67IA1hD0sLkQnY5KhPzJ63 /4mkfQ7DhR42h44w9TmPvwmqY4RmZuqCcD5SDWHemxR4cccMj+y9HsJ/GJCs5HNVuG+/rynoQYr wPeFWQmKjGfcPV36Mx6qum+AoChEG9ANd1q5CqPmP1kHOhAGUHIXcVDt/GikxzIPJe3SeKPZjDd kISVI8I3tFskexoRRPvw7pLuWl2Hj+B+hxhN298yw2lu3QXAzlYOfmUu9NWcnRXOK91Eh3QsyTW qR5sRoWpO3DfzOL04SmGUNvbIs6uSflJDpdb767FNmAmqROxFyFrc4tXhvS6+YpljXvpbIH6VGd iK6VB/LwN3M4FhyH83mrk5Pl/q8JEVyYaxfp5ioL+sFSGgY+KPBmi76bAchM7oEGbjoC7V1Voeb BqMT/pMFzO9d3ZgQMb3yVkgZX7mlUwI/4aJhTyT9WnWC1PvHRRRSPYsuk4hoNHf2rujoreZakzh RmH1xfbtQIeGQ== X-Google-Smtp-Source: AGHT+IFOmUSm8/z5jcH9NKrpV6ugry7nIt6vZyPsNVAxgbB2504wXZXC4U9rOEjTlGUoPaq/8BRDDA== X-Received: by 2002:a17:907:940f:b0:b73:826a:9102 with SMTP id a640c23a62f3a-b73826a9b7emr889787466b.49.1763390342750; Mon, 17 Nov 2025 06:39:02 -0800 (PST) Message-ID: <54dbc592-93a6-47bb-9304-14addd41610f@suse.com> Date: Mon, 17 Nov 2025 15:39:03 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH v4 5/8] x86/HPET: drop "long timeout" handling from reprogram_hpet_evt_channel() From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= References: <57f34114-54b7-483d-8ac0-e9fa49df959f@suse.com> Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <57f34114-54b7-483d-8ac0-e9fa49df959f@suse.com> Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1763390362525153000 Content-Type: text/plain; charset="utf-8" Neither caller passes STIME_MAX, so (bogusly) handling the case isn't necessary. "Bogusly" because with 32-bit counters, writing 0 means on average half the wrapping period until an interrupt would be raised, while of course in extreme cases an interrupt would be raised almost right away. Amends: aa42fc0e9cd9 ("cpuidle: remove hpet access in hpet_broadcast_exit") Signed-off-by: Jan Beulich --- v3: Drop the code instead of adjusting it. --- a/xen/arch/x86/hpet.c +++ b/xen/arch/x86/hpet.c @@ -162,13 +162,6 @@ static int reprogram_hpet_evt_channel( =20 ch->next_event =3D expire; =20 - if ( expire =3D=3D STIME_MAX ) - { - /* We assume it will take a long time for the timer to wrap. */ - hpet_write32(0, HPET_Tn_CMP(ch->idx)); - return 0; - } - delta =3D min_t(int64_t, delta, MAX_DELTA_NS); delta =3D max_t(int64_t, delta, MIN_DELTA_NS); delta =3D ns2ticks(delta, ch->shift, ch->mult); From nobody Wed Nov 19 01:56:09 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1763390387; cv=none; d=zohomail.com; s=zohoarc; b=JSlvHx1xMlcyCjMeMml/uvD9XwcAoo92Q4xYn/TFVuBjSAI86jMv8ud1W7S3qEwE5OblempUGZzm6y/xOq2NKurewmHKUFFA+xUca1p3bHMxXzcmCMliSe1IDbxeY3ODrnBeL/c520NP0AMdjFeWiZtsVncOkH+OAS0UBuaRlwg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1763390387; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Yfju5TuSYr1gnKBFs17R38Pvw/Jb2fzNTTH63D/Pa3U=; b=dfLvRsynCTRow/GVWOsg+aTI7LFudXzYQL4kWtXl9KYnNkkgEbU2V2LrOMxMpSV7EbR6lLzPV4EqNQ4bP5q8GGrpms7Xo92OYGr9QbhJ6sW4RfROZdGa0T8Ayaw75dcsVEtalNr/sEv50JE/v5YXqZqULmE+D6rr/IE87SReYJ0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1763390387792638.1203907846293; Mon, 17 Nov 2025 06:39:47 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.1164104.1491114 (Exim 4.92) (envelope-from ) id 1vL0OB-00086u-9f; Mon, 17 Nov 2025 14:39:31 +0000 Received: by outflank-mailman (output) from mailman id 1164104.1491114; Mon, 17 Nov 2025 14:39:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vL0OB-00086n-78; Mon, 17 Nov 2025 14:39:31 +0000 Received: by outflank-mailman (input) for mailman id 1164104; Mon, 17 Nov 2025 14:39:30 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vL0OA-0007Pr-SI for xen-devel@lists.xenproject.org; Mon, 17 Nov 2025 14:39:30 +0000 Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [2a00:1450:4864:20::631]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 39b229e4-c3c3-11f0-9d18-b5c5bf9af7f9; Mon, 17 Nov 2025 15:39:30 +0100 (CET) Received: by mail-ej1-x631.google.com with SMTP id a640c23a62f3a-b7277324204so574071566b.0 for ; Mon, 17 Nov 2025 06:39:30 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b734fedb2eesm1089927466b.68.2025.11.17.06.39.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Nov 2025 06:39:29 -0800 (PST) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 39b229e4-c3c3-11f0-9d18-b5c5bf9af7f9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1763390370; x=1763995170; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=Yfju5TuSYr1gnKBFs17R38Pvw/Jb2fzNTTH63D/Pa3U=; b=M7I822gJPFWI4MHnpyr7sWzwrYwyv165WM3oRfNaztDlWZ+cNeFJXYNQBENgindruD t3KlUobWSyWNiTna8nt3Hv7uBlmEkmGjnXOeMZHDWHgppKrjg21pQMXs5gJEUQsxigPq 4XdSn2mD7+SheiFyBJ9aUm93svu6NLW+LzvFVd2MW4beThK/kdzvkUs2kD5KSXQtVcVa rvXrW2GzA5wXkqSOLK5WPQ1Wgpr/vWFq5AjF0sK6crPxzkdpyuv9RzNHVS9ewq8CiHac xvXZvjkCsKDdZqN1qvv0bQQhj5ZHfHaSvVIy+Bghr8UE7fhpPo5sCqigqKFTFz+llPOJ an1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763390370; x=1763995170; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Yfju5TuSYr1gnKBFs17R38Pvw/Jb2fzNTTH63D/Pa3U=; b=HwBYHnCH00oRdtCgeu9sEWpRYsFjOERB6ev1YSpCTX4egwdw8+ACg4LCRJqrNe5h89 hSHy/vKcLm7H8llvvTxp1equuSMk7IiLeehEpK6Elt9YVzxfAj74Gf6jVOxZ5ThbOZix HPgiqnZd4NeGi8fFdn8T/Bky6grlwQvN86E3PbopaRI5zbDvDVgkBA9u6+oy29Fzphj4 hlUuGnD6XdoUzdloCads4qtOXwYm9oYXzMscMsI2AxlwnoAjndUfdb4uO5IVX+QNz+PF bkOEX7slfeM721qKSvyYz/ps+CUrF3ZzsZDEPbN0SDXMtsAVhPo+n/WFqDuzPndifNid gs7Q== X-Gm-Message-State: AOJu0YzWvkWxYjbcv2eqLvZmWkE9Mdb6yNkuHlDh0/toSQx+jOlDCMng Mj419xx+ze2xgIVXZ0/u+897QJEGdcKMnFAlCk6XTP8a/P9BZ9KY0T8sTojvfEKBgGKvUbyqR+6 WXBA= X-Gm-Gg: ASbGncsNGxyqw8CBROm5/nqXpNnhOr733N3znLXxlPMfc1zNeO5KNVSoPWb1SU6hCCP sSDYL5kIzm1ErohQ9vnK42/7conCiMG/tDuBg/TLKMtrnjhL4ouS+O15IqpFbU5lUeiC5S91ace 2pcNqMnZK1TMx8PBhWg2Y6DVHSgzlW7xFV7BybY8/bT1LBweEBfIsE05fEVEgX2VB+fqVtL2sl2 CJucV5XQ15GfHnWgUfJTUCrDQPhPeaBl5TzimFlyu6WlibgEVe4zjYU4XUcl1EK3rN2EDosZ+q7 Ipwedlfa5FjB2Z5nwUmkxqCYJuKXuPNFBCi/EvtIA+lmlyUNpsZnHMD/LUKyFQ6XqOKDWH2XFof 2l7USiOJKvo1fvP15gtQOzPT4kkWIJX45fQ+xqYcemAYsy2eH48LKZIaz5kjbgKh0KLjzwJTFUC 0DoVfaIp5kUmtmAoF6k2qQaVBCHKNxy9imZQ87s+cJuuFKvq2VPc5Sj8y0HjY2ezWcfYQQ3+lUV nMwnexT1s8Rgg== X-Google-Smtp-Source: AGHT+IFqKWURIzhu1XRhapZ/K6XdgrEUTElkp6+U2JG4zQb4GkX7BZZ7YWOcY6wzJVt2sz+bOVLMZQ== X-Received: by 2002:a17:907:7b8d:b0:b70:b93c:26cf with SMTP id a640c23a62f3a-b73678086a4mr1208450666b.6.1763390369788; Mon, 17 Nov 2025 06:39:29 -0800 (PST) Message-ID: <0bc920e2-2e32-4b3d-9ed0-a2c2b34e9591@suse.com> Date: Mon, 17 Nov 2025 15:39:30 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH v4 6/8] x86/HPET: simplify "expire" check a little in reprogram_hpet_evt_channel() From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= References: <57f34114-54b7-483d-8ac0-e9fa49df959f@suse.com> Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <57f34114-54b7-483d-8ac0-e9fa49df959f@suse.com> Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1763390390862153000 Content-Type: text/plain; charset="utf-8" When this was added, the log message was updated correctly, but the zero case was needlessly checked separately: hpet_broadcast_enter() had a zero check added at the same time, while handle_hpet_broadcast() can't possibly pass 0 here anyway. Fixes: 7145897cfb81 ("cpuidle: Fix for timer_deadline=3D=3D0 case") Signed-off-by: Jan Beulich --- v2: New. --- a/xen/arch/x86/hpet.c +++ b/xen/arch/x86/hpet.c @@ -147,10 +147,10 @@ static int reprogram_hpet_evt_channel( int64_t delta; int ret; =20 - if ( (ch->flags & HPET_EVT_DISABLE) || (expire =3D=3D 0) ) + if ( ch->flags & HPET_EVT_DISABLE ) return 0; =20 - if ( unlikely(expire < 0) ) + if ( unlikely(expire <=3D 0) ) { printk(KERN_DEBUG "reprogram: expire <=3D 0\n"); return -ETIME; From nobody Wed Nov 19 01:56:09 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1763390412; cv=none; d=zohomail.com; s=zohoarc; b=Xk1eJr9RMNtAIL22mbvLUGKATuq0nXt5HbdGeob8NWerdqb2QB6kFagcjOYZ221uVjbR6sMDbtw9IZ5lwnSVAa4ePBuPaM3qtBSBitDFhrf/7XF7iDJ6L+xaOs8srDMJYviaDqfOFjngdZzDn4OqeabzclMuVsI6KdMWKbZuguI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1763390412; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=y0auAxXnuppooklnSDerPgHwMUEE+NEjFepbTDvIXXk=; b=blPGD0kt74kjY/suLDd9SHWll0jCXEFHKYpuL2oQqfiZlH9kQ5KPJNF8/7g+4t/Vww9Cizsrb7ebp3en27IYYr1E6xKIhz2vyEWbEbjzp4Sv9GR0Q58e804JOSgMwuY+Nr2iZWknOgp0YovEbe2Usaa4sZu8MTNzNarfYY3EnAk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1763390412650145.0479535784384; Mon, 17 Nov 2025 06:40:12 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.1164118.1491125 (Exim 4.92) (envelope-from ) id 1vL0OY-0000Dp-MY; Mon, 17 Nov 2025 14:39:54 +0000 Received: by outflank-mailman (output) from mailman id 1164118.1491125; Mon, 17 Nov 2025 14:39:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vL0OY-0000D3-JK; Mon, 17 Nov 2025 14:39:54 +0000 Received: by outflank-mailman (input) for mailman id 1164118; Mon, 17 Nov 2025 14:39:53 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vL0OX-00079j-6y for xen-devel@lists.xenproject.org; Mon, 17 Nov 2025 14:39:53 +0000 Received: from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com [2a00:1450:4864:20::62b]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 464e5df0-c3c3-11f0-980a-7dc792cee155; Mon, 17 Nov 2025 15:39:51 +0100 (CET) Received: by mail-ej1-x62b.google.com with SMTP id a640c23a62f3a-b7355f6ef12so723024466b.3 for ; Mon, 17 Nov 2025 06:39:51 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b734fa81172sm1085670266b.15.2025.11.17.06.39.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Nov 2025 06:39:49 -0800 (PST) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 464e5df0-c3c3-11f0-980a-7dc792cee155 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1763390391; x=1763995191; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=y0auAxXnuppooklnSDerPgHwMUEE+NEjFepbTDvIXXk=; b=PzefT0+Tt6vUwGzEcU25LGh2cqy/7E1+tWQUJlYz4ZdRKa4jd7ThJo1w1hLrCLjf/8 D1/RGQVqGPehmg6pWgV5H2Yr/E3uEIhRt5YwgJPPl1PIAa5d29fXbtHcefjPmImfVYqE WJQzOhhhxpEob1Qw5t5q3omZbvzF+TlrN+9ouiHkFnx7XJABaiQJITD/ps8+wvXFPL95 elhCbdEbjZ/PrfXBVXWnF2ZDvGymAWRrwO0EnDwVK4Psto5wMarUahLzNg6gPuC2FfHf Rk923IN55wZ9ZPTrYQc/ksiVx4Jm1hNNWxqRxcV1gXE+3XZxOfjSzsCCk73m1S4Wzddc F5Mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763390391; x=1763995191; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=y0auAxXnuppooklnSDerPgHwMUEE+NEjFepbTDvIXXk=; b=daLy7+MxLu14K4Wzr9CWR8lS2zZm7Z2bhhBwEExlqmWsznXotW0Iw2sK92yj+zvW9g g/92Kx8XZj0YxwCZ0rUxrImNYYhNks7wHkmA6ONRfaJG8MfurNeCOSyhV5BgZx1JMf8X q2JCy206BDA3L8VfYpi5AhtdZWEZC+8KLdzNr+RwVmHhWvDQBvDI1Lu92Y58+6O3R0Eo snjPnIWoIN4uNMLev/t8XwdsrqKsTL/RWmJ++nUtmVofX3NHBnIWITASunhw4lvdxvRC MN89+OUnH5X10V6zVMQxTL9CK+J2jcIPyCw3jnyDLzKw8fYFiwTYKE4LisSX6SY75zxx UZNw== X-Gm-Message-State: AOJu0YxymdIVgfEBlysCSRkzQHl011vbJNiarp+OJ3ItBlrxE9F42Nlh +wrkjFXyj0s3xjqGgCCnZgi4kf6sQLXWghnSbysird7nmQlHp7paRq07xCh8gLpahnZPaRiu3Qw QG6U= X-Gm-Gg: ASbGncushpYq+6oW4OjA6FPB0EFEfRqFHCNZx73NxEuTwh+SubYxnuSPDuPjqZDHwMB KoW4iSFOwSDCrvvBkU33wBYaMQN914Dx0T5Rr4ReyPa32hv81MSaDIbrr/CC1v+LtDsJE7f452p qI8a2uaIlEWVN0tvh5wMCH4vnM1F+MKoe8q095pbDHsMQ2ALhLqd8q5f8m0Vy9B+zl2RbjvpkJ7 HN57nPtZxXSXOsXIBkCcevyTwMx5WTzUBozqfqGNuY+0l5YVHhxvsZFp6R9r1SBmko790qCci1w nM8JP4ZR7E0iOFEd2r94kCVdl529PpOwYYo6BzlpvIkhRG1zc5eq1Hm45QGjo+5jtGAFBWe8KCO sliETsRJsauz9eaiJZ2y/axZNeJy6VhX3YKnB9AmvredEnZ0nN65F/ECcJ1cAp/EQkxLaomjNRh WznUz03sy25tFW5SVFk9AJ822NUgwJQRCzIrDuDq7D6UnhJMf2et3Pef87lIj+G1Ax X-Google-Smtp-Source: AGHT+IG9dgAgdipcXC/EhIFV2j2Hx95fMyUeXKzGksp4jaH2e+ltPjQaZyef1keZ4a9X8AqeOl49vA== X-Received: by 2002:a17:907:9714:b0:b73:9937:e96b with SMTP id a640c23a62f3a-b739937ead7mr389975666b.52.1763390390958; Mon, 17 Nov 2025 06:39:50 -0800 (PST) Message-ID: <5e09670f-dd80-4dfe-a8d6-182545b744ee@suse.com> Date: Mon, 17 Nov 2025 15:39:50 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH v4 7/8] x86/HPET: drop .set_affinity hook From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= References: <57f34114-54b7-483d-8ac0-e9fa49df959f@suse.com> Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <57f34114-54b7-483d-8ac0-e9fa49df959f@suse.com> Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1763390413220158500 Content-Type: text/plain; charset="utf-8" No IRQ balancing is supposed to be happening on the broadcast IRQs. The only entity responsible for fiddling with the CPU affinities is set_channel_irq_affinity(). They shouldn't even be fiddled with when offlining a CPU: A CPU going down can't at the same time be idle. Some properties (->arch.cpu_mask in particular) may transiently reference an offline CPU, but that'll be adjusted as soon as a channel goes into active use again. Along with adjusting fixup_irqs() (in a more general way, i.e. covering all vectors which are marked in use globally), also adjust section placement of used_vectors. Signed-off-by: Jan Beulich --- v4: New. --- a/xen/arch/x86/hpet.c +++ b/xen/arch/x86/hpet.c @@ -294,22 +294,6 @@ static int hpet_msi_write(struct hpet_ev =20 #define hpet_msi_shutdown hpet_msi_mask =20 -static void cf_check hpet_msi_set_affinity( - struct irq_desc *desc, const cpumask_t *mask) -{ - struct hpet_event_channel *ch =3D desc->action->dev_id; - struct msi_msg msg =3D ch->msi.msg; - - /* This really is only for dump_irqs(). */ - cpumask_copy(desc->arch.cpu_mask, mask); - - msg.dest32 =3D cpu_mask_to_apicid(mask); - msg.address_lo &=3D ~MSI_ADDR_DEST_ID_MASK; - msg.address_lo |=3D MSI_ADDR_DEST_ID(msg.dest32); - if ( msg.dest32 !=3D ch->msi.msg.dest32 ) - hpet_msi_write(ch, &msg); -} - /* * IRQ Chip for MSI HPET Devices, */ @@ -321,7 +305,6 @@ static hw_irq_controller hpet_msi_type =3D .disable =3D hpet_msi_mask, .ack =3D irq_actor_none, .end =3D end_nonmaskable_irq, - .set_affinity =3D hpet_msi_set_affinity, }; =20 static int __hpet_setup_msi_irq(struct irq_desc *desc) --- a/xen/arch/x86/irq.c +++ b/xen/arch/x86/irq.c @@ -51,7 +51,7 @@ static vmask_t global_used_vector_map; =20 struct irq_desc __read_mostly *irq_desc =3D NULL; =20 -static DECLARE_BITMAP(used_vectors, X86_IDT_VECTORS); +static DECLARE_BITMAP(used_vectors, X86_IDT_VECTORS) __ro_after_init; =20 static DEFINE_SPINLOCK(vector_lock); =20 @@ -2630,13 +2630,17 @@ void fixup_irqs(void) spin_lock(&desc->lock); =20 vector =3D irq_to_vector(irq); - if ( vector >=3D FIRST_HIPRIORITY_VECTOR && - vector <=3D LAST_HIPRIORITY_VECTOR && - desc->handler =3D=3D &no_irq_type ) + if ( (vector >=3D FIRST_HIPRIORITY_VECTOR && + vector <=3D LAST_HIPRIORITY_VECTOR && + desc->handler =3D=3D &no_irq_type) || + test_bit(vector, used_vectors) ) { /* * This can in particular happen when parking secondary threads * during boot and when the serial console wants to use a PCI = IRQ. + * + * Globally used vectors (like the HPET broadcast IRQ ones), n= eed + * to be left alone in any event. */ spin_unlock(&desc->lock); continue; From nobody Wed Nov 19 01:56:09 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1763390428; cv=none; d=zohomail.com; s=zohoarc; b=aTmqcImx1Fl+afhDr5o/CwiH6w+hPS7VkCUrjiXauqYTB0nxlP7nsEhd2DhPc4W/xNo7uv5T/wlNmA8EoYJBgThgdpDde46YyHKd2G2u/zsQPDC/ews1H8dtkgB68kb0npo77erZ0U6UbbtRD4/fzwPgyRsb46oAXuCSZWPoNpE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1763390428; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=5uOHVwkR4wfmN/82FZJU7rBePSTRT32bVOhGvFMjl6E=; b=R5iwl8OhbJ+GJLBVtLtmd4OcbG/PLdyDGw5OFehWm7lj4ZLHDpZ5fFwTjE3maLV68ADzXn6Qu5tT207kSYeHqRLcGdvmXP0forYfK5vSiHsVsoZdgpGMpL8WV0AyAhMZCa2RQlSHHdWBHpXhXY2qLn/c1cqmRQJjxDUnRd2cjnA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1763390428276750.8240167232564; Mon, 17 Nov 2025 06:40:28 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.1164127.1491135 (Exim 4.92) (envelope-from ) id 1vL0Oq-0001el-VL; Mon, 17 Nov 2025 14:40:12 +0000 Received: by outflank-mailman (output) from mailman id 1164127.1491135; Mon, 17 Nov 2025 14:40:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vL0Oq-0001ee-Rq; Mon, 17 Nov 2025 14:40:12 +0000 Received: by outflank-mailman (input) for mailman id 1164127; Mon, 17 Nov 2025 14:40:11 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vL0Op-00079j-48 for xen-devel@lists.xenproject.org; Mon, 17 Nov 2025 14:40:11 +0000 Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [2a00:1450:4864:20::536]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5108964c-c3c3-11f0-980a-7dc792cee155; Mon, 17 Nov 2025 15:40:09 +0100 (CET) Received: by mail-ed1-x536.google.com with SMTP id 4fb4d7f45d1cf-640e9f5951aso8493010a12.1 for ; Mon, 17 Nov 2025 06:40:09 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b734fda8d69sm1082524466b.50.2025.11.17.06.40.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Nov 2025 06:40:08 -0800 (PST) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5108964c-c3c3-11f0-980a-7dc792cee155 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1763390409; x=1763995209; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=5uOHVwkR4wfmN/82FZJU7rBePSTRT32bVOhGvFMjl6E=; b=OX906PjD48P3Gg0a4DIAIDtzLpa2HF95lj3cqS0IBCHUJdcGpnlzkfsUMEKTdCsh6G eUCoyw+tFzTVv09bw9aAogfrQtZH5H4l1zb5k7wdaM0ppDAOQVKOAI7X6OFLY8ZXR1sR 3mR7wnwCR8XTFn5fBaTNa4ECRj+M8XXeUBM3trafGKg9+xK02tBCEF8qPwpy85+Ywnc2 dreDn8dNQAZlyunlQ1y330Z/iC/tIztAdYYb1yTtDp25+Ow+TNr/ITgDZYRfFlKYLrVB PtG+71xt4Uw2hMdfSOcDmhcQIt4gP28cm/ffJ4dSVaOIXJQ4PcsGUPHh+ZqivBF0lOkI Bl5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763390409; x=1763995209; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=5uOHVwkR4wfmN/82FZJU7rBePSTRT32bVOhGvFMjl6E=; b=nGfwB724ldz1CxdqqjPg4fJlPoSPxFIAbkC/YFnCDOW3AzY5zoyx92VmjocK66xM3w jkm5+QbY6ixikk5pIVy9ORUWqeP8nEeRKzJQTSrUQQOh2tzsiYSpdVAzH+zkMvQ7W41u lqUPNpfBiRW6zv6+OgP6W0bh9rEbIFfWoClFjrPiBBoSej7Do4H4NY4milhEk3rxMmrD pZyE7iKQu/DNE4YCGyjS2TqQqCMsOUSVObSrR42qbkpQYWQNZkY2JT9sMmJUAXFvPkIw t0z8us5fs35wRxdIpz+awuh5XaV2QVgIhR8wY/zHv/RddB1JK6MFvh/FDz+3FFerc0Yt RssQ== X-Gm-Message-State: AOJu0Yx27I53kh3gTnqQ6lavcB6HE6itLyOUwQqkWSYyHSaeOTUko0WQ XqYxct/yL+KkZmW8s+8ZaNXqa0452358r+dfMuwlDq6jXfk0huU8dcmkiHp6RjKyfatoH9gW6Gg HOJs= X-Gm-Gg: ASbGncvQuuiB6+JcCBEEOSfzN5ROgloQoV05k2yvUy0O0fM+JXuDafcctPl53ujXrcd 88oBsMTJsQIIpklPc6x/42d5pr1O6LREmUq2NXEkm1mQAxjwUR8JW5vp39AYT9dPeP0FvWCpCuo de2yKUYYSSmdRSIb4uzSsdTKIOFYzTId5yQWKoNXsf3Xr0NX4ufviVyuSDew0qHMaXOhdIv9M1D UXkTLEoWyokRILsX5mmEiD70B28LL6xacwzE76fTOtxzocyt/x8ktdlhWuy6sbKHD29wcYwDaqx YNlx7u618ipdiB/P2oFqsfzrLkdup09E+dkwB7irDn5oBPLA2ROiyFCAJFR3pCQlBfqelan80l+ NGHxbWe6wXM9ruJ0aAkN/GivhDy3oUQANaOsjtjBJvIf0CkrMQBRxGswYz3PQoVr8ZYWNSqOWIi ymHjMeoByQE1a1/LzFFFaSwwRLcSIurMYhho9EXt0VbILdArVSOqfHJ9mJ2jZTWlrI X-Google-Smtp-Source: AGHT+IGwrnn4A1jKS8uEriGFes2b0JucnS5GbtRGHV4wkeQ3vTw9dpeZS6tcxLaz+RsgFAF4E7cGug== X-Received: by 2002:a17:906:9f85:b0:b73:2ced:9af0 with SMTP id a640c23a62f3a-b7365b11119mr1248131366b.27.1763390408967; Mon, 17 Nov 2025 06:40:08 -0800 (PST) Message-ID: <37cdba83-9bf8-493a-9a7b-5ec11c32159a@suse.com> Date: Mon, 17 Nov 2025 15:40:08 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH v4 8/8] x86/HPET: don't arbitrarily cap delta in reprogram_hpet_evt_channel() From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= References: <57f34114-54b7-483d-8ac0-e9fa49df959f@suse.com> Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <57f34114-54b7-483d-8ac0-e9fa49df959f@suse.com> Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1763390429494153000 Content-Type: text/plain; charset="utf-8" There's no reason to set an arbitrary upper bound of 10 seconds. We can simply set the comparator such that it'll take a whole cycle through all 32-bit values until the next interrupt would be raised. (For an extremely fast-running HPET [400 MHz and up] 10 seconds would also be too long.) Signed-off-by: Jan Beulich --- v4: New. --- a/xen/arch/x86/hpet.c +++ b/xen/arch/x86/hpet.c @@ -23,7 +23,6 @@ #include #include =20 -#define MAX_DELTA_NS MILLISECS(10*1000) #define MIN_DELTA_NS MICROSECS(20) =20 #define HPET_EVT_USED_BIT 0 @@ -162,10 +161,15 @@ static int reprogram_hpet_evt_channel( =20 ch->next_event =3D expire; =20 - delta =3D min_t(int64_t, delta, MAX_DELTA_NS); delta =3D max_t(int64_t, delta, MIN_DELTA_NS); delta =3D ns2ticks(delta, ch->shift, ch->mult); =20 + if ( delta > UINT32_MAX ) + { + hpet_write32(hpet_read32(HPET_COUNTER), HPET_Tn_CMP(ch->idx)); + return 0; + } + do { ret =3D hpet_next_event(delta, ch->idx); delta +=3D delta;