From nobody Sat Apr 27 04:20:49 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=suse.com); dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=2; a=rsa-sha256; t=1637674814; cv=pass; d=zohomail.com; s=zohoarc; b=kPbe8y255yN8IzBOyS567l0DwNPT6zrUvljZKsvmsA4JMyTimh2qmREHpPK8v1kNQ9ur8/eWnqYlJnJbBXbTiKtnvsl+0a4q0xzovkcjLBTiihMlmorOYUYWVfcXbhH6UErMzoYvfuHo0RQqE+8aPnWeXopiKK0msAR4uMPt8Cw= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1637674814; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=kTVWcpgaN5RHhZXfVu5ub8/JYsiP0odQFTntwSRApa0=; b=S4BUZS5KiRc3j6W+ClMUGTWex00t/oJHt/uIBxHcd0dIASzDSCR9P5AQWHM8HWhXnLbAtWIzuA1BZ4AaUPWq1czOMjaqmOHbobPiLcsajhxv6ivDKlTzfAy1IEVPiI8n+6X8Xqs0Z6XNDuh6PNOZtShZl3cdS/Xva3buf9bykG4= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=suse.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1637674814915458.46141466686527; Tue, 23 Nov 2021 05:40:14 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.229605.397048 (Exim 4.92) (envelope-from ) id 1mpW1Q-0006Wj-Vr; Tue, 23 Nov 2021 13:39:44 +0000 Received: by outflank-mailman (output) from mailman id 229605.397048; Tue, 23 Nov 2021 13:39:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mpW1Q-0006Wc-RD; Tue, 23 Nov 2021 13:39:44 +0000 Received: by outflank-mailman (input) for mailman id 229605; Tue, 23 Nov 2021 13:39:43 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mpW1O-0005zm-Tu for xen-devel@lists.xenproject.org; Tue, 23 Nov 2021 13:39:43 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id cfeb60e2-4c62-11ec-9787-a32c541c8605; Tue, 23 Nov 2021 14:39:42 +0100 (CET) Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-ve1eur02lp2057.outbound.protection.outlook.com [104.47.6.57]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-37-q3U3v-FHOwame6kRf4RtIA-1; Tue, 23 Nov 2021 14:39:40 +0100 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR04MB5325.eurprd04.prod.outlook.com (2603:10a6:803:60::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.22; Tue, 23 Nov 2021 13:39:39 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::8062:d7cb:ca45:1898]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::8062:d7cb:ca45:1898%3]) with mapi id 15.20.4713.026; Tue, 23 Nov 2021 13:39:39 +0000 Received: from [10.156.60.236] (37.24.206.209) by AM7PR03CA0028.eurprd03.prod.outlook.com (2603:10a6:20b:130::38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.19 via Frontend Transport; Tue, 23 Nov 2021 13:39:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cfeb60e2-4c62-11ec-9787-a32c541c8605 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1637674781; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kTVWcpgaN5RHhZXfVu5ub8/JYsiP0odQFTntwSRApa0=; b=CyebUsNnAxyqypaB3P+Q8DfK2Jf1OrGLSjcV/5iStJD99epD8dHXAOfzAYa6qv5TOd8lvS Ksdaio6NO/5XmsethlD/kmedL3xppZeUcBYZggdo01PbIqmk0RQz3WsfrLmgX/8Q6hkW2O EQnIEF6SkdBh00q1ANsq49kdUYtco5k= X-MC-Unique: q3U3v-FHOwame6kRf4RtIA-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=B8j9p7I8Wx84jFOj2U8bcWWNLUrr6LbvIXfypckMNEFZ78qZ665pHshKVYxAjRHOv3gDqbxRXyFQzgPf0QEkhFGPHhXvKb4KsQ6JxNxVZUGJ6bzH3n49QJwbWI8UCSnyRyG9WNgbeEtDajYsTwi5MumdqSBxvz3/PAXV4cmmQfIaPKeSf3FoA1UGWEOrlXgsIySwc/A3Xwc4l3ztKW7BcSdDLqih6+Gu7lI8oXNTj0KwXEGG1TXAzXeoOKvc58CzotFOGgb3AXUZHYM8mgTyIJP3YLVEPtbBl2X7WNQEFaM4iOCjPl7xOkUjFj5YqJPP63uhvKu8o1fhQM0KttnK3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kTVWcpgaN5RHhZXfVu5ub8/JYsiP0odQFTntwSRApa0=; b=IH2cVGt8Tg6wVdbEgiHhvCcoRCIj5CWZXMUHKO88cXXx96vTEiyAFaQI4p5iv6naNNOM66uALAYz+i9YWQgdZzGFvzCNPiW9rcQEb75Eby0iK4VZ8IGzYKrQjwYmfDv59uOqU5k0Qig1HXRxbC43wrnx2ttY8n54dHPUtXYwR+wzMCKM7sNYZK2mjnsmTrzfekdrvheJqVyWaJNNnJnq8gqZol5aIfSj8ejwSgExEYeisWy2cqrMMuPuiAdOv3rel5OheVfLaugTAqe2gvb5EYHkM57YzqCGO/HDmzLjbsnHh93Y2FPpEmaW0XZo8pmvaZNRMaPt0HSxQ57AGC4ZbA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <4e801190-ad7e-32da-da87-985e1b6a76bd@suse.com> Date: Tue, 23 Nov 2021 14:39:38 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.3.1 Subject: [PATCH 1/3] VT-d: prune SAGAW recognition Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Kevin Tian References: <54e38a20-5281-2ab3-8513-3506ab66dbe8@suse.com> In-Reply-To: <54e38a20-5281-2ab3-8513-3506ab66dbe8@suse.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AM7PR03CA0028.eurprd03.prod.outlook.com (2603:10a6:20b:130::38) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 40a898b2-9ed7-432e-4bb8-08d9ae86b2c0 X-MS-TrafficTypeDiagnostic: VI1PR04MB5325: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qYlONdBEQGCbDEHbWLxKS9q0SbDY3xIIzOCwuinob+PlpJ/FNGIbj3RcquBdgvEnbbjeVFeqPiBMANTQxpzkKVGhIQ/rOfEcHR3n/Hh16tmpMAzD8KF+qnspIsy9avSiICaqI4z/AzoH4DWnzFasXECaxzOJTsX50hgsjmhTgsV8Eq6ap3GENgTWAUsMknRa3MXWzwAl3seGeIk9z3LBhDSl6BuVfZBJonBbjgEFxW/DQ/gckIFKNHa4ERnRx84NiMtR5K1NDnAkgHYtROEvNEDsgRqr+wjfqCM7A1q8sH7FhuFOKj3r8mpMneaBz+yKfJk9UdI7hds+9WFhnPuDTYrSg0amGcn8FqH9a6wHIrZHgCbBPAN+WNOCv5lVUYbD+3fGS3mvJm3LCpS+8ThtaJ0dQZWhcuvH+WYiJN5aS3ZdVnUaWWGScQMnf6C7Xod75UR1yWGhQQM4ZIMEEscj6knh8vWyeiUZcmJDXhmbHTjl1ajGb8dzS/ShCWJRmq1BDtiHaNhglPFacOzS3VNXRtn43/o/o+m3QihOJsIMvthngX3ytjJxIlrFmzzjZMxsjwE4lpkJxSEyY3/XTar0QIOHhRvnnnpwGw/+ZVYTSdaHaC5p3NtDsRpILApHBrp0sWezkZJmRkRh/EYU1rDmuqCxXOiS+9Mto9EnBnTfcfFWqWCWNQUC53MMuuim37aaKVW/vVHnBZlb8V5Pvg9UMEMM8t4jf4UKhZbUQabcLBk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(956004)(2616005)(66476007)(4326008)(2906002)(6916009)(36756003)(316002)(66946007)(6486002)(186003)(16576012)(31696002)(5660300002)(508600001)(8936002)(38100700002)(26005)(8676002)(66556008)(31686004)(86362001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aWxrQVp2MHZaKzRxMHRaK0FJdFVuRHI4bUp4T3JTY1pFYmpjaXlmQWh3SitM?= =?utf-8?B?N3h2MXgyT0VxU0RuV3U5NmNKQVlQR21FbEhWV2x4bnRMZEdML0I3dFNkSzlW?= =?utf-8?B?TWlUYk50Y000bFk1U3Z6OWRxTDRQcGIvYnl5SjIySVRiRzd0NjJUT2tOQURp?= =?utf-8?B?aFUwZmRsUStiQVJqRWJJTk9aVTA3YTlGY3U0N2Vrb1hlQXo5UTZQRWh0WlJZ?= =?utf-8?B?WS8wZlQ2ME9zdmZYQmltZEUwU3NwNnFOa3d3cnlKWTZ1dXBsVVpZay9VeGxs?= =?utf-8?B?VEE2Z2thTHVlZkZVWDAvVjkzQ3pjNGN0VkZlR0dQZURKNytTQ1NVWHpacmp2?= =?utf-8?B?S2tiNlUycXpneDg3bU0rSERiRDBBSElxUTRVWjc3clNTZkVlcFVmNGdOK3B0?= =?utf-8?B?ZUpIVWczcGpkVmdyTDE3OWQ3NmpuUHBDS2diRVJRd2hRYjQrMkZSdStvZUJy?= =?utf-8?B?bklOMVRTeW5EVjFsSzRtQXE5Wjk3UW8xWFgyNmdyTTc1Szd2cFpsQTBkeUE1?= =?utf-8?B?QmJYZExhZzZlNXZUSFlPd2h0VVlCQkw2d25QemU2UmFrNHVES3BxUW9ORkly?= =?utf-8?B?MU16U0JyWjMxMnZkS0k3YllkUDlvdFJ3dmxBV25YM1FuUnc4R0ZORVE2RnEx?= =?utf-8?B?SGZJNzNVejRMaUVlZ0NRT2JpRDZHVnpvVW5jOHNwOXJFdmhOWHBzQWQyeDFX?= =?utf-8?B?a0cwZ3M5dEk3YUtzMTBFRjUrWjlFR2hyRmhleVZ0Z0xlQnliU3hubms4TmZV?= =?utf-8?B?bDJrcnlhNXM0TDVKblc0V1BBaWlOKzZOVlBCM0V1NW0xcC92ZnMrRG0vVVZw?= =?utf-8?B?RXZUY2liaEMyU2o5eGJ0TEtjdkp0QWhvbjRSbkVHOWlzek4zSnVBbndHV0pG?= =?utf-8?B?b01pZXFEZGsxaTY3UEJKZzd3c2JQNE42aGtwU0p1cGg0NFozNTNPKzZ2TGxB?= =?utf-8?B?Q2Yxc0oxSkJvUlppTzhPMmRZby85Ymd3dys3UkFTZXc3REEvbGNDcU5HTW5i?= =?utf-8?B?QVVSUmx2L2tVOXlYVUFUOEdaWDI5MVpoRkVFYUd0YnJsUGpiOUdKNDdCUmYz?= =?utf-8?B?eVpLUHM3dTYyT1REQjJmT01Reks3OFFvdk1CZlhOZTZleS9QY0hmS1BndEVV?= =?utf-8?B?bk04UEJHWnQyVWRxbFpFZ296eVF3dDZQNnU4NVVYdXVocTFacE10d1dIUitU?= =?utf-8?B?MXVoZHFvTXR4eTRKekY1UVNWUE10ZUdVSDEzUjR6MUF1MjBNV0ZYWmkzdm56?= =?utf-8?B?ay8zdTlFbGUxYytiTnRZeHNCR3BXeERLTUowWWk3cTVqTXU2TjNBNlRFSWN6?= =?utf-8?B?eG8yaDR3TnY4eGI3TWxnQnpyaTNPTVNxTWVZQ1lVRTc4K0cvQVM2MUlLbjlL?= =?utf-8?B?cFhLVG05NE1MallmSE40QmZFZ3lEbHdWeXBBUDlJYjZ1MmM2KzNNbTA0Z3BV?= =?utf-8?B?Z0NndFdzNVQ4Z0h5WTJJSElWNmlIaWpHQ1NUK1ZpR1BsSXV1dmE1cU1NMnNJ?= =?utf-8?B?MGdqYmdBclBvaFZSNC9vMXRXZ2dRUThZVTNIZi9MUHdlVm8vUzBLWC9oYS96?= =?utf-8?B?WUZvc0tPYzZ0VHlqZVBoTm90eERzNlJVakFkU0NQK1Q1TUVua1JFY2w5RHg4?= =?utf-8?B?UGlhL29YVUdRRk5YNVVQWlp6SzA3OHhKVnJSZEVaazNmNEUvZWZqTlJxd3Zu?= =?utf-8?B?VDl5WW1DdVNDRU9vTlJNbklMcHNwMzJKa21RZXhPUFUrZVdUVWlvTTMvK1lt?= =?utf-8?B?Wm4vS1cwOVZZdU5RREE0Q25aZGN2QUN2UkdWdk9LUjN0ZVg0TFBPSzIvTnBG?= =?utf-8?B?VUIzVkpyQ1VoY2ZUdUxMeTNrMk9HREQvNXBwdkczdU5rUjl6UTBNYXI1eVRK?= =?utf-8?B?U3ZZeCt0WkdLeFpSMDZ0QkdkUnhTdGRhMkp5am4wd2N3K0FFQ1lwdENZVExh?= =?utf-8?B?Ly90NXhleCtzZ24wdnZPUW5kbDhFdmkyaTJOQ1hQUDZsT0dndkdCNXpIUUVj?= =?utf-8?B?ek5JTFJwZElncVZOWnk0RnN1Zjhkc1VxaG8zV1NTRnArSis0K3BvMi9YV29y?= =?utf-8?B?alpTTDJQTSsrOU04NjY2RU11eFRPTEZIYnh3YTBpdHdTZjFDU1J3ZlRFQWJN?= =?utf-8?B?NTFyemVrczhoNEdESnBlRnIyM1BWcldoeE9uVjVoVFAzNGFocEdqZ0pOQmw1?= =?utf-8?Q?Bwy3Wj6vPtdH9wW0EKefhWU=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 40a898b2-9ed7-432e-4bb8-08d9ae86b2c0 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Nov 2021 13:39:39.8232 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1KV8phmLh3izguW8uSKD7vJOR8vqIlb3ij7/ZC3BwL2/8XjprNGwtzK1Ec8yEYCDbyrCB8Ynmrm0UGvBlxiyJQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5325 X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1637674815637100001 Content-Type: text/plain; charset="utf-8" Bit 0 of the capability register field has become reserved at or before spec version 2.2. Treat it as such. Replace the effective open-coding of find_first_set_bit(). Adjust local variable types. Signed-off-by: Jan Beulich --- Strictly speaking IOMMUs supporting only 3-level tables ought to result in guests seeing a suitably reduced physical address width in CPUID. And then the same would apply to restrictions resulting from MGAW. --- a/xen/drivers/passthrough/vtd/iommu.c +++ b/xen/drivers/passthrough/vtd/iommu.c @@ -356,7 +356,7 @@ static uint64_t domain_pgd_maddr(struct pgd_maddr =3D hd->arch.vtd.pgd_maddr; } =20 - /* Skip top levels of page tables for 2- and 3-level DRHDs. */ + /* Skip top level(s) of page tables for less-than-maximum level DRHDs.= */ for ( agaw =3D level_to_agaw(4); agaw !=3D level_to_agaw(nr_pt_levels); agaw-- ) @@ -1183,8 +1183,7 @@ static int __init iommu_set_interrupt(st int __init iommu_alloc(struct acpi_drhd_unit *drhd) { struct vtd_iommu *iommu; - unsigned long sagaw, nr_dom; - int agaw; + unsigned int sagaw, agaw =3D 0, nr_dom; =20 iommu =3D xzalloc(struct vtd_iommu); if ( iommu =3D=3D NULL ) @@ -1237,14 +1236,13 @@ int __init iommu_alloc(struct acpi_drhd_ return -ENODEV; } =20 - /* Calculate number of pagetable levels: between 2 and 4. */ + /* Calculate number of pagetable levels: 3 or 4. */ sagaw =3D cap_sagaw(iommu->cap); - for ( agaw =3D level_to_agaw(4); agaw >=3D 0; agaw-- ) - if ( test_bit(agaw, &sagaw) ) - break; - if ( agaw < 0 ) + if ( sagaw & 6 ) + agaw =3D find_first_set_bit(sagaw & 6); + if ( !agaw ) { - printk(XENLOG_ERR VTDPREFIX "IOMMU: unsupported sagaw %lx\n", saga= w); + printk(XENLOG_ERR VTDPREFIX "IOMMU: unsupported sagaw %x\n", sagaw= ); print_iommu_regs(drhd); return -ENODEV; } From nobody Sat Apr 27 04:20:49 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=suse.com); dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=2; a=rsa-sha256; t=1637674834; cv=pass; d=zohomail.com; s=zohoarc; b=apIp+D6Uttu9+jRdy/sc7XEBpvVerC2vJ8VbAx37Gxp6j5olwLrO7nTG3459XJ1UBa4iGuQ6EJyqoOKbahyvJzS3AjvFrmz7Zip6uQW3IONog1tKIQcoJ9pMSdzT4D8gpthyeFpgbCuSckX9uPasxu9gKF8/aYVVwBqqROj5awo= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1637674834; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=7UpnXoNN4OOD8dNV51znqRmM214jyttiYXA4qdhkm0s=; b=ZoDaRVKtiCcramaY83WakA2KWwNEW1PPgETZMyRC4pyIE+XLNQwhW4Sccp8+EyK55s7yKRcP54MSZUR/HIwB8m9MmPqeSP6SO9YkNmijNIQe1ubNbMPmYLsbVEajRli0SlIHzWKUhrKiM7umwn+CL1y+SkG61oT2qWjsDzU9PFw= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=suse.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1637674834209942.7713643240221; Tue, 23 Nov 2021 05:40:34 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.229609.397059 (Exim 4.92) (envelope-from ) id 1mpW1q-0007lr-9o; Tue, 23 Nov 2021 13:40:10 +0000 Received: by outflank-mailman (output) from mailman id 229609.397059; Tue, 23 Nov 2021 13:40:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mpW1q-0007lk-5D; Tue, 23 Nov 2021 13:40:10 +0000 Received: by outflank-mailman (input) for mailman id 229609; Tue, 23 Nov 2021 13:40:09 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mpW1p-0006K2-24 for xen-devel@lists.xenproject.org; Tue, 23 Nov 2021 13:40:09 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id df5d4ee1-4c62-11ec-a9d2-d9f7a1cc8784; Tue, 23 Nov 2021 14:40:08 +0100 (CET) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01lp2050.outbound.protection.outlook.com [104.47.2.50]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-22-BSAAXH1QNjONoB3pIxpIdg-1; Tue, 23 Nov 2021 14:40:06 +0100 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR04MB5325.eurprd04.prod.outlook.com (2603:10a6:803:60::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.22; Tue, 23 Nov 2021 13:40:05 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::8062:d7cb:ca45:1898]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::8062:d7cb:ca45:1898%3]) with mapi id 15.20.4713.026; Tue, 23 Nov 2021 13:40:05 +0000 Received: from [10.156.60.236] (37.24.206.209) by AM6P194CA0020.EURP194.PROD.OUTLOOK.COM (2603:10a6:209:90::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.19 via Frontend Transport; Tue, 23 Nov 2021 13:40:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: df5d4ee1-4c62-11ec-a9d2-d9f7a1cc8784 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1637674807; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7UpnXoNN4OOD8dNV51znqRmM214jyttiYXA4qdhkm0s=; b=dAni9xxVsWcVuWebXbNYrplFK40Mp2MfgnzKFCu++hvtuyzZXZ7V+YknUzmVuPYUSPHa0K gQ1ePoeL7qm5QV2hQthewxUggqXjtnL2V7uW8JGYEORIYyrohld69/uhyr3uVMLLu45/c3 Vvzc8Xo6m4k9b1cFSC0PMAsEmUJOdYQ= X-MC-Unique: BSAAXH1QNjONoB3pIxpIdg-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Kbs2bI/JfnKfMCpQwEF4YQg4k4MW4uhLmnEkb7zVXApJRQHOnx0qQ6Ewht0kuJuxabtbLXp8xZLI40Bm5DEJxzK1iCmCV+ficfoffhjgrwqJHIYRFec5HM84gW+Q2v0ddNoW9/nBID1x21EBw2E8iEIzKOfVsuXNBCa+mjIBcaNlg1fiOHSHi+WOaMJb1SqJO36wAgRDKOxEDqzAGpGDG7xcdRfg7a03Q8bhVP+JmZme+feHde1P3HaDwm1hDjizgqjm7rnIUi3K/Jwv1yXHgGCIEyh842czyTBOuBIUZhJoo3SP69h/SULxCsJoXin7SkHXoRzWT+KKTH0PspM5eA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7UpnXoNN4OOD8dNV51znqRmM214jyttiYXA4qdhkm0s=; b=aPV6ZGQDmhBwY73MeCiBIdoC4qL4PYKtsBFnEO/ClZTM80w1wsBmKQz9tLOpXf3R9ZAwiaYNm1M9x1yGBkpMocKOBMxCNyaJbpnnKG3OgVgQJJ8u24fAfBMsI2F6HikQQytB29iowopvErJO39hIxGhb4PbxvUWJkcJ/jkoqfq6KI1c2lIlQV7wP4zXRVqU8EuOjxb/Bc+8PSxdL088y21/KO+jx1y0SE6b0LJqOSfdbU+5JOP+ZFWjTLEchq3nGkTy7Z83L797hOX0MK2RXEmYysLJLotv69E0D81NnkPnlL/YEETv5bmNk2sP9U4uKxQV38kJwg2s24aOEj5ePkQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 23 Nov 2021 14:40:03 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.3.1 Subject: [PATCH 2/3] VT-d: correct off-by-1 in fault register range check Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Kevin Tian References: <54e38a20-5281-2ab3-8513-3506ab66dbe8@suse.com> In-Reply-To: <54e38a20-5281-2ab3-8513-3506ab66dbe8@suse.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AM6P194CA0020.EURP194.PROD.OUTLOOK.COM (2603:10a6:209:90::33) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 10cc8ec8-4365-4cf9-493f-08d9ae86c206 X-MS-TrafficTypeDiagnostic: VI1PR04MB5325: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:5516; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Wq4TDOz9ITbJYDbXN6cnU9heRTePoDQpA+YgGwqb5V0Kbgopb1ofVQV680mJbfcqO0xjDXAQaEXVnQuREUruh1GrphMbLjSESopBN/1gKoKEMCIMz/PBRwirn8mYNi8cuEvuA5BYLkBAyfqGg2uJsHg5bNeQFAQyIqn2UObBPUllQVIHNpuflVTlA1s4aiwSs7FyeJQMiQ1oxR5/9eGAODolCsiKWnzv+jVkl/hhmVvnzr+UR4MzjjiiKagsVkV6IS67Vh2L6/vnVX9DSRIhu8ojcDzagE/l6Cpd2Oi5QQ+uOa/TaP+I2Z4aXQBcXmG52ncKlS534TGEf1f8tgeWOirK0zs+GxHTO0pcgl5M8eXbKfiUwGzGx0v9iSP1/YopJ6jUiGCuRP+6iqHG/hi0XrlodX9xVLn/QgeW0ISXboDCrWKmoVI7MrP+sw+of4fIW3dvwLueQK0p76ILM68AnkXetZZOj/rxe6BKIIf8NJHlBmkDUKqEk3yOOemrF3jO7AtB/xRDvm7+6lG/tFVasD9nDgGNBGl1ZGnxhmyzy9I4hLEpF1MXmCBtulZFmXEQQwC9DyjGqpjBAVX+BvTpzHQG797rdI/iLYVbbTQ3T/dX/5TLY5FaY0maAUFlx59PECdF4RYaHP10SArL3JtInh5KlqZdQUuWo+aP0BxtpnC5+4ZKZAetN0OuDHnl2YQg381DrUEkaRdo+6iySzC/ETuxD8TNyxX08hSxRh1uHO8= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(956004)(2616005)(4744005)(66476007)(4326008)(2906002)(6916009)(36756003)(316002)(66946007)(6486002)(186003)(16576012)(31696002)(5660300002)(508600001)(8936002)(38100700002)(26005)(8676002)(66556008)(31686004)(86362001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MnpaU3A5WTZ6c0FKT0t2WUkyQWcvR1BQR1lwaXRDUW84RFBlYkdua2p0eUFU?= =?utf-8?B?OEJzREIyMmVZZkp5SVZOUmYzM2w1L3Q4bWszN2tnQStyeWFLU1h6Z0g0bDBC?= =?utf-8?B?Mitqd0xUQnFUaENXTFRORnE1SmlRbFRzUzFEUGtxNGpuV1pKc1A4V3UyODBr?= =?utf-8?B?cy9RNG41Zk9abzBQVEE2VkovMWlDR0I1YmNTY0RJbU5XV2tnWHppbTJEN1E0?= =?utf-8?B?VVl3QmI4czJiUEFGcjB5TVQzVHhnNXVXMVdRdzJrRjc4VHNNdXBTVkhWU1o4?= =?utf-8?B?MkdxNkFaODlZbkFNSlNmK2hIb2FaYTJ2cWZScW9wVGsyaTlXNGphcjFPZDRP?= =?utf-8?B?NXU2bmZyWW1hVWhvVXZ6YWs5OEV6VE9qNHpkNEx1cjdwaG9FOGhrRGtyVVVa?= =?utf-8?B?OXRUQXplWjFEaFA3QS9Kc0RGUk5sVWRQcGRTTTJmaDV4dzF2Z3k2S3d5TFZD?= =?utf-8?B?VFc1NmdvcGhPQjQwZXFFWW9ZYnkwcEcxWkNWMmVibmRZWnd3T1JTeW5TU3Bz?= =?utf-8?B?S0FITWljMjI2Z1FCSVVuSGFUbkJwbGhpbDd6enRRQVlWcHNya2h6aUdrNlVr?= =?utf-8?B?ejZyVUVqcXNvMzVOOXRZSmtyZ1U0UmpOZktrN0lpSzgrU1hnR1c1UmR2L0xH?= =?utf-8?B?RWp4YURGRS9SMnNlakdPTkFSNUkyTW4wcUc0OFNGT1UyS20zVTBaWDdzemlR?= =?utf-8?B?a043OGNkcUljbFpwMjJmK01qeGhMejJzUU5hSmdaZXJucS9VdU5ZMEswY0t3?= =?utf-8?B?a0RMZklFYUx1TWxSRjRoU2ZlL2VJWER0eE43Wjd6S0M1QW51RTN3NjV3UHho?= =?utf-8?B?Q1haMSt2VzV3c2d0SG05RUpWOFNENzNMblZoYjBQb3NYVjlFcUJqbEY0MmRo?= =?utf-8?B?dmcwcUhMTHdSSmZ6WmgxdDE4VHRHbzMxZUUyOWk5M1c3VEtlcDd2aTM0MmM4?= =?utf-8?B?R3U4MTBTcEFyTnJGUHd4dDNXU0IxN28za0tua215L2ZRQjI2MTh1NElCakdH?= =?utf-8?B?MTFwUUVVQUxHeUVjbEFZN2NHNTF0Mit1ckFVY3pXekxJaVNmU0xGK0FHUEto?= =?utf-8?B?QmxQVERaSUQrY3pIN3l5YjlJVWFuelRnZ2JKcHVQSm83bDZER0xTdVNHZlJT?= =?utf-8?B?L0pibXBLd3pBQ0tsT1pFSHUycVNiTWJLN3pVSmt2QUUzQWJwMzlIQ0tJM0pE?= =?utf-8?B?T2phWE0wUnNTSythZkl6U2pmUkgyb2RzZ3orblgwZWUvcEF4c1FDVFZjL1Qx?= =?utf-8?B?VDB1USt0cVczSUp4RWh6NXU2TEIzQm5ybVlVVlVEOFNPZWpkN0d5Y3p3K2NX?= =?utf-8?B?ZTEwZWpFTFkvVElVams2bHlySWZuaUhuc3IwWWJYZkpLMjc1eFB4L3RwWkcr?= =?utf-8?B?Yk90Z2lUL3htWkFoTTNQTGdySVZBMCtPbHZWMkk0cjBtcE1NdmFvQXFEN0s5?= =?utf-8?B?bkE1RGpsOG9HdE13MDJmNERxZ3diL01DVCtZYVZlZUVCWXZwemFhOHBXWHdB?= =?utf-8?B?UjdxczlQKzlYaGNiVFZpUGFxZS9xRG94UFE2MGkxRlZYMUxSNlNjZmd1Ry80?= =?utf-8?B?ZjcvWGU1UGdWdG52b0lpK0wyWTdYelBtbTJ6NzBtc2U1dkFQZytCdkw0L3FX?= =?utf-8?B?cUZyZUtQMUVteWFYbldQbTQ3QkprY2hvczAvM2VUK1BzZldYTjYyanhLbytP?= =?utf-8?B?b25rVndzRDcvcHBDQ0VGRmlQa28zTGZpYXF3c3Z0NXRRQUllYXhkakpnKzJp?= =?utf-8?B?UFQ3UGc3QTIvN2dOUnZJejJMVSs4TStoUndLNldocEtmMEgrMGdLUkdCV3Uy?= =?utf-8?B?S0Y0WHlLU0hYMHRzMEFGRHQxNGNpNXNQdkNHT0M0Zzk2b3BhWWV2N3VST1k5?= =?utf-8?B?SlNvK01CaEZCVmMwK0FOdE5vbmREYndnaUpGdTVnOFZoOWx5YjdRd0kyQ1dV?= =?utf-8?B?K0ZNZXBSSk1CTHJZN1JHZ0RRWEtBVmFQRW9FOTd6ajd1ZGQ3QmZPTXRXWHhS?= =?utf-8?B?eGNONXFwVGR0ZjhGODBIZlZkdk0wTTl0QUluWmxScDV3U0dhTU54UlFKbGFQ?= =?utf-8?B?UEE4ckNwcGhLTjhYZmcxZG50dndZWklselFzNkZ0bkhsQjdCT0tJdnZSVlIv?= =?utf-8?B?V2lvbjcwbWdnOXJxME05TERVNlBaTm9SK3B1RFJCcnQwZmE1Rkk2d3YvZXZQ?= =?utf-8?Q?XzxFe/MMmq/DX8Sn73PQ/Pw=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 10cc8ec8-4365-4cf9-493f-08d9ae86c206 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Nov 2021 13:40:05.4477 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: PMaa9gcJ4vcKR4TExIcAq5j5eySrab3SoeocB9lKRROFEYeMo1RGzLYa/kjd4gK5uU1TGLiy5n5o0aJWRroD2g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5325 X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1637674834870100001 Content-Type: text/plain; charset="utf-8" All our present implementation requires is that the range fully fits in a single page. No need to exclude the case of the last register extending right to the end of that page. Signed-off-by: Jan Beulich Reviewed-by: Kevin Tian --- a/xen/drivers/passthrough/vtd/iommu.c +++ b/xen/drivers/passthrough/vtd/iommu.c @@ -1229,7 +1229,7 @@ int __init iommu_alloc(struct acpi_drhd_ quirk_iommu_caps(iommu); =20 if ( cap_fault_reg_offset(iommu->cap) + - cap_num_fault_regs(iommu->cap) * PRIMARY_FAULT_REG_LEN >=3D PAGE_= SIZE || + cap_num_fault_regs(iommu->cap) * PRIMARY_FAULT_REG_LEN > PAGE_SIZ= E || ecap_iotlb_offset(iommu->ecap) >=3D PAGE_SIZE ) { printk(XENLOG_ERR VTDPREFIX "IOMMU: unsupported\n"); From nobody Sat Apr 27 04:20:49 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=suse.com); dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=2; a=rsa-sha256; t=1637674853; cv=pass; d=zohomail.com; s=zohoarc; b=PqpoO0EtoxFYJaqnVlRcQra6cDsaNOW70Q7H+djdd6Y1pb9mo6PADoXM8f3wKMTBNgKel4Gh2nC8hceFH/OLtzi8Hf3pUbFG5FvtkRmeKTRJ+in4K5o8lW3+B09SVXcaXI50GuzXnwreSLdFa/QbmHd0ghJPSKWoKoNhB/iaGMs= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1637674853; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=GlPYVPHHKY0fQf4fXHxR88XAwYQ3msowxF+8PXwpKEI=; b=B9LGNAg5GzV/L3CI64kgxouL7QNMYW0HwDC8sshbMpsiUn2Wo6DTNAS9a6Vy+NQSEhys5aez8J4OkEzAIpxfRFCFOQLYEIErLMqz9GoHNuaGeJ7oWUAZb7nrI8BNOXgqCx8s/beWiqy9DweUzoZ4BdjAQCxBlAKeySMf2AR3Jx8= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=suse.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1637674853309129.15614350817407; Tue, 23 Nov 2021 05:40:53 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.229611.397070 (Exim 4.92) (envelope-from ) id 1mpW27-0008IJ-Lm; Tue, 23 Nov 2021 13:40:27 +0000 Received: by outflank-mailman (output) from mailman id 229611.397070; Tue, 23 Nov 2021 13:40:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mpW27-0008IC-HZ; Tue, 23 Nov 2021 13:40:27 +0000 Received: by outflank-mailman (input) for mailman id 229611; Tue, 23 Nov 2021 13:40:26 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mpW26-0006K2-5g for xen-devel@lists.xenproject.org; Tue, 23 Nov 2021 13:40:26 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e9be069d-4c62-11ec-a9d2-d9f7a1cc8784; Tue, 23 Nov 2021 14:40:25 +0100 (CET) Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-ve1eur02lp2054.outbound.protection.outlook.com [104.47.6.54]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-31-UhAEPmoZM3e6cHHxmmDjGg-1; Tue, 23 Nov 2021 14:40:24 +0100 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR04MB5325.eurprd04.prod.outlook.com (2603:10a6:803:60::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.22; Tue, 23 Nov 2021 13:40:23 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::8062:d7cb:ca45:1898]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::8062:d7cb:ca45:1898%3]) with mapi id 15.20.4713.026; Tue, 23 Nov 2021 13:40:23 +0000 Received: from [10.156.60.236] (37.24.206.209) by AM5PR0301CA0004.eurprd03.prod.outlook.com (2603:10a6:206:14::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.22 via Frontend Transport; Tue, 23 Nov 2021 13:40:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e9be069d-4c62-11ec-a9d2-d9f7a1cc8784 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1637674825; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GlPYVPHHKY0fQf4fXHxR88XAwYQ3msowxF+8PXwpKEI=; b=CuVWfBMBTuC27D+2bhQdClmbLCZXg8qZF31ywejirw2oESN5GvYAXMvu7hkMuDEbUGOshu EyDp+TtCBIqLFY4gqOv/fU4ZXYqPJsfbKYpHMGzWcl2UfJS6wifhwmLPUtZU+7lV065umf IPEnzRtD2en4gFL6fMwpXyz1zzInpso= X-MC-Unique: UhAEPmoZM3e6cHHxmmDjGg-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=e3OXwlBXBA1tw7vEgUymdKuo1o5wqWQciBxJjY/2bke63RZqF7BUb5CjoR3nQlAIPxjWBYEmG+R8U1ValllOgy6iK1zEhDd4Wah8SmdnjkLmrDZHxlEWxhAPvU6BXCI4sg89daJilebanLB3wsnl52jhIp1CK/3HrQ8KQMXjFL0mcCc8xrzchRMOTUcQ5VHAjKICM3IItBfykZ3HoW7jNcp/duiIgAzw9DVTCRrDL2Dtb85IcMzDCmY5B78J/9+NimK4D2IJNMXbDQ8BH8vi1NijgXRUzQPkhC4tu2ChO260dneEwZjbUjTNjUUebhM61b7EsAUuAPWVZjg9ofq0ig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GlPYVPHHKY0fQf4fXHxR88XAwYQ3msowxF+8PXwpKEI=; b=krGXBSTXg6qwRPtca0mBQdDsmCbspKtZskIEUMfzOcF3I+8A+tQm2AeTfVSj55zoyCBSyj0kSwd8JF1y343PxzZQT8pgJ2763x7XSTeILvJl7EpHy8YCB6vClsZnr0R6VBHb48meKN2OfqXG6oH6kOfUYKmEpf8SIl+/HYZS3oqQqQO+FCCvDjcnWUaFAtnRKkwelMV6x9OMSo42RSDxh6zgQFYahlbvWQpkoW5qMsdox3i9/rSISvrezXmbW4VA76Hhp6AR5VvvtR/8jJGbNyOavBGKvhbrLu3e/94bCfYyqccr6ME0bDsFBZTsSgFvYLM7YRuRcfr3FVezKxMHGA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <63da915f-03dc-f846-3c6b-e90890d1f8fc@suse.com> Date: Tue, 23 Nov 2021 14:40:22 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.3.1 Subject: [PATCH 3/3] VT-d: conditionalize IOTLB register offset check Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Kevin Tian References: <54e38a20-5281-2ab3-8513-3506ab66dbe8@suse.com> In-Reply-To: <54e38a20-5281-2ab3-8513-3506ab66dbe8@suse.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AM5PR0301CA0004.eurprd03.prod.outlook.com (2603:10a6:206:14::17) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4b5376d2-ca02-4e53-a250-08d9ae86cccf X-MS-TrafficTypeDiagnostic: VI1PR04MB5325: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6790; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: H4dRqMBCOdhQ4C4FIxDcFqJruA1RgqcaI59PQ++3TskKjPxP9C4rkKM5//Q/ChJ5isgXpc+LWe27vXNRBCa3qcv3Kd6jJfpMwiUPOzu1BMn+fM4DleJW+VrXgZhsw/B4DeHTiftufsbGXARsy57prF8wIs9ETA5bFQYsi041+v1j+2uYD4JKCcvmbOVKLwJE7hIkgBYxb2+GeR688+GUmuxHxwD2Rc/ajEdMvqHIEdHvmzhrvwVgTHlm4tYmMap/eQX0MvNTOSe+xWMogi3Pf1k/1FQAlzBT8/nfXxDOb36N/24ciVw+GzRNJlpsT0Ibd6f3FluPw6PkpkJlLuD3ChsEoXqtIJonohX5Xan/F4p87XNgq/zIg8hS5T/bFs8mvEhB18asoS8WU2YLkDTDYDo8zrkRwmTVy0jSdrbZ/B1KJXMxeXI7JeNDQgUN+Wx0IUhAKbAR7dEZtA/uC1KpcRb7woe1XESaJiLUKFxg64ycBPgJlVgw47GN9hmw1KZIbinz0gFKreRZTm+PCgFYyd7YLAhL+/vpBAUP7nBJom5Z3FX/iixIb7EhTISxC7xBdkpHsxRk+KMGO1untwE2rkCZN056Ymfu2bgcaP43gm1gCcKYfBLLi6WyEnJO2KTu7aWDYami356U6vv5NI3cFnqYg6zn1HrpLlR83S5DVgwrrlSq+v3kJbwxqT3s0Zo0w9KPH2VqP9U5G1iDiReZN5GouG3s5BtJREPgkzaBm4A= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(956004)(2616005)(4744005)(83380400001)(66476007)(4326008)(2906002)(6916009)(36756003)(316002)(66946007)(6486002)(186003)(16576012)(31696002)(5660300002)(508600001)(8936002)(38100700002)(26005)(8676002)(66556008)(31686004)(86362001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QktXYnk3UFpWbE9mYm9kZStFQ0FtQXpsU2hpOHVWRzQrWUdVa3BVRDIyY3lN?= =?utf-8?B?MUFrUG5vUVhONnE2eEk2ek9DL0tqWWZxcGg1OWdpbW9yVlI3WmJyRENZZGhY?= =?utf-8?B?dldMRkVkSHVTU1h4NmVNMzJUdlFzUEVwdlNRbnptV2haeXRhd05VZnArUkFo?= =?utf-8?B?eFNwdW52UkhEMkJjZkF4UWxRUFJ1elE3SG14eHh1N3J6SEwrMXJLYW13UXU1?= =?utf-8?B?ZmhZeUhHSDVKa2dCa0ZuU2lMclBNdVpJVURxVGZjRHBHWElpYTdTbWNxdXBT?= =?utf-8?B?QnhpbEtZMWpiWEx1ZnFEN2srTzdYZjkzUEY0dmEzVTQwYWtOWnEyWGZYWEFw?= =?utf-8?B?eThLeUdyd3JWNDg2S1Y3RHUraXU1RElMdndjak9xQ1VsNWpvNVJGY3J3YWtO?= =?utf-8?B?VnhzL1gyTzdac29teTliV1lCZnR0cEtodmRGRHZieS82Q3lKcFJDcU8rb3RV?= =?utf-8?B?b1FabzdIK0h0STFCd3N2NmNBUnNSNEVCUHU4dnl0VEx5enc1UHg3Ris4NVNL?= =?utf-8?B?S0hnNG91SGZ1a2Z6dmZJNDZ1d1FFM0hTNEpneHYxYnh6bXBiTjZSY29sUUhI?= =?utf-8?B?MC9HMm91MGNCdEdhSEhPWWk5citBanNhZno2byszbmtYMUw0cE9VaDFxOXlm?= =?utf-8?B?S3B0ZTA2ZFZkSC95ZDBTa0NYc1Y5QjNjMDFyMjliK3dhQ1ZCa2M2RGl2cVVW?= =?utf-8?B?UXNyd1hlYzlVbXBRRFhPTG1JWTJpK09nTjk5VGlud1hTQXF4MVYvWm5nYXdS?= =?utf-8?B?dmZpQ3pudkNsOXlUdGhzTDdFdzlGUUR5TWdRaXdSQThyVmV0YUJQMXNnL2tD?= =?utf-8?B?N3VvcFY2T2xmcjBUQ2lpVS95R1hXZUZIbWNyTXBPNmtXWTVrTCtSTDUzcW5y?= =?utf-8?B?QXo4YnA5b29GMWpDcHlrM0hMK2swZGhFbzkxWDFFNGJSR2xTTDdaWFY3Uk0y?= =?utf-8?B?cmdOandlSWhHcXZjR1dpWGIzSXdrNHJEZVh2ZndNVW9sL3JLelFmS3VqUXpr?= =?utf-8?B?WHdnbUYxdVRzWHU2djg4Snd5b0U4RUZVQTBLVTVwRVpkNmxlNWlubEFpRTRs?= =?utf-8?B?eXhzYW96SGw5cEtTdlZOOG5UZzJ0L1dOc01FRTcxQlFBWFhqRVZscmRVUXJi?= =?utf-8?B?dmQwemZuSEt6eHdHZ1JvREJ2Z1F6VFZFZWFFVDZyRWhVR2ZwQXBqbFgwRkpu?= =?utf-8?B?ZkJza0wzTllwS1hUUS9EVXFraTdCVjZDMSt5TDJEelV4eExFbXdqcEd1ZTVh?= =?utf-8?B?NnhhUHF1YnJpZTZZVVlQRkxwdnJ6OXkwVnNqWTEvbFk2WVB4UE5yN2lwNEw0?= =?utf-8?B?Q1RXd0w3RXg2d2Z6NUkrODNHakh0ajgvb09WQjBsT2lPU3hGbEVMd0w0ZlFL?= =?utf-8?B?ZmNxNnkwRHFuM2d3MHBUbFNxd01UT0oyVDVTRUt1N01NRmN0bUNTeTkxWTFD?= =?utf-8?B?d1ZSd1hmbWVwSldGVlRVajNsRERSNFdkZGxENG1uaGZuR3JURTczQTBQRGls?= =?utf-8?B?SXpKK2xPRUNuSnNYbzdOd3ZGaVZFaXJZNkJVL01HSVNzc2JBTVllWW84OHhB?= =?utf-8?B?UytlWU1qaHQ1eXJvbncrRUVoY0lxU3dqcGlrelY4K2M3blFienppNjBRRXpJ?= =?utf-8?B?a21ST0taRWFmN1FnL1QwYzNFbXk4eWFEbXNYRnp2ZUZ5djRSUUE5THdQakVN?= =?utf-8?B?aFNUY0tUdWM0d3V5bnVvcDRCUmdERDhMM2g4NzRraDFQd2tVWlhxYnRBam9n?= =?utf-8?B?TTJSc05CWEpFOWVxY3VPZ05QNHMwcFhrb3lqMEM1TXVPMGd4Z1lXVlhPRmF6?= =?utf-8?B?QTU4N3pMcm9oWHlDOVIrSjE4UnNnVUxDWEJVN1dCNTZ3Q0N1TW9FMDU3c1FE?= =?utf-8?B?c1RQQTRuQlN4bndIV09zV0dseXhUMjBibUEvci9mYlRYMHA4NlJvYWx6ZW10?= =?utf-8?B?TS9yTXoxcW5lMXpFaXdZS1FTbXlPUW1nUjdjTkxWVzBmKzNibHRLK3JTaENG?= =?utf-8?B?REVlcDZYbnIvT1ZlZ2lsQWJpQ29HdUtrOGtoR1ZVeGtWams5bklEUXpYL1Iv?= =?utf-8?B?b2tPeEV0bVUreWtnWFBwSlcvV21Ydk83VjhIV2JMRWgyM3NuVEh2L1Y1RURN?= =?utf-8?B?K1hnVkhGWGI3YVI5YnNXWmI4d1ZxVmNlU3o0SCtEa1B4Z3dkWCthZHhkZ29v?= =?utf-8?Q?hsonfecHDxmWObJz1M2MZgE=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4b5376d2-ca02-4e53-a250-08d9ae86cccf X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Nov 2021 13:40:23.5595 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ylcz26brxDMbB7XWxwU3kUyJnLnKak7guYHVZiKElvlknl6DhMQ5YaSJMEbSyWbGOAJYSlUMIaGuAZTKznYbQg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5325 X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1637674855320100001 Content-Type: text/plain; charset="utf-8" As of commit 6773b1a7584a ("VT-d: Don't assume register-based invalidation is always supported") we don't (try to) use register based invalidation anymore when that's not supported by hardware. Hence there's also no point in the respective check, avoiding pointless IOMMU initialization failure. After all the spec (version 3.3 at the time of writing) doesn't say what the respective Extended Capability Register field would contain in such a case. Signed-off-by: Jan Beulich Reviewed-by: Kevin Tian --- a/xen/drivers/passthrough/vtd/iommu.c +++ b/xen/drivers/passthrough/vtd/iommu.c @@ -1228,7 +1228,8 @@ int __init iommu_alloc(struct acpi_drhd_ =20 if ( cap_fault_reg_offset(iommu->cap) + cap_num_fault_regs(iommu->cap) * PRIMARY_FAULT_REG_LEN > PAGE_SIZ= E || - ecap_iotlb_offset(iommu->ecap) >=3D PAGE_SIZE ) + (has_register_based_invalidation(iommu) && + ecap_iotlb_offset(iommu->ecap) >=3D PAGE_SIZE) ) { printk(XENLOG_ERR VTDPREFIX "IOMMU: unsupported\n"); print_iommu_regs(drhd);