From nobody Wed Nov 19 01:57:07 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1763478357; cv=none; d=zohomail.com; s=zohoarc; b=QdT5YzGZ271IYp+W37tT8ZP3cICt+0vnjrAOSAZZsPXhzl0eoXl6uojztg2iA6yWHZkc2wd7VEyZm1ytcE3YFxd15nRoVSOLEpAwzeriu4OKgnFI2PGojy5xCZCpGJaGZ3su4HZoCl/v+zPtOaGV4NYmetGb9ohYjdXK/ltxDUI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1763478357; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=pgIgBRyiwOjy12i+6dPUnzqpZO6a+/apZ7nKGk1jXJ4=; b=ehz1BvKZINeRvGZybznX8mMMrVCKuUtoXHqXcv7/tmCoHQzkQGVD1fZvMy3kAFr6G4EGt0rIRo/5uzt87a+e4d5VQ65NSXSmBzULkTLYVz42kLVF4D69jfOa5BV9evCRdAviZwfC3QTSwb1eyGv3AKNig++J7ZtCWxABCTVWLrg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1763478357991180.17408327791998; Tue, 18 Nov 2025 07:05:57 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.1164904.1491754 (Exim 4.92) (envelope-from ) id 1vLNH6-0001ol-Vr; Tue, 18 Nov 2025 15:05:44 +0000 Received: by outflank-mailman (output) from mailman id 1164904.1491754; Tue, 18 Nov 2025 15:05:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vLNH6-0001oe-TH; Tue, 18 Nov 2025 15:05:44 +0000 Received: by outflank-mailman (input) for mailman id 1164904; Tue, 18 Nov 2025 15:05:44 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vLNH6-0001oV-4F for xen-devel@lists.xenproject.org; Tue, 18 Nov 2025 15:05:44 +0000 Received: from mail-ej1-x62a.google.com (mail-ej1-x62a.google.com [2a00:1450:4864:20::62a]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0d9fec03-c490-11f0-9d18-b5c5bf9af7f9; Tue, 18 Nov 2025 16:05:43 +0100 (CET) Received: by mail-ej1-x62a.google.com with SMTP id a640c23a62f3a-b736ffc531fso718723066b.1 for ; Tue, 18 Nov 2025 07:05:43 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b734fed90c0sm1387633666b.65.2025.11.18.07.05.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Nov 2025 07:05:42 -0800 (PST) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0d9fec03-c490-11f0-9d18-b5c5bf9af7f9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1763478343; x=1764083143; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=pgIgBRyiwOjy12i+6dPUnzqpZO6a+/apZ7nKGk1jXJ4=; b=fhzV+UEwSuV90Ps+qM2iWY8y/q8SnJNeFHI6kAHJA8EywDq5x/OLbzOz5D5XRRRcd7 ikuu9ESA070puRnoKM94TPkrO4Ss1FOL5Pg61XFeACb4UtRzmO4AUhzECew51L0XmB/z lQZ9uEJieFoYFME6/AV06cYEsKiTY6YWBC/Td0ABzOcCcVEHQQFsYcWChiXcaZGktTue H9qDuIwuF+OpImnFA6FY0YdT7QT72VNKjBlSg4LaD8mruHJGPZ+JGT+V3B4m4apTf/ry w6wIkyK2XpSu/OKafuveLHrVtBLIBLFWgNnvEQCTypBjNbxtzzLYHkkDRVzUTy0/7cqe 2lfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763478343; x=1764083143; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=pgIgBRyiwOjy12i+6dPUnzqpZO6a+/apZ7nKGk1jXJ4=; b=PO0T0EyO7cxHxrSMZOwBpE43da/iyqSN/hjtY+4VV/soTTp0GdvbjvoDPek/Cmfhy7 rf91QHThPfGDI5lrecm8T2tMAB+TZnKQWbEwO/DWdMlzxsfXU3DulwaUv2ncsyfD0QF8 tVtUezJvDXMZZAhweuu/eE5KW8wQlWMiCPp9cO0xD2tjT0xn52KIAgQOUV4gfNMtZ7eb fExlJQ6UCZcnUxR9kqQSDBc9Mo0ScVCH9ncAPBW+hSU6wD/jrgtPv2u3YVeHortLGME6 zo7KFiWXX6Z5HmC103+HQZJ+bXzuNEIVCVp+4kc7RNkUjcEWcXLwfVjfFk5uc0gzDfzY Uj+g== X-Gm-Message-State: AOJu0YwLYBgkmlB9rO7MGHeIgjUQL57iysJJROS/WMINAPURsgiSDBzg UkiIqubHHVmjgWfw2iFEbHaUgVJdmFSIbyc3LIKTPnTrVngxeJ9Ld0DdTkJ59ZAlRw+piIhRDX+ wbjA= X-Gm-Gg: ASbGnct7WWWD+9EPR7yJHtCVuPLiDj+7Xc6rzUbdi1sNm34GfMkeVXXN6uoUZrPj7Ob 2uVhPpuhg+pYJe27j5L3EnaZoQZaTFvCfAIuQYjomrlpvEYEFltFYYAov+6eQnZpvobc+Nhc6O8 2Fr4XGswKg5kcIQePED/om173bm3vOe09V/WzvGaBihb7snEuDDcF+FKZpCHyKyLOfoH+wdKyIK jXxYvDeZg3vdHhP+9LJvKjpmYN9Ji/om2jSFh+nHzQEAlhWkbcWE70ayeXLIlaF9dK2QeSBrPMi JwGSQb6jR58kYvBCjlzBgvpbknnOM880hikIAjd8NQmhZ6bwPMDMYIIVOR/A32KisrHUWSs/k6t tbJvX3IRAVWhBaRxeN6QlszczyyWJ8kx6zhf+G9+xYB86QdfGHVHKhKbyBrv41+SFmusHjhkMUw yeTUV9PeY+P0unIcHhTaGJDglptR+IbpJ0huhBEu+Hs5vxBLIFzoiiIAskVywbmYlnasprKa/GK PWSKvZE50wDSg== X-Google-Smtp-Source: AGHT+IFpf6pTRBLI+R8S1l7vTgZNNT3iCQA3US4G+aR+ZYIXjj2+t2wNhkPnHMWteSDiMYPU3RSJ6A== X-Received: by 2002:a17:906:9fd0:b0:b72:b8a9:78f4 with SMTP id a640c23a62f3a-b73678f4f66mr1837416166b.39.1763478342628; Tue, 18 Nov 2025 07:05:42 -0800 (PST) Message-ID: Date: Tue, 18 Nov 2025 16:05:41 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH 1/8] x86/cpu-policy: move invocation of recalculate_misc() From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Teddy Astie References: <53ef6c9a-1115-4bb4-bb7f-e2595ab9d0b6@suse.com> Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <53ef6c9a-1115-4bb4-bb7f-e2595ab9d0b6@suse.com> Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1763478359964158500 Content-Type: text/plain; charset="utf-8" The function is about guest exposure of features / leaves. There's no need for it to be applied on the host policy. In fact doing so gets in the way of using the host policy in certain places. Signed-off-by: Jan Beulich Reviewed-by: Andrew Cooper --- a/xen/arch/x86/cpu-policy.c +++ b/xen/arch/x86/cpu-policy.c @@ -383,7 +383,6 @@ static void __init calculate_host_policy =20 x86_cpu_featureset_to_policy(boot_cpu_data.x86_capability, p); recalculate_xstate(p); - recalculate_misc(p); =20 /* When vPMU is disabled, drop it from the host policy. */ if ( vpmu_mode =3D=3D XENPMU_MODE_OFF ) @@ -634,6 +633,7 @@ static void __init calculate_pv_max_poli unsigned int i; =20 *p =3D host_cpu_policy; + recalculate_misc(p); =20 guest_common_max_leaves(p); =20 @@ -736,6 +736,7 @@ static void __init calculate_hvm_max_pol const uint32_t *mask; =20 *p =3D host_cpu_policy; + recalculate_misc(p); =20 guest_common_max_leaves(p); From nobody Wed Nov 19 01:57:07 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1763478391; cv=none; d=zohomail.com; s=zohoarc; b=HPspjsuX3q07hzW2c+BdMwWOJlkW9ONHMaxgi6Be2hzvNVcmQz/4Nbaltz1lHnghooquAUc6HpcHU6o3uCijzj+VXooaZCCI3i3F4PCrzjS1LwZxaIQ2SZAtKtNa3qnM627xPj8dJEhj3WVK2DvVDO67gqnDK9FUQmDvGxXJuLY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1763478391; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=MuGvsatbOCNTnf1+piHi4k6STW82U3evhUtfXUWwz38=; b=I0Ej9JqhLwoGwf6LB+lrEjHtgLii1o/7mZAKlSZIw1LYTNvxVclT0/dFucelCcUv4BQY6HTfxTLO4aKQg3n1t4XA5QVJTsa6yFnaFPB5So4F81pnYYVMT1kwhKMMepGlCec313J9jjSSn7LXVaxwtxOB9cLIgS8NZUM4uUFzlVs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1763478391243843.2473989411952; Tue, 18 Nov 2025 07:06:31 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.1164910.1491764 (Exim 4.92) (envelope-from ) id 1vLNHa-0002F8-7I; Tue, 18 Nov 2025 15:06:14 +0000 Received: by outflank-mailman (output) from mailman id 1164910.1491764; Tue, 18 Nov 2025 15:06:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vLNHa-0002F1-4O; Tue, 18 Nov 2025 15:06:14 +0000 Received: by outflank-mailman (input) for mailman id 1164910; Tue, 18 Nov 2025 15:06:13 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vLNHZ-00026P-7Y for xen-devel@lists.xenproject.org; Tue, 18 Nov 2025 15:06:13 +0000 Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [2a00:1450:4864:20::536]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1e5faad2-c490-11f0-980a-7dc792cee155; Tue, 18 Nov 2025 16:06:11 +0100 (CET) Received: by mail-ed1-x536.google.com with SMTP id 4fb4d7f45d1cf-6419aaced59so7585778a12.0 for ; Tue, 18 Nov 2025 07:06:11 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6450e8d1a23sm883561a12.15.2025.11.18.07.06.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Nov 2025 07:06:10 -0800 (PST) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1e5faad2-c490-11f0-980a-7dc792cee155 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1763478371; x=1764083171; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=MuGvsatbOCNTnf1+piHi4k6STW82U3evhUtfXUWwz38=; b=XwPw7oGq0Dz3tDGnK9H4mVkz3NlCua/EsIGWpagevuu36gQzMXoAzM5/Zw72fYsEx4 4yWMpk8JaBa3VN5IQrj6fENrNIjw5dWk8K3SlIRRDfuzy082B8HIuv2hLNUrmdMpDLt3 OukLgqY3qYsxMK5IfIRKyyB4ncRMq0ox2eDWvo1d8cTvrtyXoeLBGuwbVWXzpypVZt3i G23Kgq5U5dm6HQ0acVRaD6NAGZaOXpqAlCd2aj/UP1QlfsihuAMjz00+y4PgZd4l1KyK JQtYtCIH/CShPjGhRuepbiTz4RU4K+UU80x+r6td6Iu3L9gThi9JKW5IknrvMAWKtils geZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763478371; x=1764083171; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=MuGvsatbOCNTnf1+piHi4k6STW82U3evhUtfXUWwz38=; b=lrOtj2X4Z8XQAI+ymLzfUvJh6rRaN40ZQ/dacCz0CNsq+uRc83Z/E6VRk8BsxzCOiz WtHTfuX/jjNFV2BHeAMsxrk/drleiroDkcGG24zipUmW7CoqFMJEEWQK7gTjc4bZya9Y GiM+R5i+WAHIKTQJCQIjTh6+o808+l/cIP5TBMoSd9d30uJgDknie+1+7zF+O2KLbuu9 smZ49q9FFeHrBgNCQIe/hBYzm/mC7zJOq0ZQyVwysZd54G+ijk8R6MGVqkPIaFyXwEJB irI6atF9JeXXRXKGx+YHRpN97FqAXk78UA8WqCB+Dtzy8jZFPe2WfNfN7yT+RlbbFKkp CqsQ== X-Gm-Message-State: AOJu0YxfXmoS3ocsIiM9AUB9cgWpKUW/EettVrSBd25kh9AV0mANIZ+3 B+PLNq2Z7e4mgBJUpZKbv9bVyUZERGZQF7PqVWJHqk1FYzI2fCIn1nz5lwWtgl6FnHjjkN8sPQM KKv4= X-Gm-Gg: ASbGncuJixqDfxSMwdoP8Qh3IBUMROXXnhWA7VUjo2q/2T0f0dR9Mfgq3MBW9ddLLuY kXCTdUKeg0naS3IGroDdTNVBhxZse+W2mbMpxqNLNHIgu/iXE36oGKHI2aL0KuEmFDg+4fWuPsl mRARFUqiT+p6cgCwpnmmZrMmBTG5coQ6PcJYPo5w5YMzXjqhgAeFPE4QxhbZIvXLDFbiIOUQwt4 C22E0QPhhc3CzXHWV0K0hNrBrEOwYFV0asC4Jebh4visvY0MSF8nN27kQk8b4Kckz9pAzaYA9rS c+zUbcUfQph1clV9J4sSSuvWPHUfBl2OXR3SlOcPRfgp+1F8oVqygHGzaPh5exBOAQAsIyaMxnU k0qKU5FC3O4jev4tMkqmZPSmlnoKiqm8tArkHBT4Yd8TBzw1ZT9IInxEJlZ1SOogO07o1FHejQ4 7EIoZpnStxYsGjYp21w1S7uLIWfSOIwIsOyEh3wQ5BhwUGSleJa57zc7mAQVKjiSo5 X-Google-Smtp-Source: AGHT+IEEiBmygkrrcJUcQiqLuhkHHAct9qy+FLpfROJT5T1xQ3QMMYhvLBaCTwjo/TyStGFSwZN+Ww== X-Received: by 2002:a05:6402:20d5:20b0:641:297b:5567 with SMTP id 4fb4d7f45d1cf-64350ec18d4mr12995892a12.35.1763478370677; Tue, 18 Nov 2025 07:06:10 -0800 (PST) Message-ID: Date: Tue, 18 Nov 2025 16:06:09 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH 2/8] x86/cpu-policy: define bits of leaf 6 From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Teddy Astie References: <53ef6c9a-1115-4bb4-bb7f-e2595ab9d0b6@suse.com> Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <53ef6c9a-1115-4bb4-bb7f-e2595ab9d0b6@suse.com> Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1763478392505158500 Content-Type: text/plain; charset="utf-8" ... as far as we presently use them in the codebase. Signed-off-by: Jan Beulich --- Or should we make both parts proper featureset elements? At least APERFMPERF could likely be made visible to guests (in principle). --- a/xen/include/xen/lib/x86/cpu-policy.h +++ b/xen/include/xen/lib/x86/cpu-policy.h @@ -121,7 +121,31 @@ struct cpu_policy uint64_t :64, :64; /* Leaf 0x3 - PSN. */ uint64_t :64, :64; /* Leaf 0x4 - Structured Cache. */ uint64_t :64, :64; /* Leaf 0x5 - MONITOR. */ - uint64_t :64, :64; /* Leaf 0x6 - Therm/Perf. */ + + /* Leaf 0x6 - Therm/Perf. */ + struct { + uint32_t /* a */:1, + turbo:1, + arat:1, + :4, + hwp:1, + hwp_notification:1, + hwp_activity_window:1, + hwp_epp:1, + hwp_plr:1, + :1, + hdc:1, + :2, + hwp_peci:1, + :2, + hw_feedback:1, + :12; + uint32_t /* b */:32; + uint32_t /* c */ aperfmperf:1, + :31; + uint32_t /* d */:32; + } pm; + uint64_t :64, :64; /* Leaf 0x7 - Structured Features. */ uint64_t :64, :64; /* Leaf 0x8 - rsvd */ uint64_t :64, :64; /* Leaf 0x9 - DCA */ From nobody Wed Nov 19 01:57:07 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1763478415; cv=none; d=zohomail.com; s=zohoarc; b=Ph56bMC7SJ2KWRKuzt/64Cg2MNO60vHDERQBWhusEnx5dWOK4LkoorE0ZYvaSPjXVf39rhSQUou/tBHAKwGQk64bYj16UBgR/HBvjweRMOT62dusmLrwNI+fdxsqsVU544+jEOrVRFVbqVe5qFSAb4nm8xkDr8rUPI0EMfEMzVM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1763478415; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=jMn/cyVZqsuQaGJk1ULIzcL8rHs+FxB5cgoYXyQZKyQ=; b=R7ucCmTETp+NmFiMqI87q7UtW5THKf5hc6Y/X+OuR2/vMs3J+Wm3XvTvIFTCuvpzNLx1XlMRzmEzSsJ7eJzbGKhFpnJReCcyYLnAOIq4nXU56XCuA/yFZFatT5QHN6gbGhOG7sdu1Jv8SG1DTv3HvW/SEhZ7Cmk4U/evHW0uOk8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1763478415424790.1676247471779; Tue, 18 Nov 2025 07:06:55 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.1164920.1491775 (Exim 4.92) (envelope-from ) id 1vLNI2-0002jd-EO; Tue, 18 Nov 2025 15:06:42 +0000 Received: by outflank-mailman (output) from mailman id 1164920.1491775; Tue, 18 Nov 2025 15:06:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vLNI2-0002jW-Bg; Tue, 18 Nov 2025 15:06:42 +0000 Received: by outflank-mailman (input) for mailman id 1164920; Tue, 18 Nov 2025 15:06:41 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vLNI1-00026P-8g for xen-devel@lists.xenproject.org; Tue, 18 Nov 2025 15:06:41 +0000 Received: from mail-ed1-x52a.google.com (mail-ed1-x52a.google.com [2a00:1450:4864:20::52a]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2eefd324-c490-11f0-980a-7dc792cee155; Tue, 18 Nov 2025 16:06:39 +0100 (CET) Received: by mail-ed1-x52a.google.com with SMTP id 4fb4d7f45d1cf-64088c6b309so83849a12.0 for ; Tue, 18 Nov 2025 07:06:39 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6450e8d1a23sm884342a12.15.2025.11.18.07.06.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Nov 2025 07:06:38 -0800 (PST) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2eefd324-c490-11f0-980a-7dc792cee155 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1763478398; x=1764083198; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=jMn/cyVZqsuQaGJk1ULIzcL8rHs+FxB5cgoYXyQZKyQ=; b=LUK24N/KS6snkn36PdfgEimuDxbVLqX5+iAtsqOXsG9lQPTh0NKZABBlZj3b6HcbW9 rtbdt5sWr2i7c4awPQ0+E0/5ce0gsbKawqxCC5cC29pY9sWWf2g2taUGcRWlmy6lIjY6 88C5aj+u0y8NBLDthdnnaV7WkOAOkAzqtJUJabK2b/lnCnnCePR8XBZRB+pUAJrAnm/D K/29ViAvC8y2opi08T3SsXBeEJ9t+sE6bjoHDHVNHDrLxG20MXZ5uG6hXkuG5UBCiGhD 3iaml9HgWX6JR1xezqT3tvX1w/5BTeSoo4GTj8nIkyBTa1QndFvA7lLNgHXv0WuHdUuB R/yw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763478398; x=1764083198; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=jMn/cyVZqsuQaGJk1ULIzcL8rHs+FxB5cgoYXyQZKyQ=; b=tLh6EJDukfv0+qMO3GY7hBHFsCE0Nj5PpkF8sP8QRMvO1IlPVyQpqem0TpIqRX35gi yocdhpd1ck1tLArngG6pvbqJ2PjQw+CdqhOLzZganc7QjrEPRBPA9PQATN2nBJbuSy5Q WZb/kxvFDGwZZsHg0JAmmQ2jLrgVi9EJAKZ7FiIB5/BrdqkcpoQC1kpqM6EYt802ZXtM /Gq350ydq+K4X6ZRRjOdQVlQtTxpzedN6PCGl9/AH+u2TY6XPthUbvn3v4xE9sgijMpH fmSFQcsLQ9ZUVYytqHtzIQLxuIQmiCLM/FuA+FGhTceJp0JnqG/CvyCNdZ9W35OENx9k fzUg== X-Gm-Message-State: AOJu0YzJT2TB2a+fWs+i04G+pg85m1xH3J4FwB9e/TBXIrd5A1+yvVt1 pp0YEPte6ERW7LaXbNDl7VKwJfYm0vToeImOFuIpasaP0WdFzaaeP819FZCAYrdpgQwQLczxFiJ B7zk= X-Gm-Gg: ASbGncs5lJpA6BFbxHuikPS7DLNMVUD85NjwANq9Z5mWHYnU8TtZCzDkgPzaGi0acxR TedVwhu+T/NsXhgF5UmIxjpQ3tCGZ7p5p5RntpqbUxMmLsdNz2Qsrj4g8GWiE3vuULGoKOsUacH D2sgfd+r9JQ436moosbnC4KFg17h71TYiz8WdCLfC7HYAHQ8SIE+FfIjiDeqr+rhW11hH4k9jET 6KzCCIBk6TMyk4QAjXUJqyQY0sJox3MsKonsqHyfZ6IWUDpE9gOQ/w2hFG0TKm3ROhcNSVeT1A9 TECg802iqeRvFgwV15thmwdHDu5E8upz2iyW7kvsUhW39zajNG8EwqddIXPpR3cJJ0qcwW4i+pH yf1tssaPQkPaeIAFem3K5oDoFo9+fNPTUT2qGFZwbNZfRy/MOE2OUppSdFcRnyE8F0J2WYhGDl3 Yk0aQ4Ny4CWm+tcUwSPfcCGaasiOoVqAvh02UVC8Sq8XrqkEisekf/naPzsy5Pd53WrcIgyD+9e HUoBlTPvTIrgA== X-Google-Smtp-Source: AGHT+IH0eHnKFf6D2JbGKosKLvylnTF5ltnaGgh2liPP4o8m65DsinatQ4lDiiGASIXW6vchOw0soA== X-Received: by 2002:a05:6402:27c8:b0:640:80f4:3914 with SMTP id 4fb4d7f45d1cf-64350e89eabmr16635900a12.19.1763478398511; Tue, 18 Nov 2025 07:06:38 -0800 (PST) Message-ID: <6525306d-aebd-47a2-b17f-918d7989798a@suse.com> Date: Tue, 18 Nov 2025 16:06:37 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH 3/8] x86/include: de-assemblify cpuid.h From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= References: <53ef6c9a-1115-4bb4-bb7f-e2595ab9d0b6@suse.com> Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <53ef6c9a-1115-4bb4-bb7f-e2595ab9d0b6@suse.com> Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1763478417874153000 Content-Type: text/plain; charset="utf-8" There's nothing in that header which assembly files would need. Arrange for cpufeatureset.h to be included directly by cpufeature.h in that case, allowing respective guarding to be dropped Signed-off-by: Jan Beulich Acked-by: Andrew Cooper --- a/xen/arch/x86/include/asm/cpufeature.h +++ b/xen/arch/x86/include/asm/cpufeature.h @@ -10,7 +10,11 @@ #include #include =20 +#ifndef __ASSEMBLY__ #include +#else +#include +#endif =20 #define cpufeat_word(idx) ((idx) / 32) #define cpufeat_bit(idx) ((idx) % 32) --- a/xen/arch/x86/include/asm/cpuid.h +++ b/xen/arch/x86/include/asm/cpuid.h @@ -3,7 +3,6 @@ =20 #include =20 -#ifndef __ASSEMBLY__ #include #include #include @@ -50,7 +49,6 @@ struct cpuid_leaf; void guest_cpuid(const struct vcpu *v, uint32_t leaf, uint32_t subleaf, struct cpuid_leaf *res); =20 -#endif /* __ASSEMBLY__ */ #endif /* !__X86_CPUID_H__ */ =20 /* From nobody Wed Nov 19 01:57:07 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1763478466; cv=none; d=zohomail.com; s=zohoarc; b=n5drVzdvditl+3R11054KfEV2rq8+JwWQrl65Ap/gwPeG1c0b+iOLT7ZIFsL3W1DIVZuS7aM1kn5Opx1CgS2lTvrNbbQaLrxW6T1E2uor33j9ThWUc6rdynN5vMXSHAwDcLOHxj6jL1lumnOvSwWo5kZd/7aH45KMiRkUdC7ynU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1763478466; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=UcLxhIrNXaMN+dEZIS/JAOfVnBILwCijMp1B3XCEPJ8=; b=cY2v8VW5mp3BpsN7DYbu4WSF2ap0jIaYw2bJB3DdOaenvBAjvW7UaMMWxUnmhaAFWgjhtHr3d0D7+GmyPIShe3AZGjtUJqW0G5FnetvVTkwwQw+lGYA9ZMtKKiGdODNoXh2Xsrw4nHhx/69lQR5e0gjmhvmFikd1RccQ7oweWt0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1763478465923187.1439225945495; Tue, 18 Nov 2025 07:07:45 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.1164935.1491785 (Exim 4.92) (envelope-from ) id 1vLNIl-0003LG-Nb; Tue, 18 Nov 2025 15:07:27 +0000 Received: by outflank-mailman (output) from mailman id 1164935.1491785; Tue, 18 Nov 2025 15:07:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vLNIl-0003L9-KX; Tue, 18 Nov 2025 15:07:27 +0000 Received: by outflank-mailman (input) for mailman id 1164935; Tue, 18 Nov 2025 15:07:26 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vLNIk-00033y-04 for xen-devel@lists.xenproject.org; Tue, 18 Nov 2025 15:07:26 +0000 Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [2a00:1450:4864:20::631]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4a805d05-c490-11f0-9d18-b5c5bf9af7f9; Tue, 18 Nov 2025 16:07:25 +0100 (CET) Received: by mail-ej1-x631.google.com with SMTP id a640c23a62f3a-b73b24f1784so272297966b.0 for ; Tue, 18 Nov 2025 07:07:25 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b734fa81296sm1393799666b.6.2025.11.18.07.07.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Nov 2025 07:07:24 -0800 (PST) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4a805d05-c490-11f0-9d18-b5c5bf9af7f9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1763478445; x=1764083245; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=UcLxhIrNXaMN+dEZIS/JAOfVnBILwCijMp1B3XCEPJ8=; b=EoyIwBqaKYIu7aNm2p71Lczqz+xj/H2j6+ZwolZH8Q1MyUf1OnV79wb5hXjhFJRAW2 Lk6aD+QocT9o3KPhnq1ORlp39YouNnqUQhXrVJweYkGE1bvpaeoOV5qwq29kLSbOpV3X Z4xjMUiFyJWrEmDxLYxFAh7XD/S/brcEn5k/qqC+riSIU90DNMV9ASueWwNmIIuvctS4 oTTCbP3sBrRbalOfmhQJLOG0SkkrDdJGFxL3rakOfJcalfDNyIMscOUkki4/sx/Qhkl6 9agYf5f4C929YxOShyHG8HcwuigyFxp/KZSgO6DJ4l3OvrDFxYyXu+kW5LfT7AnqeA2s Ysgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763478445; x=1764083245; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=UcLxhIrNXaMN+dEZIS/JAOfVnBILwCijMp1B3XCEPJ8=; b=PCNxfoyvwQYHETA6XOYhr6RalWJnX1bWba0YPCHro7epv/CXkwMUrtoxnPsL7YmuOc l/KuIP6TdFf7J6REOf8yyLt7u+8UWH1C89sfet89/AhA9eEicK7OcT2kpYnjPNftW+OO DpKfuJFBaFHsKL9TN/FP1lZEJSAxqQ6r0ZbjJH2S+R+i/RiBN1zT9uBvRrgQbnLoHtTH 01w7we2t+gE4B6yum2920Un6EJhPoM7VNwyaj4cZe12y8ZfBWz1TYklIoAtaPsA9QMbS RobvgH+Q+qJ23xo+ZFeBCxrRTodtNbIsc8LlYIcM/7jSIA82vFQvWh+HeXo1nOvJbJeW 5y1A== X-Gm-Message-State: AOJu0Yw8r0s+n71NY805jhK8XR65k2M+MBMJYXr1UiA3w6roNwwbxqXi R3LV7b9UbrjPHhLCZKu94dp5xZ2J7yUkeRpt9V/awiywGxogPVd3siB9y6vCwL7JjJTTN3EXCQ9 ODaQ= X-Gm-Gg: ASbGncs/Sb5lfM0n7kFEmleMcG0qkqXpok4h7kjhREXpRJy366D4uxIOI/6k8dXr4dB KQDO3VJ5irArGzgpcnhT0t1k8JdMkXOy/C9MfHiUfK0Vu8joq14DVpGmEJHlWIiJYnoDfZCKTI2 8uvV4tepwZc1XghTPaOf9oBqRkid7mRFiZMnYaEocYGURGK5YBFAHS3j49/Du69RZfPfYw0bivv cW9afuDUERzyBRt7Oj4mF4i4rzDrwgNsC80PUi+gxQObOwwZs+G7MSdfsbg5GaYuGzQzIps3ujZ f+QBZrz5CHnhVYDJ1OpSIu6ifYPwmP21WzIwPwN+Afvk0/yeTDyxQA60Sx260S0ZZyW+snA27O5 OMyHciNTpXWepRrOkCaDPVOPt8O+7My51QBvmtZDnQPY5JS5xDn83LzPMbU9IYcRfl1i7H5YbzK fIu5PiHfq/vPWaYE7LX6Uq0rYayoMdyKagsiZBU026SKmxWYDaThmaCwCC4a48vSfBCqf/HmpR3 RIoAvxS/2lpag== X-Google-Smtp-Source: AGHT+IE2AMQszacX3K1IzrjUWAeT0RvSIr8T9X7hWthAm+aZ3Z96afG5mCWt0bR5QdrEXk8PAbchzA== X-Received: by 2002:a17:907:2d87:b0:b6d:3456:14b3 with SMTP id a640c23a62f3a-b75a0a546b7mr365066466b.20.1763478444409; Tue, 18 Nov 2025 07:07:24 -0800 (PST) Message-ID: <505029ff-cb2e-425c-bf5c-3ac364f32140@suse.com> Date: Tue, 18 Nov 2025 16:07:23 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH 4/8] x86: replace APERFMPERF synthetic feature bit From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= References: <53ef6c9a-1115-4bb4-bb7f-e2595ab9d0b6@suse.com> Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <53ef6c9a-1115-4bb4-bb7f-e2595ab9d0b6@suse.com> Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1763478466717158500 Content-Type: text/plain; charset="utf-8" Use the respective host CPU policy bit instead. Signed-off-by: Jan Beulich --- a/xen/arch/x86/cpu/common.c +++ b/xen/arch/x86/cpu/common.c @@ -523,10 +523,6 @@ static void generic_identify(struct cpui if ( cpu_has(c, X86_FEATURE_CLFLUSH) ) c->x86_clflush_size =3D ((ebx >> 8) & 0xff) * 8; =20 - if ( (c->cpuid_level >=3D CPUID_PM_LEAF) && - (cpuid_ecx(CPUID_PM_LEAF) & CPUID6_ECX_APERFMPERF_CAPABILITY) ) - __set_bit(X86_FEATURE_APERFMPERF, c->x86_capability); - /* AMD-defined flags: level 0x80000001 */ if (c->extended_cpuid_level >=3D 0x80000001) cpuid(0x80000001, &tmp, &tmp, --- a/xen/arch/x86/include/asm/cpufeature.h +++ b/xen/arch/x86/include/asm/cpufeature.h @@ -11,7 +11,9 @@ #include =20 #ifndef __ASSEMBLY__ +#include #include +#include #else #include #endif @@ -121,7 +123,6 @@ static inline bool boot_cpu_has(unsigned #define CPUID6_EAX_HDC BIT(13, U) #define CPUID6_EAX_HWP_PECI BIT(16, U) #define CPUID6_EAX_HW_FEEDBACK BIT(19, U) -#define CPUID6_ECX_APERFMPERF_CAPABILITY BIT(0, U) =20 /* CPUID level 0x00000001.edx */ #define cpu_has_fpu 1 @@ -175,6 +176,9 @@ static inline bool boot_cpu_has(unsigned #define cpu_has_fma4 boot_cpu_has(X86_FEATURE_FMA4) #define cpu_has_tbm boot_cpu_has(X86_FEATURE_TBM) =20 +/* CPUID level 0x00000006.ecx */ +#define cpu_has_aperfmperf host_cpu_policy.basic.pm.aperfmperf + /* CPUID level 0x0000000D:1.eax */ #define cpu_has_xsaveopt boot_cpu_has(X86_FEATURE_XSAVEOPT) #define cpu_has_xsavec boot_cpu_has(X86_FEATURE_XSAVEC) @@ -292,7 +296,6 @@ static inline bool boot_cpu_has(unsigned /* Synthesized. */ #define cpu_has_arch_perfmon boot_cpu_has(X86_FEATURE_ARCH_PERFMON) #define cpu_has_cpuid_faulting boot_cpu_has(X86_FEATURE_CPUID_FAULTING) -#define cpu_has_aperfmperf boot_cpu_has(X86_FEATURE_APERFMPERF) #define cpu_has_xen_lbr boot_cpu_has(X86_FEATURE_XEN_LBR) #define cpu_has_xen_shstk (IS_ENABLED(CONFIG_XEN_SHSTK) && \ boot_cpu_has(X86_FEATURE_XEN_SHSTK)) --- a/xen/arch/x86/include/asm/cpufeatures.h +++ b/xen/arch/x86/include/asm/cpufeatures.h @@ -19,7 +19,7 @@ XEN_CPUFEATURE(TSC_RELIABLE, X86_SY XEN_CPUFEATURE(XTOPOLOGY, X86_SYNTH( 5)) /* cpu topology enum exte= nsions */ XEN_CPUFEATURE(CPUID_FAULTING, X86_SYNTH( 6)) /* cpuid faulting */ XEN_CPUFEATURE(XEN_FRED, X86_SYNTH( 7)) /* Xen uses FRED */ -XEN_CPUFEATURE(APERFMPERF, X86_SYNTH( 8)) /* APERFMPERF */ +/* Bit 8 unused */ XEN_CPUFEATURE(MFENCE_RDTSC, X86_SYNTH( 9)) /* MFENCE synchronizes RD= TSC */ XEN_CPUFEATURE(XEN_SMEP, X86_SYNTH(10)) /* SMEP gets used by Xen = itself */ XEN_CPUFEATURE(XEN_SMAP, X86_SYNTH(11)) /* SMAP gets used by Xen = itself */ From nobody Wed Nov 19 01:57:07 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1763478711; cv=none; d=zohomail.com; s=zohoarc; b=ZM8mB/aWyH7xYSHS8DpZfNLL59bDL3sUF+a13zhQkA953Ox6ap6lKZfet2XCRchxinNaNCWEAWUmYHkYW6q/guKh2TPgN0ytUUOX0n+OR/SWHEcjaFUWnn7OXYdtUfkb0FDH6tJ/MKFDi/32XvUnn9OVA6R4FNXXfuW+tDY0rOw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1763478711; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=ogwqBuXZSaN+AgPZhx6o0JgPjsKbQmKgsLL7wy4U8mQ=; b=dLBVPWhL601Pb0Bu2QA6KOWCm/gvQK7nWX4K5Um3t2kWTeUJwtuOW6xwkX9iXCV/sw7JBSqW0szT3/dgLUtc0NJjDw7wCfIrIL4D18Jd6YNI5yWAWM89FSDjV7Agq+0cbXIaoGncnUnwjl5RwXahFpcXvWv8sHbV1/ynnuoxnPE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1763478711393274.11408218867007; Tue, 18 Nov 2025 07:11:51 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.1164971.1491824 (Exim 4.92) (envelope-from ) id 1vLNMm-0006Th-5f; Tue, 18 Nov 2025 15:11:36 +0000 Received: by outflank-mailman (output) from mailman id 1164971.1491824; Tue, 18 Nov 2025 15:11:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vLNMm-0006Ta-2n; Tue, 18 Nov 2025 15:11:36 +0000 Received: by outflank-mailman (input) for mailman id 1164971; Tue, 18 Nov 2025 15:11:35 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vLNJ6-00026P-Pz for xen-devel@lists.xenproject.org; Tue, 18 Nov 2025 15:07:48 +0000 Received: from mail-ej1-x635.google.com (mail-ej1-x635.google.com [2a00:1450:4864:20::635]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5736c4ec-c490-11f0-980a-7dc792cee155; Tue, 18 Nov 2025 16:07:46 +0100 (CET) Received: by mail-ej1-x635.google.com with SMTP id a640c23a62f3a-b727f452fffso1090538866b.1 for ; Tue, 18 Nov 2025 07:07:46 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b734fa81172sm1360206366b.15.2025.11.18.07.07.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Nov 2025 07:07:45 -0800 (PST) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5736c4ec-c490-11f0-980a-7dc792cee155 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1763478466; x=1764083266; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=ogwqBuXZSaN+AgPZhx6o0JgPjsKbQmKgsLL7wy4U8mQ=; b=ducR8lKb+vbtuzzaVdY3f7EAoZ8MhqQX/QHxq0WfvFyBuiAFSQ28qwWaCT6EFyVRTh tO2ouQUYds1VuDopCzOkADYN9DS6uhhEp9EBpQx0/L610tecBeGjm3fhCsZ/Hr27wVQJ Ne1SY28axBT2Jaktrsyg3YfvxiiywpXbgA3xtwnj5Ooq+CYl7Kd6k712Rpp6I13refAy mDr5i50BnPkMwILZGjSxsLvsg/CxSSPV7YFY4BHJ4zPygMZtop9EwCV7rJeAKtgt5svm xyKEDmWeZiYzZUpRk+E3OsQCx5aZWL5y6WfVFKyDQDcWVdR8ljHnkeO9Grn02C5AcHK5 2tUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763478466; x=1764083266; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ogwqBuXZSaN+AgPZhx6o0JgPjsKbQmKgsLL7wy4U8mQ=; b=S3J0OXaQMywDbZLiwcYV4W9SovPIzKIGfHAVO/SDDbqts9+Xk6n9705b5VuwQRt508 A89KBt+ItZaGRto+0wT53dZ+pgxt6Ya+F85eqv3cBLdFz32rORbXkGheT90AkDr8cEOr rFm/nNGnm0FhhftZhZHvVXWFfsg1biMqHy2UcfwNejlWEIErLaIKz+ErX7I4lSOqvLVG gzPjKg0rzkvP6e2PCjDaE4DjEP5YSQ+2ctfMK4p6Bl2V5XPYmTNBdGvgc8CaC7ZvVuHy Q0DACn49LlVNSYCuzCgJ09rINv9xjRtvLExKyijW5NKehZg8tVupGJxDyuK/+ubZCHIl XUCg== X-Gm-Message-State: AOJu0Yz4duhDhAiOh2lxa22m2Bh3ME0KIWys0gCWiN35TmCIH2i33ej9 xxuhsmSy8DuhjoJYaHxAogbEhlUqQinbagsBeqZtlHyOPVQcXU2QWFwGov5X0KaMvnmTogR9UYN XVT8= X-Gm-Gg: ASbGncuVfA+H/g5nNm0xAkoJNWz8zh80ZIYICyaeW+fxn/ZtAZ4C+nChMs0Wo5QM39X j0IQJ8yzWCaQKE0WGpfUjej45tMnCIRVoecEnuge5bWgtlvQq4eTayw1PD+9YQPcTCdFinEosRZ bA2TQsw4Np9iG2gQ3agnMQSAiGUm/eJkQn8hoCnHWE6pg6Jr1UnlT8iUeOOloFg6QMJ6euujeX9 Ma5a9qyngWAJ6EGkMJX7y3OoYRbKiBfLsmdZSBSIicqB56m3j8jRcdoHpWuk/xvy5a1ESNMxK4E 98qThXuSFOO4m8JqDXS4YEwMQxznUlv45jXP0JUKiBcSA4f0+hPq6aPt78fVBvVFHyK9rycTDYS FRHD1/RgkuyV+HK2LWEhQO5SpkxTue7rVsw0USXvh7aJHQptc4mNVDrIPVrIzXMTF3byfQ2l0cI 0VyXABDXCgl6QoGKJtHyutWo6YeOpKDjboyQfmRqhriuMCv2a4BJTxQ8kh0AgmHHBHtfJD4y6Xc VE= X-Google-Smtp-Source: AGHT+IFR9Pomx8rFbS6hsHAUaKwk67R3YEGcCjD+fMbAYcxcBh7aP2reu+6Hpe15tc6hWW/ITUC/6Q== X-Received: by 2002:a17:907:d16:b0:b72:e158:8229 with SMTP id a640c23a62f3a-b75a09f290bmr484598866b.15.1763478466123; Tue, 18 Nov 2025 07:07:46 -0800 (PST) Message-ID: Date: Tue, 18 Nov 2025 16:07:44 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH 5/8] x86: rename ARAT feature flag From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= References: <53ef6c9a-1115-4bb4-bb7f-e2595ab9d0b6@suse.com> Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <53ef6c9a-1115-4bb4-bb7f-e2595ab9d0b6@suse.com> Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1763478713773153000 Content-Type: text/plain; charset="utf-8" Add a XEN infix, to properly distinguish it from the CPUID feature flag (leaf 6 EAX bit 2). Signed-off-by: Jan Beulich --- Question is whether we still need opt_arat (and the command line option), or whether we could go directly from the CPUID bit (overriding it to on for older AMD [and Hygon?] CPUs). Or whether to have opt_arat affect the (host) CPU policy directly. --- a/xen/arch/x86/acpi/cpu_idle.c +++ b/xen/arch/x86/acpi/cpu_idle.c @@ -109,7 +109,7 @@ void (*__read_mostly lapic_timer_on)(voi =20 bool lapic_timer_init(void) { - if ( boot_cpu_has(X86_FEATURE_ARAT) ) + if ( boot_cpu_has(X86_FEATURE_XEN_ARAT) ) { lapic_timer_off =3D lapic_timer_nop; lapic_timer_on =3D lapic_timer_nop; @@ -1463,7 +1463,7 @@ static void amd_cpuidle_init(struct acpi =20 if ( !vendor_override ) { - if ( !boot_cpu_has(X86_FEATURE_ARAT) ) + if ( !boot_cpu_has(X86_FEATURE_XEN_ARAT) ) hpet_broadcast_init(); =20 if ( !lapic_timer_init() ) --- a/xen/arch/x86/cpu/amd.c +++ b/xen/arch/x86/cpu/amd.c @@ -1355,7 +1355,7 @@ static void cf_check init_amd(struct cpu * running in deep C states. */ if ( opt_arat && c->x86 > 0x11 ) - __set_bit(X86_FEATURE_ARAT, c->x86_capability); + __set_bit(X86_FEATURE_XEN_ARAT, c->x86_capability); =20 /* * Prior to Family 0x14, perf counters are not reset during warm reboot. --- a/xen/arch/x86/cpu/hygon.c +++ b/xen/arch/x86/cpu/hygon.c @@ -76,7 +76,7 @@ static void cf_check init_hygon(struct c =20 /* Hygon processors have APIC timer running in deep C states. */ if (opt_arat) - __set_bit(X86_FEATURE_ARAT, c->x86_capability); + __set_bit(X86_FEATURE_XEN_ARAT, c->x86_capability); =20 if (cpu_has(c, X86_FEATURE_EFRO)) { rdmsrl(MSR_K8_HWCR, value); --- a/xen/arch/x86/cpu/intel.c +++ b/xen/arch/x86/cpu/intel.c @@ -668,7 +668,7 @@ static void cf_check init_intel(struct c if ( opt_arat && ( c->cpuid_level >=3D 0x00000006 ) && ( cpuid_eax(0x00000006) & (1u<<2) ) ) - __set_bit(X86_FEATURE_ARAT, c->x86_capability); + __set_bit(X86_FEATURE_XEN_ARAT, c->x86_capability); =20 if ((opt_cpu_info && !(c->apicid & (c->x86_num_siblings - 1))) || c =3D=3D &boot_cpu_data ) --- a/xen/arch/x86/cpu/mwait-idle.c +++ b/xen/arch/x86/cpu/mwait-idle.c @@ -1633,7 +1633,7 @@ static int __init mwait_idle_probe(void) icpu =3D id->driver_data; cpuidle_state_table =3D icpu->state_table; =20 - if (boot_cpu_has(X86_FEATURE_ARAT)) + if (boot_cpu_has(X86_FEATURE_XEN_ARAT)) lapic_timer_reliable_states =3D LAPIC_TIMER_ALWAYS_RELIABLE; =20 pr_debug(PREFIX "v" MWAIT_IDLE_VERSION " model %#x\n", @@ -1792,7 +1792,7 @@ int __init mwait_idle_init(struct notifi return -ENODEV; =20 err =3D mwait_idle_probe(); - if (!err && !boot_cpu_has(X86_FEATURE_ARAT)) { + if (!err && !boot_cpu_has(X86_FEATURE_XEN_ARAT)) { hpet_broadcast_init(); if (xen_cpuidle < 0 && !hpet_broadcast_is_available()) err =3D -ENODEV; --- a/xen/arch/x86/include/asm/cpufeatures.h +++ b/xen/arch/x86/include/asm/cpufeatures.h @@ -13,7 +13,7 @@ /* Synthetic features */ XEN_CPUFEATURE(CONSTANT_TSC, X86_SYNTH( 0)) /* TSC ticks at a constan= t rate */ XEN_CPUFEATURE(NONSTOP_TSC, X86_SYNTH( 1)) /* TSC does not stop in C= states */ -XEN_CPUFEATURE(ARAT, X86_SYNTH( 2)) /* Always running APIC ti= mer */ +XEN_CPUFEATURE(XEN_ARAT, X86_SYNTH( 2)) /* Xen may utilize always= running APIC timer */ XEN_CPUFEATURE(ARCH_PERFMON, X86_SYNTH( 3)) /* Intel Architectural Pe= rfMon */ XEN_CPUFEATURE(TSC_RELIABLE, X86_SYNTH( 4)) /* TSC is known to be rel= iable */ XEN_CPUFEATURE(XTOPOLOGY, X86_SYNTH( 5)) /* cpu topology enum exte= nsions */ --- a/xen/arch/x86/time.c +++ b/xen/arch/x86/time.c @@ -2642,7 +2642,7 @@ static int _disable_pit_irq(bool init) * XXX dom0 may rely on RTC interrupt delivery, so only enable * hpet_broadcast if FSB mode available or if force_hpet_broadcast. */ - if ( cpuidle_using_deep_cstate() && !boot_cpu_has(X86_FEATURE_ARAT) ) + if ( cpuidle_using_deep_cstate() && !boot_cpu_has(X86_FEATURE_XEN_ARAT= ) ) { init ? hpet_broadcast_init() : hpet_broadcast_resume(); if ( !hpet_broadcast_is_available() ) From nobody Wed Nov 19 01:57:07 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1763478711; cv=none; d=zohomail.com; s=zohoarc; b=ZpBQG9jgh6lBYbMbgJgJe0/g5KotrTPU1RW2rha9QXsrGOWFTn9uPu+oN6vfsP4lnsmhpYzbFvAGKWGUy5UnyvnOnwMu8tH/9IIF4QUGOvBQWnTevuWwaUQkbxXICPpGp0WCVqtOdcsF9aH7mZZ8EuJjFQfdoBKgZIFicgmkllc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1763478711; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=W86zTLEXpDpklYi+GcoFltRiRTg9CcQOeSAaFkrNf28=; b=YjbzKYVx8vwagmuh03kztOH8Q9fKh4SYpUSaDmNVz/4ZePeZzDuaSz/UXFc5y5HGCGRJHYZ2FMnVVOA8YeLYVmJMPL2a+pyWKndHAqFqUSfROWyNEQi8dPhVpnhHyZwOMLU09sBrrjdTS4/f4seR6RHrR2LQnqjhHafKhdSeJ5I= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1763478711394870.4425492417663; Tue, 18 Nov 2025 07:11:51 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.1164972.1491835 (Exim 4.92) (envelope-from ) id 1vLNMo-0006jb-Dv; Tue, 18 Nov 2025 15:11:38 +0000 Received: by outflank-mailman (output) from mailman id 1164972.1491835; Tue, 18 Nov 2025 15:11:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vLNMo-0006jS-9W; Tue, 18 Nov 2025 15:11:38 +0000 Received: by outflank-mailman (input) for mailman id 1164972; Tue, 18 Nov 2025 15:11:36 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vLNJV-00026P-I6 for xen-devel@lists.xenproject.org; Tue, 18 Nov 2025 15:08:13 +0000 Received: from mail-ed1-x533.google.com (mail-ed1-x533.google.com [2a00:1450:4864:20::533]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 662e9a63-c490-11f0-980a-7dc792cee155; Tue, 18 Nov 2025 16:08:11 +0100 (CET) Received: by mail-ed1-x533.google.com with SMTP id 4fb4d7f45d1cf-6417313bddaso9029704a12.3 for ; Tue, 18 Nov 2025 07:08:11 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b734fa80afbsm1350070166b.11.2025.11.18.07.08.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Nov 2025 07:08:10 -0800 (PST) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 662e9a63-c490-11f0-980a-7dc792cee155 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1763478491; x=1764083291; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=W86zTLEXpDpklYi+GcoFltRiRTg9CcQOeSAaFkrNf28=; b=buihZib3bkytVULX1qWJ16BSNmfek/ewWT8+waWnCQEbdE90P2cRGX1gATkO32KtdG eARg4UZV2Q+/F6rOXuSsqVApXVvcpl3VrbquG0XWuQM25DboVbJyuLghqcdyqf9eHgS2 tAeObkmiq0HUzmIcCDiFwtovIzV/6H7SCzxipGmQBOKxubzvEuayGZzG0B+bfATuRX32 tJJqeI9f41oGkPzz1a3aaDz16xBFrVFAPS2GoOPQ5fpdwSlPFjVnbPGJT5ZkpREVDH74 DinjHIBrdrW6kNecmCWar7KD4yFjbGKgt7j5uwNu1yOhyWt5/FllTQsQxtmnoCoKONpl +nRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763478491; x=1764083291; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=W86zTLEXpDpklYi+GcoFltRiRTg9CcQOeSAaFkrNf28=; b=QLpNO5OxO4qliODQUrq3E7I1raKjIWT9aH4ZViR8NbtBMXq4VvytcUz0hbhe7bHNa9 OLwu5okYpthpq3I1f2j3I2KCGRzNbUSUEEJbp8A3Qh+C5Kvga7i1q0Wh5oyO63KPnVem aBaqEDNMwCTBWLZ3cjHXpW9z8wmaHyznx3qeAJp6dSjoNOX6TjxUdzsYjuxitNlGYFXb 5BSkwFEl/XGTKG+hZ6nfocrYm0G5pXTkaYpEkhgnOEBaspqqg+W0CV+AEXt2sE8MDkbt +pSA7tozJOpChfeV9RhdykH4lZ39TQxiQM9FNaHw/DK60UyzNogW9jF96PWw6auMOUVo ZM7w== X-Gm-Message-State: AOJu0YyJNb4AR8fOgdtLnZWpAQGAcFD7mZN7wfwx4zciZyAnfWXElBX+ JLIpHWFb0rcQQ/Sf3ommaaBuO6S9WbO8yfknGFeFm5w/V8Oc2EvHrBvi3bLAX9UT+U0Py1nxndc OsuA= X-Gm-Gg: ASbGncufTdA2eSIhZaTDPB/8bGkQFSgT8y9iW2zOtf2QfDC7sm2qBVFkknjIVuG5zT4 YmaaAonLH7a6LkwCPXJt5qki9hNjocKJwrZlH3sKUSgAVBsozK1/ntuSPwdY62MX3kOq7VQFix3 UzrTB3ihqltzE7CCsuRO6HbTQR3BhL/atFjeIhaceuN6jYts0tz9Z4oZpgaKUoUiJXzh07q/PT7 9sZIe8z3pZS46f6EF+vd/2YoO+QAERAm65kfkav5tXVOl8rqP0fNCQzlyrOBTVnbgkAnfqfG6oP WDrOhyjxm7NOKB1026DjBPF9NDWXBzm3KqDMA85mClAtyNVtGDGkp4bJScpnDXzPPT7KDKKnosr WTOvWdXv0CfMJf1MkELWfBQrXDgeQLi8eeTRaiKX4sTiGFOzUAdNgrndiqebNVB2uYQpWvznd21 S5tsxrq1Nh+h/IlCGPnlaOdrLdiUqOKuTt+tBgnQ3s8AR5T8XVYIl9OlAxV3FC2XGikeivicvBF iQ= X-Google-Smtp-Source: AGHT+IEczz1Xgz1tWQgteHlheUhiJDKhuAQVZpHPlpECj+Ngb7vc1kuYcwHlMZr0Z8Drt989UCT1rQ== X-Received: by 2002:a17:906:4786:b0:b73:5131:c45b with SMTP id a640c23a62f3a-b73678293b3mr1437014566b.22.1763478491035; Tue, 18 Nov 2025 07:08:11 -0800 (PST) Message-ID: <65cb802c-922d-4bee-9dee-566367bec6ed@suse.com> Date: Tue, 18 Nov 2025 16:08:09 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH 6/8] x86/Intel: use host CPU policy for ARAT checking From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= References: <53ef6c9a-1115-4bb4-bb7f-e2595ab9d0b6@suse.com> Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <53ef6c9a-1115-4bb4-bb7f-e2595ab9d0b6@suse.com> Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1763478713739153000 Content-Type: text/plain; charset="utf-8" There's no need to invoke CPUID yet another time. However, as the host CPU policy is set up only shortly after init_intel() ran on the BSP, defer the logic to a pre-SMP initcall. This can't be (a new) one in cpu/intel.c though, as that's linked after acpi/cpu_idle.c (which is where we already need the feature set). Since opt_arat is local to the cpu/ subtree, introduce a new Intel-specific helper to hold the code needed. Further, as we assume symmetry anyway, use setup_force_cpu_cap() and hence limit the checking to the boot CPU. Signed-off-by: Jan Beulich --- The need to move where cpu_has_arat is checked would go away if we did away with opt_arat (as mentioned in the previous patch), and hence could use cpu_has_arat directly where right now XEN_ARAT is checked. --- a/xen/arch/x86/acpi/cpu_idle.c +++ b/xen/arch/x86/acpi/cpu_idle.c @@ -1666,6 +1666,9 @@ static int __init cf_check cpuidle_presm { void *cpu =3D (void *)(long)smp_processor_id(); =20 + if ( boot_cpu_data.vendor =3D=3D X86_VENDOR_INTEL ) + intel_init_arat(); + if ( !xen_cpuidle ) return 0; =20 --- a/xen/arch/x86/cpu/intel.c +++ b/xen/arch/x86/cpu/intel.c @@ -665,10 +665,6 @@ static void cf_check init_intel(struct c __set_bit(X86_FEATURE_NONSTOP_TSC, c->x86_capability); __set_bit(X86_FEATURE_TSC_RELIABLE, c->x86_capability); } - if ( opt_arat && - ( c->cpuid_level >=3D 0x00000006 ) && - ( cpuid_eax(0x00000006) & (1u<<2) ) ) - __set_bit(X86_FEATURE_XEN_ARAT, c->x86_capability); =20 if ((opt_cpu_info && !(c->apicid & (c->x86_num_siblings - 1))) || c =3D=3D &boot_cpu_data ) @@ -690,3 +686,9 @@ const struct cpu_dev __initconst_cf_clob .c_early_init =3D early_init_intel, .c_init =3D init_intel, }; + +void __init intel_init_arat(void) +{ + if ( opt_arat && cpu_has_arat ) + setup_force_cpu_cap(X86_FEATURE_XEN_ARAT); +} --- a/xen/arch/x86/include/asm/cpufeature.h +++ b/xen/arch/x86/include/asm/cpufeature.h @@ -176,6 +176,9 @@ static inline bool boot_cpu_has(unsigned #define cpu_has_fma4 boot_cpu_has(X86_FEATURE_FMA4) #define cpu_has_tbm boot_cpu_has(X86_FEATURE_TBM) =20 +/* CPUID level 0x00000006.eax */ +#define cpu_has_arat host_cpu_policy.basic.pm.arat + /* CPUID level 0x00000006.ecx */ #define cpu_has_aperfmperf host_cpu_policy.basic.pm.aperfmperf =20 --- a/xen/arch/x86/include/asm/processor.h +++ b/xen/arch/x86/include/asm/processor.h @@ -102,6 +102,7 @@ extern void setup_force_cpu_cap(unsigned extern bool is_forced_cpu_cap(unsigned int cap); extern void print_cpu_info(unsigned int cpu); extern void init_intel_cacheinfo(struct cpuinfo_x86 *c); +extern void intel_init_arat(void); =20 #define cpu_to_core(_cpu) (cpu_data[_cpu].cpu_core_id) #define cpu_to_socket(_cpu) (cpu_data[_cpu].phys_proc_id) From nobody Wed Nov 19 01:57:07 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1763478703; cv=none; d=zohomail.com; s=zohoarc; b=MYyhR9LOjGPXPiWkXFl7q1yeup3sZoKrt8IhDq3RQmDrb32fwcCwXLU7XENiDxAAuhOFCm+Vz/Xp55Yaxxq7tfs1kHHrvm1B3tj+eQsnHgFak7ktSh3YsRN0Gun+ui/OdBcKXtJcSWV5EPmeqx6L9QecC6pN/eCdZhHt96tGlXM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1763478703; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=EaxTfRibb0WV/8D0hz8O8sCazTK04DB2X0gZg+rQ2po=; b=K/3pKMG3JhQpMMVa5w6TiVdyaBaRdYFfOcRxzUejLvuKQ/3hnbGrqFJadcB7Bn8ehSb5J+QlZ3ok00klMNqM3LUOQ7l8ljgmiaXZfr0kKaesVv2DqgRnfP6jxy6lTqgevW8ZPwaVkkZiMNGgjkPdCWIToMMzhkB+E2F5RXyop8c= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1763478703865919.1712921370992; Tue, 18 Nov 2025 07:11:43 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.1164970.1491816 (Exim 4.92) (envelope-from ) id 1vLNMg-000697-Rz; Tue, 18 Nov 2025 15:11:30 +0000 Received: by outflank-mailman (output) from mailman id 1164970.1491816; Tue, 18 Nov 2025 15:11:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vLNMg-00068z-NE; Tue, 18 Nov 2025 15:11:30 +0000 Received: by outflank-mailman (input) for mailman id 1164970; Tue, 18 Nov 2025 15:11:29 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vLNJo-00026P-Bz for xen-devel@lists.xenproject.org; Tue, 18 Nov 2025 15:08:32 +0000 Received: from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com [2a00:1450:4864:20::62b]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 716e96de-c490-11f0-980a-7dc792cee155; Tue, 18 Nov 2025 16:08:30 +0100 (CET) Received: by mail-ej1-x62b.google.com with SMTP id a640c23a62f3a-b7277324054so780203266b.0 for ; Tue, 18 Nov 2025 07:08:30 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6433a3f8e6dsm12962919a12.10.2025.11.18.07.08.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Nov 2025 07:08:29 -0800 (PST) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 716e96de-c490-11f0-980a-7dc792cee155 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1763478510; x=1764083310; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=EaxTfRibb0WV/8D0hz8O8sCazTK04DB2X0gZg+rQ2po=; b=LuibiqdlColTs3PtBpB7QESVQzwFR7g4nvr08wAnTNIs/n03ujuuqbdy1zJo1j64Vw iQfpnwdKF+eX2BgSNqYkL5lE97hIUYAjVkbqWboy4hBUK2sLZ6nxsGtllo42aFnxp2ru xxuAHHfi5wa6g9EHApt2l2goFWEu1XRMoC3LyX5A/sbe3XtR7KqW9ABv9T8JLga3rMV6 K+txCbcXTFUY8GaIbG+cPNxL1YWw3KeADSbdAmqTh1w9StgI+Hxv0LnW/5zO8CeuAjHv 4UxQG/Ex0Yk39DT8uCcKbwzxHgHARBjbJS1xKYyTXIJFajQ6DifKXJ8hq16+hKfDObMq Zspw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763478510; x=1764083310; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=EaxTfRibb0WV/8D0hz8O8sCazTK04DB2X0gZg+rQ2po=; b=wEjp0ki5xYCofsfOPSloUxAu88bxRPUOK6njwyy52nGEQBt/cu1BEb1VqTeyaOHkqe geb9XWIoq4NzE6VuIAYuMpN75kqx5uMfLrIdr6/H7QQ4qF5M0fmOyeILMqOdXOyCLUf4 qP9KsH9hhRy5+7ZAA7kfjJqtO9gxkPSINuQXQXuHZAeX8N4ex8TlEGNoFHIFAptQxeCZ iljitpV4sbjJZo2SWsxY88QhO7RLHTd/8TJZP9Tpb/HvypX0cCtTvWN4mqfa7OaIE9q/ wUUPx8YhHiqAO1y8483SEYMCdZuWpIkVgebxI1n42WsMeUT4gblgG/abtArqdDItBBQk Wvrw== X-Gm-Message-State: AOJu0Yy5UOkZKfvl6DHJs6uYTcLLorI5JZxbW2f0Qy8aU8ERnLE0Oow6 TVxWyFtmoS/IveDJO3YaDILzz8lDdy1bL2aJpisaxA4vCDmK5ISLaW4M3L51S8fj6UZmD3fZ3MF 6sPw= X-Gm-Gg: ASbGncvfVpoqTcln7TDCkyPDFUhaBTPPoFHpnz8pfLS60sa+JqlX0TKUpb77tgBt2e8 zcFK1PN4zTHcHfFIyz9oPt+uyBTeERgGntzbUHg8EENqnzEVaLN2h7cSGibrdGe6JVwLgaZFqUr yQBEfxlnHGjFEB//amR8ySz1kZjiM1bjM/Hj3y3YVAb+CTKFdDbqKAOM7DF18/KT55IATWQlUY9 DA4vGa8JeIulc+TJFBsy43xNxpsJ52B9twd7I5CahyIMsc3I2QZZ9QvPzeLNwGt0Cnq5QkUdAFk QgV06MTlMdfZemQ/LRHRgXqu58RbHsC3bzlMtsIssSHplnDU2LRU9Qu780SFEy0DznSbltdMBgi a8xjxm2A1UkqXWWVwU+B/7Z3/dQdMC09bBuVosh+X1EndIH9hbeZJ6Qhp/GA14Ff8f0ntLt6L+r 6gslNdbYZ4it4OxF8WW1zSO0jNdKc0uDq+0mxGFaiaXnB5myufYa7J06UEWDcCWRQRiUUKkQS9s eqjEUv4ygON8DLJBzNuauTC X-Google-Smtp-Source: AGHT+IF9K+r8GqRKCQE8yRN/NEsAGLmYIOctpAT8+1Dotrt3AMrqEBoosrWzfJtNzDqIBLUsN78mPg== X-Received: by 2002:a17:906:7304:b0:b72:a899:168d with SMTP id a640c23a62f3a-b73677edba0mr1701170166b.13.1763478510059; Tue, 18 Nov 2025 07:08:30 -0800 (PST) Message-ID: Date: Tue, 18 Nov 2025 16:08:28 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH 7/8] x86/cpufreq: use host CPU policy for Turbo checking From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= References: <53ef6c9a-1115-4bb4-bb7f-e2595ab9d0b6@suse.com> Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <53ef6c9a-1115-4bb4-bb7f-e2595ab9d0b6@suse.com> Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1763478704180158501 Content-Type: text/plain; charset="utf-8" There's no need to invoke CPUID yet another time - we assume symmetry anyway. With symmetry assumed, logging per-CPU also isn't very useful. Signed-off-by: Jan Beulich --- a/xen/arch/x86/acpi/cpufreq/acpi.c +++ b/xen/arch/x86/acpi/cpufreq/acpi.c @@ -220,14 +220,11 @@ static unsigned int cf_check get_cur_fre =20 void intel_feature_detect(struct cpufreq_policy *policy) { - unsigned int eax; - - eax =3D cpuid_eax(6); - if (eax & 0x2) { + if ( cpu_has_turbo ) + { policy->turbo =3D CPUFREQ_TURBO_ENABLED; - if (cpufreq_verbose) - printk(XENLOG_INFO "CPU%u: Turbo Mode detected and enabled\n", - smp_processor_id()); + if ( cpufreq_verbose ) + printk_once(XENLOG_INFO "Turbo Mode detected and enabled\n"); } } =20 --- a/xen/arch/x86/include/asm/cpufeature.h +++ b/xen/arch/x86/include/asm/cpufeature.h @@ -177,6 +177,7 @@ static inline bool boot_cpu_has(unsigned #define cpu_has_tbm boot_cpu_has(X86_FEATURE_TBM) =20 /* CPUID level 0x00000006.eax */ +#define cpu_has_turbo host_cpu_policy.basic.pm.turbo #define cpu_has_arat host_cpu_policy.basic.pm.arat =20 /* CPUID level 0x00000006.ecx */ From nobody Wed Nov 19 01:57:07 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1763478563; cv=none; d=zohomail.com; s=zohoarc; b=L9I8MbWXS4cubgJVLmdk7udrL1nIu5/A0sBauXczOz55Mp/1aOpN6I58gmNffyqGfLWrEV1qq011FmTTBc80M+BtmNs2B1nvj/oaJ3CHNewRZm3fXyNq1ETcBqPb8INZlD5OuIB5NdUeSePCPRsmv0SH+ZmqnqkIYN9qbImHOok= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1763478563; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=GTDHw2weO1AUBfmHmJK8dwo4mfz5EckyJJgzqO2xOwA=; b=DGM+28xtRtha/7IsngfAizdvrW9ztklKzGco0hdo/nMq6+dZt1zOQ/2G7yv2XliGEfHCStsyYi6SlkU5XL6nWYQtl4CTDWwIan7G6koIfqnhLe62CG80Juk8+1Bi1QM0+6UqhJWjjwTMBkIRQkYK8cN9wrkr5TiGvjrqwY8prBQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1763478563365198.66719067922236; Tue, 18 Nov 2025 07:09:23 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.1164945.1491795 (Exim 4.92) (envelope-from ) id 1vLNKO-00040G-7j; Tue, 18 Nov 2025 15:09:08 +0000 Received: by outflank-mailman (output) from mailman id 1164945.1491795; Tue, 18 Nov 2025 15:09:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vLNKO-000409-4H; Tue, 18 Nov 2025 15:09:08 +0000 Received: by outflank-mailman (input) for mailman id 1164945; Tue, 18 Nov 2025 15:09:07 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vLNKN-000403-7V for xen-devel@lists.xenproject.org; Tue, 18 Nov 2025 15:09:07 +0000 Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [2a00:1450:4864:20::636]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 85ecb686-c490-11f0-980a-7dc792cee155; Tue, 18 Nov 2025 16:09:05 +0100 (CET) Received: by mail-ej1-x636.google.com with SMTP id a640c23a62f3a-b735487129fso887276166b.0 for ; Tue, 18 Nov 2025 07:09:05 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b734fd809fasm1377008966b.45.2025.11.18.07.09.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Nov 2025 07:09:04 -0800 (PST) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 85ecb686-c490-11f0-980a-7dc792cee155 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1763478544; x=1764083344; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=GTDHw2weO1AUBfmHmJK8dwo4mfz5EckyJJgzqO2xOwA=; b=NBIP8Qkp3P+7Apoye79IAKEtBeHU9UNkIJivOGO3YU2QZNCOTFuEFsc9SrOekLtujG GcAVzjauRXeULfkGJA/4dEibNVpg2Ezo4Z83M95IskGmYGGnOVbETaCaV4VkMU1A05Kj 4khHDhqi2vV7G58f8LghBiUcUJb0lsbuxdCBKj0CHcY3ZctZDDIS/JcPQQK6JoX9hcKT R4/bksgeJ/trkLKYLKP7edt0LGErksDpNb61ejtMM/8DckaY9DN7E1elAxykAB5Kla3a 3uiyScDLq8l1W4/6qcbohqP68dTkwYovGjGxnvjm0zLyALR9lHVTH0D6ddamM+hZdGyC hVQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763478544; x=1764083344; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=GTDHw2weO1AUBfmHmJK8dwo4mfz5EckyJJgzqO2xOwA=; b=PpxkAIy+/xsPrfWJMWq7LkZ2HkoAXiRXekf1xxwAOnPyQQn9xk0ZlV2q4l95Xa9tqw qlyPjIV7pIN0BnAJ1I3b9Hdjd5kFO22XjNWury8HSmEcEMoL6dZJKFufcj49Kj4GHfCJ 7CI/tMdPl/lJYiIzBvOiWOr12UwDttgvfwygLu2PDl+sH5XOTPGwlbrEjrQ5yfoboQBM oihkSu4IEVCH63Zo1MPfp1WsQgSH021mRXuID/pf8UKp2NJnINM073zbb9uX8/rB2Mom JW0PX4vOh4ajblThFZblsd3N8fjlJXX5S2H3/vfaX2l6+7vWuB/gJW0rhnAC7Oz8iTC6 dV2A== X-Gm-Message-State: AOJu0Yxugq930fAbm/8Pzyb7e8n0vnDKesJ5nRwgVBXnnvoW4lVsHZOs lJfZUpIL8nJRC5PXqeQaoaxe2PYWgy66Hf9gLpk8/l2YyRqUB4gM8+pBKk4IVH+NqE1XQIZ6AAn rW1g= X-Gm-Gg: ASbGncs3U1QXuToBKaOfR2vVQs6YLjaqMWxdOG1XqF+40fMJgT7y5U2ZI1UgwclyMC7 106D3vnMJbj1dBAxvdiB7fP+iYlY85E3z0dDSlzHSfrVbRKuoL6P1QeEOKBk75nRFteaEMMQSkN 2JONW/IqxR2Kaj/92R/FYpz+ZejE3Nz8Awq33vei8865H20lbi7ZtEaqeDtj0CUlBVHmge9Dm+X WvpIOqT6qT4x+1WX4R7yMCXOxBi/evnSorUf8rcX0RL6ZzIJulbq3WfTlfd8OdAbe6Wls+cPI9/ ZNcgTIHdYOTecuGCWk1R+r82/O7bX7B7ppXsa4ZIV8ewNZ2AqWcEp19GvKnTp28L2Vl3tB44zVf EkUOb+pVB2y/Yp3jkNgLxsqRRfsR5NJNTvul4F3hMtSEef6UEsUYQ+fxwBH6WyYyhElZF8t6e3Z YXum3VgxxcByqEfpkwk419W+YcNLzfhjoiLEooA7i8BHLuCoB5uy3/kKjGcbtI7AGCBd4GODytY QFL5IsIXERBcw== X-Google-Smtp-Source: AGHT+IG3BCZghm7TEjUUuD1BxyRHTbjbFWeuzyTzfuwgLhtPozzm+QKLrPoqRE7cBld2KTh8wnJTKw== X-Received: by 2002:a17:907:7eaa:b0:b76:2d96:6c28 with SMTP id a640c23a62f3a-b762d966d88mr158348966b.24.1763478544425; Tue, 18 Nov 2025 07:09:04 -0800 (PST) Message-ID: Date: Tue, 18 Nov 2025 16:09:03 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH 8/8] x86/cpufreq: use host CPU policy in HWP driver From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Jason Andryuk References: <53ef6c9a-1115-4bb4-bb7f-e2595ab9d0b6@suse.com> Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <53ef6c9a-1115-4bb4-bb7f-e2595ab9d0b6@suse.com> Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1763478565524158500 Content-Type: text/plain; charset="utf-8" There's no need to invoke CPUID yet another time. This way two of the static booleans can also go away. Signed-off-by: Jan Beulich Reviewed-by: Jason Andryuk --- a/xen/arch/x86/acpi/cpufreq/hwp.c +++ b/xen/arch/x86/acpi/cpufreq/hwp.c @@ -18,9 +18,6 @@ =20 static bool __ro_after_init hwp_in_use; =20 -static bool __ro_after_init feature_hwp_notification; -static bool __ro_after_init feature_hwp_activity_window; - static bool __read_mostly feature_hdc; =20 static bool __ro_after_init opt_cpufreq_hdc =3D true; @@ -165,8 +162,6 @@ bool hwp_active(void) =20 static bool __init hwp_available(void) { - unsigned int eax; - if ( boot_cpu_data.cpuid_level < CPUID_PM_LEAF ) { hwp_verbose("cpuid_level (%#x) lacks HWP support\n", @@ -183,29 +178,25 @@ static bool __init hwp_available(void) return false; } =20 - eax =3D cpuid_eax(CPUID_PM_LEAF); - hwp_verbose("%d notify: %d act-window: %d energy-perf: %d pkg-level: %= d peci: %d\n", - !!(eax & CPUID6_EAX_HWP), - !!(eax & CPUID6_EAX_HWP_NOTIFICATION), - !!(eax & CPUID6_EAX_HWP_ACTIVITY_WINDOW), - !!(eax & CPUID6_EAX_HWP_ENERGY_PERFORMANCE_PREFERENCE), - !!(eax & CPUID6_EAX_HWP_PACKAGE_LEVEL_REQUEST), - !!(eax & CPUID6_EAX_HWP_PECI)); + host_cpu_policy.basic.pm.hwp, + host_cpu_policy.basic.pm.hwp_notification, + host_cpu_policy.basic.pm.hwp_activity_window, + host_cpu_policy.basic.pm.hwp_epp, + host_cpu_policy.basic.pm.hwp_plr, + host_cpu_policy.basic.pm.hwp_peci); =20 - if ( !(eax & CPUID6_EAX_HWP) ) + if ( !host_cpu_policy.basic.pm.hwp ) return false; =20 - if ( !(eax & CPUID6_EAX_HWP_ENERGY_PERFORMANCE_PREFERENCE) ) + if ( !host_cpu_policy.basic.pm.hwp_epp ) { hwp_verbose("disabled: No energy/performance preference available"= ); =20 return false; } =20 - feature_hwp_notification =3D eax & CPUID6_EAX_HWP_NOTIFICATION; - feature_hwp_activity_window =3D eax & CPUID6_EAX_HWP_ACTIVITY_WINDOW; - feature_hdc =3D eax & CPUID6_EAX_HDC; + feature_hdc =3D host_cpu_policy.basic.pm.hdc; =20 hwp_verbose("Hardware Duty Cycling (HDC) %ssupported%s\n", feature_hdc ? "" : "not ", @@ -213,7 +204,7 @@ static bool __init hwp_available(void) : ""); =20 hwp_verbose("HW_FEEDBACK %ssupported\n", - (eax & CPUID6_EAX_HW_FEEDBACK) ? "" : "not "); + host_cpu_policy.basic.pm.hw_feedback ? "" : "not "); =20 hwp_in_use =3D true; =20 @@ -226,7 +217,8 @@ static int cf_check hwp_cpufreq_verify(s { struct hwp_drv_data *data =3D per_cpu(hwp_drv_data, policy->cpu); =20 - if ( !feature_hwp_activity_window && data->activity_window ) + if ( !host_cpu_policy.basic.pm.hwp_activity_window && + data->activity_window ) { hwp_verbose("HWP activity window not supported\n"); =20 @@ -268,7 +260,7 @@ static int cf_check hwp_cpufreq_target(s hwp_req.max_perf =3D data->maximum; hwp_req.desired =3D data->desired; hwp_req.energy_perf =3D data->energy_perf; - if ( feature_hwp_activity_window ) + if ( host_cpu_policy.basic.pm.hwp_activity_window ) hwp_req.activity_window =3D data->activity_window; =20 if ( hwp_req.raw =3D=3D data->curr_req.raw ) @@ -365,7 +357,7 @@ static void cf_check hwp_init_msrs(void } =20 /* Ensure we don't generate interrupts */ - if ( feature_hwp_notification ) + if ( host_cpu_policy.basic.pm.hwp_notification ) wrmsr_safe(MSR_HWP_INTERRUPT, 0); =20 if ( !(val & PM_ENABLE_HWP_ENABLE) ) @@ -537,7 +529,8 @@ int get_hwp_para(unsigned int cpu, return -ENODATA; =20 cppc_para->features =3D - (feature_hwp_activity_window ? XEN_SYSCTL_CPPC_FEAT_ACT_WINDOW : 0= ); + (host_cpu_policy.basic.pm.hwp_activity_window + ? XEN_SYSCTL_CPPC_FEAT_ACT_WINDOW : 0); cppc_para->lowest =3D data->hw.lowest; cppc_para->lowest_nonlinear =3D data->hw.most_efficient; cppc_para->nominal =3D data->hw.guaranteed; @@ -585,7 +578,7 @@ int set_hwp_para(struct cpufreq_policy * =20 /* Clear out activity window if lacking HW supported. */ if ( (set_cppc->set_params & XEN_SYSCTL_CPPC_SET_ACT_WINDOW) && - !feature_hwp_activity_window ) + !host_cpu_policy.basic.pm.hwp_activity_window ) { set_cppc->set_params &=3D ~XEN_SYSCTL_CPPC_SET_ACT_WINDOW; cleared_act_window =3D true; --- a/xen/arch/x86/include/asm/cpufeature.h +++ b/xen/arch/x86/include/asm/cpufeature.h @@ -115,14 +115,6 @@ static inline bool boot_cpu_has(unsigned } =20 #define CPUID_PM_LEAF 6 -#define CPUID6_EAX_HWP BIT(7, U) -#define CPUID6_EAX_HWP_NOTIFICATION BIT(8, U) -#define CPUID6_EAX_HWP_ACTIVITY_WINDOW BIT(9, U) -#define CPUID6_EAX_HWP_ENERGY_PERFORMANCE_PREFERENCE BIT(10, U) -#define CPUID6_EAX_HWP_PACKAGE_LEVEL_REQUEST BIT(11, U) -#define CPUID6_EAX_HDC BIT(13, U) -#define CPUID6_EAX_HWP_PECI BIT(16, U) -#define CPUID6_EAX_HW_FEEDBACK BIT(19, U) =20 /* CPUID level 0x00000001.edx */ #define cpu_has_fpu 1