From nobody Sun Apr 28 19:11:59 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1614097784; cv=none; d=zohomail.com; s=zohoarc; b=VQ6yO8o/8+uTJs3TdGZH/mDCvZ89ssf2aMtVyA9evdlueCc8mAKz60LpqWWrZYK4r1hxLqm8HsLxBic4SllIvRaDDtZcbheq7gK9Uy+/TRJZ8w2WoXOLJYJMWUPZHc3dgDiwDLfuJEbfeprfIUfNgsFUGNMHdv2c4lFEflJPESc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1614097784; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=1fcBBVi2VQJZ1nf/JdbxVgiBTyHyQF9V+0dM+Pib8sw=; b=T5lAbYyLbtaJB3SlD0R9ZswZySjDcC4R5n0tN3QrD84GquRbgZP6CZHHD41n2XM99qslgD7JeJL12Djzm4mdbUDXk+OAUaLx8S/wJPinqA8cBBYQmTtAtjCrFRqlI8c04Wf+WJmHYFBzKydzx2dKYec0rNx66MM6Mruhw8jja9Q= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) header.from= Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1614097784317728.1078962474093; Tue, 23 Feb 2021 08:29:44 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.88900.167311 (Exim 4.92) (envelope-from ) id 1lEaYy-0007ui-8b; Tue, 23 Feb 2021 16:29:28 +0000 Received: by outflank-mailman (output) from mailman id 88900.167311; Tue, 23 Feb 2021 16:29:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lEaYy-0007ub-59; Tue, 23 Feb 2021 16:29:28 +0000 Received: by outflank-mailman (input) for mailman id 88900; Tue, 23 Feb 2021 16:29:26 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lEaYw-0007uW-Eu for xen-devel@lists.xenproject.org; Tue, 23 Feb 2021 16:29:26 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 78f96d78-34a1-4204-846a-25d16c4ea25c; Tue, 23 Feb 2021 16:29:25 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id E6070ACBF; Tue, 23 Feb 2021 16:29:24 +0000 (UTC) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 78f96d78-34a1-4204-846a-25d16c4ea25c X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1614097765; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=1fcBBVi2VQJZ1nf/JdbxVgiBTyHyQF9V+0dM+Pib8sw=; b=AIsb4Pg1kS6LzyrZ1kIU6GCBQu5bS5bkoOedIG3Nw+T9eBFfq99Ao4VwWMueQmuco2vIjY Ic3soYYBWVMq3BTbOblmODIv+41R+gt4ZwjNpzlcBwXmp+D2rTGKlpOAF3SBvncPRo5TlM gdvQxneUDFJeKhdpBdnIo3AHxIoYMyc= To: Wei Liu , Paul Durrant Cc: "xen-devel@lists.xenproject.org" , "netdev@vger.kernel.org" From: Jan Beulich Subject: [PATCH] xen-netback: correct success/error reporting for the SKB-with-fraglist case Message-ID: <4dd5b8ec-a255-7ab1-6dbf-52705acd6d62@suse.com> Date: Tue, 23 Feb 2021 17:29:25 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @suse.com) Content-Type: text/plain; charset="utf-8" When re-entering the main loop of xenvif_tx_check_gop() a 2nd time, the special considerations for the head of the SKB no longer apply. Don't mistakenly report ERROR to the frontend for the first entry in the list, even if - from all I can tell - this shouldn't matter much as the overall transmit will need to be considered failed anyway. Signed-off-by: Jan Beulich Reviewed-by: Paul Durrant --- a/drivers/net/xen-netback/netback.c +++ b/drivers/net/xen-netback/netback.c @@ -499,7 +499,7 @@ check_frags: * the header's copy failed, and they are * sharing a slot, send an error */ - if (i =3D=3D 0 && sharedslot) + if (i =3D=3D 0 && !first_shinfo && sharedslot) xenvif_idx_release(queue, pending_idx, XEN_NETIF_RSP_ERROR); else