From nobody Sat May 30 11:16:49 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1778838334; cv=none; d=zohomail.com; s=zohoarc; b=FE90D4jMGINU/zH6HGOahgzbv5ZU7ddUaVb7PNUM2ZpPsgC0ThxxAo88GdudUvzcCSRrm+xc/tfKhY2X79utoHQbaTA1gW6dJVqj1uD2DHzfGG8EQ9hOgy/WRhTH86DZV5H4R2+xoLLjWUyFzQU6NFqsJ3aaK8LPM8ntp60vbmE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1778838334; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=+hJaSnQ3sX5cqD1qfGugpJRcqI2K1GGAvge8mcTL6Nw=; b=Eu6SIU9G9B3lbXjYfKekDsQpSsAnB+TOgVfI1HB9lWPSmWrDrIUOXf8Sc6pHvnE3S96/rm7IxACtT8fFDa0jd3z0BhD8Neu65MQC8PKiGmFGGvjxHxdgeSKuRwmAzgaQbdX0leIQTiyZj++xYttKwLRmSF46Fc/XM+ovv57KTZM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1778838334687691.7215701876476; Fri, 15 May 2026 02:45:34 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1309795.1580840 (Exim 4.92) (envelope-from ) id 1wNp6V-0001A4-Vg; Fri, 15 May 2026 09:45:11 +0000 Received: by outflank-mailman (output) from mailman id 1309795.1580840; Fri, 15 May 2026 09:45:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wNp6V-00019x-T1; Fri, 15 May 2026 09:45:11 +0000 Received: by outflank-mailman (input) for mailman id 1309795; Fri, 15 May 2026 09:45:10 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wNp6U-00019q-9q for xen-devel@lists.xenproject.org; Fri, 15 May 2026 09:45:10 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wNp6T-005wNZ-4i for xen-devel@lists.xenproject.org; Fri, 15 May 2026 11:45:09 +0200 Received: from [10.42.69.11] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a06eb0f-5cb7-0a2a0a5109dd-0a2a450bc304-48 for ; Fri, 15 May 2026 11:45:09 +0200 Received: from [209.85.218.51] (helo=mail-ej1-f51.google.com) by tlsNG-42698a.mxtls.expurgate.net with ESMTPS (eXpurgate 4.56.1) (envelope-from ) id 6a06eb24-212f-0a2a450b0019-d155da33f128-3 for ; Fri, 15 May 2026 11:45:09 +0200 Received: by mail-ej1-f51.google.com with SMTP id a640c23a62f3a-bcc2b199c17so874180166b.3 for ; Fri, 15 May 2026 02:45:09 -0700 (PDT) Received: from EPUAKYIW02F7.. ([45.12.26.18]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bd4f4ded99dsm197009366b.30.2026.05.15.02.45.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 May 2026 02:45:07 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:MIME-Version:Message-ID:Date:Subject:Cc:To:From" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778838308; x=1779443108; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=+hJaSnQ3sX5cqD1qfGugpJRcqI2K1GGAvge8mcTL6Nw=; b=kKMolczeSgGFbWFeXf52Gcj4XbbkObleKPvTEcVpsum/34KlH5yft+nlCSjEdxwwBo O6x4rW+wOguqXN9gJ2BafWtNxBrPzWLCdYJh3eUXZ8j6KDWn5GzQtZN3Gu3IIOohB+f7 PnJtAD/nFwdVw60lgI11JWtbwU84flL9ib8y6DT5kBI1LIRxlO3jLJmEwuINTLecONhz Obv6ywHSBd8LPQ+p3CBnlqHAB6uC9CF0zsBuo/Zexja56s9m8hyAi2BTzVnR0E5PVUw9 7btjHrzKoZU9FK/6ymYUvZTS3b3cIRinWKCrH6qLweVreiFsXRkRKw5IbNNDQZfFA5EZ ZTRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778838308; x=1779443108; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+hJaSnQ3sX5cqD1qfGugpJRcqI2K1GGAvge8mcTL6Nw=; b=Nzze+uh3KFBQJnRGOS1zbS+1uqGhOhKfLvIgbSxT8Q9uy1UD4W8LtyupDDaIVdzPXh Xb27LwO6f3/No4ObdkHgj3sEUGUKuRfAdta7zUS8vuHTr1zV8UlU4ZmmTZtvTmrr+N3L pGcLdKYv53wzqCWNiKXmi4e4MJ3ZOLRTcGk858Fbo/h4xTcYgAd0Rvt7npqx2ztUJhlj IMyUo/8nIoTZfP6IgsmBr4ya23Dj/uLd7y+cfGm3nW185aRTnJ7JNeWJGjPTRSxcBwQn wKmYGOqQO8n6q7c42GTCtUrOTyQ4AiyfOfxyfBi4mjrKzFaON42zgYasqjMB87r49YAU eofA== X-Gm-Message-State: AOJu0YzXwkjV00066iiChEbnnE3hx33uvP3s0dlELs7ZxAFv+bBiYGeu T99ua74zAJ2xVbCqevXkppLNwx30Z2yKxgTvbuaI5dOEyJdzdEu+UgA6TBRGzg== X-Gm-Gg: Acq92OG32P2INN95E2zzXRCdqtEZQTHq1f4Ifht9/dTkXEzniufgVMXPYqDoH4pM14D vl4bnKkj4WHOlJuAqFZM9nH1bMaOHtkBRno193jb08hR6ADW8LxuBLNspDpdyKD6DzM4LUmfNDZ DRLExxH4bUltnQK4ps6MLAJAokImDciHdlaUUJJ7drfZ4dusyyxrF841uX7uSF+4YmK2NRmmaly h9ovx6pa4E7bFxyuIkxjcLL31HQBn5Wkq3N8ZP/kBpAgP+ycUlijcoTvLD9vcWjppV++haSEsCZ EF8ot3b1OtbQ5EiM3pqMDsL4aVtW59m/W0Glw9/hPpIF1v1pJFAM6cZonx7DmoIiStUmQt8AC64 eqnh7daxKmZhajXE8z4d79Kd3VwOhFFDwfbgzBhBpq0tGDmYzsLmPaJv3heH01BAEdh7QjeD6zk yfwGPRo+WmWBht2xJ6ARQo/fKmLkS60PNjGbXG X-Received: by 2002:a17:907:6d01:b0:bd2:b983:96b with SMTP id a640c23a62f3a-bd5178652bdmr147607466b.20.1778838308287; Fri, 15 May 2026 02:45:08 -0700 (PDT) From: Mykola Kvach To: xen-devel@lists.xenproject.org Cc: Mykola Kvach , Stefano Stabellini , Julien Grall , Bertrand Marquis , Michal Orzel , Volodymyr Babchuk Subject: [PATCH] arm/gicv3: Detect normal NC ITS command queues Date: Fri, 15 May 2026 12:40:31 +0300 Message-ID: <4d72da78b9c30f5da62c8e03c3b03a01c24101eb.1778836836.git.mykola_kvach@epam.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-purgate-ID: tlsNG-42698a/1778838309-21B86F3B-F118FD1E/0/0 X-purgate-type: clean X-purgate-size: 1399 X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1778838335950158500 Content-Type: text/plain; charset="utf-8" From: Mykola Kvach GITS_CBASER.InnerCache uses the GIC BASER cacheability encoding. Both 0b000 (Device-nGnRnE) and 0b001 (Normal Inner Non-cacheable) describe non-cacheable accesses to the command queue. its_map_cbaser() only checked whether the shifted field was zero, so an ITS that reports Normal Inner Non-cacheable would not set HOST_ITS_FLUSH_CMD_QUEUE. Decode the field before comparing it with the unshifted enum value, matching the handling of ITS BASER tables and GICR_PROPBASER. Fixes: 8ed8d21373be ("ARM: GICv3 ITS: map ITS command buffer") Signed-off-by: Mykola Kvach Reviewed-by: Luca Fancellu Reviewed-by: Michal Orzel --- xen/arch/arm/gic-v3-its.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/xen/arch/arm/gic-v3-its.c b/xen/arch/arm/gic-v3-its.c index 9005ce8ce5..7560d46c6d 100644 --- a/xen/arch/arm/gic-v3-its.c +++ b/xen/arch/arm/gic-v3-its.c @@ -424,7 +424,8 @@ static void *its_map_cbaser(struct host_its *its) * If the command queue memory is mapped as uncached, we need to flush * it on every access. */ - if ( !(reg & GITS_BASER_INNER_CACHEABILITY_MASK) ) + if ( MASK_EXTR(reg, GITS_BASER_INNER_CACHEABILITY_MASK) <=3D + GIC_BASER_CACHE_nC ) { its->flags |=3D HOST_ITS_FLUSH_CMD_QUEUE; printk(XENLOG_WARNING "using non-cacheable ITS command queue\n"); --=20 2.43.0