From nobody Thu Oct 30 23:14:02 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1753272017; cv=none; d=zohomail.com; s=zohoarc; b=YQ7tmrXoWPRVEivRoSWPOxqR9FjNS+c8ckigOrSHViGAN6JIPjVuAkN4mHCjxD92JThmQG3vfxhGVKh1pLr569ckevImFJQhowo9P6VTJVOst+vmkmN8a9HNcX2j7lr8t4cYoXbwIu+nsovxc4n4ew7PsMI5Z5ANbJ4+oDBVFcc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1753272017; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=QkLtzKWTr7VWTz1c5nZAKZ9xc/t7FKu3CJQjNdsnyLE=; b=aRRTWBYP/M6UfqgCOv5Vj7RqE1XMeeuGiad9HeOFcML6AodWv11SgHoHZ/IlPWNlh7Ya5jWx1RFlYUH6w8CIuZ9bko9vnMK/uhUNXO8tkXQjt9vPW6fUH9qwGNRSDMZADvOLyj357qG3k4S7KmqF//l2D/3L6+vDg1b64iSkFuY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1753272016868713.1400857042967; Wed, 23 Jul 2025 05:00:16 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1053852.1422645 (Exim 4.92) (envelope-from ) id 1ueY8g-0007Cf-4J; Wed, 23 Jul 2025 12:00:02 +0000 Received: by outflank-mailman (output) from mailman id 1053852.1422645; Wed, 23 Jul 2025 12:00:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ueY8g-0007CE-1I; Wed, 23 Jul 2025 12:00:02 +0000 Received: by outflank-mailman (input) for mailman id 1053852; Wed, 23 Jul 2025 12:00:00 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ueY8e-00077G-Op for xen-devel@lists.xenproject.org; Wed, 23 Jul 2025 12:00:00 +0000 Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [2a00:1450:4864:20::433]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8e296a3b-67bc-11f0-b895-0df219b8e170; Wed, 23 Jul 2025 13:59:58 +0200 (CEST) Received: by mail-wr1-x433.google.com with SMTP id ffacd0b85a97d-3a6e2d85705so3412487f8f.0 for ; Wed, 23 Jul 2025 04:59:58 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-23e3b6d2a8dsm95524805ad.165.2025.07.23.04.59.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 23 Jul 2025 04:59:57 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8e296a3b-67bc-11f0-b895-0df219b8e170 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1753271998; x=1753876798; darn=lists.xenproject.org; h=content-transfer-encoding:autocrypt:subject:from:cc:to :content-language:user-agent:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=QkLtzKWTr7VWTz1c5nZAKZ9xc/t7FKu3CJQjNdsnyLE=; b=Q8ZUniuVna/bwcaYAWxI2VQMzohleAOtk7Cx7zn8giNRuVXbAR2yp3+t//Mhbcdwb8 SmxFx9uO4tZK8xE0QyPf5TKXrauK5Wf/yuT86PovnpQ/1hWpy6zfVjbTb8rlRGSUBwsg K3S5PZiXlkuMp7BdhPlNmY1KbmDC19gBJ91bmtGKXx/W50nPIf9KlaS1cIvxaGPQUjfK F58tY+ZDAJymVe5E8PZ9v8Ie16aHSsVYHWo/z3FDAOduI+4mkAkJzD/4QIiPGN/qlAau 5R4Qov67tF7+PiF+F7k2jsAruU4nujagI99uTh0AxDfkeKXMN/zImlcRtI0hVKY+EWie jJQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753271998; x=1753876798; h=content-transfer-encoding:autocrypt:subject:from:cc:to :content-language:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QkLtzKWTr7VWTz1c5nZAKZ9xc/t7FKu3CJQjNdsnyLE=; b=Ibmd4RblIyR2aJjlleKYnyFzdRnXHH0T5wnGObel/jXvLjYsuIUoDHJwhe4rIgZ6dE E4BerG9TJKJGTITFHVBoqaM8Y2GNWCCHJex8kZIu/MJ62kCFgns+Q8pBpq43hAI9C0ku D1sBT6yJvR+eAUYjKgMHr4faX2VJ3dKR16N19cQdVN3V1wvmNJqsDFGHhRM6G77rkSoC vJbbVCSLi4DVgfq+IDxapK/uMqxS7zZKE8emuZDvdec0/bvJXGhTx1d5PZx2uolkoG3s a+kibEH6dKeu/93lT3horlawff1TTIjUkeBsc4uegQe0wnhRxHjyER2oo9NUpckeTdgO tHeQ== X-Gm-Message-State: AOJu0YygpGJ6uv1PkB7l4lhdstm63m0/Rzsxjni/dhfqu+DVkvq6G5JO uK1I9tK5SZJqwGhWXkK42EJTMDQne3qJHCARgPhIX4aTmOlN7bzmu9k53Bzi3YtuunVCXWi0+OR Bo9Q= X-Gm-Gg: ASbGncvVZ/r1teIThhWaW+nJe/eJxFsFcOOU1BY1qGhyVhRkOnsXnS4kf46Mmx391Fj vjVx4NkDSjZrjPZzG5ow0+Oyjc/HqThJcz9fcJprB+Ze1gpPfUwXkuUkmXyA5Vid1HSmr3pMarM c6l9VVCr2U5BmHrWUp+GvkPNdjFnUzzE3VZram1ZhQkmoh2xIk1wm80BPIm/Rglambvt/wt2gpa acn3xd76jE+Mvgiwh79d2SGpHM6ljA0PiVFPozZgqGmtOJ7Z0xlSDY4f2Af2dgpw+kXv+ew4mf3 5R+7Qj0fMS7L43Xa24vczUk8a6UOxfYEGqpAURMOYomoM/ojJ88djoYBwlA2Jciu6oKr+bVgLFz RrOWnpv2KdKzJp4kyFZVOF0Lwe5SCaae5+6NzyRRskR/rkTlCiSAqcPp4vzHhEmJPXa02lMtEMC 8LSaHeYoI= X-Google-Smtp-Source: AGHT+IFHEyJwBGDuggbqZ288KRxe48fdG3kRxMAUNOT/bRX/AuhrCAW6M52syirj8asMPXL/3v4RXw== X-Received: by 2002:a05:6000:2389:b0:3aa:34f4:d437 with SMTP id ffacd0b85a97d-3b768ef9577mr2042851f8f.37.1753271997983; Wed, 23 Jul 2025 04:59:57 -0700 (PDT) Message-ID: <4897cfe9-f5d5-4ab6-a29c-cda32ab56122@suse.com> Date: Wed, 23 Jul 2025 13:59:49 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Julien Grall , Stefano Stabellini , Anthony PERARD , Michal Orzel , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= From: Jan Beulich Subject: [PATCH] x86/pmstat: drop struct px_stat's usable field Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1753272019671116600 Content-Type: text/plain; charset="utf-8" Its initial calculation in cpufreq_statistic_init() is entirely unused, as do_get_pm_info() recalculates it before use. That re-calculation can then be done right where the output field is set, eliminating the need for the internal field. In turn the struct pointer there can then be constified. Signed-off-by: Jan Beulich Acked-by: Andrew Cooper --- a/xen/drivers/acpi/pmstat.c +++ b/xen/drivers/acpi/pmstat.c @@ -144,7 +144,6 @@ int cpufreq_statistic_init(unsigned int } =20 pxpt->u.total =3D count; - pxpt->u.usable =3D count - pmpt->perf.platform_limit; =20 for ( i =3D 0; i < count; i++ ) pxpt->u.pt[i].freq =3D pmpt->perf.states[i].core_frequency; @@ -257,7 +256,7 @@ int do_get_pm_info(struct xen_sysctl_get case PMSTAT_get_pxstat: { uint32_t ct; - struct pm_px *pxpt; + const struct pm_px *pxpt; spinlock_t *cpufreq_statistic_lock =3D=20 &per_cpu(cpufreq_statistic_lock, op->cpuid); =20 @@ -270,8 +269,6 @@ int do_get_pm_info(struct xen_sysctl_get return -ENODATA; } =20 - pxpt->u.usable =3D pmpt->perf.state_count - pmpt->perf.platform_li= mit; - cpufreq_residency_update(op->cpuid, pxpt->u.cur); =20 /* @@ -296,7 +293,7 @@ int do_get_pm_info(struct xen_sysctl_get } =20 op->u.getpx.total =3D pxpt->u.total; - op->u.getpx.usable =3D pxpt->u.usable; + op->u.getpx.usable =3D pmpt->perf.state_count - pmpt->perf.platfor= m_limit; op->u.getpx.last =3D pxpt->u.last; op->u.getpx.cur =3D pxpt->u.cur; =20 --- a/xen/include/acpi/cpufreq/processor_perf.h +++ b/xen/include/acpi/cpufreq/processor_perf.h @@ -51,7 +51,6 @@ extern struct processor_pminfo *processo =20 struct px_stat { uint8_t total; /* total Px states */ - uint8_t usable; /* usable Px states */ uint8_t last; /* last Px state */ uint8_t cur; /* current Px state */ uint64_t *trans_pt; /* Px transition table */