From nobody Sun Feb 8 22:35:14 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1769692147; cv=none; d=zohomail.com; s=zohoarc; b=mGhqkFgByFM3hwngSSHXfuJ9PUMMbcz7XcYeD1KYcO7vhftEuZ4SDcBGtZOWV5/Q/nL51jweMGIXgSeAVSCUIw1WIMRktPLspjekSOww0Sh/75CpWt8LaU9sQfwe+ljCF4/6152BCBLkCfKDY0SvGAL77SDVxvZSdaU1S2y5QJk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1769692147; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=q7HeAt5kQvtbrf8+RdQ3a+ODredpYahprDWyAOhDj04=; b=cxbxVkXKt1ikqsL+6L7SRCj429fFK8Vaf4/rb84HvlZLpG6BQwan4eI34yT4hJt+K9qayl6dgo+B4Jn8QuASES5r1H1TTGKLsNJksdDdRX3mEdNtwOtRq8wGcmqOZHB7RV+QVBuDEqmEGFYJ66nIrhTtirNrjOaurVXSAC4Pem0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1769692147896752.9566061788314; Thu, 29 Jan 2026 05:09:07 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.1216439.1526392 (Exim 4.92) (envelope-from ) id 1vlRlZ-00043z-LY; Thu, 29 Jan 2026 13:08:57 +0000 Received: by outflank-mailman (output) from mailman id 1216439.1526392; Thu, 29 Jan 2026 13:08:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vlRlZ-00043s-GY; Thu, 29 Jan 2026 13:08:57 +0000 Received: by outflank-mailman (input) for mailman id 1216439; Thu, 29 Jan 2026 13:08:56 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vlRlY-00038i-Mo for xen-devel@lists.xenproject.org; Thu, 29 Jan 2026 13:08:56 +0000 Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [2a00:1450:4864:20::334]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id aa3ecf93-fd13-11f0-9ccf-f158ae23cfc8; Thu, 29 Jan 2026 14:08:55 +0100 (CET) Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-48039fdc8aeso5725355e9.3 for ; Thu, 29 Jan 2026 05:08:55 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48066bee687sm293711645e9.5.2026.01.29.05.08.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Jan 2026 05:08:54 -0800 (PST) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: aa3ecf93-fd13-11f0-9ccf-f158ae23cfc8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1769692135; x=1770296935; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=q7HeAt5kQvtbrf8+RdQ3a+ODredpYahprDWyAOhDj04=; b=SJRbApp+YKZyNb8nkAVx1JycJG3WI1/g0uJAIjhVi64nBX1IwFhuZquCKVwcrRZqXY mZXO4n5uBVoE5CrJtLuOp6H2nF2TySty6BPqPr2CGKIruZdXsJ5sc5/q8Cdv07LeUbyC 46o5D+jNoF9JeWdVUnoQRYcCP4Afwx5H+Y5VTq+BGaaTEQMmFYZgzRinRIP4cpzTj2SI J6D6kbfh1Z7I56eFnLQxJxsWlStTdAnAF2xKwHEPoKfDbQv1NIuaCkOGxYSguZFh2CwK D7ttA5rnT80SfUJJBz9f7maZJYGoEYkLzmjzamM95h5upaegeYvsx0FHRYM2jfoDzLL5 KZJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769692135; x=1770296935; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=q7HeAt5kQvtbrf8+RdQ3a+ODredpYahprDWyAOhDj04=; b=jSbGfjULW1flnIMxZ8o++KVRGRLviCdXeM/tj1G5il8vhbCSDyeOyhsHf19rKmQJWR VtJWShqVd9XXJUBiL9ogPa5tmtdY/NF4/awBFukNa2RRZDlfDwZ+Nshr+DYQBd6/X65t wYlUiSjb0X5Y1NRqVGcO+/c0uVirE3lXi1xB2GmcrbGHESGiEtWbboG/JEFIBSpDVzpR haoq7632lfbfe5aDXcDNi033SVqtwxO0sAHm8IW9CTfnK2XZTmaoB2cjVUVVC3wgeeT3 hl6c9QBhDbxKP9alfAppls7bdaMDUuesxN1WudjBtupf6ItQA4hYr1Ms79yZ6B3CTppl /NXw== X-Gm-Message-State: AOJu0YxlBRPcw+RWFnuc2fuAUspY7+agIaeVtahKb0Ffuc9WT4KsEB1m VpP1r5yFGngM860ojlf65g1VG6DkugelYZAx9fgBX442cOzvRQ30dQg6iCNiYQYK5joHRekizOt KP6c= X-Gm-Gg: AZuq6aLZqPJRNy/L1hQJISngsWDx2oPxo6SCmnLJr+VABrQDzxEDxMN5Pgke71+QFnQ HvmM5BfhS1/MRebiUW0lgS/131m+YfNXbCLSWgqY+S6tSHTSgOGp/BTJJUvlhLsNsWoL7ZmHUwJ I7iSMJhgSds/aGyyBxOnusb0aKxwAFniFCwLlGPN0Do+fg5SqxocAyDaWiUA6NBeddxZbg0Hmnm hsZXV+bwDPwtNbFChDP9V1iZ83N25i8azrXbayx6VAS9ykTFM+VFu3uLgJlNUQ14JW2Xo8x7op3 173Cp0wpUU/dtu6qzSemxlbA20I6SUwuTWRkc7nVPL/myJieh467DJqrfqEr/AbjM6ozdkLTnaK 65JAsXyr5pcASwAaFEUkBTGOYDn9MfdtHHrFtj1o7s1FEjTptkpeSvlZSg2TxdfvIPVkbkc/9AQ cfpzJGNdG3Xe4voZCIBfwH+fXMED38XHqRBY58uX7I48v+3ZAw2ltq9OUL0DqPKeVnTVzwPWWlc is= X-Received: by 2002:a05:600c:8b22:b0:47e:e61d:b8d2 with SMTP id 5b1f17b1804b1-48069c7c4d7mr112909255e9.27.1769692134608; Thu, 29 Jan 2026 05:08:54 -0800 (PST) Message-ID: <47c2fe41-c8c0-4c86-b3c7-8c7f96e59f1f@suse.com> Date: Thu, 29 Jan 2026 14:08:52 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH v3 3/6] PCI: don't look for ext-caps when there's no extended cfg space From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Julien Grall , Stefano Stabellini , Anthony PERARD , Michal Orzel , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Stewart Hildebrand References: Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1769692156607158500 Avoid interpreting as extended capabilities what may be about anything. In doing so, vPCI then also won't mis-interpret data from beyond base config space anymore. Fixes: 3b35911d709e ("Enable pci mmcfg and ATS for x86_64") Fixes: a845b50c12f3 ("vpci/header: Emulate extended capability list for dom= 0") Signed-off-by: Jan Beulich Reviewed-by: Stewart Hildebrand Acked-by: Roger Pau Monn=C3=A9 --- Because of the multiple prereq changes, despite the Fixes: tags I'm not quite sure whether to backport this. (I'm leaning towards "no".) --- a/xen/drivers/pci/pci.c +++ b/xen/drivers/pci/pci.c @@ -113,6 +113,12 @@ unsigned int pci_find_next_ext_capabilit int ttl =3D 480; /* 3840 bytes, minimum 8 bytes per capability */ unsigned int pos =3D max(start, PCI_CFG_SPACE_SIZE + 0U); =20 + if ( !pdev->ext_cfg ) + { + ASSERT(!start); + return 0; + } + header =3D pci_conf_read32(pdev->sbdf, pos); =20 /*