From nobody Mon Feb 9 08:31:27 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1690987147022862.3196370483242; Wed, 2 Aug 2023 07:39:07 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.574980.900702 (Exim 4.92) (envelope-from ) id 1qRCzv-00009w-Bd; Wed, 02 Aug 2023 14:38:47 +0000 Received: by outflank-mailman (output) from mailman id 574980.900702; Wed, 02 Aug 2023 14:38:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRCzv-00007s-4D; Wed, 02 Aug 2023 14:38:47 +0000 Received: by outflank-mailman (input) for mailman id 574980; Wed, 02 Aug 2023 14:38:45 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRCzt-0006bO-Hd for xen-devel@lists.xenproject.org; Wed, 02 Aug 2023 14:38:45 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4884aa7a-3142-11ee-b260-6b7b168915f2; Wed, 02 Aug 2023 16:38:45 +0200 (CEST) Received: from nico.bugseng.com (unknown [147.123.100.131]) by support.bugseng.com (Postfix) with ESMTPSA id 519DB4EE0746; Wed, 2 Aug 2023 16:38:44 +0200 (CEST) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4884aa7a-3142-11ee-b260-6b7b168915f2 From: Nicola Vetrini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Nicola Vetrini , George Dunlap , Dario Faggioli Subject: [XEN PATCH 10/11] xen/sched: add ASSERT_UNREACHABLE() to address MISRA C:2012 Rule 2.1 Date: Wed, 2 Aug 2023 16:38:16 +0200 Message-Id: <3f1385f2ddb151a53ca092ea1caeac5d12fd80f5.1690985045.git.nicola.vetrini@bugseng.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1690990032795100001 Content-Type: text/plain; charset="utf-8" The break statement after the return statement is definitely unreachable. As such, an call to the ASSERT_UNREACHABLE() macro is added to signal the intentionality of such construct. Signed-off-by: Nicola Vetrini --- The break in the clause is mandated by Required Rule 16.3, which is not yet an accepted rule for Xen, but may be in the future. --- xen/common/sched/core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/xen/common/sched/core.c b/xen/common/sched/core.c index 022f548652..fcee902b4e 100644 --- a/xen/common/sched/core.c +++ b/xen/common/sched/core.c @@ -2233,6 +2233,7 @@ static bool sched_tasklet_check_cpu(unsigned int cpu) /* fallthrough */ case TASKLET_enqueued|TASKLET_scheduled: return true; + ASSERT_UNREACHABLE(); break; case TASKLET_scheduled: clear_bit(_TASKLET_scheduled, tasklet_work); --=20 2.34.1