From nobody Mon Feb 9 21:39:49 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=fail(p=none dis=none) header.from=arm.com Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1770291253398710.5947675674969; Thu, 5 Feb 2026 03:34:13 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.1221768.1529906 (Exim 4.92) (envelope-from ) id 1vnxcF-0003fD-Vm; Thu, 05 Feb 2026 11:33:43 +0000 Received: by outflank-mailman (output) from mailman id 1221768.1529906; Thu, 05 Feb 2026 11:33:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vnxcF-0003f6-S5; Thu, 05 Feb 2026 11:33:43 +0000 Received: by outflank-mailman (input) for mailman id 1221768; Thu, 05 Feb 2026 11:33:42 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vnxcE-0003et-Cr for xen-devel@lists.xenproject.org; Thu, 05 Feb 2026 11:33:42 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 83fc179f-0286-11f1-b161-2bf370ae4941; Thu, 05 Feb 2026 12:33:39 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id F322E339; Thu, 5 Feb 2026 03:33:31 -0800 (PST) Received: from C3HXLD123V.arm.com (unknown [10.57.53.248]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A11213F7D8; Thu, 5 Feb 2026 03:33:36 -0800 (PST) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 83fc179f-0286-11f1-b161-2bf370ae4941 From: Bertrand Marquis To: xen-devel@lists.xenproject.org Cc: Andrew Cooper , Anthony PERARD , Michal Orzel , Jan Beulich , Julien Grall , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Stefano Stabellini Subject: [PATCH v1] xen: Use MFLAGS for silent-mode detection Date: Thu, 5 Feb 2026 12:33:12 +0100 Message-ID: <3ab39249c788fd0463e73df9464d482fefe8516b.1770290975.git.bertrand.marquis@arm.com> X-Mailer: git-send-email 2.52.0 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1770291256143154100 GNU make 4.4+ exposes variable overrides in MAKEFLAGS after "--" (e.g. O=3D/path, FOO=3Dbar). The silent-mode check searches for "s" and can match an override value, forcing silent output even without -s. Use MFLAGS for short options and filter out any long options before searching for "s". This preserves -s detection while avoiding false positives from overrides. Fixes: 4fdb4b71b152 ("xen/build: introduce if_changed and if_changed_rule") Signed-off-by: Bertrand Marquis --- xen/Makefile | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/xen/Makefile b/xen/Makefile index 13e336ba5484..5fc725fb02db 100644 --- a/xen/Makefile +++ b/xen/Makefile @@ -113,10 +113,11 @@ else Q :=3D @ endif =20 -# If the user is running make -s (silent mode), suppress echoing of -# commands - -ifneq ($(findstring s,$(filter-out --%,$(MAKEFLAGS))),) +# If the user is running make -s (silent mode), suppress echoing of comman= ds. +# Use MFLAGS (short options only). MAKEFLAGS may include variable overrides +# after =E2=80=9C--=E2=80=9D (GNU make greater than 4.4), which can contai= n an =E2=80=9Cs=E2=80=9D and falsely +# trigger silent mode. +ifneq ($(findstring s,$(filter-out --%,$(MFLAGS))),) quiet :=3D silent_ endif =20 --=20 2.52.0