From nobody Mon Feb 9 21:01:28 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1691656830160745.1526368589382; Thu, 10 Aug 2023 01:40:30 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.581925.911408 (Exim 4.92) (envelope-from ) id 1qU1DI-0005gt-SF; Thu, 10 Aug 2023 08:40:12 +0000 Received: by outflank-mailman (output) from mailman id 581925.911408; Thu, 10 Aug 2023 08:40:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qU1DI-0005gS-M5; Thu, 10 Aug 2023 08:40:12 +0000 Received: by outflank-mailman (input) for mailman id 581925; Thu, 10 Aug 2023 08:40:11 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qU1DH-0005Mc-Aj for xen-devel@lists.xenproject.org; Thu, 10 Aug 2023 08:40:11 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7d9acf43-3759-11ee-8613-37d641c3527e; Thu, 10 Aug 2023 10:39:59 +0200 (CEST) Received: from nico.bugseng.com (unknown [147.123.100.131]) by support.bugseng.com (Postfix) with ESMTPSA id D242D4EE0742; Thu, 10 Aug 2023 10:40:08 +0200 (CEST) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7d9acf43-3759-11ee-8613-37d641c3527e From: Nicola Vetrini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Nicola Vetrini , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Wei Liu , Luca Fancellu Subject: [XEN PATCH v2 2/7] xen: make 'saved_cmdline' static Date: Thu, 10 Aug 2023 10:39:42 +0200 Message-Id: <3a3f56b54b7051a9a741f5b54e8bc266b451c5e4.1691655814.git.nicola.vetrini@bugseng.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1691656832219100003 Content-Type: text/plain; charset="utf-8" The variable 'saved_cmdline' can be defined static, as its only uses are within the same file. This in turn avoids violating Rule 8.4 because no declaration is present. Signed-off-by: Nicola Vetrini Fixes: e6ee01ad24b6 ("xen/version: Drop compat/kernel.c") Reviewed-by: Luca Fancellu Reviewed-by: Stefano Stabellini --- Changes in v2: - Revised commit message --- xen/common/kernel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/common/kernel.c b/xen/common/kernel.c index fb919f3d9c38..52aa28762782 100644 --- a/xen/common/kernel.c +++ b/xen/common/kernel.c @@ -28,7 +28,7 @@ CHECK_feature_info; =20 enum system_state system_state =3D SYS_STATE_early_boot; =20 -xen_commandline_t saved_cmdline; +static xen_commandline_t saved_cmdline; static const char __initconst opt_builtin_cmdline[] =3D CONFIG_CMDLINE; =20 static int assign_integer_param(const struct kernel_param *param, uint64_t= val) --=20 2.34.1