From nobody Fri Nov 1 00:31:15 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=suse.com); dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=2; a=rsa-sha256; t=1686570346; cv=pass; d=zohomail.com; s=zohoarc; b=OuoGqf2TlKMuTULFvwARtABIQaciykh2GqQ6pptZlgqcv3QsdIQifJlcFrMOGUung9SaZxEo1VCRuoC2TtVhjs2SUbjy+C6TLKGP7ZNqWWjK5yPuM+wpoHqjsFcps5gX5iLOJYihx+SjLU3aRCWmx6veZ+wFfCROb4xPFa2In1w= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1686570346; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=U1YzWXeZ3z6bC+mXj26Xjsu53Z/uSpydklQeVDdytmY=; b=az9Eo9tI0tEF4+XOwYhjDTf4tiVmLk/2fb40wKy0UkYooj3RwceiNmcjr/9WzXn4+5bc9rhqWf5iOJKIw5eBspQ1MECPmIGRIr/Iuexkx3HhwzBPTdmWkjGVmNKDfMX/7Wz+6+Ct8kzSjzDNywwF6vYuzj49PPrl4q7F/6OQgzo= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=suse.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1686570346137246.78229663160664; Mon, 12 Jun 2023 04:45:46 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.547049.854231 (Exim 4.92) (envelope-from ) id 1q8fzB-00075H-3C; Mon, 12 Jun 2023 11:45:25 +0000 Received: by outflank-mailman (output) from mailman id 547049.854231; Mon, 12 Jun 2023 11:45:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1q8fzB-000759-0P; Mon, 12 Jun 2023 11:45:25 +0000 Received: by outflank-mailman (input) for mailman id 547049; Mon, 12 Jun 2023 11:45:23 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1q8fz9-0006zd-Ld for xen-devel@lists.xenproject.org; Mon, 12 Jun 2023 11:45:23 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on0608.outbound.protection.outlook.com [2a01:111:f400:fe0e::608]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9d3a3d42-0916-11ee-b232-6b7b168915f2; Mon, 12 Jun 2023 13:45:23 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DU2PR04MB9196.eurprd04.prod.outlook.com (2603:10a6:10:2fb::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6477.29; Mon, 12 Jun 2023 11:45:21 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e442:306f:7711:e24c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e442:306f:7711:e24c%5]) with mapi id 15.20.6455.039; Mon, 12 Jun 2023 11:45:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9d3a3d42-0916-11ee-b232-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YibojOIAdW5tPGK2VycNy0yipEcUu2k0A+xhpKTNoBQVWarroikS4pJgYoWE2YdEC/r23QEReyAv7AjGOmY7D9vkNR96Ehxpne1hEh1U+7XMj1YUXFDMdPgvJtimLuXngLHgczOXXuKPPg+GijS/qUkDIkh+qBAay3y456kPP9J0daF8dUxWZDEDk3yMQjy8Q4sbYY9jJikd/GuEeHH+Rg6y9Qh+f5maaZqHp5Y2LY9US6nex5FYBdQtRJkeyw67IHpTl7i3xAsnXkJqVpRSNesxbxHeI1eppYJMz3U4AVAqGfJrcHewubHgVsb8/tu+hPZDeNZ562UwcC/9OnCDfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=U1YzWXeZ3z6bC+mXj26Xjsu53Z/uSpydklQeVDdytmY=; b=kpp+DfTPJPbW4bTuPk3rGFXT4nT+rPAivFHH61hAZk1GPWdCVe4yz0JC8WVRxYeqZpwLq/KGV5hTKzGLLp9LvPLLYPlsHwSK7DeSEc2Rf2Aa10iT7KA0waQ4qHy0zI440FYoJRgy1xTmKjS4M7M8oX8aRSCJkSkt/V2Mogf0os6lHN0xsCIR8C3vLDSnqC1Pc5YhVTXAvyaVLW0DoB8fsHVLJ+mnR4aaonLr50W9d14DiDeD2vnkPgc5R13MwZ6PzfZZ7SrCfy2cbDn59kO/0Zm5IYckCjZKYjGaFHUrmj/0Ny8YY/zhz6auWv7Ol18UQ/JPmskxYn32cZxWXcx1HQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=U1YzWXeZ3z6bC+mXj26Xjsu53Z/uSpydklQeVDdytmY=; b=orqTSxlynbBkXGxentfJ0rDR9LeM/IaftWeMPCXKAPSprBAkCDGzmQla3YrkuNHVQnrtZsU1m3tKhP+1/LdkcDnRBaDRD3iClFkHVWoIlL2lMDRTArb4hwyMCQ2nqfpi4DoMVaXVPgRCHyhd6PqOfwCbHkLlUHQIyEyKDFQzDhlaQ04aY3fvs6XmmzFM4zo9LXW3bjJSox10BkuHQHctYVaTr7tQDANx3ds3SlfTcd5UrASBOrC7lgzQKnte5yJWfpcdl3BYj5Ai7nuaYcTsLGAbGuOAxQWrzAwIijHcnZC05AP0uQQmag2sc9H1W/Q4zAv9U74DX+IcFdgy0ObV9Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 12 Jun 2023 13:45:20 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: [PATCH 1/5] xen-mfndump: drop dead assignment to "page" from lookup_pte_func() Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Anthony Perard , Wei Liu References: <2dc50b58-a4e4-3e32-1876-94412b14b052@suse.com> In-Reply-To: <2dc50b58-a4e4-3e32-1876-94412b14b052@suse.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: FR2P281CA0076.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9a::18) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DU2PR04MB9196:EE_ X-MS-Office365-Filtering-Correlation-Id: 5dd76939-9ab7-4e30-f616-08db6b3a80d1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: arLVgovyo329rgDR+VnOfp7vWkCeFN5E9CfnqrV+WFUgpMAaGpajNNTC7UKw+m7gbqLxw1yx1CnvgZTFaOXElcF0HEzxIMBJrq5Qkhz+75PdBBs/QQZca3nqyFev+EzRTiJGPc1Fw7yEctA1N0sP/dzMJIdP+WKe5S+dj4JiqqChuWQrxDY1Dhxh7BcvHXOIWLLZMgqxmR2MOQywaWlXfgE/r5m2Olx/iRTj5NbIjJx/f6ckAK+Fk2PZRbixZz9BXGppA6aQeSiEC/4W1XB2ltm035Ergrvsq85E+iPNeaHlSF/z+4qODTAq7e3JOsy87k7Ju4nmDaaoHZKy3p9krmJVUZ9gwWRYNdWbFRuS5OPZwL2wkBCqcir6+sF3un5MsQXF2Wppe2aDb0/HPaVZadbjD+A0TL/b5KdT8pepK/DCavIK6k6jJ5/XGrhdxIUcaAV4GTprxOsKoYG74eqrQL0US8J9BJ8DpsoMbml4zC/CGCijhkDtzBDm0aZa2Hc1I46vw3BkU0J0x2UeLpZ929vl7SkmBYUfAn+I0Qj1cVtvI/rVCmnBsavamvc4LODXsbb2dkiZ5tdpqly2bmP6TWCWltfomqh4BehlI2ak72tqF6sCU9TphBIQKWT+BWPvsFQuvUiXx6z9uQF2JhvJO/jTEQF4NniGBw12UXT5FIcHkYAqW44NtKGwIR5QL/Al X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39850400004)(366004)(376002)(346002)(136003)(396003)(451199021)(54906003)(5660300002)(31686004)(4326008)(66946007)(66556008)(6916009)(8936002)(8676002)(41300700001)(316002)(4744005)(186003)(2906002)(478600001)(66476007)(6486002)(6512007)(6506007)(26005)(36756003)(86362001)(2616005)(31696002)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SkJTUUNlZzJ5ZExMb0Y1Z0pOVURJVkcyYU1FcXlFUnpaZVhseUd6RXYxcW5W?= =?utf-8?B?UW1tUWpsbGVhSmx5NnNoVEpYQ1RGL0tFelFnWUV6M2QxMHhScTdDSERUVzJ5?= =?utf-8?B?WnRHN0dIRDBkY1JIbmJuMk54VGVoZ0tSbVdXQmp2VVNIWGpGVDZiYU5SdTRm?= =?utf-8?B?alo5VXVleEI0Ynd6YS9zaXlyR3VIMmVadm9BWE9jY3pJWENhbWpuNDFna0dn?= =?utf-8?B?MEo2dk95bTJtWHZ0VE9oMTdBUjczeHZLaWJpVk1xMmV4NldNOEdBRDl2UFBz?= =?utf-8?B?dlBGbVZjK3VDSG5ITEdiTDFVVEZnTzN6aVFnblhVZTg1YVZVTEJFTUdCODhB?= =?utf-8?B?MTh1Tlg0MU5IeUJIUHc4enVtSjdFcjZmeUpwM3gzZEo3bFIzYjBIRlIweHMr?= =?utf-8?B?Ujh2Q0RMQnAzVmhtTUtwYURCTzBrVWRwVFZiaFFYUW0vSVhFTXlYTVJHT2V4?= =?utf-8?B?TGdDbDVEemIvcEt0SVYybW5GKzVDTDh6Nk1JbXFKdlJ5ZHM5eXl3WVdJdW9h?= =?utf-8?B?UFpCdzhHSDhsbmYrN3ZEd1hrUHZwMUF4WlBkWS9YWVY5bE5JYkh1UGVpbjlJ?= =?utf-8?B?M0VnMWxVdHhVUk92bG5kMDF1UTgrNEhuZmZ5Sm50T1oxNmVCZm5ua2VvRDdi?= =?utf-8?B?Y1h1UVdwRHNnQkFLTlFCYkdSTnplcGx2MldxbzBrTmVmNFFpNlBLY1oxMWZs?= =?utf-8?B?YUczc1VINktkTzBKKzdnWW42UXE4STJmL1ZwWnpFSXp5ZVQrdnZYM1dIMUFv?= =?utf-8?B?cU5rVGhyWkxzRHVwOVZmZ05DVjZjU1F2NXJqYjBMQUc3LzRVN2RmNUUzb1RH?= =?utf-8?B?R0NEd2ttd3ZvVTV4UzlJaDRtZnpSeXVJNjFVK2U5Q0l2aTNma1FnTDY4RlUz?= =?utf-8?B?VStvWVcrWkpuYXd0c0ZhOWhUTDVqcWR4SGRYejJEMFlEWkt6ell3OUNXRzln?= =?utf-8?B?cXVCRjU2c2RCQ3ZjUWtVdGEvY2VTSW00WGlSNVA1VG1vMzMwODdBUXNwQW9i?= =?utf-8?B?M09QYzlnUkxSL1c5QWxTUzJybE5EeUFIVGZMQS9xamhqekVuYS9VYlFmbGtF?= =?utf-8?B?MERrb24vRzBjYlkyS0MyRG1rS2xRZkpsRC80MjlXczB3MkMxTTZYOFdjVjFo?= =?utf-8?B?U3NsTHFESUQ2Tkc3ZmEzaTlEejY4TnZCbmZ4MS9qVEJnZWFxUDBmRlBkaW1v?= =?utf-8?B?SzR3R3hlanRtWkxpdGIrNWczc1lseVBpZnhIUGV6ay9LbkF0ZldjWE1sbFVw?= =?utf-8?B?c1pIeG11ZjFZMEtlakFmcGZrQWYwUnNtaDVrV0hORnQvdng5dUdyalVrekFr?= =?utf-8?B?cXNaSUhJN2lUdmVSaTZUMFJlTXFMSGhsM1dERkhYWjZRdXRrcTJuNW11R2la?= =?utf-8?B?MGwvWTB3SlZDTUtvUE9kRGtaSWd1SnJybjNTbXArTFA1ZmlwSVN0aU84OXFt?= =?utf-8?B?eG9lMTk3THVEYXZCbGgzdmZFNmJSWTRZTjlXQW5pa0FraTNoM3FLYnFQeS8v?= =?utf-8?B?OVlhN0dRSkRMNXlWS0VKVGtPR3pWeFBIYXlwYlpMdEo5SDBUVm8rTUxQVGVP?= =?utf-8?B?QUNoeXRoYkc5UDdoZDlBeVVkdjlFbDBHYVhuTGFOZUExUEx5bVFEamNQMkVK?= =?utf-8?B?bHg2eGFFcER4VlpseWdCSXI1ZDhPSHltT2hEZGEzbGxqMHpMNURWTXAyWmFH?= =?utf-8?B?Zk9Kbks2TVJueU1VWWpIblZOZnZKVVlHOHNyMHRnOWNOcUNpdU5JeENmSUFW?= =?utf-8?B?RmlzVDVFVWtudW1BOEx1VHRzazlUR0NicWNRSXhYK2t5aHNhRHI2ODVMbk1C?= =?utf-8?B?bzNLcmljcVN5VXpWQSs4OW14K0VNeENXc3JIWDFrSWlJWFBqdnU5Mlg4aHdZ?= =?utf-8?B?cEtmUEZSenJvWmp6dTlXYVhMQm5hSUtlVU9OSnROT09Qd3hiL0Q2MGJnMEhR?= =?utf-8?B?SlZROHd1NUYrRkNVTjAyVFU5ZzAyR3RYNWZTUWpEWVFnOWNDL1IxUHZETkxG?= =?utf-8?B?anFESnI4TUdSUXQvdGdmMVJPNlNKdkdsK01nczNpU2cyUWJ1L01IWTlValN0?= =?utf-8?B?ZTltU1V5M1lzSzZMV3J6bTdETFJqY3RKS0ZqQ3hkOWJkdndUNHFGL2VVTHEy?= =?utf-8?Q?SXrc/SN2JKNre5A+BOvsdE6aB?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5dd76939-9ab7-4e30-f616-08db6b3a80d1 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jun 2023 11:45:21.7926 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: OjfulOSW86MDsYfvM438jEvZq2+rmKHzLe20+PzCZVEkVxKuNkXwDobZZKeCFR7PDwpiEdj+9j9hEFMeRXAm1w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB9196 X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1686570347960100001 Content-Type: text/plain; charset="utf-8" The variable isn't used past the loop, and its value also isn't meaningful across iterations. Reduce its scope to make this more obvious. Coverity ID: 1532310 Fixes: ae763e422430 ("tools/misc: introduce xen-mfndump") Signed-off-by: Jan Beulich Acked-by: Anthony PERARD Reviewed-by: Jason Andryuk --- a/tools/misc/xen-mfndump.c +++ b/tools/misc/xen-mfndump.c @@ -265,7 +265,6 @@ int lookup_pte_func(int argc, char *argv { struct xc_domain_meminfo minfo; xc_domaininfo_t info; - void *page =3D NULL; unsigned long i, j; int domid, pte_num; xen_pfn_t mfn; @@ -301,6 +300,8 @@ int lookup_pte_func(int argc, char *argv =20 for ( i =3D 0; i < minfo.p2m_size; i++ ) { + void *page; + if ( !(minfo.pfn_type[i] & XEN_DOMCTL_PFINFO_LTABTYPE_MASK) ) continue; =20 @@ -323,7 +324,6 @@ int lookup_pte_func(int argc, char *argv } =20 munmap(page, XC_PAGE_SIZE); - page =3D NULL; } =20 xc_unmap_domain_meminfo(xch, &minfo); From nobody Fri Nov 1 00:31:15 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=suse.com); dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=2; a=rsa-sha256; t=1686570404; cv=pass; d=zohomail.com; s=zohoarc; b=DAIfl6Hv+FJ4IBqTOo1RhcwE9gcrYNhcXK1Oad1YsBGseRuBJ1Nsa9+15X4n6kWIaAlNmRzF9bKQsYw8yAF6Z1+cnQp7XzrXnWcfjGM99bCEXFIwbCTqirHc5M2fCJ6KzE5iLnFtHVa+PvP0WsAFDpxZUsG0vcN7coJffoBYhEM= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1686570404; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=+dDuzZO3NY+2JEelv9HlCc27GL3IfXBwOaXL4IVoUlc=; b=caXyykzGnJndk5WdwDMOLaoYrmzDtrmHh2KyZPegHINDQu9aQctFbpRbZj7ncDKBIQZcsYo71siCF3LAKYv5u1OOYRk3T7y3D4HNDiaI1jnwocmEFJc6vtbNl7e1XLtWRgloWx3sEtUkOIOUJ/85MahrEiAJvH7v0mqHgk8BrU8= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=suse.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1686570404964968.6997212747322; Mon, 12 Jun 2023 04:46:44 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.547061.854250 (Exim 4.92) (envelope-from ) id 1q8g0D-0008FN-MA; Mon, 12 Jun 2023 11:46:29 +0000 Received: by outflank-mailman (output) from mailman id 547061.854250; Mon, 12 Jun 2023 11:46:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1q8g0D-0008FG-JT; Mon, 12 Jun 2023 11:46:29 +0000 Received: by outflank-mailman (input) for mailman id 547061; Mon, 12 Jun 2023 11:46:28 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1q8g0C-0008F8-0v for xen-devel@lists.xenproject.org; Mon, 12 Jun 2023 11:46:28 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on0627.outbound.protection.outlook.com [2a01:111:f400:fe0e::627]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c3719919-0916-11ee-b232-6b7b168915f2; Mon, 12 Jun 2023 13:46:27 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB9424.eurprd04.prod.outlook.com (2603:10a6:102:2b2::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.33; Mon, 12 Jun 2023 11:46:23 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e442:306f:7711:e24c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e442:306f:7711:e24c%5]) with mapi id 15.20.6455.039; Mon, 12 Jun 2023 11:46:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c3719919-0916-11ee-b232-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cuBb1RoVDyFLwaSn2pW2mdhS103q6yLgOy/dymeMaq/6vbJATYYM8L/WP1xmRtbK5+O4uNT8dFOak4OMWC7mH3HU/I67paXlVEntc3iz8ku9CsjcF3GV+PqvOdoGLRAhk8IB1Fda79fdV7kV8jG5cKwfdYiOTqcHypxpzstve8cHDTIx1JMIpHALk8LlywZYDpm7FbE+Gt4cDhdM9WGFflJnlsG85eeh+oPEsOGntZ2aMshsCdhSCqbNMkkV9+Tdr4/JsxVu6A7/1sxHVQiYm2IyfkbKOanDbVFw622P0ARBLU0XszHjAUeJ2Io17aGfE4p2/CLs/teIWH6vwWrrTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+dDuzZO3NY+2JEelv9HlCc27GL3IfXBwOaXL4IVoUlc=; b=Tgx4oLAGyXtu9R+WofTZ1vIT2GoJVcxQAN8E2tc1TU8i0I6pQoFYBiRTTsk+B47GocdxiBRKMmBW2x+xxBS298QJCU/7muajlfIkvHyA6IVQ6eQQULAMlpRSMXZ+0IT+Jxs/C2jX8MIOZQO0R/NL9gv9OevhfrOm6l6hbammN+50ig1lamLCIsIsd+9Z4bvVSfieES3jo/GmXAUhtbGGiPHqzbhmro2fBxFFyuUVGmpAL6wvknGhSZ3yaxLXcEdGvcdwnkKyxJbrCnIiEC4bQ54BcGf2mXTSLcHJh1qsKQg9voLLZo2vkTr4hT0TkPQgiHgnsO2Tb3zryWrxhPQ+Qw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+dDuzZO3NY+2JEelv9HlCc27GL3IfXBwOaXL4IVoUlc=; b=0PxbqoHncnfKxb0EkDIuBDlElfqDg/52LjB3Hum7awJH2xkBWZ45yuG50rRMMNLTQf5AKQbatkRITggZhFuyWe+cX1i2+HGPW8BrS3v9TpP8pC+D9fi0wSpBuEINZmRU/n0HH0bOY1mD1wY3dItfoiIkwC+MMDITp9LfI8javGKjTZoB8PMmVr/owKnexTobhwnjGPrqrsZwqVO3hmWHeUZhfCi2nN4QqBfR+oWkzR8XW77Ys1//ePru+sAjQJ8z8c8cRa+5fj+cSid79ljEkz5KIGHZIseYqheLUqwr5wvbQsyH2FrCoT/GqYR0Ztx+kI9qtOIPtGy5zgVJUTBCBw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <5eda17da-7185-9cf6-7e87-70da57aa0ebc@suse.com> Date: Mon, 12 Jun 2023 13:46:19 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: [PATCH 2/5] libxl: drop dead assignments to "ret" from libxl__domain_config_setdefault() Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Anthony Perard , Wei Liu , Juergen Gross , Daniel Smith References: <2dc50b58-a4e4-3e32-1876-94412b14b052@suse.com> In-Reply-To: <2dc50b58-a4e4-3e32-1876-94412b14b052@suse.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: FR2P281CA0095.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9b::17) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB9424:EE_ X-MS-Office365-Filtering-Correlation-Id: b886b6c6-6e15-4515-cdf0-08db6b3aa47c X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1a9JzZS1gVN6MoesZUCHQqmbztcsCmxJ176c184Z57bQ51Nr4d8AvzKypk5GWhcfTx5Yw7pDLc0rTixQNQXz7H+qXY0FaLUEYGiFBy71ee7AmA4sZno4xY2oPdfPOTrL8cUqMcpYV5x5dEr5s1s+2G1Pv6it7JaVdTO6tx0LVyYnlkrUOue+/zRP7JE6wvu/rDMxpDK1WKdAtqXhvIguMk0/wL+waenZan8IY38IEfIYrk/6vBIpk0Kdb410LlqdztHEKYUMDDj0NQ5/4+Dv6oOazpeLhxGZF+gXDWVPr1mCtuy0BxzpYUOW9vr4dFqQBhdlPsWXCnSvRnxQh418DHNVC/W890qa31nydzTo+wOn0yJa9YUpBuxPpJgQdocWoQTtYkUBGOyrvB+b5Ae4fNeGngIFmrjwu9rI0TnOskRggseQikBWHBVmRHoClzRluXx4OfiqWQOXgC2jE1J3P0tqcSiJHuZFDbF83iCgJ43x7vOkzIdy3WQCg9gPqYLCr9HifINLUVqJ216/IxEUkdi2w6u4nszFJXpQLWnM+xBS/bK3b78sVTbTtVuwkxfKLF60mCAJp/4FGqsfGx1h3DNOPNW07fSY80+RNOScaWT/z6uT1SMYZXwPl4jhYILcSI+4HRvuLIszhmqPEHlYDE8Lm5qm3/iWD294CpyPv9WX2lc06TbuRZmH22K9laIx X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(366004)(376002)(346002)(136003)(396003)(39860400002)(451199021)(478600001)(8936002)(8676002)(54906003)(6506007)(5660300002)(41300700001)(316002)(6486002)(66556008)(6916009)(26005)(186003)(31686004)(4326008)(6512007)(66476007)(66946007)(2616005)(83380400001)(2906002)(38100700002)(86362001)(36756003)(31696002)(101420200003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MXRYdWhtMVYyc2xCLysyZ2RFU2g3MU1TamphWWliNGcycjhPRE9wbjJWQ2xi?= =?utf-8?B?ZVc4OHVwSkRhYWVCMW4wby85MFdvU295NGhVdTV2Q3RqaHpybUpSQ2lDWnFL?= =?utf-8?B?U3N4SENsQjdEdVJEVkM2ZG9qMHliMFpWeVFTNm9BRkxWdUpMby9uNTROZ25n?= =?utf-8?B?MHQyb2F6eHZkL2VZZGt0anl3WFRqQ3ZiWjdnL0ppZ1AzbkMrdzJyQ2oxblZq?= =?utf-8?B?MHI3dXJPYkx5ay9kTFBuWFNZQ1poWmowSFI2YmhaS0pkeEw5b0xpVDZ3M3BY?= =?utf-8?B?dlIrdWFFMXBuT2Jkczd6c21rNWZBQUNDMkJaZWljeFBRSlU2cmFWTlp1WitY?= =?utf-8?B?eVhxVlVxeG1iejlKYXRkdXBhWFl3cGtQTUxKS3hRUFJ0dCtCL1RLdmZ3MXNB?= =?utf-8?B?OWwySk40K0tmeE0yaUlISmhKQ3NVbTM4SVRTUlVjcEx0dEdFengybndURWJW?= =?utf-8?B?Qm9NY2NpeW02OXplVTZkZVlYWEYvdWhUazdOajNReE8vZFFHTkZHL0hJU3JI?= =?utf-8?B?Y0oveGdoc1ZlaDdFeWF6OXRqSXN1RzY0azF1cWFuTWNXSWw3eCtWWXpCdElI?= =?utf-8?B?T1lwWmhSRXdwVkZKZGpFemdtSjE0dDhJaE5GQWpuamhqRll5dWszNVZhWTVV?= =?utf-8?B?NXB5a0hYa1J6SUNYUGdBSHpJY3UwbXRGTmU2RHVTeUFvckEzcjYwTk0rcTFk?= =?utf-8?B?SnZTREUzSmY3NnNDTDg1YjFpcDFJM1loaThueW0rOVppTS8wakRMamJDOEha?= =?utf-8?B?R0FZS3dMQlJWWndMSmNtbzRuWGlNQnE5R1VqMjdaOHpDcDZOWVVTQ1pzQWcv?= =?utf-8?B?STU5bWw0RlI0NVlmTzhxdjR2WGtzdUtDaGJFUEdzamtVMTlEUllDdEtXbmhT?= =?utf-8?B?SlVTRVpVcVdpUGg4Qk5MeDU1a3Y5czNIdGVYa1JTZmQrcHZiSkJoYWU2TE4v?= =?utf-8?B?dW1nZENSNmVUeXZYTGdUSGg1djM1YWlsbEtyY3AwK0dRT21pSGRtT1hMa09F?= =?utf-8?B?VytzS2VaenR4ME9BTDFER1FFR0FtVDgvY2tuc01BajRDYkY4aUU1aWZsSUtu?= =?utf-8?B?QStjcnJIak03V2Z3dlIwUnF6M21IMm1pQTcrLzVaQzdoSUZmVGpoY2UveDhq?= =?utf-8?B?SjIrb3ZWeXd0V0hLYklTWVRGSFdyWlBMbGY5MHZ1dS9ZcFJYTWNSZ0RsYjBk?= =?utf-8?B?L2g5U1B1dVhDQW1lejZTamFMbTNwV2hySTZncXVYQW5xWjcwZytIcS9QdDlw?= =?utf-8?B?YkllelRmekdPQmZDUDBidnV2VnpEWWJXeXM3eE1KQmM3RW9BOUFqc1lUMEdS?= =?utf-8?B?SFFzMW9HWFV6anh6MDYzOTFka0FaRVNOdnorb3lhaHd2ODVLalpmN1lYNGtC?= =?utf-8?B?NzRpcVdRZHl4UDl0V1ZQdFUwM28vVDBudThnbWpQUDhJYlpIdHNkaElKTDIz?= =?utf-8?B?ZU5zYjNTUGpVVkt5by8wbU1adFdPZFI5SS9OcU5iZ0R5TVJEc1ZRUVkwa3Z4?= =?utf-8?B?djUwZXN0WmxoRkZNTG9UQU1hTkRNakNYaGFsQms1QlVuaFVEanFkbllnMzd3?= =?utf-8?B?cEpZNlVSQTJ2NmlRMmppaGcvcFhkZ2Z6TCtyVlF6TmViLy9hcFY3c3FhbjVE?= =?utf-8?B?U1FQQ0E2aU9TMnIrQjZJVG9vNVZ5Wnh4c1B1ZEZ3L0MyeGVpS0wyQXk4aWg0?= =?utf-8?B?TzF2aEloNjhxbzBpRXIzd21QQTdDazB2d1VFeEVMN1JhdEM3aWdtSWdVUzRE?= =?utf-8?B?bVpyd1M0dXpHSnVONS9Udmtna0tUbjJUdHNYdWFXSzFDVjFYMXd3WXZhQ0xO?= =?utf-8?B?WWJjMEUwS3hrbW5PWTZNd0RVVDRCY2lkMXoyV040UktnVGpyYThJRXZzbSs3?= =?utf-8?B?SEovVTFkMjBNSERSMUg1KzhPT2h1dXlvZDk2Q3NldFBjKzB2cmJsanBsajdM?= =?utf-8?B?aFVtaDlwOUR3L0lMT3ltMGFyMVk5K2FHKytPeGZlY2RncDVnYlplOGwwUVpH?= =?utf-8?B?WjRhU1NJQXdUb2g5MzlRTXUyeEZseElvSnNOL1h3WHY1NENMREtzOW1PdE9z?= =?utf-8?B?N0s3Y2t3aTJYcjlZdW9HeGprMkF1WkpEZXZrb3R5MlVtUHg3NnZsRzY4N1la?= =?utf-8?Q?QBP5t8u7qgd8rwnhNW4aU2U1H?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: b886b6c6-6e15-4515-cdf0-08db6b3aa47c X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jun 2023 11:46:21.6682 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ftxTKhRU7ShBGZ0fgaiRi1IUAKzVMDjTlt6cjH/4Wqm1TsSOmzeZ8BopzhCb3u4hSDYISFseHi/e2l6L5P+QaA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9424 X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1686570406619100001 Content-Type: text/plain; charset="utf-8" The variable needs to be properly set only on the error paths. Coverity ID: 1532311 Fixes: ab4440112bec ("xl / libxl: push parsing of SSID and CPU pool ID down= to libxl") Signed-off-by: Jan Beulich Acked-by: Anthony PERARD Reviewed-by: Daniel P. Smith Reviewed-by: Juergen Gross --- If XSM is disabled, is it really useful to issue the 2nd and 3rd calls if the 1st yielded ENOSYS? --- a/tools/libs/light/libxl_create.c +++ b/tools/libs/light/libxl_create.c @@ -1081,13 +1079,12 @@ int libxl__domain_config_setdefault(libx ret =3D libxl_flask_context_to_sid(ctx, s, strlen(s), &d_config->c_info.ssidref); if (ret) { - if (errno =3D=3D ENOSYS) { - LOGD(WARN, domid, "XSM Disabled: init_seclabel not support= ed"); - ret =3D 0; - } else { + if (errno !=3D ENOSYS) { LOGD(ERROR, domid, "Invalid init_seclabel: %s", s); goto error_out; } + + LOGD(WARN, domid, "XSM Disabled: init_seclabel not supported"); } } =20 @@ -1096,13 +1093,12 @@ int libxl__domain_config_setdefault(libx ret =3D libxl_flask_context_to_sid(ctx, s, strlen(s), &d_config->b_info.exec_ssidref); if (ret) { - if (errno =3D=3D ENOSYS) { - LOGD(WARN, domid, "XSM Disabled: seclabel not supported"); - ret =3D 0; - } else { + if (errno !=3D ENOSYS) { LOGD(ERROR, domid, "Invalid seclabel: %s", s); goto error_out; } + + LOGD(WARN, domid, "XSM Disabled: seclabel not supported"); } } =20 @@ -1111,14 +1107,13 @@ int libxl__domain_config_setdefault(libx ret =3D libxl_flask_context_to_sid(ctx, s, strlen(s), &d_config->b_info.device_model_ss= idref); if (ret) { - if (errno =3D=3D ENOSYS) { - LOGD(WARN, domid, - "XSM Disabled: device_model_stubdomain_seclabel not s= upported"); - ret =3D 0; - } else { + if (errno !=3D ENOSYS) { LOGD(ERROR, domid, "Invalid device_model_stubdomain_seclab= el: %s", s); goto error_out; } + + LOGD(WARN, domid, + "XSM Disabled: device_model_stubdomain_seclabel not suppo= rted"); } } From nobody Fri Nov 1 00:31:15 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=suse.com); dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=2; a=rsa-sha256; t=1686570426; cv=pass; d=zohomail.com; s=zohoarc; b=DRk83uvtGcE5CN7mPqD3/+FfproUreryATxUzfejytumiGlJjZ1XDN7fm/WHrlN4XQ/8LwbcSffqNM9gMa3BidE+mRtN9XaWJ2ohmQ7WRR7KEnBtdsNBBQXzctYIzbYEMoygqclXCgbEn1cEJBFuRTzTOywQegRKACAl0/YKI44= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1686570426; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=rPVECL3iX1325C06pRAn0RbvmreO2AjYKQ1yM2vVRJ8=; b=jtWd2659zz2/12/McfzB35VtckH9HV2RkgMb8lOh/YgGasukfla34ML89eea7rC8dNq22ABX2nf8JpqsIiBeWgYUzjQy+EHNblnF+53jlgFjc8l/3nmS04ch2tcG1HaOv7tqvTyfDtcy6qGyDBG69Ip1AJLaz9HBYmy1NrHBVdM= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=suse.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1686570426073440.1073579377578; Mon, 12 Jun 2023 04:47:06 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.547063.854261 (Exim 4.92) (envelope-from ) id 1q8g0T-0000B7-Uz; Mon, 12 Jun 2023 11:46:45 +0000 Received: by outflank-mailman (output) from mailman id 547063.854261; Mon, 12 Jun 2023 11:46:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1q8g0T-0000A3-R1; Mon, 12 Jun 2023 11:46:45 +0000 Received: by outflank-mailman (input) for mailman id 547063; Mon, 12 Jun 2023 11:46:44 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1q8g0S-0008F8-7B for xen-devel@lists.xenproject.org; Mon, 12 Jun 2023 11:46:44 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on0628.outbound.protection.outlook.com [2a01:111:f400:fe0e::628]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id cd3a102c-0916-11ee-b232-6b7b168915f2; Mon, 12 Jun 2023 13:46:43 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB9424.eurprd04.prod.outlook.com (2603:10a6:102:2b2::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.33; Mon, 12 Jun 2023 11:46:42 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e442:306f:7711:e24c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e442:306f:7711:e24c%5]) with mapi id 15.20.6455.039; Mon, 12 Jun 2023 11:46:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cd3a102c-0916-11ee-b232-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=P2z65NHZLHfHzPGCAaoJqmkwopKeWpZen0NY99NV8MNrBvKSxWzhbSm8iSIJUf5XNlNJH6KrsiGWIu5ZMxQXuPzr/ikF/5jio70MCwLdCXLRrv62FHLHYet/7pfrzTsKtfor8vKpSkAodyXqwy5FsdYLkQddIBkRKhNzTHUMkN5U4bllZB4wYY7UWi6JKGNChwLca4oCfFYQLK8tbuBjp3d62b/kNfF4WVe23FihmuEmn0w37wCiXc0sIodAVw2n0X1eTXnoKxgY/d567MLKYEPeGErJCsJ/FMJvtiUys9/DQb2WGG+DRLhRy+4q5ClzHPP00xqOI8BaJ3cBbS8SRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rPVECL3iX1325C06pRAn0RbvmreO2AjYKQ1yM2vVRJ8=; b=Hb4EbkjUfxA6eW8v6YqVI0lcy8GneIngjRiI0Ypb5Z14bv9DNLRZ/+rFsw+Wb6W7BmBU3HXLaG1QzwzRmtgyjcaVvUU2Gko9exWNs5ST+8zRi28jU24vVElYHUPc54I31o7LM55z3Xudun98GWPeP5zGEqkWWooKxq8GQL6CaT+J1sdO0WYeV6HPN7PiOP2JCrx6TW0J40dXcfcvvNxWWcaSgfWp+RyYPzGqXHHS9Ycw2fwWPzuB0pE9JAUZBPFzE+zEtZ31fQhLH05VDv5ekfcGW79dvQMp+rdT1NnGOv9/yfhFby1/YLL42ZAcFIcU3Y2qP6ns4NSnF/rcdlHFJg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rPVECL3iX1325C06pRAn0RbvmreO2AjYKQ1yM2vVRJ8=; b=3uTip3c+Hntan0MmCkFCY9GXmpA27MUEZ0tmcnb7l/S98uqt8YiW5C+QZ4eTQzENtRWDFs85Yr3Yx3Og3U28bhdgAUmhhq86RXsUY6RMJwfqzdjppSSan0GwwMRkE8RwG/xULGcQ6Vnvt2MU0mG2GXFqzTQfs/C2Bid7kmlDcdr2tfh/LPtlQGdLE+CbQx3KkjCyr08UGOJiDNE7UzQPVGl1VGeY9KpIuQEX1v818CaClYFDc8zBtJkIUsUHj1S9huSZnZ7y9JtqUdLj58IbkdYdIZSDaidpcLveYsC5XYAEDAJVxDGGRY5EIAb2PFjSCd7b0iKX8xeHL8m4ImQdww== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 12 Jun 2023 13:46:40 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: [PATCH 3/5] libxg: drop dead assignment to "ptes" from xc_core_arch_map_p2m_list_rw() Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Anthony Perard , Wei Liu , Juergen Gross References: <2dc50b58-a4e4-3e32-1876-94412b14b052@suse.com> In-Reply-To: <2dc50b58-a4e4-3e32-1876-94412b14b052@suse.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: FR0P281CA0172.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:b4::14) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB9424:EE_ X-MS-Office365-Filtering-Correlation-Id: dbdcf97e-575a-459e-318d-08db6b3ab0be X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dmzPkbX53d/WwDSxNKurA3qeSA/VaGO/h5QllgK5+u2QFoFOiNErvfrycOxP+5Ruu7Bzo325I7Fc6Fi1qS734r6Ta9gb6mJW8Ga91WxprE/p0+uVSrkgzaTkTh0lL2TOYbgC+SiA0vlz/KTSHPxNbrR20wp4ak1lZ8rXqLNbPu3ojZ06Z6uw/kWWQhro6/yxn+uzIzkMEnsCYA3ZerKNH1rSmxIZX89xE6blLHyOYSgkRCyWufrPUd154upPTLmj8DcU85d3BdqIjQzAvo5tzqWUXfuW3puSzAAASz2m3ChdV4XD/V1fzc8bhZoCcTgmP26epmYLASCgnS4tHKVQQ2cEvVYLuccEKEFMH12HWkIihf0eLAC05oBdgK+8EFEbtVqESr+F4DGrCGqzjLq5vAVHX2llSglyKxKLLVO6gL1stUH0g1lSM7Bp9zxB85ul/jnVGUfLQ8hVhmfa5EAkPe9M4o2hLKI5E2Ofisg8BIUJy8AEd3Ci6nncNUD6vAPC6wU9U74GVvJwnoS/ONBVMtRm7rjzb89XH8BEimBLgFPYv6YwzPDAw/m3Doza65eg4JmQ/DobUIdYlvx1Im/SHouua/+xOepqFhuPQuVGp88YdOZUzfFJs1tHNPNCpvSyQssunFKO1nxcL5UK4P6duRIPuzS753e2caZbJWE1fkUFLLxqK4AEgsQQl9zyHxa+ X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(366004)(376002)(346002)(136003)(396003)(39860400002)(451199021)(478600001)(8936002)(107886003)(8676002)(54906003)(6506007)(5660300002)(41300700001)(316002)(6486002)(66556008)(6916009)(26005)(186003)(31686004)(4326008)(6512007)(66476007)(66946007)(2616005)(83380400001)(4744005)(2906002)(38100700002)(86362001)(36756003)(31696002)(70780200001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cC9hT2RmcmEzdm9KL1FwODhjRnVoeEFyRkZVSWEwcC8zQXRKc3pLRWU2SHJk?= =?utf-8?B?MUNSMzdHc25nVTFwRTdBcGpweFU5bWdKN29KN2lxZEU2dTlkYkVwWXJmMngx?= =?utf-8?B?QkoweWUxVjlIc1dTYVFVRDd3RDl4aDU2R28yS0RqSkpOV1k5NjA3YWt4VWtX?= =?utf-8?B?WUFKUkFnREl6dyt1b3JsUDFRTUJEa21BN1lZV3JZSTlrclVaV3Z4RHROWE5V?= =?utf-8?B?cEgvcXBOWUo2WVZIWndab3h5U2FGaHpRNnU3Qk5EbUNGdXBGK3hpS2xWMEhr?= =?utf-8?B?bGx0cm02YWV0YUZZOXhGd1NZcVg5Wk82SlBvczY1RGNodHBKYldMZGxtVGlp?= =?utf-8?B?TXhISExxMlplZ1NXdXI0clRwMG9HelZUUGFKTzVKWVNpa3NuejBRaUhOMGd6?= =?utf-8?B?cUk1RGhvNzBnRjlWblI2eXpIdE5Cc1VVVWY3MCt2WE1tM1lvKytrbHFNMFV5?= =?utf-8?B?UmUzRjFkdlFSN203d21SUXl6Um93V01POFFJdEFGVGNXZzJsR01uQ2dWcURl?= =?utf-8?B?bGpRT3gzcHdkSmpDL3h0NTl5U3lma0pSZmJQS2ViTWp0U3N1cTVBa2Z6dWs0?= =?utf-8?B?ZDAyYVdlVEUwdnRVYlBodnhMZUp2WGN1WEV4SWs4YnNZWW9hY2xyZjMzRjd2?= =?utf-8?B?MjVBYVFuYmtTSjRaajdoeWJhN3pEdEhaaE9jcC8xa1RYN090OWxJMGJvaFFR?= =?utf-8?B?c3FQSU9oV2Y2NnJtZGh6NWNQN2VWVjVGdnpKa3pDZTI3bi9xWEhoYmpHQ21s?= =?utf-8?B?cWI3RXphNkdPa1BuNXBGMFJiY1BCUHN2NmJOYlZiTnNVbG9OV055QnJqWEpI?= =?utf-8?B?ZjhOMDdiN0VVMG1wdXd2YXRRN2tlMlZ3ZUdaRFFjMWd4RTJXKzRaMmFzcDVx?= =?utf-8?B?Y3NYTnJ5RlFpa1NXMHA0alpHakJDRk5ZeEo4ZjA3aFZjK2h2QkNYTlptME81?= =?utf-8?B?ZzB6aU4xSGFscjN4a3Rpem8zQTR4SVdXdkpQMmhmZURnVWlxdmM5QjZaNkU0?= =?utf-8?B?MzRMb20vek1UM1B0RlVnckVZVndmTmpZWEJnbmF1VkVhclJzUXdhYXg5VGRW?= =?utf-8?B?cDRoN0NLWWR5MWxaTWgxeTAxdlNIWEhVc1FMT1F3cFVvUXBtNzZNY2ZFRHZo?= =?utf-8?B?TjRPKzl2NmRZdjE3aFpGRGZ3YzJieGhGdkM5T3NnYmYwVEd0TnlnTExBWEFR?= =?utf-8?B?M1krd1ZIV0dNdnFib0t1YzdhL0E1SE03N1hQa3ArU3loUXBRVHViUWFib2tE?= =?utf-8?B?UVF4WVZEaURjN3BZclZhYVZueU5sd0lPZlFVQnlLamovdVBlaTBZTnVIY2do?= =?utf-8?B?UDZiTEtadS84SDlmQmRHVEJTT0N4OTE3NHNWWkR3Y1B3b2I1WXR4RlNxS2VY?= =?utf-8?B?bTI1VUJONityZm1LVmh4VkY2ekZRVGtLTkdGMFRyTmgrMnkvMkI3MlNLQjll?= =?utf-8?B?NzZ5bGRCQVQ5Tkhodm1ha3JPaTY2SWVud2RyS0JuZUpURlFmeVZCY3VuT1la?= =?utf-8?B?ZkIyWXViM3FMYVVKY0x4YTBVcytxOGhFOEtnZXJIeHluQStlYVFOUEc4d055?= =?utf-8?B?djZCNWZSTkpjNTloSEZ3d2pld3hNM1RSZ0hqdkZzVFdONmRPUHlnamlnbEU2?= =?utf-8?B?RzY3MW52VHh5NUJHcjJLV2dMQTBxWXRkN3VLYU50UjcvVTJ2TnZEeXREcFZ3?= =?utf-8?B?aEJUV3cwMFNUN2JUdzM0TzVwWWxCQmo3M0lWSEdlbkV2STNqT3NVQzQxU3dk?= =?utf-8?B?dmZkVTN5S25YanlNSmNUb0pqVkdrQUEvY2UwMWxLa0VLa0QzeUs1ZHFxUGQr?= =?utf-8?B?Ky8yV2hnbWFITDFoc01BOU44RjFKVHhPYXljQWFibEpsQ2toQmlPdjZSZGpR?= =?utf-8?B?RWFNMU92Z0RCNWVXalJpdklDMmJLVEllL1pmZ3pzTDdSYnlVKzVwQkh5b1Rl?= =?utf-8?B?emZsajIvYlF6Zmw3S29WdnROTmVIdmFNbDBGS1c2aFdxQklRTnE4MUZwaEhh?= =?utf-8?B?ZkNXbkVKV0Y0K3dBSGd1N0JSRzdjZDY4TmYvMndMTUFVYWNjVkQ1MDA1Z0JO?= =?utf-8?B?dzVtZWtoVGRnSGxza0w3bXc0OEU5czVueC85Z2ltU0V1TTMzaHBFM1VMQTZx?= =?utf-8?Q?tjIMk8+uVFQ+J56ZYc4obFOjy?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: dbdcf97e-575a-459e-318d-08db6b3ab0be X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jun 2023 11:46:42.2189 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: chZI6/Z//fRkk4+b/7Hm0CbFeNURtfK+8CT/r9k2Hed49sL6V1eYZRbJHuf5x1fH9/9NRFCUztb5J99RUClfyg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9424 X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1686570428229100001 Content-Type: text/plain; charset="utf-8" The function returns immediately after the enclosing if(). Coverity ID: 1532314 Fixes: bd7a29c3d0b9 ("tools/libs/ctrl: fix xc_core_arch_map_p2m() to suppor= t linear p2m table") Signed-off-by: Jan Beulich Reviewed-by: Juergen Gross --- a/tools/libs/guest/xg_core_x86.c +++ b/tools/libs/guest/xg_core_x86.c @@ -210,7 +210,6 @@ xc_core_arch_map_p2m_list_rw(xc_interfac } =20 munmap(ptes, n_pages * PAGE_SIZE); - ptes =3D NULL; off =3D p2m_vaddr & ((mask >> shift) << shift); } From nobody Fri Nov 1 00:31:15 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=suse.com); dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=2; a=rsa-sha256; t=1686570453; cv=pass; d=zohomail.com; s=zohoarc; b=QgrugE6tQyooKUw7jGa6fFBt/7IVDnXI7la3ThBoolDaE7aSWYGD9Rmx3aBnQvZzaAJZpXVGlTMRdwdVDuft0AZLy38bpkrud8HRSqcRmOxgFocLXhwQKJF/7t5f5Hoosc0k/sz0ym8xPiF+har3hefs2sJEs2XYkbmIey3XoYw= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1686570453; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=B+/y/m3EuaFu5IzJQsr10ANAsj4GrJLsTnjbxyCCt7g=; b=Cckq0N5mCvHkVegE1dnkF384CJu72nLA27syTWM2/tTqF85Tq+2a7WUmdZ4VbGJ/hBfZRpwqecoth4tDjw2JzK4je5RXdOnwK7QbMamPCbnvRNZhyr7A/R/7vd2vtWrdpZjxWTYVdzf/UKlLRHEtA7lyM64DEdhZgpYhuLKl7rM= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=suse.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1686570453267715.9828391465066; Mon, 12 Jun 2023 04:47:33 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.547071.854271 (Exim 4.92) (envelope-from ) id 1q8g11-0000t4-77; Mon, 12 Jun 2023 11:47:19 +0000 Received: by outflank-mailman (output) from mailman id 547071.854271; Mon, 12 Jun 2023 11:47:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1q8g11-0000sx-4N; Mon, 12 Jun 2023 11:47:19 +0000 Received: by outflank-mailman (input) for mailman id 547071; Mon, 12 Jun 2023 11:47:17 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1q8g0z-0008F8-Qn for xen-devel@lists.xenproject.org; Mon, 12 Jun 2023 11:47:17 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on061f.outbound.protection.outlook.com [2a01:111:f400:fe0e::61f]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e13492d9-0916-11ee-b232-6b7b168915f2; Mon, 12 Jun 2023 13:47:17 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB9424.eurprd04.prod.outlook.com (2603:10a6:102:2b2::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.33; Mon, 12 Jun 2023 11:47:15 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e442:306f:7711:e24c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e442:306f:7711:e24c%5]) with mapi id 15.20.6455.039; Mon, 12 Jun 2023 11:47:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e13492d9-0916-11ee-b232-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jroH4RQ06pKYUqUL/tSj0ZPW84WaSBvwaZOwhLDIX+igvk91SuhBMRIreM9Ul5yZ5xLMfXxlOqHL4xlMR4x7QX0xq+KXKj/vjpovO+Izvvkxm7mcMvUm7vX5a6dewThZQPUYSdTxDJMvmwzzldrYVXUcGDyz1d2wvmrhaqyoSocr0nr4Q6xMoc8At4vWfnP65KJnroDAasMANJP/KbIB1RSoS6OjotDMO/oKN3gGmSXgnXQXEcIqdf7f5nKeat6aJ1lty6T/FPXq6CaQuCXHfGsi+Pmk2VR/Ax49NbX3z7HF9ufbmDEaXn9wWk+kSVcxd4XFAf0PkwoKkmAZ79Dkgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=B+/y/m3EuaFu5IzJQsr10ANAsj4GrJLsTnjbxyCCt7g=; b=KhQDCSOp4CWzl7HCJ1xAJ7Faru+4+vUploMMs7So2jQfup+2Ws+FkPHs0UmwWOUURZ7YVDZHb9WM9HU45o3v1D+qmT0WrPjP7T5uxkSxlA0SwX+K2t/uJzTpA9tPDqTobxF0yyiMQJF3Z98MvzsjAsjqs+mi3AHtWtizCRei77s21folNqu7EeMo265BqSuneZICW+NNZbgG255LRnyRDJ+evEC83WP5nUhu79OngS3mRxgCVSAymnYyTB5XJJZhunhvJC/mEJhtK1MKmYCNUMI/TyQT4tK1I42s1IYCwP0gDoTYE8u+249voX0ssif6P3nNWcL8ifJhfPQBqiDnhw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=B+/y/m3EuaFu5IzJQsr10ANAsj4GrJLsTnjbxyCCt7g=; b=yN21UeDhi+eBaZqW5aDN7U/QlSnQL1POm/nzZbnoSsT+tXiqrOySiYyZDbsLgN8HEJpxla7p7mfARXVINRZKNljiuiZOnKj1Q3I7l2kYZognoMRSv0AVLIWUPWNN/ssXtYCxSp+EtBjxPUPvBzXbPxkDoQUs3MtmjeR0NfhJfCmKWVTfJhjFceulxrp2AZ3zFdWb6X4cqU9SmbCCLWmxtC2Q0CZVl1oJIIR+LFdmSt5dlPIxGlfoTBNxiZjZy5YataXV9i0P5zOEAeGQlTvBSbS5j7xnCd/R1OPSbK8hoc5R7tNzdXSj+eVx46ZPdcUqvEackny71gsx/giWKjWn6w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <89c45e29-fa7e-93e9-a2d5-45991c302794@suse.com> Date: Mon, 12 Jun 2023 13:47:13 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: [PATCH 4/5] libxg: drop dead assignment to "rc" from xc_cpuid_apply_policy() Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Anthony Perard , Wei Liu , Juergen Gross , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <2dc50b58-a4e4-3e32-1876-94412b14b052@suse.com> In-Reply-To: <2dc50b58-a4e4-3e32-1876-94412b14b052@suse.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: FR0P281CA0083.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1e::18) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB9424:EE_ X-MS-Office365-Filtering-Correlation-Id: e37195fe-b498-47f9-bd37-08db6b3ac45f X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: DxZssvo65/JcAV/t6goMFqjIykoss3/7Kx4/GehuaRJZZ/BqcX6ivwPuXHvftBHLNTH0AuA2KcqATj0F1S6U+QQX8k32pJglA14dNA7AZsx1pgo+vkLvlFU/ht7rziJ/g9Ag06UmC+bNxvlUEah+jaOXg7SGA/bLl+D6H1XAhLquKzVpqJVpo+3rBsIqOuCxnIIO4VWBF4spHQxJGU7IoJ7l9fMYe7Q2uzD71A3uLWIHSgksAtH6xCST+gZLSWPWrv8l1lsylsPNgaEuC8etQtUGtRtgZJud74zb7YNWsoTLMPS5ORqbxgMuJ3yPoAozsZRUYGe0xh5Vvu3Te+0oSh8u3MJDP17wlSPLW9RrhxHG6FljTD53Ey+3kxriqrMgq1GLAYVKgXgRc1oXE+KcarJzxqdm3UUZ7NV5fJCn6Z9WeTx9H2EjDY5iF4Z15asH57pV3T39c0m0PbdMERc956tWcXXVAVluE1HQwOYX/DRjWSIqMFm/0SQdO4yPP89nLtVOTZzNj7aOtlKaTHK+n2r3VY7TvN9AXOeqamvPzjMyhOImRFi/ApUTLvHp9Plo1JmnlAZmTtxnJno5Sf3rqhHL+jkskrCs3sR2pAX0zi4LrXHk8tbh/0seTufIJgqk0G1KFHBZ8ZjfSlnSxgszwQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(366004)(376002)(346002)(136003)(396003)(39860400002)(451199021)(478600001)(8936002)(8676002)(54906003)(6506007)(5660300002)(41300700001)(316002)(6486002)(66556008)(6916009)(26005)(186003)(31686004)(4326008)(6512007)(66476007)(66946007)(2616005)(83380400001)(2906002)(38100700002)(86362001)(36756003)(31696002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Z09rMnpQQXFWU2hQR2Q4UUVOaU5rZkpiSXBwQzNHV2hzbnpmYzNVdVdaRDZj?= =?utf-8?B?M1duVHdwcGhFemFWcy9aek9aWnlHR01XeWs2RDkyYkcwVnUxd1NnMnZHdjFP?= =?utf-8?B?ajNiZkpXdHBhWTBvbmJ5MWdZaGVyMFZqaU4xSGFTZ3VIOEhJOHlDZTBQOHJF?= =?utf-8?B?dWNObzVrOGhzUHdRSGp4VUVrNHFrRnM4Y2RmbDJ6NVBWcTE4N2lFaGljclFR?= =?utf-8?B?Q0NSbU1VVlpCUlVValYxOGxQU2xQRHFVRnVheG45bjBuS1NoOVZ5VVdkQnBX?= =?utf-8?B?ME5zbkt2eGhIZ3ZQYWZsWFVqS09aNEM5VzVCeEEyV2VqZ0JlMURBQ2FvNW9w?= =?utf-8?B?c0NTQ0IyMmk3OVQ2Wmd0Zk9qaUdhenhtUEJ2c09ia09kTFVqUzNZZWM5YXlu?= =?utf-8?B?MWZCRTBQbFBCSmxJUU9jSFAzTzU4NGpMTzBrdG5TQ3VBTFlXUTBEZVlFbS9w?= =?utf-8?B?VWpGbGlmRWlvWStlc3BLTXEwemZEVmFQR0ZTekMrcHI2K3VQUFRXblJweEVR?= =?utf-8?B?SmpZQ00zcjIxMXc4ZEFwN2Y5SHhDRUg3WWhraEl5Qk5yNTNEdnJrSXc4RktI?= =?utf-8?B?dWpaMGR0VFlyMk1ZOEREWlpnNzk0UXY1eUcyOGZsZlRYdHpQUFJmcUhGM01M?= =?utf-8?B?UW5DUytObHpIbThEdDJoTHJYWit2Q0dHUFRDQ3U2MGt0dmVyM3hGZ3V3RXdn?= =?utf-8?B?NFI0QmZmc3BpUkVKaFlvTUl6L09wSmllSk5vQ0o5WmpDSlFSOGxNeTJORWQ5?= =?utf-8?B?Mjd4Vi96NlNWWEVZbGVtKzBudVRSTWFzVmZEQm9OY2xNK08rM2kzVTZVY2Va?= =?utf-8?B?UzlRSjJhK2dxcXlrMEJsbzFvR2lQQjNnZ1d0WjdhUGkwbmZGN3pGTkNOb3or?= =?utf-8?B?QWRyNUQ5REc1TGJWSUFidktkV1JxSzJpVGNWUDVmdFE5aEJ2bVE1bUdoOERi?= =?utf-8?B?dDVFZnBTemdnbnZldW13OVdsM2dCN01zbHFvYytIek03aGVpYjR0VVVlR2wv?= =?utf-8?B?OXd6L3BXOTJZR2RPSGFyNU9PcmVpdHphMnpJcmZXNndoZ1NPSWNXQmRHTjYx?= =?utf-8?B?a294VkN5ZU5vV29qb1BDdjRZN3RQMC9iaFdJQ1F4Z0Fuem5uZ3RIWU9iZEtw?= =?utf-8?B?TGhOSkhwWEliMEdic1AraW1vVEZPMmlMclgrZlVhdldkdEM4MVZlOStaSVZw?= =?utf-8?B?QTE3eW5VSlRSSmd3NVNUU0tYcXdIQVg1RHlaVTcrSDBXTkN1M0trMlR5T1l0?= =?utf-8?B?SDVYajFrdXVPZFhpL2RzNXlOT1lxbmU2TXc3MXh5T0dUdmsrYndwOStNS05l?= =?utf-8?B?ZjVrYWN2N2wrbXVNczFkbWtTUnVQVGdPc2s0dWc2c2MrWFdKTlIxbHpIU1RF?= =?utf-8?B?Wk1MYnB3T2lnM0lnbXRDUlZPdjQ0bjcyTXFMaGovQkdpeWdiNFh3TDc4cHJ0?= =?utf-8?B?WWNHQjM3dExHZU4zK25abW4zcEhnckp4SGtYaGxmY1JpTjlCQVMvdlRhYTBE?= =?utf-8?B?TkxnNnFtTHJJeHlQd0tGUVAvVzZwek4wSUFIZlhveDM5clFLSlZXeDhrSDRh?= =?utf-8?B?YWtPVmlRdXgweE1JTnVCcTNHUEUzTzgwQlh6WkRwVUczTkREYWx0OTUyTDZM?= =?utf-8?B?Ujc2VGRMeDJIZlVkVFZXMUZiWG5GVUNwR0ZwbHlhS0M2NmNQUUlrd29QK214?= =?utf-8?B?UUZXdXZNM3NJSTUxQzJoWkU3dW9wUDh5MUNWS0IwVWZ5c1NybkhEZkFIQitJ?= =?utf-8?B?ZXpiK0x1RXhKbEQ1M1F4NjI2M21IQ25rZjBMcGkwRHlUS0t6OGlxeUhQL1Uw?= =?utf-8?B?bW1oMkhMSEk2djRGNlNkRU5lSk1WN3lFUEpiSlJZYlc4Nlh5OWhRaWN2cjht?= =?utf-8?B?R01mSzVwdlpJVk4zbmh4QXd5Q3dId2x4cVNKUDdhMzVwc1F2SkRkUjc4RHJU?= =?utf-8?B?QUwyL3lDNEdMaTdHa0k5eC8xMjFMc2lIVHdrOXFnZlhUZklzUlBpdmF6SXp5?= =?utf-8?B?VzRQdWd5dEI3aHprYzRoQkw1ZVJLSUdlVVRxbVdIL0J5djY0UmFKZzRCeDBp?= =?utf-8?B?Q2RabDkwbXltbUdTTm5jMC93ek1CYkhEUmpCTnpOQVVCSVBOTkVBYk5qTXV4?= =?utf-8?Q?7gOCCbOKwVT6Jf1plObHl/Dke?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: e37195fe-b498-47f9-bd37-08db6b3ac45f X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jun 2023 11:47:15.1388 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: czparCyPdKRU4+qIQv2WeyjQCfRFeWQltMCb5SODLCg6++m+JPbnHPyiy7Qd53Al44frp8hKRJ5mhDCLUucV3w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9424 X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1686570455500100001 Content-Type: text/plain; charset="utf-8" "rc" is written immediately below the outer if(). Fold the remaining two if()s. Coverity ID: 1532320 Fixes: 685e922d6f30 ("tools/libxc: Rework xc_cpuid_apply_policy() to use {g= et,set}_cpu_policy()") Signed-off-by: Jan Beulich Acked-by: Anthony PERARD Reviewed-by: Juergen Gross --- The code in question was subsequently moved by 54463aa79dac ("x86/hvm: Disable MPX by default"). --- a/tools/libs/guest/xg_cpuid_x86.c +++ b/tools/libs/guest/xg_cpuid_x86.c @@ -462,17 +462,12 @@ int xc_cpuid_apply_policy(xc_interface * /* Get the host policy. */ rc =3D xc_get_cpu_featureset(xch, XEN_SYSCTL_cpu_featureset_host, &len, host_featureset); - if ( rc ) + /* Tolerate "buffer too small", as we've got the bits we need. */ + if ( rc && errno !=3D ENOBUFS ) { - /* Tolerate "buffer too small", as we've got the bits we need. */ - if ( errno =3D=3D ENOBUFS ) - rc =3D 0; - else - { - PERROR("Failed to obtain host featureset"); - rc =3D -errno; - goto out; - } + PERROR("Failed to obtain host featureset"); + rc =3D -errno; + goto out; } =20 /* Get the domain's default policy. */ From nobody Fri Nov 1 00:31:15 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=suse.com); dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=2; a=rsa-sha256; t=1686570596; cv=pass; d=zohomail.com; s=zohoarc; b=YuhcbyuFokvchV0FfVB1SjCn5UeINLyIqjALuSxhLDej8sZ0RmUTaUx5pmxmg9RoJbJv+IIHNTyDTCNLD+pFnfyWY8Xn3/wFq4NQRzF4k1Cv+9soLoG/s1MN69JBEXKnFRRLWHLjcCYz5RbtSXfNR3qh2Wmv3Kp54h9207Y19m0= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1686570596; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=AnyjzGqpglbOicW2phJjjVaeWkQi3azKxAQ6SvQhGCQ=; b=dlegD+nh0h2uEGMVeUYCaXd8QVp+261bZ1jkKGUfry+TMro98kAbRr5eP/NU2AkqSHLasiqPjhDK6VkmFqKiYDdTU8tNbzTYrfPfwDLaC/EI83yv0q61HO7JkcUe7g3sYB6BpkUk88Fnckfy4HsjjstFdyUEQX7IrXSIWuFuz8g= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=suse.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1686570596370755.5990276884346; Mon, 12 Jun 2023 04:49:56 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.547080.854280 (Exim 4.92) (envelope-from ) id 1q8g39-0001eu-ML; Mon, 12 Jun 2023 11:49:31 +0000 Received: by outflank-mailman (output) from mailman id 547080.854280; Mon, 12 Jun 2023 11:49:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1q8g39-0001en-Jl; Mon, 12 Jun 2023 11:49:31 +0000 Received: by outflank-mailman (input) for mailman id 547080; Mon, 12 Jun 2023 11:49:30 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1q8g1Z-0008F8-Ps for xen-devel@lists.xenproject.org; Mon, 12 Jun 2023 11:47:53 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on062b.outbound.protection.outlook.com [2a01:111:f400:fe0e::62b]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f6d36afd-0916-11ee-b232-6b7b168915f2; Mon, 12 Jun 2023 13:47:53 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB9424.eurprd04.prod.outlook.com (2603:10a6:102:2b2::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.33; Mon, 12 Jun 2023 11:47:52 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e442:306f:7711:e24c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e442:306f:7711:e24c%5]) with mapi id 15.20.6455.039; Mon, 12 Jun 2023 11:47:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f6d36afd-0916-11ee-b232-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mvLXPY/UuRVEiZdNmc2i9Bd1VhMS8sZM+1rwYaMMAXyFErAUi5kxH+Bc9firnll8L4Pc+2ZKZr7gJ4CpL2QiCdDNyPuncoX7VJ944aEnltfOw4v1PjH/jYldcIEb916qLJo1seoLzFUWRw8llPHCNVBW4l9kSgrvrmc3VgEHwaZ4fsqkCFmLH7CZm+jBMnRvxaRincOjjJT9QhMBLGQa6uom0ns3PufLPgwG40aqdHqCuy4UUaokf8O9dVi/ztn8ePn4d3yPiUWMr9Gn+aNeEF52aLGw6bCb4pDvL8eZYG75gURFqFzfhGEaJZDHK+w1srwqEi/TVWMWugA7HT+/fA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AnyjzGqpglbOicW2phJjjVaeWkQi3azKxAQ6SvQhGCQ=; b=kTV4tS7pn9l4+Jsr73aeYLmCk1/kTmWRsmZEnyTLrAs/u1H1Jrb6BAZnYDu8MtclYFudKcMMkD/DuKhmP+l6Oxm7KlzzpK/WuXgA/GNoR/JIw+sj/BqLOcO3VK4KZSAC5SW6DpdywAldU5gL3OzkmRd0+IQR1GCLNq3tCFLNEgJbpeMERwTpBQuqb3Cy8WOV31CcgG+MQdu7XvTOjBfQ+3aXoRVk9ypFYtvuHg2V9veMPM5XVtpLU/qZd3UQhwRzOVGLtxV1chnUeP/n58JtM/wI5ki2cOdp5VpkNDaVNFT5Qh2n6DcdIQ7FxP1g9jfQF1Y9xpwZdHWO610MaCvoRA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AnyjzGqpglbOicW2phJjjVaeWkQi3azKxAQ6SvQhGCQ=; b=WH0jUf9kVTjOvv5FGCnlBxFMSfGJh+32U90cokiWZwEx0vFb1n3Ua7TtZ5carbTOR9IlonlDeRoMTG0L0LZSGOz5MZhLiV/8RoCc59J44xdRrkMNWFnylMxH0+QvcyehVa6e+mOEVWRD+6+GwHC6sk8bkKVYCPhrus7xCk1UKQRIy7Vfyul9QClTkXgQ8tthMkRqL/gt1aNc6LbkHKXLji93H8+Y1RnwAKAmonjY7HIhV9jbmH8NBTd/wjkTyiS3oURiLyJ7a5CoOh5lkIGIgeB3NygHl3wbjOk/C9oS/Fpobv3vXNcHhdiEO/3ok0ToBR2DO0JBegVKB6GbbvxTXw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <4fcbe916-890a-1dfc-86a8-eef2bafb2801@suse.com> Date: Mon, 12 Jun 2023 13:47:50 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: [PATCH 5/5] libxl: drop dead assignment to transaction variable from libxl__domain_make() Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Anthony Perard , Wei Liu , Juergen Gross References: <2dc50b58-a4e4-3e32-1876-94412b14b052@suse.com> In-Reply-To: <2dc50b58-a4e4-3e32-1876-94412b14b052@suse.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: FR0P281CA0224.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:ac::10) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB9424:EE_ X-MS-Office365-Filtering-Correlation-Id: 94e28055-3421-461a-ab8c-08db6b3ada76 X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ebyXXuCzQdQa1HMgNpnvehe90sh/TgzZAZiHEjSmyG78toWYH8CvL554PN1tF8SfB6jeFvmXbIcvi9dQgaFUBTgM9NbqIwWqP0v6bOZHFmlC55jnvdvYd/VYy3xRkSHh+A02iiswwZ5GjQqqbUQGC6b6MwcPPvcPmRAQBpfIcaAS0ezOHiTbh8jbePHVlKg722r05uHUMX9fzWWfbXFVHvTigPUUbSfvo3a7dvXHbeRSJONsRxB//IkVHHBxNdvJQmcdsO5Qkd+CVHDD8lXieJoOwMolrT0rjrxLODvvlnDvx1ufzD5k51Dqp2t74EMdl0c1ATTVHqy86gw8T9cAn4YHnNujeI3PhDejHhso5Y36cNw2jTodxdDYIeKK3V5km1SZavl+0+34vXD7qDDvpu4psPj9olpPqu2vV63G5r9tASMYMl7+MpN47WB8ZUFaXAORfnuTBDsOhvZaV98ak4K5CX6bNq/N7leU3yjB1EOosftTMFDzna0DBsxwp/+FIvfKSYYc3vtHV3N4NRLp4Wek+l+0lGykOFABaoq7cPhxo+oPMJ1pIDPHz8g1lX7zl0F17EViPNWcBhh68CvxCKu+zF1cnM07P2nwralJRXOeVLsZQe//cTHJzHjw21imWwND7VW8OrK/EtuVZfbD1IjsVkwtsLlORonBuEijSQw3G/Iuq975bHGmGTPAUMDO X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(366004)(376002)(346002)(136003)(396003)(39860400002)(451199021)(478600001)(8936002)(107886003)(8676002)(54906003)(6506007)(5660300002)(41300700001)(316002)(6486002)(66556008)(6916009)(26005)(186003)(31686004)(4326008)(6512007)(66476007)(66946007)(2616005)(4744005)(2906002)(38100700002)(86362001)(36756003)(31696002)(101420200003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TTNaR1JTY0QycGJ2cy9Yb2FmM3hnQ0FrOWhVaTduRHlmcWkremt5T1M5V0hv?= =?utf-8?B?aDhoNEFqZG84V2h1cWYwVzVSVG1KeGJvUGpXK0dNUzhZOFhXdElYcW1QQ3h6?= =?utf-8?B?SDlKb2tQVlhVUGU5Z0gxNkdabXd1TzRRYnErTzRTUjdvcEI4ZjRxbUhUd3VY?= =?utf-8?B?V0JPdTZnaVhZdVZ6T1I3QnBnUm9TYmdBQk9QME1tT00yM21wRmR4Vmc1ZWpa?= =?utf-8?B?YkxmUUdGV2txbG9qOGNyWFA1NEw3Qkl0S05rZ2xQZWp2V0pMWm8vOWhQNzF1?= =?utf-8?B?Tmd6WDROSWJ4OE1hODlHbkYvM21LaFp2dkFCVThrdzluSmRvdXozNWk0ZEVV?= =?utf-8?B?MkVlbGZ1SHJYcWZPRXJMMHhaVThTRTRlVzN0d0ZtcjFBNTdGcjNjdGNBVFdr?= =?utf-8?B?Zy9PSXZWb3c3aHhuK0xyblZWZjdYaEpxQk05NDROWTh1cXNhdFA0VG15OFpY?= =?utf-8?B?amNmNDB5TEkySDFMV1F0dWh4UnpMbHFSU0ZtQzNERFJxdkpldHVVRkdBT1lz?= =?utf-8?B?YnFLTGxmWThuN0JhOE44VWFjK3MwSHhoOVlneE5pUnh1dWEyUGtBUzVSSXk1?= =?utf-8?B?eklicXpuN2E0NHNuWUNUKzNDdUNmaWpucC9aY2szelRHUWRHeTY1dUJCL1Jz?= =?utf-8?B?cG4zYkQwS1hpOU9nUnd0SEd3RHYwSXhUSlo4YVVSQ0xCK2gvc2FKVFp0YjhT?= =?utf-8?B?cXNySnZ0a0FoS0FJblluQWNpUmRxS2FUZFU2Vk5ZWGVHSzZldGQvd3BhTFVQ?= =?utf-8?B?VnRrT2tiQjNnTnVFSmdMdWtCSDlHOWJtNEFxOEJtY3NwNURrQUdXLzh3V1g3?= =?utf-8?B?S1dSUW1GaG0xMndSM056VzlQa3ZxdlU5ZXpoYWNQOHV1THZESEF6U2hYMmwr?= =?utf-8?B?RitTZ1dWR2ZZY2p4ZTV5a0kyOWNGY1hkcU1EdDdRSktVYnJvdnBtNUczU3hF?= =?utf-8?B?U0NiZXpEM2xaT3VTNmpKN1hUdDVWT2JxUkdYMnBDT0FGRzdRdWtQcU42MmpH?= =?utf-8?B?S2pGL0pzNnJuRFl6L1B0Zk1PM1cwcXZBRk42dHhOWHR2ZTJjbHFsY2tuOFQ0?= =?utf-8?B?SVlIT3ZSWmx2S0VHdE5oUkY1aW14dHRQbkdoYURRRGlSdFFSaFVqNEdtNWY0?= =?utf-8?B?aHIxbS9QQ2tMZWtPSW41cXBOS2cvUWpacE5VaGFzMWFUZTRNUm5FeGZtSFhD?= =?utf-8?B?bFNtT0ZQYnZ3Ymp6OTdCN3lMbmNKcnFJcVk3RTZHOGt1bkljYXNySW9aNkYz?= =?utf-8?B?VkRhVlovYVhSclQyRDhJUnZMMy9QcWZGQ1RJUE9idkw5Q1VYWUc1N0V4S1ZV?= =?utf-8?B?L3B3ZEJUdk42QlE2amRBNUxEMGcvR1VCL2FrTEFQV1YwSE54RFdXQkFmNjJr?= =?utf-8?B?SVFQcDMzbFBBWkwrUzZ6dmduc01aTElLSFdiZlZvNUJ4UmgzeE5wM3IwSFlW?= =?utf-8?B?TElYaXF2Z1Jvb0FzM0xvYXFaTlcvWGw5R3IvT0FKZEpKenY5WUZEb2F2eVl0?= =?utf-8?B?dHQ1T3ErY1dnT00yRUZQTnZ3M01DeDNncCs4UXN5bFZGcXdUTmFoNnBuU2NI?= =?utf-8?B?c0dxcnBZU213M3M5L3hkSzNocG0rR1h5RVYwb2ZNV3hiTFlSWTBVY3dXN3JY?= =?utf-8?B?TU1pVkJtcFdrUmRISUlJaGhuVFdQSEFiSUF1b0taR2RYSDlVc3NYUHRURjYx?= =?utf-8?B?dkdLVll4djMvcEl2OFpKMmZ1NjNCUGIwSDU3SEhrWUwvRlc0bEZoU0hXRkgr?= =?utf-8?B?MUxJWGFESU4xSEZ3b2pud2VzUWlwWkkwRFRhTllEZE51cjFjVU8ybmU3a0NS?= =?utf-8?B?VnVueGdKWThFdUk1S3lQMDNrRmppQUdNcTAzMUhUOEZ2VWZ4eEUrTGc5R0Va?= =?utf-8?B?ejhtK2M1MEloYWpUWU5oczVWMFpZVGhKTGVwTHJYT1dnbVJvRjNmbCtNamlS?= =?utf-8?B?WU1meER3TkU1UHB0REFrd1d6SlpncUJ6akV0RU1RY0NudytJWUVzc1dvSE55?= =?utf-8?B?dVVpUHd1R0RmMnhXWkVVeTMvaGo0UGNlTWJwcXlIRXRBZjBhdTdsa3o3M0px?= =?utf-8?B?UnUvSUhDQXJNOWtQMG96cWhzdnlWRHo3Z0hZZEw2Q29ZYmRRRFB5QlRCdHRC?= =?utf-8?Q?Oer77vO44GL9Tm1Pk8jDT8pyC?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 94e28055-3421-461a-ab8c-08db6b3ada76 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jun 2023 11:47:52.1725 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /LFB5LatvAzoi92dNzBAzRQlOmd+sBQwVlqHq8s2NXFREY+h+P24OGSRwchp1NAQP+OrxcVfnlrMPspsPxsiRg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9424 X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1686570597490100001 Content-Type: text/plain; charset="utf-8" "t" is written first thing at the "retry_transaction" label. Coverity ID: 1532321 Fixes: 1057300109ea ("libxl: fix error handling (xenstore transaction leak)= in libxl__domain_make") Signed-off-by: Jan Beulich Acked-by: Anthony PERARD Reviewed-by: Juergen Gross --- a/tools/libs/light/libxl_create.c +++ b/tools/libs/light/libxl_create.c @@ -909,10 +909,8 @@ retry_transaction: strlen(dom_type)); =20 if (!xs_transaction_end(ctx->xsh, t, 0)) { - if (errno =3D=3D EAGAIN) { - t =3D 0; + if (errno =3D=3D EAGAIN) goto retry_transaction; - } LOGED(ERROR, *domid, "domain creation ""xenstore transaction commi= t failed"); rc =3D ERROR_FAIL; goto out;