From nobody Mon Nov 25 05:49:05 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1718892175852643.722004055012; Thu, 20 Jun 2024 07:02:55 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.744612.1151709 (Exim 4.92) (envelope-from ) id 1sKIN4-000080-Kq; Thu, 20 Jun 2024 14:02:38 +0000 Received: by outflank-mailman (output) from mailman id 744612.1151709; Thu, 20 Jun 2024 14:02:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1sKIN4-00007c-Do; Thu, 20 Jun 2024 14:02:38 +0000 Received: by outflank-mailman (input) for mailman id 744612; Thu, 20 Jun 2024 14:02:37 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1sKIN3-0007p3-82 for xen-devel@lists.xenproject.org; Thu, 20 Jun 2024 14:02:37 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id beec8c11-2f0d-11ef-b4bb-af5377834399; Thu, 20 Jun 2024 16:02:35 +0200 (CEST) Received: from truciolo.bugseng.com (unknown [78.208.165.219]) by support.bugseng.com (Postfix) with ESMTPSA id D86744EE0756; Thu, 20 Jun 2024 16:02:34 +0200 (CEST) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: beec8c11-2f0d-11ef-b4bb-af5377834399 From: Federico Serafini To: xen-devel@lists.xenproject.org Cc: consulting@bugseng.com, Federico Serafini , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Subject: [XEN PATCH 04/13] x86/vpmu: address violations of MISRA C Rule 16.3 Date: Thu, 20 Jun 2024 16:02:15 +0200 Message-Id: <2b08ef10fb4907255688d5fb38b5928e972407e9.1718892030.git.federico.serafini@bugseng.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1718892176175100005 Content-Type: text/plain; charset="utf-8" Add missing break statements to address violations of MISRA C Rule 16.3: "An unconditional `break' statement shall terminate every switch-clause". No functional change. Signed-off-by: Federico Serafini --- xen/arch/x86/cpu/vpmu.c | 3 +++ xen/arch/x86/cpu/vpmu_intel.c | 1 + 2 files changed, 4 insertions(+) diff --git a/xen/arch/x86/cpu/vpmu.c b/xen/arch/x86/cpu/vpmu.c index a7bc0cd1fc..b2ba999412 100644 --- a/xen/arch/x86/cpu/vpmu.c +++ b/xen/arch/x86/cpu/vpmu.c @@ -663,6 +663,8 @@ long do_xenpmu_op( =20 if ( pmu_params.version.maj !=3D XENPMU_VER_MAJ ) return -EINVAL; + + break; } =20 switch ( op ) @@ -776,6 +778,7 @@ long do_xenpmu_op( =20 default: ret =3D -EINVAL; + break; } =20 return ret; diff --git a/xen/arch/x86/cpu/vpmu_intel.c b/xen/arch/x86/cpu/vpmu_intel.c index cd414165df..46f3ff86e7 100644 --- a/xen/arch/x86/cpu/vpmu_intel.c +++ b/xen/arch/x86/cpu/vpmu_intel.c @@ -713,6 +713,7 @@ static int cf_check core2_vpmu_do_rdmsr(unsigned int ms= r, uint64_t *msr_content) break; default: rdmsrl(msr, *msr_content); + break; } } else if ( msr =3D=3D MSR_IA32_MISC_ENABLE ) --=20 2.34.1