From nobody Mon Feb 9 21:40:23 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1713885201573547.2353623120704; Tue, 23 Apr 2024 08:13:21 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.710789.1110249 (Exim 4.92) (envelope-from ) id 1rzHpT-00059h-Ag; Tue, 23 Apr 2024 15:13:07 +0000 Received: by outflank-mailman (output) from mailman id 710789.1110249; Tue, 23 Apr 2024 15:13:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1rzHpT-00059a-7l; Tue, 23 Apr 2024 15:13:07 +0000 Received: by outflank-mailman (input) for mailman id 710789; Tue, 23 Apr 2024 15:13:06 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1rzHpS-0003wh-1w for xen-devel@lists.xenproject.org; Tue, 23 Apr 2024 15:13:06 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id fb56fa57-0183-11ef-b4bb-af5377834399; Tue, 23 Apr 2024 17:13:04 +0200 (CEST) Received: from nico.bugseng.com.homenet.telecomitalia.it (host-79-60-221-62.business.telecomitalia.it [79.60.221.62]) by support.bugseng.com (Postfix) with ESMTPSA id 872D54EE073F; Tue, 23 Apr 2024 17:13:00 +0200 (CEST) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fb56fa57-0183-11ef-b4bb-af5377834399 From: Nicola Vetrini To: xen-devel@lists.xenproject.org, nicola.vetrini@bugseng.com Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, bertrand.marquis@arm.com, julien@xen.org, Andrew Cooper , George Dunlap , Jan Beulich Subject: [XEN PATCH 01/10] libelf: address violations of MISRA C Rule 20.7 Date: Tue, 23 Apr 2024 17:12:43 +0200 Message-Id: <250b556fc0516e4a20b24161dad3032e2ac3db80.1713885065.git.nicola.vetrini@bugseng.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1713885202806100001 Content-Type: text/plain; charset="utf-8" MISRA C Rule 20.7 states: "Expressions resulting from the expansion of macro parameters shall be enclosed in parentheses". Therefore, some macro definitions should gain additional parentheses to ensure that all current and future users will be safe with respect to expansions that can possibly alter the semantics of the passed-in macro parameter. No functional change. Signed-off-by: Nicola Vetrini Acked-by: Jan Beulich --- xen/common/libelf/libelf-private.h | 2 +- xen/include/xen/libelf.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/xen/common/libelf/libelf-private.h b/xen/common/libelf/libelf-= private.h index 98cac65bc50d..197d7a7623a3 100644 --- a/xen/common/libelf/libelf-private.h +++ b/xen/common/libelf/libelf-private.h @@ -26,7 +26,7 @@ /* we would like to use elf->log_callback but we can't because * there is no vprintk in Xen */ #define elf_msg(elf, fmt, args ... ) \ - if (elf->verbose) printk(fmt, ## args ) + if ((elf)->verbose) printk(fmt, ## args ) #define elf_err(elf, fmt, args ... ) \ printk(fmt, ## args ) =20 diff --git a/xen/include/xen/libelf.h b/xen/include/xen/libelf.h index 9ac530acc2a8..a0675a4dc352 100644 --- a/xen/include/xen/libelf.h +++ b/xen/include/xen/libelf.h @@ -288,7 +288,7 @@ bool elf_access_ok(struct elf_binary * elf, #define elf_store_val(elf, type, ptr, val) \ ({ \ typeof(type) elf_store__val =3D (val); \ - elf_ptrval elf_store__targ =3D ptr; \ + elf_ptrval elf_store__targ =3D (ptr); \ if (elf_access_ok((elf), elf_store__targ, \ sizeof(elf_store__val))) { \ elf_memcpy_unchecked((void*)elf_store__targ, &elf_store__val, \ --=20 2.34.1