From nobody Tue May 7 21:49:29 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=none dis=none) header.from=xenproject.org ARC-Seal: i=1; a=rsa-sha256; t=1635943638; cv=none; d=zohomail.com; s=zohoarc; b=cvJvWTiahMNeHi7jX1yh1OQaB5d81C+8y7ZAYt0f9hkXELRt+VfxEuC/9jUGlCMMdfJMlIM1H34jQq9JnEVtcvqIUNr+7jOfaG3mOaZcsonN02hgPUqQBotY52NRB9s6eUnk9pW46taBWEmV9c0Ysn4WcPBAJiZBIQOOvOy1K9Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1635943638; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=bNIUA9dwKv+xMM0ZEJqg8KAT93Z7eod3e2jfVLTn/2o=; b=EB035s0xpHsRffeuaeDlwYU/HcxNK1xY02vMbBh/yAEh1Q5dqnbxjGTy+2gvkfsOGfaotSm/pEeimkpJnvsBS//liJTZ8/85hxcYbwsXddkCsAvr5w32WYeZw3GqGqH7JEkgmdL/QuGoViVYn8rHHucQYtouUP05OIUqspoItLs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1635943638251211.41946871551147; Wed, 3 Nov 2021 05:47:18 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.220866.382286 (Exim 4.92) (envelope-from ) id 1miFfB-0007A5-Ny; Wed, 03 Nov 2021 12:46:45 +0000 Received: by outflank-mailman (output) from mailman id 220866.382286; Wed, 03 Nov 2021 12:46:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1miFfB-00079y-L0; Wed, 03 Nov 2021 12:46:45 +0000 Received: by outflank-mailman (input) for mailman id 220866; Wed, 03 Nov 2021 12:46:44 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1miFfA-00079s-9Z for xen-devel@lists.xenproject.org; Wed, 03 Nov 2021 12:46:44 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1miFfA-0000Dx-4t for xen-devel@lists.xenproject.org; Wed, 03 Nov 2021 12:46:44 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1miFfA-0004kl-3l for xen-devel@lists.xenproject.org; Wed, 03 Nov 2021 12:46:44 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1miFf7-0004FT-R7 for xen-devel@lists.xenproject.org; Wed, 03 Nov 2021 12:46:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Subject:To:Date:Message-ID: Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=bNIUA9dwKv+xMM0ZEJqg8KAT93Z7eod3e2jfVLTn/2o=; b=YSDMh/n8O3+Zo27T0NBgqxaPWZ thaAtUPWktIFeQYPbmfiwDQDR1HxlbrCcXc2CbDB4PwdE5QnjF13EnloJoa7vCYPZ63ET9vaC5sto V14ZvqYZ61mCKAFao3tAGQ/XkZBeim9hPSmjzxd5ud9EvfXBC2g8zbRqVOk/EU7ePYD0=; From: Ian Jackson MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Message-ID: <24962.33969.4127.546561@mariner.uk.xensource.com> Date: Wed, 3 Nov 2021 12:46:41 +0000 To: xen-devel@lists.xenproject.org Subject: [OSSTEST PATCH] starvation: Only count "pass" and "fail" as done jobs X-ZohoMail-DKIM: pass (identity @xenproject.org) X-ZM-MESSAGEID: 1635943640517100001 Content-Type: text/plain; charset="utf-8" Release implications: I have eyeballed this again and the effect is to treat some things as not starved as described. This may make some additional tests run but only in a good way. So, formally: Release-Acked-by: Ian Jackson From 4a62c669ba9d7635caeac02b0a925bb05199f72a Mon Sep 17 00:00:00 2001 From: Ian Jackson Subject: [OSSTEST PATCH] starvation: Only count "pass" and "fail" as done j= obs Date: Tue, 12 Oct 2021 18:25:59 +0100 The main effect is to treat "broken" and "blocked" jobs as not part of the flight for starvation calculations. This is correct for commissioning flights and OK for other flights. Signed-off-by: Ian Jackson --- Osstest/Executive.pm | 3 ++- ts-hosts-allocate-Executive | 5 ++++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/Osstest/Executive.pm b/Osstest/Executive.pm index d95d848dc..9d7c71369 100644 --- a/Osstest/Executive.pm +++ b/Osstest/Executive.pm @@ -1148,7 +1148,8 @@ END # to allow for slow jobs, compared to other jobs # W number of jobs waiting - strictly, jobs in states # preparing queued running -# D number of jobs done - strictly, other states +# D number of jobs done - strictly, jobs in states +# pass fail # tuning parameters: # Xt X when D=3D9 W=3D1, ie cancel one job out of ten # Xh X when D=3D1 W=3D1, ie cancel one job out of two diff --git a/ts-hosts-allocate-Executive b/ts-hosts-allocate-Executive index 4dfcd0cd1..19047d49e 100755 --- a/ts-hosts-allocate-Executive +++ b/ts-hosts-allocate-Executive @@ -846,11 +846,14 @@ sub starving ($$$) { # is indistinguishable from a flight which is at the head # of the queue for a small set of resources. return (0, "job $j status $st, don't give up just yet"); - } else { + } elsif ($st eq 'pass' || + $st eq 'fail') { $d++; return (0, "job $j status $st but no step finished time!") unless defined $fin; $maxfin =3D $fin if $fin > $maxfin; + } else { + # disregard - neither W or D } } # we quit if the total time from the start of the flight --=20 2.20.1