Julien Grall writes ("[PATCH for-4.15 0/5] xenstore: Address coverity issues in the LiveUpdate code"): > tools/xenstored: Avoid unnecessary talloc_strdup() in do_control_lu() > tools/xenstored: Avoid unnecessary talloc_strdup() in do_lu_start() > tools/xenstored: control: Store the save filename in lu_dump_state > tools/xenstore-control: Don't leak buf in live_update_start() These four are actual bugfixes: Release-Acked-by: Ian Jackson <iwj@xenproject.org> > tools/xenstored: Silence coverity when using xs_state_* structures For this I can't see a reason to give a release ack ? See also Andy's comments. Ian.
Hi Ian, On 25/02/2021 17:54, Ian Jackson wrote: > Julien Grall writes ("[PATCH for-4.15 0/5] xenstore: Address coverity issues in the LiveUpdate code"): >> tools/xenstored: Avoid unnecessary talloc_strdup() in do_control_lu() >> tools/xenstored: Avoid unnecessary talloc_strdup() in do_lu_start() >> tools/xenstored: control: Store the save filename in lu_dump_state >> tools/xenstore-control: Don't leak buf in live_update_start() > > These four are actual bugfixes: > > Release-Acked-by: Ian Jackson <iwj@xenproject.org> Thanks! > >> tools/xenstored: Silence coverity when using xs_state_* structures > > For this I can't see a reason to give a release ack ? See also Andy's > comments. I don't have a reason for this one as it is so far just silencing Coverity. Sorry I should have mention that this one is not really 4.15 material. Cheers, -- Julien Grall
Julien Grall writes ("Re: [PATCH for-4.15 0/5] xenstore: Address coverity issues in the LiveUpdate code"): > On 25/02/2021 17:54, Ian Jackson wrote: > > Julien Grall writes ("[PATCH for-4.15 0/5] xenstore: Address coverity issues in the LiveUpdate code"): > >> tools/xenstored: Silence coverity when using xs_state_* structures > > > > For this I can't see a reason to give a release ack ? See also Andy's > > comments. > > I don't have a reason for this one as it is so far just silencing > Coverity. Sorry I should have mention that this one is not really 4.15 > material. No problem, thanks for the fixes! Ian.
© 2016 - 2024 Red Hat, Inc.