From nobody Fri Oct 23 15:33:47 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=none dis=none) header.from=xenproject.org ARC-Seal: i=1; a=rsa-sha256; t=1790846387; cv=none; d=zohomail.com; s=zohoarc; b=k0ZGcYkj8924RG8F9qHOCsw/gXysXrauUykAycD7/IWKAftbgGdmCulDeWVi41DCpD8dy7Dy8rYjtWcTv4S1VjKF/sjj4da+ewsnAhQ8peJLiHtRBHP49e5aBN7aXlZIZ4H6X50rurOzn19nWIQsUG2ny+SrBaid/SqPMBrxi50= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1790846387; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=eWuRD7GAnUTDVqVn/Np8AQGIp5fI3wXhz1oTFtVC0ac=; b=ONcg2hfc0HgfmCA2/yi6an4mK1zPnNA0DK2QJbmBwRCJkZeCXteXTDZlpHBGdqPiMzXi+0nI6nQeETH3WwjPEliqjfQHmijiE7Scxb4tPcJwIk9Lqn4PvPbfvmTQLy7/CsadtmtUNL8GoINtlgA4eWwGWPiwleTCCm6BykcjJL4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1790846387163710.0186610660246; Thu, 1 Oct 2026 02:19:47 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1438096.1656986 (Exim 4.92) (envelope-from ) id 1xCCwq-0005EJ-NN; Thu, 01 Oct 2026 09:19:28 +0000 Received: by outflank-mailman (output) from mailman id 1438096.1656986; Thu, 01 Oct 2026 09:19:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1xCCwq-0005EC-KI; Thu, 01 Oct 2026 09:19:28 +0000 Received: by outflank-mailman (input) for mailman id 1438096; Thu, 01 Oct 2026 09:19:27 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1xCCwp-0005E6-L8 for xen-devel@lists.xenproject.org; Thu, 01 Oct 2026 09:19:27 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.96) (envelope-from ) id 1xCCwn-009MBP-2k; Thu, 01 Oct 2026 09:19:26 +0000 Received: from 224.pool85-54-217.dynamic.orange.es ([85.54.217.224] helo=localhost) by xenbits.xenproject.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1xCCwn-0028hK-2R; Thu, 01 Oct 2026 09:19:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type: MIME-Version:Message-ID:Date:Subject:Cc:To:From; bh=eWuRD7GAnUTDVqVn/Np8AQGIp5fI3wXhz1oTFtVC0ac=; b=qA4DiN8Eqiuq8ljqK0A3iCI9ac ijv7n3+T6tJMa5uBC8wrtwbJ6ZjrCNowRTo+7rieQBdEJfUU0TeIVby5rFbXs2zOoL3p6ZGfQb+m9 9ge54dU8Uudu5UziUt/Tm+PC9ppb5ofI6YNxVlE4az/G41ZuT/LyWiOxExqbJO1/AO+U=; From: Roger Pau Monne To: xen-devel@lists.xenproject.org Cc: Roger Pau Monne , Andrew Cooper , Anthony PERARD , Michal Orzel , Jan Beulich , Julien Grall , Stefano Stabellini Subject: [PATCH v2] xen/x86: restrict XENFEAT_pae_pgdir_above_4gb setting to PV guests Date: Thu, 1 Oct 2026 11:19:21 +0200 Message-ID: <20261001091921.94138-1-roger@xenproject.org> X-Mailer: git-send-email 2.55.0 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @xenproject.org) X-ZM-MESSAGEID: 1790846388063158500 XENFEAT_pae_pgdir_above_4gb is only used by 32bit PV guests, hence limit its setting in XENVER_get_features to the is_pv_domain() guarded section, with the rest of the PV specific features. No functional change intended. Signed-off-by: Roger Pau Monn=C3=A9 Acked-by: Andrew Cooper Reviewed-by: Teddy Astie --- Changes since v1: - Just move the conditional but don't merge it. --- xen/common/kernel.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/xen/common/kernel.c b/xen/common/kernel.c index f4bbd8818fa8..6811599f95fd 100644 --- a/xen/common/kernel.c +++ b/xen/common/kernel.c @@ -677,8 +677,6 @@ long do_xen_version(int cmd, XEN_GUEST_HANDLE_PARAM(voi= d) arg) (1U << XENFEAT_vcpu_time_phys_area) | #endif (1U << XENFEAT_runstate_phys_area); - if ( VM_ASSIST(d, pae_extended_cr3) ) - fi.submap |=3D (1U << XENFEAT_pae_pgdir_above_4gb); if ( paging_mode_translate(d) ) fi.submap |=3D (1U << XENFEAT_writable_page_tables) | @@ -690,9 +688,13 @@ long do_xen_version(int cmd, XEN_GUEST_HANDLE_PARAM(vo= id) arg) #endif #ifdef CONFIG_X86 if ( is_pv_domain(d) ) + { fi.submap |=3D (1U << XENFEAT_mmu_pt_update_preserve_ad) | (1U << XENFEAT_highmem_assist) | (1U << XENFEAT_gnttab_map_avail_bits); + if ( VM_ASSIST(d, pae_extended_cr3) ) + fi.submap |=3D (1U << XENFEAT_pae_pgdir_above_4gb); + } else fi.submap |=3D (1U << XENFEAT_hvm_safe_pvclock) | (1U << XENFEAT_hvm_callback_vector) | --=20 2.55.0