From nobody Thu Sep 24 19:04:36 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1789555522; cv=pass; d=zohomail.com; s=zohoarc; b=P+DnRy6gqeMZ3kHIaWQCuwWAw3z7v5oSaJGD1T+dFXJ/giXoqRn3SkU7T1gELfAX7SIG0dsKmCdwxCL6ODhjlFbxfZEHzHJZplxYgthjiR72HXsqUzFSlEzTiQAa+ejowqyWeqtxE32QZwKNhlpQg47hugTUpLcI+CtbuIr/HwU= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1789555522; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=prUedyp4AYuc7mLB5VI6y/YZt603NMIJq8WEZ9TCJCA=; b=T1rMySDup3agY7kiQsL4oDYOsR8EXWMZlCeyAvHJca4no5JspePFZ8KuII3qMBJUkcbo3+L323GIdEswdEpvBSf6kIQN9/OQFMkznUITR50iCwtGT+/pLmuGmLfCyVYEZn0bmBt4QGn8w00KDj8hsE6uYc3c0P2/g1o8qVBFAgk= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1789555522299260.6833023640635; Wed, 16 Sep 2026 03:45:22 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1422577.1647919 (Exim 4.92) (envelope-from ) id 1x6n8L-0002Ta-Q9; Wed, 16 Sep 2026 10:44:57 +0000 Received: by outflank-mailman (output) from mailman id 1422577.1647919; Wed, 16 Sep 2026 10:44:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1x6n8L-0002TT-ND; Wed, 16 Sep 2026 10:44:57 +0000 Received: by outflank-mailman (input) for mailman id 1422577; Wed, 16 Sep 2026 10:44:56 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1x6n8K-0002TN-8s for xen-devel@lists.xenproject.org; Wed, 16 Sep 2026 10:44:56 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1x6n8J-002G1v-H8 for xen-devel@lists.xenproject.org; Wed, 16 Sep 2026 12:44:55 +0200 Received: from [10.42.69.1] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6aaa7321-e002-0a2a0a5209dd-0a2a45018ec4-24 for ; Wed, 16 Sep 2026 12:44:55 +0200 Received: from [148.163.151.68] (helo=mx0a-002c1b01.pphosted.com) by tlsNG-d62444.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6aaa7325-5984-0a2a45010019-94a39744a086-3 for ; Wed, 16 Sep 2026 12:44:55 +0200 Received: from pps.filterd (m0127839.ppops.net [127.0.0.1]) by mx0a-002c1b01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68G8NpPu539450; Wed, 16 Sep 2026 03:44:44 -0700 Received: from co1pr03cu002.outbound.protection.outlook.com (mail-westus2azon11020142.outbound.protection.outlook.com [52.101.46.142]) by mx0a-002c1b01.pphosted.com (PPS) with ESMTPS id 4gqa0pt9xh-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 16 Sep 2026 03:44:44 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by MW4PR02MB7380.namprd02.prod.outlook.com (2603:10b6:303:74::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.406.12; Wed, 16 Sep 2026 10:44:41 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::8e97:bc32:822c:b250]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::8e97:bc32:822c:b250%3]) with mapi id 15.21.0406.007; Wed, 16 Sep 2026 10:44:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=proofpoint20171006 header.d=nutanix.com header.i="@nutanix.com" header.h="Content-Transfer-Encoding:Content-Type:Date:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To"; dkim=pass header.s=selector1 header.d=nutanix.com header.i="@nutanix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=prUedyp4AYuc7mLB5VI6y/YZt603NMIJq8WEZ9TCJ CA=; b=FIBYkMQKRY8M7UhxUNQSJvQ4jvq22gaAwa7lYbJLyKlXEdCRcZthh6oSx PA7ZtsmyiktmbYj8FIBvGWROVhwqYwRDC1scewmC0y/CrT1+wy5Q/MreJgkdMDnF jXyPdTAAkVvJDmkY8/qD+WoqCUmH5RkY0Pr01HVrkN85Ot8GBqoCSA583PVrVcFo s4ZMkosZ/hU8yLZM2HZ3LpSncEu/EfAQj0DpRmFjkUaZTJaOR1Qfn5ooHJrE/RaY H/GzClR1ii35zJl17RNkbeFrssSakKSQtgXX9nWVQ04ftv4wXgkK2ToCT45Kso5M O8L2nW3YtblrFc+G0h8ucSKTdqxow== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=flhFFEppQEBRdsHvOmRubo5NntVuDipcwFr6iadkFrI41ndIBqwa2gILt/QNrRCgMMuWJFMvzS1Kh4hzHEaIso/g/7MAtHyGAyuKgcPMm8/dJ3S/OcM23xbVUl3KnNTA6LYQrhRZfw0tmgrZKTWYRDCpz43D3PR2wWKfJ0BJ66XEgre4fgMZyzXv1VUFWPnV0tP+/N7MqJLH5YYWtpo6tbvvLbYAl3a9+wBgLSwSbBXXKKblS0utOdybx25ismav1iDJoc5gsySLfDVJwRTvae3BS4o3APpf8r6M7wGNRN15bMqsbwCwDjWGH51ZBHGZQDBwMT+KMhfNft38EfCl2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=prUedyp4AYuc7mLB5VI6y/YZt603NMIJq8WEZ9TCJCA=; b=Ib3WNAbScNxPoRiv9cjY774vkDzGAeltmam54wTaJBvQ1QYCYbES51CKHWc/4HU93u+cZiy55yR8UwhSE0NylBJmtTCYN3h8cV+CVzxmbIqCFd6A3hYlG3RflBHEj9G17JWYXY5x7pqke8PxxgGVncBPUiqKghceeYg/Lx/bBmOiWoqF6iep3leWJjumPk2NznL0ZZ3DVYk3gM7APxp5UzvGzgneUXP4erutTTNQmR6ZaVQdjz7C/qSebDM359gubHNHYWqyBvE7uB5iK9yVGkMKZasXVPUHe5w1aXA7pfVFnl6fyWPzuYMYjY06pTV3eNJ9r1tVX8LgON5IEVvfPw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=prUedyp4AYuc7mLB5VI6y/YZt603NMIJq8WEZ9TCJCA=; b=Xfvxz5kMUI7cPZkRE5O/VeNgwqUKCgSW1AM8pfAfMFvjeL2TjgKzYxdBtqkX/hrypzJP1pGrjnL2xf0OjE4liIqxMlJQ6vXGYZXShYuUAAsMkozPIkOtWFkE1NzbSPeo8tLIucOKp+cOusy9xvfeHYG6rItAtI1F1k67SIiHxtwevoArEvPZqgV3HAUOHdP1QzVp3kw5kZT2faFYR7pdVk8DWUb5tbvpQNJ3OwjzIpratTgj0lKkjn8oB9cnCR1gEbpfWRpCBAnwfAU7nSComssNUZHO+bE7x4EmdTxN/7v1tL1QIGfCHx5MJTC8/DFCsi9yWj7oS4ZJGtBs0/jceg== From: Mark Cave-Ayland To: pbonzini@redhat.com, richard.henderson@linaro.org, mst@redhat.com, sstabellini@kernel.org, anthony@xenproject.org, edgar.iglesias@gmail.com, qemu-devel@nongnu.org, xen-devel@lists.xenproject.org Subject: [PATCH 01/22] i8259_internal.h: rename PIC_COMMON to I8259_COMMON Date: Wed, 16 Sep 2026 11:43:29 +0100 Message-ID: <20260916104435.600211-2-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260916104435.600211-1-mark.caveayland@nutanix.com> References: <20260916104435.600211-1-mark.caveayland@nutanix.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SJ0PR03CA0277.namprd03.prod.outlook.com (2603:10b6:a03:39e::12) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|MW4PR02MB7380:EE_ X-MS-Office365-Filtering-Correlation-Id: b928cdc9-c82a-4b3b-cb26-08df13df837f x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|23010399003|376014|22082099003|10067099003|56012099006|18002099003; X-Microsoft-Antispam-Message-Info: 78SkZK4UYr7breG+pCgv55dS6aPSQVRgF0mjs1+rCRh7cigI75iKm1oRfZW5NsAl9pwbAPDEFK463uUdh+4rxAh7qO2rZ2R3/WOeXLkSrBh1waGcHiokxogWH8pD24R16YzkyGKqJxur28+nriKF/vVP1wRzFt2jmgKyjkPiBIpPkrPuSaiz5rdH7hFx/kcx3KdGl2jF4OkNYd6zQIhF4r2eBUErog+P3O9qstKlaSBcfjjU/KaSoOkWLTWCSmKce8SvoRyReldBIrkC9BWDItakSU+qpU4yGSI5ZX4tjJcD1nhTBSaLyYQxvEq6L0FXA8ufQ/Sh/2FM0GWMU7QP7+I9BWZTg2DLoi5HEhqhPwHEYzyOg5E3rhIAQ60Vl9oYiOm2pA0C+Tz4gmnTlbA08mlpJv0or04kDLtwE+vS+PVjf12K8gEMOHFRp3wmxhqVX/dZywIFjfRzioUMBHPXJR/9Ukd7WmFIL+5GW1yrsSRnmCpz0aDNiZm9sJcwZoqwScpFkC4JEIwKC2BHg8hJMifFLSSIXvvbT5IelOQkDGo/Nh0l3gAlbdVxGOimsVzkeLX5TuPTs8w0cY+H3VibTNdw2DEo/dsMASulNNbGAmyN5fHw5VaFsPwBuzpn1T0RZP2o5mOiafimOx+MVJXgQPWpFAbJlI5e+nVC3AQdLnA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR02MB7159.namprd02.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(23010399003)(376014)(22082099003)(10067099003)(56012099006)(18002099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?RH+VyBB8HlGNe00NDjHfYo8XhmlIniyU6P6S9VYvU9U3PmlVC6/6jZ6k/fkS?= =?us-ascii?Q?WZv0/M9hC6EoxCajWQnud7cV574I/KId+B5eDa5Jq0q5c2qDQBwAB6Sznx8O?= =?us-ascii?Q?BOuq0Q1EubOsTgLsnGzyP/T0f/SR5eerX3obqQJMlynIj6fMPFn4S7DUU3q6?= =?us-ascii?Q?V5OQaNxy4sizA6Qi50TK4YDeguV6eEMrrPBe2xmOL5rOWqobMGIjGXXyY8sP?= =?us-ascii?Q?EDfC9A6EnSOhgCPPKcOWdbpy/de29HTTS70IvpVdmtsaUzeu0em+tPwqzOyE?= =?us-ascii?Q?OB/A12vLKB2/lmYuW7kLoUFgxQwH+uPOuDtamQtbnOWbmjq9FbDfgP3toPAe?= =?us-ascii?Q?1E0TeHFpq4DnH5neOlPPJmvDoRQwLMHkc3ukaxTQpLCt7Z+AbUloT+MRuQU0?= =?us-ascii?Q?BS6vP1G9BkKKpjkecBcjO7Z4RLiA6/1K62puqf6K2w4h0yMWE6RbzQe/Cypz?= =?us-ascii?Q?Iau6ztZFdFpNrywO1uzFVf8vOx2dHVmaQPGseQHlx9W1QnzDB/kOdDUX3xEe?= =?us-ascii?Q?RZU2RmmU+RppWtr0pd2n+ibK0yaLSii8h9iA8If2EUStvPVf1XvOXp42Ffof?= =?us-ascii?Q?x+6NG+Xqr46d3uiZZkePBwuPlpnmsD3g+1X3ywsHVPKvzytXJ4hVyc2q1UDr?= =?us-ascii?Q?wcBocxHSpV8BSSMdn7T9yRZm5x3f39p7FlqCNVuPEQmS7lukRYmeeYv0XFnZ?= =?us-ascii?Q?kAXVXA3/tytaO4bA3F03u2YhwEdJyIkiAr5cnfX+wHRoT/otJKnW0+lDIPGh?= =?us-ascii?Q?wcdCUbKUy6Gb2swtKlw1Vc31YublLys5NgTAi5VXHBCKr/VPuC2QyfqPc3tf?= =?us-ascii?Q?rsbu3RnwKj1yHTBXn4sj5SgBz78AwkcLpvue+Hu7Ku9CZTLtqAEsraByKJsS?= =?us-ascii?Q?hkUlMOP67ElisIYZq1nfLk5fHH3GbPDs/Phnljcj1gBL79MFW6oPOX0JgCbJ?= =?us-ascii?Q?6FgUZF1BSohvdXFJyKVG73r8qBneQipgeDXC6htz7PDrOAUhnH05SSGY+5E1?= =?us-ascii?Q?ZPtVPPRs5wH/YDhIgt7HJj3rVauNld6LQRC+iJ99Dar9FxSm1FAa84eG/YZv?= =?us-ascii?Q?Q/HF4uDQ1E6u414Z0Vj9qE5XP3qG//Ib9oQBgxl1RxMw+8jLExahuSKaMlI5?= =?us-ascii?Q?eELIIsnYeg+ngalyfFRkS3UwghKdJvfVbfjQY3BtLVP4mXHCA14AlEEl/ELA?= =?us-ascii?Q?UX4Pjl5teXFIiRKfUzvJp7yP8MgpVhH1VfdwqY6aaGV9Ky7iWSAlrXPLSC//?= =?us-ascii?Q?aMiQBrpWedMTLjw1Uf+QFdmCXRGOf8MAuc0OiWMRFwyag4wuqm5O5p57tkSV?= =?us-ascii?Q?gA6zrO4EhdUOyeDH+/KhD7f/uAFm+cw5qtYG38J54P6ufQ70EUlWS9y/ogcr?= =?us-ascii?Q?lE2lP7+YraXNkGCf7rsvhhZdfYl34dzQzrSbvfQVeXXNQ4gikWRlUhRYIicO?= =?us-ascii?Q?L6Lx+7eE3iPJBefXJ9g6XNuxCZscD/wne1/TzHFJDeP4EUP6gZzBCNV9ms5m?= =?us-ascii?Q?XHapHj7hkZ0xKsruQRywFzmXs1Q4j2zmNKvyJb36RLIeMqW8/JQPilvTf1Tu?= =?us-ascii?Q?ie+FFplp2k0vvRug8ZuqokstwhiUQASAVjYQuSWE8MrYLRvzE+bRKhV1e+lK?= =?us-ascii?Q?tFOvevm0M59z4Z41SHJgi8aoPZojR0FAghIFx6oZgvUtdPSERVj0pXPv5RGh?= =?us-ascii?Q?WItkY0LOUT48qbwQHzeY6Psdg+LVpuFpUdMeCxWzuatHsc60pgJPocfuVryv?= =?us-ascii?Q?Oavh5/25Lru2pKC8dumP4necU6OUH9E=3D?= X-Exchange-RoutingPolicyChecked: tLU+vcdoC2UwaurktwJti4xWLmJqH+1lYmZ20NF8d13hWD64gtR0+JTcY/4GQoBVbrwA5nhMvSNqfAfzxL67Dg4Sp4mIr3dgvYHVvWeY4SzfbFiCBsbL3aMDaKMfbxPIp5y1AG0+M/SofbI19wIAKfHSDhDfLN0YFSx1RqULFmaCdU4pQkmWVDkoIRASXGxolOa8aVEGD7t91YyzZE+axjesPSA/QRrWsUSuJ7Y57uGVIMecojT+4yASGSGjmv6FDesuZAizFDG8DhofCq3NDB9tBZtCbNIGeLr659i3b4SMFXcOCdgt+DnUWiN3S+lstOmYUKKVVAuowQ+QXzM6gw== X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: b928cdc9-c82a-4b3b-cb26-08df13df837f X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Sep 2026 10:44:41.7065 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: tZI/IjMG42zOcz+IcxJU8s/D5Qkfx9ZQutCyLilBvdMm7of6moT5t/xxVz/KnhjKdWbR+vJ2k0Cu6w+QL4SxKKkRguyLp+ljRjUn/weieRE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR02MB7380 X-Proofpoint-GUID: u7lcTM77ncOdzjWAb2vWC9dhAk_goSs6 X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE2MDE0MSBTYWx0ZWRfXy0BXZ3ibuEtP Ai0e2uYsGgUOy3BZHRotvBrYPXqUUtrE27e3Q55/2kT7RHX5Sj6zY/vp33xiKikGCL1yJgT7C04 /oHC4joucQhgpyBvRjPTYWR202ynoME= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE2MDE0MSBTYWx0ZWRfXw5C/Lkpm3pHb 8Xrk419VfF/FFnYM03Ha4Zee0RLoLdk3BxURbQ/lCo/du0Ig0aLVGj0NPk3qW3+X4ATC4wEvnSs Oa9n+lS1FxSsKb7SpfYpEb//gHnAivt7aSUwa5rh0DWN+dmaibKH4v/r3xjPa5+Z9nvP+Ar/k1z TUji7GdYKjpSuN5GrEm/YRomDwzPSS8ZfYUQMGORfFVTkgqkGXSoP1dSWGR100nBVWLJyqroo+a HUdftljsy6t4Lo/EyMtmdDa9cqkc2Kyj6aa8TqzdLMAVYDwhCQ/cxxdXmHr97TLq9TOH8SbXqIW KKKKcFMx8/TbCPsrmCsdRCDL4Ez6776oi7eXetX+Wj5chaohDrcDHOPAFhgbP5nyukflNr0S3nb G8CgzTHOZhtP0aiFdfdA28EgaDz4iPvoWrdEBuZTvAUzfph+ovKydiqjd0LAAH6UomMibmwH/Cv CSANQ5cdqOVid9Vf4pA== X-Proofpoint-ORIG-GUID: u7lcTM77ncOdzjWAb2vWC9dhAk_goSs6 X-Authority-Analysis: v=2.4 cv=Ps4G/AM3 c=1 sm=1 tr=0 ts=6aaa731c cx=c_pps a=iw/g3Nm1s12GBgadF/0+Gw==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=xqWC_Br6kY4A:10 a=VdqzKS8jKosA:10 a=0kUYKlekyDsA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VofLwUrZ8Iiv6rRUPXIb:22 a=y4UcunY2MAxhM4LwGdWI:22 a=64Cc0HZtAAAA:8 a=XF9Y1ugsmyLceZbb4BIA:9 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-15_05,2026-09-15_02,2025-10-01_01 X-Proofpoint-Spam-Reason: safe X-purgate-ID: tlsNG-d62444/1789555495-1FE68757-AAEBCA89/0/0 X-purgate-type: clean X-purgate-size: 6588 X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1789555522894158500 Content-Type: text/plain; charset="utf-8" This is to emphasise that child types of PIC_COMMON are all instances of an an 8259 PIC. Signed-off-by: Mark Cave-Ayland --- include/hw/isa/i8259_internal.h | 4 ++-- hw/i386/kvm/i8259.c | 8 ++++---- hw/intc/i8259.c | 10 +++++----- hw/intc/i8259_common.c | 14 +++++++------- 4 files changed, 18 insertions(+), 18 deletions(-) diff --git a/include/hw/isa/i8259_internal.h b/include/hw/isa/i8259_interna= l.h index f9dcc4163e..54dc9036cf 100644 --- a/include/hw/isa/i8259_internal.h +++ b/include/hw/isa/i8259_internal.h @@ -31,8 +31,8 @@ #include "qom/object.h" =20 =20 -#define TYPE_PIC_COMMON "pic-common" -OBJECT_DECLARE_TYPE(PICCommonState, PICCommonClass, PIC_COMMON) +#define TYPE_I8259_COMMON "pic-common" +OBJECT_DECLARE_TYPE(PICCommonState, PICCommonClass, I8259_COMMON) =20 struct PICCommonClass { DeviceClass parent_class; diff --git a/hw/i386/kvm/i8259.c b/hw/i386/kvm/i8259.c index 66f37e1303..14029783e5 100644 --- a/hw/i386/kvm/i8259.c +++ b/hw/i386/kvm/i8259.c @@ -103,7 +103,7 @@ static void kvm_pic_put(PICCommonState *s) =20 static void kvm_pic_reset(DeviceState *dev) { - PICCommonState *s =3D PIC_COMMON(dev); + PICCommonState *s =3D I8259_COMMON(dev); =20 s->elcr =3D 0; pic_reset_common(s); @@ -122,7 +122,7 @@ static void kvm_pic_set_irq(void *opaque, int irq, int = level) =20 static void kvm_pic_realize(DeviceState *dev, Error **errp) { - PICCommonState *s =3D PIC_COMMON(dev); + PICCommonState *s =3D I8259_COMMON(dev); KVMPICClass *kpc =3D KVM_PIC_GET_CLASS(dev); =20 memory_region_init_io(&s->base_io, OBJECT(dev), NULL, NULL, "kvm-pic",= 2); @@ -142,7 +142,7 @@ qemu_irq *kvm_i8259_init(ISABus *bus) static void kvm_i8259_class_init(ObjectClass *klass, const void *data) { KVMPICClass *kpc =3D KVM_PIC_CLASS(klass); - PICCommonClass *k =3D PIC_COMMON_CLASS(klass); + PICCommonClass *k =3D I8259_COMMON_CLASS(klass); DeviceClass *dc =3D DEVICE_CLASS(klass); =20 device_class_set_legacy_reset(dc, kvm_pic_reset); @@ -153,7 +153,7 @@ static void kvm_i8259_class_init(ObjectClass *klass, co= nst void *data) =20 static const TypeInfo kvm_i8259_info =3D { .name =3D TYPE_KVM_I8259, - .parent =3D TYPE_PIC_COMMON, + .parent =3D TYPE_I8259_COMMON, .instance_size =3D sizeof(PICCommonState), .class_init =3D kvm_i8259_class_init, .class_size =3D sizeof(KVMPICClass), diff --git a/hw/intc/i8259.c b/hw/intc/i8259.c index 8f2aa1f0fb..52e24d333e 100644 --- a/hw/intc/i8259.c +++ b/hw/intc/i8259.c @@ -218,7 +218,7 @@ static void pic_init_reset(PICCommonState *s) =20 static void pic_reset(DeviceState *dev) { - PICCommonState *s =3D PIC_COMMON(dev); + PICCommonState *s =3D I8259_COMMON(dev); =20 s->elcr =3D 0; s->ltim =3D 0; @@ -387,7 +387,7 @@ static const MemoryRegionOps pic_elcr_ioport_ops =3D { =20 static void pic_realize(DeviceState *dev, Error **errp) { - PICCommonState *s =3D PIC_COMMON(dev); + PICCommonState *s =3D I8259_COMMON(dev); PICClass *pc =3D PIC_GET_CLASS(dev); =20 memory_region_init_io(&s->base_io, OBJECT(s), &pic_base_ioport_ops, s, @@ -418,7 +418,7 @@ qemu_irq *i8259_init(ISABus *bus, qemu_irq parent_irq_i= n) irq_set[i] =3D qdev_get_gpio_in(dev, i); } =20 - isa_pic =3D PIC_COMMON(dev); + isa_pic =3D I8259_COMMON(dev); =20 isadev =3D i8259_init_chip(TYPE_I8259, bus, false); dev =3D DEVICE(isadev); @@ -428,7 +428,7 @@ qemu_irq *i8259_init(ISABus *bus, qemu_irq parent_irq_i= n) irq_set[i + 8] =3D qdev_get_gpio_in(dev, i); } =20 - slave_pic =3D PIC_COMMON(dev); + slave_pic =3D I8259_COMMON(dev); =20 return irq_set; } @@ -445,7 +445,7 @@ static void i8259_class_init(ObjectClass *klass, const = void *data) static const TypeInfo i8259_info =3D { .name =3D TYPE_I8259, .instance_size =3D sizeof(PICCommonState), - .parent =3D TYPE_PIC_COMMON, + .parent =3D TYPE_I8259_COMMON, .class_init =3D i8259_class_init, .class_size =3D sizeof(PICClass), }; diff --git a/hw/intc/i8259_common.c b/hw/intc/i8259_common.c index 8ceb5841b9..e2f997e161 100644 --- a/hw/intc/i8259_common.c +++ b/hw/intc/i8259_common.c @@ -56,7 +56,7 @@ void pic_reset_common(PICCommonState *s) static int pic_dispatch_pre_save(void *opaque) { PICCommonState *s =3D opaque; - PICCommonClass *info =3D PIC_COMMON_GET_CLASS(s); + PICCommonClass *info =3D I8259_COMMON_GET_CLASS(s); =20 if (info->pre_save) { info->pre_save(s); @@ -68,7 +68,7 @@ static int pic_dispatch_pre_save(void *opaque) static int pic_dispatch_post_load(void *opaque, int version_id) { PICCommonState *s =3D opaque; - PICCommonClass *info =3D PIC_COMMON_GET_CLASS(s); + PICCommonClass *info =3D I8259_COMMON_GET_CLASS(s); =20 if (info->post_load) { info->post_load(s); @@ -78,7 +78,7 @@ static int pic_dispatch_post_load(void *opaque, int versi= on_id) =20 static void pic_common_realize(DeviceState *dev, Error **errp) { - PICCommonState *s =3D PIC_COMMON(dev); + PICCommonState *s =3D I8259_COMMON(dev); ISADevice *isa =3D ISA_DEVICE(dev); =20 isa_register_ioport(isa, &s->base_io, s->iobase); @@ -118,7 +118,7 @@ void pic_stat_update_irq(int irq, int level) static bool pic_get_statistics(InterruptStatsProvider *obj, uint64_t **irq_counts, unsigned int *nb_irq= s) { - PICCommonState *s =3D PIC_COMMON(obj); + PICCommonState *s =3D I8259_COMMON(obj); =20 if (s->master) { *irq_counts =3D irq_count; @@ -133,7 +133,7 @@ static bool pic_get_statistics(InterruptStatsProvider *= obj, =20 static void pic_print_info(InterruptStatsProvider *obj, GString *buf) { - PICCommonState *s =3D PIC_COMMON(obj); + PICCommonState *s =3D I8259_COMMON(obj); =20 pic_dispatch_pre_save(s); g_string_append_printf(buf, "pic%d: irr=3D%02x imr=3D%02x isr=3D%02x h= prio=3D%d " @@ -146,7 +146,7 @@ static void pic_print_info(InterruptStatsProvider *obj,= GString *buf) =20 static bool ltim_state_needed(void *opaque) { - PICCommonState *s =3D PIC_COMMON(opaque); + PICCommonState *s =3D I8259_COMMON(opaque); =20 return !!s->ltim; } @@ -220,7 +220,7 @@ static void pic_common_class_init(ObjectClass *klass, c= onst void *data) } =20 static const TypeInfo pic_common_type =3D { - .name =3D TYPE_PIC_COMMON, + .name =3D TYPE_I8259_COMMON, .parent =3D TYPE_ISA_DEVICE, .instance_size =3D sizeof(PICCommonState), .class_size =3D sizeof(PICCommonClass), --=20 2.43.0 From nobody Thu Sep 24 19:04:36 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1789555521; cv=pass; d=zohomail.com; s=zohoarc; b=Z507986u3nQ5mX7NHGDYSxxChdCypjYLivVB4jSbiFh8uC2a8HReKfjC2syu3kd7dAAKA72BpqrNtByeR0gKjlwwdKuWedayHhC2u8qAeAxAYK7/8TLCPVfqMOiIlkzR/YTkpnKjzLqNozXi2oSVASQeJ1yrlUNZ3sWasY6DNok= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1789555521; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=47KAukU17fw16ZQnEsguQxctcBzaDB9q4df+PeVtSuI=; b=O46UOy+83WBrKsVuKCcNeO1MV/7dn9eRaRM4LPzhggcjY72dMqXMlZZ9QhXu3VKaafW8jYCwbBFoAKXP4CF7Ulg97tTI4onmu+htLKH8P6XvOB7WcMKxngGc2srgipgUlnOOdtCipm1bh3eObTX9BxbNLSJFJOHDebRu1ikKDIc= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1789555521526565.198364229924; Wed, 16 Sep 2026 03:45:21 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1422578.1647929 (Exim 4.92) (envelope-from ) id 1x6n8O-0002hC-5u; Wed, 16 Sep 2026 10:45:00 +0000 Received: by outflank-mailman (output) from mailman id 1422578.1647929; Wed, 16 Sep 2026 10:45:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1x6n8O-0002h2-2K; Wed, 16 Sep 2026 10:45:00 +0000 Received: by outflank-mailman (input) for mailman id 1422578; Wed, 16 Sep 2026 10:44:58 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1x6n8M-0002c9-K0 for xen-devel@lists.xenproject.org; Wed, 16 Sep 2026 10:44:58 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1x6n8M-009u9P-0R for xen-devel@lists.xenproject.org; Wed, 16 Sep 2026 12:44:58 +0200 Received: from [10.42.69.4] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6aaa7316-2eae-0a2a0a5409dd-0a2a4504cc16-20 for ; Wed, 16 Sep 2026 12:44:57 +0200 Received: from [148.163.155.12] (helo=mx0b-002c1b01.pphosted.com) by tlsNG-ebf023.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6aaa7328-b57f-0a2a45040019-94a39b0c723a-3 for ; Wed, 16 Sep 2026 12:44:57 +0200 Received: from pps.filterd (m0127844.ppops.net [127.0.0.1]) by mx0b-002c1b01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68G89JCJ579568; Wed, 16 Sep 2026 03:44:46 -0700 Received: from co1pr03cu002.outbound.protection.outlook.com (mail-westus2azon11020135.outbound.protection.outlook.com [52.101.46.135]) by mx0b-002c1b01.pphosted.com (PPS) with ESMTPS id 4gqbtb9y9h-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 16 Sep 2026 03:44:46 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by MW4PR02MB7380.namprd02.prod.outlook.com (2603:10b6:303:74::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.406.12; Wed, 16 Sep 2026 10:44:45 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::8e97:bc32:822c:b250]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::8e97:bc32:822c:b250%3]) with mapi id 15.21.0406.007; Wed, 16 Sep 2026 10:44:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=proofpoint20171006 header.d=nutanix.com header.i="@nutanix.com" header.h="Content-Transfer-Encoding:Content-Type:Date:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To"; dkim=pass header.s=selector1 header.d=nutanix.com header.i="@nutanix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=47KAukU17fw16ZQnEsguQxctcBzaDB9q4df+PeVtS uI=; b=xAB73kb2TKiB4lf3zzZPXVzl3G4Xpciqrha9Qs3G5HomT8wjXxh6IXVaB XvsZj3qjW+yN6dWgBHMVnkCfOhGmGqNO7ROa3sYP5ADjQDXZqz77ThT77mX0qQp9 tKMHyNqh0qsqoGezXo5AeNTk23n5h9YDdaBVJMm1mqTkR9oyW+iG0Ht2hW7GqvOd NPEmxVckzTP+MP4PCAf7ucrTUGNr/JjoyV6EABjm/xJ6uYM9uAMGuOhSYgMdhuA3 CNYbQNt8nkJcE+rhqzHV6eshGdpmuurJCA29YV7cdfrGPkd4j1L40d0rFlW2j/LA jsSJqEMWrENv8PMBE2+k5eAYz8d5g== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=DHMstPH0mNxvah2vThSXjVCT3By8Jk8irxXa7RUA6KIyUN9+BvjQRjHOsq6KsK43WVZlOEjSE5hcMDdGebfb7UrxtoNWzjNcJ1DZR0gGXfykXQc8CeXM9Vh53eLjb5zrVRniBY8gLRYIyoOLr21KXF/KwOtrlgbrC8Q/63T59UXWTuCfCiC+XftQFgEmMsEcIMQ2WqPbX0EjoLsi734mPOcxVLQRLnWv+uX1FGbBE8G+nd9Xo5TeZDELhnWExNnO8pEzRg3pcfcqpBB4VWMorIOk8KwHfNAXNiM2XWjCuWO6HpoRzNvmDBhRnCYuqvSaSEWVQwjtzvAJeUj1hXcD7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=47KAukU17fw16ZQnEsguQxctcBzaDB9q4df+PeVtSuI=; b=VrQE7dhvYMh2XtotwSdcrj/tYTgt6NeYXySxPwdl6LDq2q7TJDVkQOfeRhbhcfF4shvh13FLuZ3IgwOdS+FXawKntzTxVpElBz7l2N5Fxama02uWou67rUHprCRM1/z79dRELhXazLRSyAmSL2erkyFm9O0nk7Zcig16si9diQm4dYpo71/UtRtFUr43lGxiz+Kg5nxerlmnZv5jR+DgzBfd6Z28EL8aPXc/JBJ4vyOJGJVTvLgqhIQa5+6Z5NKQ8DXRYexz178mi7bCawhcfO4ln30oMl8YiAks7ZD7Nc/Z9mxfPc0OdhXX7PdpYfYc2ENxbBHDIZ4qCNUsGvDIMg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=47KAukU17fw16ZQnEsguQxctcBzaDB9q4df+PeVtSuI=; b=uTKuzKXlcFMjiKljBBivyj+/aUQcK49sWdOW5baDrlyw9ASGnLmAbut00+80881SdKpc73Q4pFviUCx0cH1IX6Xh191iQ2V5zCHaPktkTWh6SffIbg5BAfeJbx7dEsN6BqflGhtgxLJiWB4hY/RVfAQ0LSPsan/5z5mDtiElFLa3rRAJlXctIU8ReriiDaus2yAVaQyZBDQJRMbQFxPJaZlVPvYd5Bm74EYVDdVJ1yZ4zUruMj1+LevmShV8NsPBeb3m60yPrzzBG9hOcyVWFY2h+V9Zpk0hb2L2oATqePOKYgSmRRb6Lm52RRH/y13P9Y3tYxVve/bxsL+bum7/0w== From: Mark Cave-Ayland To: pbonzini@redhat.com, richard.henderson@linaro.org, mst@redhat.com, sstabellini@kernel.org, anthony@xenproject.org, edgar.iglesias@gmail.com, qemu-devel@nongnu.org, xen-devel@lists.xenproject.org Subject: [PATCH 02/22] i8259_internal.h: rename TYPE_I8259_COMMON to i8259-common Date: Wed, 16 Sep 2026 11:43:30 +0100 Message-ID: <20260916104435.600211-3-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260916104435.600211-1-mark.caveayland@nutanix.com> References: <20260916104435.600211-1-mark.caveayland@nutanix.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SJ0PR03CA0245.namprd03.prod.outlook.com (2603:10b6:a03:3a0::10) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|MW4PR02MB7380:EE_ X-MS-Office365-Filtering-Correlation-Id: 39542bc0-e8d3-4c67-7a01-08df13df85a9 x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|23010399003|376014|22082099003|10067099003|56012099006|18002099003; X-Microsoft-Antispam-Message-Info: 6vhYz4JyaWMhD5U3FnyuVC0rB/40xgbpBlxHyy7gGyMGhtlknLUYuOaWFqraZl+nmCOf4NBGZbUcPi+TOM0WzbG2Uw6YIjDRFQSPu5IAWg/dgpGN+eCOjiUvCIHu4iKe72OLEqrHpsXhkppZG+Y9nvFol19qe1KDJYPfO3wTVf/LCbEa1OCu2DZzs8W0DgakNq8tgOwD26Whco+moiyDSHs/lDsGqmL1UQ9TTQ6OIbAM4d2fJKVSG/E+UFKoQbXIBUf/c0LCsfJuq033qFXVgXMqhhwpAWTLgfWUB/tdz7h9jFbACqTKI2AUJp9qJ0JTJ8U7V2bvAWmHr9TGe53OeDy2zTgJ5Ejrw1Q+b6kmf7E+zD9sCcBQVPzA465bBkABKdDhoOq96pX0iGwew6H6KTJJXimSMk2y1o3mPK+RaMxgA2IV9j7IpOHtYFOYzZBnr95Nwcqn+TabWWtUTt65HL7sDMmhmYVvjMRH42FKxqquBa1smgMcJOGk/a/VgoeV7ZAOD8wKxnWwoBkrH2IgaDqhmSKpl98sL0zKue19FZLrt4I31uC7oHKtyzZ3TOoMtrhcV/Fnz/FGfVZPDys45JkmSWQlDgRDgiTRZ+ol0RD211oLXR+X/7eZJLnIc9kvX3MReMs2dSwyIp6rp5q6aBRLr8xLSMNSNerP+UPlGHE= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR02MB7159.namprd02.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(23010399003)(376014)(22082099003)(10067099003)(56012099006)(18002099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?7Qgcxb7gSoWiqUff4CSTkHBUYrJBWlwcSgOJW/O3uhVvoMPYoVfqjVvCN+cd?= =?us-ascii?Q?ALLNUtWchhpthrjE5STWNTOnn/8iLGIgJLjVzBECYBnApNAyrV3e4BhiMfQt?= =?us-ascii?Q?blQF3B5ZPdZb9D8nsE8mHKYC1pT+aSUjDahPXMbfbcJSsZUJlk+QZ4sieJbS?= =?us-ascii?Q?qTosNPoPx0MDxB7JV9ta4m2xWS76ciNkMqUoog9fEWBfmH9lxRd6i5TtE28k?= =?us-ascii?Q?bdczvRfCnzm020T4Clwh4jHdS46EWBWr+ZDfbeCFG925wg2vRi3YP80ynXDQ?= =?us-ascii?Q?sIWGDarbPJI8ypGNS141W4OSpp87/eeIfCN8cGbxhvUs4dxuQ5eC5DMlKf9y?= =?us-ascii?Q?6sV0PzgFvpH4eXMPrXet5WRYaz6SP1z/fKVU6BJIJeXzUvoyzH7Ti289uOph?= =?us-ascii?Q?C/zq24G3/GMpCQ29Vb3sQ7/BHLoG4ELGoDgyePX/SDUDHMiT9mQAXn9uF/WG?= =?us-ascii?Q?rP0c1yomXX5msjv95Vx8ECKVpC/rForgObLE215StuRYRg5cBGAYa3MRWVHf?= =?us-ascii?Q?/vx6a1xnrNnW2/x90WrKx89bYvsgcXI+LWPsCWMSNabEwEplF2Z5G8ArIZpB?= =?us-ascii?Q?2Y4Oi5v1d8zReqvVkqwi7UWO5iZ56kATiCoDBHcjfIL+y3bthpLGacQSUKZg?= =?us-ascii?Q?EjSQ00mli6DwL5yBm2YezwtSU4EZJs6RnUEIr/pLuzYwCGE8da1rEjp/X9xq?= =?us-ascii?Q?vDeyEcA90KT/rdzTC2HHZdxdcm5XIk1LeNkubYL6miHlUvf8ROFB++1cHVJE?= =?us-ascii?Q?+4RugPFfZ5rB/E4iHx/y76G8dPw9y3wGbLV+ZyfiyK4SvcQvZkfPsC0UPOrn?= =?us-ascii?Q?AgsA6AQoeTbenzETUeH2Vol5YlOmU68tzhUo/Dm5LwWhwUsDtNH4/q5foeYj?= =?us-ascii?Q?QonYHkjDBhRLDvz9z0d2Z6UjB7yqm/qzI5P6pS19YpOL95iFuFxmS2YPQT+8?= =?us-ascii?Q?x4OHNONRtLcvJ8XUIYN60dEqko3Togvm+cev1xFTbKo2oEdHulizkodDXDKV?= =?us-ascii?Q?e784sy8WmtT0Oorra8eAWb1QCmwolzYyiSkBGk3ImAOxgyMImFL4DRFY/Fsn?= =?us-ascii?Q?tFBi0DtpvZy7xPrPJfd/pFLjvUeoA0hnVq/fqYm0LCQtZ4bCW2OWGD+V1rrn?= =?us-ascii?Q?M+xSOE4j/cVa7cuirVXZlxgiYscvQWSvCingJC5w4OcKtrgVVxpb8PoLwF7y?= =?us-ascii?Q?P2JCg2MhXRswTyB1j/xW15DzwpRybvt3eE49ycxR/Poh8DZgHyOjqdz/BhAV?= =?us-ascii?Q?jeFX0i2CzCp/4KNADtCQYYUlviito/JzJkjLNx5fDAJ9We0eUZJhwDPjUVsd?= =?us-ascii?Q?NnIbhas/aK/nbtoFPACym23rLCHdlBeBfvbD4/5P7Z8EXa/yFeXuGq/q4rtm?= =?us-ascii?Q?a9HBddKqUmBJxc+X210EsgrKfHyfhCLkbL9KOTYWYWtvCbU+R73lCn20H5xD?= =?us-ascii?Q?HauJxxIVIeiH1iMUaQm92OFXq+Y01rPn7Ehm5lPxI7Zrw3yd0sRi1n+Y2GPq?= =?us-ascii?Q?jQUUrCxTCsRVeqyn4jlkLH/DMpTTjt/3WzL1VDrNKLmkRS9QJPmQGmYJ5PL7?= =?us-ascii?Q?CKSIb0ocWs9TtvixpJKstEz5I+46vUcv9Tg7Ho7Tfw3DpgOlC4oew3ThNLiP?= =?us-ascii?Q?b464PbB/tXrqaIhawF2jYFqbEpE/x2DNt281HVhKIZ/oDPv2WgBqn1SGt9Y4?= =?us-ascii?Q?Dm36DUFTv+2u+W8P+lBn36fSIX4OhWU4YyXqro+wvseoxgqkCI6sHsEk8nEm?= =?us-ascii?Q?jIZI/GYShndmjiUW9h3z5tQLrR3G4SM=3D?= X-Exchange-RoutingPolicyChecked: RqYqtDzWPAE9uZKty4+QO9eq/OFm8IQxbvTCY9F735n1ZyQIKRNEHe1bHveU1nin+yzE8PxeGhyoi/E2gFMcf91Nu7ulZRhJEjzgP9Zbxw7RfTEDPyJeHGbJTl59jsHKwNic03MPtdtb99MNQQ9VQsOE7pgzOPQP6E3awLGOiLng/Ry2K2krrR8pjbfBJ8wglHeUsTgaWSUIOta5eaBWxrhyOZtsLgAuxXw1n6pcOF66J2W6pdZHWuyO3QgfGUDaOm42HamH1M0GSt9qaS+ROWhN/kV/aaqJNhPNf6VajMIJooCRJbIT97V43O0AbL0wzRFs04Rbw/Fty2FW/v+9qg== X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 39542bc0-e8d3-4c67-7a01-08df13df85a9 X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Sep 2026 10:44:45.1695 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: jqR0BXsLOpDdDYUyi+6RL+QDdQC5Tdg/wUMbMaddnXQzLQRz43HESo8mcixC0oHYNczeDjXU0KXDzNk7vTEszgy7n0VZOTycuPtBYwPWcYQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR02MB7380 X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE2MDE0MSBTYWx0ZWRfXxzfpPlhYTKgz 9opON5QGoH4vI9pAitfxn7VmMKcRs3GYUvj7IrEQmkcE0zu7qJf7D2dzy1PUU/wD1Vjqzp6MAyi xYf2F6iXGGMa2CETHOpKVCjiNcGqmgU= X-Proofpoint-ORIG-GUID: 6GxFv3o7tf2jdG0-aexsyqUYcgSr1KfO X-Proofpoint-GUID: 6GxFv3o7tf2jdG0-aexsyqUYcgSr1KfO X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE2MDE0MSBTYWx0ZWRfX8vn0HnGTVMmL qlxF0G1x6vsFtt8dEVVEMfvhfazWFXk9KGSP3GOARQGDALHQJsjuusQGJZ6wMSkZoEPShL9hSXc ie4obN0ArWNdEscdiSKzZ4g+MQ3ehTRglAFua/nU1OiGPgjcllaeOB1DYsmsu+37XBmEBSTjbb2 6CDBfxOUfP9ESMWcCrT2oD5pdqrATF29v5ilMc5XbL9akTVE0+H1sBmODtpPInchReKyIWpHkGL RU+Zk4RnDbLgSNgD8+dO0jRCZBDDVu2Tj7Je5I/KIDtGzlmFyStTqhoh0a7txDG/7OcLsoSkmMv 3XsLTMeY9GPHXCn8SrITMeZWCk2D/jOwOPxdkm97lLjyBX1Q1CmW5feNpxaWc7Jm4vG28P9Xwuk vlNpNVfhI3lounrd8WM4UFBjF9EXeNR3mLOckjoRKkiErTlbOSgOIVQviwlLlmFgJXVAkvLDgBh BtW4O3QGVkHZQ5kDZrg== X-Authority-Analysis: v=2.4 cv=QYvzLcbv c=1 sm=1 tr=0 ts=6aaa731e cx=c_pps a=5R5l3xa2V1v4tL9kvXelng==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=xqWC_Br6kY4A:10 a=VdqzKS8jKosA:10 a=0kUYKlekyDsA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VofLwUrZ8Iiv6rRUPXIb:22 a=0LlEyIVc8U2lsR7dKhuH:22 a=64Cc0HZtAAAA:8 a=xWlEjtkXqD840QCPih0A:9 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-15_05,2026-09-15_02,2025-10-01_01 X-Proofpoint-Spam-Reason: safe X-purgate-ID: tlsNG-ebf023/1789555497-C24CBB50-58A9F50B/0/0 X-purgate-type: clean X-purgate-size: 694 X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1789555522830158500 Content-Type: text/plain; charset="utf-8" This is to emphasise that child types of PIC_COMMON are all instances of an an 8259 PIC. Signed-off-by: Mark Cave-Ayland --- include/hw/isa/i8259_internal.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/hw/isa/i8259_internal.h b/include/hw/isa/i8259_interna= l.h index 54dc9036cf..289d08b7d7 100644 --- a/include/hw/isa/i8259_internal.h +++ b/include/hw/isa/i8259_internal.h @@ -31,7 +31,7 @@ #include "qom/object.h" =20 =20 -#define TYPE_I8259_COMMON "pic-common" +#define TYPE_I8259_COMMON "i8259-common" OBJECT_DECLARE_TYPE(PICCommonState, PICCommonClass, I8259_COMMON) =20 struct PICCommonClass { --=20 2.43.0 From nobody Thu Sep 24 19:04:36 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1789555525; cv=pass; d=zohomail.com; s=zohoarc; b=f1dkNzWRmmLg12JzEhXfyRRSoTnJRiyo/AKDaeD0Jfkw0bai4wKO4ABcfCwZrXJE06AU3fjOrTS8G1voFojdHObvVwPn9VqxQGYAGcFAHYhykCdPTRRQXdx+2YmOuRawJjojDlfNIx330ut3+Tud/wpImCAAkE3dxFU6OEuXavA= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1789555525; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=oCxDLQQ0JtOJx+l00uKoBh/UgomiZOIYm3LR6JQrDXA=; b=Ca6BxmsB26SsNR3Aor8GOxYkdNN9my/GnhBz11zrkmtkzl/VUxvaVy6YP3TmJ/cuRyw0S/c5IatinGkPYjMb0/GrxrB5wlE6DWbjQ2MSuk3H5+eBRZD2vlWc6AoHV0nsiwQKj380WJ9OK5pxSLafiNyGwBFgebgj9nQqUj8/OrE= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 178955552582455.47165435915133; Wed, 16 Sep 2026 03:45:25 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1422580.1647944 (Exim 4.92) (envelope-from ) id 1x6n8Q-0002yo-QY; Wed, 16 Sep 2026 10:45:02 +0000 Received: by outflank-mailman (output) from mailman id 1422580.1647944; Wed, 16 Sep 2026 10:45:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1x6n8Q-0002yR-IP; Wed, 16 Sep 2026 10:45:02 +0000 Received: by outflank-mailman (input) for mailman id 1422580; Wed, 16 Sep 2026 10:45:01 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1x6n8O-0002p8-T9 for xen-devel@lists.xenproject.org; Wed, 16 Sep 2026 10:45:01 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1x6n8O-002G4Y-A4 for xen-devel@lists.xenproject.org; Wed, 16 Sep 2026 12:45:00 +0200 Received: from [10.42.69.1] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6aaa7321-e002-0a2a0a5209dd-0a2a45018ec4-42 for ; Wed, 16 Sep 2026 12:45:00 +0200 Received: from [148.163.151.68] (helo=mx0a-002c1b01.pphosted.com) by tlsNG-d62444.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6aaa732a-5984-0a2a45010019-94a39744bf5c-3 for ; Wed, 16 Sep 2026 12:44:59 +0200 Received: from pps.filterd (m0127839.ppops.net [127.0.0.1]) by mx0a-002c1b01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68G8q4Ub541814; Wed, 16 Sep 2026 03:44:54 -0700 Received: from bn1pr04cu002.outbound.protection.outlook.com (mail-eastus2azon11020103.outbound.protection.outlook.com [52.101.56.103]) by mx0a-002c1b01.pphosted.com (PPS) with ESMTPS id 4gqa0pt9xw-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 16 Sep 2026 03:44:54 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by MW4PR02MB7380.namprd02.prod.outlook.com (2603:10b6:303:74::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.406.12; Wed, 16 Sep 2026 10:44:48 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::8e97:bc32:822c:b250]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::8e97:bc32:822c:b250%3]) with mapi id 15.21.0406.007; Wed, 16 Sep 2026 10:44:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=proofpoint20171006 header.d=nutanix.com header.i="@nutanix.com" header.h="Content-Transfer-Encoding:Content-Type:Date:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To"; dkim=pass header.s=selector1 header.d=nutanix.com header.i="@nutanix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=oCxDLQQ0JtOJx+l00uKoBh/UgomiZOIYm3LR6JQrD XA=; b=zHHVnhS6ojghbU7jIp7YfnsSZ+e6aA3ok8ZgOJCPNrylUk5KqJ94VlSqg 5b3DSQ3sY9KWKUrioIMa3dr57cOih+jJ4GcXRnHGjL1Qo5rHnRwDYwJ98LpsOwyg Mbkc6CIMe/wLnOEQHNOkhc85ivF5yEYsYi9rmYFnzVzzaJQbe2/iDzlO7L2ghj9N zjp6UwdYa4HNO2Uq60uGcILT3gekkRnf8Q+V3BWOTM+S1yrpbvJp9a/seHcCtskS sa2ieIYqn2qeybL77cb+kFuKtcg5UedwNIU5WeMJy6dK/i15IhuuYE5u3qZAxHWM D1qOULVZ+1Ab9mKdr6/R9ui7FsqOw== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=J4Ytt+ZAMJcNRjOYNEiYnROly+7klnM2ruopQOO8rs1MNNKFNzyjNNwbRaSEExOYCFX4aiqGdZ8wOtArYcJM1A1w884qMB4iQmWijN9qK3PSm56Ao+T1b6Gnvq0lbaA1ztC//9N4kt1dVYCojCb2Mr0uJ3mw61P7hh8DivtNB/8h2KY8jIHrNTufGszDwQ1cOkQpuvRfPp68eLAbaf37KqSwx1bUec1PV0095JLS0wFwjiCGxSBWLiDQbLqXqOPYnuJKE4g3eF/Dj4/cTMlTO5vFc28pkleY13ghanhp8zs4DsauTvon4qB6tFewXt1swOVVgjmAEdFXSn18Dj9few== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oCxDLQQ0JtOJx+l00uKoBh/UgomiZOIYm3LR6JQrDXA=; b=e9bt/ipdC/4WmHDbuq2MYD4CcMRGRbcAKM0sCeHJ0sP79abTyyN8J7BtKDtphnz8BgrN7IO6OGtS+rZtjeYNsfFuw+ucli3GRFvuAPyo698qc4e01KGVMfvM6JBwnGcudN6imAu+hRKPiIubXoY/iZQyw74OXmw8V9CrR5LblkTPtQ7cyexS36NbHwUJYsPmoF4OvXcALSUMeKL0zuVFKbhiLkCuFT6b9VH59+4k6oAym6UEk0GJNQpBXo0pXyEuAtnolwoRfsqUxK4M+t+5+6aivJ+n0hXM2sa2rqtC+DeDALSKYnc/uRAKqnzGrR9ZMbiLB0xowxKfqwutPE4vvg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oCxDLQQ0JtOJx+l00uKoBh/UgomiZOIYm3LR6JQrDXA=; b=VAagvSOdYPhz7ilzs5Q/RrPHgqJ+0Ki1trQuX52D+fQ7pZBp0dGATP8yocyJUIiF0WYlvCtJZu9yI4ivhskoej0AK9QFBNj4GZDLjCePSnbv2apyM0w8EI7Im/MACfSaSkrfjDwMA9rkbCKVvidZT50GthLukwDkhOzi8dba3v4IZwHh5Qifp9HJFxAOfrvKlgwclOwK3/lHvTiH52vXjFZgiMX1KzumZWRmVr6Fni05WM5DpZkE9c4TjFmh0hskigzlz5KmVtRJQE6RKjnQfquOsAJqgjujmIA9X1fWo/Shi4O7kgt/FYkne8o5EgtHOCc1fS8c3aT0f2ZDkuXUCw== From: Mark Cave-Ayland To: pbonzini@redhat.com, richard.henderson@linaro.org, mst@redhat.com, sstabellini@kernel.org, anthony@xenproject.org, edgar.iglesias@gmail.com, qemu-devel@nongnu.org, xen-devel@lists.xenproject.org Subject: [PATCH 03/22] i8259_internal.h: rename PICCommonState to I8259CommonState Date: Wed, 16 Sep 2026 11:43:31 +0100 Message-ID: <20260916104435.600211-4-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260916104435.600211-1-mark.caveayland@nutanix.com> References: <20260916104435.600211-1-mark.caveayland@nutanix.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SJ0PR03CA0056.namprd03.prod.outlook.com (2603:10b6:a03:33e::31) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|MW4PR02MB7380:EE_ X-MS-Office365-Filtering-Correlation-Id: f52442b9-c85d-4c94-e8a9-08df13df87b5 x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|23010399003|376014|22082099003|10067099003|3023799007|56012099006|18002099003; X-Microsoft-Antispam-Message-Info: pzBTX3ZpHkQEMssxpYlRUxBmCcytQ06n+Cyzla4PFCi55Nv1Ztc4BJ508xXZk530NJ7LuhG6310lDTbI4dir6VMnLevE0/Klg1V1N4f2QGzFjLRu1cc1Nn/ZPT6oUl7wdrDwmf0aM50X/fac2qH2PK5ZjjPmqnQqGbQCblwpGckyypuKqSDgrA4fqe7wPwitWOh+OZuplVbUdFWWwWj3/uRKsm7Ng84jhTioAsRoiAkHl1yiAwQnBlQqHiR+3jeY6W5p81iiH6+WaPQkQAavdwu35GRbXIz/yhHaump40KKL37nhYGolscwy1nS2WUr0YfgyqtuFjxESKbAScgDMKqm9CSwJD1z1EJ0NccPzrOSo6hj+MhGAsRm6eqXXMf+g+vczvfPgyiT2UJ8TfBBfT6S+RaLe1Byz0wc9jHdXUmlQkR5Uw0H6M+qYNquz8LxTR2iyAs4fJtoUQWM9vR4MCpMWn/JlYpoXuhZBq3rw2AVPG0kaQPNvC/2INXPRsS8XBUXNB0Kwb4VY5wf2POwfJdDju+Chm8IISFStIbuqtXdo4WON0qyoxZwnjfddjSfiRYwPXOJYZ0UvCUS27H/zN+bMdoahU6l1omiGvKxSr5HQJ6L4iZWXemLkBlB8OG3C49+RTBK+NRGhb6gFGZbvOKFg+binYLVQanLO4XEP1ZE= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR02MB7159.namprd02.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(23010399003)(376014)(22082099003)(10067099003)(3023799007)(56012099006)(18002099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?DGx0rcPHr9WquJH6dWY5Ml7TrVKKK8i2Vo2EBBfa3amL9XVhgpjdo+xEiMUN?= =?us-ascii?Q?QEttGsBgL9GGbnqshQzavuVj24yGkR2Go+6DW2JWIQYuDFKPNHqky/3ySkvE?= =?us-ascii?Q?PCBEkZ6xwXVCL5xhkbAY5wz3eGageuAY1CbR39nfZBD8GcXQaQ0zK5v/4JSu?= =?us-ascii?Q?2+vQmt4TFtz4lhrzi9Msepyyy83CHwuTpFgybzAFZPESP0MdW4tcVt3oQLQx?= =?us-ascii?Q?Nd0eLboFCtACojz4zUU+iWAKgk3obs+sbQlK7nSbgZwLs+tSNfQaMbYbr8hT?= =?us-ascii?Q?+IzfX79EcUm6Gv3njDQRSBt4CaFjxNHBcZJWyZuGxRHIgJ+QXVdi07/rMEPM?= =?us-ascii?Q?lDlCDRKB6tMFAZuh0IdtErsLw1mM2HQTZudB6gtdCxs5XtQkeAASBAqFgAxV?= =?us-ascii?Q?J/hQ/kkTcFYIJBhhHLOp1eoVdyHHDwtZjBiWnU4Cyp3ndPOiJti+fNe5wjH9?= =?us-ascii?Q?egwZOkxncgldAspLHQN4D0ZvKdOo6q3mOFALew1qC2wmKEamyW+yo1OneMc3?= =?us-ascii?Q?qx0uXZ+ekNMvGBPBjt6r1FV8cn9K/IIjY5f0/mgmNlCW/6uLzeYIKREz01Xs?= =?us-ascii?Q?FkyATZ4ftOgyIcu5uOzUp6u8eHAwUloi/giXFJttE4o2n7DxMcdJpY0YsGeo?= =?us-ascii?Q?qJHfZyMjNDQAqxKRjU2fgO/v4ZYPsRXto5iyO1M5IVF1W+ru/kiJB040TjF0?= =?us-ascii?Q?PJ8RHedcELkQuNkYOvQcoQmPLTEkBcWIXivinBNQ86ZsrNl3iLwy4kaGaDdz?= =?us-ascii?Q?6C5T8fJFo9RSH00TCtZMdslI1nupKcabR37tvnOJa53bEHvmZktaORMY3UQp?= =?us-ascii?Q?qvtkn5fBqE87bkFrJWx8SkPv7UUpDHLGbMWClBgMo/dGuerJNvYSRDUWqRHa?= =?us-ascii?Q?sNB7QmziKinzouEkojlWVpPDLtTB7yPhzOZ6xM9V6g5eLtGsZKZAUsj27TtH?= =?us-ascii?Q?uUaENN3aHBM06JWrq+HPO1YVhbSMJwjar4wSkyY17Txf7r/0ordHkS9+LuO/?= =?us-ascii?Q?kIiEvuZTezb01QTpyUJeSUfKd+kDMqlT6S0BR7fbzz22Dz5urnl+647wE0F5?= =?us-ascii?Q?ckPJCDKZN8C09OJ8o6CPYwXGB6CqzR5g4SdYbAPpoSBzm9qxumYcni85gAYZ?= =?us-ascii?Q?WXi+bWjAHfWo4F4zXtw2mJKfRFi9/cMrymbPbpL9hRg6aVSgyEXcUrP2fEFR?= =?us-ascii?Q?+82+zsQI5SYbXPGoRyt01X0JZt6u+P3wtVTj5cEZqSMlw74zjDiqkuhHAY1l?= =?us-ascii?Q?8YGmaFcCddl2lw0fc1vQhKlwQZszZuKWZbE7wU/07ziGDV9dqI0xITs854V+?= =?us-ascii?Q?6iKlOPH2XrUijQmJINIsb8T++4fDZWZvn/BeK6/kW1ZZ0iNrQ+I/Hi/1K2sd?= =?us-ascii?Q?F/9l1LlP6vJwkMU93PLOmbQek7eOv4ob0I2LsHCeKabahQPjg3/5+g/g1fIN?= =?us-ascii?Q?P+AYIPvjEDd4xcryGvhdTb9qRcObtRLpLVg/9skthzhsW6vLF6px2btHQt+E?= =?us-ascii?Q?H0kdO5MU3p//i/1njokyfZOliVzgI5zYJWXNUhtfNgJmv1K3GHUSxQUe19/1?= =?us-ascii?Q?jq2yRIdKgdtqhkz6pyFPzetIS2X6UPspxzaitkpDMhgsu4PuLXf5Ll0Azh6d?= =?us-ascii?Q?MdMITmEoprfZcsZIhvZHj86zU9PcL0rBagQP4cFVIojcha3WcTEjYuqJqQnm?= =?us-ascii?Q?JQJype+4bwD5FeEDHsBu7uBOkZIrOlbnNOzxMWGoE2QZ1/slSRy9xpVnGlqj?= =?us-ascii?Q?eOHqcRz7j8fVaTvw+H6dHAIY5LF2/oY=3D?= X-Exchange-RoutingPolicyChecked: fiXGG/uq0ni/TD5YsQf+7XB/3OIi5Zv1pXl7JC7vQza+86dveJaPmGWeJpTDFwXpBOGykzZ2JS08XJTGDFIv/Ik+VfJjJFuazbH+XFfIYrbysGAzu0u+ihlnKT+hA04meHLgU1GsAnD7nSMDX6NjdjRz5C3n44kR2Wm6LNFgUK2kzlYUMDWDDuhwexHwYLapaTVkkhws6hWenQ/gf+qJ3qOGWfOkgfszF5vEHcwCQSs2f4dpk/zy7S9o21/huJFX6vW9kkbuPXFX9q8WvwIqOEhYOXotfk5bjTagB4l8cRmYlQ9nKzuV7XmMD1CLwgwZgiCkxjwL5ROJc/mvWrccJQ== X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: f52442b9-c85d-4c94-e8a9-08df13df87b5 X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Sep 2026 10:44:48.7674 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: joFT/uxeyLQxacYAsLt5so5Cj94sXdpPTkuk9Z7ONz+biwg88xqWimaFgb7+QbpAsF3KOW+Z7d6WDqEK31J58PjW0mCBiNMjVGTGSnh497Y= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR02MB7380 X-Proofpoint-GUID: rnFeN0odM08iXz9gj7odNRaiY4vShV-e X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE2MDE0MSBTYWx0ZWRfX7zmgByKtVDO/ sMMsDsb/pm66Tyhbiqn9Pzo2XDLbPuo8OseAdQRmsa+uh/c5a0XYpI5/4cFzd0y7PPWtHL7EZvC kytv7cVuk9sdK8xzAzm2OvuwozUwhfg= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE2MDE0MSBTYWx0ZWRfX6FAZ131tOhRZ gXuOMU/atiFn4btLM+IMqIqxsBgPcRi+gH917zBDxuaNT5crThTk2RNlaYIPy0VGOJ/8Z43K+yL PccjQNWTKYE4JI/YXcEUYCSLnkBLDkAs0kNl3j5XRLVcptaO6x1D5s+4NUAbe8uOvQA3+yBnssM TDzomF7y/jtqzkfx6kF5Ex04w7vWZbEZTUOjEbwGCJ6T1RxAb36QEu1fPcAWrr3EVt+9q82bjTD NidRibG9wJqHh53ku9Nre6MIWO+7wh0gKGY01dR2f+fmoOIMM+Giz/f1cGzprwDFgjzE8For/7s DwJnuhzTLBI1yljFZxnBlanPFKLv14TCid3GsRtLbIO/YvkU8V32sqfepGKH9f7zV44sAD6BawA 5x70Shc/eT3NaLAU15Ik+2X+T/ZY54nkip1Et992tBNOX1AM/Ikwh5hSPVN7saFkrw9jzy6iBER BIgMD3fVHR67hpWBfDw== X-Proofpoint-ORIG-GUID: rnFeN0odM08iXz9gj7odNRaiY4vShV-e X-Authority-Analysis: v=2.4 cv=Ps4G/AM3 c=1 sm=1 tr=0 ts=6aaa7326 cx=c_pps a=WPXs+xwE9Zb4LCNJX07eKw==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=xqWC_Br6kY4A:10 a=VdqzKS8jKosA:10 a=0kUYKlekyDsA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VofLwUrZ8Iiv6rRUPXIb:22 a=y4UcunY2MAxhM4LwGdWI:22 a=64Cc0HZtAAAA:8 a=01ND9n3NiX1-kDoXiQMA:9 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-15_05,2026-09-15_02,2025-10-01_01 X-Proofpoint-Spam-Reason: safe X-purgate-ID: tlsNG-d62444/1789555500-1E27A757-83CDB1E9/0/0 X-purgate-type: clean X-purgate-size: 14343 X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1789555526995158500 Content-Type: text/plain; charset="utf-8" Signed-off-by: Mark Cave-Ayland --- include/hw/intc/i8259.h | 8 ++--- include/hw/isa/i8259_internal.h | 10 +++--- hw/i386/kvm/i8259.c | 10 +++--- hw/intc/i8259.c | 34 +++++++++---------- hw/intc/i8259_common.c | 58 ++++++++++++++++----------------- 5 files changed, 60 insertions(+), 60 deletions(-) diff --git a/include/hw/intc/i8259.h b/include/hw/intc/i8259.h index 1f2420231f..1921a30371 100644 --- a/include/hw/intc/i8259.h +++ b/include/hw/intc/i8259.h @@ -3,9 +3,9 @@ =20 /* i8259.c */ =20 -typedef struct PICCommonState PICCommonState; +typedef struct I8259CommonState I8259CommonState; =20 -extern PICCommonState *isa_pic; +extern I8259CommonState *isa_pic; =20 /* * i8259_init() @@ -16,7 +16,7 @@ extern PICCommonState *isa_pic; */ qemu_irq *i8259_init(ISABus *bus, qemu_irq parent_irq_in); qemu_irq *kvm_i8259_init(ISABus *bus); -int pic_get_output(PICCommonState *s); -int pic_read_irq(PICCommonState *s); +int pic_get_output(I8259CommonState *s); +int pic_read_irq(I8259CommonState *s); =20 #endif diff --git a/include/hw/isa/i8259_internal.h b/include/hw/isa/i8259_interna= l.h index 289d08b7d7..7a2f9addaf 100644 --- a/include/hw/isa/i8259_internal.h +++ b/include/hw/isa/i8259_internal.h @@ -32,16 +32,16 @@ =20 =20 #define TYPE_I8259_COMMON "i8259-common" -OBJECT_DECLARE_TYPE(PICCommonState, PICCommonClass, I8259_COMMON) +OBJECT_DECLARE_TYPE(I8259CommonState, PICCommonClass, I8259_COMMON) =20 struct PICCommonClass { DeviceClass parent_class; =20 - void (*pre_save)(PICCommonState *s); - void (*post_load)(PICCommonState *s); + void (*pre_save)(I8259CommonState *s); + void (*post_load)(I8259CommonState *s); }; =20 -struct PICCommonState { +struct I8259CommonState { ISADevice parent_obj; =20 uint8_t last_irr; /* edge detection */ @@ -70,7 +70,7 @@ struct PICCommonState { MemoryRegion elcr_io; }; =20 -void pic_reset_common(PICCommonState *s); +void pic_reset_common(I8259CommonState *s); ISADevice *i8259_init_chip(const char *name, ISABus *bus, bool master); void pic_stat_update_irq(int irq, int level); =20 diff --git a/hw/i386/kvm/i8259.c b/hw/i386/kvm/i8259.c index 14029783e5..f10643a120 100644 --- a/hw/i386/kvm/i8259.c +++ b/hw/i386/kvm/i8259.c @@ -34,7 +34,7 @@ struct KVMPICClass { DeviceRealize parent_realize; }; =20 -static void kvm_pic_get(PICCommonState *s) +static void kvm_pic_get(I8259CommonState *s) { struct kvm_irqchip chip; struct kvm_pic_state *kpic; @@ -67,7 +67,7 @@ static void kvm_pic_get(PICCommonState *s) s->elcr_mask =3D kpic->elcr_mask; } =20 -static void kvm_pic_put(PICCommonState *s) +static void kvm_pic_put(I8259CommonState *s) { struct kvm_irqchip chip; struct kvm_pic_state *kpic; @@ -103,7 +103,7 @@ static void kvm_pic_put(PICCommonState *s) =20 static void kvm_pic_reset(DeviceState *dev) { - PICCommonState *s =3D I8259_COMMON(dev); + I8259CommonState *s =3D I8259_COMMON(dev); =20 s->elcr =3D 0; pic_reset_common(s); @@ -122,7 +122,7 @@ static void kvm_pic_set_irq(void *opaque, int irq, int = level) =20 static void kvm_pic_realize(DeviceState *dev, Error **errp) { - PICCommonState *s =3D I8259_COMMON(dev); + I8259CommonState *s =3D I8259_COMMON(dev); KVMPICClass *kpc =3D KVM_PIC_GET_CLASS(dev); =20 memory_region_init_io(&s->base_io, OBJECT(dev), NULL, NULL, "kvm-pic",= 2); @@ -154,7 +154,7 @@ static void kvm_i8259_class_init(ObjectClass *klass, co= nst void *data) static const TypeInfo kvm_i8259_info =3D { .name =3D TYPE_KVM_I8259, .parent =3D TYPE_I8259_COMMON, - .instance_size =3D sizeof(PICCommonState), + .instance_size =3D sizeof(I8259CommonState), .class_init =3D kvm_i8259_class_init, .class_size =3D sizeof(KVMPICClass), }; diff --git a/hw/intc/i8259.c b/hw/intc/i8259.c index 52e24d333e..45db87a2ad 100644 --- a/hw/intc/i8259.c +++ b/hw/intc/i8259.c @@ -52,12 +52,12 @@ struct PICClass { #ifdef DEBUG_IRQ_LATENCY static int64_t irq_time[16]; #endif -PICCommonState *isa_pic; -static PICCommonState *slave_pic; +I8259CommonState *isa_pic; +static I8259CommonState *slave_pic; =20 /* return the highest priority found in mask (highest =3D smallest number). Return 8 if no irq */ -static int get_priority(PICCommonState *s, int mask) +static int get_priority(I8259CommonState *s, int mask) { int priority; =20 @@ -72,7 +72,7 @@ static int get_priority(PICCommonState *s, int mask) } =20 /* return the pic wanted interrupt. return -1 if none */ -static int pic_get_irq(PICCommonState *s) +static int pic_get_irq(I8259CommonState *s) { int mask, cur_priority, priority; =20 @@ -101,7 +101,7 @@ static int pic_get_irq(PICCommonState *s) } =20 /* Update INT output. Must be called every time the output may have change= d. */ -static void pic_update_irq(PICCommonState *s) +static void pic_update_irq(I8259CommonState *s) { int irq; =20 @@ -117,7 +117,7 @@ static void pic_update_irq(PICCommonState *s) /* set irq level. If an edge is detected, then the IRR is set to 1 */ static void pic_set_irq(void *opaque, int irq, int level) { - PICCommonState *s =3D opaque; + I8259CommonState *s =3D opaque; int mask =3D 1 << irq; int irq_index =3D s->master ? irq : irq + 8; =20 @@ -154,7 +154,7 @@ static void pic_set_irq(void *opaque, int irq, int leve= l) } =20 /* acknowledge interrupt 'irq' */ -static void pic_intack(PICCommonState *s, int irq) +static void pic_intack(I8259CommonState *s, int irq) { if (s->auto_eoi) { if (s->rotate_on_auto_eoi) { @@ -170,7 +170,7 @@ static void pic_intack(PICCommonState *s, int irq) pic_update_irq(s); } =20 -int pic_read_irq(PICCommonState *s) +int pic_read_irq(I8259CommonState *s) { int irq, intno; =20 @@ -210,7 +210,7 @@ int pic_read_irq(PICCommonState *s) return intno; } =20 -static void pic_init_reset(PICCommonState *s) +static void pic_init_reset(I8259CommonState *s) { pic_reset_common(s); pic_update_irq(s); @@ -218,7 +218,7 @@ static void pic_init_reset(PICCommonState *s) =20 static void pic_reset(DeviceState *dev) { - PICCommonState *s =3D I8259_COMMON(dev); + I8259CommonState *s =3D I8259_COMMON(dev); =20 s->elcr =3D 0; s->ltim =3D 0; @@ -228,7 +228,7 @@ static void pic_reset(DeviceState *dev) static void pic_ioport_write(void *opaque, hwaddr addr64, uint64_t val64, unsigned size) { - PICCommonState *s =3D opaque; + I8259CommonState *s =3D opaque; uint32_t addr =3D addr64; uint32_t val =3D val64; int priority, cmd, irq; @@ -321,7 +321,7 @@ static void pic_ioport_write(void *opaque, hwaddr addr6= 4, static uint64_t pic_ioport_read(void *opaque, hwaddr addr, unsigned size) { - PICCommonState *s =3D opaque; + I8259CommonState *s =3D opaque; int ret; =20 if (s->poll) { @@ -348,7 +348,7 @@ static uint64_t pic_ioport_read(void *opaque, hwaddr ad= dr, return ret; } =20 -int pic_get_output(PICCommonState *s) +int pic_get_output(I8259CommonState *s) { return (pic_get_irq(s) >=3D 0); } @@ -356,14 +356,14 @@ int pic_get_output(PICCommonState *s) static void elcr_ioport_write(void *opaque, hwaddr addr, uint64_t val, unsigned size) { - PICCommonState *s =3D opaque; + I8259CommonState *s =3D opaque; s->elcr =3D val & s->elcr_mask; } =20 static uint64_t elcr_ioport_read(void *opaque, hwaddr addr, unsigned size) { - PICCommonState *s =3D opaque; + I8259CommonState *s =3D opaque; return s->elcr; } =20 @@ -387,7 +387,7 @@ static const MemoryRegionOps pic_elcr_ioport_ops =3D { =20 static void pic_realize(DeviceState *dev, Error **errp) { - PICCommonState *s =3D I8259_COMMON(dev); + I8259CommonState *s =3D I8259_COMMON(dev); PICClass *pc =3D PIC_GET_CLASS(dev); =20 memory_region_init_io(&s->base_io, OBJECT(s), &pic_base_ioport_ops, s, @@ -444,7 +444,7 @@ static void i8259_class_init(ObjectClass *klass, const = void *data) =20 static const TypeInfo i8259_info =3D { .name =3D TYPE_I8259, - .instance_size =3D sizeof(PICCommonState), + .instance_size =3D sizeof(I8259CommonState), .parent =3D TYPE_I8259_COMMON, .class_init =3D i8259_class_init, .class_size =3D sizeof(PICClass), diff --git a/hw/intc/i8259_common.c b/hw/intc/i8259_common.c index e2f997e161..17040bdb1e 100644 --- a/hw/intc/i8259_common.c +++ b/hw/intc/i8259_common.c @@ -33,7 +33,7 @@ static int irq_level[16]; static uint64_t irq_count[16]; =20 -void pic_reset_common(PICCommonState *s) +void pic_reset_common(I8259CommonState *s) { s->last_irr =3D 0; s->irr &=3D s->elcr; @@ -55,7 +55,7 @@ void pic_reset_common(PICCommonState *s) =20 static int pic_dispatch_pre_save(void *opaque) { - PICCommonState *s =3D opaque; + I8259CommonState *s =3D opaque; PICCommonClass *info =3D I8259_COMMON_GET_CLASS(s); =20 if (info->pre_save) { @@ -67,7 +67,7 @@ static int pic_dispatch_pre_save(void *opaque) =20 static int pic_dispatch_post_load(void *opaque, int version_id) { - PICCommonState *s =3D opaque; + I8259CommonState *s =3D opaque; PICCommonClass *info =3D I8259_COMMON_GET_CLASS(s); =20 if (info->post_load) { @@ -78,7 +78,7 @@ static int pic_dispatch_post_load(void *opaque, int versi= on_id) =20 static void pic_common_realize(DeviceState *dev, Error **errp) { - PICCommonState *s =3D I8259_COMMON(dev); + I8259CommonState *s =3D I8259_COMMON(dev); ISADevice *isa =3D ISA_DEVICE(dev); =20 isa_register_ioport(isa, &s->base_io, s->iobase); @@ -118,7 +118,7 @@ void pic_stat_update_irq(int irq, int level) static bool pic_get_statistics(InterruptStatsProvider *obj, uint64_t **irq_counts, unsigned int *nb_irq= s) { - PICCommonState *s =3D I8259_COMMON(obj); + I8259CommonState *s =3D I8259_COMMON(obj); =20 if (s->master) { *irq_counts =3D irq_count; @@ -133,7 +133,7 @@ static bool pic_get_statistics(InterruptStatsProvider *= obj, =20 static void pic_print_info(InterruptStatsProvider *obj, GString *buf) { - PICCommonState *s =3D I8259_COMMON(obj); + I8259CommonState *s =3D I8259_COMMON(obj); =20 pic_dispatch_pre_save(s); g_string_append_printf(buf, "pic%d: irr=3D%02x imr=3D%02x isr=3D%02x h= prio=3D%d " @@ -146,7 +146,7 @@ static void pic_print_info(InterruptStatsProvider *obj,= GString *buf) =20 static bool ltim_state_needed(void *opaque) { - PICCommonState *s =3D I8259_COMMON(opaque); + I8259CommonState *s =3D I8259_COMMON(opaque); =20 return !!s->ltim; } @@ -157,7 +157,7 @@ static const VMStateDescription vmstate_pic_ltim =3D { .minimum_version_id =3D 1, .needed =3D ltim_state_needed, .fields =3D (const VMStateField[]) { - VMSTATE_UINT8(ltim, PICCommonState), + VMSTATE_UINT8(ltim, I8259CommonState), VMSTATE_END_OF_LIST() } }; @@ -169,22 +169,22 @@ static const VMStateDescription vmstate_pic_common = =3D { .pre_save =3D pic_dispatch_pre_save, .post_load =3D pic_dispatch_post_load, .fields =3D (const VMStateField[]) { - VMSTATE_UINT8(last_irr, PICCommonState), - VMSTATE_UINT8(irr, PICCommonState), - VMSTATE_UINT8(imr, PICCommonState), - VMSTATE_UINT8(isr, PICCommonState), - VMSTATE_UINT8(priority_add, PICCommonState), - VMSTATE_UINT8(irq_base, PICCommonState), - VMSTATE_UINT8(read_reg_select, PICCommonState), - VMSTATE_UINT8(poll, PICCommonState), - VMSTATE_UINT8(special_mask, PICCommonState), - VMSTATE_UINT8(init_state, PICCommonState), - VMSTATE_UINT8(auto_eoi, PICCommonState), - VMSTATE_UINT8(rotate_on_auto_eoi, PICCommonState), - VMSTATE_UINT8(special_fully_nested_mode, PICCommonState), - VMSTATE_UINT8(init4, PICCommonState), - VMSTATE_UINT8(single_mode, PICCommonState), - VMSTATE_UINT8(elcr, PICCommonState), + VMSTATE_UINT8(last_irr, I8259CommonState), + VMSTATE_UINT8(irr, I8259CommonState), + VMSTATE_UINT8(imr, I8259CommonState), + VMSTATE_UINT8(isr, I8259CommonState), + VMSTATE_UINT8(priority_add, I8259CommonState), + VMSTATE_UINT8(irq_base, I8259CommonState), + VMSTATE_UINT8(read_reg_select, I8259CommonState), + VMSTATE_UINT8(poll, I8259CommonState), + VMSTATE_UINT8(special_mask, I8259CommonState), + VMSTATE_UINT8(init_state, I8259CommonState), + VMSTATE_UINT8(auto_eoi, I8259CommonState), + VMSTATE_UINT8(rotate_on_auto_eoi, I8259CommonState), + VMSTATE_UINT8(special_fully_nested_mode, I8259CommonState), + VMSTATE_UINT8(init4, I8259CommonState), + VMSTATE_UINT8(single_mode, I8259CommonState), + VMSTATE_UINT8(elcr, I8259CommonState), VMSTATE_END_OF_LIST() }, .subsections =3D (const VMStateDescription * const []) { @@ -194,10 +194,10 @@ static const VMStateDescription vmstate_pic_common = =3D { }; =20 static const Property pic_properties_common[] =3D { - DEFINE_PROP_UINT32("iobase", PICCommonState, iobase, -1), - DEFINE_PROP_UINT32("elcr_addr", PICCommonState, elcr_addr, -1), - DEFINE_PROP_UINT8("elcr_mask", PICCommonState, elcr_mask, -1), - DEFINE_PROP_BIT("master", PICCommonState, master, 0, false), + DEFINE_PROP_UINT32("iobase", I8259CommonState, iobase, -1), + DEFINE_PROP_UINT32("elcr_addr", I8259CommonState, elcr_addr, -1), + DEFINE_PROP_UINT8("elcr_mask", I8259CommonState, elcr_mask, -1), + DEFINE_PROP_BIT("master", I8259CommonState, master, 0, false), }; =20 static void pic_common_class_init(ObjectClass *klass, const void *data) @@ -222,7 +222,7 @@ static void pic_common_class_init(ObjectClass *klass, c= onst void *data) static const TypeInfo pic_common_type =3D { .name =3D TYPE_I8259_COMMON, .parent =3D TYPE_ISA_DEVICE, - .instance_size =3D sizeof(PICCommonState), + .instance_size =3D sizeof(I8259CommonState), .class_size =3D sizeof(PICCommonClass), .class_init =3D pic_common_class_init, .abstract =3D true, --=20 2.43.0 From nobody Thu Sep 24 19:04:36 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1789555530; cv=pass; d=zohomail.com; s=zohoarc; b=icENjA88nK3q/mxAy4V1WnZC+Qi0dFEfmGOke9yYK3WbVuXuDSP1b2YN856+ObrOTptNmGf+rP6kBXz3GglDkPKqRjEMWFKhy0wvrwFb3Ngt3R2yNFQqOnCzQ1Z6gv/OlHtPpKffRvwVOzxxfb/ZicAf8E7WENfKXypb5fKJVtU= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1789555530; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=/JiDjhK9ihDCRHHsJrq/x8B2es8Is22hCKPznDosIPI=; b=XKvpLZEun+1PTko4tJn19KmCDXK/BZLxlMUpVTd+Af7M4HOe1VH+V3Gt0qGgZRfLMo8GB9pdM6fnnc+kYTQDNq4CD1PKaDTQCQ1syoqPSxyG1JVxBbIJEEanhTUwBqw/qGXMg7mouZJUz1wC6C10+Vw/2h63VSxVBq57h2BZrZ8= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1789555530305587.3063856556763; Wed, 16 Sep 2026 03:45:30 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1422579.1647938 (Exim 4.92) (envelope-from ) id 1x6n8Q-0002vj-Ch; Wed, 16 Sep 2026 10:45:02 +0000 Received: by outflank-mailman (output) from mailman id 1422579.1647938; Wed, 16 Sep 2026 10:45:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1x6n8Q-0002vb-9p; Wed, 16 Sep 2026 10:45:02 +0000 Received: by outflank-mailman (input) for mailman id 1422579; Wed, 16 Sep 2026 10:45:01 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1x6n8O-0002pu-Vm for xen-devel@lists.xenproject.org; Wed, 16 Sep 2026 10:45:01 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1x6n8O-002G4Y-CV for xen-devel@lists.xenproject.org; Wed, 16 Sep 2026 12:45:00 +0200 Received: from [10.42.69.5] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6aaa732b-e002-0a2a0a5209dd-0a2a45059d64-4 for ; Wed, 16 Sep 2026 12:45:00 +0200 Received: from [148.163.151.68] (helo=mx0a-002c1b01.pphosted.com) by tlsNG-c201ff.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6aaa732a-4cb1-0a2a45050019-94a39744bb5e-3 for ; Wed, 16 Sep 2026 12:44:59 +0200 Received: from pps.filterd (m0127839.ppops.net [127.0.0.1]) by mx0a-002c1b01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68G8q4Uc541814; Wed, 16 Sep 2026 03:44:55 -0700 Received: from bn1pr04cu002.outbound.protection.outlook.com (mail-eastus2azon11020103.outbound.protection.outlook.com [52.101.56.103]) by mx0a-002c1b01.pphosted.com (PPS) with ESMTPS id 4gqa0pt9xw-2 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 16 Sep 2026 03:44:54 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by MW4PR02MB7380.namprd02.prod.outlook.com (2603:10b6:303:74::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.406.12; Wed, 16 Sep 2026 10:44:53 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::8e97:bc32:822c:b250]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::8e97:bc32:822c:b250%3]) with mapi id 15.21.0406.007; Wed, 16 Sep 2026 10:44:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=proofpoint20171006 header.d=nutanix.com header.i="@nutanix.com" header.h="Content-Transfer-Encoding:Content-Type:Date:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To"; dkim=pass header.s=selector1 header.d=nutanix.com header.i="@nutanix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=/JiDjhK9ihDCRHHsJrq/x8B2es8Is22hCKPznDosI PI=; b=2G8M55Xbdeso9Lyaz/tF/PHCTQMqBf2xkG8nok1Ef+2h9zJcittzfqr7t mcGMauXPWiFcMgudgYQKNvQe3rrW+1ZSTAiOL6WKTIhfn+jmsRGNNaS9BbJrkk+j x0h3VR2NKkL21PZtkgO2kASUf3Tph8S/D+UEQayTUsfH0oo0vWu9GI63UhQjXSTo yS1aT2Y8jSYIbu4k32Z2xqPSrNWMT3R1ZRNWnoH6zMTGjHQ/j3OjJeFFieY1yT01 9CQw91hkbBQWWHm4BEzpN2nOv/YCkA35PZkjLTulSZ+Vt8/WjuTX/EFzCxtGjL0p CKZresKeYd8/WeJvSHOtWbs4UuxAQ== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=FFeHadgar+P43tvQV9tE/xFb3ai4EpiLCUeJWsibWtsk22gG4x+YYkaZYAx2pnYeqsPH+PMk+6GZ6oeydPQcBLw4rhroL3Sut+liZ5RggEg3VJXB3zi7jpS0A+J9qGQaGbzawdUHoIWOoOSJK5nkIfRWkmvtYFs8TuZtBdVQZMvNHXC/P5AHLWTiqPZSdzmtv5sWZbONkISGLSo2dxgqbwA0yttFbQFybQNqSB86vk+zKdRKxvXB508BCF+Z3OdYRzmIhZ64u5IqaQ5wICI5kaySFogIiDii1BLqG95k0ylu7R4nyupvoz6CWvgbeO5wDV8qoQ2B7SFeNgRw8NCSGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/JiDjhK9ihDCRHHsJrq/x8B2es8Is22hCKPznDosIPI=; b=CTyNfM0rxldafRJAYw3lpAYGajwteKkYjWCP3SEDaRdwjBebriMfXb+nK1fg65nZI3E9ikZzTkxiSZNm3buLZsNt90/xvccvQjAeKw9dPe2mzw50gAm+oUGi6DWLP3uqzsJ2pE4jUVkt+vt7tVftqpA7WU1qCNLcq/zbXGCVYeb3NZeNrWksB3k4/Pyqrj50tneb6wBHoI6SKgDmgxn67vsHo3E7oATXhyx3L9B3sSHY74SrF7i1cAsgkOmQAAevX3/ib7KtTHbAe7Mqay8mbbLR8Pg0eaVM3J8nVtIkXY4yPpeYHIWZJdpNvCztJ3KcSaDq8Rk8Xhtb1OJwQ8Li2w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/JiDjhK9ihDCRHHsJrq/x8B2es8Is22hCKPznDosIPI=; b=dRoIrO7O5EuJa7Hg5Ee7wz+vzL1yU6KhT3VCTShpSfE4uiB7yJ0Ifnmdqr6OGTTsyTVKnYjl46OBcfoRbRFXtdyjUqenZ1qnjaj2HXl6rzOFTnqkwNDIDP8exAnCaAwxDuUTRulDzv4TMEEJ9M+QD8X0Bpe/QU7RNu+dkhpZM/IbppyGAbnXME7Ej1Ebv+Tzom0AIOqC5OYYS19zk69bLvXqTU4x4z75V8lq6+SIFSAlN0OEoArn7CYMWXhGtewj2JX+jP0fAexS2CBYc5xAOWcHoYyCtK0p1dam2FeXU/uQC8+CWG1Nh/YURqZhVwUCAvM0iTt73Rlmb2coGgz1OQ== From: Mark Cave-Ayland To: pbonzini@redhat.com, richard.henderson@linaro.org, mst@redhat.com, sstabellini@kernel.org, anthony@xenproject.org, edgar.iglesias@gmail.com, qemu-devel@nongnu.org, xen-devel@lists.xenproject.org Subject: [PATCH 04/22] i8259_internal.h: rename PICCommonClass to I8259CommonClass Date: Wed, 16 Sep 2026 11:43:32 +0100 Message-ID: <20260916104435.600211-5-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260916104435.600211-1-mark.caveayland@nutanix.com> References: <20260916104435.600211-1-mark.caveayland@nutanix.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SJ0PR05CA0172.namprd05.prod.outlook.com (2603:10b6:a03:339::27) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|MW4PR02MB7380:EE_ X-MS-Office365-Filtering-Correlation-Id: 253c477a-c126-49ae-400c-08df13df8a36 x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|23010399003|376014|22082099003|10067099003|56012099006|18002099003; X-Microsoft-Antispam-Message-Info: 9H+ghNKnwKDFH7EdiIysRAASGEH6ET+us2KM5JNcprZM6LUgkH5cGE/7iXOi+nqSseBgAcEp94BQoOBd3mEYQBAw7lCg77EDkj5/hWg3dMYlBrD3yUyuWNlBG+ZkPU3E7vUM7YPctwha+z9z2WZA09tzo3KrY0hgUCri9J68TLOBIx/Awc8V4EMDZ9B31p6cy1gLSuxT3WAj4q7wEOBVaDCjKa6rof46MYErzNpd4p2K/sWaYIfo2y7uXtC/lSPup2ks4zZD0K1pNI2PoNRHfWiqkCN4IaX5LXuARNLTBROe9w9yW5AUlG3pQudCjE1RHuV36hhj9noza5YI3VYytYH/dFrV9oYiUUrZI66O9JOowDvc0fGOuxqSFcQNntHDJjnZe/qahBaofQUXK81baXStdSqOQe+IWsk0MMNiuH0C2QzWmjqftUBHIfuRLvSa6N5Cr2u9+2i1Ogmjq1jyRy4lE9+9LlR5Snh8fuf8IjtPPAgugIrGSjteKXVUTQLAKBO6UyuvmhUeCxh+f/tgeg6liceDNoX4VB+oSXXM317WnK8IXlDNUy1s4y0sUpxf5PVtpPlNBTiEWHPUTUhdqNP+UdhVlreQNtov4NIiuFjZ+3o4e+qXtKYWWTEQi3Z0885XpE/QDlW3HZgnXKGe5ruCCYzr5lqEds95uxm5d+0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR02MB7159.namprd02.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(23010399003)(376014)(22082099003)(10067099003)(56012099006)(18002099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?/Y6aHUZhj4ZcKESIabf8UQPM3yBnXRPfyNlgjdfxCH8lDRbRV8QuT2XgOWjf?= =?us-ascii?Q?H7JL5H7gxOp4WI/265vIpJAiV06O2HZJhkftfbaPu9p94WAU7Het/Tq/NRZn?= =?us-ascii?Q?flXlCmgeBH+asbA4Trz7V1eqAIOdpj3T8sda1VZUvSb2Nmp3SZXatQWCKG6v?= =?us-ascii?Q?uWNG0Ggsgb0vLHt9c7UQBkGXuYfsRKVm7adWS8Bk8yrd8K0uis803yRml3i+?= =?us-ascii?Q?MZk/F0REnx3Epo53JGsoAmjMoXZV+7ZlQoNWJ3Vft8ZeO2HVSLNQGwLUGrMA?= =?us-ascii?Q?1pqChdliLO8ovXa2suRrU2iZwt9iy3VPuamlNqbB8CbcF62VsDXT8TtQnvDw?= =?us-ascii?Q?beCusrVC8HM9gTKawZ/2p6/aHo/wBHJb4kgkgFheqmWecB+EgRLLthd0H0Ms?= =?us-ascii?Q?hVPF3V+bE3dEoBMCAbWOItJa4inEI17aP5x102/5oWcQU6RoBitYdFHgxtHP?= =?us-ascii?Q?MJjwQl9FmHsQW7TyseSlWm3sOTX9IflF3+YSrGL64065aIVjkFJwTUFg2QCU?= =?us-ascii?Q?nh4w4QnX0/V+XHG/9tmE2TslGek8ftUfCau9sdgw+nJQYfif0CXcae5etmuP?= =?us-ascii?Q?pSYhh+06Sxczk4uAKZZnw+P0X1HhPVYenA2czgjIE9cwShXVltYcYQUf1MwY?= =?us-ascii?Q?h5YQQCRpI9USK2TO7WsyvuC5kJ8OflRItrw8NKV+TqrZyXDRhBu5bmZpUBry?= =?us-ascii?Q?8Adq6MZi84+XKC0uEN/50S80mgbVYzuyHAdykGDWxSJGcm3/aex5CPkM99M0?= =?us-ascii?Q?/dHvrn9Q3obzCdvkIs0roF1sGseKjxJAEYBcy7lsQ2Cn0JuJAGxGNEzbl38k?= =?us-ascii?Q?gpZKlSAZfz5ifnQLxe8hBF9k0Z9uZHUF0iS+1AneujNnDLN9IYd5HTPztNY8?= =?us-ascii?Q?9biQZg4GAg/zwuLi1N9fjLo0bEXUz74kmqJ8MDKWflSgmEranMy4JKAyhlsZ?= =?us-ascii?Q?G/rngIPm+q+fok18WHCY6kamOMEUR6wVwGBpgXO/4WCQlIOKk6yeWevk47AE?= =?us-ascii?Q?szuTRb1LexEKma15mASW520xF4AJzo2fmsz/pawdr6n8GkIa2E+sOmnMpBfo?= =?us-ascii?Q?EXJ3nUQDlFho5ViHQ+eu0NdnL1PE+KHvjJReVD4BTJNwtChzGWdnHnOUS2Ep?= =?us-ascii?Q?34sH1WxKD0HVZFReJ+SG9xMLsYNXFUc2clP32ByJuIFawBS1LbIinNZnfFyu?= =?us-ascii?Q?XqoHbxgHHAWIywkcRBiBLJhJ/PFs++Wvgg6RqpA+Mdq9s4AGcr1G4d0usYQ7?= =?us-ascii?Q?frKgH8CokLXWv71xVsw/Eau3Vonln6jHhJMV6GmdClYprp/lQFPckaQ+iXxe?= =?us-ascii?Q?pAL8uFepLOvIQ0B8zRHPEjzvp4kAAA4/N81tTMuDz8O4dKXUhuXgmWGye9RT?= =?us-ascii?Q?C7sYAI4S5cDLRbXmdIcd8e5c5vJlhenXj9JApXOT8NBqStALpyVpB1OJnEAm?= =?us-ascii?Q?mh+ePKPiseq4UdrfGPKc4jgLFOPMpzb3cA5UaDeQGFQTehljCYFzg9cuNr9l?= =?us-ascii?Q?PdertWQl/3krp/EHYsnsFeixSx26IrZElCl4K8zJZaJOqccrCcw0VVrz+UdQ?= =?us-ascii?Q?OCjfkrbcXh2soKFylY46FgiZec2BaFmXwUDXzhX3V5AR1PNCVi4IptfaX4vo?= =?us-ascii?Q?NqqV4+CS5OWv55E8JSmOAVj+dxETFYeoKAdaj42s+vr9zkDUVOe7kZxN6FMk?= =?us-ascii?Q?+bgNwQUsCKTVZwP/zoOzeJiPA9tfDe4MUVKgBX4c5qboJVTRcHJizc02C9Cl?= =?us-ascii?Q?DyI9sPRzaJwgwzVBJX02CUCd+FePdak=3D?= X-Exchange-RoutingPolicyChecked: u2MfnjxmuHq21fyYdaEZAZhzlTRIFc4XsQYS329QN0AmMIOTFNlRVee/I2gtT+Ih/aYZiBgASMQKHKduUtYM70DH/KJKvD6o+Mm4QnkRKjRTJCBt0Te+REJyBisvm078VK4zPORi7JNOyZkRJPMYSOVKToOTIPIH+pEGEYgQCKhVXCG2hWKIEUlt5/lUwSvdN6VMXqjd7XfAdZlwTkBgN84LEYvBvl/gD/N7ygLNOBiOrWHYx3RMDZziNOMLZ8OyBRM/QTZfE7bOcmnLVCrpnlLnfm+sAqQihve0inT/r66yNzsDBHJTT9GuWaqw2AzYgbDLmpaeXuzmbZg38xHElQ== X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 253c477a-c126-49ae-400c-08df13df8a36 X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Sep 2026 10:44:52.9570 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: szo+oyR6Z42Cub15A6V3HoL5abKwWCnUUMV/urC53LXJSk4NZdBteyR346SW+jrCLNTEBqlVQ4rCQUGlc225SquDX43JGbU3IoE8ldMmRSI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR02MB7380 X-Proofpoint-GUID: 6QG87q_fHnRmciYURCiYzuxU4ytyhHfa X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE2MDE0MSBTYWx0ZWRfXzD0hUIVFxmFS e2wMDX8/qZmRMSlktjwNtT2ZKNax+aqlFtpmhYXdj0vb6B1g7bNtVaogTac/Iu0D5Jlxt4N3uqY HJE/WK8gndrngs3T/mr+LkttGMeaD/o= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE2MDE0MSBTYWx0ZWRfX6lmGkHivmc+O SIfzKS6onzYc37akVMtRkp+0B7NG7Atj7GBPTSRx2cKzmq1Tz8keGbpOkDjKdkRwAMviKgnDWG0 jK5Dyxt0vv3Z0OXtplVBXMhSiuf6PigSiv8CJdB68beC2a0PB/z/e7E6l/s8ApG5qjn0C1LWTTw uG8uuEWgO6N4Lwz7iIqkVWGuXfUlk05ql/ZvJhlUXcsujd86rJ3S31dyF8+icVQg1BWBVNFaIxa VcnHxdN6r3qhZ3VjBm5lbHMD841wFrPxpGbHKQRkzaKLia6SkNtMyciR5aLTf8oPnU2gZpKuJQt o9A+xhK51N7UZndnhAYW1I1dywA2y19kZYkdOuOaPbJ7SF9fSc8yTQvYsBmd+3T4CjPZrtsebRS EFwKoh/BTLwO+hPoBus/8/dBQSIBMxuogNk07wu3vVz8NOJenrAJDFze/sButiOF2YnUOXr3zfU t1WySzR4464WZ0EDy1Q== X-Proofpoint-ORIG-GUID: 6QG87q_fHnRmciYURCiYzuxU4ytyhHfa X-Authority-Analysis: v=2.4 cv=Ps4G/AM3 c=1 sm=1 tr=0 ts=6aaa7327 cx=c_pps a=WPXs+xwE9Zb4LCNJX07eKw==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=xqWC_Br6kY4A:10 a=VdqzKS8jKosA:10 a=0kUYKlekyDsA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VofLwUrZ8Iiv6rRUPXIb:22 a=y4UcunY2MAxhM4LwGdWI:22 a=64Cc0HZtAAAA:8 a=qh9Ixq9Ib_qUO60TQ2wA:9 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-15_05,2026-09-15_02,2025-10-01_01 X-Proofpoint-Spam-Reason: safe X-purgate-ID: tlsNG-c201ff/1789555499-24D1E2A1-06DE47A5/0/0 X-purgate-type: clean X-purgate-size: 3236 X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1789555530780158500 Content-Type: text/plain; charset="utf-8" Signed-off-by: Mark Cave-Ayland --- include/hw/isa/i8259_internal.h | 4 ++-- hw/i386/kvm/i8259.c | 4 ++-- hw/intc/i8259.c | 2 +- hw/intc/i8259_common.c | 6 +++--- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/include/hw/isa/i8259_internal.h b/include/hw/isa/i8259_interna= l.h index 7a2f9addaf..e039d6f067 100644 --- a/include/hw/isa/i8259_internal.h +++ b/include/hw/isa/i8259_internal.h @@ -32,9 +32,9 @@ =20 =20 #define TYPE_I8259_COMMON "i8259-common" -OBJECT_DECLARE_TYPE(I8259CommonState, PICCommonClass, I8259_COMMON) +OBJECT_DECLARE_TYPE(I8259CommonState, I8259CommonClass, I8259_COMMON) =20 -struct PICCommonClass { +struct I8259CommonClass { DeviceClass parent_class; =20 void (*pre_save)(I8259CommonState *s); diff --git a/hw/i386/kvm/i8259.c b/hw/i386/kvm/i8259.c index f10643a120..68607d721d 100644 --- a/hw/i386/kvm/i8259.c +++ b/hw/i386/kvm/i8259.c @@ -29,7 +29,7 @@ DECLARE_CLASS_CHECKERS(KVMPICClass, KVM_PIC, * @parent_realize: The parent's realizefn. */ struct KVMPICClass { - PICCommonClass parent_class; + I8259CommonClass parent_class; =20 DeviceRealize parent_realize; }; @@ -142,7 +142,7 @@ qemu_irq *kvm_i8259_init(ISABus *bus) static void kvm_i8259_class_init(ObjectClass *klass, const void *data) { KVMPICClass *kpc =3D KVM_PIC_CLASS(klass); - PICCommonClass *k =3D I8259_COMMON_CLASS(klass); + I8259CommonClass *k =3D I8259_COMMON_CLASS(klass); DeviceClass *dc =3D DEVICE_CLASS(klass); =20 device_class_set_legacy_reset(dc, kvm_pic_reset); diff --git a/hw/intc/i8259.c b/hw/intc/i8259.c index 45db87a2ad..547e86c5f4 100644 --- a/hw/intc/i8259.c +++ b/hw/intc/i8259.c @@ -44,7 +44,7 @@ DECLARE_CLASS_CHECKERS(PICClass, PIC, * @parent_realize: The parent's realizefn. */ struct PICClass { - PICCommonClass parent_class; + I8259CommonClass parent_class; =20 DeviceRealize parent_realize; }; diff --git a/hw/intc/i8259_common.c b/hw/intc/i8259_common.c index 17040bdb1e..ac8dc7cf00 100644 --- a/hw/intc/i8259_common.c +++ b/hw/intc/i8259_common.c @@ -56,7 +56,7 @@ void pic_reset_common(I8259CommonState *s) static int pic_dispatch_pre_save(void *opaque) { I8259CommonState *s =3D opaque; - PICCommonClass *info =3D I8259_COMMON_GET_CLASS(s); + I8259CommonClass *info =3D I8259_COMMON_GET_CLASS(s); =20 if (info->pre_save) { info->pre_save(s); @@ -68,7 +68,7 @@ static int pic_dispatch_pre_save(void *opaque) static int pic_dispatch_post_load(void *opaque, int version_id) { I8259CommonState *s =3D opaque; - PICCommonClass *info =3D I8259_COMMON_GET_CLASS(s); + I8259CommonClass *info =3D I8259_COMMON_GET_CLASS(s); =20 if (info->post_load) { info->post_load(s); @@ -223,7 +223,7 @@ static const TypeInfo pic_common_type =3D { .name =3D TYPE_I8259_COMMON, .parent =3D TYPE_ISA_DEVICE, .instance_size =3D sizeof(I8259CommonState), - .class_size =3D sizeof(PICCommonClass), + .class_size =3D sizeof(I8259CommonClass), .class_init =3D pic_common_class_init, .abstract =3D true, .interfaces =3D (const InterfaceInfo[]) { --=20 2.43.0 From nobody Thu Sep 24 19:04:36 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1789555531; cv=pass; d=zohomail.com; s=zohoarc; b=cBvA8KtyvDwMQSLYLOW4vp3CiAb6lQAHLpH0vr3wx0szGcoisSjbQStaQ8lP8GUOIPImytjRq2gwu0wQjbA3EG35y99luFg0emSqxhxq5Q3Rrsx0ct6K7fkXKTPSHeQZYtO3S70KOlJ4YORALNfftqfL8rQ391paYPhuh6yl5zw= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1789555531; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=v0kaGrtHuAWW3BhosR58UAq4Y91huIt/VByeAJS2Uco=; b=iDuhbhj95A7btDL3nOwxVLzTuun+dLnCaThSiXytH8dSkU/j6AkAAnoHMSGndGqkssrVhTmaoNo9oaeJOVdTbkfAM/gYpFj1jxaoX8RFIBCOneRmqmLgZ6Q9jBV0hWkLSMcsloe2F/xrilh4bAP9jbKHZ0ah4nwTLDnqGCQGW2Q= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1789555531229286.37095372182034; Wed, 16 Sep 2026 03:45:31 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1422581.1647956 (Exim 4.92) (envelope-from ) id 1x6n8T-0003PK-6y; Wed, 16 Sep 2026 10:45:05 +0000 Received: by outflank-mailman (output) from mailman id 1422581.1647956; Wed, 16 Sep 2026 10:45:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1x6n8T-0003PD-3n; Wed, 16 Sep 2026 10:45:05 +0000 Received: by outflank-mailman (input) for mailman id 1422581; Wed, 16 Sep 2026 10:45:04 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1x6n8S-0003KK-0c for xen-devel@lists.xenproject.org; Wed, 16 Sep 2026 10:45:04 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1x6n8R-009uGc-Cx for xen-devel@lists.xenproject.org; Wed, 16 Sep 2026 12:45:03 +0200 Received: from [10.42.69.6] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6aaa732d-2eae-0a2a0a5409dd-0a2a4506cbf2-6 for ; Wed, 16 Sep 2026 12:45:03 +0200 Received: from [148.163.151.68] (helo=mx0a-002c1b01.pphosted.com) by tlsNG-16d1c6.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6aaa732d-195a-0a2a45060019-94a39744f828-3 for ; Wed, 16 Sep 2026 12:45:02 +0200 Received: from pps.filterd (m0127837.ppops.net [127.0.0.1]) by mx0a-002c1b01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68G8j54J700548; Wed, 16 Sep 2026 03:44:57 -0700 Received: from byapr05cu005.outbound.protection.outlook.com (mail-westusazon11020092.outbound.protection.outlook.com [52.101.85.92]) by mx0a-002c1b01.pphosted.com (PPS) with ESMTPS id 4gqa0ka9vx-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 16 Sep 2026 03:44:57 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by MW4PR02MB7380.namprd02.prod.outlook.com (2603:10b6:303:74::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.406.12; Wed, 16 Sep 2026 10:44:56 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::8e97:bc32:822c:b250]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::8e97:bc32:822c:b250%3]) with mapi id 15.21.0406.007; Wed, 16 Sep 2026 10:44:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=proofpoint20171006 header.d=nutanix.com header.i="@nutanix.com" header.h="Content-Transfer-Encoding:Content-Type:Date:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To"; dkim=pass header.s=selector1 header.d=nutanix.com header.i="@nutanix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=v0kaGrtHuAWW3BhosR58UAq4Y91huIt/VByeAJS2U co=; b=dse14ZTYUTLslaaYJwd1AdvlSIwpiyGZovETRTb94qD1ZfKjBAsUmM58p t2fn2D6OvQ6x8zYQSZc2AZS25EeOqQ9qkaHRbRNoIUil7jQoh/InpJXbhSr6dydW Jn/vftsoy7Hw/ziJ7Um8uBFTDvgYPkx1vabyX+AQ3picI8aoAdRnoCqoPjcJc9RJ K1VAC94Kw4OXOXIUHWEG1ZM1Z5YEjMtn9bC1er+dRxe8NVfCt629OFo+G65Gid2p y1ROGUpSTUNfT/zWGZzkYmB+KKkoo45qh4MpUN23cmnBncoPkyrgYL6pKbdcYu3z RznQCX8I0OiqmnKrdndF262cOW4CQ== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=cOZHR7B0KZ10MZ5h7Hu45RrRKErR4xJDqbed9pBIujBoSW3sOqta92RcVPJ+MVZSjrlai5M71IPaVE9o7Np8gWy5+m1t0rUj0Zn33SwA92sKVfrouRWIqTYB5XmDoHkyu9eiBggwWm4k3AQcwNnpu4hy4O9q+yIp7US4Ua6a7H02zzBK8xaVwaWfk/Pw61CgyEH2xbl/q97+RQfGE0eKawNBVhzpNMO+47LlLkEDI2xa+SYc83b/EQ6atRC15ssgDpyxlPWfGir1VUrTBGVetN8gyb+g5GoTjGCOGMkbKYf/QFkWN0fT4G9c4Ad5KCbi6eiUIsmPWLegeXdjyUswVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=v0kaGrtHuAWW3BhosR58UAq4Y91huIt/VByeAJS2Uco=; b=NQ54SL+D+qsPMEEKb82HxvlK6MX1lYOwS1wBg4V+7x4CABbKlE1g+tRLaxSiUrNZhmNnx0K4RWec5zVdJ4o2yw/mJWyBzdJsV1M3g/XlwIdgS0ISFFowp48iEns5zlSdDFiYCCnApTFr1IpX0RYjprmWtoyDPdPPwcrhWIu3JXWoi7dnwMSrmrEHS7N358kag2RDdidni58HVInmOr2F/lUB8MP3ndE9QQquFhhPL0337e3wnE472DDWl6LD64oEpe6xFZGqMMKx4qR9IBQwXycauJhnxtidnLspR3F2lhd/OeIZTxNgVTVfqINMu0ZoCKV7JOC83zsYD4mF5RNIoA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=v0kaGrtHuAWW3BhosR58UAq4Y91huIt/VByeAJS2Uco=; b=fm8ZRSb2cyR5AK1+NlVV8PivMgqzAvdhG9pvC0iCcBoZXXbKzSgxpB9kOb6t6hXxxx+6PVjsgDC6//HBQNGj7UFMHgLFmkogjTjI4R6hHWGLkYVhjc8RQczES1zF81WWE0MCzqnCBWwxd7M2WN0agabEScGNSIl7N21adMopsZZbmdJ7K1/88AnHhoaEpu8XFt33S6G+2/KgtsbcrApU/kwlCCQhxkeD8raeEky8LP8Lpns50cOYuGcBZQK6ZqnuTYMVeyQTNF4oCKAbTO6bKgWxWHzTcH4IsXAUZPhcOg9VVIFA6NUKf5tAt8gne3v/0WOc6qfo51+15mwvW6XTng== From: Mark Cave-Ayland To: pbonzini@redhat.com, richard.henderson@linaro.org, mst@redhat.com, sstabellini@kernel.org, anthony@xenproject.org, edgar.iglesias@gmail.com, qemu-devel@nongnu.org, xen-devel@lists.xenproject.org Subject: [PATCH 05/22] i8259.c: move parent_realize from PICClass to I8259CommonClass Date: Wed, 16 Sep 2026 11:43:33 +0100 Message-ID: <20260916104435.600211-6-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260916104435.600211-1-mark.caveayland@nutanix.com> References: <20260916104435.600211-1-mark.caveayland@nutanix.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SJ0PR13CA0205.namprd13.prod.outlook.com (2603:10b6:a03:2c3::30) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|MW4PR02MB7380:EE_ X-MS-Office365-Filtering-Correlation-Id: d6fecace-1a57-44df-fb14-08df13df8c39 x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|23010399003|376014|22082099003|10067099003|56012099006|18002099003; X-Microsoft-Antispam-Message-Info: 6XrZisVsJ2t8aDwyDz7LWugPmBd6G4B1BeuENS0ib6rXuq7GKZO8J9J6zIHC6uslGcsLZSpGdtuaSST2BrLHt9TysBKdgHtFg7WoxDRwehOWt26fIO98+esuL8gXrFHLM4dTx7PAqeejKUbEEvVk4XIqaZfi13BIUEB/J/qGvRl0N55zY/b5QP6tGro9sd7f9VQxoajL/Skidi1/+f6gYwdlaA6ivkO/ej8JAIm2nsC4rfU/ZL8noZi+m+77WFmFsHQiP61o8fXHj7ViqGKLqjd2JYqFcb6zvx4hEcTvcggl4CfuMrOwRkvsJVSJSl3cZscrtrtv0DNuEJN66Zonqm4IdttnW9sYyn4Zf94lK9TAosK4VoPQInORS6+oP4B+Jp5+DGzsdOfIh6Qq59H8yFbVCW5ftVAAA+SxyKqeXqXp9VnawjBQs99ArU6GE7yWjKNjb/Ynsna7gN+8YKg/a5l1hIBAIIA8s0bp32G6yM1h/dsMJF+Fa/MqsbTqrPsIzFCsFFxrQfUWqWC7wri8DRquH18drMpd46vDvBqWI7ei4Kpau0npCI5Vu8MwUv0T3Y3XYK65oB6LSxpf1bQ5f37if0zlpOqGjShlnqNjD9u4mErAAMysUWSXsrAsAhvh7lgdqVyEC+pFOX3j1sBbXrGoo3vtfVG+/FJEfCF6fCs= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR02MB7159.namprd02.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(23010399003)(376014)(22082099003)(10067099003)(56012099006)(18002099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Ws2oX42ZeYUHrXOtJ5se5MwjBoOUjxH2V/pu6fizyM/2kiK/1N1BN5HcayCk?= =?us-ascii?Q?3LyzfZD16sVuMlyErwUIKk0eNQ72VO1aAVD7Z53rMMHYGz2RzGdIJSvX35Eh?= =?us-ascii?Q?zGFWamTNfCuiRdx5fQUzgKS9AdXqHbFshFGZknLxeHWSyEqo5Le2x1BRJV5i?= =?us-ascii?Q?pau8cvoBcRRlwVmtz9kHEVM5DrEWHt32Y/Qxqc0BqwmBf/J4XUvAWPrmh9Vr?= =?us-ascii?Q?Pvtu0L3Azegu4FhYRR9afL1rjA8bT2cJ2MoLfuLxFQp0s29Xu8dH8Uivj5Id?= =?us-ascii?Q?3VcbTTmOrlYv+cRerBmNifeMoOwjO9IOIE410Q1IknAREmLk9whlWRCDc6GL?= =?us-ascii?Q?RPBfle8ZIgRMdLGdBI2WVmd8kvr0HnqbTaAk3M3rMmjmUwRS+WMmJTmOg1sb?= =?us-ascii?Q?HpnuL+TxtmxeFU324/l5qB/O4UXXPZJpHaIsJwRxq9J566dRULPNeCRvROqE?= =?us-ascii?Q?HuuDv/kn921/zihffHS2ZXpWb/TiZyyeU867RBgxUPgg3olQ2knXzpr3y6Tv?= =?us-ascii?Q?sYkRpIhQAouqgTDamYcoLHwHigpfo8sVg0HzLxDxblL5UFM/2pihjf0rp8TL?= =?us-ascii?Q?Ce3ztaLfUPkxCHVzC0gP3DGiP7XVD2DN/N/GRMtwxyyIvrsO7krbAhvFr4Vt?= =?us-ascii?Q?ppSybhB7qozc1aMQN/ag3q/XZV76po+C20O5HjA3b+8JchWof92Lzr2TsJhh?= =?us-ascii?Q?DvslmjuAGr2di8eGOrx6hXbyDZ2dq5Iz0/PrnkCT4zkVS3BAK3ts5+rQRHkq?= =?us-ascii?Q?Vjpsks9F7NgOvzskO+lJCRTOhMvjgcvSQSIEKgacVjP8oJ5CXQcmBz5zET1M?= =?us-ascii?Q?n6GVla5t6W1bG4xZ1p9jZZ9zNiFyl9bg68jAv1/KuBSqpfqZjXorsb6TM9CR?= =?us-ascii?Q?uo5teBQKrIj4ij3SRpbc8TL+QN/ow/R1+bK3Twcegqjp53VG2vx1ZLHNjA/v?= =?us-ascii?Q?2AoarONCnXS5/1ThzHrlRV0MVR6OXJijx9GPyYq8JKXBWdM/pHCzBZcD1UaA?= =?us-ascii?Q?nYOFr1o32EroojmFF9iM5Uz+g7IXIGaOUTKh49VJeddAMd7N/KOogXh/gMpo?= =?us-ascii?Q?XOVxDmu8ZvKlvObn/t3otSjM4K10rHBbjwaovd23bSqG3H1Ygw870Ds4B9TW?= =?us-ascii?Q?iNxxsXmd/XXldUN1jsdJ9I/VuQ1XDN4M1igiJQ4HgaPCsEZIJwUhA7OVynxI?= =?us-ascii?Q?qJ3BYUA//pTAQD0oeRqXX2pygTvIMKKUQ8QqK9+K3KA51ErARIfRzk7MrEgd?= =?us-ascii?Q?T9Gm/V/CwkJW+jAH6++zgDlczgS6zfvgybqqpFUurt8uLqg12FxlZiEsa7xB?= =?us-ascii?Q?ogNUfBGzfXvn58qEB0p9S5c/K5ujfgzconh8PQGmav0YQSWsBulg6KbSnGdr?= =?us-ascii?Q?7uxDaqsAK9KY0nyu0DVD6rr2MUOGevgfkjMqOpnAY6V3PNndc/cJvglZJINy?= =?us-ascii?Q?UAH4uCOygWbneKaHXU+SpkSLsK941r1yv09BXdH36+mTy8UKBEDj+PmT/dsp?= =?us-ascii?Q?GsUJPordlD1RP8YZPe/OTI2GOW52Prcwpr6qlmLqa2L6JC9EQaruFtOdlTwg?= =?us-ascii?Q?66UGoqu7lLK8ypuQHHKLX+PbOuMGs9TlvedtIAuYNBrnqLXF5V0l9Y6IYxiP?= =?us-ascii?Q?kPLjYlTd2Em18kJSZbRCMqnhkql5U50kEnkC81pJaY1ICfWr3RFjxGvG74/M?= =?us-ascii?Q?GU6Z1M/ul8CF7RRpjyi9CJycPEr6H4s3JvlOcYW+a7PmN1IGVSquVP25ZNSi?= =?us-ascii?Q?2XWXsdmoOGNqWfG7zk35DxHqsb64bDc=3D?= X-Exchange-RoutingPolicyChecked: qZqCFZo609+/6AAEK5jj4c5MtFYNF+p7zgH/aSytJnrlgV/f1shxLwq8f3D0T9EcZwtUBvZel6jeSxOinRlSVdyX0yLJmC0L9Z+Pipn0Q11sv4bpoK7lnR/cVXsAfHGEK10QQdrxsTS3wYiMZOVs8dmZ7OSUOEkdS4zShDoosVVmJpopqY45DODJNwtvISbNyEm6bdj86US4u1k7SpNsJx+XQVbRCywZiu8ufh5D8Ag0dIAvohDd0gZpaR48oPGmbzaXqhPgDNCgqsQv9EmvuzXpo0Xj22BAYsdYfJ3vQ7DWLKU6ZlUXtfeZkC+gc0lBvtd5j0aRrUek8haNamKZaQ== X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: d6fecace-1a57-44df-fb14-08df13df8c39 X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Sep 2026 10:44:56.3169 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: GCvl1ght25PaCEj9zR6R2GF/tWG9ndXTToP3OHyNObdTy0YHeK+pAl0RX7wXyy8WP0cT7/34n8+h89n2Hk2dGx4niDEG8SD8fb3TUAN2ygU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR02MB7380 X-Proofpoint-GUID: 6S3yKRD2RXniTedcURJuooGA0kiTLUxg X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE2MDE0MSBTYWx0ZWRfX+fd2EWzCHdks UsyjeJCBtiIMuotuc2DI6cdp8NumtpdpryfYHgzy838au1MmsZqvpLIxg3GHnsWbU4grQU1iBM1 TVAd0bAe4onLW+CLpG1esk92On9Bl1k= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE2MDE0MSBTYWx0ZWRfX1amkBnlD4tw8 QRnJvbvhnkPkcX3EN6upw8OuOu/IZmj7dNYcO6wJxx2/jCRb5KxFgAMcPv9sLaeixMJ6gadOy0W QesPP5XSve9qPDylAyeSM7ZKAPWx9s5ywCRjKur+zl3MgHOUBtXL6WQh8luMEYhKQq8lrUmTsjb 5zC7P6FjfUHuQEOJJS47On0bwVVbSm3Hpjo9BNXA3LOXZdUJur6UX03L1hsqedFuVy+XL/QEZmt aQ24zRlI6qclTyvQckbFAdgnbIGOK6pDq4vOf8fvYUeei3jyM6T+bhDmiVW4XWSDxg8uWIhW/RZ 4CeaMfwabFnIRhMv2MCzajUfXBUR9TBs2s2QxQgMrVjTZzgkyOX5F1evBnOo2Ejv1dbEhbscRy2 XmuQRMXb77sHhen+fe6mQ2yBUWrwOfF0fi8cNGO+dpcjOYaxBSwP2Ph35KANxmvPsr7eOqbHvQx 7dkDotVDQLaQkAJHXmw== X-Authority-Analysis: v=2.4 cv=P46vFSAu c=1 sm=1 tr=0 ts=6aaa7329 cx=c_pps a=rN54qV+o3v1qfa0lUeS+bg==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=xqWC_Br6kY4A:10 a=VdqzKS8jKosA:10 a=0kUYKlekyDsA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VofLwUrZ8Iiv6rRUPXIb:22 a=Ap8k9tRZuQ82DLYWQqG7:22 a=64Cc0HZtAAAA:8 a=REJzgUj2r183NUftQ48A:9 X-Proofpoint-ORIG-GUID: 6S3yKRD2RXniTedcURJuooGA0kiTLUxg X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-15_05,2026-09-15_02,2025-10-01_01 X-Proofpoint-Spam-Reason: safe X-purgate-ID: tlsNG-16d1c6/1789555503-F5E0E77B-7109FD4D/0/0 X-purgate-type: clean X-purgate-size: 3022 X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1789555532817158500 Content-Type: text/plain; charset="utf-8" Both the emulated and KVM i8259 implementations store a reference to the parent_realize function in their respective classes. Start by moving parent_realize from PICClass to I8259CommonClass and removing PICClass since it is no longer required. Signed-off-by: Mark Cave-Ayland --- include/hw/isa/i8259_internal.h | 2 ++ hw/intc/i8259.c | 21 +++------------------ 2 files changed, 5 insertions(+), 18 deletions(-) diff --git a/include/hw/isa/i8259_internal.h b/include/hw/isa/i8259_interna= l.h index e039d6f067..e2b0b00f5b 100644 --- a/include/hw/isa/i8259_internal.h +++ b/include/hw/isa/i8259_internal.h @@ -37,6 +37,8 @@ OBJECT_DECLARE_TYPE(I8259CommonState, I8259CommonClass, I= 8259_COMMON) struct I8259CommonClass { DeviceClass parent_class; =20 + DeviceRealize parent_realize; + void (*pre_save)(I8259CommonState *s); void (*post_load)(I8259CommonState *s); }; diff --git a/hw/intc/i8259.c b/hw/intc/i8259.c index 547e86c5f4..131aaf9b04 100644 --- a/hw/intc/i8259.c +++ b/hw/intc/i8259.c @@ -35,19 +35,6 @@ /*#define DEBUG_IRQ_LATENCY*/ =20 #define TYPE_I8259 "isa-i8259" -typedef struct PICClass PICClass; -DECLARE_CLASS_CHECKERS(PICClass, PIC, - TYPE_I8259) - -/** - * PICClass: - * @parent_realize: The parent's realizefn. - */ -struct PICClass { - I8259CommonClass parent_class; - - DeviceRealize parent_realize; -}; =20 #ifdef DEBUG_IRQ_LATENCY static int64_t irq_time[16]; @@ -388,7 +375,7 @@ static const MemoryRegionOps pic_elcr_ioport_ops =3D { static void pic_realize(DeviceState *dev, Error **errp) { I8259CommonState *s =3D I8259_COMMON(dev); - PICClass *pc =3D PIC_GET_CLASS(dev); + I8259CommonClass *k =3D I8259_COMMON_GET_CLASS(dev); =20 memory_region_init_io(&s->base_io, OBJECT(s), &pic_base_ioport_ops, s, "pic", 2); @@ -398,7 +385,7 @@ static void pic_realize(DeviceState *dev, Error **errp) qdev_init_gpio_out(dev, s->int_out, ARRAY_SIZE(s->int_out)); qdev_init_gpio_in(dev, pic_set_irq, 8); =20 - pc->parent_realize(dev, errp); + k->parent_realize(dev, errp); } =20 qemu_irq *i8259_init(ISABus *bus, qemu_irq parent_irq_in) @@ -435,7 +422,7 @@ qemu_irq *i8259_init(ISABus *bus, qemu_irq parent_irq_i= n) =20 static void i8259_class_init(ObjectClass *klass, const void *data) { - PICClass *k =3D PIC_CLASS(klass); + I8259CommonClass *k =3D I8259_COMMON_CLASS(klass); DeviceClass *dc =3D DEVICE_CLASS(klass); =20 device_class_set_parent_realize(dc, pic_realize, &k->parent_realize); @@ -444,10 +431,8 @@ static void i8259_class_init(ObjectClass *klass, const= void *data) =20 static const TypeInfo i8259_info =3D { .name =3D TYPE_I8259, - .instance_size =3D sizeof(I8259CommonState), .parent =3D TYPE_I8259_COMMON, .class_init =3D i8259_class_init, - .class_size =3D sizeof(PICClass), }; =20 static void pic_register_types(void) --=20 2.43.0 From nobody Thu Sep 24 19:04:36 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1789555528; cv=pass; d=zohomail.com; s=zohoarc; b=LGn8sBuWVmq1t24WeRB4ZI5XIq1DO1akEuZNMTIip2RnfPTVfZEaDtIatmXWSehhEaT2oElC95mhiI/6uekyGSHuiNuKs2Mo4DzJ4A6rDOs6ZP0sNpZPcQUsbWu7LWqazUGUPpTlRy3jZqp5exPKddP4eCcLvbnFy3B+6dz9JGo= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1789555528; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=b4a1VVZQ1aZOauQn24XOWH2/qUfMYMvEynGh+kmjSlA=; b=XThtMYI8wItxl+wpQPLqfrQPiG+Y13MbrYjUrzghy0qENfpJ2mYBmZhLhoLSZKMCN1ySMhYvbs6j/n2MyPGODnNqE7H8xeIgFkIaNu8qQq3e0EOnld55O5YC7pvNsMKD5M/WYP0rFDyTvqDGk419fRV5jffAYnc+EIm68+GfAxg= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1789555528195341.94509885934735; Wed, 16 Sep 2026 03:45:28 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1422582.1647965 (Exim 4.92) (envelope-from ) id 1x6n8X-0003k8-En; Wed, 16 Sep 2026 10:45:09 +0000 Received: by outflank-mailman (output) from mailman id 1422582.1647965; Wed, 16 Sep 2026 10:45:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1x6n8X-0003js-BB; Wed, 16 Sep 2026 10:45:09 +0000 Received: by outflank-mailman (input) for mailman id 1422582; Wed, 16 Sep 2026 10:45:08 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1x6n8W-0003gE-6a for xen-devel@lists.xenproject.org; Wed, 16 Sep 2026 10:45:08 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1x6n8V-00Gz7F-1i for xen-devel@lists.xenproject.org; Wed, 16 Sep 2026 12:45:07 +0200 Received: from [10.42.69.12] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6aaa732c-8faa-0a2a0a5109dd-0a2a450cb4b8-20 for ; Wed, 16 Sep 2026 12:45:07 +0200 Received: from [148.163.155.12] (helo=mx0b-002c1b01.pphosted.com) by tlsNG-d25034.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6aaa7331-f479-0a2a450c0019-94a39b0c405c-3 for ; Wed, 16 Sep 2026 12:45:06 +0200 Received: from pps.filterd (m0127842.ppops.net [127.0.0.1]) by mx0b-002c1b01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68G7x2ou3215142; Wed, 16 Sep 2026 03:45:01 -0700 Received: from bn1pr04cu002.outbound.protection.outlook.com (mail-eastus2azon11020125.outbound.protection.outlook.com [52.101.56.125]) by mx0b-002c1b01.pphosted.com (PPS) with ESMTPS id 4gqbt7a0e8-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 16 Sep 2026 03:45:01 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by MW4PR02MB7380.namprd02.prod.outlook.com (2603:10b6:303:74::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.406.12; Wed, 16 Sep 2026 10:44:59 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::8e97:bc32:822c:b250]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::8e97:bc32:822c:b250%3]) with mapi id 15.21.0406.007; Wed, 16 Sep 2026 10:44:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=proofpoint20171006 header.d=nutanix.com header.i="@nutanix.com" header.h="Content-Transfer-Encoding:Content-Type:Date:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To"; dkim=pass header.s=selector1 header.d=nutanix.com header.i="@nutanix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=b4a1VVZQ1aZOauQn24XOWH2/qUfMYMvEynGh+kmjS lA=; b=y+/5AS/N2zk9y5fdI5wfAb97v8e+ELn7SYJ4vwpgoPnIzcczycY7gGvQs 3/pPrSOYGQqAVo0NuWwndRO0ngKhvmZ2qij80i5msmEYMoLbECD11K6thlRloJbN LpGzEi6qQzLhhXpYEcjB/z+nfUMgM5by7IQz+cP1GKJEdl76TigRAo93wvinqiPq y2mEA60afVjalh3ytcmCG6fcuDoh/jK9LHrSa6QqMW9dqskhoiLjL5JpGSe9PJSu tKNTiuCxIxWsNJD5BE6IlWKZURWxFH/VDu2VGRG8PlmL4Bx/GKWrRelStPBtumsU JPaStMkDUhzsPSU2fA33Dy1NiW8Kg== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=JVrSN/8qfPXU7fBMOlJLhPTSEqOqIZV6uFR0YaEk1v7DBKKvkWVp7Oppi4YzYyBXfT9I//iZE0OADALjnMuK9Yciho3Xe8uQ1OpFAUe9e6A1RAV8h4kX8X7slC4F1cUrC4pfzsBo1tBc5HToYlMpuICr/YJOVohWi0RGNPQglRuhWsONJfhXIuNWS0M/eQHKsqU8zkoL4ft+Gxyb3QKTz+EOqeq+blwkWV/kFXRVQC6WHGTUjs4be/u5KuuDR8TaZewMUvKGLJ2Z87KzCNUxYwElQXwtX99d4itct/z0gegpOn86y1caBxxsFn+689lXSVb9Il2zQrLg/AC7G57bww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=b4a1VVZQ1aZOauQn24XOWH2/qUfMYMvEynGh+kmjSlA=; b=XJmJEYb1XbNefDZHTOgbzcddC3unWyAYyPY7p9eF+eQJsuRGhhBX4eReBa23o5DHl2WOYt364AlgAmRkw9fZM+m35RsbuDG/stfkbpi/gUKdy91Bg/o5c72fbrPXXqsUIVhok0TYTfRVGJzIZ1gXazzrLAiDDtnMkGWU7EZ7Ho10kRTxD67KALL4gcNxV4nG18UBVMuTbaJCL9xvqqQjcnrtrm+EA8+MIXo5EmPM/ASP9h3PhUzllk3Xp0k/houNuWUVUH1tabDNdFLvjvO1T8p3H5NDuaZZSon+lnuC5WWkkMv95TtqAs1SJtzFEFEfWQvlhmGOOqBSFb6PBq3i1g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=b4a1VVZQ1aZOauQn24XOWH2/qUfMYMvEynGh+kmjSlA=; b=sNPeExw1tAdIH9+QfxnsDQ4DwtMJfvsIBb6qIjki+eUC11DGcFWZ4ni2qYOQQZ74ODNLKTsmf6+knzjL/fXJu0RCIyAsF0SFg3FpYcJ8YFnG9kFOJ1xIY8nZr/yNhLrM9n80WNNP1VDMlfMBvYSQX7Qrv808l7oWe61DR5q/xeX41BwVaKI4cfDTjoZpAJVtGkVmEWhk926rzF+I5bCoofEY9L1oANkclQ2oLv46unB1428lWfQM5r7IEJMWlgrFPqerXU4ih0mZyYvQZCNjO1enoOU05RW9j3ctyqlx/dMzj471cJQizFd/2yXQn4Zk28BBQ5rXJPcGGnUVNIqKNg== From: Mark Cave-Ayland To: pbonzini@redhat.com, richard.henderson@linaro.org, mst@redhat.com, sstabellini@kernel.org, anthony@xenproject.org, edgar.iglesias@gmail.com, qemu-devel@nongnu.org, xen-devel@lists.xenproject.org Subject: [PATCH 06/22] kvm/i8259.c: move parent_realize from KVMPICClass to I8259CommonClass Date: Wed, 16 Sep 2026 11:43:34 +0100 Message-ID: <20260916104435.600211-7-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260916104435.600211-1-mark.caveayland@nutanix.com> References: <20260916104435.600211-1-mark.caveayland@nutanix.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SJ0PR03CA0252.namprd03.prod.outlook.com (2603:10b6:a03:3a0::17) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|MW4PR02MB7380:EE_ X-MS-Office365-Filtering-Correlation-Id: e108a641-3265-48fb-48b8-08df13df8e4d x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|23010399003|376014|22082099003|10067099003|56012099006|18002099003; X-Microsoft-Antispam-Message-Info: JiKH92oK2ZnSvZA2C36llbjqvWUHpdy/5Tlkt2075BxWtew+XOBkirf9oXYeXeYJRO0xu+QaHwLbeT9LKOqzkmNdXMA9EXzj8hD8xuZ64fIuH5Xu5Hlts0waUtr6Ny7Oj+P05heEfnHCH4Q2BQigKyGyOcvQ03/39qUUG3i6Axd1IZBvCq8QBZEwQ2VMmq8yLXzQkgj/3WJLXqZvEOfYO+Zu3QeBui/qjb5+u1ySzMxixF+bw0IKUiEHrsVAC9vYMIOqll6eKCYtUS9FKTFduPWJMBnOmM2ojy3UrHRRCUgVmcW3iR4lPmzaYetrCqDm6sfv4PkHq0NpuMnWvbjQsvph+3ktyv+2zmAPE8u2bVJYsWWjIDB9LXIXWyzk4YDVKgFykhb4SVXx57sXeXbfGSCRx8WkWFl66dRjIGzRqSG/Hf28G0bm4ZU1zcAfLG5YqyMSbUeJEHV5VWEkrmaE57x7Mb52zPba3IkIh6tmkD95flvMJJIzMRjnFJ4aM3JJHd1CjN8cmcq52MjkZqBwaVLYcakC/f3NWB8LiJczxotfw4QI4/H1/rLXAjAT9t1dunfui5HXIBqiyP/B+69N/7THFEl3rv/RbOJj14OQeXCErGWVm4eFu2bgLsyLFR0UgsqFd2oo9tpd2T7tgFPQS72zbAE3OkzT7lB7/hyLF5M= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR02MB7159.namprd02.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(23010399003)(376014)(22082099003)(10067099003)(56012099006)(18002099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?zPPLT7lKRItLPOrDAIBZqd3XWcAmH3wHY6dyeVzBLM3/P7u8Bcx0TrdgsEed?= =?us-ascii?Q?M2tjS1mTcT6hwCjQoD+I1dLT+uQc57zLmlBI6T29w+flFRIScvOTVs9s0yFq?= =?us-ascii?Q?Ld3MEUD9jl7unsaN3QHcfMwcR6sB7akL5TvFSNuhzkuZW3MQQzLKDeRJQCWf?= =?us-ascii?Q?tduU4HdpIjlf9vzszOEHI0eWriKCH40v/5HxSPhM/xMGbSUngMdmQpiH9reC?= =?us-ascii?Q?CNR5Ug/RczUwF4zbc7bzMD9JQWfhODHh3MBYdtmuSQyqyNpbRTQ41o/dsoXW?= =?us-ascii?Q?qlpAolxrDKBnpV2qvVm38aRbT48hM3u0wZwYPxmdKh8kQNgaKie6bvwAn7JC?= =?us-ascii?Q?DGzIdY8C4YXs/JL6Zv8JGUt6HOcfTx5mu2Jd4mVh5+7skzeNLqGcfqJjjn7F?= =?us-ascii?Q?Ge1vRl2oC0dz3BC1mDPW7qKW2RC/LGZKAQzXIW2H+KcOHyeq8TI93hon7qSj?= =?us-ascii?Q?NqFfRl2Abn8/d1pCmCLBUs4ZhPZoKLicsbD9WB4cM95EAcbgVI7be1MTTNn6?= =?us-ascii?Q?ocrPBgJ+m+aei7ygKecX6FRrHpVysT+FtTJlruwrZXBfV9B08l0CzCTUo9Wb?= =?us-ascii?Q?dIng8Q8wPwpRtg1DFWo+i/bD7Xnud6HuiL1Biaw4U/qlE+e2u1NO775OG3rc?= =?us-ascii?Q?kRqYFR2Fc+qcdOa5/4qlVYHMoCo0wsjj443hPGUlfK4J0R0yipDcDMMvep8s?= =?us-ascii?Q?fTov7gMVVnr1nUy5pMSTUw8qBdl8g+CVKIcjc6diUgTFkWbSVjsUc/cfBCgZ?= =?us-ascii?Q?WoXArF/DoNvtdh03u4yC4/K2eYcseh8wkJ+/m0N7Sr7N/zLuyAcHOV0qijyt?= =?us-ascii?Q?BSLRq3b0CTlqj1ufYN9DErY717b2/sdDPieM+Hn7W5XTnp8LHIBvCKGs4Y5M?= =?us-ascii?Q?po/R/5ZZazCZ7l53u12+dajHDTui5eoimRrTI8cBFo8zRKOyxsbGB9VQzfTp?= =?us-ascii?Q?MRQHc+c8tOpWQUiXMTfEO3z24Scm8cWR/J4JKIDkLLgIcXhtwerniKd3P1/S?= =?us-ascii?Q?foORxOmVw5hDe++ArAHVaecvrDrYAeGRgUyYY0AGFLPV0cGmPkjcxncK93gJ?= =?us-ascii?Q?czPY1A/f8qx2qIqg4GZrMAgVIFio98vev7UEZlohL9UMEUSY7sL9FGyZ47Q1?= =?us-ascii?Q?jvFtxn1/8vftfVnonXI0Ofq2img95C2JX+yADYK4ixiuuAzA8MjYyaQG+ue8?= =?us-ascii?Q?K1lbrXOqV+4Gz7WHRztdB+7H4hLuEhWmn80fGetZKRcpOKcTOKayZDUqHRkA?= =?us-ascii?Q?ETINou+l4KdlMjMHz4tnt1ZgjLtKM6Jh9iJPVJnP52iMEXeaDhAHERAiXzGr?= =?us-ascii?Q?Konxe8a2m6WlLMt5PmXCGKHbqdYiGoXbtslcK1vhbPP42KiPzOVDLB0Ly0zH?= =?us-ascii?Q?yNqd+sQtHK6j3WYnk1XzcvRyjkjX9dcqtZ/fopJU+XXryUrEehpSIyrYR2Me?= =?us-ascii?Q?knM+8UQNWZ6iWeZXrffGO8z9s/P1QlRcNT6UyDmsX5Xaw2M79JYjX/g5OlD5?= =?us-ascii?Q?aBA7zf9PFUKFC0/Sy8YIRHFWrMEs7SE9S4FbS6h8eqLpimDIYDiZtcVHxAMk?= =?us-ascii?Q?aNAA3uK7fHkamHKKkOrd4UHrNmGfraUK0A79yRbH43DjwtwW/W0RFoIhg2QQ?= =?us-ascii?Q?dLE6DXkgpl/ccpBzc5Mpk8VKpRvz7Sv5Tza0uTTnMuf4iX41y4e1nfTrSVqS?= =?us-ascii?Q?+pYPaapwo6LZmUXTguLEx6oIpstk+BmD9sH2eh/klSTXZgM0y8371tiRsl6b?= =?us-ascii?Q?174Tr6MgZnWtv4Vs5RAay/F3zjPFqZ4=3D?= X-Exchange-RoutingPolicyChecked: UbL2DofvExxBA5nP2qQWuCNHhJJ3/cceT9t7VlbFNhr5TnlccQeB/FqX/G3iJ3JpKrSjUyzk4lQuQ/9zg1DjrZOQQ5MnE/3KGtxIvGrShI0x98Si2ddcyXw4T12j+x1yEpzoYxr7dyYho0hUe7F4qPYr644hWp2zw2j9ZY9oojy109S2FVnDyhEJQzxeGExmFTceYHKaa6G6D6D1+y+R9A54+z7jDxKnJjv8Iw5jdZmxjjPuAOgQxs2ts5Vhz3Gihi5TF6v1kJ4/xeIPNFx8Lv7VPv4/iIsyJ9yQuJbyAg0IbYwGjf5sVWMpx7UDoFtm2becNGl3Tf6IFx8CuV97Ww== X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: e108a641-3265-48fb-48b8-08df13df8e4d X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Sep 2026 10:44:59.6645 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: uiieCWXnTHntT4i2VSTPG3vfEsPGdlT5+h+L8d7yW/A6N06OLQm9dIWtaN1MNLmJCbw7hen27r0ChvG3tExPXzH+h+Lhjv7ztQc2/hAi/FE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR02MB7380 X-Authority-Analysis: v=2.4 cv=d+pgWhjE c=1 sm=1 tr=0 ts=6aaa732d cx=c_pps a=qoAvcrxUHY3FHMzwJxUv3w==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=xqWC_Br6kY4A:10 a=VdqzKS8jKosA:10 a=0kUYKlekyDsA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VofLwUrZ8Iiv6rRUPXIb:22 a=VUi8bpU7OL1Oj2-RSIOF:22 a=64Cc0HZtAAAA:8 a=JoGAwIMGT5QChKfUXAUA:9 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE2MDE0MSBTYWx0ZWRfX7V5uxCAVch/A FB9NntY0sY7NiMCrVuy9asnh832qZCQ/k2D/k2AW58C3PjbuNkRLmLngGrgaMALSaTF1bvb15Af SrzWLe7sGT+DRHlrzycYNQOyt2vRtp4q5N5b65LjL65jId07QZNLr2RkStOQ9Z4vVxou3BzyQjl oJW1dr7/w83swce2VcdPRkrDiYk6eGFDpQNw64UStKazF51p8QRygpuchE0tvgC+w6LBNTi6AmU cv6xMkQ+xXu5FqXofGTAV5xhD9NZPp6UWiS3UEswDzBTz5EEf+wAWicniN9KnEWJQuquciS0fCl gPm7j3rQuJtg741i+SL0Njw88cDbujmVvhawoha30nYK2UO/8MbtfP6oBBeiPlqp+iMBCF67yDV raFVw8Qn1o2Ax+S23KCpcelTpBSFI0nDDqjIcTY9c660EjaqSmxb6Oai3XqAq9keuaE364brpqu 5tqjKzKzBWYNxQq2BKA== X-Proofpoint-ORIG-GUID: LN-aDWzHnMxDCbWYLG6YZL1HgNvVKXCH X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE2MDE0MSBTYWx0ZWRfX4YCkNzbTRQeM dbXql7nub+BF83MsqbvArBUT8J4K8R7EC3LCm0UGU+HbdBRS8gEnM9WalX5/F/ezOIU6Z967Dov jUZCb2SS5LwvGc3tFNhZazx7de85xgQ= X-Proofpoint-GUID: LN-aDWzHnMxDCbWYLG6YZL1HgNvVKXCH X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-15_05,2026-09-15_02,2025-10-01_01 X-Proofpoint-Spam-Reason: safe X-purgate-ID: tlsNG-d25034/1789555506-018C5A5B-2AFCF907/0/0 X-purgate-type: clean X-purgate-size: 2462 X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1789555528780158500 Content-Type: text/plain; charset="utf-8" Move parent_realize from KVMPICClass to I8259CommonClass and remove KVMPICC= lass since it is no longer required. Signed-off-by: Mark Cave-Ayland --- hw/i386/kvm/i8259.c | 22 +++------------------- 1 file changed, 3 insertions(+), 19 deletions(-) diff --git a/hw/i386/kvm/i8259.c b/hw/i386/kvm/i8259.c index 68607d721d..bcfed11a3a 100644 --- a/hw/i386/kvm/i8259.c +++ b/hw/i386/kvm/i8259.c @@ -20,19 +20,6 @@ #include "qom/object.h" =20 #define TYPE_KVM_I8259 "kvm-i8259" -typedef struct KVMPICClass KVMPICClass; -DECLARE_CLASS_CHECKERS(KVMPICClass, KVM_PIC, - TYPE_KVM_I8259) - -/** - * KVMPICClass: - * @parent_realize: The parent's realizefn. - */ -struct KVMPICClass { - I8259CommonClass parent_class; - - DeviceRealize parent_realize; -}; =20 static void kvm_pic_get(I8259CommonState *s) { @@ -123,12 +110,12 @@ static void kvm_pic_set_irq(void *opaque, int irq, in= t level) static void kvm_pic_realize(DeviceState *dev, Error **errp) { I8259CommonState *s =3D I8259_COMMON(dev); - KVMPICClass *kpc =3D KVM_PIC_GET_CLASS(dev); + I8259CommonClass *k =3D I8259_COMMON_GET_CLASS(dev); =20 memory_region_init_io(&s->base_io, OBJECT(dev), NULL, NULL, "kvm-pic",= 2); memory_region_init_io(&s->elcr_io, OBJECT(dev), NULL, NULL, "kvm-elcr"= , 1); =20 - kpc->parent_realize(dev, errp); + k->parent_realize(dev, errp); } =20 qemu_irq *kvm_i8259_init(ISABus *bus) @@ -141,12 +128,11 @@ qemu_irq *kvm_i8259_init(ISABus *bus) =20 static void kvm_i8259_class_init(ObjectClass *klass, const void *data) { - KVMPICClass *kpc =3D KVM_PIC_CLASS(klass); I8259CommonClass *k =3D I8259_COMMON_CLASS(klass); DeviceClass *dc =3D DEVICE_CLASS(klass); =20 device_class_set_legacy_reset(dc, kvm_pic_reset); - device_class_set_parent_realize(dc, kvm_pic_realize, &kpc->parent_real= ize); + device_class_set_parent_realize(dc, kvm_pic_realize, &k->parent_realiz= e); k->pre_save =3D kvm_pic_get; k->post_load =3D kvm_pic_put; } @@ -154,9 +140,7 @@ static void kvm_i8259_class_init(ObjectClass *klass, co= nst void *data) static const TypeInfo kvm_i8259_info =3D { .name =3D TYPE_KVM_I8259, .parent =3D TYPE_I8259_COMMON, - .instance_size =3D sizeof(I8259CommonState), .class_init =3D kvm_i8259_class_init, - .class_size =3D sizeof(KVMPICClass), }; =20 static void kvm_pic_register_types(void) --=20 2.43.0 From nobody Thu Sep 24 19:04:36 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1789555544; cv=pass; d=zohomail.com; s=zohoarc; b=XeDIwVvMpOtCEFt96UjopNWbXwdxSmAsZZyl5kr+jz0RGwWryM8d5m+9ZsyTAcu0Qs/kFAzDdElQe41Sur5+VR19KCCqmjE3HQasoFwrP/Q1cRPwcsXf5NMF1XESVVWhnu1TY3ZxWyRdfG9pbLSAfzqZ9/tLnOPxoeHb/GTH+Jk= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1789555544; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=VGDCeduTgR2HUCuVX9bXOtAEkzXf6+m9yLeGk+5Fri8=; b=UNxgxW31WY3Zku3zVptfckmMRAajysQnPzCtpvYksh9ZTlHjzAb+NBOgNPIuZJtt3ZOedB8aAF8E7D6K04B8rFnxK1mniBihEkT80dn2Ytf9oRC+C+xLi82S9p0HG/eZSX5wVdTaoa6GNVuS/OWngPOvc6s3M/DjlPPMEvBLwHc= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1789555544433391.9129308709324; Wed, 16 Sep 2026 03:45:44 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1422585.1647974 (Exim 4.92) (envelope-from ) id 1x6n8Z-000437-Um; Wed, 16 Sep 2026 10:45:11 +0000 Received: by outflank-mailman (output) from mailman id 1422585.1647974; Wed, 16 Sep 2026 10:45:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1x6n8Z-00042v-R1; Wed, 16 Sep 2026 10:45:11 +0000 Received: by outflank-mailman (input) for mailman id 1422585; Wed, 16 Sep 2026 10:45:10 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1x6n8Y-0003vZ-Fq for xen-devel@lists.xenproject.org; Wed, 16 Sep 2026 10:45:10 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1x6n8X-00Gz7F-S1 for xen-devel@lists.xenproject.org; Wed, 16 Sep 2026 12:45:09 +0200 Received: from [10.42.69.1] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6aaa7330-8faa-0a2a0a5109dd-0a2a4501db78-16 for ; Wed, 16 Sep 2026 12:45:09 +0200 Received: from [148.163.155.12] (helo=mx0b-002c1b01.pphosted.com) by tlsNG-d62444.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6aaa7334-5984-0a2a45010019-94a39b0c79e8-3 for ; Wed, 16 Sep 2026 12:45:09 +0200 Received: from pps.filterd (m0127844.ppops.net [127.0.0.1]) by mx0b-002c1b01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68G7x6qC579616; Wed, 16 Sep 2026 03:45:05 -0700 Received: from ch5pr02cu005.outbound.protection.outlook.com (mail-northcentralusazon11022116.outbound.protection.outlook.com [40.107.200.116]) by mx0b-002c1b01.pphosted.com (PPS) with ESMTPS id 4gqbtb9yac-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 16 Sep 2026 03:45:05 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by PHXPR02MB11343.namprd02.prod.outlook.com (2603:10b6:510:3cc::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.428.9; Wed, 16 Sep 2026 10:45:03 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::8e97:bc32:822c:b250]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::8e97:bc32:822c:b250%3]) with mapi id 15.21.0406.007; Wed, 16 Sep 2026 10:45:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=proofpoint20171006 header.d=nutanix.com header.i="@nutanix.com" header.h="Content-Transfer-Encoding:Content-Type:Date:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To"; dkim=pass header.s=selector1 header.d=nutanix.com header.i="@nutanix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=VGDCeduTgR2HUCuVX9bXOtAEkzXf6+m9yLeGk+5Fr i8=; b=V8DF21NKiAi4zMAehbr36+SVQSsenEC6bZQdEIdWjYq9akjE14ipNXVRh hxYRTKkYynKiFzp7CzGni7w0bAXRsTmwEdCjjVrKSHvN04mQhBCI8lb5YzJkHfgf E1bkbNMgseTlt7Dnr73coich9UZqeEP0OTPblcbj2a1fuOKFOK9mf/DJEGjB6dtY Iwxbw4EgRyv45QZVLQMXoAb7x8Yiijd9d7MUFKVq8YGCiXX0fwwy+QeUxb7lhfII +nvWtP3M1U/23vzbNlijek+IixzTWZ0ANV9PcaYqQLu3dS6yORx4Nm0uFuIWUvVb aixgAoW0nj3MDvNEP5Tjfz7WKnI+w== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Qkf3qoHTf1uYCMWPKn/7dEwabeJMIL84DzBmszzeq52iG2Tsbbq8RrhN0zEaK36edHiExhKiGKmHkX0+nBTUVz/AxtjwuuhcScOupEc/qjTb+cx5b38y66PwesaALfFjvb7svLHLI0EKPlABgBs3xZ8BHGT9mATnwlShQmXxXeT4+edm3jxQSt+h3DHpNUEyM/QqEMzQMATwCLGeuCoEC4fIdjQ+daTK+iVqttoowqEjVBwYmsZAyYU1hMApNCGWGV552mm7+xeTvfTwGz0AwYExQaV8RPR3I0onvilrnuGE+joueMvQXWJ7iXZaFWFzoGVUZoGlHBcPmNJA2kwqJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VGDCeduTgR2HUCuVX9bXOtAEkzXf6+m9yLeGk+5Fri8=; b=FlPNxqKbSHpP+ECI5znJr/uX14A0i2zeTs3jxziaMJL3lbriCPYtwN4pdySX2COR7bU17MOt4lA5dBHKYTyi9PzZatZHz9YZtbuqBmOU+9FQ7SyKTZA13r6YQh3ZykanInwbyKVWw/cWJNda3ShbxrqyfSzdJwTKEmpvnI6NoNTrpeOMFVNH+VTF4I8YyAkI39VHXOs+Y/Og2ly9m3q8EVa9+J/AwU1NuAXmA//7o+b35lK7UJZLvXYg7M6+eIGw5iV5SJKlkfD6gm40foXYeV8FfTU1wRjX1Ge/VTxiPtFR7QWs8/qh7b2lI9DzWDXVgYy9f7gVwbE7tBZ6/SwFnw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VGDCeduTgR2HUCuVX9bXOtAEkzXf6+m9yLeGk+5Fri8=; b=h0MBpQsVoaayr9IABN3DQ5XMLKTKE2JoFvqkNhmNEkc0vXvC0hoBiP+pIdhEfE2QuCefZqKFxdfnfBZsdJ1Glvp52Lc7/m6S4SK3on9ZJYNP11Eb7v5yx5SdtuJiByBzu3+qWDi+/c9XoeFniTvmiU6JNIqKqx1sjNH2Wkf8fvupB/BJEJ2tMQOhO+7PHynqBmO1JBrL6gMAuGAZ9XvDbVy4ysgnTgerYLa7RpleQCLbXBtTfR/R67cK2HPLWKYTubLK9Fi8wAnPnPuKEu21nBeOSqlKS2pJN4iX9tx/6oLHuTKwlBKtcMySmosTJIquduAc0w0Xeqv2afX/eSYHLQ== From: Mark Cave-Ayland To: pbonzini@redhat.com, richard.henderson@linaro.org, mst@redhat.com, sstabellini@kernel.org, anthony@xenproject.org, edgar.iglesias@gmail.com, qemu-devel@nongnu.org, xen-devel@lists.xenproject.org Subject: [PATCH 07/22] i8259_common.c: use i8259/i8259_common prefix for functions Date: Wed, 16 Sep 2026 11:43:35 +0100 Message-ID: <20260916104435.600211-8-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260916104435.600211-1-mark.caveayland@nutanix.com> References: <20260916104435.600211-1-mark.caveayland@nutanix.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SJ2P221CA0014.NAMP221.PROD.OUTLOOK.COM (2603:10b6:a03:5db::9) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|PHXPR02MB11343:EE_ X-MS-Office365-Filtering-Correlation-Id: 4146b6d7-058d-4c5a-1d2f-08df13df9056 x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|1800799024|23010399003|18002099003|10067099003|56012099006|22082099003; X-Microsoft-Antispam-Message-Info: E5xM66L2oDgB8wvZ+4HEIRdGsSbN0BUCrz5ut2H8axVqyvIdSv1NDJgjAMcVlsPCXxPUigtCy4GqYkHN36PyQ4FoYVn8vmtyupqT/TGE8gaNCvd0A9pGp//kjgMOfC4JqAYPYDpL6pXEgN8O/5gU3gd59ZK4DI4ez7RnBShEVHanjdgFZ51eWlwslwD8hpDBD+FG2ukErHVxPfHskLIkaNy5xxNP+EqI2W2ChysmZC5v9OT5na3vehSFyBMKW4PEfaLkumxyhK11lfYv2V7O0qmy/bGRnKV8saDKwGoLQShjtjXnX41f9xf+5m0+fxc/Us9VjeTMmGs+dgCVNPuppn9jC7PmB2QsOSeJykr00euRQl5TG96Hdwl6AmbTQo293Y3aXgK1bvWJWjDYVfoZzO+Z2Zj8Xc72QVv9vu8/rKhRURPgW3wh68rH66hiAR5p2J0tpD2esIwB8rHj/gsDoq2gIOJbUQX4duWG/MY/zZqw+RJOUqkBKeHCUICzFm2t9+KxbVVyIJt5OdzWUriPWfVu2/ED7zNCWQRlTH7mfoJURw8GSllh9RfV/1nCiVuR3UPYec3qoT+OigX98vchzuNGQgl97rwKNvginQGPzS78PuBuZ1zgejG5Wg1mOjWCCdS0XykGizyjHV4wS049wmtFr50eshc8/ty2Oa3BQ6s= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR02MB7159.namprd02.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(1800799024)(23010399003)(18002099003)(10067099003)(56012099006)(22082099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?1IlOgYxR/ObmOBJp62O2rQ7nVpAlWy31BHH4tmbhF5YMBN7zB/4HWZ9JGEfw?= =?us-ascii?Q?kIaeDTTYY2mSIp7CiXsrRAfuL7zhdflnwWeTRy4bgX6CK+OGVawT84iAzqmW?= =?us-ascii?Q?mANNh5Usq9+d8dYchmTm0Jj4NrhvKvYUP/ldY1ecQ1UrZAJqz+VGAJBZRB+n?= =?us-ascii?Q?GN1U3Au1nVQdIIYTJxURpeZpZfQnqfQwbZnlKCGoNBr3AW+O4BbvErzCUUNK?= =?us-ascii?Q?WTNNBa3TaCf/A56B+05R/2SmaE/rO3s7EhtHaRNKvVBwsEODX9zYhWsY8pHX?= =?us-ascii?Q?0m/ovZRSv6ozsNV+vSxc8d4c3MBfHGA2TG3rNeOZmEG79898wOO62Ul7zfLN?= =?us-ascii?Q?QEELH0RFYsVizmdjoOtcvSC66d0MM8IJc9YR4h6wXGSIEOAVM+5ufJ4H+4hM?= =?us-ascii?Q?254EN7HzDqIySt9GXIOe/lRBbUADgHuvgZ2bjB0yoUnLAzNkdN0RPi2lMzJ/?= =?us-ascii?Q?wh7U+T00tW5RIITj1uGvoEFGVFRfVmBWXVqImYZA0BO8j4Z+5Zy5f9HtQZnF?= =?us-ascii?Q?CuzbvVyhrR5/pqtZei6stA1vSRcg2W0FA3ux5RGU1RJgH2R9+0XsHHFss2vB?= =?us-ascii?Q?hTMuk7dYJSvpSuInpj6WNwT8XYXuq80P1cs7VSgbm+fkch+62HFJPWdPx9BN?= =?us-ascii?Q?6kWeveGW5CpXfKGfCMxE/qGcBwN69sBLMsg2hqH4MD97r7xSvevLwJkfLfzK?= =?us-ascii?Q?+NaysCYuwsh473gwRqVsSgBzdkAcjjoctEtccB/8+6mWAXSFJz21byOSjoES?= =?us-ascii?Q?cEuSTvLRuvWlt33QWRXlBKK7EyfdRzkvMgX1XF71tU9hxLMClT1mMSBDhzvM?= =?us-ascii?Q?Iu01KDRMNReAFoYhQRLJjCKJkV8BFs9y36QiFxq9s1wS7XoCJLp3gWVrUUbs?= =?us-ascii?Q?TCwGiy3/ZbvKFwpSULGcH1lPKf535jsesn7nidin/TN/CqNVNYSlXsBb00Ng?= =?us-ascii?Q?/mstHlEdLw+9/yyAtd03w5BqeTqMDvg24VQryjvYh/QQRUcds30niqzIocql?= =?us-ascii?Q?yVRhB2I/i7JtTPOFa8nNkAPSBw7y4TwSQK7DCYxQVlxTedFvOpKRD6TMGtHF?= =?us-ascii?Q?7BxelcmGcOIfH616uRMlAzMD1uiyCHOeJBONFaf3ZlPXFpO6HVSMd0z1OGob?= =?us-ascii?Q?PLiEkirTaVlXtxBL8dA2CA2NUXGtE350/CSz5l/pRbAacosd1klcKypOXyvJ?= =?us-ascii?Q?DKrN1osonbyF6M54ucsSCP4nqPF+426H+9OEeFR1YXEBx9c9+9xZC6Z6QECY?= =?us-ascii?Q?0COJa4H2YEFhIb6kYuKs+GHs6mfExu0znRul9E9q6pidesYuoKoJvH/kD248?= =?us-ascii?Q?c6Fy3GFz7/bja8GyIVpoXNxR0AT19wWQxAEC/x/4+saTgH9j6kyYJOW81FR7?= =?us-ascii?Q?nunLDa06MzJyXNn+xKcbzCu6dfB9/LXhXu+3g9OjkE5DmB+pm6JpfJZ5Gp72?= =?us-ascii?Q?vy/hInBqXSbTPq40/ezoHEJRly+UNSu8zYnfTImJZk3x+5tMetQNcSbGjQtp?= =?us-ascii?Q?LE5mMQvMyhrFH0pBWPG1RstTTditcuK9l1B46j0S3L3/PCJHQ2wEKCkdd9Vy?= =?us-ascii?Q?js2BdAetD60EM58brKALqg6rQlGHRvZF8jxpDJBQxKNfjh0iiQyaFzz3p5CI?= =?us-ascii?Q?FHDpPtiRZ2j2Ki9E6al3MQq8/zRxx3uzsmVGLGIfclaYFOoA6frinMkeg2uH?= =?us-ascii?Q?InemVceqbYQ656tasjv43kEETwfNM75jj71vZQppS3dBp5AvUe8Axqpl9D4w?= =?us-ascii?Q?akwo+/zFvNRUN4bk+BKoU2ccVraLP8o=3D?= X-Exchange-RoutingPolicyChecked: 5YRUKibA2hiJ9PqmmM9rwmMIpGc7DVXUyCIey9xs16rLt32d6/3QlAV+seMJHqA26x7ZdsJqIW0pcDH/1rWUbuqMncPynxAOflPSaXKdkbXURO1Ryubr2Bz3emJTaoWqan5twZ2VWpovu0UBdcM0TpULk++0p1oWqD278Dft1tvrBwGGEJ8fDbY8Lm+KhLEaZGHpcVIHxmj2/8ic6+JdKkS7fOAQNGBS1lnvk6UvZv6mPdMuRn1FwDnrZKoJ59rKle9pYlen++9Yih/VT/JKcfas184K9/jkOmKw56UFyFWdXxj8QMjFHMQSKi0hEG6I2qwDEKsAaU8jzwHT/40yOA== X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4146b6d7-058d-4c5a-1d2f-08df13df9056 X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Sep 2026 10:45:03.2135 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: FWhIlFW1/4jw0IWsdiuI4HJGUleFdTnVoBMFw+RP4dbJ4JOmGN90jCOxFwTUDE8EYUPYCeYu7qnOlJRbnOrn0l45e1pN5+R2Vn/KiDa7+pg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PHXPR02MB11343 X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE2MDE0MSBTYWx0ZWRfX1OOpLJspM3rC ndxqwP4IWOJ1PhSdnAXwNH8dhfW9tJuVX3BJW1YG+cKIaaHlWgHKCzSvetVr03jLvPjBDKlNUqU /1v1pa1NaGL73Pa8XXmzAJtaT2aO8rs= X-Proofpoint-ORIG-GUID: 1LoA-P8ySFLkkX0P8s6wptaZLc2Nrk2W X-Proofpoint-GUID: 1LoA-P8ySFLkkX0P8s6wptaZLc2Nrk2W X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE2MDE0MSBTYWx0ZWRfX+F2H58qFmULN 7qbJqLAI2CDvmxwV6pb3LTvv4VSok55hW0l1hvp2aES72kQGi4FqKWP+6tIMdQ0tuW7iiSeqbcJ XprMAKnufDxkMRR9cbTU7T81QGfgGcXh9ufdsSv2BkqNJi+liaWT37LlCCI4zNNMyioQFrCWq+d StW5FAZrLDoY/kia6C5MAKK5Tjxm9znztG1eQs8hEkQvjSBLwGCw11KitTOY2hMcOpH3Bfab2vI JSr7klhj3Rp4i4rCOSaDL8GbN+Cn2p1HykAFsHBsfntCFgFLr7u3xsYubXl930BU1CbJVh9TwSk hbqMObjXCeKy/vgdrAq/1V98UrRZEJZ9U0c76JacAU0cjCiquxtiQ4ulR9UH1puStwJ5GqWkfMt dzPlei4Nw5GAMTXJfytLY70CwShovWNxxXxRBfxghpX8/NBMy5DmDdyj7S/utDc/+QsCqxcIpZG O3SwwxrcSKzNFTtlm1A== X-Authority-Analysis: v=2.4 cv=QYvzLcbv c=1 sm=1 tr=0 ts=6aaa7331 cx=c_pps a=iaCbk/XvQ83LTQeyZmlihA==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=xqWC_Br6kY4A:10 a=VdqzKS8jKosA:10 a=0kUYKlekyDsA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VofLwUrZ8Iiv6rRUPXIb:22 a=0LlEyIVc8U2lsR7dKhuH:22 a=64Cc0HZtAAAA:8 a=ox8dIxdxdu1w5TD4ToMA:9 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-15_05,2026-09-15_02,2025-10-01_01 X-Proofpoint-Spam-Reason: safe X-purgate-ID: tlsNG-d62444/1789555509-BE27A757-ECE2AFFC/0/0 X-purgate-type: clean X-purgate-size: 8028 X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1789555544865158500 Content-Type: text/plain; charset="utf-8" This ensures consistency with our normal QOM-based naming convention. Signed-off-by: Mark Cave-Ayland --- include/hw/isa/i8259_internal.h | 4 +-- hw/i386/kvm/i8259.c | 4 +-- hw/intc/i8259.c | 4 +-- hw/intc/i8259_common.c | 49 +++++++++++++++++---------------- 4 files changed, 31 insertions(+), 30 deletions(-) diff --git a/include/hw/isa/i8259_internal.h b/include/hw/isa/i8259_interna= l.h index e2b0b00f5b..282e437d25 100644 --- a/include/hw/isa/i8259_internal.h +++ b/include/hw/isa/i8259_internal.h @@ -72,8 +72,8 @@ struct I8259CommonState { MemoryRegion elcr_io; }; =20 -void pic_reset_common(I8259CommonState *s); +void i8259_common_reset(I8259CommonState *s); ISADevice *i8259_init_chip(const char *name, ISABus *bus, bool master); -void pic_stat_update_irq(int irq, int level); +void i8259_stat_update_irq(int irq, int level); =20 #endif /* QEMU_I8259_INTERNAL_H */ diff --git a/hw/i386/kvm/i8259.c b/hw/i386/kvm/i8259.c index bcfed11a3a..6c79907aaa 100644 --- a/hw/i386/kvm/i8259.c +++ b/hw/i386/kvm/i8259.c @@ -93,7 +93,7 @@ static void kvm_pic_reset(DeviceState *dev) I8259CommonState *s =3D I8259_COMMON(dev); =20 s->elcr =3D 0; - pic_reset_common(s); + i8259_common_reset(s); =20 kvm_pic_put(s); } @@ -102,7 +102,7 @@ static void kvm_pic_set_irq(void *opaque, int irq, int = level) { int delivered; =20 - pic_stat_update_irq(irq, level); + i8259_stat_update_irq(irq, level); delivered =3D kvm_set_irq(kvm_state, irq, level); kvm_report_irq_delivered(delivered); } diff --git a/hw/intc/i8259.c b/hw/intc/i8259.c index 131aaf9b04..0f823f9824 100644 --- a/hw/intc/i8259.c +++ b/hw/intc/i8259.c @@ -109,7 +109,7 @@ static void pic_set_irq(void *opaque, int irq, int leve= l) int irq_index =3D s->master ? irq : irq + 8; =20 trace_pic_set_irq(s->master, irq, level); - pic_stat_update_irq(irq_index, level); + i8259_stat_update_irq(irq_index, level); =20 #ifdef DEBUG_IRQ_LATENCY if (level) { @@ -199,7 +199,7 @@ int pic_read_irq(I8259CommonState *s) =20 static void pic_init_reset(I8259CommonState *s) { - pic_reset_common(s); + i8259_common_reset(s); pic_update_irq(s); } =20 diff --git a/hw/intc/i8259_common.c b/hw/intc/i8259_common.c index ac8dc7cf00..e03bbb9a8c 100644 --- a/hw/intc/i8259_common.c +++ b/hw/intc/i8259_common.c @@ -33,7 +33,7 @@ static int irq_level[16]; static uint64_t irq_count[16]; =20 -void pic_reset_common(I8259CommonState *s) +void i8259_common_reset(I8259CommonState *s) { s->last_irr =3D 0; s->irr &=3D s->elcr; @@ -53,7 +53,7 @@ void pic_reset_common(I8259CommonState *s) /* Note: ELCR and LTIM are not reset */ } =20 -static int pic_dispatch_pre_save(void *opaque) +static int i8259_common_dispatch_pre_save(void *opaque) { I8259CommonState *s =3D opaque; I8259CommonClass *info =3D I8259_COMMON_GET_CLASS(s); @@ -65,7 +65,7 @@ static int pic_dispatch_pre_save(void *opaque) return 0; } =20 -static int pic_dispatch_post_load(void *opaque, int version_id) +static int i8259_common_dispatch_post_load(void *opaque, int version_id) { I8259CommonState *s =3D opaque; I8259CommonClass *info =3D I8259_COMMON_GET_CLASS(s); @@ -76,7 +76,7 @@ static int pic_dispatch_post_load(void *opaque, int versi= on_id) return 0; } =20 -static void pic_common_realize(DeviceState *dev, Error **errp) +static void i8259_common_realize(DeviceState *dev, Error **errp) { I8259CommonState *s =3D I8259_COMMON(dev); ISADevice *isa =3D ISA_DEVICE(dev); @@ -105,7 +105,7 @@ ISADevice *i8259_init_chip(const char *name, ISABus *bu= s, bool master) return isadev; } =20 -void pic_stat_update_irq(int irq, int level) +void i8259_stat_update_irq(int irq, int level) { if (level !=3D irq_level[irq]) { irq_level[irq] =3D level; @@ -115,8 +115,9 @@ void pic_stat_update_irq(int irq, int level) } } =20 -static bool pic_get_statistics(InterruptStatsProvider *obj, - uint64_t **irq_counts, unsigned int *nb_irq= s) +static bool i8259_common_get_statistics(InterruptStatsProvider *obj, + uint64_t **irq_counts, + unsigned int *nb_irqs) { I8259CommonState *s =3D I8259_COMMON(obj); =20 @@ -131,11 +132,11 @@ static bool pic_get_statistics(InterruptStatsProvider= *obj, return true; } =20 -static void pic_print_info(InterruptStatsProvider *obj, GString *buf) +static void i8259_common_print_info(InterruptStatsProvider *obj, GString *= buf) { I8259CommonState *s =3D I8259_COMMON(obj); =20 - pic_dispatch_pre_save(s); + i8259_common_dispatch_pre_save(s); g_string_append_printf(buf, "pic%d: irr=3D%02x imr=3D%02x isr=3D%02x h= prio=3D%d " "irq_base=3D%02x rr_sel=3D%d elcr=3D%02x fnm=3D= %d\n", s->master ? 0 : 1, s->irr, s->imr, s->isr, @@ -162,12 +163,12 @@ static const VMStateDescription vmstate_pic_ltim =3D { } }; =20 -static const VMStateDescription vmstate_pic_common =3D { +static const VMStateDescription vmstate_i8259_common =3D { .name =3D "i8259", .version_id =3D 1, .minimum_version_id =3D 1, - .pre_save =3D pic_dispatch_pre_save, - .post_load =3D pic_dispatch_post_load, + .pre_save =3D i8259_common_dispatch_pre_save, + .post_load =3D i8259_common_dispatch_post_load, .fields =3D (const VMStateField[]) { VMSTATE_UINT8(last_irr, I8259CommonState), VMSTATE_UINT8(irr, I8259CommonState), @@ -193,21 +194,21 @@ static const VMStateDescription vmstate_pic_common = =3D { } }; =20 -static const Property pic_properties_common[] =3D { +static const Property i8259_common_properties[] =3D { DEFINE_PROP_UINT32("iobase", I8259CommonState, iobase, -1), DEFINE_PROP_UINT32("elcr_addr", I8259CommonState, elcr_addr, -1), DEFINE_PROP_UINT8("elcr_mask", I8259CommonState, elcr_mask, -1), DEFINE_PROP_BIT("master", I8259CommonState, master, 0, false), }; =20 -static void pic_common_class_init(ObjectClass *klass, const void *data) +static void i8259_common_class_init(ObjectClass *klass, const void *data) { DeviceClass *dc =3D DEVICE_CLASS(klass); InterruptStatsProviderClass *ic =3D INTERRUPT_STATS_PROVIDER_CLASS(kla= ss); =20 - dc->vmsd =3D &vmstate_pic_common; - device_class_set_props(dc, pic_properties_common); - dc->realize =3D pic_common_realize; + dc->vmsd =3D &vmstate_i8259_common; + device_class_set_props(dc, i8259_common_properties); + dc->realize =3D i8259_common_realize; /* * Reason: unlike ordinary ISA devices, the PICs need additional * wiring: its IRQ input lines are set up by board code, and the @@ -215,16 +216,16 @@ static void pic_common_class_init(ObjectClass *klass,= const void *data) * code. */ dc->user_creatable =3D false; - ic->get_statistics =3D pic_get_statistics; - ic->print_info =3D pic_print_info; + ic->get_statistics =3D i8259_common_get_statistics; + ic->print_info =3D i8259_common_print_info; } =20 -static const TypeInfo pic_common_type =3D { +static const TypeInfo i8259_common_type =3D { .name =3D TYPE_I8259_COMMON, .parent =3D TYPE_ISA_DEVICE, .instance_size =3D sizeof(I8259CommonState), .class_size =3D sizeof(I8259CommonClass), - .class_init =3D pic_common_class_init, + .class_init =3D i8259_common_class_init, .abstract =3D true, .interfaces =3D (const InterfaceInfo[]) { { TYPE_INTERRUPT_STATS_PROVIDER }, @@ -232,9 +233,9 @@ static const TypeInfo pic_common_type =3D { }, }; =20 -static void pic_common_register_types(void) +static void i8259_common_register_types(void) { - type_register_static(&pic_common_type); + type_register_static(&i8259_common_type); } =20 -type_init(pic_common_register_types) +type_init(i8259_common_register_types) --=20 2.43.0 From nobody Thu Sep 24 19:04:36 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1789555530; cv=pass; d=zohomail.com; s=zohoarc; b=nil643qL+h18M4wDpWxK9OEFNRF7WVZ1vQx0c4m8J/Wud5kZLnoTxB8c0vogkmn9BGCypCNVAXG1MMWR1dUvtXODHorKuUWiW8bekBxtpLI0vGI7V4P9dy8Jy9JTBacSVvYJrDkL1DcF9Wp4E7dSJ8sfE4FVru0kSQebrjzBIy4= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1789555530; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=rqR4OCxXqweOsL/Jai/0JNZHCvy6zRsE6FKKgK6aIjY=; b=bKsqWPf68lMcBIbdwxHRGWCWHKPTbb5nSuyCP6rS15TzQXc36RYhCzOAkt7XBWv2+mhwYHoarXCfQiBgqt67TasLSd5ebk66MfclWWHtKJ4Pn00QyVPhq4HzA5uxkQqVhfm6GhQD29DRa1X3+kJ6VDTo7MOVpQTrVFVJ3sr05Hc= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1789555530882780.462954519494; Wed, 16 Sep 2026 03:45:30 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1422591.1647983 (Exim 4.92) (envelope-from ) id 1x6n8f-0004VJ-8f; Wed, 16 Sep 2026 10:45:17 +0000 Received: by outflank-mailman (output) from mailman id 1422591.1647983; Wed, 16 Sep 2026 10:45:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1x6n8f-0004V5-4C; Wed, 16 Sep 2026 10:45:17 +0000 Received: by outflank-mailman (input) for mailman id 1422591; Wed, 16 Sep 2026 10:45:16 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1x6n8e-0004St-DT for xen-devel@lists.xenproject.org; Wed, 16 Sep 2026 10:45:16 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1x6n8d-002G7R-Px for xen-devel@lists.xenproject.org; Wed, 16 Sep 2026 12:45:15 +0200 Received: from [10.42.69.6] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6aaa733b-e002-0a2a0a5209dd-0a2a4506b20c-2 for ; Wed, 16 Sep 2026 12:45:15 +0200 Received: from [148.163.151.68] (helo=mx0a-002c1b01.pphosted.com) by tlsNG-16d1c6.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6aaa733a-195a-0a2a45060019-94a39744c98e-3 for ; Wed, 16 Sep 2026 12:45:15 +0200 Received: from pps.filterd (m0127840.ppops.net [127.0.0.1]) by mx0a-002c1b01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68G83uAV353108; Wed, 16 Sep 2026 03:45:10 -0700 Received: from sn4pr0501cu005.outbound.protection.outlook.com (mail-southcentralusazon11021110.outbound.protection.outlook.com [40.93.194.110]) by mx0a-002c1b01.pphosted.com (PPS) with ESMTPS id 4gq9drte5n-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 16 Sep 2026 03:45:09 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by PHXPR02MB11343.namprd02.prod.outlook.com (2603:10b6:510:3cc::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.428.9; Wed, 16 Sep 2026 10:45:06 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::8e97:bc32:822c:b250]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::8e97:bc32:822c:b250%3]) with mapi id 15.21.0406.007; Wed, 16 Sep 2026 10:45:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=proofpoint20171006 header.d=nutanix.com header.i="@nutanix.com" header.h="Content-Transfer-Encoding:Content-Type:Date:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To"; dkim=pass header.s=selector1 header.d=nutanix.com header.i="@nutanix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=rqR4OCxXqweOsL/Jai/0JNZHCvy6zRsE6FKKgK6aI jY=; b=H0kEaFEAk0x7mAXoWd6tNILZjvshdU9zZNf3G0EmkYPl2SUvBN/9aHhe6 f9QqX7HYjp79po2IF+6cgQO7e9pYp5vp/wKOhk1//rqDRnMtLM8/zGplVKxzt0U+ 4J7niN1uwSe6fjRh9iIEMh4IzpXV9+cflNlO01AIr4ju7zujJck5yCfeYZ+BU3e/ KPV4R56lbxxmaIVP54hxvjF3alMC4ExD8H2wbuCPTFkBUrDrdwcjHc18bWp9ML3z vpwPTxxD2K4YISOPRZIhqziVF7LqN182HYMjsphglDIJSjBgc8IIEOmFi//JWhaW Q+ekL0KJhUWr7xDjFrdtstiwXVrsw== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=kTa+P3NbkbGcSQVfHFiBBmzGHTE4TbgzPEiEAfspzTqnYKbS7tlPLYHywt1oKlpjXhtvUUK1UCYQ5ofKMSmfClgRJnvhj2zWRSFeJV8dtKnluATOKH6tR/R/VbWMBbZy4Lm3piFrbcYzir0M6vYvKXciLh9LLcw84YxweKAcUm/cCpJxI1crKMcWeBKJ8hOmGdEm6UpX9pgCVhscRpWEkXkDDgrn91cKSGg6Od+wJjouFDE8LD2O/V0FBr3sVXK8ca0DRDLG8P+Ow6/y5UsnlmW2RNOjureKhdNUT+KaLjOLGiDyFuSiblfPZ2+xE5eHeCtj2Ux3WZDyw0b64o75fA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rqR4OCxXqweOsL/Jai/0JNZHCvy6zRsE6FKKgK6aIjY=; b=v436zD+6gmFY3AlR0Easw+y+nQDH/rD0YxprzFKXWZnAitPAtmMBSCqowUIGACBGuhlckABFT8+kFKHdPVuPN0nd6fRrhKQCsMv2aCGBhv60u+j4l+LYaObSszH4XlN6KCoojswqpiNvnMcjixbPkwLqgE4BFD93hffI8uCH1ZIlQeDpvVNUifBGkeQ99flpBmHqOlinA6EgWxVeXTX0ncrxgPjoOn4sljcboczRb8XAZXiAtu3zoJOLDb26xTwVNmLB6hXPqRFJGNWGOOY0+SoL9qixUQ2RlEWLMtbMzQmB9ukYmE0XXTaHyPlEJq4upzKskdIOK2k3ib/cUtyKkA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rqR4OCxXqweOsL/Jai/0JNZHCvy6zRsE6FKKgK6aIjY=; b=MeViRYOai88j4s90fB9SIlPLROpBc4cgsxWi0V2lJ0Aa/3k2RcOi9E3SycAcGQz/UbcrBOts754tqcIB7wCtRShxF4KjyOuKYjPDpNyP0HoiRZeF5+gKv8mfBEvc8/9p2/119qiSNsk1niHPDo+f4xf40ulhzIrAo9qDCTkMBtFlbIspQGwraV3zMr5a5127Gh/+PJE+7WNghhA4DYL1+iaPYFN3OKL5TLxjcVfiBK78DEzGqyxLILwcwKEIZs0jkGxVpXTCeHdSYmEM9P6cUyikVdHaqWGc2JN80pnrU9czcf9h9lxA3VfWKPTL/LfI4E8eAuv5eFROFiZroymcbw== From: Mark Cave-Ayland To: pbonzini@redhat.com, richard.henderson@linaro.org, mst@redhat.com, sstabellini@kernel.org, anthony@xenproject.org, edgar.iglesias@gmail.com, qemu-devel@nongnu.org, xen-devel@lists.xenproject.org Subject: [PATCH 08/22] i8259.c: use i8259 prefix for functions Date: Wed, 16 Sep 2026 11:43:36 +0100 Message-ID: <20260916104435.600211-9-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260916104435.600211-1-mark.caveayland@nutanix.com> References: <20260916104435.600211-1-mark.caveayland@nutanix.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SJ0PR13CA0098.namprd13.prod.outlook.com (2603:10b6:a03:2c5::13) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|PHXPR02MB11343:EE_ X-MS-Office365-Filtering-Correlation-Id: 5269b4fb-f3a4-4e56-f155-08df13df925e x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|1800799024|23010399003|18002099003|3023799007|10067099003|56012099006|22082099003; X-Microsoft-Antispam-Message-Info: SXbMYsg9PDJTvWMSgZQzZCkvXjgTQ2+TLB0GhvRj+V6lHb/EmBlvF88+J7O6LC0olFrmnNJRUHvPDUa1oIhBMrPyg8AGlDRx2xFjug4DLUaOo2PWH53IB8BO2fYmPy0RsXYfjV4uvDNAe3O1PaakYeekjLGtc5cvoE5ItY0snjOJejNoiR+ebcXRwWf+cIzShQrQQM3cktPT9TZTBzdALUApnmtCEP5dxWM7VHbNBIKA7PrbYDfPlUXyQ50gx9xeGBCDgXcs0j1bf46EMLeTtQRgXnSjE1ZX0gRg8xyCgsqL7vKGGG+KhdR1vVd4zzQbPEGEFOl8YYhnDR2uPc34UlfIeNkIBaDcpL9VXxg09BtxvrKihlj3UFFzkPIezXzmjh+982ubGUt6Ct5EocB2adghobQpwO3G+a7M0mJB53Beisb/BcXtB5VZFoJxDG291NkUqt1cOVJNADj/vHivoTMaEkrGRspjqJ5qx6U8SKJyEMTt0bD3b25IjzkCMuzry2b1rVEcrRKs23BcvHRX5qX6IMaXZi8JqnbOGwzrmUX1RsjMC/Or0XnESkOx7GdNJSFNmnEwh9kmCrcNX4UzlUla1RVzaitzLphTCz0HQ3ChuQJ+yNWVMwnYPifO4ccpEVXyXUaCKDT6osfDXxHnncmjOP73hmfuwjBCeVIVUL8= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR02MB7159.namprd02.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(1800799024)(23010399003)(18002099003)(3023799007)(10067099003)(56012099006)(22082099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?P1Je7kpW/EvkbA5e7LlZ18HfjbEI6+lpILEQjUrTYR4C7EsLgQtSr6MOoQfA?= =?us-ascii?Q?idHi5b6lKEAUJKYlqUgaRBEbtBXoIahhb8VT217/4j/mOKaZjKaLGfvoDYU/?= =?us-ascii?Q?vLPYrQ5eSWk4Ldpvt92G6YvjLniq3VoOTPtF1YH3A9P2BH6pPvTMrfZy0HvD?= =?us-ascii?Q?f6LOo0d9hm0PQPGWiT0aNPoKwHQsnw5R5GHTmXrZr8g86Vp0+71H2Qysv9FK?= =?us-ascii?Q?5kzXqDU/SGATK1rOeWX7zMUDF9vOqFjzeSsObFiZYNaKCQRpa5vYO0gT+/1p?= =?us-ascii?Q?Aqlqr9aL1KQ6bYCgCvJCZ/DaOMmbnOPVljHqMEasVdZucoiqLKnlfBLS3CXs?= =?us-ascii?Q?cK3jGebr5BUJxBjGM/9T1FE2hAOVvT9BOPzJKjQqEofL/dIivLFEU1R2Ok5u?= =?us-ascii?Q?7nT0hHSTBiuiOKVRgG9OhF4l2Vy0YAAC5tHyDvlRLG1PzNXh3q1sCvpxJcRJ?= =?us-ascii?Q?zgi1nRbFjFnHKDMDZw5TBHTjziY1IUCcADFqDlsAUDvIz7pqijtUWmepMKJH?= =?us-ascii?Q?P/yVFLIdFN7BW2edaQFru/dVCf0acgZ5O9MzEbZgUAKRSXxqUu0Xz8nvfk+s?= =?us-ascii?Q?1VBtXn4nY1yhgSXZYGKCb4E+qlIATTS2kP2ZuHAQpBOk0MzclcRNIVGzMp+H?= =?us-ascii?Q?ruZAX81HquedrY/tcPqhggLKs1rNJLTb8N4LU621Q3b+7KZt4wH/2QBnM5mU?= =?us-ascii?Q?QLGjlooX3g6I6BhH1Q7Q4BDWi7a6cK5k2wWSjhzgLFTB10AEeirpo31T8hQw?= =?us-ascii?Q?vLugoblKCs2xw7jS3pbTAsNPp+eAcg5lJWa8IIBVqP4qZW1wjZscknWbX2cw?= =?us-ascii?Q?MJzeKA9v5+q0CheeT690etezrKiGPdwWERZSlioA84DLGqOEDvXfAvKKWTRa?= =?us-ascii?Q?dBjml10v+oZj1JQlma0cDwmAu2mxfZ0a4TIcUP196IgHNixXNOeOBi2kg6o2?= =?us-ascii?Q?79HMDIT1dusYtyhYgoDYoPF60XgpTYsL+SkwGL5hO7o5K6LWktbGoEkIa4X7?= =?us-ascii?Q?SoCI6fNzRshBtLnLHPrHDuGRensix/akXGK08Ytaf0oMYkBFF94W5TXCOPIr?= =?us-ascii?Q?L3+83z3rMpNhSiuWLi/RVO9ZAtj0rJSzjyTfLNFDLYtJsDZoI9aQO6Med0Qu?= =?us-ascii?Q?VWGYNJQKnF7ym/d7NkUnCNHBBWUziwxP4SdPSW6hnm/u9lCfotBZiEIX4AEx?= =?us-ascii?Q?4qgNKREWcCX0lA2fCPvLApNnKhbXzUPshRvKvnNtklq1EETVp7kKtRBhALaF?= =?us-ascii?Q?QIzcLBaf3nLrXV2GYDtB/ex1quYX62+k8WkXFYLISm9PqQTae6s1A0cNAdfY?= =?us-ascii?Q?trS8Xj8xuXc2qW1/O00geHp4J1g/bXcaQB0nq56IdfJITDdWub7r8MY9vl9V?= =?us-ascii?Q?FMlzdj0OvdjgT49hOA9F/nr294iB7LRxGWJ+rHI938f+GWjhh/uMYTyfAkfY?= =?us-ascii?Q?6jfINCCZ+YUhcHxx0GnP161J7DN8vKD6qgJtwR101bbc5TMMU2gF1U/3TpS3?= =?us-ascii?Q?fi/2EBT4BwCU/BbCBjo2EVDfg/yEdhgpECFjKsfaJPIzYq0LoJNvLE3WHNnJ?= =?us-ascii?Q?M7aBd/MP2STWP626BxOEg5bfCtF5bQLTGJPnD37GYJkQa4TWVhRiBigqN8C/?= =?us-ascii?Q?g7fBu/MuSuec+lPZRmILPoBr7xQveN6bdoCDvPrpPvl7+2Wv4xOQPxNoWKbl?= =?us-ascii?Q?Lb5ryQYd0GmTpMFGu25Eb30otf7mhukMno9hKRt1x7X+J9cq40t/2JyosgCY?= =?us-ascii?Q?hLSxuhJpM+ae8zfJzH8LyqM6aX8NLBg=3D?= X-Exchange-RoutingPolicyChecked: Cy4e4t7YytaJLNU/lWLKjarCPi/7bMQaBpUfm9LZSFU8Kz9o7sRLOVOi6QfIr6rL5OSok1BbwqY9147cne3A0wVJYftaMVQ6bIP59h98jP64o3gGjQwju4F4z61sCcCOgV/UPI2qY2IrC6C+NY+HeUaPT3390TPsl4Pel7Eh3pAZOYVFHiBIQ4BM7szTxmNDBdGPeAzlC6hbePHwFYHO/NjZnP7GzDNnIjS3n3u8jFLC0yuSE68js17KwFAR3PWyvk4aHCLZ0f4YWXpDS5blmX5ujAZP7L0SLZQMScgr1bfDBE5jbGMoWqoYC1E63Z53rAskEwFhw+JGBCDZr4XfEQ== X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5269b4fb-f3a4-4e56-f155-08df13df925e X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Sep 2026 10:45:06.6799 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: JNvxgy2qQDgJT2Y4XeDnr6kOQYB1MEYjN1+V92FUi0rUqAHOYa2JinLQx+MWSUiEFP1eTJ1YI2RdO+TJyInslXpGI55FNE+VDbpuIsGE/04= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PHXPR02MB11343 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE2MDE0MSBTYWx0ZWRfX82gp2FDuEBHv Qcsl7T+xAtQ+rY5vFovefwtSFR/hzq10ufPcduLb7/T/0Qrj4ROxb1OLjNOsirmc/nqOKQoXth0 kNPcUe+FNPkiv5xjzlHZunL9so9n+YCDb3iJXDRalDXqt1r/icHobVaKjuGBdKTwB7SzgQ1fmO2 dwokE06wAsjpeQvUXoHVDNCs4eTSJQRvUEzE3OIIcc48XgJbH2ebQjr3QbW1+FxJA+VQvayXSn6 kl8jNu8J3U4drObBYonq0H+3TWsL/uMhKC2Lj8HJ0M4sVCruwyzTybLsZXYoiTHjezjHejNX3QM fByXxQHB5sLNbHvlgnyF3pu6hMtZ6ISQuoanpfh+BeaKnnkVvNwpgCd3fIEorjp8UhOEqkDLwuW 8O58iUAmGHFNyxbJMzFCS+TqpPK+hgSH71yLNY4MOX63FRkR4CDFQFibr4VVER6JFcgxoPvuPC4 oC1bPExP0kDDDI50MzQ== X-Authority-Analysis: v=2.4 cv=XO2l2ghE c=1 sm=1 tr=0 ts=6aaa7335 cx=c_pps a=is1TPszdXRKtgCc8Qn4wPQ==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=xqWC_Br6kY4A:10 a=VdqzKS8jKosA:10 a=0kUYKlekyDsA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VofLwUrZ8Iiv6rRUPXIb:22 a=_-M8LpHI31CeLmyZm6wg:22 a=64Cc0HZtAAAA:8 a=BS222h8BhpbHzx9SlcQA:9 X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE2MDE0MSBTYWx0ZWRfXxWnwiWtsqE83 OYoNWSplpst/B0FCIEvDMBHcCGGiLgWzs5bo0mB5eH+c0t9+dko21ENL7DXw0oG70nIBSUmsqa6 goxqbtI37E9+GQkqU6ToYUxGAL9rjfw= X-Proofpoint-ORIG-GUID: FgC-zqXhrwH76hr1rGkCGWtBbHOJ5WVj X-Proofpoint-GUID: FgC-zqXhrwH76hr1rGkCGWtBbHOJ5WVj X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-15_05,2026-09-15_02,2025-10-01_01 X-Proofpoint-Spam-Reason: safe X-purgate-ID: tlsNG-16d1c6/1789555515-1ECC577B-C9F663C8/0/0 X-purgate-type: clean X-purgate-size: 9444 X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1789555532785158500 Content-Type: text/plain; charset="utf-8" This ensures consistency with our normal QOM-based naming convention. Signed-off-by: Mark Cave-Ayland FIXME: rename trace events? --- hw/intc/i8259.c | 96 ++++++++++++++++++++++++------------------------- 1 file changed, 48 insertions(+), 48 deletions(-) diff --git a/hw/intc/i8259.c b/hw/intc/i8259.c index 0f823f9824..f2d8cb1489 100644 --- a/hw/intc/i8259.c +++ b/hw/intc/i8259.c @@ -58,8 +58,8 @@ static int get_priority(I8259CommonState *s, int mask) return priority; } =20 -/* return the pic wanted interrupt. return -1 if none */ -static int pic_get_irq(I8259CommonState *s) +/* return the i8259 wanted interrupt. return -1 if none */ +static int i8259_get_irq(I8259CommonState *s) { int mask, cur_priority, priority; =20 @@ -88,11 +88,11 @@ static int pic_get_irq(I8259CommonState *s) } =20 /* Update INT output. Must be called every time the output may have change= d. */ -static void pic_update_irq(I8259CommonState *s) +static void i8259_update_irq(I8259CommonState *s) { int irq; =20 - irq =3D pic_get_irq(s); + irq =3D i8259_get_irq(s); if (irq >=3D 0) { trace_pic_update_irq(s->master, s->imr, s->irr, s->priority_add); qemu_irq_raise(s->int_out[0]); @@ -102,7 +102,7 @@ static void pic_update_irq(I8259CommonState *s) } =20 /* set irq level. If an edge is detected, then the IRR is set to 1 */ -static void pic_set_irq(void *opaque, int irq, int level) +static void i8259_set_irq(void *opaque, int irq, int level) { I8259CommonState *s =3D opaque; int mask =3D 1 << irq; @@ -137,11 +137,11 @@ static void pic_set_irq(void *opaque, int irq, int le= vel) s->last_irr &=3D ~mask; } } - pic_update_irq(s); + i8259_update_irq(s); } =20 /* acknowledge interrupt 'irq' */ -static void pic_intack(I8259CommonState *s, int irq) +static void i8259_intack(I8259CommonState *s, int irq) { if (s->auto_eoi) { if (s->rotate_on_auto_eoi) { @@ -154,31 +154,31 @@ static void pic_intack(I8259CommonState *s, int irq) if (!s->ltim && !(s->elcr & (1 << irq))) { s->irr &=3D ~(1 << irq); } - pic_update_irq(s); + i8259_update_irq(s); } =20 int pic_read_irq(I8259CommonState *s) { int irq, intno; =20 - irq =3D pic_get_irq(s); + irq =3D i8259_get_irq(s); if (irq >=3D 0) { int irq2; =20 if (irq =3D=3D 2) { - irq2 =3D pic_get_irq(slave_pic); + irq2 =3D i8259_get_irq(slave_pic); if (irq2 >=3D 0) { - pic_intack(slave_pic, irq2); + i8259_intack(slave_pic, irq2); } else { /* spurious IRQ on slave controller */ irq2 =3D 7; } intno =3D slave_pic->irq_base + irq2; - pic_intack(s, irq); + i8259_intack(s, irq); irq =3D irq2 + 8; } else { intno =3D s->irq_base + irq; - pic_intack(s, irq); + i8259_intack(s, irq); } } else { /* spurious IRQ on host controller */ @@ -197,23 +197,23 @@ int pic_read_irq(I8259CommonState *s) return intno; } =20 -static void pic_init_reset(I8259CommonState *s) +static void i8259_init_reset(I8259CommonState *s) { i8259_common_reset(s); - pic_update_irq(s); + i8259_update_irq(s); } =20 -static void pic_reset(DeviceState *dev) +static void i8259_reset(DeviceState *dev) { I8259CommonState *s =3D I8259_COMMON(dev); =20 s->elcr =3D 0; s->ltim =3D 0; - pic_init_reset(s); + i8259_init_reset(s); } =20 -static void pic_ioport_write(void *opaque, hwaddr addr64, - uint64_t val64, unsigned size) +static void i8259_base_ioport_write(void *opaque, hwaddr addr64, + uint64_t val64, unsigned size) { I8259CommonState *s =3D opaque; uint32_t addr =3D addr64; @@ -224,7 +224,7 @@ static void pic_ioport_write(void *opaque, hwaddr addr6= 4, =20 if (addr =3D=3D 0) { if (val & 0x10) { - pic_init_reset(s); + i8259_init_reset(s); s->init_state =3D 1; s->init4 =3D val & 1; s->single_mode =3D val & 2; @@ -255,23 +255,23 @@ static void pic_ioport_write(void *opaque, hwaddr add= r64, if (cmd =3D=3D 5) { s->priority_add =3D (irq + 1) & 7; } - pic_update_irq(s); + i8259_update_irq(s); } break; case 3: irq =3D val & 7; s->isr &=3D ~(1 << irq); - pic_update_irq(s); + i8259_update_irq(s); break; case 6: s->priority_add =3D (val + 1) & 7; - pic_update_irq(s); + i8259_update_irq(s); break; case 7: irq =3D val & 7; s->isr &=3D ~(1 << irq); s->priority_add =3D (irq + 1) & 7; - pic_update_irq(s); + i8259_update_irq(s); break; default: /* no operation */ @@ -283,7 +283,7 @@ static void pic_ioport_write(void *opaque, hwaddr addr6= 4, case 0: /* normal mode */ s->imr =3D val; - pic_update_irq(s); + i8259_update_irq(s); break; case 1: s->irq_base =3D val & 0xf8; @@ -305,16 +305,16 @@ static void pic_ioport_write(void *opaque, hwaddr add= r64, } } =20 -static uint64_t pic_ioport_read(void *opaque, hwaddr addr, - unsigned size) +static uint64_t i8259_base_ioport_read(void *opaque, hwaddr addr, + unsigned size) { I8259CommonState *s =3D opaque; int ret; =20 if (s->poll) { - ret =3D pic_get_irq(s); + ret =3D i8259_get_irq(s); if (ret >=3D 0) { - pic_intack(s, ret); + i8259_intack(s, ret); ret |=3D 0x80; } else { ret =3D 0; @@ -337,53 +337,53 @@ static uint64_t pic_ioport_read(void *opaque, hwaddr = addr, =20 int pic_get_output(I8259CommonState *s) { - return (pic_get_irq(s) >=3D 0); + return (i8259_get_irq(s) >=3D 0); } =20 -static void elcr_ioport_write(void *opaque, hwaddr addr, - uint64_t val, unsigned size) +static void i8259_elcr_ioport_write(void *opaque, hwaddr addr, + uint64_t val, unsigned size) { I8259CommonState *s =3D opaque; s->elcr =3D val & s->elcr_mask; } =20 -static uint64_t elcr_ioport_read(void *opaque, hwaddr addr, - unsigned size) +static uint64_t i8259_elcr_ioport_read(void *opaque, hwaddr addr, + unsigned size) { I8259CommonState *s =3D opaque; return s->elcr; } =20 -static const MemoryRegionOps pic_base_ioport_ops =3D { - .read =3D pic_ioport_read, - .write =3D pic_ioport_write, +static const MemoryRegionOps i8259_base_ioport_ops =3D { + .read =3D i8259_base_ioport_read, + .write =3D i8259_base_ioport_write, .impl =3D { .min_access_size =3D 1, .max_access_size =3D 1, }, }; =20 -static const MemoryRegionOps pic_elcr_ioport_ops =3D { - .read =3D elcr_ioport_read, - .write =3D elcr_ioport_write, +static const MemoryRegionOps i8259_elcr_ioport_ops =3D { + .read =3D i8259_elcr_ioport_read, + .write =3D i8259_elcr_ioport_write, .impl =3D { .min_access_size =3D 1, .max_access_size =3D 1, }, }; =20 -static void pic_realize(DeviceState *dev, Error **errp) +static void i8259_realize(DeviceState *dev, Error **errp) { I8259CommonState *s =3D I8259_COMMON(dev); I8259CommonClass *k =3D I8259_COMMON_GET_CLASS(dev); =20 - memory_region_init_io(&s->base_io, OBJECT(s), &pic_base_ioport_ops, s, + memory_region_init_io(&s->base_io, OBJECT(s), &i8259_base_ioport_ops, = s, "pic", 2); - memory_region_init_io(&s->elcr_io, OBJECT(s), &pic_elcr_ioport_ops, s, + memory_region_init_io(&s->elcr_io, OBJECT(s), &i8259_elcr_ioport_ops, = s, "elcr", 1); =20 qdev_init_gpio_out(dev, s->int_out, ARRAY_SIZE(s->int_out)); - qdev_init_gpio_in(dev, pic_set_irq, 8); + qdev_init_gpio_in(dev, i8259_set_irq, 8); =20 k->parent_realize(dev, errp); } @@ -425,8 +425,8 @@ static void i8259_class_init(ObjectClass *klass, const = void *data) I8259CommonClass *k =3D I8259_COMMON_CLASS(klass); DeviceClass *dc =3D DEVICE_CLASS(klass); =20 - device_class_set_parent_realize(dc, pic_realize, &k->parent_realize); - device_class_set_legacy_reset(dc, pic_reset); + device_class_set_parent_realize(dc, i8259_realize, &k->parent_realize); + device_class_set_legacy_reset(dc, i8259_reset); } =20 static const TypeInfo i8259_info =3D { @@ -435,9 +435,9 @@ static const TypeInfo i8259_info =3D { .class_init =3D i8259_class_init, }; =20 -static void pic_register_types(void) +static void i8259_register_types(void) { type_register_static(&i8259_info); } =20 -type_init(pic_register_types) +type_init(i8259_register_types) --=20 2.43.0 From nobody Thu Sep 24 19:04:36 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1789555554; cv=pass; d=zohomail.com; s=zohoarc; b=eY/2/RvUqGiLgVSCMqGGKAoYuiHHpZCE1piAd5fJJNFfd/gBqmKc19Scp8E9UqiHu4uQhOB/0EkG+KyOcOiU2W10nV/Y421/gG6SlO1pra0J/08duHiDI7NIYfep5WksaFAEYp8BTW5krPHGth+7zmQPO7S8pr52l9sEMqTdCn0= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1789555554; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=YYDEHb0n4ZArJUHD5DiG9aC24YVKRRvasL5SP6kR9mY=; b=eczT/hSyyDTZVohGIGTnapuXhX1NbjwH5zcrjcj2XbSx9TKU0htFx71AqeouAxFQJXWxht3XakSX4UQpw9yBO5L8JVXbCynpQUNpZrauTJLR505hC0t3bgrCeE3W4++PEeEjbmgLN3dEH2v4xlmaUTdtuXFmZGdDvzu2S7JBASg= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1789555554731145.00371159321458; Wed, 16 Sep 2026 03:45:54 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1422592.1647992 (Exim 4.92) (envelope-from ) id 1x6n8g-0004ng-Ll; Wed, 16 Sep 2026 10:45:18 +0000 Received: by outflank-mailman (output) from mailman id 1422592.1647992; Wed, 16 Sep 2026 10:45:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1x6n8g-0004mx-HX; Wed, 16 Sep 2026 10:45:18 +0000 Received: by outflank-mailman (input) for mailman id 1422592; Wed, 16 Sep 2026 10:45:17 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1x6n8f-0004V0-8w for xen-devel@lists.xenproject.org; Wed, 16 Sep 2026 10:45:17 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1x6n8e-002G7R-Ln for xen-devel@lists.xenproject.org; Wed, 16 Sep 2026 12:45:16 +0200 Received: from [10.42.69.5] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6aaa732b-e002-0a2a0a5209dd-0a2a45059d64-42 for ; Wed, 16 Sep 2026 12:45:16 +0200 Received: from [148.163.151.68] (helo=mx0a-002c1b01.pphosted.com) by tlsNG-c201ff.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6aaa733a-4cb1-0a2a45050019-94a397444cac-3 for ; Wed, 16 Sep 2026 12:45:16 +0200 Received: from pps.filterd (m0127838.ppops.net [127.0.0.1]) by mx0a-002c1b01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68G8eiYw769720; Wed, 16 Sep 2026 03:45:11 -0700 Received: from ph8pr06cu001.outbound.protection.outlook.com (mail-westus3azon11022142.outbound.protection.outlook.com [40.107.209.142]) by mx0a-002c1b01.pphosted.com (PPS) with ESMTPS id 4gqatdt57e-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 16 Sep 2026 03:45:11 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by PHXPR02MB11343.namprd02.prod.outlook.com (2603:10b6:510:3cc::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.428.9; Wed, 16 Sep 2026 10:45:10 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::8e97:bc32:822c:b250]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::8e97:bc32:822c:b250%3]) with mapi id 15.21.0406.007; Wed, 16 Sep 2026 10:45:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=proofpoint20171006 header.d=nutanix.com header.i="@nutanix.com" header.h="Content-Transfer-Encoding:Content-Type:Date:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To"; dkim=pass header.s=selector1 header.d=nutanix.com header.i="@nutanix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=YYDEHb0n4ZArJUHD5DiG9aC24YVKRRvasL5SP6kR9 mY=; b=FPcZtlSoxuaRcpjIOgs0TtP0y00gkKRhOvQ1/1ufsnUSB/TvZFsUNquci A2iZ7qpwcC+NFFSnWiocotTXXBTGFuNnMCtcHTmjhvhYUiBBmsiiDWe4hDAWz9SF DEpb45BCxb0GUUh8NrsReZOn6Iodzz0rN86G+70/54qWNojvvmuxat1FP/c9W8hS lyyZ5nHDYOHRNyiZFliGiDxu7RKsxFhCYgpl72BEdAeDfwmB4O3rkjD0QwB27lg4 rUxqcXqt7kln/rIEKAS9+XCvAlOTKIrQrFXucqigso32ucFm8FmwYEeN3I0VwN+z hzm6I2i+ztVZf86jJWuOJd0IK4OsA== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=O02g03XyahCaMLq2dW3ZvNDims63MSR9gkV5ZgbyhxIEdDazxFjffqCRRbLxwZKOHF+IOpJ9crrz4Y+8yTU620OSok04M5pIbX27FRYkxma5bgrsN1j81U2k5CMq/3vEHEKLBBmNyW0Aydnl40wtpHl54irNfFukMlYXuxYrPNvTjw/P+Yl593SvpBsOBPeXr+wuupdxDHinjHQ/pV8TXDy0EOoI67S8c18uXyjKGhaJhLyYyJW02/qxf+yY0G/3EoDAHKEuT+kfH9nOx5fkKrT8K2gZcYln3gZGNt76RpnnB9Q/KuokJAio1ki7lTA2biBZid86+k5Vka64LxjTlA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YYDEHb0n4ZArJUHD5DiG9aC24YVKRRvasL5SP6kR9mY=; b=eefDZys6pr3HUbkI1LGQF2eTiuut8iAiVEb5e4whgdD0cApZ1AJRtjmM43FLvH6PItQ++fNcB4LsCpoyRzIXkX0nhpT6tiUhA2UEELlZPZrLCFEKd47gXS/PNyYkiF9qwdRihovN/70fG5ChtxlLGcmh3+rQAJrSTzSY5CKO61knXmU8NyX3KV9krOrmyabemfJObyLJEiugwc7eakctNPsBoLeR3OqjyqpeI1UQeLS9qpBp2/l4zd/kagB2rg4zeSA29fd2ubRG+sFPpftzejgGrGxUVR2dLuiR4Sqd2WijoMRHy+BYDHVr4TrEXMZtkNHA47vgzpUnqDTGvCSjsA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YYDEHb0n4ZArJUHD5DiG9aC24YVKRRvasL5SP6kR9mY=; b=QkUunYrYv8rw/uM/p2z/z1xwQL6i6tSEAct0NKMFoLcaJwmusPZD/FWg+eRG1iMHxWVSb6nOEdxXJCx54FmkwoGXN096tVDS9FJsYRVV6mwXGurULXCf1JiExs4OEa40RjfynrVDizXQ8rMAn4uTMUTPmenyxwO+tsM4N1SpT2Crp+Of8jiHb+BHwhzsHf3/mfO/0IY1bj4UrPMKFYrE4BgcHNrLKE6kSPYPW0wR0A9Tu9DkByktzexmdLbGCuzHSMF0S59ChBLN8QRUa+tnDhyJIEaMaU8PwefK5vuRc8huN2i9htbaEq74Otd+/GVYy7oKucw2xjgGFavtUWtc+A== From: Mark Cave-Ayland To: pbonzini@redhat.com, richard.henderson@linaro.org, mst@redhat.com, sstabellini@kernel.org, anthony@xenproject.org, edgar.iglesias@gmail.com, qemu-devel@nongnu.org, xen-devel@lists.xenproject.org Subject: [PATCH 09/22] kvm/i8259.c: use kvm_i8259 prefix for functions Date: Wed, 16 Sep 2026 11:43:37 +0100 Message-ID: <20260916104435.600211-10-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260916104435.600211-1-mark.caveayland@nutanix.com> References: <20260916104435.600211-1-mark.caveayland@nutanix.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: BY3PR05CA0015.namprd05.prod.outlook.com (2603:10b6:a03:254::20) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|PHXPR02MB11343:EE_ X-MS-Office365-Filtering-Correlation-Id: e53f911c-66cc-477b-ffb5-08df13df9485 x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|1800799024|23010399003|18002099003|10067099003|56012099006|22082099003; X-Microsoft-Antispam-Message-Info: uspjZd+TqpZfrDi+P88YVTHmXXBueMk92Zgkkm8Jun3CVOrez0PfNu6ARjlsej6zMd02GaQ/WnJJJvQegfgwr1Gj3Hs0F36h6maCe8O9nHtDlnQMjWWbhaVdBcgrEm6kVvd/M04IgcrP9ED9XyI+8GOYsGbqN7qV/afCqk5izDTePvJTNML6tqeewZdgcVu98y7xz7Skd8y1ZTiyUYPiQw5epnHInnrLuY1Bhf37fQ+10e910ODqX8ODWz0M6YQyJZd+LOwgoT8mArU/ZVL6saNU0B+FqeuTMDv0XwGcbQj6nI0ISIef5w57oiHeR/MMvkUDoSjTf+0Wkg9lvbeecO3OhOQdszxlhANH3wuHI9tbyh91CJhPO+4aheqYocRfWDl0rM9c3Qb8oX4HYJm2deV2n0edalvv8PwszMcNQz2QV3eNRVfc1sE4pP8y1olJ6atMrQagwLmJLuj+oaUTi3sCMZ1ceJePGUY8foYG7HGPmPtQNDxsJ2Zv9K5EOULVNDdNQGoWEcpDZkWi5UPXVTBTSRpBGIH2KhVzTkCc9PhJZpodoa9iPNDJGpJcP/uOCvlup8pVH0ubpK1r7/Elz4NeeevWymMyzCeWYdmiB6qyIM+HOx0E14OnCu7dTT4glJpG6gZBRxAjev/NNAM4UP5J7XTUbdqQWtQ3hkYTKyQ= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR02MB7159.namprd02.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(1800799024)(23010399003)(18002099003)(10067099003)(56012099006)(22082099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?UrViESBIOGc2G1j+3aaeHXamvjOHeysESpFHO30/xdSux06npIwfeVLpZIOm?= =?us-ascii?Q?vRcE8/oilNU4EeObRSIea11e+P+V5L37dc9N5IJF54yE2+9PnNxsR+Yo7OR/?= =?us-ascii?Q?XA8IAkgst8hIwGPhbNFAvGED55iYz5Yyqj2Y6cFm3aM+m5EOxIJN4/+akZwX?= =?us-ascii?Q?lQp4DYGl2FD8Vc7930U34nd/i9vr7WmwfJt8gEqooA35D3K8WK72cKz2KD3G?= =?us-ascii?Q?d/24Bd98qKMpu040laErd9Kcy7zjOqJ7q5cWlBd10ZJIgC+xaUWewIAC74dt?= =?us-ascii?Q?Ct9HL5YeLCfnXPMIYjibkoEzo5cVVO5r14pB7qQkM445nCwznnAZi9sxkxZK?= =?us-ascii?Q?fMr/1byJbz44G5ljbxxJRVqDRH34PJQWLG4L7axYNwDHS2WgTW+jzjTcT2hS?= =?us-ascii?Q?BGLitEsxV9pbMoXxe7JejMLhYpBNwa00ktG3OogfX9EfPfj20g+v/1y0rIQE?= =?us-ascii?Q?ntPNyxwckkglTzZ4bJ6YntTL/KIslz3Ev27NSzc38aI2inP1C1RYYJe55n2H?= =?us-ascii?Q?cVblgfyOmsN+TtKhn28Q0PfP25T8qoVmBncnxhuxC8ucUfuLdxOSKB48nU8Y?= =?us-ascii?Q?0Akn+ljHgFIKs4M1BDmimT8fFSi9t7NtYoFNGOh1PTktXsL9Kut3PT70HFO+?= =?us-ascii?Q?ielSvmqGNswmdHpeYOGsXxpfWv22sAWQrjA22+s5Pe3U3j496oeVImWMkwOj?= =?us-ascii?Q?jseOIS7hK+IHhe8FFljmSeKDyw0OlKfGODyEAVtLKVIKnYU8kPYPNk/2v91p?= =?us-ascii?Q?HtZuykix0tiR2RiqesC9mlyddsAJGqfE6jozoaHLqpllOAXygecP0+eVPUxi?= =?us-ascii?Q?kei9eIC8gjuUfwkOEDONzNpKLmwhWD6C2ydWzUXj/fUw/Kx35F1KuU6zkRJJ?= =?us-ascii?Q?hcT8lOW64ipmhuDKu45UYahAqMl5xdl2fAApgKTIdPceOCQLeTlZ6q52JBdS?= =?us-ascii?Q?Tpl+dTXE1FE84/hSKvt82EWTXjMDU5oLa77ND/qtAjl96iXQawAGhddmIG6A?= =?us-ascii?Q?PVUxy6wWt74TUKiiZ2NXiuTdqIhrBC/q0kfdNKg+wUiXhxE6dKRV8m7e//81?= =?us-ascii?Q?Apa2dD+/EczGVbZ+KeCwHsr2tJCp5jXJZgQIIWrzL0H6UK+FNys5QbAruibz?= =?us-ascii?Q?KsSHQZtF6P4Grwh76U3MxdIm6ULl5axsNa71hPOrLDQksEqC55U+C0DQEvOw?= =?us-ascii?Q?qJ2Hz3TjJz4XdD10zjl4yr6yVFNr9j5CL5huCKJo8t1b+WszcUxLDwqVNoLF?= =?us-ascii?Q?Gir+34VF8n3ovACmSu0dLyIwzzg6lJicKDg/uFqPbHW+FEglt3tMiCK22FCK?= =?us-ascii?Q?RuXNx3Mb6zl5I7Epe5R5wQWIQklvBhh0CGUeRV3uB5gEV2IbRp+Hvq7eer7D?= =?us-ascii?Q?MoqqL3E1XmS2rZKjHA/TFYP4/f08SfTjGHfDNCt3S33d1iqUnwbBqZQQ3IX1?= =?us-ascii?Q?L4ll2mK+3tHjsoqHH3/JX0nfGKN3ma+VW/CdBtbPUaKm5yM99M+tS7+Xu1re?= =?us-ascii?Q?c1ti9GduiRKdh30RpEBnxzMdkYsh3lRrlpZVKKFcTtKCwzBNkX2BdKn+j5VE?= =?us-ascii?Q?x1ikWEvYeCmlPioOqvCaOzFIZ/buXZPMsr0WN6Jsh5FD7yOjugrs5yWzumgM?= =?us-ascii?Q?fDgUY/6HG2AZQ0gWLNRgysHmANP1CKUsSz2q2ZhmrjUZEuXF9DhMrXJXYO+x?= =?us-ascii?Q?AeyFztOdw+SUkduK81EwPtTaxnywfApmEkakF2qaES0SmaUWLbmIra4q9vgz?= =?us-ascii?Q?GukDXRxo6kzb2O6V172QROWoaCWcBm0=3D?= X-Exchange-RoutingPolicyChecked: AHH32F8l9b+IL9t4X6TLHplogOJ6ijoggsP3OxrnBDE6W1ouVjao80PAMJMnwrbHID37RHDSMbPC0noaGRd3LuPnN+ojyZ7ofjDr8lWtoYHOou4Ww6/lzHkObiEP75PqVieBJo7Xd54LWBBgQIXbxaaJ4/ZRz2czVzxiddSeEdlFzw1mAApLQds8/e99izpXIDWao7Uc7vchfDztgbUtctXacRbT4Hah8R+m8SNvGZPvESuIl+SHMeenCD2bxsmseHh9gdg4ofITfH5iuRaynN/tjZVJFj+6dpp/PG5p33eEsGygrqhlGjHaUrnQoI61E8G2aipCHrkCTM7RvNWyYQ== X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: e53f911c-66cc-477b-ffb5-08df13df9485 X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Sep 2026 10:45:10.3027 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: AWlReVDpbF8MdOEIdhtaAufd8OAF/sWE0lgm85XeirSXeh26v8VPcdLQh+ALT2T1+CLunOIfifrSocwrlnCRBxVMsk+0LF7dqoaJt8A4Ouk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PHXPR02MB11343 X-Proofpoint-ORIG-GUID: -LgbwupfRSQeycAqC9PLXcpxPNnu8If0 X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE2MDE0MSBTYWx0ZWRfX9aXO6XXv4Imv b4QNFMNJKrlWbzqzstjQY+t4MfxlPH45J8bv5JronZq1dS/17nbm0pBYlCb/sjTFFqRx4LzW9mp Nyj/bW5/3BukxZadbeujW/TDPk78BFo= X-Authority-Analysis: v=2.4 cv=IbsSymqa c=1 sm=1 tr=0 ts=6aaa7337 cx=c_pps a=0JIDn+9SpPUHitkVorI07Q==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=xqWC_Br6kY4A:10 a=VdqzKS8jKosA:10 a=0kUYKlekyDsA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VofLwUrZ8Iiv6rRUPXIb:22 a=1L6crL_YRTbalZ11mEUO:22 a=64Cc0HZtAAAA:8 a=TUTnhI6DmTZhWknvEmIA:9 X-Proofpoint-GUID: -LgbwupfRSQeycAqC9PLXcpxPNnu8If0 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE2MDE0MSBTYWx0ZWRfX9XNRIZAHGYDE KTFrRneWP5UdBzO8NG4kx5o2H3UTVZcOQfNPnisraPmj4QsexqyH1BBIegRQ7dFpEVwOeabVX1j /1WIvjW8UBoYXvzHqY/MR1FlRXkbCgWOeLiArNirl1jE3WrbnwRiKB9vJOLhzinktwuRlxtGp7z bMUagofS5uWQulwlug9yxUdxQw48IQvemA68ImasFWVGTqodZ1IWejyffTwDjWsWSsOo9BwfQU+ FboHAdJ4V9kR7BrK81Hzr+8xz35vGoqz1ETy9NPVEW8S4Luks1clH163PSMxwX4aZo3d3iN836C USdQDOK4LDH0FE5AqJs9C0E6xvr0hKImV10T2DkaY25TtaZJziwQNfSBuTcUUjCp0dSdy3bEPYK jv+X8HKIYJ8Gxb9M9zxXHakGI/sHsIStljPlBnLqX06FBEW0JH+Gp+gpNC9xtjAR9dX0749/0pe 8zagrjj2ksE9tuozy3w== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-15_05,2026-09-15_02,2025-10-01_01 X-Proofpoint-Spam-Reason: safe X-purgate-ID: tlsNG-c201ff/1789555516-73EB92A1-06CF51E2/0/0 X-purgate-type: clean X-purgate-size: 2669 X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1789555554905158500 Content-Type: text/plain; charset="utf-8" This ensures consistency with our normal QOM-based naming convention. Signed-off-by: Mark Cave-Ayland --- hw/i386/kvm/i8259.c | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/hw/i386/kvm/i8259.c b/hw/i386/kvm/i8259.c index 6c79907aaa..28e6e40bd2 100644 --- a/hw/i386/kvm/i8259.c +++ b/hw/i386/kvm/i8259.c @@ -21,7 +21,7 @@ =20 #define TYPE_KVM_I8259 "kvm-i8259" =20 -static void kvm_pic_get(I8259CommonState *s) +static void kvm_i8259_get(I8259CommonState *s) { struct kvm_irqchip chip; struct kvm_pic_state *kpic; @@ -54,7 +54,7 @@ static void kvm_pic_get(I8259CommonState *s) s->elcr_mask =3D kpic->elcr_mask; } =20 -static void kvm_pic_put(I8259CommonState *s) +static void kvm_i8259_put(I8259CommonState *s) { struct kvm_irqchip chip; struct kvm_pic_state *kpic; @@ -88,14 +88,14 @@ static void kvm_pic_put(I8259CommonState *s) } } =20 -static void kvm_pic_reset(DeviceState *dev) +static void kvm_i8259_reset(DeviceState *dev) { I8259CommonState *s =3D I8259_COMMON(dev); =20 s->elcr =3D 0; i8259_common_reset(s); =20 - kvm_pic_put(s); + kvm_i8259_put(s); } =20 static void kvm_pic_set_irq(void *opaque, int irq, int level) @@ -107,7 +107,7 @@ static void kvm_pic_set_irq(void *opaque, int irq, int = level) kvm_report_irq_delivered(delivered); } =20 -static void kvm_pic_realize(DeviceState *dev, Error **errp) +static void kvm_i8259_realize(DeviceState *dev, Error **errp) { I8259CommonState *s =3D I8259_COMMON(dev); I8259CommonClass *k =3D I8259_COMMON_GET_CLASS(dev); @@ -131,10 +131,10 @@ static void kvm_i8259_class_init(ObjectClass *klass, = const void *data) I8259CommonClass *k =3D I8259_COMMON_CLASS(klass); DeviceClass *dc =3D DEVICE_CLASS(klass); =20 - device_class_set_legacy_reset(dc, kvm_pic_reset); - device_class_set_parent_realize(dc, kvm_pic_realize, &k->parent_realiz= e); - k->pre_save =3D kvm_pic_get; - k->post_load =3D kvm_pic_put; + device_class_set_legacy_reset(dc, kvm_i8259_reset); + device_class_set_parent_realize(dc, kvm_i8259_realize, &k->parent_real= ize); + k->pre_save =3D kvm_i8259_get; + k->post_load =3D kvm_i8259_put; } =20 static const TypeInfo kvm_i8259_info =3D { @@ -143,9 +143,9 @@ static const TypeInfo kvm_i8259_info =3D { .class_init =3D kvm_i8259_class_init, }; =20 -static void kvm_pic_register_types(void) +static void kvm_i8259_register_types(void) { type_register_static(&kvm_i8259_info); } =20 -type_init(kvm_pic_register_types) +type_init(kvm_i8259_register_types) --=20 2.43.0 From nobody Thu Sep 24 19:04:36 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1789555541; cv=pass; d=zohomail.com; s=zohoarc; b=FFFaGTPAOTI4WFasoblP5ceN0Q8QPtAt08PAThaKUyxZT4cpJfzXpqwh/q1XcmCG5DwV+7J8+nYrTdk4I1RXEIbGX63mZaIY50YAT8/96kY4Y+fXwxg93GuZ6hDuzYjh6JFmXUDNMNkdT4InR9HP7rPQY+SujU7IyQBWENK4amE= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1789555541; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=X2tdt+OFRJu3/CyARXQCgURgSsSHaKXcsV/f/DeQLC0=; b=BOUmCpbPtrCvQjzskK7U1gOawU0Q801PEulu4B8LIrJeZkbcuTvRfbgUv0AHhTM65eosuKVMw3JR+9b7+gGPUDcUiFtbwSk2NTFbUkHygFW1gET46nGPISqRpPUSukcno+55l7SsRgtkcl84GOa8t9bNPl5SW1BWhCjZb3W0VeY= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1789555541742366.9308076788184; Wed, 16 Sep 2026 03:45:41 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1422595.1648001 (Exim 4.92) (envelope-from ) id 1x6n8l-0005I1-2k; Wed, 16 Sep 2026 10:45:23 +0000 Received: by outflank-mailman (output) from mailman id 1422595.1648001; Wed, 16 Sep 2026 10:45:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1x6n8k-0005He-Sa; Wed, 16 Sep 2026 10:45:22 +0000 Received: by outflank-mailman (input) for mailman id 1422595; Wed, 16 Sep 2026 10:45:21 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1x6n8i-00056z-Ui for xen-devel@lists.xenproject.org; Wed, 16 Sep 2026 10:45:21 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1x6n8i-009uMQ-B1 for xen-devel@lists.xenproject.org; Wed, 16 Sep 2026 12:45:20 +0200 Received: from [10.42.69.2] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6aaa7333-bab6-0a2a0a5309dd-0a2a4502b36e-26 for ; Wed, 16 Sep 2026 12:45:20 +0200 Received: from [148.163.155.12] (helo=mx0b-002c1b01.pphosted.com) by tlsNG-720697.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6aaa733f-6ca4-0a2a45020019-94a39b0c1600-3 for ; Wed, 16 Sep 2026 12:45:20 +0200 Received: from pps.filterd (m0127843.ppops.net [127.0.0.1]) by mx0b-002c1b01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68G8P5He767662; Wed, 16 Sep 2026 03:45:15 -0700 Received: from ph0pr06cu001.outbound.protection.outlook.com (mail-westus3azon11021107.outbound.protection.outlook.com [40.107.208.107]) by mx0b-002c1b01.pphosted.com (PPS) with ESMTPS id 4gqdhm9r5r-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 16 Sep 2026 03:45:15 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by PHXPR02MB11343.namprd02.prod.outlook.com (2603:10b6:510:3cc::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.428.9; Wed, 16 Sep 2026 10:45:14 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::8e97:bc32:822c:b250]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::8e97:bc32:822c:b250%3]) with mapi id 15.21.0406.007; Wed, 16 Sep 2026 10:45:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=proofpoint20171006 header.d=nutanix.com header.i="@nutanix.com" header.h="Content-Transfer-Encoding:Content-Type:Date:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To"; dkim=pass header.s=selector1 header.d=nutanix.com header.i="@nutanix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=X2tdt+OFRJu3/CyARXQCgURgSsSHaKXcsV/f/DeQL C0=; b=FJppL52EIWlx1gPC8DqzjanmQIgsEPl9hlX3JwrrSN+nZZpBuKjLN0rtZ v/AMwbYWOgeTcuS7NniskUEf5CjwxWtMfPxNEUPnZ+dY9F+3oXCVAPY1/hd6hvP8 96lZPPPS4a2kTf9IKv3sPSlP5twGoerKxoPJ5JMNLadZR0fue7f78PyAnceVgEqd dO7vLbzynpi0aNobRDPRjQFwsAfCp0w361JiI5U393JhGS0E3Y6AtVAznRc3wdeQ Zn4KTYBGCACuDccgBIvV31PJ39Qg1VMVGMvaizQ2l/BEiItWjC6uRa+4yxckuHL5 u9fgag4WPveWjZuW/l3jYgYUmSQwg== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=NQO/vaaCAqSpCRa5TMHFZf3YKzFNFehxiKbdPwxjBTbLl/V/cFc+/Qx0bJwrYJyJJmiOW31ZOkwoCkXNA1+FM7TKR9FG5CbLSCH+WCKuMvJmC0QrOeTQ2MDy+dI0HOb/ij0dLYaKD4rZH7dROW5b49nY+Q7ORU8clIh8Np94OssZOJskatSnfunTvzftfynHeVLsN3WQi/IeH+Tkw7M2o/RSZyZQS7wvaJdAf1heywv9vC4fWbpNdUO6HfYLv/vABSfRgtd1kyTErSJKtRbT0Zr+vm38Rx74UA6GLqju+rw6OCtJxiKHv8GrTDkSb7rqgGO6gMkJk1l0VGoV8te3rQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=X2tdt+OFRJu3/CyARXQCgURgSsSHaKXcsV/f/DeQLC0=; b=cQaKTYEhGgOZ1SqIq+WdWBq6mKADQf7ao/hmCduzmj/PsJ1j0ehKOKxiEFNG7F+/EQ2zJ+/ceu796+WdMdp7dmCWzIWOV20v7zwydRTXrdqVS5BGwDkExO/5ljQMrik5AK9Fs55KqJGFMhRGuSIEZT52g9ntWWpC1H5CjgXplyz3d17aJx7yG2JQMrc1R6aM3kka7axN3H33nSUR6JoMb5JG/BbgBjVoWZxfGyCzp9yNGTk+kQidLpUn30t4/tJnySVZDY4tXPYIkz6+OGXI+wY27YF6McPT9lPCgWosCML+O+XePibmdBqvDQsmR65dHt18+zrQzHVrrXMPXcPy7A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=X2tdt+OFRJu3/CyARXQCgURgSsSHaKXcsV/f/DeQLC0=; b=uoFqTH1U5oXo5A1RSkyi/QlT2h2AqcKvfaXUP7k29HmoIkh47IsbUuD7wfkdh4txW7qrV1CDfiU/2fQDEZZ7zSRbmVztN1DeCK+ZDPu/TC5d75uOp8GRwqAgivEz8RbfJPsWJDLkgzKGo+ICG5+mgh0rJUp5qJwOG9J02AyEww2RnjMHCIy1iBGOnitjv6mMDcSUBT6l0J7BFPHQaxzEC7gs46BpCRVmg3og4m2hjumG3wirZZeVqUscOv4EPIkQVwxvbQznzhxpHZ077hhL0uzIND5+QGMd5ZGx72UvR3A9TSXovbmZjrRTeHBgf49zljU6Orv+OUHQYemvVjVOEg== From: Mark Cave-Ayland To: pbonzini@redhat.com, richard.henderson@linaro.org, mst@redhat.com, sstabellini@kernel.org, anthony@xenproject.org, edgar.iglesias@gmail.com, qemu-devel@nongnu.org, xen-devel@lists.xenproject.org Subject: [PATCH 10/22] i8259_common.c: convert to use DEFINE_TYPES() macro Date: Wed, 16 Sep 2026 11:43:38 +0100 Message-ID: <20260916104435.600211-11-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260916104435.600211-1-mark.caveayland@nutanix.com> References: <20260916104435.600211-1-mark.caveayland@nutanix.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: BY3PR03CA0003.namprd03.prod.outlook.com (2603:10b6:a03:39a::8) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|PHXPR02MB11343:EE_ X-MS-Office365-Filtering-Correlation-Id: 9f611f48-a192-4198-e6ba-08df13df9720 x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|1800799024|23010399003|18002099003|10067099003|56012099006|22082099003; X-Microsoft-Antispam-Message-Info: R0FmaNe43d6KeEPyWoMoYIszH/snIJx9M/Csyg8m0MaXtyT49xiWYhxgkuwT9aWYixham5jSf7PEytPe+9Wa5Vs1zxV6ZAvvB3nJmoC8MC29D0c48zozGPtFRGcNibAxZijhcOeCe6l5mrHXVgHicFlDkT1XsveWPKl6RrpOJx6mKjOqax5kd176mDD6Z4qclcpIgylDZ5O3nV7kRTTVEbJ6fFN3CXk17RH1FLDsdYMhCOg7Ly8GdPzTOalX1i10z490u7Vz5+XvA+JTTatTBwRuvSg3n2QWJ5KAMCVbiLUCevbibZizZUKb/4uUDXtYen06UlteFR7PLW09IrudestWJZ1cMhbsEvNbAmjw2XGJUKVUeJaL7fFuExn3Npe7WLuV++bT/B/ves2zk+wpE7xBOZpzHWJVyHC61bGbFvsZ7ADMCaHJAqNpZINWuThm7v81XsI4JSRxf8RmrFUoLUq0iqx1gKo/T3kqwm93acbunD8Zkj/CN9AOAn/kJHIV/3nMPD1pwG81m97Flm9xrgUpzBlEVQq+zQO9mmYQakTxK9qUruG71k4GjBfAiW52FJCEdCT/nUQ8hUaqmF77bUEJeuTFj1UilZxrum+8TO9/gM0NvQuqr8HUs+lm5oqSnxQXalmIV6BBdgbO1EuJ8738aRHNCdGAnQOJUcAoIdM= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR02MB7159.namprd02.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(1800799024)(23010399003)(18002099003)(10067099003)(56012099006)(22082099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?qUEfJ8oa7buYc7bX+Aq4HAea77L2DFzkyMM9xzxI3SE5VDGyAq7FgTvmPRXQ?= =?us-ascii?Q?bIIZOZyc87Sy67BenoKoub9hIb4Y83OCQOTTh6ufVWun3Rr5c3HMeJbH3MBN?= =?us-ascii?Q?zckjLyekwsLki7cHN2KsiMYk4b+4ZtgSR/bNFhfeAdoWH06o7QpwfdDeVdzf?= =?us-ascii?Q?ppSj1UQammdXqGM0IboqC78GGHMYVYavI5vmEDB+y3tMg6k2YPU0ZbTIN28B?= =?us-ascii?Q?6ycqDyOoHvGzxWaIXHWOO1lJb0M/t+fRovWwLJU2e3EIRHh3ekGyU0YAhbCH?= =?us-ascii?Q?lFkcEpQvg5q6XwJ46KxqWcPowndNw8d7Y9QZKyZDkbMi9v2GZVxZRnikLwuI?= =?us-ascii?Q?BCsyBucutoL9s+8rjmIwikB6aaOlJhjrCplfX6QJAjngzIc2EwojIK7CKo2b?= =?us-ascii?Q?95TwKu0xr6Hf+UkR7i7TKbMS0/E3cWS7cSup5qY/wDqV25EFtiZdek2MmBOu?= =?us-ascii?Q?ApFfubvsS6sokmL1hvrAWeGy/VZRhseQ0ylp4V0dIDdHPhZcrTwxh2E6ndMc?= =?us-ascii?Q?n9UMV9lDOJfT1Tl+yQzeqFNC7CdnqDdmpR1Y+PdzpvwWRALbhcHxNCO8ZUkx?= =?us-ascii?Q?CPzplAakFGoUcadVLcFs+6WeEHTbIh8BtlEh6qE+AX7SMWq4n55prwXReVIw?= =?us-ascii?Q?sfHM57WqKqrC9Z9GCk263x0cT04lxTXyRwYGSJtL/97BG/5JSkoEpI0qPfJd?= =?us-ascii?Q?NRAVnjfnyam3M5yh+P35YT++z8SQVoJI0p26RrPugNyfKmLna5JRLm+f7EV5?= =?us-ascii?Q?lA6dk8bZDnPsMt1xdi/FSJKJy6huHEQI3FEKh4aICaXqzYe7Cv2ZGJwz9FJ1?= =?us-ascii?Q?U3T4tPW33/yfvAmuR/qmaUAVrkBn6GrjZOaQCR0CY8oWdYcgjgYirLMcrBAF?= =?us-ascii?Q?m+aTo/1ifhPHCq1yAZRJvgChLF+26TyZEgs0ZI/Lgv7RjY3kxNKoe8TufVT7?= =?us-ascii?Q?PN0X0k4j6mbXEUGj2BRkDeAHY+BdJE964EztRz7Ecw+qe8B0T8clXkk7kPSO?= =?us-ascii?Q?xi37YaUVbRtqkuPLvR/t6FuKvbF81fEWJGyqtUrKR2lXDksx2mVTnK1i6i59?= =?us-ascii?Q?pzrvH7zS/rBJWcQ4msYqL7URyJmU/6NkHjFgdu/CXV8R028WUIRh8DjybPIF?= =?us-ascii?Q?HQevVFWzLaKoSV1ULhq108+R2s/dCwf6OPXzKWFkiLuZl5tzQO+uneHQ5/DA?= =?us-ascii?Q?CefOPfBGtlIUc77fByGYxVXbbMSvNC1sh3GEoWyHtihe7nVPpBLRYQsFTQaa?= =?us-ascii?Q?fQztoNmW1vzHY4Slt6+wgVj3As5bwta+18zJRtLpiZ+jhgw4D11BMBJPUmlY?= =?us-ascii?Q?JapW7x6Mb4JWYgl4ENAFWZaMpDB9NE8XJobBBe6lmj6CRX5loI4SqTce1lWd?= =?us-ascii?Q?zUPFxaHJoN8K88b4Kp0Md+LHIMSAUrxk7JNKRrlqCkjMOD2xmFFDhxCu8uJW?= =?us-ascii?Q?ml21pRnUnVGmUYe+jec2Y9gFx/NDFNlE8n8Wbf//M55EqvXwNIPka9tNLBxY?= =?us-ascii?Q?a6lP/4F+8fshQHJhjMmUM5FTWa4v7w/bbyIo+AJCkPXswuruNFstPphM5/6m?= =?us-ascii?Q?LsLg6kQFICmcWTMeX/33146/Kb7gh/8moTX9q4ayRA6IyGyyJLs6tNnXlDE6?= =?us-ascii?Q?Y9x4Guzr/ChUHxu9LTz7Eg2THp/5GkIehVm+YyupmkyJ0Qr/e7364op/8vv1?= =?us-ascii?Q?uGUnBuUcuRi25Jym0kIQAqLW+wOSChml0oLizDHVU0RmVvNon1pp77PBQj66?= =?us-ascii?Q?5J+/UHSWYebhCUfvYOeoZoqagQT4IlE=3D?= X-Exchange-RoutingPolicyChecked: LfgLXvB5EuUvkgLgq1kDx03FgihHEJ/2/XmuX+qaABZB02gWcNbr72HXt36B7ZMba7bnBqtx2MpKV0imENdrZfuYgPalKzpg849VTmUoASLLyJP/NnLZlwL+sLi6cZ/OuF++0tzXvp2p8GnvFL8ip4rRtA8TEljBzLqTqeqRpwNPW2Hy+yvsbsiDrdj2A8bs2WGu4F2BcS/MiL037qQi5LJ1KWzDs6XkSPyPP8Hr479hmX70/KbZKef7kRNi8qJM5QCjQzK9AWxAe2GWFApWwLldIa6RP2NMgiO0uPwjACyCHo3S0jhj3vgouC64d3tlDHx2RTFQeR+RLTADDKC43g== X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9f611f48-a192-4198-e6ba-08df13df9720 X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Sep 2026 10:45:14.4800 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2sjoA53h4b1DnOmHcSZW4k3XCzGj8Hah80RHfhBXxMunwbrLNlluxnfeFOMIQQOUP+UwoRI3dahr+2pquHFhXGJGjyinDRW5x3KUFgKVJl4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PHXPR02MB11343 X-Proofpoint-GUID: RqA5faqyttuuwWO5UZprhGJV3WeZmooD X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE2MDE0MSBTYWx0ZWRfXxLl8jwUk2/z6 TkpY4bnv6IvMjJxZnH7OtGieAKfLW3E5050ZyJqeKrBulpP5BzO7MXPtU++4PHvVU5dT72knMXa WEw5HvakiOs1Q8ovbXi94ZjrPOnR91Y= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE2MDE0MSBTYWx0ZWRfX7ngutfmFB9nI NA3vlYrG7YyVXE7uvbh83FTbLKmYmzuIplzdIPVcDT9ozd4k3l68yz7p2GsNo1nWscumXB5hH2i 7Z2JT5ZdIMPMvN91LNmZuBeKcuOF/q5fMq7JoP1jYgrFDxfS5xIuU++jhFEchzdd+0vzvzASwdQ jgWe33YFZQK04AgrLi5j93ruECEiUFBbIZ4WGIiWMc49Ju57Vt3dkY6BXHh6uevLJj3tVq8Tw/I M6vx6dU+8WEZtF4lB2TKV7n/o6FXfBSK3WADWBcTKahbnIk0G/TnydmK3X16R/SMv/bU1hxbCM5 DX9L0ylZVTublXe3Jyoy2Uqa3CahVr5i+J4qLPjZuT4muZ1pMGjOmF9Ae5lNbhwDg++kOWkfkGe 02XRXsN87QgeiCu3ifl0ySUbaYi0LtG+GbtziQTDbtZrBleoNQopfXypAGm4vE4+DwA3KsNsD9m jKkX63SQGzPGh+Ad7pQ== X-Authority-Analysis: v=2.4 cv=IfkSymqa c=1 sm=1 tr=0 ts=6aaa733b cx=c_pps a=WvTO7h1a7pp8pZEQxufCPQ==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=xqWC_Br6kY4A:10 a=VdqzKS8jKosA:10 a=0kUYKlekyDsA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VofLwUrZ8Iiv6rRUPXIb:22 a=dEe9Ve2bX-KnNSUMM2s9:22 a=64Cc0HZtAAAA:8 a=bPck6Z4TT5Um9jj7BtEA:9 X-Proofpoint-ORIG-GUID: RqA5faqyttuuwWO5UZprhGJV3WeZmooD X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-15_05,2026-09-15_02,2025-10-01_01 X-Proofpoint-Spam-Reason: safe X-purgate-ID: tlsNG-720697/1789555520-303C42AC-3FCC8A15/0/0 X-purgate-type: clean X-purgate-size: 1540 X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1789555542865158500 Content-Type: text/plain; charset="utf-8" Signed-off-by: Mark Cave-Ayland --- hw/intc/i8259_common.c | 29 +++++++++++++---------------- 1 file changed, 13 insertions(+), 16 deletions(-) diff --git a/hw/intc/i8259_common.c b/hw/intc/i8259_common.c index e03bbb9a8c..ec229a0b5d 100644 --- a/hw/intc/i8259_common.c +++ b/hw/intc/i8259_common.c @@ -220,22 +220,19 @@ static void i8259_common_class_init(ObjectClass *klas= s, const void *data) ic->print_info =3D i8259_common_print_info; } =20 -static const TypeInfo i8259_common_type =3D { - .name =3D TYPE_I8259_COMMON, - .parent =3D TYPE_ISA_DEVICE, - .instance_size =3D sizeof(I8259CommonState), - .class_size =3D sizeof(I8259CommonClass), - .class_init =3D i8259_common_class_init, - .abstract =3D true, - .interfaces =3D (const InterfaceInfo[]) { - { TYPE_INTERRUPT_STATS_PROVIDER }, - { } +static const TypeInfo i8259_common_type_infos[] =3D { + { + .name =3D TYPE_I8259_COMMON, + .parent =3D TYPE_ISA_DEVICE, + .instance_size =3D sizeof(I8259CommonState), + .class_size =3D sizeof(I8259CommonClass), + .class_init =3D i8259_common_class_init, + .abstract =3D true, + .interfaces =3D (const InterfaceInfo[]) { + { TYPE_INTERRUPT_STATS_PROVIDER }, + { } + }, }, }; =20 -static void i8259_common_register_types(void) -{ - type_register_static(&i8259_common_type); -} - -type_init(i8259_common_register_types) +DEFINE_TYPES(i8259_common_type_infos) --=20 2.43.0 From nobody Thu Sep 24 19:04:36 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1789555564; cv=pass; d=zohomail.com; s=zohoarc; b=gL/b7dIL3V5phFTc3krgrIUGiosvFqEcnf+gLDvX1i4/7G1vQkrE907TDEknHogXvGWuXYTbR7zBJ/0sZxefh11GsagWVEW38KUm+ZwQR5TLrgs9yfN2g9wzenHCo66EI849OofTJGb0Tjl0qKJuTCfGtRL2YcKDTgJflkuCLFc= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1789555564; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=iHuChNbu5rbXyA0PVs5s0TbcMgtzaERrjGU1D2vny2c=; b=b/OEhsLs1tPEwIbFF4TupM6VGOdBG51CHfenEQTze3maJyMAfxzIl865CRS/j3iFExk3UOGWbeseWFNt34/Xd0iYiI4XoTQOBT5H3uSTcWfVZIGCfELBkEBbblp0bhP5cF3ZfcNFWiQq0Z+RQ9gyt4FCbHW5DHejVUq0hFbGN0U= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1789555564409748.7677147660827; Wed, 16 Sep 2026 03:46:04 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1422600.1648010 (Exim 4.92) (envelope-from ) id 1x6n8p-0005jv-9N; Wed, 16 Sep 2026 10:45:27 +0000 Received: by outflank-mailman (output) from mailman id 1422600.1648010; Wed, 16 Sep 2026 10:45:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1x6n8p-0005jd-4p; Wed, 16 Sep 2026 10:45:27 +0000 Received: by outflank-mailman (input) for mailman id 1422600; Wed, 16 Sep 2026 10:45:25 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1x6n8m-0005cy-Rp for xen-devel@lists.xenproject.org; Wed, 16 Sep 2026 10:45:24 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1x6n8m-009uPu-8O for xen-devel@lists.xenproject.org; Wed, 16 Sep 2026 12:45:24 +0200 Received: from [10.42.69.8] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6aaa7343-2eae-0a2a0a5409dd-0a2a45089568-2 for ; Wed, 16 Sep 2026 12:45:24 +0200 Received: from [148.163.155.12] (helo=mx0b-002c1b01.pphosted.com) by tlsNG-c1860d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6aaa7342-f659-0a2a45080019-94a39b0c8042-3 for ; Wed, 16 Sep 2026 12:45:23 +0200 Received: from pps.filterd (m0127844.ppops.net [127.0.0.1]) by mx0b-002c1b01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68G81MRd579034; Wed, 16 Sep 2026 03:45:20 -0700 Received: from ph0pr06cu001.outbound.protection.outlook.com (mail-westus3azon11021117.outbound.protection.outlook.com [40.107.208.117]) by mx0b-002c1b01.pphosted.com (PPS) with ESMTPS id 4gqbtb9yb3-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 16 Sep 2026 03:45:19 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by PHXPR02MB11343.namprd02.prod.outlook.com (2603:10b6:510:3cc::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.428.9; Wed, 16 Sep 2026 10:45:18 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::8e97:bc32:822c:b250]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::8e97:bc32:822c:b250%3]) with mapi id 15.21.0406.007; Wed, 16 Sep 2026 10:45:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=proofpoint20171006 header.d=nutanix.com header.i="@nutanix.com" header.h="Content-Transfer-Encoding:Content-Type:Date:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To"; dkim=pass header.s=selector1 header.d=nutanix.com header.i="@nutanix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=iHuChNbu5rbXyA0PVs5s0TbcMgtzaERrjGU1D2vny 2c=; b=aPIChpv9SLgz6h9+7a/QT8YbBtPd7Yxpcu5TiJKB1SmzoGEE4w3XwTc3R E4olm4PAv5Zhown74IZCt0QaKyIncoZoLdTk3cVC4TtiyHsbx+jwf4JqEueQw9RE JmwVLZ0YGSF2hRDSQCgCI8PeteOw1UAZ4ejNDpEUvwYrOF0NaIXVrvkfCGa20mqV ueV4SbgAbGUP+CtUHfOqOCw1yjsFU4OXdBEnc4rsf1qyim9a7UrymDZETo4ar0X5 h408zfbAyhSB3/Gs/h063m7x4lrZRfcV4QLGweqNTXZAaVfO3bh6cCdes4eBjW6/ k/c9BDOXNnZXqwfO0fAaBpPFlYg4A== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=NXoSynAj3pqOeFftRU4ugQUmLGxjxNcZ6WFS14d9HPhYyIyM67V48YEn8Y0HSDyxBUarz7SMi6SEdLKGoQ8wPuk6iKVQWA5L7QkpoKpX+tA0MuXesGCpeCd30wLwvrCHsqrmZBzuL5wtC/j/nMhA19/bZv4l3McoAIZJ5t9tlsNnwovpzmPyVdQ9qg+DbPxXKyZ1aZ0rdV7HtX1RQzd0AdyS3SmT7IsK6ofcNzoHG+OTafDscmZb3Z8fv1zsmlJ7rI6i7fLIvDlZkG9mtLN8B8Ywm/mJLtUf9LIWrVPjz26TzOTE0v278qW3NY5YkIXBFbtzmBnPgFBJZoBYz95+aQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iHuChNbu5rbXyA0PVs5s0TbcMgtzaERrjGU1D2vny2c=; b=OCy3+9scQ85i+x+PnJFA7Dz7zJDE1cux9vdzV2W77SfVg778fLGCwuZBhj7Z96QvxOlpXmUKvxf812sEV6IWXPsKtFMkkGZuijNlWQK7qoAS53wy7rKgRqWF6eWI+jt/ogYL3KOKuqU22rW+edNKyljLwNbvQYQc2n7yVHspeUjdsybGtuosIQesTMZgMoE7XHIK64PVJJoNe/7VLCDmyrtjrXJ1vO90yoWkibV1WGssDg42qIZqTEmsMxoP7cTEPZWI7892btuq/cpCBGleLkId5e0mPuTLBlB9OlM7HDhngkeesdRZ8ayNW3pBIOTmF9ovIIzao3EYFF5LK3dEEg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iHuChNbu5rbXyA0PVs5s0TbcMgtzaERrjGU1D2vny2c=; b=wicJ7Sb77IsjkASCtm9QGpVG8oBTm9x4k3Aucv2350gOm2AOf+w8787d5YVe3Eaw0aHDb2WQSsXyW5lnHPe79gSvRCs4FXr5AOA/7bQNf1VDmh3jmNRYjOF+HvYFj+0JCo1ei+/H6JHeVRDRcThdX54T9lruMJyklx0vzm9MnmIKFoDRccHCHWQ19cuI8OnYDPzXFzOKb4naejA9Q0DUGVQqiwGDqvkPrTgVUu8MHeqOLh++tp9kO2gPF5apjbIPtQNeTCmgKmmDB0qAowTH9+4v5aTzc/2nwEOkJ0srV5moDguqvhfbgqucFBGq8dqyrrS/B14ZRTVH/Z0ZVHPC1A== From: Mark Cave-Ayland To: pbonzini@redhat.com, richard.henderson@linaro.org, mst@redhat.com, sstabellini@kernel.org, anthony@xenproject.org, edgar.iglesias@gmail.com, qemu-devel@nongnu.org, xen-devel@lists.xenproject.org Subject: [PATCH 11/22] i8259.c: convert to use DEFINE_TYPES() macro Date: Wed, 16 Sep 2026 11:43:39 +0100 Message-ID: <20260916104435.600211-12-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260916104435.600211-1-mark.caveayland@nutanix.com> References: <20260916104435.600211-1-mark.caveayland@nutanix.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SJ0PR05CA0070.namprd05.prod.outlook.com (2603:10b6:a03:332::15) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|PHXPR02MB11343:EE_ X-MS-Office365-Filtering-Correlation-Id: 3b2d9d4c-b562-4545-e46c-08df13df9969 x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|1800799024|23010399003|18002099003|10067099003|56012099006|22082099003; X-Microsoft-Antispam-Message-Info: prJoDOR8yx1WBqIPyJNTXUB8ZLH+vqWeUJs5H6umAmMF5NcLWgXoUd8IKgvhTk1hiu78Zz0c7yRAPXcWX+QR0j9Hux/bA6kzmagFAj66GFwV5CRyvSQgX5+mjSpaSqz7ZAFSvl4znUvTTl2pFBh5w66GG0sK/lO4+zVHH+zaZ2qea+uOG7lINk33LFPLhOEvWF90MhRTjq/mXkz8OVZW9oyDVsZxWM0uiZClSawuXQDGsbiCDa1YaiRUZf6Mx3mlJuiPYB0VjnNPlBaZaC2frrtQ2DsQu/jMoL05j03I9rjPyPShEms7xjkRr5IPEN0z+DyqlDR1HHVOh7F7mAcDn3oSpmhVyzUmVkoPPkMxxA5So0B57vlAyeoMNrSF/xEjgpCcLc2p1Oj32Bf2lC45vNrIvstbjXyyuAS2QxKQLay5BZChk3LQFyrmtf0DptnJjcrF0knvFxvab8EiDE74EAnXQa3iC3NGqjXNbescEMKh2koNQsvN5hQvn1+Sk95VhWC4q6Ibl5NOyPQnT08d6zUdQyPPAXnW9/NgAAImisaru3mnTv8klhWIVJmmhS4tMxhgzi63dX441kEnx9/Mvo9QCuxUjA5ydU/1ukzGApqZ7sD8hxxaJ9h14EHq+jm9LM5o8vd+ZcifjZJWDb4KzxYJymhmfXwQ82GSmsgqixY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR02MB7159.namprd02.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(1800799024)(23010399003)(18002099003)(10067099003)(56012099006)(22082099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?GZNsWJUOH8v3xYMC+xQ8yZ3aER1nnzwboLkmW9AEc5PLGE9FEN+UcUM2/qsv?= =?us-ascii?Q?wMf0rrGQ8ffzLyDS3U9RNUWonE/gPEyp65ZvMqppZq2YxtIxwvJZ9kcaL1fg?= =?us-ascii?Q?L2S3tK7qACONpR3uwGOX8T7OPRgRRMdUskO/I3E0QxKmnNxcgN4P6e55UtNZ?= =?us-ascii?Q?WNHJa6TFlsRhvXi/8dUk7B32sCtI6kjO7kjLv7RsHcK487whIlmGB/WukFdg?= =?us-ascii?Q?FPIAVxtGv+9iJFX912emTWfUu2DLWcUKkL9A3m31ioqfhpgx5wwVGwkPEGZn?= =?us-ascii?Q?r6HySyUDc8KHsKkfYOpwoQt0nx7TGb2xf0nS/f32MPvIumQPkSBmPLwjNRp/?= =?us-ascii?Q?HZSn08T6ps5oItCJwpnxOWyiSNSPx1x26hH0l0zQeApUboYacy6Mz19t3RaB?= =?us-ascii?Q?IW8Hn2Y7/64vy9gT/tj6/k0tL/8V1mliT7u10KSt1ok3mm/d+gvd78FxkqPK?= =?us-ascii?Q?Qly7tDlL7thv5vZEk7yVKLTIi7h2G/Pdu26QiAzsgvOGFaXPRRMe5jPdxbBs?= =?us-ascii?Q?tW5X9woG/XGY1MoZ2u5pXvHVDkmzO5cklYo0FuquyNRuwHGBFf7k7/NL/jQ8?= =?us-ascii?Q?f7YgGcVChhhmwz46GhHenh+JNfZl+SGc+Yjouj+0pqpE1n+9RMue+fg8KHyM?= =?us-ascii?Q?JJEtadptNOEJWRyp6aYa6Qzl2xIxQt25LR3pmbXzGCY7XsJUAquVcWKW1IOm?= =?us-ascii?Q?OaBr2BIvwvC4S2Zyjh1j8GKZleSymnXt5TkBh8dZH6VuDHC4t2sWx3GBQn7C?= =?us-ascii?Q?E/wVQo2E1lxKTIVjlDSFpYNTGOk82/PmVGMAFEr1Q2/tYwVGLFVEn6/RvN9P?= =?us-ascii?Q?k+4XklBiBtxfpI30OlC7z3OIkrwU3h90rX58FbMErrpUe7HLwwwB7GwkH3y3?= =?us-ascii?Q?vEJmS+VxPStfq2sW8xxeZ0K+BohGzQGgokBnSgKr6TBnkFCAuSz3KcmK0wjK?= =?us-ascii?Q?ot+wCfsCwE9y9b7dU6r84sYIEsc9FNIH1AwaU524bKW4d+8GrA0jCdEZelMJ?= =?us-ascii?Q?XT5TK8dSk3NQbfrF7aUcFAIPMDwo9ZAbJ1uBoyQOk3bBgZFCrdFTnb05dAw9?= =?us-ascii?Q?Z37fBe0i4xtmSVXhpFywykGTyA9Pm/bFd7Jlt1FXaeJOvo6HyLb8tRHwUNjc?= =?us-ascii?Q?JEtp6jen7DYV/TwA4gxqgRqQv6E8+iC5dC3JNJJkE3bnHbhJozT1sqiD98cN?= =?us-ascii?Q?CmUNnz//aI6jr1RGHPNDQBv/D3oKg2HXH5Zk0+cjdoJFCUD0r/pSB1SCZLD7?= =?us-ascii?Q?aFWQDS7J4WcrxuXfGCxPrU5+aEdXMUD5N5DbT5c0FqxtXSr7bLxoYFy5D19Y?= =?us-ascii?Q?1d+pMEXoumQiDv7GSCs4iRR9jePsb2C1HmqFIq4gAJ/qAf5JEQLTbAoaB7SF?= =?us-ascii?Q?tiiD/2AzhAYGRNHRvBlZ9PfMiAKBiK5TjDuRTHaTqeHmns91o+aEPvbGTHga?= =?us-ascii?Q?I2VWHTMQp+bVWt4dgeeR5x2pFi8E2CQTcBN/FhTBsdV92+1K8tWacyzhYgqs?= =?us-ascii?Q?4sQeW8h3Snl5PHYE/kMcqcqZLbbL9d+FoKOzu9IenWWc79VUOGqT0sdNQrS0?= =?us-ascii?Q?fWNiSxQZPAdKVCszNm590yl8Nu2ieZgNpuUU5dmNZiju3Hw8gaMa8LUS/kuz?= =?us-ascii?Q?uzpYqpwVqtsldjaehhPoG+UBpGovrQMGYoSN6BrNRAyP0NF9NFPrfiiODZLG?= =?us-ascii?Q?1RGc9r0VSjiaQqTckqjzkfJ/uLAeHggwpHz/Ven2rN97o72RqRxXieCqG3B5?= =?us-ascii?Q?XdZBixzhysLKNjEIMLGNqbVndddfnqo=3D?= X-Exchange-RoutingPolicyChecked: jLEfsHiq1xlZcmq9vpqLejaNdN2egt3edMN8H7vRf0xmMYxSkPAErmqOJTzYT8vQPDrmFupnsSi9q29Uwm7tzN1A9TnoFtAlTcTjmAxYsuzNEIO/LXevTmxTu/Jew21FobA7r0xhmCwAFxOJOXRxZoiv+ipviAwBeQ3wPhIJNPuw2FLBPJollkCJyOAXfA5UolU8CmvXfPbTuA5IJFG6MhnERwU8tW24apDdtnWAA75pWolSQ3jas0cIcSfgtH0YAFlk+qpJ4Abf5tBC+N3dHKBVyYY4wIoSGVHGg2iV6GsLG/UrMzLmWVvfmKYANhpMFxCsz7gbTeuCzR1zftIOzA== X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3b2d9d4c-b562-4545-e46c-08df13df9969 X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Sep 2026 10:45:18.3671 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: l1Fl1rshUhTKy6dNuYmf1y9ulbiQc9abteeTKr2aEBJYQcP8pko1vJgxfbSTKIlFEn6Vqupnhe0I7GW6/8sgsMxX8WnCDR9rPAlnJmSzFtY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PHXPR02MB11343 X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE2MDE0MSBTYWx0ZWRfX4rcPc3GjM8D1 wa5uB0EY0Y9iyLgzrpamJfFXSefkD46zEZ3+tEYY8zdZ/NVaZMPjaDJdZzP2Nqlsi9ff7+IOTpi Nrs+jN3S39p6OhME0Zd1YLFAscx0Csg= X-Proofpoint-ORIG-GUID: Uh_gmNpcXbqHiEMQ9VPaUsqYzNb0UyrM X-Proofpoint-GUID: Uh_gmNpcXbqHiEMQ9VPaUsqYzNb0UyrM X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE2MDE0MSBTYWx0ZWRfX0RBcQQwhNTmY Lwea4NNuGtL8yO3UhLvXnw08n/iEaRlEVidtwX2j23xIRiNFapc0ZA34wPWSpugZ8zdixWAboRf VinHkIyr67fbsO1JMDcDMhb4uIqwNe0D6+/TmQEUJ2Nx+CxGZdBb/rQtRf4Ae5ycbE+c6EmTvZc adN7eVEyZIdjVVDy/qNWWFyXWJnmCpilP2yESbe/f20XWDZPn/+IIVhDAY3ME5tp7JIvbJqgwRd ylQtrIAONuSmYdnT7a7JtQREeaTuqjx5r8Zk7mXM0AanK/JhwidBau93o81DOAJ95sIt/rfvYUk oMUF7lItAgm4EBiFcD01m/TC4SbIOMZiBtunUiyVtCl3EiVHHwTmco3qhoh4ZSLAv75KfVIrzg9 TlhclNsRe+PT5jxQYwjMoGekMUw1LQg7ABCeeMuREX4gTDouf3RN81j0L7w+gXoOo1fGFQKcFic DzcQ5NyKa8DXKwDdWAA== X-Authority-Analysis: v=2.4 cv=QYvzLcbv c=1 sm=1 tr=0 ts=6aaa733f cx=c_pps a=fJIB0T+C2yAfE4P2TQxPqg==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=xqWC_Br6kY4A:10 a=VdqzKS8jKosA:10 a=0kUYKlekyDsA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VofLwUrZ8Iiv6rRUPXIb:22 a=0LlEyIVc8U2lsR7dKhuH:22 a=64Cc0HZtAAAA:8 a=7eIJgSlqxBVt2QvjjhkA:9 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-15_05,2026-09-15_02,2025-10-01_01 X-Proofpoint-Spam-Reason: safe X-purgate-ID: tlsNG-c1860d/1789555524-CD94A87B-C44751BD/0/0 X-purgate-type: clean X-purgate-size: 960 X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1789555564955158500 Content-Type: text/plain; charset="utf-8" Signed-off-by: Mark Cave-Ayland --- hw/intc/i8259.c | 17 +++++++---------- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/hw/intc/i8259.c b/hw/intc/i8259.c index f2d8cb1489..af33b71591 100644 --- a/hw/intc/i8259.c +++ b/hw/intc/i8259.c @@ -429,15 +429,12 @@ static void i8259_class_init(ObjectClass *klass, cons= t void *data) device_class_set_legacy_reset(dc, i8259_reset); } =20 -static const TypeInfo i8259_info =3D { - .name =3D TYPE_I8259, - .parent =3D TYPE_I8259_COMMON, - .class_init =3D i8259_class_init, +static const TypeInfo i8259_type_infos[] =3D { + { + .name =3D TYPE_I8259, + .parent =3D TYPE_I8259_COMMON, + .class_init =3D i8259_class_init, + }, }; =20 -static void i8259_register_types(void) -{ - type_register_static(&i8259_info); -} - -type_init(i8259_register_types) +DEFINE_TYPES(i8259_type_infos) --=20 2.43.0 From nobody Thu Sep 24 19:04:36 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1789555544; cv=pass; d=zohomail.com; s=zohoarc; b=FiQI/VjotxUJlgq/YvrTMGcwbMAB9EB2uMPt3ijEzc9CYN8Z2VyNBXJ+Tmw2cJdJnKxof0v2M2c9rBr+NNpz+u780dI4vo59cNHBH7tAlePuoee39tKR2ZGy4pxCm1AdWaPuzJFtOL3Og3MdenoIjIfnqIBSL0un0HnSWf/ZgFo= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1789555544; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=GeiLRjmqXC7pnl0xUqlMjcIIuJxuKXS5eOpzhsJsz4E=; b=RgPDsCueJPF9N0711P8eZbxB1s2cjm1lsYKPcfc+S89s4CQFo5IRSa1g6iCzXPpH/+42hAjeZ2ZDgP8pZ4sDIbsHzVNLvIA3Xz9ZesfJlDof0JH/LrTqgz5wxiQZiVgkLImOO8essIAw9wA4gInp/X8NBSnHI69oxm0aL3cD4sI= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1789555544497275.3985335787967; Wed, 16 Sep 2026 03:45:44 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1422604.1648019 (Exim 4.92) (envelope-from ) id 1x6n8s-0006GI-S9; Wed, 16 Sep 2026 10:45:30 +0000 Received: by outflank-mailman (output) from mailman id 1422604.1648019; Wed, 16 Sep 2026 10:45:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1x6n8s-0006FQ-Ms; Wed, 16 Sep 2026 10:45:30 +0000 Received: by outflank-mailman (input) for mailman id 1422604; Wed, 16 Sep 2026 10:45:29 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1x6n8r-00062u-2s for xen-devel@lists.xenproject.org; Wed, 16 Sep 2026 10:45:29 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1x6n8q-009uPu-Ep for xen-devel@lists.xenproject.org; Wed, 16 Sep 2026 12:45:28 +0200 Received: from [10.42.69.11] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6aaa7348-2eae-0a2a0a5409dd-0a2a450b84ac-0 for ; Wed, 16 Sep 2026 12:45:28 +0200 Received: from [148.163.151.68] (helo=mx0a-002c1b01.pphosted.com) by tlsNG-42698a.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6aaa7346-b7e8-0a2a450b0019-94a39744e836-3 for ; Wed, 16 Sep 2026 12:45:27 +0200 Received: from pps.filterd (m0127840.ppops.net [127.0.0.1]) by mx0a-002c1b01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68G83uAY353108; Wed, 16 Sep 2026 03:45:22 -0700 Received: from ph0pr06cu001.outbound.protection.outlook.com (mail-westus3azon11021074.outbound.protection.outlook.com [40.107.208.74]) by mx0a-002c1b01.pphosted.com (PPS) with ESMTPS id 4gq9drte6d-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 16 Sep 2026 03:45:22 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by PHXPR02MB11343.namprd02.prod.outlook.com (2603:10b6:510:3cc::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.428.9; Wed, 16 Sep 2026 10:45:21 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::8e97:bc32:822c:b250]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::8e97:bc32:822c:b250%3]) with mapi id 15.21.0406.007; Wed, 16 Sep 2026 10:45:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=proofpoint20171006 header.d=nutanix.com header.i="@nutanix.com" header.h="Content-Transfer-Encoding:Content-Type:Date:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To"; dkim=pass header.s=selector1 header.d=nutanix.com header.i="@nutanix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=GeiLRjmqXC7pnl0xUqlMjcIIuJxuKXS5eOpzhsJsz 4E=; b=dtgz3oDYS/p6TQ9xHyEtPGQ7SOdVB44WwYKYxMFMHqI5CnEaRb7LcV3Ng pjUSvPkwaLbp6YMBdHBd9f9IDGzZRI840vXK9gFG8BJMh54MZgmErumWVM8cJ234 /kq49kS/W3nb838f5STVHIPhoGPDb6zGOFGbLghvfqQRA32dQOEnCYJOYthMwi9q v95HmtEmXgBk0JneIkDzgHtRpdv0/f9SlsK2Poc2BYMx/d8Wn5R4odxNhRfbqkga ALbmo0+ZexS1CeXiyGlVPUBuHd+NnbLU5iCnQnU/rvPq/wqOc99QdmN/Ew/Ap28q xzB8B115tSRBEIUNZq/lCn988ilqg== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=qlf4q3wuc4mtJNyQDaGQAFvVDA3352BNuMmFZKh6P/A8DNfDdOxKx8k5b7yVFMie+6oyHeRz09vP214q0kGiB7WQ1ijhA4jMBTXSCfN8kSpDGVKersTv7ATeHGV1GkOUz1+tidOKPvQUFb9DMKdjj3IkqOdn4aATb8kTbkPRG8VCJJvY5odQlZiFlR8/5j2oDZ6MV54MLqFDmpeLoRqqpZSul8n9/Y4uxZCKcVkXL4q/xY9FRbCFA8vLCNuz3jUcz/lqG078y5CgSCzolAUEnFW/X7nxe+b/tjk/WvwPWz2JNzZcoHnt2U55JsrbwdqGg4lxMYyqDEhmwj8RiSnRWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GeiLRjmqXC7pnl0xUqlMjcIIuJxuKXS5eOpzhsJsz4E=; b=c6X3GcL9bsfYwe+QO7kCB/jqGDIQDiIaa6fXMW3tJiHBb2rr1NqyqZ4+au3l5VUlEeUSVvK4qxa9BGsWYIh5yle1TaMihQNB4e1x417gCHnkldhLRTuEt0TcD9LAnRDi/wqLlkCTMMPZPoTOBaoUOC/k0wJRmAfixUuTqgB4fvUkHdSCKOUBsv4Vmw/x49SNFyd0mik2p6EB6l0XIXzWSrnZrEQZIX03CPSP5l9qa7acdquTWYLlA5aqW6kIILpVkCop67WfnLu3UgSNwPho2OifbyHI/uCuOlP7KQ3Jr9MkxIsHUo/5C+V2VpJYZJB9ObmAPHJ3aFYasQosnG0kHw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GeiLRjmqXC7pnl0xUqlMjcIIuJxuKXS5eOpzhsJsz4E=; b=dJJ6Ik/oPfwZCcvmmPqW/m5TsQGLzUGlcEtccVgZwMHqWZxswRNcp3t6ZEeJCGyffmCKUIijo++2U6Vr+R0oKseR9dvYumcpmTwXcBAn8nRspBfvXKVH2hVCt+Rs2LbCzK4Joc4OJ2L90XSdzItdLXKl8hht6pFCKTiIhYMxmVDVFGrwAX4LVehl69PN+JqBX3D7HHynfEbhMxPI40fClDY+bhUpi9PhEYxln3/3Hz+WqgpNfsR9rEAPAO9F+56JK2tf8GWiT98C0lrGHPiU4lXXjcK51T/2xYseMEBPpH8yXFirufU7G18XJILXSB1dD265QYM3+p0jlbNsdnHcOg== From: Mark Cave-Ayland To: pbonzini@redhat.com, richard.henderson@linaro.org, mst@redhat.com, sstabellini@kernel.org, anthony@xenproject.org, edgar.iglesias@gmail.com, qemu-devel@nongnu.org, xen-devel@lists.xenproject.org Subject: [PATCH 12/22] kvm/i8259.c: convert to use DEFINE_TYPES() macro Date: Wed, 16 Sep 2026 11:43:40 +0100 Message-ID: <20260916104435.600211-13-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260916104435.600211-1-mark.caveayland@nutanix.com> References: <20260916104435.600211-1-mark.caveayland@nutanix.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SJ2PR07CA0004.namprd07.prod.outlook.com (2603:10b6:a03:505::10) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|PHXPR02MB11343:EE_ X-MS-Office365-Filtering-Correlation-Id: 47c17469-b1c6-4396-bd73-08df13df9b5d x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|1800799024|23010399003|18002099003|10067099003|56012099006|22082099003; X-Microsoft-Antispam-Message-Info: SZgu+T00QUcGv3RCctNJLGqm3X+vaLNyJxcGm3gR8HFF03HWJewtNf0M2DGY1hC0TRq3L4MH1UCKrZnEkzODmRofoABu6KBZ6LfCi0Tvnm146Kz/ULsYMX+nTRPWdPG/OxW3RsDJYZYBjhFM8q2eSTPSZ04b4IStKN7sjCiM8wcA3sh78Z1qMkkpM0ciL8dFCDIN2wHrlwTdsMeyZPRa+bocAKFMR55iFrDlShPALhyDfaAnCcIekO/7NWY+7kmg+UmebIa+inaHtjKyHXO7fv7YSQbvfNl/V4DRH+qsQ6i9d6Oyg5eVLGB8WCE38KMLPB9GAoiXXX8CsU+rfuci+TfEcZRyLzH2lc68V1CiA9OZoD0UqCVbVmZN/hBIYjK5RwvzgAgof0KkWfXVJ1dP9ZUNdMkpB8RjC37pTbld9Un9buESEy13turlW5vP29emgkgOTIq7Zie+M4nKb990xY8Hf5z1BlGXKVr7qZt2fP0M+t00o5fMg8IlPudZ/XlwZ0oYMHMgVHbbnfgwvIK18zmFhXTQvjqPET7kgBhqLV4wJkY4Esbu4NceDEc6M6BufkpG3a8inb1LwJYAIuz4Ljq6k2X88LhwrHLckkkZ7UW/GcJu4qFSjxt9YcGvMQzokG4Yk36q1bFeLE5Rg+vfY3d7GxyK6f5wVE5jv26BcaM= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR02MB7159.namprd02.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(1800799024)(23010399003)(18002099003)(10067099003)(56012099006)(22082099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ojhDwRMRuP0ldhUeCzvfgkMqGEpUlRcGnZzp6ilSV+SrM2lNvjhCriE4aJIN?= =?us-ascii?Q?g/cYh3dIL/JWynrihGV4Jv/WEvsF4EsOx534KHTG0IIwTRVRQ8CpHKBCxuAo?= =?us-ascii?Q?0zaTantCaRraRJUF3eNDnZpq5jKctxqpPiDs8z14c2690LWuC7NXGmKpuVID?= =?us-ascii?Q?/K18mh6GapVw6/53Trj7O7K800WRWWHx2kFMa4aYdIdbWk9JeeUN6Ea2h8fl?= =?us-ascii?Q?uwXuLW2FaIt+RjCYzaek+1zUlp94NKho26XcWjzntQ7gj+X1WeZxQ7NUwd5R?= =?us-ascii?Q?g6MzxF3jTVyuM3R6Nrqqp0Sp6JtHEmPsZpmIz7GUEldx5KTJGnQzKCuFBFgZ?= =?us-ascii?Q?vUKayhH4FKNJ1+AWJ5OGp14LOxk/pjEMVMyBAGIDYWuIUVZUNJyHaPmGYVHB?= =?us-ascii?Q?r1WiO/46SgDd+AfcnUe46JPpEiw4Wmtq6WZGnb4+ctOuISqtKRvpRFhxnRtw?= =?us-ascii?Q?5Y87/9ahZncP+U5JpEEmHIvc16tJYa71y4EawRVN8Vdxlo+itDrda0nfEvmm?= =?us-ascii?Q?7SCxzS/di72+uJ9r38aUPrk3qWY3nNgWP44nXAGmEwVteiu20LxE/anyfDFj?= =?us-ascii?Q?o4w/Wc0QJDsCrSg1TDVSGrdPjbRoPEZ0PEN0eOS8z23Z2ciowhSWbzDBphhb?= =?us-ascii?Q?Ay52kWj24evlqaodxI923knEGcnXdwf0c8zNqVGhJj7QHG82WW+gzt5kk4ig?= =?us-ascii?Q?JA4C5u0VMB8EBYjm/ZW5CKD4f0covco0+kciIT/iJv5y5T0/TFLw/sRD4har?= =?us-ascii?Q?HIPCoo6QDAE6IJbWjeEqPdGtmBC3EyT4BMnnbSx2AB+SYOfqCt4hzEv44fnZ?= =?us-ascii?Q?YZx5K5NoVa8xk1NHDTNpmzRSmbvIFuJsW6kuS1ACPID2WKZFexTZ5rILruCv?= =?us-ascii?Q?WkF8sYYKTU4ITWfyPjCU9qeqITgyl/ipG16zuLFJobwVtymLjY6aS3L+lkXF?= =?us-ascii?Q?rxgfUWQ5YWelDdyN8eyzzX85lbfb4kYJVeQMMao3OqMq8cnafvyQvwS3CDi5?= =?us-ascii?Q?4ZvKRtX4wf23jZzgAL9XnO8uRfB7nFadJgKi8xYIFUJuK9q4EySqqDzlhITo?= =?us-ascii?Q?uXmkGhDjsde2ybOgB0pXswIeAu0BQkCZIMUeib1xt6H1HaW9X8PqC0nb6hF+?= =?us-ascii?Q?0vV8iakuTLXXCU8bBW2sKVEGD6XHrcAiyYu4ZSawSLQD/Mx5UiHQ1Mt7VMG2?= =?us-ascii?Q?pD6WYpdLHuTh1Cn5QEHP32pbTbwNNLopbMeacTpesZemPFqP0rzBoBGZeGug?= =?us-ascii?Q?AT1HeJqjgrfaM5DY18CRsoZf/Y1BJOa00e/g5IEJDjCx5KvDSR0n3jQUm57Y?= =?us-ascii?Q?VS2Jkk5eMRi01/kBD8hteoL9oJhlO7mbx1YNEHlaIwgMycPAsRv4vZuY9iqF?= =?us-ascii?Q?0k8rO0T7Ps4U27RWRC4mPTXB395iZCa/ecJjoQZ8u7STtO9SvidTM6UbEXyI?= =?us-ascii?Q?SyAHNam9mFVh3UDqfi552Dh4qm+Hq9c3lG4ZXTkpZDbvVdXYWRfqahZd/5sP?= =?us-ascii?Q?4+J1uaFhFnjknwqnKm9FlV3qbbXYSky2zuLGpwKIDD8NaqhmwmTK4qNCz0qz?= =?us-ascii?Q?dYihB4DBqSbOU+G+mZaaxiBxNhCHd9XP9itoSqTz6a6QnSdk6Msbq9taXefY?= =?us-ascii?Q?s70KlC66U+oUVvrX+WpW48YIN1zo/Pe1g6ijeGKOP0kqm1Yov5+nay1SLsfk?= =?us-ascii?Q?AMoP3h236wqSh01VSKQoJDNFbBYGbe7GFLfNwf2+4VMGHkLTjh28SaALvsLI?= =?us-ascii?Q?6dSU3XxWYcTHuC9dETomiGOg21Kd+VQ=3D?= X-Exchange-RoutingPolicyChecked: JL22umKvd0v3nk8hOR1fY25JA0L4r0LIwgis+yvClCkhRbUMPXKicsjQgATepJoPX1Nf/9UH9LmZcMsaT1dUNJrolhSgzhKoOO6v8MEetRjvGgwNdWqe63Jntnh163joCwk2fQ0hlwXR35nXzBqrakc5VwaLtjw2v3uBO+jNSj6yrMjAoYkAdvlxnV4OjJ4zAkwzWWfTs6c9QDOHX+N7GCfW5T5Y0daskPKd/tv+fK1KxrY1MdodW9Geojjk2eLY2pfjCsU5XBNFtRAztoghqplfr4HC31dFg/2kqqR8En57xcTgjJDQ7TbKMtM9KsbhyouZ3weKxYARl+/+ZWgSHA== X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 47c17469-b1c6-4396-bd73-08df13df9b5d X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Sep 2026 10:45:21.6800 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ABjGaAYpoy2dJKk5f2EzK6bFcjqC9QYlZgRU2XOTVO38UvWBcS3Eggzj119tjlZUr2Hut0P4YsNsFKD9tBL/5Z3TAPpWel0xl3xmaNold30= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PHXPR02MB11343 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE2MDE0MSBTYWx0ZWRfXxTDLGFL8AyqA PJPgH8XpyN3vlQxtndYYE9wTnobK3lkTudDgQH4dVzOT+AKwSLsl8bCX1JNGwDz5b4zHZ0JPqh1 0yFYgvO91MWYYw0+IvGHgQwL/FiaJ/QHFN55vGokY8rEX1R8SQvyub4oXg7/UinVkUQGHVc5Z4d wo8lf7HuvFkg6yAAKmBoMRbODUolvjfu5agxHqZy2NBNYxTeyYVjtritIlrf8WK+S0ghEkoUqQ0 /pPt01oA4UrGi9RbFCpuLBiBr3W2wgvWB8+sYzAB1DMymedfb/skQxh9zKm3torDwenA8KwXl95 Tdg61Mf2JK3dGIcLoCGu48Na38o0YXNr1ycg/Bo9TgsG5hmixDkSs7Uyyu5/jnE4gS9KkIwueC6 eAWNmCsi/q3cmBdE1AIy5ht7qmTKse63cO5uqOiZtvSUl1/kbCzStIk+lOMmAaKIPIrD0MIdaE5 laymsUU9yzDnDq5fqFQ== X-Authority-Analysis: v=2.4 cv=XO2l2ghE c=1 sm=1 tr=0 ts=6aaa7342 cx=c_pps a=QrNjdqYeTG6M0XQO4N/sOg==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=xqWC_Br6kY4A:10 a=VdqzKS8jKosA:10 a=0kUYKlekyDsA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VofLwUrZ8Iiv6rRUPXIb:22 a=_-M8LpHI31CeLmyZm6wg:22 a=64Cc0HZtAAAA:8 a=AnAY-G272_MYj7koicQA:9 X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE2MDE0MSBTYWx0ZWRfXy3hCaGO24Dnv Tf5DCCUWRRyNelbW0P5uC/AZMJv1gPs6rTSMHuRWMBZoRGX3jH/TGZIZr6sallFuLLPN9JSb3ch k/wEtuWTFpKZQg8EMHvCS8KsgTNob80= X-Proofpoint-ORIG-GUID: Ye0svMxooe8ZJkyyGMnl99pJQBNl6-pF X-Proofpoint-GUID: Ye0svMxooe8ZJkyyGMnl99pJQBNl6-pF X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-15_05,2026-09-15_02,2025-10-01_01 X-Proofpoint-Spam-Reason: safe X-purgate-ID: tlsNG-42698a/1789555527-1AAD89EA-519350BF/0/0 X-purgate-type: clean X-purgate-size: 987 X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1789555544876158500 Content-Type: text/plain; charset="utf-8" Signed-off-by: Mark Cave-Ayland --- hw/i386/kvm/i8259.c | 17 +++++++---------- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/hw/i386/kvm/i8259.c b/hw/i386/kvm/i8259.c index 28e6e40bd2..9793473163 100644 --- a/hw/i386/kvm/i8259.c +++ b/hw/i386/kvm/i8259.c @@ -137,15 +137,12 @@ static void kvm_i8259_class_init(ObjectClass *klass, = const void *data) k->post_load =3D kvm_i8259_put; } =20 -static const TypeInfo kvm_i8259_info =3D { - .name =3D TYPE_KVM_I8259, - .parent =3D TYPE_I8259_COMMON, - .class_init =3D kvm_i8259_class_init, +static const TypeInfo kvm_i8259_type_infos[] =3D { + { + .name =3D TYPE_KVM_I8259, + .parent =3D TYPE_I8259_COMMON, + .class_init =3D kvm_i8259_class_init, + }, }; =20 -static void kvm_i8259_register_types(void) -{ - type_register_static(&kvm_i8259_info); -} - -type_init(kvm_i8259_register_types) +DEFINE_TYPES(kvm_i8259_type_infos) --=20 2.43.0 From nobody Thu Sep 24 19:04:36 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1789555573; cv=pass; d=zohomail.com; s=zohoarc; b=J9aCVNqTmj8wkqNeR6byDgBbISfhROz8k2i6yXvyGM0RT6hgZf0moDRUTPbv3Aa9WxQ8ucbL71jQojhqI0fKyAbjNWuarpQJPNTlCeKr8gZj5UVOjo7TPWWIgKLWIMyLzz0IliLQm85wo7NzmDl2cIVzjZ9YnoVwECsAU2lBTjE= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1789555573; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=Jy1v04X56TCY5cimNIdgAFOsHOMy8I9bpWBMtANdRtA=; b=AOFSTtfCccZhHfcZnufjFvXB8w87yTIJiveCqLekjeOlwFgyMH29qdMM6k3pjGvcWRMb0uArC/5Ep5S2llnc0wWTvdf1RWZ9aehClfJM6hWPo3wKNcynhPjRCpDfuLedNWKKiYOj2UPwWjTA6ItK+0L8SXylV5f8I6idEBiBFfk= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1789555573412538.4485202792827; Wed, 16 Sep 2026 03:46:13 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1422613.1648028 (Exim 4.92) (envelope-from ) id 1x6n8w-0006nb-6F; Wed, 16 Sep 2026 10:45:34 +0000 Received: by outflank-mailman (output) from mailman id 1422613.1648028; Wed, 16 Sep 2026 10:45:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1x6n8w-0006nQ-0Y; Wed, 16 Sep 2026 10:45:34 +0000 Received: by outflank-mailman (input) for mailman id 1422613; Wed, 16 Sep 2026 10:45:32 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1x6n8t-0006V9-W5 for xen-devel@lists.xenproject.org; Wed, 16 Sep 2026 10:45:32 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1x6n8t-007b2k-CC for xen-devel@lists.xenproject.org; Wed, 16 Sep 2026 12:45:31 +0200 Received: from [10.42.69.4] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6aaa733b-bab6-0a2a0a5309dd-0a2a4504b194-32 for ; Wed, 16 Sep 2026 12:45:31 +0200 Received: from [148.163.155.12] (helo=mx0b-002c1b01.pphosted.com) by tlsNG-ebf023.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6aaa734a-b57f-0a2a45040019-94a39b0cddb6-3 for ; Wed, 16 Sep 2026 12:45:31 +0200 Received: from pps.filterd (m0127843.ppops.net [127.0.0.1]) by mx0b-002c1b01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68G8Ooof768822; Wed, 16 Sep 2026 03:45:26 -0700 Received: from ch5pr02cu005.outbound.protection.outlook.com (mail-northcentralusazon11022120.outbound.protection.outlook.com [40.107.200.120]) by mx0b-002c1b01.pphosted.com (PPS) with ESMTPS id 4gqdhm9r6q-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 16 Sep 2026 03:45:26 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by PHXPR02MB11343.namprd02.prod.outlook.com (2603:10b6:510:3cc::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.428.9; Wed, 16 Sep 2026 10:45:24 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::8e97:bc32:822c:b250]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::8e97:bc32:822c:b250%3]) with mapi id 15.21.0406.007; Wed, 16 Sep 2026 10:45:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=proofpoint20171006 header.d=nutanix.com header.i="@nutanix.com" header.h="Content-Transfer-Encoding:Content-Type:Date:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To"; dkim=pass header.s=selector1 header.d=nutanix.com header.i="@nutanix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=Jy1v04X56TCY5cimNIdgAFOsHOMy8I9bpWBMtANdR tA=; b=pWRxEbwvqnF6Z+gbQw0tVVDRTnVrL31Chv3FbbP3hLyOgmmDw9qbA9vv8 Dzbz+GzmtCPNFFqfqgoAyTMgzBrajbE0YQDlY414Yk9riRm4rRi0iUln338G/+hp d9LXGKLL8GENEkHrPgoV2fQ3gsaovUDYztis4UU6O31MuG4yee0ozyA53fEe9Hfb lYguyINjbqFnuxbkS2M9WdqTDH3jYm7U106DXhaR3g4wI2Idj6A9SsgaqeYiffgw KXU/FL1YUeeFZQIhcoLjkMBboFC7BUY5Pt5HWTDypkmz+4mG01OJbtCPZeI+FtAJ 7BbMT52G4UbFANV0XRxPUI1e+0Bwg== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=fXxEsjAaWUWgSimyTrdo5AaAZrIjYQEBapDnOJSQ6YGN+A4jPzqfP8SUi4DYq/ENuhn9tmQv4CuPedOR8Vng6/nXvNTrWyVtvFiqiH9MADhCb88QlBA1m8ynac4kGWJRHELpaoq3hAO8LvqJqlqQ7PC9qZfuzEdhMiAP7S40nP5BfXMDY8zd8GgtGI7s/BAmIWtocO5MCIjJjZxB1sftfX8zu3Jhl79HrsAns+f9x4m8Ho62BjgGQQwpFR5aAf3pzL8jLIc1zyq9Lq6UF1r6LKYRI9T0x4SjgrjgLT43ihl3eUmdpJJhv6x8rO2LI26XBOg2Mez0cGydxYIY6UstwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Jy1v04X56TCY5cimNIdgAFOsHOMy8I9bpWBMtANdRtA=; b=hxYF6acavvPm2wxGhYlHUsx8qIoHdxR2dKmK5bqyqMOqIw1E2J+PDwG3Rp929Sq3r32PflAWVHfVuMPkYO+Owha50RRkMK2m0KlaVsg8Daqixf/FAXO9nRbcEG6+NPPLGdL6W/3stbcKo4NqlWEXktRqH+Z/s11l8eHmyreXwN7/Gd3kauYF2nSkjk+gw9nyouZEKWZxtKZeSxR4MW90e5JPuLohd4nIhVlTag7IKz5jFHwdPcrdhbmEW0wYybft46KBRbWIRC/USYt634PFl/9DfE6/9wCdTAHgUNWBz3AsEr8KmG1wkJlnfikm9SFzWIvEhNttZA71K/JefhxFlg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Jy1v04X56TCY5cimNIdgAFOsHOMy8I9bpWBMtANdRtA=; b=mdAx/NZDFw8qqaZSFH2r1j6P4nk+ywr0Z/uv6RfnjENqrCcXxCbzF2e4AnqF4pTwWRbNtvXjhzx/sXHMbY7QG/dYSEXUw2S4ygnYxWP03ZiLZHvVTdKVcnHl94gILkO6mTf1bB7YB/h4UxMgwftXR5ZnYAxa4eB4NLuhfByp3/Pbit+qgQN1IFBEFj238euDu0ciYIUO4XUWdAxgXm6IT2jrIdoaS42X5dQIff7jT42qeMC4nDJ8SrAifixV5bwGWwaePxOTIqHCob5gd5WulZMvLsYX31s5/PZjgksz4wxB53pAz//uWiI1qqLRegcTv0xyIENcbSvS6dXUVHBAeQ== From: Mark Cave-Ayland To: pbonzini@redhat.com, richard.henderson@linaro.org, mst@redhat.com, sstabellini@kernel.org, anthony@xenproject.org, edgar.iglesias@gmail.com, qemu-devel@nongnu.org, xen-devel@lists.xenproject.org Subject: [PATCH 13/22] i8259.c: introduce TYPE_I8259_PIC device Date: Wed, 16 Sep 2026 11:43:41 +0100 Message-ID: <20260916104435.600211-14-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260916104435.600211-1-mark.caveayland@nutanix.com> References: <20260916104435.600211-1-mark.caveayland@nutanix.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SJ0PR03CA0182.namprd03.prod.outlook.com (2603:10b6:a03:2ef::7) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|PHXPR02MB11343:EE_ X-MS-Office365-Filtering-Correlation-Id: 4f8559f2-1bf2-4f92-104d-08df13df9d2c x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|1800799024|23010399003|18002099003|10067099003|56012099006|22082099003; X-Microsoft-Antispam-Message-Info: kqkNYyfUzXHn99juzjFDmXWP6HZyCnqZbbEYlhCHfbtXG9DGLKV29MNB8uZFblsY9dgT7SdlXatzi3/zijRH3l6/Oj7PQM81iF3Dvq6umQfiO6CO6DKp7znX+Vde2NLvx44h7M5mluKqgbswWgrfThJ8m5TLn0LT/NYt/zm6ElIdShk2aJtzJ0oVM/tnw7AMVN4BhVL2ADH/79x17CS6WQfOALpNdVeS/ssZvWEwyH7ASm+IYly3mFXDuK4hnuL0I655DDcE/ZlCMqeuC9UNQ6otgZNn0QBF0kym1rR2KOMySSR1DZ8MVYs44ciuzj5kMdsaqrsKta9Armb88gkqVbnlNMu7yLNPvX12dZ2oecVhFg3AhaJh0gufuIK/5im9d4dxPGACp02jJo7pzYGegrQ5Ez3M6vXENmHEH5JyrFNRuKvFZwM9ZLl6kAG4498PmGzpizymrie6BPZbdoo6W7nSZybe6ZEL4IIOH9qIy22uHpE2OkpQZXsoce246yvPoCQUZWWL83NgxjoHFcwB4H37P0G5PZCQCmnWFvVLeX1mn6Rgk+6vUYavoa/oKktq1ADnnGCTnSPmmC/gNKRl0rysVTPwlatzsAIX1ykaZ0WEkNmeCT0UfE9AQOwMuO6JRbxoqlG+7pcXHpogUNteeWyJb4ZRLnikg/JM0rCFg+8= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR02MB7159.namprd02.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(1800799024)(23010399003)(18002099003)(10067099003)(56012099006)(22082099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?fO/qg/o4mWVX6Xp9u2DdQgDWXFk8ZlXRJ/IblQrGlOq068PncphbdmG6HSSg?= =?us-ascii?Q?VD1ILevdii4eiKxSIJ5OmGJZOo/pCigqZKYUtp9ijftwBoIudt4OXKYGPMyi?= =?us-ascii?Q?tvl+gWc/g/qPdVDfeR4EFmk6WztfoUDLIIiTosEi9Xs0MBS9ZZXkifAjM/bM?= =?us-ascii?Q?ZvkYvP9fNjtBOFMwBV5fzmaIjaQVu8jMJAUtf0s+q33EPqVhOwj4mB2lWTlG?= =?us-ascii?Q?eDhJiD/WnKQWmh47O5EcBl6/Tc7w7gwrx1D4ze0qWvjMpm09J3vr6SrvqnOr?= =?us-ascii?Q?LplR8pJ32IjX7kXf8bezryJbLU2oEph/TWTU8mBCw/FJ/QY4rYK5Ea2ZRC80?= =?us-ascii?Q?iB+DyxgsD0RKMj9UP8tJ5RO0bLm2kWJs0lXBVQh3m1MZ8qWgAUJK3+1n/DnG?= =?us-ascii?Q?I++wtvRcdP2mKDS5limDMBpNwSqV34kjm9wOm/VyBBN5FyQJXE4cTCYyw3+r?= =?us-ascii?Q?dxVyKOGlR9m15jO19BNBXrhGvD+8PDgEV9gsxsDt0zLH1W79n07vzw0RUkgf?= =?us-ascii?Q?dv464GpEyZR8d0D9PDbrGt1XXFZx4h33jFPbYYrNvNZAcoU/wxU1jGlba6iT?= =?us-ascii?Q?ORQdHXul2cmLA8z2+XmBpq1Trd+fVUCsXu5iRbRUGFlCbAhr0njhJrB+eOfD?= =?us-ascii?Q?HzsauaSRJjn4t0YVxDltqGd0b1DvjBBmCjOEiUUDtmdLI0qTbhrB19xVxlib?= =?us-ascii?Q?Cmq/1ncf96+w1Dsuvn0zW/AwdFwZ97VLe5pN4gVukPO/rnn3u/6pzzrUAKHa?= =?us-ascii?Q?rhE4qHxWi/PIwiwH2B7YJaqVS6GhtFUZi+GXJWuKHRZMz6fh/s6Ca2V8InnQ?= =?us-ascii?Q?ZxqnnSpzKL9bREGPdpyoZJsYyWvXIBYJJMnxmj9xuFzzpdN5yAJC5YOp26nJ?= =?us-ascii?Q?gvFk3GTiFLHgfIffu5SltIZRg1VXnzRvne8Ww4QT9N/M0KKiZQsjWdqWagOE?= =?us-ascii?Q?IvILDkBCNQg5q9Lh4a3KzrnZPssXyYZGRibMOs12aG5d/N9RzPcjnewd9Sf2?= =?us-ascii?Q?5QzkZOmWRqHoSN6gXe/FBe6UGtVbEXnojyAIfyosw4mqI94dgiBtogDQn7fb?= =?us-ascii?Q?z9nvVJ61MjZMT+eksMpwqaUgihJOV2fYilmDcxn3rF6W842dlik89uR5P0ad?= =?us-ascii?Q?meI9TrTdgS8SooFZwXiQvn5A8tQh2NIhz7hBgSgkedeMlojFOgonjP2H/xm1?= =?us-ascii?Q?xiPHH20a0TLwMmBbtwzRuj+QU390mU2AjXTWyRDAw491HgoXaRhGag7v0vXz?= =?us-ascii?Q?wW3PZGNapAdjP+FxUGZ+ouMAzZYbVB64wnFyWiSGESs60B+2bNsL2JC+MyYw?= =?us-ascii?Q?SKxGAXuUUPDHWWbR66+RAA3eUyQjXNQHu1BXGW7OSFi5szvi6qMeOy5JoQlY?= =?us-ascii?Q?df9SiBCfGfPNCfFPhdAy3u2OvwGJNwgDFtspviH5cef4r3e32EXTo/0jEre6?= =?us-ascii?Q?Vy3mWp/7+4zS2NM3VH8GqCmJbnN0RAVB+1LbwYskbhD9L8jWqa4EXC/k/MQO?= =?us-ascii?Q?XJOa7ID98t+qbEke326LhRyeDHn7xGPRoOyJHJWV95aGa0DidQr+V3QGLKH1?= =?us-ascii?Q?h4HJoTMMYBNem2YohLLofe9rGHkNL8Vgpyh6tmbEr5J9u/aGSwzo/L53d6Fe?= =?us-ascii?Q?eNxOYxSC8UMr/3WCVGkaFUuazDFTpnq1NX0DjAnNgvtU6z80/bDwvLE8Hoqv?= =?us-ascii?Q?4mz862JUrfGwSGAkBiZPmzC2Ga1seFE3ojg4YqJDYH6aLr+xZArV9raFohbi?= =?us-ascii?Q?CjonJENfGKfVgLbR8xzb0DC+T6Ge+/I=3D?= X-Exchange-RoutingPolicyChecked: Zh+aTXM23hqHIdvBbI+8g2nITmaZWJAbOwtrRA9q0uYroeNsjrg0nccH82mgA6dgQOTfemyx5wi8vPGSg8d9MwwYkPrRQgFm1OmHhB4pis81HManflorzUJL3k6nMkGpirSNk3VkgJytQ+OB9o92dbst23eBiEk1Uh/74SQTrCgG2GXza51zQYbwCYcJA98OW+dGPRhS2Qzgxko6fVuEyWuRsIotH7hUsWM21bpoLyHsRHmJCnmr+tDKCOZgySPgo6UzPClX0yBIa91eGYU/EOQLSqmcWT1BiHnq2XXcdkYq1fWdhG3/SBowgWRy+pXcqXsDLMb9dc060GB2hWbzIQ== X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4f8559f2-1bf2-4f92-104d-08df13df9d2c X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Sep 2026 10:45:24.7474 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: QW+3vlhqxQ6aYe24vIgD/RNLUekWgayHi42HnVr+xdp0BLjY+FknQC6OlBhj7T5DYB9KKygxOJRJsnyayRPuNJDulXyl38Gn5ksqe5iktzc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PHXPR02MB11343 X-Proofpoint-GUID: etXJZf7p4Z2i7zg11tkyG5VuRnhs_8Li X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE2MDE0MSBTYWx0ZWRfX/EIlMI7ap35K vn2Eo4a8QuJsBEJZp3EyzlZYe5VFyyybBukoyDr7n8lAcWVhrlIeGcTYgLfv/guk5IExNz73vGv RqufHpVQ3i5+oojwtWt26ALpxoSKwHs= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE2MDE0MSBTYWx0ZWRfXxeoiuqGmZ0sb vAqxMlEq8JNEdXAV70Yuu14GI7/trknOSpWcLOSe3BJiJW9Oq/JnbZc7UteOdKYIKsDVhD9b9+T fVQioZxRGOC6MSmcPS7A6bYFZI5tmvCBNbyXsegsOhuBCk6XpTCkmImeFuFjrQQwlBSfZ8Zj9R2 cFVocbL2G7UgXTu+pFh0jD5ey/cyp6aopfxYGujRd6hyRG5p18SRUUK6OG4dNYzLus9Oy3Qv1tO enjjprwd3PK93cqGSi8DzLtn5/OCHKIDQKIJPgLjCCllkjj58tGeWeAxEF9bPP51V9RimVLnoEu 6sAwx1mRWBILO8lOfmvzssVuqN+h+N+U0qcEIC0kz1Uh5bMcuwN9x8cb5lfNeVUIK9bhUCPQT/C IwIUp0CvLkMIzJfDFyOLId6v4aw7ZbTH3tRjXf7UfdToVZh7BIoN31Fjh/NC986mVzI0lp+iJgk 3PI5mhLusQ2K7RylPtA== X-Authority-Analysis: v=2.4 cv=IfkSymqa c=1 sm=1 tr=0 ts=6aaa7346 cx=c_pps a=3SCk7X9PwWHtu4c5+rqWlQ==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=xqWC_Br6kY4A:10 a=VdqzKS8jKosA:10 a=0kUYKlekyDsA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VofLwUrZ8Iiv6rRUPXIb:22 a=dEe9Ve2bX-KnNSUMM2s9:22 a=64Cc0HZtAAAA:8 a=wVjqpWDhUWNmLA9U0x4A:9 X-Proofpoint-ORIG-GUID: etXJZf7p4Z2i7zg11tkyG5VuRnhs_8Li X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-15_05,2026-09-15_02,2025-10-01_01 X-Proofpoint-Spam-Reason: safe X-purgate-ID: tlsNG-ebf023/1789555531-C24CBB50-30C0EA97/0/0 X-purgate-type: clean X-purgate-size: 5607 X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1789555575015158500 Content-Type: text/plain; charset="utf-8" This device represents a PIC for an x86 machine consisting of 2 cascaded i8= 259 devices wired accordingly. Signed-off-by: Mark Cave-Ayland --- hw/intc/i8259.c | 133 ++++++++++++++++++++++++++++++++++++++++++------ 1 file changed, 118 insertions(+), 15 deletions(-) diff --git a/hw/intc/i8259.c b/hw/intc/i8259.c index af33b71591..fcc94e12f8 100644 --- a/hw/intc/i8259.c +++ b/hw/intc/i8259.c @@ -25,7 +25,9 @@ #include "qemu/osdep.h" #include "hw/intc/i8259.h" #include "hw/core/irq.h" +#include "hw/core/qdev-properties.h" #include "hw/isa/isa.h" +#include "qapi/error.h" #include "qemu/timer.h" #include "qemu/log.h" #include "hw/isa/i8259_internal.h" @@ -36,6 +38,22 @@ =20 #define TYPE_I8259 "isa-i8259" =20 +#define TYPE_I8259_PIC "isa-i8259-pic" + +struct I8259PICState { + DeviceState parent_obj; + + qemu_irq pic_out_irq; + qemu_irq pass_irqs[ISA_NUM_IRQS]; + + ISABus *isabus; + IRQState i8259_primary_out_irq; + I8259CommonState i8259[2]; +}; + +OBJECT_DECLARE_SIMPLE_TYPE(I8259PICState, I8259_PIC) + + #ifdef DEBUG_IRQ_LATENCY static int64_t irq_time[16]; #endif @@ -392,30 +410,24 @@ qemu_irq *i8259_init(ISABus *bus, qemu_irq parent_irq= _in) { qemu_irq *irq_set; DeviceState *dev; - ISADevice *isadev; + Object *pic_obj; int i; =20 irq_set =3D g_new0(qemu_irq, ISA_NUM_IRQS); =20 - isadev =3D i8259_init_chip(TYPE_I8259, bus, true); - dev =3D DEVICE(isadev); + dev =3D qdev_new(TYPE_I8259_PIC); + object_property_set_link(OBJECT(dev), "bus", OBJECT(bus), &error_fatal= ); + qdev_realize_and_unref(dev, NULL, &error_fatal); =20 qdev_connect_gpio_out(dev, 0, parent_irq_in); - for (i =3D 0 ; i < 8; i++) { + for (i =3D 0 ; i < ISA_NUM_IRQS; i++) { irq_set[i] =3D qdev_get_gpio_in(dev, i); } =20 - isa_pic =3D I8259_COMMON(dev); - - isadev =3D i8259_init_chip(TYPE_I8259, bus, false); - dev =3D DEVICE(isadev); - - qdev_connect_gpio_out(dev, 0, irq_set[2]); - for (i =3D 0 ; i < 8; i++) { - irq_set[i + 8] =3D qdev_get_gpio_in(dev, i); - } - - slave_pic =3D I8259_COMMON(dev); + pic_obj =3D object_resolve_path_component(OBJECT(dev), "primary"); + isa_pic =3D I8259_COMMON(pic_obj); + pic_obj =3D object_resolve_path_component(OBJECT(dev), "secondary"); + slave_pic =3D I8259_COMMON(pic_obj); =20 return irq_set; } @@ -429,12 +441,103 @@ static void i8259_class_init(ObjectClass *klass, con= st void *data) device_class_set_legacy_reset(dc, i8259_reset); } =20 + +static void i8259_pic_set_irq(void *opaque, int n, int level) +{ + I8259PICState *s =3D opaque; + + qemu_set_irq(s->pass_irqs[n], level); +} + +static void i8259_primary_out_irq(void *opaque, int n, int level) +{ + I8259PICState *s =3D opaque; + + qemu_set_irq(s->pic_out_irq, level); +} + +static void i8259_pic_init(Object *obj) +{ + I8259PICState *s =3D I8259_PIC(obj); + + object_initialize_child(obj, "primary", &s->i8259[0], TYPE_I8259); + object_initialize_child(obj, "secondary", &s->i8259[1], TYPE_I8259); + + qemu_init_irq(&s->i8259_primary_out_irq, i8259_primary_out_irq, s, 1); + + qdev_init_gpio_in(DEVICE(obj), i8259_pic_set_irq, ISA_NUM_IRQS); + qdev_init_gpio_out(DEVICE(obj), &s->pic_out_irq, 1); +} + +static void i8259_pic_realize(DeviceState *dev, Error **errp) +{ + I8259PICState *s =3D I8259_PIC(dev); + DeviceState *pri_dev, *sec_dev; + int i; + + /* Primary */ + pri_dev =3D DEVICE(&s->i8259[0]); + qdev_prop_set_uint32(pri_dev, "iobase", 0x20); + qdev_prop_set_uint32(pri_dev, "elcr_addr", 0x4d0); + qdev_prop_set_uint8(pri_dev, "elcr_mask", 0xf8); + qdev_prop_set_bit(pri_dev, "master", 1); + if (!isa_realize_and_unref(ISA_DEVICE(pri_dev), s->isabus, errp)) { + return; + } + + for (i =3D 0; i < 8; i++) { + s->pass_irqs[i] =3D qdev_get_gpio_in(pri_dev, i); + } + + qdev_connect_gpio_out(pri_dev, 0, &s->i8259_primary_out_irq); + + /* Secondary */ + sec_dev =3D DEVICE(&s->i8259[1]); + qdev_prop_set_uint32(sec_dev, "iobase", 0xa0); + qdev_prop_set_uint32(sec_dev, "elcr_addr", 0x4d1); + qdev_prop_set_uint8(sec_dev, "elcr_mask", 0xde); + if (!isa_realize_and_unref(ISA_DEVICE(sec_dev), s->isabus, errp)) { + return; + } + + /* Wire up secondary cascade */ + qdev_connect_gpio_out(sec_dev, 0, s->pass_irqs[2]); + + for (i =3D 8; i < ISA_NUM_IRQS; i++) { + s->pass_irqs[i] =3D qdev_get_gpio_in(sec_dev, i - 8); + } +} + +static const Property i8259_pic_properties[] =3D { + DEFINE_PROP_LINK("bus", I8259PICState, isabus, TYPE_ISA_BUS, + ISABus *), +}; + +static void i8259_pic_class_init(ObjectClass *klass, const void *data) +{ + DeviceClass *dc =3D DEVICE_CLASS(klass); + + dc->realize =3D i8259_pic_realize; + device_class_set_props(dc, i8259_pic_properties); + /* + * Reason: must be wired to the ISA bus via the "bus" property + */ + dc->user_creatable =3D false; +} + static const TypeInfo i8259_type_infos[] =3D { { .name =3D TYPE_I8259, .parent =3D TYPE_I8259_COMMON, .class_init =3D i8259_class_init, }, + { + .name =3D TYPE_I8259_PIC, + .parent =3D TYPE_DEVICE, + .class_init =3D i8259_pic_class_init, + .instance_init =3D i8259_pic_init, + .instance_size =3D sizeof(I8259PICState), + }, }; =20 DEFINE_TYPES(i8259_type_infos) --=20 2.43.0 From nobody Thu Sep 24 19:04:36 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1789555553; cv=pass; d=zohomail.com; s=zohoarc; b=dItqq1pY4+MCjZ37//Gbe4fkeBKSHmEVwp2WnpolUD3quJFt8XSu3NXKNy3hOPWeE9Tp60vxZVphFdVdI80H2lLSV4uqsibgjSxxyfyt2/eT/SLXuBaLYlj5GTv8ZibF7prkQDFPkyXOBC9cCrDQ15v0mA/ec70lAxqTrGwBVv4= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1789555553; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=KaJeHdK8X2+JKUmO1RyhHbFBbRUmyKqMfGaHwwjNQEk=; b=iRigUSTJ2kXc749USVZWagGuQis+2BudY5Q7NoqQ7eJoiOtZKDm2VhdtAlI3oSMvgYgrCTT27OmhR26yGrOXpe6oBg56b1Ixlga7bqeazShZG60OlYRNfMwS7K59+Xp+s6CcNuncD99QUUtG4Y1OYL7Olqz3pgf5t2rWzdv33IM= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1789555553986365.0681536242969; Wed, 16 Sep 2026 03:45:53 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1422625.1648036 (Exim 4.92) (envelope-from ) id 1x6n8x-00078U-Nq; Wed, 16 Sep 2026 10:45:35 +0000 Received: by outflank-mailman (output) from mailman id 1422625.1648036; Wed, 16 Sep 2026 10:45:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1x6n8x-00077S-I3; Wed, 16 Sep 2026 10:45:35 +0000 Received: by outflank-mailman (input) for mailman id 1422625; Wed, 16 Sep 2026 10:45:35 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1x6n8w-0006z0-RG for xen-devel@lists.xenproject.org; Wed, 16 Sep 2026 10:45:34 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1x6n8w-009uTy-7z for xen-devel@lists.xenproject.org; Wed, 16 Sep 2026 12:45:34 +0200 Received: from [10.42.69.8] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6aaa7343-2eae-0a2a0a5409dd-0a2a45089568-42 for ; Wed, 16 Sep 2026 12:45:34 +0200 Received: from [148.163.151.68] (helo=mx0a-002c1b01.pphosted.com) by tlsNG-c1860d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6aaa734c-f659-0a2a45080019-94a397442c0c-3 for ; Wed, 16 Sep 2026 12:45:33 +0200 Received: from pps.filterd (m0127839.ppops.net [127.0.0.1]) by mx0a-002c1b01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68G80eEf539594; Wed, 16 Sep 2026 03:45:29 -0700 Received: from sn4pr0501cu005.outbound.protection.outlook.com (mail-southcentralusazon11021111.outbound.protection.outlook.com [40.93.194.111]) by mx0a-002c1b01.pphosted.com (PPS) with ESMTPS id 4gqa0pta0c-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 16 Sep 2026 03:45:28 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by PHXPR02MB11343.namprd02.prod.outlook.com (2603:10b6:510:3cc::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.428.9; Wed, 16 Sep 2026 10:45:27 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::8e97:bc32:822c:b250]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::8e97:bc32:822c:b250%3]) with mapi id 15.21.0406.007; Wed, 16 Sep 2026 10:45:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=proofpoint20171006 header.d=nutanix.com header.i="@nutanix.com" header.h="Content-Transfer-Encoding:Content-Type:Date:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To"; dkim=pass header.s=selector1 header.d=nutanix.com header.i="@nutanix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=KaJeHdK8X2+JKUmO1RyhHbFBbRUmyKqMfGaHwwjNQ Ek=; b=Tm40bbzjQBoWMoE5Ec8y137ts/ChyVPjJV2uSRGCixUz/MbUY6wu37Rju Oc51l4a78XXC2qru+8IQIs3+/KoTMy2qmzKAHKNdZAqVX1dBsZdU8XIv4EHLiR/P dE1rGLedcqRV64nQ9XEMiWBIuz7Rwayz5XdU9R2+rNgrltkb/y4JW1gWeQqIJQNU G4VoxM9CgSNSk503+7DMS6uPoS8/Rmib5JyvxRoezgjAHUQfw3VlbgF9TnFsjsli lSU/zng2NXqdYNv5SzxrxcXhkCzYCFhT2bu7XewaRkDJWwgUDi1/EUy9k/0J6ibe FZBQF3wO1/AzEN08gnvIHQyDbieeA== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=W8IQ9qs7agnm4IWI3NMGImwgAP6mT3rqEQyuXt+2NT+J9ZEOfnT5eGt6ycEc8ZNDmXGmoPpSa6Gij1zHRIiUJQDEPa4b4alFjaLy+2cMc++pH2nZ6GDTRJhRhl3904OG9EkGoL+OFWadMrhOeK7YwhQcIEHuPG214wgCZE6DxVlkfIu4O0cWf0O/3QErhfFcYBsZWh8pM1g+eHsMyiDFZ9b2cxUSNokEIE+n0ss9gB3ThPLC8tfkl6XyDkzsvrW3XKRyq+54/xQ0/ONrwLy/EGh8nfBKQWjn1cLaSI7agWHKTyQUM0GiY2D22LMX/ZE3zU6KnScfr+5zLN4zNxcPow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KaJeHdK8X2+JKUmO1RyhHbFBbRUmyKqMfGaHwwjNQEk=; b=Nk/cmRa5RpSMez6tt1FNz1MbS40EPnZuYVJwRm07sd1DKLIP3yEKkK6yrgPJiHfsvqfLi3+zTycJUVwden0Wpk+cZsZZaTSX5yQdgoZQcvbmKzyWvi0iRuJkz2ttiVMz/yzt+e6mc2FJR65aNFAQCLCIAHf/daC7iJrd8EbB4EvnFgN7i+0zkCzyQqDlvitC3vHcc5s7fXUGpmORoS4aKU4rGT/hKk3E/frRzT51FuAoQmBpIbHr0mDmL+cvRM9rgVLgGQr2A7nwyKzNDW2Y1uhay7JLs95LTm8SONkpEUEyBjVx3P87EjUnBB1dJ3ByRDhHyuHY3P3tSgJ9UAl9LA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KaJeHdK8X2+JKUmO1RyhHbFBbRUmyKqMfGaHwwjNQEk=; b=gzfqlvcHFhjE52VrWGrIAv8QWvqdcyulBCConAVv3L9MGGRPzfWBarghMuRumULgINjNdzjZrX39J5tMuvTCLhYOx/32Nwt7iJBrFsCODb40SM1goh5rzB51xrwdr1BtvFVd2GyzM8di0m0nA/3R5DLGOZcssxMTn+GKtWuznD0wRpR58dYp07NXdLjVP3NOsF4/LF+GYgO9zdrPYWT4IGQhbdrcDFbKBuEmEiKMvnMXStOzYrAU4yY5mivPu+FwUM66zREH5bcbRTZf4HxU819H1ll7lPyVlyQ4p/NZ8/nNirMcTYlRlCo2s0bJNt4t4plxs4hDBlSr0WTaFOdZKQ== From: Mark Cave-Ayland To: pbonzini@redhat.com, richard.henderson@linaro.org, mst@redhat.com, sstabellini@kernel.org, anthony@xenproject.org, edgar.iglesias@gmail.com, qemu-devel@nongnu.org, xen-devel@lists.xenproject.org Subject: [PATCH 14/22] i8259.c: properly cascade secondary i8259 from primary i8259 Date: Wed, 16 Sep 2026 11:43:42 +0100 Message-ID: <20260916104435.600211-15-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260916104435.600211-1-mark.caveayland@nutanix.com> References: <20260916104435.600211-1-mark.caveayland@nutanix.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: BY3PR05CA0026.namprd05.prod.outlook.com (2603:10b6:a03:254::31) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|PHXPR02MB11343:EE_ X-MS-Office365-Filtering-Correlation-Id: 4e945ac3-1529-4c9f-2b1f-08df13df9f05 x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|1800799024|23010399003|18002099003|3023799007|10067099003|56012099006|22082099003; X-Microsoft-Antispam-Message-Info: VcQ7Mb9r1OYyCbJryQGF2bel79bqeqHy6UyqrWN01MVDAlA8A6NAO0StdrHfNS5Z9yPwH2fLtAYYU7sPyCD1tNAW5JAZUrJBhJ/QYeKuXYxFAsJV7uzYyq+o9sdC5VrfrQ1iwBnfKfiW11g6Yv8sOPrTRcUmDXiSgnohucur9hNtEmiV6dHDEUCYBGAzbZEGw9v+Mx1SxkXvIES5QnXWLtyo+mxRf+ne6UhnteTvjZ2+Z8GaZyJzCIGKelUhYdcw69SubfMDDckcx7Y6leINO5uxNn89RhBUdvp/0YvUHbyD87zi6s1K4rgLtIg3un0XnOi+LXdMWQdo5cMW8YipWHXGwxgoN6Yd4c/lr8qaKsfyyDLfDnSJu4Peb+cVpDVSZftuG2ouGVPptrh99VewlIPJzOc2tHmzm+8UW4aMWm2JEBbez1f4468ZwKZfffHYITq+vMi3ErhiXAjGS8vUqw2t03w38ZiUYp3S2fORUBWWVrAmLL7c7+k5tKpLhdALW5Spm7toS1xXNsMOUt72UU+C+euGm4wb/Anrx/CpC+knADmZzE60OGguU447BYXCXnSBHTBbXgW/qA0dbq15keOkZAd6JMZKNEs0aFxW0+YpRt3epSjt+0Zt1NzFIcNW7/nHIAlD/rsrb1fua0EJ+LonL+UTIZGu5ZR9G8mnm6c= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR02MB7159.namprd02.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(1800799024)(23010399003)(18002099003)(3023799007)(10067099003)(56012099006)(22082099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?zPBqx7B0JlQ41uiY46E24Nav7YXDPvFEHEnVdXVoAmUiS+YJOgEKR35m+t3L?= =?us-ascii?Q?n3P67WVtVABEEMEntIosBtimT9MeSpaV3JmWBNw3yEpm6KPq7A/wcawDIlVA?= =?us-ascii?Q?m6qw/IE2eU7IM0e3diN9cV75AGiepSa0c0XpOjeUsXf2j44a+9xfFpkwNb/8?= =?us-ascii?Q?l+5Gi4SiLNZoL2486XSy6Q+2UevsdvEedB9rDMRuZeGWerWuxtqJIjciy/Yy?= =?us-ascii?Q?NmNLvhtaK4wNBcACHqGW8rtrTye9hYC7c7RtTsyyFJPGwb+jNuzH/MIT+nQD?= =?us-ascii?Q?mpADYQp7ghg9PwSPqRN3VzmyzER0MlgcEvzu8EsasmXJD3uZGDAfpXbmMQZR?= =?us-ascii?Q?mlBXKpiwPkiRlfPrWLxu78gJAWUyYxgJsUW+wPoxA8SKR20w4x5kZHAJLT69?= =?us-ascii?Q?32QVG5Xt4cJJxVeDocovqujxQlE6xOUGc/1nDO7vw1e2dFN8NNT4qvJUzBUi?= =?us-ascii?Q?dNaZ9aJa62djnjAHR1RxFlq0Yw8H4lnl4s7lTZIDO1jlYWnAJXtg12MHnxlj?= =?us-ascii?Q?KtWD7HDompwiHnjd+VKufHw8D2ocSKPUW6ju66B15xiy6dTRFlpgVJI6igZz?= =?us-ascii?Q?7HD+S7A029ceDSS7PRrZLTPUim3HnYIQz4tmr1mljRkB1eiiRY4/0HOTZJgh?= =?us-ascii?Q?ASjfRYUQMEXgNBfFXlV4bjk4nNUxA6xtTp3vKEEWJ6eGe88DwvlhxU+5irna?= =?us-ascii?Q?rXSkbZMKBdxxWt0ZwNcV2loJE+rKdBsZxd8BYgSeGla/0dayKrzU91RkKxb8?= =?us-ascii?Q?hxzvseKdrJu0Q53txhMQlJn3J2nk1iKQZJNtq53B6TS+RP74NJsz9tQyaD5w?= =?us-ascii?Q?mvbCB6dMhVk0FkebW4d83gaFL8BmmT8BMdyYsLNWITkC83sg0tp9HsXJjOJl?= =?us-ascii?Q?FBbRmLVq11t8R2C55VKTV1HusfM7PcBTRIhKJxi3ZmGDoUZ8nZemvxJPczsi?= =?us-ascii?Q?hPjunp4fS7GYsgBT+wt/4xVsNkfhPxcQN+x6Gr4Fd1/02g/1rxMZw/0lWQ16?= =?us-ascii?Q?k3yJlw6hTEWYSUfVdxy9XLQzNYAVfHtsnK6RTkIDKLcp8+wUe7cb60xM3ubA?= =?us-ascii?Q?2oWlAAr84lwb+XUYoHSDWC5+rOy5u8SI4edmLzKsaAtbv5lw2yRTKToGnEYu?= =?us-ascii?Q?do5Q+odWRZfCG0vpClGFoF0xrgmk5CXzn9WVp6PsZzMkFvuWnX3ezUFkuNsn?= =?us-ascii?Q?KRJIS9qduOOzqYtw8tFTnxCuU5VvuKiT9urh64RWvnlFGQwMVvaPtxXVYwY5?= =?us-ascii?Q?87WenBu6hpRU8bLsKRW2EfYLwMlPtRc6kAd6VEI/L0CiQY8U7e5S5e9aEHGk?= =?us-ascii?Q?wiZPifEEhz3Xz6Vl/8sRHu3fmjBOmtUG/aavT++o9RLxfIfN/0davziL+GB3?= =?us-ascii?Q?52nyTGxl8jr6hmKC++iGnmuVzGqqt7S+KllSwCxNhWBHcl04a4jiko/1QQHC?= =?us-ascii?Q?tf0XIV5McNE0YIWYDMZjMSdQP/T2Ay1L93Zf63pVIVsJscnQJ5D5eeWclE5Q?= =?us-ascii?Q?yhTQaB2Xs6XFupinD8hzOowokmpLvUSBKIWXPqK3q8EQpFiSoJaIQAsKVSIG?= =?us-ascii?Q?IiOuGm/3qY2qa8lkJcCsEHET5aZJaHaqBwFgsAzpANidfWnA33jVOeBFSc8e?= =?us-ascii?Q?KzplutZiHfZLEE3pDnM1+QP3HqfJ8pJnENrku3FSxWLhr1B4S2l8SzaMm/PD?= =?us-ascii?Q?JjhAY0V4Y/+5EVTGpoE63HpaunqQ1jJAD24/lkKpH0KBAJ1FQWrlHi8cZfFh?= =?us-ascii?Q?Nmbr8tcSE7CLcUA4qDxFX00OVR463NA=3D?= X-Exchange-RoutingPolicyChecked: wSmWmZMeTDpYSvv9EF0gnp2ud/pkOe4oUMo67WOtpVcuNYbMtqVky9K2EvHM9pp+8i5UTOVkzoRQqsILswnACiY1t4q6u7V136dDLep66OgQyLzTsHfHEFmKxFDBPKNFhTWXFZVtLEKzLhJXcQazjiXJAuHVNHxBs8io6sUvT1kQSOcmvMD2iahY3ePfyfnrcNE+ttOfSFCsJ9KPjgvpYuYhvwcXEOjq3KaCF40huHvfmk+/Q5GXzicSx/9gfzHr7PJ7ugm2aQlF+2b64P5LLqAR+K3Qgt1QcrKrwpJmiLkgNdzp6WzPd3jj6Mf+h4ZtklDlLYvpywnHUGNGofKuig== X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4e945ac3-1529-4c9f-2b1f-08df13df9f05 X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Sep 2026 10:45:27.7693 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: dmaXQuMyb7DQQOPLaJc8GJ5Xl3dtUHrlyBfm2WnHsLiHi3v4Oq1kB6+9JUPjZ+7/VBRoDyNOmwXRDi+lse1BJst82W1HGrm3wEqeH9Oy64o= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PHXPR02MB11343 X-Proofpoint-GUID: xXvIDoLSfYsO4AQT1nn-gGaJpLHEO11W X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE2MDE0MSBTYWx0ZWRfX6s2lHkCRWpUR SJSu+SZmpCPSDTTy25uzyD3ekb9G7GXS8tQMlB+01HbOrzirZ4uwdv5NahncRocLwu4gbYWzXOj TNDUM4JyKS5Tm6KF7GuGCZtgyCSJv2s= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE2MDE0MSBTYWx0ZWRfX9zgopvbNXKQT uZ/MMF0cjOCALNVE/xe/8t3aRT9lLGniY05Ocx6OG6YnidPO1PvWZS00KjUzckKQduzWN0JhGxT lP3LCzx0aBqJNUaDEfvqHe5LcGgvt8/zPl9njdPJuvrdXOJXUGkEb+ZZ5f78aSkTeXG6IeDTwW1 0ChdzZvzocRznBb4bKhW8oLNdKsxE84dchxzx2Yjg2tWyGjzKtpGUb7gvujrPE2sHPGM/hiuxpP ow6C6pUp94Iz/mTrKNJPkiCGXJiGzQs54Ov733i6WvOxk4cZGDUaZK39AEP7tgA71Ku+rzTKnCH WFYLq2gYdZc/q5S+NgjamD+coXAnDyiLHVwUBFFNV8ZZ/wTvicuS1kS+uAbwdwuzL1Wkz+cSGsl zbBQkxxI+GyXQRGE/7NteloUCQymk/plVHQptLiDjYrepxTXRHHfGHMx0Wb4ezZc0qHy4kVtQ1n W9TQGuTzG6u4Hl8/hWw== X-Proofpoint-ORIG-GUID: xXvIDoLSfYsO4AQT1nn-gGaJpLHEO11W X-Authority-Analysis: v=2.4 cv=Ps4G/AM3 c=1 sm=1 tr=0 ts=6aaa7349 cx=c_pps a=Xow/CfGS+sd61STD3JSCXQ==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=xqWC_Br6kY4A:10 a=VdqzKS8jKosA:10 a=0kUYKlekyDsA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VofLwUrZ8Iiv6rRUPXIb:22 a=y4UcunY2MAxhM4LwGdWI:22 a=64Cc0HZtAAAA:8 a=qb3w2fq3S_qpQCe-DwsA:9 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-15_05,2026-09-15_02,2025-10-01_01 X-Proofpoint-Spam-Reason: safe X-purgate-ID: tlsNG-c1860d/1789555534-DF8D587B-72B79366/0/0 X-purgate-type: clean X-purgate-size: 866 X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1789555554917158500 Content-Type: text/plain; charset="utf-8" Currently the cascaded output from the secondary i8259 is returned directly= in the pass_irqs[] array, instead of being connected to the relevant input of = the primary i8259. Signed-off-by: Mark Cave-Ayland --- hw/intc/i8259.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/intc/i8259.c b/hw/intc/i8259.c index fcc94e12f8..964ceb04b2 100644 --- a/hw/intc/i8259.c +++ b/hw/intc/i8259.c @@ -501,7 +501,8 @@ static void i8259_pic_realize(DeviceState *dev, Error *= *errp) } =20 /* Wire up secondary cascade */ - qdev_connect_gpio_out(sec_dev, 0, s->pass_irqs[2]); + qdev_connect_gpio_out(sec_dev, 0, + qdev_get_gpio_in(pri_dev, 2)); =20 for (i =3D 8; i < ISA_NUM_IRQS; i++) { s->pass_irqs[i] =3D qdev_get_gpio_in(sec_dev, i - 8); --=20 2.43.0 From nobody Thu Sep 24 19:04:36 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1789555564; cv=pass; d=zohomail.com; s=zohoarc; b=YCR/wrT7B1me9XwpYYzcnnA2Y8yvofdcT0USe3glkbmlB7DLb3P23cJa8CePNM/VStm4b1CuE6WWTP87Ss+YGyqlpYWQWR6/2b+9RJ994GOwehj6lG5T/50WtoAI33fq9L8Now3Saq6z+6TwiUq7lKmCQhnS34Xg9bpv0Zkblc8= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1789555564; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=ltDhewVOxH5BIDFITuFF3S3YzHHvPXtjOOTxeIvEY0k=; b=EklFX0lRMKT4fSvMFbb6P0v77NyUK6TxCLT7RXu1tlK56JoeWuscS2eSb1ljDfBUOURACoFKLzQ5KPrqplh0X00dd8A3Ek7naDPaeXVILAIGz/m5DCxgPGr4Z8U3Ip5yHJ48+lqJSmAzjf/BiBacE8+PCH1stPsMUoLjvkr7ByM= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1789555564936808.3460102504564; Wed, 16 Sep 2026 03:46:04 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1422635.1648047 (Exim 4.92) (envelope-from ) id 1x6n92-0007jH-0M; Wed, 16 Sep 2026 10:45:40 +0000 Received: by outflank-mailman (output) from mailman id 1422635.1648047; Wed, 16 Sep 2026 10:45:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1x6n91-0007j6-RV; Wed, 16 Sep 2026 10:45:39 +0000 Received: by outflank-mailman (input) for mailman id 1422635; Wed, 16 Sep 2026 10:45:39 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1x6n91-0007gZ-0l for xen-devel@lists.xenproject.org; Wed, 16 Sep 2026 10:45:39 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1x6n90-00FCP9-D7 for xen-devel@lists.xenproject.org; Wed, 16 Sep 2026 12:45:38 +0200 Received: from [10.42.69.5] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6aaa734f-e002-0a2a0a5209dd-0a2a450582a2-6 for ; Wed, 16 Sep 2026 12:45:38 +0200 Received: from [148.163.151.68] (helo=mx0a-002c1b01.pphosted.com) by tlsNG-c201ff.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6aaa7350-4cb1-0a2a45050019-94a39744b51e-3 for ; Wed, 16 Sep 2026 12:45:38 +0200 Received: from pps.filterd (m0127837.ppops.net [127.0.0.1]) by mx0a-002c1b01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68G8JrHB700573; Wed, 16 Sep 2026 03:45:33 -0700 Received: from sn4pr0501cu005.outbound.protection.outlook.com (mail-southcentralusazon11021119.outbound.protection.outlook.com [40.93.194.119]) by mx0a-002c1b01.pphosted.com (PPS) with ESMTPS id 4gqa0ka9xq-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 16 Sep 2026 03:45:32 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by PHXPR02MB11343.namprd02.prod.outlook.com (2603:10b6:510:3cc::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.428.9; Wed, 16 Sep 2026 10:45:31 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::8e97:bc32:822c:b250]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::8e97:bc32:822c:b250%3]) with mapi id 15.21.0406.007; Wed, 16 Sep 2026 10:45:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=proofpoint20171006 header.d=nutanix.com header.i="@nutanix.com" header.h="Content-Transfer-Encoding:Content-Type:Date:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To"; dkim=pass header.s=selector1 header.d=nutanix.com header.i="@nutanix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=ltDhewVOxH5BIDFITuFF3S3YzHHvPXtjOOTxeIvEY 0k=; b=mWxOnbPIybvQPEWqgbBSAS0KfdaXAQcDGrvzReQkEbLjId6pdBOUiRqb0 VyMXcS0bJUJvhi5mLSsK3rlpKhRSOrQ+rv+jN46aEFVHq9plinrGf4JK7Vx7HYdc /Eq1t8yh9TNu5FWLEeaqMjXQklR0Cb01lOg7mtxW6CVvXD/M6hO2xHT5GJS2WTYr PNjA5nS6p+Gf2hDqs8nMpPTlChlsLeYot5FMun3lvz87zgn0CKRpEegcLveBhR2T asnkFztAzAutBoGCBm32QmDERjCd9ZZRVFnnS4qS27MCx0lN8TqQcr+PXka1wSnX sADp6D1kFD6aFJyRjpCUzke/hq08g== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=m8ypQl+IrGsTzYmc+VrPAaOR1r6Ntw/opRWBH34Gp2rl02pe2YNSM/0cRTxjCfdx/rIUpxEl+ykjCfCwuE0I3Yr+1Vf2oGauOHyilkvt0x9owt6GbdJgLPc90g/DnDaONQ/2G/5PM//vKMgl2yrMcY29SxUH3p0+0+ojgFO71z9bHF9i/9lc27f9lwhJcCV5P4nCHLPAIjfv8/v4xna2TQILNuhNZmFUf7LBg5OHH+YYLpThXC0pmB+/VKPPtVaGFTq0JBHbSk65omf6ccfZBmEfJbk4Npt65Wq+2asvZ0YASSnyZ8p+yaFhJh4bPxAl9EMOB7knDjWkqUwKlKDfGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ltDhewVOxH5BIDFITuFF3S3YzHHvPXtjOOTxeIvEY0k=; b=mDBO+/8t5BKeOdf5kcZwaBcZB4328h2w4Mkw5u5iSlak5cN6svDIHpMxSl3LUgcc38jkwG1/kTlJPlAd4dUtR2kqM9PE0/1nzdSRwjv6iHxshHeY/JbXS7UNQrTqLth/5FRCbBgiXZrv9UhuZiBhHSGcnpkQluIHVnBqUUifItjqetJUboPeCdOheWC1P09Xf/HRg1gTH+WOjoiNVqIDQJPkvUM5osle8b3nMKJ5dIvkwHNclPCoiaA4kwqDSNWOqLPOahgXYAfpsTl272uHOG4LRK3v7fM8xJnt91YVfsY5/ldL6iUMddamzMLzxVUtg0Ah+MELH35BppTdgnQxQg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ltDhewVOxH5BIDFITuFF3S3YzHHvPXtjOOTxeIvEY0k=; b=h+fBzxXMZzbeXRlX8daQQx7bnosXt1AjjxzpTy9RxDoBH8hKqHAsR5gpQ8qWMz5zQiWc+dFfcjcz9d+nJAHRP2kDDFyhLbZtH7E7fOrCXdAzw7yh90V1xeRMcowFlmQ45eYi+TPUmpXqyHwQWVxQahYMVenKBkbU5EJHeRTCSMP53mDSl4l4P0RicGy15kEFE046TYbbCGFJTu+qOdQtm9CuraICAVv2PZjV2oLW88wuzav5qDc4UzL/GwtCubP498OhJmyaXDzecLCH9ey5UcYG2A7Gf0vmGPiJS/wFR/os2gsO5+kZPJFlnFbVQrnovu5TZauWx0SWPYjZeq5JsA== From: Mark Cave-Ayland To: pbonzini@redhat.com, richard.henderson@linaro.org, mst@redhat.com, sstabellini@kernel.org, anthony@xenproject.org, edgar.iglesias@gmail.com, qemu-devel@nongnu.org, xen-devel@lists.xenproject.org Subject: [PATCH 15/22] kvm/i8259.c: introduce TYPE_KVM_I8259_PIC device Date: Wed, 16 Sep 2026 11:43:43 +0100 Message-ID: <20260916104435.600211-16-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260916104435.600211-1-mark.caveayland@nutanix.com> References: <20260916104435.600211-1-mark.caveayland@nutanix.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SJ0PR03CA0224.namprd03.prod.outlook.com (2603:10b6:a03:39f::19) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|PHXPR02MB11343:EE_ X-MS-Office365-Filtering-Correlation-Id: 57b3878d-70e3-4cf6-8b81-08df13dfa0db x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|1800799024|23010399003|18002099003|10067099003|56012099006|22082099003; X-Microsoft-Antispam-Message-Info: XlXoTM862QELIzTTHjHasT7T9OoYtP7Wae/N70KYeqZeL31ekCOiDQMJ+BtSli4D7FuQTk1vkx6N4IINR074ry+aDFMIXC09W9LnPWUFOpts7Zm7W0uL/8ILLmTApQ4W+OSvP6pTysZHZcMp33FRcXTuFMG6aRDXqk6pjoLqdn0hCF4gYtliExHDefpLGjU1YVK2qwGBBMjT2i4gmHf1sHoAdZR0gL/lM558gXhCe18n6D5HD8tBsDSmLIltMspWsVPfBZ36T2mv+Hha+JW3Sn7kxJGXxncz2Q+VzdGGTdEwhvT5SiZwtNqLuXcXHkraNwyFAdrKyoYBTi9stIU4uScwHb6ozJpJU6zSKdSd3p1/BSsUhdNT5WRDs4kR0XdJ1+xh5bydBU1bM+FuoYOl55/RemLJPp6/9fS927PnYn3cHfs3pIlTDXNNOx/3Nd/7mQDeYERYV4L8jkAbXNC1YMPgSvEioAWVbhtwd3FkpM84WoR8x+5G1AWXvDkOBIpzkYsE7gxQ9kPz15KGN/ohn/11urmUpU+4Jfk6L6zjqQLdVoL5/P6pQv5pIaJj08HhtSXiydHlXYhffS8XGXzE4PmpQAulOo8Vqu9OaWa9R/3NEluqnesI2ypfjOep+W/OZTTZ71IKpPDZRiNO8kjrjREi+i4JeNBZXcb36u3g/tg= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR02MB7159.namprd02.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(1800799024)(23010399003)(18002099003)(10067099003)(56012099006)(22082099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?28KCIf911ApyxylgPf1uidPuvnRpiOvHhF4B2FNc/oP0tnZRO3Ccc2GBg1vZ?= =?us-ascii?Q?XIVyuDwkPohmWWj6xxTUUYGYcs5y2wLhMGtgelUYZLlahl7dY6TEkcQHqksp?= =?us-ascii?Q?J76bacDHGQXXv5ztkmrzMfekLblkEmbCZL3xuFB1c5M4VCnWX97Rit9N3eLp?= =?us-ascii?Q?jPuKLGZseTPjjZh9Zp4V2VQ4LhjzerM04V8UpZgDWmQ9Yks3n2Kj7bslroV7?= =?us-ascii?Q?JmkK4YLYHR/VsjbUOvcUC/MzETecauJXQPOCnEby/bVo8rcxbkeyPtLh9UND?= =?us-ascii?Q?t+gZiR9ALLtDbs2uabkbFEQVIgE39bALqZ0Fb7tmLqbtZdoAF+iHavGre/7j?= =?us-ascii?Q?g5UeU1cCKXj72AiEQOBB6NhfF/lBfK72eqpFAXx+79fJg0oDaNxS/tBPcBD3?= =?us-ascii?Q?uWBSMLHnfpiXe/vm6Q2O6TbRhQS7Bbs0V3QNZnAYk2M5wLTSbqFNoCfRIDJA?= =?us-ascii?Q?vv+DKEBxjWVDndPg0/uZEw40/ouFxLZYr3nMf+4KgDThck2Jl4BBbSikVedk?= =?us-ascii?Q?B4xb53GkDav19HZh+HirzuxFNZv9NvqvNkhO7iYvwnLlPPvcvlPq4CJ1yB2T?= =?us-ascii?Q?RKvn/PX9MP/9WRLC6Q6svl4PHZFx9YutxKV53zhnP0+1SL7cmp29fDxFrVcT?= =?us-ascii?Q?a3OJtCiBBQ4rYe1Bfg7qIAupYs46XxctUhe1k0XzL2U+6GnfUj1d2e3qFCOm?= =?us-ascii?Q?mOLdQ2+7dy8b/of0jepwycP5ccvwWwcQsb4se09qZPF6fGYmifcuZKUKlCGC?= =?us-ascii?Q?wR21tVr+t2E6/4+NTct8g9GVLwcB81/m6EbJjIqspYgMd7ZLxj+H5O68sU9F?= =?us-ascii?Q?1GFSutjYdJsstPRdHaT54f66w1xYdaK1hWX29mTcDbEtjSg2adCqT3SioDZy?= =?us-ascii?Q?oUVh+PyTqMO+g8D/qEjJM1gA6GOwc0pKtKIKgRzpy0kRQgUgcQwAdQSew9kQ?= =?us-ascii?Q?KYePYdjthpGa5RGVlMI6HqcAideE8GlXOKDkTCuNlN4Pp6daBU8oJtgTjVrM?= =?us-ascii?Q?r8w68YeTR8wJ9BW4kZSbbmK833mfBssOzfTOtGGz0Y4+6j1b9eru48tcq0LR?= =?us-ascii?Q?w/OMTsrmdJQviDGmm+0WIEfI5baKksAY+wOJF5QoKKTeuQ5/LG0828GzbfmN?= =?us-ascii?Q?HzPS4czfQdP7K9AnzN/6M7rDOnzXAx8TmtrZlZT+H1/CCEFKeGUXgy+EuAgD?= =?us-ascii?Q?07iTaKCUl2+aWZ5+YriCaeGo9q0inYkdVDYf5LXPQoBzxvKvARfpiqhH7fud?= =?us-ascii?Q?X5zZGicqIGWCBNvILavp+twwUU0kVA/qoA7YPvwJa9yKhqGOwSSUinihzi3H?= =?us-ascii?Q?CWUIwoTfsLp5pkXRtovS/pHoga5pGYANAmwqPOxVQhobLDv7geguZkU0THzQ?= =?us-ascii?Q?xsaywAHtovyJ36G5ExGTVcmQ2tvn9a4zSQvZoRyaK4vvoUrzmYSMrHrkiIMS?= =?us-ascii?Q?2z09n2+GNKxvRxVXFQijHfR3uPCQYvmkXuuzPmMLnRrTteO9rIi2dKP/QekP?= =?us-ascii?Q?0WErm5gHZx1ruUeBo77XJZqKLp7ljT0nS0B0UdLqlFX4m2+ziHJk8gwavppb?= =?us-ascii?Q?zN4oQEsbaBBkfc879sOja9lruSS3YRjWzLXlwb6SMIBhYu+w9tNn88EHFlYs?= =?us-ascii?Q?WSY6ssJ4HOhIey4tSdsB7pS+lQvA91ybLTrN+m5aOJI4w4DnDIUbZEC7SIJL?= =?us-ascii?Q?YMoTMSrTcTH46diRbgAXeXS31lpwId2Zb0+AT2U0x4NCK/DJLS9cLU8Fc+3x?= =?us-ascii?Q?uhtRDYul3eRZM1DWV3Vu4KeMcR9I4gM=3D?= X-Exchange-RoutingPolicyChecked: XJVhPw+63izdzpFrqJ3YvOlHjghh4Y9E/gNhUFdzFuaaxN8d/B+KfzsSt+8iq2lnxxnl1esN6X1J2FdosL9jPLupaGgTKEl4rtOx0x/b+HdTnn4n2gF+w28pwaQJDP/a5FbMgYdaXLkaEJFQ+edZ2OWRbs9fY+TJpboQD0l8gnu3YAgpqQWuvojn7SZNHnbDyiSEjuLAhQLybKlRI9+ROjueaexww+D71ETQtmKt1s5k/BjT/JjaQfb701DvZtLAmvpXcG/uVw58FRrCs2RyUhF4KFurcE8ED5SytFaNjWbrxltYXbgtk+8DyfToN6ZitlxmNhQovSS6kmrLkYh09Q== X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 57b3878d-70e3-4cf6-8b81-08df13dfa0db X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Sep 2026 10:45:31.0196 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: xNYoYZn0QtEYCNygkpIMnHxIEOurJvq2W+XeuIIYijDwgXK71QMnrBupo+8bnfi0QAFqVXPXb4yEQ+ItpxGoRFUwEkoGYhyVlO8OYyRhJFs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PHXPR02MB11343 X-Proofpoint-GUID: T_a2ioT64h1SRz37BaKhPISEOa-ScxtI X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE2MDE0MSBTYWx0ZWRfX27lMZ/R2MGJF PXGDVMGD1a0xFW7hWzB19B1OlxwAnrM3npfFjq5JpRzAK/PiXcSUixMfBfFvJo+pWdpYuzDuAHi gF8qi5k2FgzZ2Cm0vruc/OhAjU2WKdM= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE2MDE0MSBTYWx0ZWRfX7qOPq2+hJAXL KfHgNAkraJHUE+miHuWArTxFhhmC9DW+yvNOzmwyCYc/PiWtaZaudKn+AtBpQWDc+fZSafIoPR6 OufkW5igW6e6W9X5PlydS7LaDV/8E6U0NuEUJYPDPIXA7Bh0FBbDVrY4uyxKxIItu2ETln6rbfw 6C7Tp48aeEFNFSAxslpvjVVaYW2ZU7FewMMpPAkQyVGWAUckbPnsZTeENZqutX2WZampasEOzOa 3X69iCyO2Uubs6uqrh9RCdLUgkA2qYBS1QWLSJA92CV8H2kZjdT1RG6LouYsi2AFPe++qN5i6vV t/GswpbWsSAQWZR77SLdwrX4zWgcf4gj3kKsS+HO0BJcZ5baXlWooP+jZsbCWN61cGR55f7svpt N9iBueTSC7oit8DyHgUszPLXB0UvMOM3e/hxy+Aw9z68OZN2tNOZte9mtl6slHiXW/KoFkLq8or Lvmia4h0yhgfcVlG6oA== X-Authority-Analysis: v=2.4 cv=P46vFSAu c=1 sm=1 tr=0 ts=6aaa734c cx=c_pps a=GdOSod5Hi6qnJTGfnwF89g==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=xqWC_Br6kY4A:10 a=VdqzKS8jKosA:10 a=0kUYKlekyDsA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VofLwUrZ8Iiv6rRUPXIb:22 a=Ap8k9tRZuQ82DLYWQqG7:22 a=64Cc0HZtAAAA:8 a=CV9Lyex1vB-al1NDbmIA:9 X-Proofpoint-ORIG-GUID: T_a2ioT64h1SRz37BaKhPISEOa-ScxtI X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-15_05,2026-09-15_02,2025-10-01_01 X-Proofpoint-Spam-Reason: safe X-purgate-ID: tlsNG-c201ff/1789555538-F7EB92A1-9E3DE4B4/0/0 X-purgate-type: clean X-purgate-size: 4164 X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1789555566963158500 Content-Type: text/plain; charset="utf-8" This device represents the KVM in-kernel PIC for an x86 machine. Signed-off-by: Mark Cave-Ayland --- hw/i386/kvm/i8259.c | 91 +++++++++++++++++++++++++++++++++++++++++++-- 1 file changed, 88 insertions(+), 3 deletions(-) diff --git a/hw/i386/kvm/i8259.c b/hw/i386/kvm/i8259.c index 9793473163..0ae5caa655 100644 --- a/hw/i386/kvm/i8259.c +++ b/hw/i386/kvm/i8259.c @@ -16,11 +16,25 @@ #include "qemu/module.h" #include "hw/intc/kvm_irqcount.h" #include "hw/core/irq.h" +#include "hw/core/qdev-properties.h" #include "system/kvm.h" +#include "qapi/error.h" #include "qom/object.h" =20 #define TYPE_KVM_I8259 "kvm-i8259" =20 +#define TYPE_KVM_I8259_PIC "kvm-i8259-pic" + +struct KVMI8259PICState { + DeviceState parent_obj; + + ISABus *isabus; + I8259CommonState i8259[2]; +}; + +OBJECT_DECLARE_SIMPLE_TYPE(KVMI8259PICState, KVM_I8259_PIC) + + static void kvm_i8259_get(I8259CommonState *s) { struct kvm_irqchip chip; @@ -120,10 +134,21 @@ static void kvm_i8259_realize(DeviceState *dev, Error= **errp) =20 qemu_irq *kvm_i8259_init(ISABus *bus) { - i8259_init_chip(TYPE_KVM_I8259, bus, true); - i8259_init_chip(TYPE_KVM_I8259, bus, false); + qemu_irq *irq_set; + DeviceState *dev; + int i; + + irq_set =3D g_new0(qemu_irq, ISA_NUM_IRQS); + + dev =3D qdev_new(TYPE_KVM_I8259_PIC); + object_property_set_link(OBJECT(dev), "bus", OBJECT(bus), &error_fatal= ); + qdev_realize_and_unref(dev, NULL, &error_fatal); =20 - return qemu_allocate_irqs(kvm_pic_set_irq, NULL, ISA_NUM_IRQS); + for (i =3D 0 ; i < ISA_NUM_IRQS; i++) { + irq_set[i] =3D qdev_get_gpio_in(dev, i); + } + + return irq_set; } =20 static void kvm_i8259_class_init(ObjectClass *klass, const void *data) @@ -137,12 +162,72 @@ static void kvm_i8259_class_init(ObjectClass *klass, = const void *data) k->post_load =3D kvm_i8259_put; } =20 + +static void kvm_i8259_pic_init(Object *obj) +{ + KVMI8259PICState *s =3D KVM_I8259_PIC(obj); + + object_initialize_child(obj, "primary", &s->i8259[0], TYPE_KVM_I8259); + object_initialize_child(obj, "secondary", &s->i8259[1], TYPE_KVM_I8259= ); + + qdev_init_gpio_in(DEVICE(obj), kvm_pic_set_irq, ISA_NUM_IRQS); +} + +static void kvm_i8259_pic_realize(DeviceState *dev, Error **errp) +{ + KVMI8259PICState *s =3D KVM_I8259_PIC(dev); + DeviceState *pri_dev, *sec_dev; + + /* Primary */ + pri_dev =3D DEVICE(&s->i8259[0]); + qdev_prop_set_uint32(pri_dev, "iobase", 0x20); + qdev_prop_set_uint32(pri_dev, "elcr_addr", 0x4d0); + qdev_prop_set_uint8(pri_dev, "elcr_mask", 0xf8); + qdev_prop_set_bit(pri_dev, "master", 1); + if (!isa_realize_and_unref(ISA_DEVICE(pri_dev), s->isabus, errp)) { + return; + } + + /* Secondary */ + sec_dev =3D DEVICE(&s->i8259[1]); + qdev_prop_set_uint32(sec_dev, "iobase", 0xa0); + qdev_prop_set_uint32(sec_dev, "elcr_addr", 0x4d1); + qdev_prop_set_uint8(sec_dev, "elcr_mask", 0xde); + if (!isa_realize_and_unref(ISA_DEVICE(sec_dev), s->isabus, errp)) { + return; + } +} + +static const Property kvm_i8259_pic_properties[] =3D { + DEFINE_PROP_LINK("bus", KVMI8259PICState, isabus, TYPE_ISA_BUS, + ISABus *), +}; + +static void kvm_i8259_pic_class_init(ObjectClass *klass, const void *data) +{ + DeviceClass *dc =3D DEVICE_CLASS(klass); + + dc->realize =3D kvm_i8259_pic_realize; + device_class_set_props(dc, kvm_i8259_pic_properties); + /* + * Reason: must be wired to the ISA bus via the "bus" property + */ + dc->user_creatable =3D false; +} + static const TypeInfo kvm_i8259_type_infos[] =3D { { .name =3D TYPE_KVM_I8259, .parent =3D TYPE_I8259_COMMON, .class_init =3D kvm_i8259_class_init, }, + { + .name =3D TYPE_KVM_I8259_PIC, + .parent =3D TYPE_DEVICE, + .class_init =3D kvm_i8259_pic_class_init, + .instance_init =3D kvm_i8259_pic_init, + .instance_size =3D sizeof(KVMI8259PICState), + }, }; =20 DEFINE_TYPES(kvm_i8259_type_infos) --=20 2.43.0 From nobody Thu Sep 24 19:04:36 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1789555573; cv=pass; d=zohomail.com; s=zohoarc; b=UAhj+ik2Bdsc6fBTVgXaogM0lORzx4WiOLtGt9LDkjsndzB1M+WfIw8l1hpZNV3lI49HC0+pfmCBjGkFP+8PDlTyovtonNqQaB6F7DDLZjvzJ4L9OxNOuwR0T+M7gUQ1BnaiHt3QpLAzs8/l3aO0BzJ6vCpFn5DdUxKEt4YvVNQ= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1789555573; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=PgMrs3YOWMsmiAprS015sI7/c0L9GRi3GbtRd7GYDRA=; b=X3p8p2G2DYC/GY5kBOWPpoUro2GPEna+/O/S088b2nIdL5TnH+gPh97SgwQ/DUOxBrQwF2RsYK3rcXLmxXSasPwnbOwqOKgQSj7qoa5Q/W399oj0XX8+y13lzm1QQtU/qruqtodIoZl9vPKz4jjvaatJlPxNPuwkHWYUZ2v+XTA= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1789555573422708.9900015142493; Wed, 16 Sep 2026 03:46:13 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1422647.1648064 (Exim 4.92) (envelope-from ) id 1x6n9A-0000C1-NS; Wed, 16 Sep 2026 10:45:48 +0000 Received: by outflank-mailman (output) from mailman id 1422647.1648064; Wed, 16 Sep 2026 10:45:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1x6n9A-0000Bs-JF; Wed, 16 Sep 2026 10:45:48 +0000 Received: by outflank-mailman (input) for mailman id 1422647; Wed, 16 Sep 2026 10:45:48 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1x6n99-0008TV-U2 for xen-devel@lists.xenproject.org; Wed, 16 Sep 2026 10:45:48 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1x6n99-007b5t-AE for xen-devel@lists.xenproject.org; Wed, 16 Sep 2026 12:45:47 +0200 Received: from [10.42.69.2] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6aaa734b-bab6-0a2a0a5309dd-0a2a4502b1f4-34 for ; Wed, 16 Sep 2026 12:45:47 +0200 Received: from [148.163.155.12] (helo=mx0b-002c1b01.pphosted.com) by tlsNG-720697.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6aaa7353-6ca4-0a2a45020019-94a39b0c83ca-3 for ; Wed, 16 Sep 2026 12:45:40 +0200 Received: from pps.filterd (m0127844.ppops.net [127.0.0.1]) by mx0b-002c1b01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68G89JCY579568; Wed, 16 Sep 2026 03:45:36 -0700 Received: from ch5pr02cu005.outbound.protection.outlook.com (mail-northcentralusazon11022099.outbound.protection.outlook.com [40.107.200.99]) by mx0b-002c1b01.pphosted.com (PPS) with ESMTPS id 4gqbtb9ybx-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 16 Sep 2026 03:45:35 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by PHXPR02MB11343.namprd02.prod.outlook.com (2603:10b6:510:3cc::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.428.9; Wed, 16 Sep 2026 10:45:34 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::8e97:bc32:822c:b250]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::8e97:bc32:822c:b250%3]) with mapi id 15.21.0406.007; Wed, 16 Sep 2026 10:45:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=proofpoint20171006 header.d=nutanix.com header.i="@nutanix.com" header.h="Content-Transfer-Encoding:Content-Type:Date:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To"; dkim=pass header.s=selector1 header.d=nutanix.com header.i="@nutanix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=PgMrs3YOWMsmiAprS015sI7/c0L9GRi3GbtRd7GYD RA=; b=vY36fqt5lxC6fuEwH1Zfa8vKp7pltFM0n9Iwg0F5iqm8eDQwmyGurOA+n fhvdXFSe3bDv2L69Uu0IteLjDTE7QVT1xePpWhy9RI5AQgrMG0EMEbY6/D2UhwHd cnBjXvSmQdlJKGUA/hCqbNUbiVu2g58AvCuWFqWJwPyMZ7v5cc0YIyVQnUiVo/gW SXxQ3PJn3B+9A/8eA0kRToUit2VuBRHh8sry9FI5NljzECjY3eOrl0zC7LTgNzp+ oDlyvwk+flBuQ9q9S8PoTcDUJm/M4apEi0kRdgS1T9E//EGxfXwpDcjuzCFDIx4A lQANDauuTnb4C1uosUsTdtUhWDmtg== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ZJYii4s4kl6rIWMm9RxkenXwqcrC9+DXdukoJZJVLA34g04luKbApx75oB+hTZQkp8p2aE0mmo93m0RyPcHbr04w2v+ddRsclUFplznyhR7jpBbU/rhBdATBU4jwRmsiiuAlz76a1V+51b2BCLxJ8FZtTPiusu1AV4MQr4UumJJ0JAk7CmB/4h1kMUBCSll0DizjgI+LMOL7Nk4VkLNUkAan64JO1XYdB+QQyFNezUPzTQHOADmAYiZ6F7oNZHKQS0rSg5QDgWsceH8AeDZQ6lZExvTzNeOaE6Qtw7Fym9KabpykP8/HwWVDbFKmoUMWKBeVYO568idRJeTwMdi3Jg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PgMrs3YOWMsmiAprS015sI7/c0L9GRi3GbtRd7GYDRA=; b=QoTkbPSvqzxBa+qXvsWfw/+VBt+M2DFAWGMrxwBKCFGIEWyuxQcSjXxjzCAbFkUc4fzvPqlVLcb5HTazcgIB3iq5WVLUMmWOal/ZMF4S5+OuhZMqzBnBdULWm6zWUO1SIs9MeH7HId1cl8WQVwpyyCkRLI6xFGAjYdDaGE6UcOHOAxPD/+6iIYQdbLcOTBXy2VrMn+bC1LJUKbxTMFBXUQ5u/hbqlO0eXVws7cfeaTwobB0CNSL8GRrY5zi0Ybhxb3bH9J4cbirRwqYkRwJH85iiUGXYyIPargAtVXGZRBj2ifbzY8+JTM8aygNPUXAf/wRvJp4r9X9kNxjDAH7r/g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PgMrs3YOWMsmiAprS015sI7/c0L9GRi3GbtRd7GYDRA=; b=ij7JQoAfBI0gHgWtmAlxQ0WtqYp1/slc5rY2WZbjSRdWEE2QpIFSVMMFaWjm7HLUyKhKhDwneGZWVU1xG9lEQ4pEtkXXYjEEaO6hjbV023anaPqNGydw9dS5jMymeWdI0OC5lmFMPwZXgxj2mD3d4R26QX3tDpq8s/jBWDVx1HDtRC5Vl721vmjK2svr1v0K/2YILL549VrJMPK0QFDG+lV+Vr/uWDgPleVSCMQ13FAjE21YCf78ZUIzX0l3TpJbTIR9LD4nKx51wL6DvL2h2+O7ebCZQK6hxMHyqA0+q7SwjZNxXYxnSEMOP7W1Hc5J5zu6/Qea1C18H6hDlZUSFw== From: Mark Cave-Ayland To: pbonzini@redhat.com, richard.henderson@linaro.org, mst@redhat.com, sstabellini@kernel.org, anthony@xenproject.org, edgar.iglesias@gmail.com, qemu-devel@nongnu.org, xen-devel@lists.xenproject.org Subject: [PATCH 16/22] xen-hvm.c: rename xen_interrupt_controller_init() to xen_i8259_init() Date: Wed, 16 Sep 2026 11:43:44 +0100 Message-ID: <20260916104435.600211-17-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260916104435.600211-1-mark.caveayland@nutanix.com> References: <20260916104435.600211-1-mark.caveayland@nutanix.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SJ0PR03CA0280.namprd03.prod.outlook.com (2603:10b6:a03:39e::15) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|PHXPR02MB11343:EE_ X-MS-Office365-Filtering-Correlation-Id: fef8331e-162c-48f7-de1c-08df13dfa30e x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|1800799024|23010399003|18002099003|10067099003|56012099006|22082099003; X-Microsoft-Antispam-Message-Info: Aez+eTmH7fj45IrYLDModWIH70IR7c2Z+1lYLTSLIp/9D8YBcEIZ4I+CQ7helSo13ieEem2EqdxSBNuVySdXIMVgg8FXYt03d7ZUa0XOhrxpfdmsYSe/uJORdJ/l0HCBZ+qtACnwDY9JV0w0UjouTj/WWVNFrITHvzt/UO1290t/iqb5TcPpF2sYfSUs7vC+8k97U7zYldLVyrzUeFa0s7CWYmBx8uhvaGI+r2YHskytFI+V926SfYx45VQbfI+T+6Q2FqRrcSI2wEE8Ivc7OriOvEhoaiB55CcKWIFqt2Cib/b5aiUrOGr/6TqStGjhpYe0vOO4wTIQ5NPi3dM+crDjx/H6uEd79AfxD7ZidUJed74e9qoDJthR7EVHWCYMxgGfyzqlg+FxHrdYyM4+TzGpHjFpatsBk1hMw1UHKr43blTNgxOuuz0YEDYQVF9wfxRYNMNvjff8ymDE9haetA8vVWDXEkuaTWyrhW7gLF+h2UYedyouV+0vnL+9zYm0fvZAO6khAm+kbL70YNoryBif/43ems+r5aG2w/1twNtVTL96u3Xh52Gz+35W0KSHXS96493Gj4KSQka2a++XUoCRWQHc0GjwLDvCKkeTLoQussZJ/f9G6BKlAsXo37Tf2kZDaBhUTFpHuX9QpVa5ZgAG8QiuHlqVx1A+LGBvJGA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR02MB7159.namprd02.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(1800799024)(23010399003)(18002099003)(10067099003)(56012099006)(22082099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?U+/UsDcJWmSbNmbYtqssDwDpCHhK017/7VVfUw+uGpU+MyxGx3mnYZCnDRxF?= =?us-ascii?Q?r7cgzhQjKydWUqwkEp8p9r+8MWW1+TyL/j4/LoV/lfpXf9vw/cTFggm9eNQ1?= =?us-ascii?Q?VGSPPrLHYFwTcl492cdVMUcTQozC42iPwyxC3ayin4GUsySn1sBf5SyNgmn+?= =?us-ascii?Q?uwMRwNOenGucrUBczlxDm/agxlVjjXkrbulfmSf1MHtSnBjScyfMeXr4FuJH?= =?us-ascii?Q?amlvUvkAQPJed5KDLyzqYrX8O/4ixVeoJqFY3m0pgQYTQFiN+9ItNb1n0CWd?= =?us-ascii?Q?+eySU2His+/JwloHaADr7b4HbSBC4N/v7w7Rn2SwL2VJ6x3mxzG3IIKFqy9c?= =?us-ascii?Q?eBVB4ySk8AJJVE1CImehYZfeU4Wa9J11f8T9W1IJzHspN2RoX70uG16WiVaC?= =?us-ascii?Q?5v1pKQKiLDPKu2G7H91gq40TImJ8hkDq5DJigkywsaGeSt7qiNu/XY0+ucwL?= =?us-ascii?Q?Q+Y29hWwijE1w6yAOCbE2zcjCVpfVkdTwkJRenPU9BSx3x2Xh9am0q9soojb?= =?us-ascii?Q?BVNI5w/kgw0LNnbptMeY+tzaBBE/555pQ+HSZa54MpgcVLEBYYqnVM7lMpgd?= =?us-ascii?Q?YQdGMZVSwd7V0mLB0Rt7wC/umnXWqSWWt1CeXDZGAQI5dXR+PckUUygKEvnW?= =?us-ascii?Q?US6mLXkvjGqzlW9F9jSwdFzq5DpSrlEyw+R2EhyBCAOH7ZxsKCPR6vX6MyUH?= =?us-ascii?Q?3wlkz/kKwCsoxCa31waviLMRstxLEpCPa20mrC2VmEKKjSBTJj2vxbcpXvfu?= =?us-ascii?Q?js2qJ0ijV1PLi4W186C4XC4Q8H0DsY/TcriQD+it24Q7mzAwWcuoI840sHpL?= =?us-ascii?Q?sQtMWhYT1KZhk2Bogo8t+ewCLgWba6dldLlYMVwhVWaZrh293ZRc1jDqTfaZ?= =?us-ascii?Q?bOwMZrNjLCntRleMVW0GaYrn7rMvAz1l1qu2wBU7ejoEbcjawRHukREOzch3?= =?us-ascii?Q?BXSPBHG+eOdYi+W8weAQAJzcfsriUtUvc7nntRHd398afoOWw5SHnXPZDGTp?= =?us-ascii?Q?f8RVDXZYQl9zzifhrDMU4Ce6ymut72HrUHwf96LwWICXv8AsFv6qsteqKepV?= =?us-ascii?Q?qUZI6GcEhRfSM7biucqtEYscPqcAiUU7p9uffQWxet55/E0aMEMz+1NnOXn3?= =?us-ascii?Q?7oVtLfFC63Mzm4T7+m+RJLhJSM4tJfkOt2K4SY0HC+okYJ1Gzb1BVH18jb6e?= =?us-ascii?Q?RuJsqmPYweV1fZe/36lhPqiAfVE/U+/8xopHWMXW0nMxG4RKUlohL8RGdn9b?= =?us-ascii?Q?Au2mGn6O/OajlDEOArZLlG4mpr/BAquEEs6GePXjCeUm7ygostPx7Oufcmgv?= =?us-ascii?Q?hw4R0diTvGBGe/0A7X06mKVtlYcE/hjdTo34FGZRHC7H9YYRkbq8dtAyN4z4?= =?us-ascii?Q?liyNojYCbVHEQwYqrdJb4Zsq3COjnR3VTOVYyDWdUHwlGBPm4ZR2B0awLbg7?= =?us-ascii?Q?DyjxWJnTo3LSWkBAG604Kit6NUrdQNkf4jF8cCVxRfaj+V80RhmIDiPllDsk?= =?us-ascii?Q?SN0Pc2e267VD7EJAqjjTwtbhlKPMzZiTL1izYN+HGmFk2pSTRbivLJ++lyOG?= =?us-ascii?Q?fKE561TT2DzeW98Az7qCF5MdV6X169f6XAe2DZtta6SFyKRuDRgv2lruSxwe?= =?us-ascii?Q?yHZq8i9ELhuUjLHTnvhGUU+yfQMs9arY7nqbEGMjMbEcA1w9bVi/P9xlbGyH?= =?us-ascii?Q?+1WuymkMtIUODbI03FUpx2Kxg+swxUa3ET+gmky+lY4txpsVV5+MFIS1QmZG?= =?us-ascii?Q?CKuOPmYdmFEjAtFTKScCeusmsBcHm2s=3D?= X-Exchange-RoutingPolicyChecked: BOV52+Ef5mPKmsfVsddPlPQoD0vA4Jlyjt8vRX6R5X0AAGQspMpiujCyZCB1pD160S2uE0oZj1lRt2wGkM93QWS/P2/0T+PzE+wwWRYTQq+IgVXPlXhz/MG8P5pcZ2KhNz4Dy51HY/Q8tnex2g1fmidm9dbOQU4LY9GTupzlUou6nZEFHZmnqd4oSJLnMcxj7RiYP5WdKVZu6DexRWWmqd6Jxk6apPbAu65+k6Cwg6k/oL0sO8ydQcUxMvfA6llzXqMrDrStJdU4QNdowUJzD7ODYecKAItMlCFYsbQL+T4cumIYPCW4zgETvSaRTU0XizXodbQLB7nZ1fj9484WSQ== X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: fef8331e-162c-48f7-de1c-08df13dfa30e X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Sep 2026 10:45:34.7302 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: iZqr55UeLIFu2ny3nlzEnvDyJnfmkOw9xsbG3rUve3xdBpZKcsyNyeJ6pf0ieA1xxC8ig9XnMu/0n0RxSV/bzD/4Nj3AQ9YZFYDE45d4ga4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PHXPR02MB11343 X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE2MDE0MSBTYWx0ZWRfX6ZuAEDy4+gw4 6z3p6hJ6iApxnrjMHFCYTc/+E6DZwvEJEeeSf37UZQVilruLMZ8LPKRrIUMm0lKZWXtFl74jrnB PDzfWcIXxsMC5J1ZNZ92BD+rxp2O/QI= X-Proofpoint-ORIG-GUID: UavbkyGv_febwgguLzMk2PySixRf5kvn X-Proofpoint-GUID: UavbkyGv_febwgguLzMk2PySixRf5kvn X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE2MDE0MSBTYWx0ZWRfXyA6sM3JL0Tm7 rISwHFx3lPHdVE9kmIZlQ4xRXeoFf8nT4ghrkzF8EGfIE8Js5RaJS95ZBqO1ql0HdCNgcf3yp49 OoxyensCSKXcVekicdPPO/uhyZz57dYd3I8DzeEbCMadNAjYzdGzvJrmcSwxiUD+2vSEn4ASz2C wuSAYmfqvlZQuUqO1wSJ/++VA7JpPZyQ+KJzV5VRBidmmaI58Dn2nKVb+bxw7UwaAw6K3CGrFed dRvsVPtmtSDziaAYTSovVDyzqVyTmibwNbJm82R6Z6ZzTekbEXDivJWzzP00WGOjr3JZUhTGDrM fsmKxPtyPmsmn3Q4h9VK/yuKk4WaqdevAWEUuVTw4kiGzrFF1KDpFiVmVVKbn2eMiJab1OUuggt 9VAwdsyaXhHis9H0N9WS0i689FMaRoUr8Skdw1J5Wy+lc5qdMVBiraT0OVXzRAmCEEuZsEkEYt0 GrZ1kepKllJf5nFdqtg== X-Authority-Analysis: v=2.4 cv=QYvzLcbv c=1 sm=1 tr=0 ts=6aaa734f cx=c_pps a=PwPAvtB/AbIKdmTKg7In6w==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=xqWC_Br6kY4A:10 a=VdqzKS8jKosA:10 a=0kUYKlekyDsA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VofLwUrZ8Iiv6rRUPXIb:22 a=0LlEyIVc8U2lsR7dKhuH:22 a=64Cc0HZtAAAA:8 a=ufYRZG4kn_nPcl-B8swA:9 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-15_05,2026-09-15_02,2025-10-01_01 X-Proofpoint-Spam-Reason: safe X-purgate-ID: tlsNG-720697/1789555540-F3EBB2AC-88B84B65/0/0 X-purgate-type: clean X-purgate-size: 2197 X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1789555575010158500 Content-Type: text/plain; charset="utf-8" This clarifies that the interrupt controller being modelled is an emulated i8259 implementation, and brings the naming convention in line with the in-built i8259 and KVM i8259 implementations. Signed-off-by: Mark Cave-Ayland --- include/hw/xen/xen.h | 2 +- hw/i386/pc.c | 2 +- hw/i386/xen/xen-hvm.c | 2 +- stubs/xen-hw-stub.c | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/include/hw/xen/xen.h b/include/hw/xen/xen.h index e94c6e5a31..ee4ed4f11b 100644 --- a/include/hw/xen/xen.h +++ b/include/hw/xen/xen.h @@ -42,7 +42,7 @@ void xen_intx_set_irq(void *opaque, int irq_num, int leve= l); void xen_hvm_inject_msi(uint64_t addr, uint32_t data); int xen_is_pirq_msi(uint32_t msi_data); =20 -qemu_irq *xen_interrupt_controller_init(void); +qemu_irq *xen_i8259_init(void); =20 void xen_register_framebuffer(struct MemoryRegion *mr); =20 diff --git a/hw/i386/pc.c b/hw/i386/pc.c index 9006e7c29e..4ad6b81816 100644 --- a/hw/i386/pc.c +++ b/hw/i386/pc.c @@ -1169,7 +1169,7 @@ void pc_i8259_create(ISABus *isa_bus, qemu_irq *i8259= _irqs) if (kvm_pic_in_kernel()) { i8259 =3D kvm_i8259_init(isa_bus); } else if (xen_enabled()) { - i8259 =3D xen_interrupt_controller_init(); + i8259 =3D xen_i8259_init(); } else { i8259 =3D i8259_init(isa_bus, x86_allocate_cpu_irq()); } diff --git a/hw/i386/xen/xen-hvm.c b/hw/i386/xen/xen-hvm.c index d3ce082e07..af3a90987c 100644 --- a/hw/i386/xen/xen-hvm.c +++ b/hw/i386/xen/xen-hvm.c @@ -112,7 +112,7 @@ static void xen_set_irq(void *opaque, int irq, int leve= l) xen_set_isa_irq_level(xen_domid, irq, level); } =20 -qemu_irq *xen_interrupt_controller_init(void) +qemu_irq *xen_i8259_init(void) { return qemu_allocate_irqs(xen_set_irq, NULL, 16); } diff --git a/stubs/xen-hw-stub.c b/stubs/xen-hw-stub.c index 6cf0e9a4c1..b3e27f0292 100644 --- a/stubs/xen-hw-stub.c +++ b/stubs/xen-hw-stub.c @@ -29,7 +29,7 @@ int xen_is_pirq_msi(uint32_t msi_data) return 0; } =20 -qemu_irq *xen_interrupt_controller_init(void) +qemu_irq *xen_i8259_init(void) { return NULL; } --=20 2.43.0 From nobody Thu Sep 24 19:04:36 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1789555561; cv=pass; d=zohomail.com; s=zohoarc; b=df3108SmTM5p45bUemzJitRlhtafpxtVAr5wILGQQj0Oz9FgAkQP11iZPtY0UMPWvS/8VCQpJ8MimoGvmwZPgVrgRYILf43L8XRo9Hn3xGbwCDXMH5jKIQI5elg28t/rnDyhlZVuf8DcH6DiaAvV17MRthT1bGQYlIOiYyAFm5Y= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1789555561; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=AbKFGCy6bi6Di+SjRTibND8oFXMooQqZd57pXAx9Hzs=; b=fmH9wQXd/h3AU3L1Yx5ZGJgDOGEaMZQVCCJXCqLvICSQ2uO6AXlkg10mfS8LnMDR6k6U8+CWuVTA1nGVu/EnZ/qJFW2sfEQg37mW/GABHAQktEF3tQPxqpSqsgvkJ8zODOI0fmxXrbxMP4uad+yL/mLphVLa1P5G6l8UuGijz7M= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1789555561058914.5784030691276; Wed, 16 Sep 2026 03:46:01 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1422643.1648055 (Exim 4.92) (envelope-from ) id 1x6n99-0008MJ-8U; Wed, 16 Sep 2026 10:45:47 +0000 Received: by outflank-mailman (output) from mailman id 1422643.1648055; Wed, 16 Sep 2026 10:45:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1x6n99-0008M8-4z; Wed, 16 Sep 2026 10:45:47 +0000 Received: by outflank-mailman (input) for mailman id 1422643; Wed, 16 Sep 2026 10:45:45 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1x6n97-0008Gm-Gn for xen-devel@lists.xenproject.org; Wed, 16 Sep 2026 10:45:45 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1x6n96-00GzGj-TD for xen-devel@lists.xenproject.org; Wed, 16 Sep 2026 12:45:44 +0200 Received: from [10.42.69.9] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6aaa7352-8faa-0a2a0a5109dd-0a2a4509ca8c-18 for ; Wed, 16 Sep 2026 12:45:44 +0200 Received: from [148.163.151.68] (helo=mx0a-002c1b01.pphosted.com) by tlsNG-bad1c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6aaa7357-be1a-0a2a45090019-94a3974463bc-3 for ; Wed, 16 Sep 2026 12:45:44 +0200 Received: from pps.filterd (m0127839.ppops.net [127.0.0.1]) by mx0a-002c1b01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68G8q4Uj541814; Wed, 16 Sep 2026 03:45:40 -0700 Received: from sn4pr0501cu005.outbound.protection.outlook.com (mail-southcentralusazon11021127.outbound.protection.outlook.com [40.93.194.127]) by mx0a-002c1b01.pphosted.com (PPS) with ESMTPS id 4gqa0pta0w-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 16 Sep 2026 03:45:39 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by PHXPR02MB11343.namprd02.prod.outlook.com (2603:10b6:510:3cc::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.428.9; Wed, 16 Sep 2026 10:45:38 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::8e97:bc32:822c:b250]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::8e97:bc32:822c:b250%3]) with mapi id 15.21.0406.007; Wed, 16 Sep 2026 10:45:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=proofpoint20171006 header.d=nutanix.com header.i="@nutanix.com" header.h="Content-Transfer-Encoding:Content-Type:Date:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To"; dkim=pass header.s=selector1 header.d=nutanix.com header.i="@nutanix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=AbKFGCy6bi6Di+SjRTibND8oFXMooQqZd57pXAx9H zs=; b=uyIAmcAkKaOGiJoy49/ZvMWPUEUi9/DNBahKbyG4sVR4UYJeIyxhP7+Op gcSsnyEV21n7pZUdWoannDO4ppcMd28d8hgwf8gMb2kexjTLuBjS/KXwkz9//oBL 2DOM7uQ+Ih5oKdPAYeGlmVIq/zloXo2n5xoulQ5KsFN1tGdSp9jRpS1SoWP94G3f oWav7DRvROr4OJBImJ/+wboQ85h0pH8HwOKiysDN/NE4xuEj+I1M5j6gi0IY3//z M/Ykk4lXG6WqA5g6/lyQLTSngp+vmah06/KmHypKJuitdleEdPVTXpZV4enPsS6i Q36B1J/9svGkTFnFPk2qtlJzDbyyg== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=fC8njwabtF4WW6oAlHmE6sMMIJpA0dBudFJAanFXdYmrc8Kfa3io3ClSdBrWrT3Kecu5V0cPi+/7BJDLm8z9PbOnrRNQf6T7+KlOX+d4voqwxfhgR6akp3wkdih36vyjHPElzqOPlhkW+6pTcbK0AcVPik94Cws8Ud56LqDJbaMhAV9A7vW9mKq0zvIaxiToyiRY0n+0gyHQqkT+1NofrguFnE45XmO1SiPoUg9lMcj8wpHlloS+SQkRhkdGjnn1SYy/i7rDq91Rfm7WtH+FEZ8rExKVzNwe4ru6NeZj6Zms015Qgx3GcAeQhe/D7A4f1uMRnsJhqe2TSsrA836FuQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AbKFGCy6bi6Di+SjRTibND8oFXMooQqZd57pXAx9Hzs=; b=lyNc5psA0/ML8NuC4mOw9UpBHfCTsY8CUTp+fcut1L048BfFqghcb+tGslezWQS3lT749FnLbbiBVFM+1QTht1p4ZGATnXLCXVCF0BCzhYpytJeC4jK3ezzjgWdsGBjXRlBEQfiOiWVw5OAW1sMi6qTDjmSD6bauDj1WXGR9jnAmjoSub95lo46OJYkFRRa56rjNX4QXvsgrDpj09Sqpby7FCKCbm+G8jNRuomzWbEEBHlS8V716laZAwhHD8xJJfX3bxFnSLFYZjA32Sx3TDLkFRQGrvlemfKZY65xnnwusqDu1AdH1q1w52P/JW3zDEIbWKg3FuADjPZH3QEm/Tg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AbKFGCy6bi6Di+SjRTibND8oFXMooQqZd57pXAx9Hzs=; b=EPDwXfHj1u1wb5qe4hSwzniOHQcC/8H0SCTbpnkp0GEN7MySDXvBddZl2blgaRsUj0Hvk/sAyWLmlkiKs6nmtoPwlnwDO+1D5Dgztw7n4rK9UsqmgV2+9/tFwVz+7Qs+X/e3r0c0yBNJYpCpxujkXs39To+o3fu0gFZcOK3fTaYCtWZafqHQnEpPLhb12QQMBkgpOjM3Fl9PbS9r71+kzoGqRKzrJBUAKkKbUbtfhsDqj96oLw0N5Da3fDLBDfgFGUt/qAdiXjKPm+fMl51ql44ItkqFIaZrVX9rdmCLVb88yEAB+GzpN19S7XR3dDkSvrF5F6QuQjVI4oO5AfZ4Wg== From: Mark Cave-Ayland To: pbonzini@redhat.com, richard.henderson@linaro.org, mst@redhat.com, sstabellini@kernel.org, anthony@xenproject.org, edgar.iglesias@gmail.com, qemu-devel@nongnu.org, xen-devel@lists.xenproject.org Subject: [PATCH 17/22] xen/xen-hvm.c: introduce TYPE_XEN_I8259_PIC device Date: Wed, 16 Sep 2026 11:43:45 +0100 Message-ID: <20260916104435.600211-18-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260916104435.600211-1-mark.caveayland@nutanix.com> References: <20260916104435.600211-1-mark.caveayland@nutanix.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SJ0PR13CA0103.namprd13.prod.outlook.com (2603:10b6:a03:2c5::18) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|PHXPR02MB11343:EE_ X-MS-Office365-Filtering-Correlation-Id: edbc8c1b-417f-4626-04f5-08df13dfa551 x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|1800799024|23010399003|18002099003|3023799007|10067099003|56012099006|22082099003; X-Microsoft-Antispam-Message-Info: RTVu5x402l1nA3jWtBY7Nmah/Z/dPEI2ST5uemMPworGzeUjMHQpy26ZwVdZIpdwtzk9BWbWF5cWcUzZKR3c6bhIAEX2FonRXfFy6WDdSIzQPYmWBegeFV31H0+U7eaulKH1wyVnULt9yqcnD1OaQ8BXCgDS9CiCf55Vn8TkKp1az80AL1yslfa9QfKo7iR5wo54ilajOp+cnnxJcrmK+liNG8QkaRaDSe7I0XG60EK7HkUSpxfejk4AyevNce8j8YAqM1igiCuYASIm9y1dxf2WkFExmW9Reg1/HfDBRwyNM+21CSV/w2f5i+CuWEBZDNO//sdl+zuNeSrwlLNWY/NS9MP+biaFlkXQ9dXszNNiTldHC3NfcvsUHTjy4L0X3Pz5ArRUS1HIp5vWHEOuC+5DbRY9rHaS6HcPQtUdPq+6DKlHwSfqkv+QBQoY/OLiBHCwJc5xqJ/iNjvHyVElK6aBnFKypCmu5AbxSTqVmdObpgrn0hufzJ7PvgevtUztnF7l3Nq2Jb7c3gUi9lHJR5PUnrq5pXR4nwzOrkOFThoNVxHgJQ8ab8nkq56Pnn6FphYNA6mwODZBKbbijcu2WN7xjIX/HxXqjQnxysRYAwIU3pjaftpnaHivuyV2y4qyvHPyEBDOwQfmXTPcNA7eG1ZGrY6oAf9iD0NiiCtCJPo= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR02MB7159.namprd02.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(1800799024)(23010399003)(18002099003)(3023799007)(10067099003)(56012099006)(22082099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?spuzrXT7E2cc9NtkVcBKdwUTCWjMDbIYz0Q/srBm/eu+gqYaySzfSsGg3ngG?= =?us-ascii?Q?WauYFAWLu9FEZtAHyhDG6NHqyutHPhOTTKUVB75t8vq3ZPu+yzsO8fXAUdMz?= =?us-ascii?Q?7mW/IMK0rrDMMUB/Ey+Af5Y2HgtzVtvRsZ2/nvEM3RpMTtkSI5puuYPNGoxa?= =?us-ascii?Q?st1F53jt/vhJUTuA69cUQ9O2/bTBFqtRBg4l6WWmU9PemQ3DRO1N7AV9muxE?= =?us-ascii?Q?dijx7XhQS3X1tBJbo4m8dsZdjKFbsgVgyfLLsHCJCB68fPezZN8pkrl08exe?= =?us-ascii?Q?LbDN7S1jpAIZbVQR26qJw3/y5yIaYTK7dZdpk9hXRUC0geyehjAD1zbvhfHt?= =?us-ascii?Q?0Html/MvJCEAABJIe5xYHsRekF2g/bnXByjvxOJKaheQiUmaBLUm3K1JfVOo?= =?us-ascii?Q?Ssc6CpeL0YyLYXF1E6nQjxGVTLvN7uMJHtqSqRvK5wdNMTxTogy6ctPPO0jP?= =?us-ascii?Q?q8/EcWsyde/RAmtK/DedgHAvajkATIJ3zbXjQcSVPPUFnQXEX6vVA4KqYVKr?= =?us-ascii?Q?U0v3lKX+qoIfRacrKaqHMpKKC1ZI0nFw+wn//5RW58wAfGloD2nxRXXrzncE?= =?us-ascii?Q?zi02go0Am7nD4QRRy3P8V60y4AskWOK1AYbtS3BlVMmnJ9usnCOTM/xzu/Jk?= =?us-ascii?Q?uB2tRakGGHaXoMT0OJm7vXgtpT/JHIGnICicF3SzFz5V79QXqClNwrx5aVpz?= =?us-ascii?Q?jISPFuNBcV2SlA7QVlZErdaiviQU3um3DJO+GwK5g7ib5Tk7pzDpYoRBw45Q?= =?us-ascii?Q?z0ia8L6K5bZHnFt3t+ogLB43mDtKnRwwj0sNuu2Q5TzHJ5sXJwBeY5cpsr7Y?= =?us-ascii?Q?OKUICW4ovksu61SJ9X5wdx4q0tplrJf2CHdRCfSCrD05FISqO1Zsp9Amkv6a?= =?us-ascii?Q?VMp6NVbBsH9Dx/A9+8ho5EE98x6iIi3i61qilsKn4Bh6Q12R5gOBdg5QPZ6d?= =?us-ascii?Q?ivWy2dHe7WGfKFL3oReiYbPOvYrHTLsGxwbv1h20WVu5Nr6KfqrxyRPcq4rr?= =?us-ascii?Q?l12HRlmhGHyFcwubgSED2kCakIK7OgqJIhVYvNUghuPSHKXzR756BOgxIbd7?= =?us-ascii?Q?m0u4+SifS23YOeaThqZXvpObE4FitmYbqVIBlmE5Z1gUEiK3oGXevzjFfAO3?= =?us-ascii?Q?ZoTJjCN49gk5PXrSzaG1GoNsWY+BlYzeDJQY8XQISrzdBuSulWDkDg09daoP?= =?us-ascii?Q?NONDKM+gSNerkcNMg+fEZudPPIMC+M1KgYr7DrPLMQlzK9R4C9Mwq66cgQpI?= =?us-ascii?Q?bhn6i1l2Aq66kngzE/ZuNcfdxWrVR4+xVYCh4IlPQqRMnacuVtS54vNqFbWU?= =?us-ascii?Q?S1Fw8DVRE44yrtlWUaOgqT9+HLi2dd4Z9V4IpaH8MiPzmqSvOzkkX9U5VvNK?= =?us-ascii?Q?wi1IG/Dkb7KSEDHmFAcbb37s/nbmzdWyUwUd2+HDDitb8Avt46VwnpEMFFzG?= =?us-ascii?Q?QBSgvRw3QO0nxpVczsrRYJXrq/a4p7DL6WEHDXdge28910+DmzcsfVsh8EsM?= =?us-ascii?Q?VNS6xlZpROOnFhDkj1p/ROtatKSEHTGpJYAIttNoqs2D/A0HSaH4mKhaJX2t?= =?us-ascii?Q?Q3AAKlN6aF5AgDBUnnFp8ECG1Dom3oVMPTt7SVAjNw0rn134px5GNjwrkaG7?= =?us-ascii?Q?Vc2s1hynP0l01+oJlzpwMi1cyrtzS+qpcpdHkhkp10OIRqIxQSpx3Sf2pwuD?= =?us-ascii?Q?YZYtl0vpSsq6LM66ytl2WdIO4ewVKtKZR77mBJSAbGDGqjnM0xGHKNEauIh7?= =?us-ascii?Q?DZGlpmCOt99NkdPrQRk893MlmdIG8O8=3D?= X-Exchange-RoutingPolicyChecked: gwBL1mSHqLxeX6dgLLLCY4OEW0iqlotCK4tGRGPdvfXt34IH70MXyO8X3hNLs+Tg8uoyJnHzzz754WqxJciczpNGNfmJPg57zrt2HYS8roSKOFQUH8mP5loCALBd+IKmG78HNBPzPvIZivV9HkTAKRi/SCkF+1oyIaFoJyqf9DWk3sV/jfIqUhM5ZRBO5giMCXfEJ/SQTpmJk7vX0ra3cBlDs5LZAhRa/FmOiWiT9FE6pcpCHlD5nNyqdxIzUGQK3umPdY4RFWRVmCXtt6g10NAEXXfgE7MH3mTQz2rkSalxXXRdiX691a39K2bglIhuTw+/xCttZImkLJhEOciFGw== X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: edbc8c1b-417f-4626-04f5-08df13dfa551 X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Sep 2026 10:45:38.4780 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 71lYsmtJ4F6NRmrK9fPw78CywHNLZ8kQnamSSJHlc5nXTp/7tEd9A4fUEiszuB/vpCmOGCsD5YYfxa+LvcHBWu4qP3oRtDXRgXByr+Lh4Js= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PHXPR02MB11343 X-Proofpoint-GUID: 2c5Iupx0Z644kjYl4UWSkPZIK8rJyrIo X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE2MDE0MSBTYWx0ZWRfX5OGqPFMkD++J Xa5IM6lVjCseNHyDdroiKWarjk0OM2xcl6SIGRHjaxxyMh9EjnqerVKYwQeS5tb4wDjilTcRJI5 +Lrcu0bLpWhh4JU2WKke3yu2QAsy67k= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE2MDE0MSBTYWx0ZWRfXw60ffdmqlbog qY4qr+LORPFKLiebn8rz9iZ+T2QPCgKRbLP8b6x+N8RMpZCCu+t5CtD68VqsPs0cJIXGXJBbBCJ 8/D23at/y/SldsLA1YBXmUEauSdf5B8WvTplyaAu19O3W2jfPmU96dTGsvTrbAGrwbX9vq7ykFo jXvRwG/OC+UfT9FhpkHztfZYY61tZ/RG4jLxoLstRkjNNHkNqHBm8lD7cam45kJXXjb6QsIzy/f pu+uSYQ5HnZ+e81dKhV/+r8qJrh45YQI++RA7JgizgXv+muH2DxvQJc6rZtcL7cgmZR3Ydv9HG4 dYp0jVXqhQASCWrdejD1PvJS+297GEFwCrerRRPEfCuP/4uC6EJJERMWRVdjnKCXX13hsiKyPM0 Eb4hx6ybH1ztZU7iNqrBSGG9SBuhFCfjlntlUiJtvi1QwhtJGOV6vC14uV/Tjs4ZVgiJmlGH4Gx HBjbPbHS92P3HIH4omw== X-Proofpoint-ORIG-GUID: 2c5Iupx0Z644kjYl4UWSkPZIK8rJyrIo X-Authority-Analysis: v=2.4 cv=Ps4G/AM3 c=1 sm=1 tr=0 ts=6aaa7353 cx=c_pps a=wuCIV2M2hcCPwYkL8T+rjw==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=xqWC_Br6kY4A:10 a=VdqzKS8jKosA:10 a=0kUYKlekyDsA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VofLwUrZ8Iiv6rRUPXIb:22 a=y4UcunY2MAxhM4LwGdWI:22 a=64Cc0HZtAAAA:8 a=tqVLSPGIGyqkaOPIRdYA:9 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-15_05,2026-09-15_02,2025-10-01_01 X-Proofpoint-Spam-Reason: safe X-purgate-ID: tlsNG-bad1c0/1789555544-3AEDE034-34FA9205/0/0 X-purgate-type: clean X-purgate-size: 2075 X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1789555562986158500 Content-Type: text/plain; charset="utf-8" This device represents the Xen PIC for an x86 machine. Signed-off-by: Mark Cave-Ayland --- hw/i386/xen/xen-hvm.c | 38 +++++++++++++++++++++++++++++++++++++- 1 file changed, 37 insertions(+), 1 deletion(-) diff --git a/hw/i386/xen/xen-hvm.c b/hw/i386/xen/xen-hvm.c index af3a90987c..b2378fe3f0 100644 --- a/hw/i386/xen/xen-hvm.c +++ b/hw/i386/xen/xen-hvm.c @@ -13,6 +13,7 @@ #include "qemu/error-report.h" #include "qapi/error.h" #include "qapi/qapi-commands-migration.h" +#include "qom/object.h" #include "trace.h" =20 #include "hw/core/hw-error.h" @@ -69,6 +70,12 @@ static unsigned long *dirty_bitmap; static Notifier suspend; static Notifier wakeup; =20 +#define TYPE_XEN_I8259_PIC "xen-i8259-pic" + +DECLARE_OBJ_CHECKERS(DeviceState, DeviceClass, XEN_I8259_PIC, + TYPE_XEN_I8259_PIC) + + /* Xen specific function for piix pci */ =20 int xen_pci_slot_get_pirq(PCIDevice *pci_dev, int irq_num) @@ -114,9 +121,28 @@ static void xen_set_irq(void *opaque, int irq, int lev= el) =20 qemu_irq *xen_i8259_init(void) { - return qemu_allocate_irqs(xen_set_irq, NULL, 16); + qemu_irq *irq_set; + DeviceState *dev; + int i; + + irq_set =3D g_new0(qemu_irq, 16); + + dev =3D qdev_new(TYPE_XEN_I8259_PIC); + qdev_realize_and_unref(dev, NULL, &error_fatal); + + for (i =3D 0 ; i < 16; i++) { + irq_set[i] =3D qdev_get_gpio_in(dev, i); + } + + return irq_set; } =20 +static void xen_i8259_pic_init(Object *obj) +{ + qdev_init_gpio_in(DEVICE(obj), xen_set_irq, 16); +} + + /* Memory Ops */ =20 static void xen_ram_init(PCMachineState *pcms, @@ -760,3 +786,13 @@ void arch_handle_ioreq(XenIOState *state, ioreq_t *req) hw_error("Invalid ioreq type 0x%x\n", req->type); } } + +static const TypeInfo xen_i8259_type_infos[] =3D { + { + .name =3D TYPE_XEN_I8259_PIC, + .parent =3D TYPE_DEVICE, + .instance_init =3D xen_i8259_pic_init, + }, +}; + +DEFINE_TYPES(xen_i8259_type_infos) --=20 2.43.0 From nobody Thu Sep 24 19:04:36 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1789555568; cv=pass; d=zohomail.com; s=zohoarc; b=Yp0HRKnHzUUHquVHC9ZvooHOpq3Jn8dGGUQuJ37ilIPOiRbSuwGjNf2zWkX2L+7thcheF0DOZOr03D/QwUcH664wI7WVQDUU6wQt784nrkVMb1saHuKVxQrR6vkBZiQEPwZE8WNJE0LKujl02ov8YZXq2zI8UdWMc1IdhNodRCI= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1789555568; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=CVzucpNfOsd45ZWBehwp5Jyz8xROMk2RY6hnw2IeO3w=; b=JWIPmP/C3S3jF/bCXy7U4WDO7KKnJpTgqiMIFpihYWdVHnrhk2GdZfy8sd48SfVOmOY/TLZJ26gyisQJXZ+Ei9se+mZ7hjxzDMNhqrYawSuIF0A+e0ePEj7idXsovOzNUEblzNcvC5f4GKIMIIuofsdNTpk/ZZok0I0wKNnvZwA= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1789555568035383.0888173449546; Wed, 16 Sep 2026 03:46:08 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1422648.1648074 (Exim 4.92) (envelope-from ) id 1x6n9C-0000Yb-B2; Wed, 16 Sep 2026 10:45:50 +0000 Received: by outflank-mailman (output) from mailman id 1422648.1648074; Wed, 16 Sep 2026 10:45:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1x6n9C-0000Y3-1K; Wed, 16 Sep 2026 10:45:50 +0000 Received: by outflank-mailman (input) for mailman id 1422648; Wed, 16 Sep 2026 10:45:49 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1x6n9A-0000C6-RA for xen-devel@lists.xenproject.org; Wed, 16 Sep 2026 10:45:48 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1x6n9A-007b5t-78 for xen-devel@lists.xenproject.org; Wed, 16 Sep 2026 12:45:48 +0200 Received: from [10.42.69.4] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6aaa7356-bab6-0a2a0a5309dd-0a2a4504a75c-4 for ; Wed, 16 Sep 2026 12:45:48 +0200 Received: from [148.163.151.68] (helo=mx0a-002c1b01.pphosted.com) by tlsNG-ebf023.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6aaa735a-b57f-0a2a45040019-94a397449eb0-3 for ; Wed, 16 Sep 2026 12:45:47 +0200 Received: from pps.filterd (m0127840.ppops.net [127.0.0.1]) by mx0a-002c1b01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68G8i7xW353641; Wed, 16 Sep 2026 03:45:43 -0700 Received: from sn4pr0501cu005.outbound.protection.outlook.com (mail-southcentralusazon11021132.outbound.protection.outlook.com [40.93.194.132]) by mx0a-002c1b01.pphosted.com (PPS) with ESMTPS id 4gq9drte7e-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 16 Sep 2026 03:45:43 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by PHXPR02MB11343.namprd02.prod.outlook.com (2603:10b6:510:3cc::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.428.9; Wed, 16 Sep 2026 10:45:42 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::8e97:bc32:822c:b250]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::8e97:bc32:822c:b250%3]) with mapi id 15.21.0406.007; Wed, 16 Sep 2026 10:45:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=proofpoint20171006 header.d=nutanix.com header.i="@nutanix.com" header.h="Content-Transfer-Encoding:Content-Type:Date:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To"; dkim=pass header.s=selector1 header.d=nutanix.com header.i="@nutanix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=CVzucpNfOsd45ZWBehwp5Jyz8xROMk2RY6hnw2IeO 3w=; b=eqlHxThBwdbt0dsXsG+Zh+BQVviFsN/bpnm4KDjhfc3zjz8mSNCkxIzqN PbDdPZEm8X+UCoHT6aQX6IcteY3bVqqtxd0i5FlR8JFT2BCSvSfVRoXutShZ6nEN Kl7yuI/H33OSJHIyxaoV/wV5nc3g0ovfJEeUzUi61V342rpHnI877E9Eey9AqXhd qe22EBY8eKeRPtLjvLssxEmdVlqH3QY0wnWkGU6winqcDrvbD/Bqsq8MQ6kTLc3u c5qH72bsPnyVOk7BFjUSJM2Y7/PLWuMN3audCxSOj9u9TUj5RwVme82V0QCRbhEj TimAtZ7RBAM+mxeZ8LOpOr0A6cGoA== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Ft3EhXjbGPe6426enODVOjnTr/xChz3Rfi8srPexCaVXvlOaoCK0U+EL1w4rqYY8pj1nuhAb9sFRXESHgeowvdVrEKffWcHQb5pZkaLNq49y4A7aFIF5SBV0N9UGmSkfdPAfispEhjiKIgOI5X8GwsfHyOMI7CKJ42nWIWprOUOOXBLpDT74cMpfuNM1n9fIs+xpDXrBBultK2Ha2x0AmEMJqBPZNZw/GhAC9z24Fc0liMp0bzL3Uezs7+dAO2XB+WrKK6xBpgejp2hUuYAjwwFW5N/80RoDPzZFaiQJR5GVMbqLlpqFTETnqr4IEsl9iespO+haSAxNZhHMbLNylA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CVzucpNfOsd45ZWBehwp5Jyz8xROMk2RY6hnw2IeO3w=; b=jMzdcyW2qkNY+r1P8qLJmbL8ufq+rMNCN3GAThZ/yDSW1Eq1AIhn8EXHaf+kHvTVon3ZUzZLgtfk/LgGDAKcBJMSWkZS1USl6KrWbpVbODNXtYjFBUaUhHsUXLQmrerjRf52VlUlacERzvhHMI1oH4PzijydiF+qXMbGOHrACCt3vPYAH7QRwwMwo4xpQjsy7krpMCjB7jC8tqNf9GRL57SVScdYdYFPveEoCEt0bQWNJa8CVvFXFnMC+MrTPeNYrFBmGB6Giob9/AZBTkPQ9yWKDmEy4svCg4jH9npDsGdmhqv931irurSxBZ/K4/8mY+VMooJyrMzYTcBZEaznCQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CVzucpNfOsd45ZWBehwp5Jyz8xROMk2RY6hnw2IeO3w=; b=LlvGyLg8+dWh68mocmH/mnfWSThgE0S+NHwAfsAbOja+N902MR7xTQzP9+TmaYUwCrbrTwwULGpM9PckXzhBLJYcPBIoZHab3yrjGgqkpzrNt7wUf4DtjhLOJBb/zVsmPmmjQhQLQEVZ7s7qzQW8Vmvl9II4HKodC8xW6XyodCi6ELz+yKW9flaRzPhzTOFfXW9npNcb8dqTELVS1NajKY6WXRiQGg/MvZwm8kaDHFyBEzPqOwPJNCJmAOwGxbFuS3rR9HzUTG8mCPHfLadxNFZtfSRdYH8Xv4x8EHLwPnfcEjuNaABoez+LKzbSpUaDWkXdTilFKCTpsa86v3Ui2w== From: Mark Cave-Ayland To: pbonzini@redhat.com, richard.henderson@linaro.org, mst@redhat.com, sstabellini@kernel.org, anthony@xenproject.org, edgar.iglesias@gmail.com, qemu-devel@nongnu.org, xen-devel@lists.xenproject.org Subject: [PATCH 18/22] i8259_common.c: remove unused i8259_init_chip() function Date: Wed, 16 Sep 2026 11:43:46 +0100 Message-ID: <20260916104435.600211-19-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260916104435.600211-1-mark.caveayland@nutanix.com> References: <20260916104435.600211-1-mark.caveayland@nutanix.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SJ0PR13CA0095.namprd13.prod.outlook.com (2603:10b6:a03:2c5::10) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|PHXPR02MB11343:EE_ X-MS-Office365-Filtering-Correlation-Id: a5f07026-3969-4637-0487-08df13dfa76d x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|1800799024|23010399003|18002099003|10067099003|56012099006|22082099003; X-Microsoft-Antispam-Message-Info: nWFSEh+wjfS9xTxhUHJZmZXI9vckJ/ffqTXv2IDdEaIwwyAnB8v77gGKPfrNd2iLQt5wIg08X8+33xQo4iXPENXORR1j3voPc6gn1BD3qQN0af3eaiDo4m3oQuc3RXEhyTOAPaeeDfKyqU2Q1QlILRmBwChS4sNBkp+74qo/VNXTXttXqanZa+7hV/XytnHDwk6QDAaE2+13f4Zh7/r7a2FGJOJ9Kb9eehM9FhPk/vbJXJ4eNJyGRXp5TMzmZFkmdbFdmzWtvlPMxTDFSHZo2A/v/tZFWRk+G592HdU3i3Fx2aruJdBbKs8zvlMoaG6tJmniOh4ofH47k+n9lDnfblZWanWsJrTV6H0w3AVfkPg5CG6ttm8W5lfSlIs64bh/MXFlQcWKBc/g9nDCF8UzhXFWQPXaMS+4MbgeHME/tjB63LDBYC3AOrTgusjfnF/wMgSLTkxcbAdESzl+i+2zJMZF6oPLqW6635/wtP9C0gpWUlH/H+yydrkCxvqgpEgkExq4BnE0xx4OPqcrl2qzVX8WgQ2ZomTMS054o4fG2I8e0VEKyyCN8Vzh1M976f7QLA22DnOQdK2C9HFQABCv7Wz0JZ//grLI9Nh01CcmYSOwZR46oN3fSOq/szFXctgemPMyvLKN/sKpLy8+dA2tDrJ3X/Zu1rmibba7iZ5fyGw= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR02MB7159.namprd02.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(1800799024)(23010399003)(18002099003)(10067099003)(56012099006)(22082099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?xqaaYB5G5dEIfMvaLJ8Ma9IONtiEHSU62+8gjaY415EE5Y+vckV3+weBzzRq?= =?us-ascii?Q?LfFIsC32UTleJzJ8ELuFXFoOEJoCpKd4MLO8p4vn6UoEY1w5q18iHckaWV1c?= =?us-ascii?Q?V3hq40LO0qVWI6EsKIXlV5AYMAt1XtkoJZJe/zUE8j2x6Ei5tLC4pFDjC4EU?= =?us-ascii?Q?qYxFPxy0FiSxvvZoFh0JzyuhxpOmZLS6krzhYtlKuOyvNGfqWxJ/2L1FWJi3?= =?us-ascii?Q?9WVFUnC+I28nBTwExOxp0468wZPmQQ7HC2FBq6MgcQ9Db6rDUdNPmQvvGiDF?= =?us-ascii?Q?HvvM/8xxGX706mdDXJ3BJv5uq4Fb9mZL8iGTlAjz+k3dliVHKgJjiALweARW?= =?us-ascii?Q?SoK+5/zmbUQ4V6fIHU4rymoovQ+w0/+RkwvYHerYH0WtiyutTwC0shycY2Am?= =?us-ascii?Q?MovNy60OniwaeQwnedeNTQvvM6cipTCstyJQewVRo7mU/2VfLfL5oa/cne7q?= =?us-ascii?Q?1ei4Xor/S2yZSxiXlVVhHo8VTkkrl1cWqxDu0n/cEwB/GgtMRSSC3fPFJ3hj?= =?us-ascii?Q?h3Mt9d5uz7spz6PHfgrAk98xqOcM3EwQ5ECEIoEbeSe7GFOHwZElgK9pLWV+?= =?us-ascii?Q?st9YJV/EDjE35YCZRLBMx+STUxuq5Dk702lTr3oHBme0ZDHPYo3bQOMmqcuS?= =?us-ascii?Q?nApyyzl6JdTgxEh68xF1it8IF6ajo5MHRl7/H6sXVt9jZSxh30u3SW3Fa14M?= =?us-ascii?Q?/OlU4JhOCnvCEssAY/kYQ8KW0Vnl3PGOw9ZId+MI1dNBFdsyX6WIjX2cr7LR?= =?us-ascii?Q?51AUEo2p3C9NKJ71H3+tyWaXR+zWB6FMFhQe1x/ouE8Kp4vPbHRbXRh/jrVY?= =?us-ascii?Q?bqTh4Rg70bhG8zLcDksqiox9uofqa3w6WPhfmwTuEiN1PCg3COI+aDVUYZDD?= =?us-ascii?Q?Hz8wSMLnOWARuzHj7BPW1Sxeb/gV9uRsVNCIy2ileGwKE6WwR9fzU/ou5kiP?= =?us-ascii?Q?3jCJRAFFEtN4Iox7whKmaNSutyHQuBMGzC+xIt3kheN1f9K7HWBHNZ5ZTj2p?= =?us-ascii?Q?KVHruimnwBI1tr47l1v7Y+UJSAWvKeBHGJ7skJV5uZmM0H39OBsNWEjrJH1B?= =?us-ascii?Q?tKV4KWoz14iIZ3W3/OJBD52C4jW3yiXUz+gzG/JMYpGiC4IZTDhR1baiqJaQ?= =?us-ascii?Q?puI6qPze+RvyXc0A8bDgaudstsQyv57EBjdmPBRPE3sLnRTBuMfvDpUzsq84?= =?us-ascii?Q?6l/nxds7ALjN5x2td3EnaIHvWBYwt1XGrEYhCEn92JQEkOlundiCf9jMO0mb?= =?us-ascii?Q?a0NqIeDJi63nqX+ONio54Zb193H9hGOHX1j3Tge58OPaueHfwfzFgme/PgDs?= =?us-ascii?Q?PT/cIlfgoUeP5EdQBNotKvBXmiuHfSAGhWHjxrJf5VMDkd+NIoLUujFfMFJL?= =?us-ascii?Q?5dwkrnQZ28KVEK1Oex9zPVE5KkA/P9VsvuJlIG2XVuM0V3Q1jGjHMfeUWhRZ?= =?us-ascii?Q?zHOfRJ1ukM2rK4KOHbBCucGFxSc919nkv9EVmFc+jK1P0SJ95dsmNRl8QQhI?= =?us-ascii?Q?egxXIr+H25Mh8bdr9DnN4dq2LaNOOz/uWpTN0utUSSD/qmzwnc2zwEIW0cEY?= =?us-ascii?Q?fZgsibwOPUgryo5KNT7RGXByXbJhgQ66A+0g0+BUxyegVwZnegvkgDJthZxE?= =?us-ascii?Q?wxtC1V7NiFoJt60XG1Vqbpo97j6MMZIrwSR0+ZFupKC7BTcDbL05O8U5I++z?= =?us-ascii?Q?bX33dS/JGAUhOjSfpdSQgjm8+wb9Q0pI7HUDim781hnUKUmG8M6bziURyMor?= =?us-ascii?Q?pLETKZ4M67xMa6aGCbSv+Igvu+HL9XY=3D?= X-Exchange-RoutingPolicyChecked: GxPX6SCW9Cx5S8NQQAYvNpZxBnz93myhLerMer4aX6/0PtFRs68rZ1oX41jm5iatqm0vx8vlHQsRH0cFyaHh7XS9/wvwu2IOa5ChVvOChkU7OH9YL5zVD4UI1yU0kPJlb0LuSRT0QlffIPVIP+LGQQ3jWZmCgmX0fLiGEnQokZRJfuZwwJMYV+k4TXSSwO+NJX4MEBayszV9GXpyIoKML1tDcMA1+llJhZlDQy3M6PpecQkPkXCAsyVOO0uFNIP2PUdm363C7lMSoCxO8ttLBEHFB5w9OowVD3QZgYyElZ2p1I9IovebbLEiR/pA1foAyb7wa/l9G27tvT+v7f286A== X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: a5f07026-3969-4637-0487-08df13dfa76d X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Sep 2026 10:45:41.9344 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: EKIf7ThANs9prk6b6tofJiZCRA9/GWvhtMqiGQh6711F55QPb9UfIJrJMfzP7xxOj9R1eisCJonivRP17jSGC3eV6L4yKrv4RXvy/lXRRoo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PHXPR02MB11343 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE2MDE0MSBTYWx0ZWRfX0nHhkCfUIt3m jGuhlmbQ2ch1t7ETxdqpB6tPSUDftOEvImB84pzjNgSBKDmWGXsNk9Zo4RZn1sPS7V3jPWzVlIf A80YHaF9P+AbJBdgms40/RKEpcSaBoSR8PnZiMF6oPLSV26/YpQjJqW9b+7ErZ/d8thHJRWZUmz j818jK5XGsZA1gcQl7SbtNtXx2xB5BkzuRiRL5V/OapWsFgwIyf15ygL3CjPyVmDpB1w+Mw+vnW r/Ggy4PKcUVFsdyRvPC1aQ/DtpPfrkHAx1pwFfXkCDq8Hy3IO30DrJ8PdkA4wZXeWsLxNzEF7Ch Ca585ciTVd9gTsk3MV8HiqVJq4BgdIwDIkEIM8L25TKedeyUez5lZGUNeHGnJfROoYi8vSSAYt9 350C0VjIZT1c1NFGlhswByMIqgP/He84R+fVixtgRurmuCt+uDLYoJ+tkCayvq2Shur9S/kGpH7 4Bmsh6rWtlYcWhsJkZQ== X-Authority-Analysis: v=2.4 cv=XO2l2ghE c=1 sm=1 tr=0 ts=6aaa7357 cx=c_pps a=hMPBqNrkZiCD5Zgemr5n7Q==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=xqWC_Br6kY4A:10 a=VdqzKS8jKosA:10 a=0kUYKlekyDsA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VofLwUrZ8Iiv6rRUPXIb:22 a=_-M8LpHI31CeLmyZm6wg:22 a=64Cc0HZtAAAA:8 a=fn9E0C1quIHmE1dKZfwA:9 X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE2MDE0MSBTYWx0ZWRfXzorE31bLTvO/ 7vxAMLg3k1BjAklsDO3NSE/msdZDiDrNPgwjOgiaNia3wX+3gtKu2XHhmeW1/2Lq5645sDvIisW 4WbYoij/PfA+S5uGFLBeGUbP5FmMKdY= X-Proofpoint-ORIG-GUID: lr9dVMnoDwcinhadbufyLQ39wMlyeJQh X-Proofpoint-GUID: lr9dVMnoDwcinhadbufyLQ39wMlyeJQh X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-15_05,2026-09-15_02,2025-10-01_01 X-Proofpoint-Spam-Reason: safe X-purgate-ID: tlsNG-ebf023/1789555548-C0CDFB50-8AF3D9C3/0/0 X-purgate-type: clean X-purgate-size: 1647 X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1789555569003158500 Content-Type: text/plain; charset="utf-8" This function is now unused and can be removed. Signed-off-by: Mark Cave-Ayland --- include/hw/isa/i8259_internal.h | 1 - hw/intc/i8259_common.c | 16 ---------------- 2 files changed, 17 deletions(-) diff --git a/include/hw/isa/i8259_internal.h b/include/hw/isa/i8259_interna= l.h index 282e437d25..390a373511 100644 --- a/include/hw/isa/i8259_internal.h +++ b/include/hw/isa/i8259_internal.h @@ -73,7 +73,6 @@ struct I8259CommonState { }; =20 void i8259_common_reset(I8259CommonState *s); -ISADevice *i8259_init_chip(const char *name, ISABus *bus, bool master); void i8259_stat_update_irq(int irq, int level); =20 #endif /* QEMU_I8259_INTERNAL_H */ diff --git a/hw/intc/i8259_common.c b/hw/intc/i8259_common.c index ec229a0b5d..b3f2600523 100644 --- a/hw/intc/i8259_common.c +++ b/hw/intc/i8259_common.c @@ -89,22 +89,6 @@ static void i8259_common_realize(DeviceState *dev, Error= **errp) qdev_set_legacy_instance_id(dev, s->iobase, 1); } =20 -ISADevice *i8259_init_chip(const char *name, ISABus *bus, bool master) -{ - DeviceState *dev; - ISADevice *isadev; - - isadev =3D isa_new(name); - dev =3D DEVICE(isadev); - qdev_prop_set_uint32(dev, "iobase", master ? 0x20 : 0xa0); - qdev_prop_set_uint32(dev, "elcr_addr", master ? 0x4d0 : 0x4d1); - qdev_prop_set_uint8(dev, "elcr_mask", master ? 0xf8 : 0xde); - qdev_prop_set_bit(dev, "master", master); - isa_realize_and_unref(isadev, bus, &error_fatal); - - return isadev; -} - void i8259_stat_update_irq(int irq, int level) { if (level !=3D irq_level[irq]) { --=20 2.43.0 From nobody Thu Sep 24 19:04:36 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1789555578; cv=pass; d=zohomail.com; s=zohoarc; b=l646FGoq0xWqqRhFPHurWSM8+0ece4VS7XV2OxLHJEzzOY5ojMq4KiuMCOYIgv4eEOaQjpqlwI84dac93ueKIbRGB7N4M8jejVa0mD2e6JpQrGWxYZfTDYC6SQmw0sg6xINcFskD4gi3W1A3IB9c9w7KzB7wC1VsLgjBhLuGkLY= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1789555578; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=ihH5Aan2jq7PxNKIjpNTz0jnjtfH5nsB0nWZwEzS8lg=; b=H927rFy2BKNv6NBNZMq6FVSSpZDqqbAt2FC4j3iFEPqeZziahoCBPSpot9rzTQv6D5mbDzpgyZ625dEVkLkgqe0cGxASyB/rvu4eNXE81bKw7ETOxDfSfsiUyevuekxKOxRzHxZRqnUCE1bJwkjr+5Iu7Rj9clk20sYiLk+8K8s= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 178955557885291.14669105092753; Wed, 16 Sep 2026 03:46:18 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1422658.1648082 (Exim 4.92) (envelope-from ) id 1x6n9F-0000zm-L3; Wed, 16 Sep 2026 10:45:53 +0000 Received: by outflank-mailman (output) from mailman id 1422658.1648082; Wed, 16 Sep 2026 10:45:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1x6n9F-0000zb-Ei; Wed, 16 Sep 2026 10:45:53 +0000 Received: by outflank-mailman (input) for mailman id 1422658; Wed, 16 Sep 2026 10:45:52 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1x6n9D-0000uz-Ty for xen-devel@lists.xenproject.org; Wed, 16 Sep 2026 10:45:52 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1x6n9D-005QVA-AS for xen-devel@lists.xenproject.org; Wed, 16 Sep 2026 12:45:51 +0200 Received: from [10.42.69.6] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6aaa735c-8faa-0a2a0a5109dd-0a2a45069e1e-10 for ; Wed, 16 Sep 2026 12:45:51 +0200 Received: from [148.163.155.12] (helo=mx0b-002c1b01.pphosted.com) by tlsNG-16d1c6.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6aaa735d-195a-0a2a45060019-94a39b0cffa6-3 for ; Wed, 16 Sep 2026 12:45:51 +0200 Received: from pps.filterd (m0127844.ppops.net [127.0.0.1]) by mx0b-002c1b01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68G7x6qJ579616; Wed, 16 Sep 2026 03:45:46 -0700 Received: from ch4pr04cu002.outbound.protection.outlook.com (mail-northcentralusazon11023123.outbound.protection.outlook.com [40.107.201.123]) by mx0b-002c1b01.pphosted.com (PPS) with ESMTPS id 4gqbtb9yck-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 16 Sep 2026 03:45:46 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by PHXPR02MB11343.namprd02.prod.outlook.com (2603:10b6:510:3cc::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.428.9; Wed, 16 Sep 2026 10:45:45 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::8e97:bc32:822c:b250]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::8e97:bc32:822c:b250%3]) with mapi id 15.21.0406.007; Wed, 16 Sep 2026 10:45:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=proofpoint20171006 header.d=nutanix.com header.i="@nutanix.com" header.h="Content-Transfer-Encoding:Content-Type:Date:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To"; dkim=pass header.s=selector1 header.d=nutanix.com header.i="@nutanix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=ihH5Aan2jq7PxNKIjpNTz0jnjtfH5nsB0nWZwEzS8 lg=; b=1YeS32lDh8hcTt5dCJ8oVmIFs5Tu/x7A0UY04UBvg+DkEn5DqoynMYIop ReS/ezvRAsWvbTJgx/6d3ECfLPt4s7v6xWY5TGPa/ko1wXwZ2WNbqr0QSamy80J4 Dtx2Wb7ksF7nlL6YnQEQMK+B4xTqd69kac3vfUhSxof3PUIYnuU5Rv80BNESKfxT hayl9GlOwjyvYY2Ke2dHm02tApNF+bQddkS6jdDTKw4dgFTs6h7qAsuaxGCE0m2m TEJtf1gPSCcx2nL2tfYR+vnGtOF8/Rk4F3KxdBP8rdgA4AFSy9WxrTBUw97cOSiP TJgDvPO4ifAEpqlXA7jy7NxmWCAjw== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Jt/EI7Y9DwmWeJSvcY1YjCRt0w451VAXPxUgFdl51ADaGZgtvfevWfu7AyJWtGJ2gs0U8mqyJ37XbXT+EgjnkTSNks29zqtRPyu/K6v27STQ+DX2W0j0uUfgxVhOncfk+1KwH2WEENZYCMpXB09gZv53x2QNxNVw8UoaeIEcpeKgmfJenm3TZaEZvaNQM688tr4gXfGcqL45Nm/FzTbaMOuEiVjQMX9EIUlh8X+n8avr8Doiqrp/Xfki/r5TVe0dj514LAuPfk3EO3o6iNtNtDSTqtNXI1GZOablG8IEACtE48mJLvJmj8Dl236YvedJAMa5OrRNZAoBkm21qRci2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ihH5Aan2jq7PxNKIjpNTz0jnjtfH5nsB0nWZwEzS8lg=; b=SZsFYpUCL8U5qZZDoO36+PUL5Bh0A3oAGfjhx5NbCVRfKQhLj15cw+1DElwRXeTeyXgGU9xjj52vs0Npc/QFMG8uMmYhp9r0IDvkYGRwxoyfh1Ex2BzBawh/jBtEZ8t9rmZeLSa3CBiUtDiPHuRMniowUAsMcxXeftwqtQCJELG2MDe2diYoW42Ap+MC6PtMSAGBoYxL14pGRpcAi1GZqeGPCpjMguihu0NsXGVTTxJRe6pSMfuGS2A0bKuYN40vrRD14Mj7QM9c3Vmpq3NOx0b8NVx0CfOZRX7dZQ/bPLimuAAl55Vb97fDBMc4g+SR5VDuP2Tup9qzqAT36VWWRw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ihH5Aan2jq7PxNKIjpNTz0jnjtfH5nsB0nWZwEzS8lg=; b=Bmfnie5TNuQgXOTidqZwziJ9rKQtB1ob7sZRHcWwI5rqjaq0RY5qp9wGzhHsSHi2EInoKqT7Id8pDl2BQMNbpg6iXAV20LyCx190rHr025ENPajtJmgs5QkfSedOkFKXW/qyafDZhAZwm/DXQugKrFEH9fIa9il8mPA9YWeu6pweWiPWOv3E3HpOerwFYlZDoXYFpuYvxa9VoATrsE0RQjU1kccYagNdgANCqi3IS8oVOcknBVDTdktg+zCUVm00s1XNNIALBgwPvoH/X00PUisEiqgSEkzEZu+hORN/A/EGgA0O9vHUNu/yubHw+Tt3+H70SajmwJopQ55++kjzZQ== From: Mark Cave-Ayland To: pbonzini@redhat.com, richard.henderson@linaro.org, mst@redhat.com, sstabellini@kernel.org, anthony@xenproject.org, edgar.iglesias@gmail.com, qemu-devel@nongnu.org, xen-devel@lists.xenproject.org Subject: [PATCH 19/22] i8259: move InterruptStatsProviderClass get_statistics() from i8259 to PIC Date: Wed, 16 Sep 2026 11:43:47 +0100 Message-ID: <20260916104435.600211-20-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260916104435.600211-1-mark.caveayland@nutanix.com> References: <20260916104435.600211-1-mark.caveayland@nutanix.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: BY1P220CA0045.NAMP220.PROD.OUTLOOK.COM (2603:10b6:a03:59e::14) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|PHXPR02MB11343:EE_ X-MS-Office365-Filtering-Correlation-Id: 7926d65c-4b18-41af-c2b7-08df13dfa95a x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|1800799024|23010399003|18002099003|3023799007|10067099003|56012099006|22082099003; X-Microsoft-Antispam-Message-Info: wEh6tNVM7FI3/NfB/qPABNPHhAZsIXSrbB80pq/L/t3CNLcmp//SwB7cajpTeL/A/9kVBMD7ylprE6DGFtn43QlFDXoo+ZvMW9/x0EzaO5+EcCkxO37J6is6Bu3wo7GVKeVDnGvtr0E+1rB1pK/5us5Ut4cJdLs314PGvqxtkJpGy3jWkChRZ9vRjAyUR29aky3Jqesd7pGhXdfrK1B8MJByFyygSgIKpUQewfgWWcRDKzG3SbF6n7V0p5L3eIt07Hta7j2jetvwQRK4zhHoDzIb3iiTnxfX+xIpC8NFoEYdZnBf/4GhXwTtPjf6/K+vyHLG6t5Ejtuf8TgZxRBxYl8EnjESCCQwKr1XBkcWZVxwhCK6c/h7QEq10iD/ZymRiHijgWHYRirmTvIep93+bj0pwepFmKwsqlUA6UjwkwAJsMObx/ee5Lm4SmFDiL4HlMccQoR/SuL2wV7pj9/FtfJ0DcR9z8e1IzmxxmKoEzSjyZ4G+VVmchoU2CFyq25aLb29tOEmZKOZyTKFv8ZQHpMcVfWyVdUsx66LQREiWmPQiPKYV30JdgAV8m1/aUkSHmgVl/3ZIxjqbLItPcIj/FJ2I4MNrY6iLAvh/1OSzBflwe/3pyHbGGF5fh7Btb/ZxsRj+6BgzO9sCLT1/JBmVs/lhrrCnrEO+ht5MWG1UUg= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR02MB7159.namprd02.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(1800799024)(23010399003)(18002099003)(3023799007)(10067099003)(56012099006)(22082099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?8pYZ6YWt+VdzaJmG54dG6HJIov/9Y2LN9/NnDkIJls7DHsK2y6UWyi5ANtms?= =?us-ascii?Q?pacqGMaiyD4nxwW3fFxdpdb9gbS3MMASmzF+weV79PT+mxDioLF2G/DDg11R?= =?us-ascii?Q?PJ1lxS6ZUVY8bAPvggvKqzBXZ1FUdjQl5hSnNA1puT9OzTQGaJz8rmmT/GQD?= =?us-ascii?Q?YsVZdwYs8Cgf9xmjJZdPZNLGvGA9XrZCFtLjdw0NzSAAH7W52DF2roHtDNBX?= =?us-ascii?Q?v3uNRg8BSxpNGDbyNF5fNzCGzmKYr3xujG0qHL5AbpMvDhkojJd9g9vWyTge?= =?us-ascii?Q?B7heebURlSPc51ca/ulQ4Z4kC+eRNQE+nSz0VDlKfRpbR/njM+67JqQeC8Nf?= =?us-ascii?Q?0xbjbVmZhWzibD0P1Lm8C9wiOtxIH1l7DAwLiCm/g56UZnP9sjCeT0dmMC+m?= =?us-ascii?Q?wSQ6AQVGRsQC2woUJLvBSVozACtObbSnryA/uE9FBBIxhhBBEsDj6YF7TzkO?= =?us-ascii?Q?lcQ6sdEB9UnPc3S2UL1/z01UKSZXlMCICk1+B2X4f/ixRdGWkmu8smO7cBD2?= =?us-ascii?Q?R4tSLb2oEpMAuXM351UDshywQ+7OZu4XsVbaFvAkRFEqAgdHBcDvCAvxQJdz?= =?us-ascii?Q?IEMHGIprbzMCY2UNYnqd+m8WDiYBFnY8+1Rmw8BJjN+6CvdEjrSWlWmaIfKn?= =?us-ascii?Q?T2G5Nlsw05h41vORybYH69jttzxjvOT0CPwnXYwrciXuIBPpjVg3LT/H8RXq?= =?us-ascii?Q?95Tk0JF3B18vgKSJJvOfNQLhd/P7MakTBGm0S9vfr56AU78PGp2R9gaSsJfe?= =?us-ascii?Q?NTwJk5aUBd/tu6jRoH0n8zOuOk5ojIZpNQug9HpDBxz5n6Zwn9Ueb35m99ka?= =?us-ascii?Q?7aaAMz9jO7WURZrHUhTncu+QJHQ5C6RmOarYyziVwXxsTELwYjrKyBUgTu/3?= =?us-ascii?Q?e9j/nkMDh15Uan/jgnqYQO1ITNOO4m+tMeFFUzYq2BniEk7C3a2jYASGG8Ln?= =?us-ascii?Q?qhqnGUsaI3J7M0H86orXTMCejd1fBItM36wtomvGEz7Z+V7Zw6D13/E1y5oh?= =?us-ascii?Q?xTDLvIb8yNhtN9I0Fo98bVsjb5hqFSqlo+qA7Y91TF8k0KtiE2kfK0Km9cJq?= =?us-ascii?Q?V3WiWFZA3LJ+taunV+N4Y761tmgpd3Fge7PuhCdqqUzCh2AE1/PfzaN85vKZ?= =?us-ascii?Q?eZCWpdCxY7NdNU6/R7FyCPwcZyJbC/2OASnujffVqfy1rkWEGFgPcIzYfF/p?= =?us-ascii?Q?njW+yz/iBvMzY2XqtI8KUyW/JFtElKk7CizJeHA6bKnTH1h/FuR2cbg4ghIT?= =?us-ascii?Q?jaWzJIfeqX+uuEfTbJ/uR4dVDwWOFChTBqm//rzNCGrjahBtsvWPwXgxBBBL?= =?us-ascii?Q?f8/VRHaFHQ41thA19r26a1sL0YusRhFqKK4GVOvBM2rthTUTWK7JzGNW4tDo?= =?us-ascii?Q?lx5BpO7c6K3oNwzc+ad40tdN0qpk14ufIVLcxmAE1oEHJ4TsWrE/FjOpPxQS?= =?us-ascii?Q?rr2wY9JtdP37/RCVaMnsSfRCOdasoH1HicmUrZNwNIlTJoEera/j21r3wJ8l?= =?us-ascii?Q?8jwSBD1FAdTun9uCrdqIZpAWKXCyuUN0kmniYZffBMSWmk80wDM2IOyNn0Sn?= =?us-ascii?Q?J3hYsplfavzezWwIGyatO0NKKpJeieYy4ILQhX0oDiHj6woh9DpI43nDEwIr?= =?us-ascii?Q?l+TOBMtpHE4zHYMY1zvHMtYKbB+ZV6uP4n41FQYJCXC91CrAQo4NLNeEp3F5?= =?us-ascii?Q?VYBRTAOEDTA8u/8YK0A1Rx5yO+T1okzbV3qZBt1ML8lmckpC21eahVr5f9jW?= =?us-ascii?Q?SPvM1cwZULZebBW1tZpHFp/RvvYDcIY=3D?= X-Exchange-RoutingPolicyChecked: g5ZdVuxOFxp4XWe3LvyjZkpOC5AeJku9Tq4meGIVWpjSwJL7DmvXpB/hU1AhZUtE408jMlhHcORgps19G05onx9/U395oTPQyxI/N4xUz13LGtRmdRaCFXxC5hzU5N/w8t4cK2bo9MOnhT1NRfqD0E2CFeLH7iPu/RhMzCRlMciNZwhhPqZhB7/ea3hak87Za9i7Torw4/thky00gCQ94DcOs/+un1u7/6s2JoJp2DaGDa4+YRaSoa3fHZGw83HhXe/Lq2SGggfdiFBTjuROZNOz1z/mDXp1SHV7R9vwiDIEs0JAoG9SaWjBKA4rxqXp/cKZ3XBicYJavs7c7rrr3A== X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7926d65c-4b18-41af-c2b7-08df13dfa95a X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Sep 2026 10:45:45.2496 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /Dh3ho+PdJTLKkHJi5fgX37f3Msrntc8M7f24zGxqV1xm94I/niydO3LJ5fXywqR6itw+CPa1kKK2WUoktWpFmnUSPYL4nD6vXgk4FbvsoI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PHXPR02MB11343 X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE2MDE0MSBTYWx0ZWRfX6LKqaZsss3Ig sX7YtgeUxUX0Ng/AurLgXLFmcY0ZHzUasLF4zKNEyPUiDtcQ9PBlR0rdmqmmtXmcpSfsJiWXJza 96YkL9p/MENJZMB/2RvY7qx92gu/iYk= X-Proofpoint-ORIG-GUID: kpVvWs6dz-q-2TTU3FAlEzs_6_aNAjUr X-Proofpoint-GUID: kpVvWs6dz-q-2TTU3FAlEzs_6_aNAjUr X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE2MDE0MSBTYWx0ZWRfX+fbmi7BTHGOA +gpdqGxbeC5/BQanNIgTrH4GzUxxPbbGzk/e+ks+dm+eIqLQII//uCDFc1zWxDpBQGE1pW1t3Eb mgpJUKRCcjMkrV5QmMP52h6//MR+pGMSNsEFntF3MOiQIB8PhJhHLQCZ3KstLkOMglGuZAeAv7m u/b79uHLpiwZI8mHmR4aZyXIosGaEbpqtHUkHOcENJOmRnJ2A0/cxy7SMr2/IebYMYj9BWFoh7/ ATJM7nsIczoeY2adBGbinjcrviNluVWqWEnd/Y71eJOnODel3tT42E+EddAqUy1tz3ZXBSbcw8C jVTNytQmHc0IzA9VSOK2LbuVctes1LRyhe9IeRHB9vOOi01FZDvkQouiKabUZOf+gpef8ynqgi3 mIZX3KFphVMHd1JhZomhG3Jqde4vIWx00S5Bz7JSF3O3YGCHONL8BQe+YczpjRJ1vHuTK2NVBSO 4IWWFkxjZ58V/5T0EQg== X-Authority-Analysis: v=2.4 cv=QYvzLcbv c=1 sm=1 tr=0 ts=6aaa735a cx=c_pps a=MuaoZ+x0jvd2FUwkjOjmXQ==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=xqWC_Br6kY4A:10 a=VdqzKS8jKosA:10 a=0kUYKlekyDsA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VofLwUrZ8Iiv6rRUPXIb:22 a=0LlEyIVc8U2lsR7dKhuH:22 a=64Cc0HZtAAAA:8 a=A7cMN0_0mIGH7w_oRUwA:9 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-15_05,2026-09-15_02,2025-10-01_01 X-Proofpoint-Spam-Reason: safe X-purgate-ID: tlsNG-16d1c6/1789555551-F480577B-222F8659/0/0 X-purgate-type: clean X-purgate-size: 5931 X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1789555581172158500 Content-Type: text/plain; charset="utf-8" The internal i8259 implementation has workaround logic for storing interrupt statistics since these are currently recorded at the PIC level (i.e. for all 16 interrupt lines) whilst being stored in the master i8259 device which on= ly has 8 physical interrupt lines. Move the get_statistics() implementation from the individual i8259 device to the containing PIC device in preparation for removing this hack. Note that this has a visible change to the "info pic" HMP monitor output since the na= med device displayed by "info irq" is now the PIC and not the individual i8259: Before (TCG): (qemu) info irq IRQ statistics for ioapic: 0: 68 4: 1 IRQ statistics for isa-i8259: 0: 68 4: 1 After (TCG): (qemu) info irq IRQ statistics for ioapic: 0: 47 4: 1 IRQ statistics for isa-i8259-pic: 0: 47 4: 1 Before (KVM): (qemu) info irq IRQ statistics for kvm-ioapic: 4: 1 IRQ statistics for kvm-i8259: 4: 1 After (KVM): (qemu) info irq IRQ statistics for kvm-ioapic: 1: 3 4: 1 IRQ statistics for kvm-i8259-pic: 1: 3 4: 1 Signed-off-by: Mark Cave-Ayland --- include/hw/intc/i8259.h | 6 ++++++ include/hw/isa/i8259_internal.h | 1 - hw/i386/kvm/i8259.c | 7 +++++++ hw/intc/i8259.c | 7 +++++++ hw/intc/i8259_common.c | 27 ++++++++++++++++++--------- 5 files changed, 38 insertions(+), 10 deletions(-) diff --git a/include/hw/intc/i8259.h b/include/hw/intc/i8259.h index 1921a30371..24237a4ed5 100644 --- a/include/hw/intc/i8259.h +++ b/include/hw/intc/i8259.h @@ -1,6 +1,8 @@ #ifndef HW_I8259_H #define HW_I8259_H =20 +#include "hw/intc/intc.h" + /* i8259.c */ =20 typedef struct I8259CommonState I8259CommonState; @@ -18,5 +20,9 @@ qemu_irq *i8259_init(ISABus *bus, qemu_irq parent_irq_in); qemu_irq *kvm_i8259_init(ISABus *bus); int pic_get_output(I8259CommonState *s); int pic_read_irq(I8259CommonState *s); +bool i8259_pic_get_statistics(InterruptStatsProvider *obj, + uint64_t **irq_counts, + unsigned int *nb_irqs); +void i8259_pic_print_info(InterruptStatsProvider *obj, GString *buf); =20 #endif diff --git a/include/hw/isa/i8259_internal.h b/include/hw/isa/i8259_interna= l.h index 390a373511..53751b045b 100644 --- a/include/hw/isa/i8259_internal.h +++ b/include/hw/isa/i8259_internal.h @@ -26,7 +26,6 @@ #define QEMU_I8259_INTERNAL_H =20 #include "hw/isa/isa.h" -#include "hw/intc/intc.h" #include "hw/intc/i8259.h" #include "qom/object.h" =20 diff --git a/hw/i386/kvm/i8259.c b/hw/i386/kvm/i8259.c index 0ae5caa655..421c9279cd 100644 --- a/hw/i386/kvm/i8259.c +++ b/hw/i386/kvm/i8259.c @@ -206,9 +206,12 @@ static const Property kvm_i8259_pic_properties[] =3D { static void kvm_i8259_pic_class_init(ObjectClass *klass, const void *data) { DeviceClass *dc =3D DEVICE_CLASS(klass); + InterruptStatsProviderClass *ic =3D INTERRUPT_STATS_PROVIDER_CLASS(kla= ss); =20 dc->realize =3D kvm_i8259_pic_realize; device_class_set_props(dc, kvm_i8259_pic_properties); + ic->get_statistics =3D i8259_pic_get_statistics; + ic->print_info =3D i8259_pic_print_info; /* * Reason: must be wired to the ISA bus via the "bus" property */ @@ -227,6 +230,10 @@ static const TypeInfo kvm_i8259_type_infos[] =3D { .class_init =3D kvm_i8259_pic_class_init, .instance_init =3D kvm_i8259_pic_init, .instance_size =3D sizeof(KVMI8259PICState), + .interfaces =3D (const InterfaceInfo[]) { + { TYPE_INTERRUPT_STATS_PROVIDER }, + { } + }, }, }; =20 diff --git a/hw/intc/i8259.c b/hw/intc/i8259.c index 964ceb04b2..ffd09f6c61 100644 --- a/hw/intc/i8259.c +++ b/hw/intc/i8259.c @@ -517,9 +517,12 @@ static const Property i8259_pic_properties[] =3D { static void i8259_pic_class_init(ObjectClass *klass, const void *data) { DeviceClass *dc =3D DEVICE_CLASS(klass); + InterruptStatsProviderClass *ic =3D INTERRUPT_STATS_PROVIDER_CLASS(kla= ss); =20 dc->realize =3D i8259_pic_realize; device_class_set_props(dc, i8259_pic_properties); + ic->get_statistics =3D i8259_pic_get_statistics; + ic->print_info =3D i8259_pic_print_info; /* * Reason: must be wired to the ISA bus via the "bus" property */ @@ -538,6 +541,10 @@ static const TypeInfo i8259_type_infos[] =3D { .class_init =3D i8259_pic_class_init, .instance_init =3D i8259_pic_init, .instance_size =3D sizeof(I8259PICState), + .interfaces =3D (const InterfaceInfo[]) { + { TYPE_INTERRUPT_STATS_PROVIDER }, + { } + }, }, }; =20 diff --git a/hw/intc/i8259_common.c b/hw/intc/i8259_common.c index b3f2600523..7980f86f1f 100644 --- a/hw/intc/i8259_common.c +++ b/hw/intc/i8259_common.c @@ -99,19 +99,28 @@ void i8259_stat_update_irq(int irq, int level) } } =20 +bool i8259_pic_get_statistics(InterruptStatsProvider *obj, + uint64_t **irq_counts, + unsigned int *nb_irqs) +{ + *irq_counts =3D irq_count; + *nb_irqs =3D ARRAY_SIZE(irq_count); + + return true; +} + +void i8259_pic_print_info(InterruptStatsProvider *obj, GString *buf) +{ + /* No information for i8259-based PICs */ + return; +} + static bool i8259_common_get_statistics(InterruptStatsProvider *obj, uint64_t **irq_counts, unsigned int *nb_irqs) { - I8259CommonState *s =3D I8259_COMMON(obj); - - if (s->master) { - *irq_counts =3D irq_count; - *nb_irqs =3D ARRAY_SIZE(irq_count); - } else { - *irq_counts =3D NULL; - *nb_irqs =3D 0; - } + /* No statistics for individual i8259s */ + *nb_irqs =3D 0; =20 return true; } --=20 2.43.0 From nobody Thu Sep 24 19:04:36 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1789555575; cv=pass; d=zohomail.com; s=zohoarc; b=W0AcvndKJzdC3GoIuvS4eC00khxUqzGwgTVanC30pvvCrqlI2Rzed1o8cmBXLDl557l/T+noc3I7sGq+9/8yu8updRxVA73xVxj0T8v5p2ixEY72/y0LyYrCruZoL29NkxiRwxk+AJiyUfJ9VZSWUUd7G/djAh4QZF7OyDyWwKY= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1789555575; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=ZeMvtYJ+Cvv28zu4IBYu7pIyvPvX3ma62mHZ983wFQ0=; b=nby8G/bQdBxgGJyjf1Is0n2DH/sDNwbtgpAhqWGVkcd8bPyFbyKpUwcebb8ei7xebhnk1YGRdeSuyvgYApndsIdDX9IIze8PZ7rL3bvai1MNAi3JYb1uP5vg0jilUybTYUz5a8yjIk3s52jBXnk4vuTYGj+3faslxeBsjGZjc20= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 17895555751061001.7426344848615; Wed, 16 Sep 2026 03:46:15 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1422665.1648091 (Exim 4.92) (envelope-from ) id 1x6n9K-0001Wc-8L; Wed, 16 Sep 2026 10:45:58 +0000 Received: by outflank-mailman (output) from mailman id 1422665.1648091; Wed, 16 Sep 2026 10:45:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1x6n9K-0001WP-30; Wed, 16 Sep 2026 10:45:58 +0000 Received: by outflank-mailman (input) for mailman id 1422665; Wed, 16 Sep 2026 10:45:56 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1x6n9I-0001Ok-K9 for xen-devel@lists.xenproject.org; Wed, 16 Sep 2026 10:45:56 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1x6n9I-005QVA-0h for xen-devel@lists.xenproject.org; Wed, 16 Sep 2026 12:45:56 +0200 Received: from [10.42.69.12] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6aaa7363-8faa-0a2a0a5109dd-0a2a450c9f74-4 for ; Wed, 16 Sep 2026 12:45:55 +0200 Received: from [148.163.151.68] (helo=mx0a-002c1b01.pphosted.com) by tlsNG-d25034.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6aaa7362-f479-0a2a450c0019-94a39744ecca-3 for ; Wed, 16 Sep 2026 12:45:55 +0200 Received: from pps.filterd (m0127837.ppops.net [127.0.0.1]) by mx0a-002c1b01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68G8K2Tx700459; Wed, 16 Sep 2026 03:45:50 -0700 Received: from sn4pr0501cu005.outbound.protection.outlook.com (mail-southcentralusazon11021091.outbound.protection.outlook.com [40.93.194.91]) by mx0a-002c1b01.pphosted.com (PPS) with ESMTPS id 4gqa0ka9yp-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 16 Sep 2026 03:45:50 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by PHXPR02MB11343.namprd02.prod.outlook.com (2603:10b6:510:3cc::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.428.9; Wed, 16 Sep 2026 10:45:49 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::8e97:bc32:822c:b250]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::8e97:bc32:822c:b250%3]) with mapi id 15.21.0406.007; Wed, 16 Sep 2026 10:45:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=proofpoint20171006 header.d=nutanix.com header.i="@nutanix.com" header.h="Content-Transfer-Encoding:Content-Type:Date:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To"; dkim=pass header.s=selector1 header.d=nutanix.com header.i="@nutanix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=ZeMvtYJ+Cvv28zu4IBYu7pIyvPvX3ma62mHZ983wF Q0=; b=xLAgrXQBvpMMlRIMejydplMeLlUcNQhnDk9FKs5pJgXApljCqGyBbKf3W mX1yXPj0Ag2xCyHMS0As0Rojf4vYPlKmkltqMQffeUE/aGmA/geW/i2GJhz18GDE RzPKm0Wz13RYkkcUp3ZKljho8utfYifpoMaRfMp5IAZLEXibq4k3aQRjYsctX5E+ PnUT4hsZ6UW5Ma4TJ0FFJxsnCY5AmD40Tt82G+FOtC4ki770fa0pwwYFAMRMg86x Y74jLVONBscmdg+c25YXodHXcX8sZK5CDyxlbS6ZE1sfnB3ROskqctN1li4PCyUm Z0cS4Avn3v39zfBM2f6Upb7P336sw== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=h9SkLQMVYi8r7PzJTGNlR0oQ+l0VIHdsVUlHqshmVWJjT17tlrrRrDBOppf8TKj12z1FqJhMht/tYqlHKEuq58z81y9OgEo5D4ObOxLC5uDvIZLctyeumtD31YgdiXfzudKKS5rMVrLqIgc9ZqSU7FHGkCos7yWvUieFh9VKkLeuyAfycAMQPU1oWkX2VUzWbbYaDnT+9GIjOpCEpOKdYsGMdQ88+29TNmvclb4iAKrDqOK+gNd4TabRYk03wgXhmXtAbjYqVFDXpkuFwJiN85K4UlTdnQBdB6jmUAVQeyAWkR+PYNtZxvaQD9mfMOO/S43aB+tozKUsKXifreFfPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZeMvtYJ+Cvv28zu4IBYu7pIyvPvX3ma62mHZ983wFQ0=; b=YO/D6yoLDm4+c+SN4oAm2UbYe4/D8P0q5BWbOfqJuJbXfzWCTnwTPLztA7HbtREQeJt6ozH5Kx1QseDLD4f7p7M//Yw01TUQKZYuE5R7HOdFj2lZ9NlFQa0zWdXhHRPUu0Y7z5QUK7K0DA4mASrtKVtBP89hNYVsdgKmRsYOJn9M4lbV7dm+v4wrJuumOprFeBAb8+92IeG95A/+/vpPWPEjUn7W+g9QbrWWUg1xkUJV0hjU9/RZ9BiSd1NvfmpChGjnXGiykAWP7xoCQmhvAGhW4AOMLNV5CfPalg6r2+AvEcgw3OpyMHNZx2qPR5BAG0VgC9PAnfik2hSnMpm/Bg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZeMvtYJ+Cvv28zu4IBYu7pIyvPvX3ma62mHZ983wFQ0=; b=NWLAE6ZSYivBF7qRGLCtXvTbKk1e8rgmF1dyhB6JoycJw4lbirQ8Y9BEXzDBaqFo+m+8GypEShklx7mWRTRB3LcahcHVoVc/rvfHnIW/suUxPcb6rJT5OXm4wTUQY7TIgJhyXdNb4r5/T3ogqVkSDuUa/rMBGzO+P7fCJ6yMfgKkmAnBX03qBpMnSJRl2PSqIfUdVqwryWBojbQQxEJJdYqj9eLn703cCkfI6axhgEGX/Hqj2Djik12OTCcMkuVkaezB+F7GtDLJZN5BnOqlpGN8J6V08If0vfUx8pcPswdhn1inSoCbUc2uM0UGvTXvHgtjWKXe5A5XDUblntc1fw== From: Mark Cave-Ayland To: pbonzini@redhat.com, richard.henderson@linaro.org, mst@redhat.com, sstabellini@kernel.org, anthony@xenproject.org, edgar.iglesias@gmail.com, qemu-devel@nongnu.org, xen-devel@lists.xenproject.org Subject: [PATCH 20/22] i8259.c: switch isa_pic from I8259CommonState to I8259PICState Date: Wed, 16 Sep 2026 11:43:48 +0100 Message-ID: <20260916104435.600211-21-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260916104435.600211-1-mark.caveayland@nutanix.com> References: <20260916104435.600211-1-mark.caveayland@nutanix.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SJ0PR03CA0188.namprd03.prod.outlook.com (2603:10b6:a03:2ef::13) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|PHXPR02MB11343:EE_ X-MS-Office365-Filtering-Correlation-Id: 5431d887-b5c3-4e13-eaee-08df13dfab79 x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|1800799024|23010399003|18002099003|3023799007|10067099003|56012099006|22082099003; X-Microsoft-Antispam-Message-Info: P+/w8UnkVOtGcFmBzS8Lh/apBY2tOSsqHthSUSr6kF3CrzQc0fslLKjI9UQPgINztRzpIpl4LDgBosczA4+Rlpk+9jEK/r2tdO9xknD/LZhsN4laIAFyWGg3kXzH+f+gm8pkWQjdSRQvA4i1mll4dVqi1WUKeXCbW/dakCmo7G1IkNt144R+alLFpVpHahgx3MdigstjD6PCurMIsXixw1iVC5F2G5yNVYinHvOzOcqSuPxdSy0tfs38QyJ4IocPjLfGRxPKXpfe0kbZco4iWFNIOqJnE/ChNQfQo4B0QsjA2SE+WYed04CwNN5luVoHCEwypXdkqqWZjSWRFyztPHHXRpA7LurDnl9eQHtmnB4mSYr8tETgO7KsB42+2vY/gf0fyQ09D0Lg55N4oD40vH9MUM1Hnr3aVAOeEXbJiQ06yeUIrUTFbeL+BR3jXAB85OgGCneVAhyq8k+oWLpXpC97i1FYUPliRSuEBJeEEY3lLtees9TIDwCz9BwGu+aJCbDG6c5hEi9wW1wkFTh/ChvdidODMwAgruTXdgEdE/g/lRl6wlYniAzQrkNLVYJYYdWdd9c07ZfGNRcChnAyMbMczb0COF5AaH8/7Fv87wTzj+8NrY8PwP/q7B3cNuNrbbDqWUy7DMpyXffmY5Y7mqKh/NbfGpHDcLa5ZKrj7+8= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR02MB7159.namprd02.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(1800799024)(23010399003)(18002099003)(3023799007)(10067099003)(56012099006)(22082099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?TEc/l7hHqXouIcnypTjVIgkkPL0uAUHMM3dBa/nmLKuhLfIqBOLvV2STaeaR?= =?us-ascii?Q?BgUiyMhPlhbg9Onj07uANQjewvjyxb0h4txMLIZ3n1y5WhT1agj4T1hbh7G2?= =?us-ascii?Q?cBvaU66v3u25u8aUxQzXidxwAU7zbr88HZm/EXfTQjZ3yD3hkqgCVVD75/gx?= =?us-ascii?Q?ZgHnhDJ9PpmMKAei7B0b930aSn5tnVKhyE7U2MwJklnsTBFZRSDFq1yet/3s?= =?us-ascii?Q?VebB34oJXE1mfQgGt7uuH4+Tvro2gF+AFarVyPNhyeEGVXFXOfDYAtD+3Kl2?= =?us-ascii?Q?WyCHct3r5USfsnja0nBuvG1y2nH84wFuiJfptRYikemoBr6/Vxtl1ft1T97F?= =?us-ascii?Q?BgsAbI8T3e/Bqix69WoIm62H9shCYTNN8VJoCVAXYQEMRydlYbr42D9Qscxi?= =?us-ascii?Q?xZMu0kWac59kUsKefN3wjH0RdOhE5wDH01XB4xKcf9oyI30rRwkpt7PmRgDW?= =?us-ascii?Q?DnW+NkyOhrOlRFrd+HdSWpqKkTsoLuc5WYhBgdd/rIbXLdwqhJ4aO9llG9dh?= =?us-ascii?Q?xm0rqq/rkWWqCpv20iiddz2yzk6hdFbDeh0H1rJUBJ2QEiQcqMd79DHtOiFK?= =?us-ascii?Q?LKk55dEQaoJtNND/fA08l70jbD8+yMACP+wPXrNrgVfGMmCBhcJaYWGB4L8m?= =?us-ascii?Q?ea9dSrBtGy0K36eUze5sx4BSpeoFqldgaMsIMPcqBw1/aa8swQWEoN+JtERF?= =?us-ascii?Q?4uWQZJm3/9C2dMRTBOw88qPibMN5BW9410D19c8QzO23ps5R3+6ZjU4G8ceD?= =?us-ascii?Q?FQrdzsfwRBR8j7I7aj2VbPwFbSZDBrI0y2q5CuMI2c3u2o95cso8f4XKPXr5?= =?us-ascii?Q?vgTGyM6r6Z8QvKZVJZ3WaYZI3ZuoIyFmAl2UzHANfDvNkXuaAtl10ip6dUy3?= =?us-ascii?Q?knFAt2EJd2vuaSujy8Tq1Ydb162oxA7qdH+baPvZrWqAJFNxye3xE4zUBqfW?= =?us-ascii?Q?CbYgdRBLOzmlGWRgvR+qNPPBOmHEFa2TbrlcpuP6Y8a839/CCQYQsewiIz/e?= =?us-ascii?Q?m+yIjHguru/EKh1hdYqO/cxfpE/2mpSwRrVj+oqL/1rQ6tnkFBg3GQaZziX7?= =?us-ascii?Q?dGPcuc0lisUX70ohM5oLNPi8MW1mcpfrfZ+/uu6nvY1jLiOyqPN9fYMazWGH?= =?us-ascii?Q?TuMoTUmKyfBm2DH/b5kyvWfFHUiNRClrgSqBfu4dLAQdO3UPXEGladiWDOn9?= =?us-ascii?Q?Mg3AWCGXGSLLQZLKVsoYSu32WKV1fYd0ccDTE7fah/OzyCrqLx+vV96WIJ+l?= =?us-ascii?Q?xnLMTev22VQiFv2SbBbn1PqAD8aLcN6V6SnBjR0R60UTICbHMT1JMXmLPBBl?= =?us-ascii?Q?m+iSoSzeodRizAHBbFF9JfxekJ7b3ZC13j8A3OngmV79QU/fcZgg++AsqdnF?= =?us-ascii?Q?y3iSsP6jhNEPVx1/LvYHFF2PfVHLpIf8Bo/1qCCgpFjdG4DdGvnshrFBV0eK?= =?us-ascii?Q?MiGfTTX1cyk4yKrkLr5djoBhN/KH38Yuo2B1vykxD2q9Aq1p+V177XL2km1g?= =?us-ascii?Q?YO0JWDyb9kvD3q1i5jVqMqWjEcxZw0OSOW8qbFqEbpwMZqjewrzPMI/jiE97?= =?us-ascii?Q?qAYrJLSC5b9TmmAqoFbxk6U1wOuL4bfrTPms6fM1LRBEbAdH7fDmQdsIv4dI?= =?us-ascii?Q?nscHcjDhq6w7sm3r5aGTT08JI+fgg47gXZs35LWn08oKeD4Yen1Q0rX+Fvl1?= =?us-ascii?Q?EvKIUhYMLtDuSRDcALn+W4nmm4bRZQfymRLF4JlkEu9PxOLOXOb1qBL610h/?= =?us-ascii?Q?OCgRXu3l//TGs3mnR6yMUqOJfkL5Bvo=3D?= X-Exchange-RoutingPolicyChecked: 4LoSZwGOSopRjvuk9BtqVMPeptbaQCknnfCOz8NVlWqmmPs7GIFmALvgo+SEfguZP23cuIotiLX8vKYjJzOaYDrm/N4gsO+j2A4ilSFGF2/90ZQ0jjQQ14dpc/OCnFba3SEWfkwo3EiaqcZvtTNEbKU6povSxX87Vaqyz4shpIWWHIBV0tK7/3orO3iWmYKp/Vx94jdyLwVdo2IJnhcYV/jQ8ME9INx2Zg3RqF7LvG7I+mnWuob0u/QGDDc6oRsSsiGJgv6OlHyJFbY8FoIH0TvWIbB+kKenotmM3ys4JbP726vfAZnmG3v/iWAGE3s7QRQZjhtJ20LCqxPjW3vPqw== X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5431d887-b5c3-4e13-eaee-08df13dfab79 X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Sep 2026 10:45:48.8774 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: JhxUdFXErCUb3KfsE/TFBklALqiK9b6XxLos0JG4ZrksHFjcBeqRRLbxgfezCifT/IL61IYBCjG0Q5h0ps0tXT6ekfQH/OpOXRoPF5zkVzc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PHXPR02MB11343 X-Proofpoint-GUID: tu4xethUYLRFAEBvP2RqVEcjIzydIsZy X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE2MDE0MSBTYWx0ZWRfX+p5bhSY0JrJc 6WtzhaImHAGmjJVp78XM7+XLKedYJVGbeKtN8XzgHvnmlZqw7DvcUcowcspkGIabDWso0JuGjeu zzngcpLJG1KhGMDtDUqsbWFA6WP5oEQ= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE2MDE0MSBTYWx0ZWRfX3Z9ESevNqs9W E85FFYt2pPe5Q3rObMJayw4OZYhFOjD87Re3zUH6bjiSMMFCCZeYioK13vvfDkAvYmI5boy04Lv 4Pvvt6fQrAQJa+AubKygMSiUqOMNQJRhEnxFq+ItL4BkZjq+nljK/CuyoHrzsOL/8CtI19Mx1Sz H0mNylMQLwDLgonc6f3PvkpxjiKfsrEO0ao/9sAmm3HgOpJ4lhpzwAGoYQUq4WzYsfCtF8fXx90 FAIy4oyWCIOl6UYx0c6BKb+XPOXTUi2dOzdhStQTCimxKM1F1IvFpIyWOi7g4nJVOdOgPg440qM NFMKv7qlLnWVLf6mD/FW/Ef1hOUd9DTHdAt47/fdMjsgExXm8d6uWZLJlsdH65gFcT4/u1YoWwp nxfp8gSOlG5j6EgZyF95clsPV2MiPWytXo7tQHMtoxvdZe7055uFSefQ/Edq5ZcyDlnWauSkfoo 4Cz0DltuMuR0uobUmzg== X-Authority-Analysis: v=2.4 cv=P46vFSAu c=1 sm=1 tr=0 ts=6aaa735e cx=c_pps a=ijlDDoB9/djO8DkT6Rc3Rw==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=xqWC_Br6kY4A:10 a=VdqzKS8jKosA:10 a=0kUYKlekyDsA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VofLwUrZ8Iiv6rRUPXIb:22 a=Ap8k9tRZuQ82DLYWQqG7:22 a=64Cc0HZtAAAA:8 a=SFRUhxsDDi52rhXrSC8A:9 X-Proofpoint-ORIG-GUID: tu4xethUYLRFAEBvP2RqVEcjIzydIsZy X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-15_05,2026-09-15_02,2025-10-01_01 X-Proofpoint-Spam-Reason: safe X-purgate-ID: tlsNG-d25034/1789555555-76CDBA5B-F07488ED/0/0 X-purgate-type: clean X-purgate-size: 4482 X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1789555577126158501 Content-Type: text/plain; charset="utf-8" The isa_pic variable exists to allow the output to be fetched or read (fetc= hed and acknowledged) from the x86 PIC. Since this can also contain a cascaded interrupt from a slave i8259, switch isa_pic from I8259CommonState to I8259PICState and update both pic_get_output() and pic_read_irq() according= ly. This has the advantage that a i8259-based PIC device contains its own inter= nal reference to both the primary and secondary i8259s, and therefore it becomes possible to completely remove the slave_pic variable. Signed-off-by: Mark Cave-Ayland --- include/hw/intc/i8259.h | 7 ++++--- hw/intc/i8259.c | 33 +++++++++++++++------------------ 2 files changed, 19 insertions(+), 21 deletions(-) diff --git a/include/hw/intc/i8259.h b/include/hw/intc/i8259.h index 24237a4ed5..72be7c3de2 100644 --- a/include/hw/intc/i8259.h +++ b/include/hw/intc/i8259.h @@ -6,8 +6,9 @@ /* i8259.c */ =20 typedef struct I8259CommonState I8259CommonState; +typedef struct I8259PICState I8259PICState; =20 -extern I8259CommonState *isa_pic; +extern I8259PICState *isa_pic; =20 /* * i8259_init() @@ -18,8 +19,8 @@ extern I8259CommonState *isa_pic; */ qemu_irq *i8259_init(ISABus *bus, qemu_irq parent_irq_in); qemu_irq *kvm_i8259_init(ISABus *bus); -int pic_get_output(I8259CommonState *s); -int pic_read_irq(I8259CommonState *s); +int pic_get_output(I8259PICState *s); +int pic_read_irq(I8259PICState *s); bool i8259_pic_get_statistics(InterruptStatsProvider *obj, uint64_t **irq_counts, unsigned int *nb_irqs); diff --git a/hw/intc/i8259.c b/hw/intc/i8259.c index ffd09f6c61..3f10777036 100644 --- a/hw/intc/i8259.c +++ b/hw/intc/i8259.c @@ -57,8 +57,7 @@ OBJECT_DECLARE_SIMPLE_TYPE(I8259PICState, I8259_PIC) #ifdef DEBUG_IRQ_LATENCY static int64_t irq_time[16]; #endif -I8259CommonState *isa_pic; -static I8259CommonState *slave_pic; +I8259PICState *isa_pic; =20 /* return the highest priority found in mask (highest =3D smallest number). Return 8 if no irq */ @@ -175,33 +174,35 @@ static void i8259_intack(I8259CommonState *s, int irq) i8259_update_irq(s); } =20 -int pic_read_irq(I8259CommonState *s) +int pic_read_irq(I8259PICState *s) { + I8259CommonState *pri =3D &s->i8259[0]; + I8259CommonState *sec =3D &s->i8259[1]; int irq, intno; =20 - irq =3D i8259_get_irq(s); + irq =3D i8259_get_irq(pri); if (irq >=3D 0) { int irq2; =20 if (irq =3D=3D 2) { - irq2 =3D i8259_get_irq(slave_pic); + irq2 =3D i8259_get_irq(sec); if (irq2 >=3D 0) { - i8259_intack(slave_pic, irq2); + i8259_intack(sec, irq2); } else { /* spurious IRQ on slave controller */ irq2 =3D 7; } - intno =3D slave_pic->irq_base + irq2; - i8259_intack(s, irq); + intno =3D sec->irq_base + irq2; + i8259_intack(pri, irq); irq =3D irq2 + 8; } else { - intno =3D s->irq_base + irq; - i8259_intack(s, irq); + intno =3D pri->irq_base + irq; + i8259_intack(pri, irq); } } else { /* spurious IRQ on host controller */ irq =3D 7; - intno =3D s->irq_base + irq; + intno =3D pri->irq_base + irq; } =20 #ifdef DEBUG_IRQ_LATENCY @@ -353,9 +354,9 @@ static uint64_t i8259_base_ioport_read(void *opaque, hw= addr addr, return ret; } =20 -int pic_get_output(I8259CommonState *s) +int pic_get_output(I8259PICState *s) { - return (i8259_get_irq(s) >=3D 0); + return (i8259_get_irq(&s->i8259[0]) >=3D 0); } =20 static void i8259_elcr_ioport_write(void *opaque, hwaddr addr, @@ -410,7 +411,6 @@ qemu_irq *i8259_init(ISABus *bus, qemu_irq parent_irq_i= n) { qemu_irq *irq_set; DeviceState *dev; - Object *pic_obj; int i; =20 irq_set =3D g_new0(qemu_irq, ISA_NUM_IRQS); @@ -424,10 +424,7 @@ qemu_irq *i8259_init(ISABus *bus, qemu_irq parent_irq_= in) irq_set[i] =3D qdev_get_gpio_in(dev, i); } =20 - pic_obj =3D object_resolve_path_component(OBJECT(dev), "primary"); - isa_pic =3D I8259_COMMON(pic_obj); - pic_obj =3D object_resolve_path_component(OBJECT(dev), "secondary"); - slave_pic =3D I8259_COMMON(pic_obj); + isa_pic =3D I8259_PIC(dev); =20 return irq_set; } --=20 2.43.0 From nobody Thu Sep 24 19:04:36 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1789555587; cv=pass; d=zohomail.com; s=zohoarc; b=T3lUah9yK3oWiDz3sL0rVJxEA3D0B5oCHUzGoNZX0VuhYeWQR7fEU/5Xl+UqZGKwhW8VVOeUprnEOGmBHmtIQcSBTKpFpFI5WPAgNLybtLMzVjVMsRDNUAErNP4NAeozH6soG6k6RY3rvzt4mZN72Ul/9Evcani3IMmgNyVRtHA= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1789555587; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=pkJiFODl6b5vPY8FgP6Q0oGKEYfQCpQNYQchDr5v9co=; b=YB2vOAyKv385q1qHm+uyURLc8pSe0MEDX6sdFAUl/uRIdaTzGLsV5FW/2qzy04rz2a+ObYbkHVNq4Z6nlK0cT37MtnfZOi3+rSUrfe9lL2NPeJb+Pou3bDTO0vrVQQz1CsFD6Hol48ziUlJbyJ28qayOcfYwZ8DT9qDFDkQRF0M= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1789555587492880.486157912072; Wed, 16 Sep 2026 03:46:27 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1422671.1648100 (Exim 4.92) (envelope-from ) id 1x6n9M-0001rn-K9; Wed, 16 Sep 2026 10:46:00 +0000 Received: by outflank-mailman (output) from mailman id 1422671.1648100; Wed, 16 Sep 2026 10:46:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1x6n9M-0001rU-EL; Wed, 16 Sep 2026 10:46:00 +0000 Received: by outflank-mailman (input) for mailman id 1422671; Wed, 16 Sep 2026 10:45:59 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1x6n9L-0001iE-BJ for xen-devel@lists.xenproject.org; Wed, 16 Sep 2026 10:45:59 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1x6n9K-00A1UL-OA for xen-devel@lists.xenproject.org; Wed, 16 Sep 2026 12:45:58 +0200 Received: from [10.42.69.2] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6aaa735b-bab6-0a2a0a5309dd-0a2a4502b0ca-38 for ; Wed, 16 Sep 2026 12:45:58 +0200 Received: from [148.163.155.12] (helo=mx0b-002c1b01.pphosted.com) by tlsNG-720697.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6aaa7365-6ca4-0a2a45020019-94a39b0ce988-3 for ; Wed, 16 Sep 2026 12:45:58 +0200 Received: from pps.filterd (m0127841.ppops.net [127.0.0.1]) by mx0b-002c1b01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68G8IwgB639332; Wed, 16 Sep 2026 03:45:54 -0700 Received: from ch4pr04cu002.outbound.protection.outlook.com (mail-northcentralusazon11023142.outbound.protection.outlook.com [40.107.201.142]) by mx0b-002c1b01.pphosted.com (PPS) with ESMTPS id 4gqbx0sysq-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 16 Sep 2026 03:45:53 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by PHXPR02MB11343.namprd02.prod.outlook.com (2603:10b6:510:3cc::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.428.9; Wed, 16 Sep 2026 10:45:52 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::8e97:bc32:822c:b250]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::8e97:bc32:822c:b250%3]) with mapi id 15.21.0406.007; Wed, 16 Sep 2026 10:45:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=proofpoint20171006 header.d=nutanix.com header.i="@nutanix.com" header.h="Content-Transfer-Encoding:Content-Type:Date:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To"; dkim=pass header.s=selector1 header.d=nutanix.com header.i="@nutanix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=pkJiFODl6b5vPY8FgP6Q0oGKEYfQCpQNYQchDr5v9 co=; b=e9049sm0PfHTdb/e3IZbpZjrt9trDXuLq7dPoe3fpbjxj/anCFZWZKGC/ IxNYIHK57znEpgLL2gvBlq9LpSsdOwZYHbCRveetBHJrQPo6HiQBgDiL5uE/rIOt 3dJw0cwNUQvM360SVben66CvGNt1iPiBhn/666+DdCERXqEgBqw6WyTTmcQBQOKD gkiiAIGd2KE73d9rx3GIWNHXszCOZiuHxX5g9PnpI37yPOFnAv3EWAtfcmEnFq+B zlV48ktvvViYjA0tmIG4hyE3Ub8XrdlFBIQQPjW4QaPnC7I3xwbNejjRaEGD+NKl YRsyO/6dr+mT4zWkId2DbxtxLc7Kw== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=rY/IzxnfvawlFNkBlpQ8EedVOLOYiA6TurSUrH28gOvHV9G7qPBuNwfbtciQpp6GmJDJfcec5r1A2Uwk5de0t3NNxpQucCyGfwI85VbLk9nwmrPnfz9BvHBlRXjoIiUIulJaS8+HmiOGUQXzHG6zn+9u/14RMNA274qW9J2d9dz1PCvYgjOp/K7DkdqXe1IaK3hy1ZEYirwqfsf6XDGFXH77CFYaT8A7mYmOQ/OZrNYAvFW1L39JJ5OcsogvHbnCNEg1GffhFxDTFdJ017acAzBaplORhRODxHy9a3wmIT02ooNmeCl1CDxRX7N2flOyv5qjHNXzv6eWuuZiVM3jcQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pkJiFODl6b5vPY8FgP6Q0oGKEYfQCpQNYQchDr5v9co=; b=lwjvvX1cUnsEg99Jr9blNxLy1sXjPD1OzxfdIzUTIP6F177GA/PbedVXIghBelEBIptzu6DXj/HGPU2bWl2pJA+V6EcNUd+S9WuKXOexXl6zzzCtoSAZYHgYfpbHCpaJ8lv/HSs0/YVsxwTxyNAzmXM1HiPx7B0eD87W4pR5A4vWCP6Eeh8GLltmlnmkqm+erSbJfwztis0OpZZU/m5VVNi1zzZOvzkwzTVJ1dn8c/6BxKeHD+05qWPbiHVIDHCOnj/XNKxCpa8f6D4szZiAsHEY5GbmF1LFvtS5vDYQ3urvBEatzM8aabRhrV1GaR/Gx2zC0QxkyTGQrDX8g6nZbw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pkJiFODl6b5vPY8FgP6Q0oGKEYfQCpQNYQchDr5v9co=; b=YPmBrh44ongr2RCK67ATKBA2lSR2kdRpNWV3ZxNXmE8EV2s0orr61mrgzV3ndC6BDvz7m3B5ur65g1A7tbMejiclyg1Ef+Tz35+h4lACqrjJATvFOEqtXzV+hO8uguKod6/MdHbKe6/UvhUdO0iKFO6O50XbY7MfNfmbw2otoKVwmqxSdQgLshPEDu6qWFKGQ4k9w0WnIQmyXbRF8QnC3QJUtp5spF8Xe8dlTGydV0yOt02utmgsQ5aWzsghueC1JVMahGH8g60uWEThwUvLasHHHwwRvKLICX69CXhsP61ed4loy/dg13+sTtiMq+rYkvJt4+FXSBOg290d7xzCug== From: Mark Cave-Ayland To: pbonzini@redhat.com, richard.henderson@linaro.org, mst@redhat.com, sstabellini@kernel.org, anthony@xenproject.org, edgar.iglesias@gmail.com, qemu-devel@nongnu.org, xen-devel@lists.xenproject.org Subject: [PATCH 21/22] i8259_common.c: remove static irq_count and irq_level variables Date: Wed, 16 Sep 2026 11:43:49 +0100 Message-ID: <20260916104435.600211-22-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260916104435.600211-1-mark.caveayland@nutanix.com> References: <20260916104435.600211-1-mark.caveayland@nutanix.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SJ0PR05CA0077.namprd05.prod.outlook.com (2603:10b6:a03:332::22) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|PHXPR02MB11343:EE_ X-MS-Office365-Filtering-Correlation-Id: 7324f8ee-bb0c-4930-96d2-08df13dfadbc x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|1800799024|23010399003|18002099003|6133799003|3023799007|10067099003|56012099006|22082099003; X-Microsoft-Antispam-Message-Info: mny/sBr/FrGXACmPXrz0nt/UdwC9w+7/2ZbBP5GQtLMbTWA0ov4gxTRt9Kpyf6NRnwYxQ5/Ik/aXEdu/Uj9UQWGAZePcYSWfhTxY4WbpGpzbrXucFJmrt3TrOX+cnKMl1r9f5FCj8dv59rFISyeKlPe1tjQtpBcA5fffGpbIht8YuKWE7iMe+qbrLL/D8IEUH+0tZ7NONrSESBbmZRSnGfl8lyZmMuNMjgAnce9wJuZ8mXtc2LUlK5WORvQT0Na1UNjsa6pVcTk3r3o6U17pMR/fezto2RsvfNVVdxUT+O2du8AQ7fln5V7v0G01Xd+87C0TbivwRASZoQx9GlT8ZeUuI/UcWysfnMvE8Qop0tRMLS+YTglw4ydnGcQmnPjr43K+R23fexkruAud6Wt+E17OJxtPB4gOG/P6hJm0cyGdbF3xMdGUXlwED2I19PXeg5h9kV5PcMx6b/bnxb/MFYhMTLE/fdrGlpYrt3Q/7DMqUpF0JhR/Me0G5D9+gb5lDs4vil8QMSNjIYBsCQ5YFbgthZwPPvBQ5fhYjmzA+qrQ7YpFC0/QlLUVa2QAUisbcUhACOjc9RAil/pDFkkkuH0M6T7u8Z8o5p8SlfsSnqG/N1AILi+ytcNcFBjfVcr5+ZmM4WaWuKV3Fhq3E9rsIeNeiRTb02rVKesHH2T1n8k= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR02MB7159.namprd02.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(1800799024)(23010399003)(18002099003)(6133799003)(3023799007)(10067099003)(56012099006)(22082099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?2X9TcRXiJULb99j7T6SQRPC2gtmRqJkHeZXbC9UfcqnS8sx+Ypwcyp8FZXYS?= =?us-ascii?Q?ABMuuwk37B1/8gkBe0LGkZySJ89JvUhsLjaXJ/1mcG+7myZVlFL2/jT108jU?= =?us-ascii?Q?OKjtK6GRxQ2dsVSy6Scx7Cm4a34b3rnscBKXAstHzEpFJmvfplyJbbZCl8Gv?= =?us-ascii?Q?ZVrUMfzF+oUggugqTSw72zW6dGtba5a1DOKczwyP5kp59ORZ/wHlyIPdYOYm?= =?us-ascii?Q?5CyEspxIzjcwSKYbv+ir30oSKdYG3R8i8rzrfDPLGiM2IcqQKAwc6DURIFXb?= =?us-ascii?Q?nU+HX4rRkUrEmCfCvHPDfUxOFyckb3rriznHoxSaZdOgzhqfD0wT8Sz2pvDO?= =?us-ascii?Q?4ylbOMj2nzGyDcHqUR5t3L50YUGvCTbVIyJmRSI/C81lavu+h8fmzVgn1IFM?= =?us-ascii?Q?zL1TVEgtj6mub/nmLZ/KJDvX3+/Trnecb7rQ2Jg5sIyNn38dBjahB30WvPiL?= =?us-ascii?Q?LUMQ9FuUve12fWArvWzvds6+UJL2cOE0enla68Q1Nu4mzNqXpGFTttXcYl6c?= =?us-ascii?Q?z0bYry+poVCpobr/YoNeM1sXUlXjOxJOzhhcHtTFyFoFGcLcF6lMUuIY/48b?= =?us-ascii?Q?spVZBmqN8q0DB5CasgpUJ73Rxec4Xhpv4xVFPIWZ8yq1s33XqddZ7WqxtFwJ?= =?us-ascii?Q?hojQ4m2IYuE1L0owiTR009Eh5P7fiKJiMhZ3s50TUzRB4ZZm5F7ISASWBUq6?= =?us-ascii?Q?Xx0bymFj7erCJrZgUXQ5B/DSwbeXjYRLk9tLKZRyYpr0ZtJi3iX/JBYq2b8K?= =?us-ascii?Q?inSl2YdzbAczMNNEgV1cNMcW6IYaCKIBGShZzMLdTunE+xN4EoqTaDy+W0HJ?= =?us-ascii?Q?XWVe7X20KOVEHzEIS8jdxL7aIwf3wDABFaium71xWZfCq/VNr9ep7DJf7xF7?= =?us-ascii?Q?mSvaxXkfZAsNEvJIh/Jypulqbj/KQKTY0+Qvf9d6eYIVmcA1H8Qbuurf+iwG?= =?us-ascii?Q?9NoIULh3pbX/8zkJh4mvzmSvouKdQMlbIFXHTyXoB8U1SrPBXjt5Mc10LSNG?= =?us-ascii?Q?FnlKEBBcMkV7xGf2zGlPZWPfG+q5CGZScjlD5jdeFSKuT3jUpF2JByZzu4Nx?= =?us-ascii?Q?EwEAENvn28NRJkagv6YILcRlbuwh9Ydu9cCt0id2mwTem19CeNaYEVXLDJDx?= =?us-ascii?Q?eJVRx5eHoYaJF+o5Iw6FuRorE2oQ1kWQe/3FS2yK5C3QLj0EgXKmMG2NQ0q4?= =?us-ascii?Q?wtutMBFgOB4n8aaAM8mr9fer8hx+zoePI3TaXePZYSB2Vli7wwJVAE7/W5Lv?= =?us-ascii?Q?CIeyU6xB6Ba7hv+rVuT5NsSUdPlFCg34UY8qXgjVrut+LP+zPRsX2Cng1Pwb?= =?us-ascii?Q?w+QPuGPjAzIZWeNFMcWpWDZHyubJiepvRAXxPe3g8w2w2jAhLmevZvGyJM6v?= =?us-ascii?Q?ySpTGeS7zTdLal8SbOqz+TYjBEr27iH6srNkee28MQ1hB2Fe9BCKjWinRQ+T?= =?us-ascii?Q?KYWjNOo7Asi0uG6JxSRC/odDcN4M85I5UfFrvyDaVBsboSeZPFazSKsCnQ7G?= =?us-ascii?Q?Te/1/IG+UYK09TgXjLbAzzczdrJHD5rr9XcQ1YURk6tm3NcGbrzEeLRGTLHe?= =?us-ascii?Q?y59HugkI0+2QlbHN6kBmiKaozmHFL5uM2YPFJO4VVn/W64cc1gqLTrOhoNGJ?= =?us-ascii?Q?bV2BXDhABNUyT7b279eC6iKRCk2iQhtexoMBq/Vc8sEYlUVWUAKefyx1T7+R?= =?us-ascii?Q?vxBcpU84mX3P73xIhv8+ZC3mT+j3MFnvtkeo+ZQ+P4R/+JUJ/WuYzfD6VMPx?= =?us-ascii?Q?tCAuwfbQtOWLyom57THudj48mrXNjaE=3D?= X-Exchange-RoutingPolicyChecked: KTivrjYdFvR7SJHrTTBQzO5zaHde9OiVioRlXndUZzYsc9CQ4KNRDFEIoMJPBBdGQbvA/c9RKoVHge2XcgtSW3LxOE864nnbWD4Nhf6ZeEc77PoKt5nTtvRgp9n9sPoX6MoewabeRsALjCdpN2YB3H5PxAAUPlPUK99j8SCJrWh9yAFQG2lL+HzBATwFpIy09ADfz4fpvhaOnfmSBGFf/SpNaCeyqETrzoilx4UFtwHHZ7ANjdNtnVWIT/j6q6tDIBbH1fCeAL7c1ONutkOyZDEQYzshOwaz0V+MpU86h4byZI2BxCEeUzmInw1kgTNk+eGgv5EKp5Gdu1tM9nDGgw== X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7324f8ee-bb0c-4930-96d2-08df13dfadbc X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Sep 2026 10:45:52.6825 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: fSxUaaZf+rCVhXhIsmBB4cJg6SsDwqqWoeVwkOEUYYlsbMyXk9WXDqm5UIDfJcadDc76n9ijQFtb8p4GMg/bHZfOTEe2M4wUycvJUBlcADY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PHXPR02MB11343 X-Authority-Analysis: v=2.4 cv=Xq5vqlF9 c=1 sm=1 tr=0 ts=6aaa7362 cx=c_pps a=nzP3m+/CqRdBhj8fzGTHBQ==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=xqWC_Br6kY4A:10 a=VdqzKS8jKosA:10 a=0kUYKlekyDsA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VofLwUrZ8Iiv6rRUPXIb:22 a=jxMXjlTPpCISP5mWtjnE:22 a=64Cc0HZtAAAA:8 a=KJqig-R1GVLqmjI8InkA:9 X-Proofpoint-ORIG-GUID: WfxuQKVPr1TjN3bNhFd63-_04f_peMQh X-Proofpoint-GUID: WfxuQKVPr1TjN3bNhFd63-_04f_peMQh X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE2MDE0MSBTYWx0ZWRfX5UNtd2mNsJum XxPo9EBN659z2gNVDxbcWR9b4FW+aTQPHhrSycdSTvKg/6vxyMmYwJSObgfzewZJP9PiidJ89S6 692RIxLRpfIq9loS0TtKWqkiv+hevcU= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE2MDE0MSBTYWx0ZWRfX7MOwfRkdisx0 bjEnOu6jpiYP887LHQj9oYMyv5JwN3ofpx0aVnzUy7X2m4khh+fwq0etKCMQ8SNQbcC7unWMOVJ mMgTyDI+PMJLuCHbdcFo95VRILXapfrEAUiYYyi1mnsUKH8OHYDwTNPuCofBJmq+jjSeqMxw3i5 fQd1x5raPK/EatgA2L0jTc9JpYaeU9D1a2l9/8WyIX83+spH1L1szQApbg4uC9PrNRGOvyXOS1Y PbfYRwHULsUcc36bZUeFxME25LSOjAL7G4y4tjHfeEFr4jqiMx5RdD6P/Hz5MXqeb1Olw1Ob/IS UIHhgmbf6tX8WnMz2vbSsafH/A3UdocCmmIw4LiibB/lReUzQMR5mQaXyFVTi2yDePbF+jcPTVi hYc5mCeDGpVigdlfD3Ue/FMGQlEfmgEG9y6ydcU5IdV0sA0bsLZBIQ6RvfhFS802t4PxTLlxpUU yeGZ2YvKI1Sb8FdrI6Q== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-15_05,2026-09-15_02,2025-10-01_01 X-Proofpoint-Spam-Reason: safe X-purgate-ID: tlsNG-720697/1789555558-F0AA52AC-A8EA178E/0/0 X-purgate-type: clean X-purgate-size: 7331 X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1789555589126158500 Content-Type: text/plain; charset="utf-8" Adjust the parameters to i8259_stat_update_irq() to allow passing in pointe= rs to the irq_count and irq_level arrays, and then move the arrays into the corresponding i8259 PIC and KVM PIC devices. Doing this allows the statistics capture logic in i8259_set_irq() that hand= les incoming cascading interrupts to be removed. Signed-off-by: Mark Cave-Ayland --- include/hw/intc/i8259.h | 3 --- include/hw/isa/i8259_internal.h | 3 ++- hw/i386/kvm/i8259.c | 20 +++++++++++++++-- hw/intc/i8259.c | 40 ++++++++++++++++++++++----------- hw/intc/i8259_common.c | 21 +++++------------ 5 files changed, 52 insertions(+), 35 deletions(-) diff --git a/include/hw/intc/i8259.h b/include/hw/intc/i8259.h index 72be7c3de2..2efdaaca2b 100644 --- a/include/hw/intc/i8259.h +++ b/include/hw/intc/i8259.h @@ -21,9 +21,6 @@ qemu_irq *i8259_init(ISABus *bus, qemu_irq parent_irq_in); qemu_irq *kvm_i8259_init(ISABus *bus); int pic_get_output(I8259PICState *s); int pic_read_irq(I8259PICState *s); -bool i8259_pic_get_statistics(InterruptStatsProvider *obj, - uint64_t **irq_counts, - unsigned int *nb_irqs); void i8259_pic_print_info(InterruptStatsProvider *obj, GString *buf); =20 #endif diff --git a/include/hw/isa/i8259_internal.h b/include/hw/isa/i8259_interna= l.h index 53751b045b..53d8e087eb 100644 --- a/include/hw/isa/i8259_internal.h +++ b/include/hw/isa/i8259_internal.h @@ -72,6 +72,7 @@ struct I8259CommonState { }; =20 void i8259_common_reset(I8259CommonState *s); -void i8259_stat_update_irq(int irq, int level); +void i8259_stat_update_irq(uint64_t *irq_levels, int *irq_counts, + int irq, int level); =20 #endif /* QEMU_I8259_INTERNAL_H */ diff --git a/hw/i386/kvm/i8259.c b/hw/i386/kvm/i8259.c index 421c9279cd..ca661afc02 100644 --- a/hw/i386/kvm/i8259.c +++ b/hw/i386/kvm/i8259.c @@ -30,6 +30,9 @@ struct KVMI8259PICState { =20 ISABus *isabus; I8259CommonState i8259[2]; + + int irq_level[ISA_NUM_IRQS]; + uint64_t irq_count[ISA_NUM_IRQS]; }; =20 OBJECT_DECLARE_SIMPLE_TYPE(KVMI8259PICState, KVM_I8259_PIC) @@ -102,6 +105,18 @@ static void kvm_i8259_put(I8259CommonState *s) } } =20 +static bool kvm_i8259_pic_get_statistics(InterruptStatsProvider *obj, + uint64_t **irq_counts, + unsigned int *nb_irqs) +{ + KVMI8259PICState *s =3D KVM_I8259_PIC(obj); + + *irq_counts =3D s->irq_count; + *nb_irqs =3D ARRAY_SIZE(s->irq_count); + + return true; +} + static void kvm_i8259_reset(DeviceState *dev) { I8259CommonState *s =3D I8259_COMMON(dev); @@ -114,9 +129,10 @@ static void kvm_i8259_reset(DeviceState *dev) =20 static void kvm_pic_set_irq(void *opaque, int irq, int level) { + KVMI8259PICState *s =3D opaque; int delivered; =20 - i8259_stat_update_irq(irq, level); + i8259_stat_update_irq(s->irq_count, s->irq_level, irq, level); delivered =3D kvm_set_irq(kvm_state, irq, level); kvm_report_irq_delivered(delivered); } @@ -210,7 +226,7 @@ static void kvm_i8259_pic_class_init(ObjectClass *klass= , const void *data) =20 dc->realize =3D kvm_i8259_pic_realize; device_class_set_props(dc, kvm_i8259_pic_properties); - ic->get_statistics =3D i8259_pic_get_statistics; + ic->get_statistics =3D kvm_i8259_pic_get_statistics; ic->print_info =3D i8259_pic_print_info; /* * Reason: must be wired to the ISA bus via the "bus" property diff --git a/hw/intc/i8259.c b/hw/intc/i8259.c index 3f10777036..ac43995ce4 100644 --- a/hw/intc/i8259.c +++ b/hw/intc/i8259.c @@ -49,14 +49,16 @@ struct I8259PICState { ISABus *isabus; IRQState i8259_primary_out_irq; I8259CommonState i8259[2]; + + int irq_level[ISA_NUM_IRQS]; + uint64_t irq_count[ISA_NUM_IRQS]; +#ifdef DEBUG_IRQ_LATENCY + int64_t irq_time[ISA_NUM_IRQS]; +#endif }; =20 OBJECT_DECLARE_SIMPLE_TYPE(I8259PICState, I8259_PIC) =20 - -#ifdef DEBUG_IRQ_LATENCY -static int64_t irq_time[16]; -#endif I8259PICState *isa_pic; =20 /* return the highest priority found in mask (highest =3D smallest @@ -123,16 +125,8 @@ static void i8259_set_irq(void *opaque, int irq, int l= evel) { I8259CommonState *s =3D opaque; int mask =3D 1 << irq; - int irq_index =3D s->master ? irq : irq + 8; =20 trace_pic_set_irq(s->master, irq, level); - i8259_stat_update_irq(irq_index, level); - -#ifdef DEBUG_IRQ_LATENCY - if (level) { - irq_time[irq_index] =3D qemu_clock_get_ns(QEMU_CLOCK_VIRTUAL); - } -#endif =20 if (s->ltim || (s->elcr & mask)) { /* level triggered */ @@ -209,7 +203,7 @@ int pic_read_irq(I8259PICState *s) printf("IRQ%d latency=3D%0.3fus\n", irq, (double)(qemu_clock_get_ns(QEMU_CLOCK_VIRTUAL) - - irq_time[irq]) * 1000000.0 / NANOSECONDS_PER_SECOND); + s->irq_time[irq]) * 1000000.0 / NANOSECONDS_PER_SECOND= ); #endif =20 trace_pic_interrupt(irq, intno); @@ -439,10 +433,30 @@ static void i8259_class_init(ObjectClass *klass, cons= t void *data) } =20 =20 +static bool i8259_pic_get_statistics(InterruptStatsProvider *obj, + uint64_t **irq_counts, + unsigned int *nb_irqs) +{ + I8259PICState *s =3D I8259_PIC(obj); + + *irq_counts =3D s->irq_count; + *nb_irqs =3D ARRAY_SIZE(s->irq_count); + + return true; +} + static void i8259_pic_set_irq(void *opaque, int n, int level) { I8259PICState *s =3D opaque; =20 + i8259_stat_update_irq(s->irq_count, s->irq_level, n, level); + +#ifdef DEBUG_IRQ_LATENCY + if (level) { + s->irq_time[n] =3D qemu_clock_get_ns(QEMU_CLOCK_VIRTUAL); + } +#endif + qemu_set_irq(s->pass_irqs[n], level); } =20 diff --git a/hw/intc/i8259_common.c b/hw/intc/i8259_common.c index 7980f86f1f..3511303c21 100644 --- a/hw/intc/i8259_common.c +++ b/hw/intc/i8259_common.c @@ -30,8 +30,6 @@ #include "migration/vmstate.h" #include "qapi/error.h" =20 -static int irq_level[16]; -static uint64_t irq_count[16]; =20 void i8259_common_reset(I8259CommonState *s) { @@ -89,26 +87,17 @@ static void i8259_common_realize(DeviceState *dev, Erro= r **errp) qdev_set_legacy_instance_id(dev, s->iobase, 1); } =20 -void i8259_stat_update_irq(int irq, int level) +void i8259_stat_update_irq(uint64_t *irq_counts, int *irq_levels, + int irq, int level) { - if (level !=3D irq_level[irq]) { - irq_level[irq] =3D level; + if (level !=3D irq_levels[irq]) { + irq_levels[irq] =3D level; if (level =3D=3D 1) { - irq_count[irq]++; + irq_counts[irq]++; } } } =20 -bool i8259_pic_get_statistics(InterruptStatsProvider *obj, - uint64_t **irq_counts, - unsigned int *nb_irqs) -{ - *irq_counts =3D irq_count; - *nb_irqs =3D ARRAY_SIZE(irq_count); - - return true; -} - void i8259_pic_print_info(InterruptStatsProvider *obj, GString *buf) { /* No information for i8259-based PICs */ --=20 2.43.0 From nobody Thu Sep 24 19:04:36 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1789555583; cv=pass; d=zohomail.com; s=zohoarc; b=fS4iE64Ku3mOyOLxA9r4iyqqL7Lgu7NRt+EtETxUE/DVf6IAQGbfYbC18eJaRMqLCrgrmtfpaid+7d+EB2/MfLWUAqnrLzgcEc/1Yj5MPMlHhGnk5RNTPGbYeYuCLdnqtqXhNkRw6xbVaFDZYCSUl7awZTLj+dYCYRUm+ToRV1Y= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1789555583; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=JTc6OttRkqFr2IJN61bUNmzaH+my9K//Vu9fu/m3ZOo=; b=Q8zLAiG5eR/VuCaoYDb439256/GA/Um9GbKauyROBUZx23EVSguscIS/jehw9HKoZsKOR26i9+Okr5GeVdb7isRe3GQmc/dKD2ug5FRjvOCFMQwzawNrTQoaOTfG/Z7hpOSjuv2i+2aTtr0I2VbejFfkr+Gs2Kmo+Xoi4uIfMUw= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1789555583639176.5925640590409; Wed, 16 Sep 2026 03:46:23 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1422682.1648110 (Exim 4.92) (envelope-from ) id 1x6n9R-0002Sm-8P; Wed, 16 Sep 2026 10:46:05 +0000 Received: by outflank-mailman (output) from mailman id 1422682.1648110; Wed, 16 Sep 2026 10:46:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1x6n9R-0002SQ-1P; Wed, 16 Sep 2026 10:46:05 +0000 Received: by outflank-mailman (input) for mailman id 1422682; Wed, 16 Sep 2026 10:46:03 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1x6n9P-0002NI-Jc for xen-devel@lists.xenproject.org; Wed, 16 Sep 2026 10:46:03 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1x6n9P-005QYS-09 for xen-devel@lists.xenproject.org; Wed, 16 Sep 2026 12:46:03 +0200 Received: from [10.42.69.12] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6aaa7363-8faa-0a2a0a5109dd-0a2a450c9f74-22 for ; Wed, 16 Sep 2026 12:46:02 +0200 Received: from [148.163.151.68] (helo=mx0a-002c1b01.pphosted.com) by tlsNG-d25034.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6aaa7369-f479-0a2a450c0019-94a39744a6da-3 for ; Wed, 16 Sep 2026 12:46:02 +0200 Received: from pps.filterd (m0127837.ppops.net [127.0.0.1]) by mx0a-002c1b01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68G8j54T700548; Wed, 16 Sep 2026 03:45:58 -0700 Received: from ch5pr02cu005.outbound.protection.outlook.com (mail-northcentralusazon11022122.outbound.protection.outlook.com [40.107.200.122]) by mx0a-002c1b01.pphosted.com (PPS) with ESMTPS id 4gqa0ka9yy-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 16 Sep 2026 03:45:57 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by PHXPR02MB11343.namprd02.prod.outlook.com (2603:10b6:510:3cc::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.428.9; Wed, 16 Sep 2026 10:45:56 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::8e97:bc32:822c:b250]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::8e97:bc32:822c:b250%3]) with mapi id 15.21.0406.007; Wed, 16 Sep 2026 10:45:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=proofpoint20171006 header.d=nutanix.com header.i="@nutanix.com" header.h="Content-Transfer-Encoding:Content-Type:Date:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To"; dkim=pass header.s=selector1 header.d=nutanix.com header.i="@nutanix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=JTc6OttRkqFr2IJN61bUNmzaH+my9K//Vu9fu/m3Z Oo=; b=HPSF88vcHpu7V/6CCbEPY0gTGaylMCyFJnShtb5Us1jBlFEwmLF9UF7fT dXsTg9f6OIrEibOZ4HSP6i/tpZFQX6CO16VxXk+Czc09EhoBsTo+imeyPx3ewVHl Na56EQeUQ9Uh4/vorX/WdeUhulUj0GtvNEYRDKXzyR96rXQtbEJz1KZNu/foRSSN ukkFP5u+gGRhOvMMvI1c4gPQmR7eXvfskk/i3pLAwU8XE+nMVIkMAWLIm0pdZOld cMVReFQEq/7o6FAIk7Pts7/owFv15049fuWXECv0SifZuwslkOGh+ktFTjawWpY/ l+/dAmQDooIHRsEEQ89vlh5mu18LA== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=GWBUpy6cJOv/8rH4IrKRao34eGCsqct/+iCDZM9JNMAxSmJF1a0LqXul+2BdWXURctViicXLDdoGRHqM940YI+uxTOeD8ohB3VOSqUCMxF0YZsq+FGQ2fw1VEqsCWIzB6Z1hczCVwhDCMtIk2hAWfao0tSsKC5jYvDv9inVCClpl1aWXg+hWXTls8C8waV01woEvxYrqKmaAtzT0Cgdj6E4xs2fzKGhV+LnsFNRw9zrp5zs6R1EfljfSOZQKcppJxUTcc7+D/b4+WQz6bOGOhKlaTLe+htC38ysbbVYCLs0kWkSZfYCOTYN5it3EodCfGTy7h3hq17A9rHeDEz72UQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JTc6OttRkqFr2IJN61bUNmzaH+my9K//Vu9fu/m3ZOo=; b=VvDbG8iywoiJWTfQkfw6b4ogjC42TCswTdDfqaDkLw/NVSXLZ2iwyHFHYtluE/fHhiE7EuIuEs89nTltfhvd0w0BZBHYH/1Gu+HjmM0Hz0hKNnGqJ89qKfXm2wyP7SPc3lcvwUu4bCCfjVvJG8IbOO3qq0EiOPcpz/WtIb4B8ERJHDsVXzqiQiAFUqtJ1iLCDz+JFfZ1mQv06VXdOIkCT+K6dPdTAXXVe5lZ+zyP92sc5uoIdfC0StOk4vDMv61LvuxQf8msDqPKufsrhoMqk8xTW6+HcVgjjxs2w/WwtSg7w5rfwFfwfAch3wjXSQu1NKcpbDlQq9WZ3DlgSnPmfQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JTc6OttRkqFr2IJN61bUNmzaH+my9K//Vu9fu/m3ZOo=; b=iLm1wj2oLJHdcLkjedcYjgWDcttr2XQEu2rdQqgZhTYtBSE9WcEg9JRuOme939+lBNYCxy2WYKW83Q7U57yVWEHzjVe+awcANQo5wqx10iqTkKNtKTD4GCxRLEqfG9eOdYsQK/pEuzDrJO1PRQ4j49ZxVYQh+wWlC8o2SNNi6JcdhDXLiC04KswPtyNLLH8xCBGxnGqhKiAgtIjyigDbrZ3ecy8zGjCyvLtvFFPz5X6Ct/8lVwPStRZWOD/HR2QRfDXSAQ3zOo2bJrl2rVXeYuzd1CpCxRomMvu6pf0gtaASqRFoRxvbV8wiJ+dZC9VXJXzFLAFAJSOEVS6c5rUUlA== From: Mark Cave-Ayland To: pbonzini@redhat.com, richard.henderson@linaro.org, mst@redhat.com, sstabellini@kernel.org, anthony@xenproject.org, edgar.iglesias@gmail.com, qemu-devel@nongnu.org, xen-devel@lists.xenproject.org Subject: [PATCH 22/22] i8259_common.c: add missing 0x prefixes to "info pic" output Date: Wed, 16 Sep 2026 11:43:50 +0100 Message-ID: <20260916104435.600211-23-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260916104435.600211-1-mark.caveayland@nutanix.com> References: <20260916104435.600211-1-mark.caveayland@nutanix.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SJ0PR03CA0074.namprd03.prod.outlook.com (2603:10b6:a03:331::19) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|PHXPR02MB11343:EE_ X-MS-Office365-Filtering-Correlation-Id: b282492a-627a-4b7e-460a-08df13dfb024 x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|1800799024|23010399003|18002099003|3023799007|10067099003|56012099006|22082099003; X-Microsoft-Antispam-Message-Info: o5fIuqwFZ6u2uLBnHwEQkkattin1LC/NI8LYF1LAGWQPhnYmafuQ/2ayPYEd0yxY40fO9ol/5nv9gnr+urPQtkaDyCsvFD+r88NLjAESze6AzOtldEvUsDrmxhJlP/WeYL3rGzAk0J06wsx/d7IESxWDKQ/rNshi4ufhBrmc9uymQbi9xZ+13nE/9ZLUxKLAAQaF04WcV1ozNn9JjTD22RUN1lJbYu3p9QyjybnLJWNhB6+zdCBSz0Pn3GyFr9hkbakhrYKRtb05H9z9xa5qHxrgXKspvtj7nz1is9XZjoffIggDEIHJJCRg+AsHkkeRT2y4B4U7Q2AVtwc3HqYxqJcB5IH1ABn6YAOad/CeLbDmVCExxpg0XUmyPnkZ2EP5L+512KHaZb3BFRBOPlSWyGH7YGcces8gKpdvMmGJL3dBZdKU9i7AuQuwRATZKVPLi41x788x6BsIuQFNaCl7Gh3btyTy6WjdykWMG/f4iFbwnj+tI+89zrIdNUWMYptYbWtkh7SgyOPAJr33zsA8vEtllF9VGKhKEQjobxa9Tk16U5CRmhJDssGI1hGjQH+Ktpf+UtGram2hH7pOs8R0Pc4TUDTv+o7Vtw8+yCSFkp38FhOXl+YsigHEMaIhwCQ8gHF0KGbJyjOQXYN/fxAJBo5cPoMlt2eVxDreqKv0YJg= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR02MB7159.namprd02.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(1800799024)(23010399003)(18002099003)(3023799007)(10067099003)(56012099006)(22082099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?eCw1hWh2Qh3daljCkUA8m1AsNubDKl1vUdFi0U4rndIZeak/ypnCLW+GjyON?= =?us-ascii?Q?fDNZtZw3CyX+wo4d7U+wWKaLpfP0N+iv6HzvxZG6Xy2i1yFH/SDtwGkMipEs?= =?us-ascii?Q?sDJHT4vgxddJmKXjEHrjacWG6rI09l9nYVF7Xiqq4xcEDX46yfFB9xXPKFXK?= =?us-ascii?Q?4E8FGYv/Vq+tTTAW7n8jzjWjc20a7hBNwOGm1yvnl+Qsmzra+DA0iof4+HwN?= =?us-ascii?Q?/cwfqe0sImMa4PshlofRih4Hsbrlu2P2pLVbjbU5n4uGnTOYDbOvIwui19um?= =?us-ascii?Q?uuWHR6qDGSTG6QgYpEbUWZjgNVM+2IMeLrS8UsW2s84/Fz3+brZq55/+NYGs?= =?us-ascii?Q?PMpH39DWZWSJYvxlC8V11dYdeUVJBRZSZhVKa5Yo3gnpjGJr1jgIBC50YMXF?= =?us-ascii?Q?ORankv1NgDZexVF0Jq7JbwMjby01f0mkb/wpGj8Kk+SYV2DS3gCHGpY/y0jy?= =?us-ascii?Q?17FN+8aqpXsK0JTuVUD0KI3gAEAYcA/fNYKm8iDbrkI2oCCR/qYIg4BKydvb?= =?us-ascii?Q?l5KCNvo50fgja2rFyukWJqQezcJ84KFk8vdVHa++6zKbnwedMOB/zzcJ0mEN?= =?us-ascii?Q?JOqRWvDWIbcP5hz9ejtx/6bFT1JEQtdbh+lbGALQr6+KwkjEgBdTvg+jHVh1?= =?us-ascii?Q?Bdkg9UMWhJ+4VzjXE28STL95BgrvY9ChFOOHkQMdzgSao/Bh2beBuvCXSVbm?= =?us-ascii?Q?M4G1fkcGk3sHj7HiRRJNGBRxCvgFtKSTMSNr+P8lIP6OM725aceMY8ZZnCBs?= =?us-ascii?Q?l4ouMcVYWwxchhTsyGlZ82XXbdXka8xpgN49qdn4UY4tE74YwneO8n33BD++?= =?us-ascii?Q?Jq9VZ8bDjgpxtJM5OsPSQHxGLHdwWWqpR0XBx6d1RzVyKhmG8cpiPcp3kES6?= =?us-ascii?Q?y/q84v/j/0la+ii70kcaHThlqHEQSeD07VfHPjztOMGXeGwFdjD0jIZlx60M?= =?us-ascii?Q?9xUMsIHNnW+B5ii0XSjc7UqqSH8xWVaAXPRu5vji9wAiMXJ2/9TRfI/Ys5Qv?= =?us-ascii?Q?Toj0R+yAcBOu1iO5YIzHMbq/8Knqr+wZQKs0KUF5FsRkcWZGxqf05BXuEB5s?= =?us-ascii?Q?6x7lUBjEhJeagCt84g/SuS5wfO4lgxcbit+8bNodbQnaJRsZwB0IxSJTPdde?= =?us-ascii?Q?rV/T84WB2BdiQ4O7rT0G12+Ff+4BJlW+ACt6B6ZgzuR1Oda1OrB3B4Ri0iff?= =?us-ascii?Q?zYJ9rmcY2jMcWUgX3p7AtZDtN8VZBrXfNiJ9hbirVJtKJMkS3bOtoP8au53/?= =?us-ascii?Q?T71YbvxHWJgGX5e8DRA2uwTTDORA0Kl9nhQ9+X6jGPK0GLuMXx6FG4fqtTgY?= =?us-ascii?Q?AaxDzvgN7MGmyP5xIZygl7APS4f4MnrMvAlzNU0F1JHMk2D0FDD+HmdC0FnB?= =?us-ascii?Q?Ksg32eilX/oy+BzINuyLdi5to1sQI9/KuJOUeZjh4rQ38IFWtiP+dE7WbqrV?= =?us-ascii?Q?+rjZnWSaYPd6mQ01yAylmTK1FW28uiJ/31EU/5mc+O68Gtw5KPONkgmMn/Mp?= =?us-ascii?Q?W8BlEcF1v5c49DKtVcoj5qBEmQ5Dx1RTsygGhZhKlxE2/4b1nTfwnZC7v++W?= =?us-ascii?Q?TNtr16YoYK13U2FVi4cbfPe6VugqtHHp7Lv4aR5tIcxVuuySDxs43ZOaeq0f?= =?us-ascii?Q?7ihM6YhEuRtyXhGIw8vnPbclLILKkBiaqpONTUhqoopSo4V8W0UK4hm/qIxA?= =?us-ascii?Q?BEekkOfj2xKktU8fwD9Ayc3DqFBBz8wfsYvnplruj4/tnUHw7czxuz8iI5AI?= =?us-ascii?Q?/4BJL/dxFMfBx/EFTRP6Gh1Sl3jxbNI=3D?= X-Exchange-RoutingPolicyChecked: UVopdt5oxqgddegIluQzc1POBGWpGLLlOgrj/UBD+y5nszAu7D5M4JxxH2+cyepGzjCNr7In9eq+hAeNPt4/JEF72BBwznf8N/peTHytsz6J74SllwkbbLJaWqVltpCVaM69q8RvQLKC6SX6HswXhi6q/ZaJ0ROh33Gfay5VrpmrUSiFJl+gK1FiX9hjMve4jF+8CQvH7MzwyCSxPQVPf5ks5ofqE4US2mgf5TrCzZ6Q7Qm04mufjikHMgAQAMuXvZKuDYU62Q2V7d7if2EniCWjmRioD7uojqAOhwMBBQ9fzyNQRgOktF8l0Db5QgHzXpykxTs2vhwG9vXTKjIQrA== X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: b282492a-627a-4b7e-460a-08df13dfb024 X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Sep 2026 10:45:56.4409 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 7RSu3+crYflFY0p8Nw54PssXWVyLZaZ1UqrFM1v9ctcvD3rwNyug7WmrMtjKEJ8yuortByDYmcoPsNYN1VYocNFQknDlpoGpzG/Sv+EWioI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PHXPR02MB11343 X-Proofpoint-GUID: SkqHOwJ-R7bjBoqc8w8XNeV6j_Zkt_z6 X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE2MDE0MSBTYWx0ZWRfX7BVlohr3YCLU 9smf44hdQb7QhqOzM19zvNIbYsTMLcpXN+LZw1un/gs3w7rAs6mhu5aUHsaclUupk87JrAIAv7m rtf+sIK5e8tvikI9Ghh/cXZaeIQBA/M= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE2MDE0MSBTYWx0ZWRfX61FSD+DTlV+h 2QIuL4OO/xAtIB54PnCW0pHxszWMPxXGpz1xLHM1h5aaIao56ll3Kg8eK+SjQCHY1jhvjwMRgE7 0BD8fSDiNIhVTMGA2TDpP+s49jERuXextxEJqCi54GLhYXe4LKq0csIU4aiESsjkPHxfx6NLJZk c8MIAcKLbm1gQWm/O0gc0KKJJgL+FqOWvEGti8/lj+2D97HfdFY/xq3vzq2QLB9GGIngCcn1pbi 7UGO4ztsBIGSpy1qxczzbybzzoNwvnImeJ2c45PbGZwgeo1QO0/M3fxRQozFQaCLG4yL0goyeVD FQ0aa50IygeRQFJ0lryfDtb2Z24NkHbARhAlVFy/IpYP9jwLqVP3Gh3fkhHqcHfWKLpfOaIcl2K rRr+tMnVvvoJXcvrm1h52wmpxy7HRUQAE9TDiU1G8u+gF5LNl76EnneX7fRQEGwxMo5wPgpKmsS pvEsLyTa5uhvnpylm8g== X-Authority-Analysis: v=2.4 cv=P46vFSAu c=1 sm=1 tr=0 ts=6aaa7365 cx=c_pps a=jsJx5cRpnMcsqjM19+T+dw==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=xqWC_Br6kY4A:10 a=VdqzKS8jKosA:10 a=0kUYKlekyDsA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VofLwUrZ8Iiv6rRUPXIb:22 a=Ap8k9tRZuQ82DLYWQqG7:22 a=64Cc0HZtAAAA:8 a=ap9nPAedobMI28Fi-wYA:9 X-Proofpoint-ORIG-GUID: SkqHOwJ-R7bjBoqc8w8XNeV6j_Zkt_z6 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-15_05,2026-09-15_02,2025-10-01_01 X-Proofpoint-Spam-Reason: safe X-purgate-ID: tlsNG-d25034/1789555562-014C7A5B-B28A8292/0/0 X-purgate-type: clean X-purgate-size: 1136 X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1789555585113158500 Content-Type: text/plain; charset="utf-8" This indicates that the specified register values are being output in hex. Signed-off-by: Mark Cave-Ayland --- hw/intc/i8259_common.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/intc/i8259_common.c b/hw/intc/i8259_common.c index 3511303c21..64d6f3e959 100644 --- a/hw/intc/i8259_common.c +++ b/hw/intc/i8259_common.c @@ -119,8 +119,9 @@ static void i8259_common_print_info(InterruptStatsProvi= der *obj, GString *buf) I8259CommonState *s =3D I8259_COMMON(obj); =20 i8259_common_dispatch_pre_save(s); - g_string_append_printf(buf, "pic%d: irr=3D%02x imr=3D%02x isr=3D%02x h= prio=3D%d " - "irq_base=3D%02x rr_sel=3D%d elcr=3D%02x fnm=3D= %d\n", + g_string_append_printf(buf, + "pic%d: irr=3D0x%02x imr=3D0x%02x isr=3D0x%02x = hprio=3D%d " + "irq_base=3D0x%02x rr_sel=3D%d elcr=3D0x%02x fn= m=3D%d\n", s->master ? 0 : 1, s->irr, s->imr, s->isr, s->priority_add, s->irq_base, s->read_reg_select, s->elcr, --=20 2.43.0