From nobody Thu Sep 3 07:04:04 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=amd.com); dmarc=pass(p=quarantine dis=none) header.from=amd.com ARC-Seal: i=2; a=rsa-sha256; t=1787639058; cv=pass; d=zohomail.com; s=zohoarc; b=B63hwEBnWBOCsTY8odPMaSPzNX4tb9mcANFd3tQtKoswrKH9F4/H1gvBIVJ/mYnMWvumLOu4GrHIRtuv8/5X4dJa6ghkIj6VaXUQsPPMPvQVIDHd9TjAvRPNbc8WT8e9uVj6T6y/nWh6+9qP5WoCkcwe1d5h1kwO3zsghFQorG0= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1787639058; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=t0tG7LxrvduKAPMs/G1qHGRWDG7gX+0MAt1PYS3j94A=; b=PHzPPN0RfkUWzipi+1gV3/mYpoPlr/oQ0tRb3a93sLkXDA4eARVDvxYq4/F3Y/rk+TdanUH1EuIxcNEGfrpG4YMpsLlnlSjP6iNf7ShuJlJJ1d3aDk53d9bg4Y1SqZlUD6swYBdcCk08NWnAfApAoyvX+3KbDWMSxqZoerbWmZc= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=amd.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1787639058451508.4372130787417; Mon, 24 Aug 2026 23:24:18 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1399053.1635265 (Exim 4.92) (envelope-from ) id 1wykZZ-0002Q2-Gs; Tue, 25 Aug 2026 06:23:49 +0000 Received: by outflank-mailman (output) from mailman id 1399053.1635265; Tue, 25 Aug 2026 06:23:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wykZZ-0002Pa-CR; Tue, 25 Aug 2026 06:23:49 +0000 Received: by outflank-mailman (input) for mailman id 1399053; Tue, 25 Aug 2026 06:23:48 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wykZY-0002Nx-BX for xen-devel@lists.xenproject.org; Tue, 25 Aug 2026 06:23:48 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wykZX-001HsD-9q for xen-devel@lists.xenproject.org; Tue, 25 Aug 2026 08:23:47 +0200 Received: from [10.42.69.9] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a8d34d4-bab6-0a2a0a5309dd-0a2a4509a984-32 for ; Tue, 25 Aug 2026 08:23:46 +0200 Received: from [40.93.198.43] (helo=CY7PR03CU001.outbound.protection.outlook.com) by tlsNG-bad1c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a8d34f0-be1a-0a2a45090019-285dc62b6adb-3 for ; Tue, 25 Aug 2026 08:23:46 +0200 Received: from CH5PR04CA0014.namprd04.prod.outlook.com (2603:10b6:610:1f4::26) by CH8PR12MB9742.namprd12.prod.outlook.com (2603:10b6:610:27a::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.339.12; Tue, 25 Aug 2026 06:23:42 +0000 Received: from CH1PEPF0000AD7C.namprd04.prod.outlook.com (2603:10b6:610:1f4:cafe::94) by CH5PR04CA0014.outlook.office365.com (2603:10b6:610:1f4::26) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.360.6 via Frontend Transport; Tue, 25 Aug 2026 06:23:42 +0000 Received: from satlexmb07.amd.com (149.199.90.133) by CH1PEPF0000AD7C.mail.protection.outlook.com (10.167.244.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.360.3 via Frontend Transport; Tue, 25 Aug 2026 06:23:41 +0000 Received: from satlexmb08.amd.com (10.181.42.217) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Tue, 25 Aug 2026 01:23:41 -0500 Received: from APPOL-18KY0J4.xilinx.com (10.180.168.240) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server id 15.2.2562.45 via Frontend Transport; Tue, 25 Aug 2026 01:23:39 -0500 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=amd.com header.i="@amd.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=UlqT/v8uI6IiJbJvn84yXdaH6jVZCpLjMZhqb8KySW4cUzz5SOJCbvPbkmr8KwCH4hxp+cnQAdWFHdxhwI6uwhgTUiVDt4XvkBkxQ8GPgAr3rQOUU9tOY45Nr+JgvRKBDG3b9M0yqZh1pSdqQdki8elzSwUWyrsLTcUlYB5MR+FNinTxBc+5LNrZTJfwu1ahaS7z8IwsPwf8hG5tRlEDBdrDx74Pg10vQisCUevO6B0Q4tHQ9bSkn3jnIrAR5wTuod/+6VaOV3kBWpNC4CSKsqXEcxGaX7ZHdlIe2CLT2BBtGQPzizcpGLvXD/pMllpeyjsD8YIuUxKVtFcwA66mWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=t0tG7LxrvduKAPMs/G1qHGRWDG7gX+0MAt1PYS3j94A=; b=YRq52nREsAAJGrsDA3pK1XpmdG2aahRiGvPfPyMJkGzrJyJgnEZnCcCpGdYvEMerer1PFBznK8RKRidxTJi3Dy06Lrpje+sT39EoQ2WTI1fEa2YHKXny0o6nDG5n8AZiiT++iHk5affvWkLraspJeWuLGwLhsjO1eHobgXMCp5aF2DG7XxgqMA6Q86D6Vuno7GL7pywPtXLeGmUf25jIZwZP0mZpGmy9esxRiIF2WossA4an62FDdOPh1wj/28tDVZSrd6MwlAj8BThjJsiH2EOnkVRfxqFEo3Ivhziloo/Kfz+F/OUIuZbOYn5Hbw7Usn6EXto0m+uNqOLR4yk7tw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=softfail (sender ip is 149.199.90.133) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=fail (p=quarantine sp=quarantine pct=100) action=quarantine header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=t0tG7LxrvduKAPMs/G1qHGRWDG7gX+0MAt1PYS3j94A=; b=LEa3B8/GjREJYJivUoW2hkOG3JSRFGlqUKH8oXkMPsapmitN3jOE6nKVmsXMjNaKZXJzonaYzXY2MyjJ2eClRvSEhYv74Ls6Gv89uLkQ7SKqMfHzTxosKPpCLSCHQNwvnWoSN03LHn7+FpsqqpBteo7tt7zpKDX49Ww72XjBYKA= X-MS-Exchange-Authentication-Results: spf=softfail (sender IP is 149.199.90.133) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=fail action=quarantine header.from=amd.com; Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Received-SPF: SoftFail (protection.outlook.com: domain of transitioning amd.com discourages use of 149.199.90.133 as permitted sender) From: Michal Orzel To: CC: Michal Orzel , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH 1/2] xen/arm: traps: report level 0 faults in panic_PAR() Date: Tue, 25 Aug 2026 08:23:28 +0200 Message-ID: <20260825062329.16762-2-michal.orzel@amd.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260825062329.16762-1-michal.orzel@amd.com> References: <20260825062329.16762-1-michal.orzel@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH1PEPF0000AD7C:EE_|CH8PR12MB9742:EE_ X-MS-Office365-Filtering-Correlation-Id: 12248c47-8c5b-44de-9ecd-08df027168b0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|82310400026|36860700016|376014|1800799024|18002099003|22082099003|56012099006|11063799006|10067099003|3023799007; X-Microsoft-Antispam-Message-Info: cE8d0hOQ85Mn2MzdTgNgdWpwJw+OAIkKyZjgI0qZcs0JLiBQoCEBiJRomUBpgyGqjlqRztMO2JxbOnY+ueQtw54XpImgE4D/jHMn8ZwoTLSRkq+Gv/okw+p4nX6NHDmqytfDtEljyI4y3lBN0PAHVOBwVSB+sT58g2vuT/wrXoo9g1RFx+6mv57UVo7jiZWAleyIanYAIVZXWpSjB5C1k3rnoysjgOlmGvCraVFaAFmexejdeXshjOfyixK0Ylv2ugPGgj5HOH+QuQCvfWG6soQn/MDqCiPuvLAUlRSvmTF/1ZMPhHtArw8VGWG4bs9GxdwwZanEz3N9g0ViMz/huqGFeD6TCX/r1M8EH2daIqITqm9jxeB/VnpmBlupelcYoEz/dhoIWQQo/UcbAzNZFgPbobc33Wz3hVWM4lL6XW1We6o+wHAsZ1uQybhy3MwDgcOmr/m4saClU1YWVikgFhiRwq3E+f2sweayUbGThP3OZb42GDiYZffbx8kgNVGNMmZk6XLXyMtjcQMMOYVq2oWIWOB7q5iePFZHJcLZjJz0GnwEUKtvp8L3BttyQjf69ESgFUrvBHpOXUamtgA0HPP1DT4WzLd1QSdHNfezFgXrxiNxrKZQuYmNmpZVTAFKIt5rhaccGEmwF3SyRy3oinW08vlnRuCMTW6SkK0JtDOfYzolY2Y8TDhXnkh+KQ0jwQeMNK0j348Bar4AVD1ucg== X-Forefront-Antispam-Report: CIP:149.199.90.133;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb07.amd.com;PTR:unknown-90-133.xilinx.com;CAT:NONE;SFS:(13230040)(23010399003)(82310400026)(36860700016)(376014)(1800799024)(18002099003)(22082099003)(56012099006)(11063799006)(10067099003)(3023799007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: kiyoA7XlN1MvYiP/IEErxZ/mNadawhY6HPLOTtCZwo3oXQc+j0xleWmLMtmACKxZ+nq+h/bGHxR9uG2lfjDOXDUOz9nV2pOQziKUX8K+ZVAOVtWXXsSPZgLvCmALPESvGYsMNPkSyyEWwOvrSBvwyWr6QyyqudOzJHH1ECcIDffguWRqoHfMhZ7kRThSdbD90eem3Hk8ZTyYCvZH3OV8M/ROipB3E0RljU1Jty9wHnExH+16HZgrquAhkIrzK2yCJWHrRM2X9weEArQRhGG4gKQFtuTzG1Rkwo6xocUUPyOjw818uWwn9JkIcQIfEkr56/EJ7LcsoSiP7dljbIPo4DjTpj+Fg+fffoXSSrxVRmjidbpn0NMIuiFgitSTB2i8VlD4bCEK1C8+hmJlr7GXy0VbocUsizLY+A1b//sVo2UwNHR7ylntbxQ8HS82/5+e X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Aug 2026 06:23:41.9454 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 12248c47-8c5b-44de-9ecd-08df027168b0 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[149.199.90.133];Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CH1PEPF0000AD7C.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH8PR12MB9742 X-purgate-ID: tlsNG-bad1c0/1787639026-FCC15034-4C6AC49A/0/0 X-purgate-type: clean X-purgate-size: 2420 X-ZohoMail-DKIM: pass (identity @amd.com) X-ZM-MESSAGEID: 1787639060081158501 Content-Type: text/plain; charset="utf-8" decode_fsc() derives the fault level from the low two bits of the FSC, so level 0 is a valid output: FSC_FLT_TRANS is 0x04, i.e. "translation fault, level 0". This is reachable on arm64 because xen_pgtable is the zeroeth-level root, but fsc_level_str() has no case for it and prints " (level invalid)" instead. At the time the function was created Xen used only three levels. Add the missing case. On arm32 the zeroeth level does not exist, hence guard the case by CONFIG_ARM_64. While at it, make decode_fsc() decode also address size faults. Signed-off-by: Michal Orzel Reviewed-by: Oleksandr Tyshchenko --- xen/arch/arm/include/asm/processor.h | 2 ++ xen/arch/arm/traps.c | 8 ++++++++ 2 files changed, 10 insertions(+) diff --git a/xen/arch/arm/include/asm/processor.h b/xen/arch/arm/include/as= m/processor.h index a3753c317fff..509040a1cdc0 100644 --- a/xen/arch/arm/include/asm/processor.h +++ b/xen/arch/arm/include/asm/processor.h @@ -521,6 +521,7 @@ extern register_t __cpu_logical_map[]; /* * 543210 BIT * 00XXLL -- XX Fault Level LL + * ..00LL -- Address Size Fault LL * ..01LL -- Translation Fault LL * ..10LL -- Access Fault LL * ..11LL -- Permission Fault LL @@ -534,6 +535,7 @@ extern register_t __cpu_logical_map[]; #define FSC_TYPE_OTH (_AC(0x02,U)<<4) #define FSC_TYPE_IMPL (_AC(0x03,U)<<4) =20 +#define FSC_FLT_ADDR_SIZE (0x00) #define FSC_FLT_TRANS (0x04) #define FSC_FLT_ACCESS (0x08) #define FSC_FLT_PERM (0x0c) diff --git a/xen/arch/arm/traps.c b/xen/arch/arm/traps.c index 0c01f37ad6b4..dc0ec8a345ed 100644 --- a/xen/arch/arm/traps.c +++ b/xen/arch/arm/traps.c @@ -307,6 +307,10 @@ static const char *decode_fsc(uint32_t fsc, int *level) =20 switch ( fsc & 0x3f ) { + case FSC_FLT_ADDR_SIZE ... FSC_FLT_ADDR_SIZE + 3: + msg =3D "Address size fault"; + *level =3D fsc & FSC_LL_MASK; + break; case FSC_FLT_TRANS ... FSC_FLT_TRANS + 3: msg =3D "Translation fault"; *level =3D fsc & FSC_LL_MASK; @@ -363,6 +367,10 @@ static const char *fsc_level_str(int level) switch ( level ) { case -1: return ""; +#ifdef CONFIG_ARM_64 + /* On arm32 the zeroeth level does not exist */ + case 0: return " at level 0"; +#endif case 1: return " at level 1"; case 2: return " at level 2"; case 3: return " at level 3"; --=20 2.43.0 From nobody Thu Sep 3 07:04:04 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=amd.com); dmarc=pass(p=quarantine dis=none) header.from=amd.com ARC-Seal: i=2; a=rsa-sha256; t=1787639058; cv=pass; d=zohomail.com; s=zohoarc; b=G+wCTkyTHbG9RtWsT8CAdbUxHgHeS80kNexSK+bvqrRU2ncji7cGkUA6zDwmCZ0nXt9ZhoDy+pG+P0/HNFYDiAbIbuvL81rLPQ2P43WLbI13pnjaZ1vMxF9ak4qfNgTDJt0EuwkvZW1vM6ZmOQ80xH5r50Ibe2JFEZdbM0Ck2dI= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1787639058; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=n4jxQvxAE1oi5hVrdaQxGmUbeCaHi8CJIvOPCare3V4=; b=Xg19wZCwPsO3Dytr7YXPUEq3ZED+PhSdluN9QeV7Zbqo91sV5qsbO1JhggKsPvoIv94dSKIV1yJDyYOTD7QKMRCUdmP6Qfl/2wlguwepxM9xT/azIGMcx3MevY92ac+AGaImWRLUNcV94Sh3LgorJTlk2L9XI/LGUw4glXSKgZw= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=amd.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 17876390581241004.9466143316595; Mon, 24 Aug 2026 23:24:18 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1399054.1635278 (Exim 4.92) (envelope-from ) id 1wykZh-0002qI-RL; Tue, 25 Aug 2026 06:23:57 +0000 Received: by outflank-mailman (output) from mailman id 1399054.1635278; Tue, 25 Aug 2026 06:23:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wykZh-0002qB-Nk; Tue, 25 Aug 2026 06:23:57 +0000 Received: by outflank-mailman (input) for mailman id 1399054; Tue, 25 Aug 2026 06:23:56 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wykZg-0002p7-Ct for xen-devel@lists.xenproject.org; Tue, 25 Aug 2026 06:23:56 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wykZf-007bIM-Dy for xen-devel@lists.xenproject.org; Tue, 25 Aug 2026 08:23:55 +0200 Received: from [10.42.69.2] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a8d34f9-e002-0a2a0a5209dd-0a2a4502ecf2-10 for ; Tue, 25 Aug 2026 08:23:55 +0200 Received: from [40.93.195.6] (helo=SN4PR2101CU001.outbound.protection.outlook.com) by tlsNG-720697.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a8d34f9-6ca4-0a2a45020019-285dc306d149-4 for ; Tue, 25 Aug 2026 08:23:54 +0200 Received: from SJ0PR03CA0165.namprd03.prod.outlook.com (2603:10b6:a03:338::20) by CY8PR12MB7100.namprd12.prod.outlook.com (2603:10b6:930:60::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.339.12; Tue, 25 Aug 2026 06:23:44 +0000 Received: from SJ5PEPF000001C9.namprd05.prod.outlook.com (2603:10b6:a03:338:cafe::36) by SJ0PR03CA0165.outlook.office365.com (2603:10b6:a03:338::20) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.360.7 via Frontend Transport; Tue, 25 Aug 2026 06:23:44 +0000 Received: from satlexmb08.amd.com (149.199.90.133) by SJ5PEPF000001C9.mail.protection.outlook.com (10.167.242.37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.360.3 via Frontend Transport; Tue, 25 Aug 2026 06:23:43 +0000 Received: from satlexmb10.amd.com (10.181.42.219) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Tue, 25 Aug 2026 01:23:43 -0500 Received: from satlexmb08.amd.com (10.181.42.217) by satlexmb10.amd.com (10.181.42.219) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Tue, 25 Aug 2026 01:23:42 -0500 Received: from APPOL-18KY0J4.xilinx.com (10.180.168.240) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server id 15.2.2562.45 via Frontend Transport; Tue, 25 Aug 2026 01:23:41 -0500 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=amd.com header.i="@amd.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=lYSiyxEm/tT+8AbAVSiXaCS5HqCqek/ylawjTIenGgKXtGz74fs/jAOQ1oV+KhExLgzHOzNfIH96n9prtYG/PflASEOkSB4cNlpy012MqBQInWhA2zGFFbEF0ZrGXKoadsieBCJn5tt5iO3Bb8J7+VTsv1xNeC+zMXvr5xUm4grSHT119ZPIuPKrxEA2WXGNgOmvewr3UjWRHmMmyFjc1okgoEjLbzGkfRX8knnCYaMRmeZYNs6GqlOSdLEIXW71a1qkurK6OJhhfa/IZwgQWKYbvCvFUSMIcSRA3cd941yHi5dRY1XCFRIkark0jC4A2DUy63aQ4xs7yWgrDky+0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=n4jxQvxAE1oi5hVrdaQxGmUbeCaHi8CJIvOPCare3V4=; b=xu8Acbcg+h+YrDOitbMIGnUxOENRRXZW4l4gOojKgqmS3XfAUF+0UPDh7c4pgeKgv+w3gghDq0fwaguxFBb4sH9HpCNhHiRFGjSrhVPQpWhQHYQo7Wti1XjjnNIU7G+Yvqv/nCq/MXwiaN7J4BRaWyZs/sURlCt6v+qa3os8JvLjEqtE9xe/2leeIHsiGfchqlK6gKYb4nTZGBNalwUw6UvHKdPwvs7GbOf+M6FhpiORi8fsIDPz6TZ1LzlheZL7KWjwldRa7k7Kyzr/3/qE77sUBsZJXExvpZfm8Qg5L3xHhFVi2EHwZ/Uhy2eBbreWK/7Nb+VrhF7pA2MqXpToSQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=softfail (sender ip is 149.199.90.133) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=fail (p=quarantine sp=quarantine pct=100) action=quarantine header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=n4jxQvxAE1oi5hVrdaQxGmUbeCaHi8CJIvOPCare3V4=; b=nJ/amJxEKD77HGqbYcCltDBbpkWL+Y4ne5ezz9DSjcXqGcl03Vr0yBvSrH8aV9avFm6YkO5MMdfu4EtFTgLydbgrvhBJkJKvIQy+zuIuF+6TUAOP9JIcop4tUlpGLN4JYhuHLfyO9E7PpnDp3jPSqcyJF8EHsLxVs2dNSpJqaZo= X-MS-Exchange-Authentication-Results: spf=softfail (sender IP is 149.199.90.133) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=fail action=quarantine header.from=amd.com; Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Received-SPF: SoftFail (protection.outlook.com: domain of transitioning amd.com discourages use of 149.199.90.133 as permitted sender) From: Michal Orzel To: CC: Michal Orzel , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH 2/2] xen/arm: traps: drop unreachable stage 2 decoding from panic_PAR() Date: Tue, 25 Aug 2026 08:23:29 +0200 Message-ID: <20260825062329.16762-3-michal.orzel@amd.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260825062329.16762-1-michal.orzel@amd.com> References: <20260825062329.16762-1-michal.orzel@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ5PEPF000001C9:EE_|CY8PR12MB7100:EE_ X-MS-Office365-Filtering-Correlation-Id: b03bdb35-2d08-4c46-0036-08df027169d8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|1800799024|82310400026|36860700016|376014|56012099006|10067099003|22082099003|11063799006|18002099003; X-Microsoft-Antispam-Message-Info: hLsmZfnpRuObw/XfEkWPrKZs/n7HMmeRsDROFkDFImKKaH8cRr4aYbWukaJtwxg3d0SQz5QemxGDeVLC2Z11XyMpcVavaJv0dTgP/q1+UQRkKEEvUohIxlozi6tTnTStC+2VrKijRRXtbIXMoZlkXOe7WoWdD0/dVCJka+KwaiDYaVoG+vJBMIZziOcuDFiLCRHGkbZ4CBUqNLHTn5+S8PtIWNQXNtM4QdlZZ6ovEnUvCcRdwKc4QAP8bqXMuQ9wHbzlHJIxDHtREgwN61QpHJagy5nQRiPQhrSpHZw6MO1GK+BOsd4BCsDeEfsfT6vU8mWJxbHL4gnmLnbi0yihAUOMJmcS7OztoASG9ZqXCxlTdvqqAESoZ2ZHx3HdajIQ+ZA7lzKsN4nx0qIP6+EgD22npZPe9p14KDl8APlcwZFuS27WRHpburO/vATBXxXb6H50aWgquyBXH7+Fza6U+h8cwTrivXntzP/OsQc0lz1PFDDnUAcLObPx2b9XGN5wjIhbEQ+gsWH8SNz8/9dIxgII/zoxmUI3vpcAxWqIYSHPHUNeF8ddK55n7xbStGM54awnFQkV7+wtrT/XgUXxDklsxzXTGvNqlkCkTlPJrT6vju8BGvIWUhb8iBr776WCyv9yfQH9LuNU1OBaardRkkg1675+ukSHCGX4KLYYuzSm9Ngl1K24K7oJRgzV5TCI70obhV6TApA9bRf09O055w== X-Forefront-Antispam-Report: CIP:149.199.90.133;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb08.amd.com;PTR:unknown-90-133.xilinx.com;CAT:NONE;SFS:(13230040)(23010399003)(1800799024)(82310400026)(36860700016)(376014)(56012099006)(10067099003)(22082099003)(11063799006)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: QYuvrVdsaEDnjECsUt9liYEnaRi6lO6fAhUn3UfxSLC76SPXeTcY3W5jinUtU5WwQDVr1ao/7u8iZrVmclMxj9TSsyx3IgAsFn0EJkWT4aW7PG9NblAZLb6katMx3B5DFHsKBCtHCgFHKV8ue869ktyQcUgvGoO1omODyY1nDsltihrj5CoDCIQFQar1eLnXEKtBbzAFWOEJedjdpVZqJCBXRcgura83o6/Y59NX6+RZSUhU7dhwfaA7YVgLSPMmQ1OjCcAqvB6yOmLhtyGjqEPEQ9Hngk5CY4HrIsmXsy82Eh/jXdX0FnzbVPm04WhEB7HyTRZZpcUtNqgqUyu7gSwS8pTxYRz7VALaejSp2Xl6qDmZC6V2KB4y72b4yt8XqMlfx9R6AoFSqSF+5CgoTM3UwuLI8fsfj249jQ3KMGua4bkCD1zgBNoXoYnCLsg9 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Aug 2026 06:23:43.8915 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b03bdb35-2d08-4c46-0036-08df027169d8 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[149.199.90.133];Helo=[satlexmb08.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SJ5PEPF000001C9.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB7100 X-purgate-ID: tlsNG-720697/1787639035-67CBA2AC-95602C8C/0/0 X-purgate-type: clean X-purgate-size: 2545 X-ZohoMail-DKIM: pass (identity @amd.com) X-ZM-MESSAGEID: 1787639060081158502 Content-Type: text/plain; charset="utf-8" panic_PAR() is only called from va_to_par(), which translates using __va_to_par(), i.e. "at s1e2r" on arm64 and ATS1HR on arm32. Both perform an EL2 stage 1 only translation, so PAR.S (PAR_STAGE2) and PAR.PTW (PAR_STAGE21) can never be set. This has been the case since commit a14447dbcf171 ("xen: arm: do not panic when failing to translate a guest address"), which made gva_to_par() and gva_to_ipa() return -EFAULT instead of calling panic_PAR() for guest translations. Print stage 1 unconditionally and keep an ASSERT() to document the invariant. PAR_STAGE21 has no user left, so drop it. While at it, fix the spacing in the decode_fsc() call. No functional change intended. Signed-off-by: Michal Orzel Reviewed-by: Oleksandr Tyshchenko --- xen/arch/arm/include/asm/processor.h | 1 - xen/arch/arm/traps.c | 17 +++++++++-------- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/xen/arch/arm/include/asm/processor.h b/xen/arch/arm/include/as= m/processor.h index 509040a1cdc0..8ee8f88fb4cb 100644 --- a/xen/arch/arm/include/asm/processor.h +++ b/xen/arch/arm/include/asm/processor.h @@ -507,7 +507,6 @@ extern register_t __cpu_logical_map[]; /* .... If F =3D=3D 1 */ #define PAR_FSC_SHIFT (1) #define PAR_FSC_MASK (_AC(0x3f,U)<> PAR_FSC_SHIFT, &level); + /* + * The only caller translates using "at s1e2r" (arm64) or ATS1HR + * (arm32), i.e. an EL2 stage 1 only translation. + */ + ASSERT(!(par & PAR_STAGE2)); + + msg =3D decode_fsc((par & PAR_FSC_MASK) >> PAR_FSC_SHIFT, &level); =20 - printk("PAR: %016"PRIx64": %s stage %d%s%s\n", - par, msg, - stage, - second_in_first ? " during second stage lookup" : "", - fsc_level_str(level)); + printk("PAR: %016"PRIx64": %s stage 1%s\n", + par, msg, fsc_level_str(level)); =20 panic("Error during Hypervisor-to-physical address translation\n"); } --=20 2.43.0